{"action":"created","comment":{"url":"https://api.github.com/repos/clappr/clappr-ios/pulls/comments/207053721","pull_request_review_id":142589673,"id":207053721,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzA1MzcyMQ==","diff_hunk":"@@ -38,6 +38,7 @@ open class AVFoundationPlayback: Playback {\n     }\n     fileprivate var timeObserver: Any?\n     fileprivate var asset: AVURLAsset?\n+    var lastDvrAvailability: Bool?","path":"Sources/Clappr_iOS/Classes/Plugin/Playback/AVFoundationPlayback.swift","position":4,"original_position":4,"commit_id":"aacb6bbbadfa0686742cf1a66e823f5509a62bb2","original_commit_id":"117b282d9a88726796555407fea839ff6a09568f","user":{"login":"igoriols","id":8026597,"node_id":"MDQ6VXNlcjgwMjY1OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8026597?v=4","gravatar_id":"","url":"https://api.github.com/users/igoriols","html_url":"https://github.com/igoriols","followers_url":"https://api.github.com/users/igoriols/followers","following_url":"https://api.github.com/users/igoriols/following{/other_user}","gists_url":"https://api.github.com/users/igoriols/gists{/gist_id}","starred_url":"https://api.github.com/users/igoriols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igoriols/subscriptions","organizations_url":"https://api.github.com/users/igoriols/orgs","repos_url":"https://api.github.com/users/igoriols/repos","events_url":"https://api.github.com/users/igoriols/events{/privacy}","received_events_url":"https://api.github.com/users/igoriols/received_events","type":"User","site_admin":false},"body":"Hey @nabilsafatli  and @dezouzart , is it necessary to be optional?","created_at":"2018-08-01T22:35:53Z","updated_at":"2018-08-01T22:35:53Z","html_url":"https://github.com/clappr/clappr-ios/pull/216#discussion_r207053721","pull_request_url":"https://api.github.com/repos/clappr/clappr-ios/pulls/216","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/clappr/clappr-ios/pulls/comments/207053721"},"html":{"href":"https://github.com/clappr/clappr-ios/pull/216#discussion_r207053721"},"pull_request":{"href":"https://api.github.com/repos/clappr/clappr-ios/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/clappr/clappr-ios/pulls/216","id":203974868,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTc0ODY4","html_url":"https://github.com/clappr/clappr-ios/pull/216","diff_url":"https://github.com/clappr/clappr-ios/pull/216.diff","patch_url":"https://github.com/clappr/clappr-ios/pull/216.patch","issue_url":"https://api.github.com/repos/clappr/clappr-ios/issues/216","number":216,"state":"open","locked":false,"title":"Refactoring DVR to keep Clappr architecture consistency","user":{"login":"nabilsafatli","id":5130095,"node_id":"MDQ6VXNlcjUxMzAwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5130095?v=4","gravatar_id":"","url":"https://api.github.com/users/nabilsafatli","html_url":"https://github.com/nabilsafatli","followers_url":"https://api.github.com/users/nabilsafatli/followers","following_url":"https://api.github.com/users/nabilsafatli/following{/other_user}","gists_url":"https://api.github.com/users/nabilsafatli/gists{/gist_id}","starred_url":"https://api.github.com/users/nabilsafatli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nabilsafatli/subscriptions","organizations_url":"https://api.github.com/users/nabilsafatli/orgs","repos_url":"https://api.github.com/users/nabilsafatli/repos","events_url":"https://api.github.com/users/nabilsafatli/events{/privacy}","received_events_url":"https://api.github.com/users/nabilsafatli/received_events","type":"User","site_admin":false},"body":"### Goal\r\n\r\nAfter talking with the Clappr team, some names were changed to inform better the DVR availability and status.\r\n\r\n- Create an event to indicate the change of DVR availability - didChangeDvrAvailability\r\n- Change the property `supportDvr` to `isDvrAvailable`\r\n- Change the property `isUsingDvr` to `isDvrInUse`\r\n- Change the event `usingDvr` to `didChangeDvrStatus`\r\n- Create a method `seekToLivePosition()` to make possible for plugins to redirect a live playback to last live moment available","created_at":"2018-07-25T21:56:44Z","updated_at":"2018-08-01T22:35:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bfdb14655bce24a27c28fe97e69225f237dc5b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":172120626,"node_id":"MDU6TGFiZWwxNzIxMjA2MjY=","url":"https://api.github.com/repos/clappr/clappr-ios/labels/done","name":"done","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/clappr/clappr-ios/pulls/216/commits","review_comments_url":"https://api.github.com/repos/clappr/clappr-ios/pulls/216/comments","review_comment_url":"https://api.github.com/repos/clappr/clappr-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clappr/clappr-ios/issues/216/comments","statuses_url":"https://api.github.com/repos/clappr/clappr-ios/statuses/aacb6bbbadfa0686742cf1a66e823f5509a62bb2","head":{"label":"clappr:refactor/dvr","ref":"refactor/dvr","sha":"aacb6bbbadfa0686742cf1a66e823f5509a62bb2","user":{"login":"clappr","id":10685859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1ODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"repo":{"id":22841953,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg0MTk1Mw==","name":"clappr-ios","full_name":"clappr/clappr-ios","owner":{"login":"clappr","id":10685859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1ODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clappr/clappr-ios","description":"An extensible media player for iOS.","fork":false,"url":"https://api.github.com/repos/clappr/clappr-ios","forks_url":"https://api.github.com/repos/clappr/clappr-ios/forks","keys_url":"https://api.github.com/repos/clappr/clappr-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clappr/clappr-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clappr/clappr-ios/teams","hooks_url":"https://api.github.com/repos/clappr/clappr-ios/hooks","issue_events_url":"https://api.github.com/repos/clappr/clappr-ios/issues/events{/number}","events_url":"https://api.github.com/repos/clappr/clappr-ios/events","assignees_url":"https://api.github.com/repos/clappr/clappr-ios/assignees{/user}","branches_url":"https://api.github.com/repos/clappr/clappr-ios/branches{/branch}","tags_url":"https://api.github.com/repos/clappr/clappr-ios/tags","blobs_url":"https://api.github.com/repos/clappr/clappr-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clappr/clappr-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clappr/clappr-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/clappr/clappr-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clappr/clappr-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/clappr/clappr-ios/languages","stargazers_url":"https://api.github.com/repos/clappr/clappr-ios/stargazers","contributors_url":"https://api.github.com/repos/clappr/clappr-ios/contributors","subscribers_url":"https://api.github.com/repos/clappr/clappr-ios/subscribers","subscription_url":"https://api.github.com/repos/clappr/clappr-ios/subscription","commits_url":"https://api.github.com/repos/clappr/clappr-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/clappr/clappr-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/clappr/clappr-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/clappr/clappr-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/clappr/clappr-ios/contents/{+path}","compare_url":"https://api.github.com/repos/clappr/clappr-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clappr/clappr-ios/merges","archive_url":"https://api.github.com/repos/clappr/clappr-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clappr/clappr-ios/downloads","issues_url":"https://api.github.com/repos/clappr/clappr-ios/issues{/number}","pulls_url":"https://api.github.com/repos/clappr/clappr-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/clappr/clappr-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/clappr/clappr-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clappr/clappr-ios/labels{/name}","releases_url":"https://api.github.com/repos/clappr/clappr-ios/releases{/id}","deployments_url":"https://api.github.com/repos/clappr/clappr-ios/deployments","created_at":"2014-08-11T14:30:00Z","updated_at":"2018-07-27T17:44:28Z","pushed_at":"2018-08-01T17:17:16Z","git_url":"git://github.com/clappr/clappr-ios.git","ssh_url":"git@github.com:clappr/clappr-ios.git","clone_url":"https://github.com/clappr/clappr-ios.git","svn_url":"https://github.com/clappr/clappr-ios","homepage":"","size":10601,"stargazers_count":70,"watchers_count":70,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":25,"open_issues":7,"watchers":70,"default_branch":"dev"}},"base":{"label":"clappr:dev","ref":"dev","sha":"1761507642f5d8c113229ccb01274182d91285c3","user":{"login":"clappr","id":10685859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1ODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"repo":{"id":22841953,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg0MTk1Mw==","name":"clappr-ios","full_name":"clappr/clappr-ios","owner":{"login":"clappr","id":10685859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1ODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clappr/clappr-ios","description":"An extensible media player for iOS.","fork":false,"url":"https://api.github.com/repos/clappr/clappr-ios","forks_url":"https://api.github.com/repos/clappr/clappr-ios/forks","keys_url":"https://api.github.com/repos/clappr/clappr-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clappr/clappr-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clappr/clappr-ios/teams","hooks_url":"https://api.github.com/repos/clappr/clappr-ios/hooks","issue_events_url":"https://api.github.com/repos/clappr/clappr-ios/issues/events{/number}","events_url":"https://api.github.com/repos/clappr/clappr-ios/events","assignees_url":"https://api.github.com/repos/clappr/clappr-ios/assignees{/user}","branches_url":"https://api.github.com/repos/clappr/clappr-ios/branches{/branch}","tags_url":"https://api.github.com/repos/clappr/clappr-ios/tags","blobs_url":"https://api.github.com/repos/clappr/clappr-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clappr/clappr-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clappr/clappr-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/clappr/clappr-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clappr/clappr-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/clappr/clappr-ios/languages","stargazers_url":"https://api.github.com/repos/clappr/clappr-ios/stargazers","contributors_url":"https://api.github.com/repos/clappr/clappr-ios/contributors","subscribers_url":"https://api.github.com/repos/clappr/clappr-ios/subscribers","subscription_url":"https://api.github.com/repos/clappr/clappr-ios/subscription","commits_url":"https://api.github.com/repos/clappr/clappr-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/clappr/clappr-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/clappr/clappr-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/clappr/clappr-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/clappr/clappr-ios/contents/{+path}","compare_url":"https://api.github.com/repos/clappr/clappr-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clappr/clappr-ios/merges","archive_url":"https://api.github.com/repos/clappr/clappr-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clappr/clappr-ios/downloads","issues_url":"https://api.github.com/repos/clappr/clappr-ios/issues{/number}","pulls_url":"https://api.github.com/repos/clappr/clappr-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/clappr/clappr-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/clappr/clappr-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clappr/clappr-ios/labels{/name}","releases_url":"https://api.github.com/repos/clappr/clappr-ios/releases{/id}","deployments_url":"https://api.github.com/repos/clappr/clappr-ios/deployments","created_at":"2014-08-11T14:30:00Z","updated_at":"2018-07-27T17:44:28Z","pushed_at":"2018-08-01T17:17:16Z","git_url":"git://github.com/clappr/clappr-ios.git","ssh_url":"git@github.com:clappr/clappr-ios.git","clone_url":"https://github.com/clappr/clappr-ios.git","svn_url":"https://github.com/clappr/clappr-ios","homepage":"","size":10601,"stargazers_count":70,"watchers_count":70,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":25,"open_issues":7,"watchers":70,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/clappr/clappr-ios/pulls/216"},"html":{"href":"https://github.com/clappr/clappr-ios/pull/216"},"issue":{"href":"https://api.github.com/repos/clappr/clappr-ios/issues/216"},"comments":{"href":"https://api.github.com/repos/clappr/clappr-ios/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/clappr/clappr-ios/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/clappr/clappr-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clappr/clappr-ios/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/clappr/clappr-ios/statuses/aacb6bbbadfa0686742cf1a66e823f5509a62bb2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"igoriols"}}