{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/comments/188802944","pull_request_review_id":120851857,"id":188802944,"diff_hunk":"@@ -383,3 +400,13 @@ def get_tron_namespaces_for_cluster(cluster=None, soa_dir=DEFAULT_SOA_DIR):\n         os.path.splitext(filename)[0] for filename in os.listdir(config_dir)\n     ]\n     return namespaces\n+\n+def get_tron_namespaces_for_cluster(cluster=None, soa_dir=DEFAULT_SOA_DIR):\n+    \"\"\"Get all the namespaces that are configured in a particular Tron cluster.\"\"\"\n+    if not cluster:\n+        cluster = load_tron_config().get_cluster_name()\n+   \n+    namespaces1 = _get_tron_namespaces_from_service_dir(cluster, soa_dir)\n+    namespaces2 = _get_tron_namespaces_from_tron_dir(cluster, soa_dir)\n+    namespaces= list(set(namespaces1) - set(namespaces2)) + namespaces2","path":"paasta_tools/tron_tools.py","position":76,"original_position":76,"commit_id":"5afb46590c3c36d6ce0976cab974f5da4fa16c46","original_commit_id":"5afb46590c3c36d6ce0976cab974f5da4fa16c46","user":{"login":"qui","id":1322636,"avatar_url":"https://avatars3.githubusercontent.com/u/1322636?v=4","gravatar_id":"","url":"https://api.github.com/users/qui","html_url":"https://github.com/qui","followers_url":"https://api.github.com/users/qui/followers","following_url":"https://api.github.com/users/qui/following{/other_user}","gists_url":"https://api.github.com/users/qui/gists{/gist_id}","starred_url":"https://api.github.com/users/qui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qui/subscriptions","organizations_url":"https://api.github.com/users/qui/orgs","repos_url":"https://api.github.com/users/qui/repos","events_url":"https://api.github.com/users/qui/events{/privacy}","received_events_url":"https://api.github.com/users/qui/received_events","type":"User","site_admin":false},"body":"why not set(namespaces1 + namespaces2)?","created_at":"2018-05-16T23:40:16Z","updated_at":"2018-05-16T23:47:50Z","html_url":"https://github.com/Yelp/paasta/pull/1836#discussion_r188802944","pull_request_url":"https://api.github.com/repos/Yelp/paasta/pulls/1836","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments/188802944"},"html":{"href":"https://github.com/Yelp/paasta/pull/1836#discussion_r188802944"},"pull_request":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1836"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/1836","id":188285357,"html_url":"https://github.com/Yelp/paasta/pull/1836","diff_url":"https://github.com/Yelp/paasta/pull/1836.diff","patch_url":"https://github.com/Yelp/paasta/pull/1836.patch","issue_url":"https://api.github.com/repos/Yelp/paasta/issues/1836","number":1836,"state":"open","locked":false,"title":"read tron config files from service directories","user":{"login":"chlgit","id":31675758,"avatar_url":"https://avatars2.githubusercontent.com/u/31675758?v=4","gravatar_id":"","url":"https://api.github.com/users/chlgit","html_url":"https://github.com/chlgit","followers_url":"https://api.github.com/users/chlgit/followers","following_url":"https://api.github.com/users/chlgit/following{/other_user}","gists_url":"https://api.github.com/users/chlgit/gists{/gist_id}","starred_url":"https://api.github.com/users/chlgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chlgit/subscriptions","organizations_url":"https://api.github.com/users/chlgit/orgs","repos_url":"https://api.github.com/users/chlgit/repos","events_url":"https://api.github.com/users/chlgit/events{/privacy}","received_events_url":"https://api.github.com/users/chlgit/received_events","type":"User","site_admin":false},"body":"I added tron_migration_status/tron-devc.yaml, and it's able to create namespace 'tron_migration_status' at tron-devc.","created_at":"2018-05-15T23:49:14Z","updated_at":"2018-05-16T23:47:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b248a35fb66bdfebc8b9a42c33fe33fcc7c0b17","assignee":{"login":"chlgit","id":31675758,"avatar_url":"https://avatars2.githubusercontent.com/u/31675758?v=4","gravatar_id":"","url":"https://api.github.com/users/chlgit","html_url":"https://github.com/chlgit","followers_url":"https://api.github.com/users/chlgit/followers","following_url":"https://api.github.com/users/chlgit/following{/other_user}","gists_url":"https://api.github.com/users/chlgit/gists{/gist_id}","starred_url":"https://api.github.com/users/chlgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chlgit/subscriptions","organizations_url":"https://api.github.com/users/chlgit/orgs","repos_url":"https://api.github.com/users/chlgit/repos","events_url":"https://api.github.com/users/chlgit/events{/privacy}","received_events_url":"https://api.github.com/users/chlgit/received_events","type":"User","site_admin":false},"assignees":[{"login":"chlgit","id":31675758,"avatar_url":"https://avatars2.githubusercontent.com/u/31675758?v=4","gravatar_id":"","url":"https://api.github.com/users/chlgit","html_url":"https://github.com/chlgit","followers_url":"https://api.github.com/users/chlgit/followers","following_url":"https://api.github.com/users/chlgit/following{/other_user}","gists_url":"https://api.github.com/users/chlgit/gists{/gist_id}","starred_url":"https://api.github.com/users/chlgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chlgit/subscriptions","organizations_url":"https://api.github.com/users/chlgit/orgs","repos_url":"https://api.github.com/users/chlgit/repos","events_url":"https://api.github.com/users/chlgit/events{/privacy}","received_events_url":"https://api.github.com/users/chlgit/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":295506239,"url":"https://api.github.com/repos/Yelp/paasta/labels/in%20review","name":"in review","color":"eac04b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/paasta/pulls/1836/commits","review_comments_url":"https://api.github.com/repos/Yelp/paasta/pulls/1836/comments","review_comment_url":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/paasta/issues/1836/comments","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/5afb46590c3c36d6ce0976cab974f5da4fa16c46","head":{"label":"Yelp:u/chl/TRON-256_moving_tron_job_to_service_directories","ref":"u/chl/TRON-256_moving_tron_job_to_service_directories","sha":"5afb46590c3c36d6ce0976cab974f5da4fa16c46","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2018-05-16T22:35:57Z","pushed_at":"2018-05-16T23:22:04Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":56391,"stargazers_count":1217,"watchers_count":1217,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":150,"open_issues":95,"watchers":1217,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"8a869b95351bcc9242a2e73ad5a82b38495fcc6f","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2018-05-16T22:35:57Z","pushed_at":"2018-05-16T23:22:04Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":56391,"stargazers_count":1217,"watchers_count":1217,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":150,"open_issues":95,"watchers":1217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1836"},"html":{"href":"https://github.com/Yelp/paasta/pull/1836"},"issue":{"href":"https://api.github.com/repos/Yelp/paasta/issues/1836"},"comments":{"href":"https://api.github.com/repos/Yelp/paasta/issues/1836/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1836/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1836/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/paasta/statuses/5afb46590c3c36d6ce0976cab974f5da4fa16c46"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"qui"}}