{"action":"created","issue":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/5051","repository_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/5051/labels{/name}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/5051/comments","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/5051/events","html_url":"https://github.com/terraform-providers/terraform-provider-aws/issues/5051","id":337587986,"node_id":"MDU6SXNzdWUzMzc1ODc5ODY=","number":5051,"title":"ALB Target Group non-existant proxy_protocol_v2 option in resource wants to update the resource","user":{"login":"hegyre","id":8317719,"node_id":"MDQ6VXNlcjgzMTc3MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/8317719?v=4","gravatar_id":"","url":"https://api.github.com/users/hegyre","html_url":"https://github.com/hegyre","followers_url":"https://api.github.com/users/hegyre/followers","following_url":"https://api.github.com/users/hegyre/following{/other_user}","gists_url":"https://api.github.com/users/hegyre/gists{/gist_id}","starred_url":"https://api.github.com/users/hegyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hegyre/subscriptions","organizations_url":"https://api.github.com/users/hegyre/orgs","repos_url":"https://api.github.com/users/hegyre/repos","events_url":"https://api.github.com/users/hegyre/events{/privacy}","received_events_url":"https://api.github.com/users/hegyre/received_events","type":"User","site_admin":false},"labels":[{"id":620316239,"node_id":"MDU6TGFiZWw2MjAzMTYyMzk=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/bug","name":"bug","color":"f7c6c7","default":true},{"id":801363986,"node_id":"MDU6TGFiZWw4MDEzNjM5ODY=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/service/elbv2","name":"service/elbv2","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-02T16:37:26Z","updated_at":"2018-07-23T19:13:40Z","closed_at":null,"author_association":"NONE","body":"### Community Note\r\n\r\n* Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request\r\n* Please do not leave \"+1\" or \"me too\" comments, they generate extra noise for issue followers and do not help prioritize the request\r\n* If you are interested in working on this issue or have submitted a pull request, please leave a comment\r\n\r\n### Terraform Version\r\n\r\nTerraform v0.11.7\r\n+ provider.aws v1.22.0\r\n\r\nPrevious provider.aws v1.14.1\r\n\r\n### Affected Resource(s)\r\n\r\n<!--- Please list the affected resources and data sources. --->\r\n\r\n* aws_lb_target_group\r\n\r\n### Terraform Configuration Files\r\n\r\n<!--- Information about code formatting: https://help.github.com/articles/basic-writing-and-formatting-syntax/#quoting-code --->\r\n\r\n```hcl\r\nresource \"aws_lb_target_group\" \"alb_tgrp_pre_nz\" {\r\n  name     = \"${var.project}-alb-tgrp-pre-nz\"\r\n  port     = 80\r\n  protocol = \"HTTP\"\r\n  vpc_id   = \"${aws_vpc.main.id}\"\r\n\r\n  deregistration_delay = 120\r\n\r\n  health_check {\r\n    protocol            = \"HTTP\"\r\n    path                = \"/config.php\"\r\n    healthy_threshold   = 4\r\n    unhealthy_threshold = 2\r\n    timeout             = 5\r\n    interval            = 10\r\n    matcher             = \"200\"\r\n  }\r\n\r\n  stickiness {\r\n    type            = \"lb_cookie\"\r\n    cookie_duration = 600\r\n  }\r\n\r\n}\r\n```\r\n\r\n### Output\r\n\r\n ```\r\n ~ update in-place\r\n\r\nTerraform will perform the following actions:\r\n\r\n  ~ aws_lb_target_group.********\r\n      proxy_protocol_v2: \"\" => \"false\"\r\n\r\n  ~ aws_lb_target_group.********\r\n      proxy_protocol_v2: \"\" => \"false\"\r\n```\r\n\r\n### Expected Behavior\r\n\r\nI expect that there is no change to the resource\r\n\r\n### Actual Behavior\r\n\r\nWill try to update the resource (well, actually not tried, but this is what it may do)\r\n\r\n### Steps to Reproduce\r\n\r\n1. Create an ALB target group with provider version 1.14.1\r\n2. Update provider to 1.22\r\n3. `terraform plan`\r\n\r\n### Important Factoids\r\n\r\nwith aws CLI json, we see there is no proxy_protocol_v2 key:\r\n```\r\naws elbv2 describe-target-groups --names *********\r\n{\r\n    \"TargetGroups\": [\r\n        {\r\n            \"HealthCheckPath\": \"/config.php\",\r\n            \"HealthCheckIntervalSeconds\": 10,\r\n            \"VpcId\": \"********\",\r\n            \"Protocol\": \"HTTP\",\r\n            \"HealthCheckTimeoutSeconds\": 5,\r\n            \"TargetType\": \"instance\",\r\n            \"HealthCheckProtocol\": \"HTTP\",\r\n            \"LoadBalancerArns\": [\r\n                \"****************\"\r\n            ],\r\n            \"UnhealthyThresholdCount\": 2,\r\n            \"HealthyThresholdCount\": 4,\r\n            \"TargetGroupArn\": \"************************\",\r\n            \"Matcher\": {\r\n                \"HttpCode\": \"200\"\r\n            },\r\n            \"HealthCheckPort\": \"traffic-port\",\r\n            \"Port\": 80,\r\n            \"TargetGroupName\": \"*****************\"\r\n        }\r\n    ]\r\n}\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/comments/407169378","html_url":"https://github.com/terraform-providers/terraform-provider-aws/issues/5051#issuecomment-407169378","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/5051","id":407169378,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzE2OTM3OA==","user":{"login":"hegyre","id":8317719,"node_id":"MDQ6VXNlcjgzMTc3MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/8317719?v=4","gravatar_id":"","url":"https://api.github.com/users/hegyre","html_url":"https://github.com/hegyre","followers_url":"https://api.github.com/users/hegyre/followers","following_url":"https://api.github.com/users/hegyre/following{/other_user}","gists_url":"https://api.github.com/users/hegyre/gists{/gist_id}","starred_url":"https://api.github.com/users/hegyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hegyre/subscriptions","organizations_url":"https://api.github.com/users/hegyre/orgs","repos_url":"https://api.github.com/users/hegyre/repos","events_url":"https://api.github.com/users/hegyre/events{/privacy}","received_events_url":"https://api.github.com/users/hegyre/received_events","type":"User","site_admin":false},"created_at":"2018-07-23T19:13:40Z","updated_at":"2018-07-23T19:13:40Z","author_association":"NONE","body":"Yes for your case, Terraform should have showed true => false, because Terraform refresh the states during the plan.\r\nIn this case this is helpful.\r\n\r\nBut for my case, it was \"\" => false, which is non-sense"}}
{"actor":{"display_login":"hegyre"}}