{"action":"created","comment":{"url":"https://api.github.com/repos/bsc-s2/pykit/pulls/comments/203236708","pull_request_review_id":138085578,"id":203236708,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzIzNjcwOA==","diff_hunk":"@@ -161,3 +161,26 @@ def add_block(self, active_range, block, level=None):\n \n         desc = BlockDesc(block)\n         self['levels'][level].add(active_range, desc)\n+\n+    def get_block_ids_by_needle_id(self, needle_id):\n+\n+        region_range = self['range']\n+        levels = self['levels']\n+\n+        if region_range is None:\n+            return None","path":"ectypes/region.py","position":11,"original_position":11,"commit_id":"db4d74b3595475dbc5ed36aeb7b31abfe98c8bdb","original_commit_id":"db4d74b3595475dbc5ed36aeb7b31abfe98c8bdb","user":{"login":"drmingdrmer","id":44069,"node_id":"MDQ6VXNlcjQ0MDY5","avatar_url":"https://avatars0.githubusercontent.com/u/44069?v=4","gravatar_id":"","url":"https://api.github.com/users/drmingdrmer","html_url":"https://github.com/drmingdrmer","followers_url":"https://api.github.com/users/drmingdrmer/followers","following_url":"https://api.github.com/users/drmingdrmer/following{/other_user}","gists_url":"https://api.github.com/users/drmingdrmer/gists{/gist_id}","starred_url":"https://api.github.com/users/drmingdrmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drmingdrmer/subscriptions","organizations_url":"https://api.github.com/users/drmingdrmer/orgs","repos_url":"https://api.github.com/users/drmingdrmer/repos","events_url":"https://api.github.com/users/drmingdrmer/events{/privacy}","received_events_url":"https://api.github.com/users/drmingdrmer/received_events","type":"User","site_admin":false},"body":"返回值类型不一致. 空列表和None都是没找到needle. 应该统一.","created_at":"2018-07-18T02:38:20Z","updated_at":"2018-07-18T02:39:25Z","html_url":"https://github.com/bsc-s2/pykit/pull/369#discussion_r203236708","pull_request_url":"https://api.github.com/repos/bsc-s2/pykit/pulls/369","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bsc-s2/pykit/pulls/comments/203236708"},"html":{"href":"https://github.com/bsc-s2/pykit/pull/369#discussion_r203236708"},"pull_request":{"href":"https://api.github.com/repos/bsc-s2/pykit/pulls/369"}}},"pull_request":{"url":"https://api.github.com/repos/bsc-s2/pykit/pulls/369","id":201805381,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODA1Mzgx","html_url":"https://github.com/bsc-s2/pykit/pull/369","diff_url":"https://github.com/bsc-s2/pykit/pull/369.diff","patch_url":"https://github.com/bsc-s2/pykit/pull/369.patch","issue_url":"https://api.github.com/repos/bsc-s2/pykit/issues/369","number":369,"state":"open","locked":false,"title":"ectypes/region add get block","user":{"login":"godgitgold","id":26970400,"node_id":"MDQ6VXNlcjI2OTcwNDAw","avatar_url":"https://avatars0.githubusercontent.com/u/26970400?v=4","gravatar_id":"","url":"https://api.github.com/users/godgitgold","html_url":"https://github.com/godgitgold","followers_url":"https://api.github.com/users/godgitgold/followers","following_url":"https://api.github.com/users/godgitgold/following{/other_user}","gists_url":"https://api.github.com/users/godgitgold/gists{/gist_id}","starred_url":"https://api.github.com/users/godgitgold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godgitgold/subscriptions","organizations_url":"https://api.github.com/users/godgitgold/orgs","repos_url":"https://api.github.com/users/godgitgold/repos","events_url":"https://api.github.com/users/godgitgold/events{/privacy}","received_events_url":"https://api.github.com/users/godgitgold/received_events","type":"User","site_admin":false},"body":"在一个region里查找该needle_id 是否在这个范围内。\r\nhttps://github.com/bsc-s2/pykit/issues/366","created_at":"2018-07-17T02:05:25Z","updated_at":"2018-07-18T02:39:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b49dd79318e9b8168e3ca6a45fbafbaf3074903","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bsc-s2/pykit/pulls/369/commits","review_comments_url":"https://api.github.com/repos/bsc-s2/pykit/pulls/369/comments","review_comment_url":"https://api.github.com/repos/bsc-s2/pykit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bsc-s2/pykit/issues/369/comments","statuses_url":"https://api.github.com/repos/bsc-s2/pykit/statuses/db4d74b3595475dbc5ed36aeb7b31abfe98c8bdb","head":{"label":"bsc-s2:cy_get_block_ids","ref":"cy_get_block_ids","sha":"db4d74b3595475dbc5ed36aeb7b31abfe98c8bdb","user":{"login":"bsc-s2","id":36946445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2OTQ2NDQ1","avatar_url":"https://avatars3.githubusercontent.com/u/36946445?v=4","gravatar_id":"","url":"https://api.github.com/users/bsc-s2","html_url":"https://github.com/bsc-s2","followers_url":"https://api.github.com/users/bsc-s2/followers","following_url":"https://api.github.com/users/bsc-s2/following{/other_user}","gists_url":"https://api.github.com/users/bsc-s2/gists{/gist_id}","starred_url":"https://api.github.com/users/bsc-s2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsc-s2/subscriptions","organizations_url":"https://api.github.com/users/bsc-s2/orgs","repos_url":"https://api.github.com/users/bsc-s2/repos","events_url":"https://api.github.com/users/bsc-s2/events{/privacy}","received_events_url":"https://api.github.com/users/bsc-s2/received_events","type":"Organization","site_admin":false},"repo":{"id":75464992,"node_id":"MDEwOlJlcG9zaXRvcnk3NTQ2NDk5Mg==","name":"pykit","full_name":"bsc-s2/pykit","owner":{"login":"bsc-s2","id":36946445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2OTQ2NDQ1","avatar_url":"https://avatars3.githubusercontent.com/u/36946445?v=4","gravatar_id":"","url":"https://api.github.com/users/bsc-s2","html_url":"https://github.com/bsc-s2","followers_url":"https://api.github.com/users/bsc-s2/followers","following_url":"https://api.github.com/users/bsc-s2/following{/other_user}","gists_url":"https://api.github.com/users/bsc-s2/gists{/gist_id}","starred_url":"https://api.github.com/users/bsc-s2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsc-s2/subscriptions","organizations_url":"https://api.github.com/users/bsc-s2/orgs","repos_url":"https://api.github.com/users/bsc-s2/repos","events_url":"https://api.github.com/users/bsc-s2/events{/privacy}","received_events_url":"https://api.github.com/users/bsc-s2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bsc-s2/pykit","description":"a collection of toolkit lib for distributed system development in python","fork":false,"url":"https://api.github.com/repos/bsc-s2/pykit","forks_url":"https://api.github.com/repos/bsc-s2/pykit/forks","keys_url":"https://api.github.com/repos/bsc-s2/pykit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsc-s2/pykit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsc-s2/pykit/teams","hooks_url":"https://api.github.com/repos/bsc-s2/pykit/hooks","issue_events_url":"https://api.github.com/repos/bsc-s2/pykit/issues/events{/number}","events_url":"https://api.github.com/repos/bsc-s2/pykit/events","assignees_url":"https://api.github.com/repos/bsc-s2/pykit/assignees{/user}","branches_url":"https://api.github.com/repos/bsc-s2/pykit/branches{/branch}","tags_url":"https://api.github.com/repos/bsc-s2/pykit/tags","blobs_url":"https://api.github.com/repos/bsc-s2/pykit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsc-s2/pykit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsc-s2/pykit/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsc-s2/pykit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsc-s2/pykit/statuses/{sha}","languages_url":"https://api.github.com/repos/bsc-s2/pykit/languages","stargazers_url":"https://api.github.com/repos/bsc-s2/pykit/stargazers","contributors_url":"https://api.github.com/repos/bsc-s2/pykit/contributors","subscribers_url":"https://api.github.com/repos/bsc-s2/pykit/subscribers","subscription_url":"https://api.github.com/repos/bsc-s2/pykit/subscription","commits_url":"https://api.github.com/repos/bsc-s2/pykit/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsc-s2/pykit/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsc-s2/pykit/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsc-s2/pykit/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsc-s2/pykit/contents/{+path}","compare_url":"https://api.github.com/repos/bsc-s2/pykit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsc-s2/pykit/merges","archive_url":"https://api.github.com/repos/bsc-s2/pykit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsc-s2/pykit/downloads","issues_url":"https://api.github.com/repos/bsc-s2/pykit/issues{/number}","pulls_url":"https://api.github.com/repos/bsc-s2/pykit/pulls{/number}","milestones_url":"https://api.github.com/repos/bsc-s2/pykit/milestones{/number}","notifications_url":"https://api.github.com/repos/bsc-s2/pykit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsc-s2/pykit/labels{/name}","releases_url":"https://api.github.com/repos/bsc-s2/pykit/releases{/id}","deployments_url":"https://api.github.com/repos/bsc-s2/pykit/deployments","created_at":"2016-12-03T09:38:38Z","updated_at":"2018-07-16T09:18:41Z","pushed_at":"2018-07-18T02:27:57Z","git_url":"git://github.com/bsc-s2/pykit.git","ssh_url":"git@github.com:bsc-s2/pykit.git","clone_url":"https://github.com/bsc-s2/pykit.git","svn_url":"https://github.com/bsc-s2/pykit","homepage":null,"size":3740,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":11,"watchers":13,"default_branch":"master"}},"base":{"label":"bsc-s2:master","ref":"master","sha":"70aa29f7c0c9bbd9d07e91ea991030c472c327ec","user":{"login":"bsc-s2","id":36946445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2OTQ2NDQ1","avatar_url":"https://avatars3.githubusercontent.com/u/36946445?v=4","gravatar_id":"","url":"https://api.github.com/users/bsc-s2","html_url":"https://github.com/bsc-s2","followers_url":"https://api.github.com/users/bsc-s2/followers","following_url":"https://api.github.com/users/bsc-s2/following{/other_user}","gists_url":"https://api.github.com/users/bsc-s2/gists{/gist_id}","starred_url":"https://api.github.com/users/bsc-s2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsc-s2/subscriptions","organizations_url":"https://api.github.com/users/bsc-s2/orgs","repos_url":"https://api.github.com/users/bsc-s2/repos","events_url":"https://api.github.com/users/bsc-s2/events{/privacy}","received_events_url":"https://api.github.com/users/bsc-s2/received_events","type":"Organization","site_admin":false},"repo":{"id":75464992,"node_id":"MDEwOlJlcG9zaXRvcnk3NTQ2NDk5Mg==","name":"pykit","full_name":"bsc-s2/pykit","owner":{"login":"bsc-s2","id":36946445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2OTQ2NDQ1","avatar_url":"https://avatars3.githubusercontent.com/u/36946445?v=4","gravatar_id":"","url":"https://api.github.com/users/bsc-s2","html_url":"https://github.com/bsc-s2","followers_url":"https://api.github.com/users/bsc-s2/followers","following_url":"https://api.github.com/users/bsc-s2/following{/other_user}","gists_url":"https://api.github.com/users/bsc-s2/gists{/gist_id}","starred_url":"https://api.github.com/users/bsc-s2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsc-s2/subscriptions","organizations_url":"https://api.github.com/users/bsc-s2/orgs","repos_url":"https://api.github.com/users/bsc-s2/repos","events_url":"https://api.github.com/users/bsc-s2/events{/privacy}","received_events_url":"https://api.github.com/users/bsc-s2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bsc-s2/pykit","description":"a collection of toolkit lib for distributed system development in python","fork":false,"url":"https://api.github.com/repos/bsc-s2/pykit","forks_url":"https://api.github.com/repos/bsc-s2/pykit/forks","keys_url":"https://api.github.com/repos/bsc-s2/pykit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsc-s2/pykit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsc-s2/pykit/teams","hooks_url":"https://api.github.com/repos/bsc-s2/pykit/hooks","issue_events_url":"https://api.github.com/repos/bsc-s2/pykit/issues/events{/number}","events_url":"https://api.github.com/repos/bsc-s2/pykit/events","assignees_url":"https://api.github.com/repos/bsc-s2/pykit/assignees{/user}","branches_url":"https://api.github.com/repos/bsc-s2/pykit/branches{/branch}","tags_url":"https://api.github.com/repos/bsc-s2/pykit/tags","blobs_url":"https://api.github.com/repos/bsc-s2/pykit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsc-s2/pykit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsc-s2/pykit/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsc-s2/pykit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsc-s2/pykit/statuses/{sha}","languages_url":"https://api.github.com/repos/bsc-s2/pykit/languages","stargazers_url":"https://api.github.com/repos/bsc-s2/pykit/stargazers","contributors_url":"https://api.github.com/repos/bsc-s2/pykit/contributors","subscribers_url":"https://api.github.com/repos/bsc-s2/pykit/subscribers","subscription_url":"https://api.github.com/repos/bsc-s2/pykit/subscription","commits_url":"https://api.github.com/repos/bsc-s2/pykit/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsc-s2/pykit/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsc-s2/pykit/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsc-s2/pykit/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsc-s2/pykit/contents/{+path}","compare_url":"https://api.github.com/repos/bsc-s2/pykit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsc-s2/pykit/merges","archive_url":"https://api.github.com/repos/bsc-s2/pykit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsc-s2/pykit/downloads","issues_url":"https://api.github.com/repos/bsc-s2/pykit/issues{/number}","pulls_url":"https://api.github.com/repos/bsc-s2/pykit/pulls{/number}","milestones_url":"https://api.github.com/repos/bsc-s2/pykit/milestones{/number}","notifications_url":"https://api.github.com/repos/bsc-s2/pykit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsc-s2/pykit/labels{/name}","releases_url":"https://api.github.com/repos/bsc-s2/pykit/releases{/id}","deployments_url":"https://api.github.com/repos/bsc-s2/pykit/deployments","created_at":"2016-12-03T09:38:38Z","updated_at":"2018-07-16T09:18:41Z","pushed_at":"2018-07-18T02:27:57Z","git_url":"git://github.com/bsc-s2/pykit.git","ssh_url":"git@github.com:bsc-s2/pykit.git","clone_url":"https://github.com/bsc-s2/pykit.git","svn_url":"https://github.com/bsc-s2/pykit","homepage":null,"size":3740,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":11,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bsc-s2/pykit/pulls/369"},"html":{"href":"https://github.com/bsc-s2/pykit/pull/369"},"issue":{"href":"https://api.github.com/repos/bsc-s2/pykit/issues/369"},"comments":{"href":"https://api.github.com/repos/bsc-s2/pykit/issues/369/comments"},"review_comments":{"href":"https://api.github.com/repos/bsc-s2/pykit/pulls/369/comments"},"review_comment":{"href":"https://api.github.com/repos/bsc-s2/pykit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bsc-s2/pykit/pulls/369/commits"},"statuses":{"href":"https://api.github.com/repos/bsc-s2/pykit/statuses/db4d74b3595475dbc5ed36aeb7b31abfe98c8bdb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"drmingdrmer"}}