{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/198318533","pull_request_review_id":132229608,"id":198318533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODMxODUzMw==","diff_hunk":"@@ -1348,6 +1319,36 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo\n     initializeDisplayPlugins();\n     qCDebug(interfaceapp, \"Initialized Display\");\n \n+    // Ignore any previous crashes if running from command line with a test script.\n+    bool inTestMode { false };\n+    for (int i = 0; i < argc; ++i) {\n+        QString parameter(argv[i]);\n+        if (parameter == TEST_SCRIPT_COMMAND) {\n+            inTestMode = true;\n+            break;\n+        }\n+    }\n+\n+    static const auto SUPPRESS_SETTINGS_RESET = \"--suppress-settings-reset\";\n+    bool suppressPrompt = cmdOptionExists(argc, const_cast<const char**>(argv), SUPPRESS_SETTINGS_RESET);\n+\n+    if (!inTestMode && !qApp->isHMDMode()) {","path":"interface/src/Application.cpp","position":87,"original_position":87,"commit_id":"34d798a87017c156081fd3d85e6794d324e216f3","original_commit_id":"34d798a87017c156081fd3d85e6794d324e216f3","user":{"login":"wayne-chen","id":10539521,"node_id":"MDQ6VXNlcjEwNTM5NTIx","avatar_url":"https://avatars1.githubusercontent.com/u/10539521?v=4","gravatar_id":"","url":"https://api.github.com/users/wayne-chen","html_url":"https://github.com/wayne-chen","followers_url":"https://api.github.com/users/wayne-chen/followers","following_url":"https://api.github.com/users/wayne-chen/following{/other_user}","gists_url":"https://api.github.com/users/wayne-chen/gists{/gist_id}","starred_url":"https://api.github.com/users/wayne-chen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wayne-chen/subscriptions","organizations_url":"https://api.github.com/users/wayne-chen/orgs","repos_url":"https://api.github.com/users/wayne-chen/repos","events_url":"https://api.github.com/users/wayne-chen/events{/privacy}","received_events_url":"https://api.github.com/users/wayne-chen/received_events","type":"User","site_admin":false},"body":"Thanks for the review.  If a check were performed on this, wouldn't that mean that the need would be to load at least the Oculus plugin of some sort in order to check if it were loaded via Oculus Home?","created_at":"2018-06-26T22:34:58Z","updated_at":"2018-06-26T22:34:59Z","html_url":"https://github.com/highfidelity/hifi/pull/13423#discussion_r198318533","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13423","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/198318533"},"html":{"href":"https://github.com/highfidelity/hifi/pull/13423#discussion_r198318533"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13423"}},"in_reply_to_id":197897672},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/13423","id":195983212,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTgzMjEy","html_url":"https://github.com/highfidelity/hifi/pull/13423","diff_url":"https://github.com/highfidelity/hifi/pull/13423.diff","patch_url":"https://github.com/highfidelity/hifi/pull/13423.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/13423","number":13423,"state":"open","locked":false,"title":"Fix crash dialog when launching Interface from Oculus Home or Steam","user":{"login":"wayne-chen","id":10539521,"node_id":"MDQ6VXNlcjEwNTM5NTIx","avatar_url":"https://avatars1.githubusercontent.com/u/10539521?v=4","gravatar_id":"","url":"https://api.github.com/users/wayne-chen","html_url":"https://github.com/wayne-chen","followers_url":"https://api.github.com/users/wayne-chen/followers","following_url":"https://api.github.com/users/wayne-chen/following{/other_user}","gists_url":"https://api.github.com/users/wayne-chen/gists{/gist_id}","starred_url":"https://api.github.com/users/wayne-chen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wayne-chen/subscriptions","organizations_url":"https://api.github.com/users/wayne-chen/orgs","repos_url":"https://api.github.com/users/wayne-chen/repos","events_url":"https://api.github.com/users/wayne-chen/events{/privacy}","received_events_url":"https://api.github.com/users/wayne-chen/received_events","type":"User","site_admin":false},"body":"- Omitting crash dialog when loading Interface from Oculus Home/Steam.\r\n\r\nhttps://highfidelity.manuscript.com/f/cases/15597/the-you-crashed-last-time-on-startup-message-doesn-t-work-well-when-launching-from-Oculus-home-or-Steam ","created_at":"2018-06-19T23:15:38Z","updated_at":"2018-06-26T22:34:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c8d1e76bb4845673254722d3136f899be14795d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":743411186,"node_id":"MDU6TGFiZWw3NDM0MTExODY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Client","name":"Client","color":"2872fc","default":false},{"id":314155316,"node_id":"MDU6TGFiZWwzMTQxNTUzMTY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Approved%20:tada:","name":"QA Approved :tada:","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/30","html_url":"https://github.com/highfidelity/hifi/milestone/30","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/30/labels","id":3290828,"node_id":"MDk6TWlsZXN0b25lMzI5MDgyOA==","number":30,"title":"RC70","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":55,"state":"open","created_at":"2018-04-23T19:27:01Z","updated_at":"2018-06-26T22:03:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13423/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13423/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/13423/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/34d798a87017c156081fd3d85e6794d324e216f3","head":{"label":"wayne-chen:crashDialogToFront-case-15597","ref":"crashDialogToFront-case-15597","sha":"34d798a87017c156081fd3d85e6794d324e216f3","user":{"login":"wayne-chen","id":10539521,"node_id":"MDQ6VXNlcjEwNTM5NTIx","avatar_url":"https://avatars1.githubusercontent.com/u/10539521?v=4","gravatar_id":"","url":"https://api.github.com/users/wayne-chen","html_url":"https://github.com/wayne-chen","followers_url":"https://api.github.com/users/wayne-chen/followers","following_url":"https://api.github.com/users/wayne-chen/following{/other_user}","gists_url":"https://api.github.com/users/wayne-chen/gists{/gist_id}","starred_url":"https://api.github.com/users/wayne-chen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wayne-chen/subscriptions","organizations_url":"https://api.github.com/users/wayne-chen/orgs","repos_url":"https://api.github.com/users/wayne-chen/repos","events_url":"https://api.github.com/users/wayne-chen/events{/privacy}","received_events_url":"https://api.github.com/users/wayne-chen/received_events","type":"User","site_admin":false},"repo":{"id":132780358,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3ODAzNTg=","name":"hifi","full_name":"wayne-chen/hifi","owner":{"login":"wayne-chen","id":10539521,"node_id":"MDQ6VXNlcjEwNTM5NTIx","avatar_url":"https://avatars1.githubusercontent.com/u/10539521?v=4","gravatar_id":"","url":"https://api.github.com/users/wayne-chen","html_url":"https://github.com/wayne-chen","followers_url":"https://api.github.com/users/wayne-chen/followers","following_url":"https://api.github.com/users/wayne-chen/following{/other_user}","gists_url":"https://api.github.com/users/wayne-chen/gists{/gist_id}","starred_url":"https://api.github.com/users/wayne-chen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wayne-chen/subscriptions","organizations_url":"https://api.github.com/users/wayne-chen/orgs","repos_url":"https://api.github.com/users/wayne-chen/repos","events_url":"https://api.github.com/users/wayne-chen/events{/privacy}","received_events_url":"https://api.github.com/users/wayne-chen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wayne-chen/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":true,"url":"https://api.github.com/repos/wayne-chen/hifi","forks_url":"https://api.github.com/repos/wayne-chen/hifi/forks","keys_url":"https://api.github.com/repos/wayne-chen/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wayne-chen/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wayne-chen/hifi/teams","hooks_url":"https://api.github.com/repos/wayne-chen/hifi/hooks","issue_events_url":"https://api.github.com/repos/wayne-chen/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/wayne-chen/hifi/events","assignees_url":"https://api.github.com/repos/wayne-chen/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/wayne-chen/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/wayne-chen/hifi/tags","blobs_url":"https://api.github.com/repos/wayne-chen/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wayne-chen/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wayne-chen/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/wayne-chen/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wayne-chen/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/wayne-chen/hifi/languages","stargazers_url":"https://api.github.com/repos/wayne-chen/hifi/stargazers","contributors_url":"https://api.github.com/repos/wayne-chen/hifi/contributors","subscribers_url":"https://api.github.com/repos/wayne-chen/hifi/subscribers","subscription_url":"https://api.github.com/repos/wayne-chen/hifi/subscription","commits_url":"https://api.github.com/repos/wayne-chen/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/wayne-chen/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/wayne-chen/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/wayne-chen/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/wayne-chen/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/wayne-chen/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wayne-chen/hifi/merges","archive_url":"https://api.github.com/repos/wayne-chen/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wayne-chen/hifi/downloads","issues_url":"https://api.github.com/repos/wayne-chen/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/wayne-chen/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/wayne-chen/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/wayne-chen/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wayne-chen/hifi/labels{/name}","releases_url":"https://api.github.com/repos/wayne-chen/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/wayne-chen/hifi/deployments","created_at":"2018-05-09T15:54:06Z","updated_at":"2018-06-22T20:53:26Z","pushed_at":"2018-06-26T21:47:48Z","git_url":"git://github.com/wayne-chen/hifi.git","ssh_url":"git@github.com:wayne-chen/hifi.git","clone_url":"https://github.com/wayne-chen/hifi.git","svn_url":"https://github.com/wayne-chen/hifi","homepage":"","size":538944,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"4424a8df1136da771c7acd1802b6ad867d37b05c","user":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"node_id":"MDEwOlJlcG9zaXRvcnk1MzcyODcy","name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2018-06-26T20:57:35Z","pushed_at":"2018-06-26T22:31:40Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":539082,"stargazers_count":631,"watchers_count":631,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":402,"mirror_url":null,"archived":false,"open_issues_count":168,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":402,"open_issues":168,"watchers":631,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13423"},"html":{"href":"https://github.com/highfidelity/hifi/pull/13423"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/13423"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/13423/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13423/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13423/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/34d798a87017c156081fd3d85e6794d324e216f3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wayne-chen"}}