{"action":"created","comment":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/comments/236041667","pull_request_review_id":178050115,"id":236041667,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA0MTY2Nw==","diff_hunk":"@@ -137,24 +267,28 @@ def bin_sha256(string):\n def sha256(string):\n     return bytes_to_hex_string(bin_sha256(string))\n \n-def bin_dbl_sha256(s):\n-    bytes_to_hash = from_string_to_bytes(s)\n+def bin_dbl_sha256(bytes_to_hash):\n     return hashlib.sha256(hashlib.sha256(bytes_to_hash).digest()).digest()\n \n def dbl_sha256(string):\n-    return safe_hexlify(bin_dbl_sha256(string))\n+    return hashlib.sha256(hashlib.sha256(string).digest()).hexdigest()\n \n def hash_to_int(x):\n     if len(x) in [40, 64]:\n         return decode(x, 16)\n     return decode(x, 256)\n \n def num_to_var_int(x):\n-    x = int(x)\n+    if not isinstance(x, int):\n+        if len(x) == 0:\n+            return b'\\x00'\n+        x = struct.unpack('B', x)[0]\n+    if x == 0:\n+        return b'\\x00'","path":"jmbitcoin/jmbitcoin/secp256k1_main.py","position":341,"original_position":341,"commit_id":"09aea95129c378adc4b695e6f3a63326859dcdf0","original_commit_id":"09aea95129c378adc4b695e6f3a63326859dcdf0","user":{"login":"undeath","id":1469278,"node_id":"MDQ6VXNlcjE0NjkyNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1469278?v=4","gravatar_id":"","url":"https://api.github.com/users/undeath","html_url":"https://github.com/undeath","followers_url":"https://api.github.com/users/undeath/followers","following_url":"https://api.github.com/users/undeath/following{/other_user}","gists_url":"https://api.github.com/users/undeath/gists{/gist_id}","starred_url":"https://api.github.com/users/undeath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/undeath/subscriptions","organizations_url":"https://api.github.com/users/undeath/orgs","repos_url":"https://api.github.com/users/undeath/repos","events_url":"https://api.github.com/users/undeath/events{/privacy}","received_events_url":"https://api.github.com/users/undeath/received_events","type":"User","site_admin":false},"body":"This will fail in weird ways in py2 when passing a long. Why is the `isinstance` check needed?","created_at":"2018-11-24T12:51:50Z","updated_at":"2018-11-24T12:51:50Z","html_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/229#discussion_r236041667","pull_request_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/229","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/comments/236041667"},"html":{"href":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/229#discussion_r236041667"},"pull_request":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/229"}},"in_reply_to_id":236034138},"pull_request":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/229","id":233140532,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMTQwNTMy","html_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/229","diff_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/229.diff","patch_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/229.patch","issue_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/229","number":229,"state":"open","locked":false,"title":"WIP: Convert jmbitcoin to py3 style","user":{"login":"jameshilliard","id":3298484,"node_id":"MDQ6VXNlcjMyOTg0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3298484?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshilliard","html_url":"https://github.com/jameshilliard","followers_url":"https://api.github.com/users/jameshilliard/followers","following_url":"https://api.github.com/users/jameshilliard/following{/other_user}","gists_url":"https://api.github.com/users/jameshilliard/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshilliard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshilliard/subscriptions","organizations_url":"https://api.github.com/users/jameshilliard/orgs","repos_url":"https://api.github.com/users/jameshilliard/repos","events_url":"https://api.github.com/users/jameshilliard/events{/privacy}","received_events_url":"https://api.github.com/users/jameshilliard/received_events","type":"User","site_admin":false},"body":"This is somewhat broken still, could use suggestions/review though.","created_at":"2018-11-23T09:16:28Z","updated_at":"2018-11-24T12:51:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6754be6580d795b19ff267fa187ccacea8acfe0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/229/commits","review_comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/229/comments","review_comment_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/229/comments","statuses_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/statuses/09aea95129c378adc4b695e6f3a63326859dcdf0","head":{"label":"jameshilliard:future","ref":"future","sha":"09aea95129c378adc4b695e6f3a63326859dcdf0","user":{"login":"jameshilliard","id":3298484,"node_id":"MDQ6VXNlcjMyOTg0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3298484?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshilliard","html_url":"https://github.com/jameshilliard","followers_url":"https://api.github.com/users/jameshilliard/followers","following_url":"https://api.github.com/users/jameshilliard/following{/other_user}","gists_url":"https://api.github.com/users/jameshilliard/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshilliard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshilliard/subscriptions","organizations_url":"https://api.github.com/users/jameshilliard/orgs","repos_url":"https://api.github.com/users/jameshilliard/repos","events_url":"https://api.github.com/users/jameshilliard/events{/privacy}","received_events_url":"https://api.github.com/users/jameshilliard/received_events","type":"User","site_admin":false},"repo":{"id":111254762,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyNTQ3NjI=","name":"joinmarket-clientserver","full_name":"jameshilliard/joinmarket-clientserver","private":false,"owner":{"login":"jameshilliard","id":3298484,"node_id":"MDQ6VXNlcjMyOTg0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3298484?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshilliard","html_url":"https://github.com/jameshilliard","followers_url":"https://api.github.com/users/jameshilliard/followers","following_url":"https://api.github.com/users/jameshilliard/following{/other_user}","gists_url":"https://api.github.com/users/jameshilliard/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshilliard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshilliard/subscriptions","organizations_url":"https://api.github.com/users/jameshilliard/orgs","repos_url":"https://api.github.com/users/jameshilliard/repos","events_url":"https://api.github.com/users/jameshilliard/events{/privacy}","received_events_url":"https://api.github.com/users/jameshilliard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jameshilliard/joinmarket-clientserver","description":"Joinmarket refactored to separate client and backend operations","fork":true,"url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver","forks_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/forks","keys_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/teams","hooks_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/hooks","issue_events_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/issues/events{/number}","events_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/events","assignees_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/assignees{/user}","branches_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/branches{/branch}","tags_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/tags","blobs_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/statuses/{sha}","languages_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/languages","stargazers_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/stargazers","contributors_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/contributors","subscribers_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/subscribers","subscription_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/subscription","commits_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/contents/{+path}","compare_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/merges","archive_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/downloads","issues_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/issues{/number}","pulls_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/pulls{/number}","milestones_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/milestones{/number}","notifications_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/labels{/name}","releases_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/releases{/id}","deployments_url":"https://api.github.com/repos/jameshilliard/joinmarket-clientserver/deployments","created_at":"2017-11-19T01:30:33Z","updated_at":"2018-11-14T23:02:22Z","pushed_at":"2018-11-24T06:44:24Z","git_url":"git://github.com/jameshilliard/joinmarket-clientserver.git","ssh_url":"git@github.com:jameshilliard/joinmarket-clientserver.git","clone_url":"https://github.com/jameshilliard/joinmarket-clientserver.git","svn_url":"https://github.com/jameshilliard/joinmarket-clientserver","homepage":null,"size":2965,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JoinMarket-Org:master","ref":"master","sha":"974b59873f664bbe1d6e95adbd5d3f762e9f648d","user":{"login":"JoinMarket-Org","id":16105296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTA1Mjk2","avatar_url":"https://avatars3.githubusercontent.com/u/16105296?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinMarket-Org","html_url":"https://github.com/JoinMarket-Org","followers_url":"https://api.github.com/users/JoinMarket-Org/followers","following_url":"https://api.github.com/users/JoinMarket-Org/following{/other_user}","gists_url":"https://api.github.com/users/JoinMarket-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinMarket-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinMarket-Org/subscriptions","organizations_url":"https://api.github.com/users/JoinMarket-Org/orgs","repos_url":"https://api.github.com/users/JoinMarket-Org/repos","events_url":"https://api.github.com/users/JoinMarket-Org/events{/privacy}","received_events_url":"https://api.github.com/users/JoinMarket-Org/received_events","type":"Organization","site_admin":false},"repo":{"id":74501389,"node_id":"MDEwOlJlcG9zaXRvcnk3NDUwMTM4OQ==","name":"joinmarket-clientserver","full_name":"JoinMarket-Org/joinmarket-clientserver","private":false,"owner":{"login":"JoinMarket-Org","id":16105296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTA1Mjk2","avatar_url":"https://avatars3.githubusercontent.com/u/16105296?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinMarket-Org","html_url":"https://github.com/JoinMarket-Org","followers_url":"https://api.github.com/users/JoinMarket-Org/followers","following_url":"https://api.github.com/users/JoinMarket-Org/following{/other_user}","gists_url":"https://api.github.com/users/JoinMarket-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinMarket-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinMarket-Org/subscriptions","organizations_url":"https://api.github.com/users/JoinMarket-Org/orgs","repos_url":"https://api.github.com/users/JoinMarket-Org/repos","events_url":"https://api.github.com/users/JoinMarket-Org/events{/privacy}","received_events_url":"https://api.github.com/users/JoinMarket-Org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver","description":"Joinmarket refactored to separate client and backend operations","fork":false,"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver","forks_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/forks","keys_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/teams","hooks_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/hooks","issue_events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/events{/number}","events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/events","assignees_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/assignees{/user}","branches_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/branches{/branch}","tags_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/tags","blobs_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/statuses/{sha}","languages_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/languages","stargazers_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/stargazers","contributors_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/contributors","subscribers_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/subscribers","subscription_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/subscription","commits_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/contents/{+path}","compare_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/merges","archive_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/downloads","issues_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues{/number}","pulls_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls{/number}","milestones_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/milestones{/number}","notifications_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/labels{/name}","releases_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/releases{/id}","deployments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/deployments","created_at":"2016-11-22T18:23:20Z","updated_at":"2018-11-23T16:16:52Z","pushed_at":"2018-11-24T06:44:25Z","git_url":"git://github.com/JoinMarket-Org/joinmarket-clientserver.git","ssh_url":"git@github.com:JoinMarket-Org/joinmarket-clientserver.git","clone_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver.git","svn_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver","homepage":null,"size":3053,"stargazers_count":45,"watchers_count":45,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":28,"open_issues":29,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/229"},"html":{"href":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/229"},"issue":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/229"},"comments":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/statuses/09aea95129c378adc4b695e6f3a63326859dcdf0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"undeath"}}