{"action":"opened","number":806,"pull_request":{"url":"https://api.github.com/repos/argoproj/argo/pulls/806","id":177508795,"html_url":"https://github.com/argoproj/argo/pull/806","diff_url":"https://github.com/argoproj/argo/pull/806.diff","patch_url":"https://github.com/argoproj/argo/pull/806.patch","issue_url":"https://api.github.com/repos/argoproj/argo/issues/806","number":806,"state":"open","locked":false,"title":"Omit empty status fields.","user":{"login":"mthx","id":457790,"avatar_url":"https://avatars1.githubusercontent.com/u/457790?v=4","gravatar_id":"","url":"https://api.github.com/users/mthx","html_url":"https://github.com/mthx","followers_url":"https://api.github.com/users/mthx/followers","following_url":"https://api.github.com/users/mthx/following{/other_user}","gists_url":"https://api.github.com/users/mthx/gists{/gist_id}","starred_url":"https://api.github.com/users/mthx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mthx/subscriptions","organizations_url":"https://api.github.com/users/mthx/orgs","repos_url":"https://api.github.com/users/mthx/repos","events_url":"https://api.github.com/users/mthx/events{/privacy}","received_events_url":"https://api.github.com/users/mthx/received_events","type":"User","site_admin":false},"body":"Primary motivation is to avoid an empty string phase value, which is\r\nawkward to map to JSON in languages other than Go, and surprising as\r\nit only arises in ADDED events.\r\n\r\nThis is could be a disruptive change for workflow clients expecting the\r\nempty value, but not sure this is likely in practice.\r\n\r\nA newly added workflow now gives:\r\n```json\r\n    \"status\": {\r\n        \"finishedAt\": null,\r\n        \"startedAt\": null\r\n    }\r\n```\r\n\r\nThe time values already have omitempty but as they're structs this\r\ndoesn't help. The nulls here are consistent with time serialization\r\nelsewhere in Kubernetes so probably best left as is.","created_at":"2018-03-26T17:02:42Z","updated_at":"2018-03-26T17:02:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/argoproj/argo/pulls/806/commits","review_comments_url":"https://api.github.com/repos/argoproj/argo/pulls/806/comments","review_comment_url":"https://api.github.com/repos/argoproj/argo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/argoproj/argo/issues/806/comments","statuses_url":"https://api.github.com/repos/argoproj/argo/statuses/2baa6a99bb6304597ed5dd9cb695a751370e921b","head":{"label":"mthx:feature/omit-empty-status-fields","ref":"feature/omit-empty-status-fields","sha":"2baa6a99bb6304597ed5dd9cb695a751370e921b","user":{"login":"mthx","id":457790,"avatar_url":"https://avatars1.githubusercontent.com/u/457790?v=4","gravatar_id":"","url":"https://api.github.com/users/mthx","html_url":"https://github.com/mthx","followers_url":"https://api.github.com/users/mthx/followers","following_url":"https://api.github.com/users/mthx/following{/other_user}","gists_url":"https://api.github.com/users/mthx/gists{/gist_id}","starred_url":"https://api.github.com/users/mthx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mthx/subscriptions","organizations_url":"https://api.github.com/users/mthx/orgs","repos_url":"https://api.github.com/users/mthx/repos","events_url":"https://api.github.com/users/mthx/events{/privacy}","received_events_url":"https://api.github.com/users/mthx/received_events","type":"User","site_admin":false},"repo":{"id":116686009,"name":"argo","full_name":"mthx/argo","owner":{"login":"mthx","id":457790,"avatar_url":"https://avatars1.githubusercontent.com/u/457790?v=4","gravatar_id":"","url":"https://api.github.com/users/mthx","html_url":"https://github.com/mthx","followers_url":"https://api.github.com/users/mthx/followers","following_url":"https://api.github.com/users/mthx/following{/other_user}","gists_url":"https://api.github.com/users/mthx/gists{/gist_id}","starred_url":"https://api.github.com/users/mthx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mthx/subscriptions","organizations_url":"https://api.github.com/users/mthx/orgs","repos_url":"https://api.github.com/users/mthx/repos","events_url":"https://api.github.com/users/mthx/events{/privacy}","received_events_url":"https://api.github.com/users/mthx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mthx/argo","description":"Get stuff done with container-native workflows for Kubernetes.","fork":true,"url":"https://api.github.com/repos/mthx/argo","forks_url":"https://api.github.com/repos/mthx/argo/forks","keys_url":"https://api.github.com/repos/mthx/argo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mthx/argo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mthx/argo/teams","hooks_url":"https://api.github.com/repos/mthx/argo/hooks","issue_events_url":"https://api.github.com/repos/mthx/argo/issues/events{/number}","events_url":"https://api.github.com/repos/mthx/argo/events","assignees_url":"https://api.github.com/repos/mthx/argo/assignees{/user}","branches_url":"https://api.github.com/repos/mthx/argo/branches{/branch}","tags_url":"https://api.github.com/repos/mthx/argo/tags","blobs_url":"https://api.github.com/repos/mthx/argo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mthx/argo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mthx/argo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mthx/argo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mthx/argo/statuses/{sha}","languages_url":"https://api.github.com/repos/mthx/argo/languages","stargazers_url":"https://api.github.com/repos/mthx/argo/stargazers","contributors_url":"https://api.github.com/repos/mthx/argo/contributors","subscribers_url":"https://api.github.com/repos/mthx/argo/subscribers","subscription_url":"https://api.github.com/repos/mthx/argo/subscription","commits_url":"https://api.github.com/repos/mthx/argo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mthx/argo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mthx/argo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mthx/argo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mthx/argo/contents/{+path}","compare_url":"https://api.github.com/repos/mthx/argo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mthx/argo/merges","archive_url":"https://api.github.com/repos/mthx/argo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mthx/argo/downloads","issues_url":"https://api.github.com/repos/mthx/argo/issues{/number}","pulls_url":"https://api.github.com/repos/mthx/argo/pulls{/number}","milestones_url":"https://api.github.com/repos/mthx/argo/milestones{/number}","notifications_url":"https://api.github.com/repos/mthx/argo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mthx/argo/labels{/name}","releases_url":"https://api.github.com/repos/mthx/argo/releases{/id}","deployments_url":"https://api.github.com/repos/mthx/argo/deployments","created_at":"2018-01-08T14:21:02Z","updated_at":"2018-01-08T14:21:04Z","pushed_at":"2018-03-26T17:02:17Z","git_url":"git://github.com/mthx/argo.git","ssh_url":"git@github.com:mthx/argo.git","clone_url":"https://github.com/mthx/argo.git","svn_url":"https://github.com/mthx/argo","homepage":"","size":17910,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"argoproj:master","ref":"master","sha":"383276f300e666bf133a0355f2da493997ddd6cc","user":{"login":"argoproj","id":30269780,"avatar_url":"https://avatars3.githubusercontent.com/u/30269780?v=4","gravatar_id":"","url":"https://api.github.com/users/argoproj","html_url":"https://github.com/argoproj","followers_url":"https://api.github.com/users/argoproj/followers","following_url":"https://api.github.com/users/argoproj/following{/other_user}","gists_url":"https://api.github.com/users/argoproj/gists{/gist_id}","starred_url":"https://api.github.com/users/argoproj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/argoproj/subscriptions","organizations_url":"https://api.github.com/users/argoproj/orgs","repos_url":"https://api.github.com/users/argoproj/repos","events_url":"https://api.github.com/users/argoproj/events{/privacy}","received_events_url":"https://api.github.com/users/argoproj/received_events","type":"Organization","site_admin":false},"repo":{"id":100982449,"name":"argo","full_name":"argoproj/argo","owner":{"login":"argoproj","id":30269780,"avatar_url":"https://avatars3.githubusercontent.com/u/30269780?v=4","gravatar_id":"","url":"https://api.github.com/users/argoproj","html_url":"https://github.com/argoproj","followers_url":"https://api.github.com/users/argoproj/followers","following_url":"https://api.github.com/users/argoproj/following{/other_user}","gists_url":"https://api.github.com/users/argoproj/gists{/gist_id}","starred_url":"https://api.github.com/users/argoproj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/argoproj/subscriptions","organizations_url":"https://api.github.com/users/argoproj/orgs","repos_url":"https://api.github.com/users/argoproj/repos","events_url":"https://api.github.com/users/argoproj/events{/privacy}","received_events_url":"https://api.github.com/users/argoproj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/argoproj/argo","description":"Get stuff done with container-native workflows for Kubernetes.","fork":false,"url":"https://api.github.com/repos/argoproj/argo","forks_url":"https://api.github.com/repos/argoproj/argo/forks","keys_url":"https://api.github.com/repos/argoproj/argo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/argoproj/argo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/argoproj/argo/teams","hooks_url":"https://api.github.com/repos/argoproj/argo/hooks","issue_events_url":"https://api.github.com/repos/argoproj/argo/issues/events{/number}","events_url":"https://api.github.com/repos/argoproj/argo/events","assignees_url":"https://api.github.com/repos/argoproj/argo/assignees{/user}","branches_url":"https://api.github.com/repos/argoproj/argo/branches{/branch}","tags_url":"https://api.github.com/repos/argoproj/argo/tags","blobs_url":"https://api.github.com/repos/argoproj/argo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/argoproj/argo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/argoproj/argo/git/refs{/sha}","trees_url":"https://api.github.com/repos/argoproj/argo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/argoproj/argo/statuses/{sha}","languages_url":"https://api.github.com/repos/argoproj/argo/languages","stargazers_url":"https://api.github.com/repos/argoproj/argo/stargazers","contributors_url":"https://api.github.com/repos/argoproj/argo/contributors","subscribers_url":"https://api.github.com/repos/argoproj/argo/subscribers","subscription_url":"https://api.github.com/repos/argoproj/argo/subscription","commits_url":"https://api.github.com/repos/argoproj/argo/commits{/sha}","git_commits_url":"https://api.github.com/repos/argoproj/argo/git/commits{/sha}","comments_url":"https://api.github.com/repos/argoproj/argo/comments{/number}","issue_comment_url":"https://api.github.com/repos/argoproj/argo/issues/comments{/number}","contents_url":"https://api.github.com/repos/argoproj/argo/contents/{+path}","compare_url":"https://api.github.com/repos/argoproj/argo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/argoproj/argo/merges","archive_url":"https://api.github.com/repos/argoproj/argo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/argoproj/argo/downloads","issues_url":"https://api.github.com/repos/argoproj/argo/issues{/number}","pulls_url":"https://api.github.com/repos/argoproj/argo/pulls{/number}","milestones_url":"https://api.github.com/repos/argoproj/argo/milestones{/number}","notifications_url":"https://api.github.com/repos/argoproj/argo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/argoproj/argo/labels{/name}","releases_url":"https://api.github.com/repos/argoproj/argo/releases{/id}","deployments_url":"https://api.github.com/repos/argoproj/argo/deployments","created_at":"2017-08-21T18:50:44Z","updated_at":"2018-03-26T15:41:34Z","pushed_at":"2018-03-25T02:14:04Z","git_url":"git://github.com/argoproj/argo.git","ssh_url":"git@github.com:argoproj/argo.git","clone_url":"https://github.com/argoproj/argo.git","svn_url":"https://github.com/argoproj/argo","homepage":"","size":17992,"stargazers_count":528,"watchers_count":528,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":73,"open_issues":56,"watchers":528,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/argoproj/argo/pulls/806"},"html":{"href":"https://github.com/argoproj/argo/pull/806"},"issue":{"href":"https://api.github.com/repos/argoproj/argo/issues/806"},"comments":{"href":"https://api.github.com/repos/argoproj/argo/issues/806/comments"},"review_comments":{"href":"https://api.github.com/repos/argoproj/argo/pulls/806/comments"},"review_comment":{"href":"https://api.github.com/repos/argoproj/argo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/argoproj/argo/pulls/806/commits"},"statuses":{"href":"https://api.github.com/repos/argoproj/argo/statuses/2baa6a99bb6304597ed5dd9cb695a751370e921b"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"mthx"}}