{"action":"created","issue":{"url":"https://api.github.com/repos/ccxt/ccxt/issues/4282","repository_url":"https://api.github.com/repos/ccxt/ccxt","labels_url":"https://api.github.com/repos/ccxt/ccxt/issues/4282/labels{/name}","comments_url":"https://api.github.com/repos/ccxt/ccxt/issues/4282/comments","events_url":"https://api.github.com/repos/ccxt/ccxt/issues/4282/events","html_url":"https://github.com/ccxt/ccxt/pull/4282","id":387745183,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MTY0NzQ5","number":4282,"title":"Don't attempt to parse unparsable strings in base exchange parse functions","user":{"login":"Legogris","id":108799,"node_id":"MDQ6VXNlcjEwODc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/108799?v=4","gravatar_id":"","url":"https://api.github.com/users/Legogris","html_url":"https://github.com/Legogris","followers_url":"https://api.github.com/users/Legogris/followers","following_url":"https://api.github.com/users/Legogris/following{/other_user}","gists_url":"https://api.github.com/users/Legogris/gists{/gist_id}","starred_url":"https://api.github.com/users/Legogris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Legogris/subscriptions","organizations_url":"https://api.github.com/users/Legogris/orgs","repos_url":"https://api.github.com/users/Legogris/repos","events_url":"https://api.github.com/users/Legogris/events{/privacy}","received_events_url":"https://api.github.com/users/Legogris/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"kroitor","id":1294454,"node_id":"MDQ6VXNlcjEyOTQ0NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false},"assignees":[{"login":"kroitor","id":1294454,"node_id":"MDQ6VXNlcjEyOTQ0NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-12-05T12:57:59Z","updated_at":"2018-12-06T19:37:33Z","closed_at":"2018-12-05T14:22:20Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ccxt/ccxt/pulls/4282","html_url":"https://github.com/ccxt/ccxt/pull/4282","diff_url":"https://github.com/ccxt/ccxt/pull/4282.diff","patch_url":"https://github.com/ccxt/ccxt/pull/4282.patch"},"body":"If results from exchange requests are not parsable JSON, raw strings will be iterated over character-wise to yield trades/ohlcv/transactions/orders.\r\nThis throws an ExchangeError if that happens."},"comment":{"url":"https://api.github.com/repos/ccxt/ccxt/issues/comments/445002051","html_url":"https://github.com/ccxt/ccxt/pull/4282#issuecomment-445002051","issue_url":"https://api.github.com/repos/ccxt/ccxt/issues/4282","id":445002051,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTAwMjA1MQ==","user":{"login":"Legogris","id":108799,"node_id":"MDQ6VXNlcjEwODc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/108799?v=4","gravatar_id":"","url":"https://api.github.com/users/Legogris","html_url":"https://github.com/Legogris","followers_url":"https://api.github.com/users/Legogris/followers","following_url":"https://api.github.com/users/Legogris/following{/other_user}","gists_url":"https://api.github.com/users/Legogris/gists{/gist_id}","starred_url":"https://api.github.com/users/Legogris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Legogris/subscriptions","organizations_url":"https://api.github.com/users/Legogris/orgs","repos_url":"https://api.github.com/users/Legogris/repos","events_url":"https://api.github.com/users/Legogris/events{/privacy}","received_events_url":"https://api.github.com/users/Legogris/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T19:37:33Z","updated_at":"2018-12-06T19:37:33Z","author_association":"CONTRIBUTOR","body":"@kroitor I fully agree that this should be handled in the respective exchange modules. But if it happens that some edge case is not handled appropriately, it is IMO more prudent to throw an exception in cases where data is decidedly invalid rather than trying to parse it as if it were valid, if that makes sense."}}
{"actor":{"display_login":"Legogris"}}