{"action":"created","comment":{"url":"https://api.github.com/repos/dat-land/dat-desktop/pulls/comments/221800064","pull_request_review_id":160537028,"id":221800064,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTgwMDA2NA==","diff_hunk":"@@ -7,19 +7,19 @@\n   \"description\": \"Dat Desktop App\",\n   \"author\": \"Dat Team <community@datproject.org>\",\n   \"scripts\": {\n-    \"start\": \"cross-env NODE_V=\\\"$(node -v)\\\" NODE_ENV=development electron .\",\n-    \"pretest\": \"npm run lint\",\n-    \"test\": \"npm run test:unit\",\n+    \"start\": \"cross-env NODE_ENV=development npm-run-all -p watch start:dev\",\n+    \"start:dev\": \"cross-env NODE_V=\\\"$(node -v)\\\" NODE_ENV=development electron .\",\n+    \"watch\": \"webpack --watch --mode=development\",","path":"package.json","position":9,"original_position":9,"commit_id":"b2dc8041245571193882c280d060f218db8c5efb","original_commit_id":"b2dc8041245571193882c280d060f218db8c5efb","user":{"login":"martinheidegger","id":914122,"node_id":"MDQ6VXNlcjkxNDEyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/914122?v=4","gravatar_id":"","url":"https://api.github.com/users/martinheidegger","html_url":"https://github.com/martinheidegger","followers_url":"https://api.github.com/users/martinheidegger/followers","following_url":"https://api.github.com/users/martinheidegger/following{/other_user}","gists_url":"https://api.github.com/users/martinheidegger/gists{/gist_id}","starred_url":"https://api.github.com/users/martinheidegger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinheidegger/subscriptions","organizations_url":"https://api.github.com/users/martinheidegger/orgs","repos_url":"https://api.github.com/users/martinheidegger/repos","events_url":"https://api.github.com/users/martinheidegger/events{/privacy}","received_events_url":"https://api.github.com/users/martinheidegger/received_events","type":"User","site_admin":false},"body":"Maybe \"start:watch\"","created_at":"2018-10-02T00:54:37Z","updated_at":"2018-10-02T00:55:56Z","html_url":"https://github.com/dat-land/dat-desktop/pull/551#discussion_r221800064","pull_request_url":"https://api.github.com/repos/dat-land/dat-desktop/pulls/551","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dat-land/dat-desktop/pulls/comments/221800064"},"html":{"href":"https://github.com/dat-land/dat-desktop/pull/551#discussion_r221800064"},"pull_request":{"href":"https://api.github.com/repos/dat-land/dat-desktop/pulls/551"}}},"pull_request":{"url":"https://api.github.com/repos/dat-land/dat-desktop/pulls/551","id":219503585,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTAzNTg1","html_url":"https://github.com/dat-land/dat-desktop/pull/551","diff_url":"https://github.com/dat-land/dat-desktop/pull/551.diff","patch_url":"https://github.com/dat-land/dat-desktop/pull/551.patch","issue_url":"https://api.github.com/repos/dat-land/dat-desktop/issues/551","number":551,"state":"open","locked":false,"title":"[WIP] Fix/clean npm scripts","user":{"login":"dkastl","id":227762,"node_id":"MDQ6VXNlcjIyNzc2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/227762?v=4","gravatar_id":"","url":"https://api.github.com/users/dkastl","html_url":"https://github.com/dkastl","followers_url":"https://api.github.com/users/dkastl/followers","following_url":"https://api.github.com/users/dkastl/following{/other_user}","gists_url":"https://api.github.com/users/dkastl/gists{/gist_id}","starred_url":"https://api.github.com/users/dkastl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkastl/subscriptions","organizations_url":"https://api.github.com/users/dkastl/orgs","repos_url":"https://api.github.com/users/dkastl/repos","events_url":"https://api.github.com/users/dkastl/events{/privacy}","received_events_url":"https://api.github.com/users/dkastl/received_events","type":"User","site_admin":false},"body":"I found the npm scripts a bit difficult to understand, not only from the point of view of the names, but also how they were organized. \r\n\r\nI tried to use a scope to group them together, where the \"short\" command is usually the one, that contains them all.\r\n\r\nI haven't done anything with `pack` and `dist`. I didn't figure out yet, why there are 6 script entries necessary for something, that probably will be run with CI tools. I also can't think of a case, where all operating systems are built with a single run. I would suggest to reduce those to just `pack` and `dist` for the current OS.","created_at":"2018-10-01T20:22:23Z","updated_at":"2018-10-02T00:55:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8af8751d90fcbe55015899ca1550649fac0823d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AtuyL","id":176803,"node_id":"MDQ6VXNlcjE3NjgwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/176803?v=4","gravatar_id":"","url":"https://api.github.com/users/AtuyL","html_url":"https://github.com/AtuyL","followers_url":"https://api.github.com/users/AtuyL/followers","following_url":"https://api.github.com/users/AtuyL/following{/other_user}","gists_url":"https://api.github.com/users/AtuyL/gists{/gist_id}","starred_url":"https://api.github.com/users/AtuyL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtuyL/subscriptions","organizations_url":"https://api.github.com/users/AtuyL/orgs","repos_url":"https://api.github.com/users/AtuyL/repos","events_url":"https://api.github.com/users/AtuyL/events{/privacy}","received_events_url":"https://api.github.com/users/AtuyL/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dat-land/dat-desktop/pulls/551/commits","review_comments_url":"https://api.github.com/repos/dat-land/dat-desktop/pulls/551/comments","review_comment_url":"https://api.github.com/repos/dat-land/dat-desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dat-land/dat-desktop/issues/551/comments","statuses_url":"https://api.github.com/repos/dat-land/dat-desktop/statuses/b2dc8041245571193882c280d060f218db8c5efb","head":{"label":"dat-land:fix/clean-npm-scripts","ref":"fix/clean-npm-scripts","sha":"b2dc8041245571193882c280d060f218db8c5efb","user":{"login":"dat-land","id":31420224,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDIwMjI0","avatar_url":"https://avatars2.githubusercontent.com/u/31420224?v=4","gravatar_id":"","url":"https://api.github.com/users/dat-land","html_url":"https://github.com/dat-land","followers_url":"https://api.github.com/users/dat-land/followers","following_url":"https://api.github.com/users/dat-land/following{/other_user}","gists_url":"https://api.github.com/users/dat-land/gists{/gist_id}","starred_url":"https://api.github.com/users/dat-land/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dat-land/subscriptions","organizations_url":"https://api.github.com/users/dat-land/orgs","repos_url":"https://api.github.com/users/dat-land/repos","events_url":"https://api.github.com/users/dat-land/events{/privacy}","received_events_url":"https://api.github.com/users/dat-land/received_events","type":"Organization","site_admin":false},"repo":{"id":59699743,"node_id":"MDEwOlJlcG9zaXRvcnk1OTY5OTc0Mw==","name":"dat-desktop","full_name":"dat-land/dat-desktop","private":false,"owner":{"login":"dat-land","id":31420224,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDIwMjI0","avatar_url":"https://avatars2.githubusercontent.com/u/31420224?v=4","gravatar_id":"","url":"https://api.github.com/users/dat-land","html_url":"https://github.com/dat-land","followers_url":"https://api.github.com/users/dat-land/followers","following_url":"https://api.github.com/users/dat-land/following{/other_user}","gists_url":"https://api.github.com/users/dat-land/gists{/gist_id}","starred_url":"https://api.github.com/users/dat-land/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dat-land/subscriptions","organizations_url":"https://api.github.com/users/dat-land/orgs","repos_url":"https://api.github.com/users/dat-land/repos","events_url":"https://api.github.com/users/dat-land/events{/privacy}","received_events_url":"https://api.github.com/users/dat-land/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dat-land/dat-desktop","description":"Peer to peer data sharing app built for humans","fork":false,"url":"https://api.github.com/repos/dat-land/dat-desktop","forks_url":"https://api.github.com/repos/dat-land/dat-desktop/forks","keys_url":"https://api.github.com/repos/dat-land/dat-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dat-land/dat-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dat-land/dat-desktop/teams","hooks_url":"https://api.github.com/repos/dat-land/dat-desktop/hooks","issue_events_url":"https://api.github.com/repos/dat-land/dat-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/dat-land/dat-desktop/events","assignees_url":"https://api.github.com/repos/dat-land/dat-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/dat-land/dat-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/dat-land/dat-desktop/tags","blobs_url":"https://api.github.com/repos/dat-land/dat-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dat-land/dat-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dat-land/dat-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/dat-land/dat-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dat-land/dat-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/dat-land/dat-desktop/languages","stargazers_url":"https://api.github.com/repos/dat-land/dat-desktop/stargazers","contributors_url":"https://api.github.com/repos/dat-land/dat-desktop/contributors","subscribers_url":"https://api.github.com/repos/dat-land/dat-desktop/subscribers","subscription_url":"https://api.github.com/repos/dat-land/dat-desktop/subscription","commits_url":"https://api.github.com/repos/dat-land/dat-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/dat-land/dat-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/dat-land/dat-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/dat-land/dat-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/dat-land/dat-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/dat-land/dat-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dat-land/dat-desktop/merges","archive_url":"https://api.github.com/repos/dat-land/dat-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dat-land/dat-desktop/downloads","issues_url":"https://api.github.com/repos/dat-land/dat-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/dat-land/dat-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/dat-land/dat-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/dat-land/dat-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dat-land/dat-desktop/labels{/name}","releases_url":"https://api.github.com/repos/dat-land/dat-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/dat-land/dat-desktop/deployments","created_at":"2016-05-25T21:42:53Z","updated_at":"2018-09-25T04:44:29Z","pushed_at":"2018-10-01T21:53:36Z","git_url":"git://github.com/dat-land/dat-desktop.git","ssh_url":"git@github.com:dat-land/dat-desktop.git","clone_url":"https://github.com/dat-land/dat-desktop.git","svn_url":"https://github.com/dat-land/dat-desktop","homepage":"http://datproject.org","size":2675,"stargazers_count":420,"watchers_count":420,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":60,"open_issues":65,"watchers":420,"default_branch":"master"}},"base":{"label":"dat-land:react","ref":"react","sha":"472698a1e711b9e9e85b6f3b316d5861619ccd85","user":{"login":"dat-land","id":31420224,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDIwMjI0","avatar_url":"https://avatars2.githubusercontent.com/u/31420224?v=4","gravatar_id":"","url":"https://api.github.com/users/dat-land","html_url":"https://github.com/dat-land","followers_url":"https://api.github.com/users/dat-land/followers","following_url":"https://api.github.com/users/dat-land/following{/other_user}","gists_url":"https://api.github.com/users/dat-land/gists{/gist_id}","starred_url":"https://api.github.com/users/dat-land/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dat-land/subscriptions","organizations_url":"https://api.github.com/users/dat-land/orgs","repos_url":"https://api.github.com/users/dat-land/repos","events_url":"https://api.github.com/users/dat-land/events{/privacy}","received_events_url":"https://api.github.com/users/dat-land/received_events","type":"Organization","site_admin":false},"repo":{"id":59699743,"node_id":"MDEwOlJlcG9zaXRvcnk1OTY5OTc0Mw==","name":"dat-desktop","full_name":"dat-land/dat-desktop","private":false,"owner":{"login":"dat-land","id":31420224,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDIwMjI0","avatar_url":"https://avatars2.githubusercontent.com/u/31420224?v=4","gravatar_id":"","url":"https://api.github.com/users/dat-land","html_url":"https://github.com/dat-land","followers_url":"https://api.github.com/users/dat-land/followers","following_url":"https://api.github.com/users/dat-land/following{/other_user}","gists_url":"https://api.github.com/users/dat-land/gists{/gist_id}","starred_url":"https://api.github.com/users/dat-land/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dat-land/subscriptions","organizations_url":"https://api.github.com/users/dat-land/orgs","repos_url":"https://api.github.com/users/dat-land/repos","events_url":"https://api.github.com/users/dat-land/events{/privacy}","received_events_url":"https://api.github.com/users/dat-land/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dat-land/dat-desktop","description":"Peer to peer data sharing app built for humans","fork":false,"url":"https://api.github.com/repos/dat-land/dat-desktop","forks_url":"https://api.github.com/repos/dat-land/dat-desktop/forks","keys_url":"https://api.github.com/repos/dat-land/dat-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dat-land/dat-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dat-land/dat-desktop/teams","hooks_url":"https://api.github.com/repos/dat-land/dat-desktop/hooks","issue_events_url":"https://api.github.com/repos/dat-land/dat-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/dat-land/dat-desktop/events","assignees_url":"https://api.github.com/repos/dat-land/dat-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/dat-land/dat-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/dat-land/dat-desktop/tags","blobs_url":"https://api.github.com/repos/dat-land/dat-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dat-land/dat-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dat-land/dat-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/dat-land/dat-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dat-land/dat-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/dat-land/dat-desktop/languages","stargazers_url":"https://api.github.com/repos/dat-land/dat-desktop/stargazers","contributors_url":"https://api.github.com/repos/dat-land/dat-desktop/contributors","subscribers_url":"https://api.github.com/repos/dat-land/dat-desktop/subscribers","subscription_url":"https://api.github.com/repos/dat-land/dat-desktop/subscription","commits_url":"https://api.github.com/repos/dat-land/dat-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/dat-land/dat-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/dat-land/dat-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/dat-land/dat-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/dat-land/dat-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/dat-land/dat-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dat-land/dat-desktop/merges","archive_url":"https://api.github.com/repos/dat-land/dat-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dat-land/dat-desktop/downloads","issues_url":"https://api.github.com/repos/dat-land/dat-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/dat-land/dat-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/dat-land/dat-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/dat-land/dat-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dat-land/dat-desktop/labels{/name}","releases_url":"https://api.github.com/repos/dat-land/dat-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/dat-land/dat-desktop/deployments","created_at":"2016-05-25T21:42:53Z","updated_at":"2018-09-25T04:44:29Z","pushed_at":"2018-10-01T21:53:36Z","git_url":"git://github.com/dat-land/dat-desktop.git","ssh_url":"git@github.com:dat-land/dat-desktop.git","clone_url":"https://github.com/dat-land/dat-desktop.git","svn_url":"https://github.com/dat-land/dat-desktop","homepage":"http://datproject.org","size":2675,"stargazers_count":420,"watchers_count":420,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":60,"open_issues":65,"watchers":420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dat-land/dat-desktop/pulls/551"},"html":{"href":"https://github.com/dat-land/dat-desktop/pull/551"},"issue":{"href":"https://api.github.com/repos/dat-land/dat-desktop/issues/551"},"comments":{"href":"https://api.github.com/repos/dat-land/dat-desktop/issues/551/comments"},"review_comments":{"href":"https://api.github.com/repos/dat-land/dat-desktop/pulls/551/comments"},"review_comment":{"href":"https://api.github.com/repos/dat-land/dat-desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dat-land/dat-desktop/pulls/551/commits"},"statuses":{"href":"https://api.github.com/repos/dat-land/dat-desktop/statuses/b2dc8041245571193882c280d060f218db8c5efb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"martinheidegger"}}