{"action":"created","comment":{"url":"https://api.github.com/repos/centrifuge/precise-proofs/pulls/comments/213117380","pull_request_review_id":149886014,"id":213117380,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzExNzM4MA==","diff_hunk":"@@ -52,16 +52,17 @@ import (\n \t\"github.com/iancoleman/strcase\"\n )\n \n+// DefaultSaltsLengthSuffix is the suffix used to store the length of slices (repeated) fields in the tree. It can be\n+// customized with the SaltsLenghtSuffix TreeOption\n const DefaultSaltsLengthSuffix = \"Length\"\n \n-/*\n-Allows to pass certain options to the tree generation logic. Currently support:\n-\t1. EnableHashSorting: Implement a merkle tree with sorted hashes\n-\t2. SaltsLengthSuffix: As precise proofs support repeated fields, when generating the merkle tree we need to add a leaf that represents the length of the slice.\n-\tThe default suffix is `Length`, although it is customizable so it does not collide with potential field names of your own proto structs.\n-*/\n+// TreeOptions allows customizing the generation of the tree\n type TreeOptions struct {\n+\t//\tEnableHashSorting: Implement a merkle tree with sorted hashes","path":"proofs/tree.go","position":16,"original_position":16,"commit_id":"842d532db2a73820aae685617795ac285fbaa521","original_commit_id":"842d532db2a73820aae685617795ac285fbaa521","user":{"login":"vimukthi-git","id":654927,"node_id":"MDQ6VXNlcjY1NDkyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/654927?v=4","gravatar_id":"","url":"https://api.github.com/users/vimukthi-git","html_url":"https://github.com/vimukthi-git","followers_url":"https://api.github.com/users/vimukthi-git/followers","following_url":"https://api.github.com/users/vimukthi-git/following{/other_user}","gists_url":"https://api.github.com/users/vimukthi-git/gists{/gist_id}","starred_url":"https://api.github.com/users/vimukthi-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimukthi-git/subscriptions","organizations_url":"https://api.github.com/users/vimukthi-git/orgs","repos_url":"https://api.github.com/users/vimukthi-git/repos","events_url":"https://api.github.com/users/vimukthi-git/events{/privacy}","received_events_url":"https://api.github.com/users/vimukthi-git/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2018-08-27T21:12:52Z","updated_at":"2018-08-27T21:13:27Z","html_url":"https://github.com/centrifuge/precise-proofs/pull/19#discussion_r213117380","pull_request_url":"https://api.github.com/repos/centrifuge/precise-proofs/pulls/19","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/centrifuge/precise-proofs/pulls/comments/213117380"},"html":{"href":"https://github.com/centrifuge/precise-proofs/pull/19#discussion_r213117380"},"pull_request":{"href":"https://api.github.com/repos/centrifuge/precise-proofs/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/centrifuge/precise-proofs/pulls/19","id":211202764,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjAyNzY0","html_url":"https://github.com/centrifuge/precise-proofs/pull/19","diff_url":"https://github.com/centrifuge/precise-proofs/pull/19.diff","patch_url":"https://github.com/centrifuge/precise-proofs/pull/19.patch","issue_url":"https://api.github.com/repos/centrifuge/precise-proofs/issues/19","number":19,"state":"open","locked":false,"title":"Refactor salts into separate file. Better docstrings.","user":{"login":"lucasvo","id":31727,"node_id":"MDQ6VXNlcjMxNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/31727?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasvo","html_url":"https://github.com/lucasvo","followers_url":"https://api.github.com/users/lucasvo/followers","following_url":"https://api.github.com/users/lucasvo/following{/other_user}","gists_url":"https://api.github.com/users/lucasvo/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasvo/subscriptions","organizations_url":"https://api.github.com/users/lucasvo/orgs","repos_url":"https://api.github.com/users/lucasvo/repos","events_url":"https://api.github.com/users/lucasvo/events{/privacy}","received_events_url":"https://api.github.com/users/lucasvo/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-27T19:12:50Z","updated_at":"2018-08-27T21:13:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85bd30818cf54ce169425a2d30d5fbe50d166b95","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/centrifuge/precise-proofs/pulls/19/commits","review_comments_url":"https://api.github.com/repos/centrifuge/precise-proofs/pulls/19/comments","review_comment_url":"https://api.github.com/repos/centrifuge/precise-proofs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/centrifuge/precise-proofs/issues/19/comments","statuses_url":"https://api.github.com/repos/centrifuge/precise-proofs/statuses/842d532db2a73820aae685617795ac285fbaa521","head":{"label":"lucasvo:cleanup","ref":"cleanup","sha":"842d532db2a73820aae685617795ac285fbaa521","user":{"login":"lucasvo","id":31727,"node_id":"MDQ6VXNlcjMxNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/31727?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasvo","html_url":"https://github.com/lucasvo","followers_url":"https://api.github.com/users/lucasvo/followers","following_url":"https://api.github.com/users/lucasvo/following{/other_user}","gists_url":"https://api.github.com/users/lucasvo/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasvo/subscriptions","organizations_url":"https://api.github.com/users/lucasvo/orgs","repos_url":"https://api.github.com/users/lucasvo/repos","events_url":"https://api.github.com/users/lucasvo/events{/privacy}","received_events_url":"https://api.github.com/users/lucasvo/received_events","type":"User","site_admin":false},"repo":{"id":128861663,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4NjE2NjM=","name":"precise-proofs","full_name":"lucasvo/precise-proofs","owner":{"login":"lucasvo","id":31727,"node_id":"MDQ6VXNlcjMxNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/31727?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasvo","html_url":"https://github.com/lucasvo","followers_url":"https://api.github.com/users/lucasvo/followers","following_url":"https://api.github.com/users/lucasvo/following{/other_user}","gists_url":"https://api.github.com/users/lucasvo/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasvo/subscriptions","organizations_url":"https://api.github.com/users/lucasvo/orgs","repos_url":"https://api.github.com/users/lucasvo/repos","events_url":"https://api.github.com/users/lucasvo/events{/privacy}","received_events_url":"https://api.github.com/users/lucasvo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucasvo/precise-proofs","description":null,"fork":true,"url":"https://api.github.com/repos/lucasvo/precise-proofs","forks_url":"https://api.github.com/repos/lucasvo/precise-proofs/forks","keys_url":"https://api.github.com/repos/lucasvo/precise-proofs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucasvo/precise-proofs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucasvo/precise-proofs/teams","hooks_url":"https://api.github.com/repos/lucasvo/precise-proofs/hooks","issue_events_url":"https://api.github.com/repos/lucasvo/precise-proofs/issues/events{/number}","events_url":"https://api.github.com/repos/lucasvo/precise-proofs/events","assignees_url":"https://api.github.com/repos/lucasvo/precise-proofs/assignees{/user}","branches_url":"https://api.github.com/repos/lucasvo/precise-proofs/branches{/branch}","tags_url":"https://api.github.com/repos/lucasvo/precise-proofs/tags","blobs_url":"https://api.github.com/repos/lucasvo/precise-proofs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucasvo/precise-proofs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucasvo/precise-proofs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucasvo/precise-proofs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucasvo/precise-proofs/statuses/{sha}","languages_url":"https://api.github.com/repos/lucasvo/precise-proofs/languages","stargazers_url":"https://api.github.com/repos/lucasvo/precise-proofs/stargazers","contributors_url":"https://api.github.com/repos/lucasvo/precise-proofs/contributors","subscribers_url":"https://api.github.com/repos/lucasvo/precise-proofs/subscribers","subscription_url":"https://api.github.com/repos/lucasvo/precise-proofs/subscription","commits_url":"https://api.github.com/repos/lucasvo/precise-proofs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucasvo/precise-proofs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucasvo/precise-proofs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucasvo/precise-proofs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucasvo/precise-proofs/contents/{+path}","compare_url":"https://api.github.com/repos/lucasvo/precise-proofs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucasvo/precise-proofs/merges","archive_url":"https://api.github.com/repos/lucasvo/precise-proofs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucasvo/precise-proofs/downloads","issues_url":"https://api.github.com/repos/lucasvo/precise-proofs/issues{/number}","pulls_url":"https://api.github.com/repos/lucasvo/precise-proofs/pulls{/number}","milestones_url":"https://api.github.com/repos/lucasvo/precise-proofs/milestones{/number}","notifications_url":"https://api.github.com/repos/lucasvo/precise-proofs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucasvo/precise-proofs/labels{/name}","releases_url":"https://api.github.com/repos/lucasvo/precise-proofs/releases{/id}","deployments_url":"https://api.github.com/repos/lucasvo/precise-proofs/deployments","created_at":"2018-04-10T02:27:41Z","updated_at":"2018-04-10T02:27:43Z","pushed_at":"2018-08-27T20:03:27Z","git_url":"git://github.com/lucasvo/precise-proofs.git","ssh_url":"git@github.com:lucasvo/precise-proofs.git","clone_url":"https://github.com/lucasvo/precise-proofs.git","svn_url":"https://github.com/lucasvo/precise-proofs","homepage":null,"size":267,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"centrifuge:master","ref":"master","sha":"c863a9834afafe170b4b5c8c10ab1c6cf0f002d8","user":{"login":"centrifuge","id":37558527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTU4NTI3","avatar_url":"https://avatars1.githubusercontent.com/u/37558527?v=4","gravatar_id":"","url":"https://api.github.com/users/centrifuge","html_url":"https://github.com/centrifuge","followers_url":"https://api.github.com/users/centrifuge/followers","following_url":"https://api.github.com/users/centrifuge/following{/other_user}","gists_url":"https://api.github.com/users/centrifuge/gists{/gist_id}","starred_url":"https://api.github.com/users/centrifuge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/centrifuge/subscriptions","organizations_url":"https://api.github.com/users/centrifuge/orgs","repos_url":"https://api.github.com/users/centrifuge/repos","events_url":"https://api.github.com/users/centrifuge/events{/privacy}","received_events_url":"https://api.github.com/users/centrifuge/received_events","type":"Organization","site_admin":false},"repo":{"id":127054951,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwNTQ5NTE=","name":"precise-proofs","full_name":"centrifuge/precise-proofs","owner":{"login":"centrifuge","id":37558527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTU4NTI3","avatar_url":"https://avatars1.githubusercontent.com/u/37558527?v=4","gravatar_id":"","url":"https://api.github.com/users/centrifuge","html_url":"https://github.com/centrifuge","followers_url":"https://api.github.com/users/centrifuge/followers","following_url":"https://api.github.com/users/centrifuge/following{/other_user}","gists_url":"https://api.github.com/users/centrifuge/gists{/gist_id}","starred_url":"https://api.github.com/users/centrifuge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/centrifuge/subscriptions","organizations_url":"https://api.github.com/users/centrifuge/orgs","repos_url":"https://api.github.com/users/centrifuge/repos","events_url":"https://api.github.com/users/centrifuge/events{/privacy}","received_events_url":"https://api.github.com/users/centrifuge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/centrifuge/precise-proofs","description":"A library to generate merkle proofs for complex data structures","fork":false,"url":"https://api.github.com/repos/centrifuge/precise-proofs","forks_url":"https://api.github.com/repos/centrifuge/precise-proofs/forks","keys_url":"https://api.github.com/repos/centrifuge/precise-proofs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/centrifuge/precise-proofs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/centrifuge/precise-proofs/teams","hooks_url":"https://api.github.com/repos/centrifuge/precise-proofs/hooks","issue_events_url":"https://api.github.com/repos/centrifuge/precise-proofs/issues/events{/number}","events_url":"https://api.github.com/repos/centrifuge/precise-proofs/events","assignees_url":"https://api.github.com/repos/centrifuge/precise-proofs/assignees{/user}","branches_url":"https://api.github.com/repos/centrifuge/precise-proofs/branches{/branch}","tags_url":"https://api.github.com/repos/centrifuge/precise-proofs/tags","blobs_url":"https://api.github.com/repos/centrifuge/precise-proofs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/centrifuge/precise-proofs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/centrifuge/precise-proofs/git/refs{/sha}","trees_url":"https://api.github.com/repos/centrifuge/precise-proofs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/centrifuge/precise-proofs/statuses/{sha}","languages_url":"https://api.github.com/repos/centrifuge/precise-proofs/languages","stargazers_url":"https://api.github.com/repos/centrifuge/precise-proofs/stargazers","contributors_url":"https://api.github.com/repos/centrifuge/precise-proofs/contributors","subscribers_url":"https://api.github.com/repos/centrifuge/precise-proofs/subscribers","subscription_url":"https://api.github.com/repos/centrifuge/precise-proofs/subscription","commits_url":"https://api.github.com/repos/centrifuge/precise-proofs/commits{/sha}","git_commits_url":"https://api.github.com/repos/centrifuge/precise-proofs/git/commits{/sha}","comments_url":"https://api.github.com/repos/centrifuge/precise-proofs/comments{/number}","issue_comment_url":"https://api.github.com/repos/centrifuge/precise-proofs/issues/comments{/number}","contents_url":"https://api.github.com/repos/centrifuge/precise-proofs/contents/{+path}","compare_url":"https://api.github.com/repos/centrifuge/precise-proofs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/centrifuge/precise-proofs/merges","archive_url":"https://api.github.com/repos/centrifuge/precise-proofs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/centrifuge/precise-proofs/downloads","issues_url":"https://api.github.com/repos/centrifuge/precise-proofs/issues{/number}","pulls_url":"https://api.github.com/repos/centrifuge/precise-proofs/pulls{/number}","milestones_url":"https://api.github.com/repos/centrifuge/precise-proofs/milestones{/number}","notifications_url":"https://api.github.com/repos/centrifuge/precise-proofs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/centrifuge/precise-proofs/labels{/name}","releases_url":"https://api.github.com/repos/centrifuge/precise-proofs/releases{/id}","deployments_url":"https://api.github.com/repos/centrifuge/precise-proofs/deployments","created_at":"2018-03-27T22:54:22Z","updated_at":"2018-08-23T14:21:38Z","pushed_at":"2018-08-27T19:12:51Z","git_url":"git://github.com/centrifuge/precise-proofs.git","ssh_url":"git@github.com:centrifuge/precise-proofs.git","clone_url":"https://github.com/centrifuge/precise-proofs.git","svn_url":"https://github.com/centrifuge/precise-proofs","homepage":"","size":232,"stargazers_count":9,"watchers_count":9,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/centrifuge/precise-proofs/pulls/19"},"html":{"href":"https://github.com/centrifuge/precise-proofs/pull/19"},"issue":{"href":"https://api.github.com/repos/centrifuge/precise-proofs/issues/19"},"comments":{"href":"https://api.github.com/repos/centrifuge/precise-proofs/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/centrifuge/precise-proofs/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/centrifuge/precise-proofs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/centrifuge/precise-proofs/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/centrifuge/precise-proofs/statuses/842d532db2a73820aae685617795ac285fbaa521"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vimukthi-git"}}