{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/192468657","pull_request_review_id":125259055,"id":192468657,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjQ2ODY1Nw==","diff_hunk":"@@ -54,7 +54,7 @@\n     \"test:ui:runner\": \"echo 'use `node scripts/functional_test_runner`' && false\",\n     \"test:server\": \"grunt test:server\",\n     \"test:coverage\": \"grunt test:coverage\",\n-    \"checkLicenses\": \"grunt licenses\",\n+    \"checkLicenses\": \"grunt licenses --dev\",","path":"package.json","position":5,"original_position":5,"commit_id":"482b0928754c92573567de2bb3f470ea0c2809ff","original_commit_id":"482b0928754c92573567de2bb3f470ea0c2809ff","user":{"login":"tylersmalley","id":40265,"node_id":"MDQ6VXNlcjQwMjY1","avatar_url":"https://avatars2.githubusercontent.com/u/40265?v=4","gravatar_id":"","url":"https://api.github.com/users/tylersmalley","html_url":"https://github.com/tylersmalley","followers_url":"https://api.github.com/users/tylersmalley/followers","following_url":"https://api.github.com/users/tylersmalley/following{/other_user}","gists_url":"https://api.github.com/users/tylersmalley/gists{/gist_id}","starred_url":"https://api.github.com/users/tylersmalley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylersmalley/subscriptions","organizations_url":"https://api.github.com/users/tylersmalley/orgs","repos_url":"https://api.github.com/users/tylersmalley/repos","events_url":"https://api.github.com/users/tylersmalley/events{/privacy}","received_events_url":"https://api.github.com/users/tylersmalley/received_events","type":"User","site_admin":false},"body":"I believe we still want development licenses to be included by default in the license check per https://github.com/elastic/kibana/issues/19502\r\n\r\n> While we do want to do license checking in Kibana for all dependencies, the release license report should only include dependencies that actually ship with Kibana.","created_at":"2018-06-01T17:48:49Z","updated_at":"2018-06-01T17:48:49Z","html_url":"https://github.com/elastic/kibana/pull/19626#discussion_r192468657","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/19626","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/192468657"},"html":{"href":"https://github.com/elastic/kibana/pull/19626#discussion_r192468657"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19626"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/19626","id":192087416,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDg3NDE2","html_url":"https://github.com/elastic/kibana/pull/19626","diff_url":"https://github.com/elastic/kibana/pull/19626.diff","patch_url":"https://github.com/elastic/kibana/pull/19626.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/19626","number":19626,"state":"open","locked":false,"title":"Dependencies license report should not include devDependencies","user":{"login":"mistic","id":4440734,"node_id":"MDQ6VXNlcjQ0NDA3MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4440734?v=4","gravatar_id":"","url":"https://api.github.com/users/mistic","html_url":"https://github.com/mistic","followers_url":"https://api.github.com/users/mistic/followers","following_url":"https://api.github.com/users/mistic/following{/other_user}","gists_url":"https://api.github.com/users/mistic/gists{/gist_id}","starred_url":"https://api.github.com/users/mistic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistic/subscriptions","organizations_url":"https://api.github.com/users/mistic/orgs","repos_url":"https://api.github.com/users/mistic/repos","events_url":"https://api.github.com/users/mistic/events{/privacy}","received_events_url":"https://api.github.com/users/mistic/received_events","type":"User","site_admin":false},"body":"This pull request ends the discussion opened in #19502 .\r\n\r\nBy default either `licenses` or `licenses:csv_report` task will exclude `devDependencies` from the checks. However a `--dev` could be provided to include those dependencies in the task scope.","created_at":"2018-06-01T16:45:29Z","updated_at":"2018-06-01T17:48:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fda45dd8d2eceb280f0a3423289f4acffcd80ae5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"epixa","id":53814,"node_id":"MDQ6VXNlcjUzODE0","avatar_url":"https://avatars0.githubusercontent.com/u/53814?v=4","gravatar_id":"","url":"https://api.github.com/users/epixa","html_url":"https://github.com/epixa","followers_url":"https://api.github.com/users/epixa/followers","following_url":"https://api.github.com/users/epixa/following{/other_user}","gists_url":"https://api.github.com/users/epixa/gists{/gist_id}","starred_url":"https://api.github.com/users/epixa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epixa/subscriptions","organizations_url":"https://api.github.com/users/epixa/orgs","repos_url":"https://api.github.com/users/epixa/repos","events_url":"https://api.github.com/users/epixa/events{/privacy}","received_events_url":"https://api.github.com/users/epixa/received_events","type":"User","site_admin":false},{"login":"jbudz","id":3143860,"node_id":"MDQ6VXNlcjMxNDM4NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/3143860?v=4","gravatar_id":"","url":"https://api.github.com/users/jbudz","html_url":"https://github.com/jbudz","followers_url":"https://api.github.com/users/jbudz/followers","following_url":"https://api.github.com/users/jbudz/following{/other_user}","gists_url":"https://api.github.com/users/jbudz/gists{/gist_id}","starred_url":"https://api.github.com/users/jbudz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbudz/subscriptions","organizations_url":"https://api.github.com/users/jbudz/orgs","repos_url":"https://api.github.com/users/jbudz/repos","events_url":"https://api.github.com/users/jbudz/events{/privacy}","received_events_url":"https://api.github.com/users/jbudz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":470241342,"node_id":"MDU6TGFiZWw0NzAyNDEzNDI=","url":"https://api.github.com/repos/elastic/kibana/labels/:Operations","name":":Operations","color":"fef2c0","default":false},{"id":135307740,"node_id":"MDU6TGFiZWwxMzUzMDc3NDA=","url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false},{"id":883958396,"node_id":"MDU6TGFiZWw4ODM5NTgzOTY=","url":"https://api.github.com/repos/elastic/kibana/labels/v6.4.0","name":"v6.4.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/19626/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/19626/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/19626/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/482b0928754c92573567de2bb3f470ea0c2809ff","head":{"label":"mistic:kibana-19502","ref":"kibana-19502","sha":"482b0928754c92573567de2bb3f470ea0c2809ff","user":{"login":"mistic","id":4440734,"node_id":"MDQ6VXNlcjQ0NDA3MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4440734?v=4","gravatar_id":"","url":"https://api.github.com/users/mistic","html_url":"https://github.com/mistic","followers_url":"https://api.github.com/users/mistic/followers","following_url":"https://api.github.com/users/mistic/following{/other_user}","gists_url":"https://api.github.com/users/mistic/gists{/gist_id}","starred_url":"https://api.github.com/users/mistic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistic/subscriptions","organizations_url":"https://api.github.com/users/mistic/orgs","repos_url":"https://api.github.com/users/mistic/repos","events_url":"https://api.github.com/users/mistic/events{/privacy}","received_events_url":"https://api.github.com/users/mistic/received_events","type":"User","site_admin":false},"repo":{"id":133453229,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NTMyMjk=","name":"kibana","full_name":"mistic/kibana","owner":{"login":"mistic","id":4440734,"node_id":"MDQ6VXNlcjQ0NDA3MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4440734?v=4","gravatar_id":"","url":"https://api.github.com/users/mistic","html_url":"https://github.com/mistic","followers_url":"https://api.github.com/users/mistic/followers","following_url":"https://api.github.com/users/mistic/following{/other_user}","gists_url":"https://api.github.com/users/mistic/gists{/gist_id}","starred_url":"https://api.github.com/users/mistic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistic/subscriptions","organizations_url":"https://api.github.com/users/mistic/orgs","repos_url":"https://api.github.com/users/mistic/repos","events_url":"https://api.github.com/users/mistic/events{/privacy}","received_events_url":"https://api.github.com/users/mistic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mistic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/mistic/kibana","forks_url":"https://api.github.com/repos/mistic/kibana/forks","keys_url":"https://api.github.com/repos/mistic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mistic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mistic/kibana/teams","hooks_url":"https://api.github.com/repos/mistic/kibana/hooks","issue_events_url":"https://api.github.com/repos/mistic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/mistic/kibana/events","assignees_url":"https://api.github.com/repos/mistic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/mistic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/mistic/kibana/tags","blobs_url":"https://api.github.com/repos/mistic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mistic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mistic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/mistic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mistic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/mistic/kibana/languages","stargazers_url":"https://api.github.com/repos/mistic/kibana/stargazers","contributors_url":"https://api.github.com/repos/mistic/kibana/contributors","subscribers_url":"https://api.github.com/repos/mistic/kibana/subscribers","subscription_url":"https://api.github.com/repos/mistic/kibana/subscription","commits_url":"https://api.github.com/repos/mistic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/mistic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/mistic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/mistic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/mistic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/mistic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mistic/kibana/merges","archive_url":"https://api.github.com/repos/mistic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mistic/kibana/downloads","issues_url":"https://api.github.com/repos/mistic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/mistic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/mistic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/mistic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mistic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/mistic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/mistic/kibana/deployments","created_at":"2018-05-15T03:20:14Z","updated_at":"2018-06-01T15:43:33Z","pushed_at":"2018-06-01T16:39:33Z","git_url":"git://github.com/mistic/kibana.git","ssh_url":"git@github.com:mistic/kibana.git","clone_url":"https://github.com/mistic/kibana.git","svn_url":"https://github.com/mistic/kibana","homepage":"https://www.elastic.co/products/kibana","size":413363,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"7440e9734d69f15d18012e0dd84fc05d4184b369","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-06-01T17:12:54Z","pushed_at":"2018-06-01T17:14:42Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":413630,"stargazers_count":9437,"watchers_count":9437,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3664,"mirror_url":null,"archived":false,"open_issues_count":3127,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3664,"open_issues":3127,"watchers":9437,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19626"},"html":{"href":"https://github.com/elastic/kibana/pull/19626"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/19626"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/19626/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19626/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19626/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/482b0928754c92573567de2bb3f470ea0c2809ff"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tylersmalley"}}