{"action":"created","comment":{"url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls/comments/240264506","pull_request_review_id":183253911,"id":240264506,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDI2NDUwNg==","diff_hunk":"@@ -105,11 +106,68 @@ dispatch.on(\"load_choice\", function (load_data, sos_graph_data, question_info) {\n             let current_fol = d3.select(\"#sel_fol\").property(\"value\");\n             let current_reg = d3.select(\"#sel_reg\").property(\"value\");\n \n+\n             let new_TBL_data = _.filter(load_data, function (row) {\n                 return _.contains(current_depts, row.DEPT) && _.contains([current_question], row.Question) && _.contains([current_fol], row.FOL) && _.contains([current_reg], row.Region);\n             });\n \n-             let new_graph_data_1 = _.groupBy(_.filter(sos_graph_data[current_fol][current_reg][current_question], function (answer) {\n+\n+\n+            if(new_TBL_data.length == 0) {\n+                d3.select(\"#no_response\")\n+                  .style(\"display\",\"block\");\n+                d3.select(\"#table_div\")\n+                  .style(\"display\",\"none\");\n+                d3.select(\"#no_response_msg\")\n+                  .text(\"There is no survey data matching the selected filters.\");\n+            } else {\n+                d3.select(\"#table_div\")\n+                  .style(\"display\",\"block\");\n+\n+                if (current_depts.length > 1){\n+                \n+                    let available_depts = [];\n+\n+                    for (i = 0; i < new_TBL_data.length ; i++) {\n+                        if (!_.contains(available_depts, new_TBL_data[i].DEPT)) {\n+                            available_depts.push(new_TBL_data[i].DEPT);\n+                        }\n+                    }\n+                    let nodata_depts = _.difference(current_depts, available_depts);","path":"javascript/load_choice.js","position":40,"original_position":40,"commit_id":"04263a21cef765cdf421ba1a8d71a6b4e0f216a1","original_commit_id":"04263a21cef765cdf421ba1a8d71a6b4e0f216a1","user":{"login":"dominicdemers","id":32339881,"node_id":"MDQ6VXNlcjMyMzM5ODgx","avatar_url":"https://avatars2.githubusercontent.com/u/32339881?v=4","gravatar_id":"","url":"https://api.github.com/users/dominicdemers","html_url":"https://github.com/dominicdemers","followers_url":"https://api.github.com/users/dominicdemers/followers","following_url":"https://api.github.com/users/dominicdemers/following{/other_user}","gists_url":"https://api.github.com/users/dominicdemers/gists{/gist_id}","starred_url":"https://api.github.com/users/dominicdemers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominicdemers/subscriptions","organizations_url":"https://api.github.com/users/dominicdemers/orgs","repos_url":"https://api.github.com/users/dominicdemers/repos","events_url":"https://api.github.com/users/dominicdemers/events{/privacy}","received_events_url":"https://api.github.com/users/dominicdemers/received_events","type":"User","site_admin":false},"body":"good idea to use the diff function!","created_at":"2018-12-10T15:48:48Z","updated_at":"2018-12-10T15:48:49Z","html_url":"https://github.com/dominicdemers/multi_series_bar_chart/pull/3#discussion_r240264506","pull_request_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls/3","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls/comments/240264506"},"html":{"href":"https://github.com/dominicdemers/multi_series_bar_chart/pull/3#discussion_r240264506"},"pull_request":{"href":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls/3","id":236982498,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTgyNDk4","html_url":"https://github.com/dominicdemers/multi_series_bar_chart/pull/3","diff_url":"https://github.com/dominicdemers/multi_series_bar_chart/pull/3.diff","patch_url":"https://github.com/dominicdemers/multi_series_bar_chart/pull/3.patch","issue_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/issues/3","number":3,"state":"open","locked":false,"title":"added no data alert for multiple selections of Organisations","user":{"login":"HoussamBedja","id":12534205,"node_id":"MDQ6VXNlcjEyNTM0MjA1","avatar_url":"https://avatars0.githubusercontent.com/u/12534205?v=4","gravatar_id":"","url":"https://api.github.com/users/HoussamBedja","html_url":"https://github.com/HoussamBedja","followers_url":"https://api.github.com/users/HoussamBedja/followers","following_url":"https://api.github.com/users/HoussamBedja/following{/other_user}","gists_url":"https://api.github.com/users/HoussamBedja/gists{/gist_id}","starred_url":"https://api.github.com/users/HoussamBedja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HoussamBedja/subscriptions","organizations_url":"https://api.github.com/users/HoussamBedja/orgs","repos_url":"https://api.github.com/users/HoussamBedja/repos","events_url":"https://api.github.com/users/HoussamBedja/events{/privacy}","received_events_url":"https://api.github.com/users/HoussamBedja/received_events","type":"User","site_admin":false},"body":"To see the changes:\r\n- Select one combination that has 0 data returned.\r\n- Select multiple organizations, including some that have no data (for example, pick All organizations, medium, small and very small).","created_at":"2018-12-07T20:17:59Z","updated_at":"2018-12-10T15:48:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d105a230f6e75a0e0d9d1c486f2e04dca3f1206","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls/3/commits","review_comments_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls/3/comments","review_comment_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/issues/3/comments","statuses_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/statuses/04263a21cef765cdf421ba1a8d71a6b4e0f216a1","head":{"label":"HoussamBedja:master","ref":"master","sha":"04263a21cef765cdf421ba1a8d71a6b4e0f216a1","user":{"login":"HoussamBedja","id":12534205,"node_id":"MDQ6VXNlcjEyNTM0MjA1","avatar_url":"https://avatars0.githubusercontent.com/u/12534205?v=4","gravatar_id":"","url":"https://api.github.com/users/HoussamBedja","html_url":"https://github.com/HoussamBedja","followers_url":"https://api.github.com/users/HoussamBedja/followers","following_url":"https://api.github.com/users/HoussamBedja/following{/other_user}","gists_url":"https://api.github.com/users/HoussamBedja/gists{/gist_id}","starred_url":"https://api.github.com/users/HoussamBedja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HoussamBedja/subscriptions","organizations_url":"https://api.github.com/users/HoussamBedja/orgs","repos_url":"https://api.github.com/users/HoussamBedja/repos","events_url":"https://api.github.com/users/HoussamBedja/events{/privacy}","received_events_url":"https://api.github.com/users/HoussamBedja/received_events","type":"User","site_admin":false},"repo":{"id":160216141,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAyMTYxNDE=","name":"multi_series_bar_chart","full_name":"HoussamBedja/multi_series_bar_chart","private":false,"owner":{"login":"HoussamBedja","id":12534205,"node_id":"MDQ6VXNlcjEyNTM0MjA1","avatar_url":"https://avatars0.githubusercontent.com/u/12534205?v=4","gravatar_id":"","url":"https://api.github.com/users/HoussamBedja","html_url":"https://github.com/HoussamBedja","followers_url":"https://api.github.com/users/HoussamBedja/followers","following_url":"https://api.github.com/users/HoussamBedja/following{/other_user}","gists_url":"https://api.github.com/users/HoussamBedja/gists{/gist_id}","starred_url":"https://api.github.com/users/HoussamBedja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HoussamBedja/subscriptions","organizations_url":"https://api.github.com/users/HoussamBedja/orgs","repos_url":"https://api.github.com/users/HoussamBedja/repos","events_url":"https://api.github.com/users/HoussamBedja/events{/privacy}","received_events_url":"https://api.github.com/users/HoussamBedja/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HoussamBedja/multi_series_bar_chart","description":null,"fork":true,"url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart","forks_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/forks","keys_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/teams","hooks_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/hooks","issue_events_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/issues/events{/number}","events_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/events","assignees_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/assignees{/user}","branches_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/branches{/branch}","tags_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/tags","blobs_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/statuses/{sha}","languages_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/languages","stargazers_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/stargazers","contributors_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/contributors","subscribers_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/subscribers","subscription_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/subscription","commits_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/contents/{+path}","compare_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/merges","archive_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/downloads","issues_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/issues{/number}","pulls_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/pulls{/number}","milestones_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/milestones{/number}","notifications_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/labels{/name}","releases_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/releases{/id}","deployments_url":"https://api.github.com/repos/HoussamBedja/multi_series_bar_chart/deployments","created_at":"2018-12-03T15:53:10Z","updated_at":"2018-12-10T15:36:34Z","pushed_at":"2018-12-10T15:36:32Z","git_url":"git://github.com/HoussamBedja/multi_series_bar_chart.git","ssh_url":"git@github.com:HoussamBedja/multi_series_bar_chart.git","clone_url":"https://github.com/HoussamBedja/multi_series_bar_chart.git","svn_url":"https://github.com/HoussamBedja/multi_series_bar_chart","homepage":null,"size":10764,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dominicdemers:master","ref":"master","sha":"9a62d068566681072e565be8c93e8b9bf4be845a","user":{"login":"dominicdemers","id":32339881,"node_id":"MDQ6VXNlcjMyMzM5ODgx","avatar_url":"https://avatars2.githubusercontent.com/u/32339881?v=4","gravatar_id":"","url":"https://api.github.com/users/dominicdemers","html_url":"https://github.com/dominicdemers","followers_url":"https://api.github.com/users/dominicdemers/followers","following_url":"https://api.github.com/users/dominicdemers/following{/other_user}","gists_url":"https://api.github.com/users/dominicdemers/gists{/gist_id}","starred_url":"https://api.github.com/users/dominicdemers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominicdemers/subscriptions","organizations_url":"https://api.github.com/users/dominicdemers/orgs","repos_url":"https://api.github.com/users/dominicdemers/repos","events_url":"https://api.github.com/users/dominicdemers/events{/privacy}","received_events_url":"https://api.github.com/users/dominicdemers/received_events","type":"User","site_admin":false},"repo":{"id":147724966,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3MjQ5NjY=","name":"multi_series_bar_chart","full_name":"dominicdemers/multi_series_bar_chart","private":false,"owner":{"login":"dominicdemers","id":32339881,"node_id":"MDQ6VXNlcjMyMzM5ODgx","avatar_url":"https://avatars2.githubusercontent.com/u/32339881?v=4","gravatar_id":"","url":"https://api.github.com/users/dominicdemers","html_url":"https://github.com/dominicdemers","followers_url":"https://api.github.com/users/dominicdemers/followers","following_url":"https://api.github.com/users/dominicdemers/following{/other_user}","gists_url":"https://api.github.com/users/dominicdemers/gists{/gist_id}","starred_url":"https://api.github.com/users/dominicdemers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominicdemers/subscriptions","organizations_url":"https://api.github.com/users/dominicdemers/orgs","repos_url":"https://api.github.com/users/dominicdemers/repos","events_url":"https://api.github.com/users/dominicdemers/events{/privacy}","received_events_url":"https://api.github.com/users/dominicdemers/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dominicdemers/multi_series_bar_chart","description":null,"fork":false,"url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart","forks_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/forks","keys_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/teams","hooks_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/hooks","issue_events_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/issues/events{/number}","events_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/events","assignees_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/assignees{/user}","branches_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/branches{/branch}","tags_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/tags","blobs_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/statuses/{sha}","languages_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/languages","stargazers_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/stargazers","contributors_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/contributors","subscribers_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/subscribers","subscription_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/subscription","commits_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/contents/{+path}","compare_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/merges","archive_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/downloads","issues_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/issues{/number}","pulls_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls{/number}","milestones_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/milestones{/number}","notifications_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/labels{/name}","releases_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/releases{/id}","deployments_url":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/deployments","created_at":"2018-09-06T19:44:14Z","updated_at":"2018-12-07T20:17:32Z","pushed_at":"2018-12-10T15:36:33Z","git_url":"git://github.com/dominicdemers/multi_series_bar_chart.git","ssh_url":"git@github.com:dominicdemers/multi_series_bar_chart.git","clone_url":"https://github.com/dominicdemers/multi_series_bar_chart.git","svn_url":"https://github.com/dominicdemers/multi_series_bar_chart","homepage":null,"size":10755,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls/3"},"html":{"href":"https://github.com/dominicdemers/multi_series_bar_chart/pull/3"},"issue":{"href":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/issues/3"},"comments":{"href":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/dominicdemers/multi_series_bar_chart/statuses/04263a21cef765cdf421ba1a8d71a6b4e0f216a1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dominicdemers"}}