{"action":"opened","issue":{"url":"https://api.github.com/repos/projectatomic/buildah/issues/451","repository_url":"https://api.github.com/repos/projectatomic/buildah","labels_url":"https://api.github.com/repos/projectatomic/buildah/issues/451/labels{/name}","comments_url":"https://api.github.com/repos/projectatomic/buildah/issues/451/comments","events_url":"https://api.github.com/repos/projectatomic/buildah/issues/451/events","html_url":"https://github.com/projectatomic/buildah/issues/451","id":294578305,"number":451,"title":"Buildah bud ignores Dockerfile non-keywords by default ","user":{"login":"ipbabble","id":1304961,"avatar_url":"https://avatars0.githubusercontent.com/u/1304961?v=4","gravatar_id":"","url":"https://api.github.com/users/ipbabble","html_url":"https://github.com/ipbabble","followers_url":"https://api.github.com/users/ipbabble/followers","following_url":"https://api.github.com/users/ipbabble/following{/other_user}","gists_url":"https://api.github.com/users/ipbabble/gists{/gist_id}","starred_url":"https://api.github.com/users/ipbabble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipbabble/subscriptions","organizations_url":"https://api.github.com/users/ipbabble/orgs","repos_url":"https://api.github.com/users/ipbabble/repos","events_url":"https://api.github.com/users/ipbabble/events{/privacy}","received_events_url":"https://api.github.com/users/ipbabble/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-05T23:23:38Z","updated_at":"2018-02-05T23:23:38Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"\r\n**Description**\r\n\r\nA Dockerfile with lines containing syntax errors - lines starting with non-keywords - does not cause an error and halt the build. Instead it skips the offending line.\r\n\r\nAlso I think a simple change of setting ignoreUnrecognizedInstructions to false is not the fix. \r\n\r\ni.e. that would have the same effect as commenting out:\r\n//      if !b.ignoreUnrecognizedInstructions {\r\n//              logrus.Debugf(\"+(UNIMPLEMENTED?) %#v\", step)\r\n//              return nil\r\n//      }\r\n\r\nBut this means that the error output is too verbose because there is no check for log-level.  We probably need to have a if !debug type of check and just output a simple \"Buildah Error: unknown instructions: <non-keyword>\"\r\n\r\n\r\n**Steps to reproduce the issue:**\r\n1.  Create a Dockerfile that has commands that need to be run without the RUN keyword at the start. Or a file to be copied without the COPY keyword. \r\n2.  buildah bud .\r\n3.\r\n\r\n\r\n**Describe the results you received:**\r\nBuild finishes fast. No instructions are executed. All skipped.\r\nI received empty images because dnf commands were not getting run.\r\n\r\n**Describe the results you expected:**\r\nBuild error: Unknown instruction: DNF\r\n\r\n**Output of `rpm -q buildah` or `apt list buildah`:**\r\n\r\n```\r\nBuilt from HEAD\r\n```\r\n\r\n**Output of `buildah version`:**\r\n\r\n```\r\nbuildah version 0.8 (image-spec 1.0.0, runtime-spec 1.0.0)\r\n\r\n```\r\n\r\n**Output of `cat /etc/*release`:**\r\n\r\n```\r\nFedora release 27 (Twenty Seven)\r\n\r\n```\r\n\r\n**Output of `uname -a`:**\r\n\r\n```\r\nLinux localhost.localdomain 4.13.9-300.fc27.x86_64 #1 SMP Mon Oct 23 13:41:58 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux\r\n```\r\n\r\n**Output of `cat /etc/containers/storage.conf`:**\r\n\r\n```\r\n# storage.conf is the configuration file for all tools\r\n# that share the containers/storage libraries\r\n# See man 5 containers-storage.conf for more information\r\n\r\n# The \"container storage\" table contains all of the server options.\r\n[storage]\r\n\r\n# Default Storage Driver\r\ndriver = \"overlay\"\r\n\r\n# Temporary storage location\r\nrunroot = \"/var/run/containers/storage\"\r\n\r\n# Primary Read/Write location of container storage\r\ngraphroot = \"/var/lib/containers/storage\"\r\n\r\n[storage.options]\r\n# AdditionalImageStores is used to pass paths to additional Read/Only image stores\r\n# Must be comma separated list.\r\nadditionalimagestores = [\r\n]\r\n\r\n# Size is used to set a maximum size of the container image.  Only supported by\r\n# certain container storage drivers.\r\nsize = \"\"\r\n\r\n# OverrideKernelCheck tells the driver to ignore kernel checks based on kernel version\r\noverride_kernel_check = \"true\"\r\n```\r\n"}}
{"actor":{"display_login":"ipbabble"}}