{"action":"created","comment":{"url":"https://api.github.com/repos/karafka/karafka/pulls/comments/191067563","pull_request_review_id":123574875,"id":191067563,"diff_hunk":"@@ -22,19 +22,24 @@ def initialize(messages_batch, topic_parser)\n       # @note Invocation of this method will cause loading and parsing each param after another.\n       #   If you want to get access without parsing, please access params_batch directly\n       def each\n-        @params_batch.each { |param| yield(param.retrieve!) }\n+        @params_batch.each { |param| yield(param.parse!) }\n       end\n \n       # @return [Array<Karafka::Params::Params>] returns all the params in a loaded state, so they\n       #   can be used for batch insert, etc. Without invoking all, up until first use, they won't\n       #   be parsed\n-      def parsed\n+      def parse!","path":"lib/karafka/params/params_batch.rb","position":12,"original_position":12,"commit_id":"a6e56fff9ff3efc493dbd7aa5b0abef17b87e219","original_commit_id":"a6e56fff9ff3efc493dbd7aa5b0abef17b87e219","user":{"login":"mensfeld","id":392754,"avatar_url":"https://avatars3.githubusercontent.com/u/392754?v=4","gravatar_id":"","url":"https://api.github.com/users/mensfeld","html_url":"https://github.com/mensfeld","followers_url":"https://api.github.com/users/mensfeld/followers","following_url":"https://api.github.com/users/mensfeld/following{/other_user}","gists_url":"https://api.github.com/users/mensfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/mensfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mensfeld/subscriptions","organizations_url":"https://api.github.com/users/mensfeld/orgs","repos_url":"https://api.github.com/users/mensfeld/repos","events_url":"https://api.github.com/users/mensfeld/events{/privacy}","received_events_url":"https://api.github.com/users/mensfeld/received_events","type":"User","site_admin":false},"body":"It's a part of the official API described in the WIKI for params lazy loading and optional preparsing all the values without lazy loading.","created_at":"2018-05-27T07:33:01Z","updated_at":"2018-05-27T07:33:02Z","html_url":"https://github.com/karafka/karafka/pull/352#discussion_r191067563","pull_request_url":"https://api.github.com/repos/karafka/karafka/pulls/352","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/karafka/karafka/pulls/comments/191067563"},"html":{"href":"https://github.com/karafka/karafka/pull/352#discussion_r191067563"},"pull_request":{"href":"https://api.github.com/repos/karafka/karafka/pulls/352"}},"in_reply_to_id":191067404},"pull_request":{"url":"https://api.github.com/repos/karafka/karafka/pulls/352","id":190774215,"html_url":"https://github.com/karafka/karafka/pull/352","diff_url":"https://github.com/karafka/karafka/pull/352.diff","patch_url":"https://github.com/karafka/karafka/pull/352.patch","issue_url":"https://api.github.com/repos/karafka/karafka/issues/352","number":352,"state":"open","locked":false,"title":"Params and params batch naming cleanup","user":{"login":"mensfeld","id":392754,"avatar_url":"https://avatars3.githubusercontent.com/u/392754?v=4","gravatar_id":"","url":"https://api.github.com/users/mensfeld","html_url":"https://github.com/mensfeld","followers_url":"https://api.github.com/users/mensfeld/followers","following_url":"https://api.github.com/users/mensfeld/following{/other_user}","gists_url":"https://api.github.com/users/mensfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/mensfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mensfeld/subscriptions","organizations_url":"https://api.github.com/users/mensfeld/orgs","repos_url":"https://api.github.com/users/mensfeld/repos","events_url":"https://api.github.com/users/mensfeld/events{/privacy}","received_events_url":"https://api.github.com/users/mensfeld/received_events","type":"User","site_admin":false},"body":"closes #351 ","created_at":"2018-05-27T07:17:40Z","updated_at":"2018-05-27T07:33:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f40afc2ad056fb660dfc522b2060aed44849ddcf","assignee":{"login":"nijikon","id":150547,"avatar_url":"https://avatars3.githubusercontent.com/u/150547?v=4","gravatar_id":"","url":"https://api.github.com/users/nijikon","html_url":"https://github.com/nijikon","followers_url":"https://api.github.com/users/nijikon/followers","following_url":"https://api.github.com/users/nijikon/following{/other_user}","gists_url":"https://api.github.com/users/nijikon/gists{/gist_id}","starred_url":"https://api.github.com/users/nijikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nijikon/subscriptions","organizations_url":"https://api.github.com/users/nijikon/orgs","repos_url":"https://api.github.com/users/nijikon/repos","events_url":"https://api.github.com/users/nijikon/events{/privacy}","received_events_url":"https://api.github.com/users/nijikon/received_events","type":"User","site_admin":false},"assignees":[{"login":"nijikon","id":150547,"avatar_url":"https://avatars3.githubusercontent.com/u/150547?v=4","gravatar_id":"","url":"https://api.github.com/users/nijikon","html_url":"https://github.com/nijikon","followers_url":"https://api.github.com/users/nijikon/followers","following_url":"https://api.github.com/users/nijikon/following{/other_user}","gists_url":"https://api.github.com/users/nijikon/gists{/gist_id}","starred_url":"https://api.github.com/users/nijikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nijikon/subscriptions","organizations_url":"https://api.github.com/users/nijikon/orgs","repos_url":"https://api.github.com/users/nijikon/repos","events_url":"https://api.github.com/users/nijikon/events{/privacy}","received_events_url":"https://api.github.com/users/nijikon/received_events","type":"User","site_admin":false},{"login":"agwozdowski","id":10708382,"avatar_url":"https://avatars3.githubusercontent.com/u/10708382?v=4","gravatar_id":"","url":"https://api.github.com/users/agwozdowski","html_url":"https://github.com/agwozdowski","followers_url":"https://api.github.com/users/agwozdowski/followers","following_url":"https://api.github.com/users/agwozdowski/following{/other_user}","gists_url":"https://api.github.com/users/agwozdowski/gists{/gist_id}","starred_url":"https://api.github.com/users/agwozdowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agwozdowski/subscriptions","organizations_url":"https://api.github.com/users/agwozdowski/orgs","repos_url":"https://api.github.com/users/agwozdowski/repos","events_url":"https://api.github.com/users/agwozdowski/events{/privacy}","received_events_url":"https://api.github.com/users/agwozdowski/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"agwozdowski","id":10708382,"avatar_url":"https://avatars3.githubusercontent.com/u/10708382?v=4","gravatar_id":"","url":"https://api.github.com/users/agwozdowski","html_url":"https://github.com/agwozdowski","followers_url":"https://api.github.com/users/agwozdowski/followers","following_url":"https://api.github.com/users/agwozdowski/following{/other_user}","gists_url":"https://api.github.com/users/agwozdowski/gists{/gist_id}","starred_url":"https://api.github.com/users/agwozdowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agwozdowski/subscriptions","organizations_url":"https://api.github.com/users/agwozdowski/orgs","repos_url":"https://api.github.com/users/agwozdowski/repos","events_url":"https://api.github.com/users/agwozdowski/events{/privacy}","received_events_url":"https://api.github.com/users/agwozdowski/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/karafka/karafka/pulls/352/commits","review_comments_url":"https://api.github.com/repos/karafka/karafka/pulls/352/comments","review_comment_url":"https://api.github.com/repos/karafka/karafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/karafka/karafka/issues/352/comments","statuses_url":"https://api.github.com/repos/karafka/karafka/statuses/a6e56fff9ff3efc493dbd7aa5b0abef17b87e219","head":{"label":"karafka:params-parse","ref":"params-parse","sha":"a6e56fff9ff3efc493dbd7aa5b0abef17b87e219","user":{"login":"karafka","id":13313336,"avatar_url":"https://avatars2.githubusercontent.com/u/13313336?v=4","gravatar_id":"","url":"https://api.github.com/users/karafka","html_url":"https://github.com/karafka","followers_url":"https://api.github.com/users/karafka/followers","following_url":"https://api.github.com/users/karafka/following{/other_user}","gists_url":"https://api.github.com/users/karafka/gists{/gist_id}","starred_url":"https://api.github.com/users/karafka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karafka/subscriptions","organizations_url":"https://api.github.com/users/karafka/orgs","repos_url":"https://api.github.com/users/karafka/repos","events_url":"https://api.github.com/users/karafka/events{/privacy}","received_events_url":"https://api.github.com/users/karafka/received_events","type":"Organization","site_admin":false},"repo":{"id":39947871,"name":"karafka","full_name":"karafka/karafka","owner":{"login":"karafka","id":13313336,"avatar_url":"https://avatars2.githubusercontent.com/u/13313336?v=4","gravatar_id":"","url":"https://api.github.com/users/karafka","html_url":"https://github.com/karafka","followers_url":"https://api.github.com/users/karafka/followers","following_url":"https://api.github.com/users/karafka/following{/other_user}","gists_url":"https://api.github.com/users/karafka/gists{/gist_id}","starred_url":"https://api.github.com/users/karafka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karafka/subscriptions","organizations_url":"https://api.github.com/users/karafka/orgs","repos_url":"https://api.github.com/users/karafka/repos","events_url":"https://api.github.com/users/karafka/events{/privacy}","received_events_url":"https://api.github.com/users/karafka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/karafka/karafka","description":"Framework for Apache Kafka based Ruby and Rails applications development.","fork":false,"url":"https://api.github.com/repos/karafka/karafka","forks_url":"https://api.github.com/repos/karafka/karafka/forks","keys_url":"https://api.github.com/repos/karafka/karafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karafka/karafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karafka/karafka/teams","hooks_url":"https://api.github.com/repos/karafka/karafka/hooks","issue_events_url":"https://api.github.com/repos/karafka/karafka/issues/events{/number}","events_url":"https://api.github.com/repos/karafka/karafka/events","assignees_url":"https://api.github.com/repos/karafka/karafka/assignees{/user}","branches_url":"https://api.github.com/repos/karafka/karafka/branches{/branch}","tags_url":"https://api.github.com/repos/karafka/karafka/tags","blobs_url":"https://api.github.com/repos/karafka/karafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karafka/karafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karafka/karafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/karafka/karafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karafka/karafka/statuses/{sha}","languages_url":"https://api.github.com/repos/karafka/karafka/languages","stargazers_url":"https://api.github.com/repos/karafka/karafka/stargazers","contributors_url":"https://api.github.com/repos/karafka/karafka/contributors","subscribers_url":"https://api.github.com/repos/karafka/karafka/subscribers","subscription_url":"https://api.github.com/repos/karafka/karafka/subscription","commits_url":"https://api.github.com/repos/karafka/karafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/karafka/karafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/karafka/karafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/karafka/karafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/karafka/karafka/contents/{+path}","compare_url":"https://api.github.com/repos/karafka/karafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karafka/karafka/merges","archive_url":"https://api.github.com/repos/karafka/karafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karafka/karafka/downloads","issues_url":"https://api.github.com/repos/karafka/karafka/issues{/number}","pulls_url":"https://api.github.com/repos/karafka/karafka/pulls{/number}","milestones_url":"https://api.github.com/repos/karafka/karafka/milestones{/number}","notifications_url":"https://api.github.com/repos/karafka/karafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karafka/karafka/labels{/name}","releases_url":"https://api.github.com/repos/karafka/karafka/releases{/id}","deployments_url":"https://api.github.com/repos/karafka/karafka/deployments","created_at":"2015-07-30T11:49:27Z","updated_at":"2018-05-25T10:30:04Z","pushed_at":"2018-05-27T07:17:41Z","git_url":"git://github.com/karafka/karafka.git","ssh_url":"git@github.com:karafka/karafka.git","clone_url":"https://github.com/karafka/karafka.git","svn_url":"https://github.com/karafka/karafka","homepage":"","size":1227,"stargazers_count":703,"watchers_count":703,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":54,"open_issues":14,"watchers":703,"default_branch":"master"}},"base":{"label":"karafka:1.3-wip","ref":"1.3-wip","sha":"c9c0e3c99be60774ec7fc42c5aff4b84d1162571","user":{"login":"karafka","id":13313336,"avatar_url":"https://avatars2.githubusercontent.com/u/13313336?v=4","gravatar_id":"","url":"https://api.github.com/users/karafka","html_url":"https://github.com/karafka","followers_url":"https://api.github.com/users/karafka/followers","following_url":"https://api.github.com/users/karafka/following{/other_user}","gists_url":"https://api.github.com/users/karafka/gists{/gist_id}","starred_url":"https://api.github.com/users/karafka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karafka/subscriptions","organizations_url":"https://api.github.com/users/karafka/orgs","repos_url":"https://api.github.com/users/karafka/repos","events_url":"https://api.github.com/users/karafka/events{/privacy}","received_events_url":"https://api.github.com/users/karafka/received_events","type":"Organization","site_admin":false},"repo":{"id":39947871,"name":"karafka","full_name":"karafka/karafka","owner":{"login":"karafka","id":13313336,"avatar_url":"https://avatars2.githubusercontent.com/u/13313336?v=4","gravatar_id":"","url":"https://api.github.com/users/karafka","html_url":"https://github.com/karafka","followers_url":"https://api.github.com/users/karafka/followers","following_url":"https://api.github.com/users/karafka/following{/other_user}","gists_url":"https://api.github.com/users/karafka/gists{/gist_id}","starred_url":"https://api.github.com/users/karafka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karafka/subscriptions","organizations_url":"https://api.github.com/users/karafka/orgs","repos_url":"https://api.github.com/users/karafka/repos","events_url":"https://api.github.com/users/karafka/events{/privacy}","received_events_url":"https://api.github.com/users/karafka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/karafka/karafka","description":"Framework for Apache Kafka based Ruby and Rails applications development.","fork":false,"url":"https://api.github.com/repos/karafka/karafka","forks_url":"https://api.github.com/repos/karafka/karafka/forks","keys_url":"https://api.github.com/repos/karafka/karafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karafka/karafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karafka/karafka/teams","hooks_url":"https://api.github.com/repos/karafka/karafka/hooks","issue_events_url":"https://api.github.com/repos/karafka/karafka/issues/events{/number}","events_url":"https://api.github.com/repos/karafka/karafka/events","assignees_url":"https://api.github.com/repos/karafka/karafka/assignees{/user}","branches_url":"https://api.github.com/repos/karafka/karafka/branches{/branch}","tags_url":"https://api.github.com/repos/karafka/karafka/tags","blobs_url":"https://api.github.com/repos/karafka/karafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karafka/karafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karafka/karafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/karafka/karafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karafka/karafka/statuses/{sha}","languages_url":"https://api.github.com/repos/karafka/karafka/languages","stargazers_url":"https://api.github.com/repos/karafka/karafka/stargazers","contributors_url":"https://api.github.com/repos/karafka/karafka/contributors","subscribers_url":"https://api.github.com/repos/karafka/karafka/subscribers","subscription_url":"https://api.github.com/repos/karafka/karafka/subscription","commits_url":"https://api.github.com/repos/karafka/karafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/karafka/karafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/karafka/karafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/karafka/karafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/karafka/karafka/contents/{+path}","compare_url":"https://api.github.com/repos/karafka/karafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karafka/karafka/merges","archive_url":"https://api.github.com/repos/karafka/karafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karafka/karafka/downloads","issues_url":"https://api.github.com/repos/karafka/karafka/issues{/number}","pulls_url":"https://api.github.com/repos/karafka/karafka/pulls{/number}","milestones_url":"https://api.github.com/repos/karafka/karafka/milestones{/number}","notifications_url":"https://api.github.com/repos/karafka/karafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karafka/karafka/labels{/name}","releases_url":"https://api.github.com/repos/karafka/karafka/releases{/id}","deployments_url":"https://api.github.com/repos/karafka/karafka/deployments","created_at":"2015-07-30T11:49:27Z","updated_at":"2018-05-25T10:30:04Z","pushed_at":"2018-05-27T07:17:41Z","git_url":"git://github.com/karafka/karafka.git","ssh_url":"git@github.com:karafka/karafka.git","clone_url":"https://github.com/karafka/karafka.git","svn_url":"https://github.com/karafka/karafka","homepage":"","size":1227,"stargazers_count":703,"watchers_count":703,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":54,"open_issues":14,"watchers":703,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/karafka/karafka/pulls/352"},"html":{"href":"https://github.com/karafka/karafka/pull/352"},"issue":{"href":"https://api.github.com/repos/karafka/karafka/issues/352"},"comments":{"href":"https://api.github.com/repos/karafka/karafka/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/karafka/karafka/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/karafka/karafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/karafka/karafka/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/karafka/karafka/statuses/a6e56fff9ff3efc493dbd7aa5b0abef17b87e219"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mensfeld"}}