{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/244650237","pull_request_review_id":188570379,"id":244650237,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDY1MDIzNw==","diff_hunk":"@@ -506,6 +507,35 @@ impl<'hir> Map<'hir> {\n         &self.forest.krate.attrs\n     }\n \n+    pub fn visit_module_item_likes<V>(&self, module: DefId, visitor: &mut V)\n+        where V: ItemLikeVisitor<'hir>\n+    {\n+        let node_id = self.as_local_node_id(module).unwrap();\n+\n+        // Read the module so we'll be re-executed if new items\n+        // appear immediately under in the module. If some new item appears\n+        // in some nested item in the module, we'll be re-executed due to the reads\n+        // in the loops below\n+        self.read(node_id);\n+\n+        let module = &self.forest.krate.modules[&node_id];\n+\n+        for id in &module.items {\n+            self.read(*id);","path":"src/librustc/hir/map/mod.rs","position":26,"original_position":26,"commit_id":"3cb613ad342a508be3004922a779514cf61f3db3","original_commit_id":"3cb613ad342a508be3004922a779514cf61f3db3","user":{"login":"Zoxc","id":25784,"node_id":"MDQ6VXNlcjI1Nzg0","avatar_url":"https://avatars3.githubusercontent.com/u/25784?v=4","gravatar_id":"","url":"https://api.github.com/users/Zoxc","html_url":"https://github.com/Zoxc","followers_url":"https://api.github.com/users/Zoxc/followers","following_url":"https://api.github.com/users/Zoxc/following{/other_user}","gists_url":"https://api.github.com/users/Zoxc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zoxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zoxc/subscriptions","organizations_url":"https://api.github.com/users/Zoxc/orgs","repos_url":"https://api.github.com/users/Zoxc/repos","events_url":"https://api.github.com/users/Zoxc/events{/privacy}","received_events_url":"https://api.github.com/users/Zoxc/received_events","type":"User","site_admin":false},"body":"This will give a dependency on changes to items in immediate submodules through `mod` items. This isn't desired since our passes do not look at these. Any change in a module will cause passes to re-execute for the parent module too.","created_at":"2019-01-01T22:58:57Z","updated_at":"2019-01-01T22:58:57Z","html_url":"https://github.com/rust-lang/rust/pull/51487#discussion_r244650237","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/51487","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/244650237"},"html":{"href":"https://github.com/rust-lang/rust/pull/51487#discussion_r244650237"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/51487"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/51487","id":193889149,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODg5MTQ5","html_url":"https://github.com/rust-lang/rust/pull/51487","diff_url":"https://github.com/rust-lang/rust/pull/51487.diff","patch_url":"https://github.com/rust-lang/rust/pull/51487.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/51487","number":51487,"state":"open","locked":false,"title":"Make more passes incremental","user":{"login":"Zoxc","id":25784,"node_id":"MDQ6VXNlcjI1Nzg0","avatar_url":"https://avatars3.githubusercontent.com/u/25784?v=4","gravatar_id":"","url":"https://api.github.com/users/Zoxc","html_url":"https://github.com/Zoxc","followers_url":"https://api.github.com/users/Zoxc/followers","following_url":"https://api.github.com/users/Zoxc/following{/other_user}","gists_url":"https://api.github.com/users/Zoxc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zoxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zoxc/subscriptions","organizations_url":"https://api.github.com/users/Zoxc/orgs","repos_url":"https://api.github.com/users/Zoxc/repos","events_url":"https://api.github.com/users/Zoxc/events{/privacy}","received_events_url":"https://api.github.com/users/Zoxc/received_events","type":"User","site_admin":false},"body":"r? @michaelwoerister","created_at":"2018-06-11T06:58:34Z","updated_at":"2019-01-01T22:58:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c2b455d9f979f5822a167518231c9d154285127","assignee":{"login":"michaelwoerister","id":1825894,"node_id":"MDQ6VXNlcjE4MjU4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"assignees":[{"login":"michaelwoerister","id":1825894,"node_id":"MDQ6VXNlcjE4MjU4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":627350354,"node_id":"MDU6TGFiZWw2MjczNTAzNTQ=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-inactive-closed","name":"S-inactive-closed","color":"d3dddd","default":false},{"id":583436937,"node_id":"MDU6TGFiZWw1ODM0MzY5Mzc=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-author","name":"S-waiting-on-author","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/51487/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/51487/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/51487/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/3cb613ad342a508be3004922a779514cf61f3db3","head":{"label":"Zoxc:incr-passes","ref":"incr-passes","sha":"3cb613ad342a508be3004922a779514cf61f3db3","user":{"login":"Zoxc","id":25784,"node_id":"MDQ6VXNlcjI1Nzg0","avatar_url":"https://avatars3.githubusercontent.com/u/25784?v=4","gravatar_id":"","url":"https://api.github.com/users/Zoxc","html_url":"https://github.com/Zoxc","followers_url":"https://api.github.com/users/Zoxc/followers","following_url":"https://api.github.com/users/Zoxc/following{/other_user}","gists_url":"https://api.github.com/users/Zoxc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zoxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zoxc/subscriptions","organizations_url":"https://api.github.com/users/Zoxc/orgs","repos_url":"https://api.github.com/users/Zoxc/repos","events_url":"https://api.github.com/users/Zoxc/events{/privacy}","received_events_url":"https://api.github.com/users/Zoxc/received_events","type":"User","site_admin":false},"repo":{"id":21868454,"node_id":"MDEwOlJlcG9zaXRvcnkyMTg2ODQ1NA==","name":"rust","full_name":"Zoxc/rust","private":false,"owner":{"login":"Zoxc","id":25784,"node_id":"MDQ6VXNlcjI1Nzg0","avatar_url":"https://avatars3.githubusercontent.com/u/25784?v=4","gravatar_id":"","url":"https://api.github.com/users/Zoxc","html_url":"https://github.com/Zoxc","followers_url":"https://api.github.com/users/Zoxc/followers","following_url":"https://api.github.com/users/Zoxc/following{/other_user}","gists_url":"https://api.github.com/users/Zoxc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zoxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zoxc/subscriptions","organizations_url":"https://api.github.com/users/Zoxc/orgs","repos_url":"https://api.github.com/users/Zoxc/repos","events_url":"https://api.github.com/users/Zoxc/events{/privacy}","received_events_url":"https://api.github.com/users/Zoxc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Zoxc/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/Zoxc/rust","forks_url":"https://api.github.com/repos/Zoxc/rust/forks","keys_url":"https://api.github.com/repos/Zoxc/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zoxc/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zoxc/rust/teams","hooks_url":"https://api.github.com/repos/Zoxc/rust/hooks","issue_events_url":"https://api.github.com/repos/Zoxc/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Zoxc/rust/events","assignees_url":"https://api.github.com/repos/Zoxc/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Zoxc/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Zoxc/rust/tags","blobs_url":"https://api.github.com/repos/Zoxc/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zoxc/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zoxc/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zoxc/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zoxc/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Zoxc/rust/languages","stargazers_url":"https://api.github.com/repos/Zoxc/rust/stargazers","contributors_url":"https://api.github.com/repos/Zoxc/rust/contributors","subscribers_url":"https://api.github.com/repos/Zoxc/rust/subscribers","subscription_url":"https://api.github.com/repos/Zoxc/rust/subscription","commits_url":"https://api.github.com/repos/Zoxc/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zoxc/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zoxc/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zoxc/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zoxc/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Zoxc/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zoxc/rust/merges","archive_url":"https://api.github.com/repos/Zoxc/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zoxc/rust/downloads","issues_url":"https://api.github.com/repos/Zoxc/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Zoxc/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Zoxc/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Zoxc/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zoxc/rust/labels{/name}","releases_url":"https://api.github.com/repos/Zoxc/rust/releases{/id}","deployments_url":"https://api.github.com/repos/Zoxc/rust/deployments","created_at":"2014-07-15T17:08:44Z","updated_at":"2018-11-27T09:59:48Z","pushed_at":"2019-01-01T18:19:27Z","git_url":"git://github.com/Zoxc/rust.git","ssh_url":"git@github.com:Zoxc/rust.git","clone_url":"https://github.com/Zoxc/rust.git","svn_url":"https://github.com/Zoxc/rust","homepage":"http://www.rust-lang.org","size":408857,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"cae164753f557f668cb75610abda4f790981e5e6","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","private":false,"owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang/rust","description":"Empowering everyone to build reliable and efficient software.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2019-01-01T22:31:18Z","pushed_at":"2019-01-01T22:55:49Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":412763,"stargazers_count":32836,"watchers_count":32836,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5431,"mirror_url":null,"archived":false,"open_issues_count":4746,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5431,"open_issues":4746,"watchers":32836,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/51487"},"html":{"href":"https://github.com/rust-lang/rust/pull/51487"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/51487"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/51487/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/51487/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/51487/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/3cb613ad342a508be3004922a779514cf61f3db3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Zoxc"}}