{"action":"created","issue":{"url":"https://api.github.com/repos/m2e-code-quality/m2e-code-quality/issues/136","repository_url":"https://api.github.com/repos/m2e-code-quality/m2e-code-quality","labels_url":"https://api.github.com/repos/m2e-code-quality/m2e-code-quality/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/m2e-code-quality/m2e-code-quality/issues/136/comments","events_url":"https://api.github.com/repos/m2e-code-quality/m2e-code-quality/issues/136/events","html_url":"https://github.com/m2e-code-quality/m2e-code-quality/pull/136","id":361660530,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NTczNTgz","number":136,"title":"Spotbugs refactoring","user":{"login":"erwint","id":713204,"node_id":"MDQ6VXNlcjcxMzIwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/713204?v=4","gravatar_id":"","url":"https://api.github.com/users/erwint","html_url":"https://github.com/erwint","followers_url":"https://api.github.com/users/erwint/followers","following_url":"https://api.github.com/users/erwint/following{/other_user}","gists_url":"https://api.github.com/users/erwint/gists{/gist_id}","starred_url":"https://api.github.com/users/erwint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwint/subscriptions","organizations_url":"https://api.github.com/users/erwint/orgs","repos_url":"https://api.github.com/users/erwint/repos","events_url":"https://api.github.com/users/erwint/events{/privacy}","received_events_url":"https://api.github.com/users/erwint/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-19T09:34:43Z","updated_at":"2018-09-19T09:52:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/m2e-code-quality/m2e-code-quality/pulls/136","html_url":"https://github.com/m2e-code-quality/m2e-code-quality/pull/136","diff_url":"https://github.com/m2e-code-quality/m2e-code-quality/pull/136.diff","patch_url":"https://github.com/m2e-code-quality/m2e-code-quality/pull/136.patch"},"body":"Add spotbugs support in addition to findbugs\r\n\r\nA new plugin and feature for spotbugs is added, so both findbugs and\r\nspotbugs will work. Spotbugs and findbugs implementation is kept totally\r\nseparated, so that future modifications for spotbugs will not affect\r\nthe deprecated findbugs support.\r\n\r\nThis PR has two commits: The first is direct application of #113, just in a separate plugin/feature.  The second commit will introduce some refactoring to better reuse some infrastructure between the plugins (and checktsyle and pmd, too)\r\n\r\nFixes #110"},"comment":{"url":"https://api.github.com/repos/m2e-code-quality/m2e-code-quality/issues/comments/422734805","html_url":"https://github.com/m2e-code-quality/m2e-code-quality/pull/136#issuecomment-422734805","issue_url":"https://api.github.com/repos/m2e-code-quality/m2e-code-quality/issues/136","id":422734805,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjczNDgwNQ==","user":{"login":"vorburger","id":298598,"node_id":"MDQ6VXNlcjI5ODU5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/298598?v=4","gravatar_id":"","url":"https://api.github.com/users/vorburger","html_url":"https://github.com/vorburger","followers_url":"https://api.github.com/users/vorburger/followers","following_url":"https://api.github.com/users/vorburger/following{/other_user}","gists_url":"https://api.github.com/users/vorburger/gists{/gist_id}","starred_url":"https://api.github.com/users/vorburger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorburger/subscriptions","organizations_url":"https://api.github.com/users/vorburger/orgs","repos_url":"https://api.github.com/users/vorburger/repos","events_url":"https://api.github.com/users/vorburger/events{/privacy}","received_events_url":"https://api.github.com/users/vorburger/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T09:52:45Z","updated_at":"2018-09-19T09:52:45Z","author_association":"MEMBER","body":"@victornoel or @hd42 @antoine-morvan (from #110) or anyone else reading this, would you be willing to locally pull, build and manually test this, with both FindBugs and SpotBugs, and confirm things still work as before with FindBugs and it now configures projects using SpotBugs as well?\r\n\r\n> I would like to have this merged ASAP. as I have 3 or 4 more PRs which would be based on this one\r\n\r\nFYI you don't really have to wait, what I usually do is just raise changes in parallel if they don't touch code that overlaps (and I accept that I sometimes have to do minor rework on rebase), or if changing related code then I would just create a new branch off the branch you used for this, and push another (single) commit change to that, and raise the PR. We can then already review that new commit on that PR (simply by looking at the invidivual commit instead of the Files changed tab), and then Rebase that one once this one is in. That workflow usually works reasonably well in practice for me for GH PRs (and in Gerrit it's even easier)."}}
{"actor":{"display_login":"vorburger"}}