{"action":"created","issue":{"url":"https://api.github.com/repos/WRSC/tracking/issues/1","repository_url":"https://api.github.com/repos/WRSC/tracking","labels_url":"https://api.github.com/repos/WRSC/tracking/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/WRSC/tracking/issues/1/comments","events_url":"https://api.github.com/repos/WRSC/tracking/issues/1/events","html_url":"https://github.com/WRSC/tracking/issues/1","id":293326244,"number":1,"title":"Refactoring app","user":{"login":"nicolas2lee","id":8910318,"avatar_url":"https://avatars2.githubusercontent.com/u/8910318?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas2lee","html_url":"https://github.com/nicolas2lee","followers_url":"https://api.github.com/users/nicolas2lee/followers","following_url":"https://api.github.com/users/nicolas2lee/following{/other_user}","gists_url":"https://api.github.com/users/nicolas2lee/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas2lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas2lee/subscriptions","organizations_url":"https://api.github.com/users/nicolas2lee/orgs","repos_url":"https://api.github.com/users/nicolas2lee/repos","events_url":"https://api.github.com/users/nicolas2lee/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas2lee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-01-31T21:56:39Z","updated_at":"2018-02-02T23:00:08Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Some important tips to keep the app staying modern:\r\n\r\n\r\n1.  Should not use MVC pattern when things get complicated, should use Domain Driven Development\r\n2.  Should add unitary test, integration test, e2e test, cucumber is a good choice\r\n3. Add logs and monitoring for web app, historically no logs stored in file\r\n4.  Maybe decouple the dependency of some use cases, add a messaging service layer, convert to message driven\r\n5. perhaps multi threading for performance optimization, also some big data framework could be a good choice (hadoop, spark, flink ? any big data framework supports ruby ?)\r\n6. add cache for the web app (since none till today)\r\n7. rethink variable name, function name and class name, take some meaningful names\r\n8. maybe use some workflow engine (normally 4 types of competitions, so maybe not need it) & business rule engine (does the competition rule changes each year ? or the score calculation changes each year ? If these things change frequently, then workflow engine & rules engine may be efficient)\r\n9. reactjs + redux or angular + ngrx is a good choice for front-end (although I use angular for my company, but personally I prefer reactjs )"},"comment":{"url":"https://api.github.com/repos/WRSC/tracking/issues/comments/362733823","html_url":"https://github.com/WRSC/tracking/issues/1#issuecomment-362733823","issue_url":"https://api.github.com/repos/WRSC/tracking/issues/1","id":362733823,"user":{"login":"nicolas2lee","id":8910318,"avatar_url":"https://avatars2.githubusercontent.com/u/8910318?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas2lee","html_url":"https://github.com/nicolas2lee","followers_url":"https://api.github.com/users/nicolas2lee/followers","following_url":"https://api.github.com/users/nicolas2lee/following{/other_user}","gists_url":"https://api.github.com/users/nicolas2lee/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas2lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas2lee/subscriptions","organizations_url":"https://api.github.com/users/nicolas2lee/orgs","repos_url":"https://api.github.com/users/nicolas2lee/repos","events_url":"https://api.github.com/users/nicolas2lee/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas2lee/received_events","type":"User","site_admin":false},"created_at":"2018-02-02T23:00:08Z","updated_at":"2018-02-02T23:00:08Z","author_association":"CONTRIBUTOR","body":"I did not know what is the issue for you to launch all tests. But it works perfectly for me, anyway some tests failed in local, because I did not configure the db correctly. I am sure rake test works, at least, it works in my local env.\r\n\r\nTo run the server locally, you just need to run rails s. As indicated in README.md, you need to export the key export SECRET_KEY_BASE=blah. Anyway it is a hidden bug, since normally with dev env, we do not need config this env variable.\r\n\r\nWhat's more, I had configured vagrant for dev env in branch develop, for people who know vagrant, maybe it is convenient."}}
{"actor":{"display_login":"nicolas2lee"}}