{"action":"created","comment":{"url":"https://api.github.com/repos/openregister/registers-frontend/pulls/comments/208480854","pull_request_review_id":144296546,"id":208480854,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODQ4MDg1NA==","diff_hunk":"@@ -210,14 +208,14 @@\n         });\n       }\n \n-      function openStoredSections($section) {\n+      function openStoredSections ($section) {\n         toggleSection($section);\n         toggleIcon($section);\n         toggleState($section.parent().find('.subsection__button'));\n         // setOpenCloseAllText();\n       }\n \n-      function setOpenCloseAllText() {\n+      function setOpenCloseAllText () {\n         var openSubsections = $('.subsection--is-open').length;\n         // Find out if the number of is-opens == total number of sections","path":"app/assets/javascripts/accordion-with-descriptions.js","position":246,"original_position":246,"commit_id":"679e499dd6f418d8ff68f3971a575dd0dc291369","original_commit_id":"679e499dd6f418d8ff68f3971a575dd0dc291369","user":{"login":"injms","id":1732331,"node_id":"MDQ6VXNlcjE3MzIzMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1732331?v=4","gravatar_id":"","url":"https://api.github.com/users/injms","html_url":"https://github.com/injms","followers_url":"https://api.github.com/users/injms/followers","following_url":"https://api.github.com/users/injms/following{/other_user}","gists_url":"https://api.github.com/users/injms/gists{/gist_id}","starred_url":"https://api.github.com/users/injms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/injms/subscriptions","organizations_url":"https://api.github.com/users/injms/orgs","repos_url":"https://api.github.com/users/injms/repos","events_url":"https://api.github.com/users/injms/events{/privacy}","received_events_url":"https://api.github.com/users/injms/received_events","type":"User","site_admin":false},"body":"Okay - this linter has highlighted a lot of stuff that isn't mine...","created_at":"2018-08-08T07:28:35Z","updated_at":"2018-08-08T07:28:35Z","html_url":"https://github.com/openregister/registers-frontend/pull/407#discussion_r208480854","pull_request_url":"https://api.github.com/repos/openregister/registers-frontend/pulls/407","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/comments/208480854"},"html":{"href":"https://github.com/openregister/registers-frontend/pull/407#discussion_r208480854"},"pull_request":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/407"}},"in_reply_to_id":208301280},"pull_request":{"url":"https://api.github.com/repos/openregister/registers-frontend/pulls/407","id":206755990,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NzU1OTkw","html_url":"https://github.com/openregister/registers-frontend/pull/407","diff_url":"https://github.com/openregister/registers-frontend/pull/407.diff","patch_url":"https://github.com/openregister/registers-frontend/pull/407.patch","issue_url":"https://api.github.com/repos/openregister/registers-frontend/issues/407","number":407,"state":"open","locked":false,"title":"Analytics rationalisation and update","user":{"login":"injms","id":1732331,"node_id":"MDQ6VXNlcjE3MzIzMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1732331?v=4","gravatar_id":"","url":"https://api.github.com/users/injms","html_url":"https://github.com/injms","followers_url":"https://api.github.com/users/injms/followers","following_url":"https://api.github.com/users/injms/following{/other_user}","gists_url":"https://api.github.com/users/injms/gists{/gist_id}","starred_url":"https://api.github.com/users/injms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/injms/subscriptions","organizations_url":"https://api.github.com/users/injms/orgs","repos_url":"https://api.github.com/users/injms/repos","events_url":"https://api.github.com/users/injms/events{/privacy}","received_events_url":"https://api.github.com/users/injms/received_events","type":"User","site_admin":false},"body":"### Context\r\nThe analytics audit showed that there was a lot of tracking where it wasn't needed, and an absence of tracking where it was needed. \r\n\r\n### Changes proposed in this pull request\r\n * Events no longer fire when links the header and the footer of the page are clicked\r\n * Events no longer fire when a register is sorted\r\n * The feedback form now includes the 'No' sub-options, and only fires when the form is submitted\r\n * Accordions only fire an event when opened, not when closed\r\n * Unsuccessful searches now fire an event to let us know what query wasn't found\r\n\r\n### Guidance to review\r\n(Apologies for the mass of linting changes that have become inextricably linked to this PR).\r\nThis has been tested in all of the supported browsers - but extra eyes are always welcome!","created_at":"2018-08-07T16:26:58Z","updated_at":"2018-08-08T07:28:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11d3ee40d1765eb05db8107af634a807ba3038ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openregister/registers-frontend/pulls/407/commits","review_comments_url":"https://api.github.com/repos/openregister/registers-frontend/pulls/407/comments","review_comment_url":"https://api.github.com/repos/openregister/registers-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openregister/registers-frontend/issues/407/comments","statuses_url":"https://api.github.com/repos/openregister/registers-frontend/statuses/679e499dd6f418d8ff68f3971a575dd0dc291369","head":{"label":"openregister:analytics-rationalisation-and-update","ref":"analytics-rationalisation-and-update","sha":"679e499dd6f418d8ff68f3971a575dd0dc291369","user":{"login":"openregister","id":10206003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjA2MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/10206003?v=4","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"repo":{"id":79900152,"node_id":"MDEwOlJlcG9zaXRvcnk3OTkwMDE1Mg==","name":"registers-frontend","full_name":"openregister/registers-frontend","owner":{"login":"openregister","id":10206003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjA2MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/10206003?v=4","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openregister/registers-frontend","description":"GOV.UK Registers Frontend","fork":false,"url":"https://api.github.com/repos/openregister/registers-frontend","forks_url":"https://api.github.com/repos/openregister/registers-frontend/forks","keys_url":"https://api.github.com/repos/openregister/registers-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openregister/registers-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openregister/registers-frontend/teams","hooks_url":"https://api.github.com/repos/openregister/registers-frontend/hooks","issue_events_url":"https://api.github.com/repos/openregister/registers-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/openregister/registers-frontend/events","assignees_url":"https://api.github.com/repos/openregister/registers-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/openregister/registers-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/openregister/registers-frontend/tags","blobs_url":"https://api.github.com/repos/openregister/registers-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openregister/registers-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openregister/registers-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/openregister/registers-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openregister/registers-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/openregister/registers-frontend/languages","stargazers_url":"https://api.github.com/repos/openregister/registers-frontend/stargazers","contributors_url":"https://api.github.com/repos/openregister/registers-frontend/contributors","subscribers_url":"https://api.github.com/repos/openregister/registers-frontend/subscribers","subscription_url":"https://api.github.com/repos/openregister/registers-frontend/subscription","commits_url":"https://api.github.com/repos/openregister/registers-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/openregister/registers-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/openregister/registers-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/openregister/registers-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/openregister/registers-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/openregister/registers-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openregister/registers-frontend/merges","archive_url":"https://api.github.com/repos/openregister/registers-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openregister/registers-frontend/downloads","issues_url":"https://api.github.com/repos/openregister/registers-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/openregister/registers-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/openregister/registers-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/openregister/registers-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openregister/registers-frontend/labels{/name}","releases_url":"https://api.github.com/repos/openregister/registers-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/openregister/registers-frontend/deployments","created_at":"2017-01-24T10:11:12Z","updated_at":"2018-08-07T15:55:39Z","pushed_at":"2018-08-07T16:26:58Z","git_url":"git://github.com/openregister/registers-frontend.git","ssh_url":"git@github.com:openregister/registers-frontend.git","clone_url":"https://github.com/openregister/registers-frontend.git","svn_url":"https://github.com/openregister/registers-frontend","homepage":"https://www.registers.service.gov.uk/","size":3183,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"openregister:master","ref":"master","sha":"641fffb2c0b7d1699e56e342271226ea256cdd7e","user":{"login":"openregister","id":10206003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjA2MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/10206003?v=4","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"repo":{"id":79900152,"node_id":"MDEwOlJlcG9zaXRvcnk3OTkwMDE1Mg==","name":"registers-frontend","full_name":"openregister/registers-frontend","owner":{"login":"openregister","id":10206003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjA2MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/10206003?v=4","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openregister/registers-frontend","description":"GOV.UK Registers Frontend","fork":false,"url":"https://api.github.com/repos/openregister/registers-frontend","forks_url":"https://api.github.com/repos/openregister/registers-frontend/forks","keys_url":"https://api.github.com/repos/openregister/registers-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openregister/registers-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openregister/registers-frontend/teams","hooks_url":"https://api.github.com/repos/openregister/registers-frontend/hooks","issue_events_url":"https://api.github.com/repos/openregister/registers-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/openregister/registers-frontend/events","assignees_url":"https://api.github.com/repos/openregister/registers-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/openregister/registers-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/openregister/registers-frontend/tags","blobs_url":"https://api.github.com/repos/openregister/registers-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openregister/registers-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openregister/registers-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/openregister/registers-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openregister/registers-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/openregister/registers-frontend/languages","stargazers_url":"https://api.github.com/repos/openregister/registers-frontend/stargazers","contributors_url":"https://api.github.com/repos/openregister/registers-frontend/contributors","subscribers_url":"https://api.github.com/repos/openregister/registers-frontend/subscribers","subscription_url":"https://api.github.com/repos/openregister/registers-frontend/subscription","commits_url":"https://api.github.com/repos/openregister/registers-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/openregister/registers-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/openregister/registers-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/openregister/registers-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/openregister/registers-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/openregister/registers-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openregister/registers-frontend/merges","archive_url":"https://api.github.com/repos/openregister/registers-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openregister/registers-frontend/downloads","issues_url":"https://api.github.com/repos/openregister/registers-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/openregister/registers-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/openregister/registers-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/openregister/registers-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openregister/registers-frontend/labels{/name}","releases_url":"https://api.github.com/repos/openregister/registers-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/openregister/registers-frontend/deployments","created_at":"2017-01-24T10:11:12Z","updated_at":"2018-08-07T15:55:39Z","pushed_at":"2018-08-07T16:26:58Z","git_url":"git://github.com/openregister/registers-frontend.git","ssh_url":"git@github.com:openregister/registers-frontend.git","clone_url":"https://github.com/openregister/registers-frontend.git","svn_url":"https://github.com/openregister/registers-frontend","homepage":"https://www.registers.service.gov.uk/","size":3183,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/407"},"html":{"href":"https://github.com/openregister/registers-frontend/pull/407"},"issue":{"href":"https://api.github.com/repos/openregister/registers-frontend/issues/407"},"comments":{"href":"https://api.github.com/repos/openregister/registers-frontend/issues/407/comments"},"review_comments":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/407/comments"},"review_comment":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/407/commits"},"statuses":{"href":"https://api.github.com/repos/openregister/registers-frontend/statuses/679e499dd6f418d8ff68f3971a575dd0dc291369"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"injms"}}