{"action":"created","issue":{"url":"https://api.github.com/repos/Samsung/TizenRT/issues/2058","repository_url":"https://api.github.com/repos/Samsung/TizenRT","labels_url":"https://api.github.com/repos/Samsung/TizenRT/issues/2058/labels{/name}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/issues/2058/comments","events_url":"https://api.github.com/repos/Samsung/TizenRT/issues/2058/events","html_url":"https://github.com/Samsung/TizenRT/pull/2058","id":351542724,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MTA4Mzk5","number":2058,"title":"arch/debug: modify DEBUG_DISPLAY_SYMBOL dependancies","user":{"login":"sunghan-chang","id":25810970,"node_id":"MDQ6VXNlcjI1ODEwOTcw","avatar_url":"https://avatars1.githubusercontent.com/u/25810970?v=4","gravatar_id":"","url":"https://api.github.com/users/sunghan-chang","html_url":"https://github.com/sunghan-chang","followers_url":"https://api.github.com/users/sunghan-chang/followers","following_url":"https://api.github.com/users/sunghan-chang/following{/other_user}","gists_url":"https://api.github.com/users/sunghan-chang/gists{/gist_id}","starred_url":"https://api.github.com/users/sunghan-chang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunghan-chang/subscriptions","organizations_url":"https://api.github.com/users/sunghan-chang/orgs","repos_url":"https://api.github.com/users/sunghan-chang/repos","events_url":"https://api.github.com/users/sunghan-chang/events{/privacy}","received_events_url":"https://api.github.com/users/sunghan-chang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-17T10:31:37Z","updated_at":"2018-08-17T10:35:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2058","html_url":"https://github.com/Samsung/TizenRT/pull/2058","diff_url":"https://github.com/Samsung/TizenRT/pull/2058.diff","patch_url":"https://github.com/Samsung/TizenRT/pull/2058.patch"},"body":"1. add a dependancy with ARCH_STACKDUMP\r\n  The assert shows call stack when ARCH_STACKDUMP is enabled.\r\n  Without above config, assert shows simple information like\r\n  below:\r\n\r\n  up_assert: Assertion failed at file:hello_main.c line: 70 ....\r\n\r\n  So, because DEBUG_DISPLAY_SYMBOL is meaningful with\r\n  ARCH_STACKDUMP, let's add \"depends on ARCH_STACKDUMP\"\r\n\r\n2. change a type of dependancy\r\n  To use DEBUG_DISPLAY_SYMBOL, DEBUG_SYMBOLS, FRAME_POINTER\r\n  and FS_ROMFS are needed so that it made dependancies\r\n  through \"depends on\".\r\n  But because first two configs (DEBUG_SYMBOLS and FRAME_POINTER)\r\n  do not have any dependancy themself, we can use \"select\" instead\r\n  of \"depends on\". \"select\" is easiler to use, gives more convenient\r\n  to user.\r\n\r\nSigned-off-by: sunghan-chang <sh924.chang@samsung.com>"},"comment":{"url":"https://api.github.com/repos/Samsung/TizenRT/issues/comments/413826218","html_url":"https://github.com/Samsung/TizenRT/pull/2058#issuecomment-413826218","issue_url":"https://api.github.com/repos/Samsung/TizenRT/issues/2058","id":413826218,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzgyNjIxOA==","user":{"login":"sunghan-chang","id":25810970,"node_id":"MDQ6VXNlcjI1ODEwOTcw","avatar_url":"https://avatars1.githubusercontent.com/u/25810970?v=4","gravatar_id":"","url":"https://api.github.com/users/sunghan-chang","html_url":"https://github.com/sunghan-chang","followers_url":"https://api.github.com/users/sunghan-chang/followers","following_url":"https://api.github.com/users/sunghan-chang/following{/other_user}","gists_url":"https://api.github.com/users/sunghan-chang/gists{/gist_id}","starred_url":"https://api.github.com/users/sunghan-chang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunghan-chang/subscriptions","organizations_url":"https://api.github.com/users/sunghan-chang/orgs","repos_url":"https://api.github.com/users/sunghan-chang/repos","events_url":"https://api.github.com/users/sunghan-chang/events{/privacy}","received_events_url":"https://api.github.com/users/sunghan-chang/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T10:35:13Z","updated_at":"2018-08-17T10:35:13Z","author_association":"CONTRIBUTOR","body":"The reason of \"depends on\" for ARCH_STACKDUMP against my 2nd commit description is\r\n1. ARCH_STACKDUMP is to find. It is in same topic of Kconfig menu and next of ARCH_STACKDUMP is DEBUG_DISPLAY_SYMBOL.\r\n2. ARCH_STACKDUMP is a highier level of config than DEBUG_DISPLAY_SYMBOL.\r\n  DEBUG_XX is meaningful only when ARCH_XX is enabled. "}}
{"actor":{"display_login":"sunghan-chang"}}