{"action":"created","issue":{"url":"https://api.github.com/repos/bendudson/matlisp/issues/1","repository_url":"https://api.github.com/repos/bendudson/matlisp","labels_url":"https://api.github.com/repos/bendudson/matlisp/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/bendudson/matlisp/issues/1/comments","events_url":"https://api.github.com/repos/bendudson/matlisp/issues/1/events","html_url":"https://github.com/bendudson/matlisp/pull/1","id":305062305,"number":1,"title":"Add coercion argument to as-tensor","user":{"login":"privet-kitty","id":10072062,"avatar_url":"https://avatars2.githubusercontent.com/u/10072062?v=4","gravatar_id":"","url":"https://api.github.com/users/privet-kitty","html_url":"https://github.com/privet-kitty","followers_url":"https://api.github.com/users/privet-kitty/followers","following_url":"https://api.github.com/users/privet-kitty/following{/other_user}","gists_url":"https://api.github.com/users/privet-kitty/gists{/gist_id}","starred_url":"https://api.github.com/users/privet-kitty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privet-kitty/subscriptions","organizations_url":"https://api.github.com/users/privet-kitty/orgs","repos_url":"https://api.github.com/users/privet-kitty/repos","events_url":"https://api.github.com/users/privet-kitty/events{/privacy}","received_events_url":"https://api.github.com/users/privet-kitty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-14T08:25:10Z","updated_at":"2018-03-14T08:39:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bendudson/matlisp/pulls/1","html_url":"https://github.com/bendudson/matlisp/pull/1","diff_url":"https://github.com/bendudson/matlisp/pull/1.diff","patch_url":"https://github.com/bendudson/matlisp/pull/1.patch"},"body":"I think it would be useful if the `AS-TENSOR` methods can do coercion of a field type.\r\n\r\nTrivial matters: I deleted `ARRAY-ELEMENT-TYPE` in `AS-TENSOR` for simple vector, as it is always `t`."},"comment":{"url":"https://api.github.com/repos/bendudson/matlisp/issues/comments/372943943","html_url":"https://github.com/bendudson/matlisp/pull/1#issuecomment-372943943","issue_url":"https://api.github.com/repos/bendudson/matlisp/issues/1","id":372943943,"user":{"login":"bendudson","id":219233,"avatar_url":"https://avatars1.githubusercontent.com/u/219233?v=4","gravatar_id":"","url":"https://api.github.com/users/bendudson","html_url":"https://github.com/bendudson","followers_url":"https://api.github.com/users/bendudson/followers","following_url":"https://api.github.com/users/bendudson/following{/other_user}","gists_url":"https://api.github.com/users/bendudson/gists{/gist_id}","starred_url":"https://api.github.com/users/bendudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendudson/subscriptions","organizations_url":"https://api.github.com/users/bendudson/orgs","repos_url":"https://api.github.com/users/bendudson/repos","events_url":"https://api.github.com/users/bendudson/events{/privacy}","received_events_url":"https://api.github.com/users/bendudson/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T08:39:42Z","updated_at":"2018-03-14T08:39:42Z","author_association":"OWNER","body":"Thanks! I hadn't realised that the simple vector was always type t; seems like that's missing a potential optimisation. \r\n\r\nI'm still not sure about this part of as-array https://github.com/privet-kitty/matlisp/blob/d53e5462097b909c7179947e365fe6246da98b92/src/base/interop.lisp#L44 since I think a 1D tensor could still have stride != 1. Probably the best thing is just to always copy.\r\n"}}
{"actor":{"display_login":"bendudson"}}