{"action":"created","comment":{"url":"https://api.github.com/repos/heptio/ark/pulls/comments/211018871","pull_request_review_id":147363715,"id":211018871,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTAxODg3MQ==","diff_hunk":"@@ -80,30 +79,28 @@ func NewBackupController(\n \tbackupInformer informers.BackupInformer,\n \tclient arkv1client.BackupsGetter,\n \tbackupper backup.Backupper,\n-\tobjectStoreConfig api.CloudProviderConfig,\n-\tbucket string,\n \tpvProviderExists bool,\n \tlogger logrus.FieldLogger,\n \tlogLevel logrus.Level,\n \tpluginRegistry plugin.Registry,\n \tbackupTracker BackupTracker,\n+\tbackupLocationInformer informers.BackupStorageLocationInformer,\n \tmetrics *metrics.ServerMetrics,\n ) Interface {\n \tc := &backupController{\n-\t\tbackupper:         backupper,\n-\t\tobjectStoreConfig: objectStoreConfig,\n-\t\tbucket:            bucket,\n-\t\tpvProviderExists:  pvProviderExists,\n-\t\tlister:            backupInformer.Lister(),\n-\t\tlisterSynced:      backupInformer.Informer().HasSynced,\n-\t\tclient:            client,\n-\t\tqueue:             workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), \"backup\"),\n-\t\tclock:             &clock.RealClock{},\n-\t\tlogger:            logger,\n-\t\tlogLevel:          logLevel,\n-\t\tpluginRegistry:    pluginRegistry,\n-\t\tbackupTracker:     backupTracker,\n-\t\tmetrics:           metrics,\n+\t\tbackupper:            backupper,","path":"pkg/controller/backup_controller.go","position":65,"original_position":65,"commit_id":"f2199ba8197fb2d3dd18bda6c6686760099716ef","original_commit_id":"f2199ba8197fb2d3dd18bda6c6686760099716ef","user":{"login":"nrb","id":321387,"node_id":"MDQ6VXNlcjMyMTM4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/321387?v=4","gravatar_id":"","url":"https://api.github.com/users/nrb","html_url":"https://github.com/nrb","followers_url":"https://api.github.com/users/nrb/followers","following_url":"https://api.github.com/users/nrb/following{/other_user}","gists_url":"https://api.github.com/users/nrb/gists{/gist_id}","starred_url":"https://api.github.com/users/nrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrb/subscriptions","organizations_url":"https://api.github.com/users/nrb/orgs","repos_url":"https://api.github.com/users/nrb/repos","events_url":"https://api.github.com/users/nrb/events{/privacy}","received_events_url":"https://api.github.com/users/nrb/received_events","type":"User","site_admin":false},"body":"I hadn't looked at it yet; want me to push the other fixes then see where we're at?\r\n\r\n","created_at":"2018-08-17T20:03:45Z","updated_at":"2018-08-17T20:03:45Z","html_url":"https://github.com/heptio/ark/pull/771#discussion_r211018871","pull_request_url":"https://api.github.com/repos/heptio/ark/pulls/771","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/heptio/ark/pulls/comments/211018871"},"html":{"href":"https://github.com/heptio/ark/pull/771#discussion_r211018871"},"pull_request":{"href":"https://api.github.com/repos/heptio/ark/pulls/771"}},"in_reply_to_id":210765489},"pull_request":{"url":"https://api.github.com/repos/heptio/ark/pulls/771","id":209004543,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDA0NTQz","html_url":"https://github.com/heptio/ark/pull/771","diff_url":"https://github.com/heptio/ark/pull/771.diff","patch_url":"https://github.com/heptio/ark/pull/771.patch","issue_url":"https://api.github.com/repos/heptio/ark/issues/771","number":771,"state":"open","locked":false,"title":"Use backup location in the backup controller","user":{"login":"nrb","id":321387,"node_id":"MDQ6VXNlcjMyMTM4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/321387?v=4","gravatar_id":"","url":"https://api.github.com/users/nrb","html_url":"https://github.com/nrb","followers_url":"https://api.github.com/users/nrb/followers","following_url":"https://api.github.com/users/nrb/following{/other_user}","gists_url":"https://api.github.com/users/nrb/gists{/gist_id}","starred_url":"https://api.github.com/users/nrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrb/subscriptions","organizations_url":"https://api.github.com/users/nrb/orgs","repos_url":"https://api.github.com/users/nrb/repos","events_url":"https://api.github.com/users/nrb/events{/privacy}","received_events_url":"https://api.github.com/users/nrb/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Nolan Brubaker <nolan@heptio.com>","created_at":"2018-08-16T22:46:20Z","updated_at":"2018-08-17T20:03:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f6b2fbfdeb31227526f5b8536cb223cd4e363c0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"carlisia","id":16508,"node_id":"MDQ6VXNlcjE2NTA4","avatar_url":"https://avatars0.githubusercontent.com/u/16508?v=4","gravatar_id":"","url":"https://api.github.com/users/carlisia","html_url":"https://github.com/carlisia","followers_url":"https://api.github.com/users/carlisia/followers","following_url":"https://api.github.com/users/carlisia/following{/other_user}","gists_url":"https://api.github.com/users/carlisia/gists{/gist_id}","starred_url":"https://api.github.com/users/carlisia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlisia/subscriptions","organizations_url":"https://api.github.com/users/carlisia/orgs","repos_url":"https://api.github.com/users/carlisia/repos","events_url":"https://api.github.com/users/carlisia/events{/privacy}","received_events_url":"https://api.github.com/users/carlisia/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heptio/ark/pulls/771/commits","review_comments_url":"https://api.github.com/repos/heptio/ark/pulls/771/comments","review_comment_url":"https://api.github.com/repos/heptio/ark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heptio/ark/issues/771/comments","statuses_url":"https://api.github.com/repos/heptio/ark/statuses/f2199ba8197fb2d3dd18bda6c6686760099716ef","head":{"label":"nrb:fix-739","ref":"fix-739","sha":"f2199ba8197fb2d3dd18bda6c6686760099716ef","user":{"login":"nrb","id":321387,"node_id":"MDQ6VXNlcjMyMTM4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/321387?v=4","gravatar_id":"","url":"https://api.github.com/users/nrb","html_url":"https://github.com/nrb","followers_url":"https://api.github.com/users/nrb/followers","following_url":"https://api.github.com/users/nrb/following{/other_user}","gists_url":"https://api.github.com/users/nrb/gists{/gist_id}","starred_url":"https://api.github.com/users/nrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrb/subscriptions","organizations_url":"https://api.github.com/users/nrb/orgs","repos_url":"https://api.github.com/users/nrb/repos","events_url":"https://api.github.com/users/nrb/events{/privacy}","received_events_url":"https://api.github.com/users/nrb/received_events","type":"User","site_admin":false},"repo":{"id":109045422,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkwNDU0MjI=","name":"ark","full_name":"nrb/ark","owner":{"login":"nrb","id":321387,"node_id":"MDQ6VXNlcjMyMTM4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/321387?v=4","gravatar_id":"","url":"https://api.github.com/users/nrb","html_url":"https://github.com/nrb","followers_url":"https://api.github.com/users/nrb/followers","following_url":"https://api.github.com/users/nrb/following{/other_user}","gists_url":"https://api.github.com/users/nrb/gists{/gist_id}","starred_url":"https://api.github.com/users/nrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrb/subscriptions","organizations_url":"https://api.github.com/users/nrb/orgs","repos_url":"https://api.github.com/users/nrb/repos","events_url":"https://api.github.com/users/nrb/events{/privacy}","received_events_url":"https://api.github.com/users/nrb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nrb/ark","description":"Heptio Ark is a utility for managing disaster recovery, specifically for your Kubernetes cluster resources and persistent volumes. Brought to you by Heptio.","fork":true,"url":"https://api.github.com/repos/nrb/ark","forks_url":"https://api.github.com/repos/nrb/ark/forks","keys_url":"https://api.github.com/repos/nrb/ark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nrb/ark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nrb/ark/teams","hooks_url":"https://api.github.com/repos/nrb/ark/hooks","issue_events_url":"https://api.github.com/repos/nrb/ark/issues/events{/number}","events_url":"https://api.github.com/repos/nrb/ark/events","assignees_url":"https://api.github.com/repos/nrb/ark/assignees{/user}","branches_url":"https://api.github.com/repos/nrb/ark/branches{/branch}","tags_url":"https://api.github.com/repos/nrb/ark/tags","blobs_url":"https://api.github.com/repos/nrb/ark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nrb/ark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nrb/ark/git/refs{/sha}","trees_url":"https://api.github.com/repos/nrb/ark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nrb/ark/statuses/{sha}","languages_url":"https://api.github.com/repos/nrb/ark/languages","stargazers_url":"https://api.github.com/repos/nrb/ark/stargazers","contributors_url":"https://api.github.com/repos/nrb/ark/contributors","subscribers_url":"https://api.github.com/repos/nrb/ark/subscribers","subscription_url":"https://api.github.com/repos/nrb/ark/subscription","commits_url":"https://api.github.com/repos/nrb/ark/commits{/sha}","git_commits_url":"https://api.github.com/repos/nrb/ark/git/commits{/sha}","comments_url":"https://api.github.com/repos/nrb/ark/comments{/number}","issue_comment_url":"https://api.github.com/repos/nrb/ark/issues/comments{/number}","contents_url":"https://api.github.com/repos/nrb/ark/contents/{+path}","compare_url":"https://api.github.com/repos/nrb/ark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nrb/ark/merges","archive_url":"https://api.github.com/repos/nrb/ark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nrb/ark/downloads","issues_url":"https://api.github.com/repos/nrb/ark/issues{/number}","pulls_url":"https://api.github.com/repos/nrb/ark/pulls{/number}","milestones_url":"https://api.github.com/repos/nrb/ark/milestones{/number}","notifications_url":"https://api.github.com/repos/nrb/ark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nrb/ark/labels{/name}","releases_url":"https://api.github.com/repos/nrb/ark/releases{/id}","deployments_url":"https://api.github.com/repos/nrb/ark/deployments","created_at":"2017-10-31T19:51:31Z","updated_at":"2018-08-08T18:53:42Z","pushed_at":"2018-08-17T19:35:17Z","git_url":"git://github.com/nrb/ark.git","ssh_url":"git@github.com:nrb/ark.git","clone_url":"https://github.com/nrb/ark.git","svn_url":"https://github.com/nrb/ark","homepage":"http://www.heptio.com","size":10457,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"heptio:backup-locations","ref":"backup-locations","sha":"d9a0bb0b7ba1f40d566ea1b4d29bbd230e455c07","user":{"login":"heptio","id":22035492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"repo":{"id":99143276,"node_id":"MDEwOlJlcG9zaXRvcnk5OTE0MzI3Ng==","name":"ark","full_name":"heptio/ark","owner":{"login":"heptio","id":22035492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heptio/ark","description":"Heptio Ark is a utility for managing disaster recovery, specifically for your Kubernetes cluster resources and persistent volumes. Brought to you by Heptio.","fork":false,"url":"https://api.github.com/repos/heptio/ark","forks_url":"https://api.github.com/repos/heptio/ark/forks","keys_url":"https://api.github.com/repos/heptio/ark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heptio/ark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heptio/ark/teams","hooks_url":"https://api.github.com/repos/heptio/ark/hooks","issue_events_url":"https://api.github.com/repos/heptio/ark/issues/events{/number}","events_url":"https://api.github.com/repos/heptio/ark/events","assignees_url":"https://api.github.com/repos/heptio/ark/assignees{/user}","branches_url":"https://api.github.com/repos/heptio/ark/branches{/branch}","tags_url":"https://api.github.com/repos/heptio/ark/tags","blobs_url":"https://api.github.com/repos/heptio/ark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heptio/ark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heptio/ark/git/refs{/sha}","trees_url":"https://api.github.com/repos/heptio/ark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heptio/ark/statuses/{sha}","languages_url":"https://api.github.com/repos/heptio/ark/languages","stargazers_url":"https://api.github.com/repos/heptio/ark/stargazers","contributors_url":"https://api.github.com/repos/heptio/ark/contributors","subscribers_url":"https://api.github.com/repos/heptio/ark/subscribers","subscription_url":"https://api.github.com/repos/heptio/ark/subscription","commits_url":"https://api.github.com/repos/heptio/ark/commits{/sha}","git_commits_url":"https://api.github.com/repos/heptio/ark/git/commits{/sha}","comments_url":"https://api.github.com/repos/heptio/ark/comments{/number}","issue_comment_url":"https://api.github.com/repos/heptio/ark/issues/comments{/number}","contents_url":"https://api.github.com/repos/heptio/ark/contents/{+path}","compare_url":"https://api.github.com/repos/heptio/ark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heptio/ark/merges","archive_url":"https://api.github.com/repos/heptio/ark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heptio/ark/downloads","issues_url":"https://api.github.com/repos/heptio/ark/issues{/number}","pulls_url":"https://api.github.com/repos/heptio/ark/pulls{/number}","milestones_url":"https://api.github.com/repos/heptio/ark/milestones{/number}","notifications_url":"https://api.github.com/repos/heptio/ark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heptio/ark/labels{/name}","releases_url":"https://api.github.com/repos/heptio/ark/releases{/id}","deployments_url":"https://api.github.com/repos/heptio/ark/deployments","created_at":"2017-08-02T17:22:11Z","updated_at":"2018-08-17T19:44:56Z","pushed_at":"2018-08-17T19:44:54Z","git_url":"git://github.com/heptio/ark.git","ssh_url":"git@github.com:heptio/ark.git","clone_url":"https://github.com/heptio/ark.git","svn_url":"https://github.com/heptio/ark","homepage":"https://www.heptio.com","size":10494,"stargazers_count":1409,"watchers_count":1409,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":180,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":180,"open_issues":166,"watchers":1409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heptio/ark/pulls/771"},"html":{"href":"https://github.com/heptio/ark/pull/771"},"issue":{"href":"https://api.github.com/repos/heptio/ark/issues/771"},"comments":{"href":"https://api.github.com/repos/heptio/ark/issues/771/comments"},"review_comments":{"href":"https://api.github.com/repos/heptio/ark/pulls/771/comments"},"review_comment":{"href":"https://api.github.com/repos/heptio/ark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heptio/ark/pulls/771/commits"},"statuses":{"href":"https://api.github.com/repos/heptio/ark/statuses/f2199ba8197fb2d3dd18bda6c6686760099716ef"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nrb"}}