{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/5981","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5981/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5981/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5981/events","html_url":"https://github.com/WordPress/gutenberg/issues/5981","id":311364798,"node_id":"MDU6SXNzdWUzMTEzNjQ3OTg=","number":5981,"title":"Review the usage of aria-label on the blocks contenteditable","user":{"login":"afercia","id":1682452,"node_id":"MDQ6VXNlcjE2ODI0NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1682452?v=4","gravatar_id":"","url":"https://api.github.com/users/afercia","html_url":"https://github.com/afercia","followers_url":"https://api.github.com/users/afercia/followers","following_url":"https://api.github.com/users/afercia/following{/other_user}","gists_url":"https://api.github.com/users/afercia/gists{/gist_id}","starred_url":"https://api.github.com/users/afercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afercia/subscriptions","organizations_url":"https://api.github.com/users/afercia/orgs","repos_url":"https://api.github.com/users/afercia/repos","events_url":"https://api.github.com/users/afercia/events{/privacy}","received_events_url":"https://api.github.com/users/afercia/received_events","type":"User","site_admin":false},"labels":[{"id":546517042,"node_id":"MDU6TGFiZWw1NDY1MTcwNDI=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/Accessibility","name":"Accessibility","color":"655104","default":false},{"id":816933178,"node_id":"MDU6TGFiZWw4MTY5MzMxNzg=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/Needs%20Testing","name":"Needs Testing","color":"67dff7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/WordPress/gutenberg/milestones/43","html_url":"https://github.com/WordPress/gutenberg/milestone/43","labels_url":"https://api.github.com/repos/WordPress/gutenberg/milestones/43/labels","id":3260055,"node_id":"MDk6TWlsZXN0b25lMzI2MDA1NQ==","number":43,"title":"Merge Proposal: Accessibility","description":"","creator":{"login":"karmatosed","id":253067,"node_id":"MDQ6VXNlcjI1MzA2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/253067?v=4","gravatar_id":"","url":"https://api.github.com/users/karmatosed","html_url":"https://github.com/karmatosed","followers_url":"https://api.github.com/users/karmatosed/followers","following_url":"https://api.github.com/users/karmatosed/following{/other_user}","gists_url":"https://api.github.com/users/karmatosed/gists{/gist_id}","starred_url":"https://api.github.com/users/karmatosed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karmatosed/subscriptions","organizations_url":"https://api.github.com/users/karmatosed/orgs","repos_url":"https://api.github.com/users/karmatosed/repos","events_url":"https://api.github.com/users/karmatosed/events{/privacy}","received_events_url":"https://api.github.com/users/karmatosed/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":11,"state":"open","created_at":"2018-04-11T20:13:28Z","updated_at":"2018-08-09T06:42:24Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-04-04T19:42:35Z","updated_at":"2018-09-10T14:17:22Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Currently, the various blocks `contenteditable` use an `aria-label` attribute, some examples (with other attributes relevant for aassistive technologies):\r\n\r\n```\r\nparagraph:\r\n\r\n<p aria-label=\"Add text or type / to add content\" role=\"textbox\" contenteditable=\"true\" ...\r\n\r\nlist:\r\n\r\n<ul aria-label=\"Write list…\" aria-multiline=\"true\" contenteditable=\"true\" ...\r\n\r\nquote:\r\n\r\n<div aria-label=\"Write quote…\" aria-multiline=\"true\" role=\"textbox\" contenteditable=\"true\" ...\r\n<p> ...\r\n```\r\n\r\nThough the intent is to give users some instructions or hint about what to type, this is a not proper use of aria-label, as it is supposed to override the element content. I doubt there's any expected behavior about what `aria-label` should do when used on a `contenteditable` element. `contenteditable` is buggy and still greatly inconsistent across browsers and assistive technologies. For example, some screen readers read out the aria-label *and* the `contenteditable` content, some don't.\r\n\r\nRegardless, we shouldn't use `aria-label` this way. We should find a different way to provide users this \"hint\"."},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/419928867","html_url":"https://github.com/WordPress/gutenberg/issues/5981#issuecomment-419928867","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5981","id":419928867,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTkyODg2Nw==","user":{"login":"afercia","id":1682452,"node_id":"MDQ6VXNlcjE2ODI0NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1682452?v=4","gravatar_id":"","url":"https://api.github.com/users/afercia","html_url":"https://github.com/afercia","followers_url":"https://api.github.com/users/afercia/followers","following_url":"https://api.github.com/users/afercia/following{/other_user}","gists_url":"https://api.github.com/users/afercia/gists{/gist_id}","starred_url":"https://api.github.com/users/afercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afercia/subscriptions","organizations_url":"https://api.github.com/users/afercia/orgs","repos_url":"https://api.github.com/users/afercia/repos","events_url":"https://api.github.com/users/afercia/events{/privacy}","received_events_url":"https://api.github.com/users/afercia/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T14:17:22Z","updated_at":"2018-09-10T14:17:22Z","author_association":"CONTRIBUTOR","body":"Removing the Needs Testing label as there's not so much to test. The visible placeholder text is used also as value for the aria-label attribute, also when the contenteditable area has content. This is far from ideal and needs to be changed for assistive technologies users. Will expand later with some proposals."}}
{"actor":{"display_login":"afercia"}}