{"action":"created","comment":{"url":"https://api.github.com/repos/clappr/clappr-android/pulls/comments/235915215","pull_request_review_id":177893556,"id":235915215,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTkxNTIxNQ==","diff_hunk":"@@ -0,0 +1,66 @@\n+package io.clappr.player.app.plugin\n+\n+import android.view.LayoutInflater\n+import android.widget.ImageView\n+import android.widget.LinearLayout\n+import android.widget.RelativeLayout\n+import android.widget.TextView\n+import com.squareup.picasso.Picasso\n+import io.clappr.player.app.R\n+import io.clappr.player.base.*\n+import io.clappr.player.components.Container\n+import io.clappr.player.components.Core\n+import io.clappr.player.plugin.container.UIContainerPlugin\n+import io.clappr.player.plugin.core.UICorePlugin\n+\n+\n+open class PlaybackStatusPlugin(container: Container) : UIContainerPlugin(container) {","path":"app/src/main/kotlin/io/clappr/player/app/plugin/PlaybackStatusPlugin.kt","position":17,"original_position":17,"commit_id":"126d4b2843472391f3dfbd50e711d0d75b886c37","original_commit_id":"126d4b2843472391f3dfbd50e711d0d75b886c37","user":{"login":"UelitonFreitas","id":7853075,"node_id":"MDQ6VXNlcjc4NTMwNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/7853075?v=4","gravatar_id":"","url":"https://api.github.com/users/UelitonFreitas","html_url":"https://github.com/UelitonFreitas","followers_url":"https://api.github.com/users/UelitonFreitas/followers","following_url":"https://api.github.com/users/UelitonFreitas/following{/other_user}","gists_url":"https://api.github.com/users/UelitonFreitas/gists{/gist_id}","starred_url":"https://api.github.com/users/UelitonFreitas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UelitonFreitas/subscriptions","organizations_url":"https://api.github.com/users/UelitonFreitas/orgs","repos_url":"https://api.github.com/users/UelitonFreitas/repos","events_url":"https://api.github.com/users/UelitonFreitas/events{/privacy}","received_events_url":"https://api.github.com/users/UelitonFreitas/received_events","type":"User","site_admin":false},"body":"Hi @pmunizferreira. Why this class need to be open? Can we keep it with default visibility final)?","created_at":"2018-11-23T11:34:59Z","updated_at":"2018-11-23T11:35:07Z","html_url":"https://github.com/clappr/clappr-android/pull/158#discussion_r235915215","pull_request_url":"https://api.github.com/repos/clappr/clappr-android/pulls/158","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/clappr/clappr-android/pulls/comments/235915215"},"html":{"href":"https://github.com/clappr/clappr-android/pull/158#discussion_r235915215"},"pull_request":{"href":"https://api.github.com/repos/clappr/clappr-android/pulls/158"}}},"pull_request":{"url":"https://api.github.com/repos/clappr/clappr-android/pulls/158","id":233059629,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDU5NjI5","html_url":"https://github.com/clappr/clappr-android/pull/158","diff_url":"https://github.com/clappr/clappr-android/pull/158.diff","patch_url":"https://github.com/clappr/clappr-android/pull/158.patch","issue_url":"https://api.github.com/repos/clappr/clappr-android/issues/158","number":158,"state":"open","locked":false,"title":"Feature/sample UIContainerPlugin","user":{"login":"pmunizferreira","id":21111170,"node_id":"MDQ6VXNlcjIxMTExMTcw","avatar_url":"https://avatars0.githubusercontent.com/u/21111170?v=4","gravatar_id":"","url":"https://api.github.com/users/pmunizferreira","html_url":"https://github.com/pmunizferreira","followers_url":"https://api.github.com/users/pmunizferreira/followers","following_url":"https://api.github.com/users/pmunizferreira/following{/other_user}","gists_url":"https://api.github.com/users/pmunizferreira/gists{/gist_id}","starred_url":"https://api.github.com/users/pmunizferreira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmunizferreira/subscriptions","organizations_url":"https://api.github.com/users/pmunizferreira/orgs","repos_url":"https://api.github.com/users/pmunizferreira/repos","events_url":"https://api.github.com/users/pmunizferreira/events{/privacy}","received_events_url":"https://api.github.com/users/pmunizferreira/received_events","type":"User","site_admin":false},"body":"Goal\r\n---\r\nAdd external plugin to Player.\r\n\r\n`PlaybackStatePlugin` is a `UIContainerPlugin` to show status of current playback\r\n \r\nHow to Test\r\n---\r\n- open clappr app\r\n- while loading video, should show `Playback Status: stalling`\r\n- while playing video, should show `Playback Status: playing`\r\n- after pause video, should show `Playback Status: didPause`\r\n- after stop video, should show `Playback Status: didStop`\r\n- after complete video, should show `Playback Status: didComplete`\r\n- after an error, should show `Playback Status: error`","created_at":"2018-11-22T19:09:23Z","updated_at":"2018-11-23T11:35:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c30e11b4956f808e9be283bb79a0ebd9886fc58c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clappr/clappr-android/pulls/158/commits","review_comments_url":"https://api.github.com/repos/clappr/clappr-android/pulls/158/comments","review_comment_url":"https://api.github.com/repos/clappr/clappr-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clappr/clappr-android/issues/158/comments","statuses_url":"https://api.github.com/repos/clappr/clappr-android/statuses/126d4b2843472391f3dfbd50e711d0d75b886c37","head":{"label":"clappr:feature/sample_plugins","ref":"feature/sample_plugins","sha":"126d4b2843472391f3dfbd50e711d0d75b886c37","user":{"login":"clappr","id":10685859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1ODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"repo":{"id":22734795,"node_id":"MDEwOlJlcG9zaXRvcnkyMjczNDc5NQ==","name":"clappr-android","full_name":"clappr/clappr-android","private":false,"owner":{"login":"clappr","id":10685859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1ODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/clappr/clappr-android","description":"An extensible media player for Android.","fork":false,"url":"https://api.github.com/repos/clappr/clappr-android","forks_url":"https://api.github.com/repos/clappr/clappr-android/forks","keys_url":"https://api.github.com/repos/clappr/clappr-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clappr/clappr-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clappr/clappr-android/teams","hooks_url":"https://api.github.com/repos/clappr/clappr-android/hooks","issue_events_url":"https://api.github.com/repos/clappr/clappr-android/issues/events{/number}","events_url":"https://api.github.com/repos/clappr/clappr-android/events","assignees_url":"https://api.github.com/repos/clappr/clappr-android/assignees{/user}","branches_url":"https://api.github.com/repos/clappr/clappr-android/branches{/branch}","tags_url":"https://api.github.com/repos/clappr/clappr-android/tags","blobs_url":"https://api.github.com/repos/clappr/clappr-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clappr/clappr-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clappr/clappr-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/clappr/clappr-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clappr/clappr-android/statuses/{sha}","languages_url":"https://api.github.com/repos/clappr/clappr-android/languages","stargazers_url":"https://api.github.com/repos/clappr/clappr-android/stargazers","contributors_url":"https://api.github.com/repos/clappr/clappr-android/contributors","subscribers_url":"https://api.github.com/repos/clappr/clappr-android/subscribers","subscription_url":"https://api.github.com/repos/clappr/clappr-android/subscription","commits_url":"https://api.github.com/repos/clappr/clappr-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/clappr/clappr-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/clappr/clappr-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/clappr/clappr-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/clappr/clappr-android/contents/{+path}","compare_url":"https://api.github.com/repos/clappr/clappr-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clappr/clappr-android/merges","archive_url":"https://api.github.com/repos/clappr/clappr-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clappr/clappr-android/downloads","issues_url":"https://api.github.com/repos/clappr/clappr-android/issues{/number}","pulls_url":"https://api.github.com/repos/clappr/clappr-android/pulls{/number}","milestones_url":"https://api.github.com/repos/clappr/clappr-android/milestones{/number}","notifications_url":"https://api.github.com/repos/clappr/clappr-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clappr/clappr-android/labels{/name}","releases_url":"https://api.github.com/repos/clappr/clappr-android/releases{/id}","deployments_url":"https://api.github.com/repos/clappr/clappr-android/deployments","created_at":"2014-08-07T20:01:54Z","updated_at":"2018-11-22T18:13:25Z","pushed_at":"2018-11-22T23:08:46Z","git_url":"git://github.com/clappr/clappr-android.git","ssh_url":"git@github.com:clappr/clappr-android.git","clone_url":"https://github.com/clappr/clappr-android.git","svn_url":"https://github.com/clappr/clappr-android","homepage":null,"size":1535,"stargazers_count":50,"watchers_count":50,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":16,"open_issues":7,"watchers":50,"default_branch":"dev"}},"base":{"label":"clappr:dev","ref":"dev","sha":"2b752e4745b7aaf6d65d1df6ad9253ec322b3430","user":{"login":"clappr","id":10685859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1ODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"repo":{"id":22734795,"node_id":"MDEwOlJlcG9zaXRvcnkyMjczNDc5NQ==","name":"clappr-android","full_name":"clappr/clappr-android","private":false,"owner":{"login":"clappr","id":10685859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1ODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/clappr/clappr-android","description":"An extensible media player for Android.","fork":false,"url":"https://api.github.com/repos/clappr/clappr-android","forks_url":"https://api.github.com/repos/clappr/clappr-android/forks","keys_url":"https://api.github.com/repos/clappr/clappr-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clappr/clappr-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clappr/clappr-android/teams","hooks_url":"https://api.github.com/repos/clappr/clappr-android/hooks","issue_events_url":"https://api.github.com/repos/clappr/clappr-android/issues/events{/number}","events_url":"https://api.github.com/repos/clappr/clappr-android/events","assignees_url":"https://api.github.com/repos/clappr/clappr-android/assignees{/user}","branches_url":"https://api.github.com/repos/clappr/clappr-android/branches{/branch}","tags_url":"https://api.github.com/repos/clappr/clappr-android/tags","blobs_url":"https://api.github.com/repos/clappr/clappr-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clappr/clappr-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clappr/clappr-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/clappr/clappr-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clappr/clappr-android/statuses/{sha}","languages_url":"https://api.github.com/repos/clappr/clappr-android/languages","stargazers_url":"https://api.github.com/repos/clappr/clappr-android/stargazers","contributors_url":"https://api.github.com/repos/clappr/clappr-android/contributors","subscribers_url":"https://api.github.com/repos/clappr/clappr-android/subscribers","subscription_url":"https://api.github.com/repos/clappr/clappr-android/subscription","commits_url":"https://api.github.com/repos/clappr/clappr-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/clappr/clappr-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/clappr/clappr-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/clappr/clappr-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/clappr/clappr-android/contents/{+path}","compare_url":"https://api.github.com/repos/clappr/clappr-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clappr/clappr-android/merges","archive_url":"https://api.github.com/repos/clappr/clappr-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clappr/clappr-android/downloads","issues_url":"https://api.github.com/repos/clappr/clappr-android/issues{/number}","pulls_url":"https://api.github.com/repos/clappr/clappr-android/pulls{/number}","milestones_url":"https://api.github.com/repos/clappr/clappr-android/milestones{/number}","notifications_url":"https://api.github.com/repos/clappr/clappr-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clappr/clappr-android/labels{/name}","releases_url":"https://api.github.com/repos/clappr/clappr-android/releases{/id}","deployments_url":"https://api.github.com/repos/clappr/clappr-android/deployments","created_at":"2014-08-07T20:01:54Z","updated_at":"2018-11-22T18:13:25Z","pushed_at":"2018-11-22T23:08:46Z","git_url":"git://github.com/clappr/clappr-android.git","ssh_url":"git@github.com:clappr/clappr-android.git","clone_url":"https://github.com/clappr/clappr-android.git","svn_url":"https://github.com/clappr/clappr-android","homepage":null,"size":1535,"stargazers_count":50,"watchers_count":50,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":16,"open_issues":7,"watchers":50,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/clappr/clappr-android/pulls/158"},"html":{"href":"https://github.com/clappr/clappr-android/pull/158"},"issue":{"href":"https://api.github.com/repos/clappr/clappr-android/issues/158"},"comments":{"href":"https://api.github.com/repos/clappr/clappr-android/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/clappr/clappr-android/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/clappr/clappr-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clappr/clappr-android/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/clappr/clappr-android/statuses/126d4b2843472391f3dfbd50e711d0d75b886c37"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"UelitonFreitas"}}