{"action":"created","comment":{"url":"https://api.github.com/repos/rancher/types/pulls/comments/237597601","pull_request_review_id":179936827,"id":237597601,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzU5NzYwMQ==","diff_hunk":"@@ -52,6 +54,7 @@ type ProjectSpec struct {\n \tClusterName                   string                  `json:\"clusterName,omitempty\" norman:\"required,type=reference[cluster]\"`\n \tResourceQuota                 *ProjectResourceQuota   `json:\"resourceQuota,omitempty\"`\n \tNamespaceDefaultResourceQuota *NamespaceResourceQuota `json:\"namespaceDefaultResourceQuota,omitempty\"`\n+\tEnableProjectMonitoring       *bool                   `json:\"enableProjectMonitoring\" norman:\"default=false\"`","path":"apis/management.cattle.io/v3/authz_types.go","position":29,"original_position":20,"commit_id":"d03ed7d91baf5ed154f83cc8eb2a7fcb0042590c","original_commit_id":"c4371b56be4da5970860bfca30f78dc64d1db51a","user":{"login":"cjellick","id":2473240,"node_id":"MDQ6VXNlcjI0NzMyNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2473240?v=4","gravatar_id":"","url":"https://api.github.com/users/cjellick","html_url":"https://github.com/cjellick","followers_url":"https://api.github.com/users/cjellick/followers","following_url":"https://api.github.com/users/cjellick/following{/other_user}","gists_url":"https://api.github.com/users/cjellick/gists{/gist_id}","starred_url":"https://api.github.com/users/cjellick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjellick/subscriptions","organizations_url":"https://api.github.com/users/cjellick/orgs","repos_url":"https://api.github.com/users/cjellick/repos","events_url":"https://api.github.com/users/cjellick/events{/privacy}","received_events_url":"https://api.github.com/users/cjellick/received_events","type":"User","site_admin":false},"body":"We only do pointer bools when we _need_ to. That generally is to support backwards compatibility and upgrade scenarios. If it doesn't have a functional need to be a pointer, it shouldn't be.","created_at":"2018-11-29T18:05:59Z","updated_at":"2018-11-29T18:06:00Z","html_url":"https://github.com/rancher/types/pull/636#discussion_r237597601","pull_request_url":"https://api.github.com/repos/rancher/types/pulls/636","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rancher/types/pulls/comments/237597601"},"html":{"href":"https://github.com/rancher/types/pull/636#discussion_r237597601"},"pull_request":{"href":"https://api.github.com/repos/rancher/types/pulls/636"}},"in_reply_to_id":237269509},"pull_request":{"url":"https://api.github.com/repos/rancher/types/pulls/636","id":234373683,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzczNjgz","html_url":"https://github.com/rancher/types/pull/636","diff_url":"https://github.com/rancher/types/pull/636.diff","patch_url":"https://github.com/rancher/types/pull/636.patch","issue_url":"https://api.github.com/repos/rancher/types/issues/636","number":636,"state":"open","locked":false,"title":"Rancher Monitoring Support","user":{"login":"orangedeng","id":15376837,"node_id":"MDQ6VXNlcjE1Mzc2ODM3","avatar_url":"https://avatars1.githubusercontent.com/u/15376837?v=4","gravatar_id":"","url":"https://api.github.com/users/orangedeng","html_url":"https://github.com/orangedeng","followers_url":"https://api.github.com/users/orangedeng/followers","following_url":"https://api.github.com/users/orangedeng/following{/other_user}","gists_url":"https://api.github.com/users/orangedeng/gists{/gist_id}","starred_url":"https://api.github.com/users/orangedeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangedeng/subscriptions","organizations_url":"https://api.github.com/users/orangedeng/orgs","repos_url":"https://api.github.com/users/orangedeng/repos","events_url":"https://api.github.com/users/orangedeng/events{/privacy}","received_events_url":"https://api.github.com/users/orangedeng/received_events","type":"User","site_admin":false},"body":"Related Issue: https://github.com/rancher/rancher/issues/14230\r\nRelated PR: https://github.com/rancher/types/pull/629\r\n\r\nThis is a PR for rancher monitoring support. Summaries are follow:\r\n1. Support prometheus crds in Rancher API.\r\n2. Adding new kind of Alert feature that supports grouping alert rules.\r\n3. Enable and disable cluster and project monitoring.\r\n4. Support monitoring metrics graph.\r\n5. Support prometheus to collect workload metrics with operator","created_at":"2018-11-28T18:04:27Z","updated_at":"2018-11-29T18:06:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a634650f0dc5b25f6cb66b9a9404f26dd19c5ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rancher/types/pulls/636/commits","review_comments_url":"https://api.github.com/repos/rancher/types/pulls/636/comments","review_comment_url":"https://api.github.com/repos/rancher/types/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/types/issues/636/comments","statuses_url":"https://api.github.com/repos/rancher/types/statuses/d03ed7d91baf5ed154f83cc8eb2a7fcb0042590c","head":{"label":"aiwantaozi:pr-branch","ref":"pr-branch","sha":"d03ed7d91baf5ed154f83cc8eb2a7fcb0042590c","user":{"login":"aiwantaozi","id":5936271,"node_id":"MDQ6VXNlcjU5MzYyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/5936271?v=4","gravatar_id":"","url":"https://api.github.com/users/aiwantaozi","html_url":"https://github.com/aiwantaozi","followers_url":"https://api.github.com/users/aiwantaozi/followers","following_url":"https://api.github.com/users/aiwantaozi/following{/other_user}","gists_url":"https://api.github.com/users/aiwantaozi/gists{/gist_id}","starred_url":"https://api.github.com/users/aiwantaozi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiwantaozi/subscriptions","organizations_url":"https://api.github.com/users/aiwantaozi/orgs","repos_url":"https://api.github.com/users/aiwantaozi/repos","events_url":"https://api.github.com/users/aiwantaozi/events{/privacy}","received_events_url":"https://api.github.com/users/aiwantaozi/received_events","type":"User","site_admin":false},"repo":{"id":118013552,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgwMTM1NTI=","name":"types","full_name":"aiwantaozi/types","private":false,"owner":{"login":"aiwantaozi","id":5936271,"node_id":"MDQ6VXNlcjU5MzYyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/5936271?v=4","gravatar_id":"","url":"https://api.github.com/users/aiwantaozi","html_url":"https://github.com/aiwantaozi","followers_url":"https://api.github.com/users/aiwantaozi/followers","following_url":"https://api.github.com/users/aiwantaozi/following{/other_user}","gists_url":"https://api.github.com/users/aiwantaozi/gists{/gist_id}","starred_url":"https://api.github.com/users/aiwantaozi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiwantaozi/subscriptions","organizations_url":"https://api.github.com/users/aiwantaozi/orgs","repos_url":"https://api.github.com/users/aiwantaozi/repos","events_url":"https://api.github.com/users/aiwantaozi/events{/privacy}","received_events_url":"https://api.github.com/users/aiwantaozi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aiwantaozi/types","description":"Rancher API types","fork":true,"url":"https://api.github.com/repos/aiwantaozi/types","forks_url":"https://api.github.com/repos/aiwantaozi/types/forks","keys_url":"https://api.github.com/repos/aiwantaozi/types/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aiwantaozi/types/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aiwantaozi/types/teams","hooks_url":"https://api.github.com/repos/aiwantaozi/types/hooks","issue_events_url":"https://api.github.com/repos/aiwantaozi/types/issues/events{/number}","events_url":"https://api.github.com/repos/aiwantaozi/types/events","assignees_url":"https://api.github.com/repos/aiwantaozi/types/assignees{/user}","branches_url":"https://api.github.com/repos/aiwantaozi/types/branches{/branch}","tags_url":"https://api.github.com/repos/aiwantaozi/types/tags","blobs_url":"https://api.github.com/repos/aiwantaozi/types/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aiwantaozi/types/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aiwantaozi/types/git/refs{/sha}","trees_url":"https://api.github.com/repos/aiwantaozi/types/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aiwantaozi/types/statuses/{sha}","languages_url":"https://api.github.com/repos/aiwantaozi/types/languages","stargazers_url":"https://api.github.com/repos/aiwantaozi/types/stargazers","contributors_url":"https://api.github.com/repos/aiwantaozi/types/contributors","subscribers_url":"https://api.github.com/repos/aiwantaozi/types/subscribers","subscription_url":"https://api.github.com/repos/aiwantaozi/types/subscription","commits_url":"https://api.github.com/repos/aiwantaozi/types/commits{/sha}","git_commits_url":"https://api.github.com/repos/aiwantaozi/types/git/commits{/sha}","comments_url":"https://api.github.com/repos/aiwantaozi/types/comments{/number}","issue_comment_url":"https://api.github.com/repos/aiwantaozi/types/issues/comments{/number}","contents_url":"https://api.github.com/repos/aiwantaozi/types/contents/{+path}","compare_url":"https://api.github.com/repos/aiwantaozi/types/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aiwantaozi/types/merges","archive_url":"https://api.github.com/repos/aiwantaozi/types/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aiwantaozi/types/downloads","issues_url":"https://api.github.com/repos/aiwantaozi/types/issues{/number}","pulls_url":"https://api.github.com/repos/aiwantaozi/types/pulls{/number}","milestones_url":"https://api.github.com/repos/aiwantaozi/types/milestones{/number}","notifications_url":"https://api.github.com/repos/aiwantaozi/types/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aiwantaozi/types/labels{/name}","releases_url":"https://api.github.com/repos/aiwantaozi/types/releases{/id}","deployments_url":"https://api.github.com/repos/aiwantaozi/types/deployments","created_at":"2018-01-18T17:13:39Z","updated_at":"2018-01-18T17:13:41Z","pushed_at":"2018-11-29T16:26:25Z","git_url":"git://github.com/aiwantaozi/types.git","ssh_url":"git@github.com:aiwantaozi/types.git","clone_url":"https://github.com/aiwantaozi/types.git","svn_url":"https://github.com/aiwantaozi/types","homepage":null,"size":8651,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancher:master","ref":"master","sha":"5ca2348448aadb7845f3c4ceb9242c25085ae85e","user":{"login":"rancher","id":9343010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNDMwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":110289036,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAyODkwMzY=","name":"types","full_name":"rancher/types","private":false,"owner":{"login":"rancher","id":9343010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNDMwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rancher/types","description":"Rancher API types","fork":false,"url":"https://api.github.com/repos/rancher/types","forks_url":"https://api.github.com/repos/rancher/types/forks","keys_url":"https://api.github.com/repos/rancher/types/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/types/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/types/teams","hooks_url":"https://api.github.com/repos/rancher/types/hooks","issue_events_url":"https://api.github.com/repos/rancher/types/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/types/events","assignees_url":"https://api.github.com/repos/rancher/types/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/types/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/types/tags","blobs_url":"https://api.github.com/repos/rancher/types/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/types/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/types/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/types/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/types/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/types/languages","stargazers_url":"https://api.github.com/repos/rancher/types/stargazers","contributors_url":"https://api.github.com/repos/rancher/types/contributors","subscribers_url":"https://api.github.com/repos/rancher/types/subscribers","subscription_url":"https://api.github.com/repos/rancher/types/subscription","commits_url":"https://api.github.com/repos/rancher/types/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/types/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/types/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/types/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/types/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/types/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/types/merges","archive_url":"https://api.github.com/repos/rancher/types/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/types/downloads","issues_url":"https://api.github.com/repos/rancher/types/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/types/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/types/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/types/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/types/labels{/name}","releases_url":"https://api.github.com/repos/rancher/types/releases{/id}","deployments_url":"https://api.github.com/repos/rancher/types/deployments","created_at":"2017-11-10T20:21:19Z","updated_at":"2018-11-29T17:12:38Z","pushed_at":"2018-11-29T17:37:26Z","git_url":"git://github.com/rancher/types.git","ssh_url":"git@github.com:rancher/types.git","clone_url":"https://github.com/rancher/types.git","svn_url":"https://github.com/rancher/types","homepage":null,"size":8063,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":53,"open_issues":19,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/types/pulls/636"},"html":{"href":"https://github.com/rancher/types/pull/636"},"issue":{"href":"https://api.github.com/repos/rancher/types/issues/636"},"comments":{"href":"https://api.github.com/repos/rancher/types/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/types/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/types/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/types/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/types/statuses/d03ed7d91baf5ed154f83cc8eb2a7fcb0042590c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cjellick"}}