{"action":"created","comment":{"url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls/comments/176734519","pull_request_review_id":106492131,"id":176734519,"diff_hunk":"@@ -39,18 +50,19 @@ public function __construct(Container $container, $path = null)\n \n     /**\n      * Returns an array in the form of var association:\n-     * list($controller, $request, $view) = self::getEverytihngFromArgs($args);\n-     *\n-     * @param $args\n+     * list($controller, $request, $view) = self::getEverythingFromArgs($args);\n      *\n-     * @return array\n+     * @param \\Enlight_Event_EventArgs $args\n+     * @param null $element\n+     * @return array|mixed|null\n      */\n-    final public static function getEverytihngFromArgs ($args)\n+    final public static function getEverythingFromArgs(\\Enlight_Event_EventArgs $args, $element = null)\n     {\n         /**\n          * @var \\Enlight_Controller_Action $controller\n          */\n-        $controller = $args->getSubject();\n+        $controller = $args->get('subject');","path":"Subscriber/AbstractSubscriber.php","position":51,"original_position":51,"commit_id":"3d3c0e7f7e8c5e322a9d162b8f1a6ae23c2e992d","original_commit_id":"3d3c0e7f7e8c5e322a9d162b8f1a6ae23c2e992d","user":{"login":"bmalpham8","id":37625286,"avatar_url":"https://avatars2.githubusercontent.com/u/37625286?v=4","gravatar_id":"","url":"https://api.github.com/users/bmalpham8","html_url":"https://github.com/bmalpham8","followers_url":"https://api.github.com/users/bmalpham8/followers","following_url":"https://api.github.com/users/bmalpham8/following{/other_user}","gists_url":"https://api.github.com/users/bmalpham8/gists{/gist_id}","starred_url":"https://api.github.com/users/bmalpham8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmalpham8/subscriptions","organizations_url":"https://api.github.com/users/bmalpham8/orgs","repos_url":"https://api.github.com/users/bmalpham8/repos","events_url":"https://api.github.com/users/bmalpham8/events{/privacy}","received_events_url":"https://api.github.com/users/bmalpham8/received_events","type":"User","site_admin":false},"body":"Not necessary, since both calls work. My version uses the magic __call method on that class. If this is ok for you, please leave this line unchanged.","created_at":"2018-03-23T13:32:35Z","updated_at":"2018-03-23T13:32:35Z","html_url":"https://github.com/bmalpham8/shopware-hybrid-auth/pull/1#discussion_r176734519","pull_request_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls/comments/176734519"},"html":{"href":"https://github.com/bmalpham8/shopware-hybrid-auth/pull/1#discussion_r176734519"},"pull_request":{"href":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls/1","id":177032437,"html_url":"https://github.com/bmalpham8/shopware-hybrid-auth/pull/1","diff_url":"https://github.com/bmalpham8/shopware-hybrid-auth/pull/1.diff","patch_url":"https://github.com/bmalpham8/shopware-hybrid-auth/pull/1.patch","issue_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/issues/1","number":1,"state":"open","locked":false,"title":"Additional clean-ups and refactorings of pull request","user":{"login":"EvilBMP","id":540478,"avatar_url":"https://avatars1.githubusercontent.com/u/540478?v=4","gravatar_id":"","url":"https://api.github.com/users/EvilBMP","html_url":"https://github.com/EvilBMP","followers_url":"https://api.github.com/users/EvilBMP/followers","following_url":"https://api.github.com/users/EvilBMP/following{/other_user}","gists_url":"https://api.github.com/users/EvilBMP/gists{/gist_id}","starred_url":"https://api.github.com/users/EvilBMP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvilBMP/subscriptions","organizations_url":"https://api.github.com/users/EvilBMP/orgs","repos_url":"https://api.github.com/users/EvilBMP/repos","events_url":"https://api.github.com/users/EvilBMP/events{/privacy}","received_events_url":"https://api.github.com/users/EvilBMP/received_events","type":"User","site_admin":false},"body":"Thank you very much for your contribution. I just wanted to push things a little bit further for all the other classes and corrected some typos etc. in your code. Could you please test the changes in your mentioned shop system?\r\n\r\nFYI: Our acceptance tests for Facebook, Google and LinkedIn are all green.","created_at":"2018-03-23T10:45:32Z","updated_at":"2018-03-23T13:32:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b6bc0fc639ca659a153233f86f1b4803de82cdf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls/1/commits","review_comments_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls/1/comments","review_comment_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/issues/1/comments","statuses_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/statuses/3d3c0e7f7e8c5e322a9d162b8f1a6ae23c2e992d","head":{"label":"portrino:several-fixes","ref":"several-fixes","sha":"3d3c0e7f7e8c5e322a9d162b8f1a6ae23c2e992d","user":{"login":"portrino","id":11866689,"avatar_url":"https://avatars0.githubusercontent.com/u/11866689?v=4","gravatar_id":"","url":"https://api.github.com/users/portrino","html_url":"https://github.com/portrino","followers_url":"https://api.github.com/users/portrino/followers","following_url":"https://api.github.com/users/portrino/following{/other_user}","gists_url":"https://api.github.com/users/portrino/gists{/gist_id}","starred_url":"https://api.github.com/users/portrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portrino/subscriptions","organizations_url":"https://api.github.com/users/portrino/orgs","repos_url":"https://api.github.com/users/portrino/repos","events_url":"https://api.github.com/users/portrino/events{/privacy}","received_events_url":"https://api.github.com/users/portrino/received_events","type":"Organization","site_admin":false},"repo":{"id":110731474,"name":"shopware-hybrid-auth","full_name":"portrino/shopware-hybrid-auth","owner":{"login":"portrino","id":11866689,"avatar_url":"https://avatars0.githubusercontent.com/u/11866689?v=4","gravatar_id":"","url":"https://api.github.com/users/portrino","html_url":"https://github.com/portrino","followers_url":"https://api.github.com/users/portrino/followers","following_url":"https://api.github.com/users/portrino/following{/other_user}","gists_url":"https://api.github.com/users/portrino/gists{/gist_id}","starred_url":"https://api.github.com/users/portrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portrino/subscriptions","organizations_url":"https://api.github.com/users/portrino/orgs","repos_url":"https://api.github.com/users/portrino/repos","events_url":"https://api.github.com/users/portrino/events{/privacy}","received_events_url":"https://api.github.com/users/portrino/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/portrino/shopware-hybrid-auth","description":"Shopware Plugin for Social Login via Facebook, Google, ...","fork":false,"url":"https://api.github.com/repos/portrino/shopware-hybrid-auth","forks_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/forks","keys_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/teams","hooks_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/hooks","issue_events_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/issues/events{/number}","events_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/events","assignees_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/assignees{/user}","branches_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/branches{/branch}","tags_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/tags","blobs_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/languages","stargazers_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/stargazers","contributors_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/contributors","subscribers_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/subscribers","subscription_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/subscription","commits_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/contents/{+path}","compare_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/merges","archive_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/downloads","issues_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/issues{/number}","pulls_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/labels{/name}","releases_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/releases{/id}","deployments_url":"https://api.github.com/repos/portrino/shopware-hybrid-auth/deployments","created_at":"2017-11-14T18:55:45Z","updated_at":"2018-03-13T16:19:22Z","pushed_at":"2018-03-23T10:39:07Z","git_url":"git://github.com/portrino/shopware-hybrid-auth.git","ssh_url":"git@github.com:portrino/shopware-hybrid-auth.git","clone_url":"https://github.com/portrino/shopware-hybrid-auth.git","svn_url":"https://github.com/portrino/shopware-hybrid-auth","homepage":"","size":1459,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"bmalpham8:several-fixes","ref":"several-fixes","sha":"36dd469afb38a198a2fa005e67eac4d6f35dcd9b","user":{"login":"bmalpham8","id":37625286,"avatar_url":"https://avatars2.githubusercontent.com/u/37625286?v=4","gravatar_id":"","url":"https://api.github.com/users/bmalpham8","html_url":"https://github.com/bmalpham8","followers_url":"https://api.github.com/users/bmalpham8/followers","following_url":"https://api.github.com/users/bmalpham8/following{/other_user}","gists_url":"https://api.github.com/users/bmalpham8/gists{/gist_id}","starred_url":"https://api.github.com/users/bmalpham8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmalpham8/subscriptions","organizations_url":"https://api.github.com/users/bmalpham8/orgs","repos_url":"https://api.github.com/users/bmalpham8/repos","events_url":"https://api.github.com/users/bmalpham8/events{/privacy}","received_events_url":"https://api.github.com/users/bmalpham8/received_events","type":"User","site_admin":false},"repo":{"id":126186642,"name":"shopware-hybrid-auth","full_name":"bmalpham8/shopware-hybrid-auth","owner":{"login":"bmalpham8","id":37625286,"avatar_url":"https://avatars2.githubusercontent.com/u/37625286?v=4","gravatar_id":"","url":"https://api.github.com/users/bmalpham8","html_url":"https://github.com/bmalpham8","followers_url":"https://api.github.com/users/bmalpham8/followers","following_url":"https://api.github.com/users/bmalpham8/following{/other_user}","gists_url":"https://api.github.com/users/bmalpham8/gists{/gist_id}","starred_url":"https://api.github.com/users/bmalpham8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmalpham8/subscriptions","organizations_url":"https://api.github.com/users/bmalpham8/orgs","repos_url":"https://api.github.com/users/bmalpham8/repos","events_url":"https://api.github.com/users/bmalpham8/events{/privacy}","received_events_url":"https://api.github.com/users/bmalpham8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmalpham8/shopware-hybrid-auth","description":"Shopware Plugin for Social Login via Facebook, Google, ...","fork":true,"url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth","forks_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/forks","keys_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/teams","hooks_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/hooks","issue_events_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/issues/events{/number}","events_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/events","assignees_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/assignees{/user}","branches_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/branches{/branch}","tags_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/tags","blobs_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/languages","stargazers_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/stargazers","contributors_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/contributors","subscribers_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/subscribers","subscription_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/subscription","commits_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/contents/{+path}","compare_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/merges","archive_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/downloads","issues_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/issues{/number}","pulls_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/labels{/name}","releases_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/releases{/id}","deployments_url":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/deployments","created_at":"2018-03-21T13:55:10Z","updated_at":"2018-03-21T13:55:12Z","pushed_at":"2018-03-23T12:25:20Z","git_url":"git://github.com/bmalpham8/shopware-hybrid-auth.git","ssh_url":"git@github.com:bmalpham8/shopware-hybrid-auth.git","clone_url":"https://github.com/bmalpham8/shopware-hybrid-auth.git","svn_url":"https://github.com/bmalpham8/shopware-hybrid-auth","homepage":"","size":1455,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls/1"},"html":{"href":"https://github.com/bmalpham8/shopware-hybrid-auth/pull/1"},"issue":{"href":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/issues/1"},"comments":{"href":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/bmalpham8/shopware-hybrid-auth/statuses/3d3c0e7f7e8c5e322a9d162b8f1a6ae23c2e992d"}},"author_association":"NONE"}}
{"actor":{"display_login":"bmalpham8"}}