{"action":"created","issue":{"url":"https://api.github.com/repos/clulab/eidos/issues/466","repository_url":"https://api.github.com/repos/clulab/eidos","labels_url":"https://api.github.com/repos/clulab/eidos/issues/466/labels{/name}","comments_url":"https://api.github.com/repos/clulab/eidos/issues/466/comments","events_url":"https://api.github.com/repos/clulab/eidos/issues/466/events","html_url":"https://github.com/clulab/eidos/pull/466","id":368950427,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMDA0ODM1","number":466,"title":"Neg handler","user":{"login":"bsharpataz","id":5384073,"node_id":"MDQ6VXNlcjUzODQwNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5384073?v=4","gravatar_id":"","url":"https://api.github.com/users/bsharpataz","html_url":"https://github.com/bsharpataz","followers_url":"https://api.github.com/users/bsharpataz/followers","following_url":"https://api.github.com/users/bsharpataz/following{/other_user}","gists_url":"https://api.github.com/users/bsharpataz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsharpataz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsharpataz/subscriptions","organizations_url":"https://api.github.com/users/bsharpataz/orgs","repos_url":"https://api.github.com/users/bsharpataz/repos","events_url":"https://api.github.com/users/bsharpataz/events{/privacy}","received_events_url":"https://api.github.com/users/bsharpataz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-11T04:41:32Z","updated_at":"2018-10-12T21:28:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/clulab/eidos/pulls/466","html_url":"https://github.com/clulab/eidos/pull/466","diff_url":"https://github.com/clulab/eidos/pull/466.diff","patch_url":"https://github.com/clulab/eidos/pull/466.patch"},"body":"Converted negationhandler to a class, currently not super lexical so I didn't make a resource file, though one could certainly be added.  However, the class is initialized with the language from the eidos.conf so lang specific implementations can (and should!) be implemented...\r\n\r\nFYI @gcgbarbosa !"},"comment":{"url":"https://api.github.com/repos/clulab/eidos/issues/comments/429467562","html_url":"https://github.com/clulab/eidos/pull/466#issuecomment-429467562","issue_url":"https://api.github.com/repos/clulab/eidos/issues/466","id":429467562,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTQ2NzU2Mg==","user":{"login":"bsharpataz","id":5384073,"node_id":"MDQ6VXNlcjUzODQwNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5384073?v=4","gravatar_id":"","url":"https://api.github.com/users/bsharpataz","html_url":"https://github.com/bsharpataz","followers_url":"https://api.github.com/users/bsharpataz/followers","following_url":"https://api.github.com/users/bsharpataz/following{/other_user}","gists_url":"https://api.github.com/users/bsharpataz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsharpataz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsharpataz/subscriptions","organizations_url":"https://api.github.com/users/bsharpataz/orgs","repos_url":"https://api.github.com/users/bsharpataz/repos","events_url":"https://api.github.com/users/bsharpataz/events{/privacy}","received_events_url":"https://api.github.com/users/bsharpataz/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T21:28:09Z","updated_at":"2018-10-12T21:28:09Z","author_association":"CONTRIBUTOR","body":"> That's a great idea passing the language to the NegationHandler. Depending on how that develops, the companion object may want to take that language and create an EnglishNegationHandler or PortugueseNegationHandler, each derived from an AgnosticNegationHandler to take care of common tasks. There is hopefully only one match statement necessary.\r\n\r\n@kwalcock can i leave for future PRs when we see how much of the code in the English one is re-usable for the Portuguese (i.e. what can be shared vs language specific?)"}}
{"actor":{"display_login":"bsharpataz"}}