{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/pulls/2","id":232147775,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTQ3Nzc1","html_url":"https://github.com/jonathanheaden/reviewing-a-pull-request/pull/2","diff_url":"https://github.com/jonathanheaden/reviewing-a-pull-request/pull/2.diff","patch_url":"https://github.com/jonathanheaden/reviewing-a-pull-request/pull/2.patch","issue_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/issues/2","number":2,"state":"open","locked":false,"title":"Update Game Instructions","user":{"login":"github-learning-lab[bot]","id":37936606,"node_id":"MDM6Qm90Mzc5MzY2MDY=","avatar_url":"https://avatars0.githubusercontent.com/in/10572?v=4","gravatar_id":"","url":"https://api.github.com/users/github-learning-lab%5Bbot%5D","html_url":"https://github.com/apps/github-learning-lab","followers_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/followers","following_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/repos","events_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"# Commenting on Pull Requests\n\nAs a collaborator on a repository, you will get and give pull request reviews before merging code. This is important! It ensures quality code and maintains momentum of changes to your project.\n\nAs you can see, I've opened this pull request and requested you as a reviewer. Pull requests are places to _share_ the changes made to the repository.\n\n### Responsibilities of a reviewer\n\nAs a pull request reviewer, your role is to help the pull request author (thats me!) by making sure:\n\n- Code destined for production is of the highest quality\n- Intentional shortcuts (technical debt) are commented on and confirmed\n- The greater team is aware of potential risks associated with changes\n\nThese broad responsibilities can include more specific goals, like:\n\n- Pointing out potential issues in code quality, security, or business logic\n- Suggesting other reviewers to the author, when warranted\n- Commenting on, approving, or requesting changes on the PR\n- Providing suggestions for alternate or better implementation details\n\nSome repositories use a [CODEOWNERS](https://help.github.com/articles/about-codeowners/) file. The `CODEOWNERS` file assigns responsibility for certain parts of the code to specific individuals or teams. When the `CODEOWNERS` feature is enabled, only the code owner has the final authority to approve the pull request. Your review may not be a formal approval, but it does show confidence.\n\n## Step 2: Communicate in pull requests\n\nWhen an approval or request for changes is not yet needed, consider using **comments**. Comments enable you to inquire about the proposed change early in the review process. You don't need to wait until something is complete to make suggestions.\n\n### :keyboard: Activity: Comment on my pull request\n\n1. On the pull request, click **Files changed**\n1. Hover over the line of code where you'd like to add a comment, and click the blue comment icon\n1. In the comment window, type a question or leave a more general comment\n1. When you're done, click **Add single comment**\n\n<hr>\n<h3 align=\"center\">Return to this pull request for my next comment</h3>\n\n> _Sometimes I respond too fast for the page to update! If you perform an expected action and don't see a response, wait a few seconds and refresh the page for your next steps._\n","created_at":"2018-11-19T23:43:08Z","updated_at":"2018-11-19T23:43:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/pulls/2/commits","review_comments_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/pulls/2/comments","review_comment_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/issues/2/comments","statuses_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/statuses/1aeb503d3a584d1c5de7bdf31f979e64be495f69","head":{"label":"jonathanheaden:game-instructions","ref":"game-instructions","sha":"1aeb503d3a584d1c5de7bdf31f979e64be495f69","user":{"login":"jonathanheaden","id":6761609,"node_id":"MDQ6VXNlcjY3NjE2MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6761609?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanheaden","html_url":"https://github.com/jonathanheaden","followers_url":"https://api.github.com/users/jonathanheaden/followers","following_url":"https://api.github.com/users/jonathanheaden/following{/other_user}","gists_url":"https://api.github.com/users/jonathanheaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanheaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanheaden/subscriptions","organizations_url":"https://api.github.com/users/jonathanheaden/orgs","repos_url":"https://api.github.com/users/jonathanheaden/repos","events_url":"https://api.github.com/users/jonathanheaden/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanheaden/received_events","type":"User","site_admin":false},"repo":{"id":158304431,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgzMDQ0MzE=","name":"reviewing-a-pull-request","full_name":"jonathanheaden/reviewing-a-pull-request","private":false,"owner":{"login":"jonathanheaden","id":6761609,"node_id":"MDQ6VXNlcjY3NjE2MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6761609?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanheaden","html_url":"https://github.com/jonathanheaden","followers_url":"https://api.github.com/users/jonathanheaden/followers","following_url":"https://api.github.com/users/jonathanheaden/following{/other_user}","gists_url":"https://api.github.com/users/jonathanheaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanheaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanheaden/subscriptions","organizations_url":"https://api.github.com/users/jonathanheaden/orgs","repos_url":"https://api.github.com/users/jonathanheaden/repos","events_url":"https://api.github.com/users/jonathanheaden/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanheaden/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jonathanheaden/reviewing-a-pull-request","description":null,"fork":false,"url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request","forks_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/forks","keys_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/teams","hooks_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/hooks","issue_events_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/issues/events{/number}","events_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/events","assignees_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/assignees{/user}","branches_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/branches{/branch}","tags_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/tags","blobs_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/statuses/{sha}","languages_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/languages","stargazers_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/stargazers","contributors_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/contributors","subscribers_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/subscribers","subscription_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/subscription","commits_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/contents/{+path}","compare_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/merges","archive_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/downloads","issues_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/issues{/number}","pulls_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/pulls{/number}","milestones_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/milestones{/number}","notifications_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/labels{/name}","releases_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/releases{/id}","deployments_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/deployments","created_at":"2018-11-19T23:42:52Z","updated_at":"2018-11-19T23:42:58Z","pushed_at":"2018-11-19T23:42:55Z","git_url":"git://github.com/jonathanheaden/reviewing-a-pull-request.git","ssh_url":"git@github.com:jonathanheaden/reviewing-a-pull-request.git","clone_url":"https://github.com/jonathanheaden/reviewing-a-pull-request.git","svn_url":"https://github.com/jonathanheaden/reviewing-a-pull-request","homepage":"https://lab.github.com/githubtraining/reviewing-pull-requests","size":0,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"jonathanheaden:master","ref":"master","sha":"6aa3c3d28fb57d449777ca57dcfaa92c05d1bb7b","user":{"login":"jonathanheaden","id":6761609,"node_id":"MDQ6VXNlcjY3NjE2MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6761609?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanheaden","html_url":"https://github.com/jonathanheaden","followers_url":"https://api.github.com/users/jonathanheaden/followers","following_url":"https://api.github.com/users/jonathanheaden/following{/other_user}","gists_url":"https://api.github.com/users/jonathanheaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanheaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanheaden/subscriptions","organizations_url":"https://api.github.com/users/jonathanheaden/orgs","repos_url":"https://api.github.com/users/jonathanheaden/repos","events_url":"https://api.github.com/users/jonathanheaden/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanheaden/received_events","type":"User","site_admin":false},"repo":{"id":158304431,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgzMDQ0MzE=","name":"reviewing-a-pull-request","full_name":"jonathanheaden/reviewing-a-pull-request","private":false,"owner":{"login":"jonathanheaden","id":6761609,"node_id":"MDQ6VXNlcjY3NjE2MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6761609?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanheaden","html_url":"https://github.com/jonathanheaden","followers_url":"https://api.github.com/users/jonathanheaden/followers","following_url":"https://api.github.com/users/jonathanheaden/following{/other_user}","gists_url":"https://api.github.com/users/jonathanheaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanheaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanheaden/subscriptions","organizations_url":"https://api.github.com/users/jonathanheaden/orgs","repos_url":"https://api.github.com/users/jonathanheaden/repos","events_url":"https://api.github.com/users/jonathanheaden/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanheaden/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jonathanheaden/reviewing-a-pull-request","description":null,"fork":false,"url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request","forks_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/forks","keys_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/teams","hooks_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/hooks","issue_events_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/issues/events{/number}","events_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/events","assignees_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/assignees{/user}","branches_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/branches{/branch}","tags_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/tags","blobs_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/statuses/{sha}","languages_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/languages","stargazers_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/stargazers","contributors_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/contributors","subscribers_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/subscribers","subscription_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/subscription","commits_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/contents/{+path}","compare_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/merges","archive_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/downloads","issues_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/issues{/number}","pulls_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/pulls{/number}","milestones_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/milestones{/number}","notifications_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/labels{/name}","releases_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/releases{/id}","deployments_url":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/deployments","created_at":"2018-11-19T23:42:52Z","updated_at":"2018-11-19T23:42:58Z","pushed_at":"2018-11-19T23:42:55Z","git_url":"git://github.com/jonathanheaden/reviewing-a-pull-request.git","ssh_url":"git@github.com:jonathanheaden/reviewing-a-pull-request.git","clone_url":"https://github.com/jonathanheaden/reviewing-a-pull-request.git","svn_url":"https://github.com/jonathanheaden/reviewing-a-pull-request","homepage":"https://lab.github.com/githubtraining/reviewing-pull-requests","size":0,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/pulls/2"},"html":{"href":"https://github.com/jonathanheaden/reviewing-a-pull-request/pull/2"},"issue":{"href":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/issues/2"},"comments":{"href":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/jonathanheaden/reviewing-a-pull-request/statuses/1aeb503d3a584d1c5de7bdf31f979e64be495f69"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":9,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"github-learning-lab"}}