{"action":"created","comment":{"url":"https://api.github.com/repos/highcharts/highcharts/pulls/comments/226623470","pull_request_review_id":166493360,"id":226623470,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjYyMzQ3MA==","diff_hunk":"@@ -0,0 +1,137 @@\n+'use strict';\n+import H from '../parts/Globals.js';\n+import '../parts/Utilities.js';\n+import requiredIndicatorMixin from '../mixins/indicator-required.js';\n+\n+var EMA = H.seriesTypes.ema,\n+    error = H.error,\n+    parentLoaded = requiredIndicatorMixin.isParentIndicatorLoaded;\n+\n+H.seriesType('apo', 'ema',\n+    /**\n+     * Absolute Price Oscillator. This series requires the `linkedTo` option to\n+     * be set and should be loaded after the `stock/indicators/indicators.js`\n+     * and `stock/indicators/ema.js`.\n+     *\n+     * @extends plotOptions.ema\n+     * @product highstock\n+     * @sample {highstock} stock/indicators/apo\n+     *                     Absolute Price Oscillator\n+     * @since 7.0.0\n+     * @excluding\n+     *             allAreas,colorAxis,joinBy,keys,stacking,\n+     *             showInNavigator,navigatorOptions,pointInterval,\n+     *             pointIntervalUnit,pointPlacement,pointRange,pointStart\n+     * @optionparent plotOptions.apo\n+     */\n+    {\n+        /**\n+         * Paramters used in calculation of Absolute Price Oscillator\n+         * series points.\n+         * @excluding period\n+         */\n+        params: {\n+            /**\n+             * Periods for Absolute Price Oscillator calculations.\n+             * @default [10, 20]\n+             * @type {Array}\n+             * @since 7.0.0\n+             */\n+            periods: [10, 20]","path":"js/indicators/apo.src.js","position":40,"original_position":40,"commit_id":"2daaf4f8dadc801662d5f5821c21e1aed475b4cd","original_commit_id":"2daaf4f8dadc801662d5f5821c21e1aed475b4cd","user":{"login":"pawelfus","id":1453926,"node_id":"MDQ6VXNlcjE0NTM5MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1453926?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelfus","html_url":"https://github.com/pawelfus","followers_url":"https://api.github.com/users/pawelfus/followers","following_url":"https://api.github.com/users/pawelfus/following{/other_user}","gists_url":"https://api.github.com/users/pawelfus/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelfus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelfus/subscriptions","organizations_url":"https://api.github.com/users/pawelfus/orgs","repos_url":"https://api.github.com/users/pawelfus/repos","events_url":"https://api.github.com/users/pawelfus/events{/privacy}","received_events_url":"https://api.github.com/users/pawelfus/received_events","type":"User","site_admin":false},"body":"For example Stochastic has `periods`, `macd` has multiple periods, so we don't have strict rules here..","created_at":"2018-10-19T12:08:20Z","updated_at":"2018-10-19T12:08:21Z","html_url":"https://github.com/highcharts/highcharts/pull/9219#discussion_r226623470","pull_request_url":"https://api.github.com/repos/highcharts/highcharts/pulls/9219","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/highcharts/highcharts/pulls/comments/226623470"},"html":{"href":"https://github.com/highcharts/highcharts/pull/9219#discussion_r226623470"},"pull_request":{"href":"https://api.github.com/repos/highcharts/highcharts/pulls/9219"}},"in_reply_to_id":226622292},"pull_request":{"url":"https://api.github.com/repos/highcharts/highcharts/pulls/9219","id":224251938,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MjUxOTM4","html_url":"https://github.com/highcharts/highcharts/pull/9219","diff_url":"https://github.com/highcharts/highcharts/pull/9219.diff","patch_url":"https://github.com/highcharts/highcharts/pull/9219.patch","issue_url":"https://api.github.com/repos/highcharts/highcharts/issues/9219","number":9219,"state":"closed","locked":false,"title":"StockTools: Absolute Price Oscillator.","user":{"login":"wchmiel","id":34909457,"node_id":"MDQ6VXNlcjM0OTA5NDU3","avatar_url":"https://avatars3.githubusercontent.com/u/34909457?v=4","gravatar_id":"","url":"https://api.github.com/users/wchmiel","html_url":"https://github.com/wchmiel","followers_url":"https://api.github.com/users/wchmiel/followers","following_url":"https://api.github.com/users/wchmiel/following{/other_user}","gists_url":"https://api.github.com/users/wchmiel/gists{/gist_id}","starred_url":"https://api.github.com/users/wchmiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchmiel/subscriptions","organizations_url":"https://api.github.com/users/wchmiel/orgs","repos_url":"https://api.github.com/users/wchmiel/repos","events_url":"https://api.github.com/users/wchmiel/events{/privacy}","received_events_url":"https://api.github.com/users/wchmiel/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-19T11:13:52Z","updated_at":"2018-10-19T12:08:21Z","closed_at":"2018-10-19T12:05:06Z","merged_at":"2018-10-19T12:05:06Z","merge_commit_sha":"96aadb5cf0d76aa26ac7315cdab843368938f89c","assignee":{"login":"wchmiel","id":34909457,"node_id":"MDQ6VXNlcjM0OTA5NDU3","avatar_url":"https://avatars3.githubusercontent.com/u/34909457?v=4","gravatar_id":"","url":"https://api.github.com/users/wchmiel","html_url":"https://github.com/wchmiel","followers_url":"https://api.github.com/users/wchmiel/followers","following_url":"https://api.github.com/users/wchmiel/following{/other_user}","gists_url":"https://api.github.com/users/wchmiel/gists{/gist_id}","starred_url":"https://api.github.com/users/wchmiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchmiel/subscriptions","organizations_url":"https://api.github.com/users/wchmiel/orgs","repos_url":"https://api.github.com/users/wchmiel/repos","events_url":"https://api.github.com/users/wchmiel/events{/privacy}","received_events_url":"https://api.github.com/users/wchmiel/received_events","type":"User","site_admin":false},"assignees":[{"login":"wchmiel","id":34909457,"node_id":"MDQ6VXNlcjM0OTA5NDU3","avatar_url":"https://avatars3.githubusercontent.com/u/34909457?v=4","gravatar_id":"","url":"https://api.github.com/users/wchmiel","html_url":"https://github.com/wchmiel","followers_url":"https://api.github.com/users/wchmiel/followers","following_url":"https://api.github.com/users/wchmiel/following{/other_user}","gists_url":"https://api.github.com/users/wchmiel/gists{/gist_id}","starred_url":"https://api.github.com/users/wchmiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchmiel/subscriptions","organizations_url":"https://api.github.com/users/wchmiel/orgs","repos_url":"https://api.github.com/users/wchmiel/repos","events_url":"https://api.github.com/users/wchmiel/events{/privacy}","received_events_url":"https://api.github.com/users/wchmiel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/highcharts/highcharts/pulls/9219/commits","review_comments_url":"https://api.github.com/repos/highcharts/highcharts/pulls/9219/comments","review_comment_url":"https://api.github.com/repos/highcharts/highcharts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highcharts/highcharts/issues/9219/comments","statuses_url":"https://api.github.com/repos/highcharts/highcharts/statuses/2daaf4f8dadc801662d5f5821c21e1aed475b4cd","head":{"label":"highcharts:hs7/absolute-price-oscillator","ref":"hs7/absolute-price-oscillator","sha":"2daaf4f8dadc801662d5f5821c21e1aed475b4cd","user":{"login":"highcharts","id":15981345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1OTgxMzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/15981345?v=4","gravatar_id":"","url":"https://api.github.com/users/highcharts","html_url":"https://github.com/highcharts","followers_url":"https://api.github.com/users/highcharts/followers","following_url":"https://api.github.com/users/highcharts/following{/other_user}","gists_url":"https://api.github.com/users/highcharts/gists{/gist_id}","starred_url":"https://api.github.com/users/highcharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highcharts/subscriptions","organizations_url":"https://api.github.com/users/highcharts/orgs","repos_url":"https://api.github.com/users/highcharts/repos","events_url":"https://api.github.com/users/highcharts/events{/privacy}","received_events_url":"https://api.github.com/users/highcharts/received_events","type":"Organization","site_admin":false},"repo":{"id":715547,"node_id":"MDEwOlJlcG9zaXRvcnk3MTU1NDc=","name":"highcharts","full_name":"highcharts/highcharts","private":false,"owner":{"login":"highcharts","id":15981345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1OTgxMzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/15981345?v=4","gravatar_id":"","url":"https://api.github.com/users/highcharts","html_url":"https://github.com/highcharts","followers_url":"https://api.github.com/users/highcharts/followers","following_url":"https://api.github.com/users/highcharts/following{/other_user}","gists_url":"https://api.github.com/users/highcharts/gists{/gist_id}","starred_url":"https://api.github.com/users/highcharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highcharts/subscriptions","organizations_url":"https://api.github.com/users/highcharts/orgs","repos_url":"https://api.github.com/users/highcharts/repos","events_url":"https://api.github.com/users/highcharts/events{/privacy}","received_events_url":"https://api.github.com/users/highcharts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/highcharts/highcharts","description":"Highcharts JS, the JavaScript charting framework","fork":false,"url":"https://api.github.com/repos/highcharts/highcharts","forks_url":"https://api.github.com/repos/highcharts/highcharts/forks","keys_url":"https://api.github.com/repos/highcharts/highcharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highcharts/highcharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highcharts/highcharts/teams","hooks_url":"https://api.github.com/repos/highcharts/highcharts/hooks","issue_events_url":"https://api.github.com/repos/highcharts/highcharts/issues/events{/number}","events_url":"https://api.github.com/repos/highcharts/highcharts/events","assignees_url":"https://api.github.com/repos/highcharts/highcharts/assignees{/user}","branches_url":"https://api.github.com/repos/highcharts/highcharts/branches{/branch}","tags_url":"https://api.github.com/repos/highcharts/highcharts/tags","blobs_url":"https://api.github.com/repos/highcharts/highcharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highcharts/highcharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highcharts/highcharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/highcharts/highcharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highcharts/highcharts/statuses/{sha}","languages_url":"https://api.github.com/repos/highcharts/highcharts/languages","stargazers_url":"https://api.github.com/repos/highcharts/highcharts/stargazers","contributors_url":"https://api.github.com/repos/highcharts/highcharts/contributors","subscribers_url":"https://api.github.com/repos/highcharts/highcharts/subscribers","subscription_url":"https://api.github.com/repos/highcharts/highcharts/subscription","commits_url":"https://api.github.com/repos/highcharts/highcharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/highcharts/highcharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/highcharts/highcharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/highcharts/highcharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/highcharts/highcharts/contents/{+path}","compare_url":"https://api.github.com/repos/highcharts/highcharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highcharts/highcharts/merges","archive_url":"https://api.github.com/repos/highcharts/highcharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highcharts/highcharts/downloads","issues_url":"https://api.github.com/repos/highcharts/highcharts/issues{/number}","pulls_url":"https://api.github.com/repos/highcharts/highcharts/pulls{/number}","milestones_url":"https://api.github.com/repos/highcharts/highcharts/milestones{/number}","notifications_url":"https://api.github.com/repos/highcharts/highcharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highcharts/highcharts/labels{/name}","releases_url":"https://api.github.com/repos/highcharts/highcharts/releases{/id}","deployments_url":"https://api.github.com/repos/highcharts/highcharts/deployments","created_at":"2010-06-11T12:23:53Z","updated_at":"2018-10-19T11:40:29Z","pushed_at":"2018-10-19T12:05:08Z","git_url":"git://github.com/highcharts/highcharts.git","ssh_url":"git@github.com:highcharts/highcharts.git","clone_url":"https://github.com/highcharts/highcharts.git","svn_url":"https://github.com/highcharts/highcharts","homepage":"https://www.highcharts.com","size":193412,"stargazers_count":8065,"watchers_count":8065,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2241,"mirror_url":null,"archived":false,"open_issues_count":1394,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2241,"open_issues":1394,"watchers":8065,"default_branch":"master"}},"base":{"label":"highcharts:hs7/stock-tools","ref":"hs7/stock-tools","sha":"ea2b491ca8caad1e2ab4aafcede392aa32e01e90","user":{"login":"highcharts","id":15981345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1OTgxMzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/15981345?v=4","gravatar_id":"","url":"https://api.github.com/users/highcharts","html_url":"https://github.com/highcharts","followers_url":"https://api.github.com/users/highcharts/followers","following_url":"https://api.github.com/users/highcharts/following{/other_user}","gists_url":"https://api.github.com/users/highcharts/gists{/gist_id}","starred_url":"https://api.github.com/users/highcharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highcharts/subscriptions","organizations_url":"https://api.github.com/users/highcharts/orgs","repos_url":"https://api.github.com/users/highcharts/repos","events_url":"https://api.github.com/users/highcharts/events{/privacy}","received_events_url":"https://api.github.com/users/highcharts/received_events","type":"Organization","site_admin":false},"repo":{"id":715547,"node_id":"MDEwOlJlcG9zaXRvcnk3MTU1NDc=","name":"highcharts","full_name":"highcharts/highcharts","private":false,"owner":{"login":"highcharts","id":15981345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1OTgxMzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/15981345?v=4","gravatar_id":"","url":"https://api.github.com/users/highcharts","html_url":"https://github.com/highcharts","followers_url":"https://api.github.com/users/highcharts/followers","following_url":"https://api.github.com/users/highcharts/following{/other_user}","gists_url":"https://api.github.com/users/highcharts/gists{/gist_id}","starred_url":"https://api.github.com/users/highcharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highcharts/subscriptions","organizations_url":"https://api.github.com/users/highcharts/orgs","repos_url":"https://api.github.com/users/highcharts/repos","events_url":"https://api.github.com/users/highcharts/events{/privacy}","received_events_url":"https://api.github.com/users/highcharts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/highcharts/highcharts","description":"Highcharts JS, the JavaScript charting framework","fork":false,"url":"https://api.github.com/repos/highcharts/highcharts","forks_url":"https://api.github.com/repos/highcharts/highcharts/forks","keys_url":"https://api.github.com/repos/highcharts/highcharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highcharts/highcharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highcharts/highcharts/teams","hooks_url":"https://api.github.com/repos/highcharts/highcharts/hooks","issue_events_url":"https://api.github.com/repos/highcharts/highcharts/issues/events{/number}","events_url":"https://api.github.com/repos/highcharts/highcharts/events","assignees_url":"https://api.github.com/repos/highcharts/highcharts/assignees{/user}","branches_url":"https://api.github.com/repos/highcharts/highcharts/branches{/branch}","tags_url":"https://api.github.com/repos/highcharts/highcharts/tags","blobs_url":"https://api.github.com/repos/highcharts/highcharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highcharts/highcharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highcharts/highcharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/highcharts/highcharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highcharts/highcharts/statuses/{sha}","languages_url":"https://api.github.com/repos/highcharts/highcharts/languages","stargazers_url":"https://api.github.com/repos/highcharts/highcharts/stargazers","contributors_url":"https://api.github.com/repos/highcharts/highcharts/contributors","subscribers_url":"https://api.github.com/repos/highcharts/highcharts/subscribers","subscription_url":"https://api.github.com/repos/highcharts/highcharts/subscription","commits_url":"https://api.github.com/repos/highcharts/highcharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/highcharts/highcharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/highcharts/highcharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/highcharts/highcharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/highcharts/highcharts/contents/{+path}","compare_url":"https://api.github.com/repos/highcharts/highcharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highcharts/highcharts/merges","archive_url":"https://api.github.com/repos/highcharts/highcharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highcharts/highcharts/downloads","issues_url":"https://api.github.com/repos/highcharts/highcharts/issues{/number}","pulls_url":"https://api.github.com/repos/highcharts/highcharts/pulls{/number}","milestones_url":"https://api.github.com/repos/highcharts/highcharts/milestones{/number}","notifications_url":"https://api.github.com/repos/highcharts/highcharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highcharts/highcharts/labels{/name}","releases_url":"https://api.github.com/repos/highcharts/highcharts/releases{/id}","deployments_url":"https://api.github.com/repos/highcharts/highcharts/deployments","created_at":"2010-06-11T12:23:53Z","updated_at":"2018-10-19T11:40:29Z","pushed_at":"2018-10-19T12:05:08Z","git_url":"git://github.com/highcharts/highcharts.git","ssh_url":"git@github.com:highcharts/highcharts.git","clone_url":"https://github.com/highcharts/highcharts.git","svn_url":"https://github.com/highcharts/highcharts","homepage":"https://www.highcharts.com","size":193412,"stargazers_count":8065,"watchers_count":8065,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2241,"mirror_url":null,"archived":false,"open_issues_count":1394,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2241,"open_issues":1394,"watchers":8065,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highcharts/highcharts/pulls/9219"},"html":{"href":"https://github.com/highcharts/highcharts/pull/9219"},"issue":{"href":"https://api.github.com/repos/highcharts/highcharts/issues/9219"},"comments":{"href":"https://api.github.com/repos/highcharts/highcharts/issues/9219/comments"},"review_comments":{"href":"https://api.github.com/repos/highcharts/highcharts/pulls/9219/comments"},"review_comment":{"href":"https://api.github.com/repos/highcharts/highcharts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highcharts/highcharts/pulls/9219/commits"},"statuses":{"href":"https://api.github.com/repos/highcharts/highcharts/statuses/2daaf4f8dadc801662d5f5821c21e1aed475b4cd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pawelfus"}}