{"action":"opened","issue":{"url":"https://api.github.com/repos/woocommerce/woocommerce/issues/21994","repository_url":"https://api.github.com/repos/woocommerce/woocommerce","labels_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/21994/labels{/name}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/21994/comments","events_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/21994/events","html_url":"https://github.com/woocommerce/woocommerce/issues/21994","id":382808183,"node_id":"MDU6SXNzdWUzODI4MDgxODM=","number":21994,"title":"\"New account\" email says \"the username you chose\" even when username auto-generated","user":{"login":"siliconforks","id":1156399,"node_id":"MDQ6VXNlcjExNTYzOTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1156399?v=4","gravatar_id":"","url":"https://api.github.com/users/siliconforks","html_url":"https://github.com/siliconforks","followers_url":"https://api.github.com/users/siliconforks/followers","following_url":"https://api.github.com/users/siliconforks/following{/other_user}","gists_url":"https://api.github.com/users/siliconforks/gists{/gist_id}","starred_url":"https://api.github.com/users/siliconforks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siliconforks/subscriptions","organizations_url":"https://api.github.com/users/siliconforks/orgs","repos_url":"https://api.github.com/users/siliconforks/repos","events_url":"https://api.github.com/users/siliconforks/events{/privacy}","received_events_url":"https://api.github.com/users/siliconforks/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-20T19:09:42Z","updated_at":"2018-11-20T19:09:42Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Describe the bug**\r\nWhen a new account is created, the new customer receives an email which says `Thanks for creating an account on %1$s. As a reminder, the username you chose is %2$s.`  This is confusing when the WooCommerce settings are configured to generate usernames automatically (because the customer never chose the username in that case).\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. In the WordPress admin section, go to WooCommerce &rarr; Settings &rarr; Accounts & Privacy.\r\n2. `Allow customers to create an account on the \"My account\" page` should be checked.\r\n3. `When creating an account, automatically generate a username from the customer's email address ` should be checked.\r\n4. Log out and visit the \"my account\" page.\r\n5. Fill out the registration form.  (You should need to enter an email address but not a username, because of the setting described in step 3 above.)\r\n6. You should receive the \"New account\" email.\r\n\r\n**Expected behavior**\r\nI would expect the \"New account\" email to make sense whether the username was auto-generated or not.  For example, the old text before the change in 866aab0ead782b8e5bb37041414d32d9191869be was more generic and made sense even if the username was auto-generated.  Alternatively, there could be an `if` statement which displays different text depending on whether username auto-generation is enabled in the settings (note that it already does something like this for auto-generated passwords).\r\n\r\n**Isolating the problem (mark completed items with an [x]):**\r\n- [x] I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.\r\n- [x] This bug happens with a default WordPress theme active, or [Storefront](https://woocommerce.com/storefront/).\r\n- [x] I can reproduce this bug consistently using the steps above.\r\n\r\n**WordPress Environment**\r\n<details>\r\n\r\n### WordPress Environment ###\r\n\r\nHome URL: http://host.test/wordpress-woocommerce-git\r\nSite URL: http://host.test/wordpress-woocommerce-git\r\nWC Version: 3.5.0\r\nLog Directory Writable: ✔\r\nWP Version: 4.9.8\r\nWP Multisite: –\r\nWP Memory Limit: 512 MB\r\nWP Debug Mode: ✔\r\nWP Cron: ✔\r\nLanguage: en_US\r\nExternal object cache: –\r\n\r\n### Server Environment ###\r\n\r\nServer Info: Apache/2.4.35 (Win32) OpenSSL/1.0.2p PHP/5.6.38\r\nPHP Version: 5.6.38 - We recommend using PHP version 7.2 or above for greater performance and security. How to update your PHP version\r\nPHP Post Max Size: 64 MB\r\nPHP Time Limit: 180\r\nPHP Max Input Vars: 1000\r\ncURL Version: 7.59.0\r\nOpenSSL/1.0.2p\r\n\r\nSUHOSIN Installed: –\r\nMySQL Version: 5.6.41-log\r\nMax Upload Size: 64 MB\r\nDefault Timezone is UTC: ✔\r\nfsockopen/cURL: ✔\r\nSoapClient: ✔\r\nDOMDocument: ✔\r\nGZip: ✔\r\nMultibyte String: ✔\r\nRemote Post: ✔\r\nRemote Get: ✔\r\n\r\n### Database ###\r\n\r\nWC Database Version: 3.5.0\r\nWC Database Prefix: wp_\r\nMaxMind GeoIP Database: ✔\r\nTotal Database Size: 1.86MB\r\nDatabase Data Size: 1.02MB\r\nDatabase Index Size: 0.84MB\r\nwp_woocommerce_sessions: Data: 0.02MB + Index: 0.02MB\r\nwp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB\r\nwp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB\r\nwp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.05MB\r\nwp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB\r\nwp_woocommerce_order_itemmeta: Data: 0.02MB + Index: 0.03MB\r\nwp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB\r\nwp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB\r\nwp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB\r\nwp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB\r\nwp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB\r\nwp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB\r\nwp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB\r\nwp_woocommerce_log: Data: 0.02MB + Index: 0.02MB\r\nwp_commentmeta: Data: 0.02MB + Index: 0.03MB\r\nwp_comments: Data: 0.02MB + Index: 0.08MB\r\nwp_links: Data: 0.02MB + Index: 0.02MB\r\nwp_options: Data: 0.48MB + Index: 0.02MB\r\nwp_postmeta: Data: 0.02MB + Index: 0.03MB\r\nwp_posts: Data: 0.02MB + Index: 0.06MB\r\nwp_termmeta: Data: 0.02MB + Index: 0.03MB\r\nwp_terms: Data: 0.02MB + Index: 0.03MB\r\nwp_term_relationships: Data: 0.02MB + Index: 0.02MB\r\nwp_term_taxonomy: Data: 0.02MB + Index: 0.03MB\r\nwp_usermeta: Data: 0.02MB + Index: 0.03MB\r\nwp_users: Data: 0.02MB + Index: 0.05MB\r\nwp_wc_download_log: Data: 0.02MB + Index: 0.03MB\r\nwp_wc_webhooks: Data: 0.02MB + Index: 0.02MB\r\n\r\n### Post Type Counts ###\r\n\r\npage: 6\r\npost: 2\r\n\r\n### Security ###\r\n\r\nSecure connection (HTTPS): ❌\r\n\t\t\t\t\tYour store is not using HTTPS. Learn more about HTTPS and SSL Certificates.\r\nHide errors from visitors: ❌Error messages should not be shown to visitors.\r\n\r\n### Active Plugins (0) ###\r\n\r\n\r\n### Settings ###\r\n\r\nAPI Enabled: –\r\nForce SSL: –\r\nCurrency: USD ($)\r\nCurrency Position: left\r\nThousand Separator: ,\r\nDecimal Separator: .\r\nNumber of Decimals: 2\r\nTaxonomies: Product Types: external (external)\r\ngrouped (grouped)\r\nsimple (simple)\r\nvariable (variable)\r\n\r\nTaxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog)\r\nexclude-from-search (exclude-from-search)\r\nfeatured (featured)\r\noutofstock (outofstock)\r\nrated-1 (rated-1)\r\nrated-2 (rated-2)\r\nrated-3 (rated-3)\r\nrated-4 (rated-4)\r\nrated-5 (rated-5)\r\n\r\n\r\n### WC Pages ###\r\n\r\nShop base: #5 - /shop/\r\nCart: #6 - /cart/\r\nCheckout: #7 - /checkout/\r\nMy account: #8 - /my-account/\r\nTerms and conditions: ❌ Page not set\r\n\r\n### Theme ###\r\n\r\nName: Storefront\r\nVersion: 2.3.5\r\nAuthor URL: https://woocommerce.com/\r\nChild Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme\r\nWooCommerce Support: ✔\r\n\r\n### Templates ###\r\n\r\nOverrides: –\r\n</details>\r\n"}}
{"actor":{"display_login":"siliconforks"}}