{"action":"closed","number":9178,"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/9178","id":210923235,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTIzMjM1","html_url":"https://github.com/scipy/scipy/pull/9178","diff_url":"https://github.com/scipy/scipy/pull/9178.diff","patch_url":"https://github.com/scipy/scipy/pull/9178.patch","issue_url":"https://api.github.com/repos/scipy/scipy/issues/9178","number":9178,"state":"closed","locked":false,"title":"MAINT: make refguide-check more robust for printed numpy arrays","user":{"login":"ev-br","id":2133832,"node_id":"MDQ6VXNlcjIxMzM4MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2133832?v=4","gravatar_id":"","url":"https://api.github.com/users/ev-br","html_url":"https://github.com/ev-br","followers_url":"https://api.github.com/users/ev-br/followers","following_url":"https://api.github.com/users/ev-br/following{/other_user}","gists_url":"https://api.github.com/users/ev-br/gists{/gist_id}","starred_url":"https://api.github.com/users/ev-br/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev-br/subscriptions","organizations_url":"https://api.github.com/users/ev-br/orgs","repos_url":"https://api.github.com/users/ev-br/repos","events_url":"https://api.github.com/users/ev-br/events{/privacy}","received_events_url":"https://api.github.com/users/ev-br/received_events","type":"User","site_admin":false},"body":"Our modified doctesting tries to compare numerical values using `np.allclose`. For this, it needs to be able to `eval` the doctest output. However, printing numpy arrays throws it off because\r\n\r\n```\r\n>>> print(np.arange(3))\r\n[0 1 2]\r\n```\r\nwhich is not a valid python code (there are no commas between values).\r\n\r\nThis PR tries to detect and work around these cases. \r\n\r\nThis would have avoided some back-and-forth in e.g. gh-9133 .","created_at":"2018-08-25T22:00:09Z","updated_at":"2018-08-26T15:54:07Z","closed_at":"2018-08-26T15:54:07Z","merged_at":"2018-08-26T15:54:07Z","merge_commit_sha":"0ce86b22fdf729001e549b5585621cfb67ca46ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":108549863,"node_id":"MDU6TGFiZWwxMDg1NDk4NjM=","url":"https://api.github.com/repos/scipy/scipy/labels/maintenance","name":"maintenance","color":"fef2c0","default":false}],"milestone":{"url":"https://api.github.com/repos/scipy/scipy/milestones/36","html_url":"https://github.com/scipy/scipy/milestone/36","labels_url":"https://api.github.com/repos/scipy/scipy/milestones/36/labels","id":3257163,"node_id":"MDk6TWlsZXN0b25lMzI1NzE2Mw==","number":36,"title":"1.2.0","description":"","creator":{"login":"pv","id":35046,"node_id":"MDQ6VXNlcjM1MDQ2","avatar_url":"https://avatars1.githubusercontent.com/u/35046?v=4","gravatar_id":"","url":"https://api.github.com/users/pv","html_url":"https://github.com/pv","followers_url":"https://api.github.com/users/pv/followers","following_url":"https://api.github.com/users/pv/following{/other_user}","gists_url":"https://api.github.com/users/pv/gists{/gist_id}","starred_url":"https://api.github.com/users/pv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pv/subscriptions","organizations_url":"https://api.github.com/users/pv/orgs","repos_url":"https://api.github.com/users/pv/repos","events_url":"https://api.github.com/users/pv/events{/privacy}","received_events_url":"https://api.github.com/users/pv/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":146,"state":"open","created_at":"2018-04-10T20:26:02Z","updated_at":"2018-08-26T15:54:07Z","due_on":"2018-11-09T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scipy/scipy/pulls/9178/commits","review_comments_url":"https://api.github.com/repos/scipy/scipy/pulls/9178/comments","review_comment_url":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/9178/comments","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/0d4c7ab484286d7bcc7e61c14aac7ac887c6a044","head":{"label":"ev-br:refguide_print_array","ref":"refguide_print_array","sha":"0d4c7ab484286d7bcc7e61c14aac7ac887c6a044","user":{"login":"ev-br","id":2133832,"node_id":"MDQ6VXNlcjIxMzM4MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2133832?v=4","gravatar_id":"","url":"https://api.github.com/users/ev-br","html_url":"https://github.com/ev-br","followers_url":"https://api.github.com/users/ev-br/followers","following_url":"https://api.github.com/users/ev-br/following{/other_user}","gists_url":"https://api.github.com/users/ev-br/gists{/gist_id}","starred_url":"https://api.github.com/users/ev-br/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev-br/subscriptions","organizations_url":"https://api.github.com/users/ev-br/orgs","repos_url":"https://api.github.com/users/ev-br/repos","events_url":"https://api.github.com/users/ev-br/events{/privacy}","received_events_url":"https://api.github.com/users/ev-br/received_events","type":"User","site_admin":false},"repo":{"id":10013462,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAxMzQ2Mg==","name":"scipy","full_name":"ev-br/scipy","owner":{"login":"ev-br","id":2133832,"node_id":"MDQ6VXNlcjIxMzM4MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2133832?v=4","gravatar_id":"","url":"https://api.github.com/users/ev-br","html_url":"https://github.com/ev-br","followers_url":"https://api.github.com/users/ev-br/followers","following_url":"https://api.github.com/users/ev-br/following{/other_user}","gists_url":"https://api.github.com/users/ev-br/gists{/gist_id}","starred_url":"https://api.github.com/users/ev-br/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev-br/subscriptions","organizations_url":"https://api.github.com/users/ev-br/orgs","repos_url":"https://api.github.com/users/ev-br/repos","events_url":"https://api.github.com/users/ev-br/events{/privacy}","received_events_url":"https://api.github.com/users/ev-br/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ev-br/scipy","description":"Scipy main repository","fork":true,"url":"https://api.github.com/repos/ev-br/scipy","forks_url":"https://api.github.com/repos/ev-br/scipy/forks","keys_url":"https://api.github.com/repos/ev-br/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ev-br/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ev-br/scipy/teams","hooks_url":"https://api.github.com/repos/ev-br/scipy/hooks","issue_events_url":"https://api.github.com/repos/ev-br/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/ev-br/scipy/events","assignees_url":"https://api.github.com/repos/ev-br/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/ev-br/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/ev-br/scipy/tags","blobs_url":"https://api.github.com/repos/ev-br/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ev-br/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ev-br/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ev-br/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ev-br/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/ev-br/scipy/languages","stargazers_url":"https://api.github.com/repos/ev-br/scipy/stargazers","contributors_url":"https://api.github.com/repos/ev-br/scipy/contributors","subscribers_url":"https://api.github.com/repos/ev-br/scipy/subscribers","subscription_url":"https://api.github.com/repos/ev-br/scipy/subscription","commits_url":"https://api.github.com/repos/ev-br/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ev-br/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ev-br/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ev-br/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ev-br/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/ev-br/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ev-br/scipy/merges","archive_url":"https://api.github.com/repos/ev-br/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ev-br/scipy/downloads","issues_url":"https://api.github.com/repos/ev-br/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/ev-br/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/ev-br/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/ev-br/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ev-br/scipy/labels{/name}","releases_url":"https://api.github.com/repos/ev-br/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/ev-br/scipy/deployments","created_at":"2013-05-12T12:46:29Z","updated_at":"2015-01-24T14:40:00Z","pushed_at":"2018-08-25T21:47:38Z","git_url":"git://github.com/ev-br/scipy.git","ssh_url":"git@github.com:ev-br/scipy.git","clone_url":"https://github.com/ev-br/scipy.git","svn_url":"https://github.com/ev-br/scipy","homepage":"http://scipy.org/","size":79503,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scipy:master","ref":"master","sha":"79b2f40acfb345c749b0e557b02d9f12ac1bcd40","user":{"login":"scipy","id":288277,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"repo":{"id":1460385,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMzg1","name":"scipy","full_name":"scipy/scipy","owner":{"login":"scipy","id":288277,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scipy/scipy","description":"Scipy library main repository","fork":false,"url":"https://api.github.com/repos/scipy/scipy","forks_url":"https://api.github.com/repos/scipy/scipy/forks","keys_url":"https://api.github.com/repos/scipy/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scipy/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scipy/scipy/teams","hooks_url":"https://api.github.com/repos/scipy/scipy/hooks","issue_events_url":"https://api.github.com/repos/scipy/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/scipy/scipy/events","assignees_url":"https://api.github.com/repos/scipy/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/scipy/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/scipy/scipy/tags","blobs_url":"https://api.github.com/repos/scipy/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scipy/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scipy/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scipy/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/scipy/scipy/languages","stargazers_url":"https://api.github.com/repos/scipy/scipy/stargazers","contributors_url":"https://api.github.com/repos/scipy/scipy/contributors","subscribers_url":"https://api.github.com/repos/scipy/scipy/subscribers","subscription_url":"https://api.github.com/repos/scipy/scipy/subscription","commits_url":"https://api.github.com/repos/scipy/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scipy/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scipy/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scipy/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scipy/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/scipy/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scipy/scipy/merges","archive_url":"https://api.github.com/repos/scipy/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scipy/scipy/downloads","issues_url":"https://api.github.com/repos/scipy/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/scipy/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/scipy/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/scipy/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scipy/scipy/labels{/name}","releases_url":"https://api.github.com/repos/scipy/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/scipy/scipy/deployments","created_at":"2011-03-09T18:52:03Z","updated_at":"2018-08-26T14:22:47Z","pushed_at":"2018-08-26T15:54:07Z","git_url":"git://github.com/scipy/scipy.git","ssh_url":"git@github.com:scipy/scipy.git","clone_url":"https://github.com/scipy/scipy.git","svn_url":"https://github.com/scipy/scipy","homepage":"https://scipy.org/scipylib/","size":81512,"stargazers_count":4832,"watchers_count":4832,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2454,"mirror_url":null,"archived":false,"open_issues_count":1308,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2454,"open_issues":1308,"watchers":4832,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/9178"},"html":{"href":"https://github.com/scipy/scipy/pull/9178"},"issue":{"href":"https://api.github.com/repos/scipy/scipy/issues/9178"},"comments":{"href":"https://api.github.com/repos/scipy/scipy/issues/9178/comments"},"review_comments":{"href":"https://api.github.com/repos/scipy/scipy/pulls/9178/comments"},"review_comment":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scipy/scipy/pulls/9178/commits"},"statuses":{"href":"https://api.github.com/repos/scipy/scipy/statuses/0d4c7ab484286d7bcc7e61c14aac7ac887c6a044"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rgommers","id":98330,"node_id":"MDQ6VXNlcjk4MzMw","avatar_url":"https://avatars3.githubusercontent.com/u/98330?v=4","gravatar_id":"","url":"https://api.github.com/users/rgommers","html_url":"https://github.com/rgommers","followers_url":"https://api.github.com/users/rgommers/followers","following_url":"https://api.github.com/users/rgommers/following{/other_user}","gists_url":"https://api.github.com/users/rgommers/gists{/gist_id}","starred_url":"https://api.github.com/users/rgommers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgommers/subscriptions","organizations_url":"https://api.github.com/users/rgommers/orgs","repos_url":"https://api.github.com/users/rgommers/repos","events_url":"https://api.github.com/users/rgommers/events{/privacy}","received_events_url":"https://api.github.com/users/rgommers/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"rgommers"}}