{"action":"created","comment":{"url":"https://api.github.com/repos/apache/samza/pulls/comments/221359522","pull_request_review_id":159995878,"id":221359522,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTM1OTUyMg==","diff_hunk":"@@ -79,10 +81,13 @@\n  *    <li>\"task.name.grouper.factory\" = {@link SingleContainerGrouperFactory}</li>\n  *    <li>\"job.name\" = \"test-samza\"</li>\n  *    <li>\"processor.id\" = \"1\"</li>\n+ *    <li>\"job.default.system\" = {@code JOB_DEFAULT_SYSTEM}</li>\n+ *    <li>\"job.host-affinity.enabled\" = \"false\"</li>\n  *  </ol>\n  *\n  */\n public class TestRunner {\n+  public static final String JOB_DEFAULT_SYSTEM = \"default-samza-system\";","path":"samza-test/src/main/java/org/apache/samza/test/framework/TestRunner.java","position":null,"original_position":20,"commit_id":"142a3f870bf7550daf3ee4e2b1768d4b75db0ade","original_commit_id":"3c1167b9850f6d5f5296903303625fbdb10e99d2","user":{"login":"Sanil15","id":16806974,"node_id":"MDQ6VXNlcjE2ODA2OTc0","avatar_url":"https://avatars0.githubusercontent.com/u/16806974?v=4","gravatar_id":"","url":"https://api.github.com/users/Sanil15","html_url":"https://github.com/Sanil15","followers_url":"https://api.github.com/users/Sanil15/followers","following_url":"https://api.github.com/users/Sanil15/following{/other_user}","gists_url":"https://api.github.com/users/Sanil15/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanil15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanil15/subscriptions","organizations_url":"https://api.github.com/users/Sanil15/orgs","repos_url":"https://api.github.com/users/Sanil15/repos","events_url":"https://api.github.com/users/Sanil15/events{/privacy}","received_events_url":"https://api.github.com/users/Sanil15/received_events","type":"User","site_admin":false},"body":"Reverted the anti-pattern, made the constants private","created_at":"2018-09-28T19:33:27Z","updated_at":"2018-09-28T19:33:45Z","html_url":"https://github.com/apache/samza/pull/651#discussion_r221359522","pull_request_url":"https://api.github.com/repos/apache/samza/pulls/651","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/comments/221359522"},"html":{"href":"https://github.com/apache/samza/pull/651#discussion_r221359522"},"pull_request":{"href":"https://api.github.com/repos/apache/samza/pulls/651"}},"in_reply_to_id":219663849},"pull_request":{"url":"https://api.github.com/repos/apache/samza/pulls/651","id":217137225,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTM3MjI1","html_url":"https://github.com/apache/samza/pull/651","diff_url":"https://github.com/apache/samza/pull/651.diff","patch_url":"https://github.com/apache/samza/pull/651.patch","issue_url":"https://api.github.com/repos/apache/samza/issues/651","number":651,"state":"open","locked":false,"title":"SAMZA-1852 Adding default job system in TestRunner, disabling host affinity to support TableDescriptors and refining addConfig method for TestRunner API           ","user":{"login":"Sanil15","id":16806974,"node_id":"MDQ6VXNlcjE2ODA2OTc0","avatar_url":"https://avatars0.githubusercontent.com/u/16806974?v=4","gravatar_id":"","url":"https://api.github.com/users/Sanil15","html_url":"https://github.com/Sanil15","followers_url":"https://api.github.com/users/Sanil15/followers","following_url":"https://api.github.com/users/Sanil15/following{/other_user}","gists_url":"https://api.github.com/users/Sanil15/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanil15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanil15/subscriptions","organizations_url":"https://api.github.com/users/Sanil15/orgs","repos_url":"https://api.github.com/users/Sanil15/repos","events_url":"https://api.github.com/users/Sanil15/events{/privacy}","received_events_url":"https://api.github.com/users/Sanil15/received_events","type":"User","site_admin":false},"body":"- The default system is a required config for intermediate streams, and since no user will write assertions against them, defaulting it makes it easier for the user to write test\r\n- To support stateful jobs using Table API descriptors we need to disable host affinity, which is enabled by table API by default \r\n- @vjagadish pointed out addConfigs vs addOverrideConfig to be a confusing user-facing API. We now support only addConfig with different signatures, this configs takes precedence over any descriptor or TestRunner generated configs","created_at":"2018-09-20T23:49:40Z","updated_at":"2018-09-28T19:33:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8b39d03606e4660ef47f079ceef8b5571ce47b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/samza/pulls/651/commits","review_comments_url":"https://api.github.com/repos/apache/samza/pulls/651/comments","review_comment_url":"https://api.github.com/repos/apache/samza/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/samza/issues/651/comments","statuses_url":"https://api.github.com/repos/apache/samza/statuses/142a3f870bf7550daf3ee4e2b1768d4b75db0ade","head":{"label":"Sanil15:SAMZA-1852","ref":"SAMZA-1852","sha":"142a3f870bf7550daf3ee4e2b1768d4b75db0ade","user":{"login":"Sanil15","id":16806974,"node_id":"MDQ6VXNlcjE2ODA2OTc0","avatar_url":"https://avatars0.githubusercontent.com/u/16806974?v=4","gravatar_id":"","url":"https://api.github.com/users/Sanil15","html_url":"https://github.com/Sanil15","followers_url":"https://api.github.com/users/Sanil15/followers","following_url":"https://api.github.com/users/Sanil15/following{/other_user}","gists_url":"https://api.github.com/users/Sanil15/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanil15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanil15/subscriptions","organizations_url":"https://api.github.com/users/Sanil15/orgs","repos_url":"https://api.github.com/users/Sanil15/repos","events_url":"https://api.github.com/users/Sanil15/events{/privacy}","received_events_url":"https://api.github.com/users/Sanil15/received_events","type":"User","site_admin":false},"repo":{"id":124150337,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxNTAzMzc=","name":"samza","full_name":"Sanil15/samza","private":false,"owner":{"login":"Sanil15","id":16806974,"node_id":"MDQ6VXNlcjE2ODA2OTc0","avatar_url":"https://avatars0.githubusercontent.com/u/16806974?v=4","gravatar_id":"","url":"https://api.github.com/users/Sanil15","html_url":"https://github.com/Sanil15","followers_url":"https://api.github.com/users/Sanil15/followers","following_url":"https://api.github.com/users/Sanil15/following{/other_user}","gists_url":"https://api.github.com/users/Sanil15/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanil15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanil15/subscriptions","organizations_url":"https://api.github.com/users/Sanil15/orgs","repos_url":"https://api.github.com/users/Sanil15/repos","events_url":"https://api.github.com/users/Sanil15/events{/privacy}","received_events_url":"https://api.github.com/users/Sanil15/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Sanil15/samza","description":"Mirror of Apache Samza","fork":true,"url":"https://api.github.com/repos/Sanil15/samza","forks_url":"https://api.github.com/repos/Sanil15/samza/forks","keys_url":"https://api.github.com/repos/Sanil15/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sanil15/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sanil15/samza/teams","hooks_url":"https://api.github.com/repos/Sanil15/samza/hooks","issue_events_url":"https://api.github.com/repos/Sanil15/samza/issues/events{/number}","events_url":"https://api.github.com/repos/Sanil15/samza/events","assignees_url":"https://api.github.com/repos/Sanil15/samza/assignees{/user}","branches_url":"https://api.github.com/repos/Sanil15/samza/branches{/branch}","tags_url":"https://api.github.com/repos/Sanil15/samza/tags","blobs_url":"https://api.github.com/repos/Sanil15/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sanil15/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sanil15/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sanil15/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sanil15/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/Sanil15/samza/languages","stargazers_url":"https://api.github.com/repos/Sanil15/samza/stargazers","contributors_url":"https://api.github.com/repos/Sanil15/samza/contributors","subscribers_url":"https://api.github.com/repos/Sanil15/samza/subscribers","subscription_url":"https://api.github.com/repos/Sanil15/samza/subscription","commits_url":"https://api.github.com/repos/Sanil15/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sanil15/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sanil15/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sanil15/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sanil15/samza/contents/{+path}","compare_url":"https://api.github.com/repos/Sanil15/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sanil15/samza/merges","archive_url":"https://api.github.com/repos/Sanil15/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sanil15/samza/downloads","issues_url":"https://api.github.com/repos/Sanil15/samza/issues{/number}","pulls_url":"https://api.github.com/repos/Sanil15/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/Sanil15/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/Sanil15/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sanil15/samza/labels{/name}","releases_url":"https://api.github.com/repos/Sanil15/samza/releases{/id}","deployments_url":"https://api.github.com/repos/Sanil15/samza/deployments","created_at":"2018-03-06T23:14:47Z","updated_at":"2018-09-27T18:42:47Z","pushed_at":"2018-09-28T19:32:56Z","git_url":"git://github.com/Sanil15/samza.git","ssh_url":"git@github.com:Sanil15/samza.git","clone_url":"https://github.com/Sanil15/samza.git","svn_url":"https://github.com/Sanil15/samza","homepage":null,"size":23924,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"66d6c5d09645bcf4dc4051deda3fed31848d0340","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32199982,"node_id":"MDEwOlJlcG9zaXRvcnkzMjE5OTk4Mg==","name":"samza","full_name":"apache/samza","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/samza","description":"Mirror of Apache Samza","fork":false,"url":"https://api.github.com/repos/apache/samza","forks_url":"https://api.github.com/repos/apache/samza/forks","keys_url":"https://api.github.com/repos/apache/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/samza/teams","hooks_url":"https://api.github.com/repos/apache/samza/hooks","issue_events_url":"https://api.github.com/repos/apache/samza/issues/events{/number}","events_url":"https://api.github.com/repos/apache/samza/events","assignees_url":"https://api.github.com/repos/apache/samza/assignees{/user}","branches_url":"https://api.github.com/repos/apache/samza/branches{/branch}","tags_url":"https://api.github.com/repos/apache/samza/tags","blobs_url":"https://api.github.com/repos/apache/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/samza/languages","stargazers_url":"https://api.github.com/repos/apache/samza/stargazers","contributors_url":"https://api.github.com/repos/apache/samza/contributors","subscribers_url":"https://api.github.com/repos/apache/samza/subscribers","subscription_url":"https://api.github.com/repos/apache/samza/subscription","commits_url":"https://api.github.com/repos/apache/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/samza/contents/{+path}","compare_url":"https://api.github.com/repos/apache/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/samza/merges","archive_url":"https://api.github.com/repos/apache/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/samza/downloads","issues_url":"https://api.github.com/repos/apache/samza/issues{/number}","pulls_url":"https://api.github.com/repos/apache/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/samza/labels{/name}","releases_url":"https://api.github.com/repos/apache/samza/releases{/id}","deployments_url":"https://api.github.com/repos/apache/samza/deployments","created_at":"2015-03-14T07:00:05Z","updated_at":"2018-09-28T17:55:09Z","pushed_at":"2018-09-28T19:32:57Z","git_url":"git://github.com/apache/samza.git","ssh_url":"git@github.com:apache/samza.git","clone_url":"https://github.com/apache/samza.git","svn_url":"https://github.com/apache/samza","homepage":null,"size":23828,"stargazers_count":456,"watchers_count":456,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":205,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":205,"open_issues":38,"watchers":456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/651"},"html":{"href":"https://github.com/apache/samza/pull/651"},"issue":{"href":"https://api.github.com/repos/apache/samza/issues/651"},"comments":{"href":"https://api.github.com/repos/apache/samza/issues/651/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/samza/pulls/651/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/samza/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/samza/pulls/651/commits"},"statuses":{"href":"https://api.github.com/repos/apache/samza/statuses/142a3f870bf7550daf3ee4e2b1768d4b75db0ade"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Sanil15"}}