{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23512","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23512/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23512/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23512/events","html_url":"https://github.com/cockroachdb/cockroach/pull/23512","id":302891900,"number":23512,"title":"sql: implement encode(..., 'escape')","user":{"login":"justinj","id":409075,"avatar_url":"https://avatars2.githubusercontent.com/u/409075?v=4","gravatar_id":"","url":"https://api.github.com/users/justinj","html_url":"https://github.com/justinj","followers_url":"https://api.github.com/users/justinj/followers","following_url":"https://api.github.com/users/justinj/following{/other_user}","gists_url":"https://api.github.com/users/justinj/gists{/gist_id}","starred_url":"https://api.github.com/users/justinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinj/subscriptions","organizations_url":"https://api.github.com/users/justinj/orgs","repos_url":"https://api.github.com/users/justinj/repos","events_url":"https://api.github.com/users/justinj/events{/privacy}","received_events_url":"https://api.github.com/users/justinj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-03-06T22:26:31Z","updated_at":"2018-03-08T15:43:15Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23512","html_url":"https://github.com/cockroachdb/cockroach/pull/23512","diff_url":"https://github.com/cockroachdb/cockroach/pull/23512.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/23512.patch"},"body":"It's become evident that this is an important feature - I know it's a\r\nbit late, but I would really like to cherry-pick this change.\r\n\r\nI think the decode version is not as important - this version is\r\nimportant so that it's possible to migrate a BYTES column to a STRING.\r\n\r\nRelease note (sql change): Add 'escape' option to the encode builtin."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/371526174","html_url":"https://github.com/cockroachdb/cockroach/pull/23512#issuecomment-371526174","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23512","id":371526174,"user":{"login":"justinj","id":409075,"avatar_url":"https://avatars2.githubusercontent.com/u/409075?v=4","gravatar_id":"","url":"https://api.github.com/users/justinj","html_url":"https://github.com/justinj","followers_url":"https://api.github.com/users/justinj/followers","following_url":"https://api.github.com/users/justinj/following{/other_user}","gists_url":"https://api.github.com/users/justinj/gists{/gist_id}","starred_url":"https://api.github.com/users/justinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinj/subscriptions","organizations_url":"https://api.github.com/users/justinj/orgs","repos_url":"https://api.github.com/users/justinj/repos","events_url":"https://api.github.com/users/justinj/events{/privacy}","received_events_url":"https://api.github.com/users/justinj/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T15:43:15Z","updated_at":"2018-03-08T15:43:15Z","author_association":"OWNER","body":"\n\n\n\nReview status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks pending.\n\n---\n\n*[pkg/sql/logictest/testdata/logic_test/builtin_function, line 1350 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/23512#-L6ydjkkHTqOEcKfN2Jb:-L75Gj94h7ceevODmyUR:b-kei8f5) ([raw file](https://github.com/cockroachdb/cockroach/blob/fee30dbc541922c796cd5bae13850371ee7bb03a/pkg/sql/logictest/testdata/logic_test/builtin_function#L1350)):*\n<details><summary><i>Previously, benesch (Nikhil Benesch) wrote…</i></summary><blockquote>\n\nWait, I don't think this is wrong! I mean, besides the NULL-bytes-are-allowed-in-strings thing, but that's another conversation.\n</blockquote></details>\n\nOk, I've also come to the conclusion that this is right, but what's *wrong* is our current conversion of STRING to BYTES, but I think that's also another conversation that I will open a separate PR for.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/23512)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"justinj"}}