{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/240549870","pull_request_review_id":183601363,"id":240549870,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDU0OTg3MA==","diff_hunk":"@@ -209,6 +215,222 @@ Scalar<DataType> time_deriv_of_lapse(\n   return dt_lapse;\n }\n \n+template <size_t SpatialDim, typename Frame, typename DataType>\n+void spatial_deriv_of_shift(\n+    const gsl::not_null<tnsr::iJ<DataType, SpatialDim, Frame>*> deriv_shift,\n+    const Scalar<DataType>& lapse,\n+    const tnsr::AA<DataType, SpatialDim, Frame>& inverse_spacetime_metric,\n+    const tnsr::A<DataType, SpatialDim, Frame>& spacetime_unit_normal,\n+    const tnsr::iaa<DataType, SpatialDim, Frame>& phi) noexcept {\n+  for (size_t i = 0; i < SpatialDim; ++i) {\n+    for (size_t j = 0; j < SpatialDim; ++j) {\n+      for (size_t a = 0; a < SpatialDim + 1; ++a) {\n+        for (size_t b = 0; b < SpatialDim + 1; ++b) {\n+          deriv_shift->get(i,j) += (inverse_spacetime_metric.get(j+1, a)\n+                + spacetime_unit_normal.get(j+1) * spacetime_unit_normal.get(a))\n+            * spacetime_unit_normal.get(b) * phi.get(i, a, b);\n+        }\n+      }\n+      deriv_shift->get(i,j) *= get(lapse);\n+    }\n+  }\n+}\n+\n+template <size_t SpatialDim, typename Frame, typename DataType>\n+tnsr::iJ<DataType, SpatialDim, Frame> spatial_deriv_of_shift(\n+    const Scalar<DataType>& lapse,\n+    const tnsr::AA<DataType, SpatialDim, Frame>& inverse_spacetime_metric,\n+    const tnsr::A<DataType, SpatialDim, Frame>& spacetime_unit_normal,\n+    const tnsr::iaa<DataType, SpatialDim, Frame>& phi) noexcept {\n+  auto deriv_shift =","path":"src/PointwiseFunctions/GeneralRelativity/ComputeGhQuantities.cpp","position":null,"original_position":61,"commit_id":"c866a06a30e7959a3269b4d87509d62b325a1fe4","original_commit_id":"39447745a8f3b6ccb0b5db7de38959f4671da197","user":{"login":"prayush","id":7142969,"node_id":"MDQ6VXNlcjcxNDI5Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/7142969?v=4","gravatar_id":"","url":"https://api.github.com/users/prayush","html_url":"https://github.com/prayush","followers_url":"https://api.github.com/users/prayush/followers","following_url":"https://api.github.com/users/prayush/following{/other_user}","gists_url":"https://api.github.com/users/prayush/gists{/gist_id}","starred_url":"https://api.github.com/users/prayush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prayush/subscriptions","organizations_url":"https://api.github.com/users/prayush/orgs","repos_url":"https://api.github.com/users/prayush/repos","events_url":"https://api.github.com/users/prayush/events{/privacy}","received_events_url":"https://api.github.com/users/prayush/received_events","type":"User","site_admin":false},"body":"changed","created_at":"2018-12-11T10:21:17Z","updated_at":"2018-12-11T10:21:18Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/1177#discussion_r240549870","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1177","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/240549870"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/1177#discussion_r240549870"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1177"}},"in_reply_to_id":239850192},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1177","id":231341070,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzQxMDcw","html_url":"https://github.com/sxs-collaboration/spectre/pull/1177","diff_url":"https://github.com/sxs-collaboration/spectre/pull/1177.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/1177.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1177","number":1177,"state":"open","locked":false,"title":"Get derivatives of shift from GH variables","user":{"login":"prayush","id":7142969,"node_id":"MDQ6VXNlcjcxNDI5Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/7142969?v=4","gravatar_id":"","url":"https://api.github.com/users/prayush","html_url":"https://github.com/prayush","followers_url":"https://api.github.com/users/prayush/followers","following_url":"https://api.github.com/users/prayush/following{/other_user}","gists_url":"https://api.github.com/users/prayush/gists{/gist_id}","starred_url":"https://api.github.com/users/prayush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prayush/subscriptions","organizations_url":"https://api.github.com/users/prayush/orgs","repos_url":"https://api.github.com/users/prayush/repos","events_url":"https://api.github.com/users/prayush/events{/privacy}","received_events_url":"https://api.github.com/users/prayush/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\n- Adds functions that compute derivatives of shift from generalized harmonic variables.\r\n\r\n### Types of changes:\r\n\r\n- [ ] Bugfix\r\n- [x] New feature\r\n\r\n### Component:\r\n\r\n- [ ] Code\r\n- [ ] Documentation\r\n- [ ] Build system\r\n- [ ] Continuous integration\r\n\r\n### Code review checklist\r\n\r\n- [ ] The PR passes all checks, including unit tests, `clang-tidy` and `IWYU`. For\r\n  instructions on how to perform the CI checks locally refer to the [Dev guide\r\n  on the Travis CI](https://spectre-code.org/travis_guide.html).\r\n- [ ] The code is documented and the documentation renders correctly. Run `make doc`\r\n  to generate the documentation locally into `BUILD_DIR/docs/html`. Then open\r\n  `index.html`.\r\n- [ ] The code follows the stylistic and code quality guidelines listed in the\r\n  [code review guide](https://spectre-code.org/code_review_guide.html).\r\n\r\n### Further comments\r\n\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by\r\nexplaining why you chose the solution you did and what alternatives you\r\nconsidered, etc...\r\n-->\r\n","created_at":"2018-11-15T21:32:10Z","updated_at":"2018-12-11T10:21:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a427c3ca717a2309cfad5e08685aa4bf76c217dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1177/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1177/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1177/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/c866a06a30e7959a3269b4d87509d62b325a1fe4","head":{"label":"prayush:dshift_gh","ref":"dshift_gh","sha":"c866a06a30e7959a3269b4d87509d62b325a1fe4","user":{"login":"prayush","id":7142969,"node_id":"MDQ6VXNlcjcxNDI5Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/7142969?v=4","gravatar_id":"","url":"https://api.github.com/users/prayush","html_url":"https://github.com/prayush","followers_url":"https://api.github.com/users/prayush/followers","following_url":"https://api.github.com/users/prayush/following{/other_user}","gists_url":"https://api.github.com/users/prayush/gists{/gist_id}","starred_url":"https://api.github.com/users/prayush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prayush/subscriptions","organizations_url":"https://api.github.com/users/prayush/orgs","repos_url":"https://api.github.com/users/prayush/repos","events_url":"https://api.github.com/users/prayush/events{/privacy}","received_events_url":"https://api.github.com/users/prayush/received_events","type":"User","site_admin":false},"repo":{"id":133052846,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwNTI4NDY=","name":"spectre","full_name":"prayush/spectre","private":false,"owner":{"login":"prayush","id":7142969,"node_id":"MDQ6VXNlcjcxNDI5Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/7142969?v=4","gravatar_id":"","url":"https://api.github.com/users/prayush","html_url":"https://github.com/prayush","followers_url":"https://api.github.com/users/prayush/followers","following_url":"https://api.github.com/users/prayush/following{/other_user}","gists_url":"https://api.github.com/users/prayush/gists{/gist_id}","starred_url":"https://api.github.com/users/prayush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prayush/subscriptions","organizations_url":"https://api.github.com/users/prayush/orgs","repos_url":"https://api.github.com/users/prayush/repos","events_url":"https://api.github.com/users/prayush/events{/privacy}","received_events_url":"https://api.github.com/users/prayush/received_events","type":"User","site_admin":false},"html_url":"https://github.com/prayush/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":true,"url":"https://api.github.com/repos/prayush/spectre","forks_url":"https://api.github.com/repos/prayush/spectre/forks","keys_url":"https://api.github.com/repos/prayush/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prayush/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prayush/spectre/teams","hooks_url":"https://api.github.com/repos/prayush/spectre/hooks","issue_events_url":"https://api.github.com/repos/prayush/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/prayush/spectre/events","assignees_url":"https://api.github.com/repos/prayush/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/prayush/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/prayush/spectre/tags","blobs_url":"https://api.github.com/repos/prayush/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prayush/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prayush/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/prayush/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prayush/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/prayush/spectre/languages","stargazers_url":"https://api.github.com/repos/prayush/spectre/stargazers","contributors_url":"https://api.github.com/repos/prayush/spectre/contributors","subscribers_url":"https://api.github.com/repos/prayush/spectre/subscribers","subscription_url":"https://api.github.com/repos/prayush/spectre/subscription","commits_url":"https://api.github.com/repos/prayush/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/prayush/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/prayush/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/prayush/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/prayush/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/prayush/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prayush/spectre/merges","archive_url":"https://api.github.com/repos/prayush/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prayush/spectre/downloads","issues_url":"https://api.github.com/repos/prayush/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/prayush/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/prayush/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/prayush/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prayush/spectre/labels{/name}","releases_url":"https://api.github.com/repos/prayush/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/prayush/spectre/deployments","created_at":"2018-05-11T14:52:11Z","updated_at":"2018-12-11T08:34:43Z","pushed_at":"2018-12-11T10:18:53Z","git_url":"git://github.com/prayush/spectre.git","ssh_url":"git@github.com:prayush/spectre.git","clone_url":"https://github.com/prayush/spectre.git","svn_url":"https://github.com/prayush/spectre","homepage":"","size":14704,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":8,"watchers":1,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"4ac453215e5680d9a26e89a5f9d9225ea4aed9f1","user":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3MDUxMA==","name":"spectre","full_name":"sxs-collaboration/spectre","private":false,"owner":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2018-12-11T01:17:52Z","pushed_at":"2018-12-11T10:18:54Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"","size":13986,"stargazers_count":31,"watchers_count":31,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":186,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":34,"open_issues":186,"watchers":31,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1177"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/1177"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1177"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1177/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1177/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1177/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/c866a06a30e7959a3269b4d87509d62b325a1fe4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"prayush"}}