{"action":"closed","number":802,"pull_request":{"url":"https://api.github.com/repos/firecracker-microvm/firecracker/pulls/802","id":241351841,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMzUxODQx","html_url":"https://github.com/firecracker-microvm/firecracker/pull/802","diff_url":"https://github.com/firecracker-microvm/firecracker/pull/802.diff","patch_url":"https://github.com/firecracker-microvm/firecracker/pull/802.patch","issue_url":"https://api.github.com/repos/firecracker-microvm/firecracker/issues/802","number":802,"state":"closed","locked":false,"title":"Apply seccomp filters to all firecracker threads","user":{"login":"acatangiu","id":31917973,"node_id":"MDQ6VXNlcjMxOTE3OTcz","avatar_url":"https://avatars3.githubusercontent.com/u/31917973?v=4","gravatar_id":"","url":"https://api.github.com/users/acatangiu","html_url":"https://github.com/acatangiu","followers_url":"https://api.github.com/users/acatangiu/followers","following_url":"https://api.github.com/users/acatangiu/following{/other_user}","gists_url":"https://api.github.com/users/acatangiu/gists{/gist_id}","starred_url":"https://api.github.com/users/acatangiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acatangiu/subscriptions","organizations_url":"https://api.github.com/users/acatangiu/orgs","repos_url":"https://api.github.com/users/acatangiu/repos","events_url":"https://api.github.com/users/acatangiu/events{/privacy}","received_events_url":"https://api.github.com/users/acatangiu/received_events","type":"User","site_admin":false},"body":"Apply seccomp filters to all firecracker threads\r\n\r\nRefactor and apply the seccomp filters to all Firecracker threads.\r\nNew syscalls had to be whitelisted as they are necessary (previously API and vCPUs threads had no filters installed).\r\n\r\nFirecracker default SECCOMP level is now 2 - SECCOMP_ADVANCED meaning filtering both on the syscall number and the syscall parameters.\r\n\r\nAdded integration test to validate all Firecracker threads have seccomp applied.\r\n\r\nFixes #800.\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-12-28T15:29:40Z","updated_at":"2018-12-28T18:42:04Z","closed_at":"2018-12-28T18:42:03Z","merged_at":"2018-12-28T18:42:03Z","merge_commit_sha":"56267c652496c0229c05385b54234abf8410c71e","assignee":{"login":"acatangiu","id":31917973,"node_id":"MDQ6VXNlcjMxOTE3OTcz","avatar_url":"https://avatars3.githubusercontent.com/u/31917973?v=4","gravatar_id":"","url":"https://api.github.com/users/acatangiu","html_url":"https://github.com/acatangiu","followers_url":"https://api.github.com/users/acatangiu/followers","following_url":"https://api.github.com/users/acatangiu/following{/other_user}","gists_url":"https://api.github.com/users/acatangiu/gists{/gist_id}","starred_url":"https://api.github.com/users/acatangiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acatangiu/subscriptions","organizations_url":"https://api.github.com/users/acatangiu/orgs","repos_url":"https://api.github.com/users/acatangiu/repos","events_url":"https://api.github.com/users/acatangiu/events{/privacy}","received_events_url":"https://api.github.com/users/acatangiu/received_events","type":"User","site_admin":false},"assignees":[{"login":"acatangiu","id":31917973,"node_id":"MDQ6VXNlcjMxOTE3OTcz","avatar_url":"https://avatars3.githubusercontent.com/u/31917973?v=4","gravatar_id":"","url":"https://api.github.com/users/acatangiu","html_url":"https://github.com/acatangiu","followers_url":"https://api.github.com/users/acatangiu/followers","following_url":"https://api.github.com/users/acatangiu/following{/other_user}","gists_url":"https://api.github.com/users/acatangiu/gists{/gist_id}","starred_url":"https://api.github.com/users/acatangiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acatangiu/subscriptions","organizations_url":"https://api.github.com/users/acatangiu/orgs","repos_url":"https://api.github.com/users/acatangiu/repos","events_url":"https://api.github.com/users/acatangiu/events{/privacy}","received_events_url":"https://api.github.com/users/acatangiu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1134597230,"node_id":"MDU6TGFiZWwxMTM0NTk3MjMw","url":"https://api.github.com/repos/firecracker-microvm/firecracker/labels/Feature:%20Seccomp","name":"Feature: Seccomp","color":"0052cc","default":false},{"id":724417540,"node_id":"MDU6TGFiZWw3MjQ0MTc1NDA=","url":"https://api.github.com/repos/firecracker-microvm/firecracker/labels/Quality:%20Bug","name":"Quality: Bug","color":"b60205","default":false},{"id":915150813,"node_id":"MDU6TGFiZWw5MTUxNTA4MTM=","url":"https://api.github.com/repos/firecracker-microvm/firecracker/labels/Security:%20Hardening","name":"Security: Hardening","color":"770000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/firecracker-microvm/firecracker/pulls/802/commits","review_comments_url":"https://api.github.com/repos/firecracker-microvm/firecracker/pulls/802/comments","review_comment_url":"https://api.github.com/repos/firecracker-microvm/firecracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firecracker-microvm/firecracker/issues/802/comments","statuses_url":"https://api.github.com/repos/firecracker-microvm/firecracker/statuses/e248eeb7ad3d72882b70e046761b671bbeca2946","head":{"label":"acatangiu:seccompfix","ref":"seccompfix","sha":"e248eeb7ad3d72882b70e046761b671bbeca2946","user":{"login":"acatangiu","id":31917973,"node_id":"MDQ6VXNlcjMxOTE3OTcz","avatar_url":"https://avatars3.githubusercontent.com/u/31917973?v=4","gravatar_id":"","url":"https://api.github.com/users/acatangiu","html_url":"https://github.com/acatangiu","followers_url":"https://api.github.com/users/acatangiu/followers","following_url":"https://api.github.com/users/acatangiu/following{/other_user}","gists_url":"https://api.github.com/users/acatangiu/gists{/gist_id}","starred_url":"https://api.github.com/users/acatangiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acatangiu/subscriptions","organizations_url":"https://api.github.com/users/acatangiu/orgs","repos_url":"https://api.github.com/users/acatangiu/repos","events_url":"https://api.github.com/users/acatangiu/events{/privacy}","received_events_url":"https://api.github.com/users/acatangiu/received_events","type":"User","site_admin":false},"repo":{"id":159280834,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkyODA4MzQ=","name":"firecracker","full_name":"acatangiu/firecracker","private":false,"owner":{"login":"acatangiu","id":31917973,"node_id":"MDQ6VXNlcjMxOTE3OTcz","avatar_url":"https://avatars3.githubusercontent.com/u/31917973?v=4","gravatar_id":"","url":"https://api.github.com/users/acatangiu","html_url":"https://github.com/acatangiu","followers_url":"https://api.github.com/users/acatangiu/followers","following_url":"https://api.github.com/users/acatangiu/following{/other_user}","gists_url":"https://api.github.com/users/acatangiu/gists{/gist_id}","starred_url":"https://api.github.com/users/acatangiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acatangiu/subscriptions","organizations_url":"https://api.github.com/users/acatangiu/orgs","repos_url":"https://api.github.com/users/acatangiu/repos","events_url":"https://api.github.com/users/acatangiu/events{/privacy}","received_events_url":"https://api.github.com/users/acatangiu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/acatangiu/firecracker","description":"Secure and fast microVMs for serverless computing.","fork":true,"url":"https://api.github.com/repos/acatangiu/firecracker","forks_url":"https://api.github.com/repos/acatangiu/firecracker/forks","keys_url":"https://api.github.com/repos/acatangiu/firecracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acatangiu/firecracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acatangiu/firecracker/teams","hooks_url":"https://api.github.com/repos/acatangiu/firecracker/hooks","issue_events_url":"https://api.github.com/repos/acatangiu/firecracker/issues/events{/number}","events_url":"https://api.github.com/repos/acatangiu/firecracker/events","assignees_url":"https://api.github.com/repos/acatangiu/firecracker/assignees{/user}","branches_url":"https://api.github.com/repos/acatangiu/firecracker/branches{/branch}","tags_url":"https://api.github.com/repos/acatangiu/firecracker/tags","blobs_url":"https://api.github.com/repos/acatangiu/firecracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acatangiu/firecracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acatangiu/firecracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/acatangiu/firecracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acatangiu/firecracker/statuses/{sha}","languages_url":"https://api.github.com/repos/acatangiu/firecracker/languages","stargazers_url":"https://api.github.com/repos/acatangiu/firecracker/stargazers","contributors_url":"https://api.github.com/repos/acatangiu/firecracker/contributors","subscribers_url":"https://api.github.com/repos/acatangiu/firecracker/subscribers","subscription_url":"https://api.github.com/repos/acatangiu/firecracker/subscription","commits_url":"https://api.github.com/repos/acatangiu/firecracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/acatangiu/firecracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/acatangiu/firecracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/acatangiu/firecracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/acatangiu/firecracker/contents/{+path}","compare_url":"https://api.github.com/repos/acatangiu/firecracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acatangiu/firecracker/merges","archive_url":"https://api.github.com/repos/acatangiu/firecracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acatangiu/firecracker/downloads","issues_url":"https://api.github.com/repos/acatangiu/firecracker/issues{/number}","pulls_url":"https://api.github.com/repos/acatangiu/firecracker/pulls{/number}","milestones_url":"https://api.github.com/repos/acatangiu/firecracker/milestones{/number}","notifications_url":"https://api.github.com/repos/acatangiu/firecracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acatangiu/firecracker/labels{/name}","releases_url":"https://api.github.com/repos/acatangiu/firecracker/releases{/id}","deployments_url":"https://api.github.com/repos/acatangiu/firecracker/deployments","created_at":"2018-11-27T05:28:36Z","updated_at":"2018-12-28T17:18:53Z","pushed_at":"2018-12-28T18:11:01Z","git_url":"git://github.com/acatangiu/firecracker.git","ssh_url":"git@github.com:acatangiu/firecracker.git","clone_url":"https://github.com/acatangiu/firecracker.git","svn_url":"https://github.com/acatangiu/firecracker","homepage":"http://firecracker-microvm.io","size":3400,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firecracker-microvm:master","ref":"master","sha":"6f5d2a09ebd38682317ff0fd803c239cb45568e4","user":{"login":"firecracker-microvm","id":44477506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NDc3NTA2","avatar_url":"https://avatars0.githubusercontent.com/u/44477506?v=4","gravatar_id":"","url":"https://api.github.com/users/firecracker-microvm","html_url":"https://github.com/firecracker-microvm","followers_url":"https://api.github.com/users/firecracker-microvm/followers","following_url":"https://api.github.com/users/firecracker-microvm/following{/other_user}","gists_url":"https://api.github.com/users/firecracker-microvm/gists{/gist_id}","starred_url":"https://api.github.com/users/firecracker-microvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firecracker-microvm/subscriptions","organizations_url":"https://api.github.com/users/firecracker-microvm/orgs","repos_url":"https://api.github.com/users/firecracker-microvm/repos","events_url":"https://api.github.com/users/firecracker-microvm/events{/privacy}","received_events_url":"https://api.github.com/users/firecracker-microvm/received_events","type":"Organization","site_admin":false},"repo":{"id":107505869,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1MDU4Njk=","name":"firecracker","full_name":"firecracker-microvm/firecracker","private":false,"owner":{"login":"firecracker-microvm","id":44477506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NDc3NTA2","avatar_url":"https://avatars0.githubusercontent.com/u/44477506?v=4","gravatar_id":"","url":"https://api.github.com/users/firecracker-microvm","html_url":"https://github.com/firecracker-microvm","followers_url":"https://api.github.com/users/firecracker-microvm/followers","following_url":"https://api.github.com/users/firecracker-microvm/following{/other_user}","gists_url":"https://api.github.com/users/firecracker-microvm/gists{/gist_id}","starred_url":"https://api.github.com/users/firecracker-microvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firecracker-microvm/subscriptions","organizations_url":"https://api.github.com/users/firecracker-microvm/orgs","repos_url":"https://api.github.com/users/firecracker-microvm/repos","events_url":"https://api.github.com/users/firecracker-microvm/events{/privacy}","received_events_url":"https://api.github.com/users/firecracker-microvm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firecracker-microvm/firecracker","description":"Secure and fast microVMs for serverless computing.","fork":false,"url":"https://api.github.com/repos/firecracker-microvm/firecracker","forks_url":"https://api.github.com/repos/firecracker-microvm/firecracker/forks","keys_url":"https://api.github.com/repos/firecracker-microvm/firecracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firecracker-microvm/firecracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firecracker-microvm/firecracker/teams","hooks_url":"https://api.github.com/repos/firecracker-microvm/firecracker/hooks","issue_events_url":"https://api.github.com/repos/firecracker-microvm/firecracker/issues/events{/number}","events_url":"https://api.github.com/repos/firecracker-microvm/firecracker/events","assignees_url":"https://api.github.com/repos/firecracker-microvm/firecracker/assignees{/user}","branches_url":"https://api.github.com/repos/firecracker-microvm/firecracker/branches{/branch}","tags_url":"https://api.github.com/repos/firecracker-microvm/firecracker/tags","blobs_url":"https://api.github.com/repos/firecracker-microvm/firecracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firecracker-microvm/firecracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firecracker-microvm/firecracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/firecracker-microvm/firecracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firecracker-microvm/firecracker/statuses/{sha}","languages_url":"https://api.github.com/repos/firecracker-microvm/firecracker/languages","stargazers_url":"https://api.github.com/repos/firecracker-microvm/firecracker/stargazers","contributors_url":"https://api.github.com/repos/firecracker-microvm/firecracker/contributors","subscribers_url":"https://api.github.com/repos/firecracker-microvm/firecracker/subscribers","subscription_url":"https://api.github.com/repos/firecracker-microvm/firecracker/subscription","commits_url":"https://api.github.com/repos/firecracker-microvm/firecracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/firecracker-microvm/firecracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/firecracker-microvm/firecracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/firecracker-microvm/firecracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/firecracker-microvm/firecracker/contents/{+path}","compare_url":"https://api.github.com/repos/firecracker-microvm/firecracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firecracker-microvm/firecracker/merges","archive_url":"https://api.github.com/repos/firecracker-microvm/firecracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firecracker-microvm/firecracker/downloads","issues_url":"https://api.github.com/repos/firecracker-microvm/firecracker/issues{/number}","pulls_url":"https://api.github.com/repos/firecracker-microvm/firecracker/pulls{/number}","milestones_url":"https://api.github.com/repos/firecracker-microvm/firecracker/milestones{/number}","notifications_url":"https://api.github.com/repos/firecracker-microvm/firecracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firecracker-microvm/firecracker/labels{/name}","releases_url":"https://api.github.com/repos/firecracker-microvm/firecracker/releases{/id}","deployments_url":"https://api.github.com/repos/firecracker-microvm/firecracker/deployments","created_at":"2017-10-19T06:18:47Z","updated_at":"2018-12-28T17:56:25Z","pushed_at":"2018-12-28T18:42:03Z","git_url":"git://github.com/firecracker-microvm/firecracker.git","ssh_url":"git@github.com:firecracker-microvm/firecracker.git","clone_url":"https://github.com/firecracker-microvm/firecracker.git","svn_url":"https://github.com/firecracker-microvm/firecracker","homepage":"http://firecracker-microvm.io","size":3389,"stargazers_count":6600,"watchers_count":6600,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":327,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":327,"open_issues":117,"watchers":6600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker/pulls/802"},"html":{"href":"https://github.com/firecracker-microvm/firecracker/pull/802"},"issue":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker/issues/802"},"comments":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker/issues/802/comments"},"review_comments":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker/pulls/802/comments"},"review_comment":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker/pulls/802/commits"},"statuses":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker/statuses/e248eeb7ad3d72882b70e046761b671bbeca2946"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"andreeaflorescu","id":2815944,"node_id":"MDQ6VXNlcjI4MTU5NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2815944?v=4","gravatar_id":"","url":"https://api.github.com/users/andreeaflorescu","html_url":"https://github.com/andreeaflorescu","followers_url":"https://api.github.com/users/andreeaflorescu/followers","following_url":"https://api.github.com/users/andreeaflorescu/following{/other_user}","gists_url":"https://api.github.com/users/andreeaflorescu/gists{/gist_id}","starred_url":"https://api.github.com/users/andreeaflorescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreeaflorescu/subscriptions","organizations_url":"https://api.github.com/users/andreeaflorescu/orgs","repos_url":"https://api.github.com/users/andreeaflorescu/repos","events_url":"https://api.github.com/users/andreeaflorescu/events{/privacy}","received_events_url":"https://api.github.com/users/andreeaflorescu/received_events","type":"User","site_admin":false},"comments":5,"review_comments":6,"maintainer_can_modify":false,"commits":6,"additions":138,"deletions":45,"changed_files":11}}
{"actor":{"display_login":"andreeaflorescu"}}