{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/802","repository_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/802/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/802/comments","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/802/events","html_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/802","id":336563898,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTg1MjU2","number":802,"title":"Move search suggestions in search layout","user":{"login":"lfdebrux","id":503614,"node_id":"MDQ6VXNlcjUwMzYxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/503614?v=4","gravatar_id":"","url":"https://api.github.com/users/lfdebrux","html_url":"https://github.com/lfdebrux","followers_url":"https://api.github.com/users/lfdebrux/followers","following_url":"https://api.github.com/users/lfdebrux/following{/other_user}","gists_url":"https://api.github.com/users/lfdebrux/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdebrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdebrux/subscriptions","organizations_url":"https://api.github.com/users/lfdebrux/orgs","repos_url":"https://api.github.com/users/lfdebrux/repos","events_url":"https://api.github.com/users/lfdebrux/events{/privacy}","received_events_url":"https://api.github.com/users/lfdebrux/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-28T10:28:25Z","updated_at":"2018-06-28T10:41:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/802","html_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/802","diff_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/802.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/802.patch"},"body":"@samuelhwilliams spotted that in the 0 results case the search suggestions look out of place since #795.\r\n\r\nThis commit fixes this by moving the search suggestions out of the search summary component to inside the search results wrapper.\r\n\r\nThe suggestions have to be inside the results wrapper so it is updated dynamically with the live search.\r\n\r\n---\r\n\r\n## Side by side\r\n\r\n![screen shot 2018-06-28 at 11 38 33 2](https://user-images.githubusercontent.com/503614/42029587-f6a9bc62-7ac7-11e8-82c4-1aae7041bdc8.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/comments/400992800","html_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/802#issuecomment-400992800","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/802","id":400992800,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDk5MjgwMA==","user":{"login":"lfdebrux","id":503614,"node_id":"MDQ6VXNlcjUwMzYxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/503614?v=4","gravatar_id":"","url":"https://api.github.com/users/lfdebrux","html_url":"https://github.com/lfdebrux","followers_url":"https://api.github.com/users/lfdebrux/followers","following_url":"https://api.github.com/users/lfdebrux/following{/other_user}","gists_url":"https://api.github.com/users/lfdebrux/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdebrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdebrux/subscriptions","organizations_url":"https://api.github.com/users/lfdebrux/orgs","repos_url":"https://api.github.com/users/lfdebrux/repos","events_url":"https://api.github.com/users/lfdebrux/events{/privacy}","received_events_url":"https://api.github.com/users/lfdebrux/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T10:41:52Z","updated_at":"2018-06-28T10:41:52Z","author_association":"CONTRIBUTOR","body":"It would be worth having a functional test on the dynamic behaviour of the search suggestions (i.e. it appears and disappears correctly when using live search)"}}
{"actor":{"display_login":"lfdebrux"}}