{"action":"created","comment":{"url":"https://api.github.com/repos/helm/charts/pulls/comments/244592570","pull_request_review_id":188505541,"id":244592570,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU5MjU3MA==","diff_hunk":"@@ -98,6 +98,20 @@ airflow:\n     pullSecret: my-docker-repo-secret\n ```\n \n+### Airflow connections\n+\n+Connections define how your Airflow instance connects to environment and 3rd party service providers.\n+This helm chart allows you to define your own connections at the time of Airflow initialization.\n+For each connection the id and the type has to be defined. All other properties are optional.\n+Example:\n+```yaml\n+airflow:\n+  connections:\n+  - id: my_aws\n+    type: aws\n+    extra: '{\"aws_access_key_id\": \"**********\", \"aws_secret_access_key\": \"***\", \"region_name\":\"eu-central-1\"}'","path":"stable/airflow/README.md","position":15,"original_position":15,"commit_id":"97c336a77cb60b4e8e9b90039803829bf90ca246","original_commit_id":"97c336a77cb60b4e8e9b90039803829bf90ca246","user":{"login":"gsemet","id":133498,"node_id":"MDQ6VXNlcjEzMzQ5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/133498?v=4","gravatar_id":"","url":"https://api.github.com/users/gsemet","html_url":"https://github.com/gsemet","followers_url":"https://api.github.com/users/gsemet/followers","following_url":"https://api.github.com/users/gsemet/following{/other_user}","gists_url":"https://api.github.com/users/gsemet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsemet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsemet/subscriptions","organizations_url":"https://api.github.com/users/gsemet/orgs","repos_url":"https://api.github.com/users/gsemet/repos","events_url":"https://api.github.com/users/gsemet/events{/privacy}","received_events_url":"https://api.github.com/users/gsemet/received_events","type":"User","site_admin":false},"body":"wonder if helm core team wont ask us to store these creds in a secret somehow. ","created_at":"2018-12-31T15:07:20Z","updated_at":"2018-12-31T15:07:20Z","html_url":"https://github.com/helm/charts/pull/10317#discussion_r244592570","pull_request_url":"https://api.github.com/repos/helm/charts/pulls/10317","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/comments/244592570"},"html":{"href":"https://github.com/helm/charts/pull/10317#discussion_r244592570"},"pull_request":{"href":"https://api.github.com/repos/helm/charts/pulls/10317"}}},"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/10317","id":241571530,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTcxNTMw","html_url":"https://github.com/helm/charts/pull/10317","diff_url":"https://github.com/helm/charts/pull/10317.diff","patch_url":"https://github.com/helm/charts/pull/10317.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/10317","number":10317,"state":"open","locked":false,"title":"[stable/airflow] : support adding connections","user":{"login":"antweiss","id":3274734,"node_id":"MDQ6VXNlcjMyNzQ3MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3274734?v=4","gravatar_id":"","url":"https://api.github.com/users/antweiss","html_url":"https://github.com/antweiss","followers_url":"https://api.github.com/users/antweiss/followers","following_url":"https://api.github.com/users/antweiss/following{/other_user}","gists_url":"https://api.github.com/users/antweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/antweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antweiss/subscriptions","organizations_url":"https://api.github.com/users/antweiss/orgs","repos_url":"https://api.github.com/users/antweiss/repos","events_url":"https://api.github.com/users/antweiss/events{/privacy}","received_events_url":"https://api.github.com/users/antweiss/received_events","type":"User","site_admin":false},"body":"@gsemet \r\n#### What this PR does / why we need it:\r\n\r\nThis adds support for providing Airflow connections as a part of the chart.\r\nWithout predefined connections most DAGs cannot execute.\r\nThough in theory it is possible to define connections via environment variables  - it is very cumbersome, especially for connections with lots of 'extra' content (e.g Amazon EMR)\r\n\r\n#### Special notes for your reviewer:\r\n\r\nCurrently this is implemented only for the scenario where init-container is enabled.\r\nThis allows extending the existing configmap-scripts template. \r\nAlternatively can be done in a separate configmap so as to decouple it from DAG loading logic.\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [x] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\r\n- [x] Chart Version bumped\r\n- [x] Variables are documented in the README.md\r\n","created_at":"2018-12-31T14:52:26Z","updated_at":"2018-12-31T15:07:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35437fb5f0e809d8565691e6875f823c3baeefee","assignee":null,"assignees":[],"requested_reviewers":[{"login":"maver1ck","id":4006010,"node_id":"MDQ6VXNlcjQwMDYwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4006010?v=4","gravatar_id":"","url":"https://api.github.com/users/maver1ck","html_url":"https://github.com/maver1ck","followers_url":"https://api.github.com/users/maver1ck/followers","following_url":"https://api.github.com/users/maver1ck/following{/other_user}","gists_url":"https://api.github.com/users/maver1ck/gists{/gist_id}","starred_url":"https://api.github.com/users/maver1ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maver1ck/subscriptions","organizations_url":"https://api.github.com/users/maver1ck/orgs","repos_url":"https://api.github.com/users/maver1ck/repos","events_url":"https://api.github.com/users/maver1ck/events{/privacy}","received_events_url":"https://api.github.com/users/maver1ck/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":676477477,"node_id":"MDU6TGFiZWw2NzY0Nzc0Nzc=","url":"https://api.github.com/repos/helm/charts/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/10317/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/10317/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/10317/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/97c336a77cb60b4e8e9b90039803829bf90ca246","head":{"label":"otomato-gh:master","ref":"master","sha":"97c336a77cb60b4e8e9b90039803829bf90ca246","user":{"login":"otomato-gh","id":17848491,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODQ4NDkx","avatar_url":"https://avatars2.githubusercontent.com/u/17848491?v=4","gravatar_id":"","url":"https://api.github.com/users/otomato-gh","html_url":"https://github.com/otomato-gh","followers_url":"https://api.github.com/users/otomato-gh/followers","following_url":"https://api.github.com/users/otomato-gh/following{/other_user}","gists_url":"https://api.github.com/users/otomato-gh/gists{/gist_id}","starred_url":"https://api.github.com/users/otomato-gh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otomato-gh/subscriptions","organizations_url":"https://api.github.com/users/otomato-gh/orgs","repos_url":"https://api.github.com/users/otomato-gh/repos","events_url":"https://api.github.com/users/otomato-gh/events{/privacy}","received_events_url":"https://api.github.com/users/otomato-gh/received_events","type":"Organization","site_admin":false},"repo":{"id":163671280,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM2NzEyODA=","name":"charts","full_name":"otomato-gh/charts","private":false,"owner":{"login":"otomato-gh","id":17848491,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODQ4NDkx","avatar_url":"https://avatars2.githubusercontent.com/u/17848491?v=4","gravatar_id":"","url":"https://api.github.com/users/otomato-gh","html_url":"https://github.com/otomato-gh","followers_url":"https://api.github.com/users/otomato-gh/followers","following_url":"https://api.github.com/users/otomato-gh/following{/other_user}","gists_url":"https://api.github.com/users/otomato-gh/gists{/gist_id}","starred_url":"https://api.github.com/users/otomato-gh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otomato-gh/subscriptions","organizations_url":"https://api.github.com/users/otomato-gh/orgs","repos_url":"https://api.github.com/users/otomato-gh/repos","events_url":"https://api.github.com/users/otomato-gh/events{/privacy}","received_events_url":"https://api.github.com/users/otomato-gh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/otomato-gh/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/otomato-gh/charts","forks_url":"https://api.github.com/repos/otomato-gh/charts/forks","keys_url":"https://api.github.com/repos/otomato-gh/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otomato-gh/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otomato-gh/charts/teams","hooks_url":"https://api.github.com/repos/otomato-gh/charts/hooks","issue_events_url":"https://api.github.com/repos/otomato-gh/charts/issues/events{/number}","events_url":"https://api.github.com/repos/otomato-gh/charts/events","assignees_url":"https://api.github.com/repos/otomato-gh/charts/assignees{/user}","branches_url":"https://api.github.com/repos/otomato-gh/charts/branches{/branch}","tags_url":"https://api.github.com/repos/otomato-gh/charts/tags","blobs_url":"https://api.github.com/repos/otomato-gh/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otomato-gh/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otomato-gh/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/otomato-gh/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otomato-gh/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/otomato-gh/charts/languages","stargazers_url":"https://api.github.com/repos/otomato-gh/charts/stargazers","contributors_url":"https://api.github.com/repos/otomato-gh/charts/contributors","subscribers_url":"https://api.github.com/repos/otomato-gh/charts/subscribers","subscription_url":"https://api.github.com/repos/otomato-gh/charts/subscription","commits_url":"https://api.github.com/repos/otomato-gh/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/otomato-gh/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/otomato-gh/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/otomato-gh/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/otomato-gh/charts/contents/{+path}","compare_url":"https://api.github.com/repos/otomato-gh/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otomato-gh/charts/merges","archive_url":"https://api.github.com/repos/otomato-gh/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otomato-gh/charts/downloads","issues_url":"https://api.github.com/repos/otomato-gh/charts/issues{/number}","pulls_url":"https://api.github.com/repos/otomato-gh/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/otomato-gh/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/otomato-gh/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otomato-gh/charts/labels{/name}","releases_url":"https://api.github.com/repos/otomato-gh/charts/releases{/id}","deployments_url":"https://api.github.com/repos/otomato-gh/charts/deployments","created_at":"2018-12-31T13:28:43Z","updated_at":"2018-12-31T14:57:21Z","pushed_at":"2018-12-31T14:57:19Z","git_url":"git://github.com/otomato-gh/charts.git","ssh_url":"git@github.com:otomato-gh/charts.git","clone_url":"https://github.com/otomato-gh/charts.git","svn_url":"https://github.com/otomato-gh/charts","homepage":"","size":15209,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"b6ac2a0a33b602f2088300eb0bc6d346d249c65f","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","private":false,"owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-12-31T14:17:30Z","pushed_at":"2018-12-31T14:57:21Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":15210,"stargazers_count":6204,"watchers_count":6204,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5693,"mirror_url":null,"archived":false,"open_issues_count":629,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5693,"open_issues":629,"watchers":6204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/10317"},"html":{"href":"https://github.com/helm/charts/pull/10317"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/10317"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/10317/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/10317/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/10317/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/97c336a77cb60b4e8e9b90039803829bf90ca246"}},"author_association":"NONE"}}
{"actor":{"display_login":"gsemet"}}