{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/dxr/pulls/comments/193701794","pull_request_review_id":126724754,"id":193701794,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzcwMTc5NA==","diff_hunk":"@@ -327,8 +329,125 @@ def get_contents(cls, path, revision, stderr=None):\n                                         filename + '@' + revision],\n                                        cwd=directory, env=env, stderr=stderr)\n \n+class Subversion(Vcs):\n+    command = 'svn'\n+\n+    def __init__(self, root):\n+        super(Subversion, self).__init__(root)\n+        # All tracked files as a dictionary (file => revision).\n+        self.files = self.__get_files_with_revision()","path":"dxr/vcs.py","position":25,"original_position":24,"commit_id":"185b0f647811e2675e09e44bebfe8343ae295b79","original_commit_id":"0c3ab4430cd2286cb92246864088fda0e4f77d0b","user":{"login":"caugner","id":495429,"node_id":"MDQ6VXNlcjQ5NTQyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/495429?v=4","gravatar_id":"","url":"https://api.github.com/users/caugner","html_url":"https://github.com/caugner","followers_url":"https://api.github.com/users/caugner/followers","following_url":"https://api.github.com/users/caugner/following{/other_user}","gists_url":"https://api.github.com/users/caugner/gists{/gist_id}","starred_url":"https://api.github.com/users/caugner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caugner/subscriptions","organizations_url":"https://api.github.com/users/caugner/orgs","repos_url":"https://api.github.com/users/caugner/repos","events_url":"https://api.github.com/users/caugner/events{/privacy}","received_events_url":"https://api.github.com/users/caugner/received_events","type":"User","site_admin":false},"body":"Actually, my implementation of `_get_files_with_revision` does not require a path parameter, see here:\r\nhttps://github.com/mozilla/dxr/pull/580/files#diff-fdc95e419de8a362ed3a4518be94408bR437","created_at":"2018-06-07T10:41:36Z","updated_at":"2018-06-07T10:41:36Z","html_url":"https://github.com/mozilla/dxr/pull/580#discussion_r193701794","pull_request_url":"https://api.github.com/repos/mozilla/dxr/pulls/580","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/comments/193701794"},"html":{"href":"https://github.com/mozilla/dxr/pull/580#discussion_r193701794"},"pull_request":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/580"}},"in_reply_to_id":68816518},"pull_request":{"url":"https://api.github.com/repos/mozilla/dxr/pulls/580","id":75518225,"node_id":"MDExOlB1bGxSZXF1ZXN0NzU1MTgyMjU=","html_url":"https://github.com/mozilla/dxr/pull/580","diff_url":"https://github.com/mozilla/dxr/pull/580.diff","patch_url":"https://github.com/mozilla/dxr/pull/580.patch","issue_url":"https://api.github.com/repos/mozilla/dxr/issues/580","number":580,"state":"open","locked":false,"title":"Add SVN support (#571).","user":{"login":"caugner","id":495429,"node_id":"MDQ6VXNlcjQ5NTQyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/495429?v=4","gravatar_id":"","url":"https://api.github.com/users/caugner","html_url":"https://github.com/caugner","followers_url":"https://api.github.com/users/caugner/followers","following_url":"https://api.github.com/users/caugner/following{/other_user}","gists_url":"https://api.github.com/users/caugner/gists{/gist_id}","starred_url":"https://api.github.com/users/caugner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caugner/subscriptions","organizations_url":"https://api.github.com/users/caugner/orgs","repos_url":"https://api.github.com/users/caugner/repos","events_url":"https://api.github.com/users/caugner/events{/privacy}","received_events_url":"https://api.github.com/users/caugner/received_events","type":"User","site_admin":false},"body":"SVN support: Provide permalink and raw VCS link for subversion repositories.\n","created_at":"2016-06-28T17:33:23Z","updated_at":"2018-06-07T10:41:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd34da525443602a050d16dacf760683dd2cc0e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/dxr/pulls/580/commits","review_comments_url":"https://api.github.com/repos/mozilla/dxr/pulls/580/comments","review_comment_url":"https://api.github.com/repos/mozilla/dxr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/dxr/issues/580/comments","statuses_url":"https://api.github.com/repos/mozilla/dxr/statuses/185b0f647811e2675e09e44bebfe8343ae295b79","head":{"label":"caugner:master","ref":"master","sha":"185b0f647811e2675e09e44bebfe8343ae295b79","user":{"login":"caugner","id":495429,"node_id":"MDQ6VXNlcjQ5NTQyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/495429?v=4","gravatar_id":"","url":"https://api.github.com/users/caugner","html_url":"https://github.com/caugner","followers_url":"https://api.github.com/users/caugner/followers","following_url":"https://api.github.com/users/caugner/following{/other_user}","gists_url":"https://api.github.com/users/caugner/gists{/gist_id}","starred_url":"https://api.github.com/users/caugner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caugner/subscriptions","organizations_url":"https://api.github.com/users/caugner/orgs","repos_url":"https://api.github.com/users/caugner/repos","events_url":"https://api.github.com/users/caugner/events{/privacy}","received_events_url":"https://api.github.com/users/caugner/received_events","type":"User","site_admin":false},"repo":{"id":62160221,"node_id":"MDEwOlJlcG9zaXRvcnk2MjE2MDIyMQ==","name":"dxr","full_name":"caugner/dxr","owner":{"login":"caugner","id":495429,"node_id":"MDQ6VXNlcjQ5NTQyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/495429?v=4","gravatar_id":"","url":"https://api.github.com/users/caugner","html_url":"https://github.com/caugner","followers_url":"https://api.github.com/users/caugner/followers","following_url":"https://api.github.com/users/caugner/following{/other_user}","gists_url":"https://api.github.com/users/caugner/gists{/gist_id}","starred_url":"https://api.github.com/users/caugner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caugner/subscriptions","organizations_url":"https://api.github.com/users/caugner/orgs","repos_url":"https://api.github.com/users/caugner/repos","events_url":"https://api.github.com/users/caugner/events{/privacy}","received_events_url":"https://api.github.com/users/caugner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caugner/dxr","description":"Powerful search for large codebases","fork":true,"url":"https://api.github.com/repos/caugner/dxr","forks_url":"https://api.github.com/repos/caugner/dxr/forks","keys_url":"https://api.github.com/repos/caugner/dxr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caugner/dxr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caugner/dxr/teams","hooks_url":"https://api.github.com/repos/caugner/dxr/hooks","issue_events_url":"https://api.github.com/repos/caugner/dxr/issues/events{/number}","events_url":"https://api.github.com/repos/caugner/dxr/events","assignees_url":"https://api.github.com/repos/caugner/dxr/assignees{/user}","branches_url":"https://api.github.com/repos/caugner/dxr/branches{/branch}","tags_url":"https://api.github.com/repos/caugner/dxr/tags","blobs_url":"https://api.github.com/repos/caugner/dxr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caugner/dxr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caugner/dxr/git/refs{/sha}","trees_url":"https://api.github.com/repos/caugner/dxr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caugner/dxr/statuses/{sha}","languages_url":"https://api.github.com/repos/caugner/dxr/languages","stargazers_url":"https://api.github.com/repos/caugner/dxr/stargazers","contributors_url":"https://api.github.com/repos/caugner/dxr/contributors","subscribers_url":"https://api.github.com/repos/caugner/dxr/subscribers","subscription_url":"https://api.github.com/repos/caugner/dxr/subscription","commits_url":"https://api.github.com/repos/caugner/dxr/commits{/sha}","git_commits_url":"https://api.github.com/repos/caugner/dxr/git/commits{/sha}","comments_url":"https://api.github.com/repos/caugner/dxr/comments{/number}","issue_comment_url":"https://api.github.com/repos/caugner/dxr/issues/comments{/number}","contents_url":"https://api.github.com/repos/caugner/dxr/contents/{+path}","compare_url":"https://api.github.com/repos/caugner/dxr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caugner/dxr/merges","archive_url":"https://api.github.com/repos/caugner/dxr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caugner/dxr/downloads","issues_url":"https://api.github.com/repos/caugner/dxr/issues{/number}","pulls_url":"https://api.github.com/repos/caugner/dxr/pulls{/number}","milestones_url":"https://api.github.com/repos/caugner/dxr/milestones{/number}","notifications_url":"https://api.github.com/repos/caugner/dxr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caugner/dxr/labels{/name}","releases_url":"https://api.github.com/repos/caugner/dxr/releases{/id}","deployments_url":"https://api.github.com/repos/caugner/dxr/deployments","created_at":"2016-06-28T17:15:01Z","updated_at":"2016-06-28T17:15:03Z","pushed_at":"2017-04-28T18:04:24Z","git_url":"git://github.com/caugner/dxr.git","ssh_url":"git@github.com:caugner/dxr.git","clone_url":"https://github.com/caugner/dxr.git","svn_url":"https://github.com/caugner/dxr","homepage":"https://dxr.readthedocs.org/","size":11182,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"d286f55fa2ba3d7ff4ef64cc85652b5945391d39","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1795049,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk1MDQ5","name":"dxr","full_name":"mozilla/dxr","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/dxr","description":"Powerful search for large codebases","fork":false,"url":"https://api.github.com/repos/mozilla/dxr","forks_url":"https://api.github.com/repos/mozilla/dxr/forks","keys_url":"https://api.github.com/repos/mozilla/dxr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/dxr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/dxr/teams","hooks_url":"https://api.github.com/repos/mozilla/dxr/hooks","issue_events_url":"https://api.github.com/repos/mozilla/dxr/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/dxr/events","assignees_url":"https://api.github.com/repos/mozilla/dxr/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/dxr/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/dxr/tags","blobs_url":"https://api.github.com/repos/mozilla/dxr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/dxr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/dxr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/dxr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/dxr/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/dxr/languages","stargazers_url":"https://api.github.com/repos/mozilla/dxr/stargazers","contributors_url":"https://api.github.com/repos/mozilla/dxr/contributors","subscribers_url":"https://api.github.com/repos/mozilla/dxr/subscribers","subscription_url":"https://api.github.com/repos/mozilla/dxr/subscription","commits_url":"https://api.github.com/repos/mozilla/dxr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/dxr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/dxr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/dxr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/dxr/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/dxr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/dxr/merges","archive_url":"https://api.github.com/repos/mozilla/dxr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/dxr/downloads","issues_url":"https://api.github.com/repos/mozilla/dxr/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/dxr/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/dxr/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/dxr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/dxr/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/dxr/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/dxr/deployments","created_at":"2011-05-24T18:52:38Z","updated_at":"2018-06-05T12:57:49Z","pushed_at":"2018-04-27T00:06:13Z","git_url":"git://github.com/mozilla/dxr.git","ssh_url":"git@github.com:mozilla/dxr.git","clone_url":"https://github.com/mozilla/dxr.git","svn_url":"https://github.com/mozilla/dxr","homepage":"https://dxr.readthedocs.org/","size":11264,"stargazers_count":545,"watchers_count":545,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":191,"open_issues":56,"watchers":545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/580"},"html":{"href":"https://github.com/mozilla/dxr/pull/580"},"issue":{"href":"https://api.github.com/repos/mozilla/dxr/issues/580"},"comments":{"href":"https://api.github.com/repos/mozilla/dxr/issues/580/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/580/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/580/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/dxr/statuses/185b0f647811e2675e09e44bebfe8343ae295b79"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"caugner"}}