{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/180354380","pull_request_review_id":110759115,"id":180354380,"diff_hunk":"@@ -39,7 +39,6 @@ const (\n \t// chainHeadChanSize is the size of channel listening to ChainHeadEvent.\n \tchainHeadChanSize = 10\n \t// rmTxChanSize is the size of channel listening to RemovedTransactionEvent.\n-\trmTxChanSize = 10","path":"core/tx_pool.go","position":4,"original_position":4,"commit_id":"639a37dc2899699d761cdad61cfbcd4823bf24b6","original_commit_id":"639a37dc2899699d761cdad61cfbcd4823bf24b6","user":{"login":"karalabe","id":129561,"avatar_url":"https://avatars2.githubusercontent.com/u/129561?v=4","gravatar_id":"","url":"https://api.github.com/users/karalabe","html_url":"https://github.com/karalabe","followers_url":"https://api.github.com/users/karalabe/followers","following_url":"https://api.github.com/users/karalabe/following{/other_user}","gists_url":"https://api.github.com/users/karalabe/gists{/gist_id}","starred_url":"https://api.github.com/users/karalabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karalabe/subscriptions","organizations_url":"https://api.github.com/users/karalabe/orgs","repos_url":"https://api.github.com/users/karalabe/repos","events_url":"https://api.github.com/users/karalabe/events{/privacy}","received_events_url":"https://api.github.com/users/karalabe/received_events","type":"User","site_admin":false},"body":"Please drop comment too.","created_at":"2018-04-10T09:35:23Z","updated_at":"2018-04-10T09:35:24Z","html_url":"https://github.com/ethereum/go-ethereum/pull/16446#discussion_r180354380","pull_request_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16446","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/180354380"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/16446#discussion_r180354380"},"pull_request":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16446"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16446","id":179620940,"html_url":"https://github.com/ethereum/go-ethereum/pull/16446","diff_url":"https://github.com/ethereum/go-ethereum/pull/16446.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/16446.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/16446","number":16446,"state":"open","locked":false,"title":"#15473 - add lint task to makefile, fix all linting errors [WIP]","user":{"login":"thomasmodeneis","id":2600966,"avatar_url":"https://avatars3.githubusercontent.com/u/2600966?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasmodeneis","html_url":"https://github.com/thomasmodeneis","followers_url":"https://api.github.com/users/thomasmodeneis/followers","following_url":"https://api.github.com/users/thomasmodeneis/following{/other_user}","gists_url":"https://api.github.com/users/thomasmodeneis/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasmodeneis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasmodeneis/subscriptions","organizations_url":"https://api.github.com/users/thomasmodeneis/orgs","repos_url":"https://api.github.com/users/thomasmodeneis/repos","events_url":"https://api.github.com/users/thomasmodeneis/events{/privacy}","received_events_url":"https://api.github.com/users/thomasmodeneis/received_events","type":"User","site_admin":false},"body":"This is WIP, the list of linting issues is quite big as follows:\r\nI will start working on fixing the issues now.\r\n\r\nComplete lint report: https://gist.github.com/thomasmodeneis/41e166b9f2fed52ccf29ad123f03a18a\r\n\r\nI see that the actual linting is done inside the `ci.go`, why is that ? \r\n\r\nWhat are the benefits of coupling a linting task inside a go file ? and not doing it on the makefile with simple two liner command ?\r\n\r\nThanks.","created_at":"2018-04-05T09:35:57Z","updated_at":"2018-04-10T09:35:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac2b29c9b38a8a06054dbaffe5a3891a263f4863","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fjl","id":6915,"avatar_url":"https://avatars0.githubusercontent.com/u/6915?v=4","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},{"login":"holiman","id":142290,"avatar_url":"https://avatars1.githubusercontent.com/u/142290?v=4","gravatar_id":"","url":"https://api.github.com/users/holiman","html_url":"https://github.com/holiman","followers_url":"https://api.github.com/users/holiman/followers","following_url":"https://api.github.com/users/holiman/following{/other_user}","gists_url":"https://api.github.com/users/holiman/gists{/gist_id}","starred_url":"https://api.github.com/users/holiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holiman/subscriptions","organizations_url":"https://api.github.com/users/holiman/orgs","repos_url":"https://api.github.com/users/holiman/repos","events_url":"https://api.github.com/users/holiman/events{/privacy}","received_events_url":"https://api.github.com/users/holiman/received_events","type":"User","site_admin":false},{"login":"gballet","id":3272758,"avatar_url":"https://avatars3.githubusercontent.com/u/3272758?v=4","gravatar_id":"","url":"https://api.github.com/users/gballet","html_url":"https://github.com/gballet","followers_url":"https://api.github.com/users/gballet/followers","following_url":"https://api.github.com/users/gballet/following{/other_user}","gists_url":"https://api.github.com/users/gballet/gists{/gist_id}","starred_url":"https://api.github.com/users/gballet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gballet/subscriptions","organizations_url":"https://api.github.com/users/gballet/orgs","repos_url":"https://api.github.com/users/gballet/repos","events_url":"https://api.github.com/users/gballet/events{/privacy}","received_events_url":"https://api.github.com/users/gballet/received_events","type":"User","site_admin":false},{"login":"zsfelfoldi","id":9884311,"avatar_url":"https://avatars0.githubusercontent.com/u/9884311?v=4","gravatar_id":"","url":"https://api.github.com/users/zsfelfoldi","html_url":"https://github.com/zsfelfoldi","followers_url":"https://api.github.com/users/zsfelfoldi/followers","following_url":"https://api.github.com/users/zsfelfoldi/following{/other_user}","gists_url":"https://api.github.com/users/zsfelfoldi/gists{/gist_id}","starred_url":"https://api.github.com/users/zsfelfoldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsfelfoldi/subscriptions","organizations_url":"https://api.github.com/users/zsfelfoldi/orgs","repos_url":"https://api.github.com/users/zsfelfoldi/repos","events_url":"https://api.github.com/users/zsfelfoldi/events{/privacy}","received_events_url":"https://api.github.com/users/zsfelfoldi/received_events","type":"User","site_admin":false},{"login":"gluk256","id":9915581,"avatar_url":"https://avatars1.githubusercontent.com/u/9915581?v=4","gravatar_id":"","url":"https://api.github.com/users/gluk256","html_url":"https://github.com/gluk256","followers_url":"https://api.github.com/users/gluk256/followers","following_url":"https://api.github.com/users/gluk256/following{/other_user}","gists_url":"https://api.github.com/users/gluk256/gists{/gist_id}","starred_url":"https://api.github.com/users/gluk256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluk256/subscriptions","organizations_url":"https://api.github.com/users/gluk256/orgs","repos_url":"https://api.github.com/users/gluk256/repos","events_url":"https://api.github.com/users/gluk256/events{/privacy}","received_events_url":"https://api.github.com/users/gluk256/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16446/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16446/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/16446/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/639a37dc2899699d761cdad61cfbcd4823bf24b6","head":{"label":"modeneis:master","ref":"master","sha":"639a37dc2899699d761cdad61cfbcd4823bf24b6","user":{"login":"modeneis","id":23136516,"avatar_url":"https://avatars0.githubusercontent.com/u/23136516?v=4","gravatar_id":"","url":"https://api.github.com/users/modeneis","html_url":"https://github.com/modeneis","followers_url":"https://api.github.com/users/modeneis/followers","following_url":"https://api.github.com/users/modeneis/following{/other_user}","gists_url":"https://api.github.com/users/modeneis/gists{/gist_id}","starred_url":"https://api.github.com/users/modeneis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modeneis/subscriptions","organizations_url":"https://api.github.com/users/modeneis/orgs","repos_url":"https://api.github.com/users/modeneis/repos","events_url":"https://api.github.com/users/modeneis/events{/privacy}","received_events_url":"https://api.github.com/users/modeneis/received_events","type":"Organization","site_admin":false},"repo":{"id":127867078,"name":"go-ethereum","full_name":"modeneis/go-ethereum","owner":{"login":"modeneis","id":23136516,"avatar_url":"https://avatars0.githubusercontent.com/u/23136516?v=4","gravatar_id":"","url":"https://api.github.com/users/modeneis","html_url":"https://github.com/modeneis","followers_url":"https://api.github.com/users/modeneis/followers","following_url":"https://api.github.com/users/modeneis/following{/other_user}","gists_url":"https://api.github.com/users/modeneis/gists{/gist_id}","starred_url":"https://api.github.com/users/modeneis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modeneis/subscriptions","organizations_url":"https://api.github.com/users/modeneis/orgs","repos_url":"https://api.github.com/users/modeneis/repos","events_url":"https://api.github.com/users/modeneis/events{/privacy}","received_events_url":"https://api.github.com/users/modeneis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modeneis/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":true,"url":"https://api.github.com/repos/modeneis/go-ethereum","forks_url":"https://api.github.com/repos/modeneis/go-ethereum/forks","keys_url":"https://api.github.com/repos/modeneis/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modeneis/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modeneis/go-ethereum/teams","hooks_url":"https://api.github.com/repos/modeneis/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/modeneis/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/modeneis/go-ethereum/events","assignees_url":"https://api.github.com/repos/modeneis/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/modeneis/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/modeneis/go-ethereum/tags","blobs_url":"https://api.github.com/repos/modeneis/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modeneis/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modeneis/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/modeneis/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modeneis/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/modeneis/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/modeneis/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/modeneis/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/modeneis/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/modeneis/go-ethereum/subscription","commits_url":"https://api.github.com/repos/modeneis/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/modeneis/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/modeneis/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/modeneis/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/modeneis/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/modeneis/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modeneis/go-ethereum/merges","archive_url":"https://api.github.com/repos/modeneis/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modeneis/go-ethereum/downloads","issues_url":"https://api.github.com/repos/modeneis/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/modeneis/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/modeneis/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/modeneis/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modeneis/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/modeneis/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/modeneis/go-ethereum/deployments","created_at":"2018-04-03T07:16:22Z","updated_at":"2018-04-09T12:48:29Z","pushed_at":"2018-04-09T12:48:28Z","git_url":"git://github.com/modeneis/go-ethereum.git","ssh_url":"git@github.com:modeneis/go-ethereum.git","clone_url":"https://github.com/modeneis/go-ethereum.git","svn_url":"https://github.com/modeneis/go-ethereum","homepage":"https://geth.ethereum.org","size":97638,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"50dbe8e2444cfc171930cb82cc99017f6a0aadf2","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/go-ethereum/deployments","created_at":"2013-12-26T13:05:46Z","updated_at":"2018-04-10T09:28:53Z","pushed_at":"2018-04-10T09:28:31Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"https://geth.ethereum.org","size":97377,"stargazers_count":16482,"watchers_count":16482,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5175,"mirror_url":null,"archived":false,"open_issues_count":861,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":5175,"open_issues":861,"watchers":16482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16446"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/16446"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/16446"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/16446/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16446/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16446/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/639a37dc2899699d761cdad61cfbcd4823bf24b6"}},"author_association":"NONE"}}
{"actor":{"display_login":"karalabe"}}