{"action":"created","issue":{"url":"https://api.github.com/repos/genevieve/leftovers/issues/34","repository_url":"https://api.github.com/repos/genevieve/leftovers","labels_url":"https://api.github.com/repos/genevieve/leftovers/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/genevieve/leftovers/issues/34/comments","events_url":"https://api.github.com/repos/genevieve/leftovers/issues/34/events","html_url":"https://github.com/genevieve/leftovers/issues/34","id":320387182,"number":34,"title":"Confusing output running `leftovers --dry-run` when there are elastic IPs on a managed NAT gateway","user":{"login":"nmahoney-pivotal","id":12817808,"avatar_url":"https://avatars2.githubusercontent.com/u/12817808?v=4","gravatar_id":"","url":"https://api.github.com/users/nmahoney-pivotal","html_url":"https://github.com/nmahoney-pivotal","followers_url":"https://api.github.com/users/nmahoney-pivotal/followers","following_url":"https://api.github.com/users/nmahoney-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/nmahoney-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/nmahoney-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmahoney-pivotal/subscriptions","organizations_url":"https://api.github.com/users/nmahoney-pivotal/orgs","repos_url":"https://api.github.com/users/nmahoney-pivotal/repos","events_url":"https://api.github.com/users/nmahoney-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/nmahoney-pivotal/received_events","type":"User","site_admin":false},"labels":[{"id":898591462,"url":"https://api.github.com/repos/genevieve/leftovers/labels/AWS","name":"AWS","color":"b8ef8d","default":false},{"id":772862332,"url":"https://api.github.com/repos/genevieve/leftovers/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-04T18:46:57Z","updated_at":"2018-05-05T02:27:00Z","closed_at":null,"author_association":"COLLABORATOR","body":"`aws.Addresses.List` will just add any elastic IP that isn't attached to a VM to the list regardless of filter. This produces confusing results when running `leftovers --dry-run` on an AWS region that has unattached elastic IPs; regardless of where they came from, it lists all EIPs. This includes EIPs that are attached to a managed NAT gateway (or other non-instance resource) *in another VPC*."},"comment":{"url":"https://api.github.com/repos/genevieve/leftovers/issues/comments/386772908","html_url":"https://github.com/genevieve/leftovers/issues/34#issuecomment-386772908","issue_url":"https://api.github.com/repos/genevieve/leftovers/issues/34","id":386772908,"user":{"login":"genevieve","id":12158641,"avatar_url":"https://avatars2.githubusercontent.com/u/12158641?v=4","gravatar_id":"","url":"https://api.github.com/users/genevieve","html_url":"https://github.com/genevieve","followers_url":"https://api.github.com/users/genevieve/followers","following_url":"https://api.github.com/users/genevieve/following{/other_user}","gists_url":"https://api.github.com/users/genevieve/gists{/gist_id}","starred_url":"https://api.github.com/users/genevieve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genevieve/subscriptions","organizations_url":"https://api.github.com/users/genevieve/orgs","repos_url":"https://api.github.com/users/genevieve/repos","events_url":"https://api.github.com/users/genevieve/events{/privacy}","received_events_url":"https://api.github.com/users/genevieve/received_events","type":"User","site_admin":false},"created_at":"2018-05-05T02:27:00Z","updated_at":"2018-05-05T02:27:00Z","author_association":"OWNER","body":"The thing with addresses is that they oftentimes don't have tagging that we can filter on. Oftentimes, they get orphaned from an instance and then there is no way to collect them because they have no associated objects with filterable tags themselves. For this resource in particular, we don't remove them  from the potential list because they might actually be related, and we don't remove them just because they might be in use, because the listing happens before deleting - so an instance that you will approve to delete is still technically using the address at the time we prompt you. Instead, we allow you to try and delete that address but if you don't also agree to delete it's bound instance with `leftovers`, then the aws api will return the error. Otherwise, users would always have to run `leftovers` twice to delete an environment. The first time around they would catch the instance, the second time they would catch the address (if that address somehow retained something we could filter on.)"}}
{"actor":{"display_login":"genevieve"}}