{"action":"created","comment":{"url":"https://api.github.com/repos/rei/rei-cedar/pulls/comments/184817271","pull_request_review_id":116086309,"id":184817271,"diff_hunk":"@@ -0,0 +1,74 @@\n+<template>\n+  <component\n+    :is=\"el\"\n+    :class=\"modifierClass\"\n+    :target=\"target\"\n+    :rel=\"computedRel\"\n+    :href=\"el === 'a' ? href : null /* don't include the href attribute if not an <a> */\"\n+  >\n+    <!-- @slot innerHTML on the inside of the anchor component -->\n+    <cdr-icon use=\"#account-profile\" />\n+\n+    <cdr-icon\n+      v-if=\"iconLeft\"\n+      :use=\"account-profile\" />\n+    <span v-if=\"iconLeft\">{{ iconLeft }}</span>\n+    <slot>Link Text</slot>\n+  </component>\n+</template>\n+\n+<script>\n+import modifier from 'mixinsdir/modifier';\n+import { CdrIcon } from '@rei/cdr-icon';\n+\n+/**\n+ *\n+ * Cedar 2 component for link.\n+ *\n+ * <span class=\"modifiers\">Modifiers</span>\n+ * {on-dark, standalone}\n+ * @version 0.0.1\n+ * @author [REI Software Engineering](https://rei.github.io/rei-cedar/)\n+ */\n+export default {\n+  name: 'CdrLink',\n+  components: {\n+    CdrIcon,\n+  },\n+  mixins: [modifier],\n+  props: {\n+    el: {\n+      type: String,\n+      default: 'a',\n+    },\n+    href: {\n+      type: String,\n+      default: '#',","path":"src/components/link/CdrLink.vue","position":46,"original_position":46,"commit_id":"c92e40ae9541e165f9e26a27533be42033469c59","original_commit_id":"c92e40ae9541e165f9e26a27533be42033469c59","user":{"login":"mhewson","id":5115458,"avatar_url":"https://avatars1.githubusercontent.com/u/5115458?v=4","gravatar_id":"","url":"https://api.github.com/users/mhewson","html_url":"https://github.com/mhewson","followers_url":"https://api.github.com/users/mhewson/followers","following_url":"https://api.github.com/users/mhewson/following{/other_user}","gists_url":"https://api.github.com/users/mhewson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhewson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhewson/subscriptions","organizations_url":"https://api.github.com/users/mhewson/orgs","repos_url":"https://api.github.com/users/mhewson/repos","events_url":"https://api.github.com/users/mhewson/events{/privacy}","received_events_url":"https://api.github.com/users/mhewson/received_events","type":"User","site_admin":false},"body":"the `#` standalone is not an accessible solution for this element. It would be rad to send a error/ warning to the console for this that asks that the implementers use the button element for links that will not have valid URL's  \r\n\r\nI almost want to explore defaulting this the a `button` until they explicitly request a `href`","created_at":"2018-04-27T22:05:53Z","updated_at":"2018-04-27T22:10:28Z","html_url":"https://github.com/rei/rei-cedar/pull/411#discussion_r184817271","pull_request_url":"https://api.github.com/repos/rei/rei-cedar/pulls/411","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/rei/rei-cedar/pulls/comments/184817271"},"html":{"href":"https://github.com/rei/rei-cedar/pull/411#discussion_r184817271"},"pull_request":{"href":"https://api.github.com/repos/rei/rei-cedar/pulls/411"}}},"pull_request":{"url":"https://api.github.com/repos/rei/rei-cedar/pulls/411","id":184159846,"html_url":"https://github.com/rei/rei-cedar/pull/411","diff_url":"https://github.com/rei/rei-cedar/pull/411.diff","patch_url":"https://github.com/rei/rei-cedar/pull/411.patch","issue_url":"https://api.github.com/repos/rei/rei-cedar/issues/411","number":411,"state":"open","locked":false,"title":"Feat/plib 1871  link cedar","user":{"login":"kevinmpowell","id":979463,"avatar_url":"https://avatars1.githubusercontent.com/u/979463?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinmpowell","html_url":"https://github.com/kevinmpowell","followers_url":"https://api.github.com/users/kevinmpowell/followers","following_url":"https://api.github.com/users/kevinmpowell/following{/other_user}","gists_url":"https://api.github.com/users/kevinmpowell/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinmpowell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinmpowell/subscriptions","organizations_url":"https://api.github.com/users/kevinmpowell/orgs","repos_url":"https://api.github.com/users/kevinmpowell/repos","events_url":"https://api.github.com/users/kevinmpowell/events{/privacy}","received_events_url":"https://api.github.com/users/kevinmpowell/received_events","type":"User","site_admin":false},"body":"@mhewson I still was unable to get `git cz` to work properly so I used the `--no-verify` arg to bypass whatever it was doing. I did get all my tests to pass locally except the visual diffing. Since this component completely changed (including its name) there's not really a baseline to visual diff against.\r\n\r\nMainly putting this up because I'm ready to receive more direct and actionable feedback on the code.","created_at":"2018-04-25T20:51:51Z","updated_at":"2018-04-27T22:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"700b1259d2cf12c439951c75ba6d08a23cfcafa7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rei/rei-cedar/pulls/411/commits","review_comments_url":"https://api.github.com/repos/rei/rei-cedar/pulls/411/comments","review_comment_url":"https://api.github.com/repos/rei/rei-cedar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rei/rei-cedar/issues/411/comments","statuses_url":"https://api.github.com/repos/rei/rei-cedar/statuses/c92e40ae9541e165f9e26a27533be42033469c59","head":{"label":"rei:feat/PLIB-1871--link-cedar","ref":"feat/PLIB-1871--link-cedar","sha":"c92e40ae9541e165f9e26a27533be42033469c59","user":{"login":"rei","id":6014050,"avatar_url":"https://avatars2.githubusercontent.com/u/6014050?v=4","gravatar_id":"","url":"https://api.github.com/users/rei","html_url":"https://github.com/rei","followers_url":"https://api.github.com/users/rei/followers","following_url":"https://api.github.com/users/rei/following{/other_user}","gists_url":"https://api.github.com/users/rei/gists{/gist_id}","starred_url":"https://api.github.com/users/rei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rei/subscriptions","organizations_url":"https://api.github.com/users/rei/orgs","repos_url":"https://api.github.com/users/rei/repos","events_url":"https://api.github.com/users/rei/events{/privacy}","received_events_url":"https://api.github.com/users/rei/received_events","type":"Organization","site_admin":false},"repo":{"id":51038668,"name":"rei-cedar","full_name":"rei/rei-cedar","owner":{"login":"rei","id":6014050,"avatar_url":"https://avatars2.githubusercontent.com/u/6014050?v=4","gravatar_id":"","url":"https://api.github.com/users/rei","html_url":"https://github.com/rei","followers_url":"https://api.github.com/users/rei/followers","following_url":"https://api.github.com/users/rei/following{/other_user}","gists_url":"https://api.github.com/users/rei/gists{/gist_id}","starred_url":"https://api.github.com/users/rei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rei/subscriptions","organizations_url":"https://api.github.com/users/rei/orgs","repos_url":"https://api.github.com/users/rei/repos","events_url":"https://api.github.com/users/rei/events{/privacy}","received_events_url":"https://api.github.com/users/rei/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rei/rei-cedar","description":"Welcome to the REI Digital Design System presentation framework. A home for modular components based on our evolving design patterns.","fork":false,"url":"https://api.github.com/repos/rei/rei-cedar","forks_url":"https://api.github.com/repos/rei/rei-cedar/forks","keys_url":"https://api.github.com/repos/rei/rei-cedar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rei/rei-cedar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rei/rei-cedar/teams","hooks_url":"https://api.github.com/repos/rei/rei-cedar/hooks","issue_events_url":"https://api.github.com/repos/rei/rei-cedar/issues/events{/number}","events_url":"https://api.github.com/repos/rei/rei-cedar/events","assignees_url":"https://api.github.com/repos/rei/rei-cedar/assignees{/user}","branches_url":"https://api.github.com/repos/rei/rei-cedar/branches{/branch}","tags_url":"https://api.github.com/repos/rei/rei-cedar/tags","blobs_url":"https://api.github.com/repos/rei/rei-cedar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rei/rei-cedar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rei/rei-cedar/git/refs{/sha}","trees_url":"https://api.github.com/repos/rei/rei-cedar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rei/rei-cedar/statuses/{sha}","languages_url":"https://api.github.com/repos/rei/rei-cedar/languages","stargazers_url":"https://api.github.com/repos/rei/rei-cedar/stargazers","contributors_url":"https://api.github.com/repos/rei/rei-cedar/contributors","subscribers_url":"https://api.github.com/repos/rei/rei-cedar/subscribers","subscription_url":"https://api.github.com/repos/rei/rei-cedar/subscription","commits_url":"https://api.github.com/repos/rei/rei-cedar/commits{/sha}","git_commits_url":"https://api.github.com/repos/rei/rei-cedar/git/commits{/sha}","comments_url":"https://api.github.com/repos/rei/rei-cedar/comments{/number}","issue_comment_url":"https://api.github.com/repos/rei/rei-cedar/issues/comments{/number}","contents_url":"https://api.github.com/repos/rei/rei-cedar/contents/{+path}","compare_url":"https://api.github.com/repos/rei/rei-cedar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rei/rei-cedar/merges","archive_url":"https://api.github.com/repos/rei/rei-cedar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rei/rei-cedar/downloads","issues_url":"https://api.github.com/repos/rei/rei-cedar/issues{/number}","pulls_url":"https://api.github.com/repos/rei/rei-cedar/pulls{/number}","milestones_url":"https://api.github.com/repos/rei/rei-cedar/milestones{/number}","notifications_url":"https://api.github.com/repos/rei/rei-cedar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rei/rei-cedar/labels{/name}","releases_url":"https://api.github.com/repos/rei/rei-cedar/releases{/id}","deployments_url":"https://api.github.com/repos/rei/rei-cedar/deployments","created_at":"2016-02-03T23:35:50Z","updated_at":"2018-04-06T18:22:59Z","pushed_at":"2018-04-27T20:40:03Z","git_url":"git://github.com/rei/rei-cedar.git","ssh_url":"git@github.com:rei/rei-cedar.git","clone_url":"https://github.com/rei/rei-cedar.git","svn_url":"https://github.com/rei/rei-cedar","homepage":"http://rei.github.io/rei-cedar/","size":34327,"stargazers_count":21,"watchers_count":21,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":7,"watchers":21,"default_branch":"master"}},"base":{"label":"rei:cedar2","ref":"cedar2","sha":"d6ca71ecde1c66776130f4f76d6fb96792ee2bd3","user":{"login":"rei","id":6014050,"avatar_url":"https://avatars2.githubusercontent.com/u/6014050?v=4","gravatar_id":"","url":"https://api.github.com/users/rei","html_url":"https://github.com/rei","followers_url":"https://api.github.com/users/rei/followers","following_url":"https://api.github.com/users/rei/following{/other_user}","gists_url":"https://api.github.com/users/rei/gists{/gist_id}","starred_url":"https://api.github.com/users/rei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rei/subscriptions","organizations_url":"https://api.github.com/users/rei/orgs","repos_url":"https://api.github.com/users/rei/repos","events_url":"https://api.github.com/users/rei/events{/privacy}","received_events_url":"https://api.github.com/users/rei/received_events","type":"Organization","site_admin":false},"repo":{"id":51038668,"name":"rei-cedar","full_name":"rei/rei-cedar","owner":{"login":"rei","id":6014050,"avatar_url":"https://avatars2.githubusercontent.com/u/6014050?v=4","gravatar_id":"","url":"https://api.github.com/users/rei","html_url":"https://github.com/rei","followers_url":"https://api.github.com/users/rei/followers","following_url":"https://api.github.com/users/rei/following{/other_user}","gists_url":"https://api.github.com/users/rei/gists{/gist_id}","starred_url":"https://api.github.com/users/rei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rei/subscriptions","organizations_url":"https://api.github.com/users/rei/orgs","repos_url":"https://api.github.com/users/rei/repos","events_url":"https://api.github.com/users/rei/events{/privacy}","received_events_url":"https://api.github.com/users/rei/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rei/rei-cedar","description":"Welcome to the REI Digital Design System presentation framework. A home for modular components based on our evolving design patterns.","fork":false,"url":"https://api.github.com/repos/rei/rei-cedar","forks_url":"https://api.github.com/repos/rei/rei-cedar/forks","keys_url":"https://api.github.com/repos/rei/rei-cedar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rei/rei-cedar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rei/rei-cedar/teams","hooks_url":"https://api.github.com/repos/rei/rei-cedar/hooks","issue_events_url":"https://api.github.com/repos/rei/rei-cedar/issues/events{/number}","events_url":"https://api.github.com/repos/rei/rei-cedar/events","assignees_url":"https://api.github.com/repos/rei/rei-cedar/assignees{/user}","branches_url":"https://api.github.com/repos/rei/rei-cedar/branches{/branch}","tags_url":"https://api.github.com/repos/rei/rei-cedar/tags","blobs_url":"https://api.github.com/repos/rei/rei-cedar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rei/rei-cedar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rei/rei-cedar/git/refs{/sha}","trees_url":"https://api.github.com/repos/rei/rei-cedar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rei/rei-cedar/statuses/{sha}","languages_url":"https://api.github.com/repos/rei/rei-cedar/languages","stargazers_url":"https://api.github.com/repos/rei/rei-cedar/stargazers","contributors_url":"https://api.github.com/repos/rei/rei-cedar/contributors","subscribers_url":"https://api.github.com/repos/rei/rei-cedar/subscribers","subscription_url":"https://api.github.com/repos/rei/rei-cedar/subscription","commits_url":"https://api.github.com/repos/rei/rei-cedar/commits{/sha}","git_commits_url":"https://api.github.com/repos/rei/rei-cedar/git/commits{/sha}","comments_url":"https://api.github.com/repos/rei/rei-cedar/comments{/number}","issue_comment_url":"https://api.github.com/repos/rei/rei-cedar/issues/comments{/number}","contents_url":"https://api.github.com/repos/rei/rei-cedar/contents/{+path}","compare_url":"https://api.github.com/repos/rei/rei-cedar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rei/rei-cedar/merges","archive_url":"https://api.github.com/repos/rei/rei-cedar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rei/rei-cedar/downloads","issues_url":"https://api.github.com/repos/rei/rei-cedar/issues{/number}","pulls_url":"https://api.github.com/repos/rei/rei-cedar/pulls{/number}","milestones_url":"https://api.github.com/repos/rei/rei-cedar/milestones{/number}","notifications_url":"https://api.github.com/repos/rei/rei-cedar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rei/rei-cedar/labels{/name}","releases_url":"https://api.github.com/repos/rei/rei-cedar/releases{/id}","deployments_url":"https://api.github.com/repos/rei/rei-cedar/deployments","created_at":"2016-02-03T23:35:50Z","updated_at":"2018-04-06T18:22:59Z","pushed_at":"2018-04-27T20:40:03Z","git_url":"git://github.com/rei/rei-cedar.git","ssh_url":"git@github.com:rei/rei-cedar.git","clone_url":"https://github.com/rei/rei-cedar.git","svn_url":"https://github.com/rei/rei-cedar","homepage":"http://rei.github.io/rei-cedar/","size":34327,"stargazers_count":21,"watchers_count":21,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":7,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rei/rei-cedar/pulls/411"},"html":{"href":"https://github.com/rei/rei-cedar/pull/411"},"issue":{"href":"https://api.github.com/repos/rei/rei-cedar/issues/411"},"comments":{"href":"https://api.github.com/repos/rei/rei-cedar/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/rei/rei-cedar/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/rei/rei-cedar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rei/rei-cedar/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/rei/rei-cedar/statuses/c92e40ae9541e165f9e26a27533be42033469c59"}},"author_association":"NONE"}}
{"actor":{"display_login":"mhewson"}}