{"action":"created","issue":{"url":"https://api.github.com/repos/kubeflow/kubeflow/issues/444","repository_url":"https://api.github.com/repos/kubeflow/kubeflow","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/444/labels{/name}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/444/comments","events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/444/events","html_url":"https://github.com/kubeflow/kubeflow/pull/444","id":306112076,"number":444,"title":"set termination policy to worker 0 by default when no master exists","user":{"login":"raddaoui","id":16418855,"avatar_url":"https://avatars0.githubusercontent.com/u/16418855?v=4","gravatar_id":"","url":"https://api.github.com/users/raddaoui","html_url":"https://github.com/raddaoui","followers_url":"https://api.github.com/users/raddaoui/followers","following_url":"https://api.github.com/users/raddaoui/following{/other_user}","gists_url":"https://api.github.com/users/raddaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/raddaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raddaoui/subscriptions","organizations_url":"https://api.github.com/users/raddaoui/orgs","repos_url":"https://api.github.com/users/raddaoui/repos","events_url":"https://api.github.com/users/raddaoui/events{/privacy}","received_events_url":"https://api.github.com/users/raddaoui/received_events","type":"User","site_admin":false},"labels":[{"id":796371394,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-17T00:27:44Z","updated_at":"2018-03-17T00:27:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/444","html_url":"https://github.com/kubeflow/kubeflow/pull/444","diff_url":"https://github.com/kubeflow/kubeflow/pull/444.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/444.patch"},"body":"most tensorflow training examples use worker 0 as the chief worker instead of master. \r\nusing ksonnet tf-job prototype to create training jobs dosen't allow that\r\nand will make the tfjob fails if we set num_masters to 0.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/444)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments/373878804","html_url":"https://github.com/kubeflow/kubeflow/pull/444#issuecomment-373878804","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/444","id":373878804,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-03-17T00:27:51Z","updated_at":"2018-03-17T00:27:51Z","author_association":"COLLABORATOR","body":"Hi @raddaoui. Thanks for your PR.\n\nI'm waiting for a [kubeflow](https://github.com/orgs/kubeflow/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://github.com/kubeflow/kubeflow/blob/master/CONTRIBUTING.md) to skip this step.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}