{"action":"opened","number":90,"pull_request":{"url":"https://api.github.com/repos/aws/lumberyard/pulls/90","id":177665651,"html_url":"https://github.com/aws/lumberyard/pull/90","diff_url":"https://github.com/aws/lumberyard/pull/90.diff","patch_url":"https://github.com/aws/lumberyard/pull/90.patch","issue_url":"https://api.github.com/repos/aws/lumberyard/issues/90","number":90,"state":"open","locked":false,"title":"39) Fix for crash due to slice instantiation","user":{"login":"tkgdhughes","id":36986799,"avatar_url":"https://avatars1.githubusercontent.com/u/36986799?v=4","gravatar_id":"","url":"https://api.github.com/users/tkgdhughes","html_url":"https://github.com/tkgdhughes","followers_url":"https://api.github.com/users/tkgdhughes/followers","following_url":"https://api.github.com/users/tkgdhughes/following{/other_user}","gists_url":"https://api.github.com/users/tkgdhughes/gists{/gist_id}","starred_url":"https://api.github.com/users/tkgdhughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkgdhughes/subscriptions","organizations_url":"https://api.github.com/users/tkgdhughes/orgs","repos_url":"https://api.github.com/users/tkgdhughes/repos","events_url":"https://api.github.com/users/tkgdhughes/events{/privacy}","received_events_url":"https://api.github.com/users/tkgdhughes/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nIf slices are instantiated from an OnAssetReady callback, the slice instantiation queue can be modified whilst iterating causing a crash.\r\nThe fix presented is to temporarily swap the queue for a blank one during the processing, so that new slices do not invalidate the iterators, and then recombine the queues after iterating.","created_at":"2018-03-27T08:29:27Z","updated_at":"2018-03-27T08:29:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/lumberyard/pulls/90/commits","review_comments_url":"https://api.github.com/repos/aws/lumberyard/pulls/90/comments","review_comment_url":"https://api.github.com/repos/aws/lumberyard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/lumberyard/issues/90/comments","statuses_url":"https://api.github.com/repos/aws/lumberyard/statuses/050ffdbaec38f7e9078529929fbdbd6a02dab18f","head":{"label":"thirdkindgames:THIRD_KIND_SLICE_QUEUE_WHILE_PROCESSING","ref":"THIRD_KIND_SLICE_QUEUE_WHILE_PROCESSING","sha":"050ffdbaec38f7e9078529929fbdbd6a02dab18f","user":{"login":"thirdkindgames","id":28574182,"avatar_url":"https://avatars0.githubusercontent.com/u/28574182?v=4","gravatar_id":"","url":"https://api.github.com/users/thirdkindgames","html_url":"https://github.com/thirdkindgames","followers_url":"https://api.github.com/users/thirdkindgames/followers","following_url":"https://api.github.com/users/thirdkindgames/following{/other_user}","gists_url":"https://api.github.com/users/thirdkindgames/gists{/gist_id}","starred_url":"https://api.github.com/users/thirdkindgames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thirdkindgames/subscriptions","organizations_url":"https://api.github.com/users/thirdkindgames/orgs","repos_url":"https://api.github.com/users/thirdkindgames/repos","events_url":"https://api.github.com/users/thirdkindgames/events{/privacy}","received_events_url":"https://api.github.com/users/thirdkindgames/received_events","type":"Organization","site_admin":false},"repo":{"id":101515319,"name":"Lumberyard","full_name":"thirdkindgames/Lumberyard","owner":{"login":"thirdkindgames","id":28574182,"avatar_url":"https://avatars0.githubusercontent.com/u/28574182?v=4","gravatar_id":"","url":"https://api.github.com/users/thirdkindgames","html_url":"https://github.com/thirdkindgames","followers_url":"https://api.github.com/users/thirdkindgames/followers","following_url":"https://api.github.com/users/thirdkindgames/following{/other_user}","gists_url":"https://api.github.com/users/thirdkindgames/gists{/gist_id}","starred_url":"https://api.github.com/users/thirdkindgames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thirdkindgames/subscriptions","organizations_url":"https://api.github.com/users/thirdkindgames/orgs","repos_url":"https://api.github.com/users/thirdkindgames/repos","events_url":"https://api.github.com/users/thirdkindgames/events{/privacy}","received_events_url":"https://api.github.com/users/thirdkindgames/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thirdkindgames/Lumberyard","description":"Amazon Lumberyard is a free AAA game engine deeply integrated with AWS and Twitch – with full source. ","fork":true,"url":"https://api.github.com/repos/thirdkindgames/Lumberyard","forks_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/forks","keys_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/teams","hooks_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/hooks","issue_events_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/issues/events{/number}","events_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/events","assignees_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/assignees{/user}","branches_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/branches{/branch}","tags_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/tags","blobs_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/git/refs{/sha}","trees_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/statuses/{sha}","languages_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/languages","stargazers_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/stargazers","contributors_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/contributors","subscribers_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/subscribers","subscription_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/subscription","commits_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/commits{/sha}","git_commits_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/git/commits{/sha}","comments_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/comments{/number}","issue_comment_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/issues/comments{/number}","contents_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/contents/{+path}","compare_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/merges","archive_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/downloads","issues_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/issues{/number}","pulls_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/pulls{/number}","milestones_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/milestones{/number}","notifications_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/labels{/name}","releases_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/releases{/id}","deployments_url":"https://api.github.com/repos/thirdkindgames/Lumberyard/deployments","created_at":"2017-08-26T21:54:32Z","updated_at":"2018-03-23T10:10:19Z","pushed_at":"2018-03-27T08:24:27Z","git_url":"git://github.com/thirdkindgames/Lumberyard.git","ssh_url":"git@github.com:thirdkindgames/Lumberyard.git","clone_url":"https://github.com/thirdkindgames/Lumberyard.git","svn_url":"https://github.com/thirdkindgames/Lumberyard","homepage":null,"size":85651,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:1.13","ref":"1.13","sha":"9608bcf905bb60e9f326bd3fe8297381c22d83a6","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":95851346,"name":"lumberyard","full_name":"aws/lumberyard","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/lumberyard","description":"Amazon Lumberyard is a free AAA game engine deeply integrated with AWS and Twitch – with full source.","fork":false,"url":"https://api.github.com/repos/aws/lumberyard","forks_url":"https://api.github.com/repos/aws/lumberyard/forks","keys_url":"https://api.github.com/repos/aws/lumberyard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/lumberyard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/lumberyard/teams","hooks_url":"https://api.github.com/repos/aws/lumberyard/hooks","issue_events_url":"https://api.github.com/repos/aws/lumberyard/issues/events{/number}","events_url":"https://api.github.com/repos/aws/lumberyard/events","assignees_url":"https://api.github.com/repos/aws/lumberyard/assignees{/user}","branches_url":"https://api.github.com/repos/aws/lumberyard/branches{/branch}","tags_url":"https://api.github.com/repos/aws/lumberyard/tags","blobs_url":"https://api.github.com/repos/aws/lumberyard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/lumberyard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/lumberyard/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/lumberyard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/lumberyard/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/lumberyard/languages","stargazers_url":"https://api.github.com/repos/aws/lumberyard/stargazers","contributors_url":"https://api.github.com/repos/aws/lumberyard/contributors","subscribers_url":"https://api.github.com/repos/aws/lumberyard/subscribers","subscription_url":"https://api.github.com/repos/aws/lumberyard/subscription","commits_url":"https://api.github.com/repos/aws/lumberyard/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/lumberyard/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/lumberyard/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/lumberyard/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/lumberyard/contents/{+path}","compare_url":"https://api.github.com/repos/aws/lumberyard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/lumberyard/merges","archive_url":"https://api.github.com/repos/aws/lumberyard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/lumberyard/downloads","issues_url":"https://api.github.com/repos/aws/lumberyard/issues{/number}","pulls_url":"https://api.github.com/repos/aws/lumberyard/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/lumberyard/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/lumberyard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/lumberyard/labels{/name}","releases_url":"https://api.github.com/repos/aws/lumberyard/releases{/id}","deployments_url":"https://api.github.com/repos/aws/lumberyard/deployments","created_at":"2017-06-30T05:18:43Z","updated_at":"2018-03-27T05:32:47Z","pushed_at":"2018-03-27T08:20:13Z","git_url":"git://github.com/aws/lumberyard.git","ssh_url":"git@github.com:aws/lumberyard.git","clone_url":"https://github.com/aws/lumberyard.git","svn_url":"https://github.com/aws/lumberyard","homepage":"","size":81952,"stargazers_count":562,"watchers_count":562,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":196,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":196,"open_issues":35,"watchers":562,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/lumberyard/pulls/90"},"html":{"href":"https://github.com/aws/lumberyard/pull/90"},"issue":{"href":"https://api.github.com/repos/aws/lumberyard/issues/90"},"comments":{"href":"https://api.github.com/repos/aws/lumberyard/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/lumberyard/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/lumberyard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/lumberyard/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/aws/lumberyard/statuses/050ffdbaec38f7e9078529929fbdbd6a02dab18f"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":10,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"tkgdhughes"}}