{"action":"created","comment":{"url":"https://api.github.com/repos/Skyscanner/backpack/pulls/comments/199112859","pull_request_review_id":133164141,"id":199112859,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTExMjg1OQ==","diff_hunk":"@@ -0,0 +1,70 @@\n+/*\n+ * Backpack - Skyscanner's Design System\n+ *\n+ * Copyright 2018 Skyscanner Ltd\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+/* @flow */\n+\n+import React from 'react';\n+import { Platform, type StyleObj, View, ViewPropTypes } from 'react-native';\n+import PropTypes from 'prop-types';\n+\n+import BpkIcon from 'react-native-bpk-component-icon';\n+import BpkTouchableNativeFeedback from 'react-native-bpk-component-touchable-native-feedback';\n+import BpkTouchableOverlay from 'react-native-bpk-component-touchable-overlay';\n+\n+type Props = {\n+  onPress: () => mixed,\n+  style: StyleObj,\n+};\n+\n+const BpkChipDismissButton = (props: Props) => {\n+  const { style, ...rest } = props;\n+  const { Touchable, touchableProps } = Platform.select({\n+    android: {\n+      Touchable: BpkTouchableNativeFeedback,\n+      touchableProps: {\n+        accessibilityComponentType: 'button',\n+      },\n+    },\n+    ios: {\n+      Touchable: BpkTouchableOverlay,\n+      touchableProps: {\n+        accessibilityTraits: ['button'],\n+        borderRadius: 'sm',\n+      },\n+    },\n+  });\n+\n+  return (\n+    <Touchable {...touchableProps} {...rest}>\n+      <View style={style}>\n+        <BpkIcon icon=\"close\" small />","path":"native/packages/react-native-bpk-component-chip/src/BpkChipDismissButton.js","position":55,"original_position":55,"commit_id":"a46640948ebf5d570f40dcfb8312368f2d6bdcec","original_commit_id":"a46640948ebf5d570f40dcfb8312368f2d6bdcec","user":{"login":"k0nserv","id":1333960,"node_id":"MDQ6VXNlcjEzMzM5NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1333960?v=4","gravatar_id":"","url":"https://api.github.com/users/k0nserv","html_url":"https://github.com/k0nserv","followers_url":"https://api.github.com/users/k0nserv/followers","following_url":"https://api.github.com/users/k0nserv/following{/other_user}","gists_url":"https://api.github.com/users/k0nserv/gists{/gist_id}","starred_url":"https://api.github.com/users/k0nserv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k0nserv/subscriptions","organizations_url":"https://api.github.com/users/k0nserv/orgs","repos_url":"https://api.github.com/users/k0nserv/repos","events_url":"https://api.github.com/users/k0nserv/events{/privacy}","received_events_url":"https://api.github.com/users/k0nserv/received_events","type":"User","site_admin":false},"body":"What's the tap area of this component? Is it sufficiently large?","created_at":"2018-06-29T10:00:15Z","updated_at":"2018-06-29T10:03:00Z","html_url":"https://github.com/Skyscanner/backpack/pull/880#discussion_r199112859","pull_request_url":"https://api.github.com/repos/Skyscanner/backpack/pulls/880","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Skyscanner/backpack/pulls/comments/199112859"},"html":{"href":"https://github.com/Skyscanner/backpack/pull/880#discussion_r199112859"},"pull_request":{"href":"https://api.github.com/repos/Skyscanner/backpack/pulls/880"}}},"pull_request":{"url":"https://api.github.com/repos/Skyscanner/backpack/pulls/880","id":197783602,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NzgzNjAy","html_url":"https://github.com/Skyscanner/backpack/pull/880","diff_url":"https://github.com/Skyscanner/backpack/pull/880.diff","patch_url":"https://github.com/Skyscanner/backpack/pull/880.patch","issue_url":"https://api.github.com/repos/Skyscanner/backpack/issues/880","number":880,"state":"open","locked":false,"title":"[BPK-1688] Add native chip components","user":{"login":"shaundon","id":73652,"node_id":"MDQ6VXNlcjczNjUy","avatar_url":"https://avatars1.githubusercontent.com/u/73652?v=4","gravatar_id":"","url":"https://api.github.com/users/shaundon","html_url":"https://github.com/shaundon","followers_url":"https://api.github.com/users/shaundon/followers","following_url":"https://api.github.com/users/shaundon/following{/other_user}","gists_url":"https://api.github.com/users/shaundon/gists{/gist_id}","starred_url":"https://api.github.com/users/shaundon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaundon/subscriptions","organizations_url":"https://api.github.com/users/shaundon/orgs","repos_url":"https://api.github.com/users/shaundon/repos","events_url":"https://api.github.com/users/shaundon/events{/privacy}","received_events_url":"https://api.github.com/users/shaundon/received_events","type":"User","site_admin":false},"body":"**To do**\r\n\r\n- [x] Readme\r\n- [x] Tests\r\n- [x] Implementation\r\n- [x] Stories\r\n- [x] Changelog\r\n- [x] Flow\r\n- [x] Fix sizing\r\n- [x] Fix Android feedback\r\n- [x] Clarify selected state with Will\r\n- [x] Fix icon alignment issue\r\n- [x] Screenshots\r\n\r\nDocs are in #883.\r\n\r\nHere are some screenshots:\r\n\r\n![screenshot_1530199892](https://user-images.githubusercontent.com/73652/42044428-e49509f4-7af0-11e8-8f97-8439daa54cfa.png)\r\n\r\n![simulator screen shot - iphone 6 - 2018-06-28 at 16 31 38](https://user-images.githubusercontent.com/73652/42044432-e736056e-7af0-11e8-822f-82e7bbec030c.png)\r\n\r\n","created_at":"2018-06-27T16:13:22Z","updated_at":"2018-06-29T10:03:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba94081d44de0a1e59df5806f313e405c5429881","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":566606285,"node_id":"MDU6TGFiZWw1NjY2MDYyODU=","url":"https://api.github.com/repos/Skyscanner/backpack/labels/Needs%20design%20review","name":"Needs design review","color":"00b2d6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Skyscanner/backpack/pulls/880/commits","review_comments_url":"https://api.github.com/repos/Skyscanner/backpack/pulls/880/comments","review_comment_url":"https://api.github.com/repos/Skyscanner/backpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Skyscanner/backpack/issues/880/comments","statuses_url":"https://api.github.com/repos/Skyscanner/backpack/statuses/a46640948ebf5d570f40dcfb8312368f2d6bdcec","head":{"label":"Skyscanner:BPK-1688-chips-n-gravy","ref":"BPK-1688-chips-n-gravy","sha":"a46640948ebf5d570f40dcfb8312368f2d6bdcec","user":{"login":"Skyscanner","id":522811,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjgxMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/522811?v=4","gravatar_id":"","url":"https://api.github.com/users/Skyscanner","html_url":"https://github.com/Skyscanner","followers_url":"https://api.github.com/users/Skyscanner/followers","following_url":"https://api.github.com/users/Skyscanner/following{/other_user}","gists_url":"https://api.github.com/users/Skyscanner/gists{/gist_id}","starred_url":"https://api.github.com/users/Skyscanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skyscanner/subscriptions","organizations_url":"https://api.github.com/users/Skyscanner/orgs","repos_url":"https://api.github.com/users/Skyscanner/repos","events_url":"https://api.github.com/users/Skyscanner/events{/privacy}","received_events_url":"https://api.github.com/users/Skyscanner/received_events","type":"Organization","site_admin":false},"repo":{"id":85820377,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgyMDM3Nw==","name":"backpack","full_name":"Skyscanner/backpack","owner":{"login":"Skyscanner","id":522811,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjgxMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/522811?v=4","gravatar_id":"","url":"https://api.github.com/users/Skyscanner","html_url":"https://github.com/Skyscanner","followers_url":"https://api.github.com/users/Skyscanner/followers","following_url":"https://api.github.com/users/Skyscanner/following{/other_user}","gists_url":"https://api.github.com/users/Skyscanner/gists{/gist_id}","starred_url":"https://api.github.com/users/Skyscanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skyscanner/subscriptions","organizations_url":"https://api.github.com/users/Skyscanner/orgs","repos_url":"https://api.github.com/users/Skyscanner/repos","events_url":"https://api.github.com/users/Skyscanner/events{/privacy}","received_events_url":"https://api.github.com/users/Skyscanner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Skyscanner/backpack","description":"Backpack Design System","fork":false,"url":"https://api.github.com/repos/Skyscanner/backpack","forks_url":"https://api.github.com/repos/Skyscanner/backpack/forks","keys_url":"https://api.github.com/repos/Skyscanner/backpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Skyscanner/backpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Skyscanner/backpack/teams","hooks_url":"https://api.github.com/repos/Skyscanner/backpack/hooks","issue_events_url":"https://api.github.com/repos/Skyscanner/backpack/issues/events{/number}","events_url":"https://api.github.com/repos/Skyscanner/backpack/events","assignees_url":"https://api.github.com/repos/Skyscanner/backpack/assignees{/user}","branches_url":"https://api.github.com/repos/Skyscanner/backpack/branches{/branch}","tags_url":"https://api.github.com/repos/Skyscanner/backpack/tags","blobs_url":"https://api.github.com/repos/Skyscanner/backpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Skyscanner/backpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Skyscanner/backpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Skyscanner/backpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Skyscanner/backpack/statuses/{sha}","languages_url":"https://api.github.com/repos/Skyscanner/backpack/languages","stargazers_url":"https://api.github.com/repos/Skyscanner/backpack/stargazers","contributors_url":"https://api.github.com/repos/Skyscanner/backpack/contributors","subscribers_url":"https://api.github.com/repos/Skyscanner/backpack/subscribers","subscription_url":"https://api.github.com/repos/Skyscanner/backpack/subscription","commits_url":"https://api.github.com/repos/Skyscanner/backpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Skyscanner/backpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Skyscanner/backpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Skyscanner/backpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/Skyscanner/backpack/contents/{+path}","compare_url":"https://api.github.com/repos/Skyscanner/backpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Skyscanner/backpack/merges","archive_url":"https://api.github.com/repos/Skyscanner/backpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Skyscanner/backpack/downloads","issues_url":"https://api.github.com/repos/Skyscanner/backpack/issues{/number}","pulls_url":"https://api.github.com/repos/Skyscanner/backpack/pulls{/number}","milestones_url":"https://api.github.com/repos/Skyscanner/backpack/milestones{/number}","notifications_url":"https://api.github.com/repos/Skyscanner/backpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Skyscanner/backpack/labels{/name}","releases_url":"https://api.github.com/repos/Skyscanner/backpack/releases{/id}","deployments_url":"https://api.github.com/repos/Skyscanner/backpack/deployments","created_at":"2017-03-22T11:34:41Z","updated_at":"2018-06-29T09:25:14Z","pushed_at":"2018-06-29T09:30:20Z","git_url":"git://github.com/Skyscanner/backpack.git","ssh_url":"git@github.com:Skyscanner/backpack.git","clone_url":"https://github.com/Skyscanner/backpack.git","svn_url":"https://github.com/Skyscanner/backpack","homepage":"https://backpack.github.io","size":73338,"stargazers_count":162,"watchers_count":162,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":56,"open_issues":13,"watchers":162,"default_branch":"master"}},"base":{"label":"Skyscanner:master","ref":"master","sha":"3c56c7d15e0e8d17a03d650277fb86f3e2e41574","user":{"login":"Skyscanner","id":522811,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjgxMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/522811?v=4","gravatar_id":"","url":"https://api.github.com/users/Skyscanner","html_url":"https://github.com/Skyscanner","followers_url":"https://api.github.com/users/Skyscanner/followers","following_url":"https://api.github.com/users/Skyscanner/following{/other_user}","gists_url":"https://api.github.com/users/Skyscanner/gists{/gist_id}","starred_url":"https://api.github.com/users/Skyscanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skyscanner/subscriptions","organizations_url":"https://api.github.com/users/Skyscanner/orgs","repos_url":"https://api.github.com/users/Skyscanner/repos","events_url":"https://api.github.com/users/Skyscanner/events{/privacy}","received_events_url":"https://api.github.com/users/Skyscanner/received_events","type":"Organization","site_admin":false},"repo":{"id":85820377,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgyMDM3Nw==","name":"backpack","full_name":"Skyscanner/backpack","owner":{"login":"Skyscanner","id":522811,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjgxMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/522811?v=4","gravatar_id":"","url":"https://api.github.com/users/Skyscanner","html_url":"https://github.com/Skyscanner","followers_url":"https://api.github.com/users/Skyscanner/followers","following_url":"https://api.github.com/users/Skyscanner/following{/other_user}","gists_url":"https://api.github.com/users/Skyscanner/gists{/gist_id}","starred_url":"https://api.github.com/users/Skyscanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skyscanner/subscriptions","organizations_url":"https://api.github.com/users/Skyscanner/orgs","repos_url":"https://api.github.com/users/Skyscanner/repos","events_url":"https://api.github.com/users/Skyscanner/events{/privacy}","received_events_url":"https://api.github.com/users/Skyscanner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Skyscanner/backpack","description":"Backpack Design System","fork":false,"url":"https://api.github.com/repos/Skyscanner/backpack","forks_url":"https://api.github.com/repos/Skyscanner/backpack/forks","keys_url":"https://api.github.com/repos/Skyscanner/backpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Skyscanner/backpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Skyscanner/backpack/teams","hooks_url":"https://api.github.com/repos/Skyscanner/backpack/hooks","issue_events_url":"https://api.github.com/repos/Skyscanner/backpack/issues/events{/number}","events_url":"https://api.github.com/repos/Skyscanner/backpack/events","assignees_url":"https://api.github.com/repos/Skyscanner/backpack/assignees{/user}","branches_url":"https://api.github.com/repos/Skyscanner/backpack/branches{/branch}","tags_url":"https://api.github.com/repos/Skyscanner/backpack/tags","blobs_url":"https://api.github.com/repos/Skyscanner/backpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Skyscanner/backpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Skyscanner/backpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Skyscanner/backpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Skyscanner/backpack/statuses/{sha}","languages_url":"https://api.github.com/repos/Skyscanner/backpack/languages","stargazers_url":"https://api.github.com/repos/Skyscanner/backpack/stargazers","contributors_url":"https://api.github.com/repos/Skyscanner/backpack/contributors","subscribers_url":"https://api.github.com/repos/Skyscanner/backpack/subscribers","subscription_url":"https://api.github.com/repos/Skyscanner/backpack/subscription","commits_url":"https://api.github.com/repos/Skyscanner/backpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Skyscanner/backpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Skyscanner/backpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Skyscanner/backpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/Skyscanner/backpack/contents/{+path}","compare_url":"https://api.github.com/repos/Skyscanner/backpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Skyscanner/backpack/merges","archive_url":"https://api.github.com/repos/Skyscanner/backpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Skyscanner/backpack/downloads","issues_url":"https://api.github.com/repos/Skyscanner/backpack/issues{/number}","pulls_url":"https://api.github.com/repos/Skyscanner/backpack/pulls{/number}","milestones_url":"https://api.github.com/repos/Skyscanner/backpack/milestones{/number}","notifications_url":"https://api.github.com/repos/Skyscanner/backpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Skyscanner/backpack/labels{/name}","releases_url":"https://api.github.com/repos/Skyscanner/backpack/releases{/id}","deployments_url":"https://api.github.com/repos/Skyscanner/backpack/deployments","created_at":"2017-03-22T11:34:41Z","updated_at":"2018-06-29T09:25:14Z","pushed_at":"2018-06-29T09:30:20Z","git_url":"git://github.com/Skyscanner/backpack.git","ssh_url":"git@github.com:Skyscanner/backpack.git","clone_url":"https://github.com/Skyscanner/backpack.git","svn_url":"https://github.com/Skyscanner/backpack","homepage":"https://backpack.github.io","size":73338,"stargazers_count":162,"watchers_count":162,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":56,"open_issues":13,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Skyscanner/backpack/pulls/880"},"html":{"href":"https://github.com/Skyscanner/backpack/pull/880"},"issue":{"href":"https://api.github.com/repos/Skyscanner/backpack/issues/880"},"comments":{"href":"https://api.github.com/repos/Skyscanner/backpack/issues/880/comments"},"review_comments":{"href":"https://api.github.com/repos/Skyscanner/backpack/pulls/880/comments"},"review_comment":{"href":"https://api.github.com/repos/Skyscanner/backpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Skyscanner/backpack/pulls/880/commits"},"statuses":{"href":"https://api.github.com/repos/Skyscanner/backpack/statuses/a46640948ebf5d570f40dcfb8312368f2d6bdcec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"k0nserv"}}