{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls/comments/229771884","pull_request_review_id":170351209,"id":229771884,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTc3MTg4NA==","diff_hunk":"@@ -11,8 +11,42 @@\n \n   let(:swagger_routes) { Api::Docs.routes }\n \n-  it \"routes match\" do\n-    expect(rails_routes).to match_array(swagger_routes)\n+  describe \"Routing\" do\n+    include Rails.application.routes.url_helpers\n+\n+    it \"routes match\" do\n+      expect(rails_routes).to match_array(swagger_routes)\n+    end\n+\n+    it \"allows customizable routes\" do","path":"spec/swagger_spec.rb","position":13,"original_position":13,"commit_id":"02269372f8b747613d18d16f2274c497888270cf","original_commit_id":"02269372f8b747613d18d16f2274c497888270cf","user":{"login":"carbonin","id":12697904,"node_id":"MDQ6VXNlcjEyNjk3OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/12697904?v=4","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false},"body":"Can you also test for the default value?","created_at":"2018-10-31T16:31:12Z","updated_at":"2018-10-31T16:31:12Z","html_url":"https://github.com/ManageIQ/topological_inventory-api/pull/32#discussion_r229771884","pull_request_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls/32","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls/comments/229771884"},"html":{"href":"https://github.com/ManageIQ/topological_inventory-api/pull/32#discussion_r229771884"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls/32","id":226217248,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjE3MjQ4","html_url":"https://github.com/ManageIQ/topological_inventory-api/pull/32","diff_url":"https://github.com/ManageIQ/topological_inventory-api/pull/32.diff","patch_url":"https://github.com/ManageIQ/topological_inventory-api/pull/32.patch","issue_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/issues/32","number":32,"state":"open","locked":false,"title":"Customizable routes path prefix","user":{"login":"bdunne","id":651659,"node_id":"MDQ6VXNlcjY1MTY1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/651659?v=4","gravatar_id":"","url":"https://api.github.com/users/bdunne","html_url":"https://github.com/bdunne","followers_url":"https://api.github.com/users/bdunne/followers","following_url":"https://api.github.com/users/bdunne/following{/other_user}","gists_url":"https://api.github.com/users/bdunne/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunne/subscriptions","organizations_url":"https://api.github.com/users/bdunne/orgs","repos_url":"https://api.github.com/users/bdunne/repos","events_url":"https://api.github.com/users/bdunne/events{/privacy}","received_events_url":"https://api.github.com/users/bdunne/received_events","type":"User","site_admin":false},"body":"Allow for ENV[\"PATH_PREFIX\"] to change the base path for the api routes.","created_at":"2018-10-26T20:29:02Z","updated_at":"2018-10-31T16:31:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"144f89ee72c70c481b5829c61840292ac496a65e","assignee":{"login":"Fryguy","id":52120,"node_id":"MDQ6VXNlcjUyMTIw","avatar_url":"https://avatars3.githubusercontent.com/u/52120?v=4","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"assignees":[{"login":"Fryguy","id":52120,"node_id":"MDQ6VXNlcjUyMTIw","avatar_url":"https://avatars3.githubusercontent.com/u/52120?v=4","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"gtanzillo","id":76593,"node_id":"MDQ6VXNlcjc2NTkz","avatar_url":"https://avatars3.githubusercontent.com/u/76593?v=4","gravatar_id":"","url":"https://api.github.com/users/gtanzillo","html_url":"https://github.com/gtanzillo","followers_url":"https://api.github.com/users/gtanzillo/followers","following_url":"https://api.github.com/users/gtanzillo/following{/other_user}","gists_url":"https://api.github.com/users/gtanzillo/gists{/gist_id}","starred_url":"https://api.github.com/users/gtanzillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtanzillo/subscriptions","organizations_url":"https://api.github.com/users/gtanzillo/orgs","repos_url":"https://api.github.com/users/gtanzillo/repos","events_url":"https://api.github.com/users/gtanzillo/events{/privacy}","received_events_url":"https://api.github.com/users/gtanzillo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1079667331,"node_id":"MDU6TGFiZWwxMDc5NjY3MzMx","url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls/32/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls/32/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/issues/32/comments","statuses_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/statuses/02269372f8b747613d18d16f2274c497888270cf","head":{"label":"bdunne:routes_path_prefix","ref":"routes_path_prefix","sha":"02269372f8b747613d18d16f2274c497888270cf","user":{"login":"bdunne","id":651659,"node_id":"MDQ6VXNlcjY1MTY1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/651659?v=4","gravatar_id":"","url":"https://api.github.com/users/bdunne","html_url":"https://github.com/bdunne","followers_url":"https://api.github.com/users/bdunne/followers","following_url":"https://api.github.com/users/bdunne/following{/other_user}","gists_url":"https://api.github.com/users/bdunne/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunne/subscriptions","organizations_url":"https://api.github.com/users/bdunne/orgs","repos_url":"https://api.github.com/users/bdunne/repos","events_url":"https://api.github.com/users/bdunne/events{/privacy}","received_events_url":"https://api.github.com/users/bdunne/received_events","type":"User","site_admin":false},"repo":{"id":152294356,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIyOTQzNTY=","name":"topological_inventory-api","full_name":"bdunne/topological_inventory-api","private":false,"owner":{"login":"bdunne","id":651659,"node_id":"MDQ6VXNlcjY1MTY1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/651659?v=4","gravatar_id":"","url":"https://api.github.com/users/bdunne","html_url":"https://github.com/bdunne","followers_url":"https://api.github.com/users/bdunne/followers","following_url":"https://api.github.com/users/bdunne/following{/other_user}","gists_url":"https://api.github.com/users/bdunne/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunne/subscriptions","organizations_url":"https://api.github.com/users/bdunne/orgs","repos_url":"https://api.github.com/users/bdunne/repos","events_url":"https://api.github.com/users/bdunne/events{/privacy}","received_events_url":"https://api.github.com/users/bdunne/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bdunne/topological_inventory-api","description":null,"fork":true,"url":"https://api.github.com/repos/bdunne/topological_inventory-api","forks_url":"https://api.github.com/repos/bdunne/topological_inventory-api/forks","keys_url":"https://api.github.com/repos/bdunne/topological_inventory-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bdunne/topological_inventory-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bdunne/topological_inventory-api/teams","hooks_url":"https://api.github.com/repos/bdunne/topological_inventory-api/hooks","issue_events_url":"https://api.github.com/repos/bdunne/topological_inventory-api/issues/events{/number}","events_url":"https://api.github.com/repos/bdunne/topological_inventory-api/events","assignees_url":"https://api.github.com/repos/bdunne/topological_inventory-api/assignees{/user}","branches_url":"https://api.github.com/repos/bdunne/topological_inventory-api/branches{/branch}","tags_url":"https://api.github.com/repos/bdunne/topological_inventory-api/tags","blobs_url":"https://api.github.com/repos/bdunne/topological_inventory-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bdunne/topological_inventory-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bdunne/topological_inventory-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/bdunne/topological_inventory-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bdunne/topological_inventory-api/statuses/{sha}","languages_url":"https://api.github.com/repos/bdunne/topological_inventory-api/languages","stargazers_url":"https://api.github.com/repos/bdunne/topological_inventory-api/stargazers","contributors_url":"https://api.github.com/repos/bdunne/topological_inventory-api/contributors","subscribers_url":"https://api.github.com/repos/bdunne/topological_inventory-api/subscribers","subscription_url":"https://api.github.com/repos/bdunne/topological_inventory-api/subscription","commits_url":"https://api.github.com/repos/bdunne/topological_inventory-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/bdunne/topological_inventory-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/bdunne/topological_inventory-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/bdunne/topological_inventory-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/bdunne/topological_inventory-api/contents/{+path}","compare_url":"https://api.github.com/repos/bdunne/topological_inventory-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bdunne/topological_inventory-api/merges","archive_url":"https://api.github.com/repos/bdunne/topological_inventory-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bdunne/topological_inventory-api/downloads","issues_url":"https://api.github.com/repos/bdunne/topological_inventory-api/issues{/number}","pulls_url":"https://api.github.com/repos/bdunne/topological_inventory-api/pulls{/number}","milestones_url":"https://api.github.com/repos/bdunne/topological_inventory-api/milestones{/number}","notifications_url":"https://api.github.com/repos/bdunne/topological_inventory-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bdunne/topological_inventory-api/labels{/name}","releases_url":"https://api.github.com/repos/bdunne/topological_inventory-api/releases{/id}","deployments_url":"https://api.github.com/repos/bdunne/topological_inventory-api/deployments","created_at":"2018-10-09T17:39:31Z","updated_at":"2018-10-10T20:03:08Z","pushed_at":"2018-10-31T14:47:09Z","git_url":"git://github.com/bdunne/topological_inventory-api.git","ssh_url":"git@github.com:bdunne/topological_inventory-api.git","clone_url":"https://github.com/bdunne/topological_inventory-api.git","svn_url":"https://github.com/bdunne/topological_inventory-api","homepage":null,"size":133,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"e6c1895e538f192bdf97cf6d1ab1295d7c9e2921","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":151619276,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE2MTkyNzY=","name":"topological_inventory-api","full_name":"ManageIQ/topological_inventory-api","private":false,"owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ManageIQ/topological_inventory-api","description":null,"fork":false,"url":"https://api.github.com/repos/ManageIQ/topological_inventory-api","forks_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/forks","keys_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/teams","hooks_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/events","assignees_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/tags","blobs_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/subscription","commits_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/merges","archive_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/downloads","issues_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/topological_inventory-api/deployments","created_at":"2018-10-04T18:39:27Z","updated_at":"2018-10-31T14:41:58Z","pushed_at":"2018-10-31T14:41:56Z","git_url":"git://github.com/ManageIQ/topological_inventory-api.git","ssh_url":"git@github.com:ManageIQ/topological_inventory-api.git","clone_url":"https://github.com/ManageIQ/topological_inventory-api.git","svn_url":"https://github.com/ManageIQ/topological_inventory-api","homepage":null,"size":135,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls/32"},"html":{"href":"https://github.com/ManageIQ/topological_inventory-api/pull/32"},"issue":{"href":"https://api.github.com/repos/ManageIQ/topological_inventory-api/issues/32"},"comments":{"href":"https://api.github.com/repos/ManageIQ/topological_inventory-api/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/topological_inventory-api/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/topological_inventory-api/statuses/02269372f8b747613d18d16f2274c497888270cf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"carbonin"}}