{"action":"created","issue":{"url":"https://api.github.com/repos/hubblestack/hubble/issues/314","repository_url":"https://api.github.com/repos/hubblestack/hubble","labels_url":"https://api.github.com/repos/hubblestack/hubble/issues/314/labels{/name}","comments_url":"https://api.github.com/repos/hubblestack/hubble/issues/314/comments","events_url":"https://api.github.com/repos/hubblestack/hubble/issues/314/events","html_url":"https://github.com/hubblestack/hubble/pull/314","id":306809718,"number":314,"title":"Clear cache of azurefs containers which are not accessible anymore","user":{"login":"yassingh","id":29591578,"avatar_url":"https://avatars1.githubusercontent.com/u/29591578?v=4","gravatar_id":"","url":"https://api.github.com/users/yassingh","html_url":"https://github.com/yassingh","followers_url":"https://api.github.com/users/yassingh/followers","following_url":"https://api.github.com/users/yassingh/following{/other_user}","gists_url":"https://api.github.com/users/yassingh/gists{/gist_id}","starred_url":"https://api.github.com/users/yassingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yassingh/subscriptions","organizations_url":"https://api.github.com/users/yassingh/orgs","repos_url":"https://api.github.com/users/yassingh/repos","events_url":"https://api.github.com/users/yassingh/events{/privacy}","received_events_url":"https://api.github.com/users/yassingh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-20T10:37:03Z","updated_at":"2018-03-22T10:03:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hubblestack/hubble/pulls/314","html_url":"https://github.com/hubblestack/hubble/pull/314","diff_url":"https://github.com/hubblestack/hubble/pull/314.diff","patch_url":"https://github.com/hubblestack/hubble/pull/314.patch"},"body":"If an azurefs container is not accessible for hubble host, it's cache folder is deleted so that the stale files are not served from that container anymore.\r\n\r\nNOTE: In case all the containers are inaccessible, cache folder will deleted for all containers. But in this case, the code will not reach the part where 'hashes' directory is deleted. As a result, hubble will keep serving the file from the last azurefs state if all the containers are inaccessible."},"comment":{"url":"https://api.github.com/repos/hubblestack/hubble/issues/comments/375242133","html_url":"https://github.com/hubblestack/hubble/pull/314#issuecomment-375242133","issue_url":"https://api.github.com/repos/hubblestack/hubble/issues/314","id":375242133,"user":{"login":"yassingh","id":29591578,"avatar_url":"https://avatars1.githubusercontent.com/u/29591578?v=4","gravatar_id":"","url":"https://api.github.com/users/yassingh","html_url":"https://github.com/yassingh","followers_url":"https://api.github.com/users/yassingh/followers","following_url":"https://api.github.com/users/yassingh/following{/other_user}","gists_url":"https://api.github.com/users/yassingh/gists{/gist_id}","starred_url":"https://api.github.com/users/yassingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yassingh/subscriptions","organizations_url":"https://api.github.com/users/yassingh/orgs","repos_url":"https://api.github.com/users/yassingh/repos","events_url":"https://api.github.com/users/yassingh/events{/privacy}","received_events_url":"https://api.github.com/users/yassingh/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T10:03:42Z","updated_at":"2018-03-22T10:03:42Z","author_association":"CONTRIBUTOR","body":">> What happens in the case of a network outage? \r\n\r\nI tried to hinder the internet connectivity ( by creating a fake dns server in /etc/resolv.conf ).\r\nThe exception message was different in this case, something like \r\n```Failed to establish a new connection...```\r\nAnd containers were not affected anyhow in this case.\r\nIf you can think of some other way(s) to test it, do let me know. I will check with them as well.\r\n\r\n\r\n\r\n>>  I'm not sure that your evaluation of the \"if all are inaccessible\" situation is correct, however....But new files will not.\r\n\r\nIf even a single container is accessible, 'hashes' folder will be deleted. So the updated files will be served. \r\n'hashes' folder will not be deleted only in one case, i.e. when all the containers are inaccessible. And in this case, it would be best to serve stale files. Fortunately, this is already happening with current code.\r\n\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"yassingh"}}