{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8587","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8587/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8587/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8587/events","html_url":"https://github.com/ARMmbed/mbed-os/pull/8587","id":375490935,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTIyODA2","number":8587,"title":"Remove extra _deselect to prevent possible hard fault","user":{"login":"jarlamsa","id":33447468,"node_id":"MDQ6VXNlcjMzNDQ3NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/33447468?v=4","gravatar_id":"","url":"https://api.github.com/users/jarlamsa","html_url":"https://github.com/jarlamsa","followers_url":"https://api.github.com/users/jarlamsa/followers","following_url":"https://api.github.com/users/jarlamsa/following{/other_user}","gists_url":"https://api.github.com/users/jarlamsa/gists{/gist_id}","starred_url":"https://api.github.com/users/jarlamsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarlamsa/subscriptions","organizations_url":"https://api.github.com/users/jarlamsa/orgs","repos_url":"https://api.github.com/users/jarlamsa/repos","events_url":"https://api.github.com/users/jarlamsa/events{/privacy}","received_events_url":"https://api.github.com/users/jarlamsa/received_events","type":"User","site_admin":false},"labels":[{"id":147112891,"node_id":"MDU6TGFiZWwxNDcxMTI4OTE=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-30T13:33:20Z","updated_at":"2018-11-05T16:02:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8587","html_url":"https://github.com/ARMmbed/mbed-os/pull/8587","diff_url":"https://github.com/ARMmbed/mbed-os/pull/8587.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/8587.patch"},"body":"### Description\r\n\r\nIf read timeout happens, the _deselect will get called twice causing a hard fault happening when mutex is released without being locked. \r\nThe SDBlockDevice::read is calling the _deselect in every case.\r\n\r\n### Pull request type\r\n\r\n<!-- \r\n    Required\r\n    Please add only one X to one of the following types. Do not fill multiple types (split the pull request otherwise).\r\n    Please note this is not a GitHub task list, indenting the boxes or changing the format to add a '.' or '*' in front\r\n    of them would change the meaning incorrectly. The only changes to be made are to add a description text under the\r\n    description heading and to add a 'x' to the correct box.\r\n-->\r\n    [x] Fix\r\n    [ ] Refactor\r\n    [ ] Target update\r\n    [ ] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments/435929274","html_url":"https://github.com/ARMmbed/mbed-os/pull/8587#issuecomment-435929274","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8587","id":435929274,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTkyOTI3NA==","user":{"login":"deepikabhavnani","id":28542450,"node_id":"MDQ6VXNlcjI4NTQyNDUw","avatar_url":"https://avatars3.githubusercontent.com/u/28542450?v=4","gravatar_id":"","url":"https://api.github.com/users/deepikabhavnani","html_url":"https://github.com/deepikabhavnani","followers_url":"https://api.github.com/users/deepikabhavnani/followers","following_url":"https://api.github.com/users/deepikabhavnani/following{/other_user}","gists_url":"https://api.github.com/users/deepikabhavnani/gists{/gist_id}","starred_url":"https://api.github.com/users/deepikabhavnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepikabhavnani/subscriptions","organizations_url":"https://api.github.com/users/deepikabhavnani/orgs","repos_url":"https://api.github.com/users/deepikabhavnani/repos","events_url":"https://api.github.com/users/deepikabhavnani/events{/privacy}","received_events_url":"https://api.github.com/users/deepikabhavnani/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T16:02:00Z","updated_at":"2018-11-05T16:02:00Z","author_association":"CONTRIBUTOR","body":"> If read timeout happens, the _deselect will get called twice\r\n\r\n_deselect is called once here `https://github.com/ARMmbed/mbed-os/pull/8587/files#diff-fab2d13deb54b56303334ba4f340d4deL895` as per the code change, which is the other location it is called from ?"}}
{"actor":{"display_login":"deepikabhavnani"}}