{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/188663132","pull_request_review_id":120687063,"id":188663132,"diff_hunk":"@@ -172,6 +172,23 @@ double HGCalDDDConstants::cellSizeHex(int type) const {\n   return cell;\n }\n \n+int HGCalDDDConstants::getLayer(double z, bool reco) const {\n+  int    lay = (int)(hgpar_->zLayerHex_.size());\n+  double zz  = std::abs(z);\n+  for (unsigned int k=1; k<hgpar_->zLayerHex_.size(); ++k) {","path":"Geometry/HGCalCommonData/src/HGCalDDDConstants.cc","position":7,"original_position":7,"commit_id":"62a60dcb25918a179bee49823753a505be11b50f","original_commit_id":"be2b56287475c2f12b01a8283824ea7fd357a052","user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars0.githubusercontent.com/u/4672808?v=4","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"body":"You can use an arbitrary lambda in `find_if()`, but since this comparison requires two elements from the vector, I don't think `find_if()` will work.","created_at":"2018-05-16T15:11:37Z","updated_at":"2018-05-16T15:11:37Z","html_url":"https://github.com/cms-sw/cmssw/pull/23211#discussion_r188663132","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23211","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/188663132"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/23211#discussion_r188663132"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23211"}},"in_reply_to_id":188534612},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23211","id":188278228,"html_url":"https://github.com/cms-sw/cmssw/pull/23211","diff_url":"https://github.com/cms-sw/cmssw/pull/23211.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/23211.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23211","number":23211,"state":"open","locked":false,"title":"Phase2-hgx111 Modify reco geometry/topology for post TDR HGCAL","user":{"login":"bsunanda","id":5033146,"avatar_url":"https://avatars1.githubusercontent.com/u/5033146?v=4","gravatar_id":"","url":"https://api.github.com/users/bsunanda","html_url":"https://github.com/bsunanda","followers_url":"https://api.github.com/users/bsunanda/followers","following_url":"https://api.github.com/users/bsunanda/following{/other_user}","gists_url":"https://api.github.com/users/bsunanda/gists{/gist_id}","starred_url":"https://api.github.com/users/bsunanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsunanda/subscriptions","organizations_url":"https://api.github.com/users/bsunanda/orgs","repos_url":"https://api.github.com/users/bsunanda/repos","events_url":"https://api.github.com/users/bsunanda/events{/privacy}","received_events_url":"https://api.github.com/users/bsunanda/received_events","type":"User","site_admin":false},"body":"Now Reco Geometry/topology can handle the new geometry. No provision of finding neighbours yet","created_at":"2018-05-15T22:59:09Z","updated_at":"2018-05-16T15:11:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3cfc7cecc1025723d149e1432d138f71942565e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52881721,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-pending","name":"geometry-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820523,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":170521617,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"ff8000","default":false},{"id":530655448,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/upgrade-pending","name":"upgrade-pending","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":311,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-05-16T14:47:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23211/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23211/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23211/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/62a60dcb25918a179bee49823753a505be11b50f","head":{"label":"bsunanda:Phase2-hgx111","ref":"Phase2-hgx111","sha":"62a60dcb25918a179bee49823753a505be11b50f","user":{"login":"bsunanda","id":5033146,"avatar_url":"https://avatars1.githubusercontent.com/u/5033146?v=4","gravatar_id":"","url":"https://api.github.com/users/bsunanda","html_url":"https://github.com/bsunanda","followers_url":"https://api.github.com/users/bsunanda/followers","following_url":"https://api.github.com/users/bsunanda/following{/other_user}","gists_url":"https://api.github.com/users/bsunanda/gists{/gist_id}","starred_url":"https://api.github.com/users/bsunanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsunanda/subscriptions","organizations_url":"https://api.github.com/users/bsunanda/orgs","repos_url":"https://api.github.com/users/bsunanda/repos","events_url":"https://api.github.com/users/bsunanda/events{/privacy}","received_events_url":"https://api.github.com/users/bsunanda/received_events","type":"User","site_admin":false},"repo":{"id":11500018,"name":"cmssw","full_name":"bsunanda/cmssw","owner":{"login":"bsunanda","id":5033146,"avatar_url":"https://avatars1.githubusercontent.com/u/5033146?v=4","gravatar_id":"","url":"https://api.github.com/users/bsunanda","html_url":"https://github.com/bsunanda","followers_url":"https://api.github.com/users/bsunanda/followers","following_url":"https://api.github.com/users/bsunanda/following{/other_user}","gists_url":"https://api.github.com/users/bsunanda/gists{/gist_id}","starred_url":"https://api.github.com/users/bsunanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsunanda/subscriptions","organizations_url":"https://api.github.com/users/bsunanda/orgs","repos_url":"https://api.github.com/users/bsunanda/repos","events_url":"https://api.github.com/users/bsunanda/events{/privacy}","received_events_url":"https://api.github.com/users/bsunanda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bsunanda/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/bsunanda/cmssw","forks_url":"https://api.github.com/repos/bsunanda/cmssw/forks","keys_url":"https://api.github.com/repos/bsunanda/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsunanda/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsunanda/cmssw/teams","hooks_url":"https://api.github.com/repos/bsunanda/cmssw/hooks","issue_events_url":"https://api.github.com/repos/bsunanda/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/bsunanda/cmssw/events","assignees_url":"https://api.github.com/repos/bsunanda/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/bsunanda/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/bsunanda/cmssw/tags","blobs_url":"https://api.github.com/repos/bsunanda/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsunanda/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsunanda/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsunanda/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsunanda/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/bsunanda/cmssw/languages","stargazers_url":"https://api.github.com/repos/bsunanda/cmssw/stargazers","contributors_url":"https://api.github.com/repos/bsunanda/cmssw/contributors","subscribers_url":"https://api.github.com/repos/bsunanda/cmssw/subscribers","subscription_url":"https://api.github.com/repos/bsunanda/cmssw/subscription","commits_url":"https://api.github.com/repos/bsunanda/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsunanda/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsunanda/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsunanda/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsunanda/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/bsunanda/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsunanda/cmssw/merges","archive_url":"https://api.github.com/repos/bsunanda/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsunanda/cmssw/downloads","issues_url":"https://api.github.com/repos/bsunanda/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/bsunanda/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/bsunanda/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/bsunanda/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsunanda/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/bsunanda/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/bsunanda/cmssw/deployments","created_at":"2013-07-18T10:17:16Z","updated_at":"2014-06-25T09:42:43Z","pushed_at":"2018-05-16T13:49:56Z","git_url":"git://github.com/bsunanda/cmssw.git","ssh_url":"git@github.com:bsunanda/cmssw.git","clone_url":"https://github.com/bsunanda/cmssw.git","svn_url":"https://github.com/bsunanda/cmssw","homepage":"cms-sw.github.io/cmssw","size":972120,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:master","ref":"master","sha":"fd85f8fc419869845d4a7ff08a84e0603fb4e0ae","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-05-16T09:04:35Z","pushed_at":"2018-05-16T14:46:46Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1002251,"stargazers_count":548,"watchers_count":548,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2565,"mirror_url":null,"archived":false,"open_issues_count":422,"license":null,"forks":2565,"open_issues":422,"watchers":548,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23211"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/23211"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23211"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23211/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23211/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23211/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/62a60dcb25918a179bee49823753a505be11b50f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kpedro88"}}