{"action":"created","issue":{"url":"https://api.github.com/repos/rocket-pool/rocketpool/issues/35","repository_url":"https://api.github.com/repos/rocket-pool/rocketpool","labels_url":"https://api.github.com/repos/rocket-pool/rocketpool/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/rocket-pool/rocketpool/issues/35/comments","events_url":"https://api.github.com/repos/rocket-pool/rocketpool/issues/35/events","html_url":"https://github.com/rocket-pool/rocketpool/pull/35","id":320167081,"number":35,"title":"cleaned up deployment script callbacks","user":{"login":"moles1","id":2696205,"avatar_url":"https://avatars0.githubusercontent.com/u/2696205?v=4","gravatar_id":"","url":"https://api.github.com/users/moles1","html_url":"https://github.com/moles1","followers_url":"https://api.github.com/users/moles1/followers","following_url":"https://api.github.com/users/moles1/following{/other_user}","gists_url":"https://api.github.com/users/moles1/gists{/gist_id}","starred_url":"https://api.github.com/users/moles1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moles1/subscriptions","organizations_url":"https://api.github.com/users/moles1/orgs","repos_url":"https://api.github.com/users/moles1/repos","events_url":"https://api.github.com/users/moles1/events{/privacy}","received_events_url":"https://api.github.com/users/moles1/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-04T06:38:07Z","updated_at":"2018-05-16T22:02:17Z","closed_at":"2018-05-15T00:43:27Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/rocket-pool/rocketpool/pulls/35","html_url":"https://github.com/rocket-pool/rocketpool/pull/35","diff_url":"https://github.com/rocket-pool/rocketpool/pull/35.diff","patch_url":"https://github.com/rocket-pool/rocketpool/pull/35.patch"},"body":"Unfortunately async/await causes issues with Truffle's deployer (as per https://github.com/rocket-pool/rocketpool/pull/22). However, I have cleaned up the deployment script by:\r\n- Chaining promises rather than nesting them within resolution callbacks\r\n- Using deployer.deploy() array syntax to batch deployments where possible\r\n- Putting post-deployment actions at the end of the promise chain\r\n\r\nShould help to make the script more maintainable."},"comment":{"url":"https://api.github.com/repos/rocket-pool/rocketpool/issues/comments/389680063","html_url":"https://github.com/rocket-pool/rocketpool/pull/35#issuecomment-389680063","issue_url":"https://api.github.com/repos/rocket-pool/rocketpool/issues/35","id":389680063,"user":{"login":"maryokhin","id":4390231,"avatar_url":"https://avatars2.githubusercontent.com/u/4390231?v=4","gravatar_id":"","url":"https://api.github.com/users/maryokhin","html_url":"https://github.com/maryokhin","followers_url":"https://api.github.com/users/maryokhin/followers","following_url":"https://api.github.com/users/maryokhin/following{/other_user}","gists_url":"https://api.github.com/users/maryokhin/gists{/gist_id}","starred_url":"https://api.github.com/users/maryokhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryokhin/subscriptions","organizations_url":"https://api.github.com/users/maryokhin/orgs","repos_url":"https://api.github.com/users/maryokhin/repos","events_url":"https://api.github.com/users/maryokhin/events{/privacy}","received_events_url":"https://api.github.com/users/maryokhin/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T22:02:17Z","updated_at":"2018-05-16T22:02:17Z","author_association":"MEMBER","body":"Nice, really good job @moles1 "}}
{"actor":{"display_login":"maryokhin"}}