{"action":"created","issue":{"url":"https://api.github.com/repos/js-joda/js-joda-locale/issues/41","repository_url":"https://api.github.com/repos/js-joda/js-joda-locale","labels_url":"https://api.github.com/repos/js-joda/js-joda-locale/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/js-joda/js-joda-locale/issues/41/comments","events_url":"https://api.github.com/repos/js-joda/js-joda-locale/issues/41/events","html_url":"https://github.com/js-joda/js-joda-locale/issues/41","id":279602762,"node_id":"MDU6SXNzdWUyNzk2MDI3NjI=","number":41,"title":"Issue with postinstall script on Windows and problems building locale packages","user":{"login":"emyhrer","id":34284027,"node_id":"MDQ6VXNlcjM0Mjg0MDI3","avatar_url":"https://avatars2.githubusercontent.com/u/34284027?v=4","gravatar_id":"","url":"https://api.github.com/users/emyhrer","html_url":"https://github.com/emyhrer","followers_url":"https://api.github.com/users/emyhrer/followers","following_url":"https://api.github.com/users/emyhrer/following{/other_user}","gists_url":"https://api.github.com/users/emyhrer/gists{/gist_id}","starred_url":"https://api.github.com/users/emyhrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emyhrer/subscriptions","organizations_url":"https://api.github.com/users/emyhrer/orgs","repos_url":"https://api.github.com/users/emyhrer/repos","events_url":"https://api.github.com/users/emyhrer/events{/privacy}","received_events_url":"https://api.github.com/users/emyhrer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-12-06T02:23:51Z","updated_at":"2018-11-02T17:58:08Z","closed_at":"2018-11-01T16:42:13Z","author_association":"NONE","body":"Hello,\r\n\r\nThanks for providing this plugin to js-joda.\r\n\r\nI am looking to use js-joda-locale using prebuilt packages like described in the Readme and have run into one small issue on Windows I wanted to let you know about, and one issue I was hoping you could provide some pointers to overcome.\r\n\r\n1. The `postinstall`, `build-dist` and `test-coverage` scripts fail in my Windows environment because of the way environment variables are set in versions 0.8.2 and 1.0.0.  This can be solved by using `cross-env` when defining the scripts in package.json. \r\n\r\n2. I am not yet able to get js-joda-locale and cldr-data to play nice together. \r\n\r\n    When using the prebuilt packages approach as described in the Readme I am able to generate the packages, but they all end up the same size at ~44MB regardless of which locales I configure. I suspect this is because of the same issues I see when using the webpack approach to minimizing the size and that the whole thing always end up getting packaged. Functionally these packages work as expected, but the size is obviously going to be an issue.\r\n\r\n    When using the webpack approach I run into a series of issues during the build_package.js script. I can get around the missing `fs` module by targeting `node `as opposed to `web`, after which the next error complains about a return statement outside of a function in the cldr-data package. After manually changing this in cldr-data to see if I could build my packages, other issues keep popping up. The next issue is the following error: \r\n\r\n    > ../cldr-data/install.js\\n46:13-40 Critical dependency: the request of a dependency is an expression\r\n\r\n    I would like to stay away from making changes to the `cldr-data` package to resolve these issues if possible.\r\n\r\nHere are the pertinent parts of my package.json:\r\n```json\r\n\"cldr-data\": \"32.0.0\",\r\n\"cldrjs\": \"0.5.0\",\r\n\"js-joda\": \"1.6.2\",\r\n\"js-joda-locale\": \"^1.0.0\",\r\n\"js-joda-timezone\": \"1.1.5\",\r\n\"webpack\": \"^3.10.0\",\r\n```\r\n\r\n```json\r\n\"cldr-data-coverage\": \"core\",\r\n\"cldr-data-urls-filter\": \"(cldr-core|cldr-numbers-modern|cldr-dates-modern)\",\r\n\"js-joda-locale\": {\r\n  \"packages\": {\r\n    \"en\": [\r\n      \"en\"\r\n    ]\r\n  },\r\n  \"stats\": false,\r\n  \"debug\": false\r\n}\r\n```\r\nand webpack.config.js:\r\n\r\n```json\r\nresolve:\r\n{\r\n  // either setting cldr-data alias\r\n  alias:\r\n  {\r\n    'cldr-data$': path.resolve(__dirname, 'node_modules/js-joda-locale/utils/load_cldrData.js')\r\n  }\r\n},\r\n// or setting target to node\r\ntarget: \"node\",\r\n// and using the CldrDataIgnorePlugin\r\nplugins:\r\n[\r\n  new CldrDataIgnorePlugin(\"<absolute path>node_modules\", ['en'])\r\n] \r\n```\r\nI suspect there is something in my setup that is different than what is expected, and would appreciate any pointers to narrow this down.\r\n\r\nThanks and regards,\r\n\r\nEinar"},"comment":{"url":"https://api.github.com/repos/js-joda/js-joda-locale/issues/comments/435460782","html_url":"https://github.com/js-joda/js-joda-locale/issues/41#issuecomment-435460782","issue_url":"https://api.github.com/repos/js-joda/js-joda-locale/issues/41","id":435460782,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTQ2MDc4Mg==","user":{"login":"emyhrer","id":34284027,"node_id":"MDQ6VXNlcjM0Mjg0MDI3","avatar_url":"https://avatars2.githubusercontent.com/u/34284027?v=4","gravatar_id":"","url":"https://api.github.com/users/emyhrer","html_url":"https://github.com/emyhrer","followers_url":"https://api.github.com/users/emyhrer/followers","following_url":"https://api.github.com/users/emyhrer/following{/other_user}","gists_url":"https://api.github.com/users/emyhrer/gists{/gist_id}","starred_url":"https://api.github.com/users/emyhrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emyhrer/subscriptions","organizations_url":"https://api.github.com/users/emyhrer/orgs","repos_url":"https://api.github.com/users/emyhrer/repos","events_url":"https://api.github.com/users/emyhrer/events{/privacy}","received_events_url":"https://api.github.com/users/emyhrer/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T17:58:08Z","updated_at":"2018-11-02T17:58:08Z","author_association":"NONE","body":"Just confirming that this now works well for us on Windows with the locale specific packages. Thanks very much for resolving!"}}
{"actor":{"display_login":"emyhrer"}}