{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues/530","repository_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl","labels_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues/530/labels{/name}","comments_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues/530/comments","events_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues/530/events","html_url":"https://github.com/JuliaNLSolvers/Optim.jl/pull/530","id":294353955,"number":530,"title":"RFC: more generic convergence assessment","user":{"login":"jonathanBieler","id":5859344,"avatar_url":"https://avatars2.githubusercontent.com/u/5859344?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanBieler","html_url":"https://github.com/jonathanBieler","followers_url":"https://api.github.com/users/jonathanBieler/followers","following_url":"https://api.github.com/users/jonathanBieler/following{/other_user}","gists_url":"https://api.github.com/users/jonathanBieler/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanBieler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanBieler/subscriptions","organizations_url":"https://api.github.com/users/jonathanBieler/orgs","repos_url":"https://api.github.com/users/jonathanBieler/repos","events_url":"https://api.github.com/users/jonathanBieler/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanBieler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-05T11:06:01Z","updated_at":"2018-02-05T12:42:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/pulls/530","html_url":"https://github.com/JuliaNLSolvers/Optim.jl/pull/530","diff_url":"https://github.com/JuliaNLSolvers/Optim.jl/pull/530.diff","patch_url":"https://github.com/JuliaNLSolvers/Optim.jl/pull/530.patch"},"body":"I've tried to implement some of the changes discussed in #309, which allows my two minimal examples of [ZerothOrderOptimizer](https://gist.github.com/jonathanBieler/47d9ae7e95e7ca0f7352de8f84827ae3) and [FirstOrderOptimizer](https://gist.github.com/jonathanBieler/ed2ae8868e7b317c9e6d2db86f6ed2b9) defined outside of Optim to run."},"comment":{"url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues/comments/363073614","html_url":"https://github.com/JuliaNLSolvers/Optim.jl/pull/530#issuecomment-363073614","issue_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues/530","id":363073614,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-02-05T12:42:04Z","updated_at":"2018-02-05T12:42:04Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/JuliaNLSolvers/Optim.jl/pull/530?src=pr&el=h1) Report\n> Merging [#530](https://codecov.io/gh/JuliaNLSolvers/Optim.jl/pull/530?src=pr&el=desc) into [master](https://codecov.io/gh/JuliaNLSolvers/Optim.jl/commit/ede177ec7668936db53e6badd7b8b43bf6b05e5d?src=pr&el=desc) will **decrease** coverage by `0.1%`.\n> The diff coverage is `77.77%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/JuliaNLSolvers/Optim.jl/pull/530/graphs/tree.svg?token=mU95uZMEF8&src=pr&width=650&height=150)](https://codecov.io/gh/JuliaNLSolvers/Optim.jl/pull/530?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #530      +/-   ##\n==========================================\n- Coverage   89.87%   89.76%   -0.11%     \n==========================================\n  Files          35       35              \n  Lines        1777     1778       +1     \n==========================================\n- Hits         1597     1596       -1     \n- Misses        180      182       +2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/JuliaNLSolvers/Optim.jl/pull/530?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...c/multivariate/solvers/zeroth\\_order/nelder\\_mead.jl](https://codecov.io/gh/JuliaNLSolvers/Optim.jl/pull/530/diff?src=pr&el=tree#diff-c3JjL211bHRpdmFyaWF0ZS9zb2x2ZXJzL3plcm90aF9vcmRlci9uZWxkZXJfbWVhZC5qbA==) | `78.01% <100%> (+0.15%)` | :arrow_up: |\n| [src/utilities/assess\\_convergence.jl](https://codecov.io/gh/JuliaNLSolvers/Optim.jl/pull/530/diff?src=pr&el=tree#diff-c3JjL3V0aWxpdGllcy9hc3Nlc3NfY29udmVyZ2VuY2Uuamw=) | `96.77% <66.66%> (-3.23%)` | :arrow_down: |\n| [src/multivariate/optimize/optimize.jl](https://codecov.io/gh/JuliaNLSolvers/Optim.jl/pull/530/diff?src=pr&el=tree#diff-c3JjL211bHRpdmFyaWF0ZS9vcHRpbWl6ZS9vcHRpbWl6ZS5qbA==) | `91.11% <80%> (-2.37%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/JuliaNLSolvers/Optim.jl/pull/530?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/JuliaNLSolvers/Optim.jl/pull/530?src=pr&el=footer). Last update [ede177e...b6fce9d](https://codecov.io/gh/JuliaNLSolvers/Optim.jl/pull/530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}