{"action":"created","issue":{"url":"https://api.github.com/repos/chainer/chainer/issues/4434","repository_url":"https://api.github.com/repos/chainer/chainer","labels_url":"https://api.github.com/repos/chainer/chainer/issues/4434/labels{/name}","comments_url":"https://api.github.com/repos/chainer/chainer/issues/4434/comments","events_url":"https://api.github.com/repos/chainer/chainer/issues/4434/events","html_url":"https://github.com/chainer/chainer/pull/4434","id":302937961,"number":4434,"title":"Typecheck split_at","user":{"login":"corochann","id":4609798,"avatar_url":"https://avatars2.githubusercontent.com/u/4609798?v=4","gravatar_id":"","url":"https://api.github.com/users/corochann","html_url":"https://github.com/corochann","followers_url":"https://api.github.com/users/corochann/followers","following_url":"https://api.github.com/users/corochann/following{/other_user}","gists_url":"https://api.github.com/users/corochann/gists{/gist_id}","starred_url":"https://api.github.com/users/corochann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corochann/subscriptions","organizations_url":"https://api.github.com/users/corochann/orgs","repos_url":"https://api.github.com/users/corochann/repos","events_url":"https://api.github.com/users/corochann/events{/privacy}","received_events_url":"https://api.github.com/users/corochann/received_events","type":"User","site_admin":false},"labels":[{"id":220754695,"url":"https://api.github.com/repos/chainer/chainer/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":619749531,"url":"https://api.github.com/repos/chainer/chainer/labels/to-be-backported","name":"to-be-backported","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"niboshi","id":635436,"avatar_url":"https://avatars0.githubusercontent.com/u/635436?v=4","gravatar_id":"","url":"https://api.github.com/users/niboshi","html_url":"https://github.com/niboshi","followers_url":"https://api.github.com/users/niboshi/followers","following_url":"https://api.github.com/users/niboshi/following{/other_user}","gists_url":"https://api.github.com/users/niboshi/gists{/gist_id}","starred_url":"https://api.github.com/users/niboshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niboshi/subscriptions","organizations_url":"https://api.github.com/users/niboshi/orgs","repos_url":"https://api.github.com/users/niboshi/repos","events_url":"https://api.github.com/users/niboshi/events{/privacy}","received_events_url":"https://api.github.com/users/niboshi/received_events","type":"User","site_admin":false},"assignees":[{"login":"niboshi","id":635436,"avatar_url":"https://avatars0.githubusercontent.com/u/635436?v=4","gravatar_id":"","url":"https://api.github.com/users/niboshi","html_url":"https://github.com/niboshi","followers_url":"https://api.github.com/users/niboshi/followers","following_url":"https://api.github.com/users/niboshi/following{/other_user}","gists_url":"https://api.github.com/users/niboshi/gists{/gist_id}","starred_url":"https://api.github.com/users/niboshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niboshi/subscriptions","organizations_url":"https://api.github.com/users/niboshi/orgs","repos_url":"https://api.github.com/users/niboshi/repos","events_url":"https://api.github.com/users/niboshi/events{/privacy}","received_events_url":"https://api.github.com/users/niboshi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-03-07T02:06:22Z","updated_at":"2018-03-07T02:46:07Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/chainer/chainer/pulls/4434","html_url":"https://github.com/chainer/chainer/pull/4434","diff_url":"https://github.com/chainer/chainer/pull/4434.diff","patch_url":"https://github.com/chainer/chainer/pull/4434.patch"},"body":"When we use `split_dataset` or `split_dataset_random`, it won't raise error when we set `float` value to the second argument of `split_at`.\r\n\r\nIt is likely happen when we want to split dataset according to the ratio of train/validation dataset.\r\ne.g.,\r\n```\r\ntrain_ratio = 0.8\r\n# here actually we must change type to int, but did not notice, because no error is raised!\r\ntrain, val = split_dataset_random(dataset, len(dataset) * ratio)\r\n```\r\n\r\nThis PR is to check type of `split_at` to be `int`. After this PR, above code will raise `TypeError`."},"comment":{"url":"https://api.github.com/repos/chainer/chainer/issues/comments/371003984","html_url":"https://github.com/chainer/chainer/pull/4434#issuecomment-371003984","issue_url":"https://api.github.com/repos/chainer/chainer/issues/4434","id":371003984,"user":{"login":"corochann","id":4609798,"avatar_url":"https://avatars2.githubusercontent.com/u/4609798?v=4","gravatar_id":"","url":"https://api.github.com/users/corochann","html_url":"https://github.com/corochann","followers_url":"https://api.github.com/users/corochann/followers","following_url":"https://api.github.com/users/corochann/following{/other_user}","gists_url":"https://api.github.com/users/corochann/gists{/gist_id}","starred_url":"https://api.github.com/users/corochann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corochann/subscriptions","organizations_url":"https://api.github.com/users/corochann/orgs","repos_url":"https://api.github.com/users/corochann/repos","events_url":"https://api.github.com/users/corochann/events{/privacy}","received_events_url":"https://api.github.com/users/corochann/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T02:46:07Z","updated_at":"2018-03-07T02:46:07Z","author_association":"NONE","body":"thanks for comment, updated."}}
{"actor":{"display_login":"corochann"}}