{"action":"created","comment":{"url":"https://api.github.com/repos/zulip/zulip/pulls/comments/195906459","pull_request_review_id":129366965,"id":195906459,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTkwNjQ1OQ==","diff_hunk":"@@ -127,23 +130,21 @@ exports.add_custom_profile_fields_to_settings = function () {\n \n             function update_custom_user_field() {\n                 var fields = [];\n-                var user_id = user_pill.get_user_ids(pills);\n-                if (user_id.length > 1) {\n-                    ui_report.message(i18n.t(\"Only one user allowed\"), $(\"#custom-field-status\"), 'alert-error');\n-                    return;\n-                }\n-                if (user_id.length < 1) {\n+                var user_ids = user_pill.get_user_ids(pills);\n+                if (user_ids.length < 1) {\n                     fields.push(field.id);\n                     update_user_custom_profile_fields(fields, channel.del);\n                 } else {\n-                    fields.push({id: field.id, value: user_id[0]});\n+                    fields.push({id: field.id, value: user_ids});\n                     update_user_custom_profile_fields(fields, channel.patch);\n                 }\n             }\n \n             if (value) {","path":"static/js/settings_account.js","position":31,"original_position":31,"commit_id":"3360c86ec40c7c1834c66f52f7d1c66e09d696cb","original_commit_id":"3360c86ec40c7c1834c66f52f7d1c66e09d696cb","user":{"login":"timabbott","id":2746074,"node_id":"MDQ6VXNlcjI3NDYwNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2746074?v=4","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"body":"This should be a check for `            if (value !== undefined && value.length > 0) {                                           ` \r\n\r\n(Otherwise, if you reload the page after deleting the last user, it doesn't work).","created_at":"2018-06-16T16:15:39Z","updated_at":"2018-06-16T16:15:40Z","html_url":"https://github.com/zulip/zulip/pull/9651#discussion_r195906459","pull_request_url":"https://api.github.com/repos/zulip/zulip/pulls/9651","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments/195906459"},"html":{"href":"https://github.com/zulip/zulip/pull/9651#discussion_r195906459"},"pull_request":{"href":"https://api.github.com/repos/zulip/zulip/pulls/9651"}}},"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/9651","id":192265898,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjY1ODk4","html_url":"https://github.com/zulip/zulip/pull/9651","diff_url":"https://github.com/zulip/zulip/pull/9651.diff","patch_url":"https://github.com/zulip/zulip/pull/9651.patch","issue_url":"https://api.github.com/repos/zulip/zulip/issues/9651","number":9651,"state":"open","locked":false,"title":"custom fields: Allow list of users in user type of custom fields.","user":{"login":"YJDave","id":25907420,"node_id":"MDQ6VXNlcjI1OTA3NDIw","avatar_url":"https://avatars2.githubusercontent.com/u/25907420?v=4","gravatar_id":"","url":"https://api.github.com/users/YJDave","html_url":"https://github.com/YJDave","followers_url":"https://api.github.com/users/YJDave/followers","following_url":"https://api.github.com/users/YJDave/following{/other_user}","gists_url":"https://api.github.com/users/YJDave/gists{/gist_id}","starred_url":"https://api.github.com/users/YJDave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YJDave/subscriptions","organizations_url":"https://api.github.com/users/YJDave/orgs","repos_url":"https://api.github.com/users/YJDave/repos","events_url":"https://api.github.com/users/YJDave/events{/privacy}","received_events_url":"https://api.github.com/users/YJDave/received_events","type":"User","site_admin":false},"body":"Allow user to add more than one user-value in user type of custom\r\nfields.\r\n\r\nFollowup of #9330 \r\n![listofusers](https://user-images.githubusercontent.com/25907420/40891054-12986d44-679d-11e8-879b-22761e1c423b.gif)\r\n","created_at":"2018-06-03T20:31:55Z","updated_at":"2018-06-16T16:15:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"804b6942972d5b78c64449c64ccf1ce99ac12fd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":804160549,"node_id":"MDU6TGFiZWw4MDQxNjA1NDk=","url":"https://api.github.com/repos/zulip/zulip/labels/size:%20XL","name":"size: XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip/pulls/9651/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip/pulls/9651/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/9651/comments","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/3360c86ec40c7c1834c66f52f7d1c66e09d696cb","head":{"label":"YJDave:custom_user_list","ref":"custom_user_list","sha":"3360c86ec40c7c1834c66f52f7d1c66e09d696cb","user":{"login":"YJDave","id":25907420,"node_id":"MDQ6VXNlcjI1OTA3NDIw","avatar_url":"https://avatars2.githubusercontent.com/u/25907420?v=4","gravatar_id":"","url":"https://api.github.com/users/YJDave","html_url":"https://github.com/YJDave","followers_url":"https://api.github.com/users/YJDave/followers","following_url":"https://api.github.com/users/YJDave/following{/other_user}","gists_url":"https://api.github.com/users/YJDave/gists{/gist_id}","starred_url":"https://api.github.com/users/YJDave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YJDave/subscriptions","organizations_url":"https://api.github.com/users/YJDave/orgs","repos_url":"https://api.github.com/users/YJDave/repos","events_url":"https://api.github.com/users/YJDave/events{/privacy}","received_events_url":"https://api.github.com/users/YJDave/received_events","type":"User","site_admin":false},"repo":{"id":102934999,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI5MzQ5OTk=","name":"zulip","full_name":"YJDave/zulip","owner":{"login":"YJDave","id":25907420,"node_id":"MDQ6VXNlcjI1OTA3NDIw","avatar_url":"https://avatars2.githubusercontent.com/u/25907420?v=4","gravatar_id":"","url":"https://api.github.com/users/YJDave","html_url":"https://github.com/YJDave","followers_url":"https://api.github.com/users/YJDave/followers","following_url":"https://api.github.com/users/YJDave/following{/other_user}","gists_url":"https://api.github.com/users/YJDave/gists{/gist_id}","starred_url":"https://api.github.com/users/YJDave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YJDave/subscriptions","organizations_url":"https://api.github.com/users/YJDave/orgs","repos_url":"https://api.github.com/users/YJDave/repos","events_url":"https://api.github.com/users/YJDave/events{/privacy}","received_events_url":"https://api.github.com/users/YJDave/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YJDave/zulip","description":"Zulip server - powerful open source group chat","fork":true,"url":"https://api.github.com/repos/YJDave/zulip","forks_url":"https://api.github.com/repos/YJDave/zulip/forks","keys_url":"https://api.github.com/repos/YJDave/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YJDave/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YJDave/zulip/teams","hooks_url":"https://api.github.com/repos/YJDave/zulip/hooks","issue_events_url":"https://api.github.com/repos/YJDave/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/YJDave/zulip/events","assignees_url":"https://api.github.com/repos/YJDave/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/YJDave/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/YJDave/zulip/tags","blobs_url":"https://api.github.com/repos/YJDave/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YJDave/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YJDave/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/YJDave/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YJDave/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/YJDave/zulip/languages","stargazers_url":"https://api.github.com/repos/YJDave/zulip/stargazers","contributors_url":"https://api.github.com/repos/YJDave/zulip/contributors","subscribers_url":"https://api.github.com/repos/YJDave/zulip/subscribers","subscription_url":"https://api.github.com/repos/YJDave/zulip/subscription","commits_url":"https://api.github.com/repos/YJDave/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/YJDave/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/YJDave/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/YJDave/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/YJDave/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/YJDave/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YJDave/zulip/merges","archive_url":"https://api.github.com/repos/YJDave/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YJDave/zulip/downloads","issues_url":"https://api.github.com/repos/YJDave/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/YJDave/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/YJDave/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/YJDave/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YJDave/zulip/labels{/name}","releases_url":"https://api.github.com/repos/YJDave/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/YJDave/zulip/deployments","created_at":"2017-09-09T07:16:10Z","updated_at":"2018-06-12T13:53:48Z","pushed_at":"2018-06-14T22:54:46Z","git_url":"git://github.com/YJDave/zulip.git","ssh_url":"git@github.com:YJDave/zulip.git","clone_url":"https://github.com/YJDave/zulip.git","svn_url":"https://github.com/YJDave/zulip","homepage":"","size":210078,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"80a2d5bc59f65eb7c2e4f16db9599345f0f60a61","user":{"login":"zulip","id":4921959,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE5NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":43160685,"node_id":"MDEwOlJlcG9zaXRvcnk0MzE2MDY4NQ==","name":"zulip","full_name":"zulip/zulip","owner":{"login":"zulip","id":4921959,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE5NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip","description":"Zulip server - powerful open source team chat","fork":false,"url":"https://api.github.com/repos/zulip/zulip","forks_url":"https://api.github.com/repos/zulip/zulip/forks","keys_url":"https://api.github.com/repos/zulip/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip/teams","hooks_url":"https://api.github.com/repos/zulip/zulip/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip/events","assignees_url":"https://api.github.com/repos/zulip/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip/tags","blobs_url":"https://api.github.com/repos/zulip/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip/subscription","commits_url":"https://api.github.com/repos/zulip/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip/merges","archive_url":"https://api.github.com/repos/zulip/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip/downloads","issues_url":"https://api.github.com/repos/zulip/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip/deployments","created_at":"2015-09-25T16:37:25Z","updated_at":"2018-06-16T16:08:05Z","pushed_at":"2018-06-16T16:07:09Z","git_url":"git://github.com/zulip/zulip.git","ssh_url":"git@github.com:zulip/zulip.git","clone_url":"https://github.com/zulip/zulip.git","svn_url":"https://github.com/zulip/zulip","homepage":"https://zulip.org/","size":210049,"stargazers_count":7341,"watchers_count":7341,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2245,"mirror_url":null,"archived":false,"open_issues_count":995,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2245,"open_issues":995,"watchers":7341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/9651"},"html":{"href":"https://github.com/zulip/zulip/pull/9651"},"issue":{"href":"https://api.github.com/repos/zulip/zulip/issues/9651"},"comments":{"href":"https://api.github.com/repos/zulip/zulip/issues/9651/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip/pulls/9651/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip/pulls/9651/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip/statuses/3360c86ec40c7c1834c66f52f7d1c66e09d696cb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"timabbott"}}