{"action":"created","comment":{"url":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls/comments/218836530","pull_request_review_id":156863002,"id":218836530,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODgzNjUzMA==","diff_hunk":"@@ -153,19 +153,29 @@ export class OrderAssertions {\n   }\n \n   public async assertLiquidityOrders(\n+    coreAddress: Address,\n+    transactionCaller: Address,\n     signedIssuanceOrder: SignedIssuanceOrder,\n     quantityToFill: BigNumber,\n     orders: (TakerWalletOrder | ZeroExSignedFillOrder)[],\n   ) {\n+    const coreContract = await CoreContract.at(coreAddress, this.web3, {});\n+\n     let makerTokensUsed = SetProtocolUtils.CONSTANTS.ZERO;\n \n     await Promise.all(\n       _.map(orders, async (order: any) => {\n         if (SetProtocolUtils.isZeroExOrder(order)) {\n-          await this.isValidZeroExOrderFills(signedIssuanceOrder, quantityToFill, order);\n+          await this.isValidZeroExOrderFills(coreContract, signedIssuanceOrder, quantityToFill, order);\n           makerTokensUsed = makerTokensUsed.plus(order.fillAmount);\n         } else if (SetProtocolUtils.isTakerWalletOrder(order)) {\n-          await this.isValidTakerWalletOrderFills(signedIssuanceOrder, quantityToFill, order);\n+          await this.isValidTakerWalletOrderFills(\n+            coreContract,","path":"src/assertions/OrderAssertions.ts","position":23,"original_position":23,"commit_id":"7e3258acae0db097e81a904da0f2fb50c114482f","original_commit_id":"7e3258acae0db097e81a904da0f2fb50c114482f","user":{"login":"felix2feng","id":17420728,"node_id":"MDQ6VXNlcjE3NDIwNzI4","avatar_url":"https://avatars0.githubusercontent.com/u/17420728?v=4","gravatar_id":"","url":"https://api.github.com/users/felix2feng","html_url":"https://github.com/felix2feng","followers_url":"https://api.github.com/users/felix2feng/followers","following_url":"https://api.github.com/users/felix2feng/following{/other_user}","gists_url":"https://api.github.com/users/felix2feng/gists{/gist_id}","starred_url":"https://api.github.com/users/felix2feng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felix2feng/subscriptions","organizations_url":"https://api.github.com/users/felix2feng/orgs","repos_url":"https://api.github.com/users/felix2feng/repos","events_url":"https://api.github.com/users/felix2feng/events{/privacy}","received_events_url":"https://api.github.com/users/felix2feng/received_events","type":"User","site_admin":false},"body":"Do you guys know of a better pattern than just passing `coreContract` through?","created_at":"2018-09-19T14:51:52Z","updated_at":"2018-09-19T14:51:52Z","html_url":"https://github.com/SetProtocol/setprotocol.js/pull/173#discussion_r218836530","pull_request_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls/173","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls/comments/218836530"},"html":{"href":"https://github.com/SetProtocol/setprotocol.js/pull/173#discussion_r218836530"},"pull_request":{"href":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls/173","id":216664992,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NjY0OTky","html_url":"https://github.com/SetProtocol/setprotocol.js/pull/173","diff_url":"https://github.com/SetProtocol/setprotocol.js/pull/173.diff","patch_url":"https://github.com/SetProtocol/setprotocol.js/pull/173.patch","issue_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/issues/173","number":173,"state":"open","locked":false,"title":"Add taker wallet balance and allowance assertions","user":{"login":"felix2feng","id":17420728,"node_id":"MDQ6VXNlcjE3NDIwNzI4","avatar_url":"https://avatars0.githubusercontent.com/u/17420728?v=4","gravatar_id":"","url":"https://api.github.com/users/felix2feng","html_url":"https://github.com/felix2feng","followers_url":"https://api.github.com/users/felix2feng/followers","following_url":"https://api.github.com/users/felix2feng/following{/other_user}","gists_url":"https://api.github.com/users/felix2feng/gists{/gist_id}","starred_url":"https://api.github.com/users/felix2feng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felix2feng/subscriptions","organizations_url":"https://api.github.com/users/felix2feng/orgs","repos_url":"https://api.github.com/users/felix2feng/repos","events_url":"https://api.github.com/users/felix2feng/events{/privacy}","received_events_url":"https://api.github.com/users/felix2feng/received_events","type":"User","site_admin":false},"body":"Handles a portion of this card:\r\nhttps://trello.com/c/YzVIxeun/436-0x-taker-wallet-order-balance-and-allowance-validations-for-takerwallet-and-0x-orders","created_at":"2018-09-19T14:40:36Z","updated_at":"2018-09-19T14:51:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"928aa10046d82a3740cfa64f28170ff2d21cd923","assignee":null,"assignees":[],"requested_reviewers":[{"login":"justinkchen","id":1000741,"node_id":"MDQ6VXNlcjEwMDA3NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1000741?v=4","gravatar_id":"","url":"https://api.github.com/users/justinkchen","html_url":"https://github.com/justinkchen","followers_url":"https://api.github.com/users/justinkchen/followers","following_url":"https://api.github.com/users/justinkchen/following{/other_user}","gists_url":"https://api.github.com/users/justinkchen/gists{/gist_id}","starred_url":"https://api.github.com/users/justinkchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinkchen/subscriptions","organizations_url":"https://api.github.com/users/justinkchen/orgs","repos_url":"https://api.github.com/users/justinkchen/repos","events_url":"https://api.github.com/users/justinkchen/events{/privacy}","received_events_url":"https://api.github.com/users/justinkchen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls/173/commits","review_comments_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls/173/comments","review_comment_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/issues/173/comments","statuses_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/statuses/7e3258acae0db097e81a904da0f2fb50c114482f","head":{"label":"SetProtocol:taker-wallet-balance-allowance-assertions","ref":"taker-wallet-balance-allowance-assertions","sha":"7e3258acae0db097e81a904da0f2fb50c114482f","user":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":111771520,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE3NzE1MjA=","name":"setprotocol.js","full_name":"SetProtocol/setprotocol.js","private":false,"owner":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SetProtocol/setprotocol.js","description":"🥞 Javascript library for a collateralized basket of ERC20 tokens","fork":false,"url":"https://api.github.com/repos/SetProtocol/setprotocol.js","forks_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/forks","keys_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/teams","hooks_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/hooks","issue_events_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/issues/events{/number}","events_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/events","assignees_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/assignees{/user}","branches_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/branches{/branch}","tags_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/tags","blobs_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/statuses/{sha}","languages_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/languages","stargazers_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/stargazers","contributors_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/contributors","subscribers_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/subscribers","subscription_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/subscription","commits_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/contents/{+path}","compare_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/merges","archive_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/downloads","issues_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/issues{/number}","pulls_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls{/number}","milestones_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/milestones{/number}","notifications_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/labels{/name}","releases_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/releases{/id}","deployments_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/deployments","created_at":"2017-11-23T06:23:58Z","updated_at":"2018-09-19T14:06:59Z","pushed_at":"2018-09-19T14:40:37Z","git_url":"git://github.com/SetProtocol/setprotocol.js.git","ssh_url":"git@github.com:SetProtocol/setprotocol.js.git","clone_url":"https://github.com/SetProtocol/setprotocol.js.git","svn_url":"https://github.com/SetProtocol/setprotocol.js","homepage":"https://www.setprotocol.com","size":6358,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"SetProtocol:master","ref":"master","sha":"bf3b977fc9348bc6580a3283fadbe063cffede09","user":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":111771520,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE3NzE1MjA=","name":"setprotocol.js","full_name":"SetProtocol/setprotocol.js","private":false,"owner":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SetProtocol/setprotocol.js","description":"🥞 Javascript library for a collateralized basket of ERC20 tokens","fork":false,"url":"https://api.github.com/repos/SetProtocol/setprotocol.js","forks_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/forks","keys_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/teams","hooks_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/hooks","issue_events_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/issues/events{/number}","events_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/events","assignees_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/assignees{/user}","branches_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/branches{/branch}","tags_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/tags","blobs_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/statuses/{sha}","languages_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/languages","stargazers_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/stargazers","contributors_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/contributors","subscribers_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/subscribers","subscription_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/subscription","commits_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/contents/{+path}","compare_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/merges","archive_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/downloads","issues_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/issues{/number}","pulls_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls{/number}","milestones_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/milestones{/number}","notifications_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/labels{/name}","releases_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/releases{/id}","deployments_url":"https://api.github.com/repos/SetProtocol/setprotocol.js/deployments","created_at":"2017-11-23T06:23:58Z","updated_at":"2018-09-19T14:06:59Z","pushed_at":"2018-09-19T14:40:37Z","git_url":"git://github.com/SetProtocol/setprotocol.js.git","ssh_url":"git@github.com:SetProtocol/setprotocol.js.git","clone_url":"https://github.com/SetProtocol/setprotocol.js.git","svn_url":"https://github.com/SetProtocol/setprotocol.js","homepage":"https://www.setprotocol.com","size":6358,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls/173"},"html":{"href":"https://github.com/SetProtocol/setprotocol.js/pull/173"},"issue":{"href":"https://api.github.com/repos/SetProtocol/setprotocol.js/issues/173"},"comments":{"href":"https://api.github.com/repos/SetProtocol/setprotocol.js/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SetProtocol/setprotocol.js/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/SetProtocol/setprotocol.js/statuses/7e3258acae0db097e81a904da0f2fb50c114482f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"felix2feng"}}