{"action":"created","comment":{"url":"https://api.github.com/repos/raiden-network/spec/pulls/comments/182811048","pull_request_review_id":113686205,"id":182811048,"diff_hunk":"@@ -165,51 +168,38 @@ Allows a channel participant to close the channel. The channel cannot be settled\n \n     Only a valid signed balance proof from the channel partner (the other channel participant) must be accepted. This balance proof sets the amount of tokens owed to the participant by the channel partner.\n \n-**Update transfer state**\n+**Update non-closing participant balance proof**\n \n-Called after a channel has been closed. Allows the non-closing participant to provide a balance proof for the latest transfer from the closing participant. This modifies the state for the closing participant.\n+Called after a channel has been closed. Can be called by any Ethereum address and allows the non-closing participant to provide the latest balance proof from the closing participant. This modifies the stored state for the closing participant.\n \n ::\n \n-    function updateTransfer(\n+    function updateNonClosingBalanceProof(\n         uint channel_identifier,\n+        bytes32 balance_hash,","path":"smart_contracts.rst","position":56,"original_position":56,"commit_id":"6c8583fc5f1624e53feac74e1015abf586fd003a","original_commit_id":"6c8583fc5f1624e53feac74e1015abf586fd003a","user":{"login":"hackaugusto","id":310139,"avatar_url":"https://avatars0.githubusercontent.com/u/310139?v=4","gravatar_id":"","url":"https://api.github.com/users/hackaugusto","html_url":"https://github.com/hackaugusto","followers_url":"https://api.github.com/users/hackaugusto/followers","following_url":"https://api.github.com/users/hackaugusto/following{/other_user}","gists_url":"https://api.github.com/users/hackaugusto/gists{/gist_id}","starred_url":"https://api.github.com/users/hackaugusto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackaugusto/subscriptions","organizations_url":"https://api.github.com/users/hackaugusto/orgs","repos_url":"https://api.github.com/users/hackaugusto/repos","events_url":"https://api.github.com/users/hackaugusto/events{/privacy}","received_events_url":"https://api.github.com/users/hackaugusto/received_events","type":"User","site_admin":false},"body":"> so only handle the MS priorities in the Raiden client.\r\n\r\nwe can configure the monitoring services priorities offchain, but we need to enforce it on-chain otherwise there is little point in having a priority field.","created_at":"2018-04-19T16:39:20Z","updated_at":"2018-04-19T16:39:20Z","html_url":"https://github.com/raiden-network/spec/pull/54#discussion_r182811048","pull_request_url":"https://api.github.com/repos/raiden-network/spec/pulls/54","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/raiden-network/spec/pulls/comments/182811048"},"html":{"href":"https://github.com/raiden-network/spec/pull/54#discussion_r182811048"},"pull_request":{"href":"https://api.github.com/repos/raiden-network/spec/pulls/54"}},"in_reply_to_id":182723889},"pull_request":{"url":"https://api.github.com/repos/raiden-network/spec/pulls/54","id":181760943,"html_url":"https://github.com/raiden-network/spec/pull/54","diff_url":"https://github.com/raiden-network/spec/pull/54.diff","patch_url":"https://github.com/raiden-network/spec/pull/54.patch","issue_url":"https://api.github.com/repos/raiden-network/spec/issues/54","number":54,"state":"open","locked":false,"title":"Smart contracts - batch unlock, settle, balance hash in balance proof","user":{"login":"loredanacirstea","id":4785356,"avatar_url":"https://avatars2.githubusercontent.com/u/4785356?v=4","gravatar_id":"","url":"https://api.github.com/users/loredanacirstea","html_url":"https://github.com/loredanacirstea","followers_url":"https://api.github.com/users/loredanacirstea/followers","following_url":"https://api.github.com/users/loredanacirstea/following{/other_user}","gists_url":"https://api.github.com/users/loredanacirstea/gists{/gist_id}","starred_url":"https://api.github.com/users/loredanacirstea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loredanacirstea/subscriptions","organizations_url":"https://api.github.com/users/loredanacirstea/orgs","repos_url":"https://api.github.com/users/loredanacirstea/repos","events_url":"https://api.github.com/users/loredanacirstea/events{/privacy}","received_events_url":"https://api.github.com/users/loredanacirstea/received_events","type":"User","site_admin":false},"body":"- Batch unlock: https://github.com/raiden-network/spec/issues/35\r\n- Monitoring Service is not required to unlock the pending transfer tokens: https://github.com/raiden-network/spec/issues/31\r\n- Use balance hash in balance proofs - ensures privacy, especially when the channel is monitored by a third party. See discussion here: https://github.com/raiden-network/spec/issues/25#issuecomment-375467874, combined with the need to provided the `locked_amount` of tokens in the balance proof, in order to keep it in the smart contract after settling the channel. `unlock` happens after `settleChannel`","created_at":"2018-04-16T06:06:08Z","updated_at":"2018-04-19T16:39:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a25ff26144cb6442f74219d7dc70f64949d6dd84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/raiden-network/spec/pulls/54/commits","review_comments_url":"https://api.github.com/repos/raiden-network/spec/pulls/54/comments","review_comment_url":"https://api.github.com/repos/raiden-network/spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raiden-network/spec/issues/54/comments","statuses_url":"https://api.github.com/repos/raiden-network/spec/statuses/6c8583fc5f1624e53feac74e1015abf586fd003a","head":{"label":"loredanacirstea:sc-privacy-unlock","ref":"sc-privacy-unlock","sha":"6c8583fc5f1624e53feac74e1015abf586fd003a","user":{"login":"loredanacirstea","id":4785356,"avatar_url":"https://avatars2.githubusercontent.com/u/4785356?v=4","gravatar_id":"","url":"https://api.github.com/users/loredanacirstea","html_url":"https://github.com/loredanacirstea","followers_url":"https://api.github.com/users/loredanacirstea/followers","following_url":"https://api.github.com/users/loredanacirstea/following{/other_user}","gists_url":"https://api.github.com/users/loredanacirstea/gists{/gist_id}","starred_url":"https://api.github.com/users/loredanacirstea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loredanacirstea/subscriptions","organizations_url":"https://api.github.com/users/loredanacirstea/orgs","repos_url":"https://api.github.com/users/loredanacirstea/repos","events_url":"https://api.github.com/users/loredanacirstea/events{/privacy}","received_events_url":"https://api.github.com/users/loredanacirstea/received_events","type":"User","site_admin":false},"repo":{"id":129681634,"name":"spec","full_name":"loredanacirstea/spec","owner":{"login":"loredanacirstea","id":4785356,"avatar_url":"https://avatars2.githubusercontent.com/u/4785356?v=4","gravatar_id":"","url":"https://api.github.com/users/loredanacirstea","html_url":"https://github.com/loredanacirstea","followers_url":"https://api.github.com/users/loredanacirstea/followers","following_url":"https://api.github.com/users/loredanacirstea/following{/other_user}","gists_url":"https://api.github.com/users/loredanacirstea/gists{/gist_id}","starred_url":"https://api.github.com/users/loredanacirstea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loredanacirstea/subscriptions","organizations_url":"https://api.github.com/users/loredanacirstea/orgs","repos_url":"https://api.github.com/users/loredanacirstea/repos","events_url":"https://api.github.com/users/loredanacirstea/events{/privacy}","received_events_url":"https://api.github.com/users/loredanacirstea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/loredanacirstea/spec","description":"Spec of the Raiden Network protocol","fork":true,"url":"https://api.github.com/repos/loredanacirstea/spec","forks_url":"https://api.github.com/repos/loredanacirstea/spec/forks","keys_url":"https://api.github.com/repos/loredanacirstea/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loredanacirstea/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loredanacirstea/spec/teams","hooks_url":"https://api.github.com/repos/loredanacirstea/spec/hooks","issue_events_url":"https://api.github.com/repos/loredanacirstea/spec/issues/events{/number}","events_url":"https://api.github.com/repos/loredanacirstea/spec/events","assignees_url":"https://api.github.com/repos/loredanacirstea/spec/assignees{/user}","branches_url":"https://api.github.com/repos/loredanacirstea/spec/branches{/branch}","tags_url":"https://api.github.com/repos/loredanacirstea/spec/tags","blobs_url":"https://api.github.com/repos/loredanacirstea/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loredanacirstea/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loredanacirstea/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/loredanacirstea/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loredanacirstea/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/loredanacirstea/spec/languages","stargazers_url":"https://api.github.com/repos/loredanacirstea/spec/stargazers","contributors_url":"https://api.github.com/repos/loredanacirstea/spec/contributors","subscribers_url":"https://api.github.com/repos/loredanacirstea/spec/subscribers","subscription_url":"https://api.github.com/repos/loredanacirstea/spec/subscription","commits_url":"https://api.github.com/repos/loredanacirstea/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/loredanacirstea/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/loredanacirstea/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/loredanacirstea/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/loredanacirstea/spec/contents/{+path}","compare_url":"https://api.github.com/repos/loredanacirstea/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loredanacirstea/spec/merges","archive_url":"https://api.github.com/repos/loredanacirstea/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loredanacirstea/spec/downloads","issues_url":"https://api.github.com/repos/loredanacirstea/spec/issues{/number}","pulls_url":"https://api.github.com/repos/loredanacirstea/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/loredanacirstea/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/loredanacirstea/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loredanacirstea/spec/labels{/name}","releases_url":"https://api.github.com/repos/loredanacirstea/spec/releases{/id}","deployments_url":"https://api.github.com/repos/loredanacirstea/spec/deployments","created_at":"2018-04-16T03:51:32Z","updated_at":"2018-04-16T03:51:34Z","pushed_at":"2018-04-19T11:29:28Z","git_url":"git://github.com/loredanacirstea/spec.git","ssh_url":"git@github.com:loredanacirstea/spec.git","clone_url":"https://github.com/loredanacirstea/spec.git","svn_url":"https://github.com/loredanacirstea/spec","homepage":null,"size":96,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"raiden-network:master","ref":"master","sha":"72592708edf39a679879c554663dbe8476bebfe2","user":{"login":"raiden-network","id":19666847,"avatar_url":"https://avatars1.githubusercontent.com/u/19666847?v=4","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"repo":{"id":120174592,"name":"spec","full_name":"raiden-network/spec","owner":{"login":"raiden-network","id":19666847,"avatar_url":"https://avatars1.githubusercontent.com/u/19666847?v=4","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raiden-network/spec","description":"Spec of the Raiden Network protocol","fork":false,"url":"https://api.github.com/repos/raiden-network/spec","forks_url":"https://api.github.com/repos/raiden-network/spec/forks","keys_url":"https://api.github.com/repos/raiden-network/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raiden-network/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raiden-network/spec/teams","hooks_url":"https://api.github.com/repos/raiden-network/spec/hooks","issue_events_url":"https://api.github.com/repos/raiden-network/spec/issues/events{/number}","events_url":"https://api.github.com/repos/raiden-network/spec/events","assignees_url":"https://api.github.com/repos/raiden-network/spec/assignees{/user}","branches_url":"https://api.github.com/repos/raiden-network/spec/branches{/branch}","tags_url":"https://api.github.com/repos/raiden-network/spec/tags","blobs_url":"https://api.github.com/repos/raiden-network/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raiden-network/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raiden-network/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/raiden-network/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raiden-network/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/raiden-network/spec/languages","stargazers_url":"https://api.github.com/repos/raiden-network/spec/stargazers","contributors_url":"https://api.github.com/repos/raiden-network/spec/contributors","subscribers_url":"https://api.github.com/repos/raiden-network/spec/subscribers","subscription_url":"https://api.github.com/repos/raiden-network/spec/subscription","commits_url":"https://api.github.com/repos/raiden-network/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/raiden-network/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/raiden-network/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/raiden-network/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/raiden-network/spec/contents/{+path}","compare_url":"https://api.github.com/repos/raiden-network/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raiden-network/spec/merges","archive_url":"https://api.github.com/repos/raiden-network/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raiden-network/spec/downloads","issues_url":"https://api.github.com/repos/raiden-network/spec/issues{/number}","pulls_url":"https://api.github.com/repos/raiden-network/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/raiden-network/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/raiden-network/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raiden-network/spec/labels{/name}","releases_url":"https://api.github.com/repos/raiden-network/spec/releases{/id}","deployments_url":"https://api.github.com/repos/raiden-network/spec/deployments","created_at":"2018-02-04T10:22:08Z","updated_at":"2018-04-06T14:43:20Z","pushed_at":"2018-04-19T11:29:28Z","git_url":"git://github.com/raiden-network/spec.git","ssh_url":"git@github.com:raiden-network/spec.git","clone_url":"https://github.com/raiden-network/spec.git","svn_url":"https://github.com/raiden-network/spec","homepage":null,"size":83,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":29,"license":null,"forks":5,"open_issues":29,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raiden-network/spec/pulls/54"},"html":{"href":"https://github.com/raiden-network/spec/pull/54"},"issue":{"href":"https://api.github.com/repos/raiden-network/spec/issues/54"},"comments":{"href":"https://api.github.com/repos/raiden-network/spec/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/raiden-network/spec/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/raiden-network/spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raiden-network/spec/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/raiden-network/spec/statuses/6c8583fc5f1624e53feac74e1015abf586fd003a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"hackaugusto"}}