{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments/211575527","pull_request_review_id":148022406,"id":211575527,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTU3NTUyNw==","diff_hunk":"@@ -13,7 +13,7 @@ Services can only be Docker containers for now.\n \n ### `DockerListener`\n \n-`DockerListener` first gets current running containers and send these to `ConfigResolver`. Then it starts listening on the Docker event API for container activity and pass by `Services` mentioned in start/stop events to `ConfigResolver` through the corresponding channel.\n+`DockerListener` first gets current running containers and send these to the `AutoConfig`. Then it starts listening on the Docker event API for container activity and pass by `Services` mentioned in start/stop events to the `AutoConfig` through the corresponding channel.","path":"pkg/autodiscovery/listeners/README.md","position":5,"original_position":5,"commit_id":"35380785ea6da7cf7a8af28a208f2f8e6080d34d","original_commit_id":"fc1a13bcd1e9af23fc76ae36e424b10d0de0e354","user":{"login":"mfpierre","id":2368736,"node_id":"MDQ6VXNlcjIzNjg3MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/2368736?v=4","gravatar_id":"","url":"https://api.github.com/users/mfpierre","html_url":"https://github.com/mfpierre","followers_url":"https://api.github.com/users/mfpierre/followers","following_url":"https://api.github.com/users/mfpierre/following{/other_user}","gists_url":"https://api.github.com/users/mfpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/mfpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfpierre/subscriptions","organizations_url":"https://api.github.com/users/mfpierre/orgs","repos_url":"https://api.github.com/users/mfpierre/repos","events_url":"https://api.github.com/users/mfpierre/events{/privacy}","received_events_url":"https://api.github.com/users/mfpierre/received_events","type":"User","site_admin":false},"body":"We should use `Autodiscovery` for the whole mechanism but here I'm talking about the `AutoConfig` struct itself (that we should rename as well at some point)","created_at":"2018-08-21T11:51:24Z","updated_at":"2018-08-21T11:51:24Z","html_url":"https://github.com/DataDog/datadog-agent/pull/2165#discussion_r211575527","pull_request_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2165","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments/211575527"},"html":{"href":"https://github.com/DataDog/datadog-agent/pull/2165#discussion_r211575527"},"pull_request":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2165"}},"in_reply_to_id":211288521},"pull_request":{"url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2165","id":208282967,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MjgyOTY3","html_url":"https://github.com/DataDog/datadog-agent/pull/2165","diff_url":"https://github.com/DataDog/datadog-agent/pull/2165.diff","patch_url":"https://github.com/DataDog/datadog-agent/pull/2165.patch","issue_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/2165","number":2165,"state":"open","locked":false,"title":"Move the service listening away from the config resolver","user":{"login":"mfpierre","id":2368736,"node_id":"MDQ6VXNlcjIzNjg3MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/2368736?v=4","gravatar_id":"","url":"https://api.github.com/users/mfpierre","html_url":"https://github.com/mfpierre","followers_url":"https://api.github.com/users/mfpierre/followers","following_url":"https://api.github.com/users/mfpierre/following{/other_user}","gists_url":"https://api.github.com/users/mfpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/mfpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfpierre/subscriptions","organizations_url":"https://api.github.com/users/mfpierre/orgs","repos_url":"https://api.github.com/users/mfpierre/repos","events_url":"https://api.github.com/users/mfpierre/events{/privacy}","received_events_url":"https://api.github.com/users/mfpierre/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\n* Move the service listening away from the config resolver\r\n* Move the template cache to the AD store\r\n* Add two required mappings in the store\r\n* Remove all dependencies of the `ConfigResolver`\r\n\r\n### Motivation\r\n\r\nThe config resolver should only resolve configs and not have dependencies","created_at":"2018-08-14T13:33:01Z","updated_at":"2018-08-21T11:51:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3b2cbae947b8d35174eed832ea1135ae68431ce","assignee":null,"assignees":[],"requested_reviewers":[{"login":"olivielpeau","id":4912500,"node_id":"MDQ6VXNlcjQ5MTI1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4912500?v=4","gravatar_id":"","url":"https://api.github.com/users/olivielpeau","html_url":"https://github.com/olivielpeau","followers_url":"https://api.github.com/users/olivielpeau/followers","following_url":"https://api.github.com/users/olivielpeau/following{/other_user}","gists_url":"https://api.github.com/users/olivielpeau/gists{/gist_id}","starred_url":"https://api.github.com/users/olivielpeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivielpeau/subscriptions","organizations_url":"https://api.github.com/users/olivielpeau/orgs","repos_url":"https://api.github.com/users/olivielpeau/repos","events_url":"https://api.github.com/users/olivielpeau/events{/privacy}","received_events_url":"https://api.github.com/users/olivielpeau/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"agent-core","id":1224133,"node_id":"MDQ6VGVhbTEyMjQxMzM=","slug":"agent-core","description":"(formerly Croissant) Core Infra Agent and Agent packaging","privacy":"closed","url":"https://api.github.com/teams/1224133","members_url":"https://api.github.com/teams/1224133/members{/member}","repositories_url":"https://api.github.com/teams/1224133/repos","permission":"pull"},{"name":"container-integrations","id":2380322,"node_id":"MDQ6VGVhbTIzODAzMjI=","slug":"container-integrations","description":"(formerly kenafeh) containers and their orchestrators","privacy":"closed","url":"https://api.github.com/teams/2380322","members_url":"https://api.github.com/teams/2380322/members{/member}","repositories_url":"https://api.github.com/teams/2380322/repos","permission":"pull"}],"labels":[{"id":664370697,"node_id":"MDU6TGFiZWw2NjQzNzA2OTc=","url":"https://api.github.com/repos/DataDog/datadog-agent/labels/component/autodiscovery","name":"component/autodiscovery","color":"0052cc","default":false},{"id":796118273,"node_id":"MDU6TGFiZWw3OTYxMTgyNzM=","url":"https://api.github.com/repos/DataDog/datadog-agent/labels/noreno","name":"noreno","color":"edd682","default":false},{"id":695417157,"node_id":"MDU6TGFiZWw2OTU0MTcxNTc=","url":"https://api.github.com/repos/DataDog/datadog-agent/labels/team/containers","name":"team/containers","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2165/commits","review_comments_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2165/comments","review_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/2165/comments","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/35380785ea6da7cf7a8af28a208f2f8e6080d34d","head":{"label":"DataDog:mfpierre/move-service-listener","ref":"mfpierre/move-service-listener","sha":"35380785ea6da7cf7a8af28a208f2f8e6080d34d","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":49970739,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3MDczOQ==","name":"datadog-agent","full_name":"DataDog/datadog-agent","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-agent","description":"Datadog Agent ","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-agent","forks_url":"https://api.github.com/repos/DataDog/datadog-agent/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-agent/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-agent/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-agent/deployments","created_at":"2016-01-19T17:40:41Z","updated_at":"2018-08-21T10:22:39Z","pushed_at":"2018-08-21T11:51:12Z","git_url":"git://github.com/DataDog/datadog-agent.git","ssh_url":"git@github.com:DataDog/datadog-agent.git","clone_url":"https://github.com/DataDog/datadog-agent.git","svn_url":"https://github.com/DataDog/datadog-agent","homepage":"https://docs.datadoghq.com/","size":26801,"stargazers_count":230,"watchers_count":230,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":107,"open_issues":135,"watchers":230,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"2d70388e9c0901e631d82534cc2819539cb53b2a","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":49970739,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3MDczOQ==","name":"datadog-agent","full_name":"DataDog/datadog-agent","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-agent","description":"Datadog Agent ","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-agent","forks_url":"https://api.github.com/repos/DataDog/datadog-agent/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-agent/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-agent/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-agent/deployments","created_at":"2016-01-19T17:40:41Z","updated_at":"2018-08-21T10:22:39Z","pushed_at":"2018-08-21T11:51:12Z","git_url":"git://github.com/DataDog/datadog-agent.git","ssh_url":"git@github.com:DataDog/datadog-agent.git","clone_url":"https://github.com/DataDog/datadog-agent.git","svn_url":"https://github.com/DataDog/datadog-agent","homepage":"https://docs.datadoghq.com/","size":26801,"stargazers_count":230,"watchers_count":230,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":107,"open_issues":135,"watchers":230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2165"},"html":{"href":"https://github.com/DataDog/datadog-agent/pull/2165"},"issue":{"href":"https://api.github.com/repos/DataDog/datadog-agent/issues/2165"},"comments":{"href":"https://api.github.com/repos/DataDog/datadog-agent/issues/2165/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2165/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2165/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/datadog-agent/statuses/35380785ea6da7cf7a8af28a208f2f8e6080d34d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mfpierre"}}