{"action":"closed","number":3059,"pull_request":{"url":"https://api.github.com/repos/syndesisio/syndesis/pulls/3059","id":201101732,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTAxNzMy","html_url":"https://github.com/syndesisio/syndesis/pull/3059","diff_url":"https://github.com/syndesisio/syndesis/pull/3059.diff","patch_url":"https://github.com/syndesisio/syndesis/pull/3059.patch","issue_url":"https://api.github.com/repos/syndesisio/syndesis/issues/3059","number":3059,"state":"closed","locked":false,"title":"fix(basic-filter-form): basic filter form rewritten with formbuilder","user":{"login":"seanforyou23","id":5942899,"node_id":"MDQ6VXNlcjU5NDI4OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5942899?v=4","gravatar_id":"","url":"https://api.github.com/users/seanforyou23","html_url":"https://github.com/seanforyou23","followers_url":"https://api.github.com/users/seanforyou23/followers","following_url":"https://api.github.com/users/seanforyou23/following{/other_user}","gists_url":"https://api.github.com/users/seanforyou23/gists{/gist_id}","starred_url":"https://api.github.com/users/seanforyou23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanforyou23/subscriptions","organizations_url":"https://api.github.com/users/seanforyou23/orgs","repos_url":"https://api.github.com/users/seanforyou23/repos","events_url":"https://api.github.com/users/seanforyou23/events{/privacy}","received_events_url":"https://api.github.com/users/seanforyou23/received_events","type":"User","site_admin":false},"body":"This PR fixes the basic filter step form which was broken as a result of the recent angular core upgrade (6.x). For this specific form we were bypassing our forms service and used the ng-dynamic-forms api directly. This stopped working and as a result we've rewritten this form using angular's FormBuilder.\r\n\r\nShould help close https://github.com/syndesisio/syndesis/issues/2955\r\n\r\nRemaining work items:\r\n- Default value for predicate select control not correctly reflected in the UI\r\n- Tie back in autocomplete for the property name field\r\n\r\nI've marked this PR as WIP while I'm work through the previously mentioned issues. This work is generally stable enough, though, if it's desirable to go ahead and get it in considering the end of sprint is closing in.\r\n\r\nng-dynamic-forms => angular formbuilder\r\nemit formattedProperties on form change\r\nreload previously saved rule array groups on load\r\npass form validators as part of form construction\r\nuse button over link for in-view functionality\r\nimprove basic filter form keyboard experience\r\nadd missing accessible names","created_at":"2018-07-12T19:26:08Z","updated_at":"2018-07-13T10:40:17Z","closed_at":"2018-07-13T10:40:17Z","merged_at":"2018-07-13T10:40:17Z","merge_commit_sha":"859555c604756049eb1cefc012a5195e18b93edd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tplevko","id":4180208,"node_id":"MDQ6VXNlcjQxODAyMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/4180208?v=4","gravatar_id":"","url":"https://api.github.com/users/tplevko","html_url":"https://github.com/tplevko","followers_url":"https://api.github.com/users/tplevko/followers","following_url":"https://api.github.com/users/tplevko/following{/other_user}","gists_url":"https://api.github.com/users/tplevko/gists{/gist_id}","starred_url":"https://api.github.com/users/tplevko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tplevko/subscriptions","organizations_url":"https://api.github.com/users/tplevko/orgs","repos_url":"https://api.github.com/users/tplevko/repos","events_url":"https://api.github.com/users/tplevko/events{/privacy}","received_events_url":"https://api.github.com/users/tplevko/received_events","type":"User","site_admin":false},{"login":"michael-coker","id":35148959,"node_id":"MDQ6VXNlcjM1MTQ4OTU5","avatar_url":"https://avatars0.githubusercontent.com/u/35148959?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-coker","html_url":"https://github.com/michael-coker","followers_url":"https://api.github.com/users/michael-coker/followers","following_url":"https://api.github.com/users/michael-coker/following{/other_user}","gists_url":"https://api.github.com/users/michael-coker/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-coker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-coker/subscriptions","organizations_url":"https://api.github.com/users/michael-coker/orgs","repos_url":"https://api.github.com/users/michael-coker/repos","events_url":"https://api.github.com/users/michael-coker/events{/privacy}","received_events_url":"https://api.github.com/users/michael-coker/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":751428754,"node_id":"MDU6TGFiZWw3NTE0Mjg3NTQ=","url":"https://api.github.com/repos/syndesisio/syndesis/labels/group/ui","name":"group/ui","color":"dce6f0","default":false},{"id":875913439,"node_id":"MDU6TGFiZWw4NzU5MTM0Mzk=","url":"https://api.github.com/repos/syndesisio/syndesis/labels/pr/review-requested","name":"pr/review-requested","color":"50549d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/syndesisio/syndesis/pulls/3059/commits","review_comments_url":"https://api.github.com/repos/syndesisio/syndesis/pulls/3059/comments","review_comment_url":"https://api.github.com/repos/syndesisio/syndesis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syndesisio/syndesis/issues/3059/comments","statuses_url":"https://api.github.com/repos/syndesisio/syndesis/statuses/c4477ba4c274a9a3643efedf877817e001b6f73b","head":{"label":"seanforyou23:issue-2955","ref":"issue-2955","sha":"c4477ba4c274a9a3643efedf877817e001b6f73b","user":{"login":"seanforyou23","id":5942899,"node_id":"MDQ6VXNlcjU5NDI4OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5942899?v=4","gravatar_id":"","url":"https://api.github.com/users/seanforyou23","html_url":"https://github.com/seanforyou23","followers_url":"https://api.github.com/users/seanforyou23/followers","following_url":"https://api.github.com/users/seanforyou23/following{/other_user}","gists_url":"https://api.github.com/users/seanforyou23/gists{/gist_id}","starred_url":"https://api.github.com/users/seanforyou23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanforyou23/subscriptions","organizations_url":"https://api.github.com/users/seanforyou23/orgs","repos_url":"https://api.github.com/users/seanforyou23/repos","events_url":"https://api.github.com/users/seanforyou23/events{/privacy}","received_events_url":"https://api.github.com/users/seanforyou23/received_events","type":"User","site_admin":false},"repo":{"id":110898803,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA4OTg4MDM=","name":"syndesis","full_name":"seanforyou23/syndesis","owner":{"login":"seanforyou23","id":5942899,"node_id":"MDQ6VXNlcjU5NDI4OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5942899?v=4","gravatar_id":"","url":"https://api.github.com/users/seanforyou23","html_url":"https://github.com/seanforyou23","followers_url":"https://api.github.com/users/seanforyou23/followers","following_url":"https://api.github.com/users/seanforyou23/following{/other_user}","gists_url":"https://api.github.com/users/seanforyou23/gists{/gist_id}","starred_url":"https://api.github.com/users/seanforyou23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanforyou23/subscriptions","organizations_url":"https://api.github.com/users/seanforyou23/orgs","repos_url":"https://api.github.com/users/seanforyou23/repos","events_url":"https://api.github.com/users/seanforyou23/events{/privacy}","received_events_url":"https://api.github.com/users/seanforyou23/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seanforyou23/syndesis","description":"A flexible, customizable, open source platform that provides core integration capabilities as a service.","fork":true,"url":"https://api.github.com/repos/seanforyou23/syndesis","forks_url":"https://api.github.com/repos/seanforyou23/syndesis/forks","keys_url":"https://api.github.com/repos/seanforyou23/syndesis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seanforyou23/syndesis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seanforyou23/syndesis/teams","hooks_url":"https://api.github.com/repos/seanforyou23/syndesis/hooks","issue_events_url":"https://api.github.com/repos/seanforyou23/syndesis/issues/events{/number}","events_url":"https://api.github.com/repos/seanforyou23/syndesis/events","assignees_url":"https://api.github.com/repos/seanforyou23/syndesis/assignees{/user}","branches_url":"https://api.github.com/repos/seanforyou23/syndesis/branches{/branch}","tags_url":"https://api.github.com/repos/seanforyou23/syndesis/tags","blobs_url":"https://api.github.com/repos/seanforyou23/syndesis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seanforyou23/syndesis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seanforyou23/syndesis/git/refs{/sha}","trees_url":"https://api.github.com/repos/seanforyou23/syndesis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seanforyou23/syndesis/statuses/{sha}","languages_url":"https://api.github.com/repos/seanforyou23/syndesis/languages","stargazers_url":"https://api.github.com/repos/seanforyou23/syndesis/stargazers","contributors_url":"https://api.github.com/repos/seanforyou23/syndesis/contributors","subscribers_url":"https://api.github.com/repos/seanforyou23/syndesis/subscribers","subscription_url":"https://api.github.com/repos/seanforyou23/syndesis/subscription","commits_url":"https://api.github.com/repos/seanforyou23/syndesis/commits{/sha}","git_commits_url":"https://api.github.com/repos/seanforyou23/syndesis/git/commits{/sha}","comments_url":"https://api.github.com/repos/seanforyou23/syndesis/comments{/number}","issue_comment_url":"https://api.github.com/repos/seanforyou23/syndesis/issues/comments{/number}","contents_url":"https://api.github.com/repos/seanforyou23/syndesis/contents/{+path}","compare_url":"https://api.github.com/repos/seanforyou23/syndesis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seanforyou23/syndesis/merges","archive_url":"https://api.github.com/repos/seanforyou23/syndesis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seanforyou23/syndesis/downloads","issues_url":"https://api.github.com/repos/seanforyou23/syndesis/issues{/number}","pulls_url":"https://api.github.com/repos/seanforyou23/syndesis/pulls{/number}","milestones_url":"https://api.github.com/repos/seanforyou23/syndesis/milestones{/number}","notifications_url":"https://api.github.com/repos/seanforyou23/syndesis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seanforyou23/syndesis/labels{/name}","releases_url":"https://api.github.com/repos/seanforyou23/syndesis/releases{/id}","deployments_url":"https://api.github.com/repos/seanforyou23/syndesis/deployments","created_at":"2017-11-15T23:29:56Z","updated_at":"2018-07-12T19:15:38Z","pushed_at":"2018-07-13T02:20:14Z","git_url":"git://github.com/seanforyou23/syndesis.git","ssh_url":"git@github.com:seanforyou23/syndesis.git","clone_url":"https://github.com/seanforyou23/syndesis.git","svn_url":"https://github.com/seanforyou23/syndesis","homepage":null,"size":60388,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"syndesisio:master","ref":"master","sha":"f17eb7a01210b9eb8b53a6e8e2696714e6519360","user":{"login":"syndesisio","id":23079786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDc5Nzg2","avatar_url":"https://avatars3.githubusercontent.com/u/23079786?v=4","gravatar_id":"","url":"https://api.github.com/users/syndesisio","html_url":"https://github.com/syndesisio","followers_url":"https://api.github.com/users/syndesisio/followers","following_url":"https://api.github.com/users/syndesisio/following{/other_user}","gists_url":"https://api.github.com/users/syndesisio/gists{/gist_id}","starred_url":"https://api.github.com/users/syndesisio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syndesisio/subscriptions","organizations_url":"https://api.github.com/users/syndesisio/orgs","repos_url":"https://api.github.com/users/syndesisio/repos","events_url":"https://api.github.com/users/syndesisio/events{/privacy}","received_events_url":"https://api.github.com/users/syndesisio/received_events","type":"Organization","site_admin":false},"repo":{"id":105563335,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1NjMzMzU=","name":"syndesis","full_name":"syndesisio/syndesis","owner":{"login":"syndesisio","id":23079786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDc5Nzg2","avatar_url":"https://avatars3.githubusercontent.com/u/23079786?v=4","gravatar_id":"","url":"https://api.github.com/users/syndesisio","html_url":"https://github.com/syndesisio","followers_url":"https://api.github.com/users/syndesisio/followers","following_url":"https://api.github.com/users/syndesisio/following{/other_user}","gists_url":"https://api.github.com/users/syndesisio/gists{/gist_id}","starred_url":"https://api.github.com/users/syndesisio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syndesisio/subscriptions","organizations_url":"https://api.github.com/users/syndesisio/orgs","repos_url":"https://api.github.com/users/syndesisio/repos","events_url":"https://api.github.com/users/syndesisio/events{/privacy}","received_events_url":"https://api.github.com/users/syndesisio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/syndesisio/syndesis","description":"A flexible, customizable, open source platform that provides core integration capabilities as a service.","fork":false,"url":"https://api.github.com/repos/syndesisio/syndesis","forks_url":"https://api.github.com/repos/syndesisio/syndesis/forks","keys_url":"https://api.github.com/repos/syndesisio/syndesis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syndesisio/syndesis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syndesisio/syndesis/teams","hooks_url":"https://api.github.com/repos/syndesisio/syndesis/hooks","issue_events_url":"https://api.github.com/repos/syndesisio/syndesis/issues/events{/number}","events_url":"https://api.github.com/repos/syndesisio/syndesis/events","assignees_url":"https://api.github.com/repos/syndesisio/syndesis/assignees{/user}","branches_url":"https://api.github.com/repos/syndesisio/syndesis/branches{/branch}","tags_url":"https://api.github.com/repos/syndesisio/syndesis/tags","blobs_url":"https://api.github.com/repos/syndesisio/syndesis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syndesisio/syndesis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syndesisio/syndesis/git/refs{/sha}","trees_url":"https://api.github.com/repos/syndesisio/syndesis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syndesisio/syndesis/statuses/{sha}","languages_url":"https://api.github.com/repos/syndesisio/syndesis/languages","stargazers_url":"https://api.github.com/repos/syndesisio/syndesis/stargazers","contributors_url":"https://api.github.com/repos/syndesisio/syndesis/contributors","subscribers_url":"https://api.github.com/repos/syndesisio/syndesis/subscribers","subscription_url":"https://api.github.com/repos/syndesisio/syndesis/subscription","commits_url":"https://api.github.com/repos/syndesisio/syndesis/commits{/sha}","git_commits_url":"https://api.github.com/repos/syndesisio/syndesis/git/commits{/sha}","comments_url":"https://api.github.com/repos/syndesisio/syndesis/comments{/number}","issue_comment_url":"https://api.github.com/repos/syndesisio/syndesis/issues/comments{/number}","contents_url":"https://api.github.com/repos/syndesisio/syndesis/contents/{+path}","compare_url":"https://api.github.com/repos/syndesisio/syndesis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syndesisio/syndesis/merges","archive_url":"https://api.github.com/repos/syndesisio/syndesis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syndesisio/syndesis/downloads","issues_url":"https://api.github.com/repos/syndesisio/syndesis/issues{/number}","pulls_url":"https://api.github.com/repos/syndesisio/syndesis/pulls{/number}","milestones_url":"https://api.github.com/repos/syndesisio/syndesis/milestones{/number}","notifications_url":"https://api.github.com/repos/syndesisio/syndesis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syndesisio/syndesis/labels{/name}","releases_url":"https://api.github.com/repos/syndesisio/syndesis/releases{/id}","deployments_url":"https://api.github.com/repos/syndesisio/syndesis/deployments","created_at":"2017-10-02T17:26:55Z","updated_at":"2018-07-13T10:01:59Z","pushed_at":"2018-07-13T10:40:17Z","git_url":"git://github.com/syndesisio/syndesis.git","ssh_url":"git@github.com:syndesisio/syndesis.git","clone_url":"https://github.com/syndesisio/syndesis.git","svn_url":"https://github.com/syndesisio/syndesis","homepage":null,"size":67937,"stargazers_count":52,"watchers_count":52,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":361,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":66,"open_issues":361,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/3059"},"html":{"href":"https://github.com/syndesisio/syndesis/pull/3059"},"issue":{"href":"https://api.github.com/repos/syndesisio/syndesis/issues/3059"},"comments":{"href":"https://api.github.com/repos/syndesisio/syndesis/issues/3059/comments"},"review_comments":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/3059/comments"},"review_comment":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/3059/commits"},"statuses":{"href":"https://api.github.com/repos/syndesisio/syndesis/statuses/c4477ba4c274a9a3643efedf877817e001b6f73b"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gashcrumb","id":351660,"node_id":"MDQ6VXNlcjM1MTY2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/351660?v=4","gravatar_id":"","url":"https://api.github.com/users/gashcrumb","html_url":"https://github.com/gashcrumb","followers_url":"https://api.github.com/users/gashcrumb/followers","following_url":"https://api.github.com/users/gashcrumb/following{/other_user}","gists_url":"https://api.github.com/users/gashcrumb/gists{/gist_id}","starred_url":"https://api.github.com/users/gashcrumb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gashcrumb/subscriptions","organizations_url":"https://api.github.com/users/gashcrumb/orgs","repos_url":"https://api.github.com/users/gashcrumb/repos","events_url":"https://api.github.com/users/gashcrumb/events{/privacy}","received_events_url":"https://api.github.com/users/gashcrumb/received_events","type":"User","site_admin":false},"comments":3,"review_comments":4,"maintainer_can_modify":false,"commits":2,"additions":263,"deletions":295,"changed_files":5}}
{"actor":{"display_login":"gashcrumb"}}