{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-nio/pulls/comments/178267997","pull_request_review_id":108304130,"id":178267997,"diff_hunk":"@@ -498,7 +498,11 @@ let channel = try { () -> Channel in\n     }\n }()\n \n-print(\"Server started and listening on \\(channel.localAddress!), htdocs path \\(htdocs)\")\n+if let localAddress = channel.localAddress {\n+    print(\"Server started and listening on \\(localAddress), htdocs path \\(htdocs)\")\n+} else {\n+    print(\"Server started but the address could not be determined. htdocs path \\(htdocs)\")","path":"Sources/NIOHTTP1Server/main.swift","position":8,"original_position":8,"commit_id":"4114588dd9de2fe80e7eed48a9c57e8d3b8d3326","original_commit_id":"4114588dd9de2fe80e7eed48a9c57e8d3b8d3326","user":{"login":"BasThomas","id":4190298,"avatar_url":"https://avatars0.githubusercontent.com/u/4190298?v=4","gravatar_id":"","url":"https://api.github.com/users/BasThomas","html_url":"https://github.com/BasThomas","followers_url":"https://api.github.com/users/BasThomas/followers","following_url":"https://api.github.com/users/BasThomas/following{/other_user}","gists_url":"https://api.github.com/users/BasThomas/gists{/gist_id}","starred_url":"https://api.github.com/users/BasThomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BasThomas/subscriptions","organizations_url":"https://api.github.com/users/BasThomas/orgs","repos_url":"https://api.github.com/users/BasThomas/repos","events_url":"https://api.github.com/users/BasThomas/events{/privacy}","received_events_url":"https://api.github.com/users/BasThomas/received_events","type":"User","site_admin":false},"body":"Nit: was `,`, now a `.` in the else case. ","created_at":"2018-03-30T10:08:40Z","updated_at":"2018-03-30T10:09:01Z","html_url":"https://github.com/apple/swift-nio/pull/259#discussion_r178267997","pull_request_url":"https://api.github.com/repos/apple/swift-nio/pulls/259","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/comments/178267997"},"html":{"href":"https://github.com/apple/swift-nio/pull/259#discussion_r178267997"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/259"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-nio/pulls/259","id":178451626,"html_url":"https://github.com/apple/swift-nio/pull/259","diff_url":"https://github.com/apple/swift-nio/pull/259.diff","patch_url":"https://github.com/apple/swift-nio/pull/259.patch","issue_url":"https://api.github.com/repos/apple/swift-nio/issues/259","number":259,"state":"open","locked":false,"title":"Fixed a few minor typos and some force unwraps","user":{"login":"agnosticdev","id":7466510,"avatar_url":"https://avatars1.githubusercontent.com/u/7466510?v=4","gravatar_id":"","url":"https://api.github.com/users/agnosticdev","html_url":"https://github.com/agnosticdev","followers_url":"https://api.github.com/users/agnosticdev/followers","following_url":"https://api.github.com/users/agnosticdev/following{/other_user}","gists_url":"https://api.github.com/users/agnosticdev/gists{/gist_id}","starred_url":"https://api.github.com/users/agnosticdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agnosticdev/subscriptions","organizations_url":"https://api.github.com/users/agnosticdev/orgs","repos_url":"https://api.github.com/users/agnosticdev/repos","events_url":"https://api.github.com/users/agnosticdev/events{/privacy}","received_events_url":"https://api.github.com/users/agnosticdev/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nReviewing the code I found a few typos for readability.\r\nFixed a few force unwraps.\r\n\r\nModifications:\r\n\r\nMinor typos fixes in the following files:\r\nByteBuffer-core.swift\r\nEventLoopFuture.swwift\r\nSelector.swift\r\nFileRegion.swift\r\nEventLoop.swift\r\nThread.swift\r\nBootstrap.swift\r\nCompositeError.swift\r\nLinuxCPUSet.swift\r\nPendingDatagramWritesManager.swift\r\nMarkedCircularBuffer.swift\r\n\r\nFixed force unwraps in the following files:\r\nNIOHTTP1Server/main.swift\r\nNIOChatServer/main.swift\r\nNIOWebSocketServer/main.swift\r\n\r\nResult:\r\n\r\nThe result will be minor typo fixes and a few force unwrap cleanups.\r\n\r\n","created_at":"2018-03-29T21:56:21Z","updated_at":"2018-03-30T10:09:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbc0d9151b94c26d1fa5fc4b45b04896552ab428","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-nio/pulls/259/commits","review_comments_url":"https://api.github.com/repos/apple/swift-nio/pulls/259/comments","review_comment_url":"https://api.github.com/repos/apple/swift-nio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-nio/issues/259/comments","statuses_url":"https://api.github.com/repos/apple/swift-nio/statuses/4114588dd9de2fe80e7eed48a9c57e8d3b8d3326","head":{"label":"agnosticdev:typo_fixes","ref":"typo_fixes","sha":"4114588dd9de2fe80e7eed48a9c57e8d3b8d3326","user":{"login":"agnosticdev","id":7466510,"avatar_url":"https://avatars1.githubusercontent.com/u/7466510?v=4","gravatar_id":"","url":"https://api.github.com/users/agnosticdev","html_url":"https://github.com/agnosticdev","followers_url":"https://api.github.com/users/agnosticdev/followers","following_url":"https://api.github.com/users/agnosticdev/following{/other_user}","gists_url":"https://api.github.com/users/agnosticdev/gists{/gist_id}","starred_url":"https://api.github.com/users/agnosticdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agnosticdev/subscriptions","organizations_url":"https://api.github.com/users/agnosticdev/orgs","repos_url":"https://api.github.com/users/agnosticdev/repos","events_url":"https://api.github.com/users/agnosticdev/events{/privacy}","received_events_url":"https://api.github.com/users/agnosticdev/received_events","type":"User","site_admin":false},"repo":{"id":127328547,"name":"swift-nio","full_name":"agnosticdev/swift-nio","owner":{"login":"agnosticdev","id":7466510,"avatar_url":"https://avatars1.githubusercontent.com/u/7466510?v=4","gravatar_id":"","url":"https://api.github.com/users/agnosticdev","html_url":"https://github.com/agnosticdev","followers_url":"https://api.github.com/users/agnosticdev/followers","following_url":"https://api.github.com/users/agnosticdev/following{/other_user}","gists_url":"https://api.github.com/users/agnosticdev/gists{/gist_id}","starred_url":"https://api.github.com/users/agnosticdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agnosticdev/subscriptions","organizations_url":"https://api.github.com/users/agnosticdev/orgs","repos_url":"https://api.github.com/users/agnosticdev/repos","events_url":"https://api.github.com/users/agnosticdev/events{/privacy}","received_events_url":"https://api.github.com/users/agnosticdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agnosticdev/swift-nio","description":"Event-driven network application framework for high performance protocol servers & clients, non-blocking.","fork":true,"url":"https://api.github.com/repos/agnosticdev/swift-nio","forks_url":"https://api.github.com/repos/agnosticdev/swift-nio/forks","keys_url":"https://api.github.com/repos/agnosticdev/swift-nio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agnosticdev/swift-nio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agnosticdev/swift-nio/teams","hooks_url":"https://api.github.com/repos/agnosticdev/swift-nio/hooks","issue_events_url":"https://api.github.com/repos/agnosticdev/swift-nio/issues/events{/number}","events_url":"https://api.github.com/repos/agnosticdev/swift-nio/events","assignees_url":"https://api.github.com/repos/agnosticdev/swift-nio/assignees{/user}","branches_url":"https://api.github.com/repos/agnosticdev/swift-nio/branches{/branch}","tags_url":"https://api.github.com/repos/agnosticdev/swift-nio/tags","blobs_url":"https://api.github.com/repos/agnosticdev/swift-nio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agnosticdev/swift-nio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agnosticdev/swift-nio/git/refs{/sha}","trees_url":"https://api.github.com/repos/agnosticdev/swift-nio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agnosticdev/swift-nio/statuses/{sha}","languages_url":"https://api.github.com/repos/agnosticdev/swift-nio/languages","stargazers_url":"https://api.github.com/repos/agnosticdev/swift-nio/stargazers","contributors_url":"https://api.github.com/repos/agnosticdev/swift-nio/contributors","subscribers_url":"https://api.github.com/repos/agnosticdev/swift-nio/subscribers","subscription_url":"https://api.github.com/repos/agnosticdev/swift-nio/subscription","commits_url":"https://api.github.com/repos/agnosticdev/swift-nio/commits{/sha}","git_commits_url":"https://api.github.com/repos/agnosticdev/swift-nio/git/commits{/sha}","comments_url":"https://api.github.com/repos/agnosticdev/swift-nio/comments{/number}","issue_comment_url":"https://api.github.com/repos/agnosticdev/swift-nio/issues/comments{/number}","contents_url":"https://api.github.com/repos/agnosticdev/swift-nio/contents/{+path}","compare_url":"https://api.github.com/repos/agnosticdev/swift-nio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agnosticdev/swift-nio/merges","archive_url":"https://api.github.com/repos/agnosticdev/swift-nio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agnosticdev/swift-nio/downloads","issues_url":"https://api.github.com/repos/agnosticdev/swift-nio/issues{/number}","pulls_url":"https://api.github.com/repos/agnosticdev/swift-nio/pulls{/number}","milestones_url":"https://api.github.com/repos/agnosticdev/swift-nio/milestones{/number}","notifications_url":"https://api.github.com/repos/agnosticdev/swift-nio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agnosticdev/swift-nio/labels{/name}","releases_url":"https://api.github.com/repos/agnosticdev/swift-nio/releases{/id}","deployments_url":"https://api.github.com/repos/agnosticdev/swift-nio/deployments","created_at":"2018-03-29T18:01:33Z","updated_at":"2018-03-29T18:01:35Z","pushed_at":"2018-03-29T21:55:33Z","git_url":"git://github.com/agnosticdev/swift-nio.git","ssh_url":"git@github.com:agnosticdev/swift-nio.git","clone_url":"https://github.com/agnosticdev/swift-nio.git","svn_url":"https://github.com/agnosticdev/swift-nio","homepage":"","size":4467,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"23744213e6f6320c9f22b21ebd37002d8af22093","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":120498971,"name":"swift-nio","full_name":"apple/swift-nio","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-nio","description":"Event-driven network application framework for high performance protocol servers & clients, non-blocking.","fork":false,"url":"https://api.github.com/repos/apple/swift-nio","forks_url":"https://api.github.com/repos/apple/swift-nio/forks","keys_url":"https://api.github.com/repos/apple/swift-nio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-nio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-nio/teams","hooks_url":"https://api.github.com/repos/apple/swift-nio/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-nio/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-nio/events","assignees_url":"https://api.github.com/repos/apple/swift-nio/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-nio/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-nio/tags","blobs_url":"https://api.github.com/repos/apple/swift-nio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-nio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-nio/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-nio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-nio/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-nio/languages","stargazers_url":"https://api.github.com/repos/apple/swift-nio/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-nio/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-nio/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-nio/subscription","commits_url":"https://api.github.com/repos/apple/swift-nio/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-nio/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-nio/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-nio/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-nio/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-nio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-nio/merges","archive_url":"https://api.github.com/repos/apple/swift-nio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-nio/downloads","issues_url":"https://api.github.com/repos/apple/swift-nio/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-nio/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-nio/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-nio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-nio/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-nio/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-nio/deployments","created_at":"2018-02-06T17:47:31Z","updated_at":"2018-03-30T09:27:18Z","pushed_at":"2018-03-30T09:14:50Z","git_url":"git://github.com/apple/swift-nio.git","ssh_url":"git@github.com:apple/swift-nio.git","clone_url":"https://github.com/apple/swift-nio.git","svn_url":"https://github.com/apple/swift-nio","homepage":"","size":4457,"stargazers_count":3261,"watchers_count":3261,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":125,"open_issues":41,"watchers":3261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/259"},"html":{"href":"https://github.com/apple/swift-nio/pull/259"},"issue":{"href":"https://api.github.com/repos/apple/swift-nio/issues/259"},"comments":{"href":"https://api.github.com/repos/apple/swift-nio/issues/259/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/259/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/259/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-nio/statuses/4114588dd9de2fe80e7eed48a9c57e8d3b8d3326"}},"author_association":"NONE"}}
{"actor":{"display_login":"BasThomas"}}