{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/kayenta/pulls/comments/217730236","pull_request_review_id":155517666,"id":217730236,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzczMDIzNg==","diff_hunk":"@@ -72,12 +78,41 @@\n   @Getter\n   private String description;\n \n+  public List<String> getTargets() {","path":"kayenta-atlas/src/main/java/com/netflix/kayenta/atlas/model/Backend.java","position":25,"original_position":25,"commit_id":"b711c985d85c8d588890c6161194e6ee888b01a0","original_commit_id":"b711c985d85c8d588890c6161194e6ee888b01a0","user":{"login":"duftler","id":8437718,"node_id":"MDQ6VXNlcjg0Mzc3MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/8437718?v=4","gravatar_id":"","url":"https://api.github.com/users/duftler","html_url":"https://github.com/duftler","followers_url":"https://api.github.com/users/duftler/followers","following_url":"https://api.github.com/users/duftler/following{/other_user}","gists_url":"https://api.github.com/users/duftler/gists{/gist_id}","starred_url":"https://api.github.com/users/duftler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duftler/subscriptions","organizations_url":"https://api.github.com/users/duftler/orgs","repos_url":"https://api.github.com/users/duftler/repos","events_url":"https://api.github.com/users/duftler/events{/privacy}","received_events_url":"https://api.github.com/users/duftler/received_events","type":"User","site_admin":false},"body":"Might be worth a sentence or two for future readers to know what is going on in this method.","created_at":"2018-09-14T14:23:06Z","updated_at":"2018-09-14T14:53:55Z","html_url":"https://github.com/spinnaker/kayenta/pull/375#discussion_r217730236","pull_request_url":"https://api.github.com/repos/spinnaker/kayenta/pulls/375","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/kayenta/pulls/comments/217730236"},"html":{"href":"https://github.com/spinnaker/kayenta/pull/375#discussion_r217730236"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/kayenta/pulls/375"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/kayenta/pulls/375","id":215099026,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDk5MDI2","html_url":"https://github.com/spinnaker/kayenta/pull/375","diff_url":"https://github.com/spinnaker/kayenta/pull/375.diff","patch_url":"https://github.com/spinnaker/kayenta/pull/375.patch","issue_url":"https://api.github.com/repos/spinnaker/kayenta/issues/375","number":375,"state":"open","locked":false,"title":"feat(locations): provide location hints for atlas","user":{"login":"skandragon","id":43517,"node_id":"MDQ6VXNlcjQzNTE3","avatar_url":"https://avatars3.githubusercontent.com/u/43517?v=4","gravatar_id":"","url":"https://api.github.com/users/skandragon","html_url":"https://github.com/skandragon","followers_url":"https://api.github.com/users/skandragon/followers","following_url":"https://api.github.com/users/skandragon/following{/other_user}","gists_url":"https://api.github.com/users/skandragon/gists{/gist_id}","starred_url":"https://api.github.com/users/skandragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skandragon/subscriptions","organizations_url":"https://api.github.com/users/skandragon/orgs","repos_url":"https://api.github.com/users/skandragon/repos","events_url":"https://api.github.com/users/skandragon/events{/privacy}","received_events_url":"https://api.github.com/users/skandragon/received_events","type":"User","site_admin":false},"body":"This is a partial fix for some Atlas complexity reduction.\r\n\r\nThis adds an ability to provide UI hints about locations.  For Atlas, Netflix has many deployment, environment, and datacenter combinations to choose from.  We have started changing to a model where these magic location strings will be sufficient to provide all these details, as they are unique across all our atlas deployments.\r\n\r\nWith this change, most of the special Atlas scope parameters will be replaced by the single location, which will greatly simplify the code.\r\n\r\nOptionally, a recommended list may be provided in the kayenta config YAML file. If provided, it will be inserted into the `recommendedLocations` list; otherwise, the list will contain whatever `locations` contains.  If it would be better to replace this with an empty list, that can be changed.\r\n\r\nI recommend the UI to present a text input box if `locations` is empty, otherwise present a pull-down with the `recommendedLocations` first, with options to switch to `locations` for the full list.  For Atlas, it makes little sense to allow arbitrary text input here, but it may also be useful for other metric sources to have a text field option as well even with locations provided if they cannot all be discovered.","created_at":"2018-09-12T21:17:32Z","updated_at":"2018-09-14T14:53:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1451f418a4a08174b7e477eea438667ff6962c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/kayenta/pulls/375/commits","review_comments_url":"https://api.github.com/repos/spinnaker/kayenta/pulls/375/comments","review_comment_url":"https://api.github.com/repos/spinnaker/kayenta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/kayenta/issues/375/comments","statuses_url":"https://api.github.com/repos/spinnaker/kayenta/statuses/b711c985d85c8d588890c6161194e6ee888b01a0","head":{"label":"skandragon:ui-hint-locations","ref":"ui-hint-locations","sha":"b711c985d85c8d588890c6161194e6ee888b01a0","user":{"login":"skandragon","id":43517,"node_id":"MDQ6VXNlcjQzNTE3","avatar_url":"https://avatars3.githubusercontent.com/u/43517?v=4","gravatar_id":"","url":"https://api.github.com/users/skandragon","html_url":"https://github.com/skandragon","followers_url":"https://api.github.com/users/skandragon/followers","following_url":"https://api.github.com/users/skandragon/following{/other_user}","gists_url":"https://api.github.com/users/skandragon/gists{/gist_id}","starred_url":"https://api.github.com/users/skandragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skandragon/subscriptions","organizations_url":"https://api.github.com/users/skandragon/orgs","repos_url":"https://api.github.com/users/skandragon/repos","events_url":"https://api.github.com/users/skandragon/events{/privacy}","received_events_url":"https://api.github.com/users/skandragon/received_events","type":"User","site_admin":false},"repo":{"id":128854851,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4NTQ4NTE=","name":"kayenta","full_name":"skandragon/kayenta","owner":{"login":"skandragon","id":43517,"node_id":"MDQ6VXNlcjQzNTE3","avatar_url":"https://avatars3.githubusercontent.com/u/43517?v=4","gravatar_id":"","url":"https://api.github.com/users/skandragon","html_url":"https://github.com/skandragon","followers_url":"https://api.github.com/users/skandragon/followers","following_url":"https://api.github.com/users/skandragon/following{/other_user}","gists_url":"https://api.github.com/users/skandragon/gists{/gist_id}","starred_url":"https://api.github.com/users/skandragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skandragon/subscriptions","organizations_url":"https://api.github.com/users/skandragon/orgs","repos_url":"https://api.github.com/users/skandragon/repos","events_url":"https://api.github.com/users/skandragon/events{/privacy}","received_events_url":"https://api.github.com/users/skandragon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skandragon/kayenta","description":"Automated Canary Service","fork":true,"url":"https://api.github.com/repos/skandragon/kayenta","forks_url":"https://api.github.com/repos/skandragon/kayenta/forks","keys_url":"https://api.github.com/repos/skandragon/kayenta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skandragon/kayenta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skandragon/kayenta/teams","hooks_url":"https://api.github.com/repos/skandragon/kayenta/hooks","issue_events_url":"https://api.github.com/repos/skandragon/kayenta/issues/events{/number}","events_url":"https://api.github.com/repos/skandragon/kayenta/events","assignees_url":"https://api.github.com/repos/skandragon/kayenta/assignees{/user}","branches_url":"https://api.github.com/repos/skandragon/kayenta/branches{/branch}","tags_url":"https://api.github.com/repos/skandragon/kayenta/tags","blobs_url":"https://api.github.com/repos/skandragon/kayenta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skandragon/kayenta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skandragon/kayenta/git/refs{/sha}","trees_url":"https://api.github.com/repos/skandragon/kayenta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skandragon/kayenta/statuses/{sha}","languages_url":"https://api.github.com/repos/skandragon/kayenta/languages","stargazers_url":"https://api.github.com/repos/skandragon/kayenta/stargazers","contributors_url":"https://api.github.com/repos/skandragon/kayenta/contributors","subscribers_url":"https://api.github.com/repos/skandragon/kayenta/subscribers","subscription_url":"https://api.github.com/repos/skandragon/kayenta/subscription","commits_url":"https://api.github.com/repos/skandragon/kayenta/commits{/sha}","git_commits_url":"https://api.github.com/repos/skandragon/kayenta/git/commits{/sha}","comments_url":"https://api.github.com/repos/skandragon/kayenta/comments{/number}","issue_comment_url":"https://api.github.com/repos/skandragon/kayenta/issues/comments{/number}","contents_url":"https://api.github.com/repos/skandragon/kayenta/contents/{+path}","compare_url":"https://api.github.com/repos/skandragon/kayenta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skandragon/kayenta/merges","archive_url":"https://api.github.com/repos/skandragon/kayenta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skandragon/kayenta/downloads","issues_url":"https://api.github.com/repos/skandragon/kayenta/issues{/number}","pulls_url":"https://api.github.com/repos/skandragon/kayenta/pulls{/number}","milestones_url":"https://api.github.com/repos/skandragon/kayenta/milestones{/number}","notifications_url":"https://api.github.com/repos/skandragon/kayenta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skandragon/kayenta/labels{/name}","releases_url":"https://api.github.com/repos/skandragon/kayenta/releases{/id}","deployments_url":"https://api.github.com/repos/skandragon/kayenta/deployments","created_at":"2018-04-10T01:27:14Z","updated_at":"2018-09-13T18:33:04Z","pushed_at":"2018-09-13T18:33:03Z","git_url":"git://github.com/skandragon/kayenta.git","ssh_url":"git@github.com:skandragon/kayenta.git","clone_url":"https://github.com/skandragon/kayenta.git","svn_url":"https://github.com/skandragon/kayenta","homepage":"","size":10079,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"d26a2d3cae7a39dc65d7083220c8f49c272a93ad","user":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":80229651,"node_id":"MDEwOlJlcG9zaXRvcnk4MDIyOTY1MQ==","name":"kayenta","full_name":"spinnaker/kayenta","owner":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/kayenta","description":"Automated Canary Service","fork":false,"url":"https://api.github.com/repos/spinnaker/kayenta","forks_url":"https://api.github.com/repos/spinnaker/kayenta/forks","keys_url":"https://api.github.com/repos/spinnaker/kayenta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/kayenta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/kayenta/teams","hooks_url":"https://api.github.com/repos/spinnaker/kayenta/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/kayenta/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/kayenta/events","assignees_url":"https://api.github.com/repos/spinnaker/kayenta/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/kayenta/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/kayenta/tags","blobs_url":"https://api.github.com/repos/spinnaker/kayenta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/kayenta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/kayenta/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/kayenta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/kayenta/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/kayenta/languages","stargazers_url":"https://api.github.com/repos/spinnaker/kayenta/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/kayenta/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/kayenta/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/kayenta/subscription","commits_url":"https://api.github.com/repos/spinnaker/kayenta/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/kayenta/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/kayenta/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/kayenta/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/kayenta/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/kayenta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/kayenta/merges","archive_url":"https://api.github.com/repos/spinnaker/kayenta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/kayenta/downloads","issues_url":"https://api.github.com/repos/spinnaker/kayenta/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/kayenta/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/kayenta/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/kayenta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/kayenta/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/kayenta/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/kayenta/deployments","created_at":"2017-01-27T17:30:07Z","updated_at":"2018-09-13T21:25:32Z","pushed_at":"2018-09-13T21:26:10Z","git_url":"git://github.com/spinnaker/kayenta.git","ssh_url":"git@github.com:spinnaker/kayenta.git","clone_url":"https://github.com/spinnaker/kayenta.git","svn_url":"https://github.com/spinnaker/kayenta","homepage":"","size":10062,"stargazers_count":711,"watchers_count":711,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":132,"open_issues":38,"watchers":711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/kayenta/pulls/375"},"html":{"href":"https://github.com/spinnaker/kayenta/pull/375"},"issue":{"href":"https://api.github.com/repos/spinnaker/kayenta/issues/375"},"comments":{"href":"https://api.github.com/repos/spinnaker/kayenta/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/kayenta/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/kayenta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/kayenta/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/kayenta/statuses/b711c985d85c8d588890c6161194e6ee888b01a0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"duftler"}}