{"action":"created","comment":{"url":"https://api.github.com/repos/gluster/glusterd2/pulls/comments/214638289","pull_request_review_id":151733812,"id":214638289,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDYzODI4OQ==","diff_hunk":"@@ -36,19 +35,28 @@ func snapshotListHandler(w http.ResponseWriter, r *http.Request) {\n \t\t\tsnapName[s.ParentVolume] = append(snapName[s.ParentVolume], s.SnapVolinfo.Name)","path":"glusterd2/commands/snapshot/snapshot-list.go","position":9,"original_position":9,"commit_id":"c68b85e729d4444ca7882aed12f72dce996426de","original_commit_id":"c68b85e729d4444ca7882aed12f72dce996426de","user":{"login":"rafikc30","id":3429960,"node_id":"MDQ6VXNlcjM0Mjk5NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/3429960?v=4","gravatar_id":"","url":"https://api.github.com/users/rafikc30","html_url":"https://github.com/rafikc30","followers_url":"https://api.github.com/users/rafikc30/followers","following_url":"https://api.github.com/users/rafikc30/following{/other_user}","gists_url":"https://api.github.com/users/rafikc30/gists{/gist_id}","starred_url":"https://api.github.com/users/rafikc30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafikc30/subscriptions","organizations_url":"https://api.github.com/users/rafikc30/orgs","repos_url":"https://api.github.com/users/rafikc30/repos","events_url":"https://api.github.com/users/rafikc30/events{/privacy}","received_events_url":"https://api.github.com/users/rafikc30/received_events","type":"User","site_admin":false},"body":"I would even suggest to use two response function one for all snapshot, and one for all snapshot of a volume","created_at":"2018-09-03T10:08:37Z","updated_at":"2018-09-03T10:08:43Z","html_url":"https://github.com/gluster/glusterd2/pull/1207#discussion_r214638289","pull_request_url":"https://api.github.com/repos/gluster/glusterd2/pulls/1207","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/comments/214638289"},"html":{"href":"https://github.com/gluster/glusterd2/pull/1207#discussion_r214638289"},"pull_request":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/1207"}},"in_reply_to_id":214625227},"pull_request":{"url":"https://api.github.com/repos/gluster/glusterd2/pulls/1207","id":212106204,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTA2MjA0","html_url":"https://github.com/gluster/glusterd2/pull/1207","diff_url":"https://github.com/gluster/glusterd2/pull/1207.diff","patch_url":"https://github.com/gluster/glusterd2/pull/1207.patch","issue_url":"https://api.github.com/repos/gluster/glusterd2/issues/1207","number":1207,"state":"open","locked":false,"title":"return complete snapshot info in snapshots list","user":{"login":"Madhu-1","id":18114231,"node_id":"MDQ6VXNlcjE4MTE0MjMx","avatar_url":"https://avatars2.githubusercontent.com/u/18114231?v=4","gravatar_id":"","url":"https://api.github.com/users/Madhu-1","html_url":"https://github.com/Madhu-1","followers_url":"https://api.github.com/users/Madhu-1/followers","following_url":"https://api.github.com/users/Madhu-1/following{/other_user}","gists_url":"https://api.github.com/users/Madhu-1/gists{/gist_id}","starred_url":"https://api.github.com/users/Madhu-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madhu-1/subscriptions","organizations_url":"https://api.github.com/users/Madhu-1/orgs","repos_url":"https://api.github.com/users/Madhu-1/repos","events_url":"https://api.github.com/users/Madhu-1/events{/privacy}","received_events_url":"https://api.github.com/users/Madhu-1/received_events","type":"User","site_admin":false},"body":"during the snapshot, list returns the complete snapshots info along with the parent volume name.\r\n if we call snapshot list we should be able to get complete snapshot information like listing volumes.\r\n\r\nSigned-off-by: Madhu Rajanna <mrajanna@redhat.com>\r\n\r\noutput:\r\n```\r\n[\r\n    {\r\n        \"parentname\": \"test12\",\r\n        \"snaps\": [\r\n            {\r\n                \"snapinfo\": {\r\n                    \"id\": \"3b3c3951-78d4-4048-a794-5b54d7dc524a\",\r\n                    \"name\": \"t11\",\r\n                    \"type\": \"Distribute\",\r\n                    \"transport\": \"tcp\",\r\n                    \"distribute-count\": 1,\r\n                    \"replica-count\": 1,\r\n                    \"options\": {\r\n                        \"bitrot-stub.bitrot\": \"off\",\r\n                        \"feature.deem-statfs\": \"off\",\r\n                        \"features.inode-quota\": \"off\",\r\n                        \"features.quota\": \"off\",\r\n                        \"features.quota-deem-statfs\": \"off\",\r\n                        \"features.read-only\": \"on\",\r\n                        \"features.uss\": \"off\",\r\n                        \"replicate.self-heal-daemon\": \"off\"\r\n                    },\r\n                    \"state\": \"Started\",\r\n                    \"subvols\": [\r\n                        {\r\n                            \"name\": \"t11-distribute-0\",\r\n                            \"type\": \"Distribute\",\r\n                            \"bricks\": [\r\n                                {\r\n                                    \"id\": \"f8f35aa2-aec4-4d1b-b95d-542c8d09b482\",\r\n                                    \"path\": \"/usr/local/var/run/glusterd2/snaps/t11/test12/subvol1/brick1\",\r\n                                    \"volume-id\": \"3b3c3951-78d4-4048-a794-5b54d7dc524a\",\r\n                                    \"volume-name\": \"t11\",\r\n                                    \"peer-id\": \"19d4532e-7ca3-4578-8bb2-927253436366\",\r\n                                    \"host\": \"dhcp43-106.lab.eng.blr.redhat.com\",\r\n                                    \"type\": \"Brick\"\r\n                                }\r\n                            ],\r\n                            \"replica-count\": 1,\r\n                            \"arbiter-count\": 0,\r\n                            \"disperse-count\": 0\r\n                        }\r\n                    ],\r\n                    \"metadata\": {},\r\n                    \"snap-list\": []\r\n                },\r\n                \"parentname\": \"test12\",\r\n                \"description\": \"\"\r\n            },\r\n            {\r\n                \"snapinfo\": {\r\n                    \"id\": \"7147b5f4-f235-4268-9e3e-bfcb1daedfb2\",\r\n                    \"name\": \"te\",\r\n                    \"type\": \"Distribute\",\r\n                    \"transport\": \"tcp\",\r\n                    \"distribute-count\": 1,\r\n                    \"replica-count\": 1,\r\n                    \"options\": {\r\n                        \"bitrot-stub.bitrot\": \"off\",\r\n                        \"feature.deem-statfs\": \"off\",\r\n                        \"features.inode-quota\": \"off\",\r\n                        \"features.quota\": \"off\",\r\n                        \"features.quota-deem-statfs\": \"off\",\r\n                        \"features.read-only\": \"on\",\r\n                        \"features.uss\": \"off\",\r\n                        \"replicate.self-heal-daemon\": \"off\"\r\n                    },\r\n                    \"state\": \"Created\",\r\n                    \"subvols\": [\r\n                        {\r\n                            \"name\": \"te-distribute-0\",\r\n                            \"type\": \"Distribute\",\r\n                            \"bricks\": [\r\n                                {\r\n                                    \"id\": \"c73bb69a-f0b9-40ea-ae8f-e34bddf104fe\",\r\n                                    \"path\": \"/usr/local/var/run/glusterd2/snaps/te/test12/subvol1/brick1\",\r\n                                    \"volume-id\": \"7147b5f4-f235-4268-9e3e-bfcb1daedfb2\",\r\n                                    \"volume-name\": \"te\",\r\n                                    \"peer-id\": \"19d4532e-7ca3-4578-8bb2-927253436366\",\r\n                                    \"host\": \"dhcp43-106.lab.eng.blr.redhat.com\",\r\n                                    \"type\": \"Brick\"\r\n                                }\r\n                            ],\r\n                            \"replica-count\": 1,\r\n                            \"arbiter-count\": 0,\r\n                            \"disperse-count\": 0\r\n                        }\r\n                    ],\r\n                    \"metadata\": {},\r\n                    \"snap-list\": []\r\n                },\r\n                \"parentname\": \"test12\",\r\n                \"description\": \"\"\r\n            }\r\n        ]\r\n    }\r\n]\r\n```","created_at":"2018-08-30T14:46:59Z","updated_at":"2018-09-03T10:08:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"612dc8a2aa33d6ba10ff58655d454c7bc1682459","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gluster/glusterd2/pulls/1207/commits","review_comments_url":"https://api.github.com/repos/gluster/glusterd2/pulls/1207/comments","review_comment_url":"https://api.github.com/repos/gluster/glusterd2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gluster/glusterd2/issues/1207/comments","statuses_url":"https://api.github.com/repos/gluster/glusterd2/statuses/c68b85e729d4444ca7882aed12f72dce996426de","head":{"label":"Madhu-1:snap-list","ref":"snap-list","sha":"c68b85e729d4444ca7882aed12f72dce996426de","user":{"login":"Madhu-1","id":18114231,"node_id":"MDQ6VXNlcjE4MTE0MjMx","avatar_url":"https://avatars2.githubusercontent.com/u/18114231?v=4","gravatar_id":"","url":"https://api.github.com/users/Madhu-1","html_url":"https://github.com/Madhu-1","followers_url":"https://api.github.com/users/Madhu-1/followers","following_url":"https://api.github.com/users/Madhu-1/following{/other_user}","gists_url":"https://api.github.com/users/Madhu-1/gists{/gist_id}","starred_url":"https://api.github.com/users/Madhu-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madhu-1/subscriptions","organizations_url":"https://api.github.com/users/Madhu-1/orgs","repos_url":"https://api.github.com/users/Madhu-1/repos","events_url":"https://api.github.com/users/Madhu-1/events{/privacy}","received_events_url":"https://api.github.com/users/Madhu-1/received_events","type":"User","site_admin":false},"repo":{"id":130645136,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA2NDUxMzY=","name":"glusterd2","full_name":"Madhu-1/glusterd2","owner":{"login":"Madhu-1","id":18114231,"node_id":"MDQ6VXNlcjE4MTE0MjMx","avatar_url":"https://avatars2.githubusercontent.com/u/18114231?v=4","gravatar_id":"","url":"https://api.github.com/users/Madhu-1","html_url":"https://github.com/Madhu-1","followers_url":"https://api.github.com/users/Madhu-1/followers","following_url":"https://api.github.com/users/Madhu-1/following{/other_user}","gists_url":"https://api.github.com/users/Madhu-1/gists{/gist_id}","starred_url":"https://api.github.com/users/Madhu-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madhu-1/subscriptions","organizations_url":"https://api.github.com/users/Madhu-1/orgs","repos_url":"https://api.github.com/users/Madhu-1/repos","events_url":"https://api.github.com/users/Madhu-1/events{/privacy}","received_events_url":"https://api.github.com/users/Madhu-1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Madhu-1/glusterd2","description":"GlusterD-2.0 is the distributed management framework to be used for GlusterFS-4.0","fork":true,"url":"https://api.github.com/repos/Madhu-1/glusterd2","forks_url":"https://api.github.com/repos/Madhu-1/glusterd2/forks","keys_url":"https://api.github.com/repos/Madhu-1/glusterd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Madhu-1/glusterd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Madhu-1/glusterd2/teams","hooks_url":"https://api.github.com/repos/Madhu-1/glusterd2/hooks","issue_events_url":"https://api.github.com/repos/Madhu-1/glusterd2/issues/events{/number}","events_url":"https://api.github.com/repos/Madhu-1/glusterd2/events","assignees_url":"https://api.github.com/repos/Madhu-1/glusterd2/assignees{/user}","branches_url":"https://api.github.com/repos/Madhu-1/glusterd2/branches{/branch}","tags_url":"https://api.github.com/repos/Madhu-1/glusterd2/tags","blobs_url":"https://api.github.com/repos/Madhu-1/glusterd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Madhu-1/glusterd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Madhu-1/glusterd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Madhu-1/glusterd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Madhu-1/glusterd2/statuses/{sha}","languages_url":"https://api.github.com/repos/Madhu-1/glusterd2/languages","stargazers_url":"https://api.github.com/repos/Madhu-1/glusterd2/stargazers","contributors_url":"https://api.github.com/repos/Madhu-1/glusterd2/contributors","subscribers_url":"https://api.github.com/repos/Madhu-1/glusterd2/subscribers","subscription_url":"https://api.github.com/repos/Madhu-1/glusterd2/subscription","commits_url":"https://api.github.com/repos/Madhu-1/glusterd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Madhu-1/glusterd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Madhu-1/glusterd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Madhu-1/glusterd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Madhu-1/glusterd2/contents/{+path}","compare_url":"https://api.github.com/repos/Madhu-1/glusterd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Madhu-1/glusterd2/merges","archive_url":"https://api.github.com/repos/Madhu-1/glusterd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Madhu-1/glusterd2/downloads","issues_url":"https://api.github.com/repos/Madhu-1/glusterd2/issues{/number}","pulls_url":"https://api.github.com/repos/Madhu-1/glusterd2/pulls{/number}","milestones_url":"https://api.github.com/repos/Madhu-1/glusterd2/milestones{/number}","notifications_url":"https://api.github.com/repos/Madhu-1/glusterd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Madhu-1/glusterd2/labels{/name}","releases_url":"https://api.github.com/repos/Madhu-1/glusterd2/releases{/id}","deployments_url":"https://api.github.com/repos/Madhu-1/glusterd2/deployments","created_at":"2018-04-23T05:37:08Z","updated_at":"2018-04-23T05:37:10Z","pushed_at":"2018-09-03T09:50:37Z","git_url":"git://github.com/Madhu-1/glusterd2.git","ssh_url":"git@github.com:Madhu-1/glusterd2.git","clone_url":"https://github.com/Madhu-1/glusterd2.git","svn_url":"https://github.com/Madhu-1/glusterd2","homepage":"","size":12983,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gluster:master","ref":"master","sha":"e8ebe18919543747201c5d98359e33de5c65adb8","user":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"repo":{"id":24369600,"node_id":"MDEwOlJlcG9zaXRvcnkyNDM2OTYwMA==","name":"glusterd2","full_name":"gluster/glusterd2","owner":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gluster/glusterd2","description":"GlusterD-2.0 is the distributed management framework to be used for GlusterFS-4.0","fork":false,"url":"https://api.github.com/repos/gluster/glusterd2","forks_url":"https://api.github.com/repos/gluster/glusterd2/forks","keys_url":"https://api.github.com/repos/gluster/glusterd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluster/glusterd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluster/glusterd2/teams","hooks_url":"https://api.github.com/repos/gluster/glusterd2/hooks","issue_events_url":"https://api.github.com/repos/gluster/glusterd2/issues/events{/number}","events_url":"https://api.github.com/repos/gluster/glusterd2/events","assignees_url":"https://api.github.com/repos/gluster/glusterd2/assignees{/user}","branches_url":"https://api.github.com/repos/gluster/glusterd2/branches{/branch}","tags_url":"https://api.github.com/repos/gluster/glusterd2/tags","blobs_url":"https://api.github.com/repos/gluster/glusterd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluster/glusterd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluster/glusterd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluster/glusterd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluster/glusterd2/statuses/{sha}","languages_url":"https://api.github.com/repos/gluster/glusterd2/languages","stargazers_url":"https://api.github.com/repos/gluster/glusterd2/stargazers","contributors_url":"https://api.github.com/repos/gluster/glusterd2/contributors","subscribers_url":"https://api.github.com/repos/gluster/glusterd2/subscribers","subscription_url":"https://api.github.com/repos/gluster/glusterd2/subscription","commits_url":"https://api.github.com/repos/gluster/glusterd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluster/glusterd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluster/glusterd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluster/glusterd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluster/glusterd2/contents/{+path}","compare_url":"https://api.github.com/repos/gluster/glusterd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluster/glusterd2/merges","archive_url":"https://api.github.com/repos/gluster/glusterd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluster/glusterd2/downloads","issues_url":"https://api.github.com/repos/gluster/glusterd2/issues{/number}","pulls_url":"https://api.github.com/repos/gluster/glusterd2/pulls{/number}","milestones_url":"https://api.github.com/repos/gluster/glusterd2/milestones{/number}","notifications_url":"https://api.github.com/repos/gluster/glusterd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluster/glusterd2/labels{/name}","releases_url":"https://api.github.com/repos/gluster/glusterd2/releases{/id}","deployments_url":"https://api.github.com/repos/gluster/glusterd2/deployments","created_at":"2014-09-23T12:02:13Z","updated_at":"2018-09-03T09:13:21Z","pushed_at":"2018-09-03T09:13:15Z","git_url":"git://github.com/gluster/glusterd2.git","ssh_url":"git@github.com:gluster/glusterd2.git","clone_url":"https://github.com/gluster/glusterd2.git","svn_url":"https://github.com/gluster/glusterd2","homepage":"","size":12949,"stargazers_count":112,"watchers_count":112,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":242,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":66,"open_issues":242,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/1207"},"html":{"href":"https://github.com/gluster/glusterd2/pull/1207"},"issue":{"href":"https://api.github.com/repos/gluster/glusterd2/issues/1207"},"comments":{"href":"https://api.github.com/repos/gluster/glusterd2/issues/1207/comments"},"review_comments":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/1207/comments"},"review_comment":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/1207/commits"},"statuses":{"href":"https://api.github.com/repos/gluster/glusterd2/statuses/c68b85e729d4444ca7882aed12f72dce996426de"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rafikc30"}}