{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/hashicorp/sentinel-sdk/pulls/13","id":224122497,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MTIyNDk3","html_url":"https://github.com/hashicorp/sentinel-sdk/pull/13","diff_url":"https://github.com/hashicorp/sentinel-sdk/pull/13.diff","patch_url":"https://github.com/hashicorp/sentinel-sdk/pull/13.patch","issue_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/issues/13","number":13,"state":"closed","locked":false,"title":"framework: Report keys properly on Get error messages","user":{"login":"vancluever","id":10704423,"node_id":"MDQ6VXNlcjEwNzA0NDIz","avatar_url":"https://avatars0.githubusercontent.com/u/10704423?v=4","gravatar_id":"","url":"https://api.github.com/users/vancluever","html_url":"https://github.com/vancluever","followers_url":"https://api.github.com/users/vancluever/followers","following_url":"https://api.github.com/users/vancluever/following{/other_user}","gists_url":"https://api.github.com/users/vancluever/gists{/gist_id}","starred_url":"https://api.github.com/users/vancluever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vancluever/subscriptions","organizations_url":"https://api.github.com/users/vancluever/orgs","repos_url":"https://api.github.com/users/vancluever/repos","events_url":"https://api.github.com/users/vancluever/events{/privacy}","received_events_url":"https://api.github.com/users/vancluever/received_events","type":"User","site_admin":false},"body":"There's currently an off-by-one error on the error reporting with keys.\r\nExample: A get or call error on import.foo.bar(\"baz\") would only report\r\n\"foo\", and import.foo(\"bar\") would just return a blank string (\"\").\r\n\r\nThis corrects that. It also shifts the tests over to allow the\r\nvalidation of the error message as well, and adds a little bit more\r\ncoverage.","created_at":"2018-10-18T22:48:40Z","updated_at":"2018-10-30T16:09:07Z","closed_at":"2018-10-30T16:09:07Z","merged_at":"2018-10-30T16:09:07Z","merge_commit_sha":"f7e95bc14c75cae544689ce2613fc907402cdff7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mitchellh","id":1299,"node_id":"MDQ6VXNlcjEyOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1299?v=4","gravatar_id":"","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},{"login":"ryanuber","id":1642288,"node_id":"MDQ6VXNlcjE2NDIyODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1642288?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanuber","html_url":"https://github.com/ryanuber","followers_url":"https://api.github.com/users/ryanuber/followers","following_url":"https://api.github.com/users/ryanuber/following{/other_user}","gists_url":"https://api.github.com/users/ryanuber/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanuber/subscriptions","organizations_url":"https://api.github.com/users/ryanuber/orgs","repos_url":"https://api.github.com/users/ryanuber/repos","events_url":"https://api.github.com/users/ryanuber/events{/privacy}","received_events_url":"https://api.github.com/users/ryanuber/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/pulls/13/commits","review_comments_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/pulls/13/comments","review_comment_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/issues/13/comments","statuses_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/statuses/d609efb557ee464c228219abc749c7ecbb0c676d","head":{"label":"hashicorp:b-fix-key-errors","ref":"b-fix-key-errors","sha":"d609efb557ee464c228219abc749c7ecbb0c676d","user":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":101724344,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE3MjQzNDQ=","name":"sentinel-sdk","full_name":"hashicorp/sentinel-sdk","private":false,"owner":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hashicorp/sentinel-sdk","description":"This SDK allows developers to extend Sentinel to source external information for use in their policies.","fork":false,"url":"https://api.github.com/repos/hashicorp/sentinel-sdk","forks_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/forks","keys_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/teams","hooks_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/events","assignees_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/tags","blobs_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/languages","stargazers_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/subscription","commits_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/merges","archive_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/downloads","issues_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/deployments","created_at":"2017-08-29T05:57:48Z","updated_at":"2018-10-10T22:08:34Z","pushed_at":"2018-10-30T16:09:07Z","git_url":"git://github.com/hashicorp/sentinel-sdk.git","ssh_url":"git@github.com:hashicorp/sentinel-sdk.git","clone_url":"https://github.com/hashicorp/sentinel-sdk.git","svn_url":"https://github.com/hashicorp/sentinel-sdk","homepage":null,"size":60,"stargazers_count":20,"watchers_count":20,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":3,"open_issues":3,"watchers":20,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"c78efd1fe64733e83f259a356b5b6be26a00db84","user":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":101724344,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE3MjQzNDQ=","name":"sentinel-sdk","full_name":"hashicorp/sentinel-sdk","private":false,"owner":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hashicorp/sentinel-sdk","description":"This SDK allows developers to extend Sentinel to source external information for use in their policies.","fork":false,"url":"https://api.github.com/repos/hashicorp/sentinel-sdk","forks_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/forks","keys_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/teams","hooks_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/events","assignees_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/tags","blobs_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/languages","stargazers_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/subscription","commits_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/merges","archive_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/downloads","issues_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/sentinel-sdk/deployments","created_at":"2017-08-29T05:57:48Z","updated_at":"2018-10-10T22:08:34Z","pushed_at":"2018-10-30T16:09:07Z","git_url":"git://github.com/hashicorp/sentinel-sdk.git","ssh_url":"git@github.com:hashicorp/sentinel-sdk.git","clone_url":"https://github.com/hashicorp/sentinel-sdk.git","svn_url":"https://github.com/hashicorp/sentinel-sdk","homepage":null,"size":60,"stargazers_count":20,"watchers_count":20,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":3,"open_issues":3,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/sentinel-sdk/pulls/13"},"html":{"href":"https://github.com/hashicorp/sentinel-sdk/pull/13"},"issue":{"href":"https://api.github.com/repos/hashicorp/sentinel-sdk/issues/13"},"comments":{"href":"https://api.github.com/repos/hashicorp/sentinel-sdk/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/sentinel-sdk/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/sentinel-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/sentinel-sdk/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/sentinel-sdk/statuses/d609efb557ee464c228219abc749c7ecbb0c676d"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"vancluever","id":10704423,"node_id":"MDQ6VXNlcjEwNzA0NDIz","avatar_url":"https://avatars0.githubusercontent.com/u/10704423?v=4","gravatar_id":"","url":"https://api.github.com/users/vancluever","html_url":"https://github.com/vancluever","followers_url":"https://api.github.com/users/vancluever/followers","following_url":"https://api.github.com/users/vancluever/following{/other_user}","gists_url":"https://api.github.com/users/vancluever/gists{/gist_id}","starred_url":"https://api.github.com/users/vancluever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vancluever/subscriptions","organizations_url":"https://api.github.com/users/vancluever/orgs","repos_url":"https://api.github.com/users/vancluever/repos","events_url":"https://api.github.com/users/vancluever/events{/privacy}","received_events_url":"https://api.github.com/users/vancluever/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":97,"deletions":35,"changed_files":2}}
{"actor":{"display_login":"vancluever"}}