{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/comments/242806662","pull_request_review_id":186406686,"id":242806662,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjgwNjY2Mg==","diff_hunk":"@@ -19,7 +19,7 @@ namespace Dynamo.Applications.Properties {\n     // class via a tool like ResGen or Visual Studio.\n     // To add or remove a member, edit your .ResX file then rerun ResGen\n     // with the /str option, or rebuild your VS project.\n-    [global::System.CodeDom.Compiler.GeneratedCodeAttribute(\"System.Resources.Tools.StronglyTypedResourceBuilder\", \"4.0.0.0\")]\n+    [global::System.CodeDom.Compiler.GeneratedCodeAttribute(\"System.Resources.Tools.StronglyTypedResourceBuilder\", \"15.0.0.0\")]","path":"src/DynamoRevit/Properties/Resources.Designer.cs","position":5,"original_position":5,"commit_id":"718f91c1d77c95207f7e7062021580cf8402d716","original_commit_id":"718f91c1d77c95207f7e7062021580cf8402d716","user":{"login":"AndyDu1985","id":10704909,"node_id":"MDQ6VXNlcjEwNzA0OTA5","avatar_url":"https://avatars2.githubusercontent.com/u/10704909?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyDu1985","html_url":"https://github.com/AndyDu1985","followers_url":"https://api.github.com/users/AndyDu1985/followers","following_url":"https://api.github.com/users/AndyDu1985/following{/other_user}","gists_url":"https://api.github.com/users/AndyDu1985/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyDu1985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyDu1985/subscriptions","organizations_url":"https://api.github.com/users/AndyDu1985/orgs","repos_url":"https://api.github.com/users/AndyDu1985/repos","events_url":"https://api.github.com/users/AndyDu1985/events{/privacy}","received_events_url":"https://api.github.com/users/AndyDu1985/received_events","type":"User","site_admin":false},"body":"Is is OK to change from 4 to 15, here? @QilongTang ","created_at":"2018-12-19T06:55:15Z","updated_at":"2018-12-19T06:55:15Z","html_url":"https://github.com/DynamoDS/DynamoRevit/pull/2317#discussion_r242806662","pull_request_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/2317","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/comments/242806662"},"html":{"href":"https://github.com/DynamoDS/DynamoRevit/pull/2317#discussion_r242806662"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/2317"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/2317","id":239376960,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5Mzc2OTYw","html_url":"https://github.com/DynamoDS/DynamoRevit/pull/2317","diff_url":"https://github.com/DynamoDS/DynamoRevit/pull/2317.diff","patch_url":"https://github.com/DynamoDS/DynamoRevit/pull/2317.patch","issue_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/2317","number":2317,"state":"open","locked":false,"title":"Fix crash when exit Revit Host Doc and undo/redo in Dynamo","user":{"login":"AndyDu1985","id":10704909,"node_id":"MDQ6VXNlcjEwNzA0OTA5","avatar_url":"https://avatars2.githubusercontent.com/u/10704909?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyDu1985","html_url":"https://github.com/AndyDu1985","followers_url":"https://api.github.com/users/AndyDu1985/followers","following_url":"https://api.github.com/users/AndyDu1985/following{/other_user}","gists_url":"https://api.github.com/users/AndyDu1985/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyDu1985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyDu1985/subscriptions","organizations_url":"https://api.github.com/users/AndyDu1985/orgs","repos_url":"https://api.github.com/users/AndyDu1985/repos","events_url":"https://api.github.com/users/AndyDu1985/events{/privacy}","received_events_url":"https://api.github.com/users/AndyDu1985/received_events","type":"User","site_admin":false},"body":"Please Note:\r\n1. Before submitting the PR, please review [How to Contribute to Dynamo](https://github.com/DynamoDS/Dynamo/blob/master/CONTRIBUTING.md)\r\n2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)\r\n3. PRs will be reviewed from oldest to newest\r\n4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team\r\n5. PRs should use either Dynamo's default PR template or [one of these other template options](https://github.com/DynamoDS/Dynamo/wiki/Choosing-a-Pull-Request-Template) in order to be considered for review.\r\n6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.\r\n7. PRs made to the `DynamoRevit` repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a `LGTM` label is added to the PR.\r\n\r\n### Purpose\r\n\r\nFix crash when exit Revit Host Doc and undo/redo in Dynamo\r\n\r\nSteps to reproduce the crash:\r\n\r\n1. Launch Revit and create a new project\r\n2. Launch Dynamo\r\n3. In Dynamo, open the sample project, \"Geometry_Solids.dyn\", let the dynamo script produce some solids in the Revit model\r\n4. In the Dynamo viewer, do a change to the script (keep the Dynamo app window open)\r\n5. Switch to the Revit application window, close current Revit Document without saving\r\n6. Switch back to Dynamo, click Undo\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [x] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [x] The level of testing this PR includes is appropriate\r\n- [x] User facing strings, if any, are extracted into `*.resx` files\r\n- [x] Snapshot of UI changes, if any.\r\n\r\n### Reviewers\r\n\r\nQilongTang, ZiyunShang\r\n","created_at":"2018-12-18T06:21:52Z","updated_at":"2018-12-19T06:55:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1af82e52867ae55941cc8c240faf53ac56d6c93a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/2317/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/2317/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/2317/comments","statuses_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/statuses/718f91c1d77c95207f7e7062021580cf8402d716","head":{"label":"DynamoDS:FixDynamoCrash","ref":"FixDynamoCrash","sha":"718f91c1d77c95207f7e7062021580cf8402d716","user":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":22768182,"node_id":"MDEwOlJlcG9zaXRvcnkyMjc2ODE4Mg==","name":"DynamoRevit","full_name":"DynamoDS/DynamoRevit","private":false,"owner":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DynamoDS/DynamoRevit","description":"Dynamo Libraries for Revit","fork":false,"url":"https://api.github.com/repos/DynamoDS/DynamoRevit","forks_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/forks","keys_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/teams","hooks_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/events","assignees_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/tags","blobs_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/subscription","commits_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/merges","archive_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/downloads","issues_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/deployments","created_at":"2014-08-08T18:52:34Z","updated_at":"2018-12-16T19:46:00Z","pushed_at":"2018-12-19T06:49:37Z","git_url":"git://github.com/DynamoDS/DynamoRevit.git","ssh_url":"git@github.com:DynamoDS/DynamoRevit.git","clone_url":"https://github.com/DynamoDS/DynamoRevit.git","svn_url":"https://github.com/DynamoDS/DynamoRevit","homepage":"http://www.dynamobim.org","size":766860,"stargazers_count":96,"watchers_count":96,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":317,"license":null,"forks":112,"open_issues":317,"watchers":96,"default_branch":"Revit2019"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"64a058736d2aac3e46dc737f70391119650db142","user":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":22768182,"node_id":"MDEwOlJlcG9zaXRvcnkyMjc2ODE4Mg==","name":"DynamoRevit","full_name":"DynamoDS/DynamoRevit","private":false,"owner":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DynamoDS/DynamoRevit","description":"Dynamo Libraries for Revit","fork":false,"url":"https://api.github.com/repos/DynamoDS/DynamoRevit","forks_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/forks","keys_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/teams","hooks_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/events","assignees_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/tags","blobs_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/subscription","commits_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/merges","archive_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/downloads","issues_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/deployments","created_at":"2014-08-08T18:52:34Z","updated_at":"2018-12-16T19:46:00Z","pushed_at":"2018-12-19T06:49:37Z","git_url":"git://github.com/DynamoDS/DynamoRevit.git","ssh_url":"git@github.com:DynamoDS/DynamoRevit.git","clone_url":"https://github.com/DynamoDS/DynamoRevit.git","svn_url":"https://github.com/DynamoDS/DynamoRevit","homepage":"http://www.dynamobim.org","size":766860,"stargazers_count":96,"watchers_count":96,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":317,"license":null,"forks":112,"open_issues":317,"watchers":96,"default_branch":"Revit2019"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/2317"},"html":{"href":"https://github.com/DynamoDS/DynamoRevit/pull/2317"},"issue":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/2317"},"comments":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/2317/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/2317/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/2317/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/statuses/718f91c1d77c95207f7e7062021580cf8402d716"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AndyDu1985"}}