{"action":"closed","issue":{"url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/209","repository_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding","labels_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/209/labels{/name}","comments_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/209/comments","events_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/209/events","html_url":"https://github.com/prysmaticlabs/geth-sharding/issues/209","id":334599490,"node_id":"MDU6SXNzdWUzMzQ1OTk0OTA=","number":209,"title":"Check AddHeader Transaction is Mined ","user":{"login":"terenc3t","id":21316537,"node_id":"MDQ6VXNlcjIxMzE2NTM3","avatar_url":"https://avatars1.githubusercontent.com/u/21316537?v=4","gravatar_id":"","url":"https://api.github.com/users/terenc3t","html_url":"https://github.com/terenc3t","followers_url":"https://api.github.com/users/terenc3t/followers","following_url":"https://api.github.com/users/terenc3t/following{/other_user}","gists_url":"https://api.github.com/users/terenc3t/gists{/gist_id}","starred_url":"https://api.github.com/users/terenc3t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terenc3t/subscriptions","organizations_url":"https://api.github.com/users/terenc3t/orgs","repos_url":"https://api.github.com/users/terenc3t/repos","events_url":"https://api.github.com/users/terenc3t/events{/privacy}","received_events_url":"https://api.github.com/users/terenc3t/received_events","type":"User","site_admin":false},"labels":[{"id":953163898,"node_id":"MDU6TGFiZWw5NTMxNjM4OTg=","url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/labels/Beginner","name":"Beginner","color":"fef2c0","default":false},{"id":802129904,"node_id":"MDU6TGFiZWw4MDIxMjk5MDQ=","url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/labels/Bug","name":"Bug","color":"ee0701","default":false},{"id":802129908,"node_id":"MDU6TGFiZWw4MDIxMjk5MDg=","url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/labels/Good%20First%20Issue","name":"Good First Issue","color":"7057ff","default":false}],"state":"closed","locked":false,"assignee":{"login":"terenc3t","id":21316537,"node_id":"MDQ6VXNlcjIxMzE2NTM3","avatar_url":"https://avatars1.githubusercontent.com/u/21316537?v=4","gravatar_id":"","url":"https://api.github.com/users/terenc3t","html_url":"https://github.com/terenc3t","followers_url":"https://api.github.com/users/terenc3t/followers","following_url":"https://api.github.com/users/terenc3t/following{/other_user}","gists_url":"https://api.github.com/users/terenc3t/gists{/gist_id}","starred_url":"https://api.github.com/users/terenc3t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terenc3t/subscriptions","organizations_url":"https://api.github.com/users/terenc3t/orgs","repos_url":"https://api.github.com/users/terenc3t/repos","events_url":"https://api.github.com/users/terenc3t/events{/privacy}","received_events_url":"https://api.github.com/users/terenc3t/received_events","type":"User","site_admin":false},"assignees":[{"login":"terenc3t","id":21316537,"node_id":"MDQ6VXNlcjIxMzE2NTM3","avatar_url":"https://avatars1.githubusercontent.com/u/21316537?v=4","gravatar_id":"","url":"https://api.github.com/users/terenc3t","html_url":"https://github.com/terenc3t","followers_url":"https://api.github.com/users/terenc3t/followers","following_url":"https://api.github.com/users/terenc3t/following{/other_user}","gists_url":"https://api.github.com/users/terenc3t/gists{/gist_id}","starred_url":"https://api.github.com/users/terenc3t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terenc3t/subscriptions","organizations_url":"https://api.github.com/users/terenc3t/orgs","repos_url":"https://api.github.com/users/terenc3t/repos","events_url":"https://api.github.com/users/terenc3t/events{/privacy}","received_events_url":"https://api.github.com/users/terenc3t/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/milestones/1","html_url":"https://github.com/prysmaticlabs/geth-sharding/milestone/1","labels_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/milestones/1/labels","id":3141840,"node_id":"MDk6TWlsZXN0b25lMzE0MTg0MA==","number":1,"title":"Ruby","description":"The Ruby Release: Local Alphanet","creator":{"login":"prestonvanloon","id":7246818,"node_id":"MDQ6VXNlcjcyNDY4MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7246818?v=4","gravatar_id":"","url":"https://api.github.com/users/prestonvanloon","html_url":"https://github.com/prestonvanloon","followers_url":"https://api.github.com/users/prestonvanloon/followers","following_url":"https://api.github.com/users/prestonvanloon/following{/other_user}","gists_url":"https://api.github.com/users/prestonvanloon/gists{/gist_id}","starred_url":"https://api.github.com/users/prestonvanloon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestonvanloon/subscriptions","organizations_url":"https://api.github.com/users/prestonvanloon/orgs","repos_url":"https://api.github.com/users/prestonvanloon/repos","events_url":"https://api.github.com/users/prestonvanloon/events{/privacy}","received_events_url":"https://api.github.com/users/prestonvanloon/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":108,"state":"open","created_at":"2018-02-25T21:22:44Z","updated_at":"2018-06-29T03:34:00Z","due_on":"2018-08-01T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-06-21T18:04:28Z","updated_at":"2018-06-29T03:34:00Z","closed_at":"2018-06-29T03:34:00Z","author_association":"MEMBER","body":"We are missing an important checking step in proposer's `AddHeader` function. It doesn't wait for AddHeader's transaction to be mined before proceeding. Let's use `TransactionReceipt` and `WaitForTransaction` functionalities in #186 to check for TX status before proceeding further.\r\n\r\n```go\r\nfunc AddHeader(transactor mainchain.ContractTransactor, collation *sharding.Collation) error {\r\n\r\n\ttx, err := transactor.SMCTransactor().AddHeader(txOps, collation.Header().ShardID(), collation.Header().Period(), chunkRoot)\r\n\tif err != nil {\r\n\t\treturn fmt.Errorf(\"unable to add header to SMC: %v\", err)\r\n\t}\r\n\r\n        // Check and wait until TX gets mined!\r\n\r\n\tlog.Info(fmt.Sprintf(\"Add header transaction hash: %v\", tx.Hash().Hex()))\r\n\treturn nil\r\n}\r\n```\r\n"}}
{"actor":{"display_login":"nisdas"}}