{"action":"opened","number":28,"pull_request":{"url":"https://api.github.com/repos/ygrek/ocurl/pulls/28","id":167131198,"html_url":"https://github.com/ygrek/ocurl/pull/28","diff_url":"https://github.com/ygrek/ocurl/pull/28.diff","patch_url":"https://github.com/ygrek/ocurl/pull/28.patch","issue_url":"https://api.github.com/repos/ygrek/ocurl/issues/28","number":28,"state":"open","locked":false,"title":"Bind to curl_multi_wait instead of curl_multi_fdset + select","user":{"login":"nojb","id":113560,"avatar_url":"https://avatars3.githubusercontent.com/u/113560?v=4","gravatar_id":"","url":"https://api.github.com/users/nojb","html_url":"https://github.com/nojb","followers_url":"https://api.github.com/users/nojb/followers","following_url":"https://api.github.com/users/nojb/following{/other_user}","gists_url":"https://api.github.com/users/nojb/gists{/gist_id}","starred_url":"https://api.github.com/users/nojb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojb/subscriptions","organizations_url":"https://api.github.com/users/nojb/orgs","repos_url":"https://api.github.com/users/nojb/repos","events_url":"https://api.github.com/users/nojb/events{/privacy}","received_events_url":"https://api.github.com/users/nojb/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nI am trying to use `Curl.Multi.{perform,wait}` under Windows. Unfortunately it does not really work because `curl_mult_fdset` returns `-1` in the `maxfd` argument, signaling that `select` cannot be used (see doc at https://curl.haxx.se/libcurl/c/curl_multi_fdset.html).\r\n\r\nInstead I tried with the function `curl_multi_wait` which is the recommended way to do select-style polling (see doc at https://curl.haxx.se/libcurl/c/curl_multi_wait.html). This seems to work fine and the C code is simpler.\r\n\r\nThis PR replaces the use of `curl_mult_fdset` + `select` by the simpler use of `curl_multi_wait` which has the advantage of working under Windows and also (according to the documentation) behaves better with respect to the usual limit of file descriptors of `select`.","created_at":"2018-02-05T12:26:49Z","updated_at":"2018-02-05T12:26:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/ygrek/ocurl/pulls/28/commits","review_comments_url":"https://api.github.com/repos/ygrek/ocurl/pulls/28/comments","review_comment_url":"https://api.github.com/repos/ygrek/ocurl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ygrek/ocurl/issues/28/comments","statuses_url":"https://api.github.com/repos/ygrek/ocurl/statuses/6e368877c968cb635cdc122f2d84e1963a0d6b88","head":{"label":"nojb:master","ref":"master","sha":"6e368877c968cb635cdc122f2d84e1963a0d6b88","user":{"login":"nojb","id":113560,"avatar_url":"https://avatars3.githubusercontent.com/u/113560?v=4","gravatar_id":"","url":"https://api.github.com/users/nojb","html_url":"https://github.com/nojb","followers_url":"https://api.github.com/users/nojb/followers","following_url":"https://api.github.com/users/nojb/following{/other_user}","gists_url":"https://api.github.com/users/nojb/gists{/gist_id}","starred_url":"https://api.github.com/users/nojb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojb/subscriptions","organizations_url":"https://api.github.com/users/nojb/orgs","repos_url":"https://api.github.com/users/nojb/repos","events_url":"https://api.github.com/users/nojb/events{/privacy}","received_events_url":"https://api.github.com/users/nojb/received_events","type":"User","site_admin":false},"repo":{"id":96908971,"name":"ocurl","full_name":"nojb/ocurl","owner":{"login":"nojb","id":113560,"avatar_url":"https://avatars3.githubusercontent.com/u/113560?v=4","gravatar_id":"","url":"https://api.github.com/users/nojb","html_url":"https://github.com/nojb","followers_url":"https://api.github.com/users/nojb/followers","following_url":"https://api.github.com/users/nojb/following{/other_user}","gists_url":"https://api.github.com/users/nojb/gists{/gist_id}","starred_url":"https://api.github.com/users/nojb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojb/subscriptions","organizations_url":"https://api.github.com/users/nojb/orgs","repos_url":"https://api.github.com/users/nojb/repos","events_url":"https://api.github.com/users/nojb/events{/privacy}","received_events_url":"https://api.github.com/users/nojb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nojb/ocurl","description":"OCaml bindings to libcurl","fork":true,"url":"https://api.github.com/repos/nojb/ocurl","forks_url":"https://api.github.com/repos/nojb/ocurl/forks","keys_url":"https://api.github.com/repos/nojb/ocurl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nojb/ocurl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nojb/ocurl/teams","hooks_url":"https://api.github.com/repos/nojb/ocurl/hooks","issue_events_url":"https://api.github.com/repos/nojb/ocurl/issues/events{/number}","events_url":"https://api.github.com/repos/nojb/ocurl/events","assignees_url":"https://api.github.com/repos/nojb/ocurl/assignees{/user}","branches_url":"https://api.github.com/repos/nojb/ocurl/branches{/branch}","tags_url":"https://api.github.com/repos/nojb/ocurl/tags","blobs_url":"https://api.github.com/repos/nojb/ocurl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nojb/ocurl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nojb/ocurl/git/refs{/sha}","trees_url":"https://api.github.com/repos/nojb/ocurl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nojb/ocurl/statuses/{sha}","languages_url":"https://api.github.com/repos/nojb/ocurl/languages","stargazers_url":"https://api.github.com/repos/nojb/ocurl/stargazers","contributors_url":"https://api.github.com/repos/nojb/ocurl/contributors","subscribers_url":"https://api.github.com/repos/nojb/ocurl/subscribers","subscription_url":"https://api.github.com/repos/nojb/ocurl/subscription","commits_url":"https://api.github.com/repos/nojb/ocurl/commits{/sha}","git_commits_url":"https://api.github.com/repos/nojb/ocurl/git/commits{/sha}","comments_url":"https://api.github.com/repos/nojb/ocurl/comments{/number}","issue_comment_url":"https://api.github.com/repos/nojb/ocurl/issues/comments{/number}","contents_url":"https://api.github.com/repos/nojb/ocurl/contents/{+path}","compare_url":"https://api.github.com/repos/nojb/ocurl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nojb/ocurl/merges","archive_url":"https://api.github.com/repos/nojb/ocurl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nojb/ocurl/downloads","issues_url":"https://api.github.com/repos/nojb/ocurl/issues{/number}","pulls_url":"https://api.github.com/repos/nojb/ocurl/pulls{/number}","milestones_url":"https://api.github.com/repos/nojb/ocurl/milestones{/number}","notifications_url":"https://api.github.com/repos/nojb/ocurl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nojb/ocurl/labels{/name}","releases_url":"https://api.github.com/repos/nojb/ocurl/releases{/id}","deployments_url":"https://api.github.com/repos/nojb/ocurl/deployments","created_at":"2017-07-11T15:33:05Z","updated_at":"2017-07-11T15:33:06Z","pushed_at":"2018-02-05T12:17:08Z","git_url":"git://github.com/nojb/ocurl.git","ssh_url":"git@github.com:nojb/ocurl.git","clone_url":"https://github.com/nojb/ocurl.git","svn_url":"https://github.com/nojb/ocurl","homepage":"http://ygrek.org.ua/p/ocurl","size":859,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ygrek:master","ref":"master","sha":"53476be643a799c119ec492b893c4a53c93f024e","user":{"login":"ygrek","id":104087,"avatar_url":"https://avatars2.githubusercontent.com/u/104087?v=4","gravatar_id":"","url":"https://api.github.com/users/ygrek","html_url":"https://github.com/ygrek","followers_url":"https://api.github.com/users/ygrek/followers","following_url":"https://api.github.com/users/ygrek/following{/other_user}","gists_url":"https://api.github.com/users/ygrek/gists{/gist_id}","starred_url":"https://api.github.com/users/ygrek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ygrek/subscriptions","organizations_url":"https://api.github.com/users/ygrek/orgs","repos_url":"https://api.github.com/users/ygrek/repos","events_url":"https://api.github.com/users/ygrek/events{/privacy}","received_events_url":"https://api.github.com/users/ygrek/received_events","type":"User","site_admin":false},"repo":{"id":7883010,"name":"ocurl","full_name":"ygrek/ocurl","owner":{"login":"ygrek","id":104087,"avatar_url":"https://avatars2.githubusercontent.com/u/104087?v=4","gravatar_id":"","url":"https://api.github.com/users/ygrek","html_url":"https://github.com/ygrek","followers_url":"https://api.github.com/users/ygrek/followers","following_url":"https://api.github.com/users/ygrek/following{/other_user}","gists_url":"https://api.github.com/users/ygrek/gists{/gist_id}","starred_url":"https://api.github.com/users/ygrek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ygrek/subscriptions","organizations_url":"https://api.github.com/users/ygrek/orgs","repos_url":"https://api.github.com/users/ygrek/repos","events_url":"https://api.github.com/users/ygrek/events{/privacy}","received_events_url":"https://api.github.com/users/ygrek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ygrek/ocurl","description":"OCaml bindings to libcurl","fork":false,"url":"https://api.github.com/repos/ygrek/ocurl","forks_url":"https://api.github.com/repos/ygrek/ocurl/forks","keys_url":"https://api.github.com/repos/ygrek/ocurl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ygrek/ocurl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ygrek/ocurl/teams","hooks_url":"https://api.github.com/repos/ygrek/ocurl/hooks","issue_events_url":"https://api.github.com/repos/ygrek/ocurl/issues/events{/number}","events_url":"https://api.github.com/repos/ygrek/ocurl/events","assignees_url":"https://api.github.com/repos/ygrek/ocurl/assignees{/user}","branches_url":"https://api.github.com/repos/ygrek/ocurl/branches{/branch}","tags_url":"https://api.github.com/repos/ygrek/ocurl/tags","blobs_url":"https://api.github.com/repos/ygrek/ocurl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ygrek/ocurl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ygrek/ocurl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ygrek/ocurl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ygrek/ocurl/statuses/{sha}","languages_url":"https://api.github.com/repos/ygrek/ocurl/languages","stargazers_url":"https://api.github.com/repos/ygrek/ocurl/stargazers","contributors_url":"https://api.github.com/repos/ygrek/ocurl/contributors","subscribers_url":"https://api.github.com/repos/ygrek/ocurl/subscribers","subscription_url":"https://api.github.com/repos/ygrek/ocurl/subscription","commits_url":"https://api.github.com/repos/ygrek/ocurl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ygrek/ocurl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ygrek/ocurl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ygrek/ocurl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ygrek/ocurl/contents/{+path}","compare_url":"https://api.github.com/repos/ygrek/ocurl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ygrek/ocurl/merges","archive_url":"https://api.github.com/repos/ygrek/ocurl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ygrek/ocurl/downloads","issues_url":"https://api.github.com/repos/ygrek/ocurl/issues{/number}","pulls_url":"https://api.github.com/repos/ygrek/ocurl/pulls{/number}","milestones_url":"https://api.github.com/repos/ygrek/ocurl/milestones{/number}","notifications_url":"https://api.github.com/repos/ygrek/ocurl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ygrek/ocurl/labels{/name}","releases_url":"https://api.github.com/repos/ygrek/ocurl/releases{/id}","deployments_url":"https://api.github.com/repos/ygrek/ocurl/deployments","created_at":"2013-01-29T01:40:37Z","updated_at":"2017-11-20T14:39:17Z","pushed_at":"2018-01-09T22:03:00Z","git_url":"git://github.com/ygrek/ocurl.git","ssh_url":"git@github.com:ygrek/ocurl.git","clone_url":"https://github.com/ygrek/ocurl.git","svn_url":"https://github.com/ygrek/ocurl","homepage":"http://ygrek.org.ua/p/ocurl","size":926,"stargazers_count":26,"watchers_count":26,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":11,"open_issues":4,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ygrek/ocurl/pulls/28"},"html":{"href":"https://github.com/ygrek/ocurl/pull/28"},"issue":{"href":"https://api.github.com/repos/ygrek/ocurl/issues/28"},"comments":{"href":"https://api.github.com/repos/ygrek/ocurl/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/ygrek/ocurl/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/ygrek/ocurl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ygrek/ocurl/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/ygrek/ocurl/statuses/6e368877c968cb635cdc122f2d84e1963a0d6b88"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":12,"deletions":38,"changed_files":2}}
{"actor":{"display_login":"nojb"}}