{"action":"created","issue":{"url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/1042","repository_url":"https://api.github.com/repos/prysmaticlabs/prysm","labels_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/1042/labels{/name}","comments_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/1042/comments","events_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/1042/events","html_url":"https://github.com/prysmaticlabs/prysm/pull/1042","id":387109039,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjcxNzA4","number":1042,"title":"Add DepositParametersRecord to protobuf types","user":{"login":"prestonvanloon","id":7246818,"node_id":"MDQ6VXNlcjcyNDY4MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7246818?v=4","gravatar_id":"","url":"https://api.github.com/users/prestonvanloon","html_url":"https://github.com/prestonvanloon","followers_url":"https://api.github.com/users/prestonvanloon/followers","following_url":"https://api.github.com/users/prestonvanloon/following{/other_user}","gists_url":"https://api.github.com/users/prestonvanloon/gists{/gist_id}","starred_url":"https://api.github.com/users/prestonvanloon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestonvanloon/subscriptions","organizations_url":"https://api.github.com/users/prestonvanloon/orgs","repos_url":"https://api.github.com/users/prestonvanloon/repos","events_url":"https://api.github.com/users/prestonvanloon/events{/privacy}","received_events_url":"https://api.github.com/users/prestonvanloon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-12-04T03:55:45Z","updated_at":"2018-12-04T15:42:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/1042","html_url":"https://github.com/prysmaticlabs/prysm/pull/1042","diff_url":"https://github.com/prysmaticlabs/prysm/pull/1042.diff","patch_url":"https://github.com/prysmaticlabs/prysm/pull/1042.patch"},"body":"Matching spec at https://github.com/ethereum/eth2.0-specs/blob/c2227a59de89a8b233974f58d55e8a4401568bce/specs/core/0_beacon-chain.md#depositparametersrecord\r\n\r\n```python\r\n{\r\n    # BLS pubkey\r\n    'pubkey': 'uint384',\r\n    # BLS proof of possession (a BLS signature)\r\n    'proof_of_possession': ['uint384'],\r\n    # Withdrawal credentials (TODO: define the format)\r\n    'withdrawal_credentials': 'hash32',\r\n    # The initial RANDAO commitment\r\n    'randao_commitment': 'hash32',\r\n}\r\n```\r\n\r\nPart of #781"},"comment":{"url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/comments/444146188","html_url":"https://github.com/prysmaticlabs/prysm/pull/1042#issuecomment-444146188","issue_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/1042","id":444146188,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDE0NjE4OA==","user":{"login":"terenc3t","id":21316537,"node_id":"MDQ6VXNlcjIxMzE2NTM3","avatar_url":"https://avatars1.githubusercontent.com/u/21316537?v=4","gravatar_id":"","url":"https://api.github.com/users/terenc3t","html_url":"https://github.com/terenc3t","followers_url":"https://api.github.com/users/terenc3t/followers","following_url":"https://api.github.com/users/terenc3t/following{/other_user}","gists_url":"https://api.github.com/users/terenc3t/gists{/gist_id}","starred_url":"https://api.github.com/users/terenc3t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terenc3t/subscriptions","organizations_url":"https://api.github.com/users/terenc3t/orgs","repos_url":"https://api.github.com/users/terenc3t/repos","events_url":"https://api.github.com/users/terenc3t/events{/privacy}","received_events_url":"https://api.github.com/users/terenc3t/received_events","type":"User","site_admin":false},"created_at":"2018-12-04T15:42:56Z","updated_at":"2018-12-04T15:42:56Z","author_association":"MEMBER","body":"I don't feel strongly against putting the unused spec data structs in proto although we might not need this for querying RPC data far down the line.\r\n\r\nI think in general we categorize spec data structs into 2 types:\r\n \r\nType 1\r\n- Gets passed between inter-services\r\n- Gets passed between beacon node and validator client\r\n- Gets passed between nodes in p2p network\r\n- Examples: Block, state and object within block like attestation or object within state like cross link\r\n- These should be in proto\r\n\r\nType 2\r\n- Gets serialized and deserialized\r\n- Only the bytecode gets included in block or state\r\n- Examples: Special objects, proposer attestations\r\n- These don't have to be in proto\r\n\r\nI'm ok with either decision : )"}}
{"actor":{"display_login":"terenc3t"}}