{"action":"created","comment":{"url":"https://api.github.com/repos/sync-for-science/test-suite/pulls/comments/169534167","pull_request_review_id":98074319,"id":169534167,"diff_hunk":"@@ -5,13 +5,20 @@ Feature: App exchanges authorization code for access token\n         Given OAuth is enabled\n         And I am not logged in\n         When I ask for authorization\n-        And I exchange my authorization code\n+        And I exchange my authorization code via a POST request\n         Then the response code should be 200\n         And the JSON response will contain access_token\n         And the JSON response will contain token_type\n         And the JSON response will contain scope\n         And the JSON response will contain patient\n \n+    Scenario: We cannot use a \"GET\" request for retrieving an access token\n+        Given OAuth is enabled\n+        And I am not logged in\n+        When I ask for authorization\n+        And I exchange my authorization code via a GET request\n+        Then the response code should be 405","path":"features/20-exchange-access-token.feature","position":17,"original_position":17,"commit_id":"f78fa8f91d2dc80629a326fd74e72b6f80e4ee9d","original_commit_id":"f78fa8f91d2dc80629a326fd74e72b6f80e4ee9d","user":{"login":"jmandel","id":313089,"avatar_url":"https://avatars0.githubusercontent.com/u/313089?v=4","gravatar_id":"","url":"https://api.github.com/users/jmandel","html_url":"https://github.com/jmandel","followers_url":"https://api.github.com/users/jmandel/followers","following_url":"https://api.github.com/users/jmandel/following{/other_user}","gists_url":"https://api.github.com/users/jmandel/gists{/gist_id}","starred_url":"https://api.github.com/users/jmandel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmandel/subscriptions","organizations_url":"https://api.github.com/users/jmandel/orgs","repos_url":"https://api.github.com/users/jmandel/repos","events_url":"https://api.github.com/users/jmandel/events{/privacy}","received_events_url":"https://api.github.com/users/jmandel/received_events","type":"User","site_admin":false},"body":"I might be less prescriptive on this even the 405 is technically correct, the main invariant that we want to enforce is that the result does succeed -- 4xx or 5xx","created_at":"2018-02-21T04:46:05Z","updated_at":"2018-02-21T04:47:47Z","html_url":"https://github.com/sync-for-science/test-suite/pull/130#discussion_r169534167","pull_request_url":"https://api.github.com/repos/sync-for-science/test-suite/pulls/130","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sync-for-science/test-suite/pulls/comments/169534167"},"html":{"href":"https://github.com/sync-for-science/test-suite/pull/130#discussion_r169534167"},"pull_request":{"href":"https://api.github.com/repos/sync-for-science/test-suite/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/sync-for-science/test-suite/pulls/130","id":170357699,"html_url":"https://github.com/sync-for-science/test-suite/pull/130","diff_url":"https://github.com/sync-for-science/test-suite/pull/130.diff","patch_url":"https://github.com/sync-for-science/test-suite/pull/130.patch","issue_url":"https://api.github.com/repos/sync-for-science/test-suite/issues/130","number":130,"state":"open","locked":false,"title":"sync-for-science/tracking#154 - Adding a new test that should force a…","user":{"login":"mtmcduffie","id":1562086,"avatar_url":"https://avatars1.githubusercontent.com/u/1562086?v=4","gravatar_id":"","url":"https://api.github.com/users/mtmcduffie","html_url":"https://github.com/mtmcduffie","followers_url":"https://api.github.com/users/mtmcduffie/followers","following_url":"https://api.github.com/users/mtmcduffie/following{/other_user}","gists_url":"https://api.github.com/users/mtmcduffie/gists{/gist_id}","starred_url":"https://api.github.com/users/mtmcduffie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtmcduffie/subscriptions","organizations_url":"https://api.github.com/users/mtmcduffie/orgs","repos_url":"https://api.github.com/users/mtmcduffie/repos","events_url":"https://api.github.com/users/mtmcduffie/events{/privacy}","received_events_url":"https://api.github.com/users/mtmcduffie/received_events","type":"User","site_admin":false},"body":"… 405 error.","created_at":"2018-02-21T01:50:36Z","updated_at":"2018-02-21T04:47:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42e5288c3213b63fb5b04b7aae3a5dc045876a14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sync-for-science/test-suite/pulls/130/commits","review_comments_url":"https://api.github.com/repos/sync-for-science/test-suite/pulls/130/comments","review_comment_url":"https://api.github.com/repos/sync-for-science/test-suite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sync-for-science/test-suite/issues/130/comments","statuses_url":"https://api.github.com/repos/sync-for-science/test-suite/statuses/f78fa8f91d2dc80629a326fd74e72b6f80e4ee9d","head":{"label":"sync-for-science:154","ref":"154","sha":"f78fa8f91d2dc80629a326fd74e72b6f80e4ee9d","user":{"login":"sync-for-science","id":17785143,"avatar_url":"https://avatars3.githubusercontent.com/u/17785143?v=4","gravatar_id":"","url":"https://api.github.com/users/sync-for-science","html_url":"https://github.com/sync-for-science","followers_url":"https://api.github.com/users/sync-for-science/followers","following_url":"https://api.github.com/users/sync-for-science/following{/other_user}","gists_url":"https://api.github.com/users/sync-for-science/gists{/gist_id}","starred_url":"https://api.github.com/users/sync-for-science/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sync-for-science/subscriptions","organizations_url":"https://api.github.com/users/sync-for-science/orgs","repos_url":"https://api.github.com/users/sync-for-science/repos","events_url":"https://api.github.com/users/sync-for-science/events{/privacy}","received_events_url":"https://api.github.com/users/sync-for-science/received_events","type":"Organization","site_admin":false},"repo":{"id":57923529,"name":"test-suite","full_name":"sync-for-science/test-suite","owner":{"login":"sync-for-science","id":17785143,"avatar_url":"https://avatars3.githubusercontent.com/u/17785143?v=4","gravatar_id":"","url":"https://api.github.com/users/sync-for-science","html_url":"https://github.com/sync-for-science","followers_url":"https://api.github.com/users/sync-for-science/followers","following_url":"https://api.github.com/users/sync-for-science/following{/other_user}","gists_url":"https://api.github.com/users/sync-for-science/gists{/gist_id}","starred_url":"https://api.github.com/users/sync-for-science/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sync-for-science/subscriptions","organizations_url":"https://api.github.com/users/sync-for-science/orgs","repos_url":"https://api.github.com/users/sync-for-science/repos","events_url":"https://api.github.com/users/sync-for-science/events{/privacy}","received_events_url":"https://api.github.com/users/sync-for-science/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sync-for-science/test-suite","description":"Test Suite for Sync for Science","fork":false,"url":"https://api.github.com/repos/sync-for-science/test-suite","forks_url":"https://api.github.com/repos/sync-for-science/test-suite/forks","keys_url":"https://api.github.com/repos/sync-for-science/test-suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sync-for-science/test-suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sync-for-science/test-suite/teams","hooks_url":"https://api.github.com/repos/sync-for-science/test-suite/hooks","issue_events_url":"https://api.github.com/repos/sync-for-science/test-suite/issues/events{/number}","events_url":"https://api.github.com/repos/sync-for-science/test-suite/events","assignees_url":"https://api.github.com/repos/sync-for-science/test-suite/assignees{/user}","branches_url":"https://api.github.com/repos/sync-for-science/test-suite/branches{/branch}","tags_url":"https://api.github.com/repos/sync-for-science/test-suite/tags","blobs_url":"https://api.github.com/repos/sync-for-science/test-suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sync-for-science/test-suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sync-for-science/test-suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/sync-for-science/test-suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sync-for-science/test-suite/statuses/{sha}","languages_url":"https://api.github.com/repos/sync-for-science/test-suite/languages","stargazers_url":"https://api.github.com/repos/sync-for-science/test-suite/stargazers","contributors_url":"https://api.github.com/repos/sync-for-science/test-suite/contributors","subscribers_url":"https://api.github.com/repos/sync-for-science/test-suite/subscribers","subscription_url":"https://api.github.com/repos/sync-for-science/test-suite/subscription","commits_url":"https://api.github.com/repos/sync-for-science/test-suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/sync-for-science/test-suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/sync-for-science/test-suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/sync-for-science/test-suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/sync-for-science/test-suite/contents/{+path}","compare_url":"https://api.github.com/repos/sync-for-science/test-suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sync-for-science/test-suite/merges","archive_url":"https://api.github.com/repos/sync-for-science/test-suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sync-for-science/test-suite/downloads","issues_url":"https://api.github.com/repos/sync-for-science/test-suite/issues{/number}","pulls_url":"https://api.github.com/repos/sync-for-science/test-suite/pulls{/number}","milestones_url":"https://api.github.com/repos/sync-for-science/test-suite/milestones{/number}","notifications_url":"https://api.github.com/repos/sync-for-science/test-suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sync-for-science/test-suite/labels{/name}","releases_url":"https://api.github.com/repos/sync-for-science/test-suite/releases{/id}","deployments_url":"https://api.github.com/repos/sync-for-science/test-suite/deployments","created_at":"2016-05-02T21:48:09Z","updated_at":"2018-01-29T21:44:51Z","pushed_at":"2018-02-21T02:48:28Z","git_url":"git://github.com/sync-for-science/test-suite.git","ssh_url":"git@github.com:sync-for-science/test-suite.git","clone_url":"https://github.com/sync-for-science/test-suite.git","svn_url":"https://github.com/sync-for-science/test-suite","homepage":"http://syncfor.science/","size":26648,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":10,"open_issues":5,"watchers":7,"default_branch":"master"}},"base":{"label":"sync-for-science:master","ref":"master","sha":"546c23731d307bea77234ce6c85456f8627b4117","user":{"login":"sync-for-science","id":17785143,"avatar_url":"https://avatars3.githubusercontent.com/u/17785143?v=4","gravatar_id":"","url":"https://api.github.com/users/sync-for-science","html_url":"https://github.com/sync-for-science","followers_url":"https://api.github.com/users/sync-for-science/followers","following_url":"https://api.github.com/users/sync-for-science/following{/other_user}","gists_url":"https://api.github.com/users/sync-for-science/gists{/gist_id}","starred_url":"https://api.github.com/users/sync-for-science/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sync-for-science/subscriptions","organizations_url":"https://api.github.com/users/sync-for-science/orgs","repos_url":"https://api.github.com/users/sync-for-science/repos","events_url":"https://api.github.com/users/sync-for-science/events{/privacy}","received_events_url":"https://api.github.com/users/sync-for-science/received_events","type":"Organization","site_admin":false},"repo":{"id":57923529,"name":"test-suite","full_name":"sync-for-science/test-suite","owner":{"login":"sync-for-science","id":17785143,"avatar_url":"https://avatars3.githubusercontent.com/u/17785143?v=4","gravatar_id":"","url":"https://api.github.com/users/sync-for-science","html_url":"https://github.com/sync-for-science","followers_url":"https://api.github.com/users/sync-for-science/followers","following_url":"https://api.github.com/users/sync-for-science/following{/other_user}","gists_url":"https://api.github.com/users/sync-for-science/gists{/gist_id}","starred_url":"https://api.github.com/users/sync-for-science/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sync-for-science/subscriptions","organizations_url":"https://api.github.com/users/sync-for-science/orgs","repos_url":"https://api.github.com/users/sync-for-science/repos","events_url":"https://api.github.com/users/sync-for-science/events{/privacy}","received_events_url":"https://api.github.com/users/sync-for-science/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sync-for-science/test-suite","description":"Test Suite for Sync for Science","fork":false,"url":"https://api.github.com/repos/sync-for-science/test-suite","forks_url":"https://api.github.com/repos/sync-for-science/test-suite/forks","keys_url":"https://api.github.com/repos/sync-for-science/test-suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sync-for-science/test-suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sync-for-science/test-suite/teams","hooks_url":"https://api.github.com/repos/sync-for-science/test-suite/hooks","issue_events_url":"https://api.github.com/repos/sync-for-science/test-suite/issues/events{/number}","events_url":"https://api.github.com/repos/sync-for-science/test-suite/events","assignees_url":"https://api.github.com/repos/sync-for-science/test-suite/assignees{/user}","branches_url":"https://api.github.com/repos/sync-for-science/test-suite/branches{/branch}","tags_url":"https://api.github.com/repos/sync-for-science/test-suite/tags","blobs_url":"https://api.github.com/repos/sync-for-science/test-suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sync-for-science/test-suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sync-for-science/test-suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/sync-for-science/test-suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sync-for-science/test-suite/statuses/{sha}","languages_url":"https://api.github.com/repos/sync-for-science/test-suite/languages","stargazers_url":"https://api.github.com/repos/sync-for-science/test-suite/stargazers","contributors_url":"https://api.github.com/repos/sync-for-science/test-suite/contributors","subscribers_url":"https://api.github.com/repos/sync-for-science/test-suite/subscribers","subscription_url":"https://api.github.com/repos/sync-for-science/test-suite/subscription","commits_url":"https://api.github.com/repos/sync-for-science/test-suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/sync-for-science/test-suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/sync-for-science/test-suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/sync-for-science/test-suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/sync-for-science/test-suite/contents/{+path}","compare_url":"https://api.github.com/repos/sync-for-science/test-suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sync-for-science/test-suite/merges","archive_url":"https://api.github.com/repos/sync-for-science/test-suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sync-for-science/test-suite/downloads","issues_url":"https://api.github.com/repos/sync-for-science/test-suite/issues{/number}","pulls_url":"https://api.github.com/repos/sync-for-science/test-suite/pulls{/number}","milestones_url":"https://api.github.com/repos/sync-for-science/test-suite/milestones{/number}","notifications_url":"https://api.github.com/repos/sync-for-science/test-suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sync-for-science/test-suite/labels{/name}","releases_url":"https://api.github.com/repos/sync-for-science/test-suite/releases{/id}","deployments_url":"https://api.github.com/repos/sync-for-science/test-suite/deployments","created_at":"2016-05-02T21:48:09Z","updated_at":"2018-01-29T21:44:51Z","pushed_at":"2018-02-21T02:48:28Z","git_url":"git://github.com/sync-for-science/test-suite.git","ssh_url":"git@github.com:sync-for-science/test-suite.git","clone_url":"https://github.com/sync-for-science/test-suite.git","svn_url":"https://github.com/sync-for-science/test-suite","homepage":"http://syncfor.science/","size":26648,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":10,"open_issues":5,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sync-for-science/test-suite/pulls/130"},"html":{"href":"https://github.com/sync-for-science/test-suite/pull/130"},"issue":{"href":"https://api.github.com/repos/sync-for-science/test-suite/issues/130"},"comments":{"href":"https://api.github.com/repos/sync-for-science/test-suite/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/sync-for-science/test-suite/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/sync-for-science/test-suite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sync-for-science/test-suite/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/sync-for-science/test-suite/statuses/f78fa8f91d2dc80629a326fd74e72b6f80e4ee9d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmandel"}}