{"action":"created","issue":{"url":"https://api.github.com/repos/andrew-bibb/cmst/issues/187","repository_url":"https://api.github.com/repos/andrew-bibb/cmst","labels_url":"https://api.github.com/repos/andrew-bibb/cmst/issues/187/labels{/name}","comments_url":"https://api.github.com/repos/andrew-bibb/cmst/issues/187/comments","events_url":"https://api.github.com/repos/andrew-bibb/cmst/issues/187/events","html_url":"https://github.com/andrew-bibb/cmst/pull/187","id":333001189,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzQwNTc1","number":187,"title":"Only call connectNotityClient when needed","user":{"login":"nicklaswj","id":1440212,"node_id":"MDQ6VXNlcjE0NDAyMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1440212?v=4","gravatar_id":"","url":"https://api.github.com/users/nicklaswj","html_url":"https://github.com/nicklaswj","followers_url":"https://api.github.com/users/nicklaswj/followers","following_url":"https://api.github.com/users/nicklaswj/following{/other_user}","gists_url":"https://api.github.com/users/nicklaswj/gists{/gist_id}","starred_url":"https://api.github.com/users/nicklaswj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicklaswj/subscriptions","organizations_url":"https://api.github.com/users/nicklaswj/orgs","repos_url":"https://api.github.com/users/nicklaswj/repos","events_url":"https://api.github.com/users/nicklaswj/events{/privacy}","received_events_url":"https://api.github.com/users/nicklaswj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-16T17:09:19Z","updated_at":"2018-06-19T00:43:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/andrew-bibb/cmst/pulls/187","html_url":"https://github.com/andrew-bibb/cmst/pull/187","diff_url":"https://github.com/andrew-bibb/cmst/pull/187.diff","patch_url":"https://github.com/andrew-bibb/cmst/pull/187.patch"},"body":"Only call connectNotitfy when the setting\r\n\"enable_daemon_notifications\" is true, to avoid\r\nunnecessary DBUS timeout wait time on CMST launch"},"comment":{"url":"https://api.github.com/repos/andrew-bibb/cmst/issues/comments/398238770","html_url":"https://github.com/andrew-bibb/cmst/pull/187#issuecomment-398238770","issue_url":"https://api.github.com/repos/andrew-bibb/cmst/issues/187","id":398238770,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODIzODc3MA==","user":{"login":"andrew-bibb","id":6935544,"node_id":"MDQ6VXNlcjY5MzU1NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6935544?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-bibb","html_url":"https://github.com/andrew-bibb","followers_url":"https://api.github.com/users/andrew-bibb/followers","following_url":"https://api.github.com/users/andrew-bibb/following{/other_user}","gists_url":"https://api.github.com/users/andrew-bibb/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-bibb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-bibb/subscriptions","organizations_url":"https://api.github.com/users/andrew-bibb/orgs","repos_url":"https://api.github.com/users/andrew-bibb/repos","events_url":"https://api.github.com/users/andrew-bibb/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-bibb/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T00:43:39Z","updated_at":"2018-06-19T00:43:39Z","author_association":"OWNER","body":"Yes you are correct, we should not go through the four timeouts if someone has said don't use the notification client. I would like to review the current code before I merge this.  For consistency I may want to handle this the same way we disable the VPN manager if somebody does not want it. It may take me a day or two (or three or four...) before I see which way I want to go.  Either way this feature will be incorporated.\r\n\r\nA quick look through just now and I also found one other initialization that I had which should be handled in a more consistent manner with the rest of the code.   \r\n\r\nThank you for finding it and preparing the PR.    "}}
{"actor":{"display_login":"andrew-bibb"}}