{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/235645767","pull_request_review_id":177557016,"id":235645767,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTY0NTc2Nw==","diff_hunk":"@@ -0,0 +1,40 @@\n+{ stdenv, fetchurl, fetchpatch, meson, ninja, pkgconfig, yacc, xkeyboard_config, libxcb, libX11, doxygen }:\n+\n+stdenv.mkDerivation rec {\n+  name = \"libxkbcommon-${version}\";\n+  version = \"0.7.2\";\n+\n+  src = fetchurl {\n+    url = \"https://xkbcommon.org/download/${name}.tar.xz\";\n+    sha256 = \"1n5rv5n210kjnkyrvbh04gfwaa7zrmzy1393p8nyqfw66lkxr918\";\n+  };\n+\n+  outputs = [ \"out\" \"dev\" \"doc\" ];\n+\n+  nativeBuildInputs = [ meson ninja pkgconfig yacc doxygen ];\n+  buildInputs = [ xkeyboard_config libxcb ];\n+\n+  patches = [\n+    # darwin compatibility\n+    (fetchpatch {\n+      url = https://github.com/xkbcommon/libxkbcommon/commit/edb1c662394578a54b7bbed231d918925e5d8150.patch;\n+      sha256 = \"0ydjlir32r3xfsbqhnsx1bz6ags2m908yhf9i09i1s7sgcimbcx5\";\n+    })\n+  ];\n+\n+  mesonFlags = [\n+    \"-Denable-wayland=false\"\n+    \"-Dxkb-config-root=${xkeyboard_config}/etc/X11/xkb\"\n+    \"-Dx-locale-root=${libX11.out}/share/X11/locale\"\n+  ];\n+\n+  doCheck = false; # fails, needs unicode locale","path":"pkgs/development/libraries/libxkbcommon/libxkbcommon_7.nix","position":31,"original_position":31,"commit_id":"fe12922256a62114a726a135addac4b9698b5260","original_commit_id":"fe12922256a62114a726a135addac4b9698b5260","user":{"login":"mrVanDalo","id":839693,"node_id":"MDQ6VXNlcjgzOTY5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/839693?v=4","gravatar_id":"","url":"https://api.github.com/users/mrVanDalo","html_url":"https://github.com/mrVanDalo","followers_url":"https://api.github.com/users/mrVanDalo/followers","following_url":"https://api.github.com/users/mrVanDalo/following{/other_user}","gists_url":"https://api.github.com/users/mrVanDalo/gists{/gist_id}","starred_url":"https://api.github.com/users/mrVanDalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrVanDalo/subscriptions","organizations_url":"https://api.github.com/users/mrVanDalo/orgs","repos_url":"https://api.github.com/users/mrVanDalo/repos","events_url":"https://api.github.com/users/mrVanDalo/events{/privacy}","received_events_url":"https://api.github.com/users/mrVanDalo/received_events","type":"User","site_admin":false},"body":"Yeah this came in after the version bump, according to git history.","created_at":"2018-11-22T09:05:11Z","updated_at":"2018-11-22T09:05:11Z","html_url":"https://github.com/NixOS/nixpkgs/pull/50652#discussion_r235645767","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50652","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/235645767"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/50652#discussion_r235645767"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50652"}},"in_reply_to_id":235567509},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50652","id":231827087,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODI3MDg3","html_url":"https://github.com/NixOS/nixpkgs/pull/50652","diff_url":"https://github.com/NixOS/nixpkgs/pull/50652.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/50652.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50652","number":50652,"state":"open","locked":false,"title":"Fix/bitwig","user":{"login":"mrVanDalo","id":839693,"node_id":"MDQ6VXNlcjgzOTY5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/839693?v=4","gravatar_id":"","url":"https://api.github.com/users/mrVanDalo","html_url":"https://github.com/mrVanDalo","followers_url":"https://api.github.com/users/mrVanDalo/followers","following_url":"https://api.github.com/users/mrVanDalo/following{/other_user}","gists_url":"https://api.github.com/users/mrVanDalo/gists{/gist_id}","starred_url":"https://api.github.com/users/mrVanDalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrVanDalo/subscriptions","organizations_url":"https://api.github.com/users/mrVanDalo/orgs","repos_url":"https://api.github.com/users/mrVanDalo/repos","events_url":"https://api.github.com/users/mrVanDalo/events{/privacy}","received_events_url":"https://api.github.com/users/mrVanDalo/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nfixing #49530\r\nI needed to split up libxkbcommon to version 8 and version 7.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-11-19T00:36:02Z","updated_at":"2018-11-22T09:05:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"101e0b29c882cd76d84cd0eed856aa6a4bb56400","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735640,"node_id":"MDU6TGFiZWw3MzE3MzU2NDA=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%20101-500","name":"10.rebuild-darwin: 101-500","color":"d93f0b","default":false},{"id":731734523,"node_id":"MDU6TGFiZWw3MzE3MzQ1MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%20501+","name":"10.rebuild-linux: 501+","color":"b60205","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50652/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50652/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50652/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/fe12922256a62114a726a135addac4b9698b5260","head":{"label":"mrVanDalo:fix/bitwig","ref":"fix/bitwig","sha":"fe12922256a62114a726a135addac4b9698b5260","user":{"login":"mrVanDalo","id":839693,"node_id":"MDQ6VXNlcjgzOTY5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/839693?v=4","gravatar_id":"","url":"https://api.github.com/users/mrVanDalo","html_url":"https://github.com/mrVanDalo","followers_url":"https://api.github.com/users/mrVanDalo/followers","following_url":"https://api.github.com/users/mrVanDalo/following{/other_user}","gists_url":"https://api.github.com/users/mrVanDalo/gists{/gist_id}","starred_url":"https://api.github.com/users/mrVanDalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrVanDalo/subscriptions","organizations_url":"https://api.github.com/users/mrVanDalo/orgs","repos_url":"https://api.github.com/users/mrVanDalo/repos","events_url":"https://api.github.com/users/mrVanDalo/events{/privacy}","received_events_url":"https://api.github.com/users/mrVanDalo/received_events","type":"User","site_admin":false},"repo":{"id":112524424,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1MjQ0MjQ=","name":"nixpkgs","full_name":"mrVanDalo/nixpkgs","private":false,"owner":{"login":"mrVanDalo","id":839693,"node_id":"MDQ6VXNlcjgzOTY5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/839693?v=4","gravatar_id":"","url":"https://api.github.com/users/mrVanDalo","html_url":"https://github.com/mrVanDalo","followers_url":"https://api.github.com/users/mrVanDalo/followers","following_url":"https://api.github.com/users/mrVanDalo/following{/other_user}","gists_url":"https://api.github.com/users/mrVanDalo/gists{/gist_id}","starred_url":"https://api.github.com/users/mrVanDalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrVanDalo/subscriptions","organizations_url":"https://api.github.com/users/mrVanDalo/orgs","repos_url":"https://api.github.com/users/mrVanDalo/repos","events_url":"https://api.github.com/users/mrVanDalo/events{/privacy}","received_events_url":"https://api.github.com/users/mrVanDalo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mrVanDalo/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/mrVanDalo/nixpkgs","forks_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/forks","keys_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/teams","hooks_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/events","assignees_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/tags","blobs_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/subscription","commits_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/merges","archive_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/downloads","issues_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/mrVanDalo/nixpkgs/deployments","created_at":"2017-11-29T20:29:21Z","updated_at":"2018-10-09T20:05:08Z","pushed_at":"2018-11-19T01:14:28Z","git_url":"git://github.com/mrVanDalo/nixpkgs.git","ssh_url":"git@github.com:mrVanDalo/nixpkgs.git","clone_url":"https://github.com/mrVanDalo/nixpkgs.git","svn_url":"https://github.com/mrVanDalo/nixpkgs","homepage":null,"size":839377,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"0925c482c8378e8a6a8724edc6596ea60f90a113","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-11-22T08:49:01Z","pushed_at":"2018-11-22T09:01:44Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":888974,"stargazers_count":3019,"watchers_count":3019,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3206,"mirror_url":null,"archived":false,"open_issues_count":3372,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3206,"open_issues":3372,"watchers":3019,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50652"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/50652"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/50652"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/50652/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50652/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50652/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/fe12922256a62114a726a135addac4b9698b5260"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mrVanDalo"}}