{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/7706","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/7706/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/7706/comments","events_url":"https://api.github.com/repos/helm/charts/issues/7706/events","html_url":"https://github.com/helm/charts/pull/7706","id":359726426,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTUyNjQ1","number":7706,"title":"Add support for deployment tolerations and update helpers","user":{"login":"shaunmansell","id":21325844,"node_id":"MDQ6VXNlcjIxMzI1ODQ0","avatar_url":"https://avatars3.githubusercontent.com/u/21325844?v=4","gravatar_id":"","url":"https://api.github.com/users/shaunmansell","html_url":"https://github.com/shaunmansell","followers_url":"https://api.github.com/users/shaunmansell/followers","following_url":"https://api.github.com/users/shaunmansell/following{/other_user}","gists_url":"https://api.github.com/users/shaunmansell/gists{/gist_id}","starred_url":"https://api.github.com/users/shaunmansell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaunmansell/subscriptions","organizations_url":"https://api.github.com/users/shaunmansell/orgs","repos_url":"https://api.github.com/users/shaunmansell/repos","events_url":"https://api.github.com/users/shaunmansell/events{/privacy}","received_events_url":"https://api.github.com/users/shaunmansell/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false}],"state":"open","locked":false,"assignee":{"login":"davidkarlsen","id":18299,"node_id":"MDQ6VXNlcjE4Mjk5","avatar_url":"https://avatars0.githubusercontent.com/u/18299?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkarlsen","html_url":"https://github.com/davidkarlsen","followers_url":"https://api.github.com/users/davidkarlsen/followers","following_url":"https://api.github.com/users/davidkarlsen/following{/other_user}","gists_url":"https://api.github.com/users/davidkarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkarlsen/subscriptions","organizations_url":"https://api.github.com/users/davidkarlsen/orgs","repos_url":"https://api.github.com/users/davidkarlsen/repos","events_url":"https://api.github.com/users/davidkarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/davidkarlsen/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidkarlsen","id":18299,"node_id":"MDQ6VXNlcjE4Mjk5","avatar_url":"https://avatars0.githubusercontent.com/u/18299?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkarlsen","html_url":"https://github.com/davidkarlsen","followers_url":"https://api.github.com/users/davidkarlsen/followers","following_url":"https://api.github.com/users/davidkarlsen/following{/other_user}","gists_url":"https://api.github.com/users/davidkarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkarlsen/subscriptions","organizations_url":"https://api.github.com/users/davidkarlsen/orgs","repos_url":"https://api.github.com/users/davidkarlsen/repos","events_url":"https://api.github.com/users/davidkarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/davidkarlsen/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-09-13T03:12:47Z","updated_at":"2018-09-29T18:17:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/7706","html_url":"https://github.com/helm/charts/pull/7706","diff_url":"https://github.com/helm/charts/pull/7706.diff","patch_url":"https://github.com/helm/charts/pull/7706.patch"},"body":"Signed-off-by: Shaun Mansell <shaun.s.mansell@gmail.com>\r\n\r\n<!--\r\nThank you for contributing to helm/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n1) Adds support for specifying tolerations in the deployment resource.\r\nA common use-case for node affinity is to set node labels **and** tolerations to work together, so we want support for both in the deployment to cover the common variations of node affinity.\r\n\r\n2) Updates the helper template functions to include the updated fullname and chart values.\r\nIf you used a release name that was the same as the chart name under the previous fullname template value, you'd end up with a fullname value that duplicate the same content. In this case, the fullname would end up as \"elasticsearch-exporter-elasticsearch-exporter\". The new helper function ensures this duplication doesn't happen any more.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/425665315","html_url":"https://github.com/helm/charts/pull/7706#issuecomment-425665315","issue_url":"https://api.github.com/repos/helm/charts/issues/7706","id":425665315,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTY2NTMxNQ==","user":{"login":"davidkarlsen","id":18299,"node_id":"MDQ6VXNlcjE4Mjk5","avatar_url":"https://avatars0.githubusercontent.com/u/18299?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkarlsen","html_url":"https://github.com/davidkarlsen","followers_url":"https://api.github.com/users/davidkarlsen/followers","following_url":"https://api.github.com/users/davidkarlsen/following{/other_user}","gists_url":"https://api.github.com/users/davidkarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkarlsen/subscriptions","organizations_url":"https://api.github.com/users/davidkarlsen/orgs","repos_url":"https://api.github.com/users/davidkarlsen/repos","events_url":"https://api.github.com/users/davidkarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/davidkarlsen/received_events","type":"User","site_admin":false},"created_at":"2018-09-29T18:17:13Z","updated_at":"2018-09-29T18:17:13Z","author_association":"MEMBER","body":"/lgtm"}}
{"actor":{"display_login":"davidkarlsen"}}