{"action":"created","issue":{"url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues/921","repository_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd","labels_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues/921/labels{/name}","comments_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues/921/comments","events_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues/921/events","html_url":"https://github.com/atlassian/react-beautiful-dnd/issues/921","id":380561139,"node_id":"MDU6SXNzdWUzODA1NjExMzk=","number":921,"title":"Draggable requires a draggableId","user":{"login":"flipchart","id":1951912,"node_id":"MDQ6VXNlcjE5NTE5MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1951912?v=4","gravatar_id":"","url":"https://api.github.com/users/flipchart","html_url":"https://github.com/flipchart","followers_url":"https://api.github.com/users/flipchart/followers","following_url":"https://api.github.com/users/flipchart/following{/other_user}","gists_url":"https://api.github.com/users/flipchart/gists{/gist_id}","starred_url":"https://api.github.com/users/flipchart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flipchart/subscriptions","organizations_url":"https://api.github.com/users/flipchart/orgs","repos_url":"https://api.github.com/users/flipchart/repos","events_url":"https://api.github.com/users/flipchart/events{/privacy}","received_events_url":"https://api.github.com/users/flipchart/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-14T06:56:54Z","updated_at":"2018-11-14T09:50:06Z","closed_at":null,"author_association":"NONE","body":"## Bug or feature request?\r\n\r\nBug\r\n\r\n<!--\r\n## Get started\r\nIf you are new to `react-beautiful-dnd` we recommend taking at look at our getting started course: https://egghead.io/courses/beautiful-and-accessible-drag-and-drop-with-react-beautiful-dnd\r\n\r\nIt will give you a good base understanding of how everything fits together. This can often be the best help in overcomming your issue.\r\n\r\n## Duplicates\r\n\r\nBefore raising a feature request or bug please search through our open and closed issues to see if there is something similar. If you do find one similar you can show it is important to you by adding a reaction (such as 👍) to the issue\r\n\r\nOpen and closed issues:\r\nhttps://github.com/atlassian/react-beautiful-dnd/issues?utf8=%E2%9C%93&q=is%3Aopen%20is%3Aclosed%20is%3Aissue%20\r\n-->\r\n\r\n<!--\r\n## Feature request\r\n\r\nThis is not a general purpose drag and drop library and is attempting\r\nto create an experience that is more physical than standard drag and drop\r\ninteractions on the web.\r\n\r\nBefore raising a new feature please ensure that it falls within the philosophy\r\nof the library.\r\n\r\nhttps://github.com/atlassian/react-beautiful-dnd#driving-philosophy-physicality\r\n\r\nAll features need to have a clear and generally applicable keyboard interaction pattern in order for us to deliver on our core goal of being highly accessible.\r\n-->\r\n\r\n<!-- ## Bug -->\r\n\r\n### Expected behavior\r\nNo error\r\n\r\n### Actual behavior\r\nConsole error & exception: Draggable requires a draggableId\r\n\r\n### Steps to reproduce\r\nCreate a Draggable element with a draggableId set to 0. The props checker checks for falsey values which renders the (IMO) perfectly acceptable draggableId value of 0 as false and throws the exception\r\n\r\n### What version of `React` are you using?\r\n16.6.3\r\n<!--\r\n  Take a look at your package.json\r\n  Ensure that it satifies our peer dependency version - see our package.json. (Currently it is \"^16.3.1\")\r\n-->\r\n\r\n### What version of `react-beautiful-dnd` are you running?\r\n10.0.1\r\n<!--\r\n  We will only look into issues that are effecting the latest version.\r\n  At this stage we are not releasing fixes for previous releases\r\n-->\r\n\r\n### What browser are you using?\r\nChrome\r\n<!--\r\nKeep in mind our supported browser matrix https://confluence.atlassian.com/cloud/supported-browsers-744721663.html\r\nIf you raise a bug that is not in a supported version we will not be fixing it\r\n-->\r\n\r\n### Demo\r\n\r\n<!--\r\nPlease provide an example to show the issue. Here is a boilerplate to help you get started:\r\nhttps://codesandbox.io/s/k260nyxq9v\r\n\r\nIf you paste a big block of code it can be difficult to debug it.\r\n\r\nIf it is a visual bug, a video or a gif would be helpful also.\r\n\r\nIssues without demo's may not be investigated\r\n-->\r\n\r\n<!--\r\nNote: stale issues will be removed\r\nWhen a maintainer asks a question about an issue and it is not responded to within a reasonable timeframe then the issue will be closed. We don't want this to happen - but we also do not want to accumulate stale issues\r\n--->\r\n"},"comment":{"url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues/comments/438602479","html_url":"https://github.com/atlassian/react-beautiful-dnd/issues/921#issuecomment-438602479","issue_url":"https://api.github.com/repos/atlassian/react-beautiful-dnd/issues/921","id":438602479,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODYwMjQ3OQ==","user":{"login":"TrySound","id":5635476,"node_id":"MDQ6VXNlcjU2MzU0NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/5635476?v=4","gravatar_id":"","url":"https://api.github.com/users/TrySound","html_url":"https://github.com/TrySound","followers_url":"https://api.github.com/users/TrySound/followers","following_url":"https://api.github.com/users/TrySound/following{/other_user}","gists_url":"https://api.github.com/users/TrySound/gists{/gist_id}","starred_url":"https://api.github.com/users/TrySound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrySound/subscriptions","organizations_url":"https://api.github.com/users/TrySound/orgs","repos_url":"https://api.github.com/users/TrySound/repos","events_url":"https://api.github.com/users/TrySound/events{/privacy}","received_events_url":"https://api.github.com/users/TrySound/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T09:50:06Z","updated_at":"2018-11-14T09:50:06Z","author_association":"CONTRIBUTOR","body":"@alexreardon Need a null check here https://github.com/atlassian/react-beautiful-dnd/blob/master/src/view/draggable/check-own-props.js#L12\r\n```\r\ninvariant(props.draggableId != null, 'Draggable requires a draggableId');\r\n```\r\n\r\n@flipchart Could you rename the issue title to something like `draggableId does not accept 0`"}}
{"actor":{"display_login":"TrySound"}}