{"action":"created","comment":{"url":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls/comments/213714993","pull_request_review_id":150607651,"id":213714993,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzcxNDk5Mw==","diff_hunk":"@@ -170,7 +153,7 @@ func (hc *HealthController) RunServer(stopCh <-chan struct{}, wg *sync.WaitGroup\n \n //RunCheck starts the HealthController's check\n func (hc *HealthController) RunCheck(healthChan <-chan *ControllerHeartbeat, stopCh <-chan struct{}, wg *sync.WaitGroup) error {\n-\tt := time.NewTicker(5000 * time.Millisecond)\n+\tt := time.NewTicker(1000 * time.Millisecond)","path":"pkg/healthcheck/health_controller.go","position":109,"original_position":109,"commit_id":"65b8c4bcc960ccea1abb70f6dfdd545301d6fc4d","original_commit_id":"65b8c4bcc960ccea1abb70f6dfdd545301d6fc4d","user":{"login":"andrewsykim","id":12699319,"node_id":"MDQ6VXNlcjEyNjk5MzE5","avatar_url":"https://avatars0.githubusercontent.com/u/12699319?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewsykim","html_url":"https://github.com/andrewsykim","followers_url":"https://api.github.com/users/andrewsykim/followers","following_url":"https://api.github.com/users/andrewsykim/following{/other_user}","gists_url":"https://api.github.com/users/andrewsykim/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewsykim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewsykim/subscriptions","organizations_url":"https://api.github.com/users/andrewsykim/orgs","repos_url":"https://api.github.com/users/andrewsykim/repos","events_url":"https://api.github.com/users/andrewsykim/events{/privacy}","received_events_url":"https://api.github.com/users/andrewsykim/received_events","type":"User","site_admin":false},"body":"With the new timeout, does it still make sense to lower this value?","created_at":"2018-08-29T15:02:27Z","updated_at":"2018-08-29T15:02:27Z","html_url":"https://github.com/cloudnativelabs/kube-router/pull/522#discussion_r213714993","pull_request_url":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls/522","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls/comments/213714993"},"html":{"href":"https://github.com/cloudnativelabs/kube-router/pull/522#discussion_r213714993"},"pull_request":{"href":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls/522"}}},"pull_request":{"url":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls/522","id":211711210,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzExMjEw","html_url":"https://github.com/cloudnativelabs/kube-router/pull/522","diff_url":"https://github.com/cloudnativelabs/kube-router/pull/522.diff","patch_url":"https://github.com/cloudnativelabs/kube-router/pull/522.patch","issue_url":"https://api.github.com/repos/cloudnativelabs/kube-router/issues/522","number":522,"state":"open","locked":false,"title":"Healthcheck & Dashboard update","user":{"login":"roffe","id":5434736,"node_id":"MDQ6VXNlcjU0MzQ3MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/5434736?v=4","gravatar_id":"","url":"https://api.github.com/users/roffe","html_url":"https://github.com/roffe","followers_url":"https://api.github.com/users/roffe/followers","following_url":"https://api.github.com/users/roffe/following{/other_user}","gists_url":"https://api.github.com/users/roffe/gists{/gist_id}","starred_url":"https://api.github.com/users/roffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roffe/subscriptions","organizations_url":"https://api.github.com/users/roffe/orgs","repos_url":"https://api.github.com/users/roffe/repos","events_url":"https://api.github.com/users/roffe/events{/privacy}","received_events_url":"https://api.github.com/users/roffe/received_events","type":"User","site_admin":false},"body":"* added configurable static timeout for the controllers, defaults to 30 sec\r\n* added metric `controller_errors` with label \"controller\"\r\n* changed metric `controller_bgp_advertisements_received` to `controller_bgp_advertisements` with label \"type\" `sent` or `received`","created_at":"2018-08-29T10:56:21Z","updated_at":"2018-08-29T15:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61071fd3c580f065677c3ef2efd5563b8c03ce59","assignee":null,"assignees":[],"requested_reviewers":[{"login":"murali-reddy","id":2202956,"node_id":"MDQ6VXNlcjIyMDI5NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2202956?v=4","gravatar_id":"","url":"https://api.github.com/users/murali-reddy","html_url":"https://github.com/murali-reddy","followers_url":"https://api.github.com/users/murali-reddy/followers","following_url":"https://api.github.com/users/murali-reddy/following{/other_user}","gists_url":"https://api.github.com/users/murali-reddy/gists{/gist_id}","starred_url":"https://api.github.com/users/murali-reddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murali-reddy/subscriptions","organizations_url":"https://api.github.com/users/murali-reddy/orgs","repos_url":"https://api.github.com/users/murali-reddy/repos","events_url":"https://api.github.com/users/murali-reddy/events{/privacy}","received_events_url":"https://api.github.com/users/murali-reddy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls/522/commits","review_comments_url":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls/522/comments","review_comment_url":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudnativelabs/kube-router/issues/522/comments","statuses_url":"https://api.github.com/repos/cloudnativelabs/kube-router/statuses/65b8c4bcc960ccea1abb70f6dfdd545301d6fc4d","head":{"label":"roffe:health-pr","ref":"health-pr","sha":"65b8c4bcc960ccea1abb70f6dfdd545301d6fc4d","user":{"login":"roffe","id":5434736,"node_id":"MDQ6VXNlcjU0MzQ3MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/5434736?v=4","gravatar_id":"","url":"https://api.github.com/users/roffe","html_url":"https://github.com/roffe","followers_url":"https://api.github.com/users/roffe/followers","following_url":"https://api.github.com/users/roffe/following{/other_user}","gists_url":"https://api.github.com/users/roffe/gists{/gist_id}","starred_url":"https://api.github.com/users/roffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roffe/subscriptions","organizations_url":"https://api.github.com/users/roffe/orgs","repos_url":"https://api.github.com/users/roffe/repos","events_url":"https://api.github.com/users/roffe/events{/privacy}","received_events_url":"https://api.github.com/users/roffe/received_events","type":"User","site_admin":false},"repo":{"id":117429455,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc0Mjk0NTU=","name":"kube-router","full_name":"roffe/kube-router","owner":{"login":"roffe","id":5434736,"node_id":"MDQ6VXNlcjU0MzQ3MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/5434736?v=4","gravatar_id":"","url":"https://api.github.com/users/roffe","html_url":"https://github.com/roffe","followers_url":"https://api.github.com/users/roffe/followers","following_url":"https://api.github.com/users/roffe/following{/other_user}","gists_url":"https://api.github.com/users/roffe/gists{/gist_id}","starred_url":"https://api.github.com/users/roffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roffe/subscriptions","organizations_url":"https://api.github.com/users/roffe/orgs","repos_url":"https://api.github.com/users/roffe/repos","events_url":"https://api.github.com/users/roffe/events{/privacy}","received_events_url":"https://api.github.com/users/roffe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roffe/kube-router","description":"Kube-router, a turnkey solution for Kubernetes networking.","fork":true,"url":"https://api.github.com/repos/roffe/kube-router","forks_url":"https://api.github.com/repos/roffe/kube-router/forks","keys_url":"https://api.github.com/repos/roffe/kube-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roffe/kube-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roffe/kube-router/teams","hooks_url":"https://api.github.com/repos/roffe/kube-router/hooks","issue_events_url":"https://api.github.com/repos/roffe/kube-router/issues/events{/number}","events_url":"https://api.github.com/repos/roffe/kube-router/events","assignees_url":"https://api.github.com/repos/roffe/kube-router/assignees{/user}","branches_url":"https://api.github.com/repos/roffe/kube-router/branches{/branch}","tags_url":"https://api.github.com/repos/roffe/kube-router/tags","blobs_url":"https://api.github.com/repos/roffe/kube-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roffe/kube-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roffe/kube-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/roffe/kube-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roffe/kube-router/statuses/{sha}","languages_url":"https://api.github.com/repos/roffe/kube-router/languages","stargazers_url":"https://api.github.com/repos/roffe/kube-router/stargazers","contributors_url":"https://api.github.com/repos/roffe/kube-router/contributors","subscribers_url":"https://api.github.com/repos/roffe/kube-router/subscribers","subscription_url":"https://api.github.com/repos/roffe/kube-router/subscription","commits_url":"https://api.github.com/repos/roffe/kube-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/roffe/kube-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/roffe/kube-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/roffe/kube-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/roffe/kube-router/contents/{+path}","compare_url":"https://api.github.com/repos/roffe/kube-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roffe/kube-router/merges","archive_url":"https://api.github.com/repos/roffe/kube-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roffe/kube-router/downloads","issues_url":"https://api.github.com/repos/roffe/kube-router/issues{/number}","pulls_url":"https://api.github.com/repos/roffe/kube-router/pulls{/number}","milestones_url":"https://api.github.com/repos/roffe/kube-router/milestones{/number}","notifications_url":"https://api.github.com/repos/roffe/kube-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roffe/kube-router/labels{/name}","releases_url":"https://api.github.com/repos/roffe/kube-router/releases{/id}","deployments_url":"https://api.github.com/repos/roffe/kube-router/deployments","created_at":"2018-01-14T12:47:40Z","updated_at":"2018-08-28T20:44:53Z","pushed_at":"2018-08-29T11:07:27Z","git_url":"git://github.com/roffe/kube-router.git","ssh_url":"git@github.com:roffe/kube-router.git","clone_url":"https://github.com/roffe/kube-router.git","svn_url":"https://github.com/roffe/kube-router","homepage":"https://kube-router.io","size":51109,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudnativelabs:master","ref":"master","sha":"468f16b5d394eb6a82f59c3e50ca194a45d67642","user":{"login":"cloudnativelabs","id":25678764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njc4NzY0","avatar_url":"https://avatars1.githubusercontent.com/u/25678764?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudnativelabs","html_url":"https://github.com/cloudnativelabs","followers_url":"https://api.github.com/users/cloudnativelabs/followers","following_url":"https://api.github.com/users/cloudnativelabs/following{/other_user}","gists_url":"https://api.github.com/users/cloudnativelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudnativelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudnativelabs/subscriptions","organizations_url":"https://api.github.com/users/cloudnativelabs/orgs","repos_url":"https://api.github.com/users/cloudnativelabs/repos","events_url":"https://api.github.com/users/cloudnativelabs/events{/privacy}","received_events_url":"https://api.github.com/users/cloudnativelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":88471725,"node_id":"MDEwOlJlcG9zaXRvcnk4ODQ3MTcyNQ==","name":"kube-router","full_name":"cloudnativelabs/kube-router","owner":{"login":"cloudnativelabs","id":25678764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njc4NzY0","avatar_url":"https://avatars1.githubusercontent.com/u/25678764?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudnativelabs","html_url":"https://github.com/cloudnativelabs","followers_url":"https://api.github.com/users/cloudnativelabs/followers","following_url":"https://api.github.com/users/cloudnativelabs/following{/other_user}","gists_url":"https://api.github.com/users/cloudnativelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudnativelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudnativelabs/subscriptions","organizations_url":"https://api.github.com/users/cloudnativelabs/orgs","repos_url":"https://api.github.com/users/cloudnativelabs/repos","events_url":"https://api.github.com/users/cloudnativelabs/events{/privacy}","received_events_url":"https://api.github.com/users/cloudnativelabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudnativelabs/kube-router","description":"Kube-router, a turnkey solution for Kubernetes networking.","fork":false,"url":"https://api.github.com/repos/cloudnativelabs/kube-router","forks_url":"https://api.github.com/repos/cloudnativelabs/kube-router/forks","keys_url":"https://api.github.com/repos/cloudnativelabs/kube-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudnativelabs/kube-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudnativelabs/kube-router/teams","hooks_url":"https://api.github.com/repos/cloudnativelabs/kube-router/hooks","issue_events_url":"https://api.github.com/repos/cloudnativelabs/kube-router/issues/events{/number}","events_url":"https://api.github.com/repos/cloudnativelabs/kube-router/events","assignees_url":"https://api.github.com/repos/cloudnativelabs/kube-router/assignees{/user}","branches_url":"https://api.github.com/repos/cloudnativelabs/kube-router/branches{/branch}","tags_url":"https://api.github.com/repos/cloudnativelabs/kube-router/tags","blobs_url":"https://api.github.com/repos/cloudnativelabs/kube-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudnativelabs/kube-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudnativelabs/kube-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudnativelabs/kube-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudnativelabs/kube-router/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudnativelabs/kube-router/languages","stargazers_url":"https://api.github.com/repos/cloudnativelabs/kube-router/stargazers","contributors_url":"https://api.github.com/repos/cloudnativelabs/kube-router/contributors","subscribers_url":"https://api.github.com/repos/cloudnativelabs/kube-router/subscribers","subscription_url":"https://api.github.com/repos/cloudnativelabs/kube-router/subscription","commits_url":"https://api.github.com/repos/cloudnativelabs/kube-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudnativelabs/kube-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudnativelabs/kube-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudnativelabs/kube-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudnativelabs/kube-router/contents/{+path}","compare_url":"https://api.github.com/repos/cloudnativelabs/kube-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudnativelabs/kube-router/merges","archive_url":"https://api.github.com/repos/cloudnativelabs/kube-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudnativelabs/kube-router/downloads","issues_url":"https://api.github.com/repos/cloudnativelabs/kube-router/issues{/number}","pulls_url":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudnativelabs/kube-router/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudnativelabs/kube-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudnativelabs/kube-router/labels{/name}","releases_url":"https://api.github.com/repos/cloudnativelabs/kube-router/releases{/id}","deployments_url":"https://api.github.com/repos/cloudnativelabs/kube-router/deployments","created_at":"2017-04-17T04:58:06Z","updated_at":"2018-08-29T13:51:54Z","pushed_at":"2018-08-29T11:07:28Z","git_url":"git://github.com/cloudnativelabs/kube-router.git","ssh_url":"git@github.com:cloudnativelabs/kube-router.git","clone_url":"https://github.com/cloudnativelabs/kube-router.git","svn_url":"https://github.com/cloudnativelabs/kube-router","homepage":"https://kube-router.io","size":50010,"stargazers_count":827,"watchers_count":827,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"archived":false,"open_issues_count":131,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":152,"open_issues":131,"watchers":827,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls/522"},"html":{"href":"https://github.com/cloudnativelabs/kube-router/pull/522"},"issue":{"href":"https://api.github.com/repos/cloudnativelabs/kube-router/issues/522"},"comments":{"href":"https://api.github.com/repos/cloudnativelabs/kube-router/issues/522/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls/522/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudnativelabs/kube-router/pulls/522/commits"},"statuses":{"href":"https://api.github.com/repos/cloudnativelabs/kube-router/statuses/65b8c4bcc960ccea1abb70f6dfdd545301d6fc4d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"andrewsykim"}}