{"action":"closed","number":13003,"pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/13003","id":237641354,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjQxMzU0","html_url":"https://github.com/nextcloud/server/pull/13003","diff_url":"https://github.com/nextcloud/server/pull/13003.diff","patch_url":"https://github.com/nextcloud/server/pull/13003.patch","issue_url":"https://api.github.com/repos/nextcloud/server/issues/13003","number":13003,"state":"closed","locked":false,"title":"Use default cursor for disabled primary buttons","user":{"login":"danxuliu","id":26858233,"node_id":"MDQ6VXNlcjI2ODU4MjMz","avatar_url":"https://avatars1.githubusercontent.com/u/26858233?v=4","gravatar_id":"","url":"https://api.github.com/users/danxuliu","html_url":"https://github.com/danxuliu","followers_url":"https://api.github.com/users/danxuliu/followers","following_url":"https://api.github.com/users/danxuliu/following{/other_user}","gists_url":"https://api.github.com/users/danxuliu/gists{/gist_id}","starred_url":"https://api.github.com/users/danxuliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danxuliu/subscriptions","organizations_url":"https://api.github.com/users/danxuliu/orgs","repos_url":"https://api.github.com/users/danxuliu/repos","events_url":"https://api.github.com/users/danxuliu/events{/privacy}","received_events_url":"https://api.github.com/users/danxuliu/received_events","type":"User","site_admin":false},"body":"[Disabled buttons use the default cursor](https://github.com/nextcloud/server/blob/f80a0234319ce1206892259b65e63f5277b2ecb9/core/css/inputs.scss#L75), but as [the cursor property for primary buttons](https://github.com/nextcloud/server/blob/f80a0234319ce1206892259b65e63f5277b2ecb9/core/css/inputs.scss#L90) is set after the cursor property for disabled buttons the latter is always overridden, even if the primary button is also\r\ndisabled. Due to this it is necessary to explicitly set the default cursor for disabled primary buttons.\r\n\r\n@nextcloud/designers \r\n\r\nBefore:\r\n![button-disabled-cursor-before](https://user-images.githubusercontent.com/26858233/49797090-b6b64b80-fd3e-11e8-8ef3-c9c3509fa235.png)\r\n\r\nAfter:\r\n![button-disabled-cursor-after](https://user-images.githubusercontent.com/26858233/49797091-b918a580-fd3e-11e8-8328-bceb1cc67209.png)\r\n\r\nI would backport this at least to _stable15_.\r\n","created_at":"2018-12-11T11:20:36Z","updated_at":"2018-12-11T13:48:03Z","closed_at":"2018-12-11T13:48:03Z","merged_at":"2018-12-11T13:48:03Z","merge_commit_sha":"4830fb7fb9dc355566ede942785d00a60323c68a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"juliushaertl","id":3404133,"node_id":"MDQ6VXNlcjM0MDQxMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3404133?v=4","gravatar_id":"","url":"https://api.github.com/users/juliushaertl","html_url":"https://github.com/juliushaertl","followers_url":"https://api.github.com/users/juliushaertl/followers","following_url":"https://api.github.com/users/juliushaertl/following{/other_user}","gists_url":"https://api.github.com/users/juliushaertl/gists{/gist_id}","starred_url":"https://api.github.com/users/juliushaertl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliushaertl/subscriptions","organizations_url":"https://api.github.com/users/juliushaertl/orgs","repos_url":"https://api.github.com/users/juliushaertl/repos","events_url":"https://api.github.com/users/juliushaertl/events{/privacy}","received_events_url":"https://api.github.com/users/juliushaertl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":389003733,"node_id":"MDU6TGFiZWwzODkwMDM3MzM=","url":"https://api.github.com/repos/nextcloud/server/labels/3.%20to%20review","name":"3. to review","color":"0052cc","default":false},{"id":392823137,"node_id":"MDU6TGFiZWwzOTI4MjMxMzc=","url":"https://api.github.com/repos/nextcloud/server/labels/backport-request","name":"backport-request","color":"006b75","default":false},{"id":386379231,"node_id":"MDU6TGFiZWwzODYzNzkyMzE=","url":"https://api.github.com/repos/nextcloud/server/labels/bug","name":"bug","color":"ee0701","default":true},{"id":388630313,"node_id":"MDU6TGFiZWwzODg2MzAzMTM=","url":"https://api.github.com/repos/nextcloud/server/labels/design","name":"design","color":"cc317c","default":false}],"milestone":{"url":"https://api.github.com/repos/nextcloud/server/milestones/59","html_url":"https://github.com/nextcloud/server/milestone/59","labels_url":"https://api.github.com/repos/nextcloud/server/milestones/59/labels","id":3749267,"node_id":"MDk6TWlsZXN0b25lMzc0OTI2Nw==","number":59,"title":"Nextcloud 16","description":null,"creator":{"login":"jancborchardt","id":925062,"node_id":"MDQ6VXNlcjkyNTA2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/925062?v=4","gravatar_id":"","url":"https://api.github.com/users/jancborchardt","html_url":"https://github.com/jancborchardt","followers_url":"https://api.github.com/users/jancborchardt/followers","following_url":"https://api.github.com/users/jancborchardt/following{/other_user}","gists_url":"https://api.github.com/users/jancborchardt/gists{/gist_id}","starred_url":"https://api.github.com/users/jancborchardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancborchardt/subscriptions","organizations_url":"https://api.github.com/users/jancborchardt/orgs","repos_url":"https://api.github.com/users/jancborchardt/repos","events_url":"https://api.github.com/users/jancborchardt/events{/privacy}","received_events_url":"https://api.github.com/users/jancborchardt/received_events","type":"User","site_admin":false},"open_issues":121,"closed_issues":129,"state":"open","created_at":"2018-10-18T12:54:37Z","updated_at":"2018-12-11T13:48:03Z","due_on":"2019-04-11T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/nextcloud/server/pulls/13003/commits","review_comments_url":"https://api.github.com/repos/nextcloud/server/pulls/13003/comments","review_comment_url":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/13003/comments","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/7dad6d8f5bde5491d50311d5d85e79ca78a0ff36","head":{"label":"nextcloud:use-default-cursor-for-disabled-primary-buttons","ref":"use-default-cursor-for-disabled-primary-buttons","sha":"7dad6d8f5bde5491d50311d5d85e79ca78a0ff36","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":60243197,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI0MzE5Nw==","name":"server","full_name":"nextcloud/server","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":false,"url":"https://api.github.com/repos/nextcloud/server","forks_url":"https://api.github.com/repos/nextcloud/server/forks","keys_url":"https://api.github.com/repos/nextcloud/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/server/teams","hooks_url":"https://api.github.com/repos/nextcloud/server/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/server/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/server/events","assignees_url":"https://api.github.com/repos/nextcloud/server/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/server/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/server/tags","blobs_url":"https://api.github.com/repos/nextcloud/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/server/languages","stargazers_url":"https://api.github.com/repos/nextcloud/server/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/server/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/server/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/server/subscription","commits_url":"https://api.github.com/repos/nextcloud/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/server/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/server/merges","archive_url":"https://api.github.com/repos/nextcloud/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/server/downloads","issues_url":"https://api.github.com/repos/nextcloud/server/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/server/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/server/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/server/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/server/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/server/deployments","created_at":"2016-06-02T07:44:14Z","updated_at":"2018-12-11T13:23:56Z","pushed_at":"2018-12-11T13:48:03Z","git_url":"git://github.com/nextcloud/server.git","ssh_url":"git@github.com:nextcloud/server.git","clone_url":"https://github.com/nextcloud/server.git","svn_url":"https://github.com/nextcloud/server","homepage":"https://nextcloud.com","size":345088,"stargazers_count":5988,"watchers_count":5988,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1054,"mirror_url":null,"archived":false,"open_issues_count":1660,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1054,"open_issues":1660,"watchers":5988,"default_branch":"master"}},"base":{"label":"nextcloud:master","ref":"master","sha":"004192091704d7bd1741738ba15ee91d88656806","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":60243197,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI0MzE5Nw==","name":"server","full_name":"nextcloud/server","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":false,"url":"https://api.github.com/repos/nextcloud/server","forks_url":"https://api.github.com/repos/nextcloud/server/forks","keys_url":"https://api.github.com/repos/nextcloud/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/server/teams","hooks_url":"https://api.github.com/repos/nextcloud/server/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/server/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/server/events","assignees_url":"https://api.github.com/repos/nextcloud/server/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/server/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/server/tags","blobs_url":"https://api.github.com/repos/nextcloud/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/server/languages","stargazers_url":"https://api.github.com/repos/nextcloud/server/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/server/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/server/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/server/subscription","commits_url":"https://api.github.com/repos/nextcloud/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/server/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/server/merges","archive_url":"https://api.github.com/repos/nextcloud/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/server/downloads","issues_url":"https://api.github.com/repos/nextcloud/server/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/server/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/server/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/server/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/server/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/server/deployments","created_at":"2016-06-02T07:44:14Z","updated_at":"2018-12-11T13:23:56Z","pushed_at":"2018-12-11T13:48:03Z","git_url":"git://github.com/nextcloud/server.git","ssh_url":"git@github.com:nextcloud/server.git","clone_url":"https://github.com/nextcloud/server.git","svn_url":"https://github.com/nextcloud/server","homepage":"https://nextcloud.com","size":345088,"stargazers_count":5988,"watchers_count":5988,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1054,"mirror_url":null,"archived":false,"open_issues_count":1660,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1054,"open_issues":1660,"watchers":5988,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextcloud/server/pulls/13003"},"html":{"href":"https://github.com/nextcloud/server/pull/13003"},"issue":{"href":"https://api.github.com/repos/nextcloud/server/issues/13003"},"comments":{"href":"https://api.github.com/repos/nextcloud/server/issues/13003/comments"},"review_comments":{"href":"https://api.github.com/repos/nextcloud/server/pulls/13003/comments"},"review_comment":{"href":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextcloud/server/pulls/13003/commits"},"statuses":{"href":"https://api.github.com/repos/nextcloud/server/statuses/7dad6d8f5bde5491d50311d5d85e79ca78a0ff36"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jancborchardt","id":925062,"node_id":"MDQ6VXNlcjkyNTA2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/925062?v=4","gravatar_id":"","url":"https://api.github.com/users/jancborchardt","html_url":"https://github.com/jancborchardt","followers_url":"https://api.github.com/users/jancborchardt/followers","following_url":"https://api.github.com/users/jancborchardt/following{/other_user}","gists_url":"https://api.github.com/users/jancborchardt/gists{/gist_id}","starred_url":"https://api.github.com/users/jancborchardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancborchardt/subscriptions","organizations_url":"https://api.github.com/users/jancborchardt/orgs","repos_url":"https://api.github.com/users/jancborchardt/repos","events_url":"https://api.github.com/users/jancborchardt/events{/privacy}","received_events_url":"https://api.github.com/users/jancborchardt/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"jancborchardt"}}