{"action":"created","comment":{"url":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/comments/237502465","pull_request_review_id":179814978,"id":237502465,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzUwMjQ2NQ==","diff_hunk":"@@ -59,6 +60,51 @@ MRAcquisitionData::write(const char* filename)\n \t}\n }\n \n+void\n+MRAcquisitionData::read( const std::string& filename_ismrmrd_with_ext )\n+{\n+\t\n+\tbool const verbose = true;\n+\n+\tif( verbose )\n+\t\tstd::cout<< \"Started reading acquisitions from \" << filename_ismrmrd_with_ext << std::endl;\n+\ttry\n+\t{\n+\n+\t\tISMRMRD::Dataset d(filename_ismrmrd_with_ext.c_str(),\"dataset\", false);\n+\n+\t\tstd::string xml;\n+\t\td.readHeader(xml);\n+\t\tthis->acqs_info_ = xml;","path":"src/xGadgetron/cGadgetron/gadgetron_data_containers.cpp","position":27,"original_position":27,"commit_id":"2698e6e091b36615ab727ada72c0e8d11062888c","original_commit_id":"2698e6e091b36615ab727ada72c0e8d11062888c","user":{"login":"johannesmayer","id":10499392,"node_id":"MDQ6VXNlcjEwNDk5Mzky","avatar_url":"https://avatars0.githubusercontent.com/u/10499392?v=4","gravatar_id":"","url":"https://api.github.com/users/johannesmayer","html_url":"https://github.com/johannesmayer","followers_url":"https://api.github.com/users/johannesmayer/followers","following_url":"https://api.github.com/users/johannesmayer/following{/other_user}","gists_url":"https://api.github.com/users/johannesmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/johannesmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannesmayer/subscriptions","organizations_url":"https://api.github.com/users/johannesmayer/orgs","repos_url":"https://api.github.com/users/johannesmayer/repos","events_url":"https://api.github.com/users/johannesmayer/events{/privacy}","received_events_url":"https://api.github.com/users/johannesmayer/received_events","type":"User","site_admin":false},"body":"ah darn you are right... ( which means you were wrong with \"Ok, you know best!\" though xD ). I'll fix it.","created_at":"2018-11-29T14:16:14Z","updated_at":"2018-11-29T14:16:15Z","html_url":"https://github.com/CCPPETMR/SIRF/pull/236#discussion_r237502465","pull_request_url":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/236","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/comments/237502465"},"html":{"href":"https://github.com/CCPPETMR/SIRF/pull/236#discussion_r237502465"},"pull_request":{"href":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/236"}},"in_reply_to_id":237492580},"pull_request":{"url":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/236","id":230083625,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDgzNjI1","html_url":"https://github.com/CCPPETMR/SIRF/pull/236","diff_url":"https://github.com/CCPPETMR/SIRF/pull/236.diff","patch_url":"https://github.com/CCPPETMR/SIRF/pull/236.patch","issue_url":"https://api.github.com/repos/CCPPETMR/SIRF/issues/236","number":236,"state":"open","locked":false,"title":"Aquisition reader","user":{"login":"johannesmayer","id":10499392,"node_id":"MDQ6VXNlcjEwNDk5Mzky","avatar_url":"https://avatars0.githubusercontent.com/u/10499392?v=4","gravatar_id":"","url":"https://api.github.com/users/johannesmayer","html_url":"https://github.com/johannesmayer","followers_url":"https://api.github.com/users/johannesmayer/followers","following_url":"https://api.github.com/users/johannesmayer/following{/other_user}","gists_url":"https://api.github.com/users/johannesmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/johannesmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannesmayer/subscriptions","organizations_url":"https://api.github.com/users/johannesmayer/orgs","repos_url":"https://api.github.com/users/johannesmayer/repos","events_url":"https://api.github.com/users/johannesmayer/events{/privacy}","received_events_url":"https://api.github.com/users/johannesmayer/received_events","type":"User","site_admin":false},"body":"Added `MRAcquisitionsData::read( const string& )` functionality.\r\nThis enables to fill acquisition data containers with `ISMRMRD::Acquisition` from an `ISMRMRD.h5` file.\r\n\r\nIn case the `ISMRMRD::Dataset` constructor throws an `std::runtime_error` the reader catches it, displays the message and throws it again.\r\n\r\nTo avoid reading noise samples and other calibration data, the `TO_BE_IGNORED` macro previously defined is now employed to exclude the potentially incompatible input. The macro was extended to allow acquisitions flagged with `ISMRMRD::ISMRMRD_ACQ_IS_REVERSE`, i.e. ones with a reversed data readout.\r\n\r\nThe beginning and ending of file reading is displayed and the progress is displayed in steps of 10% to avoid the impression the program being stuck if the file is large. The scopes where `verbose == true` can be readily deleted without impairing the functionality if this console output is deemed unnecessary.\r\n","created_at":"2018-11-12T10:24:10Z","updated_at":"2018-11-29T14:16:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fabf885de7eeebc05a4f4bb284d378b270a61b8b","assignee":{"login":"evgueni-ovtchinnikov","id":15048532,"node_id":"MDQ6VXNlcjE1MDQ4NTMy","avatar_url":"https://avatars1.githubusercontent.com/u/15048532?v=4","gravatar_id":"","url":"https://api.github.com/users/evgueni-ovtchinnikov","html_url":"https://github.com/evgueni-ovtchinnikov","followers_url":"https://api.github.com/users/evgueni-ovtchinnikov/followers","following_url":"https://api.github.com/users/evgueni-ovtchinnikov/following{/other_user}","gists_url":"https://api.github.com/users/evgueni-ovtchinnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgueni-ovtchinnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgueni-ovtchinnikov/subscriptions","organizations_url":"https://api.github.com/users/evgueni-ovtchinnikov/orgs","repos_url":"https://api.github.com/users/evgueni-ovtchinnikov/repos","events_url":"https://api.github.com/users/evgueni-ovtchinnikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgueni-ovtchinnikov/received_events","type":"User","site_admin":false},"assignees":[{"login":"evgueni-ovtchinnikov","id":15048532,"node_id":"MDQ6VXNlcjE1MDQ4NTMy","avatar_url":"https://avatars1.githubusercontent.com/u/15048532?v=4","gravatar_id":"","url":"https://api.github.com/users/evgueni-ovtchinnikov","html_url":"https://github.com/evgueni-ovtchinnikov","followers_url":"https://api.github.com/users/evgueni-ovtchinnikov/followers","following_url":"https://api.github.com/users/evgueni-ovtchinnikov/following{/other_user}","gists_url":"https://api.github.com/users/evgueni-ovtchinnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgueni-ovtchinnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgueni-ovtchinnikov/subscriptions","organizations_url":"https://api.github.com/users/evgueni-ovtchinnikov/orgs","repos_url":"https://api.github.com/users/evgueni-ovtchinnikov/repos","events_url":"https://api.github.com/users/evgueni-ovtchinnikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgueni-ovtchinnikov/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/236/commits","review_comments_url":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/236/comments","review_comment_url":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CCPPETMR/SIRF/issues/236/comments","statuses_url":"https://api.github.com/repos/CCPPETMR/SIRF/statuses/2698e6e091b36615ab727ada72c0e8d11062888c","head":{"label":"johannesmayer:aquisition_reader","ref":"aquisition_reader","sha":"2698e6e091b36615ab727ada72c0e8d11062888c","user":{"login":"johannesmayer","id":10499392,"node_id":"MDQ6VXNlcjEwNDk5Mzky","avatar_url":"https://avatars0.githubusercontent.com/u/10499392?v=4","gravatar_id":"","url":"https://api.github.com/users/johannesmayer","html_url":"https://github.com/johannesmayer","followers_url":"https://api.github.com/users/johannesmayer/followers","following_url":"https://api.github.com/users/johannesmayer/following{/other_user}","gists_url":"https://api.github.com/users/johannesmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/johannesmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannesmayer/subscriptions","organizations_url":"https://api.github.com/users/johannesmayer/orgs","repos_url":"https://api.github.com/users/johannesmayer/repos","events_url":"https://api.github.com/users/johannesmayer/events{/privacy}","received_events_url":"https://api.github.com/users/johannesmayer/received_events","type":"User","site_admin":false},"repo":{"id":126021990,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYwMjE5OTA=","name":"SIRF","full_name":"johannesmayer/SIRF","private":false,"owner":{"login":"johannesmayer","id":10499392,"node_id":"MDQ6VXNlcjEwNDk5Mzky","avatar_url":"https://avatars0.githubusercontent.com/u/10499392?v=4","gravatar_id":"","url":"https://api.github.com/users/johannesmayer","html_url":"https://github.com/johannesmayer","followers_url":"https://api.github.com/users/johannesmayer/followers","following_url":"https://api.github.com/users/johannesmayer/following{/other_user}","gists_url":"https://api.github.com/users/johannesmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/johannesmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannesmayer/subscriptions","organizations_url":"https://api.github.com/users/johannesmayer/orgs","repos_url":"https://api.github.com/users/johannesmayer/repos","events_url":"https://api.github.com/users/johannesmayer/events{/privacy}","received_events_url":"https://api.github.com/users/johannesmayer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/johannesmayer/SIRF","description":"Main repository for the CCPPETMR software","fork":true,"url":"https://api.github.com/repos/johannesmayer/SIRF","forks_url":"https://api.github.com/repos/johannesmayer/SIRF/forks","keys_url":"https://api.github.com/repos/johannesmayer/SIRF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johannesmayer/SIRF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johannesmayer/SIRF/teams","hooks_url":"https://api.github.com/repos/johannesmayer/SIRF/hooks","issue_events_url":"https://api.github.com/repos/johannesmayer/SIRF/issues/events{/number}","events_url":"https://api.github.com/repos/johannesmayer/SIRF/events","assignees_url":"https://api.github.com/repos/johannesmayer/SIRF/assignees{/user}","branches_url":"https://api.github.com/repos/johannesmayer/SIRF/branches{/branch}","tags_url":"https://api.github.com/repos/johannesmayer/SIRF/tags","blobs_url":"https://api.github.com/repos/johannesmayer/SIRF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johannesmayer/SIRF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johannesmayer/SIRF/git/refs{/sha}","trees_url":"https://api.github.com/repos/johannesmayer/SIRF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johannesmayer/SIRF/statuses/{sha}","languages_url":"https://api.github.com/repos/johannesmayer/SIRF/languages","stargazers_url":"https://api.github.com/repos/johannesmayer/SIRF/stargazers","contributors_url":"https://api.github.com/repos/johannesmayer/SIRF/contributors","subscribers_url":"https://api.github.com/repos/johannesmayer/SIRF/subscribers","subscription_url":"https://api.github.com/repos/johannesmayer/SIRF/subscription","commits_url":"https://api.github.com/repos/johannesmayer/SIRF/commits{/sha}","git_commits_url":"https://api.github.com/repos/johannesmayer/SIRF/git/commits{/sha}","comments_url":"https://api.github.com/repos/johannesmayer/SIRF/comments{/number}","issue_comment_url":"https://api.github.com/repos/johannesmayer/SIRF/issues/comments{/number}","contents_url":"https://api.github.com/repos/johannesmayer/SIRF/contents/{+path}","compare_url":"https://api.github.com/repos/johannesmayer/SIRF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johannesmayer/SIRF/merges","archive_url":"https://api.github.com/repos/johannesmayer/SIRF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johannesmayer/SIRF/downloads","issues_url":"https://api.github.com/repos/johannesmayer/SIRF/issues{/number}","pulls_url":"https://api.github.com/repos/johannesmayer/SIRF/pulls{/number}","milestones_url":"https://api.github.com/repos/johannesmayer/SIRF/milestones{/number}","notifications_url":"https://api.github.com/repos/johannesmayer/SIRF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johannesmayer/SIRF/labels{/name}","releases_url":"https://api.github.com/repos/johannesmayer/SIRF/releases{/id}","deployments_url":"https://api.github.com/repos/johannesmayer/SIRF/deployments","created_at":"2018-03-20T13:29:42Z","updated_at":"2018-08-16T13:18:16Z","pushed_at":"2018-11-28T15:33:54Z","git_url":"git://github.com/johannesmayer/SIRF.git","ssh_url":"git@github.com:johannesmayer/SIRF.git","clone_url":"https://github.com/johannesmayer/SIRF.git","svn_url":"https://github.com/johannesmayer/SIRF","homepage":"http://www.ccppetmr.ac.uk","size":12105,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":24,"watchers":0,"default_branch":"master"}},"base":{"label":"CCPPETMR:master","ref":"master","sha":"f2792f685bcc6465d2a5fac1e5aa72196fd4d327","user":{"login":"CCPPETMR","id":16674841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Njc0ODQx","avatar_url":"https://avatars1.githubusercontent.com/u/16674841?v=4","gravatar_id":"","url":"https://api.github.com/users/CCPPETMR","html_url":"https://github.com/CCPPETMR","followers_url":"https://api.github.com/users/CCPPETMR/followers","following_url":"https://api.github.com/users/CCPPETMR/following{/other_user}","gists_url":"https://api.github.com/users/CCPPETMR/gists{/gist_id}","starred_url":"https://api.github.com/users/CCPPETMR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCPPETMR/subscriptions","organizations_url":"https://api.github.com/users/CCPPETMR/orgs","repos_url":"https://api.github.com/users/CCPPETMR/repos","events_url":"https://api.github.com/users/CCPPETMR/events{/privacy}","received_events_url":"https://api.github.com/users/CCPPETMR/received_events","type":"Organization","site_admin":false},"repo":{"id":74830009,"node_id":"MDEwOlJlcG9zaXRvcnk3NDgzMDAwOQ==","name":"SIRF","full_name":"CCPPETMR/SIRF","private":false,"owner":{"login":"CCPPETMR","id":16674841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Njc0ODQx","avatar_url":"https://avatars1.githubusercontent.com/u/16674841?v=4","gravatar_id":"","url":"https://api.github.com/users/CCPPETMR","html_url":"https://github.com/CCPPETMR","followers_url":"https://api.github.com/users/CCPPETMR/followers","following_url":"https://api.github.com/users/CCPPETMR/following{/other_user}","gists_url":"https://api.github.com/users/CCPPETMR/gists{/gist_id}","starred_url":"https://api.github.com/users/CCPPETMR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCPPETMR/subscriptions","organizations_url":"https://api.github.com/users/CCPPETMR/orgs","repos_url":"https://api.github.com/users/CCPPETMR/repos","events_url":"https://api.github.com/users/CCPPETMR/events{/privacy}","received_events_url":"https://api.github.com/users/CCPPETMR/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CCPPETMR/SIRF","description":"Main repository for the CCPPETMR software","fork":false,"url":"https://api.github.com/repos/CCPPETMR/SIRF","forks_url":"https://api.github.com/repos/CCPPETMR/SIRF/forks","keys_url":"https://api.github.com/repos/CCPPETMR/SIRF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CCPPETMR/SIRF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CCPPETMR/SIRF/teams","hooks_url":"https://api.github.com/repos/CCPPETMR/SIRF/hooks","issue_events_url":"https://api.github.com/repos/CCPPETMR/SIRF/issues/events{/number}","events_url":"https://api.github.com/repos/CCPPETMR/SIRF/events","assignees_url":"https://api.github.com/repos/CCPPETMR/SIRF/assignees{/user}","branches_url":"https://api.github.com/repos/CCPPETMR/SIRF/branches{/branch}","tags_url":"https://api.github.com/repos/CCPPETMR/SIRF/tags","blobs_url":"https://api.github.com/repos/CCPPETMR/SIRF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CCPPETMR/SIRF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CCPPETMR/SIRF/git/refs{/sha}","trees_url":"https://api.github.com/repos/CCPPETMR/SIRF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CCPPETMR/SIRF/statuses/{sha}","languages_url":"https://api.github.com/repos/CCPPETMR/SIRF/languages","stargazers_url":"https://api.github.com/repos/CCPPETMR/SIRF/stargazers","contributors_url":"https://api.github.com/repos/CCPPETMR/SIRF/contributors","subscribers_url":"https://api.github.com/repos/CCPPETMR/SIRF/subscribers","subscription_url":"https://api.github.com/repos/CCPPETMR/SIRF/subscription","commits_url":"https://api.github.com/repos/CCPPETMR/SIRF/commits{/sha}","git_commits_url":"https://api.github.com/repos/CCPPETMR/SIRF/git/commits{/sha}","comments_url":"https://api.github.com/repos/CCPPETMR/SIRF/comments{/number}","issue_comment_url":"https://api.github.com/repos/CCPPETMR/SIRF/issues/comments{/number}","contents_url":"https://api.github.com/repos/CCPPETMR/SIRF/contents/{+path}","compare_url":"https://api.github.com/repos/CCPPETMR/SIRF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CCPPETMR/SIRF/merges","archive_url":"https://api.github.com/repos/CCPPETMR/SIRF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CCPPETMR/SIRF/downloads","issues_url":"https://api.github.com/repos/CCPPETMR/SIRF/issues{/number}","pulls_url":"https://api.github.com/repos/CCPPETMR/SIRF/pulls{/number}","milestones_url":"https://api.github.com/repos/CCPPETMR/SIRF/milestones{/number}","notifications_url":"https://api.github.com/repos/CCPPETMR/SIRF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CCPPETMR/SIRF/labels{/name}","releases_url":"https://api.github.com/repos/CCPPETMR/SIRF/releases{/id}","deployments_url":"https://api.github.com/repos/CCPPETMR/SIRF/deployments","created_at":"2016-11-26T14:19:12Z","updated_at":"2018-11-02T21:29:27Z","pushed_at":"2018-11-29T13:37:27Z","git_url":"git://github.com/CCPPETMR/SIRF.git","ssh_url":"git@github.com:CCPPETMR/SIRF.git","clone_url":"https://github.com/CCPPETMR/SIRF.git","svn_url":"https://github.com/CCPPETMR/SIRF","homepage":"http://www.ccppetmr.ac.uk","size":3897,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":58,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/236"},"html":{"href":"https://github.com/CCPPETMR/SIRF/pull/236"},"issue":{"href":"https://api.github.com/repos/CCPPETMR/SIRF/issues/236"},"comments":{"href":"https://api.github.com/repos/CCPPETMR/SIRF/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/CCPPETMR/SIRF/statuses/2698e6e091b36615ab727ada72c0e8d11062888c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"johannesmayer"}}