{"action":"created","comment":{"url":"https://api.github.com/repos/slaclab/pydm/pulls/comments/191844561","pull_request_review_id":124498359,"id":191844561,"diff_hunk":"@@ -240,7 +245,7 @@ def alarm_severity_changed(self, new_alarm_severity):\n         \"\"\"\n         PyDMWritableWidget.alarm_severity_changed(self, new_alarm_severity)\n         if hasattr(self, \"value_label\"):\n-            if self._channels is not None:\n+            if self._channel is not None:","path":"pydm/widgets/slider.py","position":59,"original_position":59,"commit_id":"b65488a5b81e91afd478bd07ebc238092e861c13","original_commit_id":"b65488a5b81e91afd478bd07ebc238092e861c13","user":{"login":"hhslepicka","id":8185425,"avatar_url":"https://avatars0.githubusercontent.com/u/8185425?v=4","gravatar_id":"","url":"https://api.github.com/users/hhslepicka","html_url":"https://github.com/hhslepicka","followers_url":"https://api.github.com/users/hhslepicka/followers","following_url":"https://api.github.com/users/hhslepicka/following{/other_user}","gists_url":"https://api.github.com/users/hhslepicka/gists{/gist_id}","starred_url":"https://api.github.com/users/hhslepicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhslepicka/subscriptions","organizations_url":"https://api.github.com/users/hhslepicka/orgs","repos_url":"https://api.github.com/users/hhslepicka/repos","events_url":"https://api.github.com/users/hhslepicka/events{/privacy}","received_events_url":"https://api.github.com/users/hhslepicka/received_events","type":"User","site_admin":false},"body":"Please add a test for an empty string also.","created_at":"2018-05-30T16:57:25Z","updated_at":"2018-05-30T16:58:45Z","html_url":"https://github.com/slaclab/pydm/pull/327#discussion_r191844561","pull_request_url":"https://api.github.com/repos/slaclab/pydm/pulls/327","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/slaclab/pydm/pulls/comments/191844561"},"html":{"href":"https://github.com/slaclab/pydm/pull/327#discussion_r191844561"},"pull_request":{"href":"https://api.github.com/repos/slaclab/pydm/pulls/327"}}},"pull_request":{"url":"https://api.github.com/repos/slaclab/pydm/pulls/327","id":191346100,"html_url":"https://github.com/slaclab/pydm/pull/327","diff_url":"https://github.com/slaclab/pydm/pull/327.diff","patch_url":"https://github.com/slaclab/pydm/pull/327.patch","issue_url":"https://api.github.com/repos/slaclab/pydm/issues/327","number":327,"state":"open","locked":false,"title":"TST: Add tests for PyDMSlider","user":{"login":"hmbui","id":36712473,"avatar_url":"https://avatars3.githubusercontent.com/u/36712473?v=4","gravatar_id":"","url":"https://api.github.com/users/hmbui","html_url":"https://github.com/hmbui","followers_url":"https://api.github.com/users/hmbui/followers","following_url":"https://api.github.com/users/hmbui/following{/other_user}","gists_url":"https://api.github.com/users/hmbui/gists{/gist_id}","starred_url":"https://api.github.com/users/hmbui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmbui/subscriptions","organizations_url":"https://api.github.com/users/hmbui/orgs","repos_url":"https://api.github.com/users/hmbui/repos","events_url":"https://api.github.com/users/hmbui/events{/privacy}","received_events_url":"https://api.github.com/users/hmbui/received_events","type":"User","site_admin":false},"body":"Also close #262 .","created_at":"2018-05-30T06:30:19Z","updated_at":"2018-05-30T16:58:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b36ef26f459dfaee970ae3de37bb439cf55dbcd2","assignee":{"login":"hhslepicka","id":8185425,"avatar_url":"https://avatars0.githubusercontent.com/u/8185425?v=4","gravatar_id":"","url":"https://api.github.com/users/hhslepicka","html_url":"https://github.com/hhslepicka","followers_url":"https://api.github.com/users/hhslepicka/followers","following_url":"https://api.github.com/users/hhslepicka/following{/other_user}","gists_url":"https://api.github.com/users/hhslepicka/gists{/gist_id}","starred_url":"https://api.github.com/users/hhslepicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhslepicka/subscriptions","organizations_url":"https://api.github.com/users/hhslepicka/orgs","repos_url":"https://api.github.com/users/hhslepicka/repos","events_url":"https://api.github.com/users/hhslepicka/events{/privacy}","received_events_url":"https://api.github.com/users/hhslepicka/received_events","type":"User","site_admin":false},"assignees":[{"login":"hhslepicka","id":8185425,"avatar_url":"https://avatars0.githubusercontent.com/u/8185425?v=4","gravatar_id":"","url":"https://api.github.com/users/hhslepicka","html_url":"https://github.com/hhslepicka","followers_url":"https://api.github.com/users/hhslepicka/followers","following_url":"https://api.github.com/users/hhslepicka/following{/other_user}","gists_url":"https://api.github.com/users/hhslepicka/gists{/gist_id}","starred_url":"https://api.github.com/users/hhslepicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhslepicka/subscriptions","organizations_url":"https://api.github.com/users/hhslepicka/orgs","repos_url":"https://api.github.com/users/hhslepicka/repos","events_url":"https://api.github.com/users/hhslepicka/events{/privacy}","received_events_url":"https://api.github.com/users/hhslepicka/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"teddyrendahl","id":25753048,"avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/slaclab/pydm/pulls/327/commits","review_comments_url":"https://api.github.com/repos/slaclab/pydm/pulls/327/comments","review_comment_url":"https://api.github.com/repos/slaclab/pydm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slaclab/pydm/issues/327/comments","statuses_url":"https://api.github.com/repos/slaclab/pydm/statuses/b65488a5b81e91afd478bd07ebc238092e861c13","head":{"label":"hmbui:test_slider","ref":"test_slider","sha":"b65488a5b81e91afd478bd07ebc238092e861c13","user":{"login":"hmbui","id":36712473,"avatar_url":"https://avatars3.githubusercontent.com/u/36712473?v=4","gravatar_id":"","url":"https://api.github.com/users/hmbui","html_url":"https://github.com/hmbui","followers_url":"https://api.github.com/users/hmbui/followers","following_url":"https://api.github.com/users/hmbui/following{/other_user}","gists_url":"https://api.github.com/users/hmbui/gists{/gist_id}","starred_url":"https://api.github.com/users/hmbui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmbui/subscriptions","organizations_url":"https://api.github.com/users/hmbui/orgs","repos_url":"https://api.github.com/users/hmbui/repos","events_url":"https://api.github.com/users/hmbui/events{/privacy}","received_events_url":"https://api.github.com/users/hmbui/received_events","type":"User","site_admin":false},"repo":{"id":122418877,"name":"pydm","full_name":"hmbui/pydm","owner":{"login":"hmbui","id":36712473,"avatar_url":"https://avatars3.githubusercontent.com/u/36712473?v=4","gravatar_id":"","url":"https://api.github.com/users/hmbui","html_url":"https://github.com/hmbui","followers_url":"https://api.github.com/users/hmbui/followers","following_url":"https://api.github.com/users/hmbui/following{/other_user}","gists_url":"https://api.github.com/users/hmbui/gists{/gist_id}","starred_url":"https://api.github.com/users/hmbui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmbui/subscriptions","organizations_url":"https://api.github.com/users/hmbui/orgs","repos_url":"https://api.github.com/users/hmbui/repos","events_url":"https://api.github.com/users/hmbui/events{/privacy}","received_events_url":"https://api.github.com/users/hmbui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hmbui/pydm","description":"Python Display Manager","fork":true,"url":"https://api.github.com/repos/hmbui/pydm","forks_url":"https://api.github.com/repos/hmbui/pydm/forks","keys_url":"https://api.github.com/repos/hmbui/pydm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmbui/pydm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmbui/pydm/teams","hooks_url":"https://api.github.com/repos/hmbui/pydm/hooks","issue_events_url":"https://api.github.com/repos/hmbui/pydm/issues/events{/number}","events_url":"https://api.github.com/repos/hmbui/pydm/events","assignees_url":"https://api.github.com/repos/hmbui/pydm/assignees{/user}","branches_url":"https://api.github.com/repos/hmbui/pydm/branches{/branch}","tags_url":"https://api.github.com/repos/hmbui/pydm/tags","blobs_url":"https://api.github.com/repos/hmbui/pydm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmbui/pydm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmbui/pydm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmbui/pydm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmbui/pydm/statuses/{sha}","languages_url":"https://api.github.com/repos/hmbui/pydm/languages","stargazers_url":"https://api.github.com/repos/hmbui/pydm/stargazers","contributors_url":"https://api.github.com/repos/hmbui/pydm/contributors","subscribers_url":"https://api.github.com/repos/hmbui/pydm/subscribers","subscription_url":"https://api.github.com/repos/hmbui/pydm/subscription","commits_url":"https://api.github.com/repos/hmbui/pydm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmbui/pydm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmbui/pydm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmbui/pydm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmbui/pydm/contents/{+path}","compare_url":"https://api.github.com/repos/hmbui/pydm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmbui/pydm/merges","archive_url":"https://api.github.com/repos/hmbui/pydm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmbui/pydm/downloads","issues_url":"https://api.github.com/repos/hmbui/pydm/issues{/number}","pulls_url":"https://api.github.com/repos/hmbui/pydm/pulls{/number}","milestones_url":"https://api.github.com/repos/hmbui/pydm/milestones{/number}","notifications_url":"https://api.github.com/repos/hmbui/pydm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmbui/pydm/labels{/name}","releases_url":"https://api.github.com/repos/hmbui/pydm/releases{/id}","deployments_url":"https://api.github.com/repos/hmbui/pydm/deployments","created_at":"2018-02-22T02:06:21Z","updated_at":"2018-05-24T23:52:05Z","pushed_at":"2018-05-30T05:49:46Z","git_url":"git://github.com/hmbui/pydm.git","ssh_url":"git@github.com:hmbui/pydm.git","clone_url":"https://github.com/hmbui/pydm.git","svn_url":"https://github.com/hmbui/pydm","homepage":"http://slaclab.github.io/pydm/","size":5740,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slaclab:master","ref":"master","sha":"2e2b1fdd6c9df47f511ab603884d70b5a9148585","user":{"login":"slaclab","id":16196854,"avatar_url":"https://avatars2.githubusercontent.com/u/16196854?v=4","gravatar_id":"","url":"https://api.github.com/users/slaclab","html_url":"https://github.com/slaclab","followers_url":"https://api.github.com/users/slaclab/followers","following_url":"https://api.github.com/users/slaclab/following{/other_user}","gists_url":"https://api.github.com/users/slaclab/gists{/gist_id}","starred_url":"https://api.github.com/users/slaclab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaclab/subscriptions","organizations_url":"https://api.github.com/users/slaclab/orgs","repos_url":"https://api.github.com/users/slaclab/repos","events_url":"https://api.github.com/users/slaclab/events{/privacy}","received_events_url":"https://api.github.com/users/slaclab/received_events","type":"Organization","site_admin":false},"repo":{"id":59700161,"name":"pydm","full_name":"slaclab/pydm","owner":{"login":"slaclab","id":16196854,"avatar_url":"https://avatars2.githubusercontent.com/u/16196854?v=4","gravatar_id":"","url":"https://api.github.com/users/slaclab","html_url":"https://github.com/slaclab","followers_url":"https://api.github.com/users/slaclab/followers","following_url":"https://api.github.com/users/slaclab/following{/other_user}","gists_url":"https://api.github.com/users/slaclab/gists{/gist_id}","starred_url":"https://api.github.com/users/slaclab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaclab/subscriptions","organizations_url":"https://api.github.com/users/slaclab/orgs","repos_url":"https://api.github.com/users/slaclab/repos","events_url":"https://api.github.com/users/slaclab/events{/privacy}","received_events_url":"https://api.github.com/users/slaclab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slaclab/pydm","description":"Python Display Manager","fork":false,"url":"https://api.github.com/repos/slaclab/pydm","forks_url":"https://api.github.com/repos/slaclab/pydm/forks","keys_url":"https://api.github.com/repos/slaclab/pydm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slaclab/pydm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slaclab/pydm/teams","hooks_url":"https://api.github.com/repos/slaclab/pydm/hooks","issue_events_url":"https://api.github.com/repos/slaclab/pydm/issues/events{/number}","events_url":"https://api.github.com/repos/slaclab/pydm/events","assignees_url":"https://api.github.com/repos/slaclab/pydm/assignees{/user}","branches_url":"https://api.github.com/repos/slaclab/pydm/branches{/branch}","tags_url":"https://api.github.com/repos/slaclab/pydm/tags","blobs_url":"https://api.github.com/repos/slaclab/pydm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slaclab/pydm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slaclab/pydm/git/refs{/sha}","trees_url":"https://api.github.com/repos/slaclab/pydm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slaclab/pydm/statuses/{sha}","languages_url":"https://api.github.com/repos/slaclab/pydm/languages","stargazers_url":"https://api.github.com/repos/slaclab/pydm/stargazers","contributors_url":"https://api.github.com/repos/slaclab/pydm/contributors","subscribers_url":"https://api.github.com/repos/slaclab/pydm/subscribers","subscription_url":"https://api.github.com/repos/slaclab/pydm/subscription","commits_url":"https://api.github.com/repos/slaclab/pydm/commits{/sha}","git_commits_url":"https://api.github.com/repos/slaclab/pydm/git/commits{/sha}","comments_url":"https://api.github.com/repos/slaclab/pydm/comments{/number}","issue_comment_url":"https://api.github.com/repos/slaclab/pydm/issues/comments{/number}","contents_url":"https://api.github.com/repos/slaclab/pydm/contents/{+path}","compare_url":"https://api.github.com/repos/slaclab/pydm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slaclab/pydm/merges","archive_url":"https://api.github.com/repos/slaclab/pydm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slaclab/pydm/downloads","issues_url":"https://api.github.com/repos/slaclab/pydm/issues{/number}","pulls_url":"https://api.github.com/repos/slaclab/pydm/pulls{/number}","milestones_url":"https://api.github.com/repos/slaclab/pydm/milestones{/number}","notifications_url":"https://api.github.com/repos/slaclab/pydm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slaclab/pydm/labels{/name}","releases_url":"https://api.github.com/repos/slaclab/pydm/releases{/id}","deployments_url":"https://api.github.com/repos/slaclab/pydm/deployments","created_at":"2016-05-25T21:50:56Z","updated_at":"2018-05-30T00:39:03Z","pushed_at":"2018-05-30T06:30:20Z","git_url":"git://github.com/slaclab/pydm.git","ssh_url":"git@github.com:slaclab/pydm.git","clone_url":"https://github.com/slaclab/pydm.git","svn_url":"https://github.com/slaclab/pydm","homepage":"http://slaclab.github.io/pydm/","size":8239,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":23,"open_issues":48,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slaclab/pydm/pulls/327"},"html":{"href":"https://github.com/slaclab/pydm/pull/327"},"issue":{"href":"https://api.github.com/repos/slaclab/pydm/issues/327"},"comments":{"href":"https://api.github.com/repos/slaclab/pydm/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/slaclab/pydm/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/slaclab/pydm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slaclab/pydm/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/slaclab/pydm/statuses/b65488a5b81e91afd478bd07ebc238092e861c13"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"hhslepicka"}}