{"action":"created","issue":{"url":"https://api.github.com/repos/Starcounter/StarcounterClientFiles/issues/103","repository_url":"https://api.github.com/repos/Starcounter/StarcounterClientFiles","labels_url":"https://api.github.com/repos/Starcounter/StarcounterClientFiles/issues/103/labels{/name}","comments_url":"https://api.github.com/repos/Starcounter/StarcounterClientFiles/issues/103/comments","events_url":"https://api.github.com/repos/Starcounter/StarcounterClientFiles/issues/103/events","html_url":"https://github.com/Starcounter/StarcounterClientFiles/pull/103","id":343953707,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNDYxNzUw","number":103,"title":"Load full uniform in app-shell","user":{"login":"alshakero","id":17054134,"node_id":"MDQ6VXNlcjE3MDU0MTM0","avatar_url":"https://avatars3.githubusercontent.com/u/17054134?v=4","gravatar_id":"","url":"https://api.github.com/users/alshakero","html_url":"https://github.com/alshakero","followers_url":"https://api.github.com/users/alshakero/followers","following_url":"https://api.github.com/users/alshakero/following{/other_user}","gists_url":"https://api.github.com/users/alshakero/gists{/gist_id}","starred_url":"https://api.github.com/users/alshakero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alshakero/subscriptions","organizations_url":"https://api.github.com/users/alshakero/orgs","repos_url":"https://api.github.com/users/alshakero/repos","events_url":"https://api.github.com/users/alshakero/events{/privacy}","received_events_url":"https://api.github.com/users/alshakero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-07-24T09:21:00Z","updated_at":"2018-07-27T14:21:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Starcounter/StarcounterClientFiles/pulls/103","html_url":"https://github.com/Starcounter/StarcounterClientFiles/pull/103","diff_url":"https://github.com/Starcounter/StarcounterClientFiles/pull/103.diff","patch_url":"https://github.com/Starcounter/StarcounterClientFiles/pull/103.patch"},"body":"5 seconds review. I tested with UniformDocs and all looks good with this app-shell (viewed by view-source):\r\n\r\n```html\r\n<!DOCTYPE html>\r\n<html>\r\n<head>\r\n    <meta charset=\"utf-8\">\r\n    <title>UniformDocs</title>\r\n\r\n    <script src=\"/sys/webcomponentsjs/webcomponents-lite.js\"></script>\r\n    <link rel=\"import\" href=\"/sys/polymer/polymer.html\">\r\n    <link rel=\"import\" href=\"/sys/starcounter.html\">\r\n    <link rel=\"stylesheet\" href=\"/sys/uniform.css/dist/uniform.css\">    \r\n    <link rel=\"manifest\">\r\n</head>\r\n<body>\r\n    <dom-bind id=\"palindrom-root\">\r\n        <template>\r\n            <starcounter-include view-model=\"{{model}}\"></starcounter-include>\r\n        </template>\r\n    </dom-bind>\r\n    \r\n    <palindrom-client ref=\"palindrom-root\" remote-url=\"/__default/AFEF5BB6513EFE1E7D000020\"></palindrom-client>\r\n</body>\r\n</html>\r\n```\r\n\r\nFixes: https://github.com/Starcounter/StarcounterClientFiles/issues/102"},"comment":{"url":"https://api.github.com/repos/Starcounter/StarcounterClientFiles/issues/comments/408433199","html_url":"https://github.com/Starcounter/StarcounterClientFiles/pull/103#issuecomment-408433199","issue_url":"https://api.github.com/repos/Starcounter/StarcounterClientFiles/issues/103","id":408433199,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODQzMzE5OQ==","user":{"login":"warpech","id":566463,"node_id":"MDQ6VXNlcjU2NjQ2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/566463?v=4","gravatar_id":"","url":"https://api.github.com/users/warpech","html_url":"https://github.com/warpech","followers_url":"https://api.github.com/users/warpech/followers","following_url":"https://api.github.com/users/warpech/following{/other_user}","gists_url":"https://api.github.com/users/warpech/gists{/gist_id}","starred_url":"https://api.github.com/users/warpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warpech/subscriptions","organizations_url":"https://api.github.com/users/warpech/orgs","repos_url":"https://api.github.com/users/warpech/repos","events_url":"https://api.github.com/users/warpech/events{/privacy}","received_events_url":"https://api.github.com/users/warpech/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T14:21:08Z","updated_at":"2018-07-27T14:21:08Z","author_association":"MEMBER","body":"I just spend an hour or so, trying to see if there is any deduping effect of `preload` in `<head>`, but I can't find such.\r\n\r\nStylesheets seem to be deduped anyway in Chrome even without `preload`: https://next.plnkr.co/edit/99fFPSkg7DPoQL4F\r\n\r\n@tomalec do you know how can this be explained?\r\n\r\nIt seems @alshakero is right that `preload` doesn't give any benefit of additional deduping."}}
{"actor":{"display_login":"warpech"}}