{"action":"created","issue":{"url":"https://api.github.com/repos/moleculerjs/moleculer/issues/373","repository_url":"https://api.github.com/repos/moleculerjs/moleculer","labels_url":"https://api.github.com/repos/moleculerjs/moleculer/issues/373/labels{/name}","comments_url":"https://api.github.com/repos/moleculerjs/moleculer/issues/373/comments","events_url":"https://api.github.com/repos/moleculerjs/moleculer/issues/373/events","html_url":"https://github.com/moleculerjs/moleculer/pull/373","id":355365090,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTEyMTky","number":373,"title":"321 packet logs","user":{"login":"faeron","id":2397128,"node_id":"MDQ6VXNlcjIzOTcxMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/2397128?v=4","gravatar_id":"","url":"https://api.github.com/users/faeron","html_url":"https://github.com/faeron","followers_url":"https://api.github.com/users/faeron/followers","following_url":"https://api.github.com/users/faeron/following{/other_user}","gists_url":"https://api.github.com/users/faeron/gists{/gist_id}","starred_url":"https://api.github.com/users/faeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faeron/subscriptions","organizations_url":"https://api.github.com/users/faeron/orgs","repos_url":"https://api.github.com/users/faeron/repos","events_url":"https://api.github.com/users/faeron/events{/privacy}","received_events_url":"https://api.github.com/users/faeron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-29T23:06:22Z","updated_at":"2018-11-08T19:34:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/moleculerjs/moleculer/pulls/373","html_url":"https://github.com/moleculerjs/moleculer/pull/373","diff_url":"https://github.com/moleculerjs/moleculer/pull/373.diff","patch_url":"https://github.com/moleculerjs/moleculer/pull/373.patch"},"body":"## :memo: Description\r\n\r\n<!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. -->\r\n\r\n### :dart: Relevant issues\r\n#321 \r\n\r\n### :gem: Type of change\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [x] This change requires a documentation update\r\n\r\n## :vertical_traffic_light: How Has This Been Tested?\r\n\r\n- I started moleculer with npm dev script and defined transit.packetLogFilter for various packet types (heartbeat, discover, info) to verify that log messages do not appear.\r\n- Unit tests\r\n\r\n## :checkered_flag: Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project\r\n- [x] I have performed a self-review of my own code\r\n- [x] **I have added tests that prove my fix is effective or that my feature works**\r\n- [x] **New and existing unit tests pass locally with my changes**\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n"},"comment":{"url":"https://api.github.com/repos/moleculerjs/moleculer/issues/comments/437127613","html_url":"https://github.com/moleculerjs/moleculer/pull/373#issuecomment-437127613","issue_url":"https://api.github.com/repos/moleculerjs/moleculer/issues/373","id":437127613,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzEyNzYxMw==","user":{"login":"faeron","id":2397128,"node_id":"MDQ6VXNlcjIzOTcxMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/2397128?v=4","gravatar_id":"","url":"https://api.github.com/users/faeron","html_url":"https://github.com/faeron","followers_url":"https://api.github.com/users/faeron/followers","following_url":"https://api.github.com/users/faeron/following{/other_user}","gists_url":"https://api.github.com/users/faeron/gists{/gist_id}","starred_url":"https://api.github.com/users/faeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faeron/subscriptions","organizations_url":"https://api.github.com/users/faeron/orgs","repos_url":"https://api.github.com/users/faeron/repos","events_url":"https://api.github.com/users/faeron/events{/privacy}","received_events_url":"https://api.github.com/users/faeron/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T19:34:37Z","updated_at":"2018-11-08T19:34:37Z","author_association":"MEMBER","body":"When trying to use ``ServiceBroker.defaultOptions.transit``some more tests are failing. It seems that there could be an issue with circular dependencies (``Transit`` now requires ``ServiceBroker``, which itself requires ``Transit``). Any idea on how to resolve that?"}}
{"actor":{"display_login":"faeron"}}