{"action":"created","comment":{"url":"https://api.github.com/repos/varnish/vagent2/pulls/comments/218062743","pull_request_review_id":155916135,"id":218062743,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODA2Mjc0Mw==","diff_hunk":"@@ -56,6 +56,24 @@ struct backend_opt {\n \tchar *probe;\n };\n \n+static char *\n+trim(char *line)\n+{\n+\tchar *end;\n+\n+\twhile(isspace((unsigned char)*line)) line++;\n+\n+\tif(*line== 0)  ","path":"src/modules/vbackends.c","position":11,"original_position":11,"commit_id":"5f7fc78ee260269ad9953018cb75244e17646521","original_commit_id":"5f7fc78ee260269ad9953018cb75244e17646521","user":{"login":"Dridi","id":891744,"node_id":"MDQ6VXNlcjg5MTc0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/891744?v=4","gravatar_id":"","url":"https://api.github.com/users/Dridi","html_url":"https://github.com/Dridi","followers_url":"https://api.github.com/users/Dridi/followers","following_url":"https://api.github.com/users/Dridi/following{/other_user}","gists_url":"https://api.github.com/users/Dridi/gists{/gist_id}","starred_url":"https://api.github.com/users/Dridi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dridi/subscriptions","organizations_url":"https://api.github.com/users/Dridi/orgs","repos_url":"https://api.github.com/users/Dridi/repos","events_url":"https://api.github.com/users/Dridi/events{/privacy}","received_events_url":"https://api.github.com/users/Dridi/received_events","type":"User","site_admin":false},"body":"Use `'\\0'` here too.","created_at":"2018-09-17T13:14:29Z","updated_at":"2018-09-17T13:14:30Z","html_url":"https://github.com/varnish/vagent2/pull/202#discussion_r218062743","pull_request_url":"https://api.github.com/repos/varnish/vagent2/pulls/202","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/varnish/vagent2/pulls/comments/218062743"},"html":{"href":"https://github.com/varnish/vagent2/pull/202#discussion_r218062743"},"pull_request":{"href":"https://api.github.com/repos/varnish/vagent2/pulls/202"}}},"pull_request":{"url":"https://api.github.com/repos/varnish/vagent2/pulls/202","id":215833770,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODMzNzcw","html_url":"https://github.com/varnish/vagent2/pull/202","diff_url":"https://github.com/varnish/vagent2/pull/202.diff","patch_url":"https://github.com/varnish/vagent2/pull/202.patch","issue_url":"https://api.github.com/repos/varnish/vagent2/issues/202","number":202,"state":"open","locked":false,"title":"Trim spaces for health probes.","user":{"login":"mariusmagureanu","id":2333090,"node_id":"MDQ6VXNlcjIzMzMwOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/2333090?v=4","gravatar_id":"","url":"https://api.github.com/users/mariusmagureanu","html_url":"https://github.com/mariusmagureanu","followers_url":"https://api.github.com/users/mariusmagureanu/followers","following_url":"https://api.github.com/users/mariusmagureanu/following{/other_user}","gists_url":"https://api.github.com/users/mariusmagureanu/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusmagureanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusmagureanu/subscriptions","organizations_url":"https://api.github.com/users/mariusmagureanu/orgs","repos_url":"https://api.github.com/users/mariusmagureanu/repos","events_url":"https://api.github.com/users/mariusmagureanu/events{/privacy}","received_events_url":"https://api.github.com/users/mariusmagureanu/received_events","type":"User","site_admin":false},"body":"Some tests would be in order here. Didn't really do much other then manually write various probes and check they look fine under /backendjson.\r\n\r\nThis commit is related to #173 \r\n\r\n@Dridi - Thoughts and suggestions are welcome as always.","created_at":"2018-09-16T17:02:02Z","updated_at":"2018-09-17T13:14:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13b15c66ecd6cb3b637567e76acd7776959d113a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/varnish/vagent2/pulls/202/commits","review_comments_url":"https://api.github.com/repos/varnish/vagent2/pulls/202/comments","review_comment_url":"https://api.github.com/repos/varnish/vagent2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/varnish/vagent2/issues/202/comments","statuses_url":"https://api.github.com/repos/varnish/vagent2/statuses/5f7fc78ee260269ad9953018cb75244e17646521","head":{"label":"varnish:gh-173","ref":"gh-173","sha":"5f7fc78ee260269ad9953018cb75244e17646521","user":{"login":"varnish","id":577014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NzAxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/577014?v=4","gravatar_id":"","url":"https://api.github.com/users/varnish","html_url":"https://github.com/varnish","followers_url":"https://api.github.com/users/varnish/followers","following_url":"https://api.github.com/users/varnish/following{/other_user}","gists_url":"https://api.github.com/users/varnish/gists{/gist_id}","starred_url":"https://api.github.com/users/varnish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varnish/subscriptions","organizations_url":"https://api.github.com/users/varnish/orgs","repos_url":"https://api.github.com/users/varnish/repos","events_url":"https://api.github.com/users/varnish/events{/privacy}","received_events_url":"https://api.github.com/users/varnish/received_events","type":"Organization","site_admin":false},"repo":{"id":7241940,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQxOTQw","name":"vagent2","full_name":"varnish/vagent2","private":false,"owner":{"login":"varnish","id":577014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NzAxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/577014?v=4","gravatar_id":"","url":"https://api.github.com/users/varnish","html_url":"https://github.com/varnish","followers_url":"https://api.github.com/users/varnish/followers","following_url":"https://api.github.com/users/varnish/following{/other_user}","gists_url":"https://api.github.com/users/varnish/gists{/gist_id}","starred_url":"https://api.github.com/users/varnish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varnish/subscriptions","organizations_url":"https://api.github.com/users/varnish/orgs","repos_url":"https://api.github.com/users/varnish/repos","events_url":"https://api.github.com/users/varnish/events{/privacy}","received_events_url":"https://api.github.com/users/varnish/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/varnish/vagent2","description":"Varnish Agent","fork":false,"url":"https://api.github.com/repos/varnish/vagent2","forks_url":"https://api.github.com/repos/varnish/vagent2/forks","keys_url":"https://api.github.com/repos/varnish/vagent2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/varnish/vagent2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/varnish/vagent2/teams","hooks_url":"https://api.github.com/repos/varnish/vagent2/hooks","issue_events_url":"https://api.github.com/repos/varnish/vagent2/issues/events{/number}","events_url":"https://api.github.com/repos/varnish/vagent2/events","assignees_url":"https://api.github.com/repos/varnish/vagent2/assignees{/user}","branches_url":"https://api.github.com/repos/varnish/vagent2/branches{/branch}","tags_url":"https://api.github.com/repos/varnish/vagent2/tags","blobs_url":"https://api.github.com/repos/varnish/vagent2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/varnish/vagent2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/varnish/vagent2/git/refs{/sha}","trees_url":"https://api.github.com/repos/varnish/vagent2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/varnish/vagent2/statuses/{sha}","languages_url":"https://api.github.com/repos/varnish/vagent2/languages","stargazers_url":"https://api.github.com/repos/varnish/vagent2/stargazers","contributors_url":"https://api.github.com/repos/varnish/vagent2/contributors","subscribers_url":"https://api.github.com/repos/varnish/vagent2/subscribers","subscription_url":"https://api.github.com/repos/varnish/vagent2/subscription","commits_url":"https://api.github.com/repos/varnish/vagent2/commits{/sha}","git_commits_url":"https://api.github.com/repos/varnish/vagent2/git/commits{/sha}","comments_url":"https://api.github.com/repos/varnish/vagent2/comments{/number}","issue_comment_url":"https://api.github.com/repos/varnish/vagent2/issues/comments{/number}","contents_url":"https://api.github.com/repos/varnish/vagent2/contents/{+path}","compare_url":"https://api.github.com/repos/varnish/vagent2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/varnish/vagent2/merges","archive_url":"https://api.github.com/repos/varnish/vagent2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/varnish/vagent2/downloads","issues_url":"https://api.github.com/repos/varnish/vagent2/issues{/number}","pulls_url":"https://api.github.com/repos/varnish/vagent2/pulls{/number}","milestones_url":"https://api.github.com/repos/varnish/vagent2/milestones{/number}","notifications_url":"https://api.github.com/repos/varnish/vagent2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/varnish/vagent2/labels{/name}","releases_url":"https://api.github.com/repos/varnish/vagent2/releases{/id}","deployments_url":"https://api.github.com/repos/varnish/vagent2/deployments","created_at":"2012-12-19T14:42:09Z","updated_at":"2018-09-14T14:37:41Z","pushed_at":"2018-09-16T17:02:03Z","git_url":"git://github.com/varnish/vagent2.git","ssh_url":"git@github.com:varnish/vagent2.git","clone_url":"https://github.com/varnish/vagent2.git","svn_url":"https://github.com/varnish/vagent2","homepage":"","size":3411,"stargazers_count":262,"watchers_count":262,"language":"Roff","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":51,"open_issues":16,"watchers":262,"default_branch":"master"}},"base":{"label":"varnish:master","ref":"master","sha":"adb766ebff642470908b4e5b5f6ea0eabadf93bf","user":{"login":"varnish","id":577014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NzAxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/577014?v=4","gravatar_id":"","url":"https://api.github.com/users/varnish","html_url":"https://github.com/varnish","followers_url":"https://api.github.com/users/varnish/followers","following_url":"https://api.github.com/users/varnish/following{/other_user}","gists_url":"https://api.github.com/users/varnish/gists{/gist_id}","starred_url":"https://api.github.com/users/varnish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varnish/subscriptions","organizations_url":"https://api.github.com/users/varnish/orgs","repos_url":"https://api.github.com/users/varnish/repos","events_url":"https://api.github.com/users/varnish/events{/privacy}","received_events_url":"https://api.github.com/users/varnish/received_events","type":"Organization","site_admin":false},"repo":{"id":7241940,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQxOTQw","name":"vagent2","full_name":"varnish/vagent2","private":false,"owner":{"login":"varnish","id":577014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NzAxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/577014?v=4","gravatar_id":"","url":"https://api.github.com/users/varnish","html_url":"https://github.com/varnish","followers_url":"https://api.github.com/users/varnish/followers","following_url":"https://api.github.com/users/varnish/following{/other_user}","gists_url":"https://api.github.com/users/varnish/gists{/gist_id}","starred_url":"https://api.github.com/users/varnish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varnish/subscriptions","organizations_url":"https://api.github.com/users/varnish/orgs","repos_url":"https://api.github.com/users/varnish/repos","events_url":"https://api.github.com/users/varnish/events{/privacy}","received_events_url":"https://api.github.com/users/varnish/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/varnish/vagent2","description":"Varnish Agent","fork":false,"url":"https://api.github.com/repos/varnish/vagent2","forks_url":"https://api.github.com/repos/varnish/vagent2/forks","keys_url":"https://api.github.com/repos/varnish/vagent2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/varnish/vagent2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/varnish/vagent2/teams","hooks_url":"https://api.github.com/repos/varnish/vagent2/hooks","issue_events_url":"https://api.github.com/repos/varnish/vagent2/issues/events{/number}","events_url":"https://api.github.com/repos/varnish/vagent2/events","assignees_url":"https://api.github.com/repos/varnish/vagent2/assignees{/user}","branches_url":"https://api.github.com/repos/varnish/vagent2/branches{/branch}","tags_url":"https://api.github.com/repos/varnish/vagent2/tags","blobs_url":"https://api.github.com/repos/varnish/vagent2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/varnish/vagent2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/varnish/vagent2/git/refs{/sha}","trees_url":"https://api.github.com/repos/varnish/vagent2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/varnish/vagent2/statuses/{sha}","languages_url":"https://api.github.com/repos/varnish/vagent2/languages","stargazers_url":"https://api.github.com/repos/varnish/vagent2/stargazers","contributors_url":"https://api.github.com/repos/varnish/vagent2/contributors","subscribers_url":"https://api.github.com/repos/varnish/vagent2/subscribers","subscription_url":"https://api.github.com/repos/varnish/vagent2/subscription","commits_url":"https://api.github.com/repos/varnish/vagent2/commits{/sha}","git_commits_url":"https://api.github.com/repos/varnish/vagent2/git/commits{/sha}","comments_url":"https://api.github.com/repos/varnish/vagent2/comments{/number}","issue_comment_url":"https://api.github.com/repos/varnish/vagent2/issues/comments{/number}","contents_url":"https://api.github.com/repos/varnish/vagent2/contents/{+path}","compare_url":"https://api.github.com/repos/varnish/vagent2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/varnish/vagent2/merges","archive_url":"https://api.github.com/repos/varnish/vagent2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/varnish/vagent2/downloads","issues_url":"https://api.github.com/repos/varnish/vagent2/issues{/number}","pulls_url":"https://api.github.com/repos/varnish/vagent2/pulls{/number}","milestones_url":"https://api.github.com/repos/varnish/vagent2/milestones{/number}","notifications_url":"https://api.github.com/repos/varnish/vagent2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/varnish/vagent2/labels{/name}","releases_url":"https://api.github.com/repos/varnish/vagent2/releases{/id}","deployments_url":"https://api.github.com/repos/varnish/vagent2/deployments","created_at":"2012-12-19T14:42:09Z","updated_at":"2018-09-14T14:37:41Z","pushed_at":"2018-09-16T17:02:03Z","git_url":"git://github.com/varnish/vagent2.git","ssh_url":"git@github.com:varnish/vagent2.git","clone_url":"https://github.com/varnish/vagent2.git","svn_url":"https://github.com/varnish/vagent2","homepage":"","size":3411,"stargazers_count":262,"watchers_count":262,"language":"Roff","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":51,"open_issues":16,"watchers":262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/varnish/vagent2/pulls/202"},"html":{"href":"https://github.com/varnish/vagent2/pull/202"},"issue":{"href":"https://api.github.com/repos/varnish/vagent2/issues/202"},"comments":{"href":"https://api.github.com/repos/varnish/vagent2/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/varnish/vagent2/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/varnish/vagent2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/varnish/vagent2/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/varnish/vagent2/statuses/5f7fc78ee260269ad9953018cb75244e17646521"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Dridi"}}