{"action":"created","issue":{"url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/issues/636","repository_url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce","labels_url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/issues/636/labels{/name}","comments_url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/issues/636/comments","events_url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/issues/636/events","html_url":"https://github.com/OXID-eSales/oxideshop_ce/pull/636","id":303868046,"number":636,"title":"Change function declarations to protected","user":{"login":"cpjolly","id":1645916,"avatar_url":"https://avatars2.githubusercontent.com/u/1645916?v=4","gravatar_id":"","url":"https://api.github.com/users/cpjolly","html_url":"https://github.com/cpjolly","followers_url":"https://api.github.com/users/cpjolly/followers","following_url":"https://api.github.com/users/cpjolly/following{/other_user}","gists_url":"https://api.github.com/users/cpjolly/gists{/gist_id}","starred_url":"https://api.github.com/users/cpjolly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpjolly/subscriptions","organizations_url":"https://api.github.com/users/cpjolly/orgs","repos_url":"https://api.github.com/users/cpjolly/repos","events_url":"https://api.github.com/users/cpjolly/events{/privacy}","received_events_url":"https://api.github.com/users/cpjolly/received_events","type":"User","site_admin":false},"labels":[{"id":184792782,"url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/labels/Ready%20to%20merge","name":"Ready to merge","color":"fbca04","default":false},{"id":777649765,"url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":{"login":"Sieg","id":98882,"avatar_url":"https://avatars2.githubusercontent.com/u/98882?v=4","gravatar_id":"","url":"https://api.github.com/users/Sieg","html_url":"https://github.com/Sieg","followers_url":"https://api.github.com/users/Sieg/followers","following_url":"https://api.github.com/users/Sieg/following{/other_user}","gists_url":"https://api.github.com/users/Sieg/gists{/gist_id}","starred_url":"https://api.github.com/users/Sieg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sieg/subscriptions","organizations_url":"https://api.github.com/users/Sieg/orgs","repos_url":"https://api.github.com/users/Sieg/repos","events_url":"https://api.github.com/users/Sieg/events{/privacy}","received_events_url":"https://api.github.com/users/Sieg/received_events","type":"User","site_admin":false},"assignees":[{"login":"Sieg","id":98882,"avatar_url":"https://avatars2.githubusercontent.com/u/98882?v=4","gravatar_id":"","url":"https://api.github.com/users/Sieg","html_url":"https://github.com/Sieg","followers_url":"https://api.github.com/users/Sieg/followers","following_url":"https://api.github.com/users/Sieg/following{/other_user}","gists_url":"https://api.github.com/users/Sieg/gists{/gist_id}","starred_url":"https://api.github.com/users/Sieg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sieg/subscriptions","organizations_url":"https://api.github.com/users/Sieg/orgs","repos_url":"https://api.github.com/users/Sieg/repos","events_url":"https://api.github.com/users/Sieg/events{/privacy}","received_events_url":"https://api.github.com/users/Sieg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-03-09T14:56:38Z","updated_at":"2018-04-19T08:57:45Z","closed_at":"2018-04-19T08:57:45Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/pulls/636","html_url":"https://github.com/OXID-eSales/oxideshop_ce/pull/636","diff_url":"https://github.com/OXID-eSales/oxideshop_ce/pull/636.diff","patch_url":"https://github.com/OXID-eSales/oxideshop_ce/pull/636.patch"},"body":"The methods isSerializedBasketValid, isClassInSerializedObject, isClassOrNullInSerializedObjectAfterField and isUnserializedBasketValid need to accessible to classes that extend the public Session::getBasket method."},"comment":{"url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/issues/comments/382662063","html_url":"https://github.com/OXID-eSales/oxideshop_ce/pull/636#issuecomment-382662063","issue_url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/issues/636","id":382662063,"user":{"login":"Sieg","id":98882,"avatar_url":"https://avatars2.githubusercontent.com/u/98882?v=4","gravatar_id":"","url":"https://api.github.com/users/Sieg","html_url":"https://github.com/Sieg","followers_url":"https://api.github.com/users/Sieg/followers","following_url":"https://api.github.com/users/Sieg/following{/other_user}","gists_url":"https://api.github.com/users/Sieg/gists{/gist_id}","starred_url":"https://api.github.com/users/Sieg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sieg/subscriptions","organizations_url":"https://api.github.com/users/Sieg/orgs","repos_url":"https://api.github.com/users/Sieg/repos","events_url":"https://api.github.com/users/Sieg/events{/privacy}","received_events_url":"https://api.github.com/users/Sieg/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T08:57:45Z","updated_at":"2018-04-19T08:57:45Z","author_association":"CONTRIBUTOR","body":"Hello @cpjolly, i have merged your changes at a3d4c90fe8fcbad99a09f7adf55410be4083755a. Thank you for the contribution and have a nice day."}}
{"actor":{"display_login":"Sieg"}}