{"action":"created","issue":{"url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5422","repository_url":"https://api.github.com/repos/gitextensions/gitextensions","labels_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5422/labels{/name}","comments_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5422/comments","events_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5422/events","html_url":"https://github.com/gitextensions/gitextensions/pull/5422","id":359627867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDc2NDA0","number":5422,"title":"Copy multiple commits to clipboard","user":{"login":"Yiabiten","id":5012992,"node_id":"MDQ6VXNlcjUwMTI5OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5012992?v=4","gravatar_id":"","url":"https://api.github.com/users/Yiabiten","html_url":"https://github.com/Yiabiten","followers_url":"https://api.github.com/users/Yiabiten/followers","following_url":"https://api.github.com/users/Yiabiten/following{/other_user}","gists_url":"https://api.github.com/users/Yiabiten/gists{/gist_id}","starred_url":"https://api.github.com/users/Yiabiten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yiabiten/subscriptions","organizations_url":"https://api.github.com/users/Yiabiten/orgs","repos_url":"https://api.github.com/users/Yiabiten/repos","events_url":"https://api.github.com/users/Yiabiten/events{/privacy}","received_events_url":"https://api.github.com/users/Yiabiten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-12T19:53:13Z","updated_at":"2018-09-14T10:57:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/5422","html_url":"https://github.com/gitextensions/gitextensions/pull/5422","diff_url":"https://github.com/gitextensions/gitextensions/pull/5422.diff","patch_url":"https://github.com/gitextensions/gitextensions/pull/5422.patch"},"body":"Fixes #5359\r\n\r\nChanges proposed in this pull request:\r\n- Copy all **selected** commits data, including branches and tags\r\n- The previous behavior was to copy the last selected commit only (in case of multiple commits selection)\r\n \r\nScreenshots before and after:\r\n- Before\r\n![before](https://user-images.githubusercontent.com/5012992/45449550-6a228c00-b6cd-11e8-8884-ee541b6251c1.png)\r\n\r\n- After\r\n![after](https://user-images.githubusercontent.com/5012992/45449549-6a228c00-b6cd-11e8-96b1-c4867683ff0f.png)\r\n\r\nWhat did I do to test the code and ensure quality:\r\n- I ran the code on multiple scenarios. No test was added.\r\n"},"comment":{"url":"https://api.github.com/repos/gitextensions/gitextensions/issues/comments/421321384","html_url":"https://github.com/gitextensions/gitextensions/pull/5422#issuecomment-421321384","issue_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/5422","id":421321384,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTMyMTM4NA==","user":{"login":"vbjay","id":3629489,"node_id":"MDQ6VXNlcjM2Mjk0ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/3629489?v=4","gravatar_id":"","url":"https://api.github.com/users/vbjay","html_url":"https://github.com/vbjay","followers_url":"https://api.github.com/users/vbjay/followers","following_url":"https://api.github.com/users/vbjay/following{/other_user}","gists_url":"https://api.github.com/users/vbjay/gists{/gist_id}","starred_url":"https://api.github.com/users/vbjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbjay/subscriptions","organizations_url":"https://api.github.com/users/vbjay/orgs","repos_url":"https://api.github.com/users/vbjay/repos","events_url":"https://api.github.com/users/vbjay/events{/privacy}","received_events_url":"https://api.github.com/users/vbjay/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T10:57:03Z","updated_at":"2018-09-14T10:57:03Z","author_association":"CONTRIBUTOR","body":"On a single commit it should look like it does now. Multiple commits it\nshould show first commit info..last commit info.\n\nCommit Hash: AAABBCC123..XXYYZZ890\n\nOn Fri, Sep 14, 2018, 6:50 AM Youness IABITEN <notifications@github.com>\nwrote:\n\n> *@Yiabiten* commented on this pull request.\n> ------------------------------\n>\n> In GitUI/UserControls/RevisionGrid/CopyContextMenuItem.cs\n> <https://github.com/gitextensions/gitextensions/pull/5422#discussion_r217674209>\n> :\n>\n> >                      }\n>\n>                      DropDownItems.Add(new ToolStripSeparator());\n>                  }\n>\n>                  // Add other items\n> -                AddItem($\"{Strings.CommitHash}     ({revision.ObjectId.ToShortString()}...)\", r => r.Guid, Images.CommitId, Keys.Control | Keys.C);\n> -                AddItem($\"{Strings.Message}     ({revision.Subject.ShortenTo(30)})\", r => r.Body ?? r.Subject, Images.Message);\n> -                AddItem($\"{Strings.Author}     ({revision.Author})\", r => r.Author, Images.Author);\n> +                AddItem(Strings.CommitHash,  (GitRevision r) => r.Guid, Images.CommitId, Keys.Control | Keys.C);\n> +                AddItem(Strings.Message,     r => r.Body ?? r.Subject, Images.Message);\n> +                AddItem(Strings.Author,      r => r.Author, Images.Author);\n> +                AddItem(Strings.AuthorDate,  r => r.AuthorDate.ToString(), Images.Date);\n>\n> Yes. I prefered to have a unified display between the two use cases\n> (multiple commits vs single commit selected)\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/gitextensions/gitextensions/pull/5422#discussion_r217674209>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ADdhsfMtM_JvaXgNhMPnVuGqW_uSnov-ks5ua4n-gaJpZM4WmDma>\n> .\n>\n"}}
{"actor":{"display_login":"vbjay"}}