{"action":"created","comment":{"url":"https://api.github.com/repos/tantivy-search/tantivy/pulls/comments/211121618","pull_request_review_id":147477884,"id":211121618,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTEyMTYxOA==","diff_hunk":"@@ -98,3 +98,15 @@ where\n         false\n     }\n }\n+\n+impl Default for StopWordFilter {\n+    fn default() -> StopWordFilter {\n+        let words = vec![\n+            \"a\", \"an\", \"and\", \"are\", \"as\", \"at\", \"be\", \"but\", \"by\", \"for\", \"if\", \"in\", \"into\",","path":"src/tokenizer/stop_word_filter.rs","position":8,"original_position":8,"commit_id":"43fb88aa758a0a28bd70abc0d79a65afe6758c22","original_commit_id":"43fb88aa758a0a28bd70abc0d79a65afe6758c22","user":{"login":"fulmicoton","id":1021506,"node_id":"MDQ6VXNlcjEwMjE1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1021506?v=4","gravatar_id":"","url":"https://api.github.com/users/fulmicoton","html_url":"https://github.com/fulmicoton","followers_url":"https://api.github.com/users/fulmicoton/followers","following_url":"https://api.github.com/users/fulmicoton/following{/other_user}","gists_url":"https://api.github.com/users/fulmicoton/gists{/gist_id}","starred_url":"https://api.github.com/users/fulmicoton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fulmicoton/subscriptions","organizations_url":"https://api.github.com/users/fulmicoton/orgs","repos_url":"https://api.github.com/users/fulmicoton/repos","events_url":"https://api.github.com/users/fulmicoton/events{/privacy}","received_events_url":"https://api.github.com/users/fulmicoton/received_events","type":"User","site_admin":false},"body":"this could be a `[&'static str; N]`.","created_at":"2018-08-20T00:44:41Z","updated_at":"2018-08-20T00:44:41Z","html_url":"https://github.com/tantivy-search/tantivy/pull/381#discussion_r211121618","pull_request_url":"https://api.github.com/repos/tantivy-search/tantivy/pulls/381","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tantivy-search/tantivy/pulls/comments/211121618"},"html":{"href":"https://github.com/tantivy-search/tantivy/pull/381#discussion_r211121618"},"pull_request":{"href":"https://api.github.com/repos/tantivy-search/tantivy/pulls/381"}}},"pull_request":{"url":"https://api.github.com/repos/tantivy-search/tantivy/pulls/381","id":209314280,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzE0Mjgw","html_url":"https://github.com/tantivy-search/tantivy/pull/381","diff_url":"https://github.com/tantivy-search/tantivy/pull/381.diff","patch_url":"https://github.com/tantivy-search/tantivy/pull/381.patch","issue_url":"https://api.github.com/repos/tantivy-search/tantivy/issues/381","number":381,"state":"open","locked":false,"title":"Add default EN stopwords to the default analyzer","user":{"login":"drusellers","id":63355,"node_id":"MDQ6VXNlcjYzMzU1","avatar_url":"https://avatars1.githubusercontent.com/u/63355?v=4","gravatar_id":"","url":"https://api.github.com/users/drusellers","html_url":"https://github.com/drusellers","followers_url":"https://api.github.com/users/drusellers/followers","following_url":"https://api.github.com/users/drusellers/following{/other_user}","gists_url":"https://api.github.com/users/drusellers/gists{/gist_id}","starred_url":"https://api.github.com/users/drusellers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drusellers/subscriptions","organizations_url":"https://api.github.com/users/drusellers/orgs","repos_url":"https://api.github.com/users/drusellers/repos","events_url":"https://api.github.com/users/drusellers/events{/privacy}","received_events_url":"https://api.github.com/users/drusellers/received_events","type":"User","site_admin":false},"body":"I'd like to suggest adding a default set of EN stopwords to the standard tokenizers for Tantivy.\r\n\r\n1. I'm not sure that `Stopwords::default` is the best method name and very open to renaming.\r\n2. I'm pretty sure my implementation could be quite a bit better memory wise.\r\n3. Is this a sensible add to the default tokenizers?","created_at":"2018-08-18T14:22:50Z","updated_at":"2018-08-20T00:44:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5029a07d6cc196c26c561ed7d25a970d482aff9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tantivy-search/tantivy/pulls/381/commits","review_comments_url":"https://api.github.com/repos/tantivy-search/tantivy/pulls/381/comments","review_comment_url":"https://api.github.com/repos/tantivy-search/tantivy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tantivy-search/tantivy/issues/381/comments","statuses_url":"https://api.github.com/repos/tantivy-search/tantivy/statuses/43fb88aa758a0a28bd70abc0d79a65afe6758c22","head":{"label":"tantivy-search:dds/en-stopwords","ref":"dds/en-stopwords","sha":"43fb88aa758a0a28bd70abc0d79a65afe6758c22","user":{"login":"tantivy-search","id":23249022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjQ5MDIy","avatar_url":"https://avatars3.githubusercontent.com/u/23249022?v=4","gravatar_id":"","url":"https://api.github.com/users/tantivy-search","html_url":"https://github.com/tantivy-search","followers_url":"https://api.github.com/users/tantivy-search/followers","following_url":"https://api.github.com/users/tantivy-search/following{/other_user}","gists_url":"https://api.github.com/users/tantivy-search/gists{/gist_id}","starred_url":"https://api.github.com/users/tantivy-search/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tantivy-search/subscriptions","organizations_url":"https://api.github.com/users/tantivy-search/orgs","repos_url":"https://api.github.com/users/tantivy-search/repos","events_url":"https://api.github.com/users/tantivy-search/events{/privacy}","received_events_url":"https://api.github.com/users/tantivy-search/received_events","type":"Organization","site_admin":false},"repo":{"id":49412556,"node_id":"MDEwOlJlcG9zaXRvcnk0OTQxMjU1Ng==","name":"tantivy","full_name":"tantivy-search/tantivy","owner":{"login":"tantivy-search","id":23249022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjQ5MDIy","avatar_url":"https://avatars3.githubusercontent.com/u/23249022?v=4","gravatar_id":"","url":"https://api.github.com/users/tantivy-search","html_url":"https://github.com/tantivy-search","followers_url":"https://api.github.com/users/tantivy-search/followers","following_url":"https://api.github.com/users/tantivy-search/following{/other_user}","gists_url":"https://api.github.com/users/tantivy-search/gists{/gist_id}","starred_url":"https://api.github.com/users/tantivy-search/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tantivy-search/subscriptions","organizations_url":"https://api.github.com/users/tantivy-search/orgs","repos_url":"https://api.github.com/users/tantivy-search/repos","events_url":"https://api.github.com/users/tantivy-search/events{/privacy}","received_events_url":"https://api.github.com/users/tantivy-search/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tantivy-search/tantivy","description":"Tantivy is a full-text search engine library inspired by Lucene and written in Rust","fork":false,"url":"https://api.github.com/repos/tantivy-search/tantivy","forks_url":"https://api.github.com/repos/tantivy-search/tantivy/forks","keys_url":"https://api.github.com/repos/tantivy-search/tantivy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tantivy-search/tantivy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tantivy-search/tantivy/teams","hooks_url":"https://api.github.com/repos/tantivy-search/tantivy/hooks","issue_events_url":"https://api.github.com/repos/tantivy-search/tantivy/issues/events{/number}","events_url":"https://api.github.com/repos/tantivy-search/tantivy/events","assignees_url":"https://api.github.com/repos/tantivy-search/tantivy/assignees{/user}","branches_url":"https://api.github.com/repos/tantivy-search/tantivy/branches{/branch}","tags_url":"https://api.github.com/repos/tantivy-search/tantivy/tags","blobs_url":"https://api.github.com/repos/tantivy-search/tantivy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tantivy-search/tantivy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tantivy-search/tantivy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tantivy-search/tantivy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tantivy-search/tantivy/statuses/{sha}","languages_url":"https://api.github.com/repos/tantivy-search/tantivy/languages","stargazers_url":"https://api.github.com/repos/tantivy-search/tantivy/stargazers","contributors_url":"https://api.github.com/repos/tantivy-search/tantivy/contributors","subscribers_url":"https://api.github.com/repos/tantivy-search/tantivy/subscribers","subscription_url":"https://api.github.com/repos/tantivy-search/tantivy/subscription","commits_url":"https://api.github.com/repos/tantivy-search/tantivy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tantivy-search/tantivy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tantivy-search/tantivy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tantivy-search/tantivy/issues/comments{/number}","contents_url":"https://api.github.com/repos/tantivy-search/tantivy/contents/{+path}","compare_url":"https://api.github.com/repos/tantivy-search/tantivy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tantivy-search/tantivy/merges","archive_url":"https://api.github.com/repos/tantivy-search/tantivy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tantivy-search/tantivy/downloads","issues_url":"https://api.github.com/repos/tantivy-search/tantivy/issues{/number}","pulls_url":"https://api.github.com/repos/tantivy-search/tantivy/pulls{/number}","milestones_url":"https://api.github.com/repos/tantivy-search/tantivy/milestones{/number}","notifications_url":"https://api.github.com/repos/tantivy-search/tantivy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tantivy-search/tantivy/labels{/name}","releases_url":"https://api.github.com/repos/tantivy-search/tantivy/releases{/id}","deployments_url":"https://api.github.com/repos/tantivy-search/tantivy/deployments","created_at":"2016-01-11T08:32:16Z","updated_at":"2018-08-20T00:40:48Z","pushed_at":"2018-08-20T00:40:53Z","git_url":"git://github.com/tantivy-search/tantivy.git","ssh_url":"git@github.com:tantivy-search/tantivy.git","clone_url":"https://github.com/tantivy-search/tantivy.git","svn_url":"https://github.com/tantivy-search/tantivy","homepage":"","size":35500,"stargazers_count":1023,"watchers_count":1023,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":58,"open_issues":69,"watchers":1023,"default_branch":"master"}},"base":{"label":"tantivy-search:master","ref":"master","sha":"23c2c3ae7c9ee7c787b1cb4af3e6555c174c7eec","user":{"login":"tantivy-search","id":23249022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjQ5MDIy","avatar_url":"https://avatars3.githubusercontent.com/u/23249022?v=4","gravatar_id":"","url":"https://api.github.com/users/tantivy-search","html_url":"https://github.com/tantivy-search","followers_url":"https://api.github.com/users/tantivy-search/followers","following_url":"https://api.github.com/users/tantivy-search/following{/other_user}","gists_url":"https://api.github.com/users/tantivy-search/gists{/gist_id}","starred_url":"https://api.github.com/users/tantivy-search/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tantivy-search/subscriptions","organizations_url":"https://api.github.com/users/tantivy-search/orgs","repos_url":"https://api.github.com/users/tantivy-search/repos","events_url":"https://api.github.com/users/tantivy-search/events{/privacy}","received_events_url":"https://api.github.com/users/tantivy-search/received_events","type":"Organization","site_admin":false},"repo":{"id":49412556,"node_id":"MDEwOlJlcG9zaXRvcnk0OTQxMjU1Ng==","name":"tantivy","full_name":"tantivy-search/tantivy","owner":{"login":"tantivy-search","id":23249022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjQ5MDIy","avatar_url":"https://avatars3.githubusercontent.com/u/23249022?v=4","gravatar_id":"","url":"https://api.github.com/users/tantivy-search","html_url":"https://github.com/tantivy-search","followers_url":"https://api.github.com/users/tantivy-search/followers","following_url":"https://api.github.com/users/tantivy-search/following{/other_user}","gists_url":"https://api.github.com/users/tantivy-search/gists{/gist_id}","starred_url":"https://api.github.com/users/tantivy-search/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tantivy-search/subscriptions","organizations_url":"https://api.github.com/users/tantivy-search/orgs","repos_url":"https://api.github.com/users/tantivy-search/repos","events_url":"https://api.github.com/users/tantivy-search/events{/privacy}","received_events_url":"https://api.github.com/users/tantivy-search/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tantivy-search/tantivy","description":"Tantivy is a full-text search engine library inspired by Lucene and written in Rust","fork":false,"url":"https://api.github.com/repos/tantivy-search/tantivy","forks_url":"https://api.github.com/repos/tantivy-search/tantivy/forks","keys_url":"https://api.github.com/repos/tantivy-search/tantivy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tantivy-search/tantivy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tantivy-search/tantivy/teams","hooks_url":"https://api.github.com/repos/tantivy-search/tantivy/hooks","issue_events_url":"https://api.github.com/repos/tantivy-search/tantivy/issues/events{/number}","events_url":"https://api.github.com/repos/tantivy-search/tantivy/events","assignees_url":"https://api.github.com/repos/tantivy-search/tantivy/assignees{/user}","branches_url":"https://api.github.com/repos/tantivy-search/tantivy/branches{/branch}","tags_url":"https://api.github.com/repos/tantivy-search/tantivy/tags","blobs_url":"https://api.github.com/repos/tantivy-search/tantivy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tantivy-search/tantivy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tantivy-search/tantivy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tantivy-search/tantivy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tantivy-search/tantivy/statuses/{sha}","languages_url":"https://api.github.com/repos/tantivy-search/tantivy/languages","stargazers_url":"https://api.github.com/repos/tantivy-search/tantivy/stargazers","contributors_url":"https://api.github.com/repos/tantivy-search/tantivy/contributors","subscribers_url":"https://api.github.com/repos/tantivy-search/tantivy/subscribers","subscription_url":"https://api.github.com/repos/tantivy-search/tantivy/subscription","commits_url":"https://api.github.com/repos/tantivy-search/tantivy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tantivy-search/tantivy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tantivy-search/tantivy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tantivy-search/tantivy/issues/comments{/number}","contents_url":"https://api.github.com/repos/tantivy-search/tantivy/contents/{+path}","compare_url":"https://api.github.com/repos/tantivy-search/tantivy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tantivy-search/tantivy/merges","archive_url":"https://api.github.com/repos/tantivy-search/tantivy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tantivy-search/tantivy/downloads","issues_url":"https://api.github.com/repos/tantivy-search/tantivy/issues{/number}","pulls_url":"https://api.github.com/repos/tantivy-search/tantivy/pulls{/number}","milestones_url":"https://api.github.com/repos/tantivy-search/tantivy/milestones{/number}","notifications_url":"https://api.github.com/repos/tantivy-search/tantivy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tantivy-search/tantivy/labels{/name}","releases_url":"https://api.github.com/repos/tantivy-search/tantivy/releases{/id}","deployments_url":"https://api.github.com/repos/tantivy-search/tantivy/deployments","created_at":"2016-01-11T08:32:16Z","updated_at":"2018-08-20T00:40:48Z","pushed_at":"2018-08-20T00:40:53Z","git_url":"git://github.com/tantivy-search/tantivy.git","ssh_url":"git@github.com:tantivy-search/tantivy.git","clone_url":"https://github.com/tantivy-search/tantivy.git","svn_url":"https://github.com/tantivy-search/tantivy","homepage":"","size":35500,"stargazers_count":1023,"watchers_count":1023,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":58,"open_issues":69,"watchers":1023,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tantivy-search/tantivy/pulls/381"},"html":{"href":"https://github.com/tantivy-search/tantivy/pull/381"},"issue":{"href":"https://api.github.com/repos/tantivy-search/tantivy/issues/381"},"comments":{"href":"https://api.github.com/repos/tantivy-search/tantivy/issues/381/comments"},"review_comments":{"href":"https://api.github.com/repos/tantivy-search/tantivy/pulls/381/comments"},"review_comment":{"href":"https://api.github.com/repos/tantivy-search/tantivy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tantivy-search/tantivy/pulls/381/commits"},"statuses":{"href":"https://api.github.com/repos/tantivy-search/tantivy/statuses/43fb88aa758a0a28bd70abc0d79a65afe6758c22"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fulmicoton"}}