{"action":"created","issue":{"url":"https://api.github.com/repos/gnosis/dx-contracts/issues/58","repository_url":"https://api.github.com/repos/gnosis/dx-contracts","labels_url":"https://api.github.com/repos/gnosis/dx-contracts/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/gnosis/dx-contracts/issues/58/comments","events_url":"https://api.github.com/repos/gnosis/dx-contracts/issues/58/events","html_url":"https://github.com/gnosis/dx-contracts/pull/58","id":383636528,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDU4NDcz","number":58,"title":"Feature/split contract","user":{"login":"anxolin","id":2352112,"node_id":"MDQ6VXNlcjIzNTIxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2352112?v=4","gravatar_id":"","url":"https://api.github.com/users/anxolin","html_url":"https://github.com/anxolin","followers_url":"https://api.github.com/users/anxolin/followers","following_url":"https://api.github.com/users/anxolin/following{/other_user}","gists_url":"https://api.github.com/users/anxolin/gists{/gist_id}","starred_url":"https://api.github.com/users/anxolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anxolin/subscriptions","organizations_url":"https://api.github.com/users/anxolin/orgs","repos_url":"https://api.github.com/users/anxolin/repos","events_url":"https://api.github.com/users/anxolin/events{/privacy}","received_events_url":"https://api.github.com/users/anxolin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"josojo","id":7348154,"node_id":"MDQ6VXNlcjczNDgxNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7348154?v=4","gravatar_id":"","url":"https://api.github.com/users/josojo","html_url":"https://github.com/josojo","followers_url":"https://api.github.com/users/josojo/followers","following_url":"https://api.github.com/users/josojo/following{/other_user}","gists_url":"https://api.github.com/users/josojo/gists{/gist_id}","starred_url":"https://api.github.com/users/josojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josojo/subscriptions","organizations_url":"https://api.github.com/users/josojo/orgs","repos_url":"https://api.github.com/users/josojo/repos","events_url":"https://api.github.com/users/josojo/events{/privacy}","received_events_url":"https://api.github.com/users/josojo/received_events","type":"User","site_admin":false},"assignees":[{"login":"josojo","id":7348154,"node_id":"MDQ6VXNlcjczNDgxNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7348154?v=4","gravatar_id":"","url":"https://api.github.com/users/josojo","html_url":"https://github.com/josojo","followers_url":"https://api.github.com/users/josojo/followers","following_url":"https://api.github.com/users/josojo/following{/other_user}","gists_url":"https://api.github.com/users/josojo/gists{/gist_id}","starred_url":"https://api.github.com/users/josojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josojo/subscriptions","organizations_url":"https://api.github.com/users/josojo/orgs","repos_url":"https://api.github.com/users/josojo/repos","events_url":"https://api.github.com/users/josojo/events{/privacy}","received_events_url":"https://api.github.com/users/josojo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-11-22T19:00:11Z","updated_at":"2018-11-23T13:33:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gnosis/dx-contracts/pulls/58","html_url":"https://github.com/gnosis/dx-contracts/pull/58","diff_url":"https://github.com/gnosis/dx-contracts/pull/58.diff","patch_url":"https://github.com/gnosis/dx-contracts/pull/58.patch"},"body":"Hi @Velenir  and @josojo !\r\n\r\nCould you help review this PR.\r\n@josojo I include you because I changed things in the smart contract, I would appreciate if you review this parts.\r\n\r\nThere's several things I do here:\r\n\r\n1.  I added a `src/migration/migrations-truffle-1.5` so other projects that are already in truffle-1.5 can deploy the dutchx contracts. I keep also the `src/migration/migrations` until we migrate the whole project\r\n\r\n2. I took some logic out of the main contract, and created some smaller contracts with them:\r\n\r\n![image](https://user-images.githubusercontent.com/2352112/48919426-010c8100-ee93-11e8-99f7-6b6c8d7e6193.png)\r\n\r\nSo the main contract inherit this other contracts:\r\n![image](https://user-images.githubusercontent.com/2352112/48919441-171a4180-ee93-11e8-8acc-aad8144c211a.png)\r\n\r\nIn the future I plan to break it more. But this is the first round. I did it because I wanted in another project to use the contract `TokenWhitelist.sol` that I just created.\r\n\r\n3. @josojo Please, note that I think there's only a small change. I duplicated the WAITING_PERIOD_CHANGE_MASTERCOPY_OR_ORACLE const making 2 different constants.\r\n\r\n4. I migrated in a similar fashion gno-token, util-contracts and owl-token projects. I didn't create PRs for them cause I think is to much overhead. \r\n\r\nLet me know your thoughts please.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/gnosis/dx-contracts/issues/comments/441242427","html_url":"https://github.com/gnosis/dx-contracts/pull/58#issuecomment-441242427","issue_url":"https://api.github.com/repos/gnosis/dx-contracts/issues/58","id":441242427,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTI0MjQyNw==","user":{"login":"anxolin","id":2352112,"node_id":"MDQ6VXNlcjIzNTIxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2352112?v=4","gravatar_id":"","url":"https://api.github.com/users/anxolin","html_url":"https://github.com/anxolin","followers_url":"https://api.github.com/users/anxolin/followers","following_url":"https://api.github.com/users/anxolin/following{/other_user}","gists_url":"https://api.github.com/users/anxolin/gists{/gist_id}","starred_url":"https://api.github.com/users/anxolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anxolin/subscriptions","organizations_url":"https://api.github.com/users/anxolin/orgs","repos_url":"https://api.github.com/users/anxolin/repos","events_url":"https://api.github.com/users/anxolin/events{/privacy}","received_events_url":"https://api.github.com/users/anxolin/received_events","type":"User","site_admin":false},"created_at":"2018-11-23T13:33:46Z","updated_at":"2018-11-23T13:33:46Z","author_association":"CONTRIBUTOR","body":"The migration scripts is OK, if you want to read them is fine, because for this project we still use truffle 4. \r\nI'm more interested in the smart contract changes.\r\n\r\nI'll review now the tests."}}
{"actor":{"display_login":"anxolin"}}