{"action":"created","comment":{"url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/comments/196369517","pull_request_review_id":129906683,"id":196369517,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjM2OTUxNw==","diff_hunk":"@@ -33,13 +34,15 @@ configurePushNotifications(store);\n export default class App extends React.Component<{}, never> {\n   public render() {\n     return (\n-      <StyleProvider style={theme()}>\n-        <Provider store={store}>\n-          <PersistGate loading={undefined} persistor={persistor}>\n-            <RootContainer />\n-          </PersistGate>\n-        </Provider>\n-      </StyleProvider>\n+      <MenuProvider>","path":"ts/App.tsx","position":19,"original_position":19,"commit_id":"416e7f356f6a0146d4ac5023933c2f5bd5dc4623","original_commit_id":"416e7f356f6a0146d4ac5023933c2f5bd5dc4623","user":{"login":"cloudify","id":48206,"node_id":"MDQ6VXNlcjQ4MjA2","avatar_url":"https://avatars2.githubusercontent.com/u/48206?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify","html_url":"https://github.com/cloudify","followers_url":"https://api.github.com/users/cloudify/followers","following_url":"https://api.github.com/users/cloudify/following{/other_user}","gists_url":"https://api.github.com/users/cloudify/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify/subscriptions","organizations_url":"https://api.github.com/users/cloudify/orgs","repos_url":"https://api.github.com/users/cloudify/repos","events_url":"https://api.github.com/users/cloudify/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify/received_events","type":"User","site_admin":false},"body":"could it make sense to just wrap the screens that need this functionality instead of the whole app?","created_at":"2018-06-19T10:22:47Z","updated_at":"2018-06-19T10:22:48Z","html_url":"https://github.com/teamdigitale/italia-app/pull/221#discussion_r196369517","pull_request_url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/221","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/teamdigitale/italia-app/pulls/comments/196369517"},"html":{"href":"https://github.com/teamdigitale/italia-app/pull/221#discussion_r196369517"},"pull_request":{"href":"https://api.github.com/repos/teamdigitale/italia-app/pulls/221"}},"in_reply_to_id":196368113},"pull_request":{"url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/221","id":194545854,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTQ1ODU0","html_url":"https://github.com/teamdigitale/italia-app/pull/221","diff_url":"https://github.com/teamdigitale/italia-app/pull/221.diff","patch_url":"https://github.com/teamdigitale/italia-app/pull/221.patch","issue_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/221","number":221,"state":"open","locked":false,"title":"[#157422715,#157422881] updated credit card component","user":{"login":"fgiobergia","id":107715,"node_id":"MDQ6VXNlcjEwNzcxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/107715?v=4","gravatar_id":"","url":"https://api.github.com/users/fgiobergia","html_url":"https://github.com/fgiobergia","followers_url":"https://api.github.com/users/fgiobergia/followers","following_url":"https://api.github.com/users/fgiobergia/following{/other_user}","gists_url":"https://api.github.com/users/fgiobergia/gists{/gist_id}","starred_url":"https://api.github.com/users/fgiobergia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgiobergia/subscriptions","organizations_url":"https://api.github.com/users/fgiobergia/orgs","repos_url":"https://api.github.com/users/fgiobergia/repos","events_url":"https://api.github.com/users/fgiobergia/events{/privacy}","received_events_url":"https://api.github.com/users/fgiobergia/received_events","type":"User","site_admin":false},"body":"This PR covers the following stories:\r\n\r\n[#157422715](https://www.pivotaltracker.com/story/show/157422715): extending the adoption of the credit card component to the screens requiring it\r\n[#157422881](https://www.pivotaltracker.com/story/show/157422881): implementation of a menu for each payment method\r\n\r\nGiven some problems with React & Android, the original \"credit card component\" story has been divided into two: the other one ([#158295555](https://www.pivotaltracker.com/story/show/158295555)) will be taken care of separately.\r\n\r\nThis screen shows the updated credit card component (minor adjustments when compared to the previous one)\r\n<img src=\"https://user-images.githubusercontent.com/107715/41346548-13b2913e-6f07-11e8-8641-b1b4b03c60b1.png\" width=256/>\r\n\r\nThis is the menu that pops up when opening the \"more\" icon on any of the cards\r\n<img src=\"https://user-images.githubusercontent.com/107715/41346619-5de6f128-6f07-11e8-967d-14f9dc82bb30.png\" width=256/>\r\n\r\nThe following are the card components adjusted for different screens (these were previously images)\r\n<img src=\"https://user-images.githubusercontent.com/107715/41346675-9a1f061c-6f07-11e8-8e47-e1c9383e0dc1.png\" width=256/>\r\n<img src=\"https://user-images.githubusercontent.com/107715/41346678-9d6f9160-6f07-11e8-85f0-11cdfdec0225.png\" width=256/>\r\n\r\nFeedback, as always, appreciated :D\r\n\r\n~TODO: still need to comment the code & restore landing screen~\r\n\r\nEDIT: btw, the \"wallet layout\" component will need to be completely restructured since (1) it's starting to get convoluted and (2) it currently doesn't support the constraints set by [#157929839](https://www.pivotaltracker.com/story/show/157929839)","created_at":"2018-06-13T10:52:12Z","updated_at":"2018-06-19T10:22:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"206baf922ed94ba7bb34a866adde4d449c698689","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gunzip","id":148224,"node_id":"MDQ6VXNlcjE0ODIyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/148224?v=4","gravatar_id":"","url":"https://api.github.com/users/gunzip","html_url":"https://github.com/gunzip","followers_url":"https://api.github.com/users/gunzip/followers","following_url":"https://api.github.com/users/gunzip/following{/other_user}","gists_url":"https://api.github.com/users/gunzip/gists{/gist_id}","starred_url":"https://api.github.com/users/gunzip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunzip/subscriptions","organizations_url":"https://api.github.com/users/gunzip/orgs","repos_url":"https://api.github.com/users/gunzip/repos","events_url":"https://api.github.com/users/gunzip/events{/privacy}","received_events_url":"https://api.github.com/users/gunzip/received_events","type":"User","site_admin":false},{"login":"matteodesanti","id":8171284,"node_id":"MDQ6VXNlcjgxNzEyODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8171284?v=4","gravatar_id":"","url":"https://api.github.com/users/matteodesanti","html_url":"https://github.com/matteodesanti","followers_url":"https://api.github.com/users/matteodesanti/followers","following_url":"https://api.github.com/users/matteodesanti/following{/other_user}","gists_url":"https://api.github.com/users/matteodesanti/gists{/gist_id}","starred_url":"https://api.github.com/users/matteodesanti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matteodesanti/subscriptions","organizations_url":"https://api.github.com/users/matteodesanti/orgs","repos_url":"https://api.github.com/users/matteodesanti/repos","events_url":"https://api.github.com/users/matteodesanti/events{/privacy}","received_events_url":"https://api.github.com/users/matteodesanti/received_events","type":"User","site_admin":false},{"login":"fpersico","id":30595520,"node_id":"MDQ6VXNlcjMwNTk1NTIw","avatar_url":"https://avatars3.githubusercontent.com/u/30595520?v=4","gravatar_id":"","url":"https://api.github.com/users/fpersico","html_url":"https://github.com/fpersico","followers_url":"https://api.github.com/users/fpersico/followers","following_url":"https://api.github.com/users/fpersico/following{/other_user}","gists_url":"https://api.github.com/users/fpersico/gists{/gist_id}","starred_url":"https://api.github.com/users/fpersico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpersico/subscriptions","organizations_url":"https://api.github.com/users/fpersico/orgs","repos_url":"https://api.github.com/users/fpersico/repos","events_url":"https://api.github.com/users/fpersico/events{/privacy}","received_events_url":"https://api.github.com/users/fpersico/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/221/commits","review_comments_url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/221/comments","review_comment_url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/221/comments","statuses_url":"https://api.github.com/repos/teamdigitale/italia-app/statuses/416e7f356f6a0146d4ac5023933c2f5bd5dc4623","head":{"label":"teamdigitale:157422715-credit-card-component","ref":"157422715-credit-card-component","sha":"416e7f356f6a0146d4ac5023933c2f5bd5dc4623","user":{"login":"teamdigitale","id":25081492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDgxNDky","avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"repo":{"id":87916228,"node_id":"MDEwOlJlcG9zaXRvcnk4NzkxNjIyOA==","name":"italia-app","full_name":"teamdigitale/italia-app","owner":{"login":"teamdigitale","id":25081492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDgxNDky","avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamdigitale/italia-app","description":"App della Cittadinanza Digitale (mobile)","fork":false,"url":"https://api.github.com/repos/teamdigitale/italia-app","forks_url":"https://api.github.com/repos/teamdigitale/italia-app/forks","keys_url":"https://api.github.com/repos/teamdigitale/italia-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamdigitale/italia-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamdigitale/italia-app/teams","hooks_url":"https://api.github.com/repos/teamdigitale/italia-app/hooks","issue_events_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/events{/number}","events_url":"https://api.github.com/repos/teamdigitale/italia-app/events","assignees_url":"https://api.github.com/repos/teamdigitale/italia-app/assignees{/user}","branches_url":"https://api.github.com/repos/teamdigitale/italia-app/branches{/branch}","tags_url":"https://api.github.com/repos/teamdigitale/italia-app/tags","blobs_url":"https://api.github.com/repos/teamdigitale/italia-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamdigitale/italia-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamdigitale/italia-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamdigitale/italia-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamdigitale/italia-app/statuses/{sha}","languages_url":"https://api.github.com/repos/teamdigitale/italia-app/languages","stargazers_url":"https://api.github.com/repos/teamdigitale/italia-app/stargazers","contributors_url":"https://api.github.com/repos/teamdigitale/italia-app/contributors","subscribers_url":"https://api.github.com/repos/teamdigitale/italia-app/subscribers","subscription_url":"https://api.github.com/repos/teamdigitale/italia-app/subscription","commits_url":"https://api.github.com/repos/teamdigitale/italia-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamdigitale/italia-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamdigitale/italia-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamdigitale/italia-app/contents/{+path}","compare_url":"https://api.github.com/repos/teamdigitale/italia-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamdigitale/italia-app/merges","archive_url":"https://api.github.com/repos/teamdigitale/italia-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamdigitale/italia-app/downloads","issues_url":"https://api.github.com/repos/teamdigitale/italia-app/issues{/number}","pulls_url":"https://api.github.com/repos/teamdigitale/italia-app/pulls{/number}","milestones_url":"https://api.github.com/repos/teamdigitale/italia-app/milestones{/number}","notifications_url":"https://api.github.com/repos/teamdigitale/italia-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamdigitale/italia-app/labels{/name}","releases_url":"https://api.github.com/repos/teamdigitale/italia-app/releases{/id}","deployments_url":"https://api.github.com/repos/teamdigitale/italia-app/deployments","created_at":"2017-04-11T09:34:46Z","updated_at":"2018-06-18T14:19:40Z","pushed_at":"2018-06-19T09:52:42Z","git_url":"git://github.com/teamdigitale/italia-app.git","ssh_url":"git@github.com:teamdigitale/italia-app.git","clone_url":"https://github.com/teamdigitale/italia-app.git","svn_url":"https://github.com/teamdigitale/italia-app","homepage":"","size":18423,"stargazers_count":53,"watchers_count":53,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":17,"watchers":53,"default_branch":"master"}},"base":{"label":"teamdigitale:master","ref":"master","sha":"ec8f60cff36193638c7608b198aa4c5bd64624a1","user":{"login":"teamdigitale","id":25081492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDgxNDky","avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"repo":{"id":87916228,"node_id":"MDEwOlJlcG9zaXRvcnk4NzkxNjIyOA==","name":"italia-app","full_name":"teamdigitale/italia-app","owner":{"login":"teamdigitale","id":25081492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDgxNDky","avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamdigitale/italia-app","description":"App della Cittadinanza Digitale (mobile)","fork":false,"url":"https://api.github.com/repos/teamdigitale/italia-app","forks_url":"https://api.github.com/repos/teamdigitale/italia-app/forks","keys_url":"https://api.github.com/repos/teamdigitale/italia-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamdigitale/italia-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamdigitale/italia-app/teams","hooks_url":"https://api.github.com/repos/teamdigitale/italia-app/hooks","issue_events_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/events{/number}","events_url":"https://api.github.com/repos/teamdigitale/italia-app/events","assignees_url":"https://api.github.com/repos/teamdigitale/italia-app/assignees{/user}","branches_url":"https://api.github.com/repos/teamdigitale/italia-app/branches{/branch}","tags_url":"https://api.github.com/repos/teamdigitale/italia-app/tags","blobs_url":"https://api.github.com/repos/teamdigitale/italia-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamdigitale/italia-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamdigitale/italia-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamdigitale/italia-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamdigitale/italia-app/statuses/{sha}","languages_url":"https://api.github.com/repos/teamdigitale/italia-app/languages","stargazers_url":"https://api.github.com/repos/teamdigitale/italia-app/stargazers","contributors_url":"https://api.github.com/repos/teamdigitale/italia-app/contributors","subscribers_url":"https://api.github.com/repos/teamdigitale/italia-app/subscribers","subscription_url":"https://api.github.com/repos/teamdigitale/italia-app/subscription","commits_url":"https://api.github.com/repos/teamdigitale/italia-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamdigitale/italia-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamdigitale/italia-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamdigitale/italia-app/contents/{+path}","compare_url":"https://api.github.com/repos/teamdigitale/italia-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamdigitale/italia-app/merges","archive_url":"https://api.github.com/repos/teamdigitale/italia-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamdigitale/italia-app/downloads","issues_url":"https://api.github.com/repos/teamdigitale/italia-app/issues{/number}","pulls_url":"https://api.github.com/repos/teamdigitale/italia-app/pulls{/number}","milestones_url":"https://api.github.com/repos/teamdigitale/italia-app/milestones{/number}","notifications_url":"https://api.github.com/repos/teamdigitale/italia-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamdigitale/italia-app/labels{/name}","releases_url":"https://api.github.com/repos/teamdigitale/italia-app/releases{/id}","deployments_url":"https://api.github.com/repos/teamdigitale/italia-app/deployments","created_at":"2017-04-11T09:34:46Z","updated_at":"2018-06-18T14:19:40Z","pushed_at":"2018-06-19T09:52:42Z","git_url":"git://github.com/teamdigitale/italia-app.git","ssh_url":"git@github.com:teamdigitale/italia-app.git","clone_url":"https://github.com/teamdigitale/italia-app.git","svn_url":"https://github.com/teamdigitale/italia-app","homepage":"","size":18423,"stargazers_count":53,"watchers_count":53,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":17,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teamdigitale/italia-app/pulls/221"},"html":{"href":"https://github.com/teamdigitale/italia-app/pull/221"},"issue":{"href":"https://api.github.com/repos/teamdigitale/italia-app/issues/221"},"comments":{"href":"https://api.github.com/repos/teamdigitale/italia-app/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/teamdigitale/italia-app/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/teamdigitale/italia-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teamdigitale/italia-app/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/teamdigitale/italia-app/statuses/416e7f356f6a0146d4ac5023933c2f5bd5dc4623"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cloudify"}}