{"action":"created","comment":{"url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls/comments/243811571","pull_request_review_id":187675744,"id":243811571,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzgxMTU3MQ==","diff_hunk":"@@ -89,4 +90,17 @@ public BuildInfoDeployer createDeployer(Run build, TaskListener listener, Artifa\n     public List<Module> getModules() {\n         return this.buildInfo.getModules();\n     }\n+\n+    public void addModule(Module other) {","path":"src/main/java/org/jfrog/hudson/pipeline/types/buildInfo/BuildInfoAccessor.java","position":22,"original_position":22,"commit_id":"f560cbc4d0a94f8589a1d30a8388676db19d4a91","original_commit_id":"0ab4b778a66ac9e5406557f9f07ed12ad3b02843","user":{"login":"yahavi","id":11367982,"node_id":"MDQ6VXNlcjExMzY3OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/11367982?v=4","gravatar_id":"","url":"https://api.github.com/users/yahavi","html_url":"https://github.com/yahavi","followers_url":"https://api.github.com/users/yahavi/followers","following_url":"https://api.github.com/users/yahavi/following{/other_user}","gists_url":"https://api.github.com/users/yahavi/gists{/gist_id}","starred_url":"https://api.github.com/users/yahavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahavi/subscriptions","organizations_url":"https://api.github.com/users/yahavi/orgs","repos_url":"https://api.github.com/users/yahavi/repos","events_url":"https://api.github.com/users/yahavi/events{/privacy}","received_events_url":"https://api.github.com/users/yahavi/received_events","type":"User","site_admin":false},"body":"I disagree. This function appends other module to this build info. It doesn't have to be a new module.","created_at":"2018-12-24T10:31:52Z","updated_at":"2018-12-24T10:31:52Z","html_url":"https://github.com/jfrog/jenkins-artifactory-plugin/pull/78#discussion_r243811571","pull_request_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls/78","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls/comments/243811571"},"html":{"href":"https://github.com/jfrog/jenkins-artifactory-plugin/pull/78#discussion_r243811571"},"pull_request":{"href":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls/78"}},"in_reply_to_id":243769166},"pull_request":{"url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls/78","id":235242812,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjQyODEy","html_url":"https://github.com/jfrog/jenkins-artifactory-plugin/pull/78","diff_url":"https://github.com/jfrog/jenkins-artifactory-plugin/pull/78.diff","patch_url":"https://github.com/jfrog/jenkins-artifactory-plugin/pull/78.patch","issue_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/issues/78","number":78,"state":"open","locked":false,"title":"Support for NPM in the Jenkins Artifactory Plugin pipeline","user":{"login":"yahavi","id":11367982,"node_id":"MDQ6VXNlcjExMzY3OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/11367982?v=4","gravatar_id":"","url":"https://api.github.com/users/yahavi","html_url":"https://github.com/yahavi","followers_url":"https://api.github.com/users/yahavi/followers","following_url":"https://api.github.com/users/yahavi/following{/other_user}","gists_url":"https://api.github.com/users/yahavi/gists{/gist_id}","starred_url":"https://api.github.com/users/yahavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahavi/subscriptions","organizations_url":"https://api.github.com/users/yahavi/orgs","repos_url":"https://api.github.com/users/yahavi/repos","events_url":"https://api.github.com/users/yahavi/events{/privacy}","received_events_url":"https://api.github.com/users/yahavi/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-02T07:18:45Z","updated_at":"2018-12-24T10:31:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5293a55ea14292092f75432ac15ae41ecb5181d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls/78/commits","review_comments_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls/78/comments","review_comment_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/issues/78/comments","statuses_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/statuses/f560cbc4d0a94f8589a1d30a8388676db19d4a91","head":{"label":"yahavi:npm-pipeline","ref":"npm-pipeline","sha":"f560cbc4d0a94f8589a1d30a8388676db19d4a91","user":{"login":"yahavi","id":11367982,"node_id":"MDQ6VXNlcjExMzY3OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/11367982?v=4","gravatar_id":"","url":"https://api.github.com/users/yahavi","html_url":"https://github.com/yahavi","followers_url":"https://api.github.com/users/yahavi/followers","following_url":"https://api.github.com/users/yahavi/following{/other_user}","gists_url":"https://api.github.com/users/yahavi/gists{/gist_id}","starred_url":"https://api.github.com/users/yahavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahavi/subscriptions","organizations_url":"https://api.github.com/users/yahavi/orgs","repos_url":"https://api.github.com/users/yahavi/repos","events_url":"https://api.github.com/users/yahavi/events{/privacy}","received_events_url":"https://api.github.com/users/yahavi/received_events","type":"User","site_admin":false},"repo":{"id":143007944,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwMDc5NDQ=","name":"jenkins-artifactory-plugin","full_name":"yahavi/jenkins-artifactory-plugin","private":false,"owner":{"login":"yahavi","id":11367982,"node_id":"MDQ6VXNlcjExMzY3OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/11367982?v=4","gravatar_id":"","url":"https://api.github.com/users/yahavi","html_url":"https://github.com/yahavi","followers_url":"https://api.github.com/users/yahavi/followers","following_url":"https://api.github.com/users/yahavi/following{/other_user}","gists_url":"https://api.github.com/users/yahavi/gists{/gist_id}","starred_url":"https://api.github.com/users/yahavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahavi/subscriptions","organizations_url":"https://api.github.com/users/yahavi/orgs","repos_url":"https://api.github.com/users/yahavi/repos","events_url":"https://api.github.com/users/yahavi/events{/privacy}","received_events_url":"https://api.github.com/users/yahavi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yahavi/jenkins-artifactory-plugin","description":"Jenkins artifactory plugin","fork":true,"url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin","forks_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/forks","keys_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/teams","hooks_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/hooks","issue_events_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/events","assignees_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/tags","blobs_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/languages","stargazers_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/stargazers","contributors_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/contributors","subscribers_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/subscribers","subscription_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/subscription","commits_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/merges","archive_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/downloads","issues_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/labels{/name}","releases_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/yahavi/jenkins-artifactory-plugin/deployments","created_at":"2018-07-31T11:56:22Z","updated_at":"2018-12-19T15:59:05Z","pushed_at":"2018-12-24T10:11:37Z","git_url":"git://github.com/yahavi/jenkins-artifactory-plugin.git","ssh_url":"git@github.com:yahavi/jenkins-artifactory-plugin.git","clone_url":"https://github.com/yahavi/jenkins-artifactory-plugin.git","svn_url":"https://github.com/yahavi/jenkins-artifactory-plugin","homepage":"http://jenkins-ci.org/","size":4332,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jfrog:master","ref":"master","sha":"2b85759e38bd215dc2bb8c0fb8315e8e8f731bc1","user":{"login":"jfrog","id":499942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTk0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/499942?v=4","gravatar_id":"","url":"https://api.github.com/users/jfrog","html_url":"https://github.com/jfrog","followers_url":"https://api.github.com/users/jfrog/followers","following_url":"https://api.github.com/users/jfrog/following{/other_user}","gists_url":"https://api.github.com/users/jfrog/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrog/subscriptions","organizations_url":"https://api.github.com/users/jfrog/orgs","repos_url":"https://api.github.com/users/jfrog/repos","events_url":"https://api.github.com/users/jfrog/events{/privacy}","received_events_url":"https://api.github.com/users/jfrog/received_events","type":"Organization","site_admin":false},"repo":{"id":1381748,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxNzQ4","name":"jenkins-artifactory-plugin","full_name":"jfrog/jenkins-artifactory-plugin","private":false,"owner":{"login":"jfrog","id":499942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTk0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/499942?v=4","gravatar_id":"","url":"https://api.github.com/users/jfrog","html_url":"https://github.com/jfrog","followers_url":"https://api.github.com/users/jfrog/followers","following_url":"https://api.github.com/users/jfrog/following{/other_user}","gists_url":"https://api.github.com/users/jfrog/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrog/subscriptions","organizations_url":"https://api.github.com/users/jfrog/orgs","repos_url":"https://api.github.com/users/jfrog/repos","events_url":"https://api.github.com/users/jfrog/events{/privacy}","received_events_url":"https://api.github.com/users/jfrog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jfrog/jenkins-artifactory-plugin","description":"Jenkins artifactory plugin","fork":true,"url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin","forks_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/forks","keys_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/teams","hooks_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/hooks","issue_events_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/events","assignees_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/tags","blobs_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/languages","stargazers_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/stargazers","contributors_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/contributors","subscribers_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/subscribers","subscription_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/subscription","commits_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/merges","archive_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/downloads","issues_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/deployments","created_at":"2011-02-18T09:17:52Z","updated_at":"2018-12-24T08:48:58Z","pushed_at":"2018-12-24T10:11:38Z","git_url":"git://github.com/jfrog/jenkins-artifactory-plugin.git","ssh_url":"git@github.com:jfrog/jenkins-artifactory-plugin.git","clone_url":"https://github.com/jfrog/jenkins-artifactory-plugin.git","svn_url":"https://github.com/jfrog/jenkins-artifactory-plugin","homepage":"http://jenkins-ci.org/","size":4183,"stargazers_count":48,"watchers_count":48,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":108,"open_issues":9,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls/78"},"html":{"href":"https://github.com/jfrog/jenkins-artifactory-plugin/pull/78"},"issue":{"href":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/issues/78"},"comments":{"href":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/jfrog/jenkins-artifactory-plugin/statuses/f560cbc4d0a94f8589a1d30a8388676db19d4a91"}},"author_association":"NONE"}}
{"actor":{"display_login":"yahavi"}}