{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/181549155","pull_request_review_id":112204485,"id":181549155,"diff_hunk":"@@ -2526,6 +2527,8 @@ function connectionListener(socket) {\n                  'If this is a HTTP request: The server was not ' +\n                  'configured with the `allowHTTP1` option or a ' +\n                  'listener for the `unknownProtocol` event.\\n');\n+\n+      socket.on('error', () => {});","path":"lib/internal/http2/core.js","position":13,"original_position":13,"commit_id":"ac893b6a83b65415c048aa3b66d9cba33e4835d7","original_commit_id":"ac893b6a83b65415c048aa3b66d9cba33e4835d7","user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars0.githubusercontent.com/u/52195?v=4","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"body":"Can you move this to _before_ the call to `end()`?","created_at":"2018-04-14T10:58:27Z","updated_at":"2018-04-14T11:00:38Z","html_url":"https://github.com/nodejs/node/pull/19986#discussion_r181549155","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/19986","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/181549155"},"html":{"href":"https://github.com/nodejs/node/pull/19986#discussion_r181549155"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/19986"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/19986","id":181311750,"html_url":"https://github.com/nodejs/node/pull/19986","diff_url":"https://github.com/nodejs/node/pull/19986.diff","patch_url":"https://github.com/nodejs/node/pull/19986.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/19986","number":19986,"state":"open","locked":false,"title":"http2: add missing error handlers","user":{"login":"ryzokuken","id":13121330,"avatar_url":"https://avatars3.githubusercontent.com/u/13121330?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false},"body":"Attach simple error handlers in http2/core.js on sockets where they\r\nseem to be missing to avoid the process from crashing.\r\n\r\nFixes: https://github.com/nodejs/node/issues/19978\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\ncc @mafintosh @nodejs/http2 ","created_at":"2018-04-12T20:07:41Z","updated_at":"2018-04-14T11:00:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4487c5107532114cdaa38ae6bbd6052ccedf14da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":311670452,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"eb6420","default":false},{"id":364533783,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"c2e0c6","default":false},{"id":647282877,"url":"https://api.github.com/repos/nodejs/node/labels/http2","name":"http2","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/19986/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/19986/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19986/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/ac893b6a83b65415c048aa3b66d9cba33e4835d7","head":{"label":"ryzokuken:bugfix/http2-handle-errors","ref":"bugfix/http2-handle-errors","sha":"ac893b6a83b65415c048aa3b66d9cba33e4835d7","user":{"login":"ryzokuken","id":13121330,"avatar_url":"https://avatars3.githubusercontent.com/u/13121330?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false},"repo":{"id":123622690,"name":"node","full_name":"ryzokuken/node","owner":{"login":"ryzokuken","id":13121330,"avatar_url":"https://avatars3.githubusercontent.com/u/13121330?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryzokuken/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/ryzokuken/node","forks_url":"https://api.github.com/repos/ryzokuken/node/forks","keys_url":"https://api.github.com/repos/ryzokuken/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryzokuken/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryzokuken/node/teams","hooks_url":"https://api.github.com/repos/ryzokuken/node/hooks","issue_events_url":"https://api.github.com/repos/ryzokuken/node/issues/events{/number}","events_url":"https://api.github.com/repos/ryzokuken/node/events","assignees_url":"https://api.github.com/repos/ryzokuken/node/assignees{/user}","branches_url":"https://api.github.com/repos/ryzokuken/node/branches{/branch}","tags_url":"https://api.github.com/repos/ryzokuken/node/tags","blobs_url":"https://api.github.com/repos/ryzokuken/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryzokuken/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryzokuken/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryzokuken/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryzokuken/node/statuses/{sha}","languages_url":"https://api.github.com/repos/ryzokuken/node/languages","stargazers_url":"https://api.github.com/repos/ryzokuken/node/stargazers","contributors_url":"https://api.github.com/repos/ryzokuken/node/contributors","subscribers_url":"https://api.github.com/repos/ryzokuken/node/subscribers","subscription_url":"https://api.github.com/repos/ryzokuken/node/subscription","commits_url":"https://api.github.com/repos/ryzokuken/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryzokuken/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryzokuken/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryzokuken/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryzokuken/node/contents/{+path}","compare_url":"https://api.github.com/repos/ryzokuken/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryzokuken/node/merges","archive_url":"https://api.github.com/repos/ryzokuken/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryzokuken/node/downloads","issues_url":"https://api.github.com/repos/ryzokuken/node/issues{/number}","pulls_url":"https://api.github.com/repos/ryzokuken/node/pulls{/number}","milestones_url":"https://api.github.com/repos/ryzokuken/node/milestones{/number}","notifications_url":"https://api.github.com/repos/ryzokuken/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryzokuken/node/labels{/name}","releases_url":"https://api.github.com/repos/ryzokuken/node/releases{/id}","deployments_url":"https://api.github.com/repos/ryzokuken/node/deployments","created_at":"2018-03-02T19:39:07Z","updated_at":"2018-04-12T19:52:14Z","pushed_at":"2018-04-13T19:50:34Z","git_url":"git://github.com/ryzokuken/node.git","ssh_url":"git@github.com:ryzokuken/node.git","clone_url":"https://github.com/ryzokuken/node.git","svn_url":"https://github.com/ryzokuken/node","homepage":"https://nodejs.org","size":368164,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"039cdebe81e232cae23acdfd8392a8149b718460","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-04-14T10:58:28Z","pushed_at":"2018-04-14T10:44:53Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":372808,"stargazers_count":47570,"watchers_count":47570,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10002,"mirror_url":null,"archived":false,"open_issues_count":744,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10002,"open_issues":744,"watchers":47570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/19986"},"html":{"href":"https://github.com/nodejs/node/pull/19986"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/19986"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/19986/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/19986/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/19986/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/ac893b6a83b65415c048aa3b66d9cba33e4835d7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mcollina"}}