{"action":"created","issue":{"url":"https://api.github.com/repos/buzzfeed/sso/issues/63","repository_url":"https://api.github.com/repos/buzzfeed/sso","labels_url":"https://api.github.com/repos/buzzfeed/sso/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/buzzfeed/sso/issues/63/comments","events_url":"https://api.github.com/repos/buzzfeed/sso/issues/63/events","html_url":"https://github.com/buzzfeed/sso/pull/63","id":361951910,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2Nzk1NTQz","number":63,"title":"Static assets now built into the binary","user":{"login":"sporkmonger","id":1778,"node_id":"MDQ6VXNlcjE3Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1778?v=4","gravatar_id":"","url":"https://api.github.com/users/sporkmonger","html_url":"https://github.com/sporkmonger","followers_url":"https://api.github.com/users/sporkmonger/followers","following_url":"https://api.github.com/users/sporkmonger/following{/other_user}","gists_url":"https://api.github.com/users/sporkmonger/gists{/gist_id}","starred_url":"https://api.github.com/users/sporkmonger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sporkmonger/subscriptions","organizations_url":"https://api.github.com/users/sporkmonger/orgs","repos_url":"https://api.github.com/users/sporkmonger/repos","events_url":"https://api.github.com/users/sporkmonger/events{/privacy}","received_events_url":"https://api.github.com/users/sporkmonger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-09-19T22:29:31Z","updated_at":"2018-09-22T00:39:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/buzzfeed/sso/pulls/63","html_url":"https://github.com/buzzfeed/sso/pull/63","diff_url":"https://github.com/buzzfeed/sso/pull/63.diff","patch_url":"https://github.com/buzzfeed/sso/pull/63.patch"},"body":"## Problem\r\n\r\nFixes #7, simplifies deployment.\r\n\r\n## Solution\r\n\r\nBake static assets into a `.go` file that functions as a file server.\r\n\r\n## Notes\r\n\r\nOpted to use https://github.com/rakyll/statik over https://github.com/jteeuwen/go-bindata since it's actively maintained."},"comment":{"url":"https://api.github.com/repos/buzzfeed/sso/issues/comments/423703838","html_url":"https://github.com/buzzfeed/sso/pull/63#issuecomment-423703838","issue_url":"https://api.github.com/repos/buzzfeed/sso/issues/63","id":423703838,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzcwMzgzOA==","user":{"login":"sporkmonger","id":1778,"node_id":"MDQ6VXNlcjE3Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1778?v=4","gravatar_id":"","url":"https://api.github.com/users/sporkmonger","html_url":"https://github.com/sporkmonger","followers_url":"https://api.github.com/users/sporkmonger/followers","following_url":"https://api.github.com/users/sporkmonger/following{/other_user}","gists_url":"https://api.github.com/users/sporkmonger/gists{/gist_id}","starred_url":"https://api.github.com/users/sporkmonger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sporkmonger/subscriptions","organizations_url":"https://api.github.com/users/sporkmonger/orgs","repos_url":"https://api.github.com/users/sporkmonger/repos","events_url":"https://api.github.com/users/sporkmonger/events{/privacy}","received_events_url":"https://api.github.com/users/sporkmonger/received_events","type":"User","site_admin":false},"created_at":"2018-09-22T00:39:48Z","updated_at":"2018-09-22T00:39:48Z","author_association":"CONTRIBUTOR","body":"Good point, I’ll take care of it.\nOn Fri, Sep 21, 2018 at 5:37 PM Shraya Ramani <notifications@github.com>\nwrote:\n\n> One more request - we should be able to also get rid of copying over the\n> static directory in the Dockerfile\n> <https://github.com/buzzfeed/sso/blob/6bc3c4473d78e94c00775f2297c3a540c7daf0d5/Dockerfile#L31>\n> when building the docker image.\n>\n> Since we are still working on figuring out a good way to build and push\n> docker images for forked community contributions, I've pushed a copy of\n> your pr branch on buzzfeed/sso (https://github.com/buzzfeed/sso/tree/pr/63)\n> to validate on our internal infrastructure so that we can get this merged!\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/buzzfeed/sso/pull/63#issuecomment-423703660>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AAAG8hAICjhvhsYNMoYNCL_sgAgL8y7Cks5udYZhgaJpZM4WxFDW>\n> .\n>\n"}}
{"actor":{"display_login":"sporkmonger"}}