{"action":"created","issue":{"url":"https://api.github.com/repos/krmbn0576/rpgmakermv/issues/1","repository_url":"https://api.github.com/repos/krmbn0576/rpgmakermv","labels_url":"https://api.github.com/repos/krmbn0576/rpgmakermv/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/krmbn0576/rpgmakermv/issues/1/comments","events_url":"https://api.github.com/repos/krmbn0576/rpgmakermv/issues/1/events","html_url":"https://github.com/krmbn0576/rpgmakermv/pull/1","id":365093583,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTIzMTQ5","number":1,"title":"FixWindowDrawing.js の変更案","user":{"login":"rev2nym","id":16161654,"node_id":"MDQ6VXNlcjE2MTYxNjU0","avatar_url":"https://avatars3.githubusercontent.com/u/16161654?v=4","gravatar_id":"","url":"https://api.github.com/users/rev2nym","html_url":"https://github.com/rev2nym","followers_url":"https://api.github.com/users/rev2nym/followers","following_url":"https://api.github.com/users/rev2nym/following{/other_user}","gists_url":"https://api.github.com/users/rev2nym/gists{/gist_id}","starred_url":"https://api.github.com/users/rev2nym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rev2nym/subscriptions","organizations_url":"https://api.github.com/users/rev2nym/orgs","repos_url":"https://api.github.com/users/rev2nym/repos","events_url":"https://api.github.com/users/rev2nym/events{/privacy}","received_events_url":"https://api.github.com/users/rev2nym/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-09-29T03:50:07Z","updated_at":"2018-10-11T04:35:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/krmbn0576/rpgmakermv/pulls/1","html_url":"https://github.com/krmbn0576/rpgmakermv/pull/1","diff_url":"https://github.com/krmbn0576/rpgmakermv/pull/1.diff","patch_url":"https://github.com/krmbn0576/rpgmakermv/pull/1.patch"},"body":"お疲れ様です。\r\n以下の変更案です。\r\n\r\n・baseTexture.update() を繰り返さないようにすること\r\n・ダーティフラグクリア処理のメソッド化\r\n\r\n以上、ご検討お願いいたします。\r\n\r\nなお、ほかの多くのWindow系クラスは\r\ncontents.clear() を refresh() メソッドで行っているようです。\r\n本来なら Window_Base クラスに refresh() を追加して\r\nその中で contents.clear() を行うのが適切であるように思います。\r\nしかし本件はそこまで踏み込むものでもないと思うので\r\nrefresh() メソッドは作っていません。\r\n\r\nあとは元々の Window_Message クラスも\r\nnewPage() メソッド内で contents.clear() しているのですが\r\n表示に反映されないのが不可解ですね…。"},"comment":{"url":"https://api.github.com/repos/krmbn0576/rpgmakermv/issues/comments/428817755","html_url":"https://github.com/krmbn0576/rpgmakermv/pull/1#issuecomment-428817755","issue_url":"https://api.github.com/repos/krmbn0576/rpgmakermv/issues/1","id":428817755,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODgxNzc1NQ==","user":{"login":"krmbn0576","id":20380362,"node_id":"MDQ6VXNlcjIwMzgwMzYy","avatar_url":"https://avatars0.githubusercontent.com/u/20380362?v=4","gravatar_id":"","url":"https://api.github.com/users/krmbn0576","html_url":"https://github.com/krmbn0576","followers_url":"https://api.github.com/users/krmbn0576/followers","following_url":"https://api.github.com/users/krmbn0576/following{/other_user}","gists_url":"https://api.github.com/users/krmbn0576/gists{/gist_id}","starred_url":"https://api.github.com/users/krmbn0576/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmbn0576/subscriptions","organizations_url":"https://api.github.com/users/krmbn0576/orgs","repos_url":"https://api.github.com/users/krmbn0576/repos","events_url":"https://api.github.com/users/krmbn0576/events{/privacy}","received_events_url":"https://api.github.com/users/krmbn0576/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T04:35:14Z","updated_at":"2018-10-11T04:35:14Z","author_association":"OWNER","body":"サンシロさんからDMでパフォーマンスに関するデータを頂き、誤差かそうでないか微妙なところという話をしました。\r\nそれから第３の案の複雑性に関する懸念を指摘され、その通りだと思ったのでコミュニティ版に第１の案でhotfixを出しました。\r\n\r\nhttps://github.com/rpgtkoolmv/corescript/pull/189"}}
{"actor":{"display_login":"krmbn0576"}}