{"action":"closed","number":41,"pull_request":{"url":"https://api.github.com/repos/farsightsec/dnstable/pulls/41","id":235663480,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjYzNDgw","html_url":"https://github.com/farsightsec/dnstable/pull/41","diff_url":"https://github.com/farsightsec/dnstable/pull/41.diff","patch_url":"https://github.com/farsightsec/dnstable/pull/41.patch","issue_url":"https://api.github.com/repos/farsightsec/dnstable/issues/41","number":41,"state":"closed","locked":false,"title":"Bug fix: dnsdb api raw lookup with rrtype.","user":{"login":"djw1149","id":4869340,"node_id":"MDQ6VXNlcjQ4NjkzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/4869340?v=4","gravatar_id":"","url":"https://api.github.com/users/djw1149","html_url":"https://github.com/djw1149","followers_url":"https://api.github.com/users/djw1149/followers","following_url":"https://api.github.com/users/djw1149/following{/other_user}","gists_url":"https://api.github.com/users/djw1149/gists{/gist_id}","starred_url":"https://api.github.com/users/djw1149/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djw1149/subscriptions","organizations_url":"https://api.github.com/users/djw1149/orgs","repos_url":"https://api.github.com/users/djw1149/repos","events_url":"https://api.github.com/users/djw1149/events{/privacy}","received_events_url":"https://api.github.com/users/djw1149/received_events","type":"User","site_admin":false},"body":"For rdata raw queries, do not append rrtype to the raw data.  The query will filter on rrtype on output.  Here is an example of the bug fix in action:\r\n\r\nUsing the \"tests\" directory's mtbl file:\r\n`$ export DNSTABLE_FNAME=.../tests/test-dns.mtbl`\r\nWithout specifying an rrtype:\r\n```\r\n$ ./src/dnstable_lookup rdata raw 00 \r\n_ldap._tcp.example.com. IN SRV 10 1 389 ldap.example.com.\r\nexample.com. IN MX 10 mail.example.com.\r\nexample.com. IN MX 20 mail2.example.com.\r\n;;; Dumped 3 entries.\r\n```\r\nUsing the original version of the code:\r\n```\r\n$ /usr/local/bin/dnstable_lookup rdata raw 00 SRV\r\n;;; Dumped 0 entries.\r\n```\r\nWith the bug fix:\r\n```\r\n$ ./src/dnstable_lookup rdata raw 00 SRV\r\n_ldap._tcp.example.com. IN SRV 10 1 389 ldap.example.com.\r\n;;; Dumped 1 entries.\r\n$ ./src/dnstable_lookup rdata raw 00 MX\r\nexample.com. IN MX 10 mail.example.com.\r\nexample.com. IN MX 20 mail2.example.com.\r\n;;; Dumped 2 entries.\r\n```","created_at":"2018-12-04T02:58:48Z","updated_at":"2018-12-04T18:57:30Z","closed_at":"2018-12-04T18:57:30Z","merged_at":"2018-12-04T18:57:30Z","merge_commit_sha":"03c354b1b28d7e2ee76c22b3a9ac8681c0b9aa3d","assignee":{"login":"cmikk","id":619909,"node_id":"MDQ6VXNlcjYxOTkwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/619909?v=4","gravatar_id":"","url":"https://api.github.com/users/cmikk","html_url":"https://github.com/cmikk","followers_url":"https://api.github.com/users/cmikk/followers","following_url":"https://api.github.com/users/cmikk/following{/other_user}","gists_url":"https://api.github.com/users/cmikk/gists{/gist_id}","starred_url":"https://api.github.com/users/cmikk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmikk/subscriptions","organizations_url":"https://api.github.com/users/cmikk/orgs","repos_url":"https://api.github.com/users/cmikk/repos","events_url":"https://api.github.com/users/cmikk/events{/privacy}","received_events_url":"https://api.github.com/users/cmikk/received_events","type":"User","site_admin":false},"assignees":[{"login":"cmikk","id":619909,"node_id":"MDQ6VXNlcjYxOTkwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/619909?v=4","gravatar_id":"","url":"https://api.github.com/users/cmikk","html_url":"https://github.com/cmikk","followers_url":"https://api.github.com/users/cmikk/followers","following_url":"https://api.github.com/users/cmikk/following{/other_user}","gists_url":"https://api.github.com/users/cmikk/gists{/gist_id}","starred_url":"https://api.github.com/users/cmikk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmikk/subscriptions","organizations_url":"https://api.github.com/users/cmikk/orgs","repos_url":"https://api.github.com/users/cmikk/repos","events_url":"https://api.github.com/users/cmikk/events{/privacy}","received_events_url":"https://api.github.com/users/cmikk/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cmikk","id":619909,"node_id":"MDQ6VXNlcjYxOTkwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/619909?v=4","gravatar_id":"","url":"https://api.github.com/users/cmikk","html_url":"https://github.com/cmikk","followers_url":"https://api.github.com/users/cmikk/followers","following_url":"https://api.github.com/users/cmikk/following{/other_user}","gists_url":"https://api.github.com/users/cmikk/gists{/gist_id}","starred_url":"https://api.github.com/users/cmikk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmikk/subscriptions","organizations_url":"https://api.github.com/users/cmikk/orgs","repos_url":"https://api.github.com/users/cmikk/repos","events_url":"https://api.github.com/users/cmikk/events{/privacy}","received_events_url":"https://api.github.com/users/cmikk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/farsightsec/dnstable/pulls/41/commits","review_comments_url":"https://api.github.com/repos/farsightsec/dnstable/pulls/41/comments","review_comment_url":"https://api.github.com/repos/farsightsec/dnstable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/farsightsec/dnstable/issues/41/comments","statuses_url":"https://api.github.com/repos/farsightsec/dnstable/statuses/e06515018abc230231ebd8ef8c9a1e869ab5aad5","head":{"label":"farsightsec:Fix_raw_rrtype","ref":"Fix_raw_rrtype","sha":"e06515018abc230231ebd8ef8c9a1e869ab5aad5","user":{"login":"farsightsec","id":5004096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMDQwOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5004096?v=4","gravatar_id":"","url":"https://api.github.com/users/farsightsec","html_url":"https://github.com/farsightsec","followers_url":"https://api.github.com/users/farsightsec/followers","following_url":"https://api.github.com/users/farsightsec/following{/other_user}","gists_url":"https://api.github.com/users/farsightsec/gists{/gist_id}","starred_url":"https://api.github.com/users/farsightsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farsightsec/subscriptions","organizations_url":"https://api.github.com/users/farsightsec/orgs","repos_url":"https://api.github.com/users/farsightsec/repos","events_url":"https://api.github.com/users/farsightsec/events{/privacy}","received_events_url":"https://api.github.com/users/farsightsec/received_events","type":"Organization","site_admin":false},"repo":{"id":16125649,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEyNTY0OQ==","name":"dnstable","full_name":"farsightsec/dnstable","private":false,"owner":{"login":"farsightsec","id":5004096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMDQwOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5004096?v=4","gravatar_id":"","url":"https://api.github.com/users/farsightsec","html_url":"https://github.com/farsightsec","followers_url":"https://api.github.com/users/farsightsec/followers","following_url":"https://api.github.com/users/farsightsec/following{/other_user}","gists_url":"https://api.github.com/users/farsightsec/gists{/gist_id}","starred_url":"https://api.github.com/users/farsightsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farsightsec/subscriptions","organizations_url":"https://api.github.com/users/farsightsec/orgs","repos_url":"https://api.github.com/users/farsightsec/repos","events_url":"https://api.github.com/users/farsightsec/events{/privacy}","received_events_url":"https://api.github.com/users/farsightsec/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/farsightsec/dnstable","description":"encoding format, library, and utilities for passive DNS data","fork":false,"url":"https://api.github.com/repos/farsightsec/dnstable","forks_url":"https://api.github.com/repos/farsightsec/dnstable/forks","keys_url":"https://api.github.com/repos/farsightsec/dnstable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/farsightsec/dnstable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/farsightsec/dnstable/teams","hooks_url":"https://api.github.com/repos/farsightsec/dnstable/hooks","issue_events_url":"https://api.github.com/repos/farsightsec/dnstable/issues/events{/number}","events_url":"https://api.github.com/repos/farsightsec/dnstable/events","assignees_url":"https://api.github.com/repos/farsightsec/dnstable/assignees{/user}","branches_url":"https://api.github.com/repos/farsightsec/dnstable/branches{/branch}","tags_url":"https://api.github.com/repos/farsightsec/dnstable/tags","blobs_url":"https://api.github.com/repos/farsightsec/dnstable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/farsightsec/dnstable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/farsightsec/dnstable/git/refs{/sha}","trees_url":"https://api.github.com/repos/farsightsec/dnstable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/farsightsec/dnstable/statuses/{sha}","languages_url":"https://api.github.com/repos/farsightsec/dnstable/languages","stargazers_url":"https://api.github.com/repos/farsightsec/dnstable/stargazers","contributors_url":"https://api.github.com/repos/farsightsec/dnstable/contributors","subscribers_url":"https://api.github.com/repos/farsightsec/dnstable/subscribers","subscription_url":"https://api.github.com/repos/farsightsec/dnstable/subscription","commits_url":"https://api.github.com/repos/farsightsec/dnstable/commits{/sha}","git_commits_url":"https://api.github.com/repos/farsightsec/dnstable/git/commits{/sha}","comments_url":"https://api.github.com/repos/farsightsec/dnstable/comments{/number}","issue_comment_url":"https://api.github.com/repos/farsightsec/dnstable/issues/comments{/number}","contents_url":"https://api.github.com/repos/farsightsec/dnstable/contents/{+path}","compare_url":"https://api.github.com/repos/farsightsec/dnstable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/farsightsec/dnstable/merges","archive_url":"https://api.github.com/repos/farsightsec/dnstable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/farsightsec/dnstable/downloads","issues_url":"https://api.github.com/repos/farsightsec/dnstable/issues{/number}","pulls_url":"https://api.github.com/repos/farsightsec/dnstable/pulls{/number}","milestones_url":"https://api.github.com/repos/farsightsec/dnstable/milestones{/number}","notifications_url":"https://api.github.com/repos/farsightsec/dnstable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/farsightsec/dnstable/labels{/name}","releases_url":"https://api.github.com/repos/farsightsec/dnstable/releases{/id}","deployments_url":"https://api.github.com/repos/farsightsec/dnstable/deployments","created_at":"2014-01-22T02:10:28Z","updated_at":"2018-11-24T15:42:28Z","pushed_at":"2018-12-04T18:57:30Z","git_url":"git://github.com/farsightsec/dnstable.git","ssh_url":"git@github.com:farsightsec/dnstable.git","clone_url":"https://github.com/farsightsec/dnstable.git","svn_url":"https://github.com/farsightsec/dnstable","homepage":null,"size":793,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":2,"watchers":13,"default_branch":"master"}},"base":{"label":"farsightsec:next","ref":"next","sha":"a6b93734dd894b80eb4ae9b88d1e565f0803d6c7","user":{"login":"farsightsec","id":5004096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMDQwOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5004096?v=4","gravatar_id":"","url":"https://api.github.com/users/farsightsec","html_url":"https://github.com/farsightsec","followers_url":"https://api.github.com/users/farsightsec/followers","following_url":"https://api.github.com/users/farsightsec/following{/other_user}","gists_url":"https://api.github.com/users/farsightsec/gists{/gist_id}","starred_url":"https://api.github.com/users/farsightsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farsightsec/subscriptions","organizations_url":"https://api.github.com/users/farsightsec/orgs","repos_url":"https://api.github.com/users/farsightsec/repos","events_url":"https://api.github.com/users/farsightsec/events{/privacy}","received_events_url":"https://api.github.com/users/farsightsec/received_events","type":"Organization","site_admin":false},"repo":{"id":16125649,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEyNTY0OQ==","name":"dnstable","full_name":"farsightsec/dnstable","private":false,"owner":{"login":"farsightsec","id":5004096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMDQwOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5004096?v=4","gravatar_id":"","url":"https://api.github.com/users/farsightsec","html_url":"https://github.com/farsightsec","followers_url":"https://api.github.com/users/farsightsec/followers","following_url":"https://api.github.com/users/farsightsec/following{/other_user}","gists_url":"https://api.github.com/users/farsightsec/gists{/gist_id}","starred_url":"https://api.github.com/users/farsightsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farsightsec/subscriptions","organizations_url":"https://api.github.com/users/farsightsec/orgs","repos_url":"https://api.github.com/users/farsightsec/repos","events_url":"https://api.github.com/users/farsightsec/events{/privacy}","received_events_url":"https://api.github.com/users/farsightsec/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/farsightsec/dnstable","description":"encoding format, library, and utilities for passive DNS data","fork":false,"url":"https://api.github.com/repos/farsightsec/dnstable","forks_url":"https://api.github.com/repos/farsightsec/dnstable/forks","keys_url":"https://api.github.com/repos/farsightsec/dnstable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/farsightsec/dnstable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/farsightsec/dnstable/teams","hooks_url":"https://api.github.com/repos/farsightsec/dnstable/hooks","issue_events_url":"https://api.github.com/repos/farsightsec/dnstable/issues/events{/number}","events_url":"https://api.github.com/repos/farsightsec/dnstable/events","assignees_url":"https://api.github.com/repos/farsightsec/dnstable/assignees{/user}","branches_url":"https://api.github.com/repos/farsightsec/dnstable/branches{/branch}","tags_url":"https://api.github.com/repos/farsightsec/dnstable/tags","blobs_url":"https://api.github.com/repos/farsightsec/dnstable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/farsightsec/dnstable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/farsightsec/dnstable/git/refs{/sha}","trees_url":"https://api.github.com/repos/farsightsec/dnstable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/farsightsec/dnstable/statuses/{sha}","languages_url":"https://api.github.com/repos/farsightsec/dnstable/languages","stargazers_url":"https://api.github.com/repos/farsightsec/dnstable/stargazers","contributors_url":"https://api.github.com/repos/farsightsec/dnstable/contributors","subscribers_url":"https://api.github.com/repos/farsightsec/dnstable/subscribers","subscription_url":"https://api.github.com/repos/farsightsec/dnstable/subscription","commits_url":"https://api.github.com/repos/farsightsec/dnstable/commits{/sha}","git_commits_url":"https://api.github.com/repos/farsightsec/dnstable/git/commits{/sha}","comments_url":"https://api.github.com/repos/farsightsec/dnstable/comments{/number}","issue_comment_url":"https://api.github.com/repos/farsightsec/dnstable/issues/comments{/number}","contents_url":"https://api.github.com/repos/farsightsec/dnstable/contents/{+path}","compare_url":"https://api.github.com/repos/farsightsec/dnstable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/farsightsec/dnstable/merges","archive_url":"https://api.github.com/repos/farsightsec/dnstable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/farsightsec/dnstable/downloads","issues_url":"https://api.github.com/repos/farsightsec/dnstable/issues{/number}","pulls_url":"https://api.github.com/repos/farsightsec/dnstable/pulls{/number}","milestones_url":"https://api.github.com/repos/farsightsec/dnstable/milestones{/number}","notifications_url":"https://api.github.com/repos/farsightsec/dnstable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/farsightsec/dnstable/labels{/name}","releases_url":"https://api.github.com/repos/farsightsec/dnstable/releases{/id}","deployments_url":"https://api.github.com/repos/farsightsec/dnstable/deployments","created_at":"2014-01-22T02:10:28Z","updated_at":"2018-11-24T15:42:28Z","pushed_at":"2018-12-04T18:57:30Z","git_url":"git://github.com/farsightsec/dnstable.git","ssh_url":"git@github.com:farsightsec/dnstable.git","clone_url":"https://github.com/farsightsec/dnstable.git","svn_url":"https://github.com/farsightsec/dnstable","homepage":null,"size":793,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":2,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/farsightsec/dnstable/pulls/41"},"html":{"href":"https://github.com/farsightsec/dnstable/pull/41"},"issue":{"href":"https://api.github.com/repos/farsightsec/dnstable/issues/41"},"comments":{"href":"https://api.github.com/repos/farsightsec/dnstable/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/farsightsec/dnstable/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/farsightsec/dnstable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/farsightsec/dnstable/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/farsightsec/dnstable/statuses/e06515018abc230231ebd8ef8c9a1e869ab5aad5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cmikk","id":619909,"node_id":"MDQ6VXNlcjYxOTkwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/619909?v=4","gravatar_id":"","url":"https://api.github.com/users/cmikk","html_url":"https://github.com/cmikk","followers_url":"https://api.github.com/users/cmikk/followers","following_url":"https://api.github.com/users/cmikk/following{/other_user}","gists_url":"https://api.github.com/users/cmikk/gists{/gist_id}","starred_url":"https://api.github.com/users/cmikk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmikk/subscriptions","organizations_url":"https://api.github.com/users/cmikk/orgs","repos_url":"https://api.github.com/users/cmikk/repos","events_url":"https://api.github.com/users/cmikk/events{/privacy}","received_events_url":"https://api.github.com/users/cmikk/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":9,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"cmikk"}}