{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/209986065","pull_request_review_id":146106922,"id":209986065,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTk4NjA2NQ==","diff_hunk":"@@ -203,27 +270,17 @@ private void createJmDNSByAddress(InetAddress address) {\n \n     @Override\n     public void onChanged(List<CidrAddress> added, List<CidrAddress> removed) {\n-        // remove jmdns instances that no longer exist due to interface changed\n-        for (CidrAddress cidrAddress : removed) {\n-            InetAddress inetAddr = cidrAddress.getAddress();\n-            if (jmdnsInstances.containsKey(inetAddr)) {\n-                JmDNS jmdns = jmdnsInstances.get(inetAddr);\n-                closeQuietly(jmdns);\n-                jmdnsInstances.remove(inetAddr);\n-                logger.debug(\"mDNS service has been removed ({} for IP {})\", jmdns.getName(),\n-                        inetAddr.getHostAddress());\n-            }\n-        }\n+        logger.debug(\"ip address change: added {}, removed {}\", added, removed);\n+        deactivate();\n+        start();\n+    }\n \n-        // add the new addresses, just like activate\n-        for (CidrAddress cidrAddress : added) {\n-            InetAddress address = cidrAddress.getAddress();\n+    @Reference(cardinality = ReferenceCardinality.MANDATORY)","path":"bundles/io/org.eclipse.smarthome.io.transport.mdns/src/main/java/org/eclipse/smarthome/io/transport/mdns/internal/MDNSClientImpl.java","position":192,"original_position":192,"commit_id":"6b5898f513c9b65f73cb64f5508df95318e3278b","original_commit_id":"6b5898f513c9b65f73cb64f5508df95318e3278b","user":{"login":"sobimibos","id":18039078,"node_id":"MDQ6VXNlcjE4MDM5MDc4","avatar_url":"https://avatars1.githubusercontent.com/u/18039078?v=4","gravatar_id":"","url":"https://api.github.com/users/sobimibos","html_url":"https://github.com/sobimibos","followers_url":"https://api.github.com/users/sobimibos/followers","following_url":"https://api.github.com/users/sobimibos/following{/other_user}","gists_url":"https://api.github.com/users/sobimibos/gists{/gist_id}","starred_url":"https://api.github.com/users/sobimibos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobimibos/subscriptions","organizations_url":"https://api.github.com/users/sobimibos/orgs","repos_url":"https://api.github.com/users/sobimibos/repos","events_url":"https://api.github.com/users/sobimibos/events{/privacy}","received_events_url":"https://api.github.com/users/sobimibos/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-08-14T15:00:12Z","updated_at":"2018-08-14T15:00:12Z","html_url":"https://github.com/eclipse/smarthome/pull/6005#discussion_r209986065","pull_request_url":"https://api.github.com/repos/eclipse/smarthome/pulls/6005","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/209986065"},"html":{"href":"https://github.com/eclipse/smarthome/pull/6005#discussion_r209986065"},"pull_request":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/6005"}},"in_reply_to_id":209920577},"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/6005","id":205986622,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTg2NjIy","html_url":"https://github.com/eclipse/smarthome/pull/6005","diff_url":"https://github.com/eclipse/smarthome/pull/6005.diff","patch_url":"https://github.com/eclipse/smarthome/pull/6005.patch","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/6005","number":6005,"state":"open","locked":false,"title":"make ip address usage configurable","user":{"login":"sobimibos","id":18039078,"node_id":"MDQ6VXNlcjE4MDM5MDc4","avatar_url":"https://avatars1.githubusercontent.com/u/18039078?v=4","gravatar_id":"","url":"https://api.github.com/users/sobimibos","html_url":"https://github.com/sobimibos","followers_url":"https://api.github.com/users/sobimibos/followers","following_url":"https://api.github.com/users/sobimibos/following{/other_user}","gists_url":"https://api.github.com/users/sobimibos/gists{/gist_id}","starred_url":"https://api.github.com/users/sobimibos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobimibos/subscriptions","organizations_url":"https://api.github.com/users/sobimibos/orgs","repos_url":"https://api.github.com/users/sobimibos/repos","events_url":"https://api.github.com/users/sobimibos/events{/privacy}","received_events_url":"https://api.github.com/users/sobimibos/received_events","type":"User","site_admin":false},"body":"I introduced two config options:\r\n- useOnlyOneAddress. \r\nThis limits the number of ip addresses to listen to to one per interface and family, so at most one IPv4 and one IPv6 address. This avoids the massive creation of JmDNS instances on interfaces with especially multiple IPv6 adresses. Having multiple IPv6 addresses is common for normal installations, I have seen devices with up to nine IPv6 addresses. This has no impact on discovery, because the IP address is not used for listening, the multicast addresses are used instead. Affects service registration, because services are registered only to one address per interface. This should cause no problems, because all addresses are valid for use.\r\n- ignoreIPv6\r\nThis causes IPv6 addresses to be completely ignored. May be used to avoid problems with devices, which have a broken IPv6 implementation.\r\n\r\nSigned-off-by: Michael Bock <mbock@gmxpro.de>","created_at":"2018-08-03T10:15:13Z","updated_at":"2018-08-14T15:00:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7539fae044c9f0c188018f9c1c5cf545e0ca4d4f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/smarthome/pulls/6005/commits","review_comments_url":"https://api.github.com/repos/eclipse/smarthome/pulls/6005/comments","review_comment_url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/6005/comments","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/6b5898f513c9b65f73cb64f5508df95318e3278b","head":{"label":"sobimibos:master","ref":"master","sha":"6b5898f513c9b65f73cb64f5508df95318e3278b","user":{"login":"sobimibos","id":18039078,"node_id":"MDQ6VXNlcjE4MDM5MDc4","avatar_url":"https://avatars1.githubusercontent.com/u/18039078?v=4","gravatar_id":"","url":"https://api.github.com/users/sobimibos","html_url":"https://github.com/sobimibos","followers_url":"https://api.github.com/users/sobimibos/followers","following_url":"https://api.github.com/users/sobimibos/following{/other_user}","gists_url":"https://api.github.com/users/sobimibos/gists{/gist_id}","starred_url":"https://api.github.com/users/sobimibos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobimibos/subscriptions","organizations_url":"https://api.github.com/users/sobimibos/orgs","repos_url":"https://api.github.com/users/sobimibos/repos","events_url":"https://api.github.com/users/sobimibos/events{/privacy}","received_events_url":"https://api.github.com/users/sobimibos/received_events","type":"User","site_admin":false},"repo":{"id":106546304,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY1NDYzMDQ=","name":"smarthome","full_name":"sobimibos/smarthome","owner":{"login":"sobimibos","id":18039078,"node_id":"MDQ6VXNlcjE4MDM5MDc4","avatar_url":"https://avatars1.githubusercontent.com/u/18039078?v=4","gravatar_id":"","url":"https://api.github.com/users/sobimibos","html_url":"https://github.com/sobimibos","followers_url":"https://api.github.com/users/sobimibos/followers","following_url":"https://api.github.com/users/sobimibos/following{/other_user}","gists_url":"https://api.github.com/users/sobimibos/gists{/gist_id}","starred_url":"https://api.github.com/users/sobimibos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobimibos/subscriptions","organizations_url":"https://api.github.com/users/sobimibos/orgs","repos_url":"https://api.github.com/users/sobimibos/repos","events_url":"https://api.github.com/users/sobimibos/events{/privacy}","received_events_url":"https://api.github.com/users/sobimibos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sobimibos/smarthome","description":"Eclipse SmartHome™ project","fork":true,"url":"https://api.github.com/repos/sobimibos/smarthome","forks_url":"https://api.github.com/repos/sobimibos/smarthome/forks","keys_url":"https://api.github.com/repos/sobimibos/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sobimibos/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sobimibos/smarthome/teams","hooks_url":"https://api.github.com/repos/sobimibos/smarthome/hooks","issue_events_url":"https://api.github.com/repos/sobimibos/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/sobimibos/smarthome/events","assignees_url":"https://api.github.com/repos/sobimibos/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/sobimibos/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/sobimibos/smarthome/tags","blobs_url":"https://api.github.com/repos/sobimibos/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sobimibos/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sobimibos/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/sobimibos/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sobimibos/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/sobimibos/smarthome/languages","stargazers_url":"https://api.github.com/repos/sobimibos/smarthome/stargazers","contributors_url":"https://api.github.com/repos/sobimibos/smarthome/contributors","subscribers_url":"https://api.github.com/repos/sobimibos/smarthome/subscribers","subscription_url":"https://api.github.com/repos/sobimibos/smarthome/subscription","commits_url":"https://api.github.com/repos/sobimibos/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/sobimibos/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/sobimibos/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/sobimibos/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/sobimibos/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/sobimibos/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sobimibos/smarthome/merges","archive_url":"https://api.github.com/repos/sobimibos/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sobimibos/smarthome/downloads","issues_url":"https://api.github.com/repos/sobimibos/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/sobimibos/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/sobimibos/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/sobimibos/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sobimibos/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/sobimibos/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/sobimibos/smarthome/deployments","created_at":"2017-10-11T11:38:28Z","updated_at":"2018-08-13T08:53:30Z","pushed_at":"2018-08-13T08:53:28Z","git_url":"git://github.com/sobimibos/smarthome.git","ssh_url":"git@github.com:sobimibos/smarthome.git","clone_url":"https://github.com/sobimibos/smarthome.git","svn_url":"https://github.com/sobimibos/smarthome","homepage":"https://www.eclipse.org/smarthome/","size":52657,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"4e91c13e1be8cef932f39094b785b4dcf182b993","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15778981,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3ODk4MQ==","name":"smarthome","full_name":"eclipse/smarthome","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/smarthome","description":"Eclipse SmartHome™ project","fork":false,"url":"https://api.github.com/repos/eclipse/smarthome","forks_url":"https://api.github.com/repos/eclipse/smarthome/forks","keys_url":"https://api.github.com/repos/eclipse/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/smarthome/teams","hooks_url":"https://api.github.com/repos/eclipse/smarthome/hooks","issue_events_url":"https://api.github.com/repos/eclipse/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/smarthome/events","assignees_url":"https://api.github.com/repos/eclipse/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/smarthome/tags","blobs_url":"https://api.github.com/repos/eclipse/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/smarthome/languages","stargazers_url":"https://api.github.com/repos/eclipse/smarthome/stargazers","contributors_url":"https://api.github.com/repos/eclipse/smarthome/contributors","subscribers_url":"https://api.github.com/repos/eclipse/smarthome/subscribers","subscription_url":"https://api.github.com/repos/eclipse/smarthome/subscription","commits_url":"https://api.github.com/repos/eclipse/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/smarthome/merges","archive_url":"https://api.github.com/repos/eclipse/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/smarthome/downloads","issues_url":"https://api.github.com/repos/eclipse/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/smarthome/deployments","created_at":"2014-01-09T20:47:19Z","updated_at":"2018-08-14T14:56:25Z","pushed_at":"2018-08-14T14:56:16Z","git_url":"git://github.com/eclipse/smarthome.git","ssh_url":"git@github.com:eclipse/smarthome.git","clone_url":"https://github.com/eclipse/smarthome.git","svn_url":"https://github.com/eclipse/smarthome","homepage":"https://www.eclipse.org/smarthome/","size":58688,"stargazers_count":733,"watchers_count":733,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":717,"mirror_url":null,"archived":false,"open_issues_count":407,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":717,"open_issues":407,"watchers":733,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/6005"},"html":{"href":"https://github.com/eclipse/smarthome/pull/6005"},"issue":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/6005"},"comments":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/6005/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/6005/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/6005/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/smarthome/statuses/6b5898f513c9b65f73cb64f5508df95318e3278b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sobimibos"}}