{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/25380","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25380/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25380/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25380/events","html_url":"https://github.com/cms-sw/cmssw/pull/25380","id":385957334,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODEwNjAw","number":25380,"title":"L1 prefiring weight producer ","user":{"login":"lathomas","id":4995867,"node_id":"MDQ6VXNlcjQ5OTU4Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/4995867?v=4","gravatar_id":"","url":"https://api.github.com/users/lathomas","html_url":"https://github.com/lathomas","followers_url":"https://api.github.com/users/lathomas/followers","following_url":"https://api.github.com/users/lathomas/following{/other_user}","gists_url":"https://api.github.com/users/lathomas/gists{/gist_id}","starred_url":"https://api.github.com/users/lathomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lathomas/subscriptions","organizations_url":"https://api.github.com/users/lathomas/orgs","repos_url":"https://api.github.com/users/lathomas/repos","events_url":"https://api.github.com/users/lathomas/events{/privacy}","received_events_url":"https://api.github.com/users/lathomas/received_events","type":"User","site_admin":false},"labels":[{"id":52881179,"node_id":"MDU6TGFiZWw1Mjg4MTE3OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04","default":false},{"id":673935056,"node_id":"MDU6TGFiZWw2NzM5MzUwNTY=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-pending","name":"code-checks-pending","color":"fbca04","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"node_id":"MDU6TGFiZWw1MjgyMDAxMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131152,"node_id":"MDU6TGFiZWw1NjEzMTE1Mg==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/78","html_url":"https://github.com/cms-sw/cmssw/milestone/78","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/78/labels","id":3727036,"node_id":"MDk6TWlsZXN0b25lMzcyNzAzNg==","number":78,"title":"CMSSW_10_4_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":442,"state":"open","created_at":"2018-10-10T09:27:21Z","updated_at":"2018-12-18T08:38:44Z","due_on":null,"closed_at":null},"comments":51,"created_at":"2018-11-29T22:37:24Z","updated_at":"2018-12-18T08:40:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25380","html_url":"https://github.com/cms-sw/cmssw/pull/25380","diff_url":"https://github.com/cms-sw/cmssw/pull/25380.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/25380.patch"},"body":"Dear CMSSW managers/PR reviewers, \r\n\r\nThis PR contains an EDProducer computing weights associated to the L1 ECAL prefiring issue that affected 2016 and 2017 data. \r\nSince the effect is not present in MC, the proposed solution is to reweight simulations by those weights. \r\nI add some links to documentation at the end of this post for more information.  \r\n\r\nThe code is a producer returning three double (central, up/down weights). The code loops over all photons and jets found in the event and multiplies their prefiring probabilities. \r\n\r\nI expect the PR to need a bit of iteration before being approved. \r\nIn particular, I would greatly appreciate your suggestions regarding the following points: \r\n\r\n- Can you please provide advise regarding the code location? I created a new package but it can/should maybe enter an already existing one?\r\n- The code relies on prefiring maps stored as TH2F in a root file. I'm not sure this is allowed... If not, can you suggest a proper format? (sorry for my ignorance). \r\n\r\nPlease let me know if anything else is unclear,\r\n\r\nThanks a lot, \r\n\r\nLaurent  \r\n\r\n***Documentation***\r\n-Talk at CMS week about prefiring: \r\nhttps://indico.cern.ch/event/704625/contributions/3164334/attachments/1726987/2790093/prefiringupdateCMSweek.pdf\r\n-Prefiring discussion at the XPOG forum: \r\nhttps://indico.cern.ch/event/764279/\r\n-Twiki describing how to run the producer:\r\nhttps://twiki.cern.ch/twiki/bin/viewauth/CMS/L1ECALPrefiringWeightRecipe\r\n-L1 prefiring maps per object:\r\nhttps://lathomas.web.cern.ch/lathomas/TSGStuff/L1Prefiring/PrefiringMaps_2016and2017/\r\n-Validation plots: \r\nhttps://twiki.cern.ch/twiki/pub/CMS/L1ECALPrefiringWeightRecipe/prefiring_producervalidation.pdf\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/448140364","html_url":"https://github.com/cms-sw/cmssw/pull/25380#issuecomment-448140364","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25380","id":448140364,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODE0MDM2NA==","user":{"login":"cmsbuild","id":4170616,"node_id":"MDQ6VXNlcjQxNzA2MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T08:40:18Z","updated_at":"2018-12-18T08:40:18Z","author_association":"CONTRIBUTOR","body":"+code-checks\n\nLogs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25380/7681"}}
{"actor":{"display_login":"cmsbuild"}}