{"action":"created","issue":{"url":"https://api.github.com/repos/m4b/scroll/issues/45","repository_url":"https://api.github.com/repos/m4b/scroll","labels_url":"https://api.github.com/repos/m4b/scroll/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/m4b/scroll/issues/45/comments","events_url":"https://api.github.com/repos/m4b/scroll/issues/45/events","html_url":"https://github.com/m4b/scroll/pull/45","id":371347949,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODE1MjU3","number":45,"title":"Remove generic {Size,Units} in favor of usize","user":{"login":"willglynn","id":118362,"node_id":"MDQ6VXNlcjExODM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/118362?v=4","gravatar_id":"","url":"https://api.github.com/users/willglynn","html_url":"https://github.com/willglynn","followers_url":"https://api.github.com/users/willglynn/followers","following_url":"https://api.github.com/users/willglynn/following{/other_user}","gists_url":"https://api.github.com/users/willglynn/gists{/gist_id}","starred_url":"https://api.github.com/users/willglynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willglynn/subscriptions","organizations_url":"https://api.github.com/users/willglynn/orgs","repos_url":"https://api.github.com/users/willglynn/repos","events_url":"https://api.github.com/users/willglynn/events{/privacy}","received_events_url":"https://api.github.com/users/willglynn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-18T03:31:53Z","updated_at":"2018-10-19T03:52:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/m4b/scroll/pulls/45","html_url":"https://github.com/m4b/scroll/pull/45","diff_url":"https://github.com/m4b/scroll/pull/45.diff","patch_url":"https://github.com/m4b/scroll/pull/45.patch"},"body":"This PR addresses https://github.com/m4b/scroll/issues/37, globally squishing `{Size,Units}` into `usize`. This is a breaking change which warrants careful consideration, but… tests pass.\r\n\r\nCorresponding `scroll_derive` PR: https://github.com/m4b/scroll_derive/pull/19"},"comment":{"url":"https://api.github.com/repos/m4b/scroll/issues/comments/431236881","html_url":"https://github.com/m4b/scroll/pull/45#issuecomment-431236881","issue_url":"https://api.github.com/repos/m4b/scroll/issues/45","id":431236881,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTIzNjg4MQ==","user":{"login":"willglynn","id":118362,"node_id":"MDQ6VXNlcjExODM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/118362?v=4","gravatar_id":"","url":"https://api.github.com/users/willglynn","html_url":"https://github.com/willglynn","followers_url":"https://api.github.com/users/willglynn/followers","following_url":"https://api.github.com/users/willglynn/following{/other_user}","gists_url":"https://api.github.com/users/willglynn/gists{/gist_id}","starred_url":"https://api.github.com/users/willglynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willglynn/subscriptions","organizations_url":"https://api.github.com/users/willglynn/orgs","repos_url":"https://api.github.com/users/willglynn/repos","events_url":"https://api.github.com/users/willglynn/events{/privacy}","received_events_url":"https://api.github.com/users/willglynn/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T03:52:51Z","updated_at":"2018-10-19T03:52:51Z","author_association":"NONE","body":"The only thing I can think of is this sacrifices the ability to scroll through 64-bit indexes on platforms where `usize` is 32 bits. This isn't as serious as it sounds since anyone using `#[derive(Pread)]` is scrolling through `&[u8]`s which are indexed by `usize` anyway.\r\n\r\nIn principle someone could be doing 64-bit offset math and then transforming that into `mmap()`ed `&[u8]`s pointing to different sections of a file or something _while also_ using their own handwritten `TryFromCtx`/`FromCtx` implementations, but that seems far fetched."}}
{"actor":{"display_login":"willglynn"}}