{"action":"created","comment":{"url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls/comments/233637301","pull_request_review_id":175097658,"id":233637301,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzYzNzMwMQ==","diff_hunk":"@@ -101,14 +115,32 @@ The following refers to preconditions that need to be met before running `botium\n * to run Botium tests: `botium-cli run`\n * To open up a browser UI with the test cases: `botium-cli emulator browser --convos=./spec/convo`\n \n-# Future Things to do\n-* Validate same city names and differents country pairings (E.g. Differentiate between Sydney Canada and Sydney Australia)\n-* When getting information about uplinks and appliances, we currently have it such that DialogFlow passes information back to the code here. This feels dirty, and we would ideally like to make it such that the information is stored on the server so that it can be retrieved there rather than having to pass it backwards and forwards. \n-\n-# Untested/Deprecated Functionalities:\n+## Untested/Deprecated Functionalities:\n The following actions have not been tested out and are deprecated. It has been left in the respository for future possible use:\n - Add site to wan\n - Add sites to wan\n - Clear sites\n - Create SSID\n - Create Zone\n+\n+# To Do\n+* Validate same city names and differents country pairings (E.g. Differentiate between Sydney Canada and Sydney Australia)\n+* When getting information about uplinks and appliances, we currently have it such that DialogFlow passes information back to the code here. This feels dirty, and we would ideally like to make it such that the information is stored on the server so that it can be retrieved there rather than having to pass it backwards and forwards. ","path":"README.md","position":102,"original_position":102,"commit_id":"37bf2ea83f84ef46a2b56f19929710fbb05130d6","original_commit_id":"37bf2ea83f84ef46a2b56f19929710fbb05130d6","user":{"login":"mirrexagon","id":1776903,"node_id":"MDQ6VXNlcjE3NzY5MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1776903?v=4","gravatar_id":"","url":"https://api.github.com/users/mirrexagon","html_url":"https://github.com/mirrexagon","followers_url":"https://api.github.com/users/mirrexagon/followers","following_url":"https://api.github.com/users/mirrexagon/following{/other_user}","gists_url":"https://api.github.com/users/mirrexagon/gists{/gist_id}","starred_url":"https://api.github.com/users/mirrexagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirrexagon/subscriptions","organizations_url":"https://api.github.com/users/mirrexagon/orgs","repos_url":"https://api.github.com/users/mirrexagon/repos","events_url":"https://api.github.com/users/mirrexagon/events{/privacy}","received_events_url":"https://api.github.com/users/mirrexagon/received_events","type":"User","site_admin":false},"body":"It took me a while to remember what this was referring to, it wasn't immediately clear to me. This is the thing where information is stored in this app between two actions, for choosing a specific uplink or appliance, right? Maybe explicitly mention that this app stores the list of appliances/uplinks so the user can choose one in a followup action.\r\n\r\nAlso, with \"we would ideally like to make it such that the information is stored on the server\", which server are you referring to?","created_at":"2018-11-14T22:01:15Z","updated_at":"2018-11-14T22:01:50Z","html_url":"https://github.com/narcs/steelconnect-dialogflow/pull/78#discussion_r233637301","pull_request_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls/78","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls/comments/233637301"},"html":{"href":"https://github.com/narcs/steelconnect-dialogflow/pull/78#discussion_r233637301"},"pull_request":{"href":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls/78","id":230799153,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNzk5MTUz","html_url":"https://github.com/narcs/steelconnect-dialogflow/pull/78","diff_url":"https://github.com/narcs/steelconnect-dialogflow/pull/78.diff","patch_url":"https://github.com/narcs/steelconnect-dialogflow/pull/78.patch","issue_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/issues/78","number":78,"state":"open","locked":false,"title":"Handover docs","user":{"login":"ameliang96","id":34373586,"node_id":"MDQ6VXNlcjM0MzczNTg2","avatar_url":"https://avatars1.githubusercontent.com/u/34373586?v=4","gravatar_id":"","url":"https://api.github.com/users/ameliang96","html_url":"https://github.com/ameliang96","followers_url":"https://api.github.com/users/ameliang96/followers","following_url":"https://api.github.com/users/ameliang96/following{/other_user}","gists_url":"https://api.github.com/users/ameliang96/gists{/gist_id}","starred_url":"https://api.github.com/users/ameliang96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ameliang96/subscriptions","organizations_url":"https://api.github.com/users/ameliang96/orgs","repos_url":"https://api.github.com/users/ameliang96/repos","events_url":"https://api.github.com/users/ameliang96/events{/privacy}","received_events_url":"https://api.github.com/users/ameliang96/received_events","type":"User","site_admin":false},"body":"Wrote handover documentation","created_at":"2018-11-14T11:21:02Z","updated_at":"2018-11-14T22:01:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01cb5155f8aadacd151887857f5f3314d5f88a9d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"caovinhlam","id":16044619,"node_id":"MDQ6VXNlcjE2MDQ0NjE5","avatar_url":"https://avatars0.githubusercontent.com/u/16044619?v=4","gravatar_id":"","url":"https://api.github.com/users/caovinhlam","html_url":"https://github.com/caovinhlam","followers_url":"https://api.github.com/users/caovinhlam/followers","following_url":"https://api.github.com/users/caovinhlam/following{/other_user}","gists_url":"https://api.github.com/users/caovinhlam/gists{/gist_id}","starred_url":"https://api.github.com/users/caovinhlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caovinhlam/subscriptions","organizations_url":"https://api.github.com/users/caovinhlam/orgs","repos_url":"https://api.github.com/users/caovinhlam/repos","events_url":"https://api.github.com/users/caovinhlam/events{/privacy}","received_events_url":"https://api.github.com/users/caovinhlam/received_events","type":"User","site_admin":false},{"login":"rpha6","id":17608634,"node_id":"MDQ6VXNlcjE3NjA4NjM0","avatar_url":"https://avatars2.githubusercontent.com/u/17608634?v=4","gravatar_id":"","url":"https://api.github.com/users/rpha6","html_url":"https://github.com/rpha6","followers_url":"https://api.github.com/users/rpha6/followers","following_url":"https://api.github.com/users/rpha6/following{/other_user}","gists_url":"https://api.github.com/users/rpha6/gists{/gist_id}","starred_url":"https://api.github.com/users/rpha6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpha6/subscriptions","organizations_url":"https://api.github.com/users/rpha6/orgs","repos_url":"https://api.github.com/users/rpha6/repos","events_url":"https://api.github.com/users/rpha6/events{/privacy}","received_events_url":"https://api.github.com/users/rpha6/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls/78/commits","review_comments_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls/78/comments","review_comment_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/issues/78/comments","statuses_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/statuses/37bf2ea83f84ef46a2b56f19929710fbb05130d6","head":{"label":"narcs:handover-docs","ref":"handover-docs","sha":"37bf2ea83f84ef46a2b56f19929710fbb05130d6","user":{"login":"narcs","id":37197226,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTk3MjI2","avatar_url":"https://avatars1.githubusercontent.com/u/37197226?v=4","gravatar_id":"","url":"https://api.github.com/users/narcs","html_url":"https://github.com/narcs","followers_url":"https://api.github.com/users/narcs/followers","following_url":"https://api.github.com/users/narcs/following{/other_user}","gists_url":"https://api.github.com/users/narcs/gists{/gist_id}","starred_url":"https://api.github.com/users/narcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narcs/subscriptions","organizations_url":"https://api.github.com/users/narcs/orgs","repos_url":"https://api.github.com/users/narcs/repos","events_url":"https://api.github.com/users/narcs/events{/privacy}","received_events_url":"https://api.github.com/users/narcs/received_events","type":"Organization","site_admin":false},"repo":{"id":125585198,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU1ODUxOTg=","name":"steelconnect-dialogflow","full_name":"narcs/steelconnect-dialogflow","private":false,"owner":{"login":"narcs","id":37197226,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTk3MjI2","avatar_url":"https://avatars1.githubusercontent.com/u/37197226?v=4","gravatar_id":"","url":"https://api.github.com/users/narcs","html_url":"https://github.com/narcs","followers_url":"https://api.github.com/users/narcs/followers","following_url":"https://api.github.com/users/narcs/following{/other_user}","gists_url":"https://api.github.com/users/narcs/gists{/gist_id}","starred_url":"https://api.github.com/users/narcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narcs/subscriptions","organizations_url":"https://api.github.com/users/narcs/orgs","repos_url":"https://api.github.com/users/narcs/repos","events_url":"https://api.github.com/users/narcs/events{/privacy}","received_events_url":"https://api.github.com/users/narcs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/narcs/steelconnect-dialogflow","description":"Manage SteelConnect networks through natural language.","fork":true,"url":"https://api.github.com/repos/narcs/steelconnect-dialogflow","forks_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/forks","keys_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/teams","hooks_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/hooks","issue_events_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/issues/events{/number}","events_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/events","assignees_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/assignees{/user}","branches_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/branches{/branch}","tags_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/tags","blobs_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/statuses/{sha}","languages_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/languages","stargazers_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/stargazers","contributors_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/contributors","subscribers_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/subscribers","subscription_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/subscription","commits_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/contents/{+path}","compare_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/merges","archive_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/downloads","issues_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/issues{/number}","pulls_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls{/number}","milestones_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/milestones{/number}","notifications_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/labels{/name}","releases_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/releases{/id}","deployments_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/deployments","created_at":"2018-03-17T01:02:13Z","updated_at":"2018-10-16T22:56:04Z","pushed_at":"2018-11-14T11:21:03Z","git_url":"git://github.com/narcs/steelconnect-dialogflow.git","ssh_url":"git@github.com:narcs/steelconnect-dialogflow.git","clone_url":"https://github.com/narcs/steelconnect-dialogflow.git","svn_url":"https://github.com/narcs/steelconnect-dialogflow","homepage":"","size":2012,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":34,"license":null,"forks":2,"open_issues":34,"watchers":1,"default_branch":"master"}},"base":{"label":"narcs:master","ref":"master","sha":"5c8363d293f34ba084f353958b3db3118bfa11fb","user":{"login":"narcs","id":37197226,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTk3MjI2","avatar_url":"https://avatars1.githubusercontent.com/u/37197226?v=4","gravatar_id":"","url":"https://api.github.com/users/narcs","html_url":"https://github.com/narcs","followers_url":"https://api.github.com/users/narcs/followers","following_url":"https://api.github.com/users/narcs/following{/other_user}","gists_url":"https://api.github.com/users/narcs/gists{/gist_id}","starred_url":"https://api.github.com/users/narcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narcs/subscriptions","organizations_url":"https://api.github.com/users/narcs/orgs","repos_url":"https://api.github.com/users/narcs/repos","events_url":"https://api.github.com/users/narcs/events{/privacy}","received_events_url":"https://api.github.com/users/narcs/received_events","type":"Organization","site_admin":false},"repo":{"id":125585198,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU1ODUxOTg=","name":"steelconnect-dialogflow","full_name":"narcs/steelconnect-dialogflow","private":false,"owner":{"login":"narcs","id":37197226,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTk3MjI2","avatar_url":"https://avatars1.githubusercontent.com/u/37197226?v=4","gravatar_id":"","url":"https://api.github.com/users/narcs","html_url":"https://github.com/narcs","followers_url":"https://api.github.com/users/narcs/followers","following_url":"https://api.github.com/users/narcs/following{/other_user}","gists_url":"https://api.github.com/users/narcs/gists{/gist_id}","starred_url":"https://api.github.com/users/narcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narcs/subscriptions","organizations_url":"https://api.github.com/users/narcs/orgs","repos_url":"https://api.github.com/users/narcs/repos","events_url":"https://api.github.com/users/narcs/events{/privacy}","received_events_url":"https://api.github.com/users/narcs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/narcs/steelconnect-dialogflow","description":"Manage SteelConnect networks through natural language.","fork":true,"url":"https://api.github.com/repos/narcs/steelconnect-dialogflow","forks_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/forks","keys_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/teams","hooks_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/hooks","issue_events_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/issues/events{/number}","events_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/events","assignees_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/assignees{/user}","branches_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/branches{/branch}","tags_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/tags","blobs_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/statuses/{sha}","languages_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/languages","stargazers_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/stargazers","contributors_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/contributors","subscribers_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/subscribers","subscription_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/subscription","commits_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/contents/{+path}","compare_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/merges","archive_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/downloads","issues_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/issues{/number}","pulls_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls{/number}","milestones_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/milestones{/number}","notifications_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/labels{/name}","releases_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/releases{/id}","deployments_url":"https://api.github.com/repos/narcs/steelconnect-dialogflow/deployments","created_at":"2018-03-17T01:02:13Z","updated_at":"2018-10-16T22:56:04Z","pushed_at":"2018-11-14T11:21:03Z","git_url":"git://github.com/narcs/steelconnect-dialogflow.git","ssh_url":"git@github.com:narcs/steelconnect-dialogflow.git","clone_url":"https://github.com/narcs/steelconnect-dialogflow.git","svn_url":"https://github.com/narcs/steelconnect-dialogflow","homepage":"","size":2012,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":34,"license":null,"forks":2,"open_issues":34,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls/78"},"html":{"href":"https://github.com/narcs/steelconnect-dialogflow/pull/78"},"issue":{"href":"https://api.github.com/repos/narcs/steelconnect-dialogflow/issues/78"},"comments":{"href":"https://api.github.com/repos/narcs/steelconnect-dialogflow/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/narcs/steelconnect-dialogflow/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/narcs/steelconnect-dialogflow/statuses/37bf2ea83f84ef46a2b56f19929710fbb05130d6"}},"author_association":"NONE"}}
{"actor":{"display_login":"mirrexagon"}}