{"action":"created","comment":{"url":"https://api.github.com/repos/georgianpartners/foreshadow/pulls/comments/241930498","pull_request_review_id":185334093,"id":241930498,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTkzMDQ5OA==","diff_hunk":"@@ -1,27 +1,32 @@\n {\n   \"columns\":{\n-    \"crim\":[\"TestGenericIntent\",\n-            [\n-              [\"StandardScaler\", \"Scaler\", {\"with_mean\":false}]\n-            ]],\n-    \"indus\":[\"TestGenericIntent\"]\n+    \"crim\":{\n+\t    \"intent\": \"TestGenericIntent\",\n+            \"pipeline\":[\n+\t    {\"transformer\": \"StandardScaler\", \n+\t       \"name\": \"Scaler\", \n+\t       \"parameters\": {\"with_mean\":false}\n+\t    }]},\n+    \"indus\":{\"intent\": \"TestGenericIntent\"}\n   },\n \n   \"postprocess\":[\n-    [\"pca\",[\"crim\",\"indus\",\"nox\"],[\n-      [\"PCA\", \"PCA\", {\"n_components\":4}]\n-    ]]\n+\t  {\"BAD\": \"pca\",","path":"foreshadow/tests/test_configs/invalid_transformer_params.json","position":22,"original_position":22,"commit_id":"4c6c24d29fc9fa1bbf7c8d6df3c749b0782f2049","original_commit_id":"4c6c24d29fc9fa1bbf7c8d6df3c749b0782f2049","user":{"login":"robocoder99","id":5898707,"node_id":"MDQ6VXNlcjU4OTg3MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/5898707?v=4","gravatar_id":"","url":"https://api.github.com/users/robocoder99","html_url":"https://github.com/robocoder99","followers_url":"https://api.github.com/users/robocoder99/followers","following_url":"https://api.github.com/users/robocoder99/following{/other_user}","gists_url":"https://api.github.com/users/robocoder99/gists{/gist_id}","starred_url":"https://api.github.com/users/robocoder99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robocoder99/subscriptions","organizations_url":"https://api.github.com/users/robocoder99/orgs","repos_url":"https://api.github.com/users/robocoder99/repos","events_url":"https://api.github.com/users/robocoder99/events{/privacy}","received_events_url":"https://api.github.com/users/robocoder99/received_events","type":"User","site_admin":false},"body":"My bad. It apparently catches the correct error first but you are correct that would throw a KeyError down the line if not caught beforehand.","created_at":"2018-12-15T01:08:00Z","updated_at":"2018-12-15T01:08:00Z","html_url":"https://github.com/georgianpartners/foreshadow/pull/22#discussion_r241930498","pull_request_url":"https://api.github.com/repos/georgianpartners/foreshadow/pulls/22","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/georgianpartners/foreshadow/pulls/comments/241930498"},"html":{"href":"https://github.com/georgianpartners/foreshadow/pull/22#discussion_r241930498"},"pull_request":{"href":"https://api.github.com/repos/georgianpartners/foreshadow/pulls/22"}},"in_reply_to_id":238678786},"pull_request":{"url":"https://api.github.com/repos/georgianpartners/foreshadow/pulls/22","id":234964400,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0OTY0NDAw","html_url":"https://github.com/georgianpartners/foreshadow/pull/22","diff_url":"https://github.com/georgianpartners/foreshadow/pull/22.diff","patch_url":"https://github.com/georgianpartners/foreshadow/pull/22.patch","issue_url":"https://api.github.com/repos/georgianpartners/foreshadow/issues/22","number":22,"state":"open","locked":false,"title":"Implemented configuration change resolving issue #10","user":{"login":"robocoder99","id":5898707,"node_id":"MDQ6VXNlcjU4OTg3MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/5898707?v=4","gravatar_id":"","url":"https://api.github.com/users/robocoder99","html_url":"https://github.com/robocoder99","followers_url":"https://api.github.com/users/robocoder99/followers","following_url":"https://api.github.com/users/robocoder99/following{/other_user}","gists_url":"https://api.github.com/users/robocoder99/gists{/gist_id}","starred_url":"https://api.github.com/users/robocoder99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robocoder99/subscriptions","organizations_url":"https://api.github.com/users/robocoder99/orgs","repos_url":"https://api.github.com/users/robocoder99/repos","events_url":"https://api.github.com/users/robocoder99/events{/privacy}","received_events_url":"https://api.github.com/users/robocoder99/received_events","type":"User","site_admin":false},"body":"Fixed issue number #10 \r\n\r\nAll changes requested were implementation and documentation was updated. Changes here are extensive and may cause merge conflicts with other commits related to pre-processor.\r\n","created_at":"2018-11-30T11:57:45Z","updated_at":"2018-12-15T01:08:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2ca1ecaa185ad1660ea14206d29d471b4b4f3aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/georgianpartners/foreshadow/milestones/1","html_url":"https://github.com/georgianpartners/foreshadow/milestone/1","labels_url":"https://api.github.com/repos/georgianpartners/foreshadow/milestones/1/labels","id":3800871,"node_id":"MDk6TWlsZXN0b25lMzgwMDg3MQ==","number":1,"title":"November 2018","description":"Milestone to complete by end of November 2018.","creator":{"login":"jichaogp","id":29146756,"node_id":"MDQ6VXNlcjI5MTQ2NzU2","avatar_url":"https://avatars2.githubusercontent.com/u/29146756?v=4","gravatar_id":"","url":"https://api.github.com/users/jichaogp","html_url":"https://github.com/jichaogp","followers_url":"https://api.github.com/users/jichaogp/followers","following_url":"https://api.github.com/users/jichaogp/following{/other_user}","gists_url":"https://api.github.com/users/jichaogp/gists{/gist_id}","starred_url":"https://api.github.com/users/jichaogp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jichaogp/subscriptions","organizations_url":"https://api.github.com/users/jichaogp/orgs","repos_url":"https://api.github.com/users/jichaogp/repos","events_url":"https://api.github.com/users/jichaogp/events{/privacy}","received_events_url":"https://api.github.com/users/jichaogp/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":10,"state":"closed","created_at":"2018-11-06T16:31:01Z","updated_at":"2018-12-06T18:59:16Z","due_on":"2018-11-30T08:00:00Z","closed_at":"2018-12-06T18:57:36Z"},"commits_url":"https://api.github.com/repos/georgianpartners/foreshadow/pulls/22/commits","review_comments_url":"https://api.github.com/repos/georgianpartners/foreshadow/pulls/22/comments","review_comment_url":"https://api.github.com/repos/georgianpartners/foreshadow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/georgianpartners/foreshadow/issues/22/comments","statuses_url":"https://api.github.com/repos/georgianpartners/foreshadow/statuses/4c6c24d29fc9fa1bbf7c8d6df3c749b0782f2049","head":{"label":"georgianpartners:issue_10","ref":"issue_10","sha":"4c6c24d29fc9fa1bbf7c8d6df3c749b0782f2049","user":{"login":"georgianpartners","id":10764713,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY0NzEz","avatar_url":"https://avatars1.githubusercontent.com/u/10764713?v=4","gravatar_id":"","url":"https://api.github.com/users/georgianpartners","html_url":"https://github.com/georgianpartners","followers_url":"https://api.github.com/users/georgianpartners/followers","following_url":"https://api.github.com/users/georgianpartners/following{/other_user}","gists_url":"https://api.github.com/users/georgianpartners/gists{/gist_id}","starred_url":"https://api.github.com/users/georgianpartners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgianpartners/subscriptions","organizations_url":"https://api.github.com/users/georgianpartners/orgs","repos_url":"https://api.github.com/users/georgianpartners/repos","events_url":"https://api.github.com/users/georgianpartners/events{/privacy}","received_events_url":"https://api.github.com/users/georgianpartners/received_events","type":"Organization","site_admin":false},"repo":{"id":139168214,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxNjgyMTQ=","name":"foreshadow","full_name":"georgianpartners/foreshadow","private":false,"owner":{"login":"georgianpartners","id":10764713,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY0NzEz","avatar_url":"https://avatars1.githubusercontent.com/u/10764713?v=4","gravatar_id":"","url":"https://api.github.com/users/georgianpartners","html_url":"https://github.com/georgianpartners","followers_url":"https://api.github.com/users/georgianpartners/followers","following_url":"https://api.github.com/users/georgianpartners/following{/other_user}","gists_url":"https://api.github.com/users/georgianpartners/gists{/gist_id}","starred_url":"https://api.github.com/users/georgianpartners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgianpartners/subscriptions","organizations_url":"https://api.github.com/users/georgianpartners/orgs","repos_url":"https://api.github.com/users/georgianpartners/repos","events_url":"https://api.github.com/users/georgianpartners/events{/privacy}","received_events_url":"https://api.github.com/users/georgianpartners/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/georgianpartners/foreshadow","description":"An automatic machine learning system: https://foreshadow.readthedocs.io","fork":false,"url":"https://api.github.com/repos/georgianpartners/foreshadow","forks_url":"https://api.github.com/repos/georgianpartners/foreshadow/forks","keys_url":"https://api.github.com/repos/georgianpartners/foreshadow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georgianpartners/foreshadow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georgianpartners/foreshadow/teams","hooks_url":"https://api.github.com/repos/georgianpartners/foreshadow/hooks","issue_events_url":"https://api.github.com/repos/georgianpartners/foreshadow/issues/events{/number}","events_url":"https://api.github.com/repos/georgianpartners/foreshadow/events","assignees_url":"https://api.github.com/repos/georgianpartners/foreshadow/assignees{/user}","branches_url":"https://api.github.com/repos/georgianpartners/foreshadow/branches{/branch}","tags_url":"https://api.github.com/repos/georgianpartners/foreshadow/tags","blobs_url":"https://api.github.com/repos/georgianpartners/foreshadow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georgianpartners/foreshadow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georgianpartners/foreshadow/git/refs{/sha}","trees_url":"https://api.github.com/repos/georgianpartners/foreshadow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georgianpartners/foreshadow/statuses/{sha}","languages_url":"https://api.github.com/repos/georgianpartners/foreshadow/languages","stargazers_url":"https://api.github.com/repos/georgianpartners/foreshadow/stargazers","contributors_url":"https://api.github.com/repos/georgianpartners/foreshadow/contributors","subscribers_url":"https://api.github.com/repos/georgianpartners/foreshadow/subscribers","subscription_url":"https://api.github.com/repos/georgianpartners/foreshadow/subscription","commits_url":"https://api.github.com/repos/georgianpartners/foreshadow/commits{/sha}","git_commits_url":"https://api.github.com/repos/georgianpartners/foreshadow/git/commits{/sha}","comments_url":"https://api.github.com/repos/georgianpartners/foreshadow/comments{/number}","issue_comment_url":"https://api.github.com/repos/georgianpartners/foreshadow/issues/comments{/number}","contents_url":"https://api.github.com/repos/georgianpartners/foreshadow/contents/{+path}","compare_url":"https://api.github.com/repos/georgianpartners/foreshadow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georgianpartners/foreshadow/merges","archive_url":"https://api.github.com/repos/georgianpartners/foreshadow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georgianpartners/foreshadow/downloads","issues_url":"https://api.github.com/repos/georgianpartners/foreshadow/issues{/number}","pulls_url":"https://api.github.com/repos/georgianpartners/foreshadow/pulls{/number}","milestones_url":"https://api.github.com/repos/georgianpartners/foreshadow/milestones{/number}","notifications_url":"https://api.github.com/repos/georgianpartners/foreshadow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georgianpartners/foreshadow/labels{/name}","releases_url":"https://api.github.com/repos/georgianpartners/foreshadow/releases{/id}","deployments_url":"https://api.github.com/repos/georgianpartners/foreshadow/deployments","created_at":"2018-06-29T15:46:59Z","updated_at":"2018-11-25T07:31:11Z","pushed_at":"2018-12-06T19:38:33Z","git_url":"git://github.com/georgianpartners/foreshadow.git","ssh_url":"git@github.com:georgianpartners/foreshadow.git","clone_url":"https://github.com/georgianpartners/foreshadow.git","svn_url":"https://github.com/georgianpartners/foreshadow","homepage":"","size":368,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":13,"watchers":6,"default_branch":"master"}},"base":{"label":"georgianpartners:development","ref":"development","sha":"bacdf5a3b64e056563a1345a144ef35148644a16","user":{"login":"georgianpartners","id":10764713,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY0NzEz","avatar_url":"https://avatars1.githubusercontent.com/u/10764713?v=4","gravatar_id":"","url":"https://api.github.com/users/georgianpartners","html_url":"https://github.com/georgianpartners","followers_url":"https://api.github.com/users/georgianpartners/followers","following_url":"https://api.github.com/users/georgianpartners/following{/other_user}","gists_url":"https://api.github.com/users/georgianpartners/gists{/gist_id}","starred_url":"https://api.github.com/users/georgianpartners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgianpartners/subscriptions","organizations_url":"https://api.github.com/users/georgianpartners/orgs","repos_url":"https://api.github.com/users/georgianpartners/repos","events_url":"https://api.github.com/users/georgianpartners/events{/privacy}","received_events_url":"https://api.github.com/users/georgianpartners/received_events","type":"Organization","site_admin":false},"repo":{"id":139168214,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxNjgyMTQ=","name":"foreshadow","full_name":"georgianpartners/foreshadow","private":false,"owner":{"login":"georgianpartners","id":10764713,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY0NzEz","avatar_url":"https://avatars1.githubusercontent.com/u/10764713?v=4","gravatar_id":"","url":"https://api.github.com/users/georgianpartners","html_url":"https://github.com/georgianpartners","followers_url":"https://api.github.com/users/georgianpartners/followers","following_url":"https://api.github.com/users/georgianpartners/following{/other_user}","gists_url":"https://api.github.com/users/georgianpartners/gists{/gist_id}","starred_url":"https://api.github.com/users/georgianpartners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgianpartners/subscriptions","organizations_url":"https://api.github.com/users/georgianpartners/orgs","repos_url":"https://api.github.com/users/georgianpartners/repos","events_url":"https://api.github.com/users/georgianpartners/events{/privacy}","received_events_url":"https://api.github.com/users/georgianpartners/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/georgianpartners/foreshadow","description":"An automatic machine learning system: https://foreshadow.readthedocs.io","fork":false,"url":"https://api.github.com/repos/georgianpartners/foreshadow","forks_url":"https://api.github.com/repos/georgianpartners/foreshadow/forks","keys_url":"https://api.github.com/repos/georgianpartners/foreshadow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georgianpartners/foreshadow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georgianpartners/foreshadow/teams","hooks_url":"https://api.github.com/repos/georgianpartners/foreshadow/hooks","issue_events_url":"https://api.github.com/repos/georgianpartners/foreshadow/issues/events{/number}","events_url":"https://api.github.com/repos/georgianpartners/foreshadow/events","assignees_url":"https://api.github.com/repos/georgianpartners/foreshadow/assignees{/user}","branches_url":"https://api.github.com/repos/georgianpartners/foreshadow/branches{/branch}","tags_url":"https://api.github.com/repos/georgianpartners/foreshadow/tags","blobs_url":"https://api.github.com/repos/georgianpartners/foreshadow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georgianpartners/foreshadow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georgianpartners/foreshadow/git/refs{/sha}","trees_url":"https://api.github.com/repos/georgianpartners/foreshadow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georgianpartners/foreshadow/statuses/{sha}","languages_url":"https://api.github.com/repos/georgianpartners/foreshadow/languages","stargazers_url":"https://api.github.com/repos/georgianpartners/foreshadow/stargazers","contributors_url":"https://api.github.com/repos/georgianpartners/foreshadow/contributors","subscribers_url":"https://api.github.com/repos/georgianpartners/foreshadow/subscribers","subscription_url":"https://api.github.com/repos/georgianpartners/foreshadow/subscription","commits_url":"https://api.github.com/repos/georgianpartners/foreshadow/commits{/sha}","git_commits_url":"https://api.github.com/repos/georgianpartners/foreshadow/git/commits{/sha}","comments_url":"https://api.github.com/repos/georgianpartners/foreshadow/comments{/number}","issue_comment_url":"https://api.github.com/repos/georgianpartners/foreshadow/issues/comments{/number}","contents_url":"https://api.github.com/repos/georgianpartners/foreshadow/contents/{+path}","compare_url":"https://api.github.com/repos/georgianpartners/foreshadow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georgianpartners/foreshadow/merges","archive_url":"https://api.github.com/repos/georgianpartners/foreshadow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georgianpartners/foreshadow/downloads","issues_url":"https://api.github.com/repos/georgianpartners/foreshadow/issues{/number}","pulls_url":"https://api.github.com/repos/georgianpartners/foreshadow/pulls{/number}","milestones_url":"https://api.github.com/repos/georgianpartners/foreshadow/milestones{/number}","notifications_url":"https://api.github.com/repos/georgianpartners/foreshadow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georgianpartners/foreshadow/labels{/name}","releases_url":"https://api.github.com/repos/georgianpartners/foreshadow/releases{/id}","deployments_url":"https://api.github.com/repos/georgianpartners/foreshadow/deployments","created_at":"2018-06-29T15:46:59Z","updated_at":"2018-11-25T07:31:11Z","pushed_at":"2018-12-06T19:38:33Z","git_url":"git://github.com/georgianpartners/foreshadow.git","ssh_url":"git@github.com:georgianpartners/foreshadow.git","clone_url":"https://github.com/georgianpartners/foreshadow.git","svn_url":"https://github.com/georgianpartners/foreshadow","homepage":"","size":368,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":13,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/georgianpartners/foreshadow/pulls/22"},"html":{"href":"https://github.com/georgianpartners/foreshadow/pull/22"},"issue":{"href":"https://api.github.com/repos/georgianpartners/foreshadow/issues/22"},"comments":{"href":"https://api.github.com/repos/georgianpartners/foreshadow/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/georgianpartners/foreshadow/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/georgianpartners/foreshadow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/georgianpartners/foreshadow/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/georgianpartners/foreshadow/statuses/4c6c24d29fc9fa1bbf7c8d6df3c749b0782f2049"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"robocoder99"}}