{"action":"closed","number":2380,"pull_request":{"url":"https://api.github.com/repos/dlang/dlang.org/pulls/2380","id":192977769,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyOTc3NzY5","html_url":"https://github.com/dlang/dlang.org/pull/2380","diff_url":"https://github.com/dlang/dlang.org/pull/2380.diff","patch_url":"https://github.com/dlang/dlang.org/pull/2380.patch","issue_url":"https://api.github.com/repos/dlang/dlang.org/issues/2380","number":2380,"state":"closed","locked":false,"title":"fix release doc build with ENABLE_RELEASE=1","user":{"login":"MartinNowak","id":288976,"node_id":"MDQ6VXNlcjI4ODk3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/288976?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinNowak","html_url":"https://github.com/MartinNowak","followers_url":"https://api.github.com/users/MartinNowak/followers","following_url":"https://api.github.com/users/MartinNowak/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowak/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowak/subscriptions","organizations_url":"https://api.github.com/users/MartinNowak/orgs","repos_url":"https://api.github.com/users/MartinNowak/repos","events_url":"https://api.github.com/users/MartinNowak/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowak/received_events","type":"User","site_admin":false},"body":"- set ENABLE_RELEASE=1 in release target and rerun makefile\r\n- use same ENABLE_RELEASE variable as dmd and create_dmd_release\r\n- Need both a target and a variable to be set for the build to work\r\n  with dlang.org's current makefile architecture (deps in variables).\r\n  The workaround is messy and separate targets should be used instead\r\n  of variables that affect file lists.\r\n\r\nThe approach in #2371 didn't work as it seems that variables in prerequisites (e.g. of the html target) get expanded before target-specific variables are applied. So even though `release : CHANGELOG_FILES:=$(filter-out changelog/pending,$(CHANGELOG_FILES))` does modify the list it has no effect on `html : $(ALL_FILES)` at the time the html target is run.","created_at":"2018-06-06T11:09:31Z","updated_at":"2018-06-07T23:07:10Z","closed_at":"2018-06-07T23:07:10Z","merged_at":"2018-06-07T23:07:10Z","merge_commit_sha":"9dfbb48ef936a030d089d8e88013b7e35c9bf655","assignee":null,"assignees":[],"requested_reviewers":[{"login":"CyberShadow","id":160894,"node_id":"MDQ6VXNlcjE2MDg5NA==","avatar_url":"https://avatars0.githubusercontent.com/u/160894?v=4","gravatar_id":"","url":"https://api.github.com/users/CyberShadow","html_url":"https://github.com/CyberShadow","followers_url":"https://api.github.com/users/CyberShadow/followers","following_url":"https://api.github.com/users/CyberShadow/following{/other_user}","gists_url":"https://api.github.com/users/CyberShadow/gists{/gist_id}","starred_url":"https://api.github.com/users/CyberShadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyberShadow/subscriptions","organizations_url":"https://api.github.com/users/CyberShadow/orgs","repos_url":"https://api.github.com/users/CyberShadow/repos","events_url":"https://api.github.com/users/CyberShadow/events{/privacy}","received_events_url":"https://api.github.com/users/CyberShadow/received_events","type":"User","site_admin":false},{"login":"andralex","id":566679,"node_id":"MDQ6VXNlcjU2NjY3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/566679?v=4","gravatar_id":"","url":"https://api.github.com/users/andralex","html_url":"https://github.com/andralex","followers_url":"https://api.github.com/users/andralex/followers","following_url":"https://api.github.com/users/andralex/following{/other_user}","gists_url":"https://api.github.com/users/andralex/gists{/gist_id}","starred_url":"https://api.github.com/users/andralex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andralex/subscriptions","organizations_url":"https://api.github.com/users/andralex/orgs","repos_url":"https://api.github.com/users/andralex/repos","events_url":"https://api.github.com/users/andralex/events{/privacy}","received_events_url":"https://api.github.com/users/andralex/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dlang.org/pulls/2380/commits","review_comments_url":"https://api.github.com/repos/dlang/dlang.org/pulls/2380/comments","review_comment_url":"https://api.github.com/repos/dlang/dlang.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dlang.org/issues/2380/comments","statuses_url":"https://api.github.com/repos/dlang/dlang.org/statuses/193c6426080f75a7860720b919824015f04a9eea","head":{"label":"MartinNowak:enable_release","ref":"enable_release","sha":"193c6426080f75a7860720b919824015f04a9eea","user":{"login":"MartinNowak","id":288976,"node_id":"MDQ6VXNlcjI4ODk3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/288976?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinNowak","html_url":"https://github.com/MartinNowak","followers_url":"https://api.github.com/users/MartinNowak/followers","following_url":"https://api.github.com/users/MartinNowak/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowak/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowak/subscriptions","organizations_url":"https://api.github.com/users/MartinNowak/orgs","repos_url":"https://api.github.com/users/MartinNowak/repos","events_url":"https://api.github.com/users/MartinNowak/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowak/received_events","type":"User","site_admin":false},"repo":{"id":11586989,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU4Njk4OQ==","name":"dlang.org","full_name":"MartinNowak/dlang.org","owner":{"login":"MartinNowak","id":288976,"node_id":"MDQ6VXNlcjI4ODk3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/288976?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinNowak","html_url":"https://github.com/MartinNowak","followers_url":"https://api.github.com/users/MartinNowak/followers","following_url":"https://api.github.com/users/MartinNowak/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowak/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowak/subscriptions","organizations_url":"https://api.github.com/users/MartinNowak/orgs","repos_url":"https://api.github.com/users/MartinNowak/repos","events_url":"https://api.github.com/users/MartinNowak/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MartinNowak/dlang.org","description":"Pages for the dlang.org website, home of the D Programming Language","fork":true,"url":"https://api.github.com/repos/MartinNowak/dlang.org","forks_url":"https://api.github.com/repos/MartinNowak/dlang.org/forks","keys_url":"https://api.github.com/repos/MartinNowak/dlang.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MartinNowak/dlang.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MartinNowak/dlang.org/teams","hooks_url":"https://api.github.com/repos/MartinNowak/dlang.org/hooks","issue_events_url":"https://api.github.com/repos/MartinNowak/dlang.org/issues/events{/number}","events_url":"https://api.github.com/repos/MartinNowak/dlang.org/events","assignees_url":"https://api.github.com/repos/MartinNowak/dlang.org/assignees{/user}","branches_url":"https://api.github.com/repos/MartinNowak/dlang.org/branches{/branch}","tags_url":"https://api.github.com/repos/MartinNowak/dlang.org/tags","blobs_url":"https://api.github.com/repos/MartinNowak/dlang.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MartinNowak/dlang.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MartinNowak/dlang.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/MartinNowak/dlang.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MartinNowak/dlang.org/statuses/{sha}","languages_url":"https://api.github.com/repos/MartinNowak/dlang.org/languages","stargazers_url":"https://api.github.com/repos/MartinNowak/dlang.org/stargazers","contributors_url":"https://api.github.com/repos/MartinNowak/dlang.org/contributors","subscribers_url":"https://api.github.com/repos/MartinNowak/dlang.org/subscribers","subscription_url":"https://api.github.com/repos/MartinNowak/dlang.org/subscription","commits_url":"https://api.github.com/repos/MartinNowak/dlang.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/MartinNowak/dlang.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/MartinNowak/dlang.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/MartinNowak/dlang.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/MartinNowak/dlang.org/contents/{+path}","compare_url":"https://api.github.com/repos/MartinNowak/dlang.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MartinNowak/dlang.org/merges","archive_url":"https://api.github.com/repos/MartinNowak/dlang.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MartinNowak/dlang.org/downloads","issues_url":"https://api.github.com/repos/MartinNowak/dlang.org/issues{/number}","pulls_url":"https://api.github.com/repos/MartinNowak/dlang.org/pulls{/number}","milestones_url":"https://api.github.com/repos/MartinNowak/dlang.org/milestones{/number}","notifications_url":"https://api.github.com/repos/MartinNowak/dlang.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MartinNowak/dlang.org/labels{/name}","releases_url":"https://api.github.com/repos/MartinNowak/dlang.org/releases{/id}","deployments_url":"https://api.github.com/repos/MartinNowak/dlang.org/deployments","created_at":"2013-07-22T17:01:54Z","updated_at":"2015-02-17T17:44:28Z","pushed_at":"2018-06-07T22:47:48Z","git_url":"git://github.com/MartinNowak/dlang.org.git","ssh_url":"git@github.com:MartinNowak/dlang.org.git","clone_url":"https://github.com/MartinNowak/dlang.org.git","svn_url":"https://github.com/MartinNowak/dlang.org","homepage":"dlang.org","size":16126,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"7303ac6bf7fd7edbfa9af39b33e7f8737d7ff75b","user":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257080,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MDgw","name":"dlang.org","full_name":"dlang/dlang.org","owner":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/dlang.org","description":"Pages for the dlang.org website, home of the D Programming Language","fork":false,"url":"https://api.github.com/repos/dlang/dlang.org","forks_url":"https://api.github.com/repos/dlang/dlang.org/forks","keys_url":"https://api.github.com/repos/dlang/dlang.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dlang.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dlang.org/teams","hooks_url":"https://api.github.com/repos/dlang/dlang.org/hooks","issue_events_url":"https://api.github.com/repos/dlang/dlang.org/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dlang.org/events","assignees_url":"https://api.github.com/repos/dlang/dlang.org/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dlang.org/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dlang.org/tags","blobs_url":"https://api.github.com/repos/dlang/dlang.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dlang.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dlang.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dlang.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dlang.org/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dlang.org/languages","stargazers_url":"https://api.github.com/repos/dlang/dlang.org/stargazers","contributors_url":"https://api.github.com/repos/dlang/dlang.org/contributors","subscribers_url":"https://api.github.com/repos/dlang/dlang.org/subscribers","subscription_url":"https://api.github.com/repos/dlang/dlang.org/subscription","commits_url":"https://api.github.com/repos/dlang/dlang.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dlang.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dlang.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dlang.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dlang.org/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dlang.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dlang.org/merges","archive_url":"https://api.github.com/repos/dlang/dlang.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dlang.org/downloads","issues_url":"https://api.github.com/repos/dlang/dlang.org/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dlang.org/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dlang.org/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dlang.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dlang.org/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dlang.org/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dlang.org/deployments","created_at":"2011-01-15T06:58:12Z","updated_at":"2018-06-06T18:54:05Z","pushed_at":"2018-06-07T23:07:10Z","git_url":"git://github.com/dlang/dlang.org.git","ssh_url":"git@github.com:dlang/dlang.org.git","clone_url":"https://github.com/dlang/dlang.org.git","svn_url":"https://github.com/dlang/dlang.org","homepage":"dlang.org","size":16152,"stargazers_count":211,"watchers_count":211,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":311,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":311,"open_issues":70,"watchers":211,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dlang.org/pulls/2380"},"html":{"href":"https://github.com/dlang/dlang.org/pull/2380"},"issue":{"href":"https://api.github.com/repos/dlang/dlang.org/issues/2380"},"comments":{"href":"https://api.github.com/repos/dlang/dlang.org/issues/2380/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dlang.org/pulls/2380/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dlang.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dlang.org/pulls/2380/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dlang.org/statuses/193c6426080f75a7860720b919824015f04a9eea"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wilzbach","id":4370550,"node_id":"MDQ6VXNlcjQzNzA1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4370550?v=4","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":3,"additions":18,"deletions":13,"changed_files":3}}
{"actor":{"display_login":"wilzbach"}}