{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/24214","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/24214/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24214/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/24214/events","html_url":"https://github.com/nodejs/node/pull/24214","id":378154374,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTI2NDYx","number":24214,"title":"timers: fix setTimeout expiration logic","user":{"login":"suguru03","id":8013633,"node_id":"MDQ6VXNlcjgwMTM2MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8013633?v=4","gravatar_id":"","url":"https://api.github.com/users/suguru03","html_url":"https://github.com/suguru03","followers_url":"https://api.github.com/users/suguru03/followers","following_url":"https://api.github.com/users/suguru03/following{/other_user}","gists_url":"https://api.github.com/users/suguru03/gists{/gist_id}","starred_url":"https://api.github.com/users/suguru03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suguru03/subscriptions","organizations_url":"https://api.github.com/users/suguru03/orgs","repos_url":"https://api.github.com/users/suguru03/repos","events_url":"https://api.github.com/users/suguru03/events{/privacy}","received_events_url":"https://api.github.com/users/suguru03/received_events","type":"User","site_admin":false},"labels":[{"id":155435976,"node_id":"MDU6TGFiZWwxNTU0MzU5NzY=","url":"https://api.github.com/repos/nodejs/node/labels/timers","name":"timers","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-11-07T06:06:01Z","updated_at":"2018-11-14T08:03:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24214","html_url":"https://github.com/nodejs/node/pull/24214","diff_url":"https://github.com/nodejs/node/pull/24214.diff","patch_url":"https://github.com/nodejs/node/pull/24214.patch"},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\nI fixed the setTimeout issue. \r\nI changed the logic to be the same logic as `v10.30.0` following the lines. https://github.com/nodejs/node/blob/v10.13.0/lib/timers.js#L240-L243\r\n\r\nFixes: https://github.com/nodejs/node/issues/24203\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/438572342","html_url":"https://github.com/nodejs/node/pull/24214#issuecomment-438572342","issue_url":"https://api.github.com/repos/nodejs/node/issues/24214","id":438572342,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODU3MjM0Mg==","user":{"login":"Trott","id":718899,"node_id":"MDQ6VXNlcjcxODg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T08:03:20Z","updated_at":"2018-11-14T08:03:20Z","author_association":"MEMBER","body":"So, uh, should this land as-is to fix the bug and then someone can submit a PR to align more with browsers, truncate/floor instead of ceil, etc.? Or should those fixes happen here and now?\r\n\r\nMy opinion: This has been quiet for 4 days, and it would be nice to get the bug fixed. So I'm inclined to land this or to suggest that anyone who thinks it should be different should get in there and change it and push a second commit to this branch. Thoughts?\r\n\r\nIn the meantime, CI: https://ci.nodejs.org/job/node-test-pull-request/18608/"}}
{"actor":{"display_login":"Trott"}}