{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/189152553","pull_request_review_id":121277131,"id":189152553,"diff_hunk":"@@ -0,0 +1,87 @@\n+\"\"\"\n+Support for Hydrawise sprinkler.\n+\n+For more details about this platform, please refer to the documentation at\n+https://home-assistant.io/components/binary_sensor.hydrawise/\n+\"\"\"\n+import logging\n+\n+import voluptuous as vol\n+\n+import homeassistant.helpers.config_validation as cv\n+from homeassistant.components.hydrawise import (\n+    BINARY_SENSORS, DATA_HYDRAWISE, HydrawiseEntity, ICON_MAP)\n+from homeassistant.components.binary_sensor import (\n+    BinarySensorDevice, PLATFORM_SCHEMA)\n+from homeassistant.const import CONF_MONITORED_CONDITIONS\n+\n+DEPENDENCIES = ['hydrawise']\n+\n+_LOGGER = logging.getLogger(__name__)\n+\n+PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({\n+    vol.Optional(CONF_MONITORED_CONDITIONS, default=list(BINARY_SENSORS)):\n+        vol.All(cv.ensure_list, [vol.In(BINARY_SENSORS)]),\n+})\n+\n+\n+def setup_platform(hass, config, add_devices, discovery_info=None):\n+    \"\"\"Set up a sensor for a hydrawise device.\"\"\"\n+    hydrawise = hass.data[DATA_HYDRAWISE].data\n+\n+    sensors = []\n+    for sensor_type in config.get(CONF_MONITORED_CONDITIONS):\n+        if sensor_type in ['status', 'rain_sensor']:\n+            sensors.append(\n+                HydrawiseBinarySensor(\n+                    hydrawise.controller_status, sensor_type))\n+\n+        else:\n+            # create a sensor for each zone\n+            for zone in hydrawise.relays:\n+                zone_data = zone\n+                zone_data['running'] = \\\n+                    hydrawise.controller_status.get('running', False)\n+                sensors.append(HydrawiseBinarySensor(zone_data, sensor_type))\n+\n+    add_devices(sensors, True)\n+    return True\n+\n+\n+class HydrawiseBinarySensor(HydrawiseEntity, BinarySensorDevice):\n+    \"\"\"A sensor implementation for hydrawise device.\"\"\"\n+\n+    @property\n+    def is_on(self):\n+        \"\"\"Return true if the binary sensor is on.\"\"\"\n+        return self._state\n+\n+    def update(self):\n+        \"\"\"Get the latest data and updates the state.\"\"\"\n+        _LOGGER.debug(\"Updating Hydrawise binary sensor: %s\", self._name)\n+        mydata = self.hass.data['hydrawise'].data\n+        if self._sensor_type == 'status':\n+            self._state = mydata.status == 'All good!'","path":"homeassistant/components/binary_sensor/hydrawise.py","position":64,"original_position":64,"commit_id":"6e0841bf31dab7d52983d485d616d11e1f52dc4a","original_commit_id":"6e0841bf31dab7d52983d485d616d11e1f52dc4a","user":{"login":"ptcryan","id":3135547,"avatar_url":"https://avatars0.githubusercontent.com/u/3135547?v=4","gravatar_id":"","url":"https://api.github.com/users/ptcryan","html_url":"https://github.com/ptcryan","followers_url":"https://api.github.com/users/ptcryan/followers","following_url":"https://api.github.com/users/ptcryan/following{/other_user}","gists_url":"https://api.github.com/users/ptcryan/gists{/gist_id}","starred_url":"https://api.github.com/users/ptcryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptcryan/subscriptions","organizations_url":"https://api.github.com/users/ptcryan/orgs","repos_url":"https://api.github.com/users/ptcryan/repos","events_url":"https://api.github.com/users/ptcryan/events{/privacy}","received_events_url":"https://api.github.com/users/ptcryan/received_events","type":"User","site_admin":false},"body":"The expression always evaluates to True or False. However, I changed to an if/else to make it clearer.","created_at":"2018-05-18T02:55:54Z","updated_at":"2018-05-18T02:55:54Z","html_url":"https://github.com/home-assistant/home-assistant/pull/14055#discussion_r189152553","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14055","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/189152553"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/14055#discussion_r189152553"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14055"}},"in_reply_to_id":186965168},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14055","id":183316329,"html_url":"https://github.com/home-assistant/home-assistant/pull/14055","diff_url":"https://github.com/home-assistant/home-assistant/pull/14055.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/14055.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/14055","number":14055,"state":"open","locked":false,"title":"Added the Hydrawise component.","user":{"login":"ptcryan","id":3135547,"avatar_url":"https://avatars0.githubusercontent.com/u/3135547?v=4","gravatar_id":"","url":"https://api.github.com/users/ptcryan","html_url":"https://github.com/ptcryan","followers_url":"https://api.github.com/users/ptcryan/followers","following_url":"https://api.github.com/users/ptcryan/following{/other_user}","gists_url":"https://api.github.com/users/ptcryan/gists{/gist_id}","starred_url":"https://api.github.com/users/ptcryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptcryan/subscriptions","organizations_url":"https://api.github.com/users/ptcryan/orgs","repos_url":"https://api.github.com/users/ptcryan/repos","events_url":"https://api.github.com/users/ptcryan/events{/privacy}","received_events_url":"https://api.github.com/users/ptcryan/received_events","type":"User","site_admin":false},"body":"## Description:\r\nThe hydrawise component allows you to integrate your Hunter Hydrawise Wi-Fi irrigation controller system in Home Assistant.\r\n\r\n**Related issue (if applicable):** fixes #<home-assistant issue number goes here>\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#5234\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\n# Example configuration.yaml entry\r\nhydrawise:\r\n  access_token: YOUR_API_KEY\r\n\r\nswitch:\r\n  - platform: hydrawise\r\n    watering_minutes: 5\r\n\r\nsensor:\r\n  - platform: hydrawise\r\n\r\nbinary_sensor:\r\n  - platform: hydrawise\r\n```\r\n\r\n## Checklist:\r\n  - [X] The code change is tested and works locally.\r\n  - [X] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [X] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [X] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [X] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [X] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [X] New files were added to `.coveragerc`.\r\n\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54","created_at":"2018-04-23T03:13:39Z","updated_at":"2018-05-18T02:55:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4c95f8831f8d19493ad6dbf7c0cd0c1543cfffd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":910610780,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20hydrawise","name":"component: hydrawise","color":"ededed","default":false},{"id":526146744,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/new-platform","name":"new-platform","color":"ededed","default":false},{"id":910610776,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20binary_sensor.hydrawise","name":"platform: binary_sensor.hydrawise","color":"ededed","default":false},{"id":910610784,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20sensor.hydrawise","name":"platform: sensor.hydrawise","color":"ededed","default":false},{"id":910610786,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20switch.hydrawise","name":"platform: switch.hydrawise","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14055/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14055/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/14055/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/6e0841bf31dab7d52983d485d616d11e1f52dc4a","head":{"label":"ptcryan:hydrawise","ref":"hydrawise","sha":"6e0841bf31dab7d52983d485d616d11e1f52dc4a","user":{"login":"ptcryan","id":3135547,"avatar_url":"https://avatars0.githubusercontent.com/u/3135547?v=4","gravatar_id":"","url":"https://api.github.com/users/ptcryan","html_url":"https://github.com/ptcryan","followers_url":"https://api.github.com/users/ptcryan/followers","following_url":"https://api.github.com/users/ptcryan/following{/other_user}","gists_url":"https://api.github.com/users/ptcryan/gists{/gist_id}","starred_url":"https://api.github.com/users/ptcryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptcryan/subscriptions","organizations_url":"https://api.github.com/users/ptcryan/orgs","repos_url":"https://api.github.com/users/ptcryan/repos","events_url":"https://api.github.com/users/ptcryan/events{/privacy}","received_events_url":"https://api.github.com/users/ptcryan/received_events","type":"User","site_admin":false},"repo":{"id":130566580,"name":"home-assistant","full_name":"ptcryan/home-assistant","owner":{"login":"ptcryan","id":3135547,"avatar_url":"https://avatars0.githubusercontent.com/u/3135547?v=4","gravatar_id":"","url":"https://api.github.com/users/ptcryan","html_url":"https://github.com/ptcryan","followers_url":"https://api.github.com/users/ptcryan/followers","following_url":"https://api.github.com/users/ptcryan/following{/other_user}","gists_url":"https://api.github.com/users/ptcryan/gists{/gist_id}","starred_url":"https://api.github.com/users/ptcryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptcryan/subscriptions","organizations_url":"https://api.github.com/users/ptcryan/orgs","repos_url":"https://api.github.com/users/ptcryan/repos","events_url":"https://api.github.com/users/ptcryan/events{/privacy}","received_events_url":"https://api.github.com/users/ptcryan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ptcryan/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/ptcryan/home-assistant","forks_url":"https://api.github.com/repos/ptcryan/home-assistant/forks","keys_url":"https://api.github.com/repos/ptcryan/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ptcryan/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ptcryan/home-assistant/teams","hooks_url":"https://api.github.com/repos/ptcryan/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/ptcryan/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/ptcryan/home-assistant/events","assignees_url":"https://api.github.com/repos/ptcryan/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/ptcryan/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/ptcryan/home-assistant/tags","blobs_url":"https://api.github.com/repos/ptcryan/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ptcryan/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ptcryan/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/ptcryan/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ptcryan/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/ptcryan/home-assistant/languages","stargazers_url":"https://api.github.com/repos/ptcryan/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/ptcryan/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/ptcryan/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/ptcryan/home-assistant/subscription","commits_url":"https://api.github.com/repos/ptcryan/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/ptcryan/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/ptcryan/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/ptcryan/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/ptcryan/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/ptcryan/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ptcryan/home-assistant/merges","archive_url":"https://api.github.com/repos/ptcryan/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ptcryan/home-assistant/downloads","issues_url":"https://api.github.com/repos/ptcryan/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/ptcryan/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/ptcryan/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/ptcryan/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ptcryan/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/ptcryan/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/ptcryan/home-assistant/deployments","created_at":"2018-04-22T12:46:27Z","updated_at":"2018-04-22T12:46:35Z","pushed_at":"2018-04-23T04:58:34Z","git_url":"git://github.com/ptcryan/home-assistant.git","ssh_url":"git@github.com:ptcryan/home-assistant.git","clone_url":"https://github.com/ptcryan/home-assistant.git","svn_url":"https://github.com/ptcryan/home-assistant","homepage":"https://home-assistant.io","size":81413,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"e4cb3af76d15567606a147da7d2a3c6c99556199","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-05-18T01:54:14Z","pushed_at":"2018-05-18T01:30:49Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":82294,"stargazers_count":14299,"watchers_count":14299,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4245,"mirror_url":null,"archived":false,"open_issues_count":819,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4245,"open_issues":819,"watchers":14299,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14055"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/14055"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/14055"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/14055/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14055/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14055/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/6e0841bf31dab7d52983d485d616d11e1f52dc4a"}},"author_association":"NONE"}}
{"actor":{"display_login":"ptcryan"}}