{"action":"closed","number":242,"pull_request":{"url":"https://api.github.com/repos/wmonk/create-react-app-typescript/pulls/242","id":165509776,"html_url":"https://github.com/wmonk/create-react-app-typescript/pull/242","diff_url":"https://github.com/wmonk/create-react-app-typescript/pull/242.diff","patch_url":"https://github.com/wmonk/create-react-app-typescript/pull/242.patch","issue_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/issues/242","number":242,"state":"closed","locked":false,"title":"Added the abillity to import js and jsx files with ts-loader","user":{"login":"GeeWee","id":6381792,"avatar_url":"https://avatars3.githubusercontent.com/u/6381792?v=4","gravatar_id":"","url":"https://api.github.com/users/GeeWee","html_url":"https://github.com/GeeWee","followers_url":"https://api.github.com/users/GeeWee/followers","following_url":"https://api.github.com/users/GeeWee/following{/other_user}","gists_url":"https://api.github.com/users/GeeWee/gists{/gist_id}","starred_url":"https://api.github.com/users/GeeWee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeeWee/subscriptions","organizations_url":"https://api.github.com/users/GeeWee/orgs","repos_url":"https://api.github.com/users/GeeWee/repos","events_url":"https://api.github.com/users/GeeWee/events{/privacy}","received_events_url":"https://api.github.com/users/GeeWee/received_events","type":"User","site_admin":false},"body":"This PR adds the abillity for ts-loader to also process js and jsx files, and lets Jest pick them up as well.\r\n\r\nThis is good progress for if you want to migrate a large js app gradually to typescript\r\n\r\nI've verified it via running it on a mixed repository:\r\n![image](https://user-images.githubusercontent.com/6381792/35470245-f922e7b0-0345-11e8-858e-f763c2bcb012.png)\r\n\r\nand tests:\r\n![image](https://user-images.githubusercontent.com/6381792/35470317-75cdb776-0347-11e8-896c-83a1d25b2423.png)\r\n\r\nI'm not sure whether there's a smarter way to test it. I did it by editing the node_modules folder directly in this branch https://github.com/GeeWee/flatris/tree/react-scripts-ts-test\r\n\r\n(if you want to test, fetch repo, run yarn install, and then git reset --hard to override)\r\n\r\nCloses #230 and #217 \r\n\r\n(I also changed the prettier config in package.json as single quotes within double quotes doesn't work on windows)\r\n","created_at":"2018-01-27T08:51:38Z","updated_at":"2018-02-13T09:00:44Z","closed_at":"2018-02-13T09:00:44Z","merged_at":"2018-02-13T09:00:44Z","merge_commit_sha":"ec0a39e080f9a04f11c935d10260b29928289fde","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/pulls/242/commits","review_comments_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/pulls/242/comments","review_comment_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/issues/242/comments","statuses_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/statuses/69eaa289bb50d000fb930b8f8766da0f7314801e","head":{"label":"GeeWee:master","ref":"master","sha":"69eaa289bb50d000fb930b8f8766da0f7314801e","user":{"login":"GeeWee","id":6381792,"avatar_url":"https://avatars3.githubusercontent.com/u/6381792?v=4","gravatar_id":"","url":"https://api.github.com/users/GeeWee","html_url":"https://github.com/GeeWee","followers_url":"https://api.github.com/users/GeeWee/followers","following_url":"https://api.github.com/users/GeeWee/following{/other_user}","gists_url":"https://api.github.com/users/GeeWee/gists{/gist_id}","starred_url":"https://api.github.com/users/GeeWee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeeWee/subscriptions","organizations_url":"https://api.github.com/users/GeeWee/orgs","repos_url":"https://api.github.com/users/GeeWee/repos","events_url":"https://api.github.com/users/GeeWee/events{/privacy}","received_events_url":"https://api.github.com/users/GeeWee/received_events","type":"User","site_admin":false},"repo":{"id":119144828,"name":"create-react-app-typescript","full_name":"GeeWee/create-react-app-typescript","owner":{"login":"GeeWee","id":6381792,"avatar_url":"https://avatars3.githubusercontent.com/u/6381792?v=4","gravatar_id":"","url":"https://api.github.com/users/GeeWee","html_url":"https://github.com/GeeWee","followers_url":"https://api.github.com/users/GeeWee/followers","following_url":"https://api.github.com/users/GeeWee/following{/other_user}","gists_url":"https://api.github.com/users/GeeWee/gists{/gist_id}","starred_url":"https://api.github.com/users/GeeWee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeeWee/subscriptions","organizations_url":"https://api.github.com/users/GeeWee/orgs","repos_url":"https://api.github.com/users/GeeWee/repos","events_url":"https://api.github.com/users/GeeWee/events{/privacy}","received_events_url":"https://api.github.com/users/GeeWee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GeeWee/create-react-app-typescript","description":"Create React apps using typescript with no build configuration.","fork":true,"url":"https://api.github.com/repos/GeeWee/create-react-app-typescript","forks_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/forks","keys_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/teams","hooks_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/hooks","issue_events_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/issues/events{/number}","events_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/events","assignees_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/assignees{/user}","branches_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/branches{/branch}","tags_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/tags","blobs_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/languages","stargazers_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/stargazers","contributors_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/contributors","subscribers_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/subscribers","subscription_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/subscription","commits_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/contents/{+path}","compare_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/merges","archive_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/downloads","issues_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/issues{/number}","pulls_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/labels{/name}","releases_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/releases{/id}","deployments_url":"https://api.github.com/repos/GeeWee/create-react-app-typescript/deployments","created_at":"2018-01-27T07:55:41Z","updated_at":"2018-01-27T07:55:47Z","pushed_at":"2018-02-12T09:12:13Z","git_url":"git://github.com/GeeWee/create-react-app-typescript.git","ssh_url":"git@github.com:GeeWee/create-react-app-typescript.git","clone_url":"https://github.com/GeeWee/create-react-app-typescript.git","svn_url":"https://github.com/GeeWee/create-react-app-typescript","homepage":"https://www.npmjs.com/package/react-scripts-ts","size":4666,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wmonk:master","ref":"master","sha":"7c0032bf6db21fd236fe6d7bc1d4b419ff946420","user":{"login":"wmonk","id":175278,"avatar_url":"https://avatars0.githubusercontent.com/u/175278?v=4","gravatar_id":"","url":"https://api.github.com/users/wmonk","html_url":"https://github.com/wmonk","followers_url":"https://api.github.com/users/wmonk/followers","following_url":"https://api.github.com/users/wmonk/following{/other_user}","gists_url":"https://api.github.com/users/wmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/wmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmonk/subscriptions","organizations_url":"https://api.github.com/users/wmonk/orgs","repos_url":"https://api.github.com/users/wmonk/repos","events_url":"https://api.github.com/users/wmonk/events{/privacy}","received_events_url":"https://api.github.com/users/wmonk/received_events","type":"User","site_admin":false},"repo":{"id":76130347,"name":"create-react-app-typescript","full_name":"wmonk/create-react-app-typescript","owner":{"login":"wmonk","id":175278,"avatar_url":"https://avatars0.githubusercontent.com/u/175278?v=4","gravatar_id":"","url":"https://api.github.com/users/wmonk","html_url":"https://github.com/wmonk","followers_url":"https://api.github.com/users/wmonk/followers","following_url":"https://api.github.com/users/wmonk/following{/other_user}","gists_url":"https://api.github.com/users/wmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/wmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmonk/subscriptions","organizations_url":"https://api.github.com/users/wmonk/orgs","repos_url":"https://api.github.com/users/wmonk/repos","events_url":"https://api.github.com/users/wmonk/events{/privacy}","received_events_url":"https://api.github.com/users/wmonk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wmonk/create-react-app-typescript","description":"Create React apps using typescript with no build configuration.","fork":true,"url":"https://api.github.com/repos/wmonk/create-react-app-typescript","forks_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/forks","keys_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/teams","hooks_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/hooks","issue_events_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/issues/events{/number}","events_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/events","assignees_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/assignees{/user}","branches_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/branches{/branch}","tags_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/tags","blobs_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/languages","stargazers_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/stargazers","contributors_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/contributors","subscribers_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/subscribers","subscription_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/subscription","commits_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/contents/{+path}","compare_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/merges","archive_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/downloads","issues_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/issues{/number}","pulls_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/labels{/name}","releases_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/releases{/id}","deployments_url":"https://api.github.com/repos/wmonk/create-react-app-typescript/deployments","created_at":"2016-12-10T18:34:32Z","updated_at":"2018-02-13T07:37:21Z","pushed_at":"2018-02-13T09:00:44Z","git_url":"git://github.com/wmonk/create-react-app-typescript.git","ssh_url":"git@github.com:wmonk/create-react-app-typescript.git","clone_url":"https://github.com/wmonk/create-react-app-typescript.git","svn_url":"https://github.com/wmonk/create-react-app-typescript","homepage":"https://www.npmjs.com/package/react-scripts-ts","size":4658,"stargazers_count":1676,"watchers_count":1676,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":180,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":180,"open_issues":39,"watchers":1676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmonk/create-react-app-typescript/pulls/242"},"html":{"href":"https://github.com/wmonk/create-react-app-typescript/pull/242"},"issue":{"href":"https://api.github.com/repos/wmonk/create-react-app-typescript/issues/242"},"comments":{"href":"https://api.github.com/repos/wmonk/create-react-app-typescript/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/wmonk/create-react-app-typescript/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/wmonk/create-react-app-typescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wmonk/create-react-app-typescript/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/wmonk/create-react-app-typescript/statuses/69eaa289bb50d000fb930b8f8766da0f7314801e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"DorianGrey","id":1473055,"avatar_url":"https://avatars0.githubusercontent.com/u/1473055?v=4","gravatar_id":"","url":"https://api.github.com/users/DorianGrey","html_url":"https://github.com/DorianGrey","followers_url":"https://api.github.com/users/DorianGrey/followers","following_url":"https://api.github.com/users/DorianGrey/following{/other_user}","gists_url":"https://api.github.com/users/DorianGrey/gists{/gist_id}","starred_url":"https://api.github.com/users/DorianGrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DorianGrey/subscriptions","organizations_url":"https://api.github.com/users/DorianGrey/orgs","repos_url":"https://api.github.com/users/DorianGrey/repos","events_url":"https://api.github.com/users/DorianGrey/events{/privacy}","received_events_url":"https://api.github.com/users/DorianGrey/received_events","type":"User","site_admin":false},"comments":11,"review_comments":13,"maintainer_can_modify":false,"commits":18,"additions":57,"deletions":10,"changed_files":6}}
{"actor":{"display_login":"DorianGrey"}}