{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls/comments/183370604","pull_request_review_id":114352959,"id":183370604,"diff_hunk":"@@ -68,8 +67,7 @@ const sessions = module.exports = { // eslint-disable-line no-multi-assign\n         saveUninitialized: true,\n         cookie: {\n           secure: cookieSecure,\n-          httpOnly: true,\n-          domain: hostName","path":"app/middleware/sessions.js","position":21,"original_position":21,"commit_id":"c756fcbb7d54f46f01dd16b4d765e5de21f210b7","original_commit_id":"c756fcbb7d54f46f01dd16b4d765e5de21f210b7","user":{"login":"dtaylor7","id":961020,"avatar_url":"https://avatars2.githubusercontent.com/u/961020?v=4","gravatar_id":"","url":"https://api.github.com/users/dtaylor7","html_url":"https://github.com/dtaylor7","followers_url":"https://api.github.com/users/dtaylor7/followers","following_url":"https://api.github.com/users/dtaylor7/following{/other_user}","gists_url":"https://api.github.com/users/dtaylor7/gists{/gist_id}","starred_url":"https://api.github.com/users/dtaylor7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtaylor7/subscriptions","organizations_url":"https://api.github.com/users/dtaylor7/orgs","repos_url":"https://api.github.com/users/dtaylor7/repos","events_url":"https://api.github.com/users/dtaylor7/events{/privacy}","received_events_url":"https://api.github.com/users/dtaylor7/received_events","type":"User","site_admin":false},"body":"you are not restricting cookies to a domain now?","created_at":"2018-04-23T12:07:05Z","updated_at":"2018-04-23T12:10:12Z","html_url":"https://github.com/hmcts/div-petitioner-frontend/pull/68#discussion_r183370604","pull_request_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls/68","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls/comments/183370604"},"html":{"href":"https://github.com/hmcts/div-petitioner-frontend/pull/68#discussion_r183370604"},"pull_request":{"href":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls/68","id":181466283,"html_url":"https://github.com/hmcts/div-petitioner-frontend/pull/68","diff_url":"https://github.com/hmcts/div-petitioner-frontend/pull/68.diff","patch_url":"https://github.com/hmcts/div-petitioner-frontend/pull/68.patch","issue_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/issues/68","number":68,"state":"open","locked":false,"title":"Cnp","user":{"login":"tchow8","id":36265570,"avatar_url":"https://avatars3.githubusercontent.com/u/36265570?v=4","gravatar_id":"","url":"https://api.github.com/users/tchow8","html_url":"https://github.com/tchow8","followers_url":"https://api.github.com/users/tchow8/followers","following_url":"https://api.github.com/users/tchow8/following{/other_user}","gists_url":"https://api.github.com/users/tchow8/gists{/gist_id}","starred_url":"https://api.github.com/users/tchow8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchow8/subscriptions","organizations_url":"https://api.github.com/users/tchow8/orgs","repos_url":"https://api.github.com/users/tchow8/repos","events_url":"https://api.github.com/users/tchow8/events{/privacy}","received_events_url":"https://api.github.com/users/tchow8/received_events","type":"User","site_admin":false},"body":"# Description\r\n\r\nThis PR contains all the changes applied to the CNP branch in order to deploy into AAT and Demo on CNP.\r\n\r\nThe main changes are:\r\nAdding in a Jenkinsfile_CNP (for AAT) and Jenkinsfile_parameterized (for Sandbox) which will get picked up by the relevent Jenkins build agent for deployment.\r\n\r\nAdding in terraform var files which define the deployment parameters and application environment variables for Sandbox, AAT and Demo.\r\n\r\nAs EM Client API should now point to CNP, which should implement PaloAlto, ClamAV has been removed as part of this PR, and tests adjusted. The token to be passed to EM Client API has been changed from the 'authorizationToken' header to a 'Authorization' header as per standard now.\r\nAs CNP urls return SSL cert errors for self signed certificates, where we are using our own Divorce Backend Services, a function to replace the https:// with http:// is in the healthcheck.js. Http:// is still a valid protocol, which should be acceptable for internal connections.\r\n\r\nNumerous package.json script changes were made to be compatible with CNP deployment script, as such please make note of what may have changed. For example, 'yarn test' now only runs unit tests and not coverage, a11y and e2e. Those have been moved to 'yarn test-all'.\r\n\r\nFunctional and Smoke Tests have been implemented and working locally (as CNP does not have the xfvb plugin to run headless browser testing), but due to a docker-compose version being outdated issue on CNP, these tests are currently disabled and simply output an echo.\r\n\r\nLogging has been updated to use the latest HMCTS nodeJs logger with support for AppInsights. As such the code has very slightly changed to use a Logger object instead of directly using the module.export. This is an extremely minor change from' logger.getLogger' to 'logger.Logger.getLogger' for example.\r\n\r\nFixes # (issue)\r\n\r\n## Type of change\r\n\r\nPlease delete options that are not relevant.\r\n- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [x] This change requires a documentation update\r\n\r\n# How Has This Been Tested?\r\n\r\nCNP changes are mostly non-functional. No new features has been added, but old features have been slightly modified. Testing was done locally and a deployment to Demo CNP was done using the same code base.\r\n\r\n**Test Configuration**:\r\n\r\n* Hardware: Mid-range Laptop\r\n* O/S and version: Ubuntu 17\r\n* JDK: Java 8\r\n\r\n# Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project\r\n- [x] I have performed a self-review of my own code\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [ ] I have made corresponding changes to the documentation\r\n- [x] My changes generate no new warnings\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [x] New and existing unit tests pass locally with my changes\r\n- [x] Any dependent changes have been merged and published in downstream modules\r\n","created_at":"2018-04-13T11:55:13Z","updated_at":"2018-04-23T12:10:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f628fe67800c7b3f4626ba814700a5ad49afe465","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mrganeshraja","id":2074783,"avatar_url":"https://avatars2.githubusercontent.com/u/2074783?v=4","gravatar_id":"","url":"https://api.github.com/users/mrganeshraja","html_url":"https://github.com/mrganeshraja","followers_url":"https://api.github.com/users/mrganeshraja/followers","following_url":"https://api.github.com/users/mrganeshraja/following{/other_user}","gists_url":"https://api.github.com/users/mrganeshraja/gists{/gist_id}","starred_url":"https://api.github.com/users/mrganeshraja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrganeshraja/subscriptions","organizations_url":"https://api.github.com/users/mrganeshraja/orgs","repos_url":"https://api.github.com/users/mrganeshraja/repos","events_url":"https://api.github.com/users/mrganeshraja/events{/privacy}","received_events_url":"https://api.github.com/users/mrganeshraja/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls/68/commits","review_comments_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls/68/comments","review_comment_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/issues/68/comments","statuses_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/statuses/c756fcbb7d54f46f01dd16b4d765e5de21f210b7","head":{"label":"hmcts:cnp","ref":"cnp","sha":"c756fcbb7d54f46f01dd16b4d765e5de21f210b7","user":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":121263307,"name":"div-petitioner-frontend","full_name":"hmcts/div-petitioner-frontend","owner":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/div-petitioner-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/div-petitioner-frontend","forks_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/forks","keys_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/teams","hooks_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/events","assignees_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/tags","blobs_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/languages","stargazers_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/subscription","commits_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/merges","archive_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/downloads","issues_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/deployments","created_at":"2018-02-12T15:23:33Z","updated_at":"2018-04-23T11:33:39Z","pushed_at":"2018-04-23T11:51:47Z","git_url":"git://github.com/hmcts/div-petitioner-frontend.git","ssh_url":"git@github.com:hmcts/div-petitioner-frontend.git","clone_url":"https://github.com/hmcts/div-petitioner-frontend.git","svn_url":"https://github.com/hmcts/div-petitioner-frontend","homepage":null,"size":1466,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":16,"watchers":0,"default_branch":"develop"}},"base":{"label":"hmcts:master","ref":"master","sha":"47e3146d1c65947ea05bf66f46da663b0aa84ad5","user":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":121263307,"name":"div-petitioner-frontend","full_name":"hmcts/div-petitioner-frontend","owner":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/div-petitioner-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/div-petitioner-frontend","forks_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/forks","keys_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/teams","hooks_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/events","assignees_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/tags","blobs_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/languages","stargazers_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/subscription","commits_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/merges","archive_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/downloads","issues_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/div-petitioner-frontend/deployments","created_at":"2018-02-12T15:23:33Z","updated_at":"2018-04-23T11:33:39Z","pushed_at":"2018-04-23T11:51:47Z","git_url":"git://github.com/hmcts/div-petitioner-frontend.git","ssh_url":"git@github.com:hmcts/div-petitioner-frontend.git","clone_url":"https://github.com/hmcts/div-petitioner-frontend.git","svn_url":"https://github.com/hmcts/div-petitioner-frontend","homepage":null,"size":1466,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":16,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls/68"},"html":{"href":"https://github.com/hmcts/div-petitioner-frontend/pull/68"},"issue":{"href":"https://api.github.com/repos/hmcts/div-petitioner-frontend/issues/68"},"comments":{"href":"https://api.github.com/repos/hmcts/div-petitioner-frontend/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/div-petitioner-frontend/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/div-petitioner-frontend/statuses/c756fcbb7d54f46f01dd16b4d765e5de21f210b7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dtaylor7"}}