{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/239282578","pull_request_review_id":182022048,"id":239282578,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTI4MjU3OA==","diff_hunk":"@@ -84,13 +86,8 @@ class MDCTabBar extends MDCComponent {\n     tabScrollerFactory = (el) => new MDCTabScroller(el)) {\n     this.tabFactory_ = tabFactory;\n     this.tabScrollerFactory_ = tabScrollerFactory;\n-\n-    this.tabList_ = this.getTabElements_().map((el) => this.tabFactory_(el));\n-\n-    const tabScrollerElement = this.root_.querySelector(MDCTabBarFoundation.strings.TAB_SCROLLER_SELECTOR);\n-    if (tabScrollerElement) {\n-      this.tabScroller_ = this.tabScrollerFactory_(tabScrollerElement);\n-    }\n+    this.tabList_ = this.instantiateTabs_(this.tabFactory_);","path":"packages/mdc-tab-bar/index.js","position":20,"original_position":20,"commit_id":"b66522ad4e6449790df781f6a5e62342c9083493","original_commit_id":"b66522ad4e6449790df781f6a5e62342c9083493","user":{"login":"kfranqueiro","id":398379,"node_id":"MDQ6VXNlcjM5ODM3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/398379?v=4","gravatar_id":"","url":"https://api.github.com/users/kfranqueiro","html_url":"https://github.com/kfranqueiro","followers_url":"https://api.github.com/users/kfranqueiro/followers","following_url":"https://api.github.com/users/kfranqueiro/following{/other_user}","gists_url":"https://api.github.com/users/kfranqueiro/gists{/gist_id}","starred_url":"https://api.github.com/users/kfranqueiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfranqueiro/subscriptions","organizations_url":"https://api.github.com/users/kfranqueiro/orgs","repos_url":"https://api.github.com/users/kfranqueiro/repos","events_url":"https://api.github.com/users/kfranqueiro/events{/privacy}","received_events_url":"https://api.github.com/users/kfranqueiro/received_events","type":"User","site_admin":false},"body":"Can we just pass `tabFactory`? Does `this.tabFactory_` even need to exist? Ditto for `this.tabScrollerFactory_`.","created_at":"2018-12-05T23:49:43Z","updated_at":"2018-12-05T23:51:21Z","html_url":"https://github.com/material-components/material-components-web/pull/4149#discussion_r239282578","pull_request_url":"https://api.github.com/repos/material-components/material-components-web/pulls/4149","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/239282578"},"html":{"href":"https://github.com/material-components/material-components-web/pull/4149#discussion_r239282578"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/4149"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/4149","id":236353374,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzUzMzc0","html_url":"https://github.com/material-components/material-components-web/pull/4149","diff_url":"https://github.com/material-components/material-components-web/pull/4149.diff","patch_url":"https://github.com/material-components/material-components-web/pull/4149.patch","issue_url":"https://api.github.com/repos/material-components/material-components-web/issues/4149","number":4149,"state":"open","locked":false,"title":"feat(tab): Get tabs by their ID","user":{"login":"patrickrodee","id":5939574,"node_id":"MDQ6VXNlcjU5Mzk1NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5939574?v=4","gravatar_id":"","url":"https://api.github.com/users/patrickrodee","html_url":"https://github.com/patrickrodee","followers_url":"https://api.github.com/users/patrickrodee/followers","following_url":"https://api.github.com/users/patrickrodee/following{/other_user}","gists_url":"https://api.github.com/users/patrickrodee/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickrodee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickrodee/subscriptions","organizations_url":"https://api.github.com/users/patrickrodee/orgs","repos_url":"https://api.github.com/users/patrickrodee/repos","events_url":"https://api.github.com/users/patrickrodee/events{/privacy}","received_events_url":"https://api.github.com/users/patrickrodee/received_events","type":"User","site_admin":false},"body":"Use unique identifiers to reference tabs instead of the object equality comparison. Change the `getIndexOfTab` method to `getIndexOfTabByID`. Update tests.\r\n\r\nBREAKING CHANGE: `MDCTabBar#getIndexOfTab(tab: MDCTab): boolean` is now `MDCTabBar#getIndexOfTabByID(id: string): boolean`","created_at":"2018-12-05T23:03:51Z","updated_at":"2018-12-05T23:51:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c2affb4b249354290870bf1a1816be5ab10b3be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1036895551,"node_id":"MDU6TGFiZWwxMDM2ODk1NTUx","url":"https://api.github.com/repos/material-components/material-components-web/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-web/pulls/4149/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-web/pulls/4149/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-web/issues/4149/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/b66522ad4e6449790df781f6a5e62342c9083493","head":{"label":"material-components:feat/tabs/getIndexOfTabByID","ref":"feat/tabs/getIndexOfTabByID","sha":"b66522ad4e6449790df781f6a5e62342c9083493","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-12-05T23:29:50Z","pushed_at":"2018-12-05T23:30:23Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/develop/","size":73515,"stargazers_count":10983,"watchers_count":10983,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1350,"mirror_url":null,"archived":false,"open_issues_count":324,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1350,"open_issues":324,"watchers":10983,"default_branch":"master"}},"base":{"label":"material-components:master","ref":"master","sha":"167add5047b5ffb184703e54241f0bf6edbb0d6a","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-12-05T23:29:50Z","pushed_at":"2018-12-05T23:30:23Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/develop/","size":73515,"stargazers_count":10983,"watchers_count":10983,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1350,"mirror_url":null,"archived":false,"open_issues_count":324,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1350,"open_issues":324,"watchers":10983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/4149"},"html":{"href":"https://github.com/material-components/material-components-web/pull/4149"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/4149"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/4149/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/4149/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/4149/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-web/statuses/b66522ad4e6449790df781f6a5e62342c9083493"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kfranqueiro"}}