{"action":"created","issue":{"url":"https://api.github.com/repos/jfoenixadmin/JFoenix/issues/773","repository_url":"https://api.github.com/repos/jfoenixadmin/JFoenix","labels_url":"https://api.github.com/repos/jfoenixadmin/JFoenix/issues/773/labels{/name}","comments_url":"https://api.github.com/repos/jfoenixadmin/JFoenix/issues/773/comments","events_url":"https://api.github.com/repos/jfoenixadmin/JFoenix/issues/773/events","html_url":"https://github.com/jfoenixadmin/JFoenix/issues/773","id":338392431,"node_id":"MDU6SXNzdWUzMzgzOTI0MzE=","number":773,"title":"Changeable in animation speed of JFXRippler","user":{"login":"schlegel11","id":5841076,"node_id":"MDQ6VXNlcjU4NDEwNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/5841076?v=4","gravatar_id":"","url":"https://api.github.com/users/schlegel11","html_url":"https://github.com/schlegel11","followers_url":"https://api.github.com/users/schlegel11/followers","following_url":"https://api.github.com/users/schlegel11/following{/other_user}","gists_url":"https://api.github.com/users/schlegel11/gists{/gist_id}","starred_url":"https://api.github.com/users/schlegel11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlegel11/subscriptions","organizations_url":"https://api.github.com/users/schlegel11/orgs","repos_url":"https://api.github.com/users/schlegel11/repos","events_url":"https://api.github.com/users/schlegel11/events{/privacy}","received_events_url":"https://api.github.com/users/schlegel11/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-07-05T00:03:18Z","updated_at":"2018-09-28T15:16:46Z","closed_at":null,"author_association":"NONE","body":"It would be great if there is a method where you can set a duration speed of an animation like:\r\nrippler.setInAnimationSpeed(Duration d);\r\n\r\nor something like that :)"},"comment":{"url":"https://api.github.com/repos/jfoenixadmin/JFoenix/issues/comments/425469424","html_url":"https://github.com/jfoenixadmin/JFoenix/issues/773#issuecomment-425469424","issue_url":"https://api.github.com/repos/jfoenixadmin/JFoenix/issues/773","id":425469424,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTQ2OTQyNA==","user":{"login":"schlegel11","id":5841076,"node_id":"MDQ6VXNlcjU4NDEwNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/5841076?v=4","gravatar_id":"","url":"https://api.github.com/users/schlegel11","html_url":"https://github.com/schlegel11","followers_url":"https://api.github.com/users/schlegel11/followers","following_url":"https://api.github.com/users/schlegel11/following{/other_user}","gists_url":"https://api.github.com/users/schlegel11/gists{/gist_id}","starred_url":"https://api.github.com/users/schlegel11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlegel11/subscriptions","organizations_url":"https://api.github.com/users/schlegel11/orgs","repos_url":"https://api.github.com/users/schlegel11/repos","events_url":"https://api.github.com/users/schlegel11/events{/privacy}","received_events_url":"https://api.github.com/users/schlegel11/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T15:16:46Z","updated_at":"2018-09-28T15:16:46Z","author_association":"NONE","body":"Hi,\r\nyes ok Template sounds good why not :blush: \r\n\r\nThe noTargets() is more or less used just for delegation (if you don't want a target but just the e.g. onFinish() method as a handler). The GenericBuilderWrapper is bad named :wink: I renamed this class to InitBuilder. It has in general the same purpose as the JFXKeyValue.Builder for the type inference. So you must call a target() method first for define the WritableValue generic. It would be also a possibility to define all other methods in the InitBuilder class but I think it's not really necessary.\r\n\r\nThe one forced argument in the target() method is supposed to really handle one or more tragets so that you can't write just targets() .\r\n\r\nThe JFXAnimationBuilder is maybe also bad named because it's not the builder itself like the JFXAnimationCreator it holds just the implementation to build a Timeline or JFXAnimationTimer.\r\nThe decoupling is because you can have different implementations.\r\nYou are right it's more or less like the Collectors class from the Stream api.\r\nThe build method from the JFXAnimationCreator can already take a such a builder or a implementation method. But it uses directly a Function<JFXAnimationCreator<N>, T> because there is only one argument needed (in this case the JFXAnimationCreator<N>) and only one function that is called.\r\nIn difference the Collector interface defines a lot more functions and it makes sense to use an Interface and a separate Factory class for the Collectors.\r\n\r\nThe creatorConfigBuilderFunction returns the lambda Function which takes an instance of the JFXAnimationCreatorConfig.Builder and returns a JFXAnimationCreator which is used for define e.g. the properties of a Timeline.\r\nI refactored all the names that it makes hopefully a little more sense :wink: \r\n\r\n\r\n "}}
{"actor":{"display_login":"schlegel11"}}