{"action":"created","issue":{"url":"https://api.github.com/repos/modelica/VehicleInterfaces/issues/28","repository_url":"https://api.github.com/repos/modelica/VehicleInterfaces","labels_url":"https://api.github.com/repos/modelica/VehicleInterfaces/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/modelica/VehicleInterfaces/issues/28/comments","events_url":"https://api.github.com/repos/modelica/VehicleInterfaces/issues/28/events","html_url":"https://github.com/modelica/VehicleInterfaces/issues/28","id":330547780,"node_id":"MDU6SXNzdWUzMzA1NDc3ODA=","number":28,"title":"Reintroduce the idea of expandable connectors for signal buses","user":{"login":"tobolar","id":9588978,"node_id":"MDQ6VXNlcjk1ODg5Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/9588978?v=4","gravatar_id":"","url":"https://api.github.com/users/tobolar","html_url":"https://github.com/tobolar","followers_url":"https://api.github.com/users/tobolar/followers","following_url":"https://api.github.com/users/tobolar/following{/other_user}","gists_url":"https://api.github.com/users/tobolar/gists{/gist_id}","starred_url":"https://api.github.com/users/tobolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobolar/subscriptions","organizations_url":"https://api.github.com/users/tobolar/orgs","repos_url":"https://api.github.com/users/tobolar/repos","events_url":"https://api.github.com/users/tobolar/events{/privacy}","received_events_url":"https://api.github.com/users/tobolar/received_events","type":"User","site_admin":false},"labels":[{"id":957626800,"node_id":"MDU6TGFiZWw5NTc2MjY4MDA=","url":"https://api.github.com/repos/modelica/VehicleInterfaces/labels/discussion","name":"discussion","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"tobolar","id":9588978,"node_id":"MDQ6VXNlcjk1ODg5Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/9588978?v=4","gravatar_id":"","url":"https://api.github.com/users/tobolar","html_url":"https://github.com/tobolar","followers_url":"https://api.github.com/users/tobolar/followers","following_url":"https://api.github.com/users/tobolar/following{/other_user}","gists_url":"https://api.github.com/users/tobolar/gists{/gist_id}","starred_url":"https://api.github.com/users/tobolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobolar/subscriptions","organizations_url":"https://api.github.com/users/tobolar/orgs","repos_url":"https://api.github.com/users/tobolar/repos","events_url":"https://api.github.com/users/tobolar/events{/privacy}","received_events_url":"https://api.github.com/users/tobolar/received_events","type":"User","site_admin":false},"assignees":[{"login":"tobolar","id":9588978,"node_id":"MDQ6VXNlcjk1ODg5Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/9588978?v=4","gravatar_id":"","url":"https://api.github.com/users/tobolar","html_url":"https://github.com/tobolar","followers_url":"https://api.github.com/users/tobolar/followers","following_url":"https://api.github.com/users/tobolar/following{/other_user}","gists_url":"https://api.github.com/users/tobolar/gists{/gist_id}","starred_url":"https://api.github.com/users/tobolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobolar/subscriptions","organizations_url":"https://api.github.com/users/tobolar/orgs","repos_url":"https://api.github.com/users/tobolar/repos","events_url":"https://api.github.com/users/tobolar/events{/privacy}","received_events_url":"https://api.github.com/users/tobolar/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/modelica/VehicleInterfaces/milestones/4","html_url":"https://github.com/modelica/VehicleInterfaces/milestone/4","labels_url":"https://api.github.com/repos/modelica/VehicleInterfaces/milestones/4/labels","id":3407805,"node_id":"MDk6TWlsZXN0b25lMzQwNzgwNQ==","number":4,"title":"v2.0.0","description":"Major version with conversion script","creator":{"login":"harmanpa","id":1428593,"node_id":"MDQ6VXNlcjE0Mjg1OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1428593?v=4","gravatar_id":"","url":"https://api.github.com/users/harmanpa","html_url":"https://github.com/harmanpa","followers_url":"https://api.github.com/users/harmanpa/followers","following_url":"https://api.github.com/users/harmanpa/following{/other_user}","gists_url":"https://api.github.com/users/harmanpa/gists{/gist_id}","starred_url":"https://api.github.com/users/harmanpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harmanpa/subscriptions","organizations_url":"https://api.github.com/users/harmanpa/orgs","repos_url":"https://api.github.com/users/harmanpa/repos","events_url":"https://api.github.com/users/harmanpa/events{/privacy}","received_events_url":"https://api.github.com/users/harmanpa/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2018-06-07T12:45:13Z","updated_at":"2018-06-21T14:20:35Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2018-06-08T07:24:21Z","updated_at":"2018-06-22T08:35:16Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The current approach with replaceable bus instances in models counteract the idea of expandable connectors. \r\nCurrently, signal bus connectors from `VehicleInterfaces.<assembly>.Interfaces` are always instantiated as replaceable in particular assembly models. This was introduced years ago. But actually this contradicts the idea of expandable connectors. Moreover, it makes problems in more complex vehicle architectures because then all bus connectors of an assembly should be of the same definition. This means to replace a plenty of connectors for a particular architecture.\r\nThe proper solution is to use \"empty\" bus connectors from `VehicleInterfaces.Interfaces` across the library as was the case in the early versions.\r\n\r\nSee also comments in #19 (and #17)."},"comment":{"url":"https://api.github.com/repos/modelica/VehicleInterfaces/issues/comments/399366706","html_url":"https://github.com/modelica/VehicleInterfaces/issues/28#issuecomment-399366706","issue_url":"https://api.github.com/repos/modelica/VehicleInterfaces/issues/28","id":399366706,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTM2NjcwNg==","user":{"login":"tobolar","id":9588978,"node_id":"MDQ6VXNlcjk1ODg5Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/9588978?v=4","gravatar_id":"","url":"https://api.github.com/users/tobolar","html_url":"https://github.com/tobolar","followers_url":"https://api.github.com/users/tobolar/followers","following_url":"https://api.github.com/users/tobolar/following{/other_user}","gists_url":"https://api.github.com/users/tobolar/gists{/gist_id}","starred_url":"https://api.github.com/users/tobolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobolar/subscriptions","organizations_url":"https://api.github.com/users/tobolar/orgs","repos_url":"https://api.github.com/users/tobolar/repos","events_url":"https://api.github.com/users/tobolar/events{/privacy}","received_events_url":"https://api.github.com/users/tobolar/received_events","type":"User","site_admin":false},"created_at":"2018-06-22T08:35:16Z","updated_at":"2018-06-22T08:35:16Z","author_association":"CONTRIBUTOR","body":"To be sure we trigger no possible conflict in a user's model, signal bus connectors in  `VehicleInterfaces.<assembly>.Internal` should include all signals of busses in `VehicleInterfaces.<assembly>.Interfaces`. May be this is fulfilled already but I will check.\r\n\r\nBut how to proceed in a best way? Should we reimplement this for comming v1.2.5 (which will be compatible to MSL v.3.2.3) or should we start non backward compatible v2.0.0 - which IMO is a safe way?"}}
{"actor":{"display_login":"tobolar"}}