{"action":"created","comment":{"url":"https://api.github.com/repos/phac-nml/bio_hansel/pulls/comments/168220428","pull_request_review_id":96552080,"id":168220428,"diff_hunk":"@@ -48,15 +48,21 @@\n n_tiles_matching_subtype\n n_tiles_matching_subtype_expected\n file_path\n+coverage","path":"bio_hansel/const.py","position":14,"original_position":14,"commit_id":"37438f9773252b647dcc8459c72c717d58988850","original_commit_id":"37438f9773252b647dcc8459c72c717d58988850","user":{"login":"hellothisisMatt","id":23063355,"avatar_url":"https://avatars1.githubusercontent.com/u/23063355?v=4","gravatar_id":"","url":"https://api.github.com/users/hellothisisMatt","html_url":"https://github.com/hellothisisMatt","followers_url":"https://api.github.com/users/hellothisisMatt/followers","following_url":"https://api.github.com/users/hellothisisMatt/following{/other_user}","gists_url":"https://api.github.com/users/hellothisisMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/hellothisisMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellothisisMatt/subscriptions","organizations_url":"https://api.github.com/users/hellothisisMatt/orgs","repos_url":"https://api.github.com/users/hellothisisMatt/repos","events_url":"https://api.github.com/users/hellothisisMatt/events{/privacy}","received_events_url":"https://api.github.com/users/hellothisisMatt/received_events","type":"User","site_admin":false},"body":"Agreed, I'll change it to that.","created_at":"2018-02-14T16:00:36Z","updated_at":"2018-02-14T16:00:36Z","html_url":"https://github.com/phac-nml/bio_hansel/pull/30#discussion_r168220428","pull_request_url":"https://api.github.com/repos/phac-nml/bio_hansel/pulls/30","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/phac-nml/bio_hansel/pulls/comments/168220428"},"html":{"href":"https://github.com/phac-nml/bio_hansel/pull/30#discussion_r168220428"},"pull_request":{"href":"https://api.github.com/repos/phac-nml/bio_hansel/pulls/30"}},"in_reply_to_id":167580980},"pull_request":{"url":"https://api.github.com/repos/phac-nml/bio_hansel/pulls/30","id":167729217,"html_url":"https://github.com/phac-nml/bio_hansel/pull/30","diff_url":"https://github.com/phac-nml/bio_hansel/pull/30.diff","patch_url":"https://github.com/phac-nml/bio_hansel/pull/30.patch","issue_url":"https://api.github.com/repos/phac-nml/bio_hansel/issues/30","number":30,"state":"open","locked":false,"title":"Fixes and QoL Additions","user":{"login":"hellothisisMatt","id":23063355,"avatar_url":"https://avatars1.githubusercontent.com/u/23063355?v=4","gravatar_id":"","url":"https://api.github.com/users/hellothisisMatt","html_url":"https://github.com/hellothisisMatt","followers_url":"https://api.github.com/users/hellothisisMatt/followers","following_url":"https://api.github.com/users/hellothisisMatt/following{/other_user}","gists_url":"https://api.github.com/users/hellothisisMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/hellothisisMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellothisisMatt/subscriptions","organizations_url":"https://api.github.com/users/hellothisisMatt/orgs","repos_url":"https://api.github.com/users/hellothisisMatt/repos","events_url":"https://api.github.com/users/hellothisisMatt/events{/privacy}","received_events_url":"https://api.github.com/users/hellothisisMatt/received_events","type":"User","site_admin":false},"body":"1) Adding fastqsanger to the list of fastq regex patterns.\r\n- This is needed as there were cases where fastqsanger wasn't being considered as a fastq file, while lead to kmer_cov_freq not being considered.\r\n2) Adding average coverage value column to the subtyping result. \r\n- Requested so that a user can check coverage in the results.\r\n3) Fixing order of parameters for blast method.\r\n- Incorrect order of parameters was causing the blast method to fail.\r\n\r\nFurther questions:\r\n- Do you think it's a good idea to have coverage present in the subtyping result? Or would you rather this be a new column in the DataFrame for match_results?\r\n","created_at":"2018-02-07T15:45:41Z","updated_at":"2018-02-14T16:00:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec9924a7fb8efe27b454185a6c946f52f7540cbd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/phac-nml/bio_hansel/pulls/30/commits","review_comments_url":"https://api.github.com/repos/phac-nml/bio_hansel/pulls/30/comments","review_comment_url":"https://api.github.com/repos/phac-nml/bio_hansel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phac-nml/bio_hansel/issues/30/comments","statuses_url":"https://api.github.com/repos/phac-nml/bio_hansel/statuses/37438f9773252b647dcc8459c72c717d58988850","head":{"label":"phac-nml:nice_to_haves","ref":"nice_to_haves","sha":"37438f9773252b647dcc8459c72c717d58988850","user":{"login":"phac-nml","id":15620262,"avatar_url":"https://avatars0.githubusercontent.com/u/15620262?v=4","gravatar_id":"","url":"https://api.github.com/users/phac-nml","html_url":"https://github.com/phac-nml","followers_url":"https://api.github.com/users/phac-nml/followers","following_url":"https://api.github.com/users/phac-nml/following{/other_user}","gists_url":"https://api.github.com/users/phac-nml/gists{/gist_id}","starred_url":"https://api.github.com/users/phac-nml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phac-nml/subscriptions","organizations_url":"https://api.github.com/users/phac-nml/orgs","repos_url":"https://api.github.com/users/phac-nml/repos","events_url":"https://api.github.com/users/phac-nml/events{/privacy}","received_events_url":"https://api.github.com/users/phac-nml/received_events","type":"Organization","site_admin":false},"repo":{"id":103222666,"name":"bio_hansel","full_name":"phac-nml/bio_hansel","owner":{"login":"phac-nml","id":15620262,"avatar_url":"https://avatars0.githubusercontent.com/u/15620262?v=4","gravatar_id":"","url":"https://api.github.com/users/phac-nml","html_url":"https://github.com/phac-nml","followers_url":"https://api.github.com/users/phac-nml/followers","following_url":"https://api.github.com/users/phac-nml/following{/other_user}","gists_url":"https://api.github.com/users/phac-nml/gists{/gist_id}","starred_url":"https://api.github.com/users/phac-nml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phac-nml/subscriptions","organizations_url":"https://api.github.com/users/phac-nml/orgs","repos_url":"https://api.github.com/users/phac-nml/repos","events_url":"https://api.github.com/users/phac-nml/events{/privacy}","received_events_url":"https://api.github.com/users/phac-nml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phac-nml/bio_hansel","description":"Subtype microbial genomes using SNV targeting k-mer subtyping schemes","fork":false,"url":"https://api.github.com/repos/phac-nml/bio_hansel","forks_url":"https://api.github.com/repos/phac-nml/bio_hansel/forks","keys_url":"https://api.github.com/repos/phac-nml/bio_hansel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phac-nml/bio_hansel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phac-nml/bio_hansel/teams","hooks_url":"https://api.github.com/repos/phac-nml/bio_hansel/hooks","issue_events_url":"https://api.github.com/repos/phac-nml/bio_hansel/issues/events{/number}","events_url":"https://api.github.com/repos/phac-nml/bio_hansel/events","assignees_url":"https://api.github.com/repos/phac-nml/bio_hansel/assignees{/user}","branches_url":"https://api.github.com/repos/phac-nml/bio_hansel/branches{/branch}","tags_url":"https://api.github.com/repos/phac-nml/bio_hansel/tags","blobs_url":"https://api.github.com/repos/phac-nml/bio_hansel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phac-nml/bio_hansel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phac-nml/bio_hansel/git/refs{/sha}","trees_url":"https://api.github.com/repos/phac-nml/bio_hansel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phac-nml/bio_hansel/statuses/{sha}","languages_url":"https://api.github.com/repos/phac-nml/bio_hansel/languages","stargazers_url":"https://api.github.com/repos/phac-nml/bio_hansel/stargazers","contributors_url":"https://api.github.com/repos/phac-nml/bio_hansel/contributors","subscribers_url":"https://api.github.com/repos/phac-nml/bio_hansel/subscribers","subscription_url":"https://api.github.com/repos/phac-nml/bio_hansel/subscription","commits_url":"https://api.github.com/repos/phac-nml/bio_hansel/commits{/sha}","git_commits_url":"https://api.github.com/repos/phac-nml/bio_hansel/git/commits{/sha}","comments_url":"https://api.github.com/repos/phac-nml/bio_hansel/comments{/number}","issue_comment_url":"https://api.github.com/repos/phac-nml/bio_hansel/issues/comments{/number}","contents_url":"https://api.github.com/repos/phac-nml/bio_hansel/contents/{+path}","compare_url":"https://api.github.com/repos/phac-nml/bio_hansel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phac-nml/bio_hansel/merges","archive_url":"https://api.github.com/repos/phac-nml/bio_hansel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phac-nml/bio_hansel/downloads","issues_url":"https://api.github.com/repos/phac-nml/bio_hansel/issues{/number}","pulls_url":"https://api.github.com/repos/phac-nml/bio_hansel/pulls{/number}","milestones_url":"https://api.github.com/repos/phac-nml/bio_hansel/milestones{/number}","notifications_url":"https://api.github.com/repos/phac-nml/bio_hansel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phac-nml/bio_hansel/labels{/name}","releases_url":"https://api.github.com/repos/phac-nml/bio_hansel/releases{/id}","deployments_url":"https://api.github.com/repos/phac-nml/bio_hansel/deployments","created_at":"2017-09-12T04:34:51Z","updated_at":"2017-12-18T21:33:07Z","pushed_at":"2018-02-09T17:56:27Z","git_url":"git://github.com/phac-nml/bio_hansel.git","ssh_url":"git@github.com:phac-nml/bio_hansel.git","clone_url":"https://github.com/phac-nml/bio_hansel.git","svn_url":"https://github.com/phac-nml/bio_hansel","homepage":"","size":12129,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"phac-nml:master","ref":"master","sha":"0e3aaa88cfb1d6b0378ef5975a790415f94d3612","user":{"login":"phac-nml","id":15620262,"avatar_url":"https://avatars0.githubusercontent.com/u/15620262?v=4","gravatar_id":"","url":"https://api.github.com/users/phac-nml","html_url":"https://github.com/phac-nml","followers_url":"https://api.github.com/users/phac-nml/followers","following_url":"https://api.github.com/users/phac-nml/following{/other_user}","gists_url":"https://api.github.com/users/phac-nml/gists{/gist_id}","starred_url":"https://api.github.com/users/phac-nml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phac-nml/subscriptions","organizations_url":"https://api.github.com/users/phac-nml/orgs","repos_url":"https://api.github.com/users/phac-nml/repos","events_url":"https://api.github.com/users/phac-nml/events{/privacy}","received_events_url":"https://api.github.com/users/phac-nml/received_events","type":"Organization","site_admin":false},"repo":{"id":103222666,"name":"bio_hansel","full_name":"phac-nml/bio_hansel","owner":{"login":"phac-nml","id":15620262,"avatar_url":"https://avatars0.githubusercontent.com/u/15620262?v=4","gravatar_id":"","url":"https://api.github.com/users/phac-nml","html_url":"https://github.com/phac-nml","followers_url":"https://api.github.com/users/phac-nml/followers","following_url":"https://api.github.com/users/phac-nml/following{/other_user}","gists_url":"https://api.github.com/users/phac-nml/gists{/gist_id}","starred_url":"https://api.github.com/users/phac-nml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phac-nml/subscriptions","organizations_url":"https://api.github.com/users/phac-nml/orgs","repos_url":"https://api.github.com/users/phac-nml/repos","events_url":"https://api.github.com/users/phac-nml/events{/privacy}","received_events_url":"https://api.github.com/users/phac-nml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phac-nml/bio_hansel","description":"Subtype microbial genomes using SNV targeting k-mer subtyping schemes","fork":false,"url":"https://api.github.com/repos/phac-nml/bio_hansel","forks_url":"https://api.github.com/repos/phac-nml/bio_hansel/forks","keys_url":"https://api.github.com/repos/phac-nml/bio_hansel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phac-nml/bio_hansel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phac-nml/bio_hansel/teams","hooks_url":"https://api.github.com/repos/phac-nml/bio_hansel/hooks","issue_events_url":"https://api.github.com/repos/phac-nml/bio_hansel/issues/events{/number}","events_url":"https://api.github.com/repos/phac-nml/bio_hansel/events","assignees_url":"https://api.github.com/repos/phac-nml/bio_hansel/assignees{/user}","branches_url":"https://api.github.com/repos/phac-nml/bio_hansel/branches{/branch}","tags_url":"https://api.github.com/repos/phac-nml/bio_hansel/tags","blobs_url":"https://api.github.com/repos/phac-nml/bio_hansel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phac-nml/bio_hansel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phac-nml/bio_hansel/git/refs{/sha}","trees_url":"https://api.github.com/repos/phac-nml/bio_hansel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phac-nml/bio_hansel/statuses/{sha}","languages_url":"https://api.github.com/repos/phac-nml/bio_hansel/languages","stargazers_url":"https://api.github.com/repos/phac-nml/bio_hansel/stargazers","contributors_url":"https://api.github.com/repos/phac-nml/bio_hansel/contributors","subscribers_url":"https://api.github.com/repos/phac-nml/bio_hansel/subscribers","subscription_url":"https://api.github.com/repos/phac-nml/bio_hansel/subscription","commits_url":"https://api.github.com/repos/phac-nml/bio_hansel/commits{/sha}","git_commits_url":"https://api.github.com/repos/phac-nml/bio_hansel/git/commits{/sha}","comments_url":"https://api.github.com/repos/phac-nml/bio_hansel/comments{/number}","issue_comment_url":"https://api.github.com/repos/phac-nml/bio_hansel/issues/comments{/number}","contents_url":"https://api.github.com/repos/phac-nml/bio_hansel/contents/{+path}","compare_url":"https://api.github.com/repos/phac-nml/bio_hansel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phac-nml/bio_hansel/merges","archive_url":"https://api.github.com/repos/phac-nml/bio_hansel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phac-nml/bio_hansel/downloads","issues_url":"https://api.github.com/repos/phac-nml/bio_hansel/issues{/number}","pulls_url":"https://api.github.com/repos/phac-nml/bio_hansel/pulls{/number}","milestones_url":"https://api.github.com/repos/phac-nml/bio_hansel/milestones{/number}","notifications_url":"https://api.github.com/repos/phac-nml/bio_hansel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phac-nml/bio_hansel/labels{/name}","releases_url":"https://api.github.com/repos/phac-nml/bio_hansel/releases{/id}","deployments_url":"https://api.github.com/repos/phac-nml/bio_hansel/deployments","created_at":"2017-09-12T04:34:51Z","updated_at":"2017-12-18T21:33:07Z","pushed_at":"2018-02-09T17:56:27Z","git_url":"git://github.com/phac-nml/bio_hansel.git","ssh_url":"git@github.com:phac-nml/bio_hansel.git","clone_url":"https://github.com/phac-nml/bio_hansel.git","svn_url":"https://github.com/phac-nml/bio_hansel","homepage":"","size":12129,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phac-nml/bio_hansel/pulls/30"},"html":{"href":"https://github.com/phac-nml/bio_hansel/pull/30"},"issue":{"href":"https://api.github.com/repos/phac-nml/bio_hansel/issues/30"},"comments":{"href":"https://api.github.com/repos/phac-nml/bio_hansel/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/phac-nml/bio_hansel/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/phac-nml/bio_hansel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phac-nml/bio_hansel/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/phac-nml/bio_hansel/statuses/37438f9773252b647dcc8459c72c717d58988850"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"hellothisisMatt"}}