{"action":"closed","number":28595,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28595","id":208440164,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDQwMTY0","html_url":"https://github.com/cockroachdb/cockroach/pull/28595","diff_url":"https://github.com/cockroachdb/cockroach/pull/28595.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/28595.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28595","number":28595,"state":"closed","locked":false,"title":"opt: Make several perf tweaks to speed up simple queries","user":{"login":"andy-kimball","id":32096062,"node_id":"MDQ6VXNlcjMyMDk2MDYy","avatar_url":"https://avatars0.githubusercontent.com/u/32096062?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-kimball","html_url":"https://github.com/andy-kimball","followers_url":"https://api.github.com/users/andy-kimball/followers","following_url":"https://api.github.com/users/andy-kimball/following{/other_user}","gists_url":"https://api.github.com/users/andy-kimball/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-kimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-kimball/subscriptions","organizations_url":"https://api.github.com/users/andy-kimball/orgs","repos_url":"https://api.github.com/users/andy-kimball/repos","events_url":"https://api.github.com/users/andy-kimball/events{/privacy}","received_events_url":"https://api.github.com/users/andy-kimball/received_events","type":"User","site_admin":false},"body":"Together, these changes improve the Optbuild scenarios from:\r\n```\r\nPhases/kv-read/OptBuild  21.4µs ± 2%\r\n```\r\nto:\r\n```\r\nPhases/kv-read/OptBuild  18.0µs ± 2%\r\n```\r\n\r\nNOTE: I changed my timing methodology so that I'm benchmarking on a single CPU (i.e. GC no longer allowed to run on another CPU). So the the 3us are not directly comparable to previous improvements in this scenario.","created_at":"2018-08-14T23:46:57Z","updated_at":"2018-08-15T03:42:30Z","closed_at":"2018-08-15T03:42:30Z","merged_at":"2018-08-15T03:42:30Z","merge_commit_sha":"0f9cdaeb2eb97d6fd78c1af9af9655d56670d25a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"justinj","id":409075,"node_id":"MDQ6VXNlcjQwOTA3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/409075?v=4","gravatar_id":"","url":"https://api.github.com/users/justinj","html_url":"https://github.com/justinj","followers_url":"https://api.github.com/users/justinj/followers","following_url":"https://api.github.com/users/justinj/following{/other_user}","gists_url":"https://api.github.com/users/justinj/gists{/gist_id}","starred_url":"https://api.github.com/users/justinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinj/subscriptions","organizations_url":"https://api.github.com/users/justinj/orgs","repos_url":"https://api.github.com/users/justinj/repos","events_url":"https://api.github.com/users/justinj/events{/privacy}","received_events_url":"https://api.github.com/users/justinj/received_events","type":"User","site_admin":false},{"login":"rytaft","id":3288732,"node_id":"MDQ6VXNlcjMyODg3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/3288732?v=4","gravatar_id":"","url":"https://api.github.com/users/rytaft","html_url":"https://github.com/rytaft","followers_url":"https://api.github.com/users/rytaft/followers","following_url":"https://api.github.com/users/rytaft/following{/other_user}","gists_url":"https://api.github.com/users/rytaft/gists{/gist_id}","starred_url":"https://api.github.com/users/rytaft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rytaft/subscriptions","organizations_url":"https://api.github.com/users/rytaft/orgs","repos_url":"https://api.github.com/users/rytaft/repos","events_url":"https://api.github.com/users/rytaft/events{/privacy}","received_events_url":"https://api.github.com/users/rytaft/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28595/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28595/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28595/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/0f9cdaeb2eb97d6fd78c1af9af9655d56670d25a","head":{"label":"andy-kimball:perf","ref":"perf","sha":"0f9cdaeb2eb97d6fd78c1af9af9655d56670d25a","user":{"login":"andy-kimball","id":32096062,"node_id":"MDQ6VXNlcjMyMDk2MDYy","avatar_url":"https://avatars0.githubusercontent.com/u/32096062?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-kimball","html_url":"https://github.com/andy-kimball","followers_url":"https://api.github.com/users/andy-kimball/followers","following_url":"https://api.github.com/users/andy-kimball/following{/other_user}","gists_url":"https://api.github.com/users/andy-kimball/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-kimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-kimball/subscriptions","organizations_url":"https://api.github.com/users/andy-kimball/orgs","repos_url":"https://api.github.com/users/andy-kimball/repos","events_url":"https://api.github.com/users/andy-kimball/events{/privacy}","received_events_url":"https://api.github.com/users/andy-kimball/received_events","type":"User","site_admin":false},"repo":{"id":117270021,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcyNzAwMjE=","name":"cockroach","full_name":"andy-kimball/cockroach","owner":{"login":"andy-kimball","id":32096062,"node_id":"MDQ6VXNlcjMyMDk2MDYy","avatar_url":"https://avatars0.githubusercontent.com/u/32096062?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-kimball","html_url":"https://github.com/andy-kimball","followers_url":"https://api.github.com/users/andy-kimball/followers","following_url":"https://api.github.com/users/andy-kimball/following{/other_user}","gists_url":"https://api.github.com/users/andy-kimball/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-kimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-kimball/subscriptions","organizations_url":"https://api.github.com/users/andy-kimball/orgs","repos_url":"https://api.github.com/users/andy-kimball/repos","events_url":"https://api.github.com/users/andy-kimball/events{/privacy}","received_events_url":"https://api.github.com/users/andy-kimball/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andy-kimball/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":true,"url":"https://api.github.com/repos/andy-kimball/cockroach","forks_url":"https://api.github.com/repos/andy-kimball/cockroach/forks","keys_url":"https://api.github.com/repos/andy-kimball/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andy-kimball/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andy-kimball/cockroach/teams","hooks_url":"https://api.github.com/repos/andy-kimball/cockroach/hooks","issue_events_url":"https://api.github.com/repos/andy-kimball/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/andy-kimball/cockroach/events","assignees_url":"https://api.github.com/repos/andy-kimball/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/andy-kimball/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/andy-kimball/cockroach/tags","blobs_url":"https://api.github.com/repos/andy-kimball/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andy-kimball/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andy-kimball/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/andy-kimball/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andy-kimball/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/andy-kimball/cockroach/languages","stargazers_url":"https://api.github.com/repos/andy-kimball/cockroach/stargazers","contributors_url":"https://api.github.com/repos/andy-kimball/cockroach/contributors","subscribers_url":"https://api.github.com/repos/andy-kimball/cockroach/subscribers","subscription_url":"https://api.github.com/repos/andy-kimball/cockroach/subscription","commits_url":"https://api.github.com/repos/andy-kimball/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/andy-kimball/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/andy-kimball/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/andy-kimball/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/andy-kimball/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/andy-kimball/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andy-kimball/cockroach/merges","archive_url":"https://api.github.com/repos/andy-kimball/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andy-kimball/cockroach/downloads","issues_url":"https://api.github.com/repos/andy-kimball/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/andy-kimball/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/andy-kimball/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/andy-kimball/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andy-kimball/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/andy-kimball/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/andy-kimball/cockroach/deployments","created_at":"2018-01-12T17:35:15Z","updated_at":"2018-01-12T17:35:25Z","pushed_at":"2018-08-14T23:41:55Z","git_url":"git://github.com/andy-kimball/cockroach.git","ssh_url":"git@github.com:andy-kimball/cockroach.git","clone_url":"https://github.com/andy-kimball/cockroach.git","svn_url":"https://github.com/andy-kimball/cockroach","homepage":"https://www.cockroachlabs.com","size":552533,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"bf3e90dbb51952ba6683ceadbf17396abf1ff667","user":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU2MzU4Nw==","name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-08-15T03:28:34Z","pushed_at":"2018-08-15T03:41:50Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":1033676,"stargazers_count":14010,"watchers_count":14010,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1469,"mirror_url":null,"archived":false,"open_issues_count":1886,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1469,"open_issues":1886,"watchers":14010,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28595"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/28595"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/28595"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/28595/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28595/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28595/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/0f9cdaeb2eb97d6fd78c1af9af9655d56670d25a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"craig[bot]","id":37807150,"node_id":"MDM6Qm90Mzc4MDcxNTA=","avatar_url":"https://avatars0.githubusercontent.com/in/10419?v=4","gravatar_id":"","url":"https://api.github.com/users/craig%5Bbot%5D","html_url":"https://github.com/apps/craig","followers_url":"https://api.github.com/users/craig%5Bbot%5D/followers","following_url":"https://api.github.com/users/craig%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/craig%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/craig%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craig%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/craig%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/craig%5Bbot%5D/repos","events_url":"https://api.github.com/users/craig%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/craig%5Bbot%5D/received_events","type":"Bot","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":352,"deletions":406,"changed_files":18}}
{"actor":{"display_login":"craig"}}