{"action":"created","comment":{"url":"https://api.github.com/repos/dbcli/pgcli/pulls/comments/209092365","pull_request_review_id":145042188,"id":209092365,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTA5MjM2NQ==","diff_hunk":"@@ -692,68 +682,54 @@ def prompt_tokens(_):\n                     len(prompt) > self.max_len_prompt):\n                 prompt = self.get_prompt('\\\\d> ')\n \n-            return [(Token.Prompt, prompt)]","path":"pgcli/main.py","position":178,"original_position":178,"commit_id":"63b14456b22b789d668a965760ac96309c82ad27","original_commit_id":"63b14456b22b789d668a965760ac96309c82ad27","user":{"login":"j-bennet","id":637013,"node_id":"MDQ6VXNlcjYzNzAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/637013?v=4","gravatar_id":"","url":"https://api.github.com/users/j-bennet","html_url":"https://github.com/j-bennet","followers_url":"https://api.github.com/users/j-bennet/followers","following_url":"https://api.github.com/users/j-bennet/following{/other_user}","gists_url":"https://api.github.com/users/j-bennet/gists{/gist_id}","starred_url":"https://api.github.com/users/j-bennet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-bennet/subscriptions","organizations_url":"https://api.github.com/users/j-bennet/orgs","repos_url":"https://api.github.com/users/j-bennet/repos","events_url":"https://api.github.com/users/j-bennet/events{/privacy}","received_events_url":"https://api.github.com/users/j-bennet/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2018-08-09T21:59:32Z","updated_at":"2018-08-09T21:59:32Z","html_url":"https://github.com/dbcli/pgcli/pull/930#discussion_r209092365","pull_request_url":"https://api.github.com/repos/dbcli/pgcli/pulls/930","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dbcli/pgcli/pulls/comments/209092365"},"html":{"href":"https://github.com/dbcli/pgcli/pull/930#discussion_r209092365"},"pull_request":{"href":"https://api.github.com/repos/dbcli/pgcli/pulls/930"}},"in_reply_to_id":209047594},"pull_request":{"url":"https://api.github.com/repos/dbcli/pgcli/pulls/930","id":204566105,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTY2MTA1","html_url":"https://github.com/dbcli/pgcli/pull/930","diff_url":"https://github.com/dbcli/pgcli/pull/930.diff","patch_url":"https://github.com/dbcli/pgcli/pull/930.patch","issue_url":"https://api.github.com/repos/dbcli/pgcli/issues/930","number":930,"state":"open","locked":false,"title":"[WIP] Cherry-picked prompt-toolkit 2.0 changes.","user":{"login":"j-bennet","id":637013,"node_id":"MDQ6VXNlcjYzNzAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/637013?v=4","gravatar_id":"","url":"https://api.github.com/users/j-bennet","html_url":"https://github.com/j-bennet","followers_url":"https://api.github.com/users/j-bennet/followers","following_url":"https://api.github.com/users/j-bennet/following{/other_user}","gists_url":"https://api.github.com/users/j-bennet/gists{/gist_id}","starred_url":"https://api.github.com/users/j-bennet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-bennet/subscriptions","organizations_url":"https://api.github.com/users/j-bennet/orgs","repos_url":"https://api.github.com/users/j-bennet/repos","events_url":"https://api.github.com/users/j-bennet/events{/privacy}","received_events_url":"https://api.github.com/users/j-bennet/received_events","type":"User","site_admin":false},"body":"Changes for prompt-toolkit 2.0, based on current master.\r\n\r\nCherry-picked from https://github.com/dbcli/pgcli/pull/826.\r\n\r\n@jonathanslenders I cherry-picked because I have no permissions to rebase your branch, but we can merge either PR, provided it's in line with current `pgcli` master.\r\n\r\n**Problems noticed so far**:\r\n\r\n* styles are not applied\r\n* cli takes longer to start. I had to increase \"show help\" integration test timeout.\r\n* ~cli won't run under 2.7~ fixed, it was unicode literals\r\n* ~`iocommands` integration test fail on editor command~ fixed\r\n* ~`named_queries` integration test fail~ fixed\r\n\r\nNamed query integration test failed because of this warning printed under `pexpect` (which is not a real terminal):\r\n\r\nhttps://github.com/jonathanslenders/python-prompt-toolkit/blob/b8d09e971e5fbad76d3c5bda4b47063e4c0644b8/prompt_toolkit/application/application.py#L706\r\n\r\n@jonathanslenders Is there a way to suppress this kind of error output for tests? perhaps is you use `warnings` vs writing to stdout?","created_at":"2018-07-28T00:33:08Z","updated_at":"2018-08-09T21:59:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"853cb4212315e3e15e784a9fde2339e2f327af27","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dbcli/pgcli/pulls/930/commits","review_comments_url":"https://api.github.com/repos/dbcli/pgcli/pulls/930/comments","review_comment_url":"https://api.github.com/repos/dbcli/pgcli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dbcli/pgcli/issues/930/comments","statuses_url":"https://api.github.com/repos/dbcli/pgcli/statuses/63b14456b22b789d668a965760ac96309c82ad27","head":{"label":"dbcli:jonathanslenders/prompt-toolkit-2.0","ref":"jonathanslenders/prompt-toolkit-2.0","sha":"63b14456b22b789d668a965760ac96309c82ad27","user":{"login":"dbcli","id":11810727,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODEwNzI3","avatar_url":"https://avatars1.githubusercontent.com/u/11810727?v=4","gravatar_id":"","url":"https://api.github.com/users/dbcli","html_url":"https://github.com/dbcli","followers_url":"https://api.github.com/users/dbcli/followers","following_url":"https://api.github.com/users/dbcli/following{/other_user}","gists_url":"https://api.github.com/users/dbcli/gists{/gist_id}","starred_url":"https://api.github.com/users/dbcli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbcli/subscriptions","organizations_url":"https://api.github.com/users/dbcli/orgs","repos_url":"https://api.github.com/users/dbcli/repos","events_url":"https://api.github.com/users/dbcli/events{/privacy}","received_events_url":"https://api.github.com/users/dbcli/received_events","type":"Organization","site_admin":false},"repo":{"id":25126616,"node_id":"MDEwOlJlcG9zaXRvcnkyNTEyNjYxNg==","name":"pgcli","full_name":"dbcli/pgcli","owner":{"login":"dbcli","id":11810727,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODEwNzI3","avatar_url":"https://avatars1.githubusercontent.com/u/11810727?v=4","gravatar_id":"","url":"https://api.github.com/users/dbcli","html_url":"https://github.com/dbcli","followers_url":"https://api.github.com/users/dbcli/followers","following_url":"https://api.github.com/users/dbcli/following{/other_user}","gists_url":"https://api.github.com/users/dbcli/gists{/gist_id}","starred_url":"https://api.github.com/users/dbcli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbcli/subscriptions","organizations_url":"https://api.github.com/users/dbcli/orgs","repos_url":"https://api.github.com/users/dbcli/repos","events_url":"https://api.github.com/users/dbcli/events{/privacy}","received_events_url":"https://api.github.com/users/dbcli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dbcli/pgcli","description":"Postgres CLI with autocompletion and syntax highlighting","fork":false,"url":"https://api.github.com/repos/dbcli/pgcli","forks_url":"https://api.github.com/repos/dbcli/pgcli/forks","keys_url":"https://api.github.com/repos/dbcli/pgcli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbcli/pgcli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbcli/pgcli/teams","hooks_url":"https://api.github.com/repos/dbcli/pgcli/hooks","issue_events_url":"https://api.github.com/repos/dbcli/pgcli/issues/events{/number}","events_url":"https://api.github.com/repos/dbcli/pgcli/events","assignees_url":"https://api.github.com/repos/dbcli/pgcli/assignees{/user}","branches_url":"https://api.github.com/repos/dbcli/pgcli/branches{/branch}","tags_url":"https://api.github.com/repos/dbcli/pgcli/tags","blobs_url":"https://api.github.com/repos/dbcli/pgcli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbcli/pgcli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbcli/pgcli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbcli/pgcli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbcli/pgcli/statuses/{sha}","languages_url":"https://api.github.com/repos/dbcli/pgcli/languages","stargazers_url":"https://api.github.com/repos/dbcli/pgcli/stargazers","contributors_url":"https://api.github.com/repos/dbcli/pgcli/contributors","subscribers_url":"https://api.github.com/repos/dbcli/pgcli/subscribers","subscription_url":"https://api.github.com/repos/dbcli/pgcli/subscription","commits_url":"https://api.github.com/repos/dbcli/pgcli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbcli/pgcli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbcli/pgcli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbcli/pgcli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbcli/pgcli/contents/{+path}","compare_url":"https://api.github.com/repos/dbcli/pgcli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbcli/pgcli/merges","archive_url":"https://api.github.com/repos/dbcli/pgcli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbcli/pgcli/downloads","issues_url":"https://api.github.com/repos/dbcli/pgcli/issues{/number}","pulls_url":"https://api.github.com/repos/dbcli/pgcli/pulls{/number}","milestones_url":"https://api.github.com/repos/dbcli/pgcli/milestones{/number}","notifications_url":"https://api.github.com/repos/dbcli/pgcli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbcli/pgcli/labels{/name}","releases_url":"https://api.github.com/repos/dbcli/pgcli/releases{/id}","deployments_url":"https://api.github.com/repos/dbcli/pgcli/deployments","created_at":"2014-10-12T17:32:33Z","updated_at":"2018-08-09T19:39:51Z","pushed_at":"2018-08-08T01:51:08Z","git_url":"git://github.com/dbcli/pgcli.git","ssh_url":"git@github.com:dbcli/pgcli.git","clone_url":"https://github.com/dbcli/pgcli.git","svn_url":"https://github.com/dbcli/pgcli","homepage":"http://pgcli.com","size":2608,"stargazers_count":6945,"watchers_count":6945,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":319,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":319,"open_issues":83,"watchers":6945,"default_branch":"master"}},"base":{"label":"dbcli:master","ref":"master","sha":"5834259535e1cf5a75204305b0533ac5559ff344","user":{"login":"dbcli","id":11810727,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODEwNzI3","avatar_url":"https://avatars1.githubusercontent.com/u/11810727?v=4","gravatar_id":"","url":"https://api.github.com/users/dbcli","html_url":"https://github.com/dbcli","followers_url":"https://api.github.com/users/dbcli/followers","following_url":"https://api.github.com/users/dbcli/following{/other_user}","gists_url":"https://api.github.com/users/dbcli/gists{/gist_id}","starred_url":"https://api.github.com/users/dbcli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbcli/subscriptions","organizations_url":"https://api.github.com/users/dbcli/orgs","repos_url":"https://api.github.com/users/dbcli/repos","events_url":"https://api.github.com/users/dbcli/events{/privacy}","received_events_url":"https://api.github.com/users/dbcli/received_events","type":"Organization","site_admin":false},"repo":{"id":25126616,"node_id":"MDEwOlJlcG9zaXRvcnkyNTEyNjYxNg==","name":"pgcli","full_name":"dbcli/pgcli","owner":{"login":"dbcli","id":11810727,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODEwNzI3","avatar_url":"https://avatars1.githubusercontent.com/u/11810727?v=4","gravatar_id":"","url":"https://api.github.com/users/dbcli","html_url":"https://github.com/dbcli","followers_url":"https://api.github.com/users/dbcli/followers","following_url":"https://api.github.com/users/dbcli/following{/other_user}","gists_url":"https://api.github.com/users/dbcli/gists{/gist_id}","starred_url":"https://api.github.com/users/dbcli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbcli/subscriptions","organizations_url":"https://api.github.com/users/dbcli/orgs","repos_url":"https://api.github.com/users/dbcli/repos","events_url":"https://api.github.com/users/dbcli/events{/privacy}","received_events_url":"https://api.github.com/users/dbcli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dbcli/pgcli","description":"Postgres CLI with autocompletion and syntax highlighting","fork":false,"url":"https://api.github.com/repos/dbcli/pgcli","forks_url":"https://api.github.com/repos/dbcli/pgcli/forks","keys_url":"https://api.github.com/repos/dbcli/pgcli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbcli/pgcli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbcli/pgcli/teams","hooks_url":"https://api.github.com/repos/dbcli/pgcli/hooks","issue_events_url":"https://api.github.com/repos/dbcli/pgcli/issues/events{/number}","events_url":"https://api.github.com/repos/dbcli/pgcli/events","assignees_url":"https://api.github.com/repos/dbcli/pgcli/assignees{/user}","branches_url":"https://api.github.com/repos/dbcli/pgcli/branches{/branch}","tags_url":"https://api.github.com/repos/dbcli/pgcli/tags","blobs_url":"https://api.github.com/repos/dbcli/pgcli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbcli/pgcli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbcli/pgcli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbcli/pgcli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbcli/pgcli/statuses/{sha}","languages_url":"https://api.github.com/repos/dbcli/pgcli/languages","stargazers_url":"https://api.github.com/repos/dbcli/pgcli/stargazers","contributors_url":"https://api.github.com/repos/dbcli/pgcli/contributors","subscribers_url":"https://api.github.com/repos/dbcli/pgcli/subscribers","subscription_url":"https://api.github.com/repos/dbcli/pgcli/subscription","commits_url":"https://api.github.com/repos/dbcli/pgcli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbcli/pgcli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbcli/pgcli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbcli/pgcli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbcli/pgcli/contents/{+path}","compare_url":"https://api.github.com/repos/dbcli/pgcli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbcli/pgcli/merges","archive_url":"https://api.github.com/repos/dbcli/pgcli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbcli/pgcli/downloads","issues_url":"https://api.github.com/repos/dbcli/pgcli/issues{/number}","pulls_url":"https://api.github.com/repos/dbcli/pgcli/pulls{/number}","milestones_url":"https://api.github.com/repos/dbcli/pgcli/milestones{/number}","notifications_url":"https://api.github.com/repos/dbcli/pgcli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbcli/pgcli/labels{/name}","releases_url":"https://api.github.com/repos/dbcli/pgcli/releases{/id}","deployments_url":"https://api.github.com/repos/dbcli/pgcli/deployments","created_at":"2014-10-12T17:32:33Z","updated_at":"2018-08-09T19:39:51Z","pushed_at":"2018-08-08T01:51:08Z","git_url":"git://github.com/dbcli/pgcli.git","ssh_url":"git@github.com:dbcli/pgcli.git","clone_url":"https://github.com/dbcli/pgcli.git","svn_url":"https://github.com/dbcli/pgcli","homepage":"http://pgcli.com","size":2608,"stargazers_count":6945,"watchers_count":6945,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":319,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":319,"open_issues":83,"watchers":6945,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dbcli/pgcli/pulls/930"},"html":{"href":"https://github.com/dbcli/pgcli/pull/930"},"issue":{"href":"https://api.github.com/repos/dbcli/pgcli/issues/930"},"comments":{"href":"https://api.github.com/repos/dbcli/pgcli/issues/930/comments"},"review_comments":{"href":"https://api.github.com/repos/dbcli/pgcli/pulls/930/comments"},"review_comment":{"href":"https://api.github.com/repos/dbcli/pgcli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dbcli/pgcli/pulls/930/commits"},"statuses":{"href":"https://api.github.com/repos/dbcli/pgcli/statuses/63b14456b22b789d668a965760ac96309c82ad27"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"j-bennet"}}