{"action":"created","comment":{"url":"https://api.github.com/repos/slicebox/dicom-streams/pulls/comments/207959066","pull_request_review_id":143675274,"id":207959066,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzk1OTA2Ng==","diff_hunk":"@@ -118,16 +118,10 @@ object ModifyFlow {\n       def findModifyPart(header: HeaderPart): List[DicomPart] = sortedModifications\n         .find(m => m.matches(tagPath))\n         .map { tagModification =>\n-          if (header.length > 0) {\n-            currentHeader = Some(header)\n-            currentModification = Some(tagModification)\n-            value = ByteString.empty\n-            Nil\n-          } else {\n-            val newValue = tagModification.modification(ByteString.empty)\n-            val newHeader = header.withUpdatedLength(newValue.length)\n-            newHeader :: valueOrNot(newValue)\n-          }\n+          currentHeader = Some(header)\n+          currentModification = Some(tagModification)\n+          value = ByteString.empty\n+          Nil","path":"src/main/scala/se/nimsa/dicom/streams/ModifyFlow.scala","position":26,"original_position":26,"commit_id":"82f80c7c5f394fd3857db1b25b4c92a32ca65b97","original_commit_id":"82f80c7c5f394fd3857db1b25b4c92a32ca65b97","user":{"login":"KarlSjostrand","id":5653610,"node_id":"MDQ6VXNlcjU2NTM2MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5653610?v=4","gravatar_id":"","url":"https://api.github.com/users/KarlSjostrand","html_url":"https://github.com/KarlSjostrand","followers_url":"https://api.github.com/users/KarlSjostrand/followers","following_url":"https://api.github.com/users/KarlSjostrand/following{/other_user}","gists_url":"https://api.github.com/users/KarlSjostrand/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlSjostrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlSjostrand/subscriptions","organizations_url":"https://api.github.com/users/KarlSjostrand/orgs","repos_url":"https://api.github.com/users/KarlSjostrand/repos","events_url":"https://api.github.com/users/KarlSjostrand/events{/privacy}","received_events_url":"https://api.github.com/users/KarlSjostrand/received_events","type":"User","site_admin":false},"body":"The above is an unrelated fix that slipped in. Else-part of this if-else cannot happen.","created_at":"2018-08-06T16:50:23Z","updated_at":"2018-08-06T16:50:23Z","html_url":"https://github.com/slicebox/dicom-streams/pull/9#discussion_r207959066","pull_request_url":"https://api.github.com/repos/slicebox/dicom-streams/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/slicebox/dicom-streams/pulls/comments/207959066"},"html":{"href":"https://github.com/slicebox/dicom-streams/pull/9#discussion_r207959066"},"pull_request":{"href":"https://api.github.com/repos/slicebox/dicom-streams/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/slicebox/dicom-streams/pulls/9","id":206457362,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDU3MzYy","html_url":"https://github.com/slicebox/dicom-streams/pull/9","diff_url":"https://github.com/slicebox/dicom-streams/pull/9.diff","patch_url":"https://github.com/slicebox/dicom-streams/pull/9.patch","issue_url":"https://api.github.com/repos/slicebox/dicom-streams/issues/9","number":9,"state":"open","locked":false,"title":"Elements with VR UN (explicit VR) now keep this VR in ParseFlow","user":{"login":"KarlSjostrand","id":5653610,"node_id":"MDQ6VXNlcjU2NTM2MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5653610?v=4","gravatar_id":"","url":"https://api.github.com/users/KarlSjostrand","html_url":"https://github.com/KarlSjostrand","followers_url":"https://api.github.com/users/KarlSjostrand/followers","following_url":"https://api.github.com/users/KarlSjostrand/following{/other_user}","gists_url":"https://api.github.com/users/KarlSjostrand/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlSjostrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlSjostrand/subscriptions","organizations_url":"https://api.github.com/users/KarlSjostrand/orgs","repos_url":"https://api.github.com/users/KarlSjostrand/repos","events_url":"https://api.github.com/users/KarlSjostrand/events{/privacy}","received_events_url":"https://api.github.com/users/KarlSjostrand/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-06T16:49:24Z","updated_at":"2018-08-06T16:50:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31964e51d0c01cd31aea916405edf5fdb959374e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fredrik-exini","id":17121621,"node_id":"MDQ6VXNlcjE3MTIxNjIx","avatar_url":"https://avatars3.githubusercontent.com/u/17121621?v=4","gravatar_id":"","url":"https://api.github.com/users/fredrik-exini","html_url":"https://github.com/fredrik-exini","followers_url":"https://api.github.com/users/fredrik-exini/followers","following_url":"https://api.github.com/users/fredrik-exini/following{/other_user}","gists_url":"https://api.github.com/users/fredrik-exini/gists{/gist_id}","starred_url":"https://api.github.com/users/fredrik-exini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredrik-exini/subscriptions","organizations_url":"https://api.github.com/users/fredrik-exini/orgs","repos_url":"https://api.github.com/users/fredrik-exini/repos","events_url":"https://api.github.com/users/fredrik-exini/events{/privacy}","received_events_url":"https://api.github.com/users/fredrik-exini/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":860648568,"node_id":"MDU6TGFiZWw4NjA2NDg1Njg=","url":"https://api.github.com/repos/slicebox/dicom-streams/labels/bug","name":"bug","color":"d73a4a","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/slicebox/dicom-streams/pulls/9/commits","review_comments_url":"https://api.github.com/repos/slicebox/dicom-streams/pulls/9/comments","review_comment_url":"https://api.github.com/repos/slicebox/dicom-streams/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slicebox/dicom-streams/issues/9/comments","statuses_url":"https://api.github.com/repos/slicebox/dicom-streams/statuses/82f80c7c5f394fd3857db1b25b4c92a32ca65b97","head":{"label":"slicebox:bugfix/#8-VR-UN-handling","ref":"bugfix/#8-VR-UN-handling","sha":"82f80c7c5f394fd3857db1b25b4c92a32ca65b97","user":{"login":"slicebox","id":12760279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzYwMjc5","avatar_url":"https://avatars1.githubusercontent.com/u/12760279?v=4","gravatar_id":"","url":"https://api.github.com/users/slicebox","html_url":"https://github.com/slicebox","followers_url":"https://api.github.com/users/slicebox/followers","following_url":"https://api.github.com/users/slicebox/following{/other_user}","gists_url":"https://api.github.com/users/slicebox/gists{/gist_id}","starred_url":"https://api.github.com/users/slicebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slicebox/subscriptions","organizations_url":"https://api.github.com/users/slicebox/orgs","repos_url":"https://api.github.com/users/slicebox/repos","events_url":"https://api.github.com/users/slicebox/events{/privacy}","received_events_url":"https://api.github.com/users/slicebox/received_events","type":"Organization","site_admin":false},"repo":{"id":124423335,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ0MjMzMzU=","name":"dicom-streams","full_name":"slicebox/dicom-streams","owner":{"login":"slicebox","id":12760279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzYwMjc5","avatar_url":"https://avatars1.githubusercontent.com/u/12760279?v=4","gravatar_id":"","url":"https://api.github.com/users/slicebox","html_url":"https://github.com/slicebox","followers_url":"https://api.github.com/users/slicebox/followers","following_url":"https://api.github.com/users/slicebox/following{/other_user}","gists_url":"https://api.github.com/users/slicebox/gists{/gist_id}","starred_url":"https://api.github.com/users/slicebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slicebox/subscriptions","organizations_url":"https://api.github.com/users/slicebox/orgs","repos_url":"https://api.github.com/users/slicebox/repos","events_url":"https://api.github.com/users/slicebox/events{/privacy}","received_events_url":"https://api.github.com/users/slicebox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slicebox/dicom-streams","description":"A streaming and non-blocking API for reading and processing DICOM data","fork":false,"url":"https://api.github.com/repos/slicebox/dicom-streams","forks_url":"https://api.github.com/repos/slicebox/dicom-streams/forks","keys_url":"https://api.github.com/repos/slicebox/dicom-streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slicebox/dicom-streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slicebox/dicom-streams/teams","hooks_url":"https://api.github.com/repos/slicebox/dicom-streams/hooks","issue_events_url":"https://api.github.com/repos/slicebox/dicom-streams/issues/events{/number}","events_url":"https://api.github.com/repos/slicebox/dicom-streams/events","assignees_url":"https://api.github.com/repos/slicebox/dicom-streams/assignees{/user}","branches_url":"https://api.github.com/repos/slicebox/dicom-streams/branches{/branch}","tags_url":"https://api.github.com/repos/slicebox/dicom-streams/tags","blobs_url":"https://api.github.com/repos/slicebox/dicom-streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slicebox/dicom-streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slicebox/dicom-streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/slicebox/dicom-streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slicebox/dicom-streams/statuses/{sha}","languages_url":"https://api.github.com/repos/slicebox/dicom-streams/languages","stargazers_url":"https://api.github.com/repos/slicebox/dicom-streams/stargazers","contributors_url":"https://api.github.com/repos/slicebox/dicom-streams/contributors","subscribers_url":"https://api.github.com/repos/slicebox/dicom-streams/subscribers","subscription_url":"https://api.github.com/repos/slicebox/dicom-streams/subscription","commits_url":"https://api.github.com/repos/slicebox/dicom-streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/slicebox/dicom-streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/slicebox/dicom-streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/slicebox/dicom-streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/slicebox/dicom-streams/contents/{+path}","compare_url":"https://api.github.com/repos/slicebox/dicom-streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slicebox/dicom-streams/merges","archive_url":"https://api.github.com/repos/slicebox/dicom-streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slicebox/dicom-streams/downloads","issues_url":"https://api.github.com/repos/slicebox/dicom-streams/issues{/number}","pulls_url":"https://api.github.com/repos/slicebox/dicom-streams/pulls{/number}","milestones_url":"https://api.github.com/repos/slicebox/dicom-streams/milestones{/number}","notifications_url":"https://api.github.com/repos/slicebox/dicom-streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slicebox/dicom-streams/labels{/name}","releases_url":"https://api.github.com/repos/slicebox/dicom-streams/releases{/id}","deployments_url":"https://api.github.com/repos/slicebox/dicom-streams/deployments","created_at":"2018-03-08T17:09:56Z","updated_at":"2018-07-13T08:31:52Z","pushed_at":"2018-08-06T16:49:24Z","git_url":"git://github.com/slicebox/dicom-streams.git","ssh_url":"git@github.com:slicebox/dicom-streams.git","clone_url":"https://github.com/slicebox/dicom-streams.git","svn_url":"https://github.com/slicebox/dicom-streams","homepage":"","size":1732,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"slicebox:develop","ref":"develop","sha":"275e867ba9e593faf0075007e75e2e706ccb62cc","user":{"login":"slicebox","id":12760279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzYwMjc5","avatar_url":"https://avatars1.githubusercontent.com/u/12760279?v=4","gravatar_id":"","url":"https://api.github.com/users/slicebox","html_url":"https://github.com/slicebox","followers_url":"https://api.github.com/users/slicebox/followers","following_url":"https://api.github.com/users/slicebox/following{/other_user}","gists_url":"https://api.github.com/users/slicebox/gists{/gist_id}","starred_url":"https://api.github.com/users/slicebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slicebox/subscriptions","organizations_url":"https://api.github.com/users/slicebox/orgs","repos_url":"https://api.github.com/users/slicebox/repos","events_url":"https://api.github.com/users/slicebox/events{/privacy}","received_events_url":"https://api.github.com/users/slicebox/received_events","type":"Organization","site_admin":false},"repo":{"id":124423335,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ0MjMzMzU=","name":"dicom-streams","full_name":"slicebox/dicom-streams","owner":{"login":"slicebox","id":12760279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzYwMjc5","avatar_url":"https://avatars1.githubusercontent.com/u/12760279?v=4","gravatar_id":"","url":"https://api.github.com/users/slicebox","html_url":"https://github.com/slicebox","followers_url":"https://api.github.com/users/slicebox/followers","following_url":"https://api.github.com/users/slicebox/following{/other_user}","gists_url":"https://api.github.com/users/slicebox/gists{/gist_id}","starred_url":"https://api.github.com/users/slicebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slicebox/subscriptions","organizations_url":"https://api.github.com/users/slicebox/orgs","repos_url":"https://api.github.com/users/slicebox/repos","events_url":"https://api.github.com/users/slicebox/events{/privacy}","received_events_url":"https://api.github.com/users/slicebox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slicebox/dicom-streams","description":"A streaming and non-blocking API for reading and processing DICOM data","fork":false,"url":"https://api.github.com/repos/slicebox/dicom-streams","forks_url":"https://api.github.com/repos/slicebox/dicom-streams/forks","keys_url":"https://api.github.com/repos/slicebox/dicom-streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slicebox/dicom-streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slicebox/dicom-streams/teams","hooks_url":"https://api.github.com/repos/slicebox/dicom-streams/hooks","issue_events_url":"https://api.github.com/repos/slicebox/dicom-streams/issues/events{/number}","events_url":"https://api.github.com/repos/slicebox/dicom-streams/events","assignees_url":"https://api.github.com/repos/slicebox/dicom-streams/assignees{/user}","branches_url":"https://api.github.com/repos/slicebox/dicom-streams/branches{/branch}","tags_url":"https://api.github.com/repos/slicebox/dicom-streams/tags","blobs_url":"https://api.github.com/repos/slicebox/dicom-streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slicebox/dicom-streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slicebox/dicom-streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/slicebox/dicom-streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slicebox/dicom-streams/statuses/{sha}","languages_url":"https://api.github.com/repos/slicebox/dicom-streams/languages","stargazers_url":"https://api.github.com/repos/slicebox/dicom-streams/stargazers","contributors_url":"https://api.github.com/repos/slicebox/dicom-streams/contributors","subscribers_url":"https://api.github.com/repos/slicebox/dicom-streams/subscribers","subscription_url":"https://api.github.com/repos/slicebox/dicom-streams/subscription","commits_url":"https://api.github.com/repos/slicebox/dicom-streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/slicebox/dicom-streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/slicebox/dicom-streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/slicebox/dicom-streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/slicebox/dicom-streams/contents/{+path}","compare_url":"https://api.github.com/repos/slicebox/dicom-streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slicebox/dicom-streams/merges","archive_url":"https://api.github.com/repos/slicebox/dicom-streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slicebox/dicom-streams/downloads","issues_url":"https://api.github.com/repos/slicebox/dicom-streams/issues{/number}","pulls_url":"https://api.github.com/repos/slicebox/dicom-streams/pulls{/number}","milestones_url":"https://api.github.com/repos/slicebox/dicom-streams/milestones{/number}","notifications_url":"https://api.github.com/repos/slicebox/dicom-streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slicebox/dicom-streams/labels{/name}","releases_url":"https://api.github.com/repos/slicebox/dicom-streams/releases{/id}","deployments_url":"https://api.github.com/repos/slicebox/dicom-streams/deployments","created_at":"2018-03-08T17:09:56Z","updated_at":"2018-07-13T08:31:52Z","pushed_at":"2018-08-06T16:49:24Z","git_url":"git://github.com/slicebox/dicom-streams.git","ssh_url":"git@github.com:slicebox/dicom-streams.git","clone_url":"https://github.com/slicebox/dicom-streams.git","svn_url":"https://github.com/slicebox/dicom-streams","homepage":"","size":1732,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/slicebox/dicom-streams/pulls/9"},"html":{"href":"https://github.com/slicebox/dicom-streams/pull/9"},"issue":{"href":"https://api.github.com/repos/slicebox/dicom-streams/issues/9"},"comments":{"href":"https://api.github.com/repos/slicebox/dicom-streams/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/slicebox/dicom-streams/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/slicebox/dicom-streams/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slicebox/dicom-streams/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/slicebox/dicom-streams/statuses/82f80c7c5f394fd3857db1b25b4c92a32ca65b97"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KarlSjostrand"}}