{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/prepack/pulls/comments/173599526","pull_request_review_id":102826734,"id":173599526,"diff_hunk":"@@ -758,6 +758,7 @@ export class ResidualHeapVisitor {\n \n   visitValue(val: Value): void {\n     invariant(!val.refuseSerialization);\n+    invariant(val.isIntrinsic);","path":"src/serializer/ResidualHeapVisitor.js","position":20,"original_position":20,"commit_id":"3a60a28945b325e8528a311e8b1bedf5dfcff47f","original_commit_id":"3a60a28945b325e8528a311e8b1bedf5dfcff47f","user":{"login":"NTillmann","id":6457462,"avatar_url":"https://avatars2.githubusercontent.com/u/6457462?v=4","gravatar_id":"","url":"https://api.github.com/users/NTillmann","html_url":"https://github.com/NTillmann","followers_url":"https://api.github.com/users/NTillmann/followers","following_url":"https://api.github.com/users/NTillmann/following{/other_user}","gists_url":"https://api.github.com/users/NTillmann/gists{/gist_id}","starred_url":"https://api.github.com/users/NTillmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTillmann/subscriptions","organizations_url":"https://api.github.com/users/NTillmann/orgs","repos_url":"https://api.github.com/users/NTillmann/repos","events_url":"https://api.github.com/users/NTillmann/events{/privacy}","received_events_url":"https://api.github.com/users/NTillmann/received_events","type":"User","site_admin":false},"body":"What is this about? Carryover from debugging?","created_at":"2018-03-10T00:13:03Z","updated_at":"2018-03-10T00:13:03Z","html_url":"https://github.com/facebook/prepack/pull/1559#discussion_r173599526","pull_request_url":"https://api.github.com/repos/facebook/prepack/pulls/1559","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/prepack/pulls/comments/173599526"},"html":{"href":"https://github.com/facebook/prepack/pull/1559#discussion_r173599526"},"pull_request":{"href":"https://api.github.com/repos/facebook/prepack/pulls/1559"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/prepack/pulls/1559","id":174095041,"html_url":"https://github.com/facebook/prepack/pull/1559","diff_url":"https://github.com/facebook/prepack/pull/1559.diff","patch_url":"https://github.com/facebook/prepack/pull/1559.patch","issue_url":"https://api.github.com/repos/facebook/prepack/issues/1559","number":1559,"state":"open","locked":false,"title":"Make Effects into a Generator","user":{"login":"cblappert","id":3744743,"avatar_url":"https://avatars1.githubusercontent.com/u/3744743?v=4","gravatar_id":"","url":"https://api.github.com/users/cblappert","html_url":"https://github.com/cblappert","followers_url":"https://api.github.com/users/cblappert/followers","following_url":"https://api.github.com/users/cblappert/following{/other_user}","gists_url":"https://api.github.com/users/cblappert/gists{/gist_id}","starred_url":"https://api.github.com/users/cblappert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblappert/subscriptions","organizations_url":"https://api.github.com/users/cblappert/orgs","repos_url":"https://api.github.com/users/cblappert/repos","events_url":"https://api.github.com/users/cblappert/events{/privacy}","received_events_url":"https://api.github.com/users/cblappert/received_events","type":"User","site_admin":false},"body":"Additional Functions duplicates the Effects traversing logic in the serializer and visitor. Consolidate this logic as well as allowing for ordering dependencies by putting all these things needing visiting/serialization into the generator. Adds new `ModifiedPropertyEntry` and `ModifiedBindingEntry` types.","created_at":"2018-03-09T19:59:28Z","updated_at":"2018-03-10T00:13:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e54bf0c5bc891c5c9dcf519be62b557ee44a94f1","assignee":{"login":"cblappert","id":3744743,"avatar_url":"https://avatars1.githubusercontent.com/u/3744743?v=4","gravatar_id":"","url":"https://api.github.com/users/cblappert","html_url":"https://github.com/cblappert","followers_url":"https://api.github.com/users/cblappert/followers","following_url":"https://api.github.com/users/cblappert/following{/other_user}","gists_url":"https://api.github.com/users/cblappert/gists{/gist_id}","starred_url":"https://api.github.com/users/cblappert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblappert/subscriptions","organizations_url":"https://api.github.com/users/cblappert/orgs","repos_url":"https://api.github.com/users/cblappert/repos","events_url":"https://api.github.com/users/cblappert/events{/privacy}","received_events_url":"https://api.github.com/users/cblappert/received_events","type":"User","site_admin":false},"assignees":[{"login":"cblappert","id":3744743,"avatar_url":"https://avatars1.githubusercontent.com/u/3744743?v=4","gravatar_id":"","url":"https://api.github.com/users/cblappert","html_url":"https://github.com/cblappert","followers_url":"https://api.github.com/users/cblappert/followers","following_url":"https://api.github.com/users/cblappert/following{/other_user}","gists_url":"https://api.github.com/users/cblappert/gists{/gist_id}","starred_url":"https://api.github.com/users/cblappert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblappert/subscriptions","organizations_url":"https://api.github.com/users/cblappert/orgs","repos_url":"https://api.github.com/users/cblappert/repos","events_url":"https://api.github.com/users/cblappert/events{/privacy}","received_events_url":"https://api.github.com/users/cblappert/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":279345275,"url":"https://api.github.com/repos/facebook/prepack/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false},{"id":844468709,"url":"https://api.github.com/repos/facebook/prepack/labels/WIP","name":"WIP","color":"81eae7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/prepack/pulls/1559/commits","review_comments_url":"https://api.github.com/repos/facebook/prepack/pulls/1559/comments","review_comment_url":"https://api.github.com/repos/facebook/prepack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/prepack/issues/1559/comments","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/3a60a28945b325e8528a311e8b1bedf5dfcff47f","head":{"label":"facebook:af_refactor","ref":"af_refactor","sha":"3a60a28945b325e8528a311e8b1bedf5dfcff47f","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":45147841,"name":"prepack","full_name":"facebook/prepack","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/prepack","description":"Prepack is a partial evaluator for JavaScript. Prepack rewrites a JavaScript bundle, resulting in JavaScript code that executes more efficiently.","fork":false,"url":"https://api.github.com/repos/facebook/prepack","forks_url":"https://api.github.com/repos/facebook/prepack/forks","keys_url":"https://api.github.com/repos/facebook/prepack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/prepack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/prepack/teams","hooks_url":"https://api.github.com/repos/facebook/prepack/hooks","issue_events_url":"https://api.github.com/repos/facebook/prepack/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/prepack/events","assignees_url":"https://api.github.com/repos/facebook/prepack/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/prepack/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/prepack/tags","blobs_url":"https://api.github.com/repos/facebook/prepack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/prepack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/prepack/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/prepack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/prepack/languages","stargazers_url":"https://api.github.com/repos/facebook/prepack/stargazers","contributors_url":"https://api.github.com/repos/facebook/prepack/contributors","subscribers_url":"https://api.github.com/repos/facebook/prepack/subscribers","subscription_url":"https://api.github.com/repos/facebook/prepack/subscription","commits_url":"https://api.github.com/repos/facebook/prepack/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/prepack/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/prepack/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/prepack/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/prepack/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/prepack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/prepack/merges","archive_url":"https://api.github.com/repos/facebook/prepack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/prepack/downloads","issues_url":"https://api.github.com/repos/facebook/prepack/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/prepack/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/prepack/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/prepack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/prepack/labels{/name}","releases_url":"https://api.github.com/repos/facebook/prepack/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/prepack/deployments","created_at":"2015-10-28T23:25:08Z","updated_at":"2018-03-09T20:43:46Z","pushed_at":"2018-03-09T22:47:08Z","git_url":"git://github.com/facebook/prepack.git","ssh_url":"git@github.com:facebook/prepack.git","clone_url":"https://github.com/facebook/prepack.git","svn_url":"https://github.com/facebook/prepack","homepage":"https://prepack.io","size":8334,"stargazers_count":11380,"watchers_count":11380,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":340,"mirror_url":null,"archived":false,"open_issues_count":142,"license":null,"forks":340,"open_issues":142,"watchers":11380,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"3101a0a556d3255f61d4652c48e035537c8dd2e2","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":45147841,"name":"prepack","full_name":"facebook/prepack","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/prepack","description":"Prepack is a partial evaluator for JavaScript. Prepack rewrites a JavaScript bundle, resulting in JavaScript code that executes more efficiently.","fork":false,"url":"https://api.github.com/repos/facebook/prepack","forks_url":"https://api.github.com/repos/facebook/prepack/forks","keys_url":"https://api.github.com/repos/facebook/prepack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/prepack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/prepack/teams","hooks_url":"https://api.github.com/repos/facebook/prepack/hooks","issue_events_url":"https://api.github.com/repos/facebook/prepack/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/prepack/events","assignees_url":"https://api.github.com/repos/facebook/prepack/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/prepack/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/prepack/tags","blobs_url":"https://api.github.com/repos/facebook/prepack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/prepack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/prepack/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/prepack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/prepack/languages","stargazers_url":"https://api.github.com/repos/facebook/prepack/stargazers","contributors_url":"https://api.github.com/repos/facebook/prepack/contributors","subscribers_url":"https://api.github.com/repos/facebook/prepack/subscribers","subscription_url":"https://api.github.com/repos/facebook/prepack/subscription","commits_url":"https://api.github.com/repos/facebook/prepack/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/prepack/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/prepack/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/prepack/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/prepack/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/prepack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/prepack/merges","archive_url":"https://api.github.com/repos/facebook/prepack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/prepack/downloads","issues_url":"https://api.github.com/repos/facebook/prepack/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/prepack/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/prepack/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/prepack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/prepack/labels{/name}","releases_url":"https://api.github.com/repos/facebook/prepack/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/prepack/deployments","created_at":"2015-10-28T23:25:08Z","updated_at":"2018-03-09T20:43:46Z","pushed_at":"2018-03-09T22:47:08Z","git_url":"git://github.com/facebook/prepack.git","ssh_url":"git@github.com:facebook/prepack.git","clone_url":"https://github.com/facebook/prepack.git","svn_url":"https://github.com/facebook/prepack","homepage":"https://prepack.io","size":8334,"stargazers_count":11380,"watchers_count":11380,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":340,"mirror_url":null,"archived":false,"open_issues_count":142,"license":null,"forks":340,"open_issues":142,"watchers":11380,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/prepack/pulls/1559"},"html":{"href":"https://github.com/facebook/prepack/pull/1559"},"issue":{"href":"https://api.github.com/repos/facebook/prepack/issues/1559"},"comments":{"href":"https://api.github.com/repos/facebook/prepack/issues/1559/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/prepack/pulls/1559/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/prepack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/prepack/pulls/1559/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/prepack/statuses/3a60a28945b325e8528a311e8b1bedf5dfcff47f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"NTillmann"}}