{"action":"closed","number":76,"pull_request":{"url":"https://api.github.com/repos/readium/r2-streamer-swift/pulls/76","id":217261333,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MjYxMzMz","html_url":"https://github.com/readium/r2-streamer-swift/pull/76","diff_url":"https://github.com/readium/r2-streamer-swift/pull/76.diff","patch_url":"https://github.com/readium/r2-streamer-swift/pull/76.patch","issue_url":"https://api.github.com/repos/readium/r2-streamer-swift/issues/76","number":76,"state":"closed","locked":false,"title":"Issue #75 - Tap not respecting length of touch","user":{"login":"ullstrm","id":6592776,"node_id":"MDQ6VXNlcjY1OTI3NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6592776?v=4","gravatar_id":"","url":"https://api.github.com/users/ullstrm","html_url":"https://github.com/ullstrm","followers_url":"https://api.github.com/users/ullstrm/followers","following_url":"https://api.github.com/users/ullstrm/following{/other_user}","gists_url":"https://api.github.com/users/ullstrm/gists{/gist_id}","starred_url":"https://api.github.com/users/ullstrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ullstrm/subscriptions","organizations_url":"https://api.github.com/users/ullstrm/orgs","repos_url":"https://api.github.com/users/ullstrm/repos","events_url":"https://api.github.com/users/ullstrm/events{/privacy}","received_events_url":"https://api.github.com/users/ullstrm/received_events","type":"User","site_admin":false},"body":"This will fix the issue with the touch always registering as a tap no matter how long it is. The 500ms is the duration of a native long press gesture in iOS, so it seems like a fitting value for this purpose.\r\n\r\nHowever, my JavaScript is very very very rusty, so I have no idea wether this is an optimal solution or not.\r\n\r\nAs I stated in #75, this needs to be implemented more sophisticated if we want to support double tap.","created_at":"2018-09-21T12:00:49Z","updated_at":"2018-11-07T12:56:01Z","closed_at":"2018-11-07T12:56:01Z","merged_at":"2018-11-07T12:56:00Z","merge_commit_sha":"de36714b6137ff73c7f2b46700363771322fbfba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/readium/r2-streamer-swift/pulls/76/commits","review_comments_url":"https://api.github.com/repos/readium/r2-streamer-swift/pulls/76/comments","review_comment_url":"https://api.github.com/repos/readium/r2-streamer-swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/readium/r2-streamer-swift/issues/76/comments","statuses_url":"https://api.github.com/repos/readium/r2-streamer-swift/statuses/e315ad067865d83f718e9c15a1471e2525e9667f","head":{"label":"ullstrm:issue_75","ref":"issue_75","sha":"e315ad067865d83f718e9c15a1471e2525e9667f","user":{"login":"ullstrm","id":6592776,"node_id":"MDQ6VXNlcjY1OTI3NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6592776?v=4","gravatar_id":"","url":"https://api.github.com/users/ullstrm","html_url":"https://github.com/ullstrm","followers_url":"https://api.github.com/users/ullstrm/followers","following_url":"https://api.github.com/users/ullstrm/following{/other_user}","gists_url":"https://api.github.com/users/ullstrm/gists{/gist_id}","starred_url":"https://api.github.com/users/ullstrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ullstrm/subscriptions","organizations_url":"https://api.github.com/users/ullstrm/orgs","repos_url":"https://api.github.com/users/ullstrm/repos","events_url":"https://api.github.com/users/ullstrm/events{/privacy}","received_events_url":"https://api.github.com/users/ullstrm/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"readium:develop","ref":"develop","sha":"1840900ff399990e7f977562d9d0008696d67580","user":{"login":"readium","id":1402124,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDIxMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1402124?v=4","gravatar_id":"","url":"https://api.github.com/users/readium","html_url":"https://github.com/readium","followers_url":"https://api.github.com/users/readium/followers","following_url":"https://api.github.com/users/readium/following{/other_user}","gists_url":"https://api.github.com/users/readium/gists{/gist_id}","starred_url":"https://api.github.com/users/readium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/readium/subscriptions","organizations_url":"https://api.github.com/users/readium/orgs","repos_url":"https://api.github.com/users/readium/repos","events_url":"https://api.github.com/users/readium/events{/privacy}","received_events_url":"https://api.github.com/users/readium/received_events","type":"Organization","site_admin":false},"repo":{"id":79466690,"node_id":"MDEwOlJlcG9zaXRvcnk3OTQ2NjY5MA==","name":"r2-streamer-swift","full_name":"readium/r2-streamer-swift","private":false,"owner":{"login":"readium","id":1402124,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDIxMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1402124?v=4","gravatar_id":"","url":"https://api.github.com/users/readium","html_url":"https://github.com/readium","followers_url":"https://api.github.com/users/readium/followers","following_url":"https://api.github.com/users/readium/following{/other_user}","gists_url":"https://api.github.com/users/readium/gists{/gist_id}","starred_url":"https://api.github.com/users/readium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/readium/subscriptions","organizations_url":"https://api.github.com/users/readium/orgs","repos_url":"https://api.github.com/users/readium/repos","events_url":"https://api.github.com/users/readium/events{/privacy}","received_events_url":"https://api.github.com/users/readium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/readium/r2-streamer-swift","description":"Repo for the Streamer implementation in Swift","fork":false,"url":"https://api.github.com/repos/readium/r2-streamer-swift","forks_url":"https://api.github.com/repos/readium/r2-streamer-swift/forks","keys_url":"https://api.github.com/repos/readium/r2-streamer-swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/readium/r2-streamer-swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/readium/r2-streamer-swift/teams","hooks_url":"https://api.github.com/repos/readium/r2-streamer-swift/hooks","issue_events_url":"https://api.github.com/repos/readium/r2-streamer-swift/issues/events{/number}","events_url":"https://api.github.com/repos/readium/r2-streamer-swift/events","assignees_url":"https://api.github.com/repos/readium/r2-streamer-swift/assignees{/user}","branches_url":"https://api.github.com/repos/readium/r2-streamer-swift/branches{/branch}","tags_url":"https://api.github.com/repos/readium/r2-streamer-swift/tags","blobs_url":"https://api.github.com/repos/readium/r2-streamer-swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/readium/r2-streamer-swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/readium/r2-streamer-swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/readium/r2-streamer-swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/readium/r2-streamer-swift/statuses/{sha}","languages_url":"https://api.github.com/repos/readium/r2-streamer-swift/languages","stargazers_url":"https://api.github.com/repos/readium/r2-streamer-swift/stargazers","contributors_url":"https://api.github.com/repos/readium/r2-streamer-swift/contributors","subscribers_url":"https://api.github.com/repos/readium/r2-streamer-swift/subscribers","subscription_url":"https://api.github.com/repos/readium/r2-streamer-swift/subscription","commits_url":"https://api.github.com/repos/readium/r2-streamer-swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/readium/r2-streamer-swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/readium/r2-streamer-swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/readium/r2-streamer-swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/readium/r2-streamer-swift/contents/{+path}","compare_url":"https://api.github.com/repos/readium/r2-streamer-swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/readium/r2-streamer-swift/merges","archive_url":"https://api.github.com/repos/readium/r2-streamer-swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/readium/r2-streamer-swift/downloads","issues_url":"https://api.github.com/repos/readium/r2-streamer-swift/issues{/number}","pulls_url":"https://api.github.com/repos/readium/r2-streamer-swift/pulls{/number}","milestones_url":"https://api.github.com/repos/readium/r2-streamer-swift/milestones{/number}","notifications_url":"https://api.github.com/repos/readium/r2-streamer-swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/readium/r2-streamer-swift/labels{/name}","releases_url":"https://api.github.com/repos/readium/r2-streamer-swift/releases{/id}","deployments_url":"https://api.github.com/repos/readium/r2-streamer-swift/deployments","created_at":"2017-01-19T15:27:51Z","updated_at":"2018-09-05T13:32:56Z","pushed_at":"2018-11-07T12:56:00Z","git_url":"git://github.com/readium/r2-streamer-swift.git","ssh_url":"git@github.com:readium/r2-streamer-swift.git","clone_url":"https://github.com/readium/r2-streamer-swift.git","svn_url":"https://github.com/readium/r2-streamer-swift","homepage":null,"size":138847,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":8,"open_issues":10,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/readium/r2-streamer-swift/pulls/76"},"html":{"href":"https://github.com/readium/r2-streamer-swift/pull/76"},"issue":{"href":"https://api.github.com/repos/readium/r2-streamer-swift/issues/76"},"comments":{"href":"https://api.github.com/repos/readium/r2-streamer-swift/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/readium/r2-streamer-swift/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/readium/r2-streamer-swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/readium/r2-streamer-swift/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/readium/r2-streamer-swift/statuses/e315ad067865d83f718e9c15a1471e2525e9667f"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"aferditamuriqi","id":17150623,"node_id":"MDQ6VXNlcjE3MTUwNjIz","avatar_url":"https://avatars0.githubusercontent.com/u/17150623?v=4","gravatar_id":"","url":"https://api.github.com/users/aferditamuriqi","html_url":"https://github.com/aferditamuriqi","followers_url":"https://api.github.com/users/aferditamuriqi/followers","following_url":"https://api.github.com/users/aferditamuriqi/following{/other_user}","gists_url":"https://api.github.com/users/aferditamuriqi/gists{/gist_id}","starred_url":"https://api.github.com/users/aferditamuriqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aferditamuriqi/subscriptions","organizations_url":"https://api.github.com/users/aferditamuriqi/orgs","repos_url":"https://api.github.com/users/aferditamuriqi/repos","events_url":"https://api.github.com/users/aferditamuriqi/events{/privacy}","received_events_url":"https://api.github.com/users/aferditamuriqi/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"aferditamuriqi"}}