{"action":"created","comment":{"url":"https://api.github.com/repos/Faithlife/styled-ui/pulls/comments/223870879","pull_request_review_id":163106237,"id":223870879,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzg3MDg3OQ==","diff_hunk":"@@ -122,7 +123,20 @@ export const DropdownButtonContainer = styled.div`\n \n export const GroupSelectorModal = styled.div`\n \t${resetStyles};\n+`;\n+\n+export const ModalScrollViewContentClass = 'modal-scroll-view-content';\n+export const ModalScrollView = styled(ScrollArea)`\n \tposition: relative;\n+\theight: 60vh;\n+\twidth: 375px;\n+\tbackground: white;\n+\tborder-radius: 4px;\n+\n+\t.${ModalScrollViewContentClass} {","path":"components/group-selector/styled.jsx","position":20,"original_position":20,"commit_id":"b5d1ef4fd69b4565637aff01a0ddf7518f71dc8e","original_commit_id":"b5d1ef4fd69b4565637aff01a0ddf7518f71dc8e","user":{"login":"dustinsoftware","id":942358,"node_id":"MDQ6VXNlcjk0MjM1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/942358?v=4","gravatar_id":"","url":"https://api.github.com/users/dustinsoftware","html_url":"https://github.com/dustinsoftware","followers_url":"https://api.github.com/users/dustinsoftware/followers","following_url":"https://api.github.com/users/dustinsoftware/following{/other_user}","gists_url":"https://api.github.com/users/dustinsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinsoftware/subscriptions","organizations_url":"https://api.github.com/users/dustinsoftware/orgs","repos_url":"https://api.github.com/users/dustinsoftware/repos","events_url":"https://api.github.com/users/dustinsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/dustinsoftware/received_events","type":"User","site_admin":false},"body":"It would be better to pass in a reference to another component than to create a class name for it, can we do that here? [Docs](https://www.styled-components.com/docs/advanced#referring-to-other-components)","created_at":"2018-10-09T21:30:27Z","updated_at":"2018-10-09T21:30:27Z","html_url":"https://github.com/Faithlife/styled-ui/pull/62#discussion_r223870879","pull_request_url":"https://api.github.com/repos/Faithlife/styled-ui/pulls/62","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Faithlife/styled-ui/pulls/comments/223870879"},"html":{"href":"https://github.com/Faithlife/styled-ui/pull/62#discussion_r223870879"},"pull_request":{"href":"https://api.github.com/repos/Faithlife/styled-ui/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/Faithlife/styled-ui/pulls/62","id":221576561,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTc2NTYx","html_url":"https://github.com/Faithlife/styled-ui/pull/62","diff_url":"https://github.com/Faithlife/styled-ui/pull/62.diff","patch_url":"https://github.com/Faithlife/styled-ui/pull/62.patch","issue_url":"https://api.github.com/repos/Faithlife/styled-ui/issues/62","number":62,"state":"open","locked":false,"title":"Use custom scrollbar for GroupSelector","user":{"login":"JordanSjodinFaithlife","id":17711909,"node_id":"MDQ6VXNlcjE3NzExOTA5","avatar_url":"https://avatars2.githubusercontent.com/u/17711909?v=4","gravatar_id":"","url":"https://api.github.com/users/JordanSjodinFaithlife","html_url":"https://github.com/JordanSjodinFaithlife","followers_url":"https://api.github.com/users/JordanSjodinFaithlife/followers","following_url":"https://api.github.com/users/JordanSjodinFaithlife/following{/other_user}","gists_url":"https://api.github.com/users/JordanSjodinFaithlife/gists{/gist_id}","starred_url":"https://api.github.com/users/JordanSjodinFaithlife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordanSjodinFaithlife/subscriptions","organizations_url":"https://api.github.com/users/JordanSjodinFaithlife/orgs","repos_url":"https://api.github.com/users/JordanSjodinFaithlife/repos","events_url":"https://api.github.com/users/JordanSjodinFaithlife/events{/privacy}","received_events_url":"https://api.github.com/users/JordanSjodinFaithlife/received_events","type":"User","site_admin":false},"body":"@dustinsoftware \r\n\r\nThe group selector has some complicated scrolling behavior, and not all browses displayed the scrollbar above the content.\r\n\r\nUsing css to attempt to alter the scrollbar was not a viable solution due to Firefox not supporting the css required.\r\n\r\nUsing a custom scrollbar allows us to have control over the location of the scrollbar and get a consistent look accross browsers.\r\n\r\nPlus, fixed some small buttons on secondary modal content and fixed a gap in the header. \r\n","created_at":"2018-10-09T20:35:05Z","updated_at":"2018-10-09T21:30:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa0b673a34aa387eb43525da718117e43dd1b673","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Faithlife/styled-ui/pulls/62/commits","review_comments_url":"https://api.github.com/repos/Faithlife/styled-ui/pulls/62/comments","review_comment_url":"https://api.github.com/repos/Faithlife/styled-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Faithlife/styled-ui/issues/62/comments","statuses_url":"https://api.github.com/repos/Faithlife/styled-ui/statuses/b5d1ef4fd69b4565637aff01a0ddf7518f71dc8e","head":{"label":"JordanSjodinFaithlife:customscrollbar","ref":"customscrollbar","sha":"b5d1ef4fd69b4565637aff01a0ddf7518f71dc8e","user":{"login":"JordanSjodinFaithlife","id":17711909,"node_id":"MDQ6VXNlcjE3NzExOTA5","avatar_url":"https://avatars2.githubusercontent.com/u/17711909?v=4","gravatar_id":"","url":"https://api.github.com/users/JordanSjodinFaithlife","html_url":"https://github.com/JordanSjodinFaithlife","followers_url":"https://api.github.com/users/JordanSjodinFaithlife/followers","following_url":"https://api.github.com/users/JordanSjodinFaithlife/following{/other_user}","gists_url":"https://api.github.com/users/JordanSjodinFaithlife/gists{/gist_id}","starred_url":"https://api.github.com/users/JordanSjodinFaithlife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordanSjodinFaithlife/subscriptions","organizations_url":"https://api.github.com/users/JordanSjodinFaithlife/orgs","repos_url":"https://api.github.com/users/JordanSjodinFaithlife/repos","events_url":"https://api.github.com/users/JordanSjodinFaithlife/events{/privacy}","received_events_url":"https://api.github.com/users/JordanSjodinFaithlife/received_events","type":"User","site_admin":false},"repo":{"id":150131849,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMzE4NDk=","name":"styled-ui","full_name":"JordanSjodinFaithlife/styled-ui","private":false,"owner":{"login":"JordanSjodinFaithlife","id":17711909,"node_id":"MDQ6VXNlcjE3NzExOTA5","avatar_url":"https://avatars2.githubusercontent.com/u/17711909?v=4","gravatar_id":"","url":"https://api.github.com/users/JordanSjodinFaithlife","html_url":"https://github.com/JordanSjodinFaithlife","followers_url":"https://api.github.com/users/JordanSjodinFaithlife/followers","following_url":"https://api.github.com/users/JordanSjodinFaithlife/following{/other_user}","gists_url":"https://api.github.com/users/JordanSjodinFaithlife/gists{/gist_id}","starred_url":"https://api.github.com/users/JordanSjodinFaithlife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordanSjodinFaithlife/subscriptions","organizations_url":"https://api.github.com/users/JordanSjodinFaithlife/orgs","repos_url":"https://api.github.com/users/JordanSjodinFaithlife/repos","events_url":"https://api.github.com/users/JordanSjodinFaithlife/events{/privacy}","received_events_url":"https://api.github.com/users/JordanSjodinFaithlife/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JordanSjodinFaithlife/styled-ui","description":"Faithlife UI styleguide and set of components ","fork":true,"url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui","forks_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/forks","keys_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/teams","hooks_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/hooks","issue_events_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/issues/events{/number}","events_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/events","assignees_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/assignees{/user}","branches_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/branches{/branch}","tags_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/tags","blobs_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/languages","stargazers_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/stargazers","contributors_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/contributors","subscribers_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/subscribers","subscription_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/subscription","commits_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/contents/{+path}","compare_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/merges","archive_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/downloads","issues_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/issues{/number}","pulls_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/labels{/name}","releases_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/releases{/id}","deployments_url":"https://api.github.com/repos/JordanSjodinFaithlife/styled-ui/deployments","created_at":"2018-09-24T16:16:24Z","updated_at":"2018-10-08T21:04:09Z","pushed_at":"2018-10-09T21:22:06Z","git_url":"git://github.com/JordanSjodinFaithlife/styled-ui.git","ssh_url":"git@github.com:JordanSjodinFaithlife/styled-ui.git","clone_url":"https://github.com/JordanSjodinFaithlife/styled-ui.git","svn_url":"https://github.com/JordanSjodinFaithlife/styled-ui","homepage":"","size":4663,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Faithlife:master","ref":"master","sha":"774e0f26f47d67a9b9a4d2bace6729b0ed529896","user":{"login":"Faithlife","id":7575190,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzUxOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/7575190?v=4","gravatar_id":"","url":"https://api.github.com/users/Faithlife","html_url":"https://github.com/Faithlife","followers_url":"https://api.github.com/users/Faithlife/followers","following_url":"https://api.github.com/users/Faithlife/following{/other_user}","gists_url":"https://api.github.com/users/Faithlife/gists{/gist_id}","starred_url":"https://api.github.com/users/Faithlife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faithlife/subscriptions","organizations_url":"https://api.github.com/users/Faithlife/orgs","repos_url":"https://api.github.com/users/Faithlife/repos","events_url":"https://api.github.com/users/Faithlife/events{/privacy}","received_events_url":"https://api.github.com/users/Faithlife/received_events","type":"Organization","site_admin":false},"repo":{"id":128816254,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4MTYyNTQ=","name":"styled-ui","full_name":"Faithlife/styled-ui","private":false,"owner":{"login":"Faithlife","id":7575190,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzUxOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/7575190?v=4","gravatar_id":"","url":"https://api.github.com/users/Faithlife","html_url":"https://github.com/Faithlife","followers_url":"https://api.github.com/users/Faithlife/followers","following_url":"https://api.github.com/users/Faithlife/following{/other_user}","gists_url":"https://api.github.com/users/Faithlife/gists{/gist_id}","starred_url":"https://api.github.com/users/Faithlife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faithlife/subscriptions","organizations_url":"https://api.github.com/users/Faithlife/orgs","repos_url":"https://api.github.com/users/Faithlife/repos","events_url":"https://api.github.com/users/Faithlife/events{/privacy}","received_events_url":"https://api.github.com/users/Faithlife/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Faithlife/styled-ui","description":"Faithlife UI styleguide and set of components ","fork":false,"url":"https://api.github.com/repos/Faithlife/styled-ui","forks_url":"https://api.github.com/repos/Faithlife/styled-ui/forks","keys_url":"https://api.github.com/repos/Faithlife/styled-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Faithlife/styled-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Faithlife/styled-ui/teams","hooks_url":"https://api.github.com/repos/Faithlife/styled-ui/hooks","issue_events_url":"https://api.github.com/repos/Faithlife/styled-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Faithlife/styled-ui/events","assignees_url":"https://api.github.com/repos/Faithlife/styled-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Faithlife/styled-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Faithlife/styled-ui/tags","blobs_url":"https://api.github.com/repos/Faithlife/styled-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Faithlife/styled-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Faithlife/styled-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Faithlife/styled-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Faithlife/styled-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Faithlife/styled-ui/languages","stargazers_url":"https://api.github.com/repos/Faithlife/styled-ui/stargazers","contributors_url":"https://api.github.com/repos/Faithlife/styled-ui/contributors","subscribers_url":"https://api.github.com/repos/Faithlife/styled-ui/subscribers","subscription_url":"https://api.github.com/repos/Faithlife/styled-ui/subscription","commits_url":"https://api.github.com/repos/Faithlife/styled-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Faithlife/styled-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Faithlife/styled-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Faithlife/styled-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Faithlife/styled-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Faithlife/styled-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Faithlife/styled-ui/merges","archive_url":"https://api.github.com/repos/Faithlife/styled-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Faithlife/styled-ui/downloads","issues_url":"https://api.github.com/repos/Faithlife/styled-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Faithlife/styled-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Faithlife/styled-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Faithlife/styled-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Faithlife/styled-ui/labels{/name}","releases_url":"https://api.github.com/repos/Faithlife/styled-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Faithlife/styled-ui/deployments","created_at":"2018-04-09T18:26:21Z","updated_at":"2018-10-07T22:49:07Z","pushed_at":"2018-10-09T21:22:07Z","git_url":"git://github.com/Faithlife/styled-ui.git","ssh_url":"git@github.com:Faithlife/styled-ui.git","clone_url":"https://github.com/Faithlife/styled-ui.git","svn_url":"https://github.com/Faithlife/styled-ui","homepage":"","size":4693,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":17,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Faithlife/styled-ui/pulls/62"},"html":{"href":"https://github.com/Faithlife/styled-ui/pull/62"},"issue":{"href":"https://api.github.com/repos/Faithlife/styled-ui/issues/62"},"comments":{"href":"https://api.github.com/repos/Faithlife/styled-ui/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/Faithlife/styled-ui/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/Faithlife/styled-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Faithlife/styled-ui/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/Faithlife/styled-ui/statuses/b5d1ef4fd69b4565637aff01a0ddf7518f71dc8e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dustinsoftware"}}