{"action":"closed","issue":{"url":"https://api.github.com/repos/theislab/batchglm/issues/46","repository_url":"https://api.github.com/repos/theislab/batchglm","labels_url":"https://api.github.com/repos/theislab/batchglm/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/theislab/batchglm/issues/46/comments","events_url":"https://api.github.com/repos/theislab/batchglm/issues/46/events","html_url":"https://github.com/theislab/batchglm/issues/46","id":373605862,"node_id":"MDU6SXNzdWUzNzM2MDU4NjI=","number":46,"title":"Switch to closed-form Jacobian","user":{"login":"Hoeze","id":1200058,"node_id":"MDQ6VXNlcjEyMDAwNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1200058?v=4","gravatar_id":"","url":"https://api.github.com/users/Hoeze","html_url":"https://github.com/Hoeze","followers_url":"https://api.github.com/users/Hoeze/followers","following_url":"https://api.github.com/users/Hoeze/following{/other_user}","gists_url":"https://api.github.com/users/Hoeze/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoeze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoeze/subscriptions","organizations_url":"https://api.github.com/users/Hoeze/orgs","repos_url":"https://api.github.com/users/Hoeze/repos","events_url":"https://api.github.com/users/Hoeze/events{/privacy}","received_events_url":"https://api.github.com/users/Hoeze/received_events","type":"User","site_admin":false},"labels":[{"id":981695064,"node_id":"MDU6TGFiZWw5ODE2OTUwNjQ=","url":"https://api.github.com/repos/theislab/batchglm/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":1040619626,"node_id":"MDU6TGFiZWwxMDQwNjE5NjI2","url":"https://api.github.com/repos/theislab/batchglm/labels/high_priority","name":"high_priority","color":"e5342d","default":false},{"id":1067411052,"node_id":"MDU6TGFiZWwxMDY3NDExMDUy","url":"https://api.github.com/repos/theislab/batchglm/labels/performance","name":"performance","color":"58fc6e","default":false}],"state":"closed","locked":false,"assignee":{"login":"davidsebfischer","id":11200205,"node_id":"MDQ6VXNlcjExMjAwMjA1","avatar_url":"https://avatars3.githubusercontent.com/u/11200205?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsebfischer","html_url":"https://github.com/davidsebfischer","followers_url":"https://api.github.com/users/davidsebfischer/followers","following_url":"https://api.github.com/users/davidsebfischer/following{/other_user}","gists_url":"https://api.github.com/users/davidsebfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsebfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsebfischer/subscriptions","organizations_url":"https://api.github.com/users/davidsebfischer/orgs","repos_url":"https://api.github.com/users/davidsebfischer/repos","events_url":"https://api.github.com/users/davidsebfischer/events{/privacy}","received_events_url":"https://api.github.com/users/davidsebfischer/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidsebfischer","id":11200205,"node_id":"MDQ6VXNlcjExMjAwMjA1","avatar_url":"https://avatars3.githubusercontent.com/u/11200205?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsebfischer","html_url":"https://github.com/davidsebfischer","followers_url":"https://api.github.com/users/davidsebfischer/followers","following_url":"https://api.github.com/users/davidsebfischer/following{/other_user}","gists_url":"https://api.github.com/users/davidsebfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsebfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsebfischer/subscriptions","organizations_url":"https://api.github.com/users/davidsebfischer/orgs","repos_url":"https://api.github.com/users/davidsebfischer/repos","events_url":"https://api.github.com/users/davidsebfischer/events{/privacy}","received_events_url":"https://api.github.com/users/davidsebfischer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-10-24T18:00:24Z","updated_at":"2019-01-04T10:18:14Z","closed_at":"2019-01-04T10:18:14Z","author_association":"COLLABORATOR","body":"@davidsebfischer The gradient has to be adjusted for:\r\n- batch_trainers\r\n- batch_trainers_a_only\r\n- batch_trainers_b_only\r\n- full_data_trainers\r\n- full_data_trainers_a_only\r\n- full_data_trainers_b_only\r\n\r\n\r\n**It has to be changed among others at the following lines:**\r\nhttps://github.com/theislab/batchglm/blob/947e8b08086d5e10b8d9bc921939e1d7d940d4e4/batchglm/train/tf/nb_glm/estimator.py#L321-L322\r\nhttps://github.com/theislab/batchglm/blob/947e8b08086d5e10b8d9bc921939e1d7d940d4e4/batchglm/train/tf/nb_glm/estimator.py#L364-L365\r\nto `gradient = [..]` like in the following part:\r\nhttps://github.com/theislab/batchglm/blob/947e8b08086d5e10b8d9bc921939e1d7d940d4e4/batchglm/train/tf/nb_glm/estimator.py#L328-L336\r\n"}}
{"actor":{"display_login":"davidsebfischer"}}