{"action":"created","comment":{"url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/comments/241503767","pull_request_review_id":184793996,"id":241503767,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTUwMzc2Nw==","diff_hunk":"@@ -268,15 +280,19 @@ void CustomExportJob::run()\n \t\t// don't lock the page here for the whole flow, else we get a dead lock...\n \t\t// the ui is blocked, so there should be no changes...\n \t\tDocument* doc = control->getDocument();\n-\n+\t\t\n \t\tXojPdfExport* pdfe = XojPdfExportFactory::createExport(doc, control);\n-\n+\t\t\n+\t\tif (this->choosenFilterName == EXPORT_PDF_NOBG)\n+\t\t{\n+\t\t\tpdfe->setNoBackgroundExport(true);\n+\t\t}\n \n #ifdef ADVANCED_PDF_EXPORT_POPPLER\n \t\t// Not working with ADVANCED_PDF_EXPORT_POPPLER\n \t\tif (!pdfe->createPdf(this->filename))\n #else\n-\t\tif (!pdfe->createPdf(this->filename, exportRange))\n+\t\tif (!pdfe->createPdf(this->filename/*, exportRange*/))\t//export range is called anyways","path":"src/control/jobs/CustomExportJob.cpp","position":72,"original_position":72,"commit_id":"87ee420a8c7899df0263d45a608e9caafeeac875","original_commit_id":"87ee420a8c7899df0263d45a608e9caafeeac875","user":{"login":"morrolinux","id":20294254,"node_id":"MDQ6VXNlcjIwMjk0MjU0","avatar_url":"https://avatars1.githubusercontent.com/u/20294254?v=4","gravatar_id":"","url":"https://api.github.com/users/morrolinux","html_url":"https://github.com/morrolinux","followers_url":"https://api.github.com/users/morrolinux/followers","following_url":"https://api.github.com/users/morrolinux/following{/other_user}","gists_url":"https://api.github.com/users/morrolinux/gists{/gist_id}","starred_url":"https://api.github.com/users/morrolinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morrolinux/subscriptions","organizations_url":"https://api.github.com/users/morrolinux/orgs","repos_url":"https://api.github.com/users/morrolinux/repos","events_url":"https://api.github.com/users/morrolinux/events{/privacy}","received_events_url":"https://api.github.com/users/morrolinux/received_events","type":"User","site_admin":false},"body":"Oh, no, ok.. there must be an index bound problem because the first page is always absent when exporting all pages","created_at":"2018-12-13T18:02:08Z","updated_at":"2018-12-13T18:02:08Z","html_url":"https://github.com/xournalpp/xournalpp/pull/525#discussion_r241503767","pull_request_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/525","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/comments/241503767"},"html":{"href":"https://github.com/xournalpp/xournalpp/pull/525#discussion_r241503767"},"pull_request":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/525"}},"in_reply_to_id":241496556},"pull_request":{"url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/525","id":238337114,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MzM3MTE0","html_url":"https://github.com/xournalpp/xournalpp/pull/525","diff_url":"https://github.com/xournalpp/xournalpp/pull/525.diff","patch_url":"https://github.com/xournalpp/xournalpp/pull/525.patch","issue_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/525","number":525,"state":"open","locked":false,"title":"PDF and PNG export with no background","user":{"login":"morrolinux","id":20294254,"node_id":"MDQ6VXNlcjIwMjk0MjU0","avatar_url":"https://avatars1.githubusercontent.com/u/20294254?v=4","gravatar_id":"","url":"https://api.github.com/users/morrolinux","html_url":"https://github.com/morrolinux","followers_url":"https://api.github.com/users/morrolinux/followers","following_url":"https://api.github.com/users/morrolinux/following{/other_user}","gists_url":"https://api.github.com/users/morrolinux/gists{/gist_id}","starred_url":"https://api.github.com/users/morrolinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morrolinux/subscriptions","organizations_url":"https://api.github.com/users/morrolinux/orgs","repos_url":"https://api.github.com/users/morrolinux/repos","events_url":"https://api.github.com/users/morrolinux/events{/privacy}","received_events_url":"https://api.github.com/users/morrolinux/received_events","type":"User","site_admin":false},"body":"DO NOT MERGE JUST YET\r\n* Export PNG with transparent background (via \"export as\")\r\n* Export PDF with plain background (same)","created_at":"2018-12-13T10:27:26Z","updated_at":"2018-12-13T18:02:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"442214ec8b60699ae0acc273bcd473d24829c89d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/525/commits","review_comments_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/525/comments","review_comment_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/525/comments","statuses_url":"https://api.github.com/repos/xournalpp/xournalpp/statuses/87ee420a8c7899df0263d45a608e9caafeeac875","head":{"label":"xournalpp:pdf_export_no_bg","ref":"pdf_export_no_bg","sha":"87ee420a8c7899df0263d45a608e9caafeeac875","user":{"login":"xournalpp","id":5192682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTI2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5192682?v=4","gravatar_id":"","url":"https://api.github.com/users/xournalpp","html_url":"https://github.com/xournalpp","followers_url":"https://api.github.com/users/xournalpp/followers","following_url":"https://api.github.com/users/xournalpp/following{/other_user}","gists_url":"https://api.github.com/users/xournalpp/gists{/gist_id}","starred_url":"https://api.github.com/users/xournalpp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xournalpp/subscriptions","organizations_url":"https://api.github.com/users/xournalpp/orgs","repos_url":"https://api.github.com/users/xournalpp/repos","events_url":"https://api.github.com/users/xournalpp/events{/privacy}","received_events_url":"https://api.github.com/users/xournalpp/received_events","type":"Organization","site_admin":false},"repo":{"id":11986447,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4NjQ0Nw==","name":"xournalpp","full_name":"xournalpp/xournalpp","private":false,"owner":{"login":"xournalpp","id":5192682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTI2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5192682?v=4","gravatar_id":"","url":"https://api.github.com/users/xournalpp","html_url":"https://github.com/xournalpp","followers_url":"https://api.github.com/users/xournalpp/followers","following_url":"https://api.github.com/users/xournalpp/following{/other_user}","gists_url":"https://api.github.com/users/xournalpp/gists{/gist_id}","starred_url":"https://api.github.com/users/xournalpp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xournalpp/subscriptions","organizations_url":"https://api.github.com/users/xournalpp/orgs","repos_url":"https://api.github.com/users/xournalpp/repos","events_url":"https://api.github.com/users/xournalpp/events{/privacy}","received_events_url":"https://api.github.com/users/xournalpp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xournalpp/xournalpp","description":"Xournal++ is a handwriting Notetaking software, working on Linux, e.g. Ubuntu and supports Tablets like Wacom.","fork":false,"url":"https://api.github.com/repos/xournalpp/xournalpp","forks_url":"https://api.github.com/repos/xournalpp/xournalpp/forks","keys_url":"https://api.github.com/repos/xournalpp/xournalpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xournalpp/xournalpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xournalpp/xournalpp/teams","hooks_url":"https://api.github.com/repos/xournalpp/xournalpp/hooks","issue_events_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/events{/number}","events_url":"https://api.github.com/repos/xournalpp/xournalpp/events","assignees_url":"https://api.github.com/repos/xournalpp/xournalpp/assignees{/user}","branches_url":"https://api.github.com/repos/xournalpp/xournalpp/branches{/branch}","tags_url":"https://api.github.com/repos/xournalpp/xournalpp/tags","blobs_url":"https://api.github.com/repos/xournalpp/xournalpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xournalpp/xournalpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xournalpp/xournalpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/xournalpp/xournalpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xournalpp/xournalpp/statuses/{sha}","languages_url":"https://api.github.com/repos/xournalpp/xournalpp/languages","stargazers_url":"https://api.github.com/repos/xournalpp/xournalpp/stargazers","contributors_url":"https://api.github.com/repos/xournalpp/xournalpp/contributors","subscribers_url":"https://api.github.com/repos/xournalpp/xournalpp/subscribers","subscription_url":"https://api.github.com/repos/xournalpp/xournalpp/subscription","commits_url":"https://api.github.com/repos/xournalpp/xournalpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/xournalpp/xournalpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/xournalpp/xournalpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/xournalpp/xournalpp/contents/{+path}","compare_url":"https://api.github.com/repos/xournalpp/xournalpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xournalpp/xournalpp/merges","archive_url":"https://api.github.com/repos/xournalpp/xournalpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xournalpp/xournalpp/downloads","issues_url":"https://api.github.com/repos/xournalpp/xournalpp/issues{/number}","pulls_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls{/number}","milestones_url":"https://api.github.com/repos/xournalpp/xournalpp/milestones{/number}","notifications_url":"https://api.github.com/repos/xournalpp/xournalpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xournalpp/xournalpp/labels{/name}","releases_url":"https://api.github.com/repos/xournalpp/xournalpp/releases{/id}","deployments_url":"https://api.github.com/repos/xournalpp/xournalpp/deployments","created_at":"2013-08-08T20:58:27Z","updated_at":"2018-12-13T16:50:58Z","pushed_at":"2018-12-13T17:34:25Z","git_url":"git://github.com/xournalpp/xournalpp.git","ssh_url":"git@github.com:xournalpp/xournalpp.git","clone_url":"https://github.com/xournalpp/xournalpp.git","svn_url":"https://github.com/xournalpp/xournalpp","homepage":"","size":17755,"stargazers_count":175,"watchers_count":175,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":46,"open_issues":34,"watchers":175,"default_branch":"master"}},"base":{"label":"xournalpp:master","ref":"master","sha":"9542a83b9515ae795d4a2e6f72de4d82c567ddd2","user":{"login":"xournalpp","id":5192682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTI2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5192682?v=4","gravatar_id":"","url":"https://api.github.com/users/xournalpp","html_url":"https://github.com/xournalpp","followers_url":"https://api.github.com/users/xournalpp/followers","following_url":"https://api.github.com/users/xournalpp/following{/other_user}","gists_url":"https://api.github.com/users/xournalpp/gists{/gist_id}","starred_url":"https://api.github.com/users/xournalpp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xournalpp/subscriptions","organizations_url":"https://api.github.com/users/xournalpp/orgs","repos_url":"https://api.github.com/users/xournalpp/repos","events_url":"https://api.github.com/users/xournalpp/events{/privacy}","received_events_url":"https://api.github.com/users/xournalpp/received_events","type":"Organization","site_admin":false},"repo":{"id":11986447,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4NjQ0Nw==","name":"xournalpp","full_name":"xournalpp/xournalpp","private":false,"owner":{"login":"xournalpp","id":5192682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTI2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5192682?v=4","gravatar_id":"","url":"https://api.github.com/users/xournalpp","html_url":"https://github.com/xournalpp","followers_url":"https://api.github.com/users/xournalpp/followers","following_url":"https://api.github.com/users/xournalpp/following{/other_user}","gists_url":"https://api.github.com/users/xournalpp/gists{/gist_id}","starred_url":"https://api.github.com/users/xournalpp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xournalpp/subscriptions","organizations_url":"https://api.github.com/users/xournalpp/orgs","repos_url":"https://api.github.com/users/xournalpp/repos","events_url":"https://api.github.com/users/xournalpp/events{/privacy}","received_events_url":"https://api.github.com/users/xournalpp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xournalpp/xournalpp","description":"Xournal++ is a handwriting Notetaking software, working on Linux, e.g. Ubuntu and supports Tablets like Wacom.","fork":false,"url":"https://api.github.com/repos/xournalpp/xournalpp","forks_url":"https://api.github.com/repos/xournalpp/xournalpp/forks","keys_url":"https://api.github.com/repos/xournalpp/xournalpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xournalpp/xournalpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xournalpp/xournalpp/teams","hooks_url":"https://api.github.com/repos/xournalpp/xournalpp/hooks","issue_events_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/events{/number}","events_url":"https://api.github.com/repos/xournalpp/xournalpp/events","assignees_url":"https://api.github.com/repos/xournalpp/xournalpp/assignees{/user}","branches_url":"https://api.github.com/repos/xournalpp/xournalpp/branches{/branch}","tags_url":"https://api.github.com/repos/xournalpp/xournalpp/tags","blobs_url":"https://api.github.com/repos/xournalpp/xournalpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xournalpp/xournalpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xournalpp/xournalpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/xournalpp/xournalpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xournalpp/xournalpp/statuses/{sha}","languages_url":"https://api.github.com/repos/xournalpp/xournalpp/languages","stargazers_url":"https://api.github.com/repos/xournalpp/xournalpp/stargazers","contributors_url":"https://api.github.com/repos/xournalpp/xournalpp/contributors","subscribers_url":"https://api.github.com/repos/xournalpp/xournalpp/subscribers","subscription_url":"https://api.github.com/repos/xournalpp/xournalpp/subscription","commits_url":"https://api.github.com/repos/xournalpp/xournalpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/xournalpp/xournalpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/xournalpp/xournalpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/xournalpp/xournalpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/xournalpp/xournalpp/contents/{+path}","compare_url":"https://api.github.com/repos/xournalpp/xournalpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xournalpp/xournalpp/merges","archive_url":"https://api.github.com/repos/xournalpp/xournalpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xournalpp/xournalpp/downloads","issues_url":"https://api.github.com/repos/xournalpp/xournalpp/issues{/number}","pulls_url":"https://api.github.com/repos/xournalpp/xournalpp/pulls{/number}","milestones_url":"https://api.github.com/repos/xournalpp/xournalpp/milestones{/number}","notifications_url":"https://api.github.com/repos/xournalpp/xournalpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xournalpp/xournalpp/labels{/name}","releases_url":"https://api.github.com/repos/xournalpp/xournalpp/releases{/id}","deployments_url":"https://api.github.com/repos/xournalpp/xournalpp/deployments","created_at":"2013-08-08T20:58:27Z","updated_at":"2018-12-13T16:50:58Z","pushed_at":"2018-12-13T17:34:25Z","git_url":"git://github.com/xournalpp/xournalpp.git","ssh_url":"git@github.com:xournalpp/xournalpp.git","clone_url":"https://github.com/xournalpp/xournalpp.git","svn_url":"https://github.com/xournalpp/xournalpp","homepage":"","size":17755,"stargazers_count":175,"watchers_count":175,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":46,"open_issues":34,"watchers":175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/525"},"html":{"href":"https://github.com/xournalpp/xournalpp/pull/525"},"issue":{"href":"https://api.github.com/repos/xournalpp/xournalpp/issues/525"},"comments":{"href":"https://api.github.com/repos/xournalpp/xournalpp/issues/525/comments"},"review_comments":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/525/comments"},"review_comment":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xournalpp/xournalpp/pulls/525/commits"},"statuses":{"href":"https://api.github.com/repos/xournalpp/xournalpp/statuses/87ee420a8c7899df0263d45a608e9caafeeac875"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"morrolinux"}}