{"action":"created","comment":{"url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/comments/218608721","pull_request_review_id":156586213,"id":218608721,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODYwODcyMQ==","diff_hunk":"@@ -100,41 +100,30 @@ class V00_MarkeplaceAdapter {\n   }\n \n   async makeOffer(listingId, ipfsBytes, data, confirmationCallback) {\n-    const { affiliate, arbitrator, commission = {}, finalizes, totalPrice = {}, unitsPurchased } = data\n+    const { affiliate, arbitrator, commission, finalizes, totalPrice = {}, unitsPurchased } = data","path":"src/adapters/marketplace/v00.js","position":5,"original_position":5,"commit_id":"8bba65841b2e5f0b6dede12c88a248e97b77653e","original_commit_id":"8bba65841b2e5f0b6dede12c88a248e97b77653e","user":{"login":"tyleryasaka","id":6504519,"node_id":"MDQ6VXNlcjY1MDQ1MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6504519?v=4","gravatar_id":"","url":"https://api.github.com/users/tyleryasaka","html_url":"https://github.com/tyleryasaka","followers_url":"https://api.github.com/users/tyleryasaka/followers","following_url":"https://api.github.com/users/tyleryasaka/following{/other_user}","gists_url":"https://api.github.com/users/tyleryasaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tyleryasaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyleryasaka/subscriptions","organizations_url":"https://api.github.com/users/tyleryasaka/orgs","repos_url":"https://api.github.com/users/tyleryasaka/repos","events_url":"https://api.github.com/users/tyleryasaka/events{/privacy}","received_events_url":"https://api.github.com/users/tyleryasaka/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2018-09-18T21:56:42Z","updated_at":"2018-09-18T21:56:42Z","html_url":"https://github.com/OriginProtocol/origin-js/pull/483#discussion_r218608721","pull_request_url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/483","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/comments/218608721"},"html":{"href":"https://github.com/OriginProtocol/origin-js/pull/483#discussion_r218608721"},"pull_request":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/483"}},"in_reply_to_id":218607522},"pull_request":{"url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/483","id":216426985,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDI2OTg1","html_url":"https://github.com/OriginProtocol/origin-js/pull/483","diff_url":"https://github.com/OriginProtocol/origin-js/pull/483.diff","patch_url":"https://github.com/OriginProtocol/origin-js/pull/483.patch","issue_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/483","number":483,"state":"open","locked":false,"title":"Money + Commission Fixes","user":{"login":"tyleryasaka","id":6504519,"node_id":"MDQ6VXNlcjY1MDQ1MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6504519?v=4","gravatar_id":"","url":"https://api.github.com/users/tyleryasaka","html_url":"https://github.com/tyleryasaka","followers_url":"https://api.github.com/users/tyleryasaka/followers","following_url":"https://api.github.com/users/tyleryasaka/following{/other_user}","gists_url":"https://api.github.com/users/tyleryasaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tyleryasaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyleryasaka/subscriptions","organizations_url":"https://api.github.com/users/tyleryasaka/orgs","repos_url":"https://api.github.com/users/tyleryasaka/repos","events_url":"https://api.github.com/users/tyleryasaka/events{/privacy}","received_events_url":"https://api.github.com/users/tyleryasaka/received_events","type":"User","site_admin":false},"body":"### Checklist:\r\n\r\n- [x] Code contains relevant tests for the problem you are solving\r\n- [x] Ensure all new and existing tests pass\r\n- [x] Update any relevant READMEs and [docs](https://github.com/OriginProtocol/docs)\r\n\r\n### Description:\r\n\r\n- Create moneyToUnits method on contract service which reads a money object and returns the blockchain units for it based on currency\r\n- Use BigNumber for safely converting ERC20 currencies to blockchain units\r\n- Fix bug where offer price validation was incorrect for ERC20 tokens\r\n- Makes `Money` a model rather than util (seems more like a model to me)\r\n","created_at":"2018-09-18T20:03:08Z","updated_at":"2018-09-18T21:56:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e823ffa153b7bc56aaa6a3810ee5c9ab3d812c3b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"micahalcorn","id":273937,"node_id":"MDQ6VXNlcjI3MzkzNw==","avatar_url":"https://avatars1.githubusercontent.com/u/273937?v=4","gravatar_id":"","url":"https://api.github.com/users/micahalcorn","html_url":"https://github.com/micahalcorn","followers_url":"https://api.github.com/users/micahalcorn/followers","following_url":"https://api.github.com/users/micahalcorn/following{/other_user}","gists_url":"https://api.github.com/users/micahalcorn/gists{/gist_id}","starred_url":"https://api.github.com/users/micahalcorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micahalcorn/subscriptions","organizations_url":"https://api.github.com/users/micahalcorn/orgs","repos_url":"https://api.github.com/users/micahalcorn/repos","events_url":"https://api.github.com/users/micahalcorn/events{/privacy}","received_events_url":"https://api.github.com/users/micahalcorn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/483/commits","review_comments_url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/483/comments","review_comment_url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/483/comments","statuses_url":"https://api.github.com/repos/OriginProtocol/origin-js/statuses/8bba65841b2e5f0b6dede12c88a248e97b77653e","head":{"label":"OriginProtocol:tyleryasaka/money-to-units","ref":"tyleryasaka/money-to-units","sha":"8bba65841b2e5f0b6dede12c88a248e97b77653e","user":{"login":"OriginProtocol","id":30638653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjM4NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/30638653?v=4","gravatar_id":"","url":"https://api.github.com/users/OriginProtocol","html_url":"https://github.com/OriginProtocol","followers_url":"https://api.github.com/users/OriginProtocol/followers","following_url":"https://api.github.com/users/OriginProtocol/following{/other_user}","gists_url":"https://api.github.com/users/OriginProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/OriginProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OriginProtocol/subscriptions","organizations_url":"https://api.github.com/users/OriginProtocol/orgs","repos_url":"https://api.github.com/users/OriginProtocol/repos","events_url":"https://api.github.com/users/OriginProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/OriginProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":112376515,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzNzY1MTU=","name":"origin-js","full_name":"OriginProtocol/origin-js","private":false,"owner":{"login":"OriginProtocol","id":30638653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjM4NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/30638653?v=4","gravatar_id":"","url":"https://api.github.com/users/OriginProtocol","html_url":"https://github.com/OriginProtocol","followers_url":"https://api.github.com/users/OriginProtocol/followers","following_url":"https://api.github.com/users/OriginProtocol/following{/other_user}","gists_url":"https://api.github.com/users/OriginProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/OriginProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OriginProtocol/subscriptions","organizations_url":"https://api.github.com/users/OriginProtocol/orgs","repos_url":"https://api.github.com/users/OriginProtocol/repos","events_url":"https://api.github.com/users/OriginProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/OriginProtocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OriginProtocol/origin-js","description":"Origin.js library for interfacing with Origin standards. Our smart contracts currently live here too.","fork":false,"url":"https://api.github.com/repos/OriginProtocol/origin-js","forks_url":"https://api.github.com/repos/OriginProtocol/origin-js/forks","keys_url":"https://api.github.com/repos/OriginProtocol/origin-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OriginProtocol/origin-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OriginProtocol/origin-js/teams","hooks_url":"https://api.github.com/repos/OriginProtocol/origin-js/hooks","issue_events_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/events{/number}","events_url":"https://api.github.com/repos/OriginProtocol/origin-js/events","assignees_url":"https://api.github.com/repos/OriginProtocol/origin-js/assignees{/user}","branches_url":"https://api.github.com/repos/OriginProtocol/origin-js/branches{/branch}","tags_url":"https://api.github.com/repos/OriginProtocol/origin-js/tags","blobs_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OriginProtocol/origin-js/statuses/{sha}","languages_url":"https://api.github.com/repos/OriginProtocol/origin-js/languages","stargazers_url":"https://api.github.com/repos/OriginProtocol/origin-js/stargazers","contributors_url":"https://api.github.com/repos/OriginProtocol/origin-js/contributors","subscribers_url":"https://api.github.com/repos/OriginProtocol/origin-js/subscribers","subscription_url":"https://api.github.com/repos/OriginProtocol/origin-js/subscription","commits_url":"https://api.github.com/repos/OriginProtocol/origin-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/OriginProtocol/origin-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/OriginProtocol/origin-js/contents/{+path}","compare_url":"https://api.github.com/repos/OriginProtocol/origin-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OriginProtocol/origin-js/merges","archive_url":"https://api.github.com/repos/OriginProtocol/origin-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OriginProtocol/origin-js/downloads","issues_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues{/number}","pulls_url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls{/number}","milestones_url":"https://api.github.com/repos/OriginProtocol/origin-js/milestones{/number}","notifications_url":"https://api.github.com/repos/OriginProtocol/origin-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OriginProtocol/origin-js/labels{/name}","releases_url":"https://api.github.com/repos/OriginProtocol/origin-js/releases{/id}","deployments_url":"https://api.github.com/repos/OriginProtocol/origin-js/deployments","created_at":"2017-11-28T19:00:15Z","updated_at":"2018-09-18T18:37:22Z","pushed_at":"2018-09-18T21:44:39Z","git_url":"git://github.com/OriginProtocol/origin-js.git","ssh_url":"git@github.com:OriginProtocol/origin-js.git","clone_url":"https://github.com/OriginProtocol/origin-js.git","svn_url":"https://github.com/OriginProtocol/origin-js","homepage":"","size":15719,"stargazers_count":72,"watchers_count":72,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":38,"open_issues":83,"watchers":72,"default_branch":"master"}},"base":{"label":"OriginProtocol:master","ref":"master","sha":"8907caf4400af2228b8a9a37a51ce3cb637e29c0","user":{"login":"OriginProtocol","id":30638653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjM4NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/30638653?v=4","gravatar_id":"","url":"https://api.github.com/users/OriginProtocol","html_url":"https://github.com/OriginProtocol","followers_url":"https://api.github.com/users/OriginProtocol/followers","following_url":"https://api.github.com/users/OriginProtocol/following{/other_user}","gists_url":"https://api.github.com/users/OriginProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/OriginProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OriginProtocol/subscriptions","organizations_url":"https://api.github.com/users/OriginProtocol/orgs","repos_url":"https://api.github.com/users/OriginProtocol/repos","events_url":"https://api.github.com/users/OriginProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/OriginProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":112376515,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzNzY1MTU=","name":"origin-js","full_name":"OriginProtocol/origin-js","private":false,"owner":{"login":"OriginProtocol","id":30638653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjM4NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/30638653?v=4","gravatar_id":"","url":"https://api.github.com/users/OriginProtocol","html_url":"https://github.com/OriginProtocol","followers_url":"https://api.github.com/users/OriginProtocol/followers","following_url":"https://api.github.com/users/OriginProtocol/following{/other_user}","gists_url":"https://api.github.com/users/OriginProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/OriginProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OriginProtocol/subscriptions","organizations_url":"https://api.github.com/users/OriginProtocol/orgs","repos_url":"https://api.github.com/users/OriginProtocol/repos","events_url":"https://api.github.com/users/OriginProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/OriginProtocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OriginProtocol/origin-js","description":"Origin.js library for interfacing with Origin standards. Our smart contracts currently live here too.","fork":false,"url":"https://api.github.com/repos/OriginProtocol/origin-js","forks_url":"https://api.github.com/repos/OriginProtocol/origin-js/forks","keys_url":"https://api.github.com/repos/OriginProtocol/origin-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OriginProtocol/origin-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OriginProtocol/origin-js/teams","hooks_url":"https://api.github.com/repos/OriginProtocol/origin-js/hooks","issue_events_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/events{/number}","events_url":"https://api.github.com/repos/OriginProtocol/origin-js/events","assignees_url":"https://api.github.com/repos/OriginProtocol/origin-js/assignees{/user}","branches_url":"https://api.github.com/repos/OriginProtocol/origin-js/branches{/branch}","tags_url":"https://api.github.com/repos/OriginProtocol/origin-js/tags","blobs_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OriginProtocol/origin-js/statuses/{sha}","languages_url":"https://api.github.com/repos/OriginProtocol/origin-js/languages","stargazers_url":"https://api.github.com/repos/OriginProtocol/origin-js/stargazers","contributors_url":"https://api.github.com/repos/OriginProtocol/origin-js/contributors","subscribers_url":"https://api.github.com/repos/OriginProtocol/origin-js/subscribers","subscription_url":"https://api.github.com/repos/OriginProtocol/origin-js/subscription","commits_url":"https://api.github.com/repos/OriginProtocol/origin-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/OriginProtocol/origin-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/OriginProtocol/origin-js/contents/{+path}","compare_url":"https://api.github.com/repos/OriginProtocol/origin-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OriginProtocol/origin-js/merges","archive_url":"https://api.github.com/repos/OriginProtocol/origin-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OriginProtocol/origin-js/downloads","issues_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues{/number}","pulls_url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls{/number}","milestones_url":"https://api.github.com/repos/OriginProtocol/origin-js/milestones{/number}","notifications_url":"https://api.github.com/repos/OriginProtocol/origin-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OriginProtocol/origin-js/labels{/name}","releases_url":"https://api.github.com/repos/OriginProtocol/origin-js/releases{/id}","deployments_url":"https://api.github.com/repos/OriginProtocol/origin-js/deployments","created_at":"2017-11-28T19:00:15Z","updated_at":"2018-09-18T18:37:22Z","pushed_at":"2018-09-18T21:44:39Z","git_url":"git://github.com/OriginProtocol/origin-js.git","ssh_url":"git@github.com:OriginProtocol/origin-js.git","clone_url":"https://github.com/OriginProtocol/origin-js.git","svn_url":"https://github.com/OriginProtocol/origin-js","homepage":"","size":15719,"stargazers_count":72,"watchers_count":72,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":38,"open_issues":83,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/483"},"html":{"href":"https://github.com/OriginProtocol/origin-js/pull/483"},"issue":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/issues/483"},"comments":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/issues/483/comments"},"review_comments":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/483/comments"},"review_comment":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/483/commits"},"statuses":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/statuses/8bba65841b2e5f0b6dede12c88a248e97b77653e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tyleryasaka"}}