{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/174825656","pull_request_review_id":104252139,"id":174825656,"diff_hunk":"@@ -681,7 +684,31 @@ func (h *putEndpointIDLabels) Handle(params PutEndpointIDLabelsParams) middlewar\n }\n \n // OnIPIdentityCacheChange is called whenever there is a change of state in the\n-// IPCache (pkg/ipcache). Currently does nothing as of now.\n-func (d *Daemon) OnIPIdentityCacheChange() {\n-\n+// IPCache (pkg/ipcache).\n+func (d *Daemon) OnIPIdentityCacheChange(modType ipcache.CacheModification, ipIDPair identity.IPIdentityPair) {\n+\t// TODO - see if we can factor this into an interface under something like\n+\t// pkg/datapath instead of in the daemon directly so that the code is more\n+\t// logically located.\n+\n+\t// Update BPF Maps.\n+\tkey := remotelxcmap.NewEndpointKey(ipIDPair.IP)\n+\tvalue := remotelxcmap.RemoteEndpointInfo{SecurityIdentity: uint16(ipIDPair.ID)}\n+\n+\tif modType == ipcache.Upsert {","path":"daemon/endpoint.go","position":27,"original_position":27,"commit_id":"d1a86c4b26baec04eac7c91f23a5ceb898fa9300","original_commit_id":"d1a86c4b26baec04eac7c91f23a5ceb898fa9300","user":{"login":"raybejjani","id":744312,"avatar_url":"https://avatars0.githubusercontent.com/u/744312?v=4","gravatar_id":"","url":"https://api.github.com/users/raybejjani","html_url":"https://github.com/raybejjani","followers_url":"https://api.github.com/users/raybejjani/followers","following_url":"https://api.github.com/users/raybejjani/following{/other_user}","gists_url":"https://api.github.com/users/raybejjani/gists{/gist_id}","starred_url":"https://api.github.com/users/raybejjani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raybejjani/subscriptions","organizations_url":"https://api.github.com/users/raybejjani/orgs","repos_url":"https://api.github.com/users/raybejjani/repos","events_url":"https://api.github.com/users/raybejjani/events{/privacy}","received_events_url":"https://api.github.com/users/raybejjani/received_events","type":"User","site_admin":false},"body":"a `switch` might be better suited here instead of the if-else chain","created_at":"2018-03-15T15:29:42Z","updated_at":"2018-03-15T15:38:33Z","html_url":"https://github.com/cilium/cilium/pull/3037#discussion_r174825656","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/3037","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/174825656"},"html":{"href":"https://github.com/cilium/cilium/pull/3037#discussion_r174825656"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3037"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/3037","id":173308793,"html_url":"https://github.com/cilium/cilium/pull/3037","diff_url":"https://github.com/cilium/cilium/pull/3037.diff","patch_url":"https://github.com/cilium/cilium/pull/3037.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/3037","number":3037,"state":"open","locked":false,"title":"pkg/maps: add remote endpoint map for egress policy enforcement","user":{"login":"ianvernon","id":3858271,"avatar_url":"https://avatars1.githubusercontent.com/u/3858271?v=4","gravatar_id":"","url":"https://api.github.com/users/ianvernon","html_url":"https://github.com/ianvernon","followers_url":"https://api.github.com/users/ianvernon/followers","following_url":"https://api.github.com/users/ianvernon/following{/other_user}","gists_url":"https://api.github.com/users/ianvernon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianvernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianvernon/subscriptions","organizations_url":"https://api.github.com/users/ianvernon/orgs","repos_url":"https://api.github.com/users/ianvernon/repos","events_url":"https://api.github.com/users/ianvernon/events{/privacy}","received_events_url":"https://api.github.com/users/ianvernon/received_events","type":"User","site_admin":false},"body":"Plumb the contents of the ip-identity cache to a BPF map for lookup in the datapath.\r\n\r\nSigned-off by: Ian Vernon <ian@cilium.io>\r\n\r\nRelated-to: #1488 \r\n\r\n```release-note\r\nPlumb the contents of the ip-identity cache to a BPF map for lookup in the datapath.\r\n```\r\n","created_at":"2018-03-06T23:10:22Z","updated_at":"2018-03-15T15:38:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2f6245d5f846e0d680fcfbb4405c06e97438848","assignee":null,"assignees":[],"requested_reviewers":[{"login":"joestringer","id":1243336,"avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},{"login":"aanm","id":5714066,"avatar_url":"https://avatars0.githubusercontent.com/u/5714066?v=4","gravatar_id":"","url":"https://api.github.com/users/aanm","html_url":"https://github.com/aanm","followers_url":"https://api.github.com/users/aanm/followers","following_url":"https://api.github.com/users/aanm/following{/other_user}","gists_url":"https://api.github.com/users/aanm/gists{/gist_id}","starred_url":"https://api.github.com/users/aanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanm/subscriptions","organizations_url":"https://api.github.com/users/aanm/orgs","repos_url":"https://api.github.com/users/aanm/repos","events_url":"https://api.github.com/users/aanm/events{/privacy}","received_events_url":"https://api.github.com/users/aanm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":721366506,"url":"https://api.github.com/repos/cilium/cilium/labels/area/daemon","name":"area/daemon","color":"089dd8","default":false},{"id":721252768,"url":"https://api.github.com/repos/cilium/cilium/labels/area/datapath","name":"area/datapath","color":"bfdadc","default":false},{"id":403149902,"url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false},{"id":809259668,"url":"https://api.github.com/repos/cilium/cilium/labels/priority/1.0-blocker","name":"priority/1.0-blocker","color":"b60205","default":false},{"id":732923415,"url":"https://api.github.com/repos/cilium/cilium/labels/release-note/minor","name":"release-note/minor","color":"c2e0c6","default":false},{"id":755969022,"url":"https://api.github.com/repos/cilium/cilium/labels/requires-janitor-review","name":"requires-janitor-review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/3037/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/3037/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/3037/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/d1a86c4b26baec04eac7c91f23a5ceb898fa9300","head":{"label":"cilium:add-remote-endpoint-map-2","ref":"add-remote-endpoint-map-2","sha":"d1a86c4b26baec04eac7c91f23a5ceb898fa9300","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Network Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-03-15T15:33:33Z","pushed_at":"2018-03-15T15:37:33Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":42860,"stargazers_count":1647,"watchers_count":1647,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":157,"mirror_url":null,"archived":false,"open_issues_count":384,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":157,"open_issues":384,"watchers":1647,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"20e34746217381ae2913125103dd5f9b5c28a0a0","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Network Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-03-15T15:33:33Z","pushed_at":"2018-03-15T15:37:33Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":42860,"stargazers_count":1647,"watchers_count":1647,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":157,"mirror_url":null,"archived":false,"open_issues_count":384,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":157,"open_issues":384,"watchers":1647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3037"},"html":{"href":"https://github.com/cilium/cilium/pull/3037"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/3037"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/3037/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3037/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3037/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/d1a86c4b26baec04eac7c91f23a5ceb898fa9300"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"raybejjani"}}