{"action":"created","issue":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/710","repository_url":"https://api.github.com/repos/openjournals/joss-reviews","labels_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/710/labels{/name}","comments_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/710/comments","events_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/710/events","html_url":"https://github.com/openjournals/joss-reviews/issues/710","id":319287171,"node_id":"MDU6SXNzdWUzMTkyODcxNzE=","number":710,"title":"[REVIEW]: MCycle: A Python package for 1D sizing and analysis of thermodynamic power cycles","user":{"login":"whedon","id":18508068,"node_id":"MDQ6VXNlcjE4NTA4MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/18508068?v=4","gravatar_id":"","url":"https://api.github.com/users/whedon","html_url":"https://github.com/whedon","followers_url":"https://api.github.com/users/whedon/followers","following_url":"https://api.github.com/users/whedon/following{/other_user}","gists_url":"https://api.github.com/users/whedon/gists{/gist_id}","starred_url":"https://api.github.com/users/whedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whedon/subscriptions","organizations_url":"https://api.github.com/users/whedon/orgs","repos_url":"https://api.github.com/users/whedon/repos","events_url":"https://api.github.com/users/whedon/events{/privacy}","received_events_url":"https://api.github.com/users/whedon/received_events","type":"User","site_admin":false},"labels":[{"id":330465313,"node_id":"MDU6TGFiZWwzMzA0NjUzMTM=","url":"https://api.github.com/repos/openjournals/joss-reviews/labels/review","name":"review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"katyhuff","id":393899,"node_id":"MDQ6VXNlcjM5Mzg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/393899?v=4","gravatar_id":"","url":"https://api.github.com/users/katyhuff","html_url":"https://github.com/katyhuff","followers_url":"https://api.github.com/users/katyhuff/followers","following_url":"https://api.github.com/users/katyhuff/following{/other_user}","gists_url":"https://api.github.com/users/katyhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/katyhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katyhuff/subscriptions","organizations_url":"https://api.github.com/users/katyhuff/orgs","repos_url":"https://api.github.com/users/katyhuff/repos","events_url":"https://api.github.com/users/katyhuff/events{/privacy}","received_events_url":"https://api.github.com/users/katyhuff/received_events","type":"User","site_admin":false},"assignees":[{"login":"katyhuff","id":393899,"node_id":"MDQ6VXNlcjM5Mzg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/393899?v=4","gravatar_id":"","url":"https://api.github.com/users/katyhuff","html_url":"https://github.com/katyhuff","followers_url":"https://api.github.com/users/katyhuff/followers","following_url":"https://api.github.com/users/katyhuff/following{/other_user}","gists_url":"https://api.github.com/users/katyhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/katyhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katyhuff/subscriptions","organizations_url":"https://api.github.com/users/katyhuff/orgs","repos_url":"https://api.github.com/users/katyhuff/repos","events_url":"https://api.github.com/users/katyhuff/events{/privacy}","received_events_url":"https://api.github.com/users/katyhuff/received_events","type":"User","site_admin":false},{"login":"puncan","id":33850969,"node_id":"MDQ6VXNlcjMzODUwOTY5","avatar_url":"https://avatars1.githubusercontent.com/u/33850969?v=4","gravatar_id":"","url":"https://api.github.com/users/puncan","html_url":"https://github.com/puncan","followers_url":"https://api.github.com/users/puncan/followers","following_url":"https://api.github.com/users/puncan/following{/other_user}","gists_url":"https://api.github.com/users/puncan/gists{/gist_id}","starred_url":"https://api.github.com/users/puncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puncan/subscriptions","organizations_url":"https://api.github.com/users/puncan/orgs","repos_url":"https://api.github.com/users/puncan/repos","events_url":"https://api.github.com/users/puncan/events{/privacy}","received_events_url":"https://api.github.com/users/puncan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":20,"created_at":"2018-05-01T18:44:45Z","updated_at":"2018-07-24T06:33:49Z","closed_at":null,"author_association":"COLLABORATOR","body":"**Submitting author:** @momargoh (<a href=\"http://orcid.org/0000-0002-6928-2187\">Momar Hughes</a>)\r\n**Repository:** <a href=\"https://github.com/momargoh/MCycle\" target =\"_blank\">https://github.com/momargoh/MCycle</a>\r\n**Version:** v0.1.2\r\n**Editor:** @katyhuff\r\n**Reviewers:** @Tabeel, @puncan\r\n**Archive:** Pending\r\n\r\n## Status\r\n\r\n[![status](http://joss.theoj.org/papers/4363ce4be11df7bc38bd47246fbd34ce/status.svg)](http://joss.theoj.org/papers/4363ce4be11df7bc38bd47246fbd34ce)\r\n\r\nStatus badge code:\r\n\r\n```\r\nHTML: <a href=\"http://joss.theoj.org/papers/4363ce4be11df7bc38bd47246fbd34ce\"><img src=\"http://joss.theoj.org/papers/4363ce4be11df7bc38bd47246fbd34ce/status.svg\"></a>\r\nMarkdown: [![status](http://joss.theoj.org/papers/4363ce4be11df7bc38bd47246fbd34ce/status.svg)](http://joss.theoj.org/papers/4363ce4be11df7bc38bd47246fbd34ce)\r\n```\r\n**Reviewers and authors**:\r\n\r\nPlease avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the <a href=\"https://github.com/momargoh/MCycle\" target=\"_blank\">target repository</a> and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)\r\n\r\n## Reviewer instructions & questions\r\n\r\n@puncan, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:\r\n1. Make sure you're logged in to your GitHub account\r\n2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations\r\n\r\nThe reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @katyhuff know.\r\n\r\n## Review checklist for @puncan\r\n### Conflict of interest\r\n\r\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\r\n\r\n### Code of Conduct\r\n\r\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\r\n\r\n### General checks\r\n\r\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/momargoh/MCycle\">repository url</a>?\r\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\r\n- [x] **Version:** Does the release version given match the GitHub release (v0.1.2)?\r\n- [x] **Authorship:** Has the submitting author (@momargoh) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\r\n\r\n### Functionality\r\n\r\n- [x] **Installation:** Does installation proceed as outlined in the documentation?\r\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\r\n- [x] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\r\n\r\n### Documentation\r\n\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\r\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\r\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\r\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\r\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\r\n\r\n### Software paper\r\n\r\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\r\n\r\n\r\n## Review checklist for @Tabeel\r\n### Conflict of interest\r\n\r\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\r\n\r\n### Code of Conduct\r\n\r\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\r\n\r\n### General checks\r\n\r\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/momargoh/MCycle\">repository url</a>?\r\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\r\n- [x] **Version:** Does the release version given match the GitHub release (v0.1.2)?\r\n- [x] **Authorship:** Has the submitting author (@momargoh) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\r\n\r\n### Functionality\r\n\r\n- [x] **Installation:** Does installation proceed as outlined in the documentation?\r\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\r\n- [x] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\r\n\r\n### Documentation\r\n\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\r\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\r\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\r\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\r\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\r\n\r\n### Software paper\r\n\r\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?"},"comment":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/comments/407296922","html_url":"https://github.com/openjournals/joss-reviews/issues/710#issuecomment-407296922","issue_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/710","id":407296922,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzI5NjkyMg==","user":{"login":"momargoh","id":18644312,"node_id":"MDQ6VXNlcjE4NjQ0MzEy","avatar_url":"https://avatars3.githubusercontent.com/u/18644312?v=4","gravatar_id":"","url":"https://api.github.com/users/momargoh","html_url":"https://github.com/momargoh","followers_url":"https://api.github.com/users/momargoh/followers","following_url":"https://api.github.com/users/momargoh/following{/other_user}","gists_url":"https://api.github.com/users/momargoh/gists{/gist_id}","starred_url":"https://api.github.com/users/momargoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momargoh/subscriptions","organizations_url":"https://api.github.com/users/momargoh/orgs","repos_url":"https://api.github.com/users/momargoh/repos","events_url":"https://api.github.com/users/momargoh/events{/privacy}","received_events_url":"https://api.github.com/users/momargoh/received_events","type":"User","site_admin":false},"created_at":"2018-07-24T06:33:49Z","updated_at":"2018-07-24T06:33:49Z","author_association":"NONE","body":"No, I haven't handled all the issues raised by @puncan yet, doing so now. I'm having trouble committing the new Cython-based version to pip due to problems creating a cross-platform dist wheel. The package can be built from the source using `python3 setup.py install` and similarly the docs will not be hosted properly until the package is on pip, so at the moment they can just be built from the source using Sphinx3 `make html`.\r\nIs this OK: the package needing to be built from source instead of available from pip?"}}
{"actor":{"display_login":"momargoh"}}