{"action":"created","issue":{"url":"https://api.github.com/repos/FirefoxUX/photon-icons/issues/33","repository_url":"https://api.github.com/repos/FirefoxUX/photon-icons","labels_url":"https://api.github.com/repos/FirefoxUX/photon-icons/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/FirefoxUX/photon-icons/issues/33/comments","events_url":"https://api.github.com/repos/FirefoxUX/photon-icons/issues/33/events","html_url":"https://github.com/FirefoxUX/photon-icons/pull/33","id":344711013,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MDM5OTM1","number":33,"title":"Update DevTools icons","user":{"login":"birtles","id":1232595,"node_id":"MDQ6VXNlcjEyMzI1OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1232595?v=4","gravatar_id":"","url":"https://api.github.com/users/birtles","html_url":"https://github.com/birtles","followers_url":"https://api.github.com/users/birtles/followers","following_url":"https://api.github.com/users/birtles/following{/other_user}","gists_url":"https://api.github.com/users/birtles/gists{/gist_id}","starred_url":"https://api.github.com/users/birtles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birtles/subscriptions","organizations_url":"https://api.github.com/users/birtles/orgs","repos_url":"https://api.github.com/users/birtles/repos","events_url":"https://api.github.com/users/birtles/events{/privacy}","received_events_url":"https://api.github.com/users/birtles/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-26T06:26:48Z","updated_at":"2018-07-26T13:15:57Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/FirefoxUX/photon-icons/pulls/33","html_url":"https://github.com/FirefoxUX/photon-icons/pull/33","diff_url":"https://github.com/FirefoxUX/photon-icons/pull/33.diff","patch_url":"https://github.com/FirefoxUX/photon-icons/pull/33.patch"},"body":"This reflects the changes from [bug 1474224](https://bugzilla.mozilla.org/show_bug.cgi?id=1474224).\r\n\r\nIn particular:\r\n\r\n* Makes the \"dock to bottom\" icon have the same width as the other docking icons\r\n* Updates the \"undock\" icon so that it matches the Photon \"Open in New\" icon but has the same proportions as the other docking icons\r\n* Updates the \"options\" icon to follow the Photon \"Settings\" icon and removes the deprecated label\r\n\r\nThese icons don't include an explicit width/height since that's generally an anti-pattern when creating SVG resources (they should scale to their container) but perhaps it's needed for the Photon icon viewer\r\nthough?"},"comment":{"url":"https://api.github.com/repos/FirefoxUX/photon-icons/issues/comments/408093486","html_url":"https://github.com/FirefoxUX/photon-icons/pull/33#issuecomment-408093486","issue_url":"https://api.github.com/repos/FirefoxUX/photon-icons/issues/33","id":408093486,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODA5MzQ4Ng==","user":{"login":"aminalhazwani","id":1721875,"node_id":"MDQ6VXNlcjE3MjE4NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/1721875?v=4","gravatar_id":"","url":"https://api.github.com/users/aminalhazwani","html_url":"https://github.com/aminalhazwani","followers_url":"https://api.github.com/users/aminalhazwani/followers","following_url":"https://api.github.com/users/aminalhazwani/following{/other_user}","gists_url":"https://api.github.com/users/aminalhazwani/gists{/gist_id}","starred_url":"https://api.github.com/users/aminalhazwani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aminalhazwani/subscriptions","organizations_url":"https://api.github.com/users/aminalhazwani/orgs","repos_url":"https://api.github.com/users/aminalhazwani/repos","events_url":"https://api.github.com/users/aminalhazwani/events{/privacy}","received_events_url":"https://api.github.com/users/aminalhazwani/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T13:15:57Z","updated_at":"2018-07-26T13:15:57Z","author_association":"MEMBER","body":"> And yes, the icons will need explicit width/heights, or we get validation errors (which you can see at npm run test).\r\n\r\nAnd also because the icons are meant to be only used at their specific size even if you might scale the SVGs. The main reasons: icon-size consistency - all the icons are 16x16. And pixel snapping - being drawn at 16x16 we made sure that the stroke is snapped to the pixel grid. If we would scale the icon to 20x20 for example the two pixel stroke would be some like 2,xxx."}}
{"actor":{"display_login":"aminalhazwani"}}