{"action":"created","comment":{"url":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls/comments/168924296","pull_request_review_id":97375526,"id":168924296,"diff_hunk":"@@ -17,20 +22,53 @@\n     @Getter @Setter private Source source;\n     @Getter @Setter private KRLanguage kRLanguage = KRLanguage.UNKNOWN;\n \n+\n     /**\n      * Gets the hash code modifier.\n+     *\n      * @return Hashcode modifier.\n      */\n     protected abstract int getHashModifier();\n \n     /**\n      * Gets the type string of the condition type.\n+     *\n      * @return The type string of the condition type.\n      */\n     protected abstract String getTypeName();\n \n+    /**\n+     * Gets the variable from a condition which are used in the condition.\n+     * @return A list of parameters. If there are no parameters, the list will start with NULL\n+     */\n+    public List<Parameter> getExpressionVariable() {\n+        return getExpressionParameterRecusion(Collections.singletonList(expression));\n+    }\n+\n+    private static List<Parameter> getExpressionParameterRecusion(List<Expression> expression) {","path":"src/main/java/nl/tudelft/goalkeeper/parser/results/files/module/conditions/Condition.java","position":42,"original_position":42,"commit_id":"75f6298ce8b29409b9bb302d5b221b4704a48b42","original_commit_id":"75f6298ce8b29409b9bb302d5b221b4704a48b42","user":{"login":"CptWesley","id":9980136,"avatar_url":"https://avatars2.githubusercontent.com/u/9980136?v=4","gravatar_id":"","url":"https://api.github.com/users/CptWesley","html_url":"https://github.com/CptWesley","followers_url":"https://api.github.com/users/CptWesley/followers","following_url":"https://api.github.com/users/CptWesley/following{/other_user}","gists_url":"https://api.github.com/users/CptWesley/gists{/gist_id}","starred_url":"https://api.github.com/users/CptWesley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CptWesley/subscriptions","organizations_url":"https://api.github.com/users/CptWesley/orgs","repos_url":"https://api.github.com/users/CptWesley/repos","events_url":"https://api.github.com/users/CptWesley/events{/privacy}","received_events_url":"https://api.github.com/users/CptWesley/received_events","type":"User","site_admin":false},"body":"And missing javadoc","created_at":"2018-02-17T15:15:12Z","updated_at":"2018-02-17T15:17:37Z","html_url":"https://github.com/CptWesley/GOALkeeper/pull/55#discussion_r168924296","pull_request_url":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls/55","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls/comments/168924296"},"html":{"href":"https://github.com/CptWesley/GOALkeeper/pull/55#discussion_r168924296"},"pull_request":{"href":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls/55"}},"in_reply_to_id":168924295},"pull_request":{"url":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls/55","id":169311981,"html_url":"https://github.com/CptWesley/GOALkeeper/pull/55","diff_url":"https://github.com/CptWesley/GOALkeeper/pull/55.diff","patch_url":"https://github.com/CptWesley/GOALkeeper/pull/55.patch","issue_url":"https://api.github.com/repos/CptWesley/GOALkeeper/issues/55","number":55,"state":"open","locked":false,"title":"Simple rule equality","user":{"login":"ceddy4395","id":8796831,"avatar_url":"https://avatars2.githubusercontent.com/u/8796831?v=4","gravatar_id":"","url":"https://api.github.com/users/ceddy4395","html_url":"https://github.com/ceddy4395","followers_url":"https://api.github.com/users/ceddy4395/followers","following_url":"https://api.github.com/users/ceddy4395/following{/other_user}","gists_url":"https://api.github.com/users/ceddy4395/gists{/gist_id}","starred_url":"https://api.github.com/users/ceddy4395/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceddy4395/subscriptions","organizations_url":"https://api.github.com/users/ceddy4395/orgs","repos_url":"https://api.github.com/users/ceddy4395/repos","events_url":"https://api.github.com/users/ceddy4395/events{/privacy}","received_events_url":"https://api.github.com/users/ceddy4395/received_events","type":"User","site_admin":false},"body":"Resolves #47 \r\n\r\n#### Changes:\r\n- Creates `ConditionComparator` class which is used in order to sort conditions. \r\n- Adds equivalence method to check if two rules are equivalent.\r\n- Adds method to get all the parameters of an expression.  \r\n- \r\n\r\n#### Notes:\r\n- This is a simplified version and will thus have to be enhanced later before it can optimally be used in checking for code duplication.\r\n","created_at":"2018-02-15T08:45:41Z","updated_at":"2018-02-17T15:17:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81ab31dd5da6db81bb6a62ac28905b515b20690f","assignee":{"login":"ceddy4395","id":8796831,"avatar_url":"https://avatars2.githubusercontent.com/u/8796831?v=4","gravatar_id":"","url":"https://api.github.com/users/ceddy4395","html_url":"https://github.com/ceddy4395","followers_url":"https://api.github.com/users/ceddy4395/followers","following_url":"https://api.github.com/users/ceddy4395/following{/other_user}","gists_url":"https://api.github.com/users/ceddy4395/gists{/gist_id}","starred_url":"https://api.github.com/users/ceddy4395/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceddy4395/subscriptions","organizations_url":"https://api.github.com/users/ceddy4395/orgs","repos_url":"https://api.github.com/users/ceddy4395/repos","events_url":"https://api.github.com/users/ceddy4395/events{/privacy}","received_events_url":"https://api.github.com/users/ceddy4395/received_events","type":"User","site_admin":false},"assignees":[{"login":"ceddy4395","id":8796831,"avatar_url":"https://avatars2.githubusercontent.com/u/8796831?v=4","gravatar_id":"","url":"https://api.github.com/users/ceddy4395","html_url":"https://github.com/ceddy4395","followers_url":"https://api.github.com/users/ceddy4395/followers","following_url":"https://api.github.com/users/ceddy4395/following{/other_user}","gists_url":"https://api.github.com/users/ceddy4395/gists{/gist_id}","starred_url":"https://api.github.com/users/ceddy4395/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceddy4395/subscriptions","organizations_url":"https://api.github.com/users/ceddy4395/orgs","repos_url":"https://api.github.com/users/ceddy4395/repos","events_url":"https://api.github.com/users/ceddy4395/events{/privacy}","received_events_url":"https://api.github.com/users/ceddy4395/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":749842465,"url":"https://api.github.com/repos/CptWesley/GOALkeeper/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":749912415,"url":"https://api.github.com/repos/CptWesley/GOALkeeper/labels/feature","name":"feature","color":"fbca04","default":false},{"id":781707614,"url":"https://api.github.com/repos/CptWesley/GOALkeeper/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls/55/commits","review_comments_url":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls/55/comments","review_comment_url":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CptWesley/GOALkeeper/issues/55/comments","statuses_url":"https://api.github.com/repos/CptWesley/GOALkeeper/statuses/75f6298ce8b29409b9bb302d5b221b4704a48b42","head":{"label":"CptWesley:rule-equality#47","ref":"rule-equality#47","sha":"75f6298ce8b29409b9bb302d5b221b4704a48b42","user":{"login":"CptWesley","id":9980136,"avatar_url":"https://avatars2.githubusercontent.com/u/9980136?v=4","gravatar_id":"","url":"https://api.github.com/users/CptWesley","html_url":"https://github.com/CptWesley","followers_url":"https://api.github.com/users/CptWesley/followers","following_url":"https://api.github.com/users/CptWesley/following{/other_user}","gists_url":"https://api.github.com/users/CptWesley/gists{/gist_id}","starred_url":"https://api.github.com/users/CptWesley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CptWesley/subscriptions","organizations_url":"https://api.github.com/users/CptWesley/orgs","repos_url":"https://api.github.com/users/CptWesley/repos","events_url":"https://api.github.com/users/CptWesley/events{/privacy}","received_events_url":"https://api.github.com/users/CptWesley/received_events","type":"User","site_admin":false},"repo":{"id":110661705,"name":"GOALkeeper","full_name":"CptWesley/GOALkeeper","owner":{"login":"CptWesley","id":9980136,"avatar_url":"https://avatars2.githubusercontent.com/u/9980136?v=4","gravatar_id":"","url":"https://api.github.com/users/CptWesley","html_url":"https://github.com/CptWesley","followers_url":"https://api.github.com/users/CptWesley/followers","following_url":"https://api.github.com/users/CptWesley/following{/other_user}","gists_url":"https://api.github.com/users/CptWesley/gists{/gist_id}","starred_url":"https://api.github.com/users/CptWesley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CptWesley/subscriptions","organizations_url":"https://api.github.com/users/CptWesley/orgs","repos_url":"https://api.github.com/users/CptWesley/repos","events_url":"https://api.github.com/users/CptWesley/events{/privacy}","received_events_url":"https://api.github.com/users/CptWesley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CptWesley/GOALkeeper","description":"Static analysis tools for GOAL programming language.","fork":false,"url":"https://api.github.com/repos/CptWesley/GOALkeeper","forks_url":"https://api.github.com/repos/CptWesley/GOALkeeper/forks","keys_url":"https://api.github.com/repos/CptWesley/GOALkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CptWesley/GOALkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CptWesley/GOALkeeper/teams","hooks_url":"https://api.github.com/repos/CptWesley/GOALkeeper/hooks","issue_events_url":"https://api.github.com/repos/CptWesley/GOALkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/CptWesley/GOALkeeper/events","assignees_url":"https://api.github.com/repos/CptWesley/GOALkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/CptWesley/GOALkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/CptWesley/GOALkeeper/tags","blobs_url":"https://api.github.com/repos/CptWesley/GOALkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CptWesley/GOALkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CptWesley/GOALkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/CptWesley/GOALkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CptWesley/GOALkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/CptWesley/GOALkeeper/languages","stargazers_url":"https://api.github.com/repos/CptWesley/GOALkeeper/stargazers","contributors_url":"https://api.github.com/repos/CptWesley/GOALkeeper/contributors","subscribers_url":"https://api.github.com/repos/CptWesley/GOALkeeper/subscribers","subscription_url":"https://api.github.com/repos/CptWesley/GOALkeeper/subscription","commits_url":"https://api.github.com/repos/CptWesley/GOALkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/CptWesley/GOALkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/CptWesley/GOALkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/CptWesley/GOALkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/CptWesley/GOALkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/CptWesley/GOALkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CptWesley/GOALkeeper/merges","archive_url":"https://api.github.com/repos/CptWesley/GOALkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CptWesley/GOALkeeper/downloads","issues_url":"https://api.github.com/repos/CptWesley/GOALkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/CptWesley/GOALkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/CptWesley/GOALkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CptWesley/GOALkeeper/labels{/name}","releases_url":"https://api.github.com/repos/CptWesley/GOALkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/CptWesley/GOALkeeper/deployments","created_at":"2017-11-14T08:26:53Z","updated_at":"2018-01-14T07:16:05Z","pushed_at":"2018-02-15T10:44:08Z","git_url":"git://github.com/CptWesley/GOALkeeper.git","ssh_url":"git@github.com:CptWesley/GOALkeeper.git","clone_url":"https://github.com/CptWesley/GOALkeeper.git","svn_url":"https://github.com/CptWesley/GOALkeeper","homepage":"","size":13274,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":17,"watchers":2,"default_branch":"master"}},"base":{"label":"CptWesley:master","ref":"master","sha":"623e0c711903869c77bc6c013d8fe26dbfc83f38","user":{"login":"CptWesley","id":9980136,"avatar_url":"https://avatars2.githubusercontent.com/u/9980136?v=4","gravatar_id":"","url":"https://api.github.com/users/CptWesley","html_url":"https://github.com/CptWesley","followers_url":"https://api.github.com/users/CptWesley/followers","following_url":"https://api.github.com/users/CptWesley/following{/other_user}","gists_url":"https://api.github.com/users/CptWesley/gists{/gist_id}","starred_url":"https://api.github.com/users/CptWesley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CptWesley/subscriptions","organizations_url":"https://api.github.com/users/CptWesley/orgs","repos_url":"https://api.github.com/users/CptWesley/repos","events_url":"https://api.github.com/users/CptWesley/events{/privacy}","received_events_url":"https://api.github.com/users/CptWesley/received_events","type":"User","site_admin":false},"repo":{"id":110661705,"name":"GOALkeeper","full_name":"CptWesley/GOALkeeper","owner":{"login":"CptWesley","id":9980136,"avatar_url":"https://avatars2.githubusercontent.com/u/9980136?v=4","gravatar_id":"","url":"https://api.github.com/users/CptWesley","html_url":"https://github.com/CptWesley","followers_url":"https://api.github.com/users/CptWesley/followers","following_url":"https://api.github.com/users/CptWesley/following{/other_user}","gists_url":"https://api.github.com/users/CptWesley/gists{/gist_id}","starred_url":"https://api.github.com/users/CptWesley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CptWesley/subscriptions","organizations_url":"https://api.github.com/users/CptWesley/orgs","repos_url":"https://api.github.com/users/CptWesley/repos","events_url":"https://api.github.com/users/CptWesley/events{/privacy}","received_events_url":"https://api.github.com/users/CptWesley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CptWesley/GOALkeeper","description":"Static analysis tools for GOAL programming language.","fork":false,"url":"https://api.github.com/repos/CptWesley/GOALkeeper","forks_url":"https://api.github.com/repos/CptWesley/GOALkeeper/forks","keys_url":"https://api.github.com/repos/CptWesley/GOALkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CptWesley/GOALkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CptWesley/GOALkeeper/teams","hooks_url":"https://api.github.com/repos/CptWesley/GOALkeeper/hooks","issue_events_url":"https://api.github.com/repos/CptWesley/GOALkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/CptWesley/GOALkeeper/events","assignees_url":"https://api.github.com/repos/CptWesley/GOALkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/CptWesley/GOALkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/CptWesley/GOALkeeper/tags","blobs_url":"https://api.github.com/repos/CptWesley/GOALkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CptWesley/GOALkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CptWesley/GOALkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/CptWesley/GOALkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CptWesley/GOALkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/CptWesley/GOALkeeper/languages","stargazers_url":"https://api.github.com/repos/CptWesley/GOALkeeper/stargazers","contributors_url":"https://api.github.com/repos/CptWesley/GOALkeeper/contributors","subscribers_url":"https://api.github.com/repos/CptWesley/GOALkeeper/subscribers","subscription_url":"https://api.github.com/repos/CptWesley/GOALkeeper/subscription","commits_url":"https://api.github.com/repos/CptWesley/GOALkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/CptWesley/GOALkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/CptWesley/GOALkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/CptWesley/GOALkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/CptWesley/GOALkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/CptWesley/GOALkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CptWesley/GOALkeeper/merges","archive_url":"https://api.github.com/repos/CptWesley/GOALkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CptWesley/GOALkeeper/downloads","issues_url":"https://api.github.com/repos/CptWesley/GOALkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/CptWesley/GOALkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/CptWesley/GOALkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CptWesley/GOALkeeper/labels{/name}","releases_url":"https://api.github.com/repos/CptWesley/GOALkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/CptWesley/GOALkeeper/deployments","created_at":"2017-11-14T08:26:53Z","updated_at":"2018-01-14T07:16:05Z","pushed_at":"2018-02-15T10:44:08Z","git_url":"git://github.com/CptWesley/GOALkeeper.git","ssh_url":"git@github.com:CptWesley/GOALkeeper.git","clone_url":"https://github.com/CptWesley/GOALkeeper.git","svn_url":"https://github.com/CptWesley/GOALkeeper","homepage":"","size":13274,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":17,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls/55"},"html":{"href":"https://github.com/CptWesley/GOALkeeper/pull/55"},"issue":{"href":"https://api.github.com/repos/CptWesley/GOALkeeper/issues/55"},"comments":{"href":"https://api.github.com/repos/CptWesley/GOALkeeper/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CptWesley/GOALkeeper/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/CptWesley/GOALkeeper/statuses/75f6298ce8b29409b9bb302d5b221b4704a48b42"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"CptWesley"}}