{"action":"created","issue":{"url":"https://api.github.com/repos/linuxmao-org/Frontieres/issues/54","repository_url":"https://api.github.com/repos/linuxmao-org/Frontieres","labels_url":"https://api.github.com/repos/linuxmao-org/Frontieres/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/linuxmao-org/Frontieres/issues/54/comments","events_url":"https://api.github.com/repos/linuxmao-org/Frontieres/issues/54/events","html_url":"https://github.com/linuxmao-org/Frontieres/pull/54","id":381862490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzI3NTQy","number":54,"title":"Olof : ajout fenetre de parametres des clouds (touche \"p\")","user":{"login":"olof29","id":25823124,"node_id":"MDQ6VXNlcjI1ODIzMTI0","avatar_url":"https://avatars3.githubusercontent.com/u/25823124?v=4","gravatar_id":"","url":"https://api.github.com/users/olof29","html_url":"https://github.com/olof29","followers_url":"https://api.github.com/users/olof29/followers","following_url":"https://api.github.com/users/olof29/following{/other_user}","gists_url":"https://api.github.com/users/olof29/gists{/gist_id}","starred_url":"https://api.github.com/users/olof29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olof29/subscriptions","organizations_url":"https://api.github.com/users/olof29/orgs","repos_url":"https://api.github.com/users/olof29/repos","events_url":"https://api.github.com/users/olof29/events{/privacy}","received_events_url":"https://api.github.com/users/olof29/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-17T13:17:52Z","updated_at":"2018-11-18T17:06:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/linuxmao-org/Frontieres/pulls/54","html_url":"https://github.com/linuxmao-org/Frontieres/pull/54","diff_url":"https://github.com/linuxmao-org/Frontieres/pull/54.diff","patch_url":"https://github.com/linuxmao-org/Frontieres/pull/54.patch"},"body":"la mise à jour se fait dans les deux sens (modifier dans la fenetre modifie aussi les parametres dans la scene, et modifier les parametres de la scene modifie ceux de la fenêtre)\r\nune fenetre possible par cloud.\r\nlà ou je ne suis pas sur du coup c'est sur la question de la destruction de la fenetre. devrais je declarer le pointeur vers la fenetre en unique ptr, afin qu'elle soit detruite à la destruction du cloud, ou cela est il deja le cas ? ou faut il detruire celle ci a la fermeture, et devoir la recrer à chaque fois qu'on veut la voir ?"},"comment":{"url":"https://api.github.com/repos/linuxmao-org/Frontieres/issues/comments/439708385","html_url":"https://github.com/linuxmao-org/Frontieres/pull/54#issuecomment-439708385","issue_url":"https://api.github.com/repos/linuxmao-org/Frontieres/issues/54","id":439708385,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTcwODM4NQ==","user":{"login":"jpcima","id":17614485,"node_id":"MDQ6VXNlcjE3NjE0NDg1","avatar_url":"https://avatars0.githubusercontent.com/u/17614485?v=4","gravatar_id":"","url":"https://api.github.com/users/jpcima","html_url":"https://github.com/jpcima","followers_url":"https://api.github.com/users/jpcima/followers","following_url":"https://api.github.com/users/jpcima/following{/other_user}","gists_url":"https://api.github.com/users/jpcima/gists{/gist_id}","starred_url":"https://api.github.com/users/jpcima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpcima/subscriptions","organizations_url":"https://api.github.com/users/jpcima/orgs","repos_url":"https://api.github.com/users/jpcima/repos","events_url":"https://api.github.com/users/jpcima/events{/privacy}","received_events_url":"https://api.github.com/users/jpcima/received_events","type":"User","site_admin":false},"created_at":"2018-11-18T17:06:46Z","updated_at":"2018-11-18T17:06:46Z","author_association":"COLLABORATOR","body":"Ok. C'est pas mal, mais je reverrais un élément dérangeant :\r\nC'est que des éléments d'interface graphique, les boîtes de dialogue, se retrouvent emmêlées avec les entités du modèle.\r\n\r\nCela contrevient à la séparation idéale modèle-vue que j'aimerais bien maintenir.\r\nDans l'idéal, je verrais mieux les boîtes de dialogue en association avec la fenêtre qui leur est parente.\r\nQuitte à passer par une HashMap de CloudID→BoîteDialogue, je trouverais une telle conception préférable.\r\n\r\nIl me semble que la destruction de la boîte de dialogue pourrait avoir lieu à l'instant de l'appui `Key_Delete`, plutôt que cela se produise dans le destructeur de nuage."}}
{"actor":{"display_login":"jpcima"}}