{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/21926","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/21926/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21926/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/21926/events","html_url":"https://github.com/nodejs/node/pull/21926","id":343340390,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDE3OTgz","number":21926,"title":"src: remove calls to deprecated v8 functions (NewFromUtf8)","user":{"login":"ryzokuken","id":13121330,"node_id":"MDQ6VXNlcjEzMTIxMzMw","avatar_url":"https://avatars3.githubusercontent.com/u/13121330?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-21T16:59:02Z","updated_at":"2018-07-29T15:06:31Z","closed_at":"2018-07-29T15:06:31Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/21926","html_url":"https://github.com/nodejs/node/pull/21926","diff_url":"https://github.com/nodejs/node/pull/21926.diff","patch_url":"https://github.com/nodejs/node/pull/21926.patch"},"body":"Remove all calls to deprecated v8 functions (here: String::NewFromUtf8) inside\r\nthe code (src directory only).\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n##### Files\r\n\r\n- [x] src/async_wrap.cc\r\n- [x] src/cares_wrap.cc\r\n- [x] src/env-inl.h\r\n- [x] src/exceptions.cc\r\n- [x] src/heap_utils.cc\r\n- [x] src/module_wrap.cc\r\n- [x] src/node.cc\r\n- [x] src/node.h\r\n- [x] src/node_api.cc\r\n- [x] src/node_config.cc\r\n- [x] src/node_crypto.cc\r\n- [x] src/node_file.cc\r\n- [x] src/node_i18n.cc\r\n- [x] src/node_internals.h\r\n- [x] src/node_os.cc\r\n- [x] src/node_perf.cc\r\n- [x] src/node_process.cc\r\n- [x] src/node_trace_events.cc\r\n- [x] src/node_url.cc\r\n- [x] src/node_util.cc\r\n- [x] src/node_v8.cc\r\n- [x] src/spawn_sync.cc\r\n- [x] src/string_bytes.cc\r\n- [x] src/string_decoder.cc\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/408683955","html_url":"https://github.com/nodejs/node/pull/21926#issuecomment-408683955","issue_url":"https://api.github.com/repos/nodejs/node/issues/21926","id":408683955,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODY4Mzk1NQ==","user":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2018-07-29T15:06:31Z","updated_at":"2018-07-29T15:06:31Z","author_association":"MEMBER","body":"Landed in 51812ff12b9e10549725bcda57167148428e256c...07cb69720bec251a1c450b3770db2136ac009778 \r\n\r\nDid a minor update to the commit message in 07cb69720bec251a1c450b3770db2136ac009778 (the previous behaviour was not encoding-agnostic). Hope that’s okay!"}}
{"actor":{"display_login":"addaleax"}}