{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/619","repository_url":"https://api.github.com/repos/theforeman/puppet-puppet","labels_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/619/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/619/comments","events_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/619/events","html_url":"https://github.com/theforeman/puppet-puppet/pull/619","id":350944976,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NjY0ODEx","number":619,"title":"updated auth.conf for the \"puppet facts upload\" command (puppetserver 5.5)","user":{"login":"slauger","id":8333300,"node_id":"MDQ6VXNlcjgzMzMzMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/8333300?v=4","gravatar_id":"","url":"https://api.github.com/users/slauger","html_url":"https://github.com/slauger","followers_url":"https://api.github.com/users/slauger/followers","following_url":"https://api.github.com/users/slauger/following{/other_user}","gists_url":"https://api.github.com/users/slauger/gists{/gist_id}","starred_url":"https://api.github.com/users/slauger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slauger/subscriptions","organizations_url":"https://api.github.com/users/slauger/orgs","repos_url":"https://api.github.com/users/slauger/repos","events_url":"https://api.github.com/users/slauger/events{/privacy}","received_events_url":"https://api.github.com/users/slauger/received_events","type":"User","site_admin":false},"labels":[{"id":794027044,"node_id":"MDU6TGFiZWw3OTQwMjcwNDQ=","url":"https://api.github.com/repos/theforeman/puppet-puppet/labels/Needs%20re-review","name":"Needs re-review","color":"0052cc","default":false},{"id":794027057,"node_id":"MDU6TGFiZWw3OTQwMjcwNTc=","url":"https://api.github.com/repos/theforeman/puppet-puppet/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-15T19:58:19Z","updated_at":"2018-10-03T13:47:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/619","html_url":"https://github.com/theforeman/puppet-puppet/pull/619","diff_url":"https://github.com/theforeman/puppet-puppet/pull/619.diff","patch_url":"https://github.com/theforeman/puppet-puppet/pull/619.patch"},"body":"Updated auth.conf.erb to add support for the \"puppet facts upload\" command (as introduced in puppetserver v5.5).\r\n\r\nSee also:\r\n- https://github.com/puppetlabs/puppetserver/blob/master/ezbake/config/conf.d/auth.conf (current default auth.conf)\r\n- https://puppet.com/docs/puppet/5.5/man/facts.html (man page for puppet facts)\r\n- https://tickets.puppetlabs.com/browse/PUP-8232 (Jira issue tickets.puppetlabs.com)  "},"comment":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/comments/426643849","html_url":"https://github.com/theforeman/puppet-puppet/pull/619#issuecomment-426643849","issue_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/619","id":426643849,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjY0Mzg0OQ==","user":{"login":"mmoll","id":1434927,"node_id":"MDQ6VXNlcjE0MzQ5Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1434927?v=4","gravatar_id":"","url":"https://api.github.com/users/mmoll","html_url":"https://github.com/mmoll","followers_url":"https://api.github.com/users/mmoll/followers","following_url":"https://api.github.com/users/mmoll/following{/other_user}","gists_url":"https://api.github.com/users/mmoll/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoll/subscriptions","organizations_url":"https://api.github.com/users/mmoll/orgs","repos_url":"https://api.github.com/users/mmoll/repos","events_url":"https://api.github.com/users/mmoll/events{/privacy}","received_events_url":"https://api.github.com/users/mmoll/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T13:47:52Z","updated_at":"2018-10-03T13:47:52Z","author_association":"MEMBER","body":"also, something like this is needed, I *think*:\r\n```diff\r\ndiff --git a/manifests/params.pp b/manifests/params.pp\r\nindex 5c06a22..1a3e951 100644\r\n--- a/manifests/params.pp\r\n+++ b/manifests/params.pp\r\n@@ -449,7 +449,9 @@ class puppet::params {\r\n   $server_use_legacy_auth_conf      = false\r\n \r\n   # For Puppetserver, certain configuration parameters are version specific. We assume a particular version here.\r\n-  if versioncmp($::puppetversion, '5.1.0') >= 0 {\r\n+  if versioncmp($::puppetversion, '5.3.0') >= 0 {\r\n+    $server_puppetserver_version = '5.3.0'\r\n+  } elsif versioncmp($::puppetversion, '5.1.0') >= 0 {\r\n     $server_puppetserver_version = '5.1.0'\r\n   } elsif versioncmp($::puppetversion, '5.0.0') >= 0 {\r\n     $server_puppetserver_version = '5.0.0'\r\n```"}}
{"actor":{"display_login":"mmoll"}}