{"action":"created","issue":{"url":"https://api.github.com/repos/lightstep/lightstep-tracer-ruby/issues/70","repository_url":"https://api.github.com/repos/lightstep/lightstep-tracer-ruby","labels_url":"https://api.github.com/repos/lightstep/lightstep-tracer-ruby/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/lightstep/lightstep-tracer-ruby/issues/70/comments","events_url":"https://api.github.com/repos/lightstep/lightstep-tracer-ruby/issues/70/events","html_url":"https://github.com/lightstep/lightstep-tracer-ruby/issues/70","id":373552169,"node_id":"MDU6SXNzdWUzNzM1NTIxNjk=","number":70,"title":"Span tag values that are not strings cause the span to not be recorded","user":{"login":"ethanjcohen-underarmour","id":43153707,"node_id":"MDQ6VXNlcjQzMTUzNzA3","avatar_url":"https://avatars2.githubusercontent.com/u/43153707?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanjcohen-underarmour","html_url":"https://github.com/ethanjcohen-underarmour","followers_url":"https://api.github.com/users/ethanjcohen-underarmour/followers","following_url":"https://api.github.com/users/ethanjcohen-underarmour/following{/other_user}","gists_url":"https://api.github.com/users/ethanjcohen-underarmour/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanjcohen-underarmour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanjcohen-underarmour/subscriptions","organizations_url":"https://api.github.com/users/ethanjcohen-underarmour/orgs","repos_url":"https://api.github.com/users/ethanjcohen-underarmour/repos","events_url":"https://api.github.com/users/ethanjcohen-underarmour/events{/privacy}","received_events_url":"https://api.github.com/users/ethanjcohen-underarmour/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-24T15:49:16Z","updated_at":"2018-10-24T19:01:11Z","closed_at":null,"author_association":"NONE","body":"I noticed that `set_tag` converts the value to a string:\r\nhttps://github.com/lightstep/lightstep-tracer-ruby/blob/master/lib/lightstep/span.rb#L69\r\n\r\nBut the values passed in an object of tags to `start_span` never get converted to strings.\r\nhttps://github.com/lightstep/lightstep-tracer-ruby/blob/master/lib/lightstep/span.rb#L45\r\n\r\nFor example, this library saves a bool and number to tags, which does not seem to work unless I add `.to_s` to both values:\r\nhttps://github.com/iaintshine/ruby-rails-tracer/blob/master/lib/rails/active_record/tracer.rb#L57\r\n\r\nThe opentracing spec says that bools and numeric types are allowed:\r\nhttps://github.com/opentracing/specification/blob/master/specification.md#set-a-span-tag"},"comment":{"url":"https://api.github.com/repos/lightstep/lightstep-tracer-ruby/issues/comments/432787270","html_url":"https://github.com/lightstep/lightstep-tracer-ruby/issues/70#issuecomment-432787270","issue_url":"https://api.github.com/repos/lightstep/lightstep-tracer-ruby/issues/70","id":432787270,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjc4NzI3MA==","user":{"login":"austinlparker","id":4140740,"node_id":"MDQ6VXNlcjQxNDA3NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/4140740?v=4","gravatar_id":"","url":"https://api.github.com/users/austinlparker","html_url":"https://github.com/austinlparker","followers_url":"https://api.github.com/users/austinlparker/followers","following_url":"https://api.github.com/users/austinlparker/following{/other_user}","gists_url":"https://api.github.com/users/austinlparker/gists{/gist_id}","starred_url":"https://api.github.com/users/austinlparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinlparker/subscriptions","organizations_url":"https://api.github.com/users/austinlparker/orgs","repos_url":"https://api.github.com/users/austinlparker/repos","events_url":"https://api.github.com/users/austinlparker/events{/privacy}","received_events_url":"https://api.github.com/users/austinlparker/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T19:01:11Z","updated_at":"2018-10-24T19:01:11Z","author_association":"CONTRIBUTOR","body":"No, we accept more than strings, so I'm actually surprised that this isn't working. I need to do some more research to understand why the problem is happening, but we should be able to get a fix out in the short term."}}
{"actor":{"display_login":"austinlparker"}}