{"action":"created","comment":{"url":"https://api.github.com/repos/serokell/ariadne/pulls/comments/195768145","pull_request_review_id":129202183,"id":195768145,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTc2ODE0NQ==","diff_hunk":"@@ -494,3 +495,46 @@ findFirstUnique lastIdx paths = fromMaybe (error \"Can't find a unique path!\")\n     . head $ dropWhile (`S.member` pathsSet) [lastIdx..]\n   where\n     pathsSet = V.foldr S.insert S.empty paths\n+\n+-- ^ This function derives a 3-level address using account index, change index\n+--   and address index. The input key is should be the master key (not the key\n+--   that was derived from purpose and coin type)\n+deriveLvl3KeyPair ::","path":"ariadne/src/Ariadne/Wallet/Backend/KeyStorage.hs","position":37,"original_position":37,"commit_id":"0cf3c87360b601b9cd828eb1e1baf6f1308e9462","original_commit_id":"0cf3c87360b601b9cd828eb1e1baf6f1308e9462","user":{"login":"gromakovsky","id":2556409,"node_id":"MDQ6VXNlcjI1NTY0MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2556409?v=4","gravatar_id":"","url":"https://api.github.com/users/gromakovsky","html_url":"https://github.com/gromakovsky","followers_url":"https://api.github.com/users/gromakovsky/followers","following_url":"https://api.github.com/users/gromakovsky/following{/other_user}","gists_url":"https://api.github.com/users/gromakovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/gromakovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gromakovsky/subscriptions","organizations_url":"https://api.github.com/users/gromakovsky/orgs","repos_url":"https://api.github.com/users/gromakovsky/repos","events_url":"https://api.github.com/users/gromakovsky/events{/privacy}","received_events_url":"https://api.github.com/users/gromakovsky/received_events","type":"User","site_admin":false},"body":"I'd rename it to something like `deriveBip44KeyPair`, which is more descriptive than `deriveLvl3KeyPair`, in my opinion.","created_at":"2018-06-15T14:58:43Z","updated_at":"2018-06-15T15:02:43Z","html_url":"https://github.com/serokell/ariadne/pull/177#discussion_r195768145","pull_request_url":"https://api.github.com/repos/serokell/ariadne/pulls/177","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/serokell/ariadne/pulls/comments/195768145"},"html":{"href":"https://github.com/serokell/ariadne/pull/177#discussion_r195768145"},"pull_request":{"href":"https://api.github.com/repos/serokell/ariadne/pulls/177"}}},"pull_request":{"url":"https://api.github.com/repos/serokell/ariadne/pulls/177","id":193038479,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMDM4NDc5","html_url":"https://github.com/serokell/ariadne/pull/177","diff_url":"https://github.com/serokell/ariadne/pull/177.diff","patch_url":"https://github.com/serokell/ariadne/pull/177.patch","issue_url":"https://api.github.com/repos/serokell/ariadne/issues/177","number":177,"state":"open","locked":false,"title":"[AD-126] Add BIP-44 key derivation","user":{"login":"hithroc","id":10367475,"node_id":"MDQ6VXNlcjEwMzY3NDc1","avatar_url":"https://avatars0.githubusercontent.com/u/10367475?v=4","gravatar_id":"","url":"https://api.github.com/users/hithroc","html_url":"https://github.com/hithroc","followers_url":"https://api.github.com/users/hithroc/followers","following_url":"https://api.github.com/users/hithroc/following{/other_user}","gists_url":"https://api.github.com/users/hithroc/gists{/gist_id}","starred_url":"https://api.github.com/users/hithroc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hithroc/subscriptions","organizations_url":"https://api.github.com/users/hithroc/orgs","repos_url":"https://api.github.com/users/hithroc/repos","events_url":"https://api.github.com/users/hithroc/events{/privacy}","received_events_url":"https://api.github.com/users/hithroc/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-06T14:45:00Z","updated_at":"2018-06-15T15:02:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b90029b7b1dbc9a36826651ccccfb99250eb3888","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":891496625,"node_id":"MDU6TGFiZWw4OTE0OTY2MjU=","url":"https://api.github.com/repos/serokell/ariadne/labels/Restart%20CI","name":"Restart CI","color":"cce8ff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/serokell/ariadne/pulls/177/commits","review_comments_url":"https://api.github.com/repos/serokell/ariadne/pulls/177/comments","review_comment_url":"https://api.github.com/repos/serokell/ariadne/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serokell/ariadne/issues/177/comments","statuses_url":"https://api.github.com/repos/serokell/ariadne/statuses/0cf3c87360b601b9cd828eb1e1baf6f1308e9462","head":{"label":"serokell:hithroc/ad-126","ref":"hithroc/ad-126","sha":"0cf3c87360b601b9cd828eb1e1baf6f1308e9462","user":{"login":"serokell","id":13840520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQwNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"repo":{"id":122662740,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NjI3NDA=","name":"ariadne","full_name":"serokell/ariadne","owner":{"login":"serokell","id":13840520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQwNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serokell/ariadne","description":"A wallet","fork":false,"url":"https://api.github.com/repos/serokell/ariadne","forks_url":"https://api.github.com/repos/serokell/ariadne/forks","keys_url":"https://api.github.com/repos/serokell/ariadne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serokell/ariadne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serokell/ariadne/teams","hooks_url":"https://api.github.com/repos/serokell/ariadne/hooks","issue_events_url":"https://api.github.com/repos/serokell/ariadne/issues/events{/number}","events_url":"https://api.github.com/repos/serokell/ariadne/events","assignees_url":"https://api.github.com/repos/serokell/ariadne/assignees{/user}","branches_url":"https://api.github.com/repos/serokell/ariadne/branches{/branch}","tags_url":"https://api.github.com/repos/serokell/ariadne/tags","blobs_url":"https://api.github.com/repos/serokell/ariadne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serokell/ariadne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serokell/ariadne/git/refs{/sha}","trees_url":"https://api.github.com/repos/serokell/ariadne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serokell/ariadne/statuses/{sha}","languages_url":"https://api.github.com/repos/serokell/ariadne/languages","stargazers_url":"https://api.github.com/repos/serokell/ariadne/stargazers","contributors_url":"https://api.github.com/repos/serokell/ariadne/contributors","subscribers_url":"https://api.github.com/repos/serokell/ariadne/subscribers","subscription_url":"https://api.github.com/repos/serokell/ariadne/subscription","commits_url":"https://api.github.com/repos/serokell/ariadne/commits{/sha}","git_commits_url":"https://api.github.com/repos/serokell/ariadne/git/commits{/sha}","comments_url":"https://api.github.com/repos/serokell/ariadne/comments{/number}","issue_comment_url":"https://api.github.com/repos/serokell/ariadne/issues/comments{/number}","contents_url":"https://api.github.com/repos/serokell/ariadne/contents/{+path}","compare_url":"https://api.github.com/repos/serokell/ariadne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serokell/ariadne/merges","archive_url":"https://api.github.com/repos/serokell/ariadne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serokell/ariadne/downloads","issues_url":"https://api.github.com/repos/serokell/ariadne/issues{/number}","pulls_url":"https://api.github.com/repos/serokell/ariadne/pulls{/number}","milestones_url":"https://api.github.com/repos/serokell/ariadne/milestones{/number}","notifications_url":"https://api.github.com/repos/serokell/ariadne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serokell/ariadne/labels{/name}","releases_url":"https://api.github.com/repos/serokell/ariadne/releases{/id}","deployments_url":"https://api.github.com/repos/serokell/ariadne/deployments","created_at":"2018-02-23T19:17:07Z","updated_at":"2018-06-15T14:43:03Z","pushed_at":"2018-06-15T14:43:01Z","git_url":"git://github.com/serokell/ariadne.git","ssh_url":"git@github.com:serokell/ariadne.git","clone_url":"https://github.com/serokell/ariadne.git","svn_url":"https://github.com/serokell/ariadne","homepage":"https://serokell.io/ariadne","size":1617,"stargazers_count":20,"watchers_count":20,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":16,"watchers":20,"default_branch":"master"}},"base":{"label":"serokell:master","ref":"master","sha":"64583e8760ae045d76c60739d6c841108b4e0e62","user":{"login":"serokell","id":13840520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQwNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"repo":{"id":122662740,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NjI3NDA=","name":"ariadne","full_name":"serokell/ariadne","owner":{"login":"serokell","id":13840520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQwNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serokell/ariadne","description":"A wallet","fork":false,"url":"https://api.github.com/repos/serokell/ariadne","forks_url":"https://api.github.com/repos/serokell/ariadne/forks","keys_url":"https://api.github.com/repos/serokell/ariadne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serokell/ariadne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serokell/ariadne/teams","hooks_url":"https://api.github.com/repos/serokell/ariadne/hooks","issue_events_url":"https://api.github.com/repos/serokell/ariadne/issues/events{/number}","events_url":"https://api.github.com/repos/serokell/ariadne/events","assignees_url":"https://api.github.com/repos/serokell/ariadne/assignees{/user}","branches_url":"https://api.github.com/repos/serokell/ariadne/branches{/branch}","tags_url":"https://api.github.com/repos/serokell/ariadne/tags","blobs_url":"https://api.github.com/repos/serokell/ariadne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serokell/ariadne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serokell/ariadne/git/refs{/sha}","trees_url":"https://api.github.com/repos/serokell/ariadne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serokell/ariadne/statuses/{sha}","languages_url":"https://api.github.com/repos/serokell/ariadne/languages","stargazers_url":"https://api.github.com/repos/serokell/ariadne/stargazers","contributors_url":"https://api.github.com/repos/serokell/ariadne/contributors","subscribers_url":"https://api.github.com/repos/serokell/ariadne/subscribers","subscription_url":"https://api.github.com/repos/serokell/ariadne/subscription","commits_url":"https://api.github.com/repos/serokell/ariadne/commits{/sha}","git_commits_url":"https://api.github.com/repos/serokell/ariadne/git/commits{/sha}","comments_url":"https://api.github.com/repos/serokell/ariadne/comments{/number}","issue_comment_url":"https://api.github.com/repos/serokell/ariadne/issues/comments{/number}","contents_url":"https://api.github.com/repos/serokell/ariadne/contents/{+path}","compare_url":"https://api.github.com/repos/serokell/ariadne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serokell/ariadne/merges","archive_url":"https://api.github.com/repos/serokell/ariadne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serokell/ariadne/downloads","issues_url":"https://api.github.com/repos/serokell/ariadne/issues{/number}","pulls_url":"https://api.github.com/repos/serokell/ariadne/pulls{/number}","milestones_url":"https://api.github.com/repos/serokell/ariadne/milestones{/number}","notifications_url":"https://api.github.com/repos/serokell/ariadne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serokell/ariadne/labels{/name}","releases_url":"https://api.github.com/repos/serokell/ariadne/releases{/id}","deployments_url":"https://api.github.com/repos/serokell/ariadne/deployments","created_at":"2018-02-23T19:17:07Z","updated_at":"2018-06-15T14:43:03Z","pushed_at":"2018-06-15T14:43:01Z","git_url":"git://github.com/serokell/ariadne.git","ssh_url":"git@github.com:serokell/ariadne.git","clone_url":"https://github.com/serokell/ariadne.git","svn_url":"https://github.com/serokell/ariadne","homepage":"https://serokell.io/ariadne","size":1617,"stargazers_count":20,"watchers_count":20,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":16,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serokell/ariadne/pulls/177"},"html":{"href":"https://github.com/serokell/ariadne/pull/177"},"issue":{"href":"https://api.github.com/repos/serokell/ariadne/issues/177"},"comments":{"href":"https://api.github.com/repos/serokell/ariadne/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/serokell/ariadne/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/serokell/ariadne/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serokell/ariadne/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/serokell/ariadne/statuses/0cf3c87360b601b9cd828eb1e1baf6f1308e9462"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gromakovsky"}}