{"action":"created","comment":{"url":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments/166766821","pull_request_review_id":94881173,"id":166766821,"diff_hunk":"@@ -171,6 +171,41 @@ public class MTABuildTest extends BasePipelineTest {\n     }\n \n \n+    @Test\n+    void mtaJarLocationFromCustomStepConfigurationTest(){\n+\n+        setupCommonPipelineEnvironmentScript.call(script: [commonPipelineEnvironment: cpe])\n+        mtaBuildScript.call(script: [commonPipelineEnvironment: cpe],\n+                      buildTarget: 'NEO')\n+\n+        assert jscr.shell[1].contains('-jar /custom/mta/mta.jar --mtar')\n+        assert jlr.log.contains(\"[mtaBuild] MTA JAR '/custom/mta/mta.jar' retrieved from configuration.\")\n+    }\n+\n+\n+    @Test\n+    void mtaJarLocationFromDefaultStepConfigurationTest() {\n+\n+        helper.registerAllowedMethod(\"readYaml\", [Map], { Map parameters ->\n+            if(parameters.text) {\n+                return new Yaml().load(parameters.text)\n+            } else if(parameters.file) {\n+                if (parameters.file == '.pipeline/config.yml') return [:]\n+                return new Yaml().load(new File(parameters.file).text)\n+            } else {\n+                throw new IllegalArgumentException(\"Key 'text' is missing in parameters $parameters.\")\n+            }\n+        })\n+\n+        setupCommonPipelineEnvironmentScript.call(script: [commonPipelineEnvironment: cpe])","path":"test/groovy/MTABuildTest.groovy","position":104,"original_position":104,"commit_id":"e4e36fecd0737a91b0d9f761776dc2bc1d9ceab8","original_commit_id":"e4e36fecd0737a91b0d9f761776dc2bc1d9ceab8","user":{"login":"OliverNocon","id":33484802,"avatar_url":"https://avatars2.githubusercontent.com/u/33484802?v=4","gravatar_id":"","url":"https://api.github.com/users/OliverNocon","html_url":"https://github.com/OliverNocon","followers_url":"https://api.github.com/users/OliverNocon/followers","following_url":"https://api.github.com/users/OliverNocon/following{/other_user}","gists_url":"https://api.github.com/users/OliverNocon/gists{/gist_id}","starred_url":"https://api.github.com/users/OliverNocon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OliverNocon/subscriptions","organizations_url":"https://api.github.com/users/OliverNocon/orgs","repos_url":"https://api.github.com/users/OliverNocon/repos","events_url":"https://api.github.com/users/OliverNocon/events{/privacy}","received_events_url":"https://api.github.com/users/OliverNocon/received_events","type":"User","site_admin":false},"body":"you might be able to get completely rid of `setupCommonPipelineEnvironment`-> see below","created_at":"2018-02-07T21:49:15Z","updated_at":"2018-02-07T21:49:23Z","html_url":"https://github.com/SAP/jenkins-library/pull/69#discussion_r166766821","pull_request_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/69","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments/166766821"},"html":{"href":"https://github.com/SAP/jenkins-library/pull/69#discussion_r166766821"},"pull_request":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/SAP/jenkins-library/pulls/69","id":166867210,"html_url":"https://github.com/SAP/jenkins-library/pull/69","diff_url":"https://github.com/SAP/jenkins-library/pull/69.diff","patch_url":"https://github.com/SAP/jenkins-library/pull/69.patch","issue_url":"https://api.github.com/repos/SAP/jenkins-library/issues/69","number":69,"state":"open","locked":false,"title":"mtaBuild with new config framework","user":{"login":"alejandraferreirovidal","id":25053039,"avatar_url":"https://avatars2.githubusercontent.com/u/25053039?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandraferreirovidal","html_url":"https://github.com/alejandraferreirovidal","followers_url":"https://api.github.com/users/alejandraferreirovidal/followers","following_url":"https://api.github.com/users/alejandraferreirovidal/following{/other_user}","gists_url":"https://api.github.com/users/alejandraferreirovidal/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandraferreirovidal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandraferreirovidal/subscriptions","organizations_url":"https://api.github.com/users/alejandraferreirovidal/orgs","repos_url":"https://api.github.com/users/alejandraferreirovidal/repos","events_url":"https://api.github.com/users/alejandraferreirovidal/events{/privacy}","received_events_url":"https://api.github.com/users/alejandraferreirovidal/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-02T18:04:28Z","updated_at":"2018-02-07T21:49:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"159e05323a1e747a89ea92a1768a506e942e7976","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kurzy","id":4758527,"avatar_url":"https://avatars2.githubusercontent.com/u/4758527?v=4","gravatar_id":"","url":"https://api.github.com/users/kurzy","html_url":"https://github.com/kurzy","followers_url":"https://api.github.com/users/kurzy/followers","following_url":"https://api.github.com/users/kurzy/following{/other_user}","gists_url":"https://api.github.com/users/kurzy/gists{/gist_id}","starred_url":"https://api.github.com/users/kurzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurzy/subscriptions","organizations_url":"https://api.github.com/users/kurzy/orgs","repos_url":"https://api.github.com/users/kurzy/repos","events_url":"https://api.github.com/users/kurzy/events{/privacy}","received_events_url":"https://api.github.com/users/kurzy/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/69/commits","review_comments_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/69/comments","review_comment_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SAP/jenkins-library/issues/69/comments","statuses_url":"https://api.github.com/repos/SAP/jenkins-library/statuses/e4e36fecd0737a91b0d9f761776dc2bc1d9ceab8","head":{"label":"alejandraferreirovidal:mtaBuildNewConfig","ref":"mtaBuildNewConfig","sha":"e4e36fecd0737a91b0d9f761776dc2bc1d9ceab8","user":{"login":"alejandraferreirovidal","id":25053039,"avatar_url":"https://avatars2.githubusercontent.com/u/25053039?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandraferreirovidal","html_url":"https://github.com/alejandraferreirovidal","followers_url":"https://api.github.com/users/alejandraferreirovidal/followers","following_url":"https://api.github.com/users/alejandraferreirovidal/following{/other_user}","gists_url":"https://api.github.com/users/alejandraferreirovidal/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandraferreirovidal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandraferreirovidal/subscriptions","organizations_url":"https://api.github.com/users/alejandraferreirovidal/orgs","repos_url":"https://api.github.com/users/alejandraferreirovidal/repos","events_url":"https://api.github.com/users/alejandraferreirovidal/events{/privacy}","received_events_url":"https://api.github.com/users/alejandraferreirovidal/received_events","type":"User","site_admin":false},"repo":{"id":110864541,"name":"jenkins-library","full_name":"alejandraferreirovidal/jenkins-library","owner":{"login":"alejandraferreirovidal","id":25053039,"avatar_url":"https://avatars2.githubusercontent.com/u/25053039?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandraferreirovidal","html_url":"https://github.com/alejandraferreirovidal","followers_url":"https://api.github.com/users/alejandraferreirovidal/followers","following_url":"https://api.github.com/users/alejandraferreirovidal/following{/other_user}","gists_url":"https://api.github.com/users/alejandraferreirovidal/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandraferreirovidal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandraferreirovidal/subscriptions","organizations_url":"https://api.github.com/users/alejandraferreirovidal/orgs","repos_url":"https://api.github.com/users/alejandraferreirovidal/repos","events_url":"https://api.github.com/users/alejandraferreirovidal/events{/privacy}","received_events_url":"https://api.github.com/users/alejandraferreirovidal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alejandraferreirovidal/jenkins-library","description":"Jenkins shared library for Continuous Delivery pipelines.","fork":true,"url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library","forks_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/forks","keys_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/teams","hooks_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/hooks","issue_events_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/issues/events{/number}","events_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/events","assignees_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/assignees{/user}","branches_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/branches{/branch}","tags_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/tags","blobs_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/statuses/{sha}","languages_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/languages","stargazers_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/stargazers","contributors_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/contributors","subscribers_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/subscribers","subscription_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/subscription","commits_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/contents/{+path}","compare_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/merges","archive_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/downloads","issues_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/issues{/number}","pulls_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/pulls{/number}","milestones_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/milestones{/number}","notifications_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/labels{/name}","releases_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/releases{/id}","deployments_url":"https://api.github.com/repos/alejandraferreirovidal/jenkins-library/deployments","created_at":"2017-11-15T17:25:55Z","updated_at":"2017-11-15T17:25:57Z","pushed_at":"2018-02-07T13:24:56Z","git_url":"git://github.com/alejandraferreirovidal/jenkins-library.git","ssh_url":"git@github.com:alejandraferreirovidal/jenkins-library.git","clone_url":"https://github.com/alejandraferreirovidal/jenkins-library.git","svn_url":"https://github.com/alejandraferreirovidal/jenkins-library","homepage":null,"size":672,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SAP:master","ref":"master","sha":"fbd03a88dafa8daa78bb482d47c3ef7bbb01b843","user":{"login":"SAP","id":2531208,"avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":107318996,"name":"jenkins-library","full_name":"SAP/jenkins-library","owner":{"login":"SAP","id":2531208,"avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SAP/jenkins-library","description":"Jenkins shared library for Continuous Delivery pipelines.","fork":false,"url":"https://api.github.com/repos/SAP/jenkins-library","forks_url":"https://api.github.com/repos/SAP/jenkins-library/forks","keys_url":"https://api.github.com/repos/SAP/jenkins-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/jenkins-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/jenkins-library/teams","hooks_url":"https://api.github.com/repos/SAP/jenkins-library/hooks","issue_events_url":"https://api.github.com/repos/SAP/jenkins-library/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/jenkins-library/events","assignees_url":"https://api.github.com/repos/SAP/jenkins-library/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/jenkins-library/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/jenkins-library/tags","blobs_url":"https://api.github.com/repos/SAP/jenkins-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/jenkins-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/jenkins-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/jenkins-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/jenkins-library/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/jenkins-library/languages","stargazers_url":"https://api.github.com/repos/SAP/jenkins-library/stargazers","contributors_url":"https://api.github.com/repos/SAP/jenkins-library/contributors","subscribers_url":"https://api.github.com/repos/SAP/jenkins-library/subscribers","subscription_url":"https://api.github.com/repos/SAP/jenkins-library/subscription","commits_url":"https://api.github.com/repos/SAP/jenkins-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/jenkins-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/jenkins-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/jenkins-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/jenkins-library/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/jenkins-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/jenkins-library/merges","archive_url":"https://api.github.com/repos/SAP/jenkins-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/jenkins-library/downloads","issues_url":"https://api.github.com/repos/SAP/jenkins-library/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/jenkins-library/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/jenkins-library/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/jenkins-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/jenkins-library/labels{/name}","releases_url":"https://api.github.com/repos/SAP/jenkins-library/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/jenkins-library/deployments","created_at":"2017-10-17T20:14:48Z","updated_at":"2018-02-07T18:34:05Z","pushed_at":"2018-02-07T13:24:56Z","git_url":"git://github.com/SAP/jenkins-library.git","ssh_url":"git@github.com:SAP/jenkins-library.git","clone_url":"https://github.com/SAP/jenkins-library.git","svn_url":"https://github.com/SAP/jenkins-library","homepage":null,"size":838,"stargazers_count":31,"watchers_count":31,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":18,"open_issues":18,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/69"},"html":{"href":"https://github.com/SAP/jenkins-library/pull/69"},"issue":{"href":"https://api.github.com/repos/SAP/jenkins-library/issues/69"},"comments":{"href":"https://api.github.com/repos/SAP/jenkins-library/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/SAP/jenkins-library/statuses/e4e36fecd0737a91b0d9f761776dc2bc1d9ceab8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"OliverNocon"}}