{"action":"created","comment":{"url":"https://api.github.com/repos/neos/neos-ui/pulls/comments/215545702","pull_request_review_id":152831467,"id":215545702,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTU0NTcwMg==","diff_hunk":"@@ -48,10 +48,8 @@ export default class InlineUI extends PureComponent {\n         const canBeDeleted = $get('policy.canRemove', this.props.focusedNode) || false;\n         const canBeEdited = $get('policy.canEdit', this.props.focusedNode) || false;\n         const visibilityCanBeToggled = !$contains('_hidden', 'policy.disallowedProperties', this.props.focusedNode);\n-        // Check if focusedNode is in Guest frame to prevent errors (e.g. if still in store)\n-        const focusedNodeInGuestFrame = findNodeInGuestFrame(focusedNodeContextPath) ? focused : {};\n \n-        return (\n+        return (findNodeInGuestFrame(focusedNodeContextPath) &&","path":"packages/neos-ui-guest-frame/src/InlineUI/index.js","position":null,"original_position":8,"commit_id":"f6555543602a2f03469b98d7d1d8170faba2f15f","original_commit_id":"b869b208d74d4e75e876f6ebce408d5631b2b480","user":{"login":"suffle","id":10942229,"node_id":"MDQ6VXNlcjEwOTQyMjI5","avatar_url":"https://avatars3.githubusercontent.com/u/10942229?v=4","gravatar_id":"","url":"https://api.github.com/users/suffle","html_url":"https://github.com/suffle","followers_url":"https://api.github.com/users/suffle/followers","following_url":"https://api.github.com/users/suffle/following{/other_user}","gists_url":"https://api.github.com/users/suffle/gists{/gist_id}","starred_url":"https://api.github.com/users/suffle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suffle/subscriptions","organizations_url":"https://api.github.com/users/suffle/orgs","repos_url":"https://api.github.com/users/suffle/repos","events_url":"https://api.github.com/users/suffle/events{/privacy}","received_events_url":"https://api.github.com/users/suffle/received_events","type":"User","site_admin":false},"body":"Removed that as well. I tried to figure out what the inlineUI-Component is for in difference to the Toolbar. I thought i figured it out seeing the Toolbar as a presentational component (only containing UI state) and the InlineUI-Component as a container with connection to the redux store...But if I'm right with that, shouldn't the decision, if the Toolbar is rendered, be made in the container-Component getting the relevant nodeElement there as well? Or did I find a pattern, that wasn't really intended?","created_at":"2018-09-06T08:54:25Z","updated_at":"2018-09-06T08:54:25Z","html_url":"https://github.com/neos/neos-ui/pull/2115#discussion_r215545702","pull_request_url":"https://api.github.com/repos/neos/neos-ui/pulls/2115","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/neos/neos-ui/pulls/comments/215545702"},"html":{"href":"https://github.com/neos/neos-ui/pull/2115#discussion_r215545702"},"pull_request":{"href":"https://api.github.com/repos/neos/neos-ui/pulls/2115"}},"in_reply_to_id":215170306},"pull_request":{"url":"https://api.github.com/repos/neos/neos-ui/pulls/2115","id":212779220,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzc5MjIw","html_url":"https://github.com/neos/neos-ui/pull/2115","diff_url":"https://github.com/neos/neos-ui/pull/2115.diff","patch_url":"https://github.com/neos/neos-ui/pull/2115.patch","issue_url":"https://api.github.com/repos/neos/neos-ui/issues/2115","number":2115,"state":"open","locked":false,"title":"BUGFIX: Prevent NodeToolbar from crashing if focused node not in DOM","user":{"login":"suffle","id":10942229,"node_id":"MDQ6VXNlcjEwOTQyMjI5","avatar_url":"https://avatars3.githubusercontent.com/u/10942229?v=4","gravatar_id":"","url":"https://api.github.com/users/suffle","html_url":"https://github.com/suffle","followers_url":"https://api.github.com/users/suffle/followers","following_url":"https://api.github.com/users/suffle/following{/other_user}","gists_url":"https://api.github.com/users/suffle/gists{/gist_id}","starred_url":"https://api.github.com/users/suffle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suffle/subscriptions","organizations_url":"https://api.github.com/users/suffle/orgs","repos_url":"https://api.github.com/users/suffle/repos","events_url":"https://api.github.com/users/suffle/events{/privacy}","received_events_url":"https://api.github.com/users/suffle/received_events","type":"User","site_admin":false},"body":"If the document node was changed and the old focused element was still in the store (it is a racing condition between set_src and set_context_path actions), the NodeToolbar crashed because it could not find the old elements dimensions.\r\n\r\nI added conditions to the InlineUI to check if the focused element is in the GuestframeWindow and also to the NodeToolbar to check if the nodeElement is set. I also updated the forceUpdate- and setState-calls to be cancelled if the component was unmounted during the debounce-delay\r\n\r\n","created_at":"2018-09-03T15:26:29Z","updated_at":"2018-09-06T08:54:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4b6174c22b7b794aa1d112ca677bb56d1ed0e84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/neos/neos-ui/pulls/2115/commits","review_comments_url":"https://api.github.com/repos/neos/neos-ui/pulls/2115/comments","review_comment_url":"https://api.github.com/repos/neos/neos-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neos/neos-ui/issues/2115/comments","statuses_url":"https://api.github.com/repos/neos/neos-ui/statuses/f6555543602a2f03469b98d7d1d8170faba2f15f","head":{"label":"suffle:bugfix-nodetoolbar-crash-if-focused-node-not-in-dom","ref":"bugfix-nodetoolbar-crash-if-focused-node-not-in-dom","sha":"f6555543602a2f03469b98d7d1d8170faba2f15f","user":{"login":"suffle","id":10942229,"node_id":"MDQ6VXNlcjEwOTQyMjI5","avatar_url":"https://avatars3.githubusercontent.com/u/10942229?v=4","gravatar_id":"","url":"https://api.github.com/users/suffle","html_url":"https://github.com/suffle","followers_url":"https://api.github.com/users/suffle/followers","following_url":"https://api.github.com/users/suffle/following{/other_user}","gists_url":"https://api.github.com/users/suffle/gists{/gist_id}","starred_url":"https://api.github.com/users/suffle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suffle/subscriptions","organizations_url":"https://api.github.com/users/suffle/orgs","repos_url":"https://api.github.com/users/suffle/repos","events_url":"https://api.github.com/users/suffle/events{/privacy}","received_events_url":"https://api.github.com/users/suffle/received_events","type":"User","site_admin":false},"repo":{"id":123457479,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM0NTc0Nzk=","name":"neos-ui","full_name":"suffle/neos-ui","owner":{"login":"suffle","id":10942229,"node_id":"MDQ6VXNlcjEwOTQyMjI5","avatar_url":"https://avatars3.githubusercontent.com/u/10942229?v=4","gravatar_id":"","url":"https://api.github.com/users/suffle","html_url":"https://github.com/suffle","followers_url":"https://api.github.com/users/suffle/followers","following_url":"https://api.github.com/users/suffle/following{/other_user}","gists_url":"https://api.github.com/users/suffle/gists{/gist_id}","starred_url":"https://api.github.com/users/suffle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suffle/subscriptions","organizations_url":"https://api.github.com/users/suffle/orgs","repos_url":"https://api.github.com/users/suffle/repos","events_url":"https://api.github.com/users/suffle/events{/privacy}","received_events_url":"https://api.github.com/users/suffle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/suffle/neos-ui","description":"Neos CMS UI written in ReactJS with Immutable data structures.","fork":true,"url":"https://api.github.com/repos/suffle/neos-ui","forks_url":"https://api.github.com/repos/suffle/neos-ui/forks","keys_url":"https://api.github.com/repos/suffle/neos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suffle/neos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suffle/neos-ui/teams","hooks_url":"https://api.github.com/repos/suffle/neos-ui/hooks","issue_events_url":"https://api.github.com/repos/suffle/neos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/suffle/neos-ui/events","assignees_url":"https://api.github.com/repos/suffle/neos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/suffle/neos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/suffle/neos-ui/tags","blobs_url":"https://api.github.com/repos/suffle/neos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suffle/neos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suffle/neos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/suffle/neos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suffle/neos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/suffle/neos-ui/languages","stargazers_url":"https://api.github.com/repos/suffle/neos-ui/stargazers","contributors_url":"https://api.github.com/repos/suffle/neos-ui/contributors","subscribers_url":"https://api.github.com/repos/suffle/neos-ui/subscribers","subscription_url":"https://api.github.com/repos/suffle/neos-ui/subscription","commits_url":"https://api.github.com/repos/suffle/neos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/suffle/neos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/suffle/neos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/suffle/neos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/suffle/neos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/suffle/neos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suffle/neos-ui/merges","archive_url":"https://api.github.com/repos/suffle/neos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suffle/neos-ui/downloads","issues_url":"https://api.github.com/repos/suffle/neos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/suffle/neos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/suffle/neos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/suffle/neos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suffle/neos-ui/labels{/name}","releases_url":"https://api.github.com/repos/suffle/neos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/suffle/neos-ui/deployments","created_at":"2018-03-01T15:57:12Z","updated_at":"2018-09-03T15:14:30Z","pushed_at":"2018-09-06T08:21:24Z","git_url":"git://github.com/suffle/neos-ui.git","ssh_url":"git@github.com:suffle/neos-ui.git","clone_url":"https://github.com/suffle/neos-ui.git","svn_url":"https://github.com/suffle/neos-ui","homepage":"","size":21551,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neos:master","ref":"master","sha":"8b875362f3b3918a016e24e2512e662d0fde8003","user":{"login":"neos","id":11575267,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTc1MjY3","avatar_url":"https://avatars2.githubusercontent.com/u/11575267?v=4","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"repo":{"id":47460181,"node_id":"MDEwOlJlcG9zaXRvcnk0NzQ2MDE4MQ==","name":"neos-ui","full_name":"neos/neos-ui","owner":{"login":"neos","id":11575267,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTc1MjY3","avatar_url":"https://avatars2.githubusercontent.com/u/11575267?v=4","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neos/neos-ui","description":"Neos CMS UI written in ReactJS with Immutable data structures.","fork":false,"url":"https://api.github.com/repos/neos/neos-ui","forks_url":"https://api.github.com/repos/neos/neos-ui/forks","keys_url":"https://api.github.com/repos/neos/neos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neos/neos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neos/neos-ui/teams","hooks_url":"https://api.github.com/repos/neos/neos-ui/hooks","issue_events_url":"https://api.github.com/repos/neos/neos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/neos/neos-ui/events","assignees_url":"https://api.github.com/repos/neos/neos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/neos/neos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/neos/neos-ui/tags","blobs_url":"https://api.github.com/repos/neos/neos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neos/neos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neos/neos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/neos/neos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neos/neos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/neos/neos-ui/languages","stargazers_url":"https://api.github.com/repos/neos/neos-ui/stargazers","contributors_url":"https://api.github.com/repos/neos/neos-ui/contributors","subscribers_url":"https://api.github.com/repos/neos/neos-ui/subscribers","subscription_url":"https://api.github.com/repos/neos/neos-ui/subscription","commits_url":"https://api.github.com/repos/neos/neos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/neos/neos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/neos/neos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/neos/neos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/neos/neos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/neos/neos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neos/neos-ui/merges","archive_url":"https://api.github.com/repos/neos/neos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neos/neos-ui/downloads","issues_url":"https://api.github.com/repos/neos/neos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/neos/neos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/neos/neos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/neos/neos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neos/neos-ui/labels{/name}","releases_url":"https://api.github.com/repos/neos/neos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/neos/neos-ui/deployments","created_at":"2015-12-05T15:04:10Z","updated_at":"2018-09-05T11:14:35Z","pushed_at":"2018-09-06T08:21:25Z","git_url":"git://github.com/neos/neos-ui.git","ssh_url":"git@github.com:neos/neos-ui.git","clone_url":"https://github.com/neos/neos-ui.git","svn_url":"https://github.com/neos/neos-ui","homepage":"","size":21642,"stargazers_count":188,"watchers_count":188,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":80,"open_issues":118,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neos/neos-ui/pulls/2115"},"html":{"href":"https://github.com/neos/neos-ui/pull/2115"},"issue":{"href":"https://api.github.com/repos/neos/neos-ui/issues/2115"},"comments":{"href":"https://api.github.com/repos/neos/neos-ui/issues/2115/comments"},"review_comments":{"href":"https://api.github.com/repos/neos/neos-ui/pulls/2115/comments"},"review_comment":{"href":"https://api.github.com/repos/neos/neos-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neos/neos-ui/pulls/2115/commits"},"statuses":{"href":"https://api.github.com/repos/neos/neos-ui/statuses/f6555543602a2f03469b98d7d1d8170faba2f15f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"suffle"}}