{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/coreos-assembler/pulls/comments/229505642","pull_request_review_id":170023156,"id":229505642,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTUwNTY0Mg==","diff_hunk":"@@ -0,0 +1,45 @@\n+This document describes some of the current high level design\n+of the project.  It assumes some familiarity with the primary `README.md`.\n+\n+Builds\n+----\n+\n+Conceptually, each run of `coreos-assembler build` may generate a new \"build\".\n+\n+By default, a single build will generate both an OSTree commit and a `-qemu.qcow2`.\n+The OSTree commit data is generated via rpm-ostree, using `src/config/manifest.yaml`.\n+The QEMU image uses the OSTree commit and the `src/config/image.ks` data, which\n+defines the partition layout.\n+\n+The new OSTree commit is written into `repo`; if you have configured a ref in\n+the manifest, it will be updated.\n+\n+The core coreos-assembler concept of a \"build\" though is represented primarily by a\n+new subdirectory in `builds/$version`, and inside that directory there's a\n+`meta.json` that contains a lot of relevant metadata, including the OSTree commit.\n+\n+By default, builds are pruned, although one can use `build --no-prune` to\n+prevent this.\n+\n+Change detection\n+---\n+\n+All of the interesting content of a build goes into the ostree commit.  Images","path":"README-design.md","position":27,"original_position":27,"commit_id":"1d63244d3353bdb1ed8b00708dba18d3565bb92d","original_commit_id":"1d63244d3353bdb1ed8b00708dba18d3565bb92d","user":{"login":"ajeddeloh","id":2753421,"node_id":"MDQ6VXNlcjI3NTM0MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2753421?v=4","gravatar_id":"","url":"https://api.github.com/users/ajeddeloh","html_url":"https://github.com/ajeddeloh","followers_url":"https://api.github.com/users/ajeddeloh/followers","following_url":"https://api.github.com/users/ajeddeloh/following{/other_user}","gists_url":"https://api.github.com/users/ajeddeloh/gists{/gist_id}","starred_url":"https://api.github.com/users/ajeddeloh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajeddeloh/subscriptions","organizations_url":"https://api.github.com/users/ajeddeloh/orgs","repos_url":"https://api.github.com/users/ajeddeloh/repos","events_url":"https://api.github.com/users/ajeddeloh/events{/privacy}","received_events_url":"https://api.github.com/users/ajeddeloh/received_events","type":"User","site_admin":false},"body":"I think we have different ideas of \"interesting\". Better to be technically correct and phrase this as something like \"All of the contents of filesystems generated by a build goes into...\".\r\n\r\nI also disagree that \"images are just wrappers\". Grub, partition layouts and the filesystems on disk matter and shouldn't be discounted.","created_at":"2018-10-30T22:13:54Z","updated_at":"2018-10-30T22:16:50Z","html_url":"https://github.com/coreos/coreos-assembler/pull/189#discussion_r229505642","pull_request_url":"https://api.github.com/repos/coreos/coreos-assembler/pulls/189","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-assembler/pulls/comments/229505642"},"html":{"href":"https://github.com/coreos/coreos-assembler/pull/189#discussion_r229505642"},"pull_request":{"href":"https://api.github.com/repos/coreos/coreos-assembler/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/coreos-assembler/pulls/189","id":227097825,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDk3ODI1","html_url":"https://github.com/coreos/coreos-assembler/pull/189","diff_url":"https://github.com/coreos/coreos-assembler/pull/189.diff","patch_url":"https://github.com/coreos/coreos-assembler/pull/189.patch","issue_url":"https://api.github.com/repos/coreos/coreos-assembler/issues/189","number":189,"state":"open","locked":false,"title":"Add a README-design.md","user":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"body":"Overdue, I know I need to write more docs.","created_at":"2018-10-30T22:07:43Z","updated_at":"2018-10-30T22:16:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a398d732fb2c8e5ed880e5cf10ee85984d86bf7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/coreos-assembler/pulls/189/commits","review_comments_url":"https://api.github.com/repos/coreos/coreos-assembler/pulls/189/comments","review_comment_url":"https://api.github.com/repos/coreos/coreos-assembler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/coreos-assembler/issues/189/comments","statuses_url":"https://api.github.com/repos/coreos/coreos-assembler/statuses/1d63244d3353bdb1ed8b00708dba18d3565bb92d","head":{"label":"cgwalters:docs","ref":"docs","sha":"1d63244d3353bdb1ed8b00708dba18d3565bb92d","user":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"repo":{"id":148163725,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgxNjM3MjU=","name":"coreos-assembler","full_name":"cgwalters/coreos-assembler","private":false,"owner":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cgwalters/coreos-assembler","description":"Tooling container to assemble CoreOS-like systems","fork":true,"url":"https://api.github.com/repos/cgwalters/coreos-assembler","forks_url":"https://api.github.com/repos/cgwalters/coreos-assembler/forks","keys_url":"https://api.github.com/repos/cgwalters/coreos-assembler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgwalters/coreos-assembler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgwalters/coreos-assembler/teams","hooks_url":"https://api.github.com/repos/cgwalters/coreos-assembler/hooks","issue_events_url":"https://api.github.com/repos/cgwalters/coreos-assembler/issues/events{/number}","events_url":"https://api.github.com/repos/cgwalters/coreos-assembler/events","assignees_url":"https://api.github.com/repos/cgwalters/coreos-assembler/assignees{/user}","branches_url":"https://api.github.com/repos/cgwalters/coreos-assembler/branches{/branch}","tags_url":"https://api.github.com/repos/cgwalters/coreos-assembler/tags","blobs_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgwalters/coreos-assembler/statuses/{sha}","languages_url":"https://api.github.com/repos/cgwalters/coreos-assembler/languages","stargazers_url":"https://api.github.com/repos/cgwalters/coreos-assembler/stargazers","contributors_url":"https://api.github.com/repos/cgwalters/coreos-assembler/contributors","subscribers_url":"https://api.github.com/repos/cgwalters/coreos-assembler/subscribers","subscription_url":"https://api.github.com/repos/cgwalters/coreos-assembler/subscription","commits_url":"https://api.github.com/repos/cgwalters/coreos-assembler/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgwalters/coreos-assembler/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgwalters/coreos-assembler/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgwalters/coreos-assembler/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgwalters/coreos-assembler/contents/{+path}","compare_url":"https://api.github.com/repos/cgwalters/coreos-assembler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgwalters/coreos-assembler/merges","archive_url":"https://api.github.com/repos/cgwalters/coreos-assembler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgwalters/coreos-assembler/downloads","issues_url":"https://api.github.com/repos/cgwalters/coreos-assembler/issues{/number}","pulls_url":"https://api.github.com/repos/cgwalters/coreos-assembler/pulls{/number}","milestones_url":"https://api.github.com/repos/cgwalters/coreos-assembler/milestones{/number}","notifications_url":"https://api.github.com/repos/cgwalters/coreos-assembler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgwalters/coreos-assembler/labels{/name}","releases_url":"https://api.github.com/repos/cgwalters/coreos-assembler/releases{/id}","deployments_url":"https://api.github.com/repos/cgwalters/coreos-assembler/deployments","created_at":"2018-09-10T13:57:28Z","updated_at":"2018-09-10T13:57:30Z","pushed_at":"2018-10-30T22:07:38Z","git_url":"git://github.com/cgwalters/coreos-assembler.git","ssh_url":"git@github.com:cgwalters/coreos-assembler.git","clone_url":"https://github.com/cgwalters/coreos-assembler.git","svn_url":"https://github.com/cgwalters/coreos-assembler","homepage":"","size":198,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"773b59a360b5449962bfa3b4abf87fdfec3415c5","user":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":133999225,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5OTkyMjU=","name":"coreos-assembler","full_name":"coreos/coreos-assembler","private":false,"owner":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coreos/coreos-assembler","description":"Tooling container to assemble CoreOS-like systems","fork":false,"url":"https://api.github.com/repos/coreos/coreos-assembler","forks_url":"https://api.github.com/repos/coreos/coreos-assembler/forks","keys_url":"https://api.github.com/repos/coreos/coreos-assembler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/coreos-assembler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/coreos-assembler/teams","hooks_url":"https://api.github.com/repos/coreos/coreos-assembler/hooks","issue_events_url":"https://api.github.com/repos/coreos/coreos-assembler/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/coreos-assembler/events","assignees_url":"https://api.github.com/repos/coreos/coreos-assembler/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/coreos-assembler/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/coreos-assembler/tags","blobs_url":"https://api.github.com/repos/coreos/coreos-assembler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/coreos-assembler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/coreos-assembler/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/coreos-assembler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/coreos-assembler/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/coreos-assembler/languages","stargazers_url":"https://api.github.com/repos/coreos/coreos-assembler/stargazers","contributors_url":"https://api.github.com/repos/coreos/coreos-assembler/contributors","subscribers_url":"https://api.github.com/repos/coreos/coreos-assembler/subscribers","subscription_url":"https://api.github.com/repos/coreos/coreos-assembler/subscription","commits_url":"https://api.github.com/repos/coreos/coreos-assembler/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/coreos-assembler/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/coreos-assembler/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/coreos-assembler/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/coreos-assembler/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/coreos-assembler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/coreos-assembler/merges","archive_url":"https://api.github.com/repos/coreos/coreos-assembler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/coreos-assembler/downloads","issues_url":"https://api.github.com/repos/coreos/coreos-assembler/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/coreos-assembler/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/coreos-assembler/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/coreos-assembler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/coreos-assembler/labels{/name}","releases_url":"https://api.github.com/repos/coreos/coreos-assembler/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/coreos-assembler/deployments","created_at":"2018-05-18T20:07:27Z","updated_at":"2018-10-30T17:14:20Z","pushed_at":"2018-10-30T22:07:44Z","git_url":"git://github.com/coreos/coreos-assembler.git","ssh_url":"git@github.com:coreos/coreos-assembler.git","clone_url":"https://github.com/coreos/coreos-assembler.git","svn_url":"https://github.com/coreos/coreos-assembler","homepage":"","size":179,"stargazers_count":19,"watchers_count":19,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":15,"open_issues":23,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-assembler/pulls/189"},"html":{"href":"https://github.com/coreos/coreos-assembler/pull/189"},"issue":{"href":"https://api.github.com/repos/coreos/coreos-assembler/issues/189"},"comments":{"href":"https://api.github.com/repos/coreos/coreos-assembler/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/coreos-assembler/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/coreos-assembler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/coreos-assembler/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/coreos-assembler/statuses/1d63244d3353bdb1ed8b00708dba18d3565bb92d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ajeddeloh"}}