{"push_id":2364930154,"size":4,"distinct_size":4,"ref":"refs/heads/bosh_interpolate_manifest_155463709","head":"88abe77d4b447ddb30ee3f8d510169db68a0f793","before":"4927c4c2d83832ac11402f749ec235056dc2d1a1","commits":[{"sha":"fd84543d02fd58e1640e60cda8aacabf61dccda5","author":{"name":"Hector Rivas Gandara","email":"7b7e5985d0d5e042df62f31a43aa47b3c2b7c938@gmail.com"},"message":"Flatten variables for certificates as certs_\n\n`bosh interpolate` does not support deep merge of variables from\nmultiple vars files. Because that, all variables must be flatten\nand have a unique root key.\n\nIn the case of the certificates, we decided rename the suffix to\ncerts_, so we replace secrets.<var> to certs_<var>\n\nWe also remove the generation of ipsec-CA.yml, as it is not being\nused.\n\nWe generate the YAML file inline in the pipeline, so the script\nfile_to_yaml.sh is not necessary anymore.\n\nSigned-off-by: Andrew Bruce <me@andrewbruce.net>","distinct":true,"url":"https://api.github.com/repos/alphagov/paas-cf/commits/fd84543d02fd58e1640e60cda8aacabf61dccda5"},{"sha":"2cbb2653020ede5cd45225f5cdbe0dc945f8dcaa","author":{"name":"Andrew Bruce","email":"b4a5ea001e047040e8c9075b67a268293138da2c@andrewbruce.net"},"message":"Always populate \"old\" cert variables\n\nIn alphagov/paas-cf#1184 we added logic to rotate the certificates,\nwhich would rename the old certs to append a suffix `_old`\n\nThat old certificate would be available in the manifest with the\nvariables `certs_<cn>_old_key` or `certs_<cn>_old_cert`. But if the\ncertificate has never been rotated these variables are not defined.\n\nWith spruce we could use the operator `||` to give a default value\nif the variables were not defined, but that is not possible with\nbosh interpolation.\n\nAs workaround, we would always generate the variables\n`certs_<cn>_old_key` or `certs_<cn>_old_cert` with the current\ncertificate if the `_old` one does not exist.\n\nThis allows us to implement a similar logic as the one implemented\nin 7e018f2330117ff678530ed6157b905329fb861c\n\nSigned-off-by: Lee Porte <lee.porte@digital.cabinet-office.gov.uk>","distinct":true,"url":"https://api.github.com/repos/alphagov/paas-cf/commits/2cbb2653020ede5cd45225f5cdbe0dc945f8dcaa"},{"sha":"4455e6a161bdb5649023f5953011f8b88465d5d7","author":{"name":"Lee Porte","email":"48ebea2d4e0e63c45f619af8298a7f2dd7ad55b5@digital.cabinet-office.gov.uk"},"message":"Flatten variables for secrets and refactor scripts\n\n`bosh interpolate` does not support deep merge of variables from\nmultiple vars files. Because that, all variables must be flatten\nand have a unique root key.\n\nFor the case of secrets, we would replace `secrets.` with `secrets_`.\n\nWe must refactor the scripts that generate and rotate the secrets:\n\n - `generate-cf-secrets.rb` would generate flatten keys `secrets_`\n - `generate-cf-secrets.rb` is able to \"update\" a previous secrets\n   YAML file.\n - We refactor how the secrets are rotated, by implement a ruby\n   script to filter the secrets to keep, rather than using spruce.\n\nTo migrate the existing cf-secrets.yml file in the bucket, we\nrely in the script `generate-cf-secrets.rb` that would be called\nin the pipeline.\n\nFlatten secrets by replacing secrets_ with secrets.\n\nSigned-off-by: Hector Rivas Gandara <keymon@gmail.com>","distinct":true,"url":"https://api.github.com/repos/alphagov/paas-cf/commits/4455e6a161bdb5649023f5953011f8b88465d5d7"},{"sha":"88abe77d4b447ddb30ee3f8d510169db68a0f793","author":{"name":"Hector Rivas Gandara","email":"7b7e5985d0d5e042df62f31a43aa47b3c2b7c938@gmail.com"},"message":"Do not merge vars-files with spruce\n\nWe have flattened all the variables passed as vars-files to\nbosh-interpolate, so there is no need to use spruce to\nmerge the vars-files first.\n\nSigned-off-by: Andrew Bruce <me@andrewbruce.net>","distinct":true,"url":"https://api.github.com/repos/alphagov/paas-cf/commits/88abe77d4b447ddb30ee3f8d510169db68a0f793"}]}
{"actor":{"display_login":"keymon"}}