{"action":"created","comment":{"url":"https://api.github.com/repos/kiwicom/mobile/pulls/comments/203313517","pull_request_review_id":138175397,"id":203313517,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzMxMzUxNw==","diff_hunk":"@@ -70,3 +70,24 @@ export type Navigation = {\n   setParams: (newParameters: NavigationStateParameters) => void,\n   goBack: (key?: string | null) => void,\n };\n+\n+type Routes = Array<{|\n+  key: string,\n+  index: number,\n+  isTransitioning: boolean,\n+  routeName: string,\n+|}>;\n+\n+export type Navigator = {\n+  state: {\n+    nav: {\n+      key: string,\n+      index: number,\n+      isTransitioning: boolean,\n+      params?: {|\n+        isModal: boolean,\n+      |},\n+      routes: Routes,\n+    },\n+  },\n+};","path":"packages/navigation/types/Navigation.js","position":24,"original_position":24,"commit_id":"51ca3e837e341dee75b99ef46997e4e32268cfc9","original_commit_id":"51ca3e837e341dee75b99ef46997e4e32268cfc9","user":{"login":"tbergq","id":7705041,"node_id":"MDQ6VXNlcjc3MDUwNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7705041?v=4","gravatar_id":"","url":"https://api.github.com/users/tbergq","html_url":"https://github.com/tbergq","followers_url":"https://api.github.com/users/tbergq/followers","following_url":"https://api.github.com/users/tbergq/following{/other_user}","gists_url":"https://api.github.com/users/tbergq/gists{/gist_id}","starred_url":"https://api.github.com/users/tbergq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbergq/subscriptions","organizations_url":"https://api.github.com/users/tbergq/orgs","repos_url":"https://api.github.com/users/tbergq/repos","events_url":"https://api.github.com/users/tbergq/events{/privacy}","received_events_url":"https://api.github.com/users/tbergq/received_events","type":"User","site_admin":false},"body":"could you change this to\r\n\r\n```\r\ntype Routes = $ReadOnlyArray<{|\r\n  +key: string,\r\n  +index: number,\r\n  +isTransitioning: boolean,\r\n  +routeName: string,\r\n|}>;\r\n\r\nexport type Navigator = {|\r\n  +state: {|\r\n    +nav: {|\r\n      +key: string,\r\n      +index: number,\r\n      +isTransitioning: boolean,\r\n      +params?: {|\r\n        isModal: boolean,\r\n      |},\r\n      +routes: Routes,\r\n    |},\r\n  |},\r\n|};\r\n```","created_at":"2018-07-18T09:38:08Z","updated_at":"2018-07-18T09:42:19Z","html_url":"https://github.com/kiwicom/mobile/pull/892#discussion_r203313517","pull_request_url":"https://api.github.com/repos/kiwicom/mobile/pulls/892","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/comments/203313517"},"html":{"href":"https://github.com/kiwicom/mobile/pull/892#discussion_r203313517"},"pull_request":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/892"}}},"pull_request":{"url":"https://api.github.com/repos/kiwicom/mobile/pulls/892","id":202184575,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTg0NTc1","html_url":"https://github.com/kiwicom/mobile/pull/892","diff_url":"https://github.com/kiwicom/mobile/pull/892.diff","patch_url":"https://github.com/kiwicom/mobile/pull/892.patch","issue_url":"https://api.github.com/repos/kiwicom/mobile/issues/892","number":892,"state":"open","locked":false,"title":"iOS: block swiping back on modally presented screen","user":{"login":"lukewalczak","id":22746080,"node_id":"MDQ6VXNlcjIyNzQ2MDgw","avatar_url":"https://avatars1.githubusercontent.com/u/22746080?v=4","gravatar_id":"","url":"https://api.github.com/users/lukewalczak","html_url":"https://github.com/lukewalczak","followers_url":"https://api.github.com/users/lukewalczak/followers","following_url":"https://api.github.com/users/lukewalczak/following{/other_user}","gists_url":"https://api.github.com/users/lukewalczak/gists{/gist_id}","starred_url":"https://api.github.com/users/lukewalczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukewalczak/subscriptions","organizations_url":"https://api.github.com/users/lukewalczak/orgs","repos_url":"https://api.github.com/users/lukewalczak/repos","events_url":"https://api.github.com/users/lukewalczak/events{/privacy}","received_events_url":"https://api.github.com/users/lukewalczak/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-18T09:05:50Z","updated_at":"2018-07-18T09:42:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d3345a912b6a6a974a9b23bff8d2a039a4379e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiwicom/mobile/pulls/892/commits","review_comments_url":"https://api.github.com/repos/kiwicom/mobile/pulls/892/comments","review_comment_url":"https://api.github.com/repos/kiwicom/mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiwicom/mobile/issues/892/comments","statuses_url":"https://api.github.com/repos/kiwicom/mobile/statuses/51ca3e837e341dee75b99ef46997e4e32268cfc9","head":{"label":"kiwicom:ios-block-swipe-on-modal","ref":"ios-block-swipe-on-modal","sha":"51ca3e837e341dee75b99ef46997e4e32268cfc9","user":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"repo":{"id":105595148,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1OTUxNDg=","name":"mobile","full_name":"kiwicom/mobile","owner":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiwicom/mobile","description":":calling: Kiwi.com mobile app written in React Native","fork":false,"url":"https://api.github.com/repos/kiwicom/mobile","forks_url":"https://api.github.com/repos/kiwicom/mobile/forks","keys_url":"https://api.github.com/repos/kiwicom/mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiwicom/mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiwicom/mobile/teams","hooks_url":"https://api.github.com/repos/kiwicom/mobile/hooks","issue_events_url":"https://api.github.com/repos/kiwicom/mobile/issues/events{/number}","events_url":"https://api.github.com/repos/kiwicom/mobile/events","assignees_url":"https://api.github.com/repos/kiwicom/mobile/assignees{/user}","branches_url":"https://api.github.com/repos/kiwicom/mobile/branches{/branch}","tags_url":"https://api.github.com/repos/kiwicom/mobile/tags","blobs_url":"https://api.github.com/repos/kiwicom/mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiwicom/mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiwicom/mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiwicom/mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiwicom/mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/kiwicom/mobile/languages","stargazers_url":"https://api.github.com/repos/kiwicom/mobile/stargazers","contributors_url":"https://api.github.com/repos/kiwicom/mobile/contributors","subscribers_url":"https://api.github.com/repos/kiwicom/mobile/subscribers","subscription_url":"https://api.github.com/repos/kiwicom/mobile/subscription","commits_url":"https://api.github.com/repos/kiwicom/mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiwicom/mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiwicom/mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiwicom/mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiwicom/mobile/contents/{+path}","compare_url":"https://api.github.com/repos/kiwicom/mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiwicom/mobile/merges","archive_url":"https://api.github.com/repos/kiwicom/mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiwicom/mobile/downloads","issues_url":"https://api.github.com/repos/kiwicom/mobile/issues{/number}","pulls_url":"https://api.github.com/repos/kiwicom/mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/kiwicom/mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/kiwicom/mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiwicom/mobile/labels{/name}","releases_url":"https://api.github.com/repos/kiwicom/mobile/releases{/id}","deployments_url":"https://api.github.com/repos/kiwicom/mobile/deployments","created_at":"2017-10-02T23:21:42Z","updated_at":"2018-07-18T08:57:26Z","pushed_at":"2018-07-18T09:05:51Z","git_url":"git://github.com/kiwicom/mobile.git","ssh_url":"git@github.com:kiwicom/mobile.git","clone_url":"https://github.com/kiwicom/mobile.git","svn_url":"https://github.com/kiwicom/mobile","homepage":"https://www.kiwi.com/","size":13826,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":24,"watchers":33,"default_branch":"master"}},"base":{"label":"kiwicom:master","ref":"master","sha":"f5132ddbbd8a5f0590f88492d9507d0d4d787926","user":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"repo":{"id":105595148,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1OTUxNDg=","name":"mobile","full_name":"kiwicom/mobile","owner":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiwicom/mobile","description":":calling: Kiwi.com mobile app written in React Native","fork":false,"url":"https://api.github.com/repos/kiwicom/mobile","forks_url":"https://api.github.com/repos/kiwicom/mobile/forks","keys_url":"https://api.github.com/repos/kiwicom/mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiwicom/mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiwicom/mobile/teams","hooks_url":"https://api.github.com/repos/kiwicom/mobile/hooks","issue_events_url":"https://api.github.com/repos/kiwicom/mobile/issues/events{/number}","events_url":"https://api.github.com/repos/kiwicom/mobile/events","assignees_url":"https://api.github.com/repos/kiwicom/mobile/assignees{/user}","branches_url":"https://api.github.com/repos/kiwicom/mobile/branches{/branch}","tags_url":"https://api.github.com/repos/kiwicom/mobile/tags","blobs_url":"https://api.github.com/repos/kiwicom/mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiwicom/mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiwicom/mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiwicom/mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiwicom/mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/kiwicom/mobile/languages","stargazers_url":"https://api.github.com/repos/kiwicom/mobile/stargazers","contributors_url":"https://api.github.com/repos/kiwicom/mobile/contributors","subscribers_url":"https://api.github.com/repos/kiwicom/mobile/subscribers","subscription_url":"https://api.github.com/repos/kiwicom/mobile/subscription","commits_url":"https://api.github.com/repos/kiwicom/mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiwicom/mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiwicom/mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiwicom/mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiwicom/mobile/contents/{+path}","compare_url":"https://api.github.com/repos/kiwicom/mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiwicom/mobile/merges","archive_url":"https://api.github.com/repos/kiwicom/mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiwicom/mobile/downloads","issues_url":"https://api.github.com/repos/kiwicom/mobile/issues{/number}","pulls_url":"https://api.github.com/repos/kiwicom/mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/kiwicom/mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/kiwicom/mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiwicom/mobile/labels{/name}","releases_url":"https://api.github.com/repos/kiwicom/mobile/releases{/id}","deployments_url":"https://api.github.com/repos/kiwicom/mobile/deployments","created_at":"2017-10-02T23:21:42Z","updated_at":"2018-07-18T08:57:26Z","pushed_at":"2018-07-18T09:05:51Z","git_url":"git://github.com/kiwicom/mobile.git","ssh_url":"git@github.com:kiwicom/mobile.git","clone_url":"https://github.com/kiwicom/mobile.git","svn_url":"https://github.com/kiwicom/mobile","homepage":"https://www.kiwi.com/","size":13826,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":24,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/892"},"html":{"href":"https://github.com/kiwicom/mobile/pull/892"},"issue":{"href":"https://api.github.com/repos/kiwicom/mobile/issues/892"},"comments":{"href":"https://api.github.com/repos/kiwicom/mobile/issues/892/comments"},"review_comments":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/892/comments"},"review_comment":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiwicom/mobile/pulls/892/commits"},"statuses":{"href":"https://api.github.com/repos/kiwicom/mobile/statuses/51ca3e837e341dee75b99ef46997e4e32268cfc9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tbergq"}}