{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/21857","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/21857/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21857/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/21857/events","html_url":"https://github.com/nodejs/node/pull/21857","id":342038736,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDMzODU3","number":21857,"title":"util: expose promise events","user":{"login":"devsnek","id":5952481,"node_id":"MDQ6VXNlcjU5NTI0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/5952481?v=4","gravatar_id":"","url":"https://api.github.com/users/devsnek","html_url":"https://github.com/devsnek","followers_url":"https://api.github.com/users/devsnek/followers","following_url":"https://api.github.com/users/devsnek/following{/other_user}","gists_url":"https://api.github.com/users/devsnek/gists{/gist_id}","starred_url":"https://api.github.com/users/devsnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devsnek/subscriptions","organizations_url":"https://api.github.com/users/devsnek/orgs","repos_url":"https://api.github.com/users/devsnek/repos","events_url":"https://api.github.com/users/devsnek/events{/privacy}","received_events_url":"https://api.github.com/users/devsnek/received_events","type":"User","site_admin":false},"labels":[{"id":340436277,"node_id":"MDU6TGFiZWwzNDA0MzYyNzc=","url":"https://api.github.com/repos/nodejs/node/labels/promises","name":"promises","color":"f7c6c7","default":false},{"id":169485478,"node_id":"MDU6TGFiZWwxNjk0ODU0Nzg=","url":"https://api.github.com/repos/nodejs/node/labels/semver-minor","name":"semver-minor","color":"fef2c0","default":false},{"id":155267446,"node_id":"MDU6TGFiZWwxNTUyNjc0NDY=","url":"https://api.github.com/repos/nodejs/node/labels/util","name":"util","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":109,"created_at":"2018-07-17T18:44:25Z","updated_at":"2018-08-08T07:32:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/21857","html_url":"https://github.com/nodejs/node/pull/21857","diff_url":"https://github.com/nodejs/node/pull/21857.diff","patch_url":"https://github.com/nodejs/node/pull/21857.patch"},"body":"Refs https://github.com/nodejs/promises-debugging/issues/8\r\nCloses https://github.com/nodejs/promises-debugging/issues/8\r\n\r\nexposes env promise hooks to userland\r\n\r\n/cc @nodejs/promises-debugging @nodejs/async_hooks @BridgeAR @ljharb\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/411314308","html_url":"https://github.com/nodejs/node/pull/21857#issuecomment-411314308","issue_url":"https://api.github.com/repos/nodejs/node/issues/21857","id":411314308,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTMxNDMwOA==","user":{"login":"benjamingr","id":1315533,"node_id":"MDQ6VXNlcjEzMTU1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1315533?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamingr","html_url":"https://github.com/benjamingr","followers_url":"https://api.github.com/users/benjamingr/followers","following_url":"https://api.github.com/users/benjamingr/following{/other_user}","gists_url":"https://api.github.com/users/benjamingr/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamingr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamingr/subscriptions","organizations_url":"https://api.github.com/users/benjamingr/orgs","repos_url":"https://api.github.com/users/benjamingr/repos","events_url":"https://api.github.com/users/benjamingr/events{/privacy}","received_events_url":"https://api.github.com/users/benjamingr/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T07:32:22Z","updated_at":"2018-08-08T07:32:22Z","author_association":"MEMBER","body":"@BridgeAR how would you prefer the API surface for subscribing to the \"reject after resolve\" events to be exposed?\r\n\r\nThis PR exposes all the promise events - I was thinking of making a library on top of this event and see if people want to use it - I'm also fine with exposing a warning directly from core as long as it's opt-in (at least initially)."}}
{"actor":{"display_login":"benjamingr"}}