{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/meas_modelfit/pulls/comments/193917740","pull_request_review_id":126991542,"id":193917740,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzkxNzc0MA==","diff_hunk":"@@ -325,8 +327,8 @@ class ProfileObjective : public OptimizerObjective {\n     Scalar _maxRadius;\n     Scalar _minRadiusDiff;\n     Scalar _normalization;\n-    ndarray::EigenView<Scalar,1,1,Eigen::ArrayXpr> _data;\n-    ndarray::EigenView<Scalar,1,1,Eigen::ArrayXpr> _arg;\n+    ndarray::Array<Scalar,1,1> _data;  // ArrayXpr\n+    ndarray::Array<Scalar,1,1> _arg;  // ArrayXpr","path":"src/DoubleShapeletPsfApprox.cc","position":40,"original_position":40,"commit_id":"2b82da0ac566786736490ae850340752da139b7f","original_commit_id":"2b82da0ac566786736490ae850340752da139b7f","user":{"login":"kfindeisen","id":8508260,"node_id":"MDQ6VXNlcjg1MDgyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/8508260?v=4","gravatar_id":"","url":"https://api.github.com/users/kfindeisen","html_url":"https://github.com/kfindeisen","followers_url":"https://api.github.com/users/kfindeisen/followers","following_url":"https://api.github.com/users/kfindeisen/following{/other_user}","gists_url":"https://api.github.com/users/kfindeisen/gists{/gist_id}","starred_url":"https://api.github.com/users/kfindeisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfindeisen/subscriptions","organizations_url":"https://api.github.com/users/kfindeisen/orgs","repos_url":"https://api.github.com/users/kfindeisen/repos","events_url":"https://api.github.com/users/kfindeisen/events{/privacy}","received_events_url":"https://api.github.com/users/kfindeisen/received_events","type":"User","site_admin":false},"body":"I don't understand these comments.","created_at":"2018-06-07T23:33:15Z","updated_at":"2018-06-07T23:57:39Z","html_url":"https://github.com/lsst/meas_modelfit/pull/58#discussion_r193917740","pull_request_url":"https://api.github.com/repos/lsst/meas_modelfit/pulls/58","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lsst/meas_modelfit/pulls/comments/193917740"},"html":{"href":"https://github.com/lsst/meas_modelfit/pull/58#discussion_r193917740"},"pull_request":{"href":"https://api.github.com/repos/lsst/meas_modelfit/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/meas_modelfit/pulls/58","id":193452808,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDUyODA4","html_url":"https://github.com/lsst/meas_modelfit/pull/58","diff_url":"https://github.com/lsst/meas_modelfit/pull/58.diff","patch_url":"https://github.com/lsst/meas_modelfit/pull/58.patch","issue_url":"https://api.github.com/repos/lsst/meas_modelfit/issues/58","number":58,"state":"open","locked":false,"title":"DM-14725: Eliminate explicit use of ndarray::EigenView in C++ code","user":{"login":"r-owen","id":874176,"node_id":"MDQ6VXNlcjg3NDE3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/874176?v=4","gravatar_id":"","url":"https://api.github.com/users/r-owen","html_url":"https://github.com/r-owen","followers_url":"https://api.github.com/users/r-owen/followers","following_url":"https://api.github.com/users/r-owen/following{/other_user}","gists_url":"https://api.github.com/users/r-owen/gists{/gist_id}","starred_url":"https://api.github.com/users/r-owen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-owen/subscriptions","organizations_url":"https://api.github.com/users/r-owen/orgs","repos_url":"https://api.github.com/users/r-owen/repos","events_url":"https://api.github.com/users/r-owen/events{/privacy}","received_events_url":"https://api.github.com/users/r-owen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-07T21:29:38Z","updated_at":"2018-06-07T23:57:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cca6e895b7fd3ab0161d216dcc989245e13a1707","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/meas_modelfit/pulls/58/commits","review_comments_url":"https://api.github.com/repos/lsst/meas_modelfit/pulls/58/comments","review_comment_url":"https://api.github.com/repos/lsst/meas_modelfit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/meas_modelfit/issues/58/comments","statuses_url":"https://api.github.com/repos/lsst/meas_modelfit/statuses/2b82da0ac566786736490ae850340752da139b7f","head":{"label":"lsst:tickets/DM-14725","ref":"tickets/DM-14725","sha":"2b82da0ac566786736490ae850340752da139b7f","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013386,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAxMzM4Ng==","name":"meas_modelfit","full_name":"lsst/meas_modelfit","owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/meas_modelfit","description":"LSST Data Management: model fitting algorithms","fork":false,"url":"https://api.github.com/repos/lsst/meas_modelfit","forks_url":"https://api.github.com/repos/lsst/meas_modelfit/forks","keys_url":"https://api.github.com/repos/lsst/meas_modelfit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/meas_modelfit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/meas_modelfit/teams","hooks_url":"https://api.github.com/repos/lsst/meas_modelfit/hooks","issue_events_url":"https://api.github.com/repos/lsst/meas_modelfit/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/meas_modelfit/events","assignees_url":"https://api.github.com/repos/lsst/meas_modelfit/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/meas_modelfit/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/meas_modelfit/tags","blobs_url":"https://api.github.com/repos/lsst/meas_modelfit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/meas_modelfit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/meas_modelfit/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/meas_modelfit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/meas_modelfit/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/meas_modelfit/languages","stargazers_url":"https://api.github.com/repos/lsst/meas_modelfit/stargazers","contributors_url":"https://api.github.com/repos/lsst/meas_modelfit/contributors","subscribers_url":"https://api.github.com/repos/lsst/meas_modelfit/subscribers","subscription_url":"https://api.github.com/repos/lsst/meas_modelfit/subscription","commits_url":"https://api.github.com/repos/lsst/meas_modelfit/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/meas_modelfit/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/meas_modelfit/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/meas_modelfit/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/meas_modelfit/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/meas_modelfit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/meas_modelfit/merges","archive_url":"https://api.github.com/repos/lsst/meas_modelfit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/meas_modelfit/downloads","issues_url":"https://api.github.com/repos/lsst/meas_modelfit/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/meas_modelfit/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/meas_modelfit/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/meas_modelfit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/meas_modelfit/labels{/name}","releases_url":"https://api.github.com/repos/lsst/meas_modelfit/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/meas_modelfit/deployments","created_at":"2014-08-16T07:46:42Z","updated_at":"2018-06-01T21:27:51Z","pushed_at":"2018-06-07T21:29:39Z","git_url":"git://github.com/lsst/meas_modelfit.git","ssh_url":"git@github.com:lsst/meas_modelfit.git","clone_url":"https://github.com/lsst/meas_modelfit.git","svn_url":"https://github.com/lsst/meas_modelfit","homepage":"http://dm.lsst.org/","size":47584,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":7,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"c1213afc75c670dafbe7ade3006db872a5d5eda3","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013386,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAxMzM4Ng==","name":"meas_modelfit","full_name":"lsst/meas_modelfit","owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/meas_modelfit","description":"LSST Data Management: model fitting algorithms","fork":false,"url":"https://api.github.com/repos/lsst/meas_modelfit","forks_url":"https://api.github.com/repos/lsst/meas_modelfit/forks","keys_url":"https://api.github.com/repos/lsst/meas_modelfit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/meas_modelfit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/meas_modelfit/teams","hooks_url":"https://api.github.com/repos/lsst/meas_modelfit/hooks","issue_events_url":"https://api.github.com/repos/lsst/meas_modelfit/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/meas_modelfit/events","assignees_url":"https://api.github.com/repos/lsst/meas_modelfit/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/meas_modelfit/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/meas_modelfit/tags","blobs_url":"https://api.github.com/repos/lsst/meas_modelfit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/meas_modelfit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/meas_modelfit/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/meas_modelfit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/meas_modelfit/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/meas_modelfit/languages","stargazers_url":"https://api.github.com/repos/lsst/meas_modelfit/stargazers","contributors_url":"https://api.github.com/repos/lsst/meas_modelfit/contributors","subscribers_url":"https://api.github.com/repos/lsst/meas_modelfit/subscribers","subscription_url":"https://api.github.com/repos/lsst/meas_modelfit/subscription","commits_url":"https://api.github.com/repos/lsst/meas_modelfit/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/meas_modelfit/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/meas_modelfit/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/meas_modelfit/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/meas_modelfit/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/meas_modelfit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/meas_modelfit/merges","archive_url":"https://api.github.com/repos/lsst/meas_modelfit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/meas_modelfit/downloads","issues_url":"https://api.github.com/repos/lsst/meas_modelfit/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/meas_modelfit/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/meas_modelfit/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/meas_modelfit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/meas_modelfit/labels{/name}","releases_url":"https://api.github.com/repos/lsst/meas_modelfit/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/meas_modelfit/deployments","created_at":"2014-08-16T07:46:42Z","updated_at":"2018-06-01T21:27:51Z","pushed_at":"2018-06-07T21:29:39Z","git_url":"git://github.com/lsst/meas_modelfit.git","ssh_url":"git@github.com:lsst/meas_modelfit.git","clone_url":"https://github.com/lsst/meas_modelfit.git","svn_url":"https://github.com/lsst/meas_modelfit","homepage":"http://dm.lsst.org/","size":47584,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":7,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/meas_modelfit/pulls/58"},"html":{"href":"https://github.com/lsst/meas_modelfit/pull/58"},"issue":{"href":"https://api.github.com/repos/lsst/meas_modelfit/issues/58"},"comments":{"href":"https://api.github.com/repos/lsst/meas_modelfit/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/meas_modelfit/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/meas_modelfit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/meas_modelfit/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/meas_modelfit/statuses/2b82da0ac566786736490ae850340752da139b7f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kfindeisen"}}