{"action":"created","comment":{"url":"https://api.github.com/repos/payara/Payara/pulls/comments/182452869","pull_request_review_id":113250376,"id":182452869,"diff_hunk":"@@ -106,6 +106,7 @@ public ConfigBuilder withConverters(Converter<?>... converters) {\n \n     @Override\n     public Config build() {\n+        this.converters.addAll(resolver.getDefaultConverters());","path":"nucleus/payara-modules/nucleus-microprofile/config-service/src/main/java/fish/payara/nucleus/microprofile/config/spi/PayaraConfigBuilder.java","position":4,"original_position":4,"commit_id":"1111119370d937780f9b1f0be110e21c00ce1a97","original_commit_id":"1111119370d937780f9b1f0be110e21c00ce1a97","user":{"login":"arjantijms","id":3037006,"avatar_url":"https://avatars2.githubusercontent.com/u/3037006?v=4","gravatar_id":"","url":"https://api.github.com/users/arjantijms","html_url":"https://github.com/arjantijms","followers_url":"https://api.github.com/users/arjantijms/followers","following_url":"https://api.github.com/users/arjantijms/following{/other_user}","gists_url":"https://api.github.com/users/arjantijms/gists{/gist_id}","starred_url":"https://api.github.com/users/arjantijms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjantijms/subscriptions","organizations_url":"https://api.github.com/users/arjantijms/orgs","repos_url":"https://api.github.com/users/arjantijms/repos","events_url":"https://api.github.com/users/arjantijms/events{/privacy}","received_events_url":"https://api.github.com/users/arjantijms/received_events","type":"User","site_admin":false},"body":"\"this.\" would not be needed here","created_at":"2018-04-18T14:42:40Z","updated_at":"2018-04-18T14:42:40Z","html_url":"https://github.com/payara/Payara/pull/2633#discussion_r182452869","pull_request_url":"https://api.github.com/repos/payara/Payara/pulls/2633","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/payara/Payara/pulls/comments/182452869"},"html":{"href":"https://github.com/payara/Payara/pull/2633#discussion_r182452869"},"pull_request":{"href":"https://api.github.com/repos/payara/Payara/pulls/2633"}}},"pull_request":{"url":"https://api.github.com/repos/payara/Payara/pulls/2633","id":181588856,"html_url":"https://github.com/payara/Payara/pull/2633","diff_url":"https://github.com/payara/Payara/pull/2633.diff","patch_url":"https://github.com/payara/Payara/pull/2633.patch","issue_url":"https://api.github.com/repos/payara/Payara/issues/2633","number":2633,"state":"open","locked":false,"title":"PAYARA-2687 ensure Config built with ConfigBuilder has the default co…","user":{"login":"smillidge","id":939073,"avatar_url":"https://avatars3.githubusercontent.com/u/939073?v=4","gravatar_id":"","url":"https://api.github.com/users/smillidge","html_url":"https://github.com/smillidge","followers_url":"https://api.github.com/users/smillidge/followers","following_url":"https://api.github.com/users/smillidge/following{/other_user}","gists_url":"https://api.github.com/users/smillidge/gists{/gist_id}","starred_url":"https://api.github.com/users/smillidge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smillidge/subscriptions","organizations_url":"https://api.github.com/users/smillidge/orgs","repos_url":"https://api.github.com/users/smillidge/repos","events_url":"https://api.github.com/users/smillidge/events{/privacy}","received_events_url":"https://api.github.com/users/smillidge/received_events","type":"User","site_admin":false},"body":"…nverters","created_at":"2018-04-13T20:29:13Z","updated_at":"2018-04-18T14:42:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9455858c88f8296906e88aa7d027dc5d4168f36f","assignee":{"login":"smillidge","id":939073,"avatar_url":"https://avatars3.githubusercontent.com/u/939073?v=4","gravatar_id":"","url":"https://api.github.com/users/smillidge","html_url":"https://github.com/smillidge","followers_url":"https://api.github.com/users/smillidge/followers","following_url":"https://api.github.com/users/smillidge/following{/other_user}","gists_url":"https://api.github.com/users/smillidge/gists{/gist_id}","starred_url":"https://api.github.com/users/smillidge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smillidge/subscriptions","organizations_url":"https://api.github.com/users/smillidge/orgs","repos_url":"https://api.github.com/users/smillidge/repos","events_url":"https://api.github.com/users/smillidge/events{/privacy}","received_events_url":"https://api.github.com/users/smillidge/received_events","type":"User","site_admin":false},"assignees":[{"login":"smillidge","id":939073,"avatar_url":"https://avatars3.githubusercontent.com/u/939073?v=4","gravatar_id":"","url":"https://api.github.com/users/smillidge","html_url":"https://github.com/smillidge","followers_url":"https://api.github.com/users/smillidge/followers","following_url":"https://api.github.com/users/smillidge/following{/other_user}","gists_url":"https://api.github.com/users/smillidge/gists{/gist_id}","starred_url":"https://api.github.com/users/smillidge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smillidge/subscriptions","organizations_url":"https://api.github.com/users/smillidge/orgs","repos_url":"https://api.github.com/users/smillidge/repos","events_url":"https://api.github.com/users/smillidge/events{/privacy}","received_events_url":"https://api.github.com/users/smillidge/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/payara/Payara/milestones/25","html_url":"https://github.com/payara/Payara/milestone/25","labels_url":"https://api.github.com/repos/payara/Payara/milestones/25/labels","id":3162224,"number":25,"title":"Payara 5.182","description":"","creator":{"login":"smillidge","id":939073,"avatar_url":"https://avatars3.githubusercontent.com/u/939073?v=4","gravatar_id":"","url":"https://api.github.com/users/smillidge","html_url":"https://github.com/smillidge","followers_url":"https://api.github.com/users/smillidge/followers","following_url":"https://api.github.com/users/smillidge/following{/other_user}","gists_url":"https://api.github.com/users/smillidge/gists{/gist_id}","starred_url":"https://api.github.com/users/smillidge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smillidge/subscriptions","organizations_url":"https://api.github.com/users/smillidge/orgs","repos_url":"https://api.github.com/users/smillidge/repos","events_url":"https://api.github.com/users/smillidge/events{/privacy}","received_events_url":"https://api.github.com/users/smillidge/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":45,"state":"open","created_at":"2018-03-05T15:11:01Z","updated_at":"2018-04-18T14:34:51Z","due_on":"2018-05-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/payara/Payara/pulls/2633/commits","review_comments_url":"https://api.github.com/repos/payara/Payara/pulls/2633/comments","review_comment_url":"https://api.github.com/repos/payara/Payara/pulls/comments{/number}","comments_url":"https://api.github.com/repos/payara/Payara/issues/2633/comments","statuses_url":"https://api.github.com/repos/payara/Payara/statuses/1111119370d937780f9b1f0be110e21c00ce1a97","head":{"label":"smillidge:PAYARA-2687","ref":"PAYARA-2687","sha":"1111119370d937780f9b1f0be110e21c00ce1a97","user":{"login":"smillidge","id":939073,"avatar_url":"https://avatars3.githubusercontent.com/u/939073?v=4","gravatar_id":"","url":"https://api.github.com/users/smillidge","html_url":"https://github.com/smillidge","followers_url":"https://api.github.com/users/smillidge/followers","following_url":"https://api.github.com/users/smillidge/following{/other_user}","gists_url":"https://api.github.com/users/smillidge/gists{/gist_id}","starred_url":"https://api.github.com/users/smillidge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smillidge/subscriptions","organizations_url":"https://api.github.com/users/smillidge/orgs","repos_url":"https://api.github.com/users/smillidge/repos","events_url":"https://api.github.com/users/smillidge/events{/privacy}","received_events_url":"https://api.github.com/users/smillidge/received_events","type":"User","site_admin":false},"repo":{"id":24259044,"name":"Payara","full_name":"smillidge/Payara","owner":{"login":"smillidge","id":939073,"avatar_url":"https://avatars3.githubusercontent.com/u/939073?v=4","gravatar_id":"","url":"https://api.github.com/users/smillidge","html_url":"https://github.com/smillidge","followers_url":"https://api.github.com/users/smillidge/followers","following_url":"https://api.github.com/users/smillidge/following{/other_user}","gists_url":"https://api.github.com/users/smillidge/gists{/gist_id}","starred_url":"https://api.github.com/users/smillidge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smillidge/subscriptions","organizations_url":"https://api.github.com/users/smillidge/orgs","repos_url":"https://api.github.com/users/smillidge/repos","events_url":"https://api.github.com/users/smillidge/events{/privacy}","received_events_url":"https://api.github.com/users/smillidge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smillidge/Payara","description":"Payara Server","fork":true,"url":"https://api.github.com/repos/smillidge/Payara","forks_url":"https://api.github.com/repos/smillidge/Payara/forks","keys_url":"https://api.github.com/repos/smillidge/Payara/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smillidge/Payara/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smillidge/Payara/teams","hooks_url":"https://api.github.com/repos/smillidge/Payara/hooks","issue_events_url":"https://api.github.com/repos/smillidge/Payara/issues/events{/number}","events_url":"https://api.github.com/repos/smillidge/Payara/events","assignees_url":"https://api.github.com/repos/smillidge/Payara/assignees{/user}","branches_url":"https://api.github.com/repos/smillidge/Payara/branches{/branch}","tags_url":"https://api.github.com/repos/smillidge/Payara/tags","blobs_url":"https://api.github.com/repos/smillidge/Payara/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smillidge/Payara/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smillidge/Payara/git/refs{/sha}","trees_url":"https://api.github.com/repos/smillidge/Payara/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smillidge/Payara/statuses/{sha}","languages_url":"https://api.github.com/repos/smillidge/Payara/languages","stargazers_url":"https://api.github.com/repos/smillidge/Payara/stargazers","contributors_url":"https://api.github.com/repos/smillidge/Payara/contributors","subscribers_url":"https://api.github.com/repos/smillidge/Payara/subscribers","subscription_url":"https://api.github.com/repos/smillidge/Payara/subscription","commits_url":"https://api.github.com/repos/smillidge/Payara/commits{/sha}","git_commits_url":"https://api.github.com/repos/smillidge/Payara/git/commits{/sha}","comments_url":"https://api.github.com/repos/smillidge/Payara/comments{/number}","issue_comment_url":"https://api.github.com/repos/smillidge/Payara/issues/comments{/number}","contents_url":"https://api.github.com/repos/smillidge/Payara/contents/{+path}","compare_url":"https://api.github.com/repos/smillidge/Payara/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smillidge/Payara/merges","archive_url":"https://api.github.com/repos/smillidge/Payara/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smillidge/Payara/downloads","issues_url":"https://api.github.com/repos/smillidge/Payara/issues{/number}","pulls_url":"https://api.github.com/repos/smillidge/Payara/pulls{/number}","milestones_url":"https://api.github.com/repos/smillidge/Payara/milestones{/number}","notifications_url":"https://api.github.com/repos/smillidge/Payara/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smillidge/Payara/labels{/name}","releases_url":"https://api.github.com/repos/smillidge/Payara/releases{/id}","deployments_url":"https://api.github.com/repos/smillidge/Payara/deployments","created_at":"2014-09-20T09:38:04Z","updated_at":"2018-04-07T06:49:40Z","pushed_at":"2018-04-13T20:30:52Z","git_url":"git://github.com/smillidge/Payara.git","ssh_url":"git@github.com:smillidge/Payara.git","clone_url":"https://github.com/smillidge/Payara.git","svn_url":"https://github.com/smillidge/Payara","homepage":null,"size":84328,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"payara:master","ref":"master","sha":"877421e72f952131bb39b3e3c9efe68404c444e0","user":{"login":"payara","id":7817189,"avatar_url":"https://avatars2.githubusercontent.com/u/7817189?v=4","gravatar_id":"","url":"https://api.github.com/users/payara","html_url":"https://github.com/payara","followers_url":"https://api.github.com/users/payara/followers","following_url":"https://api.github.com/users/payara/following{/other_user}","gists_url":"https://api.github.com/users/payara/gists{/gist_id}","starred_url":"https://api.github.com/users/payara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payara/subscriptions","organizations_url":"https://api.github.com/users/payara/orgs","repos_url":"https://api.github.com/users/payara/repos","events_url":"https://api.github.com/users/payara/events{/privacy}","received_events_url":"https://api.github.com/users/payara/received_events","type":"Organization","site_admin":false},"repo":{"id":23930639,"name":"Payara","full_name":"payara/Payara","owner":{"login":"payara","id":7817189,"avatar_url":"https://avatars2.githubusercontent.com/u/7817189?v=4","gravatar_id":"","url":"https://api.github.com/users/payara","html_url":"https://github.com/payara","followers_url":"https://api.github.com/users/payara/followers","following_url":"https://api.github.com/users/payara/following{/other_user}","gists_url":"https://api.github.com/users/payara/gists{/gist_id}","starred_url":"https://api.github.com/users/payara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payara/subscriptions","organizations_url":"https://api.github.com/users/payara/orgs","repos_url":"https://api.github.com/users/payara/repos","events_url":"https://api.github.com/users/payara/events{/privacy}","received_events_url":"https://api.github.com/users/payara/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/payara/Payara","description":"Payara Server is derived from GlassFish Server Open Source Edition and 100% open source","fork":false,"url":"https://api.github.com/repos/payara/Payara","forks_url":"https://api.github.com/repos/payara/Payara/forks","keys_url":"https://api.github.com/repos/payara/Payara/keys{/key_id}","collaborators_url":"https://api.github.com/repos/payara/Payara/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/payara/Payara/teams","hooks_url":"https://api.github.com/repos/payara/Payara/hooks","issue_events_url":"https://api.github.com/repos/payara/Payara/issues/events{/number}","events_url":"https://api.github.com/repos/payara/Payara/events","assignees_url":"https://api.github.com/repos/payara/Payara/assignees{/user}","branches_url":"https://api.github.com/repos/payara/Payara/branches{/branch}","tags_url":"https://api.github.com/repos/payara/Payara/tags","blobs_url":"https://api.github.com/repos/payara/Payara/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/payara/Payara/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/payara/Payara/git/refs{/sha}","trees_url":"https://api.github.com/repos/payara/Payara/git/trees{/sha}","statuses_url":"https://api.github.com/repos/payara/Payara/statuses/{sha}","languages_url":"https://api.github.com/repos/payara/Payara/languages","stargazers_url":"https://api.github.com/repos/payara/Payara/stargazers","contributors_url":"https://api.github.com/repos/payara/Payara/contributors","subscribers_url":"https://api.github.com/repos/payara/Payara/subscribers","subscription_url":"https://api.github.com/repos/payara/Payara/subscription","commits_url":"https://api.github.com/repos/payara/Payara/commits{/sha}","git_commits_url":"https://api.github.com/repos/payara/Payara/git/commits{/sha}","comments_url":"https://api.github.com/repos/payara/Payara/comments{/number}","issue_comment_url":"https://api.github.com/repos/payara/Payara/issues/comments{/number}","contents_url":"https://api.github.com/repos/payara/Payara/contents/{+path}","compare_url":"https://api.github.com/repos/payara/Payara/compare/{base}...{head}","merges_url":"https://api.github.com/repos/payara/Payara/merges","archive_url":"https://api.github.com/repos/payara/Payara/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/payara/Payara/downloads","issues_url":"https://api.github.com/repos/payara/Payara/issues{/number}","pulls_url":"https://api.github.com/repos/payara/Payara/pulls{/number}","milestones_url":"https://api.github.com/repos/payara/Payara/milestones{/number}","notifications_url":"https://api.github.com/repos/payara/Payara/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/payara/Payara/labels{/name}","releases_url":"https://api.github.com/repos/payara/Payara/releases{/id}","deployments_url":"https://api.github.com/repos/payara/Payara/deployments","created_at":"2014-09-11T18:32:40Z","updated_at":"2018-04-18T14:34:54Z","pushed_at":"2018-04-18T14:34:51Z","git_url":"git://github.com/payara/Payara.git","ssh_url":"git@github.com:payara/Payara.git","clone_url":"https://github.com/payara/Payara.git","svn_url":"https://github.com/payara/Payara","homepage":"http://www.payara.fish","size":88868,"stargazers_count":542,"watchers_count":542,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":126,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":155,"open_issues":126,"watchers":542,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/payara/Payara/pulls/2633"},"html":{"href":"https://github.com/payara/Payara/pull/2633"},"issue":{"href":"https://api.github.com/repos/payara/Payara/issues/2633"},"comments":{"href":"https://api.github.com/repos/payara/Payara/issues/2633/comments"},"review_comments":{"href":"https://api.github.com/repos/payara/Payara/pulls/2633/comments"},"review_comment":{"href":"https://api.github.com/repos/payara/Payara/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/payara/Payara/pulls/2633/commits"},"statuses":{"href":"https://api.github.com/repos/payara/Payara/statuses/1111119370d937780f9b1f0be110e21c00ce1a97"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"arjantijms"}}