{"action":"created","comment":{"url":"https://api.github.com/repos/UCLALibrary/californica/pulls/comments/217153251","pull_request_review_id":154799227,"id":217153251,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzE1MzI1MQ==","diff_hunk":"@@ -28,10 +28,20 @@ def loaded_files_excluding_current_rake_file\n       \"hearing over eminent domain for construction of Harbor Freeway, Calif., 1947\"\n     end\n     let(:description) { [\"At the Hall of Records, 220 N. Broadway.\", \"Description 2\"] }\n+    let(:subj) do\n+      [\"Express highways--California--Los Angeles County--Design and construction\",\n+       \"Eminent domain--California--Los Angeles\",\n+       \"Demonstrations--California--Los Angeles County\",\n+       \"Transportation\",\n+       \"Government\",\n+       \"Activism\",\n+       \"Interstate 10\"]\n+    end\n \n     it 'has created a work with the correct metadata' do\n       expect(created_work.title).to contain_exactly(title)\n       expect(created_work.description).to contain_exactly(*description)\n+      expect(created_work.subject).to contain_exactly(*subj)","path":"spec/tasks/ingest_spec.rb","position":17,"original_position":17,"commit_id":"bda19c27ca56963b3f47deccf97361112e53a5e1","original_commit_id":"bda19c27ca56963b3f47deccf97361112e53a5e1","user":{"login":"no-reply","id":1361776,"node_id":"MDQ6VXNlcjEzNjE3NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1361776?v=4","gravatar_id":"","url":"https://api.github.com/users/no-reply","html_url":"https://github.com/no-reply","followers_url":"https://api.github.com/users/no-reply/followers","following_url":"https://api.github.com/users/no-reply/following{/other_user}","gists_url":"https://api.github.com/users/no-reply/gists{/gist_id}","starred_url":"https://api.github.com/users/no-reply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-reply/subscriptions","organizations_url":"https://api.github.com/users/no-reply/orgs","repos_url":"https://api.github.com/users/no-reply/repos","events_url":"https://api.github.com/users/no-reply/events{/privacy}","received_events_url":"https://api.github.com/users/no-reply/received_events","type":"User","site_admin":false},"body":"We might want to change this eventually to `expect(created_work).to have_attributes(..., subject: contain_exactly(*subj), ...)`. That would report unexpected values all at once, instead of failing at the first bad expectation.\r\n\r\nFor now, I'm :+1: on this.","created_at":"2018-09-12T19:05:46Z","updated_at":"2018-09-12T19:05:46Z","html_url":"https://github.com/UCLALibrary/californica/pull/137#discussion_r217153251","pull_request_url":"https://api.github.com/repos/UCLALibrary/californica/pulls/137","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/UCLALibrary/californica/pulls/comments/217153251"},"html":{"href":"https://github.com/UCLALibrary/californica/pull/137#discussion_r217153251"},"pull_request":{"href":"https://api.github.com/repos/UCLALibrary/californica/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/UCLALibrary/californica/pulls/137","id":215057462,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDU3NDYy","html_url":"https://github.com/UCLALibrary/californica/pull/137","diff_url":"https://github.com/UCLALibrary/californica/pull/137.diff","patch_url":"https://github.com/UCLALibrary/californica/pull/137.patch","issue_url":"https://api.github.com/repos/UCLALibrary/californica/issues/137","number":137,"state":"open","locked":false,"title":"Added specs for subject field. Story #94","user":{"login":"val99erie","id":298865,"node_id":"MDQ6VXNlcjI5ODg2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/298865?v=4","gravatar_id":"","url":"https://api.github.com/users/val99erie","html_url":"https://github.com/val99erie","followers_url":"https://api.github.com/users/val99erie/followers","following_url":"https://api.github.com/users/val99erie/following{/other_user}","gists_url":"https://api.github.com/users/val99erie/gists{/gist_id}","starred_url":"https://api.github.com/users/val99erie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/val99erie/subscriptions","organizations_url":"https://api.github.com/users/val99erie/orgs","repos_url":"https://api.github.com/users/val99erie/repos","events_url":"https://api.github.com/users/val99erie/events{/privacy}","received_events_url":"https://api.github.com/users/val99erie/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-12T18:39:23Z","updated_at":"2018-09-12T19:05:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"734b28092f01fcdccbd3c2c71c8072bdcf626820","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":992163972,"node_id":"MDU6TGFiZWw5OTIxNjM5NzI=","url":"https://api.github.com/repos/UCLALibrary/californica/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/UCLALibrary/californica/pulls/137/commits","review_comments_url":"https://api.github.com/repos/UCLALibrary/californica/pulls/137/comments","review_comment_url":"https://api.github.com/repos/UCLALibrary/californica/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UCLALibrary/californica/issues/137/comments","statuses_url":"https://api.github.com/repos/UCLALibrary/californica/statuses/bda19c27ca56963b3f47deccf97361112e53a5e1","head":{"label":"UCLALibrary:subj","ref":"subj","sha":"bda19c27ca56963b3f47deccf97361112e53a5e1","user":{"login":"UCLALibrary","id":2214013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQwMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2214013?v=4","gravatar_id":"","url":"https://api.github.com/users/UCLALibrary","html_url":"https://github.com/UCLALibrary","followers_url":"https://api.github.com/users/UCLALibrary/followers","following_url":"https://api.github.com/users/UCLALibrary/following{/other_user}","gists_url":"https://api.github.com/users/UCLALibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/UCLALibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCLALibrary/subscriptions","organizations_url":"https://api.github.com/users/UCLALibrary/orgs","repos_url":"https://api.github.com/users/UCLALibrary/repos","events_url":"https://api.github.com/users/UCLALibrary/events{/privacy}","received_events_url":"https://api.github.com/users/UCLALibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":140747991,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3NDc5OTE=","name":"californica","full_name":"UCLALibrary/californica","owner":{"login":"UCLALibrary","id":2214013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQwMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2214013?v=4","gravatar_id":"","url":"https://api.github.com/users/UCLALibrary","html_url":"https://github.com/UCLALibrary","followers_url":"https://api.github.com/users/UCLALibrary/followers","following_url":"https://api.github.com/users/UCLALibrary/following{/other_user}","gists_url":"https://api.github.com/users/UCLALibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/UCLALibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCLALibrary/subscriptions","organizations_url":"https://api.github.com/users/UCLALibrary/orgs","repos_url":"https://api.github.com/users/UCLALibrary/repos","events_url":"https://api.github.com/users/UCLALibrary/events{/privacy}","received_events_url":"https://api.github.com/users/UCLALibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCLALibrary/californica","description":"A content management samvera app","fork":false,"url":"https://api.github.com/repos/UCLALibrary/californica","forks_url":"https://api.github.com/repos/UCLALibrary/californica/forks","keys_url":"https://api.github.com/repos/UCLALibrary/californica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCLALibrary/californica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCLALibrary/californica/teams","hooks_url":"https://api.github.com/repos/UCLALibrary/californica/hooks","issue_events_url":"https://api.github.com/repos/UCLALibrary/californica/issues/events{/number}","events_url":"https://api.github.com/repos/UCLALibrary/californica/events","assignees_url":"https://api.github.com/repos/UCLALibrary/californica/assignees{/user}","branches_url":"https://api.github.com/repos/UCLALibrary/californica/branches{/branch}","tags_url":"https://api.github.com/repos/UCLALibrary/californica/tags","blobs_url":"https://api.github.com/repos/UCLALibrary/californica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCLALibrary/californica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCLALibrary/californica/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCLALibrary/californica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCLALibrary/californica/statuses/{sha}","languages_url":"https://api.github.com/repos/UCLALibrary/californica/languages","stargazers_url":"https://api.github.com/repos/UCLALibrary/californica/stargazers","contributors_url":"https://api.github.com/repos/UCLALibrary/californica/contributors","subscribers_url":"https://api.github.com/repos/UCLALibrary/californica/subscribers","subscription_url":"https://api.github.com/repos/UCLALibrary/californica/subscription","commits_url":"https://api.github.com/repos/UCLALibrary/californica/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCLALibrary/californica/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCLALibrary/californica/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCLALibrary/californica/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCLALibrary/californica/contents/{+path}","compare_url":"https://api.github.com/repos/UCLALibrary/californica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCLALibrary/californica/merges","archive_url":"https://api.github.com/repos/UCLALibrary/californica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCLALibrary/californica/downloads","issues_url":"https://api.github.com/repos/UCLALibrary/californica/issues{/number}","pulls_url":"https://api.github.com/repos/UCLALibrary/californica/pulls{/number}","milestones_url":"https://api.github.com/repos/UCLALibrary/californica/milestones{/number}","notifications_url":"https://api.github.com/repos/UCLALibrary/californica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCLALibrary/californica/labels{/name}","releases_url":"https://api.github.com/repos/UCLALibrary/californica/releases{/id}","deployments_url":"https://api.github.com/repos/UCLALibrary/californica/deployments","created_at":"2018-07-12T18:01:16Z","updated_at":"2018-09-12T18:00:48Z","pushed_at":"2018-09-12T18:50:37Z","git_url":"git://github.com/UCLALibrary/californica.git","ssh_url":"git@github.com:UCLALibrary/californica.git","clone_url":"https://github.com/UCLALibrary/californica.git","svn_url":"https://github.com/UCLALibrary/californica","homepage":null,"size":1050,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":32,"watchers":2,"default_branch":"master"}},"base":{"label":"UCLALibrary:master","ref":"master","sha":"54a287302bcbd48d4f575f099b622181ac0572a8","user":{"login":"UCLALibrary","id":2214013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQwMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2214013?v=4","gravatar_id":"","url":"https://api.github.com/users/UCLALibrary","html_url":"https://github.com/UCLALibrary","followers_url":"https://api.github.com/users/UCLALibrary/followers","following_url":"https://api.github.com/users/UCLALibrary/following{/other_user}","gists_url":"https://api.github.com/users/UCLALibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/UCLALibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCLALibrary/subscriptions","organizations_url":"https://api.github.com/users/UCLALibrary/orgs","repos_url":"https://api.github.com/users/UCLALibrary/repos","events_url":"https://api.github.com/users/UCLALibrary/events{/privacy}","received_events_url":"https://api.github.com/users/UCLALibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":140747991,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3NDc5OTE=","name":"californica","full_name":"UCLALibrary/californica","owner":{"login":"UCLALibrary","id":2214013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQwMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2214013?v=4","gravatar_id":"","url":"https://api.github.com/users/UCLALibrary","html_url":"https://github.com/UCLALibrary","followers_url":"https://api.github.com/users/UCLALibrary/followers","following_url":"https://api.github.com/users/UCLALibrary/following{/other_user}","gists_url":"https://api.github.com/users/UCLALibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/UCLALibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCLALibrary/subscriptions","organizations_url":"https://api.github.com/users/UCLALibrary/orgs","repos_url":"https://api.github.com/users/UCLALibrary/repos","events_url":"https://api.github.com/users/UCLALibrary/events{/privacy}","received_events_url":"https://api.github.com/users/UCLALibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCLALibrary/californica","description":"A content management samvera app","fork":false,"url":"https://api.github.com/repos/UCLALibrary/californica","forks_url":"https://api.github.com/repos/UCLALibrary/californica/forks","keys_url":"https://api.github.com/repos/UCLALibrary/californica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCLALibrary/californica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCLALibrary/californica/teams","hooks_url":"https://api.github.com/repos/UCLALibrary/californica/hooks","issue_events_url":"https://api.github.com/repos/UCLALibrary/californica/issues/events{/number}","events_url":"https://api.github.com/repos/UCLALibrary/californica/events","assignees_url":"https://api.github.com/repos/UCLALibrary/californica/assignees{/user}","branches_url":"https://api.github.com/repos/UCLALibrary/californica/branches{/branch}","tags_url":"https://api.github.com/repos/UCLALibrary/californica/tags","blobs_url":"https://api.github.com/repos/UCLALibrary/californica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCLALibrary/californica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCLALibrary/californica/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCLALibrary/californica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCLALibrary/californica/statuses/{sha}","languages_url":"https://api.github.com/repos/UCLALibrary/californica/languages","stargazers_url":"https://api.github.com/repos/UCLALibrary/californica/stargazers","contributors_url":"https://api.github.com/repos/UCLALibrary/californica/contributors","subscribers_url":"https://api.github.com/repos/UCLALibrary/californica/subscribers","subscription_url":"https://api.github.com/repos/UCLALibrary/californica/subscription","commits_url":"https://api.github.com/repos/UCLALibrary/californica/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCLALibrary/californica/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCLALibrary/californica/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCLALibrary/californica/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCLALibrary/californica/contents/{+path}","compare_url":"https://api.github.com/repos/UCLALibrary/californica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCLALibrary/californica/merges","archive_url":"https://api.github.com/repos/UCLALibrary/californica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCLALibrary/californica/downloads","issues_url":"https://api.github.com/repos/UCLALibrary/californica/issues{/number}","pulls_url":"https://api.github.com/repos/UCLALibrary/californica/pulls{/number}","milestones_url":"https://api.github.com/repos/UCLALibrary/californica/milestones{/number}","notifications_url":"https://api.github.com/repos/UCLALibrary/californica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCLALibrary/californica/labels{/name}","releases_url":"https://api.github.com/repos/UCLALibrary/californica/releases{/id}","deployments_url":"https://api.github.com/repos/UCLALibrary/californica/deployments","created_at":"2018-07-12T18:01:16Z","updated_at":"2018-09-12T18:00:48Z","pushed_at":"2018-09-12T18:50:37Z","git_url":"git://github.com/UCLALibrary/californica.git","ssh_url":"git@github.com:UCLALibrary/californica.git","clone_url":"https://github.com/UCLALibrary/californica.git","svn_url":"https://github.com/UCLALibrary/californica","homepage":null,"size":1050,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":32,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UCLALibrary/californica/pulls/137"},"html":{"href":"https://github.com/UCLALibrary/californica/pull/137"},"issue":{"href":"https://api.github.com/repos/UCLALibrary/californica/issues/137"},"comments":{"href":"https://api.github.com/repos/UCLALibrary/californica/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/UCLALibrary/californica/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/UCLALibrary/californica/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UCLALibrary/californica/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/UCLALibrary/californica/statuses/bda19c27ca56963b3f47deccf97361112e53a5e1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"no-reply"}}