{"action":"created","issue":{"url":"https://api.github.com/repos/flatpak/flatpak/issues/2010","repository_url":"https://api.github.com/repos/flatpak/flatpak","labels_url":"https://api.github.com/repos/flatpak/flatpak/issues/2010/labels{/name}","comments_url":"https://api.github.com/repos/flatpak/flatpak/issues/2010/comments","events_url":"https://api.github.com/repos/flatpak/flatpak/issues/2010/events","html_url":"https://github.com/flatpak/flatpak/pull/2010","id":353796544,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzQ5Njgx","number":2010,"title":"Fix hang in system-herlpe::DeplayAppstream for OCI","user":{"login":"alexlarsson","id":990736,"node_id":"MDQ6VXNlcjk5MDczNg==","avatar_url":"https://avatars2.githubusercontent.com/u/990736?v=4","gravatar_id":"","url":"https://api.github.com/users/alexlarsson","html_url":"https://github.com/alexlarsson","followers_url":"https://api.github.com/users/alexlarsson/followers","following_url":"https://api.github.com/users/alexlarsson/following{/other_user}","gists_url":"https://api.github.com/users/alexlarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlarsson/subscriptions","organizations_url":"https://api.github.com/users/alexlarsson/orgs","repos_url":"https://api.github.com/users/alexlarsson/repos","events_url":"https://api.github.com/users/alexlarsson/events{/privacy}","received_events_url":"https://api.github.com/users/alexlarsson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-24T14:02:08Z","updated_at":"2018-08-26T13:34:07Z","closed_at":"2018-08-26T09:29:43Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/flatpak/flatpak/pulls/2010","html_url":"https://github.com/flatpak/flatpak/pull/2010","diff_url":"https://github.com/flatpak/flatpak/pull/2010.diff","patch_url":"https://github.com/flatpak/flatpak/pull/2010.patch"},"body":"When deploying the appstream for an OCI remote we actually pull the\r\nhttp remote. This triggers some libsoup code that recurses the default\r\nmainloop. As this happens of the main thread we can get the response\r\nback on the wrong thread leading causing us to never send the reply\r\nback, hanging the call."},"comment":{"url":"https://api.github.com/repos/flatpak/flatpak/issues/comments/416039350","html_url":"https://github.com/flatpak/flatpak/pull/2010#issuecomment-416039350","issue_url":"https://api.github.com/repos/flatpak/flatpak/issues/2010","id":416039350,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjAzOTM1MA==","user":{"login":"owtaylor","id":1145674,"node_id":"MDQ6VXNlcjExNDU2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1145674?v=4","gravatar_id":"","url":"https://api.github.com/users/owtaylor","html_url":"https://github.com/owtaylor","followers_url":"https://api.github.com/users/owtaylor/followers","following_url":"https://api.github.com/users/owtaylor/following{/other_user}","gists_url":"https://api.github.com/users/owtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/owtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owtaylor/subscriptions","organizations_url":"https://api.github.com/users/owtaylor/orgs","repos_url":"https://api.github.com/users/owtaylor/repos","events_url":"https://api.github.com/users/owtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/owtaylor/received_events","type":"User","site_admin":false},"created_at":"2018-08-26T13:34:07Z","updated_at":"2018-08-26T13:34:07Z","author_association":"CONTRIBUTOR","body":"Generally, the diagnosis seems plausible to me. The code that recurses the default main loop is in Flatpak (`flatpak_*_http_uri`) not inside libsoup. If HTTP downloads can be triggered off the public API (I think so) and if the public API is meant to be thread safe (I think so), then I wonder if we should fix this inside `flatpak-http-utils.c` and not expose such a trap to API users?"}}
{"actor":{"display_login":"owtaylor"}}