{"action":"created","comment":{"url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/comments/174827822","pull_request_review_id":104243275,"id":174827822,"diff_hunk":"@@ -37,7 +37,7 @@ type goMetadata struct {\n func readFiles(bctx build.Context, inputs []string) ([]*goMetadata, error) {\n \toutputs := []*goMetadata{}\n \tfor _, input := range inputs {\n-\t\tif m, err := readGoMetadata(bctx, input, true); err != nil {\n+\t\tif m, err := readGoMetadata(bctx, abs(input), true); err != nil {","path":"go/tools/builders/filter.go","position":5,"original_position":5,"commit_id":"b426e07c1bda78f9c67d50cdd11ad2a93d34264c","original_commit_id":"b426e07c1bda78f9c67d50cdd11ad2a93d34264c","user":{"login":"jayconrod","id":164791,"avatar_url":"https://avatars3.githubusercontent.com/u/164791?v=4","gravatar_id":"","url":"https://api.github.com/users/jayconrod","html_url":"https://github.com/jayconrod","followers_url":"https://api.github.com/users/jayconrod/followers","following_url":"https://api.github.com/users/jayconrod/following{/other_user}","gists_url":"https://api.github.com/users/jayconrod/gists{/gist_id}","starred_url":"https://api.github.com/users/jayconrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayconrod/subscriptions","organizations_url":"https://api.github.com/users/jayconrod/orgs","repos_url":"https://api.github.com/users/jayconrod/repos","events_url":"https://api.github.com/users/jayconrod/events{/privacy}","received_events_url":"https://api.github.com/users/jayconrod/received_events","type":"User","site_admin":false},"body":"Looks like tests are failing because `//go/builders:filter_test` does not include env.go, which it now needs.","created_at":"2018-03-15T15:35:45Z","updated_at":"2018-03-15T15:37:26Z","html_url":"https://github.com/bazelbuild/rules_go/pull/1382#discussion_r174827822","pull_request_url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1382","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/rules_go/pulls/comments/174827822"},"html":{"href":"https://github.com/bazelbuild/rules_go/pull/1382#discussion_r174827822"},"pull_request":{"href":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1382"}}},"pull_request":{"url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1382","id":175132247,"html_url":"https://github.com/bazelbuild/rules_go/pull/1382","diff_url":"https://github.com/bazelbuild/rules_go/pull/1382.diff","patch_url":"https://github.com/bazelbuild/rules_go/pull/1382.patch","issue_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1382","number":1382,"state":"open","locked":false,"title":"Handle Windows long file names in a few more places.","user":{"login":"pmuetschard","id":13356324,"avatar_url":"https://avatars3.githubusercontent.com/u/13356324?v=4","gravatar_id":"","url":"https://api.github.com/users/pmuetschard","html_url":"https://github.com/pmuetschard","followers_url":"https://api.github.com/users/pmuetschard/followers","following_url":"https://api.github.com/users/pmuetschard/following{/other_user}","gists_url":"https://api.github.com/users/pmuetschard/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuetschard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuetschard/subscriptions","organizations_url":"https://api.github.com/users/pmuetschard/orgs","repos_url":"https://api.github.com/users/pmuetschard/repos","events_url":"https://api.github.com/users/pmuetschard/events{/privacy}","received_events_url":"https://api.github.com/users/pmuetschard/received_events","type":"User","site_admin":false},"body":"Go can handle long file names on Windows if they are not relative. This change makes some file paths absolute so that go can handle them. See https://github.com/golang/go/blob/b86e76681366447798c94abb959bb60875bcc856/src/os/path_windows.go#L133.\r\n\r\nThe `protoc` binary cannot handle long filenames either, so this change generates go protos in the temporary folder and then moves the contents into place.","created_at":"2018-03-15T02:17:48Z","updated_at":"2018-03-15T15:37:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bca394daff2ea3df3753df30530f4622758484f1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ianthehat","id":858832,"avatar_url":"https://avatars0.githubusercontent.com/u/858832?v=4","gravatar_id":"","url":"https://api.github.com/users/ianthehat","html_url":"https://github.com/ianthehat","followers_url":"https://api.github.com/users/ianthehat/followers","following_url":"https://api.github.com/users/ianthehat/following{/other_user}","gists_url":"https://api.github.com/users/ianthehat/gists{/gist_id}","starred_url":"https://api.github.com/users/ianthehat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianthehat/subscriptions","organizations_url":"https://api.github.com/users/ianthehat/orgs","repos_url":"https://api.github.com/users/ianthehat/repos","events_url":"https://api.github.com/users/ianthehat/events{/privacy}","received_events_url":"https://api.github.com/users/ianthehat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":342134177,"url":"https://api.github.com/repos/bazelbuild/rules_go/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1382/commits","review_comments_url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1382/comments","review_comment_url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1382/comments","statuses_url":"https://api.github.com/repos/bazelbuild/rules_go/statuses/b426e07c1bda78f9c67d50cdd11ad2a93d34264c","head":{"label":"pmuetschard:long","ref":"long","sha":"b426e07c1bda78f9c67d50cdd11ad2a93d34264c","user":{"login":"pmuetschard","id":13356324,"avatar_url":"https://avatars3.githubusercontent.com/u/13356324?v=4","gravatar_id":"","url":"https://api.github.com/users/pmuetschard","html_url":"https://github.com/pmuetschard","followers_url":"https://api.github.com/users/pmuetschard/followers","following_url":"https://api.github.com/users/pmuetschard/following{/other_user}","gists_url":"https://api.github.com/users/pmuetschard/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuetschard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuetschard/subscriptions","organizations_url":"https://api.github.com/users/pmuetschard/orgs","repos_url":"https://api.github.com/users/pmuetschard/repos","events_url":"https://api.github.com/users/pmuetschard/events{/privacy}","received_events_url":"https://api.github.com/users/pmuetschard/received_events","type":"User","site_admin":false},"repo":{"id":114986393,"name":"rules_go","full_name":"pmuetschard/rules_go","owner":{"login":"pmuetschard","id":13356324,"avatar_url":"https://avatars3.githubusercontent.com/u/13356324?v=4","gravatar_id":"","url":"https://api.github.com/users/pmuetschard","html_url":"https://github.com/pmuetschard","followers_url":"https://api.github.com/users/pmuetschard/followers","following_url":"https://api.github.com/users/pmuetschard/following{/other_user}","gists_url":"https://api.github.com/users/pmuetschard/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuetschard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuetschard/subscriptions","organizations_url":"https://api.github.com/users/pmuetschard/orgs","repos_url":"https://api.github.com/users/pmuetschard/repos","events_url":"https://api.github.com/users/pmuetschard/events{/privacy}","received_events_url":"https://api.github.com/users/pmuetschard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmuetschard/rules_go","description":"Go rules for Bazel","fork":true,"url":"https://api.github.com/repos/pmuetschard/rules_go","forks_url":"https://api.github.com/repos/pmuetschard/rules_go/forks","keys_url":"https://api.github.com/repos/pmuetschard/rules_go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmuetschard/rules_go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmuetschard/rules_go/teams","hooks_url":"https://api.github.com/repos/pmuetschard/rules_go/hooks","issue_events_url":"https://api.github.com/repos/pmuetschard/rules_go/issues/events{/number}","events_url":"https://api.github.com/repos/pmuetschard/rules_go/events","assignees_url":"https://api.github.com/repos/pmuetschard/rules_go/assignees{/user}","branches_url":"https://api.github.com/repos/pmuetschard/rules_go/branches{/branch}","tags_url":"https://api.github.com/repos/pmuetschard/rules_go/tags","blobs_url":"https://api.github.com/repos/pmuetschard/rules_go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmuetschard/rules_go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmuetschard/rules_go/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmuetschard/rules_go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmuetschard/rules_go/statuses/{sha}","languages_url":"https://api.github.com/repos/pmuetschard/rules_go/languages","stargazers_url":"https://api.github.com/repos/pmuetschard/rules_go/stargazers","contributors_url":"https://api.github.com/repos/pmuetschard/rules_go/contributors","subscribers_url":"https://api.github.com/repos/pmuetschard/rules_go/subscribers","subscription_url":"https://api.github.com/repos/pmuetschard/rules_go/subscription","commits_url":"https://api.github.com/repos/pmuetschard/rules_go/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmuetschard/rules_go/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmuetschard/rules_go/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmuetschard/rules_go/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmuetschard/rules_go/contents/{+path}","compare_url":"https://api.github.com/repos/pmuetschard/rules_go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmuetschard/rules_go/merges","archive_url":"https://api.github.com/repos/pmuetschard/rules_go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmuetschard/rules_go/downloads","issues_url":"https://api.github.com/repos/pmuetschard/rules_go/issues{/number}","pulls_url":"https://api.github.com/repos/pmuetschard/rules_go/pulls{/number}","milestones_url":"https://api.github.com/repos/pmuetschard/rules_go/milestones{/number}","notifications_url":"https://api.github.com/repos/pmuetschard/rules_go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmuetschard/rules_go/labels{/name}","releases_url":"https://api.github.com/repos/pmuetschard/rules_go/releases{/id}","deployments_url":"https://api.github.com/repos/pmuetschard/rules_go/deployments","created_at":"2017-12-21T09:14:22Z","updated_at":"2017-12-21T09:14:24Z","pushed_at":"2018-03-15T02:20:20Z","git_url":"git://github.com/pmuetschard/rules_go.git","ssh_url":"git@github.com:pmuetschard/rules_go.git","clone_url":"https://github.com/pmuetschard/rules_go.git","svn_url":"https://github.com/pmuetschard/rules_go","homepage":null,"size":2164,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazelbuild:master","ref":"master","sha":"67f44035d84a352cffb9465159e199066ecb814c","user":{"login":"bazelbuild","id":11684617,"avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":53954979,"name":"rules_go","full_name":"bazelbuild/rules_go","owner":{"login":"bazelbuild","id":11684617,"avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazelbuild/rules_go","description":"Go rules for Bazel","fork":false,"url":"https://api.github.com/repos/bazelbuild/rules_go","forks_url":"https://api.github.com/repos/bazelbuild/rules_go/forks","keys_url":"https://api.github.com/repos/bazelbuild/rules_go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazelbuild/rules_go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazelbuild/rules_go/teams","hooks_url":"https://api.github.com/repos/bazelbuild/rules_go/hooks","issue_events_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/events{/number}","events_url":"https://api.github.com/repos/bazelbuild/rules_go/events","assignees_url":"https://api.github.com/repos/bazelbuild/rules_go/assignees{/user}","branches_url":"https://api.github.com/repos/bazelbuild/rules_go/branches{/branch}","tags_url":"https://api.github.com/repos/bazelbuild/rules_go/tags","blobs_url":"https://api.github.com/repos/bazelbuild/rules_go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazelbuild/rules_go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazelbuild/rules_go/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazelbuild/rules_go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazelbuild/rules_go/statuses/{sha}","languages_url":"https://api.github.com/repos/bazelbuild/rules_go/languages","stargazers_url":"https://api.github.com/repos/bazelbuild/rules_go/stargazers","contributors_url":"https://api.github.com/repos/bazelbuild/rules_go/contributors","subscribers_url":"https://api.github.com/repos/bazelbuild/rules_go/subscribers","subscription_url":"https://api.github.com/repos/bazelbuild/rules_go/subscription","commits_url":"https://api.github.com/repos/bazelbuild/rules_go/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazelbuild/rules_go/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazelbuild/rules_go/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazelbuild/rules_go/contents/{+path}","compare_url":"https://api.github.com/repos/bazelbuild/rules_go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazelbuild/rules_go/merges","archive_url":"https://api.github.com/repos/bazelbuild/rules_go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazelbuild/rules_go/downloads","issues_url":"https://api.github.com/repos/bazelbuild/rules_go/issues{/number}","pulls_url":"https://api.github.com/repos/bazelbuild/rules_go/pulls{/number}","milestones_url":"https://api.github.com/repos/bazelbuild/rules_go/milestones{/number}","notifications_url":"https://api.github.com/repos/bazelbuild/rules_go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazelbuild/rules_go/labels{/name}","releases_url":"https://api.github.com/repos/bazelbuild/rules_go/releases{/id}","deployments_url":"https://api.github.com/repos/bazelbuild/rules_go/deployments","created_at":"2016-03-15T15:15:14Z","updated_at":"2018-03-15T02:13:31Z","pushed_at":"2018-03-15T13:20:27Z","git_url":"git://github.com/bazelbuild/rules_go.git","ssh_url":"git@github.com:bazelbuild/rules_go.git","clone_url":"https://github.com/bazelbuild/rules_go.git","svn_url":"https://github.com/bazelbuild/rules_go","homepage":null,"size":2149,"stargazers_count":233,"watchers_count":233,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":167,"open_issues":95,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1382"},"html":{"href":"https://github.com/bazelbuild/rules_go/pull/1382"},"issue":{"href":"https://api.github.com/repos/bazelbuild/rules_go/issues/1382"},"comments":{"href":"https://api.github.com/repos/bazelbuild/rules_go/issues/1382/comments"},"review_comments":{"href":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1382/comments"},"review_comment":{"href":"https://api.github.com/repos/bazelbuild/rules_go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1382/commits"},"statuses":{"href":"https://api.github.com/repos/bazelbuild/rules_go/statuses/b426e07c1bda78f9c67d50cdd11ad2a93d34264c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jayconrod"}}