{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/236711991","pull_request_review_id":178842550,"id":236711991,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjcxMTk5MQ==","diff_hunk":"@@ -854,7 +854,7 @@ sub load_inst_tests {\n             loadtest \"installation/sles4sap_product_installation_mode\";\n         }\n         # Kubic doesn't have a partitioning step\n-        if (!is_caasp('kubic')) {\n+        unless (is_caasp) {","path":"lib/main_common.pm","position":20,"original_position":20,"commit_id":"fa0713310e4fa77ff9647deb803e86f393382b17","original_commit_id":"fa0713310e4fa77ff9647deb803e86f393382b17","user":{"login":"kravciak","id":538604,"node_id":"MDQ6VXNlcjUzODYwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/538604?v=4","gravatar_id":"","url":"https://api.github.com/users/kravciak","html_url":"https://github.com/kravciak","followers_url":"https://api.github.com/users/kravciak/followers","following_url":"https://api.github.com/users/kravciak/following{/other_user}","gists_url":"https://api.github.com/users/kravciak/gists{/gist_id}","starred_url":"https://api.github.com/users/kravciak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kravciak/subscriptions","organizations_url":"https://api.github.com/users/kravciak/orgs","repos_url":"https://api.github.com/users/kravciak/repos","events_url":"https://api.github.com/users/kravciak/events{/privacy}","received_events_url":"https://api.github.com/users/kravciak/received_events","type":"User","site_admin":false},"body":"is_caasp returns true for both caasp & kubic - kubic is just filter parameter\r\n```perl\r\nis_caasp = is_caasp('caasp') || is_caasp('kubic')\r\n```","created_at":"2018-11-27T15:24:29Z","updated_at":"2018-11-27T15:24:29Z","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6293#discussion_r236711991","pull_request_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6293","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/236711991"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6293#discussion_r236711991"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6293"}},"in_reply_to_id":236711235},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6293","id":233643345,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjQzMzQ1","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6293","diff_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6293.diff","patch_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6293.patch","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6293","number":6293,"state":"open","locked":false,"title":"CaaSP 4.0 fixes after rebase on SLE 15","user":{"login":"kravciak","id":538604,"node_id":"MDQ6VXNlcjUzODYwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/538604?v=4","gravatar_id":"","url":"https://api.github.com/users/kravciak","html_url":"https://github.com/kravciak","followers_url":"https://api.github.com/users/kravciak/followers","following_url":"https://api.github.com/users/kravciak/following{/other_user}","gists_url":"https://api.github.com/users/kravciak/gists{/gist_id}","starred_url":"https://api.github.com/users/kravciak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kravciak/subscriptions","organizations_url":"https://api.github.com/users/kravciak/orgs","repos_url":"https://api.github.com/users/kravciak/repos","events_url":"https://api.github.com/users/kravciak/events{/privacy}","received_events_url":"https://api.github.com/users/kravciak/received_events","type":"User","site_admin":false},"body":"Needles: https://gitlab.suse.de/openqa/os-autoinst-needles-sles/merge_requests/1013\r\n\r\nLocal runs:\r\n - http://dhcp126.suse.cz/tests/11554 - QAM cluster\r\n - http://dhcp126.suse.cz/tests/11583 - QA cluster\r\n - http://dhcp126.suse.cz/tests/11549 - MicroOS-10G-disk\r\n - http://dhcp126.suse.cz/tests/11547 - MicroOS-rcshell","created_at":"2018-11-26T17:46:21Z","updated_at":"2018-11-27T15:24:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"330946ec14e7832d51f0379c77b3b3da6e6fc888","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6293/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6293/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6293/comments","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/fa0713310e4fa77ff9647deb803e86f393382b17","head":{"label":"kravciak:caasp4_microos","ref":"caasp4_microos","sha":"fa0713310e4fa77ff9647deb803e86f393382b17","user":{"login":"kravciak","id":538604,"node_id":"MDQ6VXNlcjUzODYwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/538604?v=4","gravatar_id":"","url":"https://api.github.com/users/kravciak","html_url":"https://github.com/kravciak","followers_url":"https://api.github.com/users/kravciak/followers","following_url":"https://api.github.com/users/kravciak/following{/other_user}","gists_url":"https://api.github.com/users/kravciak/gists{/gist_id}","starred_url":"https://api.github.com/users/kravciak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kravciak/subscriptions","organizations_url":"https://api.github.com/users/kravciak/orgs","repos_url":"https://api.github.com/users/kravciak/repos","events_url":"https://api.github.com/users/kravciak/events{/privacy}","received_events_url":"https://api.github.com/users/kravciak/received_events","type":"User","site_admin":false},"repo":{"id":45985015,"node_id":"MDEwOlJlcG9zaXRvcnk0NTk4NTAxNQ==","name":"openqa-tests","full_name":"kravciak/openqa-tests","private":false,"owner":{"login":"kravciak","id":538604,"node_id":"MDQ6VXNlcjUzODYwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/538604?v=4","gravatar_id":"","url":"https://api.github.com/users/kravciak","html_url":"https://github.com/kravciak","followers_url":"https://api.github.com/users/kravciak/followers","following_url":"https://api.github.com/users/kravciak/following{/other_user}","gists_url":"https://api.github.com/users/kravciak/gists{/gist_id}","starred_url":"https://api.github.com/users/kravciak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kravciak/subscriptions","organizations_url":"https://api.github.com/users/kravciak/orgs","repos_url":"https://api.github.com/users/kravciak/repos","events_url":"https://api.github.com/users/kravciak/events{/privacy}","received_events_url":"https://api.github.com/users/kravciak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kravciak/openqa-tests","description":"os-autoinst test cases for openSUSE","fork":true,"url":"https://api.github.com/repos/kravciak/openqa-tests","forks_url":"https://api.github.com/repos/kravciak/openqa-tests/forks","keys_url":"https://api.github.com/repos/kravciak/openqa-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kravciak/openqa-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kravciak/openqa-tests/teams","hooks_url":"https://api.github.com/repos/kravciak/openqa-tests/hooks","issue_events_url":"https://api.github.com/repos/kravciak/openqa-tests/issues/events{/number}","events_url":"https://api.github.com/repos/kravciak/openqa-tests/events","assignees_url":"https://api.github.com/repos/kravciak/openqa-tests/assignees{/user}","branches_url":"https://api.github.com/repos/kravciak/openqa-tests/branches{/branch}","tags_url":"https://api.github.com/repos/kravciak/openqa-tests/tags","blobs_url":"https://api.github.com/repos/kravciak/openqa-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kravciak/openqa-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kravciak/openqa-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/kravciak/openqa-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kravciak/openqa-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/kravciak/openqa-tests/languages","stargazers_url":"https://api.github.com/repos/kravciak/openqa-tests/stargazers","contributors_url":"https://api.github.com/repos/kravciak/openqa-tests/contributors","subscribers_url":"https://api.github.com/repos/kravciak/openqa-tests/subscribers","subscription_url":"https://api.github.com/repos/kravciak/openqa-tests/subscription","commits_url":"https://api.github.com/repos/kravciak/openqa-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/kravciak/openqa-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/kravciak/openqa-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/kravciak/openqa-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/kravciak/openqa-tests/contents/{+path}","compare_url":"https://api.github.com/repos/kravciak/openqa-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kravciak/openqa-tests/merges","archive_url":"https://api.github.com/repos/kravciak/openqa-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kravciak/openqa-tests/downloads","issues_url":"https://api.github.com/repos/kravciak/openqa-tests/issues{/number}","pulls_url":"https://api.github.com/repos/kravciak/openqa-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/kravciak/openqa-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/kravciak/openqa-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kravciak/openqa-tests/labels{/name}","releases_url":"https://api.github.com/repos/kravciak/openqa-tests/releases{/id}","deployments_url":"https://api.github.com/repos/kravciak/openqa-tests/deployments","created_at":"2015-11-11T14:01:04Z","updated_at":"2018-05-21T12:13:16Z","pushed_at":"2018-11-27T15:16:58Z","git_url":"git://github.com/kravciak/openqa-tests.git","ssh_url":"git@github.com:kravciak/openqa-tests.git","clone_url":"https://github.com/kravciak/openqa-tests.git","svn_url":"https://github.com/kravciak/openqa-tests","homepage":null,"size":104538,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"79f30d0a346c376ee491856686b4da1ca011d228","user":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":17630288,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYzMDI4OA==","name":"os-autoinst-distri-opensuse","full_name":"os-autoinst/os-autoinst-distri-opensuse","private":false,"owner":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":false,"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/deployments","created_at":"2014-03-11T12:54:42Z","updated_at":"2018-11-27T14:18:27Z","pushed_at":"2018-11-27T15:23:53Z","git_url":"git://github.com/os-autoinst/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:os-autoinst/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":98786,"stargazers_count":34,"watchers_count":34,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":62,"license":null,"forks":155,"open_issues":62,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6293"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6293"},"issue":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6293"},"comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6293/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6293/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6293/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/fa0713310e4fa77ff9647deb803e86f393382b17"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kravciak"}}