{"action":"created","issue":{"url":"https://api.github.com/repos/snapcore/snapd/issues/5718","repository_url":"https://api.github.com/repos/snapcore/snapd","labels_url":"https://api.github.com/repos/snapcore/snapd/issues/5718/labels{/name}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/5718/comments","events_url":"https://api.github.com/repos/snapcore/snapd/issues/5718/events","html_url":"https://github.com/snapcore/snapd/pull/5718","id":353717697,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjkyMzA3","number":5718,"title":"overlord/ifacestate: remove \"old-conn\" from connect/undo connect handlers","user":{"login":"stolowski","id":168604,"node_id":"MDQ6VXNlcjE2ODYwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/168604?v=4","gravatar_id":"","url":"https://api.github.com/users/stolowski","html_url":"https://github.com/stolowski","followers_url":"https://api.github.com/users/stolowski/followers","following_url":"https://api.github.com/users/stolowski/following{/other_user}","gists_url":"https://api.github.com/users/stolowski/gists{/gist_id}","starred_url":"https://api.github.com/users/stolowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stolowski/subscriptions","organizations_url":"https://api.github.com/users/stolowski/orgs","repos_url":"https://api.github.com/users/stolowski/repos","events_url":"https://api.github.com/users/stolowski/events{/privacy}","received_events_url":"https://api.github.com/users/stolowski/received_events","type":"User","site_admin":false},"labels":[{"id":912422407,"node_id":"MDU6TGFiZWw5MTI0MjI0MDc=","url":"https://api.github.com/repos/snapcore/snapd/labels/Simple","name":"Simple","color":"90ed34","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-24T09:50:35Z","updated_at":"2018-08-31T15:36:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/5718","html_url":"https://github.com/snapcore/snapd/pull/5718","diff_url":"https://github.com/snapcore/snapd/pull/5718.diff","patch_url":"https://github.com/snapcore/snapd/pull/5718.patch"},"body":"Remove \"old-conn\" attribute from connect and its undo handler.\r\nIt was initially implemented to support re-connecting over existing connection, in which case undo would restore the previous state of the connection. The idea of re-connecting existing connection was however dropped and re-connecting is explicitly prevented in `ifacestate.Connect(..)` method.\r\n\r\nNote, \"old-conn\" is also used in disconnect/disconnect-undo handlers, but it's required there."},"comment":{"url":"https://api.github.com/repos/snapcore/snapd/issues/comments/417702633","html_url":"https://github.com/snapcore/snapd/pull/5718#issuecomment-417702633","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/5718","id":417702633,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzcwMjYzMw==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T15:36:17Z","updated_at":"2018-08-31T15:36:17Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/snapcore/snapd/pull/5718?src=pr&el=h1) Report\n> Merging [#5718](https://codecov.io/gh/snapcore/snapd/pull/5718?src=pr&el=desc) into [master](https://codecov.io/gh/snapcore/snapd/commit/d4286ea584b10494679dfd2d610a99e0bc3dca41?src=pr&el=desc) will **increase** coverage by `0.34%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/snapcore/snapd/pull/5718/graphs/tree.svg?width=650&token=T2u6lhEZS6&height=150&src=pr)](https://codecov.io/gh/snapcore/snapd/pull/5718?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #5718      +/-   ##\n==========================================\n+ Coverage   78.98%   79.32%   +0.34%     \n==========================================\n  Files         525      528       +3     \n  Lines       40105    40776     +671     \n==========================================\n+ Hits        31676    32345     +669     \n+ Misses       5856     5852       -4     \n- Partials     2573     2579       +6\n```\n\n\n| [Impacted Files](https://codecov.io/gh/snapcore/snapd/pull/5718?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [overlord/ifacestate/handlers.go](https://codecov.io/gh/snapcore/snapd/pull/5718/diff?src=pr&el=tree#diff-b3ZlcmxvcmQvaWZhY2VzdGF0ZS9oYW5kbGVycy5nbw==) | `64.07% <100%> (+0.49%)` | :arrow_up: |\n| [httputil/logger.go](https://codecov.io/gh/snapcore/snapd/pull/5718/diff?src=pr&el=tree#diff-aHR0cHV0aWwvbG9nZ2VyLmdv) | `77.27% <0%> (-2.28%)` | :arrow_down: |\n| [overlord/hookstate/hookmgr.go](https://codecov.io/gh/snapcore/snapd/pull/5718/diff?src=pr&el=tree#diff-b3ZlcmxvcmQvaG9va3N0YXRlL2hvb2ttZ3IuZ28=) | `73.55% <0%> (-0.97%)` | :arrow_down: |\n| [image/image.go](https://codecov.io/gh/snapcore/snapd/pull/5718/diff?src=pr&el=tree#diff-aW1hZ2UvaW1hZ2UuZ28=) | `71.42% <0%> (-0.44%)` | :arrow_down: |\n| [httputil/client.go](https://codecov.io/gh/snapcore/snapd/pull/5718/diff?src=pr&el=tree#diff-aHR0cHV0aWwvY2xpZW50Lmdv) | `100% <0%> (ø)` | |\n| [cmd/snap/cmd\\_version\\_linux.go](https://codecov.io/gh/snapcore/snapd/pull/5718/diff?src=pr&el=tree#diff-Y21kL3NuYXAvY21kX3ZlcnNpb25fbGludXguZ28=) | `33.33% <0%> (ø)` | |\n| [overlord/configstate/proxyconf/proxy.go](https://codecov.io/gh/snapcore/snapd/pull/5718/diff?src=pr&el=tree#diff-b3ZlcmxvcmQvY29uZmlnc3RhdGUvcHJveHljb25mL3Byb3h5Lmdv) | `75% <0%> (ø)` | |\n| [store/store.go](https://codecov.io/gh/snapcore/snapd/pull/5718/diff?src=pr&el=tree#diff-c3RvcmUvc3RvcmUuZ28=) | `87.9% <0%> (+5.98%)` | :arrow_up: |\n| [overlord/overlord.go](https://codecov.io/gh/snapcore/snapd/pull/5718/diff?src=pr&el=tree#diff-b3ZlcmxvcmQvb3ZlcmxvcmQuZ28=) | `88.07% <0%> (+6.29%)` | :arrow_up: |\n| ... and [1 more](https://codecov.io/gh/snapcore/snapd/pull/5718/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/snapcore/snapd/pull/5718?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/snapcore/snapd/pull/5718?src=pr&el=footer). Last update [d4286ea...e7961f0](https://codecov.io/gh/snapcore/snapd/pull/5718?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}