{"push_id":2407391817,"size":7,"distinct_size":5,"ref":"refs/heads/safe_navigation","head":"7807d807c9e730ef1187afb63f505d681d375487","before":"7b06cf23b0427b93b70132b1d868d4f7d622a298","commits":[{"sha":"1fe5faca833176238f34e5f30018b6f70e752850","author":{"name":"Masataka Pocke Kuwabara","email":"a53a2726e606ab6532a5eca4bb59f9d2f238174d@pocke.me"},"message":"Update the formatter manual\n\nThis pull-request updates `manual/formatters.md`.\nThe manual has some outdated contents, so I updates them.\nIt change two things.\n\nFirstly, add cop name to the outputs. See https://github.com/bbatsov/rubocop/pull/5037\n\nSecondly, update `--format offenses` example. Currently the formatter outputs cop full names (e.g. Metrics/LineLength), but the example does not display full name (e.g. LineLength). So I updated the example.\nAnd I use an real output in a project as the example. Because I'm not sure the all departments of the current examples, and I don't know they still live (probably some cops has been renamed). So I replaced whole the example.","distinct":false,"url":"https://api.github.com/repos/rrosenblum/rubocop/commits/1fe5faca833176238f34e5f30018b6f70e752850"},{"sha":"b885f387575855b178fcc86fe0a7f123cdab04ec","author":{"name":"Koichi ITO","email":"710d7b1878652604e93043a95716c999b31b8376@gmail.com"},"message":"Fix false positive for `Style/EmptyLineAfterGuardClause`\n\nThis PR fixes a false positive for `Style/EmptyLineAfterGuardClause` when\nguard clause is before `rescue` or `ensure`.\n\n## Reproduction code\n\n```ruby\ndef foo\n  begin\n    return another_object if something_different?\n  rescue SomeException\n    bar\n  end\nend\n```\n\nand\n\n```ruby\ndef foo\n  begin\n    return another_object if something_different?\n  ensure\n    bar\n  end\nend\n```\n\n## Expected behavior\n\nNo offenses.\n\n## Actual behavior and Steps to reproduce the problem\n\n```console\n% rubocop /tmp/example.rb --only Style/EmptyLineAfterGuardClause\nInspecting 1 file\nC\n\nOffenses:\n\n/tmp/example.rb:3:5: C: Style/EmptyLineAfterGuardClause: Add empty line\nafter guard clause.\n    return another_object if something_different?\n    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\n1 file inspected, 1 offense detected\n```\n\n## RuboCop version\n\n```console\n% rubocop -V\n0.53.0 (using Parser 2.5.0.4, running on ruby 2.5.0 x86_64-darwin17)\n```\n\nThis PR fixes the above false positive.\nAlso, the condition `node.parent.single_line?` seems to have no effect on\nbehavior, so this PR removes it.","distinct":false,"url":"https://api.github.com/repos/rrosenblum/rubocop/commits/b885f387575855b178fcc86fe0a7f123cdab04ec"},{"sha":"cc6aa6b310ede8d929f248a3b18f40e06a817e68","author":{"name":"Ryan Rosenblum","email":"f91b9d7d7c18293c6f0194ea0ad4f8bfa66b18ef@gmail.com"},"message":"[Fix #5674] Fix auto-correction of EmptyComment when the comment is next to code (#5676)","distinct":true,"url":"https://api.github.com/repos/rrosenblum/rubocop/commits/cc6aa6b310ede8d929f248a3b18f40e06a817e68"},{"sha":"7769691899baf50ab192d9fdcc9668d4c25762fc","author":{"name":"Masataka Pocke Kuwabara","email":"a53a2726e606ab6532a5eca4bb59f9d2f238174d@pocke.me"},"message":"[Fix #5670] Suggest valid memoized instance variable for bang method\n\nSee #5670 and #5648","distinct":true,"url":"https://api.github.com/repos/rrosenblum/rubocop/commits/7769691899baf50ab192d9fdcc9668d4c25762fc"},{"sha":"b247cf92e0698733d672c1864de4cb91c078b67d","author":{"name":"Masataka Pocke Kuwabara","email":"81733ef6e5f775c1eff0ddb6f90229d020d8f526@gmail.com"},"message":"[Fix #5436] Allow empty kwrest args in UncommunicativeName cops (#5681)\n\nFollow up this comment https://github.com/bbatsov/rubocop/issues/5436#issuecomment-372063395\r\n\r\nSee also  https://github.com/bbatsov/rubocop/pull/5462","distinct":true,"url":"https://api.github.com/repos/rrosenblum/rubocop/commits/b247cf92e0698733d672c1864de4cb91c078b67d"},{"sha":"19c674bfc46a1ed6abeb12da57c5a99e067025b0","author":{"name":"Joe Faber","email":"d467a6f0b2fb9b7f0fdf17eb6c0743748aa2a49f@secureauth.com"},"message":"[Fix #5683] Fix message for Naming/UncommunicativeXParamName cops","distinct":true,"url":"https://api.github.com/repos/rrosenblum/rubocop/commits/19c674bfc46a1ed6abeb12da57c5a99e067025b0"},{"sha":"7807d807c9e730ef1187afb63f505d681d375487","author":{"name":"Bozhidar Batsov","email":"987316bc8a2ab5061fd5201a36556edc973b1dc2@gmail.com"},"message":"Merge branch 'master' into safe_navigation","distinct":true,"url":"https://api.github.com/repos/rrosenblum/rubocop/commits/7807d807c9e730ef1187afb63f505d681d375487"}]}
{"actor":{"display_login":"bbatsov"}}