{"action":"created","issue":{"url":"https://api.github.com/repos/confluentinc/ksql/issues/1923","repository_url":"https://api.github.com/repos/confluentinc/ksql","labels_url":"https://api.github.com/repos/confluentinc/ksql/issues/1923/labels{/name}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/1923/comments","events_url":"https://api.github.com/repos/confluentinc/ksql/issues/1923/events","html_url":"https://github.com/confluentinc/ksql/pull/1923","id":362227431,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDAzMjY2","number":1923,"title":"Make it clear what props are default values.","user":{"login":"big-andy-coates","id":8012398,"node_id":"MDQ6VXNlcjgwMTIzOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8012398?v=4","gravatar_id":"","url":"https://api.github.com/users/big-andy-coates","html_url":"https://github.com/big-andy-coates","followers_url":"https://api.github.com/users/big-andy-coates/followers","following_url":"https://api.github.com/users/big-andy-coates/following{/other_user}","gists_url":"https://api.github.com/users/big-andy-coates/gists{/gist_id}","starred_url":"https://api.github.com/users/big-andy-coates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/big-andy-coates/subscriptions","organizations_url":"https://api.github.com/users/big-andy-coates/orgs","repos_url":"https://api.github.com/users/big-andy-coates/repos","events_url":"https://api.github.com/users/big-andy-coates/events{/privacy}","received_events_url":"https://api.github.com/users/big-andy-coates/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-20T14:55:41Z","updated_at":"2018-09-24T15:01:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/1923","html_url":"https://github.com/confluentinc/ksql/pull/1923","diff_url":"https://github.com/confluentinc/ksql/pull/1923.diff","patch_url":"https://github.com/confluentinc/ksql/pull/1923.patch"},"body":"### Description \r\nFixes: #1920\r\n\r\nThe idea here is that the `list properties` call should make it clear what properties are at their default value.  We already have a marker for `LOCAL OVERRIDE`. I've added a new `DEFAULT` marker for those properties that are not set via server config or have local overrides.\r\n\r\nSo you now get an output like:\r\n\r\n```\r\nksql> LIST PROPERTIES;\r\n\r\n Property                                               | Value\r\n------------------------------------------------------------------------------------------------------------------------------------\r\n[...]\r\n ksql.streams.auto.offset.reset (DEFAULT)                | latest\r\n[...]\r\n```\r\n\r\nNot sure if we should also add a `SERVER OVERRIDE` tag too...?\r\n\r\n### Testing done \r\nAdded tests plus manual\r\n\r\n### Reviewer checklist\r\n- [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).\r\n- [ ] Ensure relevant issues are linked (description should include text like \"Fixes #<issue number>\")\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/confluentinc/ksql/issues/comments/424006333","html_url":"https://github.com/confluentinc/ksql/pull/1923#issuecomment-424006333","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/1923","id":424006333,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDAwNjMzMw==","user":{"login":"miguno","id":294849,"node_id":"MDQ6VXNlcjI5NDg0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/294849?v=4","gravatar_id":"","url":"https://api.github.com/users/miguno","html_url":"https://github.com/miguno","followers_url":"https://api.github.com/users/miguno/followers","following_url":"https://api.github.com/users/miguno/following{/other_user}","gists_url":"https://api.github.com/users/miguno/gists{/gist_id}","starred_url":"https://api.github.com/users/miguno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguno/subscriptions","organizations_url":"https://api.github.com/users/miguno/orgs","repos_url":"https://api.github.com/users/miguno/repos","events_url":"https://api.github.com/users/miguno/events{/privacy}","received_events_url":"https://api.github.com/users/miguno/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T15:01:11Z","updated_at":"2018-09-24T15:01:11Z","author_association":"MEMBER","body":"@big-andy-coates : Ack.  I synced with @rmoff offline.  Let's go with the (updated) suggestion of SERVER and SESSION!"}}
{"actor":{"display_login":"miguno"}}