{"action":"created","comment":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/226236164","pull_request_review_id":165879792,"id":226236164,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjIzNjE2NA==","diff_hunk":"@@ -0,0 +1,477 @@\n+/* Copyright JS Foundation and other contributors, http://js.foundation\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+ class A {\n+   constructor (a) {\n+     this.a = a;\n+   }\n+\n+   f () {\n+     return 5;\n+   }\n+ }\n+\n+class Animal {\n+  constructor (name) {\n+    this.name = name;\n+  }\n+\n+  hello () {\n+    return \"Hello I am \" + this.name;\n+  }\n+\n+  static speak () {\n+    return \"Animals roar.\";\n+  }\n+\n+  static explain () {\n+    return \"I can walk,\";\n+  }\n+\n+  whoAmI () {\n+    return \"I am an Animal.\";\n+  }\n+\n+  breath () {\n+    return \"I am breathing.\";\n+  }\n+\n+  get myName () {\n+    return this.name;\n+  }\n+\n+  set rename (name) {\n+    this.name = name;\n+  }\n+}\n+\n+class Dog extends Animal {\n+  constructor (name, barks) {\n+    super (name);\n+    this.barks = barks;\n+  }\n+\n+  hello () {\n+    return super.hello () + \" and I can \" + (this.barks ? \"bark\" : \"not bark\");\n+  }\n+\n+  whoAmI () {\n+    return \"I am a Dog.\";\n+  }\n+\n+  static speak () {\n+    return \"Dogs bark.\";\n+  }\n+\n+  static explain () {\n+    return super.explain () + \" jump,\";\n+  }\n+\n+  bark () {\n+    return this.barks ? \"Woof\" : \"----\";\n+  }\n+}\n+\n+class Doge extends Dog {\n+  constructor (name, barks, awesomeness) {\n+    super (name, barks);\n+    this.awesomeness = awesomeness;\n+  }\n+\n+  hello () {\n+    return super.hello () + \" and I'm \" + (this.awesomeness > 9000 ? \"super awesome\" : \"awesome\") + \".\";\n+  }\n+\n+  whoAmI ( ) {\n+    return \"I am a Doge.\";\n+  }\n+\n+  static speak () {\n+    return \"Doges wow.\";\n+  }\n+\n+  static explain () {\n+    return super.explain () + \" dance.\";\n+  }\n+}\n+\n+var doge = new Doge (\"doggoe\", true, 10000);\n+assert (doge.name === \"doggoe\");\n+doge.rename = \"doggo\";\n+assert (doge.myName === \"doggo\");\n+assert (doge.barks === true);\n+assert (doge.awesomeness === 10000);\n+assert (doge.hello () === \"Hello I am doggo and I can bark and I'm super awesome.\");\n+assert (doge.whoAmI () === \"I am a Doge.\");\n+assert (doge.breath () === \"I am breathing.\");\n+assert (doge.bark () === \"Woof\");\n+assert (Doge.speak () === \"Doges wow.\");\n+assert (Doge.explain () === \"I can walk, jump, dance.\");\n+assert (doge instanceof Animal);\n+assert (doge instanceof Dog);\n+assert (doge instanceof Doge);\n+assert (Dog.prototype.constructor === Dog)\n+assert (Doge.prototype.constructor === Doge)\n+\n+class C {\n+  static a () {\n+    return 5;\n+  }\n+}\n+\n+class D extends C {\n+  constructor () {\n+    super ();\n+  }\n+}\n+\n+assert (D.a () === 5);\n+\n+C.a = function () {\n+  return 6;\n+}\n+\n+assert (D.a () === 6);\n+\n+C = 5;\n+\n+assert (D.a () === 6);\n+\n+class A extends Array {\n+  constructor (a, b, c) {\n+    super (a, b);\n+    this.f = 5;\n+  }\n+}\n+\n+class B extends A { }\n+\n+var b = new B (1, 2, 3, 4);\n+assert (b.f === 5);\n+assert (b.length === 2);\n+\n+class A extends Array {\n+  constructor (a, b, c) {\n+    super (a, b);\n+    this.f = 5;\n+  }\n+}\n+\n+class B extends A {\n+  constructor (a, b, c) {\n+    super (a, b);\n+    this.g = super.f;\n+    this.h = this.f;\n+  }\n+}","path":"tests/jerry/es2015/class-inheritance-core.js","position":178,"original_position":178,"commit_id":"61b40709cc4caec802c993a9d54fd5a242b95deb","original_commit_id":"61b40709cc4caec802c993a9d54fd5a242b95deb","user":{"login":"akosthekiss","id":9976482,"node_id":"MDQ6VXNlcjk5NzY0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/9976482?v=4","gravatar_id":"","url":"https://api.github.com/users/akosthekiss","html_url":"https://github.com/akosthekiss","followers_url":"https://api.github.com/users/akosthekiss/followers","following_url":"https://api.github.com/users/akosthekiss/following{/other_user}","gists_url":"https://api.github.com/users/akosthekiss/gists{/gist_id}","starred_url":"https://api.github.com/users/akosthekiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akosthekiss/subscriptions","organizations_url":"https://api.github.com/users/akosthekiss/orgs","repos_url":"https://api.github.com/users/akosthekiss/repos","events_url":"https://api.github.com/users/akosthekiss/events{/privacy}","received_events_url":"https://api.github.com/users/akosthekiss/received_events","type":"User","site_admin":false},"body":"Is it intentional that `A` and `B` are redefined over and over again in the same test file with slightly different content? All redefinitions seem to be potential test file splitting points.","created_at":"2018-10-18T09:36:19Z","updated_at":"2018-10-18T09:45:59Z","html_url":"https://github.com/jerryscript-project/jerryscript/pull/2439#discussion_r226236164","pull_request_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2439","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/226236164"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/2439#discussion_r226236164"},"pull_request":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2439"}}},"pull_request":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2439","id":204802947,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODAyOTQ3","html_url":"https://github.com/jerryscript-project/jerryscript/pull/2439","diff_url":"https://github.com/jerryscript-project/jerryscript/pull/2439.diff","patch_url":"https://github.com/jerryscript-project/jerryscript/pull/2439.patch","issue_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2439","number":2439,"state":"open","locked":false,"title":"Implement ES2015 class feature (part II.)","user":{"login":"rerobika","id":22135179,"node_id":"MDQ6VXNlcjIyMTM1MTc5","avatar_url":"https://avatars0.githubusercontent.com/u/22135179?v=4","gravatar_id":"","url":"https://api.github.com/users/rerobika","html_url":"https://github.com/rerobika","followers_url":"https://api.github.com/users/rerobika/followers","following_url":"https://api.github.com/users/rerobika/following{/other_user}","gists_url":"https://api.github.com/users/rerobika/gists{/gist_id}","starred_url":"https://api.github.com/users/rerobika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rerobika/subscriptions","organizations_url":"https://api.github.com/users/rerobika/orgs","repos_url":"https://api.github.com/users/rerobika/repos","events_url":"https://api.github.com/users/rerobika/events{/privacy}","received_events_url":"https://api.github.com/users/rerobika/received_events","type":"User","site_admin":false},"body":"This patch is the second milestone of the implementation of this new language element.\r\n\r\nSupported:\r\n - Single class inheritance\r\n - Functionality of 'super' keyword\r\n - Implicit constructor in class heritage\r\n - Specific behaviour while extending with the built-in 'Array' or '%TypedArray%' object\r\n - Abstract subclasses (Mix-ins)\r\n\r\nJerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu","created_at":"2018-07-30T13:23:39Z","updated_at":"2018-10-18T09:45:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fcfcb6bf9b53e09cfc69dd3cb5dae19438e889e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":544292438,"node_id":"MDU6TGFiZWw1NDQyOTI0Mzg=","url":"https://api.github.com/repos/jerryscript-project/jerryscript/labels/ES2015","name":"ES2015","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2439/commits","review_comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2439/comments","review_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2439/comments","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/61b40709cc4caec802c993a9d54fd5a242b95deb","head":{"label":"rerobika:es2015_class_part_II","ref":"es2015_class_part_II","sha":"61b40709cc4caec802c993a9d54fd5a242b95deb","user":{"login":"rerobika","id":22135179,"node_id":"MDQ6VXNlcjIyMTM1MTc5","avatar_url":"https://avatars0.githubusercontent.com/u/22135179?v=4","gravatar_id":"","url":"https://api.github.com/users/rerobika","html_url":"https://github.com/rerobika","followers_url":"https://api.github.com/users/rerobika/followers","following_url":"https://api.github.com/users/rerobika/following{/other_user}","gists_url":"https://api.github.com/users/rerobika/gists{/gist_id}","starred_url":"https://api.github.com/users/rerobika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rerobika/subscriptions","organizations_url":"https://api.github.com/users/rerobika/orgs","repos_url":"https://api.github.com/users/rerobika/repos","events_url":"https://api.github.com/users/rerobika/events{/privacy}","received_events_url":"https://api.github.com/users/rerobika/received_events","type":"User","site_admin":false},"repo":{"id":93626584,"node_id":"MDEwOlJlcG9zaXRvcnk5MzYyNjU4NA==","name":"jerryscript","full_name":"rerobika/jerryscript","private":false,"owner":{"login":"rerobika","id":22135179,"node_id":"MDQ6VXNlcjIyMTM1MTc5","avatar_url":"https://avatars0.githubusercontent.com/u/22135179?v=4","gravatar_id":"","url":"https://api.github.com/users/rerobika","html_url":"https://github.com/rerobika","followers_url":"https://api.github.com/users/rerobika/followers","following_url":"https://api.github.com/users/rerobika/following{/other_user}","gists_url":"https://api.github.com/users/rerobika/gists{/gist_id}","starred_url":"https://api.github.com/users/rerobika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rerobika/subscriptions","organizations_url":"https://api.github.com/users/rerobika/orgs","repos_url":"https://api.github.com/users/rerobika/repos","events_url":"https://api.github.com/users/rerobika/events{/privacy}","received_events_url":"https://api.github.com/users/rerobika/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rerobika/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things.","fork":true,"url":"https://api.github.com/repos/rerobika/jerryscript","forks_url":"https://api.github.com/repos/rerobika/jerryscript/forks","keys_url":"https://api.github.com/repos/rerobika/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rerobika/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rerobika/jerryscript/teams","hooks_url":"https://api.github.com/repos/rerobika/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/rerobika/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/rerobika/jerryscript/events","assignees_url":"https://api.github.com/repos/rerobika/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/rerobika/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/rerobika/jerryscript/tags","blobs_url":"https://api.github.com/repos/rerobika/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rerobika/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rerobika/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/rerobika/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rerobika/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/rerobika/jerryscript/languages","stargazers_url":"https://api.github.com/repos/rerobika/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/rerobika/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/rerobika/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/rerobika/jerryscript/subscription","commits_url":"https://api.github.com/repos/rerobika/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/rerobika/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/rerobika/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/rerobika/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/rerobika/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/rerobika/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rerobika/jerryscript/merges","archive_url":"https://api.github.com/repos/rerobika/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rerobika/jerryscript/downloads","issues_url":"https://api.github.com/repos/rerobika/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/rerobika/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/rerobika/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/rerobika/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rerobika/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/rerobika/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/rerobika/jerryscript/deployments","created_at":"2017-06-07T11:11:17Z","updated_at":"2017-06-07T11:11:21Z","pushed_at":"2018-10-17T14:47:14Z","git_url":"git://github.com/rerobika/jerryscript.git","ssh_url":"git@github.com:rerobika/jerryscript.git","clone_url":"https://github.com/rerobika/jerryscript.git","svn_url":"https://github.com/rerobika/jerryscript","homepage":"http://jerryscript.net","size":32057,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jerryscript-project:master","ref":"master","sha":"afe2a804316de0cc2a225c475516c3fb9f89ae1b","user":{"login":"jerryscript-project","id":23194380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTk0Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/23194380?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"node_id":"MDEwOlJlcG9zaXRvcnkzMzMzOTY2MA==","name":"jerryscript","full_name":"jerryscript-project/jerryscript","private":false,"owner":{"login":"jerryscript-project","id":23194380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTk0Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/23194380?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jerryscript-project/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things.","fork":false,"url":"https://api.github.com/repos/jerryscript-project/jerryscript","forks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/forks","keys_url":"https://api.github.com/repos/jerryscript-project/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryscript-project/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryscript-project/jerryscript/teams","hooks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/events","assignees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/jerryscript-project/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/tags","blobs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryscript-project/jerryscript/languages","stargazers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscription","commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/jerryscript-project/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryscript-project/jerryscript/merges","archive_url":"https://api.github.com/repos/jerryscript-project/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryscript-project/jerryscript/downloads","issues_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryscript-project/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryscript-project/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryscript-project/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/jerryscript-project/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/deployments","created_at":"2015-04-03T01:10:31Z","updated_at":"2018-10-18T07:33:52Z","pushed_at":"2018-10-18T08:47:11Z","git_url":"git://github.com/jerryscript-project/jerryscript.git","ssh_url":"git@github.com:jerryscript-project/jerryscript.git","clone_url":"https://github.com/jerryscript-project/jerryscript.git","svn_url":"https://github.com/jerryscript-project/jerryscript","homepage":"http://jerryscript.net","size":46920,"stargazers_count":3283,"watchers_count":3283,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":385,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":385,"open_issues":56,"watchers":3283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2439"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/2439"},"issue":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2439"},"comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2439/comments"},"review_comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2439/comments"},"review_comment":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2439/commits"},"statuses":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/61b40709cc4caec802c993a9d54fd5a242b95deb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"akosthekiss"}}