{"action":"created","issue":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1754","repository_url":"https://api.github.com/repos/SpongePowered/SpongeCommon","labels_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1754/labels{/name}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1754/comments","events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1754/events","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/1754","id":294101197,"number":1754,"title":"Fix SpongeContextCalculator NPE on Client","user":{"login":"Faithcaio","id":1575592,"avatar_url":"https://avatars1.githubusercontent.com/u/1575592?v=4","gravatar_id":"","url":"https://api.github.com/users/Faithcaio","html_url":"https://github.com/Faithcaio","followers_url":"https://api.github.com/users/Faithcaio/followers","following_url":"https://api.github.com/users/Faithcaio/following{/other_user}","gists_url":"https://api.github.com/users/Faithcaio/gists{/gist_id}","starred_url":"https://api.github.com/users/Faithcaio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faithcaio/subscriptions","organizations_url":"https://api.github.com/users/Faithcaio/orgs","repos_url":"https://api.github.com/users/Faithcaio/repos","events_url":"https://api.github.com/users/Faithcaio/events{/privacy}","received_events_url":"https://api.github.com/users/Faithcaio/received_events","type":"User","site_admin":false},"labels":[{"id":201461297,"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/labels/status:%20needs%20review","name":"status: needs review","color":"eb6420","default":false},{"id":653167652,"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/labels/system:%20permission","name":"system: permission","color":"902a07","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-03T10:33:35Z","updated_at":"2018-02-03T11:05:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1754","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/1754","diff_url":"https://github.com/SpongePowered/SpongeCommon/pull/1754.diff","patch_url":"https://github.com/SpongePowered/SpongeCommon/pull/1754.patch"},"body":"When running Sponge on a Client the InetSocketAddress is unresolved causing a NPE when calculating Permission Contexts.\r\n"},"comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/comments/362798303","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/1754#issuecomment-362798303","issue_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1754","id":362798303,"user":{"login":"Minecrell","id":3035868,"avatar_url":"https://avatars0.githubusercontent.com/u/3035868?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecrell","html_url":"https://github.com/Minecrell","followers_url":"https://api.github.com/users/Minecrell/followers","following_url":"https://api.github.com/users/Minecrell/following{/other_user}","gists_url":"https://api.github.com/users/Minecrell/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecrell/subscriptions","organizations_url":"https://api.github.com/users/Minecrell/orgs","repos_url":"https://api.github.com/users/Minecrell/repos","events_url":"https://api.github.com/users/Minecrell/events{/privacy}","received_events_url":"https://api.github.com/users/Minecrell/received_events","type":"User","site_admin":false},"created_at":"2018-02-03T11:05:07Z","updated_at":"2018-02-03T11:05:07Z","author_association":"MEMBER","body":"I guess there are two things we can do, not sure which one is better because I don't know much about the permission API:\r\n\r\n- Return null if the hostname can't be resolved and modify `buildAddressCache` to skip adding the context entirely if the method returns null (instead of throwing a NPE).\r\n- Given that the virtual host should usually point to the server itself, we could use the local IP address of the server as a fallback."}}
{"actor":{"display_login":"Minecrell"}}