{"action":"created","comment":{"url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/comments/207156663","pull_request_review_id":142709221,"id":207156663,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzE1NjY2Mw==","diff_hunk":"@@ -0,0 +1,657 @@\n+#ifndef SRC_NODE_API_H_","path":"include/node_api.h","position":1,"original_position":1,"commit_id":"927672a926ce7e6005751c73a8928300f66cac48","original_commit_id":"927672a926ce7e6005751c73a8928300f66cac48","user":{"login":"yorkie","id":1935767,"node_id":"MDQ6VXNlcjE5MzU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1935767?v=4","gravatar_id":"","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"body":"How about downloading this from Node.js?","created_at":"2018-08-02T09:18:40Z","updated_at":"2018-08-02T09:18:40Z","html_url":"https://github.com/Rokid/ShadowNode/pull/243#discussion_r207156663","pull_request_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/243","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/comments/207156663"},"html":{"href":"https://github.com/Rokid/ShadowNode/pull/243#discussion_r207156663"},"pull_request":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/243"}}},"pull_request":{"url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/243","id":205668810,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NjY4ODEw","html_url":"https://github.com/Rokid/ShadowNode/pull/243","diff_url":"https://github.com/Rokid/ShadowNode/pull/243.diff","patch_url":"https://github.com/Rokid/ShadowNode/pull/243.patch","issue_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/243","number":243,"state":"open","locked":false,"title":"napi: module registration","user":{"login":"legendecas","id":8500303,"node_id":"MDQ6VXNlcjg1MDAzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/8500303?v=4","gravatar_id":"","url":"https://api.github.com/users/legendecas","html_url":"https://github.com/legendecas","followers_url":"https://api.github.com/users/legendecas/followers","following_url":"https://api.github.com/users/legendecas/following{/other_user}","gists_url":"https://api.github.com/users/legendecas/gists{/gist_id}","starred_url":"https://api.github.com/users/legendecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legendecas/subscriptions","organizations_url":"https://api.github.com/users/legendecas/orgs","repos_url":"https://api.github.com/users/legendecas/repos","events_url":"https://api.github.com/users/legendecas/events{/privacy}","received_events_url":"https://api.github.com/users/legendecas/received_events","type":"User","site_admin":false},"body":"close #230 \r\n\r\nNAPI module are loaded with gcc compilation attribute `__attribute__((constructor))`. Thus on the load of a native add-on, if the module are registered already shall be checked before current iotjs add-on module load process.\r\n\r\n- [ ] tests\r\n- [ ] documents","created_at":"2018-08-02T09:17:28Z","updated_at":"2018-08-02T09:18:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65242a9d8e67e78048791e1f646456af37ee67da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/243/commits","review_comments_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/243/comments","review_comment_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/243/comments","statuses_url":"https://api.github.com/repos/Rokid/ShadowNode/statuses/927672a926ce7e6005751c73a8928300f66cac48","head":{"label":"Rokid:napi/module-registration","ref":"napi/module-registration","sha":"927672a926ce7e6005751c73a8928300f66cac48","user":{"login":"Rokid","id":19773259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczMjU5","avatar_url":"https://avatars2.githubusercontent.com/u/19773259?v=4","gravatar_id":"","url":"https://api.github.com/users/Rokid","html_url":"https://github.com/Rokid","followers_url":"https://api.github.com/users/Rokid/followers","following_url":"https://api.github.com/users/Rokid/following{/other_user}","gists_url":"https://api.github.com/users/Rokid/gists{/gist_id}","starred_url":"https://api.github.com/users/Rokid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rokid/subscriptions","organizations_url":"https://api.github.com/users/Rokid/orgs","repos_url":"https://api.github.com/users/Rokid/repos","events_url":"https://api.github.com/users/Rokid/events{/privacy}","received_events_url":"https://api.github.com/users/Rokid/received_events","type":"Organization","site_admin":false},"repo":{"id":114971968,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ5NzE5Njg=","name":"ShadowNode","full_name":"Rokid/ShadowNode","owner":{"login":"Rokid","id":19773259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczMjU5","avatar_url":"https://avatars2.githubusercontent.com/u/19773259?v=4","gravatar_id":"","url":"https://api.github.com/users/Rokid","html_url":"https://github.com/Rokid","followers_url":"https://api.github.com/users/Rokid/followers","following_url":"https://api.github.com/users/Rokid/following{/other_user}","gists_url":"https://api.github.com/users/Rokid/gists{/gist_id}","starred_url":"https://api.github.com/users/Rokid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rokid/subscriptions","organizations_url":"https://api.github.com/users/Rokid/orgs","repos_url":"https://api.github.com/users/Rokid/repos","events_url":"https://api.github.com/users/Rokid/events{/privacy}","received_events_url":"https://api.github.com/users/Rokid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rokid/ShadowNode","description":"Use Node.js in your end devices :)","fork":false,"url":"https://api.github.com/repos/Rokid/ShadowNode","forks_url":"https://api.github.com/repos/Rokid/ShadowNode/forks","keys_url":"https://api.github.com/repos/Rokid/ShadowNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rokid/ShadowNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rokid/ShadowNode/teams","hooks_url":"https://api.github.com/repos/Rokid/ShadowNode/hooks","issue_events_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/events{/number}","events_url":"https://api.github.com/repos/Rokid/ShadowNode/events","assignees_url":"https://api.github.com/repos/Rokid/ShadowNode/assignees{/user}","branches_url":"https://api.github.com/repos/Rokid/ShadowNode/branches{/branch}","tags_url":"https://api.github.com/repos/Rokid/ShadowNode/tags","blobs_url":"https://api.github.com/repos/Rokid/ShadowNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rokid/ShadowNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rokid/ShadowNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rokid/ShadowNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rokid/ShadowNode/statuses/{sha}","languages_url":"https://api.github.com/repos/Rokid/ShadowNode/languages","stargazers_url":"https://api.github.com/repos/Rokid/ShadowNode/stargazers","contributors_url":"https://api.github.com/repos/Rokid/ShadowNode/contributors","subscribers_url":"https://api.github.com/repos/Rokid/ShadowNode/subscribers","subscription_url":"https://api.github.com/repos/Rokid/ShadowNode/subscription","commits_url":"https://api.github.com/repos/Rokid/ShadowNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rokid/ShadowNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rokid/ShadowNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rokid/ShadowNode/contents/{+path}","compare_url":"https://api.github.com/repos/Rokid/ShadowNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rokid/ShadowNode/merges","archive_url":"https://api.github.com/repos/Rokid/ShadowNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rokid/ShadowNode/downloads","issues_url":"https://api.github.com/repos/Rokid/ShadowNode/issues{/number}","pulls_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls{/number}","milestones_url":"https://api.github.com/repos/Rokid/ShadowNode/milestones{/number}","notifications_url":"https://api.github.com/repos/Rokid/ShadowNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rokid/ShadowNode/labels{/name}","releases_url":"https://api.github.com/repos/Rokid/ShadowNode/releases{/id}","deployments_url":"https://api.github.com/repos/Rokid/ShadowNode/deployments","created_at":"2017-12-21T06:40:28Z","updated_at":"2018-08-02T07:01:11Z","pushed_at":"2018-08-02T09:17:29Z","git_url":"git://github.com/Rokid/ShadowNode.git","ssh_url":"git@github.com:Rokid/ShadowNode.git","clone_url":"https://github.com/Rokid/ShadowNode.git","svn_url":"https://github.com/Rokid/ShadowNode","homepage":"https://t.me/shadownode","size":8512,"stargazers_count":324,"watchers_count":324,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":44,"watchers":324,"default_branch":"master"}},"base":{"label":"Rokid:master","ref":"master","sha":"43e7b243f40159929e4d1d7ec0a380e3beef64b1","user":{"login":"Rokid","id":19773259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczMjU5","avatar_url":"https://avatars2.githubusercontent.com/u/19773259?v=4","gravatar_id":"","url":"https://api.github.com/users/Rokid","html_url":"https://github.com/Rokid","followers_url":"https://api.github.com/users/Rokid/followers","following_url":"https://api.github.com/users/Rokid/following{/other_user}","gists_url":"https://api.github.com/users/Rokid/gists{/gist_id}","starred_url":"https://api.github.com/users/Rokid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rokid/subscriptions","organizations_url":"https://api.github.com/users/Rokid/orgs","repos_url":"https://api.github.com/users/Rokid/repos","events_url":"https://api.github.com/users/Rokid/events{/privacy}","received_events_url":"https://api.github.com/users/Rokid/received_events","type":"Organization","site_admin":false},"repo":{"id":114971968,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ5NzE5Njg=","name":"ShadowNode","full_name":"Rokid/ShadowNode","owner":{"login":"Rokid","id":19773259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczMjU5","avatar_url":"https://avatars2.githubusercontent.com/u/19773259?v=4","gravatar_id":"","url":"https://api.github.com/users/Rokid","html_url":"https://github.com/Rokid","followers_url":"https://api.github.com/users/Rokid/followers","following_url":"https://api.github.com/users/Rokid/following{/other_user}","gists_url":"https://api.github.com/users/Rokid/gists{/gist_id}","starred_url":"https://api.github.com/users/Rokid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rokid/subscriptions","organizations_url":"https://api.github.com/users/Rokid/orgs","repos_url":"https://api.github.com/users/Rokid/repos","events_url":"https://api.github.com/users/Rokid/events{/privacy}","received_events_url":"https://api.github.com/users/Rokid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rokid/ShadowNode","description":"Use Node.js in your end devices :)","fork":false,"url":"https://api.github.com/repos/Rokid/ShadowNode","forks_url":"https://api.github.com/repos/Rokid/ShadowNode/forks","keys_url":"https://api.github.com/repos/Rokid/ShadowNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rokid/ShadowNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rokid/ShadowNode/teams","hooks_url":"https://api.github.com/repos/Rokid/ShadowNode/hooks","issue_events_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/events{/number}","events_url":"https://api.github.com/repos/Rokid/ShadowNode/events","assignees_url":"https://api.github.com/repos/Rokid/ShadowNode/assignees{/user}","branches_url":"https://api.github.com/repos/Rokid/ShadowNode/branches{/branch}","tags_url":"https://api.github.com/repos/Rokid/ShadowNode/tags","blobs_url":"https://api.github.com/repos/Rokid/ShadowNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rokid/ShadowNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rokid/ShadowNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rokid/ShadowNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rokid/ShadowNode/statuses/{sha}","languages_url":"https://api.github.com/repos/Rokid/ShadowNode/languages","stargazers_url":"https://api.github.com/repos/Rokid/ShadowNode/stargazers","contributors_url":"https://api.github.com/repos/Rokid/ShadowNode/contributors","subscribers_url":"https://api.github.com/repos/Rokid/ShadowNode/subscribers","subscription_url":"https://api.github.com/repos/Rokid/ShadowNode/subscription","commits_url":"https://api.github.com/repos/Rokid/ShadowNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rokid/ShadowNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rokid/ShadowNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rokid/ShadowNode/contents/{+path}","compare_url":"https://api.github.com/repos/Rokid/ShadowNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rokid/ShadowNode/merges","archive_url":"https://api.github.com/repos/Rokid/ShadowNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rokid/ShadowNode/downloads","issues_url":"https://api.github.com/repos/Rokid/ShadowNode/issues{/number}","pulls_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls{/number}","milestones_url":"https://api.github.com/repos/Rokid/ShadowNode/milestones{/number}","notifications_url":"https://api.github.com/repos/Rokid/ShadowNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rokid/ShadowNode/labels{/name}","releases_url":"https://api.github.com/repos/Rokid/ShadowNode/releases{/id}","deployments_url":"https://api.github.com/repos/Rokid/ShadowNode/deployments","created_at":"2017-12-21T06:40:28Z","updated_at":"2018-08-02T07:01:11Z","pushed_at":"2018-08-02T09:17:29Z","git_url":"git://github.com/Rokid/ShadowNode.git","ssh_url":"git@github.com:Rokid/ShadowNode.git","clone_url":"https://github.com/Rokid/ShadowNode.git","svn_url":"https://github.com/Rokid/ShadowNode","homepage":"https://t.me/shadownode","size":8512,"stargazers_count":324,"watchers_count":324,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":44,"watchers":324,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/243"},"html":{"href":"https://github.com/Rokid/ShadowNode/pull/243"},"issue":{"href":"https://api.github.com/repos/Rokid/ShadowNode/issues/243"},"comments":{"href":"https://api.github.com/repos/Rokid/ShadowNode/issues/243/comments"},"review_comments":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/243/comments"},"review_comment":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/243/commits"},"statuses":{"href":"https://api.github.com/repos/Rokid/ShadowNode/statuses/927672a926ce7e6005751c73a8928300f66cac48"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"yorkie"}}