{"action":"created","issue":{"url":"https://api.github.com/repos/coq/coq/issues/7740","repository_url":"https://api.github.com/repos/coq/coq","labels_url":"https://api.github.com/repos/coq/coq/issues/7740/labels{/name}","comments_url":"https://api.github.com/repos/coq/coq/issues/7740/comments","events_url":"https://api.github.com/repos/coq/coq/issues/7740/events","html_url":"https://github.com/coq/coq/issues/7740","id":330476340,"node_id":"MDU6SXNzdWUzMzA0NzYzNDA=","number":7740,"title":"coq_makefile usage of DESTDIR is incorrect","user":{"login":"JasonGross","id":396076,"node_id":"MDQ6VXNlcjM5NjA3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/396076?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonGross","html_url":"https://github.com/JasonGross","followers_url":"https://api.github.com/users/JasonGross/followers","following_url":"https://api.github.com/users/JasonGross/following{/other_user}","gists_url":"https://api.github.com/users/JasonGross/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGross/subscriptions","organizations_url":"https://api.github.com/users/JasonGross/orgs","repos_url":"https://api.github.com/users/JasonGross/repos","events_url":"https://api.github.com/users/JasonGross/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGross/received_events","type":"User","site_admin":false},"labels":[{"id":723364180,"node_id":"MDU6TGFiZWw3MjMzNjQxODA=","url":"https://api.github.com/repos/coq/coq/labels/part:%20tools","name":"part: tools","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-08T00:06:04Z","updated_at":"2018-06-11T11:44:53Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"#### Version\r\n\r\n8.8.0\r\n\r\n#### Operating system\r\n\r\nLinux\r\n\r\n#### Description of the problem\r\n\r\nAccording to https://www.gnu.org/prep/standards/html_node/DESTDIR.html, \r\n\r\n> `DESTDIR` is a variable prepended to each installed target file, like this:\r\n>\r\n>     $(INSTALL_PROGRAM) foo $(DESTDIR)$(bindir)/foo\r\n>     $(INSTALL_DATA) libfoo.a $(DESTDIR)$(libdir)/libfoo.a\r\n>\r\n> The `DESTDIR` variable is specified by the user on the `make` command line as an absolute file name. For example:\r\n>\r\n>     make DESTDIR=/tmp/stage install\r\n>\r\n> `DESTDIR` should be supported only in the `install*` and `uninstall*` targets, as those are the only targets where it is useful.\r\n>\r\n> If your installation step would normally install `/usr/local/bin/foo` and `/usr/local/lib/libfoo.a`, then an installation invoked as in the example above would install `/tmp/stage/usr/local/bin/foo` and `/tmp/stage/usr/local/lib/libfoo.a` instead.\r\n\r\nHowever, this is not how\r\n```\r\nconcat_path = $(if $(1),$(1)/$(subst $(COQMF_WINDRIVE),/,$(2)),$(2))\r\n\r\nCOQLIBINSTALL = $(call concat_path,$(DESTDIR),$(COQLIB)user-contrib)\r\nCOQDOCINSTALL = $(call concat_path,$(DESTDIR),$(DOCDIR)user-contrib)\r\nCOQTOPINSTALL = $(call concat_path,$(DESTDIR),$(COQLIB)toploop)\r\n```\r\nworks, because `COQMF_WINDRIVE` includes `lib/coq` at the end of it.\r\n\r\ncc @andres-erbsen @gares \r\n\r\nSee Also #7722"},"comment":{"url":"https://api.github.com/repos/coq/coq/issues/comments/396215191","html_url":"https://github.com/coq/coq/issues/7740#issuecomment-396215191","issue_url":"https://api.github.com/repos/coq/coq/issues/7740","id":396215191,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjIxNTE5MQ==","user":{"login":"gares","id":1013846,"node_id":"MDQ6VXNlcjEwMTM4NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1013846?v=4","gravatar_id":"","url":"https://api.github.com/users/gares","html_url":"https://github.com/gares","followers_url":"https://api.github.com/users/gares/followers","following_url":"https://api.github.com/users/gares/following{/other_user}","gists_url":"https://api.github.com/users/gares/gists{/gist_id}","starred_url":"https://api.github.com/users/gares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gares/subscriptions","organizations_url":"https://api.github.com/users/gares/orgs","repos_url":"https://api.github.com/users/gares/repos","events_url":"https://api.github.com/users/gares/events{/privacy}","received_events_url":"https://api.github.com/users/gares/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T11:44:53Z","updated_at":"2018-06-11T11:44:53Z","author_association":"MEMBER","body":"See also #7241"}}
{"actor":{"display_login":"gares"}}