{"action":"created","comment":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/comments/173605154","pull_request_review_id":102833215,"id":173605154,"diff_hunk":"@@ -151,6 +152,8 @@ public void write(IToken token, Object data) throws OverwriteException {\n                 // to validate the state of the write, we know that it didn't went through.\n                 if (re instanceof OverwriteException) {\n                     throw re;\n+                } else if (re instanceof WriteTooLarge) {\n+                    throw re;\n                 }\n \n                 validateStateOfWrittenEntry(token.getTokenValue(), ld);","path":"runtime/src/main/java/org/corfudb/runtime/view/AddressSpaceView.java","position":16,"original_position":16,"commit_id":"ad44573247f8bcee9f34b5e52c4ebf93efd01cd9","original_commit_id":"ad44573247f8bcee9f34b5e52c4ebf93efd01cd9","user":{"login":"Maithem","id":7818642,"avatar_url":"https://avatars2.githubusercontent.com/u/7818642?v=4","gravatar_id":"","url":"https://api.github.com/users/Maithem","html_url":"https://github.com/Maithem","followers_url":"https://api.github.com/users/Maithem/followers","following_url":"https://api.github.com/users/Maithem/following{/other_user}","gists_url":"https://api.github.com/users/Maithem/gists{/gist_id}","starred_url":"https://api.github.com/users/Maithem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maithem/subscriptions","organizations_url":"https://api.github.com/users/Maithem/orgs","repos_url":"https://api.github.com/users/Maithem/repos","events_url":"https://api.github.com/users/Maithem/events{/privacy}","received_events_url":"https://api.github.com/users/Maithem/received_events","type":"User","site_admin":false},"body":"@rogermichoud this method is problematic, it will throw an Overwrite exception regardless of the exception type. Please look into it. ","created_at":"2018-03-10T01:18:43Z","updated_at":"2018-03-10T01:18:44Z","html_url":"https://github.com/CorfuDB/CorfuDB/pull/1214#discussion_r173605154","pull_request_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/1214","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/comments/173605154"},"html":{"href":"https://github.com/CorfuDB/CorfuDB/pull/1214#discussion_r173605154"},"pull_request":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/1214"}}},"pull_request":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/1214","id":174137810,"html_url":"https://github.com/CorfuDB/CorfuDB/pull/1214","diff_url":"https://github.com/CorfuDB/CorfuDB/pull/1214.diff","patch_url":"https://github.com/CorfuDB/CorfuDB/pull/1214.patch","issue_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1214","number":1214,"state":"open","locked":false,"title":"Set Max Write Limit","user":{"login":"Maithem","id":7818642,"avatar_url":"https://avatars2.githubusercontent.com/u/7818642?v=4","gravatar_id":"","url":"https://api.github.com/users/Maithem","html_url":"https://github.com/Maithem","followers_url":"https://api.github.com/users/Maithem/followers","following_url":"https://api.github.com/users/Maithem/following{/other_user}","gists_url":"https://api.github.com/users/Maithem/gists{/gist_id}","starred_url":"https://api.github.com/users/Maithem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maithem/subscriptions","organizations_url":"https://api.github.com/users/Maithem/orgs","repos_url":"https://api.github.com/users/Maithem/repos","events_url":"https://api.github.com/users/Maithem/events{/privacy}","received_events_url":"https://api.github.com/users/Maithem/received_events","type":"User","site_admin":false},"body":"## Overview\r\nAdded the ability to enforce a max write limit for the client.\r\n\r\nWhy should this be merged: \r\nFor some applications clients would like to set a max write limit. This PR will reject writes greater than the limit if its configured. \r\n\r\n\r\n## Checklist (Definition of Done):\r\n\r\n- [x] There are no TODOs left in the code\r\n- [x] [Coding conventions](https://github.com/CorfuDB/CorfuDB/wiki/Corfu-Style-Guidelines) (e.g. for logging, unit tests) have been followed\r\n- [x] Change is covered by automated tests\r\n- [x] Public API has Javadoc\r\n","created_at":"2018-03-10T00:07:10Z","updated_at":"2018-03-10T01:18:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62194e582faeb8abfef31182a7aaacf1535769db","assignee":{"login":"Maithem","id":7818642,"avatar_url":"https://avatars2.githubusercontent.com/u/7818642?v=4","gravatar_id":"","url":"https://api.github.com/users/Maithem","html_url":"https://github.com/Maithem","followers_url":"https://api.github.com/users/Maithem/followers","following_url":"https://api.github.com/users/Maithem/following{/other_user}","gists_url":"https://api.github.com/users/Maithem/gists{/gist_id}","starred_url":"https://api.github.com/users/Maithem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maithem/subscriptions","organizations_url":"https://api.github.com/users/Maithem/orgs","repos_url":"https://api.github.com/users/Maithem/repos","events_url":"https://api.github.com/users/Maithem/events{/privacy}","received_events_url":"https://api.github.com/users/Maithem/received_events","type":"User","site_admin":false},"assignees":[{"login":"Maithem","id":7818642,"avatar_url":"https://avatars2.githubusercontent.com/u/7818642?v=4","gravatar_id":"","url":"https://api.github.com/users/Maithem","html_url":"https://github.com/Maithem","followers_url":"https://api.github.com/users/Maithem/followers","following_url":"https://api.github.com/users/Maithem/following{/other_user}","gists_url":"https://api.github.com/users/Maithem/gists{/gist_id}","starred_url":"https://api.github.com/users/Maithem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maithem/subscriptions","organizations_url":"https://api.github.com/users/Maithem/orgs","repos_url":"https://api.github.com/users/Maithem/repos","events_url":"https://api.github.com/users/Maithem/events{/privacy}","received_events_url":"https://api.github.com/users/Maithem/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"no2chem","id":6496984,"avatar_url":"https://avatars0.githubusercontent.com/u/6496984?v=4","gravatar_id":"","url":"https://api.github.com/users/no2chem","html_url":"https://github.com/no2chem","followers_url":"https://api.github.com/users/no2chem/followers","following_url":"https://api.github.com/users/no2chem/following{/other_user}","gists_url":"https://api.github.com/users/no2chem/gists{/gist_id}","starred_url":"https://api.github.com/users/no2chem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no2chem/subscriptions","organizations_url":"https://api.github.com/users/no2chem/orgs","repos_url":"https://api.github.com/users/no2chem/repos","events_url":"https://api.github.com/users/no2chem/events{/privacy}","received_events_url":"https://api.github.com/users/no2chem/received_events","type":"User","site_admin":false},{"login":"zalokhan","id":10751367,"avatar_url":"https://avatars3.githubusercontent.com/u/10751367?v=4","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false},{"login":"annym","id":19276204,"avatar_url":"https://avatars0.githubusercontent.com/u/19276204?v=4","gravatar_id":"","url":"https://api.github.com/users/annym","html_url":"https://github.com/annym","followers_url":"https://api.github.com/users/annym/followers","following_url":"https://api.github.com/users/annym/following{/other_user}","gists_url":"https://api.github.com/users/annym/gists{/gist_id}","starred_url":"https://api.github.com/users/annym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annym/subscriptions","organizations_url":"https://api.github.com/users/annym/orgs","repos_url":"https://api.github.com/users/annym/repos","events_url":"https://api.github.com/users/annym/events{/privacy}","received_events_url":"https://api.github.com/users/annym/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":770447724,"url":"https://api.github.com/repos/CorfuDB/CorfuDB/labels/feature","name":"feature","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/1214/commits","review_comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/1214/comments","review_comment_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1214/comments","statuses_url":"https://api.github.com/repos/CorfuDB/CorfuDB/statuses/ad44573247f8bcee9f34b5e52c4ebf93efd01cd9","head":{"label":"CorfuDB:maxWrite","ref":"maxWrite","sha":"ad44573247f8bcee9f34b5e52c4ebf93efd01cd9","user":{"login":"CorfuDB","id":10199273,"avatar_url":"https://avatars0.githubusercontent.com/u/10199273?v=4","gravatar_id":"","url":"https://api.github.com/users/CorfuDB","html_url":"https://github.com/CorfuDB","followers_url":"https://api.github.com/users/CorfuDB/followers","following_url":"https://api.github.com/users/CorfuDB/following{/other_user}","gists_url":"https://api.github.com/users/CorfuDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CorfuDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CorfuDB/subscriptions","organizations_url":"https://api.github.com/users/CorfuDB/orgs","repos_url":"https://api.github.com/users/CorfuDB/repos","events_url":"https://api.github.com/users/CorfuDB/events{/privacy}","received_events_url":"https://api.github.com/users/CorfuDB/received_events","type":"Organization","site_admin":false},"repo":{"id":12960439,"name":"CorfuDB","full_name":"CorfuDB/CorfuDB","owner":{"login":"CorfuDB","id":10199273,"avatar_url":"https://avatars0.githubusercontent.com/u/10199273?v=4","gravatar_id":"","url":"https://api.github.com/users/CorfuDB","html_url":"https://github.com/CorfuDB","followers_url":"https://api.github.com/users/CorfuDB/followers","following_url":"https://api.github.com/users/CorfuDB/following{/other_user}","gists_url":"https://api.github.com/users/CorfuDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CorfuDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CorfuDB/subscriptions","organizations_url":"https://api.github.com/users/CorfuDB/orgs","repos_url":"https://api.github.com/users/CorfuDB/repos","events_url":"https://api.github.com/users/CorfuDB/events{/privacy}","received_events_url":"https://api.github.com/users/CorfuDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CorfuDB/CorfuDB","description":"A cluster consistency platform","fork":false,"url":"https://api.github.com/repos/CorfuDB/CorfuDB","forks_url":"https://api.github.com/repos/CorfuDB/CorfuDB/forks","keys_url":"https://api.github.com/repos/CorfuDB/CorfuDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CorfuDB/CorfuDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CorfuDB/CorfuDB/teams","hooks_url":"https://api.github.com/repos/CorfuDB/CorfuDB/hooks","issue_events_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/events{/number}","events_url":"https://api.github.com/repos/CorfuDB/CorfuDB/events","assignees_url":"https://api.github.com/repos/CorfuDB/CorfuDB/assignees{/user}","branches_url":"https://api.github.com/repos/CorfuDB/CorfuDB/branches{/branch}","tags_url":"https://api.github.com/repos/CorfuDB/CorfuDB/tags","blobs_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CorfuDB/CorfuDB/statuses/{sha}","languages_url":"https://api.github.com/repos/CorfuDB/CorfuDB/languages","stargazers_url":"https://api.github.com/repos/CorfuDB/CorfuDB/stargazers","contributors_url":"https://api.github.com/repos/CorfuDB/CorfuDB/contributors","subscribers_url":"https://api.github.com/repos/CorfuDB/CorfuDB/subscribers","subscription_url":"https://api.github.com/repos/CorfuDB/CorfuDB/subscription","commits_url":"https://api.github.com/repos/CorfuDB/CorfuDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/CorfuDB/CorfuDB/contents/{+path}","compare_url":"https://api.github.com/repos/CorfuDB/CorfuDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CorfuDB/CorfuDB/merges","archive_url":"https://api.github.com/repos/CorfuDB/CorfuDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CorfuDB/CorfuDB/downloads","issues_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues{/number}","pulls_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls{/number}","milestones_url":"https://api.github.com/repos/CorfuDB/CorfuDB/milestones{/number}","notifications_url":"https://api.github.com/repos/CorfuDB/CorfuDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CorfuDB/CorfuDB/labels{/name}","releases_url":"https://api.github.com/repos/CorfuDB/CorfuDB/releases{/id}","deployments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/deployments","created_at":"2013-09-19T22:02:36Z","updated_at":"2018-03-08T03:12:01Z","pushed_at":"2018-03-10T01:14:02Z","git_url":"git://github.com/CorfuDB/CorfuDB.git","ssh_url":"git@github.com:CorfuDB/CorfuDB.git","clone_url":"https://github.com/CorfuDB/CorfuDB.git","svn_url":"https://github.com/CorfuDB/CorfuDB","homepage":"","size":388690,"stargazers_count":338,"watchers_count":338,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":67,"open_issues":167,"watchers":338,"default_branch":"master"}},"base":{"label":"CorfuDB:master","ref":"master","sha":"b974235adfbdc5254c96c4012aef8d65e0429f66","user":{"login":"CorfuDB","id":10199273,"avatar_url":"https://avatars0.githubusercontent.com/u/10199273?v=4","gravatar_id":"","url":"https://api.github.com/users/CorfuDB","html_url":"https://github.com/CorfuDB","followers_url":"https://api.github.com/users/CorfuDB/followers","following_url":"https://api.github.com/users/CorfuDB/following{/other_user}","gists_url":"https://api.github.com/users/CorfuDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CorfuDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CorfuDB/subscriptions","organizations_url":"https://api.github.com/users/CorfuDB/orgs","repos_url":"https://api.github.com/users/CorfuDB/repos","events_url":"https://api.github.com/users/CorfuDB/events{/privacy}","received_events_url":"https://api.github.com/users/CorfuDB/received_events","type":"Organization","site_admin":false},"repo":{"id":12960439,"name":"CorfuDB","full_name":"CorfuDB/CorfuDB","owner":{"login":"CorfuDB","id":10199273,"avatar_url":"https://avatars0.githubusercontent.com/u/10199273?v=4","gravatar_id":"","url":"https://api.github.com/users/CorfuDB","html_url":"https://github.com/CorfuDB","followers_url":"https://api.github.com/users/CorfuDB/followers","following_url":"https://api.github.com/users/CorfuDB/following{/other_user}","gists_url":"https://api.github.com/users/CorfuDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CorfuDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CorfuDB/subscriptions","organizations_url":"https://api.github.com/users/CorfuDB/orgs","repos_url":"https://api.github.com/users/CorfuDB/repos","events_url":"https://api.github.com/users/CorfuDB/events{/privacy}","received_events_url":"https://api.github.com/users/CorfuDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CorfuDB/CorfuDB","description":"A cluster consistency platform","fork":false,"url":"https://api.github.com/repos/CorfuDB/CorfuDB","forks_url":"https://api.github.com/repos/CorfuDB/CorfuDB/forks","keys_url":"https://api.github.com/repos/CorfuDB/CorfuDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CorfuDB/CorfuDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CorfuDB/CorfuDB/teams","hooks_url":"https://api.github.com/repos/CorfuDB/CorfuDB/hooks","issue_events_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/events{/number}","events_url":"https://api.github.com/repos/CorfuDB/CorfuDB/events","assignees_url":"https://api.github.com/repos/CorfuDB/CorfuDB/assignees{/user}","branches_url":"https://api.github.com/repos/CorfuDB/CorfuDB/branches{/branch}","tags_url":"https://api.github.com/repos/CorfuDB/CorfuDB/tags","blobs_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CorfuDB/CorfuDB/statuses/{sha}","languages_url":"https://api.github.com/repos/CorfuDB/CorfuDB/languages","stargazers_url":"https://api.github.com/repos/CorfuDB/CorfuDB/stargazers","contributors_url":"https://api.github.com/repos/CorfuDB/CorfuDB/contributors","subscribers_url":"https://api.github.com/repos/CorfuDB/CorfuDB/subscribers","subscription_url":"https://api.github.com/repos/CorfuDB/CorfuDB/subscription","commits_url":"https://api.github.com/repos/CorfuDB/CorfuDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/CorfuDB/CorfuDB/contents/{+path}","compare_url":"https://api.github.com/repos/CorfuDB/CorfuDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CorfuDB/CorfuDB/merges","archive_url":"https://api.github.com/repos/CorfuDB/CorfuDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CorfuDB/CorfuDB/downloads","issues_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues{/number}","pulls_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls{/number}","milestones_url":"https://api.github.com/repos/CorfuDB/CorfuDB/milestones{/number}","notifications_url":"https://api.github.com/repos/CorfuDB/CorfuDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CorfuDB/CorfuDB/labels{/name}","releases_url":"https://api.github.com/repos/CorfuDB/CorfuDB/releases{/id}","deployments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/deployments","created_at":"2013-09-19T22:02:36Z","updated_at":"2018-03-08T03:12:01Z","pushed_at":"2018-03-10T01:14:02Z","git_url":"git://github.com/CorfuDB/CorfuDB.git","ssh_url":"git@github.com:CorfuDB/CorfuDB.git","clone_url":"https://github.com/CorfuDB/CorfuDB.git","svn_url":"https://github.com/CorfuDB/CorfuDB","homepage":"","size":388690,"stargazers_count":338,"watchers_count":338,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":67,"open_issues":167,"watchers":338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/1214"},"html":{"href":"https://github.com/CorfuDB/CorfuDB/pull/1214"},"issue":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1214"},"comments":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1214/comments"},"review_comments":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/1214/comments"},"review_comment":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/1214/commits"},"statuses":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/statuses/ad44573247f8bcee9f34b5e52c4ebf93efd01cd9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Maithem"}}