{"action":"created","issue":{"url":"https://api.github.com/repos/bincrafters/community/issues/254","repository_url":"https://api.github.com/repos/bincrafters/community","labels_url":"https://api.github.com/repos/bincrafters/community/issues/254/labels{/name}","comments_url":"https://api.github.com/repos/bincrafters/community/issues/254/comments","events_url":"https://api.github.com/repos/bincrafters/community/issues/254/events","html_url":"https://github.com/bincrafters/community/issues/254","id":320286594,"number":254,"title":"Review of inclusion request `libusb/1.0.21@bincrafters/stable`","user":{"login":"lasote","id":3807515,"avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"labels":[{"id":869378321,"url":"https://api.github.com/repos/bincrafters/community/labels/conan-center","name":"conan-center","color":"247bcc","default":false}],"state":"closed","locked":false,"assignee":{"login":"uilianries","id":4870173,"avatar_url":"https://avatars0.githubusercontent.com/u/4870173?v=4","gravatar_id":"","url":"https://api.github.com/users/uilianries","html_url":"https://github.com/uilianries","followers_url":"https://api.github.com/users/uilianries/followers","following_url":"https://api.github.com/users/uilianries/following{/other_user}","gists_url":"https://api.github.com/users/uilianries/gists{/gist_id}","starred_url":"https://api.github.com/users/uilianries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uilianries/subscriptions","organizations_url":"https://api.github.com/users/uilianries/orgs","repos_url":"https://api.github.com/users/uilianries/repos","events_url":"https://api.github.com/users/uilianries/events{/privacy}","received_events_url":"https://api.github.com/users/uilianries/received_events","type":"User","site_admin":false},"assignees":[{"login":"uilianries","id":4870173,"avatar_url":"https://avatars0.githubusercontent.com/u/4870173?v=4","gravatar_id":"","url":"https://api.github.com/users/uilianries","html_url":"https://github.com/uilianries","followers_url":"https://api.github.com/users/uilianries/followers","following_url":"https://api.github.com/users/uilianries/following{/other_user}","gists_url":"https://api.github.com/users/uilianries/gists{/gist_id}","starred_url":"https://api.github.com/users/uilianries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uilianries/subscriptions","organizations_url":"https://api.github.com/users/uilianries/orgs","repos_url":"https://api.github.com/users/uilianries/repos","events_url":"https://api.github.com/users/uilianries/events{/privacy}","received_events_url":"https://api.github.com/users/uilianries/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-05-04T14:00:36Z","updated_at":"2018-05-29T12:54:13Z","closed_at":"2018-05-28T09:57:05Z","author_association":"NONE","body":"\r\n## Inclusion Request Review\r\n\r\nThis is a review for [libusb/1.0.21@bincrafters/stable (bincrafters/public-conan)](https://github.com/bincrafters/conan-libusb) inclusion request to conan-center.\r\nThis review follows the [inclusion guidelines or third party libraries](http://docs.conan.io/en/latest/uploading_packages/bintray/conan_center_guide.html#inclusion-guidelines-for-third-party-libraries).\r\n\r\n### Package\r\nlibusb/1.0.21@bincrafters/stable\r\n\r\n### Checks and Comments\r\n\r\n#### Recipe quality\r\n- [x] Git public repository\r\n- [x] Recipe fields\r\n- [x] Linter\r\n- [ ] Updated\r\n\r\n    - The recipe is using the deprecated `build_sln_command`, it has been replaced with the build helper `MSBuild()`\r\n    - To avoid the \"x86\"/\"Win32\" replacement probably you can use the `platforms` parameter `platforms={\"x86\":\"Win32\"}` (read [reference](http://docs.conan.io/en/latest/reference/build_helpers/visual_studio.html))\r\n\r\n     ```\r\n     build_command = tools.build_sln_command(self.settings, solution_file, upgrade_project=False)\r\n     if self.settings.arch == \"x86\":\r\n          build_command = build_command.replace(\"x86\", \"Win32\")\r\n     ```\r\n\r\n    - For Linux/Mac/MinGW, the `AutoToolsBuildEnvironment` now take cares automatically of the `--prefix` so you can remove it, and use directly the `env_build.configure` \r\n\r\n- [x] Clean\r\n- [x] test_package\r\n- [x] Raise errors on invalid configurations\r\n- [x] LICENSE of the recipe\r\n- [x] LICENSE of the library\r\n\r\n#### CI Integration\r\n- [x] Provide at least one CI configuration (header only)\r\n- [x] (If not header only) CI configurations for Linux/MacOSX/Windows\r\n\r\n#### Bintray Package Information\r\n- [x] Description\r\n- [x] Licenses\r\n- [x] Tags\r\n- [x] Maturity\r\n- [x] Website (if any)\r\n- [x] Issue tracker\r\n- [x] Version control\r\n\r\n### Additional comments\r\n\r\nThere are some outdated packages, regenerate all and/or:\r\n\r\n`conan remove libusb/1.0.21@bincrafters/stable --outdated -r bincrafters`\r\n\r\nGood work! just some comments due to some Conan improvements.\r\n"},"comment":{"url":"https://api.github.com/repos/bincrafters/community/issues/comments/392765206","html_url":"https://github.com/bincrafters/community/issues/254#issuecomment-392765206","issue_url":"https://api.github.com/repos/bincrafters/community/issues/254","id":392765206,"user":{"login":"solvingj","id":8557737,"avatar_url":"https://avatars0.githubusercontent.com/u/8557737?v=4","gravatar_id":"","url":"https://api.github.com/users/solvingj","html_url":"https://github.com/solvingj","followers_url":"https://api.github.com/users/solvingj/followers","following_url":"https://api.github.com/users/solvingj/following{/other_user}","gists_url":"https://api.github.com/users/solvingj/gists{/gist_id}","starred_url":"https://api.github.com/users/solvingj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solvingj/subscriptions","organizations_url":"https://api.github.com/users/solvingj/orgs","repos_url":"https://api.github.com/users/solvingj/repos","events_url":"https://api.github.com/users/solvingj/events{/privacy}","received_events_url":"https://api.github.com/users/solvingj/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T12:54:12Z","updated_at":"2018-05-29T12:54:12Z","author_association":"MEMBER","body":"@uilianries is amazing."}}
{"actor":{"display_login":"solvingj"}}