{"action":"created","issue":{"url":"https://api.github.com/repos/STScI-JWST/jwst/issues/2035","repository_url":"https://api.github.com/repos/STScI-JWST/jwst","labels_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/2035/labels{/name}","comments_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/2035/comments","events_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/2035/events","html_url":"https://github.com/STScI-JWST/jwst/issues/2035","id":323723281,"number":2035,"title":"Ramp_fit error on MIRI NGROUPS<=2 exposure","user":{"login":"hbushouse","id":12860084,"avatar_url":"https://avatars1.githubusercontent.com/u/12860084?v=4","gravatar_id":"","url":"https://api.github.com/users/hbushouse","html_url":"https://github.com/hbushouse","followers_url":"https://api.github.com/users/hbushouse/followers","following_url":"https://api.github.com/users/hbushouse/following{/other_user}","gists_url":"https://api.github.com/users/hbushouse/gists{/gist_id}","starred_url":"https://api.github.com/users/hbushouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbushouse/subscriptions","organizations_url":"https://api.github.com/users/hbushouse/orgs","repos_url":"https://api.github.com/users/hbushouse/repos","events_url":"https://api.github.com/users/hbushouse/events{/privacy}","received_events_url":"https://api.github.com/users/hbushouse/received_events","type":"User","site_admin":false},"labels":[{"id":388553031,"url":"https://api.github.com/repos/STScI-JWST/jwst/labels/bug","name":"bug","color":"ee0701","default":true},{"id":390243263,"url":"https://api.github.com/repos/STScI-JWST/jwst/labels/ramp_fitting","name":"ramp_fitting","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":{"login":"dmggh","id":3719822,"avatar_url":"https://avatars3.githubusercontent.com/u/3719822?v=4","gravatar_id":"","url":"https://api.github.com/users/dmggh","html_url":"https://github.com/dmggh","followers_url":"https://api.github.com/users/dmggh/followers","following_url":"https://api.github.com/users/dmggh/following{/other_user}","gists_url":"https://api.github.com/users/dmggh/gists{/gist_id}","starred_url":"https://api.github.com/users/dmggh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmggh/subscriptions","organizations_url":"https://api.github.com/users/dmggh/orgs","repos_url":"https://api.github.com/users/dmggh/repos","events_url":"https://api.github.com/users/dmggh/events{/privacy}","received_events_url":"https://api.github.com/users/dmggh/received_events","type":"User","site_admin":false},"assignees":[{"login":"dmggh","id":3719822,"avatar_url":"https://avatars3.githubusercontent.com/u/3719822?v=4","gravatar_id":"","url":"https://api.github.com/users/dmggh","html_url":"https://github.com/dmggh","followers_url":"https://api.github.com/users/dmggh/followers","following_url":"https://api.github.com/users/dmggh/following{/other_user}","gists_url":"https://api.github.com/users/dmggh/gists{/gist_id}","starred_url":"https://api.github.com/users/dmggh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmggh/subscriptions","organizations_url":"https://api.github.com/users/dmggh/orgs","repos_url":"https://api.github.com/users/dmggh/repos","events_url":"https://api.github.com/users/dmggh/events{/privacy}","received_events_url":"https://api.github.com/users/dmggh/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/STScI-JWST/jwst/milestones/6","html_url":"https://github.com/STScI-JWST/jwst/milestone/6","labels_url":"https://api.github.com/repos/STScI-JWST/jwst/milestones/6/labels","id":2946419,"number":6,"title":"Build 7.1.3","description":"Patch build. \r\n\r\nSCSB development due 11-May-2018. Other subsystems due 18-May-2018. Iterative integration from 21-May-2018 through 12-June-2018. Final DMS delivery to I&T due 15-June-2018.","creator":{"login":"hbushouse","id":12860084,"avatar_url":"https://avatars1.githubusercontent.com/u/12860084?v=4","gravatar_id":"","url":"https://api.github.com/users/hbushouse","html_url":"https://github.com/hbushouse","followers_url":"https://api.github.com/users/hbushouse/followers","following_url":"https://api.github.com/users/hbushouse/following{/other_user}","gists_url":"https://api.github.com/users/hbushouse/gists{/gist_id}","starred_url":"https://api.github.com/users/hbushouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbushouse/subscriptions","organizations_url":"https://api.github.com/users/hbushouse/orgs","repos_url":"https://api.github.com/users/hbushouse/repos","events_url":"https://api.github.com/users/hbushouse/events{/privacy}","received_events_url":"https://api.github.com/users/hbushouse/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":257,"state":"open","created_at":"2017-11-29T12:14:10Z","updated_at":"2018-05-23T14:10:05Z","due_on":"2018-05-11T07:00:00Z","closed_at":null},"comments":6,"created_at":"2018-05-16T17:50:49Z","updated_at":"2018-05-23T14:10:05Z","closed_at":"2018-05-23T14:10:05Z","author_association":"CONTRIBUTOR","body":"DMS testing of 0.9.3rc1 reports:\r\n```\r\n/ifs/int/jwstc/store/doggett/tests/QnGV2/cstring/JWSTDP-2018_1-180430/2018-05-16-145153/sdp/fits/jw93135336001_02102_00001_mirifulong_uncal.fits\r\n \r\nCRDS - DEBUG - Final effective context is 'jwst_0456.pmap' \r\nCRDS - DEBUG - Computing best references locally. \r\nCRDS - DEBUG - Bestrefs header: \r\n{'META.EXPOSURE.READPATT [READPATT]': 'FAST', \r\n'META.EXPOSURE.TYPE [EXP_TYPE]': 'MIR_FLATMRS', \r\n'META.INSTRUMENT.BAND [BAND]': 'LONG', \r\n'META.INSTRUMENT.CHANNEL [CHANNEL]': '34.0', \r\n'META.INSTRUMENT.DETECTOR [DETECTOR]': 'MIRIFULONG', \r\n'META.INSTRUMENT.FILTER [FILTER]': 'N/A', \r\n'META.INSTRUMENT.NAME [INSTRUME]': 'MIRI', \r\n'META.OBSERVATION.DATE [DATE-OBS]': '2016-01-23', \r\n'META.OBSERVATION.TIME [TIME-OBS]': '13:55:06.059', \r\n'META.SUBARRAY.NAME [SUBARRAY]': 'FULL', \r\n'REFTYPE': 'UNDEFINED'} \r\nCRDS - DEBUG - Reference type 'gain' defined as 'jwst_miri_gain_0006.fits' \r\n2018-05-16 15:30:39,186 - stpipe.Detector1Pipeline.ramp_fit - INFO - Using READNOISE reference file: /ifs/int/jwstc/ref/crds/cache/references/jwst/miri/jwst_miri_readnoise_0038.fits \r\n2018-05-16 15:30:39,403 - stpipe.Detector1Pipeline.ramp_fit - INFO - Using GAIN reference file: /ifs/int/jwstc/ref/crds/cache/references/jwst/miri/jwst_miri_gain_0006.fits \r\n2018-05-16 15:30:39,482 - stpipe.Detector1Pipeline.ramp_fit - INFO - Using algorithm = ols \r\n2018-05-16 15:30:39,482 - stpipe.Detector1Pipeline.ramp_fit - INFO - Using weighting = optimal \r\n2018-05-16 15:30:39,489 - stpipe.Detector1Pipeline.ramp_fit - INFO - MIRI dataset has all final groups flagged as DO_NOT_USE. \r\n2018-05-16 15:30:39,489 - stpipe.Detector1Pipeline.ramp_fit - ERROR - MIRI datasets require at least 2 groups/integration \r\n2018-05-16 15:30:39,489 - stpipe.Detector1Pipeline.ramp_fit - ERROR - (NGROUPS), so will not process this dataset. \r\nTraceback (most recent call last): \r\nFile \"/ifs/int/jwstc/pipeline/pkgs/miniconda3/envs/jwstdp-0.9.3rc1-py35/lib/python3.5/site-packages/jwst-0.9.3rc1-py3.5-linux-x86_64.egg/EGG-INFO/scripts/strun\", line 14, in <module> \r\nstep = Step.from_cmdline(sys.argv[1:]) \r\nFile \"/ifs/int/jwstc/pipeline/pkgs/miniconda3/envs/jwstdp-0.9.3rc1-py35/lib/python3.5/site-packages/jwst-0.9.3rc1-py3.5-linux-x86_64.egg/jwst/stpipe/step.py\", line 157, in from_cmdline \r\nreturn cmdline.step_from_cmdline(args) \r\nFile \"/ifs/int/jwstc/pipeline/pkgs/miniconda3/envs/jwstdp-0.9.3rc1-py35/lib/python3.5/site-packages/jwst-0.9.3rc1-py3.5-linux-x86_64.egg/jwst/stpipe/cmdline.py\", line 297, in step_from_cmdline \r\nstep.run(*positional) \r\nFile \"/ifs/int/jwstc/pipeline/pkgs/miniconda3/envs/jwstdp-0.9.3rc1-py35/lib/python3.5/site-packages/jwst-0.9.3rc1-py3.5-linux-x86_64.egg/jwst/stpipe/step.py\", line 391, in run \r\nstep_result = self.process(*args) \r\nFile \"/ifs/int/jwstc/pipeline/pkgs/miniconda3/envs/jwstdp-0.9.3rc1-py35/lib/python3.5/site-packages/jwst-0.9.3rc1-py3.5-linux-x86_64.egg/jwst/pipeline/calwebb_detector1.py\", line 132, in process \r\ninput, ints_model = self.ramp_fit(input) \r\nFile \"/ifs/int/jwstc/pipeline/pkgs/miniconda3/envs/jwstdp-0.9.3rc1-py35/lib/python3.5/site-packages/jwst-0.9.3rc1-py3.5-linux-x86_64.egg/jwst/stpipe/step.py\", line 391, in run \r\nstep_result = self.process(*args) \r\nFile \"/ifs/int/jwstc/pipeline/pkgs/miniconda3/envs/jwstdp-0.9.3rc1-py35/lib/python3.5/site-packages/jwst-0.9.3rc1-py3.5-linux-x86_64.egg/jwst/ramp_fitting/ramp_fit_step.py\", line 69, in process \r\nself.weighting \r\nFile \"/ifs/int/jwstc/pipeline/pkgs/miniconda3/envs/jwstdp-0.9.3rc1-py35/lib/python3.5/site-packages/jwst-0.9.3rc1-py3.5-linux-x86_64.egg/jwst/ramp_fitting/ramp_fit.py\", line 101, in ramp_fit \r\nnew_model.meta.bunit_data = 'DN/s' \r\nAttributeError: 'NoneType' object has no attribute 'meta' \r\n```\r\nThe ramp_fit step is returning without computing any slopes because it doesn't have enough groups per integration to work with. It then fails in the calling routine when trying to set a value for the BUNIT keyword in the output model and apparently the output model is either None or undefined.\r\n\r\nShouldn't the step still be calculating pseudo-slope values for these cases, by just subtracting group 1 from group 2, or group 0 from group 1, and return a populated data model?"},"comment":{"url":"https://api.github.com/repos/STScI-JWST/jwst/issues/comments/391361321","html_url":"https://github.com/STScI-JWST/jwst/issues/2035#issuecomment-391361321","issue_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/2035","id":391361321,"user":{"login":"hbushouse","id":12860084,"avatar_url":"https://avatars1.githubusercontent.com/u/12860084?v=4","gravatar_id":"","url":"https://api.github.com/users/hbushouse","html_url":"https://github.com/hbushouse","followers_url":"https://api.github.com/users/hbushouse/followers","following_url":"https://api.github.com/users/hbushouse/following{/other_user}","gists_url":"https://api.github.com/users/hbushouse/gists{/gist_id}","starred_url":"https://api.github.com/users/hbushouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbushouse/subscriptions","organizations_url":"https://api.github.com/users/hbushouse/orgs","repos_url":"https://api.github.com/users/hbushouse/repos","events_url":"https://api.github.com/users/hbushouse/events{/privacy}","received_events_url":"https://api.github.com/users/hbushouse/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T14:10:05Z","updated_at":"2018-05-23T14:10:05Z","author_association":"CONTRIBUTOR","body":"Fixed by #2040."}}
{"actor":{"display_login":"hbushouse"}}