{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/241818651","pull_request_review_id":185192652,"id":241818651,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTgxODY1MQ==","diff_hunk":"@@ -51,7 +51,7 @@\n         \"rgba(237, 129, 40, 0.9)\",\n         \"rgb(255, 0, 0)\"\n       ],\n-      \"datasource\": \"$datasource\",","path":"roles/ceph-grafana/files/dashboards/ceph-cluster.json","position":null,"original_position":4,"commit_id":"6b871c9e19ca0d5dcd15b34963f2a23bba5dc4c2","original_commit_id":"6b871c9e19ca0d5dcd15b34963f2a23bba5dc4c2","user":{"login":"zmc","id":58307,"node_id":"MDQ6VXNlcjU4MzA3","avatar_url":"https://avatars1.githubusercontent.com/u/58307?v=4","gravatar_id":"","url":"https://api.github.com/users/zmc","html_url":"https://github.com/zmc","followers_url":"https://api.github.com/users/zmc/followers","following_url":"https://api.github.com/users/zmc/following{/other_user}","gists_url":"https://api.github.com/users/zmc/gists{/gist_id}","starred_url":"https://api.github.com/users/zmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmc/subscriptions","organizations_url":"https://api.github.com/users/zmc/orgs","repos_url":"https://api.github.com/users/zmc/repos","events_url":"https://api.github.com/users/zmc/events{/privacy}","received_events_url":"https://api.github.com/users/zmc/received_events","type":"User","site_admin":false},"body":"Oh, okay - it's just that none of the dashboards were working by default. I'll update the PR to use the packaged dashboards. It does look like they use a templated datasource name as well, so I'll see about fixing the default behavior.\r\n\r\nI'd tentatively suggest that we shouldn't store them in two places, for maintenance reasons. It shouldn't be hard to backport the dashboards to luminous if we need to.","created_at":"2018-12-14T16:46:51Z","updated_at":"2018-12-14T16:46:51Z","html_url":"https://github.com/ceph/ceph-ansible/pull/3426#discussion_r241818651","pull_request_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3426","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/241818651"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/3426#discussion_r241818651"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3426"}},"in_reply_to_id":241816426},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3426","id":236904042,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTA0MDQy","html_url":"https://github.com/ceph/ceph-ansible/pull/3426","diff_url":"https://github.com/ceph/ceph-ansible/pull/3426.diff","patch_url":"https://github.com/ceph/ceph-ansible/pull/3426.patch","issue_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/3426","number":3426,"state":"open","locked":false,"title":"[DNM] Merge dashboard-ansible code into ceph-ansible","user":{"login":"b-ranto","id":8439091,"node_id":"MDQ6VXNlcjg0MzkwOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8439091?v=4","gravatar_id":"","url":"https://api.github.com/users/b-ranto","html_url":"https://github.com/b-ranto","followers_url":"https://api.github.com/users/b-ranto/followers","following_url":"https://api.github.com/users/b-ranto/following{/other_user}","gists_url":"https://api.github.com/users/b-ranto/gists{/gist_id}","starred_url":"https://api.github.com/users/b-ranto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-ranto/subscriptions","organizations_url":"https://api.github.com/users/b-ranto/orgs","repos_url":"https://api.github.com/users/b-ranto/repos","events_url":"https://api.github.com/users/b-ranto/events{/privacy}","received_events_url":"https://api.github.com/users/b-ranto/received_events","type":"User","site_admin":false},"body":"This PR merges the dashboard instllation code into ceph-ansible. The code only supports containerized deployment and the PR creates four new roles: ceph-grafana, ceph-dashboard, ceph-prometheus and ceph-node-exporter.\r\n\r\nEdit (@zmc):\r\nTo-do:\r\n- [ ] `purge-cluster.yml`\r\n- [ ] `site-container.yml.sample`\r\n- [ ] `purge-docker-cluster.yml`\r\n- [ ] Is there a better way to template the datasource name inside the dashboard files?\r\n- [ ] Squash and/or clean up commits","created_at":"2018-12-07T15:28:53Z","updated_at":"2018-12-14T16:46:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5070c3dc71fe8241ef4bfc919b4f1de804ba9e6","assignee":{"login":"zmc","id":58307,"node_id":"MDQ6VXNlcjU4MzA3","avatar_url":"https://avatars1.githubusercontent.com/u/58307?v=4","gravatar_id":"","url":"https://api.github.com/users/zmc","html_url":"https://github.com/zmc","followers_url":"https://api.github.com/users/zmc/followers","following_url":"https://api.github.com/users/zmc/following{/other_user}","gists_url":"https://api.github.com/users/zmc/gists{/gist_id}","starred_url":"https://api.github.com/users/zmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmc/subscriptions","organizations_url":"https://api.github.com/users/zmc/orgs","repos_url":"https://api.github.com/users/zmc/repos","events_url":"https://api.github.com/users/zmc/events{/privacy}","received_events_url":"https://api.github.com/users/zmc/received_events","type":"User","site_admin":false},"assignees":[{"login":"zmc","id":58307,"node_id":"MDQ6VXNlcjU4MzA3","avatar_url":"https://avatars1.githubusercontent.com/u/58307?v=4","gravatar_id":"","url":"https://api.github.com/users/zmc","html_url":"https://github.com/zmc","followers_url":"https://api.github.com/users/zmc/followers","following_url":"https://api.github.com/users/zmc/following{/other_user}","gists_url":"https://api.github.com/users/zmc/gists{/gist_id}","starred_url":"https://api.github.com/users/zmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmc/subscriptions","organizations_url":"https://api.github.com/users/zmc/orgs","repos_url":"https://api.github.com/users/zmc/repos","events_url":"https://api.github.com/users/zmc/events{/privacy}","received_events_url":"https://api.github.com/users/zmc/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zmc","id":58307,"node_id":"MDQ6VXNlcjU4MzA3","avatar_url":"https://avatars1.githubusercontent.com/u/58307?v=4","gravatar_id":"","url":"https://api.github.com/users/zmc","html_url":"https://github.com/zmc","followers_url":"https://api.github.com/users/zmc/followers","following_url":"https://api.github.com/users/zmc/following{/other_user}","gists_url":"https://api.github.com/users/zmc/gists{/gist_id}","starred_url":"https://api.github.com/users/zmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmc/subscriptions","organizations_url":"https://api.github.com/users/zmc/orgs","repos_url":"https://api.github.com/users/zmc/repos","events_url":"https://api.github.com/users/zmc/events{/privacy}","received_events_url":"https://api.github.com/users/zmc/received_events","type":"User","site_admin":false},{"login":"guits","id":3717838,"node_id":"MDQ6VXNlcjM3MTc4Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3717838?v=4","gravatar_id":"","url":"https://api.github.com/users/guits","html_url":"https://github.com/guits","followers_url":"https://api.github.com/users/guits/followers","following_url":"https://api.github.com/users/guits/following{/other_user}","gists_url":"https://api.github.com/users/guits/gists{/gist_id}","starred_url":"https://api.github.com/users/guits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guits/subscriptions","organizations_url":"https://api.github.com/users/guits/orgs","repos_url":"https://api.github.com/users/guits/repos","events_url":"https://api.github.com/users/guits/events{/privacy}","received_events_url":"https://api.github.com/users/guits/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":974825238,"node_id":"MDU6TGFiZWw5NzQ4MjUyMzg=","url":"https://api.github.com/repos/ceph/ceph-ansible/labels/DNM","name":"DNM","color":"e85a93","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3426/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3426/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/3426/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/6b871c9e19ca0d5dcd15b34963f2a23bba5dc4c2","head":{"label":"ceph:wip-dashboard","ref":"wip-dashboard","sha":"6b871c9e19ca0d5dcd15b34963f2a23bba5dc4c2","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":17373313,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3MzMxMw==","name":"ceph-ansible","full_name":"ceph/ceph-ansible","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph-ansible","description":"Ansible playbooks to deploy Ceph, the distributed filesystem.","fork":false,"url":"https://api.github.com/repos/ceph/ceph-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-ansible/deployments","created_at":"2014-03-03T17:12:09Z","updated_at":"2018-12-14T12:42:45Z","pushed_at":"2018-12-14T15:35:15Z","git_url":"git://github.com/ceph/ceph-ansible.git","ssh_url":"git@github.com:ceph/ceph-ansible.git","clone_url":"https://github.com/ceph/ceph-ansible.git","svn_url":"https://github.com/ceph/ceph-ansible","homepage":"","size":6142,"stargazers_count":813,"watchers_count":813,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":538,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":538,"open_issues":197,"watchers":813,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"ffd56177e7616ba6345f1f1cc1f3b3e6ea7d66f3","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":17373313,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3MzMxMw==","name":"ceph-ansible","full_name":"ceph/ceph-ansible","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph-ansible","description":"Ansible playbooks to deploy Ceph, the distributed filesystem.","fork":false,"url":"https://api.github.com/repos/ceph/ceph-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-ansible/deployments","created_at":"2014-03-03T17:12:09Z","updated_at":"2018-12-14T12:42:45Z","pushed_at":"2018-12-14T15:35:15Z","git_url":"git://github.com/ceph/ceph-ansible.git","ssh_url":"git@github.com:ceph/ceph-ansible.git","clone_url":"https://github.com/ceph/ceph-ansible.git","svn_url":"https://github.com/ceph/ceph-ansible","homepage":"","size":6142,"stargazers_count":813,"watchers_count":813,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":538,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":538,"open_issues":197,"watchers":813,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3426"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/3426"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/3426"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/3426/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3426/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3426/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-ansible/statuses/6b871c9e19ca0d5dcd15b34963f2a23bba5dc4c2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zmc"}}