{"action":"closed","number":24966,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24966","id":181388409,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24966","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24966.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24966.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24966","number":24966,"state":"closed","locked":false,"title":"[node] Microsoft/TypeScript#23155 - Type error in Buffer.from()","user":{"login":"a-tarasyuk","id":509265,"avatar_url":"https://avatars0.githubusercontent.com/u/509265?v=4","gravatar_id":"","url":"https://api.github.com/users/a-tarasyuk","html_url":"https://github.com/a-tarasyuk","followers_url":"https://api.github.com/users/a-tarasyuk/followers","following_url":"https://api.github.com/users/a-tarasyuk/following{/other_user}","gists_url":"https://api.github.com/users/a-tarasyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/a-tarasyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-tarasyuk/subscriptions","organizations_url":"https://api.github.com/users/a-tarasyuk/orgs","repos_url":"https://api.github.com/users/a-tarasyuk/repos","events_url":"https://api.github.com/users/a-tarasyuk/events{/privacy}","received_events_url":"https://api.github.com/users/a-tarasyuk/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [ ] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: <<https://github.com/Microsoft/TypeScript/issues/23155>>\r\n- [ ] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n","created_at":"2018-04-13T05:19:53Z","updated_at":"2018-04-13T13:14:44Z","closed_at":"2018-04-13T13:14:44Z","merged_at":null,"merge_commit_sha":"cb3ae63e3ef6848921ee7b04813fef5bbd8ab966","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":397523192,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":684321576,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false},{"id":57534397,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/The%20Travis%20CI%20build%20failed","name":"The Travis CI build failed","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24966/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24966/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24966/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/4c39ef5329e333308ac9890aa5856534027bd01c","head":{"label":"a-tarasyuk:bug/type-error-in-buffer-from","ref":"bug/type-error-in-buffer-from","sha":"4c39ef5329e333308ac9890aa5856534027bd01c","user":{"login":"a-tarasyuk","id":509265,"avatar_url":"https://avatars0.githubusercontent.com/u/509265?v=4","gravatar_id":"","url":"https://api.github.com/users/a-tarasyuk","html_url":"https://github.com/a-tarasyuk","followers_url":"https://api.github.com/users/a-tarasyuk/followers","following_url":"https://api.github.com/users/a-tarasyuk/following{/other_user}","gists_url":"https://api.github.com/users/a-tarasyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/a-tarasyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-tarasyuk/subscriptions","organizations_url":"https://api.github.com/users/a-tarasyuk/orgs","repos_url":"https://api.github.com/users/a-tarasyuk/repos","events_url":"https://api.github.com/users/a-tarasyuk/events{/privacy}","received_events_url":"https://api.github.com/users/a-tarasyuk/received_events","type":"User","site_admin":false},"repo":{"id":129347129,"name":"DefinitelyTyped","full_name":"a-tarasyuk/DefinitelyTyped","owner":{"login":"a-tarasyuk","id":509265,"avatar_url":"https://avatars0.githubusercontent.com/u/509265?v=4","gravatar_id":"","url":"https://api.github.com/users/a-tarasyuk","html_url":"https://github.com/a-tarasyuk","followers_url":"https://api.github.com/users/a-tarasyuk/followers","following_url":"https://api.github.com/users/a-tarasyuk/following{/other_user}","gists_url":"https://api.github.com/users/a-tarasyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/a-tarasyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-tarasyuk/subscriptions","organizations_url":"https://api.github.com/users/a-tarasyuk/orgs","repos_url":"https://api.github.com/users/a-tarasyuk/repos","events_url":"https://api.github.com/users/a-tarasyuk/events{/privacy}","received_events_url":"https://api.github.com/users/a-tarasyuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-tarasyuk/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped","forks_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/a-tarasyuk/DefinitelyTyped/deployments","created_at":"2018-04-13T04:23:37Z","updated_at":"2018-04-13T04:24:01Z","pushed_at":"2018-04-13T12:53:59Z","git_url":"git://github.com/a-tarasyuk/DefinitelyTyped.git","ssh_url":"git@github.com:a-tarasyuk/DefinitelyTyped.git","clone_url":"https://github.com/a-tarasyuk/DefinitelyTyped.git","svn_url":"https://github.com/a-tarasyuk/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":310847,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"3b4991e3fa6e137833fd9b722abd6369842b236b","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-04-13T11:41:25Z","pushed_at":"2018-04-13T12:54:46Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":310808,"stargazers_count":15072,"watchers_count":15072,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12556,"mirror_url":null,"archived":false,"open_issues_count":2051,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12556,"open_issues":2051,"watchers":15072,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24966"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24966"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24966"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24966/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24966/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24966/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/4c39ef5329e333308ac9890aa5856534027bd01c"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":86,"deletions":85,"changed_files":10}}
{"actor":{"display_login":"a-tarasyuk"}}