{"action":"closed","number":576,"pull_request":{"url":"https://api.github.com/repos/tokio-rs/tokio/pulls/576","id":210874960,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwODc0OTYw","html_url":"https://github.com/tokio-rs/tokio/pull/576","diff_url":"https://github.com/tokio-rs/tokio/pull/576.diff","patch_url":"https://github.com/tokio-rs/tokio/pull/576.patch","issue_url":"https://api.github.com/repos/tokio-rs/tokio/issues/576","number":576,"state":"closed","locked":false,"title":"Fix non-terminating loop in `tokio_io::length_delimited::FramedWrite`","user":{"login":"hawkw","id":2796466,"node_id":"MDQ6VXNlcjI3OTY0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false},"body":"## Motivation\r\n\r\nThere is currently an issue in the deprecated\r\n`length_delimited::FramedWrite` implementation in the `tokio-io` crate:\r\nwhen the underlying writer returns `Ok(0)` (indicating that it can no\r\nlonger accept any additional bytes), the `FramedWrite` continues to loop\r\nrather than returning a `WriteZero` error. This issue does _not_ exist\r\nin the `FramedWrite` type added to `tokio::codec::length_delimited` in\r\n#575, as this is just a type alias for the `codec::FramedWrite` type\r\nwith a length-delimited `Encoder`, and the issue does not exist there.\r\n\r\n## Solution\r\n\r\nThis branch adds tests for this issue to the tests for both versions of\r\n`length_delimited`, and fixes the (deprecated)\r\n`tokio::io::length_delimited::FramedWrite` type so that both tests pass.\r\nSince the new `tokio::codec::length_delimited::FramedWrite` alias does\r\nnot have this bug, no additional work was necessary for its version of\r\nthe test to pass.\r\n\r\nFixes: #497, #500\r\n\r\nSigned-off-by: Eliza Weisman <eliza@buoyant.io>\r\n","created_at":"2018-08-25T00:24:43Z","updated_at":"2018-08-31T10:31:44Z","closed_at":"2018-08-31T10:31:44Z","merged_at":"2018-08-31T10:31:44Z","merge_commit_sha":"bc91bc5022ae76b43ece9f5dd5df89f517af56c4","assignee":{"login":"hawkw","id":2796466,"node_id":"MDQ6VXNlcjI3OTY0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false},"assignees":[{"login":"hawkw","id":2796466,"node_id":"MDQ6VXNlcjI3OTY0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tokio-rs/tokio/pulls/576/commits","review_comments_url":"https://api.github.com/repos/tokio-rs/tokio/pulls/576/comments","review_comment_url":"https://api.github.com/repos/tokio-rs/tokio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tokio-rs/tokio/issues/576/comments","statuses_url":"https://api.github.com/repos/tokio-rs/tokio/statuses/be090326e142e73de8b26f477dc7117cffc8ea1f","head":{"label":"hawkw:eliza/length-delimited-tests","ref":"eliza/length-delimited-tests","sha":"be090326e142e73de8b26f477dc7117cffc8ea1f","user":{"login":"hawkw","id":2796466,"node_id":"MDQ6VXNlcjI3OTY0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false},"repo":{"id":133991783,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5OTE3ODM=","name":"tokio","full_name":"hawkw/tokio","owner":{"login":"hawkw","id":2796466,"node_id":"MDQ6VXNlcjI3OTY0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hawkw/tokio","description":"A runtime for writing reliable, asynchronous, and slim applications with the Rust programming language.","fork":true,"url":"https://api.github.com/repos/hawkw/tokio","forks_url":"https://api.github.com/repos/hawkw/tokio/forks","keys_url":"https://api.github.com/repos/hawkw/tokio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkw/tokio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkw/tokio/teams","hooks_url":"https://api.github.com/repos/hawkw/tokio/hooks","issue_events_url":"https://api.github.com/repos/hawkw/tokio/issues/events{/number}","events_url":"https://api.github.com/repos/hawkw/tokio/events","assignees_url":"https://api.github.com/repos/hawkw/tokio/assignees{/user}","branches_url":"https://api.github.com/repos/hawkw/tokio/branches{/branch}","tags_url":"https://api.github.com/repos/hawkw/tokio/tags","blobs_url":"https://api.github.com/repos/hawkw/tokio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkw/tokio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkw/tokio/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkw/tokio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkw/tokio/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkw/tokio/languages","stargazers_url":"https://api.github.com/repos/hawkw/tokio/stargazers","contributors_url":"https://api.github.com/repos/hawkw/tokio/contributors","subscribers_url":"https://api.github.com/repos/hawkw/tokio/subscribers","subscription_url":"https://api.github.com/repos/hawkw/tokio/subscription","commits_url":"https://api.github.com/repos/hawkw/tokio/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkw/tokio/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkw/tokio/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkw/tokio/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkw/tokio/contents/{+path}","compare_url":"https://api.github.com/repos/hawkw/tokio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkw/tokio/merges","archive_url":"https://api.github.com/repos/hawkw/tokio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkw/tokio/downloads","issues_url":"https://api.github.com/repos/hawkw/tokio/issues{/number}","pulls_url":"https://api.github.com/repos/hawkw/tokio/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkw/tokio/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkw/tokio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkw/tokio/labels{/name}","releases_url":"https://api.github.com/repos/hawkw/tokio/releases{/id}","deployments_url":"https://api.github.com/repos/hawkw/tokio/deployments","created_at":"2018-05-18T18:41:50Z","updated_at":"2018-05-18T18:41:52Z","pushed_at":"2018-08-30T23:54:32Z","git_url":"git://github.com/hawkw/tokio.git","ssh_url":"git@github.com:hawkw/tokio.git","clone_url":"https://github.com/hawkw/tokio.git","svn_url":"https://github.com/hawkw/tokio","homepage":"https://tokio.rs","size":3568,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tokio-rs:master","ref":"master","sha":"a7b053372f220f66963fefe91690b0284d0921a0","user":{"login":"tokio-rs","id":20248544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ4NTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/20248544?v=4","gravatar_id":"","url":"https://api.github.com/users/tokio-rs","html_url":"https://github.com/tokio-rs","followers_url":"https://api.github.com/users/tokio-rs/followers","following_url":"https://api.github.com/users/tokio-rs/following{/other_user}","gists_url":"https://api.github.com/users/tokio-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tokio-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokio-rs/subscriptions","organizations_url":"https://api.github.com/users/tokio-rs/orgs","repos_url":"https://api.github.com/users/tokio-rs/repos","events_url":"https://api.github.com/users/tokio-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tokio-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":67836789,"node_id":"MDEwOlJlcG9zaXRvcnk2NzgzNjc4OQ==","name":"tokio","full_name":"tokio-rs/tokio","owner":{"login":"tokio-rs","id":20248544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ4NTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/20248544?v=4","gravatar_id":"","url":"https://api.github.com/users/tokio-rs","html_url":"https://github.com/tokio-rs","followers_url":"https://api.github.com/users/tokio-rs/followers","following_url":"https://api.github.com/users/tokio-rs/following{/other_user}","gists_url":"https://api.github.com/users/tokio-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tokio-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokio-rs/subscriptions","organizations_url":"https://api.github.com/users/tokio-rs/orgs","repos_url":"https://api.github.com/users/tokio-rs/repos","events_url":"https://api.github.com/users/tokio-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tokio-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tokio-rs/tokio","description":"A runtime for writing reliable, asynchronous, and slim applications with the Rust programming language.","fork":false,"url":"https://api.github.com/repos/tokio-rs/tokio","forks_url":"https://api.github.com/repos/tokio-rs/tokio/forks","keys_url":"https://api.github.com/repos/tokio-rs/tokio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tokio-rs/tokio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tokio-rs/tokio/teams","hooks_url":"https://api.github.com/repos/tokio-rs/tokio/hooks","issue_events_url":"https://api.github.com/repos/tokio-rs/tokio/issues/events{/number}","events_url":"https://api.github.com/repos/tokio-rs/tokio/events","assignees_url":"https://api.github.com/repos/tokio-rs/tokio/assignees{/user}","branches_url":"https://api.github.com/repos/tokio-rs/tokio/branches{/branch}","tags_url":"https://api.github.com/repos/tokio-rs/tokio/tags","blobs_url":"https://api.github.com/repos/tokio-rs/tokio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tokio-rs/tokio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tokio-rs/tokio/git/refs{/sha}","trees_url":"https://api.github.com/repos/tokio-rs/tokio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tokio-rs/tokio/statuses/{sha}","languages_url":"https://api.github.com/repos/tokio-rs/tokio/languages","stargazers_url":"https://api.github.com/repos/tokio-rs/tokio/stargazers","contributors_url":"https://api.github.com/repos/tokio-rs/tokio/contributors","subscribers_url":"https://api.github.com/repos/tokio-rs/tokio/subscribers","subscription_url":"https://api.github.com/repos/tokio-rs/tokio/subscription","commits_url":"https://api.github.com/repos/tokio-rs/tokio/commits{/sha}","git_commits_url":"https://api.github.com/repos/tokio-rs/tokio/git/commits{/sha}","comments_url":"https://api.github.com/repos/tokio-rs/tokio/comments{/number}","issue_comment_url":"https://api.github.com/repos/tokio-rs/tokio/issues/comments{/number}","contents_url":"https://api.github.com/repos/tokio-rs/tokio/contents/{+path}","compare_url":"https://api.github.com/repos/tokio-rs/tokio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tokio-rs/tokio/merges","archive_url":"https://api.github.com/repos/tokio-rs/tokio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tokio-rs/tokio/downloads","issues_url":"https://api.github.com/repos/tokio-rs/tokio/issues{/number}","pulls_url":"https://api.github.com/repos/tokio-rs/tokio/pulls{/number}","milestones_url":"https://api.github.com/repos/tokio-rs/tokio/milestones{/number}","notifications_url":"https://api.github.com/repos/tokio-rs/tokio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tokio-rs/tokio/labels{/name}","releases_url":"https://api.github.com/repos/tokio-rs/tokio/releases{/id}","deployments_url":"https://api.github.com/repos/tokio-rs/tokio/deployments","created_at":"2016-09-09T22:31:36Z","updated_at":"2018-08-31T09:00:51Z","pushed_at":"2018-08-31T10:31:44Z","git_url":"git://github.com/tokio-rs/tokio.git","ssh_url":"git@github.com:tokio-rs/tokio.git","clone_url":"https://github.com/tokio-rs/tokio.git","svn_url":"https://github.com/tokio-rs/tokio","homepage":"https://tokio.rs","size":3948,"stargazers_count":3028,"watchers_count":3028,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":198,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":198,"open_issues":78,"watchers":3028,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tokio-rs/tokio/pulls/576"},"html":{"href":"https://github.com/tokio-rs/tokio/pull/576"},"issue":{"href":"https://api.github.com/repos/tokio-rs/tokio/issues/576"},"comments":{"href":"https://api.github.com/repos/tokio-rs/tokio/issues/576/comments"},"review_comments":{"href":"https://api.github.com/repos/tokio-rs/tokio/pulls/576/comments"},"review_comment":{"href":"https://api.github.com/repos/tokio-rs/tokio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tokio-rs/tokio/pulls/576/commits"},"statuses":{"href":"https://api.github.com/repos/tokio-rs/tokio/statuses/be090326e142e73de8b26f477dc7117cffc8ea1f"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tobz","id":222615,"node_id":"MDQ6VXNlcjIyMjYxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/222615?v=4","gravatar_id":"","url":"https://api.github.com/users/tobz","html_url":"https://github.com/tobz","followers_url":"https://api.github.com/users/tobz/followers","following_url":"https://api.github.com/users/tobz/following{/other_user}","gists_url":"https://api.github.com/users/tobz/gists{/gist_id}","starred_url":"https://api.github.com/users/tobz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobz/subscriptions","organizations_url":"https://api.github.com/users/tobz/orgs","repos_url":"https://api.github.com/users/tobz/repos","events_url":"https://api.github.com/users/tobz/events{/privacy}","received_events_url":"https://api.github.com/users/tobz/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":26,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"tobz"}}