{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls/comments/198089793","pull_request_review_id":131953512,"id":198089793,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODA4OTc5Mw==","diff_hunk":"@@ -23,6 +25,7 @@ class IconGenerator {\n     companion object {\n         private val TEXT_SIZE_DP = 36f\n         private val DEFAULT_ICON_CHAR = '?'\n+        private val SEARCH_ICON_FRAME = 0.15","path":"app/src/main/java/org/mozilla/focus/shortcut/IconGenerator.kt","position":15,"original_position":15,"commit_id":"5dd892877d6d90eb176e6c5f9ace34d2054bbe61","original_commit_id":"5dd892877d6d90eb176e6c5f9ace34d2054bbe61","user":{"login":"sputnikci","id":15047461,"node_id":"MDQ6VXNlcjE1MDQ3NDYx","avatar_url":"https://avatars2.githubusercontent.com/u/15047461?v=4","gravatar_id":"","url":"https://api.github.com/users/sputnikci","html_url":"https://github.com/sputnikci","followers_url":"https://api.github.com/users/sputnikci/followers","following_url":"https://api.github.com/users/sputnikci/following{/other_user}","gists_url":"https://api.github.com/users/sputnikci/gists{/gist_id}","starred_url":"https://api.github.com/users/sputnikci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sputnikci/subscriptions","organizations_url":"https://api.github.com/users/sputnikci/orgs","repos_url":"https://api.github.com/users/sputnikci/repos","events_url":"https://api.github.com/users/sputnikci/events{/privacy}","received_events_url":"https://api.github.com/users/sputnikci/received_events","type":"User","site_admin":false},"body":"\\[detekt\\] INFO: \\[style/MagicNumber\\] Report magic numbers\\. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is\\. It's better to declare such numbers as constants and give them a proper name\\. By default, \\-1, 0, 1, and 2 are not considered to be magic numbers\\.","created_at":"2018-06-26T10:15:39Z","updated_at":"2018-06-26T10:15:39Z","html_url":"https://github.com/mozilla-mobile/focus-android/pull/2773#discussion_r198089793","pull_request_url":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls/2773","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls/comments/198089793"},"html":{"href":"https://github.com/mozilla-mobile/focus-android/pull/2773#discussion_r198089793"},"pull_request":{"href":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls/2773"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls/2773","id":196738211,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NzM4MjEx","html_url":"https://github.com/mozilla-mobile/focus-android/pull/2773","diff_url":"https://github.com/mozilla-mobile/focus-android/pull/2773.diff","patch_url":"https://github.com/mozilla-mobile/focus-android/pull/2773.patch","issue_url":"https://api.github.com/repos/mozilla-mobile/focus-android/issues/2773","number":2773,"state":"open","locked":false,"title":"Closes #1982 - generic icon for each custom search engine","user":{"login":"kai-chi","id":32437462,"node_id":"MDQ6VXNlcjMyNDM3NDYy","avatar_url":"https://avatars1.githubusercontent.com/u/32437462?v=4","gravatar_id":"","url":"https://api.github.com/users/kai-chi","html_url":"https://github.com/kai-chi","followers_url":"https://api.github.com/users/kai-chi/followers","following_url":"https://api.github.com/users/kai-chi/following{/other_user}","gists_url":"https://api.github.com/users/kai-chi/gists{/gist_id}","starred_url":"https://api.github.com/users/kai-chi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kai-chi/subscriptions","organizations_url":"https://api.github.com/users/kai-chi/orgs","repos_url":"https://api.github.com/users/kai-chi/repos","events_url":"https://api.github.com/users/kai-chi/events{/privacy}","received_events_url":"https://api.github.com/users/kai-chi/received_events","type":"User","site_admin":false},"body":"This changes the icon for custom search engine to a generic one. \r\nScreenshot:\r\n<img src=\"https://user-images.githubusercontent.com/32437462/41778864-4d1763e8-7630-11e8-8e26-9664bda52bb6.png\" width=300>\r\n","created_at":"2018-06-22T13:27:30Z","updated_at":"2018-06-26T10:15:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db983d287a744ea34b8b18347c4cf4934ba25d7f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls/2773/commits","review_comments_url":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls/2773/comments","review_comment_url":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-mobile/focus-android/issues/2773/comments","statuses_url":"https://api.github.com/repos/mozilla-mobile/focus-android/statuses/5dd892877d6d90eb176e6c5f9ace34d2054bbe61","head":{"label":"kai-chi:i-1982","ref":"i-1982","sha":"5dd892877d6d90eb176e6c5f9ace34d2054bbe61","user":{"login":"kai-chi","id":32437462,"node_id":"MDQ6VXNlcjMyNDM3NDYy","avatar_url":"https://avatars1.githubusercontent.com/u/32437462?v=4","gravatar_id":"","url":"https://api.github.com/users/kai-chi","html_url":"https://github.com/kai-chi","followers_url":"https://api.github.com/users/kai-chi/followers","following_url":"https://api.github.com/users/kai-chi/following{/other_user}","gists_url":"https://api.github.com/users/kai-chi/gists{/gist_id}","starred_url":"https://api.github.com/users/kai-chi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kai-chi/subscriptions","organizations_url":"https://api.github.com/users/kai-chi/orgs","repos_url":"https://api.github.com/users/kai-chi/repos","events_url":"https://api.github.com/users/kai-chi/events{/privacy}","received_events_url":"https://api.github.com/users/kai-chi/received_events","type":"User","site_admin":false},"repo":{"id":119878562,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4Nzg1NjI=","name":"focus-android","full_name":"kai-chi/focus-android","owner":{"login":"kai-chi","id":32437462,"node_id":"MDQ6VXNlcjMyNDM3NDYy","avatar_url":"https://avatars1.githubusercontent.com/u/32437462?v=4","gravatar_id":"","url":"https://api.github.com/users/kai-chi","html_url":"https://github.com/kai-chi","followers_url":"https://api.github.com/users/kai-chi/followers","following_url":"https://api.github.com/users/kai-chi/following{/other_user}","gists_url":"https://api.github.com/users/kai-chi/gists{/gist_id}","starred_url":"https://api.github.com/users/kai-chi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kai-chi/subscriptions","organizations_url":"https://api.github.com/users/kai-chi/orgs","repos_url":"https://api.github.com/users/kai-chi/repos","events_url":"https://api.github.com/users/kai-chi/events{/privacy}","received_events_url":"https://api.github.com/users/kai-chi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kai-chi/focus-android","description":"Firefox Focus: The privacy browser - Browse like no one’s watching.","fork":true,"url":"https://api.github.com/repos/kai-chi/focus-android","forks_url":"https://api.github.com/repos/kai-chi/focus-android/forks","keys_url":"https://api.github.com/repos/kai-chi/focus-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kai-chi/focus-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kai-chi/focus-android/teams","hooks_url":"https://api.github.com/repos/kai-chi/focus-android/hooks","issue_events_url":"https://api.github.com/repos/kai-chi/focus-android/issues/events{/number}","events_url":"https://api.github.com/repos/kai-chi/focus-android/events","assignees_url":"https://api.github.com/repos/kai-chi/focus-android/assignees{/user}","branches_url":"https://api.github.com/repos/kai-chi/focus-android/branches{/branch}","tags_url":"https://api.github.com/repos/kai-chi/focus-android/tags","blobs_url":"https://api.github.com/repos/kai-chi/focus-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kai-chi/focus-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kai-chi/focus-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/kai-chi/focus-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kai-chi/focus-android/statuses/{sha}","languages_url":"https://api.github.com/repos/kai-chi/focus-android/languages","stargazers_url":"https://api.github.com/repos/kai-chi/focus-android/stargazers","contributors_url":"https://api.github.com/repos/kai-chi/focus-android/contributors","subscribers_url":"https://api.github.com/repos/kai-chi/focus-android/subscribers","subscription_url":"https://api.github.com/repos/kai-chi/focus-android/subscription","commits_url":"https://api.github.com/repos/kai-chi/focus-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/kai-chi/focus-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/kai-chi/focus-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/kai-chi/focus-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/kai-chi/focus-android/contents/{+path}","compare_url":"https://api.github.com/repos/kai-chi/focus-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kai-chi/focus-android/merges","archive_url":"https://api.github.com/repos/kai-chi/focus-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kai-chi/focus-android/downloads","issues_url":"https://api.github.com/repos/kai-chi/focus-android/issues{/number}","pulls_url":"https://api.github.com/repos/kai-chi/focus-android/pulls{/number}","milestones_url":"https://api.github.com/repos/kai-chi/focus-android/milestones{/number}","notifications_url":"https://api.github.com/repos/kai-chi/focus-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kai-chi/focus-android/labels{/name}","releases_url":"https://api.github.com/repos/kai-chi/focus-android/releases{/id}","deployments_url":"https://api.github.com/repos/kai-chi/focus-android/deployments","created_at":"2018-02-01T18:49:55Z","updated_at":"2018-05-23T08:39:56Z","pushed_at":"2018-06-26T09:38:31Z","git_url":"git://github.com/kai-chi/focus-android.git","ssh_url":"git@github.com:kai-chi/focus-android.git","clone_url":"https://github.com/kai-chi/focus-android.git","svn_url":"https://github.com/kai-chi/focus-android","homepage":"","size":160920,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-mobile:master","ref":"master","sha":"3618b59c15f6b5b56091c553aa5dd9eff1547484","user":{"login":"mozilla-mobile","id":22351667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3","avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":75990052,"node_id":"MDEwOlJlcG9zaXRvcnk3NTk5MDA1Mg==","name":"focus-android","full_name":"mozilla-mobile/focus-android","owner":{"login":"mozilla-mobile","id":22351667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3","avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-mobile/focus-android","description":"Firefox Focus: The privacy browser - Browse like no one’s watching.","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/focus-android","forks_url":"https://api.github.com/repos/mozilla-mobile/focus-android/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/focus-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/focus-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/focus-android/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/focus-android/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/focus-android/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/focus-android/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/focus-android/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/focus-android/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/focus-android/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/focus-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/focus-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/focus-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/focus-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/focus-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/focus-android/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/focus-android/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/focus-android/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/focus-android/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/focus-android/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/focus-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/focus-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/focus-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/focus-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/focus-android/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/focus-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/focus-android/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/focus-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/focus-android/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/focus-android/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/focus-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/focus-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/focus-android/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/focus-android/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/focus-android/deployments","created_at":"2016-12-09T01:31:11Z","updated_at":"2018-06-26T07:00:54Z","pushed_at":"2018-06-26T09:38:33Z","git_url":"git://github.com/mozilla-mobile/focus-android.git","ssh_url":"git@github.com:mozilla-mobile/focus-android.git","clone_url":"https://github.com/mozilla-mobile/focus-android.git","svn_url":"https://github.com/mozilla-mobile/focus-android","homepage":"","size":161300,"stargazers_count":837,"watchers_count":837,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":312,"mirror_url":null,"archived":false,"open_issues_count":396,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":312,"open_issues":396,"watchers":837,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls/2773"},"html":{"href":"https://github.com/mozilla-mobile/focus-android/pull/2773"},"issue":{"href":"https://api.github.com/repos/mozilla-mobile/focus-android/issues/2773"},"comments":{"href":"https://api.github.com/repos/mozilla-mobile/focus-android/issues/2773/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls/2773/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-mobile/focus-android/pulls/2773/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-mobile/focus-android/statuses/5dd892877d6d90eb176e6c5f9ace34d2054bbe61"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sputnikci"}}