{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/hono/pulls/comments/229024923","pull_request_review_id":169422972,"id":229024923,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTAyNDkyMw==","diff_hunk":"@@ -1209,24 +1214,34 @@ protected final void onCommandReceived(\n         // example: control/DEFAULT_TENANT/4711/req/xyz/light\n         final String topic = String.format(\"%s/%s/%s/%s/%s/%s\", subscription.getEndpoint(), tenantId, deviceId,\n                 subscription.getRequestPart(), command.getRequestId(), command.getName());\n+        LOG.debug(\"Publishing command to device [tenant-id: {}, device-id: {}, MQTT client-id: {}, QoS: {}]\",\n+                subscription.getTenant(), subscription.getDeviceId(), endpoint.clientIdentifier(), qos);\n         endpoint.publish(topic, command.getPayload(), qos, false, false);\n+        endpoint.publishAcknowledgeHandler(\n+                messageId -> afterCommandPublished(endpoint, qos, subscription, topic, commandContext));","path":"adapters/mqtt-vertx-base/src/main/java/org/eclipse/hono/adapter/mqtt/AbstractVertxBasedMqttProtocolAdapter.java","position":126,"original_position":126,"commit_id":"3b1ff01ec5c4df730c416cbe8436412d3fe10c59","original_commit_id":"3b1ff01ec5c4df730c416cbe8436412d3fe10c59","user":{"login":"sophokles73","id":5682135,"node_id":"MDQ6VXNlcjU2ODIxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5682135?v=4","gravatar_id":"","url":"https://api.github.com/users/sophokles73","html_url":"https://github.com/sophokles73","followers_url":"https://api.github.com/users/sophokles73/followers","following_url":"https://api.github.com/users/sophokles73/following{/other_user}","gists_url":"https://api.github.com/users/sophokles73/gists{/gist_id}","starred_url":"https://api.github.com/users/sophokles73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sophokles73/subscriptions","organizations_url":"https://api.github.com/users/sophokles73/orgs","repos_url":"https://api.github.com/users/sophokles73/repos","events_url":"https://api.github.com/users/sophokles73/events{/privacy}","received_events_url":"https://api.github.com/users/sophokles73/received_events","type":"User","site_admin":false},"body":"this is not how the *publishAcknowledgeHandler* works, is it? The handler is supposed to process the message ID that is being acknowledged by the peer. So I guess it needs to be passed in to the handler method as a parameter. This, however, requires that you keep track of the unacknowledged message IDs somewhere ...","created_at":"2018-10-29T17:28:58Z","updated_at":"2018-10-29T17:29:03Z","html_url":"https://github.com/eclipse/hono/pull/869#discussion_r229024923","pull_request_url":"https://api.github.com/repos/eclipse/hono/pulls/869","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/hono/pulls/comments/229024923"},"html":{"href":"https://github.com/eclipse/hono/pull/869#discussion_r229024923"},"pull_request":{"href":"https://api.github.com/repos/eclipse/hono/pulls/869"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/hono/pulls/869","id":226632125,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjMyMTI1","html_url":"https://github.com/eclipse/hono/pull/869","diff_url":"https://github.com/eclipse/hono/pull/869.diff","patch_url":"https://github.com/eclipse/hono/pull/869.patch","issue_url":"https://api.github.com/repos/eclipse/hono/issues/869","number":869,"state":"open","locked":false,"title":"[#832] Added support to publish commands with QoS 1 in Mqtt adapter","user":{"login":"kaniyan","id":18659982,"node_id":"MDQ6VXNlcjE4NjU5OTgy","avatar_url":"https://avatars3.githubusercontent.com/u/18659982?v=4","gravatar_id":"","url":"https://api.github.com/users/kaniyan","html_url":"https://github.com/kaniyan","followers_url":"https://api.github.com/users/kaniyan/followers","following_url":"https://api.github.com/users/kaniyan/following{/other_user}","gists_url":"https://api.github.com/users/kaniyan/gists{/gist_id}","starred_url":"https://api.github.com/users/kaniyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaniyan/subscriptions","organizations_url":"https://api.github.com/users/kaniyan/orgs","repos_url":"https://api.github.com/users/kaniyan/repos","events_url":"https://api.github.com/users/kaniyan/events{/privacy}","received_events_url":"https://api.github.com/users/kaniyan/received_events","type":"User","site_admin":false},"body":"With this PR, MQTT adapter supports publishing commands with QoS 1. If a device subscribes with QoS 1 to a control endpoint, then MQTT adapter also publishes commands to that device with QoS 1. When a device subscribes with QoS 0, then commands are published using QoS 0.\r\n\r\n","created_at":"2018-10-29T16:40:04Z","updated_at":"2018-10-29T17:29:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"721a6489bfa4b6eb972238c6105d06f5e9362574","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/hono/pulls/869/commits","review_comments_url":"https://api.github.com/repos/eclipse/hono/pulls/869/comments","review_comment_url":"https://api.github.com/repos/eclipse/hono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/hono/issues/869/comments","statuses_url":"https://api.github.com/repos/eclipse/hono/statuses/3b1ff01ec5c4df730c416cbe8436412d3fe10c59","head":{"label":"bsinno:#832_MQTT_Adapter_publish_commands_with_QoS1","ref":"#832_MQTT_Adapter_publish_commands_with_QoS1","sha":"3b1ff01ec5c4df730c416cbe8436412d3fe10c59","user":{"login":"bsinno","id":9215699,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyMTU2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"repo":{"id":51764062,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc2NDA2Mg==","name":"hono","full_name":"bsinno/hono","private":false,"owner":{"login":"bsinno","id":9215699,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyMTU2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bsinno/hono","description":"Hono project","fork":true,"url":"https://api.github.com/repos/bsinno/hono","forks_url":"https://api.github.com/repos/bsinno/hono/forks","keys_url":"https://api.github.com/repos/bsinno/hono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsinno/hono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsinno/hono/teams","hooks_url":"https://api.github.com/repos/bsinno/hono/hooks","issue_events_url":"https://api.github.com/repos/bsinno/hono/issues/events{/number}","events_url":"https://api.github.com/repos/bsinno/hono/events","assignees_url":"https://api.github.com/repos/bsinno/hono/assignees{/user}","branches_url":"https://api.github.com/repos/bsinno/hono/branches{/branch}","tags_url":"https://api.github.com/repos/bsinno/hono/tags","blobs_url":"https://api.github.com/repos/bsinno/hono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsinno/hono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsinno/hono/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsinno/hono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsinno/hono/statuses/{sha}","languages_url":"https://api.github.com/repos/bsinno/hono/languages","stargazers_url":"https://api.github.com/repos/bsinno/hono/stargazers","contributors_url":"https://api.github.com/repos/bsinno/hono/contributors","subscribers_url":"https://api.github.com/repos/bsinno/hono/subscribers","subscription_url":"https://api.github.com/repos/bsinno/hono/subscription","commits_url":"https://api.github.com/repos/bsinno/hono/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsinno/hono/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsinno/hono/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsinno/hono/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsinno/hono/contents/{+path}","compare_url":"https://api.github.com/repos/bsinno/hono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsinno/hono/merges","archive_url":"https://api.github.com/repos/bsinno/hono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsinno/hono/downloads","issues_url":"https://api.github.com/repos/bsinno/hono/issues{/number}","pulls_url":"https://api.github.com/repos/bsinno/hono/pulls{/number}","milestones_url":"https://api.github.com/repos/bsinno/hono/milestones{/number}","notifications_url":"https://api.github.com/repos/bsinno/hono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsinno/hono/labels{/name}","releases_url":"https://api.github.com/repos/bsinno/hono/releases{/id}","deployments_url":"https://api.github.com/repos/bsinno/hono/deployments","created_at":"2016-02-15T15:18:09Z","updated_at":"2018-10-26T22:26:17Z","pushed_at":"2018-10-29T16:40:30Z","git_url":"git://github.com/bsinno/hono.git","ssh_url":"git@github.com:bsinno/hono.git","clone_url":"https://github.com/bsinno/hono.git","svn_url":"https://github.com/bsinno/hono","homepage":null,"size":17028,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"337c5fae48eeb52718a0c662033c8e11af60bf5e","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":51307016,"node_id":"MDEwOlJlcG9zaXRvcnk1MTMwNzAxNg==","name":"hono","full_name":"eclipse/hono","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/hono","description":"Eclipse Hono™ Project","fork":false,"url":"https://api.github.com/repos/eclipse/hono","forks_url":"https://api.github.com/repos/eclipse/hono/forks","keys_url":"https://api.github.com/repos/eclipse/hono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/hono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/hono/teams","hooks_url":"https://api.github.com/repos/eclipse/hono/hooks","issue_events_url":"https://api.github.com/repos/eclipse/hono/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/hono/events","assignees_url":"https://api.github.com/repos/eclipse/hono/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/hono/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/hono/tags","blobs_url":"https://api.github.com/repos/eclipse/hono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/hono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/hono/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/hono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/hono/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/hono/languages","stargazers_url":"https://api.github.com/repos/eclipse/hono/stargazers","contributors_url":"https://api.github.com/repos/eclipse/hono/contributors","subscribers_url":"https://api.github.com/repos/eclipse/hono/subscribers","subscription_url":"https://api.github.com/repos/eclipse/hono/subscription","commits_url":"https://api.github.com/repos/eclipse/hono/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/hono/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/hono/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/hono/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/hono/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/hono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/hono/merges","archive_url":"https://api.github.com/repos/eclipse/hono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/hono/downloads","issues_url":"https://api.github.com/repos/eclipse/hono/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/hono/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/hono/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/hono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/hono/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/hono/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/hono/deployments","created_at":"2016-02-08T15:45:28Z","updated_at":"2018-10-29T13:24:32Z","pushed_at":"2018-10-29T16:40:32Z","git_url":"git://github.com/eclipse/hono.git","ssh_url":"git@github.com:eclipse/hono.git","clone_url":"https://github.com/eclipse/hono.git","svn_url":"https://github.com/eclipse/hono","homepage":"http://www.eclipse.org/hono","size":16823,"stargazers_count":164,"watchers_count":164,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":54,"open_issues":69,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/hono/pulls/869"},"html":{"href":"https://github.com/eclipse/hono/pull/869"},"issue":{"href":"https://api.github.com/repos/eclipse/hono/issues/869"},"comments":{"href":"https://api.github.com/repos/eclipse/hono/issues/869/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/hono/pulls/869/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/hono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/hono/pulls/869/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/hono/statuses/3b1ff01ec5c4df730c416cbe8436412d3fe10c59"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sophokles73"}}