{"action":"created","comment":{"url":"https://api.github.com/repos/rapidsai/cudf/pulls/comments/239641887","pull_request_review_id":182073579,"id":239641887,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTY0MTg4Nw==","diff_hunk":"@@ -75,9 +75,9 @@ typedef struct {\n   bool\t\t\tdayfirst;\t\t\t\t\t// is the first value the day?  DD/MM  versus MM/DD\n \n   char\t\t\t*compression;\t\t\t\t// specify the type of compression\n-  char\t\t\t*thousands;\t\t\t\t\t// single character\t\ta separate within numeric data  - if this matches the delimiter then system will return NULL\n+  char\t\t\t*thousands;\t\t\t\t\t/**<  pointer to a single character that separates thousands in numeric data. If this matches the delimiter then system will return NULL */","path":"cpp/include/cudf/io_types.h","position":5,"original_position":5,"commit_id":"2479ada8b7f1ca0c3778922190035c6f9141074a","original_commit_id":"2479ada8b7f1ca0c3778922190035c6f9141074a","user":{"login":"harrism","id":783069,"node_id":"MDQ6VXNlcjc4MzA2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/783069?v=4","gravatar_id":"","url":"https://api.github.com/users/harrism","html_url":"https://github.com/harrism","followers_url":"https://api.github.com/users/harrism/followers","following_url":"https://api.github.com/users/harrism/following{/other_user}","gists_url":"https://api.github.com/users/harrism/gists{/gist_id}","starred_url":"https://api.github.com/users/harrism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrism/subscriptions","organizations_url":"https://api.github.com/users/harrism/orgs","repos_url":"https://api.github.com/users/harrism/repos","events_url":"https://api.github.com/users/harrism/events{/privacy}","received_events_url":"https://api.github.com/users/harrism/received_events","type":"User","site_admin":false},"body":"In fact, it looks like you indeed return `GDF_INVALID_API_CALL` in this case. Please update comment.","created_at":"2018-12-06T22:40:30Z","updated_at":"2018-12-06T22:41:18Z","html_url":"https://github.com/rapidsai/cudf/pull/455#discussion_r239641887","pull_request_url":"https://api.github.com/repos/rapidsai/cudf/pulls/455","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/comments/239641887"},"html":{"href":"https://github.com/rapidsai/cudf/pull/455#discussion_r239641887"},"pull_request":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/455"}},"in_reply_to_id":239319870},"pull_request":{"url":"https://api.github.com/repos/rapidsai/cudf/pulls/455","id":236322438,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzIyNDM4","html_url":"https://github.com/rapidsai/cudf/pull/455","diff_url":"https://github.com/rapidsai/cudf/pull/455.diff","patch_url":"https://github.com/rapidsai/cudf/pull/455.patch","issue_url":"https://api.github.com/repos/rapidsai/cudf/issues/455","number":455,"state":"open","locked":false,"title":"[REVIEW] read_csv support for user-specified decimal point and thousands separator ","user":{"login":"vuule","id":16005690,"node_id":"MDQ6VXNlcjE2MDA1Njkw","avatar_url":"https://avatars2.githubusercontent.com/u/16005690?v=4","gravatar_id":"","url":"https://api.github.com/users/vuule","html_url":"https://github.com/vuule","followers_url":"https://api.github.com/users/vuule/followers","following_url":"https://api.github.com/users/vuule/following{/other_user}","gists_url":"https://api.github.com/users/vuule/gists{/gist_id}","starred_url":"https://api.github.com/users/vuule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuule/subscriptions","organizations_url":"https://api.github.com/users/vuule/orgs","repos_url":"https://api.github.com/users/vuule/repos","events_url":"https://api.github.com/users/vuule/events{/privacy}","received_events_url":"https://api.github.com/users/vuule/received_events","type":"User","site_admin":false},"body":"Implemented support for custom decimal point and thousands separator. \r\n\r\nInterface details:\r\n* New parameters are optional, default decimal point is '.', default thousands separator is None.\r\n* Decimal point cannot be the same as the delimiter.\r\n\r\nImplementation details:\r\n* Thousands separator is not applied to date/time parsing.\r\n* Fixed the old behavior where comma was implicitly used as a thousands separator for both integers and floats. New default is consistent with pandas implementation.\r\n* Added separate tests for the two options.\r\n* Reduced the block size due to memory constraints - the added kernel parameters (decimal, thousands) caused failure with the original block size.","created_at":"2018-12-05T21:05:46Z","updated_at":"2018-12-06T22:41:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62c63bce6986371ad6b2f5094aa69f41d5fb092f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rapidsai/cudf/pulls/455/commits","review_comments_url":"https://api.github.com/repos/rapidsai/cudf/pulls/455/comments","review_comment_url":"https://api.github.com/repos/rapidsai/cudf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapidsai/cudf/issues/455/comments","statuses_url":"https://api.github.com/repos/rapidsai/cudf/statuses/2479ada8b7f1ca0c3778922190035c6f9141074a","head":{"label":"vuule:enh-ext-csv-num-format","ref":"enh-ext-csv-num-format","sha":"2479ada8b7f1ca0c3778922190035c6f9141074a","user":{"login":"vuule","id":16005690,"node_id":"MDQ6VXNlcjE2MDA1Njkw","avatar_url":"https://avatars2.githubusercontent.com/u/16005690?v=4","gravatar_id":"","url":"https://api.github.com/users/vuule","html_url":"https://github.com/vuule","followers_url":"https://api.github.com/users/vuule/followers","following_url":"https://api.github.com/users/vuule/following{/other_user}","gists_url":"https://api.github.com/users/vuule/gists{/gist_id}","starred_url":"https://api.github.com/users/vuule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuule/subscriptions","organizations_url":"https://api.github.com/users/vuule/orgs","repos_url":"https://api.github.com/users/vuule/repos","events_url":"https://api.github.com/users/vuule/events{/privacy}","received_events_url":"https://api.github.com/users/vuule/received_events","type":"User","site_admin":false},"repo":{"id":160574847,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA1NzQ4NDc=","name":"cudf","full_name":"vuule/cudf","private":false,"owner":{"login":"vuule","id":16005690,"node_id":"MDQ6VXNlcjE2MDA1Njkw","avatar_url":"https://avatars2.githubusercontent.com/u/16005690?v=4","gravatar_id":"","url":"https://api.github.com/users/vuule","html_url":"https://github.com/vuule","followers_url":"https://api.github.com/users/vuule/followers","following_url":"https://api.github.com/users/vuule/following{/other_user}","gists_url":"https://api.github.com/users/vuule/gists{/gist_id}","starred_url":"https://api.github.com/users/vuule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuule/subscriptions","organizations_url":"https://api.github.com/users/vuule/orgs","repos_url":"https://api.github.com/users/vuule/repos","events_url":"https://api.github.com/users/vuule/events{/privacy}","received_events_url":"https://api.github.com/users/vuule/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vuule/cudf","description":"cuDF - GPU DataFrame Library","fork":true,"url":"https://api.github.com/repos/vuule/cudf","forks_url":"https://api.github.com/repos/vuule/cudf/forks","keys_url":"https://api.github.com/repos/vuule/cudf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuule/cudf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuule/cudf/teams","hooks_url":"https://api.github.com/repos/vuule/cudf/hooks","issue_events_url":"https://api.github.com/repos/vuule/cudf/issues/events{/number}","events_url":"https://api.github.com/repos/vuule/cudf/events","assignees_url":"https://api.github.com/repos/vuule/cudf/assignees{/user}","branches_url":"https://api.github.com/repos/vuule/cudf/branches{/branch}","tags_url":"https://api.github.com/repos/vuule/cudf/tags","blobs_url":"https://api.github.com/repos/vuule/cudf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuule/cudf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuule/cudf/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuule/cudf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuule/cudf/statuses/{sha}","languages_url":"https://api.github.com/repos/vuule/cudf/languages","stargazers_url":"https://api.github.com/repos/vuule/cudf/stargazers","contributors_url":"https://api.github.com/repos/vuule/cudf/contributors","subscribers_url":"https://api.github.com/repos/vuule/cudf/subscribers","subscription_url":"https://api.github.com/repos/vuule/cudf/subscription","commits_url":"https://api.github.com/repos/vuule/cudf/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuule/cudf/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuule/cudf/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuule/cudf/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuule/cudf/contents/{+path}","compare_url":"https://api.github.com/repos/vuule/cudf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuule/cudf/merges","archive_url":"https://api.github.com/repos/vuule/cudf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuule/cudf/downloads","issues_url":"https://api.github.com/repos/vuule/cudf/issues{/number}","pulls_url":"https://api.github.com/repos/vuule/cudf/pulls{/number}","milestones_url":"https://api.github.com/repos/vuule/cudf/milestones{/number}","notifications_url":"https://api.github.com/repos/vuule/cudf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuule/cudf/labels{/name}","releases_url":"https://api.github.com/repos/vuule/cudf/releases{/id}","deployments_url":"https://api.github.com/repos/vuule/cudf/deployments","created_at":"2018-12-05T20:32:05Z","updated_at":"2018-12-05T20:32:08Z","pushed_at":"2018-12-05T20:47:22Z","git_url":"git://github.com/vuule/cudf.git","ssh_url":"git@github.com:vuule/cudf.git","clone_url":"https://github.com/vuule/cudf.git","svn_url":"https://github.com/vuule/cudf","homepage":"http://rapids.ai","size":12900,"stargazers_count":0,"watchers_count":0,"language":"Cuda","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rapidsai:master","ref":"master","sha":"0dc1467609047d9343a54ea50f0c940d17b757b8","user":{"login":"rapidsai","id":43887749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/43887749?v=4","gravatar_id":"","url":"https://api.github.com/users/rapidsai","html_url":"https://github.com/rapidsai","followers_url":"https://api.github.com/users/rapidsai/followers","following_url":"https://api.github.com/users/rapidsai/following{/other_user}","gists_url":"https://api.github.com/users/rapidsai/gists{/gist_id}","starred_url":"https://api.github.com/users/rapidsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapidsai/subscriptions","organizations_url":"https://api.github.com/users/rapidsai/orgs","repos_url":"https://api.github.com/users/rapidsai/repos","events_url":"https://api.github.com/users/rapidsai/events{/privacy}","received_events_url":"https://api.github.com/users/rapidsai/received_events","type":"Organization","site_admin":false},"repo":{"id":90506918,"node_id":"MDEwOlJlcG9zaXRvcnk5MDUwNjkxOA==","name":"cudf","full_name":"rapidsai/cudf","private":false,"owner":{"login":"rapidsai","id":43887749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/43887749?v=4","gravatar_id":"","url":"https://api.github.com/users/rapidsai","html_url":"https://github.com/rapidsai","followers_url":"https://api.github.com/users/rapidsai/followers","following_url":"https://api.github.com/users/rapidsai/following{/other_user}","gists_url":"https://api.github.com/users/rapidsai/gists{/gist_id}","starred_url":"https://api.github.com/users/rapidsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapidsai/subscriptions","organizations_url":"https://api.github.com/users/rapidsai/orgs","repos_url":"https://api.github.com/users/rapidsai/repos","events_url":"https://api.github.com/users/rapidsai/events{/privacy}","received_events_url":"https://api.github.com/users/rapidsai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rapidsai/cudf","description":"cuDF - GPU DataFrame Library","fork":false,"url":"https://api.github.com/repos/rapidsai/cudf","forks_url":"https://api.github.com/repos/rapidsai/cudf/forks","keys_url":"https://api.github.com/repos/rapidsai/cudf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapidsai/cudf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapidsai/cudf/teams","hooks_url":"https://api.github.com/repos/rapidsai/cudf/hooks","issue_events_url":"https://api.github.com/repos/rapidsai/cudf/issues/events{/number}","events_url":"https://api.github.com/repos/rapidsai/cudf/events","assignees_url":"https://api.github.com/repos/rapidsai/cudf/assignees{/user}","branches_url":"https://api.github.com/repos/rapidsai/cudf/branches{/branch}","tags_url":"https://api.github.com/repos/rapidsai/cudf/tags","blobs_url":"https://api.github.com/repos/rapidsai/cudf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapidsai/cudf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapidsai/cudf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapidsai/cudf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapidsai/cudf/statuses/{sha}","languages_url":"https://api.github.com/repos/rapidsai/cudf/languages","stargazers_url":"https://api.github.com/repos/rapidsai/cudf/stargazers","contributors_url":"https://api.github.com/repos/rapidsai/cudf/contributors","subscribers_url":"https://api.github.com/repos/rapidsai/cudf/subscribers","subscription_url":"https://api.github.com/repos/rapidsai/cudf/subscription","commits_url":"https://api.github.com/repos/rapidsai/cudf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapidsai/cudf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapidsai/cudf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapidsai/cudf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapidsai/cudf/contents/{+path}","compare_url":"https://api.github.com/repos/rapidsai/cudf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapidsai/cudf/merges","archive_url":"https://api.github.com/repos/rapidsai/cudf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapidsai/cudf/downloads","issues_url":"https://api.github.com/repos/rapidsai/cudf/issues{/number}","pulls_url":"https://api.github.com/repos/rapidsai/cudf/pulls{/number}","milestones_url":"https://api.github.com/repos/rapidsai/cudf/milestones{/number}","notifications_url":"https://api.github.com/repos/rapidsai/cudf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapidsai/cudf/labels{/name}","releases_url":"https://api.github.com/repos/rapidsai/cudf/releases{/id}","deployments_url":"https://api.github.com/repos/rapidsai/cudf/deployments","created_at":"2017-05-07T03:43:37Z","updated_at":"2018-12-06T21:02:09Z","pushed_at":"2018-12-06T22:34:44Z","git_url":"git://github.com/rapidsai/cudf.git","ssh_url":"git@github.com:rapidsai/cudf.git","clone_url":"https://github.com/rapidsai/cudf.git","svn_url":"https://github.com/rapidsai/cudf","homepage":"http://rapids.ai","size":12873,"stargazers_count":914,"watchers_count":914,"language":"Cuda","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":138,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":138,"open_issues":137,"watchers":914,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/455"},"html":{"href":"https://github.com/rapidsai/cudf/pull/455"},"issue":{"href":"https://api.github.com/repos/rapidsai/cudf/issues/455"},"comments":{"href":"https://api.github.com/repos/rapidsai/cudf/issues/455/comments"},"review_comments":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/455/comments"},"review_comment":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/455/commits"},"statuses":{"href":"https://api.github.com/repos/rapidsai/cudf/statuses/2479ada8b7f1ca0c3778922190035c6f9141074a"}},"author_association":"NONE"}}
{"actor":{"display_login":"harrism"}}