{"action":"created","issue":{"url":"https://api.github.com/repos/parse-community/parse-server/issues/4439","repository_url":"https://api.github.com/repos/parse-community/parse-server","labels_url":"https://api.github.com/repos/parse-community/parse-server/issues/4439/labels{/name}","comments_url":"https://api.github.com/repos/parse-community/parse-server/issues/4439/comments","events_url":"https://api.github.com/repos/parse-community/parse-server/issues/4439/events","html_url":"https://github.com/parse-community/parse-server/pull/4439","id":283397097,"number":4439,"title":"Regenerate Email Verification Token on Email Request","user":{"login":"montymxb","id":5070304,"avatar_url":"https://avatars1.githubusercontent.com/u/5070304?v=4","gravatar_id":"","url":"https://api.github.com/users/montymxb","html_url":"https://github.com/montymxb","followers_url":"https://api.github.com/users/montymxb/followers","following_url":"https://api.github.com/users/montymxb/following{/other_user}","gists_url":"https://api.github.com/users/montymxb/gists{/gist_id}","starred_url":"https://api.github.com/users/montymxb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montymxb/subscriptions","organizations_url":"https://api.github.com/users/montymxb/orgs","repos_url":"https://api.github.com/users/montymxb/repos","events_url":"https://api.github.com/users/montymxb/events{/privacy}","received_events_url":"https://api.github.com/users/montymxb/received_events","type":"User","site_admin":false},"labels":[{"id":318120539,"url":"https://api.github.com/repos/parse-community/parse-server/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-12-19T23:01:43Z","updated_at":"2018-02-01T23:34:53Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/parse-community/parse-server/pulls/4439","html_url":"https://github.com/parse-community/parse-server/pull/4439","diff_url":"https://github.com/parse-community/parse-server/pull/4439.diff","patch_url":"https://github.com/parse-community/parse-server/pull/4439.patch"},"body":"This is a fix for an issue observed in #4369. The issue being that requesting additional verification emails from **/verificationEmailRequest** does _not_ regenerate the verification token or expiration that is currently set. The problem here is that a verification request can simply time out and subsequent requests from this endpoint will produce emails that will not work. Note this is not an issue if no expiration is set.\r\n\r\nMaking a similar request to **/apps/:appId/resend_verification_email** is effectively the same as this endpoint, but it regenerates the verification token & expiration per request.\r\n\r\nMaking this change would prevent future users/devs from simply 'getting stuck' when trying to retrieve a new verification request when their existing one has expired. The key thing to note about this change is that there can only be **one** valid verification token at at time. Only the last requested email will have a valid token, all others (even if they were valid and unexpired) will be rendered invalid. I believe this is acceptable considering that one can simply request a new verification email rather than fuss over existing ones.\r\n\r\n::edit::\r\nThis modifies an existing test to further validate that post-request the underlying verification token & expiration have been modified from their original values."},"comment":{"url":"https://api.github.com/repos/parse-community/parse-server/issues/comments/362437657","html_url":"https://github.com/parse-community/parse-server/pull/4439#issuecomment-362437657","issue_url":"https://api.github.com/repos/parse-community/parse-server/issues/4439","id":362437657,"user":{"login":"flovilmart","id":364568,"avatar_url":"https://avatars3.githubusercontent.com/u/364568?v=4","gravatar_id":"","url":"https://api.github.com/users/flovilmart","html_url":"https://github.com/flovilmart","followers_url":"https://api.github.com/users/flovilmart/followers","following_url":"https://api.github.com/users/flovilmart/following{/other_user}","gists_url":"https://api.github.com/users/flovilmart/gists{/gist_id}","starred_url":"https://api.github.com/users/flovilmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flovilmart/subscriptions","organizations_url":"https://api.github.com/users/flovilmart/orgs","repos_url":"https://api.github.com/users/flovilmart/repos","events_url":"https://api.github.com/users/flovilmart/events{/privacy}","received_events_url":"https://api.github.com/users/flovilmart/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T23:34:53Z","updated_at":"2018-02-01T23:34:53Z","author_association":"OWNER","body":"It’s all good. Merging?"}}
{"actor":{"display_login":"flovilmart"}}