{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/lukeed/kleur/pulls/18","id":236952835,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTUyODM1","html_url":"https://github.com/lukeed/kleur/pull/18","diff_url":"https://github.com/lukeed/kleur/pull/18.diff","patch_url":"https://github.com/lukeed/kleur/pull/18.patch","issue_url":"https://api.github.com/repos/lukeed/kleur/issues/18","number":18,"state":"closed","locked":false,"title":"Make properties enumerable + fix TS typings","user":{"login":"marvinhagemeister","id":1062408,"node_id":"MDQ6VXNlcjEwNjI0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1062408?v=4","gravatar_id":"","url":"https://api.github.com/users/marvinhagemeister","html_url":"https://github.com/marvinhagemeister","followers_url":"https://api.github.com/users/marvinhagemeister/followers","following_url":"https://api.github.com/users/marvinhagemeister/following{/other_user}","gists_url":"https://api.github.com/users/marvinhagemeister/gists{/gist_id}","starred_url":"https://api.github.com/users/marvinhagemeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvinhagemeister/subscriptions","organizations_url":"https://api.github.com/users/marvinhagemeister/orgs","repos_url":"https://api.github.com/users/marvinhagemeister/repos","events_url":"https://api.github.com/users/marvinhagemeister/events{/privacy}","received_events_url":"https://api.github.com/users/marvinhagemeister/received_events","type":"User","site_admin":false},"body":"Thanks for making another awesome library! Have used it in a few personal projects so far and love it 👍 While working with it I'm wondering if you're open to these two suggestions:\r\n\r\n**1) Make properties enumerable**\r\n\r\nA simple `console.log(kleur)` would previously only show `enabled` property as available which might be confusing to newcomers. With this change it would list all available color properties.\r\n\r\n**2) Fix TypeScript typings**\r\n\r\nTS typings for `commonjs` modules are not as straightforward as for `es6` based libraries. If the libraries code is exported via `module.exports = myLib` one cannot declare it as `default` exports as this would create an ambiguity in regards to named exports.\r\n\r\nThis PR changes that to the [recommended way](https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require) of changing the declaration to `export = myLib` (verified locally). ","created_at":"2018-12-07T18:19:40Z","updated_at":"2018-12-07T19:18:35Z","closed_at":"2018-12-07T19:18:35Z","merged_at":"2018-12-07T19:18:35Z","merge_commit_sha":"48b3027d8218f1986233282da7abe1d02ec72915","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lukeed/kleur/pulls/18/commits","review_comments_url":"https://api.github.com/repos/lukeed/kleur/pulls/18/comments","review_comment_url":"https://api.github.com/repos/lukeed/kleur/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lukeed/kleur/issues/18/comments","statuses_url":"https://api.github.com/repos/lukeed/kleur/statuses/a80c2a5007249f6aa1135f4db9a8bc6000fd0ea3","head":{"label":"marvinhagemeister:typings","ref":"typings","sha":"a80c2a5007249f6aa1135f4db9a8bc6000fd0ea3","user":{"login":"marvinhagemeister","id":1062408,"node_id":"MDQ6VXNlcjEwNjI0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1062408?v=4","gravatar_id":"","url":"https://api.github.com/users/marvinhagemeister","html_url":"https://github.com/marvinhagemeister","followers_url":"https://api.github.com/users/marvinhagemeister/followers","following_url":"https://api.github.com/users/marvinhagemeister/following{/other_user}","gists_url":"https://api.github.com/users/marvinhagemeister/gists{/gist_id}","starred_url":"https://api.github.com/users/marvinhagemeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvinhagemeister/subscriptions","organizations_url":"https://api.github.com/users/marvinhagemeister/orgs","repos_url":"https://api.github.com/users/marvinhagemeister/repos","events_url":"https://api.github.com/users/marvinhagemeister/events{/privacy}","received_events_url":"https://api.github.com/users/marvinhagemeister/received_events","type":"User","site_admin":false},"repo":{"id":159176643,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkxNzY2NDM=","name":"kleur","full_name":"marvinhagemeister/kleur","private":false,"owner":{"login":"marvinhagemeister","id":1062408,"node_id":"MDQ6VXNlcjEwNjI0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1062408?v=4","gravatar_id":"","url":"https://api.github.com/users/marvinhagemeister","html_url":"https://github.com/marvinhagemeister","followers_url":"https://api.github.com/users/marvinhagemeister/followers","following_url":"https://api.github.com/users/marvinhagemeister/following{/other_user}","gists_url":"https://api.github.com/users/marvinhagemeister/gists{/gist_id}","starred_url":"https://api.github.com/users/marvinhagemeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvinhagemeister/subscriptions","organizations_url":"https://api.github.com/users/marvinhagemeister/orgs","repos_url":"https://api.github.com/users/marvinhagemeister/repos","events_url":"https://api.github.com/users/marvinhagemeister/events{/privacy}","received_events_url":"https://api.github.com/users/marvinhagemeister/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marvinhagemeister/kleur","description":"The fastest Node.js library for formatting terminal text with ANSI colors~!","fork":true,"url":"https://api.github.com/repos/marvinhagemeister/kleur","forks_url":"https://api.github.com/repos/marvinhagemeister/kleur/forks","keys_url":"https://api.github.com/repos/marvinhagemeister/kleur/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marvinhagemeister/kleur/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marvinhagemeister/kleur/teams","hooks_url":"https://api.github.com/repos/marvinhagemeister/kleur/hooks","issue_events_url":"https://api.github.com/repos/marvinhagemeister/kleur/issues/events{/number}","events_url":"https://api.github.com/repos/marvinhagemeister/kleur/events","assignees_url":"https://api.github.com/repos/marvinhagemeister/kleur/assignees{/user}","branches_url":"https://api.github.com/repos/marvinhagemeister/kleur/branches{/branch}","tags_url":"https://api.github.com/repos/marvinhagemeister/kleur/tags","blobs_url":"https://api.github.com/repos/marvinhagemeister/kleur/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marvinhagemeister/kleur/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marvinhagemeister/kleur/git/refs{/sha}","trees_url":"https://api.github.com/repos/marvinhagemeister/kleur/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marvinhagemeister/kleur/statuses/{sha}","languages_url":"https://api.github.com/repos/marvinhagemeister/kleur/languages","stargazers_url":"https://api.github.com/repos/marvinhagemeister/kleur/stargazers","contributors_url":"https://api.github.com/repos/marvinhagemeister/kleur/contributors","subscribers_url":"https://api.github.com/repos/marvinhagemeister/kleur/subscribers","subscription_url":"https://api.github.com/repos/marvinhagemeister/kleur/subscription","commits_url":"https://api.github.com/repos/marvinhagemeister/kleur/commits{/sha}","git_commits_url":"https://api.github.com/repos/marvinhagemeister/kleur/git/commits{/sha}","comments_url":"https://api.github.com/repos/marvinhagemeister/kleur/comments{/number}","issue_comment_url":"https://api.github.com/repos/marvinhagemeister/kleur/issues/comments{/number}","contents_url":"https://api.github.com/repos/marvinhagemeister/kleur/contents/{+path}","compare_url":"https://api.github.com/repos/marvinhagemeister/kleur/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marvinhagemeister/kleur/merges","archive_url":"https://api.github.com/repos/marvinhagemeister/kleur/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marvinhagemeister/kleur/downloads","issues_url":"https://api.github.com/repos/marvinhagemeister/kleur/issues{/number}","pulls_url":"https://api.github.com/repos/marvinhagemeister/kleur/pulls{/number}","milestones_url":"https://api.github.com/repos/marvinhagemeister/kleur/milestones{/number}","notifications_url":"https://api.github.com/repos/marvinhagemeister/kleur/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marvinhagemeister/kleur/labels{/name}","releases_url":"https://api.github.com/repos/marvinhagemeister/kleur/releases{/id}","deployments_url":"https://api.github.com/repos/marvinhagemeister/kleur/deployments","created_at":"2018-11-26T13:47:38Z","updated_at":"2018-11-26T13:47:40Z","pushed_at":"2018-12-07T18:59:21Z","git_url":"git://github.com/marvinhagemeister/kleur.git","ssh_url":"git@github.com:marvinhagemeister/kleur.git","clone_url":"https://github.com/marvinhagemeister/kleur.git","svn_url":"https://github.com/marvinhagemeister/kleur","homepage":null,"size":80,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lukeed:master","ref":"master","sha":"7528bcd17017d2c30e038b6abe55f0423ed24f2b","user":{"login":"lukeed","id":5855893,"node_id":"MDQ6VXNlcjU4NTU4OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5855893?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeed","html_url":"https://github.com/lukeed","followers_url":"https://api.github.com/users/lukeed/followers","following_url":"https://api.github.com/users/lukeed/following{/other_user}","gists_url":"https://api.github.com/users/lukeed/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeed/subscriptions","organizations_url":"https://api.github.com/users/lukeed/orgs","repos_url":"https://api.github.com/users/lukeed/repos","events_url":"https://api.github.com/users/lukeed/events{/privacy}","received_events_url":"https://api.github.com/users/lukeed/received_events","type":"User","site_admin":false},"repo":{"id":140393403,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzOTM0MDM=","name":"kleur","full_name":"lukeed/kleur","private":false,"owner":{"login":"lukeed","id":5855893,"node_id":"MDQ6VXNlcjU4NTU4OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5855893?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeed","html_url":"https://github.com/lukeed","followers_url":"https://api.github.com/users/lukeed/followers","following_url":"https://api.github.com/users/lukeed/following{/other_user}","gists_url":"https://api.github.com/users/lukeed/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeed/subscriptions","organizations_url":"https://api.github.com/users/lukeed/orgs","repos_url":"https://api.github.com/users/lukeed/repos","events_url":"https://api.github.com/users/lukeed/events{/privacy}","received_events_url":"https://api.github.com/users/lukeed/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lukeed/kleur","description":"The fastest Node.js library for formatting terminal text with ANSI colors~!","fork":false,"url":"https://api.github.com/repos/lukeed/kleur","forks_url":"https://api.github.com/repos/lukeed/kleur/forks","keys_url":"https://api.github.com/repos/lukeed/kleur/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukeed/kleur/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukeed/kleur/teams","hooks_url":"https://api.github.com/repos/lukeed/kleur/hooks","issue_events_url":"https://api.github.com/repos/lukeed/kleur/issues/events{/number}","events_url":"https://api.github.com/repos/lukeed/kleur/events","assignees_url":"https://api.github.com/repos/lukeed/kleur/assignees{/user}","branches_url":"https://api.github.com/repos/lukeed/kleur/branches{/branch}","tags_url":"https://api.github.com/repos/lukeed/kleur/tags","blobs_url":"https://api.github.com/repos/lukeed/kleur/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukeed/kleur/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukeed/kleur/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukeed/kleur/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukeed/kleur/statuses/{sha}","languages_url":"https://api.github.com/repos/lukeed/kleur/languages","stargazers_url":"https://api.github.com/repos/lukeed/kleur/stargazers","contributors_url":"https://api.github.com/repos/lukeed/kleur/contributors","subscribers_url":"https://api.github.com/repos/lukeed/kleur/subscribers","subscription_url":"https://api.github.com/repos/lukeed/kleur/subscription","commits_url":"https://api.github.com/repos/lukeed/kleur/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukeed/kleur/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukeed/kleur/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukeed/kleur/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukeed/kleur/contents/{+path}","compare_url":"https://api.github.com/repos/lukeed/kleur/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukeed/kleur/merges","archive_url":"https://api.github.com/repos/lukeed/kleur/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukeed/kleur/downloads","issues_url":"https://api.github.com/repos/lukeed/kleur/issues{/number}","pulls_url":"https://api.github.com/repos/lukeed/kleur/pulls{/number}","milestones_url":"https://api.github.com/repos/lukeed/kleur/milestones{/number}","notifications_url":"https://api.github.com/repos/lukeed/kleur/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukeed/kleur/labels{/name}","releases_url":"https://api.github.com/repos/lukeed/kleur/releases{/id}","deployments_url":"https://api.github.com/repos/lukeed/kleur/deployments","created_at":"2018-07-10T07:22:28Z","updated_at":"2018-12-07T16:08:08Z","pushed_at":"2018-12-07T19:18:35Z","git_url":"git://github.com/lukeed/kleur.git","ssh_url":"git@github.com:lukeed/kleur.git","clone_url":"https://github.com/lukeed/kleur.git","svn_url":"https://github.com/lukeed/kleur","homepage":null,"size":81,"stargazers_count":594,"watchers_count":594,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":0,"watchers":594,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lukeed/kleur/pulls/18"},"html":{"href":"https://github.com/lukeed/kleur/pull/18"},"issue":{"href":"https://api.github.com/repos/lukeed/kleur/issues/18"},"comments":{"href":"https://api.github.com/repos/lukeed/kleur/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/lukeed/kleur/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/lukeed/kleur/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lukeed/kleur/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/lukeed/kleur/statuses/a80c2a5007249f6aa1135f4db9a8bc6000fd0ea3"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lukeed","id":5855893,"node_id":"MDQ6VXNlcjU4NTU4OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5855893?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeed","html_url":"https://github.com/lukeed","followers_url":"https://api.github.com/users/lukeed/followers","following_url":"https://api.github.com/users/lukeed/following{/other_user}","gists_url":"https://api.github.com/users/lukeed/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeed/subscriptions","organizations_url":"https://api.github.com/users/lukeed/orgs","repos_url":"https://api.github.com/users/lukeed/repos","events_url":"https://api.github.com/users/lukeed/events{/privacy}","received_events_url":"https://api.github.com/users/lukeed/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":3,"additions":3,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"lukeed"}}