{"action":"created","issue":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/14969","repository_url":"https://api.github.com/repos/brave/browser-laptop","labels_url":"https://api.github.com/repos/brave/browser-laptop/issues/14969/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/14969/comments","events_url":"https://api.github.com/repos/brave/browser-laptop/issues/14969/events","html_url":"https://github.com/brave/browser-laptop/issues/14969","id":348505076,"node_id":"MDU6SXNzdWUzNDg1MDUwNzY=","number":14969,"title":"password is not required","user":{"login":"LaurenWags","id":28145373,"node_id":"MDQ6VXNlcjI4MTQ1Mzcz","avatar_url":"https://avatars1.githubusercontent.com/u/28145373?v=4","gravatar_id":"","url":"https://api.github.com/users/LaurenWags","html_url":"https://github.com/LaurenWags","followers_url":"https://api.github.com/users/LaurenWags/followers","following_url":"https://api.github.com/users/LaurenWags/following{/other_user}","gists_url":"https://api.github.com/users/LaurenWags/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurenWags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurenWags/subscriptions","organizations_url":"https://api.github.com/users/LaurenWags/orgs","repos_url":"https://api.github.com/users/LaurenWags/repos","events_url":"https://api.github.com/users/LaurenWags/events{/privacy}","received_events_url":"https://api.github.com/users/LaurenWags/received_events","type":"User","site_admin":false},"labels":[{"id":433043709,"node_id":"MDU6TGFiZWw0MzMwNDM3MDk=","url":"https://api.github.com/repos/brave/browser-laptop/labels/QA/checked-Win64","name":"QA/checked-Win64","color":"0e8a16","default":false},{"id":420081901,"node_id":"MDU6TGFiZWw0MjAwODE5MDE=","url":"https://api.github.com/repos/brave/browser-laptop/labels/QA/test-plan-specified","name":"QA/test-plan-specified","color":"1d76db","default":false},{"id":1002729440,"node_id":"MDU6TGFiZWwxMDAyNzI5NDQw","url":"https://api.github.com/repos/brave/browser-laptop/labels/feature/ETH-Wallet","name":"feature/ETH-Wallet","color":"444444","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/121","html_url":"https://github.com/brave/browser-laptop/milestone/121","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/121/labels","id":3523574,"node_id":"MDk6TWlsZXN0b25lMzUyMzU3NA==","number":121,"title":"0.23.x Release 6 (ETH Wallet - Beta Channel)","description":"","creator":{"login":"bsclifton","id":4733304,"node_id":"MDQ6VXNlcjQ3MzMzMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4733304?v=4","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":37,"state":"open","created_at":"2018-07-25T17:52:27Z","updated_at":"2018-08-14T11:36:47Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-08-07T22:08:42Z","updated_at":"2018-08-14T12:04:23Z","closed_at":"2018-08-09T19:44:35Z","author_association":"NONE","body":"<!--\r\nHave you searched for similar issues? We have received a lot of feedback and bug reports that we have closed as duplicates. Before submitting this issue, please visit our community site for common ones: https://community.brave.com/c/common-issues\r\n-->\r\n\r\n### Description\r\nWhen the password box is displayed upon opening the ETH Wallet page, clicking elsewhere on the page dismisses the password box. You can then create a wallet that I guess doesn't have a password. Not sure if this is expected as the password functionality is not yet defined in the spec.\r\n\r\n\r\n### Steps to Reproduce\r\n<!--\r\nPlease add a series of steps to reproduce the problem. See https://stackoverflow.com/help/mcve for in depth information on how to create a minimal, complete, and verifiable example.\r\n-->\r\n\r\n  1. Build and launch from eth-wallet PR. (\r\n  2. Enable ETH Wallet.\r\n  3. Close/relaunch Brave (use same parameters as step 1 if using ropsten, etc)\r\n  4. You are prompted to enter a password on the ETH Wallet page.\r\n  5. Click elsewhere on the page.\r\n  6. pw box goes away. Create a wallet.\r\n  7. Leave and come back to the ETH Wallet page.\r\n  8. Prompted for password again, can click away. (if you enter a password here, you get notified it's wrong)\r\n  \r\n\r\n\r\n**Actual result:**\r\nAble to click away and password box is no longer shown/required.\r\n![ethwalletpw](https://user-images.githubusercontent.com/28145373/43805136-a14c9f22-9a6c-11e8-8724-e7fb35e35c15.gif)\r\n\r\n\r\n\r\n**Expected result:**\r\nI'd expect it to be required if we need a password to send transactions, but I'm not sure this was the intent.\r\n\r\n\r\n**Reproduces how often:**\r\neasily\r\n\r\n\r\n### Brave Version\r\n\r\n**about:brave info:**\r\n \r\nBrave: 0.25.0 \r\nV8: 6.8.275.24 \r\nrev: 6d7c1f167fbd9d59bd4dff94f891b2da466c5655 \r\nMuon: 8.0.6 \r\nOS Release: 16.7.0 \r\nUpdate Channel:  \r\nOS Architecture: x64 \r\nOS Platform: macOS \r\nNode.js: 7.9.0 \r\nBrave Sync: v1.4.2 \r\nlibchromiumcontent: 68.0.3440.84\r\n\r\n\r\n**Reproducible on current live release:**\r\nn/a\r\n\r\n\r\n### Additional Information\r\ncc @tomlowenthal to confirm what the expected result should be\r\n"},"comment":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/comments/412849157","html_url":"https://github.com/brave/browser-laptop/issues/14969#issuecomment-412849157","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/14969","id":412849157,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjg0OTE1Nw==","user":{"login":"GeetaSarvadnya","id":38657976,"node_id":"MDQ6VXNlcjM4NjU3OTc2","avatar_url":"https://avatars3.githubusercontent.com/u/38657976?v=4","gravatar_id":"","url":"https://api.github.com/users/GeetaSarvadnya","html_url":"https://github.com/GeetaSarvadnya","followers_url":"https://api.github.com/users/GeetaSarvadnya/followers","following_url":"https://api.github.com/users/GeetaSarvadnya/following{/other_user}","gists_url":"https://api.github.com/users/GeetaSarvadnya/gists{/gist_id}","starred_url":"https://api.github.com/users/GeetaSarvadnya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeetaSarvadnya/subscriptions","organizations_url":"https://api.github.com/users/GeetaSarvadnya/orgs","repos_url":"https://api.github.com/users/GeetaSarvadnya/repos","events_url":"https://api.github.com/users/GeetaSarvadnya/events{/privacy}","received_events_url":"https://api.github.com/users/GeetaSarvadnya/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T12:04:23Z","updated_at":"2018-08-14T12:04:23Z","author_association":"COLLABORATOR","body":"Verified on Windows x64 with\r\n• 0.23.100 5e197a1a877c9967aecc838b9a7ca528ee5b46bd\r\n• Muon 8.0.8\r\n• libchromiumcontent 68.0.3440.84\r\n"}}
{"actor":{"display_login":"GeetaSarvadnya"}}