{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/235108506","pull_request_review_id":176899188,"id":235108506,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTEwODUwNg==","diff_hunk":"@@ -2266,7 +2266,7 @@ public final class net.corda.core.flows.NotaryFlow extends java.lang.Object\n ##\n @DoNotImplement\n @InitiatingFlow\n-public static class net.corda.core.flows.NotaryFlow$Client extends net.corda.core.flows.FlowLogic implements net.corda.core.internal.TimedFlow\n+public static class net.corda.core.flows.NotaryFlow$Client extends net.corda.core.internal.BackpressureAwareTimedFlow","path":".ci/api-current.txt","position":5,"original_position":5,"commit_id":"35bbc2ac6ebd6456087034e74867c3438c70d4bc","original_commit_id":"35bbc2ac6ebd6456087034e74867c3438c70d4bc","user":{"login":"rick-r3","id":23558791,"node_id":"MDQ6VXNlcjIzNTU4Nzkx","avatar_url":"https://avatars2.githubusercontent.com/u/23558791?v=4","gravatar_id":"","url":"https://api.github.com/users/rick-r3","html_url":"https://github.com/rick-r3","followers_url":"https://api.github.com/users/rick-r3/followers","following_url":"https://api.github.com/users/rick-r3/following{/other_user}","gists_url":"https://api.github.com/users/rick-r3/gists{/gist_id}","starred_url":"https://api.github.com/users/rick-r3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rick-r3/subscriptions","organizations_url":"https://api.github.com/users/rick-r3/orgs","repos_url":"https://api.github.com/users/rick-r3/repos","events_url":"https://api.github.com/users/rick-r3/events{/privacy}","received_events_url":"https://api.github.com/users/rick-r3/received_events","type":"User","site_admin":false},"body":"Yep.  This appears to extend all of the prior interfaces / super classes, just in a slightly different hierarchy.  So if anyone was directly calling this, and for some bizarre reason doing some casting to one of them it should be fine.  ","created_at":"2018-11-20T17:57:03Z","updated_at":"2018-11-20T17:57:03Z","html_url":"https://github.com/corda/corda/pull/4242#discussion_r235108506","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/4242","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/235108506"},"html":{"href":"https://github.com/corda/corda/pull/4242#discussion_r235108506"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/4242"}}},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/4242","id":231292245,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjkyMjQ1","html_url":"https://github.com/corda/corda/pull/4242","diff_url":"https://github.com/corda/corda/pull/4242.diff","patch_url":"https://github.com/corda/corda/pull/4242.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/4242","number":4242,"state":"open","locked":false,"title":"NotaryServiceFlow backpressure","user":{"login":"thschroeter","id":40804,"node_id":"MDQ6VXNlcjQwODA0","avatar_url":"https://avatars1.githubusercontent.com/u/40804?v=4","gravatar_id":"","url":"https://api.github.com/users/thschroeter","html_url":"https://github.com/thschroeter","followers_url":"https://api.github.com/users/thschroeter/followers","following_url":"https://api.github.com/users/thschroeter/following{/other_user}","gists_url":"https://api.github.com/users/thschroeter/gists{/gist_id}","starred_url":"https://api.github.com/users/thschroeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thschroeter/subscriptions","organizations_url":"https://api.github.com/users/thschroeter/orgs","repos_url":"https://api.github.com/users/thschroeter/repos","events_url":"https://api.github.com/users/thschroeter/events{/privacy}","received_events_url":"https://api.github.com/users/thschroeter/received_events","type":"User","site_admin":false},"body":"Implementation of application level notary backpressure, based on the request queue size in the uniqueness provider.\r\n\r\nClients are asked to further delay their timed flows if the ETA of request processing in the notary exceeds the default retry timeout.\r\n\r\nWhen the bottleneck is transport level (Artemis) messaging, not the request processing in the UniquenessProvider, the clients will still retry.\r\n\r\nWe tested with artificial delay in the uniqueness provider.","created_at":"2018-11-15T18:28:58Z","updated_at":"2018-11-20T17:57:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4881af2dd69bbee22b81d1f459e4a69df55404d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mnesbit","id":20210228,"node_id":"MDQ6VXNlcjIwMjEwMjI4","avatar_url":"https://avatars2.githubusercontent.com/u/20210228?v=4","gravatar_id":"","url":"https://api.github.com/users/mnesbit","html_url":"https://github.com/mnesbit","followers_url":"https://api.github.com/users/mnesbit/followers","following_url":"https://api.github.com/users/mnesbit/following{/other_user}","gists_url":"https://api.github.com/users/mnesbit/gists{/gist_id}","starred_url":"https://api.github.com/users/mnesbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnesbit/subscriptions","organizations_url":"https://api.github.com/users/mnesbit/orgs","repos_url":"https://api.github.com/users/mnesbit/repos","events_url":"https://api.github.com/users/mnesbit/events{/privacy}","received_events_url":"https://api.github.com/users/mnesbit/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/4242/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/4242/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/4242/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/35bbc2ac6ebd6456087034e74867c3438c70d4bc","head":{"label":"corda:thomas/ENT-2356-backpressure","ref":"thomas/ENT-2356-backpressure","sha":"35bbc2ac6ebd6456087034e74867c3438c70d4bc","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","private":false,"owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-11-20T17:16:47Z","pushed_at":"2018-11-20T17:50:56Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":167035,"stargazers_count":2497,"watchers_count":2497,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":639,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":639,"open_issues":91,"watchers":2497,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"0e51d117432a60c78d0672eb993df8f79e048c48","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","private":false,"owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-11-20T17:16:47Z","pushed_at":"2018-11-20T17:50:56Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":167035,"stargazers_count":2497,"watchers_count":2497,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":639,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":639,"open_issues":91,"watchers":2497,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/4242"},"html":{"href":"https://github.com/corda/corda/pull/4242"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/4242"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/4242/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/4242/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/4242/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/35bbc2ac6ebd6456087034e74867c3438c70d4bc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rick-r3"}}