{"action":"created","issue":{"url":"https://api.github.com/repos/LibreTime/libretime/issues/515","repository_url":"https://api.github.com/repos/LibreTime/libretime","labels_url":"https://api.github.com/repos/LibreTime/libretime/issues/515/labels{/name}","comments_url":"https://api.github.com/repos/LibreTime/libretime/issues/515/comments","events_url":"https://api.github.com/repos/LibreTime/libretime/issues/515/events","html_url":"https://github.com/LibreTime/libretime/issues/515","id":360142657,"node_id":"MDU6SXNzdWUzNjAxNDI2NTc=","number":515,"title":"Feature Request: Use a different \"base_url\" for API services than the web front-end","user":{"login":"ned-kelly","id":17648709,"node_id":"MDQ6VXNlcjE3NjQ4NzA5","avatar_url":"https://avatars1.githubusercontent.com/u/17648709?v=4","gravatar_id":"","url":"https://api.github.com/users/ned-kelly","html_url":"https://github.com/ned-kelly","followers_url":"https://api.github.com/users/ned-kelly/followers","following_url":"https://api.github.com/users/ned-kelly/following{/other_user}","gists_url":"https://api.github.com/users/ned-kelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ned-kelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ned-kelly/subscriptions","organizations_url":"https://api.github.com/users/ned-kelly/orgs","repos_url":"https://api.github.com/users/ned-kelly/repos","events_url":"https://api.github.com/users/ned-kelly/events{/privacy}","received_events_url":"https://api.github.com/users/ned-kelly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-14T03:21:18Z","updated_at":"2018-09-16T01:54:16Z","closed_at":null,"author_association":"NONE","body":"So, I'm running Libretime in a multi-container docker setup that I've built ready for production use (see here for the repo: https://github.com/ned-kelly/docker-multicontainer-libretime), and ideally I'd like to request that there be two base_url variables added to the airtime.conf file:\r\n\r\n - One for the actual Web UI (So that you can specify an external public facing endpoint for the IFrames that are loaded)\r\n\r\n - The other would be the endpoint that API's can hit - This way it can be another local docker containers hostname (joined in a bridged network), or just \"localhost\" etc...\r\n\r\nHope this makes sense and isn't too much to ask.\r\n"},"comment":{"url":"https://api.github.com/repos/LibreTime/libretime/issues/comments/421670849","html_url":"https://github.com/LibreTime/libretime/issues/515#issuecomment-421670849","issue_url":"https://api.github.com/repos/LibreTime/libretime/issues/515","id":421670849,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTY3MDg0OQ==","user":{"login":"ned-kelly","id":17648709,"node_id":"MDQ6VXNlcjE3NjQ4NzA5","avatar_url":"https://avatars1.githubusercontent.com/u/17648709?v=4","gravatar_id":"","url":"https://api.github.com/users/ned-kelly","html_url":"https://github.com/ned-kelly","followers_url":"https://api.github.com/users/ned-kelly/followers","following_url":"https://api.github.com/users/ned-kelly/following{/other_user}","gists_url":"https://api.github.com/users/ned-kelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ned-kelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ned-kelly/subscriptions","organizations_url":"https://api.github.com/users/ned-kelly/orgs","repos_url":"https://api.github.com/users/ned-kelly/repos","events_url":"https://api.github.com/users/ned-kelly/events{/privacy}","received_events_url":"https://api.github.com/users/ned-kelly/received_events","type":"User","site_admin":false},"created_at":"2018-09-16T01:54:16Z","updated_at":"2018-09-16T01:54:16Z","author_association":"NONE","body":"> Cool project, I've been meaning to investigate docker more and how it could be applicable towards the project. You seem to have done quite a bit in your repo.\r\n\r\nThanks, the goal is to have a PROPER multi-container docker setup (with various services such as the DB, etc split out using their respective official docker repo's and not all in one ubuntu container like other previous builds of the older Airtime) - This will allow for the deployment Libretime for \"production\" (so use in a live station setup), where database files, uploaded media, config etc will properly persist between standing up and down the environment etc (so upgrading via docker won't blow away your setup etc)...\r\n\r\n> Just to clarify here when you are talking about front facing you are mostly talking about the iframe widgets used for the embeddable player and schedule etc right ?\r\n\r\nThis fix is for the front-end ... The proper immediate fix is to just ensure that every iFrame is referenced in the widgets, schedule etc (on the main server homepage) are relative (Since they are always going to come from the same domain anyway as the parent webpage).\r\n\r\n> Also I noticed you mentioned in your PR that LibreTime was released by SourceFabric. That's not the case, this is an independent project just built upon their open-source work in Airtime. They know maintain Airtime.pro as a SaaS project with source only available to their internal team and haven't made any contributions since the fork etc.\r\n\r\nOops, yeah I'm aware - Have spent quite a lot of time over the past day or two reading all the docs on http://libretime.org/ :) - I just forgot change that from from my other container I built for Airtime (before discovering Libretime only a few hours later...) - I'll fix that now :).\r\n\r\nOn the general subject of docker - Docker is a powerful way to get people up and running reliably and quickly - since you're ensuring that the environment they are running is going to be exactly the same, every time - so I'd encourage it, happy to merge what I've started into the Libretime project if you guys do go down the docker route."}}
{"actor":{"display_login":"ned-kelly"}}