{"action":"created","issue":{"url":"https://api.github.com/repos/istvan-ujjmeszaros/bootstrap-dropdown-hover/issues/20","repository_url":"https://api.github.com/repos/istvan-ujjmeszaros/bootstrap-dropdown-hover","labels_url":"https://api.github.com/repos/istvan-ujjmeszaros/bootstrap-dropdown-hover/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/istvan-ujjmeszaros/bootstrap-dropdown-hover/issues/20/comments","events_url":"https://api.github.com/repos/istvan-ujjmeszaros/bootstrap-dropdown-hover/issues/20/events","html_url":"https://github.com/istvan-ujjmeszaros/bootstrap-dropdown-hover/pull/20","id":315685364,"number":20,"title":"Add support for data-target.","user":{"login":"hkmaly","id":4201080,"avatar_url":"https://avatars3.githubusercontent.com/u/4201080?v=4","gravatar_id":"","url":"https://api.github.com/users/hkmaly","html_url":"https://github.com/hkmaly","followers_url":"https://api.github.com/users/hkmaly/followers","following_url":"https://api.github.com/users/hkmaly/following{/other_user}","gists_url":"https://api.github.com/users/hkmaly/gists{/gist_id}","starred_url":"https://api.github.com/users/hkmaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkmaly/subscriptions","organizations_url":"https://api.github.com/users/hkmaly/orgs","repos_url":"https://api.github.com/users/hkmaly/repos","events_url":"https://api.github.com/users/hkmaly/events{/privacy}","received_events_url":"https://api.github.com/users/hkmaly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-19T00:18:25Z","updated_at":"2018-04-19T01:33:35Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/istvan-ujjmeszaros/bootstrap-dropdown-hover/pulls/20","html_url":"https://github.com/istvan-ujjmeszaros/bootstrap-dropdown-hover/pull/20","diff_url":"https://github.com/istvan-ujjmeszaros/bootstrap-dropdown-hover/pull/20.diff","patch_url":"https://github.com/istvan-ujjmeszaros/bootstrap-dropdown-hover/pull/20.patch"},"body":"Support explicit data-target attribute on dropdown, just as bootstrap itself does.\r\n\r\nOriginally complained about this on #19 but was misunderstood.\r\n\r\nNote: This pull request only contain the change for the basic javascript file. Should be also done in the minified one but I don't know how (I hope it's not done manually)."},"comment":{"url":"https://api.github.com/repos/istvan-ujjmeszaros/bootstrap-dropdown-hover/issues/comments/382580804","html_url":"https://github.com/istvan-ujjmeszaros/bootstrap-dropdown-hover/pull/20#issuecomment-382580804","issue_url":"https://api.github.com/repos/istvan-ujjmeszaros/bootstrap-dropdown-hover/issues/20","id":382580804,"user":{"login":"istvan-ujjmeszaros","id":1273763,"avatar_url":"https://avatars3.githubusercontent.com/u/1273763?v=4","gravatar_id":"","url":"https://api.github.com/users/istvan-ujjmeszaros","html_url":"https://github.com/istvan-ujjmeszaros","followers_url":"https://api.github.com/users/istvan-ujjmeszaros/followers","following_url":"https://api.github.com/users/istvan-ujjmeszaros/following{/other_user}","gists_url":"https://api.github.com/users/istvan-ujjmeszaros/gists{/gist_id}","starred_url":"https://api.github.com/users/istvan-ujjmeszaros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istvan-ujjmeszaros/subscriptions","organizations_url":"https://api.github.com/users/istvan-ujjmeszaros/orgs","repos_url":"https://api.github.com/users/istvan-ujjmeszaros/repos","events_url":"https://api.github.com/users/istvan-ujjmeszaros/events{/privacy}","received_events_url":"https://api.github.com/users/istvan-ujjmeszaros/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T01:33:35Z","updated_at":"2018-04-19T01:33:35Z","author_association":"OWNER","body":"Hey @hkmaly, thanks for the pull request, I have never used `data-target` with dropdowns so didn't know about it.\r\n\r\nI have tried your code with the following snippet, but didn't work:\r\n```html\r\n<div class=\"bs-example\">\r\n  <div class=\"dropdown\">\r\n    <a id=\"dLabel\" data-target=\"#\" href=\"http://example.com\" data-toggle=\"dropdown\" role=\"button\" aria-haspopup=\"true\" aria-expanded=\"false\">\r\n      Using <code>data-target</code>\r\n      <span class=\"caret\"></span>\r\n    </a>\r\n\r\n    <ul class=\"dropdown-menu\" aria-labelledby=\"dLabel\">\r\n      <li><a href=\"#\">Action</a></li>\r\n      <li><a href=\"#\">Another action</a></li>\r\n      <li><a href=\"#\">Something else here</a></li>\r\n      <li role=\"separator\" class=\"divider\"></li>\r\n      <li><a href=\"#\">Separated link</a></li>\r\n    </ul>\r\n  </div>\r\n</div>\r\n\r\n```\r\nI could fix it, but I think your contribution would completely disappear then. Do you want to fix it? You should edit the file in the `src` folder as the `dist` folder is generated. I can take care of the `dist` files if you update the pull request with the working fix in the `src/jquery.bootstrap-dropdown-hover.js` file.\r\nFeel free to add the above snippet to the `demo/index-bs3.html` file (somewhere inside the \"Other dropdown type examples\" section) so you can test your fix easily.\r\n\r\nLet me know if you don't have time to look into it as I will do it then."}}
{"actor":{"display_login":"istvan-ujjmeszaros"}}