{"action":"opened","issue":{"url":"https://api.github.com/repos/2018-BGMP/demultiplexing-philmcnamara/issues/3","repository_url":"https://api.github.com/repos/2018-BGMP/demultiplexing-philmcnamara","labels_url":"https://api.github.com/repos/2018-BGMP/demultiplexing-philmcnamara/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/2018-BGMP/demultiplexing-philmcnamara/issues/3/comments","events_url":"https://api.github.com/repos/2018-BGMP/demultiplexing-philmcnamara/issues/3/events","html_url":"https://github.com/2018-BGMP/demultiplexing-philmcnamara/issues/3","id":364953144,"node_id":"MDU6SXNzdWUzNjQ5NTMxNDQ=","number":3,"title":"RR Review","user":{"login":"rarichardson92","id":40405027,"node_id":"MDQ6VXNlcjQwNDA1MDI3","avatar_url":"https://avatars2.githubusercontent.com/u/40405027?v=4","gravatar_id":"","url":"https://api.github.com/users/rarichardson92","html_url":"https://github.com/rarichardson92","followers_url":"https://api.github.com/users/rarichardson92/followers","following_url":"https://api.github.com/users/rarichardson92/following{/other_user}","gists_url":"https://api.github.com/users/rarichardson92/gists{/gist_id}","starred_url":"https://api.github.com/users/rarichardson92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rarichardson92/subscriptions","organizations_url":"https://api.github.com/users/rarichardson92/orgs","repos_url":"https://api.github.com/users/rarichardson92/repos","events_url":"https://api.github.com/users/rarichardson92/events{/privacy}","received_events_url":"https://api.github.com/users/rarichardson92/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-28T16:10:30Z","updated_at":"2018-09-28T16:10:30Z","closed_at":null,"author_association":"NONE","body":"Nice Phil! \r\n\r\nVery clear, good logic. I like the counter being used at the quality passing point and reading sets of four lines for each file for comparison. However, I would argue that if I didn’t have the assignment in front of me, I wouldn’t know what you’re processing/why and what your intended output is (first two bullets in assignment, probably just needs an informative comment at the start of your code). I would also say that your final output is a touch unclear from what’s written alone, I would make your intended “prints” (# of properly matched indexes per index as well as level of index hopping) a little more defined. \r\n\r\nStrong functions, not sure if you need the part in mean_read_quality to convert the string to a list. I think you can iterate through a string by character in a for loop? And as a last side note, while you do mention a unit test at the end for checking record sums of the output files and that is on point, I think that the intention was to make a few example files to test on, with four input and however many you would need for the output based on what indexes are in your example inputs.\r\n\r\nAnyway, solid work! (I may borrow a couple ideas to be honest, so thanks!)"}}
{"actor":{"display_login":"rarichardson92"}}