{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments/172926088","pull_request_review_id":102028400,"id":172926088,"diff_hunk":"@@ -200,12 +168,37 @@ def max_planned_weight\n         @max_planned_weight ||= planned_devices.map { |dev| planned_weight(dev) }.compact.max\n       end\n \n+      # Whether there is /boot/efi filesystem in a software raid\n+      #\n+      # @return [Boolean] false if there is no /boot/efi or it's not located in\n+      #   an MD RAID\n+      def efi_in_md_raid1?\n+        filesystem = filesystem_for_mountpoint(\"/boot/efi\")\n+        return false unless filesystem\n+\n+        raid = filesystem.ancestors.find { |dev| dev.is?(:software_raid) }\n+        return false unless raid\n+\n+        return raid.md_level.is?(:raid1)","path":"src/lib/y2storage/boot_requirements_strategies/analyzer.rb","position":146,"original_position":105,"commit_id":"0477c5303b073bf927a4e2592734e644c515efea","original_commit_id":"508fe9e0d1b9605574f9bd4eff946fd30e40cb50","user":{"login":"ancorgs","id":3638289,"avatar_url":"https://avatars0.githubusercontent.com/u/3638289?v=4","gravatar_id":"","url":"https://api.github.com/users/ancorgs","html_url":"https://github.com/ancorgs","followers_url":"https://api.github.com/users/ancorgs/followers","following_url":"https://api.github.com/users/ancorgs/following{/other_user}","gists_url":"https://api.github.com/users/ancorgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ancorgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancorgs/subscriptions","organizations_url":"https://api.github.com/users/ancorgs/orgs","repos_url":"https://api.github.com/users/ancorgs/repos","events_url":"https://api.github.com/users/ancorgs/events{/privacy}","received_events_url":"https://api.github.com/users/ancorgs/received_events","type":"User","site_admin":false},"body":"I added a commit with better documentation for this method. Please check whether it's clear now.","created_at":"2018-03-07T17:44:39Z","updated_at":"2018-03-07T17:44:39Z","html_url":"https://github.com/yast/yast-storage-ng/pull/564#discussion_r172926088","pull_request_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/564","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments/172926088"},"html":{"href":"https://github.com/yast/yast-storage-ng/pull/564#discussion_r172926088"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/564"}},"in_reply_to_id":172905369},"pull_request":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/564","id":173204640,"html_url":"https://github.com/yast/yast-storage-ng/pull/564","diff_url":"https://github.com/yast/yast-storage-ng/pull/564.diff","patch_url":"https://github.com/yast/yast-storage-ng/pull/564.patch","issue_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/564","number":564,"state":"open","locked":false,"title":"New boot requirements for s390","user":{"login":"ancorgs","id":3638289,"avatar_url":"https://avatars0.githubusercontent.com/u/3638289?v=4","gravatar_id":"","url":"https://api.github.com/users/ancorgs","html_url":"https://github.com/ancorgs","followers_url":"https://api.github.com/users/ancorgs/followers","following_url":"https://api.github.com/users/ancorgs/following{/other_user}","gists_url":"https://api.github.com/users/ancorgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ancorgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancorgs/subscriptions","organizations_url":"https://api.github.com/users/ancorgs/orgs","repos_url":"https://api.github.com/users/ancorgs/repos","events_url":"https://api.github.com/users/ancorgs/events{/privacy}","received_events_url":"https://api.github.com/users/ancorgs/received_events","type":"User","site_admin":false},"body":"Man PR for https://trello.com/c/xm6GG23D/277-2-sles15-p3-1070265-sles-15-beta3-not-possible-to-format-edev-device-yast\r\n\r\nBetter review commit by commit.\r\n\r\nFrom the proposal POV:\r\n - We do not longer propose a separate `/boot/zipl` if installing with plain partitions (no LVM or encryption) and XFS/ext filesystem.\r\n - We do not longer refuse to use a FBA disk for \"/\" (only LDL is forbidden)\r\n\r\nFrom the partitioner checks POV:\r\n - We do not longer ask for a separate `/boot/zipl` if there is a `/boot` plain partition formatted as  XFS/ext.\r\n - We do not longer ask for a separate `/boot/zipl` if `/` is a plain partition formatted as  XFS/ext.\r\n - We do not longer warn about placing \"/\" or \"/boot\" in FBA (only bitch for LDL)\r\n - In that regard, unit tests improved and added tests for MD RAID.\r\n\r\nDocumentation (specially boot-requirements.md) also updated.","created_at":"2018-03-06T16:09:38Z","updated_at":"2018-03-07T17:44:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e67b9bae4c153f18f03c86a6f3dbd04dc4d65697","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/564/commits","review_comments_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/564/comments","review_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/564/comments","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/0477c5303b073bf927a4e2592734e644c515efea","head":{"label":"ancorgs:change_s390_req","ref":"change_s390_req","sha":"0477c5303b073bf927a4e2592734e644c515efea","user":{"login":"ancorgs","id":3638289,"avatar_url":"https://avatars0.githubusercontent.com/u/3638289?v=4","gravatar_id":"","url":"https://api.github.com/users/ancorgs","html_url":"https://github.com/ancorgs","followers_url":"https://api.github.com/users/ancorgs/followers","following_url":"https://api.github.com/users/ancorgs/following{/other_user}","gists_url":"https://api.github.com/users/ancorgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ancorgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancorgs/subscriptions","organizations_url":"https://api.github.com/users/ancorgs/orgs","repos_url":"https://api.github.com/users/ancorgs/repos","events_url":"https://api.github.com/users/ancorgs/events{/privacy}","received_events_url":"https://api.github.com/users/ancorgs/received_events","type":"User","site_admin":false},"repo":{"id":52606196,"name":"yast-storage-ng","full_name":"ancorgs/yast-storage-ng","owner":{"login":"ancorgs","id":3638289,"avatar_url":"https://avatars0.githubusercontent.com/u/3638289?v=4","gravatar_id":"","url":"https://api.github.com/users/ancorgs","html_url":"https://github.com/ancorgs","followers_url":"https://api.github.com/users/ancorgs/followers","following_url":"https://api.github.com/users/ancorgs/following{/other_user}","gists_url":"https://api.github.com/users/ancorgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ancorgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancorgs/subscriptions","organizations_url":"https://api.github.com/users/ancorgs/orgs","repos_url":"https://api.github.com/users/ancorgs/repos","events_url":"https://api.github.com/users/ancorgs/events{/privacy}","received_events_url":"https://api.github.com/users/ancorgs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ancorgs/yast-storage-ng","description":null,"fork":true,"url":"https://api.github.com/repos/ancorgs/yast-storage-ng","forks_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/forks","keys_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/teams","hooks_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/hooks","issue_events_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/events","assignees_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/tags","blobs_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/languages","stargazers_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/stargazers","contributors_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/contributors","subscribers_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/subscribers","subscription_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/subscription","commits_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/merges","archive_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/downloads","issues_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/labels{/name}","releases_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/ancorgs/yast-storage-ng/deployments","created_at":"2016-02-26T13:28:05Z","updated_at":"2016-02-26T13:28:06Z","pushed_at":"2018-03-07T17:43:48Z","git_url":"git://github.com/ancorgs/yast-storage-ng.git","ssh_url":"git@github.com:ancorgs/yast-storage-ng.git","clone_url":"https://github.com/ancorgs/yast-storage-ng.git","svn_url":"https://github.com/ancorgs/yast-storage-ng","homepage":null,"size":4992,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"a6bbbaf2f47882053eec71deecd42c6d6a14a43e","user":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":46064409,"name":"yast-storage-ng","full_name":"yast/yast-storage-ng","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-storage-ng","description":"Rewrite of https://github.com/yast/yast-storage","fork":false,"url":"https://api.github.com/repos/yast/yast-storage-ng","forks_url":"https://api.github.com/repos/yast/yast-storage-ng/forks","keys_url":"https://api.github.com/repos/yast/yast-storage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-storage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-storage-ng/teams","hooks_url":"https://api.github.com/repos/yast/yast-storage-ng/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-storage-ng/events","assignees_url":"https://api.github.com/repos/yast/yast-storage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-storage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-storage-ng/tags","blobs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-storage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-storage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-storage-ng/languages","stargazers_url":"https://api.github.com/repos/yast/yast-storage-ng/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-storage-ng/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-storage-ng/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-storage-ng/subscription","commits_url":"https://api.github.com/repos/yast/yast-storage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-storage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-storage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-storage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-storage-ng/merges","archive_url":"https://api.github.com/repos/yast/yast-storage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-storage-ng/downloads","issues_url":"https://api.github.com/repos/yast/yast-storage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-storage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-storage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-storage-ng/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-storage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-storage-ng/deployments","created_at":"2015-11-12T16:09:03Z","updated_at":"2017-12-13T17:35:51Z","pushed_at":"2018-03-07T17:43:49Z","git_url":"git://github.com/yast/yast-storage-ng.git","ssh_url":"git@github.com:yast/yast-storage-ng.git","clone_url":"https://github.com/yast/yast-storage-ng.git","svn_url":"https://github.com/yast/yast-storage-ng","homepage":"http://yast.github.io/","size":4858,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":13,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/564"},"html":{"href":"https://github.com/yast/yast-storage-ng/pull/564"},"issue":{"href":"https://api.github.com/repos/yast/yast-storage-ng/issues/564"},"comments":{"href":"https://api.github.com/repos/yast/yast-storage-ng/issues/564/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/564/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/564/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-storage-ng/statuses/0477c5303b073bf927a4e2592734e644c515efea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ancorgs"}}