{"action":"created","comment":{"url":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls/comments/208135288","pull_request_review_id":143882933,"id":208135288,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODEzNTI4OA==","diff_hunk":"@@ -98,17 +104,21 @@ def test_with_large_files(self):\n \n     def test_buffered_large_files(self):\n         test_sizes = [1000, 10000, 100000]\n+        test_sizes = [10,]\n \n         for size in test_sizes:\n-            contents = random_string(size)\n+            contents = bytes(random_string(size), encoding='ascii')\n+            self.assertTrue(len(contents), size)\n \n             with EncodedFile(TEST_FILENAME, mode='wb') as fp:\n                 fp.write(contents)\n \n             with EncodedFile(TEST_FILENAME) as fp:\n                 # Read small buffer sizes\n-                read_func = functools.partial(fp.read, 512)\n-                read_str = ''.join([s for s in iter(read_func, '')])\n+                read_str = fp.read()\n+                # FIXME!","path":"tests/test_streams.py","position":45,"original_position":45,"commit_id":"f0e17c2bc13f38f83c81d3e9a106dea55036deba","original_commit_id":"f0e17c2bc13f38f83c81d3e9a106dea55036deba","user":{"login":"kalouantonis","id":2864000,"node_id":"MDQ6VXNlcjI4NjQwMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2864000?v=4","gravatar_id":"","url":"https://api.github.com/users/kalouantonis","html_url":"https://github.com/kalouantonis","followers_url":"https://api.github.com/users/kalouantonis/followers","following_url":"https://api.github.com/users/kalouantonis/following{/other_user}","gists_url":"https://api.github.com/users/kalouantonis/gists{/gist_id}","starred_url":"https://api.github.com/users/kalouantonis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalouantonis/subscriptions","organizations_url":"https://api.github.com/users/kalouantonis/orgs","repos_url":"https://api.github.com/users/kalouantonis/repos","events_url":"https://api.github.com/users/kalouantonis/events{/privacy}","received_events_url":"https://api.github.com/users/kalouantonis/received_events","type":"User","site_admin":false},"body":"How come you marked this one as FIXME? ","created_at":"2018-08-07T08:08:55Z","updated_at":"2018-08-07T08:08:55Z","html_url":"https://github.com/johan-sports/pyheatshrink/pull/15#discussion_r208135288","pull_request_url":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls/15","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls/comments/208135288"},"html":{"href":"https://github.com/johan-sports/pyheatshrink/pull/15#discussion_r208135288"},"pull_request":{"href":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls/15","id":206212002,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjEyMDAy","html_url":"https://github.com/johan-sports/pyheatshrink/pull/15","diff_url":"https://github.com/johan-sports/pyheatshrink/pull/15.diff","patch_url":"https://github.com/johan-sports/pyheatshrink/pull/15.patch","issue_url":"https://api.github.com/repos/johan-sports/pyheatshrink/issues/15","number":15,"state":"open","locked":false,"title":"Python3 fix","user":{"login":"nyov","id":438293,"node_id":"MDQ6VXNlcjQzODI5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/438293?v=4","gravatar_id":"","url":"https://api.github.com/users/nyov","html_url":"https://github.com/nyov","followers_url":"https://api.github.com/users/nyov/followers","following_url":"https://api.github.com/users/nyov/following{/other_user}","gists_url":"https://api.github.com/users/nyov/gists{/gist_id}","starred_url":"https://api.github.com/users/nyov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyov/subscriptions","organizations_url":"https://api.github.com/users/nyov/orgs","repos_url":"https://api.github.com/users/nyov/repos","events_url":"https://api.github.com/users/nyov/events{/privacy}","received_events_url":"https://api.github.com/users/nyov/received_events","type":"User","site_admin":false},"body":"This makes it work for me (Python 3.5).","created_at":"2018-08-04T22:09:58Z","updated_at":"2018-08-07T08:08:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88b4043b458ce010cad8a23fbaed1327b370ee02","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls/15/commits","review_comments_url":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls/15/comments","review_comment_url":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/johan-sports/pyheatshrink/issues/15/comments","statuses_url":"https://api.github.com/repos/johan-sports/pyheatshrink/statuses/f0e17c2bc13f38f83c81d3e9a106dea55036deba","head":{"label":"nyov:patch","ref":"patch","sha":"f0e17c2bc13f38f83c81d3e9a106dea55036deba","user":{"login":"nyov","id":438293,"node_id":"MDQ6VXNlcjQzODI5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/438293?v=4","gravatar_id":"","url":"https://api.github.com/users/nyov","html_url":"https://github.com/nyov","followers_url":"https://api.github.com/users/nyov/followers","following_url":"https://api.github.com/users/nyov/following{/other_user}","gists_url":"https://api.github.com/users/nyov/gists{/gist_id}","starred_url":"https://api.github.com/users/nyov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyov/subscriptions","organizations_url":"https://api.github.com/users/nyov/orgs","repos_url":"https://api.github.com/users/nyov/repos","events_url":"https://api.github.com/users/nyov/events{/privacy}","received_events_url":"https://api.github.com/users/nyov/received_events","type":"User","site_admin":false},"repo":{"id":143565981,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1NjU5ODE=","name":"pyheatshrink","full_name":"nyov/pyheatshrink","owner":{"login":"nyov","id":438293,"node_id":"MDQ6VXNlcjQzODI5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/438293?v=4","gravatar_id":"","url":"https://api.github.com/users/nyov","html_url":"https://github.com/nyov","followers_url":"https://api.github.com/users/nyov/followers","following_url":"https://api.github.com/users/nyov/following{/other_user}","gists_url":"https://api.github.com/users/nyov/gists{/gist_id}","starred_url":"https://api.github.com/users/nyov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyov/subscriptions","organizations_url":"https://api.github.com/users/nyov/orgs","repos_url":"https://api.github.com/users/nyov/repos","events_url":"https://api.github.com/users/nyov/events{/privacy}","received_events_url":"https://api.github.com/users/nyov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nyov/pyheatshrink","description":"Python binding to the heatshrink library","fork":true,"url":"https://api.github.com/repos/nyov/pyheatshrink","forks_url":"https://api.github.com/repos/nyov/pyheatshrink/forks","keys_url":"https://api.github.com/repos/nyov/pyheatshrink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyov/pyheatshrink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyov/pyheatshrink/teams","hooks_url":"https://api.github.com/repos/nyov/pyheatshrink/hooks","issue_events_url":"https://api.github.com/repos/nyov/pyheatshrink/issues/events{/number}","events_url":"https://api.github.com/repos/nyov/pyheatshrink/events","assignees_url":"https://api.github.com/repos/nyov/pyheatshrink/assignees{/user}","branches_url":"https://api.github.com/repos/nyov/pyheatshrink/branches{/branch}","tags_url":"https://api.github.com/repos/nyov/pyheatshrink/tags","blobs_url":"https://api.github.com/repos/nyov/pyheatshrink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyov/pyheatshrink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyov/pyheatshrink/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyov/pyheatshrink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyov/pyheatshrink/statuses/{sha}","languages_url":"https://api.github.com/repos/nyov/pyheatshrink/languages","stargazers_url":"https://api.github.com/repos/nyov/pyheatshrink/stargazers","contributors_url":"https://api.github.com/repos/nyov/pyheatshrink/contributors","subscribers_url":"https://api.github.com/repos/nyov/pyheatshrink/subscribers","subscription_url":"https://api.github.com/repos/nyov/pyheatshrink/subscription","commits_url":"https://api.github.com/repos/nyov/pyheatshrink/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyov/pyheatshrink/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyov/pyheatshrink/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyov/pyheatshrink/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyov/pyheatshrink/contents/{+path}","compare_url":"https://api.github.com/repos/nyov/pyheatshrink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyov/pyheatshrink/merges","archive_url":"https://api.github.com/repos/nyov/pyheatshrink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyov/pyheatshrink/downloads","issues_url":"https://api.github.com/repos/nyov/pyheatshrink/issues{/number}","pulls_url":"https://api.github.com/repos/nyov/pyheatshrink/pulls{/number}","milestones_url":"https://api.github.com/repos/nyov/pyheatshrink/milestones{/number}","notifications_url":"https://api.github.com/repos/nyov/pyheatshrink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyov/pyheatshrink/labels{/name}","releases_url":"https://api.github.com/repos/nyov/pyheatshrink/releases{/id}","deployments_url":"https://api.github.com/repos/nyov/pyheatshrink/deployments","created_at":"2018-08-04T22:05:43Z","updated_at":"2018-08-04T22:05:45Z","pushed_at":"2018-08-06T16:59:40Z","git_url":"git://github.com/nyov/pyheatshrink.git","ssh_url":"git@github.com:nyov/pyheatshrink.git","clone_url":"https://github.com/nyov/pyheatshrink.git","svn_url":"https://github.com/nyov/pyheatshrink","homepage":"","size":3082,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"johan-sports:master","ref":"master","sha":"e915fab0c1fd57e1da3b55ad2d1e4ee5586bc0f0","user":{"login":"johan-sports","id":19567521,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTY3NTIx","avatar_url":"https://avatars1.githubusercontent.com/u/19567521?v=4","gravatar_id":"","url":"https://api.github.com/users/johan-sports","html_url":"https://github.com/johan-sports","followers_url":"https://api.github.com/users/johan-sports/followers","following_url":"https://api.github.com/users/johan-sports/following{/other_user}","gists_url":"https://api.github.com/users/johan-sports/gists{/gist_id}","starred_url":"https://api.github.com/users/johan-sports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johan-sports/subscriptions","organizations_url":"https://api.github.com/users/johan-sports/orgs","repos_url":"https://api.github.com/users/johan-sports/repos","events_url":"https://api.github.com/users/johan-sports/events{/privacy}","received_events_url":"https://api.github.com/users/johan-sports/received_events","type":"Organization","site_admin":false},"repo":{"id":59664790,"node_id":"MDEwOlJlcG9zaXRvcnk1OTY2NDc5MA==","name":"pyheatshrink","full_name":"johan-sports/pyheatshrink","owner":{"login":"johan-sports","id":19567521,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTY3NTIx","avatar_url":"https://avatars1.githubusercontent.com/u/19567521?v=4","gravatar_id":"","url":"https://api.github.com/users/johan-sports","html_url":"https://github.com/johan-sports","followers_url":"https://api.github.com/users/johan-sports/followers","following_url":"https://api.github.com/users/johan-sports/following{/other_user}","gists_url":"https://api.github.com/users/johan-sports/gists{/gist_id}","starred_url":"https://api.github.com/users/johan-sports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johan-sports/subscriptions","organizations_url":"https://api.github.com/users/johan-sports/orgs","repos_url":"https://api.github.com/users/johan-sports/repos","events_url":"https://api.github.com/users/johan-sports/events{/privacy}","received_events_url":"https://api.github.com/users/johan-sports/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/johan-sports/pyheatshrink","description":"Python binding to the heatshrink library","fork":false,"url":"https://api.github.com/repos/johan-sports/pyheatshrink","forks_url":"https://api.github.com/repos/johan-sports/pyheatshrink/forks","keys_url":"https://api.github.com/repos/johan-sports/pyheatshrink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johan-sports/pyheatshrink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johan-sports/pyheatshrink/teams","hooks_url":"https://api.github.com/repos/johan-sports/pyheatshrink/hooks","issue_events_url":"https://api.github.com/repos/johan-sports/pyheatshrink/issues/events{/number}","events_url":"https://api.github.com/repos/johan-sports/pyheatshrink/events","assignees_url":"https://api.github.com/repos/johan-sports/pyheatshrink/assignees{/user}","branches_url":"https://api.github.com/repos/johan-sports/pyheatshrink/branches{/branch}","tags_url":"https://api.github.com/repos/johan-sports/pyheatshrink/tags","blobs_url":"https://api.github.com/repos/johan-sports/pyheatshrink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johan-sports/pyheatshrink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johan-sports/pyheatshrink/git/refs{/sha}","trees_url":"https://api.github.com/repos/johan-sports/pyheatshrink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johan-sports/pyheatshrink/statuses/{sha}","languages_url":"https://api.github.com/repos/johan-sports/pyheatshrink/languages","stargazers_url":"https://api.github.com/repos/johan-sports/pyheatshrink/stargazers","contributors_url":"https://api.github.com/repos/johan-sports/pyheatshrink/contributors","subscribers_url":"https://api.github.com/repos/johan-sports/pyheatshrink/subscribers","subscription_url":"https://api.github.com/repos/johan-sports/pyheatshrink/subscription","commits_url":"https://api.github.com/repos/johan-sports/pyheatshrink/commits{/sha}","git_commits_url":"https://api.github.com/repos/johan-sports/pyheatshrink/git/commits{/sha}","comments_url":"https://api.github.com/repos/johan-sports/pyheatshrink/comments{/number}","issue_comment_url":"https://api.github.com/repos/johan-sports/pyheatshrink/issues/comments{/number}","contents_url":"https://api.github.com/repos/johan-sports/pyheatshrink/contents/{+path}","compare_url":"https://api.github.com/repos/johan-sports/pyheatshrink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johan-sports/pyheatshrink/merges","archive_url":"https://api.github.com/repos/johan-sports/pyheatshrink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johan-sports/pyheatshrink/downloads","issues_url":"https://api.github.com/repos/johan-sports/pyheatshrink/issues{/number}","pulls_url":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls{/number}","milestones_url":"https://api.github.com/repos/johan-sports/pyheatshrink/milestones{/number}","notifications_url":"https://api.github.com/repos/johan-sports/pyheatshrink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johan-sports/pyheatshrink/labels{/name}","releases_url":"https://api.github.com/repos/johan-sports/pyheatshrink/releases{/id}","deployments_url":"https://api.github.com/repos/johan-sports/pyheatshrink/deployments","created_at":"2016-05-25T13:20:04Z","updated_at":"2017-05-14T12:09:37Z","pushed_at":"2018-08-06T16:59:41Z","git_url":"git://github.com/johan-sports/pyheatshrink.git","ssh_url":"git@github.com:johan-sports/pyheatshrink.git","clone_url":"https://github.com/johan-sports/pyheatshrink.git","svn_url":"https://github.com/johan-sports/pyheatshrink","homepage":"","size":3080,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":2,"open_issues":2,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls/15"},"html":{"href":"https://github.com/johan-sports/pyheatshrink/pull/15"},"issue":{"href":"https://api.github.com/repos/johan-sports/pyheatshrink/issues/15"},"comments":{"href":"https://api.github.com/repos/johan-sports/pyheatshrink/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/johan-sports/pyheatshrink/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/johan-sports/pyheatshrink/statuses/f0e17c2bc13f38f83c81d3e9a106dea55036deba"}},"author_association":"NONE"}}
{"actor":{"display_login":"kalouantonis"}}