{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/comments/178307546","pull_request_review_id":108352558,"id":178307546,"diff_hunk":"@@ -171,6 +171,9 @@ public String url() {\n \n     private transient boolean allowKill;\n \n+    /** Controls whether or not our execution has been initialized via its {@link FlowExecution#onLoad(FlowExecutionOwner)} method yet if.*/\n+    transient boolean executionLoaded = false;  // NonPrivate for tests","path":"src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java","position":32,"original_position":32,"commit_id":"3cc104b7990fec46269c33ecbbfe22b7f6523ebb","original_commit_id":"3cc104b7990fec46269c33ecbbfe22b7f6523ebb","user":{"login":"abayer","id":120218,"avatar_url":"https://avatars2.githubusercontent.com/u/120218?v=4","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"body":"I actually wonder if that might be something we want to expose outside of just tests - I don't have a specific scenario in mind, but I know I've stumbled across cases where this could be useful information. I think. I may be getting confused with something else, though.","created_at":"2018-03-30T15:04:43Z","updated_at":"2018-03-30T15:13:44Z","html_url":"https://github.com/jenkinsci/workflow-job-plugin/pull/93#discussion_r178307546","pull_request_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/93","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/comments/178307546"},"html":{"href":"https://github.com/jenkinsci/workflow-job-plugin/pull/93#discussion_r178307546"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/93","id":178085519,"html_url":"https://github.com/jenkinsci/workflow-job-plugin/pull/93","diff_url":"https://github.com/jenkinsci/workflow-job-plugin/pull/93.diff","patch_url":"https://github.com/jenkinsci/workflow-job-plugin/pull/93.patch","issue_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/93","number":93,"state":"open","locked":false,"title":"[WIP] Fix resume issues [JENKINS-49686] and [JENKINS-50199] and [JENKINS-50407]","user":{"login":"svanoort","id":5400948,"avatar_url":"https://avatars3.githubusercontent.com/u/5400948?v=4","gravatar_id":"","url":"https://api.github.com/users/svanoort","html_url":"https://github.com/svanoort","followers_url":"https://api.github.com/users/svanoort/followers","following_url":"https://api.github.com/users/svanoort/following{/other_user}","gists_url":"https://api.github.com/users/svanoort/gists{/gist_id}","starred_url":"https://api.github.com/users/svanoort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svanoort/subscriptions","organizations_url":"https://api.github.com/users/svanoort/orgs","repos_url":"https://api.github.com/users/svanoort/repos","events_url":"https://api.github.com/users/svanoort/events{/privacy}","received_events_url":"https://api.github.com/users/svanoort/received_events","type":"User","site_admin":false},"body":"Aims to resolve (in conjunction with workflow-cps changes as well that help harden the logic): \r\n\r\n* [JENKINS-50199](https://issues.jenkins-ci.org/browse/JENKINS-50199)\r\n* [JENKINS-46986](https://issues.jenkins-ci.org/browse/JENKINS-46986)\r\n* [JENKINS-50407](https://issues.jenkins-ci.org/browse/JENKINS-50407)\r\n\r\nIncludes lazy-load for FlowExecutions (enhancement):  [JENKINS-45585](https://issues.jenkins-ci.org/browse/JENKINS-45585) -- which if merged will replace [49086](https://issues.jenkins-ci.org/browse/JENKINS-49086) because it will defer a ton of the load-time logic for completed Pipelines.\r\n\r\nTODOs:\r\n\r\n* Cross-test with workflow-cps durability tests\r\n* Fix issue with unitialized listener field for unable-to-resume flows (may mandate changes in wf-cps too)\r\n* Hardening: consider forcing atomic write of XML file when re-saving with the completed field persisted -- even when normally non-atomic (guarantees we won't mangle original build record if an error occurs upon save). ","created_at":"2018-03-28T15:56:09Z","updated_at":"2018-03-30T15:13:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3a782fc83282ab051cb829cf259817645ed6058","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jglick","id":154109,"avatar_url":"https://avatars1.githubusercontent.com/u/154109?v=4","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":385354193,"url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/labels/work-in-progress","name":"work-in-progress","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/93/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/93/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/93/comments","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/statuses/3cc104b7990fec46269c33ecbbfe22b7f6523ebb","head":{"label":"svanoort:fix-resume-issues","ref":"fix-resume-issues","sha":"3cc104b7990fec46269c33ecbbfe22b7f6523ebb","user":{"login":"svanoort","id":5400948,"avatar_url":"https://avatars3.githubusercontent.com/u/5400948?v=4","gravatar_id":"","url":"https://api.github.com/users/svanoort","html_url":"https://github.com/svanoort","followers_url":"https://api.github.com/users/svanoort/followers","following_url":"https://api.github.com/users/svanoort/following{/other_user}","gists_url":"https://api.github.com/users/svanoort/gists{/gist_id}","starred_url":"https://api.github.com/users/svanoort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svanoort/subscriptions","organizations_url":"https://api.github.com/users/svanoort/orgs","repos_url":"https://api.github.com/users/svanoort/repos","events_url":"https://api.github.com/users/svanoort/events{/privacy}","received_events_url":"https://api.github.com/users/svanoort/received_events","type":"User","site_admin":false},"repo":{"id":102875636,"name":"workflow-job-plugin","full_name":"svanoort/workflow-job-plugin","owner":{"login":"svanoort","id":5400948,"avatar_url":"https://avatars3.githubusercontent.com/u/5400948?v=4","gravatar_id":"","url":"https://api.github.com/users/svanoort","html_url":"https://github.com/svanoort","followers_url":"https://api.github.com/users/svanoort/followers","following_url":"https://api.github.com/users/svanoort/following{/other_user}","gists_url":"https://api.github.com/users/svanoort/gists{/gist_id}","starred_url":"https://api.github.com/users/svanoort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svanoort/subscriptions","organizations_url":"https://api.github.com/users/svanoort/orgs","repos_url":"https://api.github.com/users/svanoort/repos","events_url":"https://api.github.com/users/svanoort/events{/privacy}","received_events_url":"https://api.github.com/users/svanoort/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/svanoort/workflow-job-plugin","description":null,"fork":true,"url":"https://api.github.com/repos/svanoort/workflow-job-plugin","forks_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/forks","keys_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/teams","hooks_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/hooks","issue_events_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/events","assignees_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/tags","blobs_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/languages","stargazers_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/stargazers","contributors_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/contributors","subscribers_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/subscribers","subscription_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/subscription","commits_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/merges","archive_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/downloads","issues_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/labels{/name}","releases_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/svanoort/workflow-job-plugin/deployments","created_at":"2017-09-08T15:23:51Z","updated_at":"2017-09-08T15:23:53Z","pushed_at":"2018-03-30T14:51:43Z","git_url":"git://github.com/svanoort/workflow-job-plugin.git","ssh_url":"git@github.com:svanoort/workflow-job-plugin.git","clone_url":"https://github.com/svanoort/workflow-job-plugin.git","svn_url":"https://github.com/svanoort/workflow-job-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Job+Plugin","size":694,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"023a0659bf9eb375b421ab2a777eb8bc5eaa8572","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":55543389,"name":"workflow-job-plugin","full_name":"jenkinsci/workflow-job-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/workflow-job-plugin","description":null,"fork":false,"url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin","forks_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/deployments","created_at":"2016-04-05T20:27:07Z","updated_at":"2018-03-08T08:34:00Z","pushed_at":"2018-03-30T14:51:44Z","git_url":"git://github.com/jenkinsci/workflow-job-plugin.git","ssh_url":"git@github.com:jenkinsci/workflow-job-plugin.git","clone_url":"https://github.com/jenkinsci/workflow-job-plugin.git","svn_url":"https://github.com/jenkinsci/workflow-job-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Job+Plugin","size":684,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":49,"open_issues":13,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/93"},"html":{"href":"https://github.com/jenkinsci/workflow-job-plugin/pull/93"},"issue":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/93"},"comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/statuses/3cc104b7990fec46269c33ecbbfe22b7f6523ebb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"abayer"}}