{"action":"created","comment":{"url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/comments/225067542","pull_request_review_id":164584814,"id":225067542,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTA2NzU0Mg==","diff_hunk":"@@ -0,0 +1,33 @@\n+//\n+//  Shape.swift\n+//  CoordinateCalculator\n+//\n+//  Created by 윤지영 on 13/10/2018.\n+//  Copyright © 2018 Codesquad Inc. All rights reserved.\n+//\n+\n+import Foundation\n+\n+typealias Point = (x: Int, y: Int)\n+\n+protocol Shape {\n+    var points: [MyPoint] { get }\n+}\n+\n+protocol CalculableShape: Shape {\n+    var calculationMessage: String { get }","path":"CoordinateCalculator/CoordinateCalculator/Shape.swift","position":18,"original_position":18,"commit_id":"2a9834e6aaf4400a83420c0ca2bcdc0ba781c3b0","original_commit_id":"4e26a1117f7929f7149f36f666f924a5cc16fae8","user":{"login":"godrm","id":278988,"node_id":"MDQ6VXNlcjI3ODk4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/278988?v=4","gravatar_id":"","url":"https://api.github.com/users/godrm","html_url":"https://github.com/godrm","followers_url":"https://api.github.com/users/godrm/followers","following_url":"https://api.github.com/users/godrm/following{/other_user}","gists_url":"https://api.github.com/users/godrm/gists{/gist_id}","starred_url":"https://api.github.com/users/godrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godrm/subscriptions","organizations_url":"https://api.github.com/users/godrm/orgs","repos_url":"https://api.github.com/users/godrm/repos","events_url":"https://api.github.com/users/godrm/events{/privacy}","received_events_url":"https://api.github.com/users/godrm/received_events","type":"User","site_admin":false},"body":"네 일단 `var` 가 붙어있으면 더 그렇죠 :)  ","created_at":"2018-10-15T07:53:14Z","updated_at":"2018-10-15T07:53:14Z","html_url":"https://github.com/code-squad/swift-coordinate/pull/121#discussion_r225067542","pull_request_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/121","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/comments/225067542"},"html":{"href":"https://github.com/code-squad/swift-coordinate/pull/121#discussion_r225067542"},"pull_request":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/121"}},"in_reply_to_id":225048325},"pull_request":{"url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/121","id":222789324,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzg5MzI0","html_url":"https://github.com/code-squad/swift-coordinate/pull/121","diff_url":"https://github.com/code-squad/swift-coordinate/pull/121.diff","patch_url":"https://github.com/code-squad/swift-coordinate/pull/121.patch","issue_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues/121","number":121,"state":"open","locked":false,"title":"좌표계산기 3단계 - 직선 입력과 출력","user":{"login":"popsmile","id":29696471,"node_id":"MDQ6VXNlcjI5Njk2NDcx","avatar_url":"https://avatars2.githubusercontent.com/u/29696471?v=4","gravatar_id":"","url":"https://api.github.com/users/popsmile","html_url":"https://github.com/popsmile","followers_url":"https://api.github.com/users/popsmile/followers","following_url":"https://api.github.com/users/popsmile/following{/other_user}","gists_url":"https://api.github.com/users/popsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/popsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popsmile/subscriptions","organizations_url":"https://api.github.com/users/popsmile/orgs","repos_url":"https://api.github.com/users/popsmile/repos","events_url":"https://api.github.com/users/popsmile/events{/privacy}","received_events_url":"https://api.github.com/users/popsmile/received_events","type":"User","site_admin":false},"body":"- 두 개의 좌표값을 처리할 수 있도록, 입력받은 값을 `-`로 나누어 따로 선언해놓은 `Point(x:Int, y:Int)` 튜플 타입으로 저장하여 이전 단계에서 수행한 과정을 동일하게 거치도록 만들었습니다.\r\n- `MyLine` 구조체를 추가했습니다. \r\n- `OutputView` 에서 같은 출력 메소드를 사용하고자 `Shape` 프로토콜을 추가하여 `MyPoint` 와 `MyLine` 이 해당 프로토콜을 따르도록 수정했습니다. \r\n- `Shape` 에 `[Points]` 라는 내부 프로퍼티를 선언하고, 이를 활용하여 `ShapeGenerator` 를 통해 `OutputView` 에 전달해줄 `MyPoint` 와 `MyLine` 을 생성해주었습니다. ","created_at":"2018-10-15T05:58:04Z","updated_at":"2018-10-15T07:53:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3af1d3fe354a7e4d81139022abf65bdb3acad7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/121/commits","review_comments_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/121/comments","review_comment_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues/121/comments","statuses_url":"https://api.github.com/repos/code-squad/swift-coordinate/statuses/2a9834e6aaf4400a83420c0ca2bcdc0ba781c3b0","head":{"label":"popsmile:coordinate-step3","ref":"coordinate-step3","sha":"2a9834e6aaf4400a83420c0ca2bcdc0ba781c3b0","user":{"login":"popsmile","id":29696471,"node_id":"MDQ6VXNlcjI5Njk2NDcx","avatar_url":"https://avatars2.githubusercontent.com/u/29696471?v=4","gravatar_id":"","url":"https://api.github.com/users/popsmile","html_url":"https://github.com/popsmile","followers_url":"https://api.github.com/users/popsmile/followers","following_url":"https://api.github.com/users/popsmile/following{/other_user}","gists_url":"https://api.github.com/users/popsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/popsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popsmile/subscriptions","organizations_url":"https://api.github.com/users/popsmile/orgs","repos_url":"https://api.github.com/users/popsmile/repos","events_url":"https://api.github.com/users/popsmile/events{/privacy}","received_events_url":"https://api.github.com/users/popsmile/received_events","type":"User","site_admin":false},"repo":{"id":151522806,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1MjI4MDY=","name":"swift-coordinate","full_name":"popsmile/swift-coordinate","private":false,"owner":{"login":"popsmile","id":29696471,"node_id":"MDQ6VXNlcjI5Njk2NDcx","avatar_url":"https://avatars2.githubusercontent.com/u/29696471?v=4","gravatar_id":"","url":"https://api.github.com/users/popsmile","html_url":"https://github.com/popsmile","followers_url":"https://api.github.com/users/popsmile/followers","following_url":"https://api.github.com/users/popsmile/following{/other_user}","gists_url":"https://api.github.com/users/popsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/popsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popsmile/subscriptions","organizations_url":"https://api.github.com/users/popsmile/orgs","repos_url":"https://api.github.com/users/popsmile/repos","events_url":"https://api.github.com/users/popsmile/events{/privacy}","received_events_url":"https://api.github.com/users/popsmile/received_events","type":"User","site_admin":false},"html_url":"https://github.com/popsmile/swift-coordinate","description":"좌표계산기_저장소","fork":true,"url":"https://api.github.com/repos/popsmile/swift-coordinate","forks_url":"https://api.github.com/repos/popsmile/swift-coordinate/forks","keys_url":"https://api.github.com/repos/popsmile/swift-coordinate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/popsmile/swift-coordinate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/popsmile/swift-coordinate/teams","hooks_url":"https://api.github.com/repos/popsmile/swift-coordinate/hooks","issue_events_url":"https://api.github.com/repos/popsmile/swift-coordinate/issues/events{/number}","events_url":"https://api.github.com/repos/popsmile/swift-coordinate/events","assignees_url":"https://api.github.com/repos/popsmile/swift-coordinate/assignees{/user}","branches_url":"https://api.github.com/repos/popsmile/swift-coordinate/branches{/branch}","tags_url":"https://api.github.com/repos/popsmile/swift-coordinate/tags","blobs_url":"https://api.github.com/repos/popsmile/swift-coordinate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/popsmile/swift-coordinate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/popsmile/swift-coordinate/git/refs{/sha}","trees_url":"https://api.github.com/repos/popsmile/swift-coordinate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/popsmile/swift-coordinate/statuses/{sha}","languages_url":"https://api.github.com/repos/popsmile/swift-coordinate/languages","stargazers_url":"https://api.github.com/repos/popsmile/swift-coordinate/stargazers","contributors_url":"https://api.github.com/repos/popsmile/swift-coordinate/contributors","subscribers_url":"https://api.github.com/repos/popsmile/swift-coordinate/subscribers","subscription_url":"https://api.github.com/repos/popsmile/swift-coordinate/subscription","commits_url":"https://api.github.com/repos/popsmile/swift-coordinate/commits{/sha}","git_commits_url":"https://api.github.com/repos/popsmile/swift-coordinate/git/commits{/sha}","comments_url":"https://api.github.com/repos/popsmile/swift-coordinate/comments{/number}","issue_comment_url":"https://api.github.com/repos/popsmile/swift-coordinate/issues/comments{/number}","contents_url":"https://api.github.com/repos/popsmile/swift-coordinate/contents/{+path}","compare_url":"https://api.github.com/repos/popsmile/swift-coordinate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/popsmile/swift-coordinate/merges","archive_url":"https://api.github.com/repos/popsmile/swift-coordinate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/popsmile/swift-coordinate/downloads","issues_url":"https://api.github.com/repos/popsmile/swift-coordinate/issues{/number}","pulls_url":"https://api.github.com/repos/popsmile/swift-coordinate/pulls{/number}","milestones_url":"https://api.github.com/repos/popsmile/swift-coordinate/milestones{/number}","notifications_url":"https://api.github.com/repos/popsmile/swift-coordinate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/popsmile/swift-coordinate/labels{/name}","releases_url":"https://api.github.com/repos/popsmile/swift-coordinate/releases{/id}","deployments_url":"https://api.github.com/repos/popsmile/swift-coordinate/deployments","created_at":"2018-10-04T05:27:39Z","updated_at":"2018-10-04T05:27:41Z","pushed_at":"2018-10-15T07:49:33Z","git_url":"git://github.com/popsmile/swift-coordinate.git","ssh_url":"git@github.com:popsmile/swift-coordinate.git","clone_url":"https://github.com/popsmile/swift-coordinate.git","svn_url":"https://github.com/popsmile/swift-coordinate","homepage":null,"size":3617,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"code-squad:popsmile","ref":"popsmile","sha":"ae29b512164eddeeba00c7b3e7575e578ef5cc5e","user":{"login":"code-squad","id":22832280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODMyMjgw","avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"repo":{"id":106258411,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYyNTg0MTE=","name":"swift-coordinate","full_name":"code-squad/swift-coordinate","private":false,"owner":{"login":"code-squad","id":22832280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODMyMjgw","avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/code-squad/swift-coordinate","description":"좌표계산기_저장소","fork":false,"url":"https://api.github.com/repos/code-squad/swift-coordinate","forks_url":"https://api.github.com/repos/code-squad/swift-coordinate/forks","keys_url":"https://api.github.com/repos/code-squad/swift-coordinate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-squad/swift-coordinate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-squad/swift-coordinate/teams","hooks_url":"https://api.github.com/repos/code-squad/swift-coordinate/hooks","issue_events_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues/events{/number}","events_url":"https://api.github.com/repos/code-squad/swift-coordinate/events","assignees_url":"https://api.github.com/repos/code-squad/swift-coordinate/assignees{/user}","branches_url":"https://api.github.com/repos/code-squad/swift-coordinate/branches{/branch}","tags_url":"https://api.github.com/repos/code-squad/swift-coordinate/tags","blobs_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-squad/swift-coordinate/statuses/{sha}","languages_url":"https://api.github.com/repos/code-squad/swift-coordinate/languages","stargazers_url":"https://api.github.com/repos/code-squad/swift-coordinate/stargazers","contributors_url":"https://api.github.com/repos/code-squad/swift-coordinate/contributors","subscribers_url":"https://api.github.com/repos/code-squad/swift-coordinate/subscribers","subscription_url":"https://api.github.com/repos/code-squad/swift-coordinate/subscription","commits_url":"https://api.github.com/repos/code-squad/swift-coordinate/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-squad/swift-coordinate/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-squad/swift-coordinate/contents/{+path}","compare_url":"https://api.github.com/repos/code-squad/swift-coordinate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-squad/swift-coordinate/merges","archive_url":"https://api.github.com/repos/code-squad/swift-coordinate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-squad/swift-coordinate/downloads","issues_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues{/number}","pulls_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls{/number}","milestones_url":"https://api.github.com/repos/code-squad/swift-coordinate/milestones{/number}","notifications_url":"https://api.github.com/repos/code-squad/swift-coordinate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-squad/swift-coordinate/labels{/name}","releases_url":"https://api.github.com/repos/code-squad/swift-coordinate/releases{/id}","deployments_url":"https://api.github.com/repos/code-squad/swift-coordinate/deployments","created_at":"2017-10-09T08:45:05Z","updated_at":"2018-07-12T09:09:19Z","pushed_at":"2018-10-15T07:49:34Z","git_url":"git://github.com/code-squad/swift-coordinate.git","ssh_url":"git@github.com:code-squad/swift-coordinate.git","clone_url":"https://github.com/code-squad/swift-coordinate.git","svn_url":"https://github.com/code-squad/swift-coordinate","homepage":null,"size":3595,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":23,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/121"},"html":{"href":"https://github.com/code-squad/swift-coordinate/pull/121"},"issue":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/issues/121"},"comments":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/statuses/2a9834e6aaf4400a83420c0ca2bcdc0ba781c3b0"}},"author_association":"NONE"}}
{"actor":{"display_login":"godrm"}}