{"action":"closed","issue":{"url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/issues/688","repository_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc","labels_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/issues/688/labels{/name}","comments_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/issues/688/comments","events_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/issues/688/events","html_url":"https://github.com/scalikejdbc/scalikejdbc/issues/688","id":228194306,"number":688,"title":"unused parameter: scalikejdbc.Log#withLevel \"e: Throwable\"","user":{"login":"xuwei-k","id":389787,"avatar_url":"https://avatars0.githubusercontent.com/u/389787?v=4","gravatar_id":"","url":"https://api.github.com/users/xuwei-k","html_url":"https://github.com/xuwei-k","followers_url":"https://api.github.com/users/xuwei-k/followers","following_url":"https://api.github.com/users/xuwei-k/following{/other_user}","gists_url":"https://api.github.com/users/xuwei-k/gists{/gist_id}","starred_url":"https://api.github.com/users/xuwei-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuwei-k/subscriptions","organizations_url":"https://api.github.com/users/xuwei-k/orgs","repos_url":"https://api.github.com/users/xuwei-k/repos","events_url":"https://api.github.com/users/xuwei-k/events{/privacy}","received_events_url":"https://api.github.com/users/xuwei-k/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"seratch","id":19658,"avatar_url":"https://avatars2.githubusercontent.com/u/19658?v=4","gravatar_id":"","url":"https://api.github.com/users/seratch","html_url":"https://github.com/seratch","followers_url":"https://api.github.com/users/seratch/followers","following_url":"https://api.github.com/users/seratch/following{/other_user}","gists_url":"https://api.github.com/users/seratch/gists{/gist_id}","starred_url":"https://api.github.com/users/seratch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seratch/subscriptions","organizations_url":"https://api.github.com/users/seratch/orgs","repos_url":"https://api.github.com/users/seratch/repos","events_url":"https://api.github.com/users/seratch/events{/privacy}","received_events_url":"https://api.github.com/users/seratch/received_events","type":"User","site_admin":false},"assignees":[{"login":"seratch","id":19658,"avatar_url":"https://avatars2.githubusercontent.com/u/19658?v=4","gravatar_id":"","url":"https://api.github.com/users/seratch","html_url":"https://github.com/seratch","followers_url":"https://api.github.com/users/seratch/followers","following_url":"https://api.github.com/users/seratch/following{/other_user}","gists_url":"https://api.github.com/users/seratch/gists{/gist_id}","starred_url":"https://api.github.com/users/seratch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seratch/subscriptions","organizations_url":"https://api.github.com/users/seratch/orgs","repos_url":"https://api.github.com/users/seratch/repos","events_url":"https://api.github.com/users/seratch/events{/privacy}","received_events_url":"https://api.github.com/users/seratch/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-05-12T05:50:58Z","updated_at":"2018-03-16T05:27:17Z","closed_at":"2018-03-16T05:27:17Z","author_association":"OWNER","body":"https://github.com/scalikejdbc/scalikejdbc/blob/3.0.0-RC4/scalikejdbc-core/src/main/scala/scalikejdbc/Log.scala#L18\r\n\r\njust remove?\r\n\r\n```diff\r\n- def withLevel(level: Symbol)(msg: => String, e: Throwable = null): Unit = {\r\n+ def withLevel(level: Symbol)(msg: => String): Unit = {\r\n```\r\n\r\nor use?\r\n\r\n\r\n```diff\r\n   def withLevel(level: Symbol)(msg: => String, e: Throwable = null): Unit = {\r\n     level match {\r\n-      case 'debug | 'DEBUG => debug(msg)\r\n-      case 'info | 'INFO => info(msg)\r\n-      case 'warn | 'WARN => warn(msg)\r\n-      case 'error | 'ERROR => error(msg)\r\n+      case 'debug | 'DEBUG => if(e == null) debug(msg) else debug(msg, e)\r\n+      case 'info | 'INFO => if(e == null) info(msg) else info(msg, e)\r\n+      case 'warn | 'WARN => if(e == null) warn(msg) else warn(msg, e)\r\n+      case 'error | 'ERROR => if(e == null) error(msg) else error(msg, e)\r\n       case _ => // nothing to do\r\n     }\r\n\r\n```\r\n"}}
{"actor":{"display_login":"seratch"}}