{"action":"closed","number":26377,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/26377","id":192508587,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTA4NTg3","html_url":"https://github.com/cockroachdb/cockroach/pull/26377","diff_url":"https://github.com/cockroachdb/cockroach/pull/26377.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/26377.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/26377","number":26377,"state":"closed","locked":false,"title":"libroach: fix concurrent access to same file when using encryption","user":{"login":"mberhault","id":5901480,"node_id":"MDQ6VXNlcjU5MDE0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5901480?v=4","gravatar_id":"","url":"https://api.github.com/users/mberhault","html_url":"https://github.com/mberhault","followers_url":"https://api.github.com/users/mberhault/followers","following_url":"https://api.github.com/users/mberhault/following{/other_user}","gists_url":"https://api.github.com/users/mberhault/gists{/gist_id}","starred_url":"https://api.github.com/users/mberhault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mberhault/subscriptions","organizations_url":"https://api.github.com/users/mberhault/orgs","repos_url":"https://api.github.com/users/mberhault/repos","events_url":"https://api.github.com/users/mberhault/events{/privacy}","received_events_url":"https://api.github.com/users/mberhault/received_events","type":"User","site_admin":false},"body":"Fixes #26261.\r\n\r\nThe various `Env::***File` objects are used concurrently by rocksdb (eg: in the compaction code).\r\nIf multiple reads occur on the same encrypted file handle and CryptoPP is using the software AES implementation, some working state in the cipher gets corrupted by the other calls. This results in broken decryption bubbling up as checksum failures on rocksdb.\r\n\r\nFix this by passing the key to the `CTRCipherStream` and initializing a new `Cipher` object for each block of data (the `RandomAccessFile::Read` block. This will still use one `Cipher` for multiple AES blocks).\r\n\r\nRelease note (bug fix): fix concurrent access to same file when using encryption","created_at":"2018-06-04T19:45:13Z","updated_at":"2018-06-04T23:20:43Z","closed_at":"2018-06-04T23:20:43Z","merged_at":"2018-06-04T23:20:43Z","merge_commit_sha":"6e9ad403b3cbab4ec1d36f390b26fa19d0fac255","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bdarnell","id":160562,"node_id":"MDQ6VXNlcjE2MDU2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/160562?v=4","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"core-prs","id":2437977,"node_id":"MDQ6VGVhbTI0Mzc5Nzc=","slug":"core-prs","description":"Join this team for notifications about core PRs","privacy":"closed","url":"https://api.github.com/teams/2437977","members_url":"https://api.github.com/teams/2437977/members{/member}","repositories_url":"https://api.github.com/teams/2437977/repos","permission":"pull"},{"name":"sql-ccl-prs","id":2437979,"node_id":"MDQ6VGVhbTI0Mzc5Nzk=","slug":"sql-ccl-prs","description":"Join this team for notifications about SQL CCL PRs","privacy":"closed","url":"https://api.github.com/teams/2437979","members_url":"https://api.github.com/teams/2437979/members{/member}","repositories_url":"https://api.github.com/teams/2437979/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/26377/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/26377/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/26377/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/6e9ad403b3cbab4ec1d36f390b26fa19d0fac255","head":{"label":"mberhault:marc/dont_reuse_cipher","ref":"marc/dont_reuse_cipher","sha":"6e9ad403b3cbab4ec1d36f390b26fa19d0fac255","user":{"login":"mberhault","id":5901480,"node_id":"MDQ6VXNlcjU5MDE0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5901480?v=4","gravatar_id":"","url":"https://api.github.com/users/mberhault","html_url":"https://github.com/mberhault","followers_url":"https://api.github.com/users/mberhault/followers","following_url":"https://api.github.com/users/mberhault/following{/other_user}","gists_url":"https://api.github.com/users/mberhault/gists{/gist_id}","starred_url":"https://api.github.com/users/mberhault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mberhault/subscriptions","organizations_url":"https://api.github.com/users/mberhault/orgs","repos_url":"https://api.github.com/users/mberhault/repos","events_url":"https://api.github.com/users/mberhault/events{/privacy}","received_events_url":"https://api.github.com/users/mberhault/received_events","type":"User","site_admin":false},"repo":{"id":95122675,"node_id":"MDEwOlJlcG9zaXRvcnk5NTEyMjY3NQ==","name":"cockroach","full_name":"mberhault/cockroach","owner":{"login":"mberhault","id":5901480,"node_id":"MDQ6VXNlcjU5MDE0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5901480?v=4","gravatar_id":"","url":"https://api.github.com/users/mberhault","html_url":"https://github.com/mberhault","followers_url":"https://api.github.com/users/mberhault/followers","following_url":"https://api.github.com/users/mberhault/following{/other_user}","gists_url":"https://api.github.com/users/mberhault/gists{/gist_id}","starred_url":"https://api.github.com/users/mberhault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mberhault/subscriptions","organizations_url":"https://api.github.com/users/mberhault/orgs","repos_url":"https://api.github.com/users/mberhault/repos","events_url":"https://api.github.com/users/mberhault/events{/privacy}","received_events_url":"https://api.github.com/users/mberhault/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mberhault/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":true,"url":"https://api.github.com/repos/mberhault/cockroach","forks_url":"https://api.github.com/repos/mberhault/cockroach/forks","keys_url":"https://api.github.com/repos/mberhault/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mberhault/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mberhault/cockroach/teams","hooks_url":"https://api.github.com/repos/mberhault/cockroach/hooks","issue_events_url":"https://api.github.com/repos/mberhault/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/mberhault/cockroach/events","assignees_url":"https://api.github.com/repos/mberhault/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/mberhault/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/mberhault/cockroach/tags","blobs_url":"https://api.github.com/repos/mberhault/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mberhault/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mberhault/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/mberhault/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mberhault/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/mberhault/cockroach/languages","stargazers_url":"https://api.github.com/repos/mberhault/cockroach/stargazers","contributors_url":"https://api.github.com/repos/mberhault/cockroach/contributors","subscribers_url":"https://api.github.com/repos/mberhault/cockroach/subscribers","subscription_url":"https://api.github.com/repos/mberhault/cockroach/subscription","commits_url":"https://api.github.com/repos/mberhault/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/mberhault/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/mberhault/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/mberhault/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/mberhault/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/mberhault/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mberhault/cockroach/merges","archive_url":"https://api.github.com/repos/mberhault/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mberhault/cockroach/downloads","issues_url":"https://api.github.com/repos/mberhault/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/mberhault/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/mberhault/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/mberhault/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mberhault/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/mberhault/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/mberhault/cockroach/deployments","created_at":"2017-06-22T14:13:03Z","updated_at":"2018-06-04T21:11:11Z","pushed_at":"2018-06-04T21:14:49Z","git_url":"git://github.com/mberhault/cockroach.git","ssh_url":"git@github.com:mberhault/cockroach.git","clone_url":"https://github.com/mberhault/cockroach.git","svn_url":"https://github.com/mberhault/cockroach","homepage":"https://www.cockroachlabs.com","size":535941,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"befc521851d637c84f13875b3fca4168a1cccdbc","user":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU2MzU4Nw==","name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-06-04T23:05:34Z","pushed_at":"2018-06-04T23:20:17Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":1012313,"stargazers_count":13536,"watchers_count":13536,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1402,"mirror_url":null,"archived":false,"open_issues_count":1755,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1402,"open_issues":1755,"watchers":13536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/26377"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/26377"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/26377"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/26377/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/26377/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/26377/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/6e9ad403b3cbab4ec1d36f390b26fa19d0fac255"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"craig[bot]","id":37807150,"node_id":"MDM6Qm90Mzc4MDcxNTA=","avatar_url":"https://avatars0.githubusercontent.com/in/10419?v=4","gravatar_id":"","url":"https://api.github.com/users/craig%5Bbot%5D","html_url":"https://github.com/apps/craig","followers_url":"https://api.github.com/users/craig%5Bbot%5D/followers","following_url":"https://api.github.com/users/craig%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/craig%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/craig%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craig%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/craig%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/craig%5Bbot%5D/repos","events_url":"https://api.github.com/users/craig%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/craig%5Bbot%5D/received_events","type":"Bot","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":282,"deletions":114,"changed_files":13}}
{"actor":{"display_login":"craig"}}