{"action":"created","issue":{"url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1737","repository_url":"https://api.github.com/repos/jonathanmccann/liferay-portal","labels_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1737/labels{/name}","comments_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1737/comments","events_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1737/events","html_url":"https://github.com/jonathanmccann/liferay-portal/pull/1737","id":391325279,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODc4NjQ5","number":1737,"title":"LPS-88284","user":{"login":"ChrisKian","id":10406971,"node_id":"MDQ6VXNlcjEwNDA2OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/10406971?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisKian","html_url":"https://github.com/ChrisKian","followers_url":"https://api.github.com/users/ChrisKian/followers","following_url":"https://api.github.com/users/ChrisKian/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKian/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKian/subscriptions","organizations_url":"https://api.github.com/users/ChrisKian/orgs","repos_url":"https://api.github.com/users/ChrisKian/repos","events_url":"https://api.github.com/users/ChrisKian/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-15T00:49:41Z","updated_at":"2018-12-17T15:50:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls/1737","html_url":"https://github.com/jonathanmccann/liferay-portal/pull/1737","diff_url":"https://github.com/jonathanmccann/liferay-portal/pull/1737.diff","patch_url":"https://github.com/jonathanmccann/liferay-portal/pull/1737.patch"},"body":"https://issues.liferay.com/browse/LPP-32406\r\nhttps://issues.liferay.com/browse/LPS-88284\r\n\r\nFrom @wanderlast:\r\n\r\n> In 7.1, we added the concept of \"display pages\" and \"content page templates\" in addition to our pre-existing page templates -- now known as \"widget page templates\". To properly deal with the import/export of these templates, new infrastructure was created under the name LayoutPageTemplateEntry (among others) to handle these. These are exported under the GroupPages portlet.\r\n> \r\n> Site templates can and should propagate page template content to a site created based on a site template. This functions properly when a combination of content page templates and/or display pages are present in the site template. However, no page template content is propagated when a widget page template is present. The underlying cause of this issue is that, when exported, the content is exported under the auspices of the GroupPages portlet. However, the portletID present in the corresponding LAR (if a WPT is present) is:\r\n> \r\n> portlet-id value \"com_liferay_portal_search_web_search_bar_portlet_SearchBarPortlet_INSTANCE_templateSearch\"\r\n> \r\n> This causes the import to be processed incorrectly and therefore for none of the templates to be properly imported into the database. This mislabled portletId originates in the LayoutPrototypeStagedModelDataHandler, which handles the export of widget page templates. During export, the portletdatacontext's portletId is changed during the running of StagedModelDataHandlerUtil.exportReferenceStagedModel() and is therefore propagated back incorrectly to PortletExportControllerImpl which uses the portletDataContext's portletID for the LAR file. The fix is therefore to save the original portletID and change it back to this value once processing of layout prototypes is done.\r\n> \r\n> Please let me know if you have any questions or concerns. Thanks!"},"comment":{"url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/comments/447892776","html_url":"https://github.com/jonathanmccann/liferay-portal/pull/1737#issuecomment-447892776","issue_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1737","id":447892776,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzg5Mjc3Ng==","user":{"login":"jonathanmccann","id":1919610,"node_id":"MDQ6VXNlcjE5MTk2MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1919610?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanmccann","html_url":"https://github.com/jonathanmccann","followers_url":"https://api.github.com/users/jonathanmccann/followers","following_url":"https://api.github.com/users/jonathanmccann/following{/other_user}","gists_url":"https://api.github.com/users/jonathanmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanmccann/subscriptions","organizations_url":"https://api.github.com/users/jonathanmccann/orgs","repos_url":"https://api.github.com/users/jonathanmccann/repos","events_url":"https://api.github.com/users/jonathanmccann/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanmccann/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T15:50:02Z","updated_at":"2018-12-17T15:50:02Z","author_association":"OWNER","body":"Reviewed and sent to Eudaldo for further review: https://github.com/ealonso/liferay-portal/pull/2027"}}
{"actor":{"display_login":"jonathanmccann"}}