{"action":"created","issue":{"url":"https://api.github.com/repos/felipeespic/merlin/issues/1","repository_url":"https://api.github.com/repos/felipeespic/merlin","labels_url":"https://api.github.com/repos/felipeespic/merlin/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/felipeespic/merlin/issues/1/comments","events_url":"https://api.github.com/repos/felipeespic/merlin/issues/1/events","html_url":"https://github.com/felipeespic/merlin/issues/1","id":274134099,"number":1,"title":"Several errors raised when running ./misc/scripts/vocoder/magphase/extract_features_for_merlin.py","user":{"login":"felipeespic","id":16511990,"avatar_url":"https://avatars2.githubusercontent.com/u/16511990?v=4","gravatar_id":"","url":"https://api.github.com/users/felipeespic","html_url":"https://github.com/felipeespic","followers_url":"https://api.github.com/users/felipeespic/followers","following_url":"https://api.github.com/users/felipeespic/following{/other_user}","gists_url":"https://api.github.com/users/felipeespic/gists{/gist_id}","starred_url":"https://api.github.com/users/felipeespic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipeespic/subscriptions","organizations_url":"https://api.github.com/users/felipeespic/orgs","repos_url":"https://api.github.com/users/felipeespic/repos","events_url":"https://api.github.com/users/felipeespic/events{/privacy}","received_events_url":"https://api.github.com/users/felipeespic/received_events","type":"User","site_admin":false},"labels":[{"id":726123861,"url":"https://api.github.com/repos/felipeespic/merlin/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2017-11-15T12:09:40Z","updated_at":"2018-02-07T08:39:25Z","closed_at":null,"author_association":"OWNER","body":"By @dreamk73: (about magphase_integration branch)\r\n\r\n> @felipeespic when running the script to extract magphase acoustic features with my 48000 Hz audio data, I get an error. Same with 16000.\r\non line 392 of tools/magphase/src/magphase.py\r\nit says: if (fs != 48000) or (fs != 16000)\r\nThe 'or' should be 'and'\r\nAnd then on line 1657 I get another error but now fs is a list of numbers instead of the single number it was before, so somewhere fs is assigned something else.\r\n\r\n-------------------------------------------------------------------\r\n> tools/magphase/src/magphase.py line 155\r\nm_sp, m_ph, v_shift, m_frms, m_fft = analysis_with_del_comp_from_pm(v_in_sig, v_pm_smpls, nFFT, win_func=win_func, nwin_per_pitch_period=nwin_per_pitch_period)\r\nshould be\r\nm_sp, m_ph, v_shift, m_frms, m_fft = analysis_with_del_comp_from_pm(v_in_sig, fs, v_pm_smpls, nFFT, win_func=win_func, nwin_per_pitch_period=nwin_per_pitch_period)\r\nAlso, that function only returns two variables and this line has five?\r\n\r\n------------------------------------------------------------------------------------------------\r\n> Change the return statement of analysis_with_del_comp_from_pm to have those five variables. Next issue is that the function get_fft_params_from_complex_data is not defined in magphase.py. I did have it in the previous version that you made but c&p it and running analysis gave lots of the same errors:\r\nfft : m must be a integer of power of 2!"},"comment":{"url":"https://api.github.com/repos/felipeespic/merlin/issues/comments/363696006","html_url":"https://github.com/felipeespic/merlin/issues/1#issuecomment-363696006","issue_url":"https://api.github.com/repos/felipeespic/merlin/issues/1","id":363696006,"user":{"login":"m-toman","id":9433378,"avatar_url":"https://avatars2.githubusercontent.com/u/9433378?v=4","gravatar_id":"","url":"https://api.github.com/users/m-toman","html_url":"https://github.com/m-toman","followers_url":"https://api.github.com/users/m-toman/followers","following_url":"https://api.github.com/users/m-toman/following{/other_user}","gists_url":"https://api.github.com/users/m-toman/gists{/gist_id}","starred_url":"https://api.github.com/users/m-toman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-toman/subscriptions","organizations_url":"https://api.github.com/users/m-toman/orgs","repos_url":"https://api.github.com/users/m-toman/repos","events_url":"https://api.github.com/users/m-toman/events{/privacy}","received_events_url":"https://api.github.com/users/m-toman/received_events","type":"User","site_admin":false},"created_at":"2018-02-07T08:39:25Z","updated_at":"2018-02-07T08:39:25Z","author_association":"NONE","body":"@felipeespic \r\nCompletely understand, unfortunately I didn't find the time for further testing either, but I'll certainly try the whole process again once you pushed the new version.\r\n\r\nRegarding the recordings: they have been made with consumer hardware at home, so they're not studio quality, no professional equipment and no voice talent... Unfortunately I can't remember if this was a version dereverbed and denoised with postfish."}}
{"actor":{"display_login":"m-toman"}}