{"action":"created","issue":{"url":"https://api.github.com/repos/snapcore/snapcraft/issues/2332","repository_url":"https://api.github.com/repos/snapcore/snapcraft","labels_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2332/labels{/name}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2332/comments","events_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2332/events","html_url":"https://github.com/snapcore/snapcraft/pull/2332","id":368376070,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTY5MzU4","number":2332,"title":"waf plugin: support for bases","user":{"login":"sergiusens","id":1146853,"node_id":"MDQ6VXNlcjExNDY4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146853?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-09T20:09:25Z","updated_at":"2018-10-09T22:11:24Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2332","html_url":"https://github.com/snapcore/snapcraft/pull/2332","diff_url":"https://github.com/snapcore/snapcraft/pull/2332.diff","patch_url":"https://github.com/snapcore/snapcraft/pull/2332.patch"},"body":"LP: #1794803\r\n\r\nSigned-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>\r\n\r\n- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?\r\n- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?\r\n- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?\r\n- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?\r\n- [ ] Have you successfully run `./runtests.sh static`?\r\n- [ ] Have you successfully run `./runtests.sh tests/unit`?\r\n\r\n-----\r\n"},"comment":{"url":"https://api.github.com/repos/snapcore/snapcraft/issues/comments/428370910","html_url":"https://github.com/snapcore/snapcraft/pull/2332#issuecomment-428370910","issue_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2332","id":428370910,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODM3MDkxMA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T22:11:24Z","updated_at":"2018-10-09T22:11:24Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/snapcore/snapcraft/pull/2332?src=pr&el=h1) Report\n> :exclamation: No coverage uploaded for pull request base (`master@f83720a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/snapcore/snapcraft/pull/2332/graphs/tree.svg?width=650&token=2FIE925NOQ&height=150&src=pr)](https://codecov.io/gh/snapcore/snapcraft/pull/2332?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##             master    #2332   +/-   ##\n=========================================\n  Coverage          ?   90.18%           \n=========================================\n  Files             ?      208           \n  Lines             ?    13318           \n  Branches          ?     1989           \n=========================================\n  Hits              ?    12011           \n  Misses            ?      901           \n  Partials          ?      406\n```\n\n\n| [Impacted Files](https://codecov.io/gh/snapcore/snapcraft/pull/2332?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [snapcraft/plugins/waf.py](https://codecov.io/gh/snapcore/snapcraft/pull/2332/diff?src=pr&el=tree#diff-c25hcGNyYWZ0L3BsdWdpbnMvd2FmLnB5) | `96.77% <100%> (ø)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/snapcore/snapcraft/pull/2332?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/snapcore/snapcraft/pull/2332?src=pr&el=footer). Last update [f83720a...7601ff0](https://codecov.io/gh/snapcore/snapcraft/pull/2332?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}