{"action":"created","issue":{"url":"https://api.github.com/repos/thysultan/stylis.js/issues/87","repository_url":"https://api.github.com/repos/thysultan/stylis.js","labels_url":"https://api.github.com/repos/thysultan/stylis.js/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/thysultan/stylis.js/issues/87/comments","events_url":"https://api.github.com/repos/thysultan/stylis.js/issues/87/events","html_url":"https://github.com/thysultan/stylis.js/pull/87","id":286714630,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYxNjA2NTUw","number":87,"title":"Ship multiple module formats","user":{"login":"Andarist","id":9800850,"node_id":"MDQ6VXNlcjk4MDA4NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9800850?v=4","gravatar_id":"","url":"https://api.github.com/users/Andarist","html_url":"https://github.com/Andarist","followers_url":"https://api.github.com/users/Andarist/followers","following_url":"https://api.github.com/users/Andarist/following{/other_user}","gists_url":"https://api.github.com/users/Andarist/gists{/gist_id}","starred_url":"https://api.github.com/users/Andarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andarist/subscriptions","organizations_url":"https://api.github.com/users/Andarist/orgs","repos_url":"https://api.github.com/users/Andarist/repos","events_url":"https://api.github.com/users/Andarist/events{/privacy}","received_events_url":"https://api.github.com/users/Andarist/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-01-08T11:18:55Z","updated_at":"2018-06-09T02:21:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/thysultan/stylis.js/pulls/87","html_url":"https://github.com/thysultan/stylis.js/pull/87","diff_url":"https://github.com/thysultan/stylis.js/pull/87.diff","patch_url":"https://github.com/thysultan/stylis.js/pull/87.patch"},"body":"fixes #81\r\n\r\nJust a proof of concept at the moment. Please take a look at the output, seems ok for me, but I still need to test it thoroughly.\r\n\r\nHaving a build pipeline we could explore later including further compilation optimizations, such as constants inlining mentioned in #79, or even shipping to npm google closure compiled files (with source maps)."},"comment":{"url":"https://api.github.com/repos/thysultan/stylis.js/issues/comments/395932838","html_url":"https://github.com/thysultan/stylis.js/pull/87#issuecomment-395932838","issue_url":"https://api.github.com/repos/thysultan/stylis.js/issues/87","id":395932838,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTkzMjgzOA==","user":{"login":"thysultan","id":810601,"node_id":"MDQ6VXNlcjgxMDYwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/810601?v=4","gravatar_id":"","url":"https://api.github.com/users/thysultan","html_url":"https://github.com/thysultan","followers_url":"https://api.github.com/users/thysultan/followers","following_url":"https://api.github.com/users/thysultan/following{/other_user}","gists_url":"https://api.github.com/users/thysultan/gists{/gist_id}","starred_url":"https://api.github.com/users/thysultan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thysultan/subscriptions","organizations_url":"https://api.github.com/users/thysultan/orgs","repos_url":"https://api.github.com/users/thysultan/repos","events_url":"https://api.github.com/users/thysultan/events{/privacy}","received_events_url":"https://api.github.com/users/thysultan/received_events","type":"User","site_admin":false},"created_at":"2018-06-09T02:21:26Z","updated_at":"2018-06-09T02:21:26Z","author_association":"OWNER","body":"## scope hoisting\r\n\r\nI can see the immediate value preposition of this point. \r\n\r\n## tree-shaking\r\n\r\nWhere you able to test if the this point does indeed remove unused imports with this. I have a feeling the current factory closure approach would be a hard blocker for tree shaking at that level.\r\n\r\nThe next major release could improve on this and other API decisions.  The question to answer then is wether there is an API pattern pattern we could use that allows you to tree-shake the functions `isolate`, `proxy`, `minify`, `use`, `set` and a good chunk of the prefixing going on in `property` if you make use non of them publicly. \r\n\r\n>primary reason for libraries like emotion to just copy its source code\r\n\r\nIn an effort to crunch bytes i think emotion also runs the code through a JavaScript parser and removes some parts manually."}}
{"actor":{"display_login":"thysultan"}}