{"action":"opened","number":773,"pull_request":{"url":"https://api.github.com/repos/Awful/Awful.app/pulls/773","id":197580368,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTgwMzY4","html_url":"https://github.com/Awful/Awful.app/pull/773","diff_url":"https://github.com/Awful/Awful.app/pull/773.diff","patch_url":"https://github.com/Awful/Awful.app/pull/773.patch","issue_url":"https://api.github.com/repos/Awful/Awful.app/issues/773","number":773,"state":"open","locked":false,"title":"move html parsing off of the main thread","user":{"login":"elindsey","id":47579,"node_id":"MDQ6VXNlcjQ3NTc5","avatar_url":"https://avatars1.githubusercontent.com/u/47579?v=4","gravatar_id":"","url":"https://api.github.com/users/elindsey","html_url":"https://github.com/elindsey","followers_url":"https://api.github.com/users/elindsey/followers","following_url":"https://api.github.com/users/elindsey/following{/other_user}","gists_url":"https://api.github.com/users/elindsey/gists{/gist_id}","starred_url":"https://api.github.com/users/elindsey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elindsey/subscriptions","organizations_url":"https://api.github.com/users/elindsey/orgs","repos_url":"https://api.github.com/users/elindsey/repos","events_url":"https://api.github.com/users/elindsey/events{/privacy}","received_events_url":"https://api.github.com/users/elindsey/received_events","type":"User","site_admin":false},"body":"Noticed some of the html parsing was still running on the main thread, occasionally taking 400+ milliseconds.\r\n\r\nThis seemed like the easiest way to move it off - but we could also default all the map/thens to running on a background queue via Promiskit's conf, or rewrite scrape to scrape(on:as: ) and update callsites.\r\n\r\nAny particular preference, or something I'm missing about why this can't/shouldn't be moved?","created_at":"2018-06-26T23:39:47Z","updated_at":"2018-06-26T23:39:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Awful/Awful.app/pulls/773/commits","review_comments_url":"https://api.github.com/repos/Awful/Awful.app/pulls/773/comments","review_comment_url":"https://api.github.com/repos/Awful/Awful.app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Awful/Awful.app/issues/773/comments","statuses_url":"https://api.github.com/repos/Awful/Awful.app/statuses/5a9290531034024f910c4c61f71a1fe6755c675d","head":{"label":"Awful:perf","ref":"perf","sha":"5a9290531034024f910c4c61f71a1fe6755c675d","user":{"login":"Awful","id":2438983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mzg5ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/2438983?v=4","gravatar_id":"","url":"https://api.github.com/users/Awful","html_url":"https://github.com/Awful","followers_url":"https://api.github.com/users/Awful/followers","following_url":"https://api.github.com/users/Awful/following{/other_user}","gists_url":"https://api.github.com/users/Awful/gists{/gist_id}","starred_url":"https://api.github.com/users/Awful/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Awful/subscriptions","organizations_url":"https://api.github.com/users/Awful/orgs","repos_url":"https://api.github.com/users/Awful/repos","events_url":"https://api.github.com/users/Awful/events{/privacy}","received_events_url":"https://api.github.com/users/Awful/received_events","type":"Organization","site_admin":false},"repo":{"id":1852094,"node_id":"MDEwOlJlcG9zaXRvcnkxODUyMDk0","name":"Awful.app","full_name":"Awful/Awful.app","owner":{"login":"Awful","id":2438983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mzg5ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/2438983?v=4","gravatar_id":"","url":"https://api.github.com/users/Awful","html_url":"https://github.com/Awful","followers_url":"https://api.github.com/users/Awful/followers","following_url":"https://api.github.com/users/Awful/following{/other_user}","gists_url":"https://api.github.com/users/Awful/gists{/gist_id}","starred_url":"https://api.github.com/users/Awful/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Awful/subscriptions","organizations_url":"https://api.github.com/users/Awful/orgs","repos_url":"https://api.github.com/users/Awful/repos","events_url":"https://api.github.com/users/Awful/events{/privacy}","received_events_url":"https://api.github.com/users/Awful/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Awful/Awful.app","description":"Something Awful Forums browser for iOS","fork":false,"url":"https://api.github.com/repos/Awful/Awful.app","forks_url":"https://api.github.com/repos/Awful/Awful.app/forks","keys_url":"https://api.github.com/repos/Awful/Awful.app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Awful/Awful.app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Awful/Awful.app/teams","hooks_url":"https://api.github.com/repos/Awful/Awful.app/hooks","issue_events_url":"https://api.github.com/repos/Awful/Awful.app/issues/events{/number}","events_url":"https://api.github.com/repos/Awful/Awful.app/events","assignees_url":"https://api.github.com/repos/Awful/Awful.app/assignees{/user}","branches_url":"https://api.github.com/repos/Awful/Awful.app/branches{/branch}","tags_url":"https://api.github.com/repos/Awful/Awful.app/tags","blobs_url":"https://api.github.com/repos/Awful/Awful.app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Awful/Awful.app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Awful/Awful.app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Awful/Awful.app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Awful/Awful.app/statuses/{sha}","languages_url":"https://api.github.com/repos/Awful/Awful.app/languages","stargazers_url":"https://api.github.com/repos/Awful/Awful.app/stargazers","contributors_url":"https://api.github.com/repos/Awful/Awful.app/contributors","subscribers_url":"https://api.github.com/repos/Awful/Awful.app/subscribers","subscription_url":"https://api.github.com/repos/Awful/Awful.app/subscription","commits_url":"https://api.github.com/repos/Awful/Awful.app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Awful/Awful.app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Awful/Awful.app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Awful/Awful.app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Awful/Awful.app/contents/{+path}","compare_url":"https://api.github.com/repos/Awful/Awful.app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Awful/Awful.app/merges","archive_url":"https://api.github.com/repos/Awful/Awful.app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Awful/Awful.app/downloads","issues_url":"https://api.github.com/repos/Awful/Awful.app/issues{/number}","pulls_url":"https://api.github.com/repos/Awful/Awful.app/pulls{/number}","milestones_url":"https://api.github.com/repos/Awful/Awful.app/milestones{/number}","notifications_url":"https://api.github.com/repos/Awful/Awful.app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Awful/Awful.app/labels{/name}","releases_url":"https://api.github.com/repos/Awful/Awful.app/releases{/id}","deployments_url":"https://api.github.com/repos/Awful/Awful.app/deployments","created_at":"2011-06-05T22:32:10Z","updated_at":"2018-06-26T23:35:20Z","pushed_at":"2018-06-26T23:37:08Z","git_url":"git://github.com/Awful/Awful.app.git","ssh_url":"git@github.com:Awful/Awful.app.git","clone_url":"https://github.com/Awful/Awful.app.git","svn_url":"https://github.com/Awful/Awful.app","homepage":"http://forums.somethingawful.com/showthread.php?threadid=3510131","size":152539,"stargazers_count":112,"watchers_count":112,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":440,"license":null,"forks":45,"open_issues":440,"watchers":112,"default_branch":"master"}},"base":{"label":"Awful:master","ref":"master","sha":"d89cd337d10fa261cdaa6086e6ab2ebb399b45b9","user":{"login":"Awful","id":2438983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mzg5ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/2438983?v=4","gravatar_id":"","url":"https://api.github.com/users/Awful","html_url":"https://github.com/Awful","followers_url":"https://api.github.com/users/Awful/followers","following_url":"https://api.github.com/users/Awful/following{/other_user}","gists_url":"https://api.github.com/users/Awful/gists{/gist_id}","starred_url":"https://api.github.com/users/Awful/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Awful/subscriptions","organizations_url":"https://api.github.com/users/Awful/orgs","repos_url":"https://api.github.com/users/Awful/repos","events_url":"https://api.github.com/users/Awful/events{/privacy}","received_events_url":"https://api.github.com/users/Awful/received_events","type":"Organization","site_admin":false},"repo":{"id":1852094,"node_id":"MDEwOlJlcG9zaXRvcnkxODUyMDk0","name":"Awful.app","full_name":"Awful/Awful.app","owner":{"login":"Awful","id":2438983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mzg5ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/2438983?v=4","gravatar_id":"","url":"https://api.github.com/users/Awful","html_url":"https://github.com/Awful","followers_url":"https://api.github.com/users/Awful/followers","following_url":"https://api.github.com/users/Awful/following{/other_user}","gists_url":"https://api.github.com/users/Awful/gists{/gist_id}","starred_url":"https://api.github.com/users/Awful/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Awful/subscriptions","organizations_url":"https://api.github.com/users/Awful/orgs","repos_url":"https://api.github.com/users/Awful/repos","events_url":"https://api.github.com/users/Awful/events{/privacy}","received_events_url":"https://api.github.com/users/Awful/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Awful/Awful.app","description":"Something Awful Forums browser for iOS","fork":false,"url":"https://api.github.com/repos/Awful/Awful.app","forks_url":"https://api.github.com/repos/Awful/Awful.app/forks","keys_url":"https://api.github.com/repos/Awful/Awful.app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Awful/Awful.app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Awful/Awful.app/teams","hooks_url":"https://api.github.com/repos/Awful/Awful.app/hooks","issue_events_url":"https://api.github.com/repos/Awful/Awful.app/issues/events{/number}","events_url":"https://api.github.com/repos/Awful/Awful.app/events","assignees_url":"https://api.github.com/repos/Awful/Awful.app/assignees{/user}","branches_url":"https://api.github.com/repos/Awful/Awful.app/branches{/branch}","tags_url":"https://api.github.com/repos/Awful/Awful.app/tags","blobs_url":"https://api.github.com/repos/Awful/Awful.app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Awful/Awful.app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Awful/Awful.app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Awful/Awful.app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Awful/Awful.app/statuses/{sha}","languages_url":"https://api.github.com/repos/Awful/Awful.app/languages","stargazers_url":"https://api.github.com/repos/Awful/Awful.app/stargazers","contributors_url":"https://api.github.com/repos/Awful/Awful.app/contributors","subscribers_url":"https://api.github.com/repos/Awful/Awful.app/subscribers","subscription_url":"https://api.github.com/repos/Awful/Awful.app/subscription","commits_url":"https://api.github.com/repos/Awful/Awful.app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Awful/Awful.app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Awful/Awful.app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Awful/Awful.app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Awful/Awful.app/contents/{+path}","compare_url":"https://api.github.com/repos/Awful/Awful.app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Awful/Awful.app/merges","archive_url":"https://api.github.com/repos/Awful/Awful.app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Awful/Awful.app/downloads","issues_url":"https://api.github.com/repos/Awful/Awful.app/issues{/number}","pulls_url":"https://api.github.com/repos/Awful/Awful.app/pulls{/number}","milestones_url":"https://api.github.com/repos/Awful/Awful.app/milestones{/number}","notifications_url":"https://api.github.com/repos/Awful/Awful.app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Awful/Awful.app/labels{/name}","releases_url":"https://api.github.com/repos/Awful/Awful.app/releases{/id}","deployments_url":"https://api.github.com/repos/Awful/Awful.app/deployments","created_at":"2011-06-05T22:32:10Z","updated_at":"2018-06-26T23:35:20Z","pushed_at":"2018-06-26T23:37:08Z","git_url":"git://github.com/Awful/Awful.app.git","ssh_url":"git@github.com:Awful/Awful.app.git","clone_url":"https://github.com/Awful/Awful.app.git","svn_url":"https://github.com/Awful/Awful.app","homepage":"http://forums.somethingawful.com/showthread.php?threadid=3510131","size":152539,"stargazers_count":112,"watchers_count":112,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":440,"license":null,"forks":45,"open_issues":440,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Awful/Awful.app/pulls/773"},"html":{"href":"https://github.com/Awful/Awful.app/pull/773"},"issue":{"href":"https://api.github.com/repos/Awful/Awful.app/issues/773"},"comments":{"href":"https://api.github.com/repos/Awful/Awful.app/issues/773/comments"},"review_comments":{"href":"https://api.github.com/repos/Awful/Awful.app/pulls/773/comments"},"review_comment":{"href":"https://api.github.com/repos/Awful/Awful.app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Awful/Awful.app/pulls/773/commits"},"statuses":{"href":"https://api.github.com/repos/Awful/Awful.app/statuses/5a9290531034024f910c4c61f71a1fe6755c675d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"elindsey"}}