{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/650","repository_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api","labels_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/650/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/650/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/650/events","html_url":"https://github.com/kubernetes-sigs/cluster-api/pull/650","id":393151516,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjU0Mjk3","number":650,"title":"Add unit test for machine controller reconcile","user":{"login":"enxebre","id":1230698,"node_id":"MDQ6VXNlcjEyMzA2OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1230698?v=4","gravatar_id":"","url":"https://api.github.com/users/enxebre","html_url":"https://github.com/enxebre","followers_url":"https://api.github.com/users/enxebre/followers","following_url":"https://api.github.com/users/enxebre/following{/other_user}","gists_url":"https://api.github.com/users/enxebre/gists{/gist_id}","starred_url":"https://api.github.com/users/enxebre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enxebre/subscriptions","organizations_url":"https://api.github.com/users/enxebre/orgs","repos_url":"https://api.github.com/users/enxebre/repos","events_url":"https://api.github.com/users/enxebre/events{/privacy}","received_events_url":"https://api.github.com/users/enxebre/received_events","type":"User","site_admin":false},"labels":[{"id":875323571,"node_id":"MDU6TGFiZWw4NzUzMjM1NzE=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":904893140,"node_id":"MDU6TGFiZWw5MDQ4OTMxNDA=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":904030780,"node_id":"MDU6TGFiZWw5MDQwMzA3ODA=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-20T17:55:32Z","updated_at":"2018-12-20T17:55:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/650","html_url":"https://github.com/kubernetes-sigs/cluster-api/pull/650","diff_url":"https://github.com/kubernetes-sigs/cluster-api/pull/650.diff","patch_url":"https://github.com/kubernetes-sigs/cluster-api/pull/650.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n5. If this PR changes image versions, please title this PR \"Bump <image name> from x.x.x to y.y.y.\"\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nAdd uni test for machine controller reconcile\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n_Please confirm that if this PR changes any image versions, then that's the sole change this PR makes._\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/comments/449083039","html_url":"https://github.com/kubernetes-sigs/cluster-api/pull/650#issuecomment-449083039","issue_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/650","id":449083039,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTA4MzAzOQ==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T17:55:50Z","updated_at":"2018-12-20T17:55:50Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes-sigs/cluster-api/pull/650#\" title=\"Author self-approved\">enxebre</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **timothysc**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @timothysc` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/kubernetes-sigs/cluster-api/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"timothysc\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}