{"action":"created","issue":{"url":"https://api.github.com/repos/BenjaminVanRyseghem/numbro/issues/376","repository_url":"https://api.github.com/repos/BenjaminVanRyseghem/numbro","labels_url":"https://api.github.com/repos/BenjaminVanRyseghem/numbro/issues/376/labels{/name}","comments_url":"https://api.github.com/repos/BenjaminVanRyseghem/numbro/issues/376/comments","events_url":"https://api.github.com/repos/BenjaminVanRyseghem/numbro/issues/376/events","html_url":"https://github.com/BenjaminVanRyseghem/numbro/pull/376","id":358620306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzEyMTE5","number":376,"title":" Fix handling of invalid inputs ","user":{"login":"lukejknight","id":6252715,"node_id":"MDQ6VXNlcjYyNTI3MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6252715?v=4","gravatar_id":"","url":"https://api.github.com/users/lukejknight","html_url":"https://github.com/lukejknight","followers_url":"https://api.github.com/users/lukejknight/followers","following_url":"https://api.github.com/users/lukejknight/following{/other_user}","gists_url":"https://api.github.com/users/lukejknight/gists{/gist_id}","starred_url":"https://api.github.com/users/lukejknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukejknight/subscriptions","organizations_url":"https://api.github.com/users/lukejknight/orgs","repos_url":"https://api.github.com/users/lukejknight/repos","events_url":"https://api.github.com/users/lukejknight/events{/privacy}","received_events_url":"https://api.github.com/users/lukejknight/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-10T13:22:10Z","updated_at":"2018-09-10T13:31:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/BenjaminVanRyseghem/numbro/pulls/376","html_url":"https://github.com/BenjaminVanRyseghem/numbro/pull/376","diff_url":"https://github.com/BenjaminVanRyseghem/numbro/pull/376.diff","patch_url":"https://github.com/BenjaminVanRyseghem/numbro/pull/376.patch"},"body":"Invalid inputs now return NaN instead of undefined.\r\n\r\nFixes #144\r\nFixes #278\r\n"},"comment":{"url":"https://api.github.com/repos/BenjaminVanRyseghem/numbro/issues/comments/419912847","html_url":"https://github.com/BenjaminVanRyseghem/numbro/pull/376#issuecomment-419912847","issue_url":"https://api.github.com/repos/BenjaminVanRyseghem/numbro/issues/376","id":419912847,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTkxMjg0Nw==","user":{"login":"lukejknight","id":6252715,"node_id":"MDQ6VXNlcjYyNTI3MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6252715?v=4","gravatar_id":"","url":"https://api.github.com/users/lukejknight","html_url":"https://github.com/lukejknight","followers_url":"https://api.github.com/users/lukejknight/followers","following_url":"https://api.github.com/users/lukejknight/following{/other_user}","gists_url":"https://api.github.com/users/lukejknight/gists{/gist_id}","starred_url":"https://api.github.com/users/lukejknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukejknight/subscriptions","organizations_url":"https://api.github.com/users/lukejknight/orgs","repos_url":"https://api.github.com/users/lukejknight/repos","events_url":"https://api.github.com/users/lukejknight/events{/privacy}","received_events_url":"https://api.github.com/users/lukejknight/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T13:31:45Z","updated_at":"2018-09-10T13:31:45Z","author_association":"NONE","body":"@BenjaminVanRyseghem \r\n\r\nI don't think this should impact clients too badly, since boolean logic remains consistent in clients that might depend on this, i.e.\r\n\r\n```\r\n> NaN ? 'true' : 'false'\r\n'false'\r\n> undefined ? 'true' : 'false'\r\n'false'\r\n```"}}
{"actor":{"display_login":"lukejknight"}}