{"action":"created","issue":{"url":"https://api.github.com/repos/esp8266/Arduino/issues/5137","repository_url":"https://api.github.com/repos/esp8266/Arduino","labels_url":"https://api.github.com/repos/esp8266/Arduino/issues/5137/labels{/name}","comments_url":"https://api.github.com/repos/esp8266/Arduino/issues/5137/comments","events_url":"https://api.github.com/repos/esp8266/Arduino/issues/5137/events","html_url":"https://github.com/esp8266/Arduino/issues/5137","id":360559415,"node_id":"MDU6SXNzdWUzNjA1NTk0MTU=","number":5137,"title":"Undocumented negative return values from HTTPClient::get()","user":{"login":"teo1978","id":542107,"node_id":"MDQ6VXNlcjU0MjEwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/542107?v=4","gravatar_id":"","url":"https://api.github.com/users/teo1978","html_url":"https://github.com/teo1978","followers_url":"https://api.github.com/users/teo1978/followers","following_url":"https://api.github.com/users/teo1978/following{/other_user}","gists_url":"https://api.github.com/users/teo1978/gists{/gist_id}","starred_url":"https://api.github.com/users/teo1978/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teo1978/subscriptions","organizations_url":"https://api.github.com/users/teo1978/orgs","repos_url":"https://api.github.com/users/teo1978/repos","events_url":"https://api.github.com/users/teo1978/events{/privacy}","received_events_url":"https://api.github.com/users/teo1978/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2018-09-15T17:28:38Z","updated_at":"2018-12-15T18:03:02Z","closed_at":"2018-09-18T02:07:21Z","author_association":"CONTRIBUTOR","body":"All I can find in the documentation about `HTTPClient::get()` return value is that it returns \"the http code\".\r\n\r\nSometimes it returns -1. I guess that happens when something fails while sending the request, or parsing the response (if you even got one), so there's no http code to be returned.\r\n\r\nHowever\r\n1. that should be documented\r\n2. There needs to be a way to get information about what the error actually was. Did the client fail to connect to the server? Did it fail to send the request? Did it get an invalid response? What else?\r\nIf there already exists a way to get that kind of information, then that needs to be documented too."},"comment":{"url":"https://api.github.com/repos/esp8266/Arduino/issues/comments/447586654","html_url":"https://github.com/esp8266/Arduino/issues/5137#issuecomment-447586654","issue_url":"https://api.github.com/repos/esp8266/Arduino/issues/5137","id":447586654,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzU4NjY1NA==","user":{"login":"teo1978","id":542107,"node_id":"MDQ6VXNlcjU0MjEwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/542107?v=4","gravatar_id":"","url":"https://api.github.com/users/teo1978","html_url":"https://github.com/teo1978","followers_url":"https://api.github.com/users/teo1978/followers","following_url":"https://api.github.com/users/teo1978/following{/other_user}","gists_url":"https://api.github.com/users/teo1978/gists{/gist_id}","starred_url":"https://api.github.com/users/teo1978/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teo1978/subscriptions","organizations_url":"https://api.github.com/users/teo1978/orgs","repos_url":"https://api.github.com/users/teo1978/repos","events_url":"https://api.github.com/users/teo1978/events{/privacy}","received_events_url":"https://api.github.com/users/teo1978/received_events","type":"User","site_admin":false},"created_at":"2018-12-15T18:03:02Z","updated_at":"2018-12-15T18:03:02Z","author_association":"CONTRIBUTOR","body":"> Then @d-a-v asked questions that weren't answered.\r\n> Please provide the requested info.\r\n\r\nI don't have the answers. It seems to me that enough information has been collected to state that there is indeed an issue to be fixed, so I thing the correct status is open, whether or not I can answer to those questions.\r\n\r\nSome of the question don't seem directed to me as the issue poster, but rather open questions as in \"what should we do with xxx\". The mere existence of such questions seems to me a reason for the issue to be open. \r\n\r\nE.g.\r\n\r\n>> What code should HTTPC return in that case ?\r\n\r\nI don't know or have a suggestion for that one.\r\n\r\n"}}
{"actor":{"display_login":"teo1978"}}