{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/49447","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/49447/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/49447/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/49447/events","html_url":"https://github.com/rust-lang/rust/pull/49447","id":309300701,"number":49447,"title":"Remove adjacent all-const match arm hack.","user":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars0.githubusercontent.com/u/173127?v=4","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"labels":[{"id":583426710,"url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"state":"open","locked":false,"assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-03-28T10:05:13Z","updated_at":"2018-03-29T12:36:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/49447","html_url":"https://github.com/rust-lang/rust/pull/49447","diff_url":"https://github.com/rust-lang/rust/pull/49447.diff","patch_url":"https://github.com/rust-lang/rust/pull/49447.patch"},"body":"An old fix for moves-in-guards had a hack for adjacent all-const match arms.\r\n\r\nThe hack was explained in a comment, which you can see here:\r\nhttps://github.com/rust-lang/rust/pull/22580/files#diff-402a0fa4b3c6755c5650027c6d4cf1efR497\r\n\r\nBut hack was incomplete (and thus unsound), as pointed out here:\r\nhttps://github.com/rust-lang/rust/issues/47295#issuecomment-357108458\r\n\r\nPlus, it is likely to be at least tricky to reimplement this hack in\r\nthe new NLL borrowck.\r\n\r\nSo rather than try to preserve the hack, we want to try to just remove\r\nit outright. (At least to see the results of a crater run.)\r\n\r\n[breaking-change]\r\n\r\nThis is a breaking-change, but our hope is that no one is actually\r\nrelying on such an extreme special case. (We hypothesize the hack was\r\noriginally added to accommodate a file in our own test suite, not code\r\nin the wild.)"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/377221437","html_url":"https://github.com/rust-lang/rust/pull/49447#issuecomment-377221437","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/49447","id":377221437,"user":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars0.githubusercontent.com/u/173127?v=4","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T12:36:11Z","updated_at":"2018-03-29T12:36:11Z","author_association":"MEMBER","body":"@Mark-Simulacrum  I re-read your message and realized that you gave me an ETA that was much sooner than I had expected, and asked me if that was okay.\r\n\r\nSo: Yes, please do a crater run, it can only help. :)"}}
{"actor":{"display_login":"pnkfelix"}}