{"action":"created","issue":{"url":"https://api.github.com/repos/iceman1001/proxmark3/issues/239","repository_url":"https://api.github.com/repos/iceman1001/proxmark3","labels_url":"https://api.github.com/repos/iceman1001/proxmark3/issues/239/labels{/name}","comments_url":"https://api.github.com/repos/iceman1001/proxmark3/issues/239/comments","events_url":"https://api.github.com/repos/iceman1001/proxmark3/issues/239/events","html_url":"https://github.com/iceman1001/proxmark3/issues/239","id":356212062,"node_id":"MDU6SXNzdWUzNTYyMTIwNjI=","number":239,"title":"Fixed problem samyrun, but is it a good fix?","user":{"login":"DidierStevens","id":6815601,"node_id":"MDQ6VXNlcjY4MTU2MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6815601?v=4","gravatar_id":"","url":"https://api.github.com/users/DidierStevens","html_url":"https://github.com/DidierStevens","followers_url":"https://api.github.com/users/DidierStevens/followers","following_url":"https://api.github.com/users/DidierStevens/following{/other_user}","gists_url":"https://api.github.com/users/DidierStevens/gists{/gist_id}","starred_url":"https://api.github.com/users/DidierStevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DidierStevens/subscriptions","organizations_url":"https://api.github.com/users/DidierStevens/orgs","repos_url":"https://api.github.com/users/DidierStevens/repos","events_url":"https://api.github.com/users/DidierStevens/events{/privacy}","received_events_url":"https://api.github.com/users/DidierStevens/received_events","type":"User","site_admin":false},"labels":[{"id":1046976389,"node_id":"MDU6TGFiZWwxMDQ2OTc2Mzg5","url":"https://api.github.com/repos/iceman1001/proxmark3/labels/See%20RDV40%20repo","name":"See RDV40 repo","color":"a0f49a","default":false},{"id":1046975504,"node_id":"MDU6TGFiZWwxMDQ2OTc1NTA0","url":"https://api.github.com/repos/iceman1001/proxmark3/labels/bugfix","name":"bugfix","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-09-01T15:44:18Z","updated_at":"2018-09-16T13:30:43Z","closed_at":null,"author_association":"NONE","body":"I could not get samyrun on my new RDV4 to read HID cards.\r\n\r\nI Debugged it: the card is never read because signalprop.isnoise is always TRUE.\r\n\r\nMy fix: in common/lfdemod.c, line 1892, replace\r\n    if (signalprop.isnoise) return -2;\r\nwith\r\n    if (justNoise(dest, *size)) return -2;\r\n\r\nNow I can read HID cards in standalone mode.\r\n\r\nBut is this a good fix? Because I compared with the Proxmark repository, and this function (HIDdemodFSK) has changed significantly.\r\nIs it better to copy that new function?\r\n"},"comment":{"url":"https://api.github.com/repos/iceman1001/proxmark3/issues/comments/421765841","html_url":"https://github.com/iceman1001/proxmark3/issues/239#issuecomment-421765841","issue_url":"https://api.github.com/repos/iceman1001/proxmark3/issues/239","id":421765841,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTc2NTg0MQ==","user":{"login":"iceman1001","id":8577004,"node_id":"MDQ6VXNlcjg1NzcwMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8577004?v=4","gravatar_id":"","url":"https://api.github.com/users/iceman1001","html_url":"https://github.com/iceman1001","followers_url":"https://api.github.com/users/iceman1001/followers","following_url":"https://api.github.com/users/iceman1001/following{/other_user}","gists_url":"https://api.github.com/users/iceman1001/gists{/gist_id}","starred_url":"https://api.github.com/users/iceman1001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceman1001/subscriptions","organizations_url":"https://api.github.com/users/iceman1001/orgs","repos_url":"https://api.github.com/users/iceman1001/repos","events_url":"https://api.github.com/users/iceman1001/events{/privacy}","received_events_url":"https://api.github.com/users/iceman1001/received_events","type":"User","site_admin":false},"created_at":"2018-09-16T13:30:43Z","updated_at":"2018-09-16T13:30:43Z","author_association":"OWNER","body":"@DidierStevens  its quite easy to swap which standalone that compiles in that repo now.\r\nOnly one line change in armsrc/makefile.    Don't let that stop you."}}
{"actor":{"display_login":"iceman1001"}}