{"push_id":2411715722,"size":33,"distinct_size":31,"ref":"refs/heads/master","head":"3a279aaff42d577ac766d351c2f41f380c4ddf4c","before":"398e16c724e7df25aa40147995444c53427c3ca5","commits":[{"sha":"87c4bba9bb1a0a900577a43e8a22058f25a6e74e","author":{"name":"Adhita Selvaraj","email":"5c69ed09083270e0e539343d226c61e57f318698@gmail.com"},"message":"Addressing go vet errors (#397)\n\nAddressing #395.\r\n\r\nThere are some errors in our code but it won't caught by the compilers\r\n\r\n$ go vet $(go list ./... | grep -v /vendor/)\r\nOutput:\r\n\r\ncmd/tf-operator/app/server.go:129: unreachable code\r\nexit status 1\r\ndashboard/backend/handler/api_handler.go:36: struct field tfJobs has json tag but is not exported\r\ndashboard/backend/handler/api_handler.go:41: struct field namespaces has json tag but is not exported\r\nexit status 1","distinct":false,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/87c4bba9bb1a0a900577a43e8a22058f25a6e74e"},{"sha":"a1ce945e3c3f2f1feb64280c91edaed3e5bd8cda","author":{"name":"Jeremy Lewi","email":"67d05a303f608c8860c0ff063dc59351aa55b332@lewi.us"},"message":"Fix bug with jobs not working if you recreate a job with same name as previous job (#399)\n\nThis appears to be a bug with the informer forgetting about active jobs.\r\n\r\nI think the root cause is that delete events are processed directly\r\nas opposed to using the work queue. This causes race conditions because\r\nthe work queue is what ensures only on thread is processing a given job\r\nat a time.\r\n\r\nSince we no longer explicitly handle delete events we rely on garbage\r\ncollection and owner references to delete the pods.\r\n\r\nWe add testing to our test runner to verify pods are garbage collected.\r\n\r\nWe update test_runner.py to try recreating jobs with the same name.\r\nIn general this doesn't reproduce the original bug.\r\n\r\nRelated to #322 (to need to push a new image to fix).\r\nFix #310\r\n\r\nRelated to #373","distinct":false,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/a1ce945e3c3f2f1feb64280c91edaed3e5bd8cda"},{"sha":"32cae5d3757f561f470c724fcadbf978707ec259","author":{"name":"Jiayu Liu","email":"7895432f05d6a2e75da9a4c178602edeb4c801e8@users.noreply.github.com"},"message":"add go 1.10 support in travis (#402)\n\n* adding go 1.10 support in travis\r\n\r\n* use string not float","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/32cae5d3757f561f470c724fcadbf978707ec259"},{"sha":"08071b30a59a12235b1f5f9bbe58d41c047ea61c","author":{"name":"Jeremy Lewi","email":"67d05a303f608c8860c0ff063dc59351aa55b332@lewi.us"},"message":"Fix lint issues with python3 and a bug in lint script (#405)\n\nOur worker image has been upgraded and its now using python3 to run the lint checks.\r\nThere are some lint failures that only started appearing when we went to python3\r\nThere is a bug in py_checks that only shows up if there are lint failures\r\n\r\nFix #404","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/08071b30a59a12235b1f5f9bbe58d41c047ea61c"},{"sha":"32d9b17f24596bb160047f021049934ac7d1175a","author":{"name":"Jiayu Liu","email":"7895432f05d6a2e75da9a4c178602edeb4c801e8@users.noreply.github.com"},"message":"use yapf to format python code (#401)\n\nto enforce more consistent code style.\r\n\r\npython code changes are all automated by the tool.\r\n\r\nI think yapf is better because it is more aggressive with a reasonable default. Ideally I've imagined something opinionated such as https://prettier.io/, and having such a tool means that the code format can only be in one shape. YMMV.","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/32d9b17f24596bb160047f021049934ac7d1175a"},{"sha":"2bcd6cebd0764fa010b2e87d776e98e57eca80ab","author":{"name":"Ankush Agarwal","email":"a37394088996d718f74e9d717066914dd047152b@google.com"},"message":"Fix typo in Makefile (#409)","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/2bcd6cebd0764fa010b2e87d776e98e57eca80ab"},{"sha":"ab1cb4ded120ba98b33cdc290a3b5ac866ac438e","author":{"name":"Ankush Agarwal","email":"a37394088996d718f74e9d717066914dd047152b@google.com"},"message":"Run glide update to update glide.lock (#410)\n\nI'm planning to add a new dependency - github.com/onrik/logrus/filename. To add that I need to run glide update, which updates all the dependencies in this repository. So I want to check changes unrelated to github.com/onrik/logrus/filename in a separate PR.","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/ab1cb4ded120ba98b33cdc290a3b5ac866ac438e"},{"sha":"c54cda92034d2cb8c2085d820a653f4065d0ed16","author":{"name":"Jeremy Lewi","email":"67d05a303f608c8860c0ff063dc59351aa55b332@lewi.us"},"message":"Support using our E2E workflow to build a Docker image for releases. (#403)\n\nUpdate our E2E test to use ksonnet not helm to deploy\r\n\r\nAs part of this we have a slightl loss in test coverage because our\r\nhelm test provides some verification that our python tests don't.\r\nCreate a releasing environment for workflows that has parameters set\r\nas needed to build using our release cluster.\r\n\r\nRelated to\r\n#400 Use Argo for releases\r\n#373 Improve our test harness","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/c54cda92034d2cb8c2085d820a653f4065d0ed16"},{"sha":"0094aaa7ef501c0bc8b332edbe4a13781fe65a88","author":{"name":"Jeremy Lewi","email":"67d05a303f608c8860c0ff063dc59351aa55b332@lewi.us"},"message":"Docs should refer to Kubeflow user guide for deploying the TFJob operator. (#412)\n\n* We don't have the resources to support and maintain ksonnet and helm packages.\r\n* We want to focus on just using ksonnet to deploy Kubeflow.","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/0094aaa7ef501c0bc8b332edbe4a13781fe65a88"},{"sha":"a814670978c8d4ef78ffc3e99b370ee2d02d980c","author":{"name":"Jeremy Lewi","email":"67d05a303f608c8860c0ff063dc59351aa55b332@lewi.us"},"message":"Create an initial OWNERS file. (#414)\n\n* This will hopefully help us spread the review, approve workload around.\r\n* Related to\r\nkubeflow/community#10","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/a814670978c8d4ef78ffc3e99b370ee2d02d980c"},{"sha":"0759f7ae5142ed2e78a6971e9703fdc86b7307cd","author":{"name":"Ce Gao","email":"8b964a013861f4c3e0811a072d5c4c0b8060633a@outlook.com"},"message":"Remove TensorBoard related code in operator (#391)\n\nRef #347\r\n\r\nBlocked until CI is running again.\r\n\r\nPS: Dashboard code is not changed.\r\n\r\nSigned-off-by: Ce Gao ce.gao@outlook.com","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/0759f7ae5142ed2e78a6971e9703fdc86b7307cd"},{"sha":"cf97cd5f18e8b3facddbe8e33df82ecec2a2d955","author":{"name":"William Buchwalter","email":"7700d403dea3a6a8c17a0860f2e2c831e784a2a8@gmail.com"},"message":"dashboard: dev guide (#417)\n\nClose #411\r\n\r\nAdd a developer guide for the dashboard.\r\n\r\nMore doc is ultimately needed, but this is the most pressing part to unblock people from contributing.","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/cf97cd5f18e8b3facddbe8e33df82ecec2a2d955"},{"sha":"1f26ef8cf9680fc500e71602d396971d79188adc","author":{"name":"Penghao Cen","email":"04cd818cfa26ef45fdffa86bbcdd16388938fcdb@caicloud.io"},"message":"Add ScorpioCPH as approver/reviewer (#419)","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/1f26ef8cf9680fc500e71602d396971d79188adc"},{"sha":"fd4b8495f0b894ecf1b8322873ed50075d7a76b0","author":{"name":"Jeremy Lewi","email":"67d05a303f608c8860c0ff063dc59351aa55b332@lewi.us"},"message":"Fix setup_cluster. (#421)\n\n* We need to stop pinning GKE version to 1.8.5 because that is no longer\r\n  a valid version.\r\n\r\n* We should no longer need to pin because 1.8 is now the default.\r\n\r\n* Fix some lint issues that seem to have crept in.\r\n\r\nFix #240","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/fd4b8495f0b894ecf1b8322873ed50075d7a76b0"},{"sha":"2459f1c8da3df04ddfd56b04ed3069d088ba6ce5","author":{"name":"Jeremy Lewi","email":"67d05a303f608c8860c0ff063dc59351aa55b332@lewi.us"},"message":"Delete Dockerfile to build a docker image to use for proow. (#425)\n\n* All repositories use a common image now.\r\n* We no longer need this image.\r\n\r\nRelated to:\r\n\r\nkubeflow/kubeflow#276","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/2459f1c8da3df04ddfd56b04ed3069d088ba6ce5"},{"sha":"5d0d12688e08f80b41bb5eeac2da5418b73bfbbe","author":{"name":"Ankush Agarwal","email":"a37394088996d718f74e9d717066914dd047152b@google.com"},"message":"Use logrus for structured logging (#416)\n\n* Move from glog to sirupsen/logrus for logging\r\n* Add a new flag json_log_format\r\n* Refactor all log statements to use logrus\r\n* Use Info level for log level V(1) and below\r\n* Use Debug level for log level V(2) and above\r\n* Tested locally\r\n\r\nAddresses https://github.com/kubeflow/tf-operator/issues/24\r\n\r\nSample logs\r\n```\r\n{\"filename\":\"app/server.go:54\",\"level\":\"info\",\"msg\":\"EnvKubeflowNamespace not set, use default namespace\",\"time\":\"2018-02-27T18:25:18-08:00\"}\r\n{\"filename\":\"app/server.go:59\",\"level\":\"info\",\"msg\":\"[Version: 0.3.0+git Git SHA: Not provided. Go Version: go1.9.3 Go OS/Arch: darwin/amd64]\",\"time\":\"2018-02-27T18:25:18-08:00\"}\r\n{\"filename\":\"app/server.go:145\",\"level\":\"info\",\"msg\":\"No controller_config_file provided; using empty config.\",\"time\":\"2018-02-27T18:25:18-08:00\"}\r\n{\"filename\":\"controller/controller.go:110\",\"level\":\"info\",\"msg\":\"Setting up event handlers\",\"time\":\"2018-02-27T18:25:18-08:00\"}\r\n```","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/5d0d12688e08f80b41bb5eeac2da5418b73bfbbe"},{"sha":"092827191bd89db0d77b31782f7cb7895bf3b2f9","author":{"name":"Ce Gao","email":"8b964a013861f4c3e0811a072d5c4c0b8060633a@outlook.com"},"message":"fix(clientset): Fix code which is changed manually (#428)\n\n* clientset: Fix code which is changed manually\r\n\r\nSigned-off-by: Ce Gao <gaoce@caicloud.io>\r\n\r\n* pkg: Fix go import order\r\n\r\nSigned-off-by: Ce Gao <gaoce@caicloud.io>","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/092827191bd89db0d77b31782f7cb7895bf3b2f9"},{"sha":"d7131a9010227ff3faf5baa15b2926836e4e0246","author":{"name":"Hitoshi Mitake","email":"5b2187c33a904b291d57dc5560a08df5e7ab946d@gmail.com"},"message":"format the python files with yapf (#429)","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/d7131a9010227ff3faf5baa15b2926836e4e0246"},{"sha":"43677ccaa3d0da5b05e5b66ae730e6e6eac0fd25","author":{"name":"XsWack","email":"49c4ecde32fdac8afde0a02c822fdc2d003a6661@huawei.com"},"message":"add boilerplate header for go file (#431)\n\n* add boilerplate Copyright for generated file\r\n\r\n* update update-codegen.sh","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/43677ccaa3d0da5b05e5b66ae730e6e6eac0fd25"},{"sha":"6706903c1b45e775ddb310fe00fce6e07942ddb4","author":{"name":"Penghao Cen","email":"04cd818cfa26ef45fdffa86bbcdd16388938fcdb@caicloud.io"},"message":"Create pod instead of job (#344)\n\nThis PR is a part of #325:\r\n\r\nrename jobName() to genName()\r\ncreate Pod instead of Job\r\n\r\nTODOs (in another PR):\r\n\r\nuse controller.PodControlInterface and CreatePodsWithControllerRef to create Pod\r\nListen Pod CRUD and update TFJob status which descried in #314","distinct":true,"url":"https://api.github.com/repos/AK-ayush/tf-operator/commits/6706903c1b45e775ddb310fe00fce6e07942ddb4"}]}
{"actor":{"display_login":"AK-ayush"}}