{"action":"created","comment":{"url":"https://api.github.com/repos/pika/pika/pulls/comments/171975798","pull_request_review_id":100929253,"id":171975798,"diff_hunk":"@@ -33,11 +31,29 @@ class AsyncTestCase(unittest.TestCase):\n \n     def setUp(self):\n         self.logger = logging.getLogger(self.__class__.__name__)\n-        self.parameters = pika.URLParameters(\n-            'amqp://guest:guest@localhost:5672/%2F')\n+        self.parameters = pika.ConnectionParameters(\n+            host='localhost',\n+            port=5672)\n+        if self.should_test_tls():\n+            self.logger.info('testing using TLS/SSL connection to port 5671')\n+            self.parameters.port = 5671\n+            self.parameters.ssl = True\n+            self.parameters.ssl_options = dict(\n+                ssl_version=ssl.PROTOCOL_TLSv1,\n+                ca_certs=\"testdata/certs/ca_certificate.pem\",\n+                keyfile=\"testdata/certs/client_key.pem\",\n+                certfile=\"testdata/certs/client_certificate.pem\",\n+                cert_reqs=ssl.CERT_REQUIRED)","path":"tests/acceptance/async_test_base.py","position":37,"original_position":37,"commit_id":"07a660255f2fab954f69c6fe4394ea76bbf155a7","original_commit_id":"07a660255f2fab954f69c6fe4394ea76bbf155a7","user":{"login":"lukebakken","id":514926,"avatar_url":"https://avatars2.githubusercontent.com/u/514926?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebakken","html_url":"https://github.com/lukebakken","followers_url":"https://api.github.com/users/lukebakken/followers","following_url":"https://api.github.com/users/lukebakken/following{/other_user}","gists_url":"https://api.github.com/users/lukebakken/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebakken/subscriptions","organizations_url":"https://api.github.com/users/lukebakken/orgs","repos_url":"https://api.github.com/users/lukebakken/repos","events_url":"https://api.github.com/users/lukebakken/events{/privacy}","received_events_url":"https://api.github.com/users/lukebakken/received_events","type":"User","site_admin":false},"body":"> Please make should_test_tls and ssl_options available to other tests\r\n\r\nThere aren't other tests that need them at this point, right? I don't really want to expand this configuration beyond what is needed by our continuous integration environments in this PR. I will, however, add a section in the README giving instructions on how to use the included certs if someone wants to run TLS tests themselves. Since we include a `rabbitmq.conf.in` file it is pretty easy to get going.","created_at":"2018-03-02T22:08:19Z","updated_at":"2018-03-02T22:08:19Z","html_url":"https://github.com/pika/pika/pull/984#discussion_r171975798","pull_request_url":"https://api.github.com/repos/pika/pika/pulls/984","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pika/pika/pulls/comments/171975798"},"html":{"href":"https://github.com/pika/pika/pull/984#discussion_r171975798"},"pull_request":{"href":"https://api.github.com/repos/pika/pika/pulls/984"}},"in_reply_to_id":171973614},"pull_request":{"url":"https://api.github.com/repos/pika/pika/pulls/984","id":172393619,"html_url":"https://github.com/pika/pika/pull/984","diff_url":"https://github.com/pika/pika/pull/984.diff","patch_url":"https://github.com/pika/pika/pull/984.patch","issue_url":"https://api.github.com/repos/pika/pika/issues/984","number":984,"state":"open","locked":false,"title":"Enable TLS/SSL testing in Travis CI and AppVeyor","user":{"login":"lukebakken","id":514926,"avatar_url":"https://avatars2.githubusercontent.com/u/514926?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebakken","html_url":"https://github.com/lukebakken","followers_url":"https://api.github.com/users/lukebakken/followers","following_url":"https://api.github.com/users/lukebakken/following{/other_user}","gists_url":"https://api.github.com/users/lukebakken/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebakken/subscriptions","organizations_url":"https://api.github.com/users/lukebakken/orgs","repos_url":"https://api.github.com/users/lukebakken/repos","events_url":"https://api.github.com/users/lukebakken/events{/privacy}","received_events_url":"https://api.github.com/users/lukebakken/received_events","type":"User","site_admin":false},"body":"Fixes pika/pika#981","created_at":"2018-03-02T00:37:45Z","updated_at":"2018-03-02T22:08:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3a7dc98c79f947729fb65879aea59bd462284fa","assignee":{"login":"lukebakken","id":514926,"avatar_url":"https://avatars2.githubusercontent.com/u/514926?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebakken","html_url":"https://github.com/lukebakken","followers_url":"https://api.github.com/users/lukebakken/followers","following_url":"https://api.github.com/users/lukebakken/following{/other_user}","gists_url":"https://api.github.com/users/lukebakken/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebakken/subscriptions","organizations_url":"https://api.github.com/users/lukebakken/orgs","repos_url":"https://api.github.com/users/lukebakken/repos","events_url":"https://api.github.com/users/lukebakken/events{/privacy}","received_events_url":"https://api.github.com/users/lukebakken/received_events","type":"User","site_admin":false},"assignees":[{"login":"lukebakken","id":514926,"avatar_url":"https://avatars2.githubusercontent.com/u/514926?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebakken","html_url":"https://github.com/lukebakken","followers_url":"https://api.github.com/users/lukebakken/followers","following_url":"https://api.github.com/users/lukebakken/following{/other_user}","gists_url":"https://api.github.com/users/lukebakken/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebakken/subscriptions","organizations_url":"https://api.github.com/users/lukebakken/orgs","repos_url":"https://api.github.com/users/lukebakken/repos","events_url":"https://api.github.com/users/lukebakken/events{/privacy}","received_events_url":"https://api.github.com/users/lukebakken/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/pika/pika/milestones/8","html_url":"https://github.com/pika/pika/milestone/8","labels_url":"https://api.github.com/repos/pika/pika/milestones/8/labels","id":2664000,"number":8,"title":"1.0.0","description":"","creator":{"login":"lukebakken","id":514926,"avatar_url":"https://avatars2.githubusercontent.com/u/514926?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebakken","html_url":"https://github.com/lukebakken","followers_url":"https://api.github.com/users/lukebakken/followers","following_url":"https://api.github.com/users/lukebakken/following{/other_user}","gists_url":"https://api.github.com/users/lukebakken/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebakken/subscriptions","organizations_url":"https://api.github.com/users/lukebakken/orgs","repos_url":"https://api.github.com/users/lukebakken/repos","events_url":"https://api.github.com/users/lukebakken/events{/privacy}","received_events_url":"https://api.github.com/users/lukebakken/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":49,"state":"open","created_at":"2017-07-26T21:40:33Z","updated_at":"2018-03-02T15:11:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/pika/pika/pulls/984/commits","review_comments_url":"https://api.github.com/repos/pika/pika/pulls/984/comments","review_comment_url":"https://api.github.com/repos/pika/pika/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pika/pika/issues/984/comments","statuses_url":"https://api.github.com/repos/pika/pika/statuses/07a660255f2fab954f69c6fe4394ea76bbf155a7","head":{"label":"lukebakken:pika-981","ref":"pika-981","sha":"07a660255f2fab954f69c6fe4394ea76bbf155a7","user":{"login":"lukebakken","id":514926,"avatar_url":"https://avatars2.githubusercontent.com/u/514926?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebakken","html_url":"https://github.com/lukebakken","followers_url":"https://api.github.com/users/lukebakken/followers","following_url":"https://api.github.com/users/lukebakken/following{/other_user}","gists_url":"https://api.github.com/users/lukebakken/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebakken/subscriptions","organizations_url":"https://api.github.com/users/lukebakken/orgs","repos_url":"https://api.github.com/users/lukebakken/repos","events_url":"https://api.github.com/users/lukebakken/events{/privacy}","received_events_url":"https://api.github.com/users/lukebakken/received_events","type":"User","site_admin":false},"repo":{"id":123504066,"name":"pika","full_name":"lukebakken/pika","owner":{"login":"lukebakken","id":514926,"avatar_url":"https://avatars2.githubusercontent.com/u/514926?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebakken","html_url":"https://github.com/lukebakken","followers_url":"https://api.github.com/users/lukebakken/followers","following_url":"https://api.github.com/users/lukebakken/following{/other_user}","gists_url":"https://api.github.com/users/lukebakken/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebakken/subscriptions","organizations_url":"https://api.github.com/users/lukebakken/orgs","repos_url":"https://api.github.com/users/lukebakken/repos","events_url":"https://api.github.com/users/lukebakken/events{/privacy}","received_events_url":"https://api.github.com/users/lukebakken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukebakken/pika","description":"Pure Python RabbitMQ/AMQP 0-9-1 client library","fork":true,"url":"https://api.github.com/repos/lukebakken/pika","forks_url":"https://api.github.com/repos/lukebakken/pika/forks","keys_url":"https://api.github.com/repos/lukebakken/pika/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukebakken/pika/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukebakken/pika/teams","hooks_url":"https://api.github.com/repos/lukebakken/pika/hooks","issue_events_url":"https://api.github.com/repos/lukebakken/pika/issues/events{/number}","events_url":"https://api.github.com/repos/lukebakken/pika/events","assignees_url":"https://api.github.com/repos/lukebakken/pika/assignees{/user}","branches_url":"https://api.github.com/repos/lukebakken/pika/branches{/branch}","tags_url":"https://api.github.com/repos/lukebakken/pika/tags","blobs_url":"https://api.github.com/repos/lukebakken/pika/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukebakken/pika/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukebakken/pika/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukebakken/pika/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukebakken/pika/statuses/{sha}","languages_url":"https://api.github.com/repos/lukebakken/pika/languages","stargazers_url":"https://api.github.com/repos/lukebakken/pika/stargazers","contributors_url":"https://api.github.com/repos/lukebakken/pika/contributors","subscribers_url":"https://api.github.com/repos/lukebakken/pika/subscribers","subscription_url":"https://api.github.com/repos/lukebakken/pika/subscription","commits_url":"https://api.github.com/repos/lukebakken/pika/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukebakken/pika/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukebakken/pika/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukebakken/pika/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukebakken/pika/contents/{+path}","compare_url":"https://api.github.com/repos/lukebakken/pika/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukebakken/pika/merges","archive_url":"https://api.github.com/repos/lukebakken/pika/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukebakken/pika/downloads","issues_url":"https://api.github.com/repos/lukebakken/pika/issues{/number}","pulls_url":"https://api.github.com/repos/lukebakken/pika/pulls{/number}","milestones_url":"https://api.github.com/repos/lukebakken/pika/milestones{/number}","notifications_url":"https://api.github.com/repos/lukebakken/pika/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukebakken/pika/labels{/name}","releases_url":"https://api.github.com/repos/lukebakken/pika/releases{/id}","deployments_url":"https://api.github.com/repos/lukebakken/pika/deployments","created_at":"2018-03-01T23:22:21Z","updated_at":"2018-03-01T23:22:22Z","pushed_at":"2018-03-02T15:31:11Z","git_url":"git://github.com/lukebakken/pika.git","ssh_url":"git@github.com:lukebakken/pika.git","clone_url":"https://github.com/lukebakken/pika.git","svn_url":"https://github.com/lukebakken/pika","homepage":"https://pika.readthedocs.io","size":6042,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pika:master","ref":"master","sha":"7f81bc721807c5416726016838398804c07effbd","user":{"login":"pika","id":660428,"avatar_url":"https://avatars3.githubusercontent.com/u/660428?v=4","gravatar_id":"","url":"https://api.github.com/users/pika","html_url":"https://github.com/pika","followers_url":"https://api.github.com/users/pika/followers","following_url":"https://api.github.com/users/pika/following{/other_user}","gists_url":"https://api.github.com/users/pika/gists{/gist_id}","starred_url":"https://api.github.com/users/pika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pika/subscriptions","organizations_url":"https://api.github.com/users/pika/orgs","repos_url":"https://api.github.com/users/pika/repos","events_url":"https://api.github.com/users/pika/events{/privacy}","received_events_url":"https://api.github.com/users/pika/received_events","type":"Organization","site_admin":false},"repo":{"id":342869,"name":"pika","full_name":"pika/pika","owner":{"login":"pika","id":660428,"avatar_url":"https://avatars3.githubusercontent.com/u/660428?v=4","gravatar_id":"","url":"https://api.github.com/users/pika","html_url":"https://github.com/pika","followers_url":"https://api.github.com/users/pika/followers","following_url":"https://api.github.com/users/pika/following{/other_user}","gists_url":"https://api.github.com/users/pika/gists{/gist_id}","starred_url":"https://api.github.com/users/pika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pika/subscriptions","organizations_url":"https://api.github.com/users/pika/orgs","repos_url":"https://api.github.com/users/pika/repos","events_url":"https://api.github.com/users/pika/events{/privacy}","received_events_url":"https://api.github.com/users/pika/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pika/pika","description":"Pure Python RabbitMQ/AMQP 0-9-1 client library","fork":false,"url":"https://api.github.com/repos/pika/pika","forks_url":"https://api.github.com/repos/pika/pika/forks","keys_url":"https://api.github.com/repos/pika/pika/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pika/pika/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pika/pika/teams","hooks_url":"https://api.github.com/repos/pika/pika/hooks","issue_events_url":"https://api.github.com/repos/pika/pika/issues/events{/number}","events_url":"https://api.github.com/repos/pika/pika/events","assignees_url":"https://api.github.com/repos/pika/pika/assignees{/user}","branches_url":"https://api.github.com/repos/pika/pika/branches{/branch}","tags_url":"https://api.github.com/repos/pika/pika/tags","blobs_url":"https://api.github.com/repos/pika/pika/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pika/pika/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pika/pika/git/refs{/sha}","trees_url":"https://api.github.com/repos/pika/pika/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pika/pika/statuses/{sha}","languages_url":"https://api.github.com/repos/pika/pika/languages","stargazers_url":"https://api.github.com/repos/pika/pika/stargazers","contributors_url":"https://api.github.com/repos/pika/pika/contributors","subscribers_url":"https://api.github.com/repos/pika/pika/subscribers","subscription_url":"https://api.github.com/repos/pika/pika/subscription","commits_url":"https://api.github.com/repos/pika/pika/commits{/sha}","git_commits_url":"https://api.github.com/repos/pika/pika/git/commits{/sha}","comments_url":"https://api.github.com/repos/pika/pika/comments{/number}","issue_comment_url":"https://api.github.com/repos/pika/pika/issues/comments{/number}","contents_url":"https://api.github.com/repos/pika/pika/contents/{+path}","compare_url":"https://api.github.com/repos/pika/pika/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pika/pika/merges","archive_url":"https://api.github.com/repos/pika/pika/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pika/pika/downloads","issues_url":"https://api.github.com/repos/pika/pika/issues{/number}","pulls_url":"https://api.github.com/repos/pika/pika/pulls{/number}","milestones_url":"https://api.github.com/repos/pika/pika/milestones{/number}","notifications_url":"https://api.github.com/repos/pika/pika/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pika/pika/labels{/name}","releases_url":"https://api.github.com/repos/pika/pika/releases{/id}","deployments_url":"https://api.github.com/repos/pika/pika/deployments","created_at":"2009-10-19T23:22:02Z","updated_at":"2018-03-01T07:20:50Z","pushed_at":"2018-03-02T20:40:55Z","git_url":"git://github.com/pika/pika.git","ssh_url":"git@github.com:pika/pika.git","clone_url":"https://github.com/pika/pika.git","svn_url":"https://github.com/pika/pika","homepage":"https://pika.readthedocs.io","size":6029,"stargazers_count":1516,"watchers_count":1516,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":471,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":471,"open_issues":38,"watchers":1516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pika/pika/pulls/984"},"html":{"href":"https://github.com/pika/pika/pull/984"},"issue":{"href":"https://api.github.com/repos/pika/pika/issues/984"},"comments":{"href":"https://api.github.com/repos/pika/pika/issues/984/comments"},"review_comments":{"href":"https://api.github.com/repos/pika/pika/pulls/984/comments"},"review_comment":{"href":"https://api.github.com/repos/pika/pika/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pika/pika/pulls/984/commits"},"statuses":{"href":"https://api.github.com/repos/pika/pika/statuses/07a660255f2fab954f69c6fe4394ea76bbf155a7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lukebakken"}}