{"action":"created","issue":{"url":"https://api.github.com/repos/jakevdp/pdvega/issues/29","repository_url":"https://api.github.com/repos/jakevdp/pdvega","labels_url":"https://api.github.com/repos/jakevdp/pdvega/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/jakevdp/pdvega/issues/29/comments","events_url":"https://api.github.com/repos/jakevdp/pdvega/issues/29/events","html_url":"https://github.com/jakevdp/pdvega/pull/29","id":349764597,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzkzMDg4","number":29,"title":"rewrite using altair","user":{"login":"Casyfill","id":2675621,"node_id":"MDQ6VXNlcjI2NzU2MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/2675621?v=4","gravatar_id":"","url":"https://api.github.com/users/Casyfill","html_url":"https://github.com/Casyfill","followers_url":"https://api.github.com/users/Casyfill/followers","following_url":"https://api.github.com/users/Casyfill/following{/other_user}","gists_url":"https://api.github.com/users/Casyfill/gists{/gist_id}","starred_url":"https://api.github.com/users/Casyfill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Casyfill/subscriptions","organizations_url":"https://api.github.com/users/Casyfill/orgs","repos_url":"https://api.github.com/users/Casyfill/repos","events_url":"https://api.github.com/users/Casyfill/events{/privacy}","received_events_url":"https://api.github.com/users/Casyfill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-11T21:22:13Z","updated_at":"2018-08-15T17:29:07Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jakevdp/pdvega/pulls/29","html_url":"https://github.com/jakevdp/pdvega/pull/29","diff_url":"https://github.com/jakevdp/pdvega/pull/29.diff","patch_url":"https://github.com/jakevdp/pdvega/pull/29.patch"},"body":"the very first passing implementation, mainly\r\n\r\n- added `altair` as a dependency\r\n- dropped `axis.py`\r\n- dropped  some altair-specific tests (perhaps should drop more)\r\n- every `plot` function now returns a \"non-interactive\" altair chart, therefore I dropped `interactive` and `ax` as arguements\r\n\r\n\r\n### Some remarks\r\n- definitely should try \"reenact\" this in the notebook https://pandas.pydata.org/pandas-docs/stable/visualization.html\r\n- perhaps it's worth considering to add the support for `repeat` in api - for example, plotting the groupby object,  or something alike "},"comment":{"url":"https://api.github.com/repos/jakevdp/pdvega/issues/comments/413272475","html_url":"https://github.com/jakevdp/pdvega/pull/29#issuecomment-413272475","issue_url":"https://api.github.com/repos/jakevdp/pdvega/issues/29","id":413272475,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzI3MjQ3NQ==","user":{"login":"jakevdp","id":781659,"node_id":"MDQ6VXNlcjc4MTY1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/781659?v=4","gravatar_id":"","url":"https://api.github.com/users/jakevdp","html_url":"https://github.com/jakevdp","followers_url":"https://api.github.com/users/jakevdp/followers","following_url":"https://api.github.com/users/jakevdp/following{/other_user}","gists_url":"https://api.github.com/users/jakevdp/gists{/gist_id}","starred_url":"https://api.github.com/users/jakevdp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakevdp/subscriptions","organizations_url":"https://api.github.com/users/jakevdp/orgs","repos_url":"https://api.github.com/users/jakevdp/repos","events_url":"https://api.github.com/users/jakevdp/events{/privacy}","received_events_url":"https://api.github.com/users/jakevdp/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T17:29:07Z","updated_at":"2018-08-15T17:29:07Z","author_association":"OWNER","body":"One over-arching comment: one thing this removes is the axes object, which I had created so that users could pass it around the same way they do in pandas; e.g.\r\n```\r\nax = df.vgplot.line(...)\r\ndf.vgplot.scatter(..., ax=ax)\r\n```\r\nCan we make that work now that the return value is an Altair chart rather than an axes object?"}}
{"actor":{"display_login":"jakevdp"}}