{"action":"created","issue":{"url":"https://api.github.com/repos/gnuradio/gnuradio/issues/1728","repository_url":"https://api.github.com/repos/gnuradio/gnuradio","labels_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/1728/labels{/name}","comments_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/1728/comments","events_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/1728/events","html_url":"https://github.com/gnuradio/gnuradio/pull/1728","id":313320581,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgwOTAwOTI1","number":1728,"title":"cmake: fix CTRLPORT includes and testing","user":{"login":"michaelld","id":157892,"node_id":"MDQ6VXNlcjE1Nzg5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/157892?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelld","html_url":"https://github.com/michaelld","followers_url":"https://api.github.com/users/michaelld/followers","following_url":"https://api.github.com/users/michaelld/following{/other_user}","gists_url":"https://api.github.com/users/michaelld/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelld/subscriptions","organizations_url":"https://api.github.com/users/michaelld/orgs","repos_url":"https://api.github.com/users/michaelld/repos","events_url":"https://api.github.com/users/michaelld/events{/privacy}","received_events_url":"https://api.github.com/users/michaelld/received_events","type":"User","site_admin":false},"labels":[{"id":824800465,"node_id":"MDU6TGFiZWw4MjQ4MDA0NjU=","url":"https://api.github.com/repos/gnuradio/gnuradio/labels/CMake","name":"CMake","color":"abfcdc","default":false},{"id":916952303,"node_id":"MDU6TGFiZWw5MTY5NTIzMDM=","url":"https://api.github.com/repos/gnuradio/gnuradio/labels/ctrlport","name":"ctrlport","color":"053384","default":false},{"id":1035766847,"node_id":"MDU6TGFiZWwxMDM1NzY2ODQ3","url":"https://api.github.com/repos/gnuradio/gnuradio/labels/waiting%20on%20CI","name":"waiting on CI","color":"4182a3","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2018-04-11T13:19:41Z","updated_at":"2018-11-15T14:05:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/1728","html_url":"https://github.com/gnuradio/gnuradio/pull/1728","diff_url":"https://github.com/gnuradio/gnuradio/pull/1728.diff","patch_url":"https://github.com/gnuradio/gnuradio/pull/1728.patch"},"body":"Currently, CTRLPORT_BACKENDS is not declared if ENABLE_GR_CTRLPORT is FALSE, so testing this variable makes no sense. All testing in gr-* is done using ENABLE_GR_CTRLPORT, so move to that in gr-blocks.\r\n\r\nThat said, having CTRLPORT_BACKENDS set to 0 could be useful, so rearrange CTRLPORT determination to set this variable correctly.\r\n\r\nIf ENABLE_CTRLPORT_THRIFT, then correctly use include_directories for header directories, -after- CTRLPORT is determined, not before. We can also combine some of these declarations to simplify the code."},"comment":{"url":"https://api.github.com/repos/gnuradio/gnuradio/issues/comments/439050802","html_url":"https://github.com/gnuradio/gnuradio/pull/1728#issuecomment-439050802","issue_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/1728","id":439050802,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTA1MDgwMg==","user":{"login":"michaelld","id":157892,"node_id":"MDQ6VXNlcjE1Nzg5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/157892?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelld","html_url":"https://github.com/michaelld","followers_url":"https://api.github.com/users/michaelld/followers","following_url":"https://api.github.com/users/michaelld/following{/other_user}","gists_url":"https://api.github.com/users/michaelld/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelld/subscriptions","organizations_url":"https://api.github.com/users/michaelld/orgs","repos_url":"https://api.github.com/users/michaelld/repos","events_url":"https://api.github.com/users/michaelld/events{/privacy}","received_events_url":"https://api.github.com/users/michaelld/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T14:05:19Z","updated_at":"2018-11-15T14:05:19Z","author_association":"CONTRIBUTOR","body":"Yes I see there's an issue for when CTRLPORT is enabled without a backend (Thrift). Let me look into it."}}
{"actor":{"display_login":"michaelld"}}