{"action":"created","issue":{"url":"https://api.github.com/repos/WFCD/warframe-drop-data/issues/17","repository_url":"https://api.github.com/repos/WFCD/warframe-drop-data","labels_url":"https://api.github.com/repos/WFCD/warframe-drop-data/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/WFCD/warframe-drop-data/issues/17/comments","events_url":"https://api.github.com/repos/WFCD/warframe-drop-data/issues/17/events","html_url":"https://github.com/WFCD/warframe-drop-data/pull/17","id":325398303,"number":17,"title":"Fix some \"_id\" fields not being unique.","user":{"login":"Senexis","id":6360733,"avatar_url":"https://avatars1.githubusercontent.com/u/6360733?v=4","gravatar_id":"","url":"https://api.github.com/users/Senexis","html_url":"https://github.com/Senexis","followers_url":"https://api.github.com/users/Senexis/followers","following_url":"https://api.github.com/users/Senexis/following{/other_user}","gists_url":"https://api.github.com/users/Senexis/gists{/gist_id}","starred_url":"https://api.github.com/users/Senexis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Senexis/subscriptions","organizations_url":"https://api.github.com/users/Senexis/orgs","repos_url":"https://api.github.com/users/Senexis/repos","events_url":"https://api.github.com/users/Senexis/events{/privacy}","received_events_url":"https://api.github.com/users/Senexis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-22T17:46:01Z","updated_at":"2018-05-23T15:25:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/WFCD/warframe-drop-data/pulls/17","html_url":"https://github.com/WFCD/warframe-drop-data/pull/17","diff_url":"https://github.com/WFCD/warframe-drop-data/pull/17.diff","patch_url":"https://github.com/WFCD/warframe-drop-data/pull/17.patch"},"body":"The field not being unique may cause issues with the difference checker as it just randomly decides the order of certain objects, causing false positives in difference checkers. It was also causing some issues in my own overlay project.\r\n\r\n- Make the \"_id\" fields use more than just the name, as duplicate names are possible in the cases of enemies.\r\n- Add an \"_id\" field to transients and refactor the file a bit.\r\n- Updates the README to reflect the \"_id\" addition.\r\n\r\nThese are the only current files that have ambiguity, but there may be more cases of this issue possible later (think items, primarily). Might need to improve the \"_id\" field of those later, too. For now, however, this suffices.\r\n\r\nDifference can be checked [here](https://senexis.github.io/warframe-drop-data/diff.html), compare with the live version of the diff checker."},"comment":{"url":"https://api.github.com/repos/WFCD/warframe-drop-data/issues/comments/391389395","html_url":"https://github.com/WFCD/warframe-drop-data/pull/17#issuecomment-391389395","issue_url":"https://api.github.com/repos/WFCD/warframe-drop-data/issues/17","id":391389395,"user":{"login":"Senexis","id":6360733,"avatar_url":"https://avatars1.githubusercontent.com/u/6360733?v=4","gravatar_id":"","url":"https://api.github.com/users/Senexis","html_url":"https://github.com/Senexis","followers_url":"https://api.github.com/users/Senexis/followers","following_url":"https://api.github.com/users/Senexis/following{/other_user}","gists_url":"https://api.github.com/users/Senexis/gists{/gist_id}","starred_url":"https://api.github.com/users/Senexis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Senexis/subscriptions","organizations_url":"https://api.github.com/users/Senexis/orgs","repos_url":"https://api.github.com/users/Senexis/repos","events_url":"https://api.github.com/users/Senexis/events{/privacy}","received_events_url":"https://api.github.com/users/Senexis/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T15:25:51Z","updated_at":"2018-05-23T15:25:51Z","author_association":"CONTRIBUTOR","body":"Oh dang, I just figured out where \"ememy\" came from, it's from the enemy mod locations file, and has been since pretty much always, dating back to 2017. Does it matter that this fixes that too or should we add \"ememy\" back for existing apps?\r\n\r\nAgain, \"ememy\" has been in there since forever."}}
{"actor":{"display_login":"Senexis"}}