{"action":"created","comment":{"url":"https://api.github.com/repos/apache/samza/pulls/comments/186198291","pull_request_review_id":117737666,"id":186198291,"diff_hunk":"@@ -194,15 +196,42 @@ public ApplicationStatus status(StreamApplication streamApp) {\n   }\n \n   /**\n-   * Block until the application finishes\n+   * Waits until the application finishes.\n    */\n+  @Override\n   public void waitForFinish() {\n+    waitForFinish(Duration.ofMillis(0));\n+  }\n+\n+  /**\n+   * Waits until the application finishes. It times out after the input duration has elapsed.","path":"samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java","position":22,"original_position":22,"commit_id":"5f00d953a2dd3eb204892e5980cae929737a235b","original_commit_id":"5f00d953a2dd3eb204892e5980cae929737a235b","user":{"login":"prateekm","id":1085859,"avatar_url":"https://avatars2.githubusercontent.com/u/1085859?v=4","gravatar_id":"","url":"https://api.github.com/users/prateekm","html_url":"https://github.com/prateekm","followers_url":"https://api.github.com/users/prateekm/followers","following_url":"https://api.github.com/users/prateekm/following{/other_user}","gists_url":"https://api.github.com/users/prateekm/gists{/gist_id}","starred_url":"https://api.github.com/users/prateekm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateekm/subscriptions","organizations_url":"https://api.github.com/users/prateekm/orgs","repos_url":"https://api.github.com/users/prateekm/repos","events_url":"https://api.github.com/users/prateekm/events{/privacy}","received_events_url":"https://api.github.com/users/prateekm/received_events","type":"User","site_admin":false},"body":"Maybe: \"Waits for {code timeout} duration for the application to finish.\"","created_at":"2018-05-04T19:52:19Z","updated_at":"2018-05-04T19:54:17Z","html_url":"https://github.com/apache/samza/pull/503#discussion_r186198291","pull_request_url":"https://api.github.com/repos/apache/samza/pulls/503","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/comments/186198291"},"html":{"href":"https://github.com/apache/samza/pull/503#discussion_r186198291"},"pull_request":{"href":"https://api.github.com/repos/apache/samza/pulls/503"}}},"pull_request":{"url":"https://api.github.com/repos/apache/samza/pulls/503","id":186017713,"html_url":"https://github.com/apache/samza/pull/503","diff_url":"https://github.com/apache/samza/pull/503.diff","patch_url":"https://github.com/apache/samza/pull/503.patch","issue_url":"https://api.github.com/repos/apache/samza/issues/503","number":503,"state":"open","locked":false,"title":"SAMZA-1653: Support waitForFinish in remote application runner and add waitForFinish","user":{"login":"bharathkk","id":1001798,"avatar_url":"https://avatars2.githubusercontent.com/u/1001798?v=4","gravatar_id":"","url":"https://api.github.com/users/bharathkk","html_url":"https://github.com/bharathkk","followers_url":"https://api.github.com/users/bharathkk/followers","following_url":"https://api.github.com/users/bharathkk/following{/other_user}","gists_url":"https://api.github.com/users/bharathkk/gists{/gist_id}","starred_url":"https://api.github.com/users/bharathkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bharathkk/subscriptions","organizations_url":"https://api.github.com/users/bharathkk/orgs","repos_url":"https://api.github.com/users/bharathkk/repos","events_url":"https://api.github.com/users/bharathkk/events{/privacy}","received_events_url":"https://api.github.com/users/bharathkk/received_events","type":"User","site_admin":false},"body":"Added the following APIs to AbstractApplicationRunner \r\n `void waitForFinish()`\r\n `void waitForFinish(Duration timeout)`\r\n\r\nImplemented the wait for finish methods in remote application runner. Note currently, there is disparity in the APIs in terms of associating runners with stream application. Ideally, we want to decide on the cardinal relation between them and change the APIs accordingly. \r\n\r\nThe goal of the PR is limited to introduce API (waitForFinish) parity between runners in the current setup. \r\n@xinyuiscool ","created_at":"2018-05-04T15:29:58Z","updated_at":"2018-05-04T19:54:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"796e8e00c09dd0f3228e747ef4ba8f66555317c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/samza/pulls/503/commits","review_comments_url":"https://api.github.com/repos/apache/samza/pulls/503/comments","review_comment_url":"https://api.github.com/repos/apache/samza/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/samza/issues/503/comments","statuses_url":"https://api.github.com/repos/apache/samza/statuses/5f00d953a2dd3eb204892e5980cae929737a235b","head":{"label":"bharathkk:samza-1653","ref":"samza-1653","sha":"5f00d953a2dd3eb204892e5980cae929737a235b","user":{"login":"bharathkk","id":1001798,"avatar_url":"https://avatars2.githubusercontent.com/u/1001798?v=4","gravatar_id":"","url":"https://api.github.com/users/bharathkk","html_url":"https://github.com/bharathkk","followers_url":"https://api.github.com/users/bharathkk/followers","following_url":"https://api.github.com/users/bharathkk/following{/other_user}","gists_url":"https://api.github.com/users/bharathkk/gists{/gist_id}","starred_url":"https://api.github.com/users/bharathkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bharathkk/subscriptions","organizations_url":"https://api.github.com/users/bharathkk/orgs","repos_url":"https://api.github.com/users/bharathkk/repos","events_url":"https://api.github.com/users/bharathkk/events{/privacy}","received_events_url":"https://api.github.com/users/bharathkk/received_events","type":"User","site_admin":false},"repo":{"id":90763289,"name":"samza","full_name":"bharathkk/samza","owner":{"login":"bharathkk","id":1001798,"avatar_url":"https://avatars2.githubusercontent.com/u/1001798?v=4","gravatar_id":"","url":"https://api.github.com/users/bharathkk","html_url":"https://github.com/bharathkk","followers_url":"https://api.github.com/users/bharathkk/followers","following_url":"https://api.github.com/users/bharathkk/following{/other_user}","gists_url":"https://api.github.com/users/bharathkk/gists{/gist_id}","starred_url":"https://api.github.com/users/bharathkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bharathkk/subscriptions","organizations_url":"https://api.github.com/users/bharathkk/orgs","repos_url":"https://api.github.com/users/bharathkk/repos","events_url":"https://api.github.com/users/bharathkk/events{/privacy}","received_events_url":"https://api.github.com/users/bharathkk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bharathkk/samza","description":"Mirror of Apache Samza","fork":true,"url":"https://api.github.com/repos/bharathkk/samza","forks_url":"https://api.github.com/repos/bharathkk/samza/forks","keys_url":"https://api.github.com/repos/bharathkk/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bharathkk/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bharathkk/samza/teams","hooks_url":"https://api.github.com/repos/bharathkk/samza/hooks","issue_events_url":"https://api.github.com/repos/bharathkk/samza/issues/events{/number}","events_url":"https://api.github.com/repos/bharathkk/samza/events","assignees_url":"https://api.github.com/repos/bharathkk/samza/assignees{/user}","branches_url":"https://api.github.com/repos/bharathkk/samza/branches{/branch}","tags_url":"https://api.github.com/repos/bharathkk/samza/tags","blobs_url":"https://api.github.com/repos/bharathkk/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bharathkk/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bharathkk/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/bharathkk/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bharathkk/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/bharathkk/samza/languages","stargazers_url":"https://api.github.com/repos/bharathkk/samza/stargazers","contributors_url":"https://api.github.com/repos/bharathkk/samza/contributors","subscribers_url":"https://api.github.com/repos/bharathkk/samza/subscribers","subscription_url":"https://api.github.com/repos/bharathkk/samza/subscription","commits_url":"https://api.github.com/repos/bharathkk/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/bharathkk/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/bharathkk/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/bharathkk/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/bharathkk/samza/contents/{+path}","compare_url":"https://api.github.com/repos/bharathkk/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bharathkk/samza/merges","archive_url":"https://api.github.com/repos/bharathkk/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bharathkk/samza/downloads","issues_url":"https://api.github.com/repos/bharathkk/samza/issues{/number}","pulls_url":"https://api.github.com/repos/bharathkk/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/bharathkk/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/bharathkk/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bharathkk/samza/labels{/name}","releases_url":"https://api.github.com/repos/bharathkk/samza/releases{/id}","deployments_url":"https://api.github.com/repos/bharathkk/samza/deployments","created_at":"2017-05-09T15:39:36Z","updated_at":"2018-05-04T15:23:02Z","pushed_at":"2018-05-04T19:20:54Z","git_url":"git://github.com/bharathkk/samza.git","ssh_url":"git@github.com:bharathkk/samza.git","clone_url":"https://github.com/bharathkk/samza.git","svn_url":"https://github.com/bharathkk/samza","homepage":null,"size":19610,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"51729ac6836f5baa522d7ba6a7308504ba027c5f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32199982,"name":"samza","full_name":"apache/samza","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/samza","description":"Mirror of Apache Samza","fork":false,"url":"https://api.github.com/repos/apache/samza","forks_url":"https://api.github.com/repos/apache/samza/forks","keys_url":"https://api.github.com/repos/apache/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/samza/teams","hooks_url":"https://api.github.com/repos/apache/samza/hooks","issue_events_url":"https://api.github.com/repos/apache/samza/issues/events{/number}","events_url":"https://api.github.com/repos/apache/samza/events","assignees_url":"https://api.github.com/repos/apache/samza/assignees{/user}","branches_url":"https://api.github.com/repos/apache/samza/branches{/branch}","tags_url":"https://api.github.com/repos/apache/samza/tags","blobs_url":"https://api.github.com/repos/apache/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/samza/languages","stargazers_url":"https://api.github.com/repos/apache/samza/stargazers","contributors_url":"https://api.github.com/repos/apache/samza/contributors","subscribers_url":"https://api.github.com/repos/apache/samza/subscribers","subscription_url":"https://api.github.com/repos/apache/samza/subscription","commits_url":"https://api.github.com/repos/apache/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/samza/contents/{+path}","compare_url":"https://api.github.com/repos/apache/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/samza/merges","archive_url":"https://api.github.com/repos/apache/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/samza/downloads","issues_url":"https://api.github.com/repos/apache/samza/issues{/number}","pulls_url":"https://api.github.com/repos/apache/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/samza/labels{/name}","releases_url":"https://api.github.com/repos/apache/samza/releases{/id}","deployments_url":"https://api.github.com/repos/apache/samza/deployments","created_at":"2015-03-14T07:00:05Z","updated_at":"2018-05-04T09:47:06Z","pushed_at":"2018-05-04T19:20:56Z","git_url":"git://github.com/apache/samza.git","ssh_url":"git@github.com:apache/samza.git","clone_url":"https://github.com/apache/samza.git","svn_url":"https://github.com/apache/samza","homepage":null,"size":19612,"stargazers_count":421,"watchers_count":421,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":186,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":186,"open_issues":24,"watchers":421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/503"},"html":{"href":"https://github.com/apache/samza/pull/503"},"issue":{"href":"https://api.github.com/repos/apache/samza/issues/503"},"comments":{"href":"https://api.github.com/repos/apache/samza/issues/503/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/samza/pulls/503/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/samza/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/samza/pulls/503/commits"},"statuses":{"href":"https://api.github.com/repos/apache/samza/statuses/5f00d953a2dd3eb204892e5980cae929737a235b"}},"author_association":"NONE"}}
{"actor":{"display_login":"prateekm"}}