{"action":"closed","issue":{"url":"https://api.github.com/repos/VCVRack/Rack/issues/871","repository_url":"https://api.github.com/repos/VCVRack/Rack","labels_url":"https://api.github.com/repos/VCVRack/Rack/issues/871/labels{/name}","comments_url":"https://api.github.com/repos/VCVRack/Rack/issues/871/comments","events_url":"https://api.github.com/repos/VCVRack/Rack/issues/871/events","html_url":"https://github.com/VCVRack/Rack/issues/871","id":310283716,"number":871,"title":"API changes - 2 questions","user":{"login":"ndrspcfd","id":11374019,"avatar_url":"https://avatars3.githubusercontent.com/u/11374019?v=4","gravatar_id":"","url":"https://api.github.com/users/ndrspcfd","html_url":"https://github.com/ndrspcfd","followers_url":"https://api.github.com/users/ndrspcfd/followers","following_url":"https://api.github.com/users/ndrspcfd/following{/other_user}","gists_url":"https://api.github.com/users/ndrspcfd/gists{/gist_id}","starred_url":"https://api.github.com/users/ndrspcfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndrspcfd/subscriptions","organizations_url":"https://api.github.com/users/ndrspcfd/orgs","repos_url":"https://api.github.com/users/ndrspcfd/repos","events_url":"https://api.github.com/users/ndrspcfd/events{/privacy}","received_events_url":"https://api.github.com/users/ndrspcfd/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-01T00:55:28Z","updated_at":"2018-05-20T23:10:23Z","closed_at":"2018-05-20T23:10:23Z","author_association":"NONE","body":"A couple of questions, hope that's ok..\r\n\r\n1) With the changes in constructing structs derived from ModuleWidget, the base class initializer uses the `module` pointer param directly, where previously we used `setModule()`. Suppose I have a module Foo, and its widget FooWidget. Can `Foo::step()` be unavoidably called by the engine during `FooWidget::FooWidget(Foo *)`? \r\n\r\n(Previously I was initialising a couple of Foo's data members in my FooWidget constructor, and had moved setModule() to the end of that so uninitialised members stopped causing segfaults in `Foo::step()` It's not ideal code, and if I continue with it there are workarounds, like a conditional at the start of step(), etc., but I'm interested in performance and coder convenience first, and purity second :) )\r\n\r\n2) Perhaps not a fair question, but how much change do  you expect between 0.6 and 1.x plugin APIs compared to that between 0.5 and 0.6? "}}
{"actor":{"display_login":"AndrewBelt"}}