{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments/187497891","pull_request_review_id":119292357,"id":187497891,"diff_hunk":"@@ -1,8 +1,6 @@\n import { createInternalAddon } from 'core/reducers/addons';\n import themeAction, { getThemeData } from 'core/themePreview';","path":"tests/unit/core/TestThemePreview.js","position":2,"original_position":2,"commit_id":"fda1f5d81c6fecffb12c8c6f843e6c567e3f0d08","original_commit_id":"fda1f5d81c6fecffb12c8c6f843e6c567e3f0d08","user":{"login":"rebmullin","id":1986001,"avatar_url":"https://avatars2.githubusercontent.com/u/1986001?v=4","gravatar_id":"","url":"https://api.github.com/users/rebmullin","html_url":"https://github.com/rebmullin","followers_url":"https://api.github.com/users/rebmullin/followers","following_url":"https://api.github.com/users/rebmullin/following{/other_user}","gists_url":"https://api.github.com/users/rebmullin/gists{/gist_id}","starred_url":"https://api.github.com/users/rebmullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebmullin/subscriptions","organizations_url":"https://api.github.com/users/rebmullin/orgs","repos_url":"https://api.github.com/users/rebmullin/repos","events_url":"https://api.github.com/users/rebmullin/events{/privacy}","received_events_url":"https://api.github.com/users/rebmullin/received_events","type":"User","site_admin":false},"body":"hey @bobsilverberg  - from what I can tell this `getThemeData` is connected to installing and getting the theme data if it's installed. I think the only place we can remove this is from the preview pieces (which i think i've done already)\r\n\r\nThe thing I am confused about is `data-browsertheme` prop itself - I wanted to see this to be sure but I don't see where that traces back to...","created_at":"2018-05-11T00:55:30Z","updated_at":"2018-05-11T00:55:30Z","html_url":"https://github.com/mozilla/addons-frontend/pull/4914#discussion_r187497891","pull_request_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4914","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments/187497891"},"html":{"href":"https://github.com/mozilla/addons-frontend/pull/4914#discussion_r187497891"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4914"}},"in_reply_to_id":187203352},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4914","id":185484421,"html_url":"https://github.com/mozilla/addons-frontend/pull/4914","diff_url":"https://github.com/mozilla/addons-frontend/pull/4914.diff","patch_url":"https://github.com/mozilla/addons-frontend/pull/4914.patch","issue_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/4914","number":4914,"state":"open","locked":false,"title":"i 3056 removing tap to preview btn","user":{"login":"rebmullin","id":1986001,"avatar_url":"https://avatars2.githubusercontent.com/u/1986001?v=4","gravatar_id":"","url":"https://api.github.com/users/rebmullin","html_url":"https://github.com/rebmullin","followers_url":"https://api.github.com/users/rebmullin/followers","following_url":"https://api.github.com/users/rebmullin/following{/other_user}","gists_url":"https://api.github.com/users/rebmullin/gists{/gist_id}","starred_url":"https://api.github.com/users/rebmullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebmullin/subscriptions","organizations_url":"https://api.github.com/users/rebmullin/orgs","repos_url":"https://api.github.com/users/rebmullin/repos","events_url":"https://api.github.com/users/rebmullin/events{/privacy}","received_events_url":"https://api.github.com/users/rebmullin/received_events","type":"User","site_admin":false},"body":"address issue #3056 \r\n\r\nwith changes - section looks like this now:\r\n![Alt text](https://monosnap.com/image/W3PXHUrot0aO51ZiifOzT1ao9zdiS9.png)\r\n\r\nbefore changes:\r\n<img width=\"987\" alt=\"spring_garden_serenity_by_madonna_ _add-ons_for_firefox\" src=\"https://user-images.githubusercontent.com/1514/39517727-9fee9218-4df8-11e8-89c1-fdd4790611c4.png\">\r\n\r\n@bobsilverberg / @willdurand - can you please take a look? // cc @muffinserearch\r\n\r\n\r\n","created_at":"2018-05-02T15:57:12Z","updated_at":"2018-05-11T00:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0d1f4d852c7c4e737d680352b9493686b82b9ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":711375807,"url":"https://api.github.com/repos/mozilla/addons-frontend/labels/state:%20do%20not%20merge","name":"state: do not merge","color":"ffa500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4914/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4914/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/4914/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-frontend/statuses/fda1f5d81c6fecffb12c8c6f843e6c567e3f0d08","head":{"label":"rebmullin:i-3056-remove-tap-to-preview-btn","ref":"i-3056-remove-tap-to-preview-btn","sha":"fda1f5d81c6fecffb12c8c6f843e6c567e3f0d08","user":{"login":"rebmullin","id":1986001,"avatar_url":"https://avatars2.githubusercontent.com/u/1986001?v=4","gravatar_id":"","url":"https://api.github.com/users/rebmullin","html_url":"https://github.com/rebmullin","followers_url":"https://api.github.com/users/rebmullin/followers","following_url":"https://api.github.com/users/rebmullin/following{/other_user}","gists_url":"https://api.github.com/users/rebmullin/gists{/gist_id}","starred_url":"https://api.github.com/users/rebmullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebmullin/subscriptions","organizations_url":"https://api.github.com/users/rebmullin/orgs","repos_url":"https://api.github.com/users/rebmullin/repos","events_url":"https://api.github.com/users/rebmullin/events{/privacy}","received_events_url":"https://api.github.com/users/rebmullin/received_events","type":"User","site_admin":false},"repo":{"id":127836690,"name":"addons-frontend","full_name":"rebmullin/addons-frontend","owner":{"login":"rebmullin","id":1986001,"avatar_url":"https://avatars2.githubusercontent.com/u/1986001?v=4","gravatar_id":"","url":"https://api.github.com/users/rebmullin","html_url":"https://github.com/rebmullin","followers_url":"https://api.github.com/users/rebmullin/followers","following_url":"https://api.github.com/users/rebmullin/following{/other_user}","gists_url":"https://api.github.com/users/rebmullin/gists{/gist_id}","starred_url":"https://api.github.com/users/rebmullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebmullin/subscriptions","organizations_url":"https://api.github.com/users/rebmullin/orgs","repos_url":"https://api.github.com/users/rebmullin/repos","events_url":"https://api.github.com/users/rebmullin/events{/privacy}","received_events_url":"https://api.github.com/users/rebmullin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rebmullin/addons-frontend","description":"Front-end to complement mozilla/addons-server","fork":true,"url":"https://api.github.com/repos/rebmullin/addons-frontend","forks_url":"https://api.github.com/repos/rebmullin/addons-frontend/forks","keys_url":"https://api.github.com/repos/rebmullin/addons-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rebmullin/addons-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rebmullin/addons-frontend/teams","hooks_url":"https://api.github.com/repos/rebmullin/addons-frontend/hooks","issue_events_url":"https://api.github.com/repos/rebmullin/addons-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/rebmullin/addons-frontend/events","assignees_url":"https://api.github.com/repos/rebmullin/addons-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/rebmullin/addons-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/rebmullin/addons-frontend/tags","blobs_url":"https://api.github.com/repos/rebmullin/addons-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rebmullin/addons-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rebmullin/addons-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/rebmullin/addons-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rebmullin/addons-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/rebmullin/addons-frontend/languages","stargazers_url":"https://api.github.com/repos/rebmullin/addons-frontend/stargazers","contributors_url":"https://api.github.com/repos/rebmullin/addons-frontend/contributors","subscribers_url":"https://api.github.com/repos/rebmullin/addons-frontend/subscribers","subscription_url":"https://api.github.com/repos/rebmullin/addons-frontend/subscription","commits_url":"https://api.github.com/repos/rebmullin/addons-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/rebmullin/addons-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/rebmullin/addons-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/rebmullin/addons-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/rebmullin/addons-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/rebmullin/addons-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rebmullin/addons-frontend/merges","archive_url":"https://api.github.com/repos/rebmullin/addons-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rebmullin/addons-frontend/downloads","issues_url":"https://api.github.com/repos/rebmullin/addons-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/rebmullin/addons-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/rebmullin/addons-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/rebmullin/addons-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rebmullin/addons-frontend/labels{/name}","releases_url":"https://api.github.com/repos/rebmullin/addons-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/rebmullin/addons-frontend/deployments","created_at":"2018-04-03T02:02:39Z","updated_at":"2018-05-03T19:19:11Z","pushed_at":"2018-05-10T13:55:36Z","git_url":"git://github.com/rebmullin/addons-frontend.git","ssh_url":"git@github.com:rebmullin/addons-frontend.git","clone_url":"https://github.com/rebmullin/addons-frontend.git","svn_url":"https://github.com/rebmullin/addons-frontend","homepage":"","size":509938,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"40e7949aafab9e9c225e92dbcc030eb763477180","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":52104368,"name":"addons-frontend","full_name":"mozilla/addons-frontend","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-frontend","description":"Front-end to complement mozilla/addons-server","fork":false,"url":"https://api.github.com/repos/mozilla/addons-frontend","forks_url":"https://api.github.com/repos/mozilla/addons-frontend/forks","keys_url":"https://api.github.com/repos/mozilla/addons-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-frontend/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-frontend/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-frontend/events","assignees_url":"https://api.github.com/repos/mozilla/addons-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-frontend/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-frontend/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-frontend/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-frontend/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-frontend/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-frontend/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-frontend/merges","archive_url":"https://api.github.com/repos/mozilla/addons-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-frontend/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-frontend/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-frontend/deployments","created_at":"2016-02-19T17:25:57Z","updated_at":"2018-05-10T19:31:35Z","pushed_at":"2018-05-10T19:45:21Z","git_url":"git://github.com/mozilla/addons-frontend.git","ssh_url":"git@github.com:mozilla/addons-frontend.git","clone_url":"https://github.com/mozilla/addons-frontend.git","svn_url":"https://github.com/mozilla/addons-frontend","homepage":"","size":510511,"stargazers_count":202,"watchers_count":202,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":136,"mirror_url":null,"archived":false,"open_issues_count":463,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":136,"open_issues":463,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4914"},"html":{"href":"https://github.com/mozilla/addons-frontend/pull/4914"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-frontend/issues/4914"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-frontend/issues/4914/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4914/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4914/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-frontend/statuses/fda1f5d81c6fecffb12c8c6f843e6c567e3f0d08"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rebmullin"}}