{"action":"created","comment":{"url":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls/comments/212927626","pull_request_review_id":149653621,"id":212927626,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjkyNzYyNg==","diff_hunk":"@@ -2,43 +2,46 @@\n PY_FAVORED_VER = 3.5\n PYTHON := $(shell which \"python\")\n ifndef PYTHON\n-    PYTHON := $(shell which \"python3\")\n+PYTHON := $(shell which \"python3\")\n endif\n \n ifndef PYTHON\n-    PYTHON := $(shell which \"python$(PY_FAVORED_VER)\")\n+PYTHON := $(shell which \"python$(PY_FAVORED_VER)\")\n endif\n \n ifndef PYTHON\n-    $(error \"Python is not executable, try to check the PATH environment variable or \\\n-        install python$(PY_FAVORED_VER) package.\")\n+$(error \"Python is not executable, try to check the PATH environment variable or \\\n+install python$(PY_FAVORED_VER) package.\")\n endif # $(shell which \"python\")\n \n PY_CHECK_VERSION := $(shell $(PYTHON) -V)\n \n ifeq \"$(filter $(PY_FAVORED_VER).%, $(PY_CHECK_VERSION))\" \"\"\n-    PYTHON := $(shell which \"python\"$(PY_FAVORED_VER))\n-    ifdef PYTHON\n-        $(error \"Found python$(PY_FAVORED_VER), but it should be set as \\\n-            default interpreter, try to set $(PYTHON) in PATH environment variable.\")\n-    else\n-        $(error \"$(shell python -V):Unsupported python version, only available for Python$(PY_FAVORED_VER).\")\n-    endif\n-endif\n+PYTHON := $(shell which \"python\"$(PY_FAVORED_VER))\n+ifdef PYTHON\n+$(error \"Found python$(PY_FAVORED_VER), but it should be set as \\\n+default interpreter, try to set $(PYTHON) in PATH environment variable.\")\n+else\n+$(error \"$(shell python -V):Unsupported python version, only available for Python$(PY_FAVORED_VER).\")\n+endif # PYTHON\n+endif # \"$(filter ...\n \n # check \"iota\" module in Python installation\n PY_CHECK_MOD_IOTA := $(shell python -c \"import iota\" 2>/dev/null && \\\n                        echo 1 || echo 0)\n-ifneq (\"$(PY_CHECK_MOD_IOTA)\",\"1\")\n-    PIP := $(shell pip -V)\n-    PIP_CHECK_VERSION := $(findstring python 3, $(PIP))\n+ifeq (\"$(PY_CHECK_MOD_IOTA)\",\"0\")\n+PIP := $(shell pip -V && echo 1 || echo 0))\n+PIP_CHECK_VERSION := $(findstring python 3, $(PIP) && echo $@ || echo 0)\n+endif\n+\n+ifneq (\"$(PIP)\", \"1\")\n+$(error \"PIP package doesn't pre-configured, try to install it.\")\n+endif\n \n-ifndef PIP\n-    $(error \"PIP package doesn't pre-configured, try to install it.\")\n+ifeq (\"$(PIP_CHECK_VERSION)\", \"0\")\n+PIP_FAVORED_VER = 3\n endif\n \n-ifndef PIP_CHECK_VERSION\n-    PIP_FAVORED_VER = 3\n+ifeq (\"$(PY_CHECK_MOD_IOTA)\", \"0\")\n+$(error \"PyOTA package doesn't pre-configured, install the latest version: pip$(PIP_FAVORED_VER) install pyota\")","path":"mk/python.mk","position":null,"original_position":64,"commit_id":"e74d2ee9453d5d232eab6ecbdd6dae55793e6b8a","original_commit_id":"98eccb6d4a116427db927abd3a4a72becc15caef","user":{"login":"jserv","id":478921,"node_id":"MDQ6VXNlcjQ3ODkyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/478921?v=4","gravatar_id":"","url":"https://api.github.com/users/jserv","html_url":"https://github.com/jserv","followers_url":"https://api.github.com/users/jserv/followers","following_url":"https://api.github.com/users/jserv/following{/other_user}","gists_url":"https://api.github.com/users/jserv/gists{/gist_id}","starred_url":"https://api.github.com/users/jserv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jserv/subscriptions","organizations_url":"https://api.github.com/users/jserv/orgs","repos_url":"https://api.github.com/users/jserv/repos","events_url":"https://api.github.com/users/jserv/events{/privacy}","received_events_url":"https://api.github.com/users/jserv/received_events","type":"User","site_admin":false},"body":"Using `pip` is not the only way to install Python packages. Sometimes, package maintainer might prepare prebuilt one or recipes that describe how to install Python packages. You can leave the message: \"please ask your administrator to install the package 'pyota' or build from source: https://github.com/iotaledger/iota.lib.py\"","created_at":"2018-08-27T10:07:16Z","updated_at":"2018-08-27T10:07:16Z","html_url":"https://github.com/yillkid/iota-swarm-node/pull/25#discussion_r212927626","pull_request_url":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls/25","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls/comments/212927626"},"html":{"href":"https://github.com/yillkid/iota-swarm-node/pull/25#discussion_r212927626"},"pull_request":{"href":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls/25"}},"in_reply_to_id":212926175},"pull_request":{"url":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls/25","id":209314349,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzE0MzQ5","html_url":"https://github.com/yillkid/iota-swarm-node/pull/25","diff_url":"https://github.com/yillkid/iota-swarm-node/pull/25.diff","patch_url":"https://github.com/yillkid/iota-swarm-node/pull/25.patch","issue_url":"https://api.github.com/repos/yillkid/iota-swarm-node/issues/25","number":25,"state":"open","locked":false,"title":"Perform sanity checks with Python3","user":{"login":"yillkid","id":185872,"node_id":"MDQ6VXNlcjE4NTg3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/185872?v=4","gravatar_id":"","url":"https://api.github.com/users/yillkid","html_url":"https://github.com/yillkid","followers_url":"https://api.github.com/users/yillkid/followers","following_url":"https://api.github.com/users/yillkid/following{/other_user}","gists_url":"https://api.github.com/users/yillkid/gists{/gist_id}","starred_url":"https://api.github.com/users/yillkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yillkid/subscriptions","organizations_url":"https://api.github.com/users/yillkid/orgs","repos_url":"https://api.github.com/users/yillkid/repos","events_url":"https://api.github.com/users/yillkid/events{/privacy}","received_events_url":"https://api.github.com/users/yillkid/received_events","type":"User","site_admin":false},"body":"Switch test suites invocation to Python3.","created_at":"2018-08-18T14:24:40Z","updated_at":"2018-08-27T10:07:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12508d37324596cd586d591f9fb09a0dd8a287f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls/25/commits","review_comments_url":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls/25/comments","review_comment_url":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yillkid/iota-swarm-node/issues/25/comments","statuses_url":"https://api.github.com/repos/yillkid/iota-swarm-node/statuses/e74d2ee9453d5d232eab6ecbdd6dae55793e6b8a","head":{"label":"yillkid:dev","ref":"dev","sha":"e74d2ee9453d5d232eab6ecbdd6dae55793e6b8a","user":{"login":"yillkid","id":185872,"node_id":"MDQ6VXNlcjE4NTg3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/185872?v=4","gravatar_id":"","url":"https://api.github.com/users/yillkid","html_url":"https://github.com/yillkid","followers_url":"https://api.github.com/users/yillkid/followers","following_url":"https://api.github.com/users/yillkid/following{/other_user}","gists_url":"https://api.github.com/users/yillkid/gists{/gist_id}","starred_url":"https://api.github.com/users/yillkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yillkid/subscriptions","organizations_url":"https://api.github.com/users/yillkid/orgs","repos_url":"https://api.github.com/users/yillkid/repos","events_url":"https://api.github.com/users/yillkid/events{/privacy}","received_events_url":"https://api.github.com/users/yillkid/received_events","type":"User","site_admin":false},"repo":{"id":126797974,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY3OTc5NzQ=","name":"iota-swarm-node","full_name":"yillkid/iota-swarm-node","owner":{"login":"yillkid","id":185872,"node_id":"MDQ6VXNlcjE4NTg3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/185872?v=4","gravatar_id":"","url":"https://api.github.com/users/yillkid","html_url":"https://github.com/yillkid","followers_url":"https://api.github.com/users/yillkid/followers","following_url":"https://api.github.com/users/yillkid/following{/other_user}","gists_url":"https://api.github.com/users/yillkid/gists{/gist_id}","starred_url":"https://api.github.com/users/yillkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yillkid/subscriptions","organizations_url":"https://api.github.com/users/yillkid/orgs","repos_url":"https://api.github.com/users/yillkid/repos","events_url":"https://api.github.com/users/yillkid/events{/privacy}","received_events_url":"https://api.github.com/users/yillkid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yillkid/iota-swarm-node","description":"IOTA Swarm node Reference Implementation","fork":false,"url":"https://api.github.com/repos/yillkid/iota-swarm-node","forks_url":"https://api.github.com/repos/yillkid/iota-swarm-node/forks","keys_url":"https://api.github.com/repos/yillkid/iota-swarm-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yillkid/iota-swarm-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yillkid/iota-swarm-node/teams","hooks_url":"https://api.github.com/repos/yillkid/iota-swarm-node/hooks","issue_events_url":"https://api.github.com/repos/yillkid/iota-swarm-node/issues/events{/number}","events_url":"https://api.github.com/repos/yillkid/iota-swarm-node/events","assignees_url":"https://api.github.com/repos/yillkid/iota-swarm-node/assignees{/user}","branches_url":"https://api.github.com/repos/yillkid/iota-swarm-node/branches{/branch}","tags_url":"https://api.github.com/repos/yillkid/iota-swarm-node/tags","blobs_url":"https://api.github.com/repos/yillkid/iota-swarm-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yillkid/iota-swarm-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yillkid/iota-swarm-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/yillkid/iota-swarm-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yillkid/iota-swarm-node/statuses/{sha}","languages_url":"https://api.github.com/repos/yillkid/iota-swarm-node/languages","stargazers_url":"https://api.github.com/repos/yillkid/iota-swarm-node/stargazers","contributors_url":"https://api.github.com/repos/yillkid/iota-swarm-node/contributors","subscribers_url":"https://api.github.com/repos/yillkid/iota-swarm-node/subscribers","subscription_url":"https://api.github.com/repos/yillkid/iota-swarm-node/subscription","commits_url":"https://api.github.com/repos/yillkid/iota-swarm-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/yillkid/iota-swarm-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/yillkid/iota-swarm-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/yillkid/iota-swarm-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/yillkid/iota-swarm-node/contents/{+path}","compare_url":"https://api.github.com/repos/yillkid/iota-swarm-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yillkid/iota-swarm-node/merges","archive_url":"https://api.github.com/repos/yillkid/iota-swarm-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yillkid/iota-swarm-node/downloads","issues_url":"https://api.github.com/repos/yillkid/iota-swarm-node/issues{/number}","pulls_url":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls{/number}","milestones_url":"https://api.github.com/repos/yillkid/iota-swarm-node/milestones{/number}","notifications_url":"https://api.github.com/repos/yillkid/iota-swarm-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yillkid/iota-swarm-node/labels{/name}","releases_url":"https://api.github.com/repos/yillkid/iota-swarm-node/releases{/id}","deployments_url":"https://api.github.com/repos/yillkid/iota-swarm-node/deployments","created_at":"2018-03-26T08:31:44Z","updated_at":"2018-08-27T09:11:53Z","pushed_at":"2018-08-27T10:00:58Z","git_url":"git://github.com/yillkid/iota-swarm-node.git","ssh_url":"git@github.com:yillkid/iota-swarm-node.git","clone_url":"https://github.com/yillkid/iota-swarm-node.git","svn_url":"https://github.com/yillkid/iota-swarm-node","homepage":"","size":89,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":7,"watchers":10,"default_branch":"master"}},"base":{"label":"yillkid:master","ref":"master","sha":"167f89e15b6f9ba925e833b924005efbbb0ce248","user":{"login":"yillkid","id":185872,"node_id":"MDQ6VXNlcjE4NTg3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/185872?v=4","gravatar_id":"","url":"https://api.github.com/users/yillkid","html_url":"https://github.com/yillkid","followers_url":"https://api.github.com/users/yillkid/followers","following_url":"https://api.github.com/users/yillkid/following{/other_user}","gists_url":"https://api.github.com/users/yillkid/gists{/gist_id}","starred_url":"https://api.github.com/users/yillkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yillkid/subscriptions","organizations_url":"https://api.github.com/users/yillkid/orgs","repos_url":"https://api.github.com/users/yillkid/repos","events_url":"https://api.github.com/users/yillkid/events{/privacy}","received_events_url":"https://api.github.com/users/yillkid/received_events","type":"User","site_admin":false},"repo":{"id":126797974,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY3OTc5NzQ=","name":"iota-swarm-node","full_name":"yillkid/iota-swarm-node","owner":{"login":"yillkid","id":185872,"node_id":"MDQ6VXNlcjE4NTg3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/185872?v=4","gravatar_id":"","url":"https://api.github.com/users/yillkid","html_url":"https://github.com/yillkid","followers_url":"https://api.github.com/users/yillkid/followers","following_url":"https://api.github.com/users/yillkid/following{/other_user}","gists_url":"https://api.github.com/users/yillkid/gists{/gist_id}","starred_url":"https://api.github.com/users/yillkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yillkid/subscriptions","organizations_url":"https://api.github.com/users/yillkid/orgs","repos_url":"https://api.github.com/users/yillkid/repos","events_url":"https://api.github.com/users/yillkid/events{/privacy}","received_events_url":"https://api.github.com/users/yillkid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yillkid/iota-swarm-node","description":"IOTA Swarm node Reference Implementation","fork":false,"url":"https://api.github.com/repos/yillkid/iota-swarm-node","forks_url":"https://api.github.com/repos/yillkid/iota-swarm-node/forks","keys_url":"https://api.github.com/repos/yillkid/iota-swarm-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yillkid/iota-swarm-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yillkid/iota-swarm-node/teams","hooks_url":"https://api.github.com/repos/yillkid/iota-swarm-node/hooks","issue_events_url":"https://api.github.com/repos/yillkid/iota-swarm-node/issues/events{/number}","events_url":"https://api.github.com/repos/yillkid/iota-swarm-node/events","assignees_url":"https://api.github.com/repos/yillkid/iota-swarm-node/assignees{/user}","branches_url":"https://api.github.com/repos/yillkid/iota-swarm-node/branches{/branch}","tags_url":"https://api.github.com/repos/yillkid/iota-swarm-node/tags","blobs_url":"https://api.github.com/repos/yillkid/iota-swarm-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yillkid/iota-swarm-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yillkid/iota-swarm-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/yillkid/iota-swarm-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yillkid/iota-swarm-node/statuses/{sha}","languages_url":"https://api.github.com/repos/yillkid/iota-swarm-node/languages","stargazers_url":"https://api.github.com/repos/yillkid/iota-swarm-node/stargazers","contributors_url":"https://api.github.com/repos/yillkid/iota-swarm-node/contributors","subscribers_url":"https://api.github.com/repos/yillkid/iota-swarm-node/subscribers","subscription_url":"https://api.github.com/repos/yillkid/iota-swarm-node/subscription","commits_url":"https://api.github.com/repos/yillkid/iota-swarm-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/yillkid/iota-swarm-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/yillkid/iota-swarm-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/yillkid/iota-swarm-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/yillkid/iota-swarm-node/contents/{+path}","compare_url":"https://api.github.com/repos/yillkid/iota-swarm-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yillkid/iota-swarm-node/merges","archive_url":"https://api.github.com/repos/yillkid/iota-swarm-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yillkid/iota-swarm-node/downloads","issues_url":"https://api.github.com/repos/yillkid/iota-swarm-node/issues{/number}","pulls_url":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls{/number}","milestones_url":"https://api.github.com/repos/yillkid/iota-swarm-node/milestones{/number}","notifications_url":"https://api.github.com/repos/yillkid/iota-swarm-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yillkid/iota-swarm-node/labels{/name}","releases_url":"https://api.github.com/repos/yillkid/iota-swarm-node/releases{/id}","deployments_url":"https://api.github.com/repos/yillkid/iota-swarm-node/deployments","created_at":"2018-03-26T08:31:44Z","updated_at":"2018-08-27T09:11:53Z","pushed_at":"2018-08-27T10:00:58Z","git_url":"git://github.com/yillkid/iota-swarm-node.git","ssh_url":"git@github.com:yillkid/iota-swarm-node.git","clone_url":"https://github.com/yillkid/iota-swarm-node.git","svn_url":"https://github.com/yillkid/iota-swarm-node","homepage":"","size":89,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":7,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls/25"},"html":{"href":"https://github.com/yillkid/iota-swarm-node/pull/25"},"issue":{"href":"https://api.github.com/repos/yillkid/iota-swarm-node/issues/25"},"comments":{"href":"https://api.github.com/repos/yillkid/iota-swarm-node/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yillkid/iota-swarm-node/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/yillkid/iota-swarm-node/statuses/e74d2ee9453d5d232eab6ecbdd6dae55793e6b8a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jserv"}}