{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/20491","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20491/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20491/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20491/events","html_url":"https://github.com/joomla/joomla-cms/pull/20491","id":324660294,"number":20491,"title":"[4.0] httpheaders Implement the suggestion by @brianteeman","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars2.githubusercontent.com/u/2596554?v=4","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"labels":[{"id":444033883,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-19T21:03:55Z","updated_at":"2018-05-19T21:59:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20491","html_url":"https://github.com/joomla/joomla-cms/pull/20491","diff_url":"https://github.com/joomla/joomla-cms/pull/20491.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/20491.patch"},"body":"### Summary of Changes\r\n\r\nImplement the list suggested by @brianteeman \r\n\r\n### Testing Instructions\r\n\r\nConfirm that the custom headers are working\r\n\r\n### Expected result\r\n\r\ncustom headers are working\r\n\r\n### Actual result\r\n\r\ncustom headers are not working\r\n\r\n### Note\r\n\r\n@brianteeman please suggest the language changes. Maybe dropping the description completely?\r\n\r\nAnd please tell me which strings from here: https://github.com/joomla/joomla-cms/pull/20459 do you want to keep or change. I'm happy to implement."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/390435465","html_url":"https://github.com/joomla/joomla-cms/pull/20491#issuecomment-390435465","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20491","id":390435465,"user":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars3.githubusercontent.com/u/1296369?v=4","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"created_at":"2018-05-19T21:59:06Z","updated_at":"2018-05-19T21:59:06Z","author_association":"CONTRIBUTOR","body":"Not sure if its my branch but I am now missing some strings. Can you check please\r\n\r\nWe don't need the PLG_SYSTEM_HTTPHEADERS_ADDITIONAL_HEADER_DESC anymore and all the strings for the options can go as well as things like X-XSS-Protection should not be translated.\r\n\r\nFinally can you change the name to System HTTP Headers - we have a space bar on an english keybard :)\r\n "}}
{"actor":{"display_login":"brianteeman"}}