{"action":"created","comment":{"url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/comments/204852039","pull_request_review_id":139994678,"id":204852039,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDg1MjAzOQ==","diff_hunk":"@@ -115,3 +118,19 @@ def write_headers(merged_header, file_path):\n   \"\"\"Writes a PCollection of ``VcfHeader`` to location ``file_path``.\"\"\"\n   _ = (merged_header | 'WriteHeaders' >>\n        vcf_header_io.WriteVcfHeaders(file_path))\n+\n+\n+def _raise_error_on_unrecognized_flags(pipeline_args):\n+  # type: (List[str]) -> None\n+  \"\"\"Raises an error if there are unrecognized flags.\"\"\"\n+  options = pipeline_options.PipelineOptions(pipeline_args).get_all_options()\n+  for flag in _get_flag_names(pipeline_args):\n+    if not any(str.startswith(option, flag) for option in options):","path":"gcp_variant_transforms/vcf_to_bq_common.py","position":null,"original_position":35,"commit_id":"da70fd8e9b4f05d9f56c33331d3aca1f871d8a3f","original_commit_id":"b8474dff0d90043ba901f74282cb5f4f3201e94d","user":{"login":"allieychen","id":36679499,"node_id":"MDQ6VXNlcjM2Njc5NDk5","avatar_url":"https://avatars0.githubusercontent.com/u/36679499?v=4","gravatar_id":"","url":"https://api.github.com/users/allieychen","html_url":"https://github.com/allieychen","followers_url":"https://api.github.com/users/allieychen/followers","following_url":"https://api.github.com/users/allieychen/following{/other_user}","gists_url":"https://api.github.com/users/allieychen/gists{/gist_id}","starred_url":"https://api.github.com/users/allieychen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allieychen/subscriptions","organizations_url":"https://api.github.com/users/allieychen/orgs","repos_url":"https://api.github.com/users/allieychen/repos","events_url":"https://api.github.com/users/allieychen/events{/privacy}","received_events_url":"https://api.github.com/users/allieychen/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-07-24T17:52:02Z","updated_at":"2018-07-24T17:55:50Z","html_url":"https://github.com/googlegenomics/gcp-variant-transforms/pull/302#discussion_r204852039","pull_request_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/302","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/comments/204852039"},"html":{"href":"https://github.com/googlegenomics/gcp-variant-transforms/pull/302#discussion_r204852039"},"pull_request":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/302"}},"in_reply_to_id":204788523},"pull_request":{"url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/302","id":203523792,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTIzNzky","html_url":"https://github.com/googlegenomics/gcp-variant-transforms/pull/302","diff_url":"https://github.com/googlegenomics/gcp-variant-transforms/pull/302.diff","patch_url":"https://github.com/googlegenomics/gcp-variant-transforms/pull/302.patch","issue_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/302","number":302,"state":"open","locked":false,"title":"raise error on unknown flags  #205","user":{"login":"allieychen","id":36679499,"node_id":"MDQ6VXNlcjM2Njc5NDk5","avatar_url":"https://avatars0.githubusercontent.com/u/36679499?v=4","gravatar_id":"","url":"https://api.github.com/users/allieychen","html_url":"https://github.com/allieychen","followers_url":"https://api.github.com/users/allieychen/followers","following_url":"https://api.github.com/users/allieychen/following{/other_user}","gists_url":"https://api.github.com/users/allieychen/gists{/gist_id}","starred_url":"https://api.github.com/users/allieychen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allieychen/subscriptions","organizations_url":"https://api.github.com/users/allieychen/orgs","repos_url":"https://api.github.com/users/allieychen/repos","events_url":"https://api.github.com/users/allieychen/events{/privacy}","received_events_url":"https://api.github.com/users/allieychen/received_events","type":"User","site_admin":false},"body":"Raise an error and fail the pipeline if there are unrecognized flags.\r\n\r\nIssue: [#205](https://github.com/googlegenomics/gcp-variant-transforms/issues/205)\r\nTested: unit tests & integration tests\r\n","created_at":"2018-07-24T13:18:37Z","updated_at":"2018-07-24T17:55:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fa692e57f2e57e0e1c8079af29921bf2ba8595c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/302/commits","review_comments_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/302/comments","review_comment_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/302/comments","statuses_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/statuses/da70fd8e9b4f05d9f56c33331d3aca1f871d8a3f","head":{"label":"allieychen:error-input","ref":"error-input","sha":"da70fd8e9b4f05d9f56c33331d3aca1f871d8a3f","user":{"login":"allieychen","id":36679499,"node_id":"MDQ6VXNlcjM2Njc5NDk5","avatar_url":"https://avatars0.githubusercontent.com/u/36679499?v=4","gravatar_id":"","url":"https://api.github.com/users/allieychen","html_url":"https://github.com/allieychen","followers_url":"https://api.github.com/users/allieychen/followers","following_url":"https://api.github.com/users/allieychen/following{/other_user}","gists_url":"https://api.github.com/users/allieychen/gists{/gist_id}","starred_url":"https://api.github.com/users/allieychen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allieychen/subscriptions","organizations_url":"https://api.github.com/users/allieychen/orgs","repos_url":"https://api.github.com/users/allieychen/repos","events_url":"https://api.github.com/users/allieychen/events{/privacy}","received_events_url":"https://api.github.com/users/allieychen/received_events","type":"User","site_admin":false},"repo":{"id":122504365,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1MDQzNjU=","name":"gcp-variant-transforms","full_name":"allieychen/gcp-variant-transforms","owner":{"login":"allieychen","id":36679499,"node_id":"MDQ6VXNlcjM2Njc5NDk5","avatar_url":"https://avatars0.githubusercontent.com/u/36679499?v=4","gravatar_id":"","url":"https://api.github.com/users/allieychen","html_url":"https://github.com/allieychen","followers_url":"https://api.github.com/users/allieychen/followers","following_url":"https://api.github.com/users/allieychen/following{/other_user}","gists_url":"https://api.github.com/users/allieychen/gists{/gist_id}","starred_url":"https://api.github.com/users/allieychen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allieychen/subscriptions","organizations_url":"https://api.github.com/users/allieychen/orgs","repos_url":"https://api.github.com/users/allieychen/repos","events_url":"https://api.github.com/users/allieychen/events{/privacy}","received_events_url":"https://api.github.com/users/allieychen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/allieychen/gcp-variant-transforms","description":"GCP Variant Transforms","fork":true,"url":"https://api.github.com/repos/allieychen/gcp-variant-transforms","forks_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/forks","keys_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/teams","hooks_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/hooks","issue_events_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/issues/events{/number}","events_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/events","assignees_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/assignees{/user}","branches_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/branches{/branch}","tags_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/tags","blobs_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/statuses/{sha}","languages_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/languages","stargazers_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/stargazers","contributors_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/contributors","subscribers_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/subscribers","subscription_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/subscription","commits_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/contents/{+path}","compare_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/merges","archive_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/downloads","issues_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/issues{/number}","pulls_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/pulls{/number}","milestones_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/milestones{/number}","notifications_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/labels{/name}","releases_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/releases{/id}","deployments_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/deployments","created_at":"2018-02-22T16:28:54Z","updated_at":"2018-05-25T21:19:53Z","pushed_at":"2018-07-24T17:55:22Z","git_url":"git://github.com/allieychen/gcp-variant-transforms.git","ssh_url":"git@github.com:allieychen/gcp-variant-transforms.git","clone_url":"https://github.com/allieychen/gcp-variant-transforms.git","svn_url":"https://github.com/allieychen/gcp-variant-transforms","homepage":null,"size":1629,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlegenomics:master","ref":"master","sha":"87fc4dfa7519f4062c838eb18f9a049c18f6f637","user":{"login":"googlegenomics","id":7434120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzQxMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7434120?v=4","gravatar_id":"","url":"https://api.github.com/users/googlegenomics","html_url":"https://github.com/googlegenomics","followers_url":"https://api.github.com/users/googlegenomics/followers","following_url":"https://api.github.com/users/googlegenomics/following{/other_user}","gists_url":"https://api.github.com/users/googlegenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/googlegenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlegenomics/subscriptions","organizations_url":"https://api.github.com/users/googlegenomics/orgs","repos_url":"https://api.github.com/users/googlegenomics/repos","events_url":"https://api.github.com/users/googlegenomics/events{/privacy}","received_events_url":"https://api.github.com/users/googlegenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":110025283,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwMjUyODM=","name":"gcp-variant-transforms","full_name":"googlegenomics/gcp-variant-transforms","owner":{"login":"googlegenomics","id":7434120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzQxMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7434120?v=4","gravatar_id":"","url":"https://api.github.com/users/googlegenomics","html_url":"https://github.com/googlegenomics","followers_url":"https://api.github.com/users/googlegenomics/followers","following_url":"https://api.github.com/users/googlegenomics/following{/other_user}","gists_url":"https://api.github.com/users/googlegenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/googlegenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlegenomics/subscriptions","organizations_url":"https://api.github.com/users/googlegenomics/orgs","repos_url":"https://api.github.com/users/googlegenomics/repos","events_url":"https://api.github.com/users/googlegenomics/events{/privacy}","received_events_url":"https://api.github.com/users/googlegenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlegenomics/gcp-variant-transforms","description":"GCP Variant Transforms","fork":false,"url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms","forks_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/forks","keys_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/teams","hooks_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/hooks","issue_events_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/events{/number}","events_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/events","assignees_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/assignees{/user}","branches_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/branches{/branch}","tags_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/tags","blobs_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/statuses/{sha}","languages_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/languages","stargazers_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/stargazers","contributors_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/contributors","subscribers_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/subscribers","subscription_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/subscription","commits_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/contents/{+path}","compare_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/merges","archive_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/downloads","issues_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues{/number}","pulls_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls{/number}","milestones_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/milestones{/number}","notifications_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/labels{/name}","releases_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/releases{/id}","deployments_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/deployments","created_at":"2017-11-08T20:12:08Z","updated_at":"2018-07-24T16:26:47Z","pushed_at":"2018-07-24T17:55:24Z","git_url":"git://github.com/googlegenomics/gcp-variant-transforms.git","ssh_url":"git@github.com:googlegenomics/gcp-variant-transforms.git","clone_url":"https://github.com/googlegenomics/gcp-variant-transforms.git","svn_url":"https://github.com/googlegenomics/gcp-variant-transforms","homepage":null,"size":1630,"stargazers_count":36,"watchers_count":36,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":54,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/302"},"html":{"href":"https://github.com/googlegenomics/gcp-variant-transforms/pull/302"},"issue":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/302"},"comments":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/statuses/da70fd8e9b4f05d9f56c33331d3aca1f871d8a3f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"allieychen"}}