{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65198","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65198/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65198/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65198/events","html_url":"https://github.com/kubernetes/kubernetes/pull/65198","id":333437597,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjUwNjIw","number":65198,"title":"GCE PD: Resolving disk name collisions","user":{"login":"verult","id":1689416,"node_id":"MDQ6VXNlcjE2ODk0MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1689416?v=4","gravatar_id":"","url":"https://api.github.com/users/verult","html_url":"https://github.com/verult","followers_url":"https://api.github.com/users/verult/followers","following_url":"https://api.github.com/users/verult/following{/other_user}","gists_url":"https://api.github.com/users/verult/gists{/gist_id}","starred_url":"https://api.github.com/users/verult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verult/subscriptions","organizations_url":"https://api.github.com/users/verult/orgs","repos_url":"https://api.github.com/users/verult/repos","events_url":"https://api.github.com/users/verult/events{/privacy}","received_events_url":"https://api.github.com/users/verult/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687565804,"node_id":"MDU6TGFiZWw2ODc1NjU4MDQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":354968448,"node_id":"MDU6TGFiZWwzNTQ5Njg0NDg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-action-required","name":"release-note-action-required","color":"c2e0c6","default":false},{"id":958178286,"node_id":"MDU6TGFiZWw5NTgxNzgyODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cloud-provider","name":"sig/cloud-provider","color":"d2b48c","default":false},{"id":679979244,"node_id":"MDU6TGFiZWw2Nzk5NzkyNDQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/gcp","name":"sig/gcp","color":"d2b48c","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"assignees":[{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-06-18T21:15:26Z","updated_at":"2018-09-04T00:42:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65198","html_url":"https://github.com/kubernetes/kubernetes/pull/65198","diff_url":"https://github.com/kubernetes/kubernetes/pull/65198.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/65198.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**: Eliminates problems with disk name collisions across zones and between zonal and regional PD.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #65126\r\n\r\n**Special notes for your reviewer**:\r\nThese are the categories of the largest changes:\r\n* Updating the Deleter to support disk identification by both name and zone\r\n* Updating the device name format to differentiate between zonal and regional disks. This change affects most of the volume functions like Attach, MountDevice, DisksAreAttached, etc.\r\n* Zone & region label generation logic\r\n\r\nThere's a major component missing: supporting upgrade and downgrade scenarios. This will be done in a separate PR.\r\n\r\nA noteworthy refactor I did is consolidating the different kinds of DiskNotFound errors into one, in order to fix a bug I discovered along the way.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n[Action Required] This impacts clusters running on GCE VMs only. Device names for GCE Regional PDs now have a different format. Upon node upgrade, VM instances with GCE PD volumes attached through Kubernetes must be restarted.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/418210583","html_url":"https://github.com/kubernetes/kubernetes/pull/65198#issuecomment-418210583","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65198","id":418210583,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODIxMDU4Mw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-09-04T00:42:18Z","updated_at":"2018-09-04T00:42:18Z","author_association":"NONE","body":"@verult: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-gce | a095077ef697a53c5c1bc8050961c55aa504c03a | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/65198/pull-kubernetes-e2e-gce/51506/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-kops-aws | a095077ef697a53c5c1bc8050961c55aa504c03a | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/65198/pull-kubernetes-e2e-kops-aws/104748/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-bazel-test | a095077ef697a53c5c1bc8050961c55aa504c03a | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/65198/pull-kubernetes-bazel-test/59382/) | `/test pull-kubernetes-bazel-test`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/65198). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/verult). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}