{"action":"created","comment":{"url":"https://api.github.com/repos/vaadin/spring/pulls/comments/192999884","pull_request_review_id":125881605,"id":192999884,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjk5OTg4NA==","diff_hunk":"@@ -29,30 +34,41 @@\n import com.vaadin.flow.server.VaadinServlet;\n import com.vaadin.flow.server.VaadinServletService;\n import com.vaadin.flow.server.VaadinSession;\n+import com.vaadin.flow.server.WebBrowser;\n import com.vaadin.flow.shared.Registration;\n+import com.vaadin.flow.theme.AbstractTheme;\n \n /**\n  * Spring application context aware Vaadin servlet service implementation.\n  *\n  * @author Vaadin Ltd\n- *\n  */\n public class SpringVaadinServletService extends VaadinServletService {\n \n     private final ApplicationContext context;\n \n     private final Registration serviceDestroyRegistration;\n \n+    public static boolean isClassnameAvailable(String clazzName) {\n+        try {\n+            Class.forName(clazzName, false,\n+                    SpringVaadinServletService.class.getClassLoader());\n+        } catch (LinkageError | ClassNotFoundException e) {","path":"vaadin-spring/src/main/java/com/vaadin/flow/spring/SpringVaadinServletService.java","position":41,"original_position":41,"commit_id":"5c9df635d25c4f92ab28d1f02d7511ab332e127b","original_commit_id":"5c9df635d25c4f92ab28d1f02d7511ab332e127b","user":{"login":"vaadin-bot","id":20280877,"node_id":"MDQ6VXNlcjIwMjgwODc3","avatar_url":"https://avatars1.githubusercontent.com/u/20280877?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin-bot","html_url":"https://github.com/vaadin-bot","followers_url":"https://api.github.com/users/vaadin-bot/followers","following_url":"https://api.github.com/users/vaadin-bot/following{/other_user}","gists_url":"https://api.github.com/users/vaadin-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin-bot/subscriptions","organizations_url":"https://api.github.com/users/vaadin-bot/orgs","repos_url":"https://api.github.com/users/vaadin-bot/repos","events_url":"https://api.github.com/users/vaadin-bot/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin-bot/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Either log or rethrow this exception. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1166)\n","created_at":"2018-06-05T09:09:37Z","updated_at":"2018-06-05T09:09:38Z","html_url":"https://github.com/vaadin/spring/pull/317#discussion_r192999884","pull_request_url":"https://api.github.com/repos/vaadin/spring/pulls/317","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/vaadin/spring/pulls/comments/192999884"},"html":{"href":"https://github.com/vaadin/spring/pull/317#discussion_r192999884"},"pull_request":{"href":"https://api.github.com/repos/vaadin/spring/pulls/317"}}},"pull_request":{"url":"https://api.github.com/repos/vaadin/spring/pulls/317","id":192601863,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNjAxODYz","html_url":"https://github.com/vaadin/spring/pull/317","diff_url":"https://github.com/vaadin/spring/pull/317.diff","patch_url":"https://github.com/vaadin/spring/pull/317.patch","issue_url":"https://api.github.com/repos/vaadin/spring/issues/317","number":317,"state":"open","locked":false,"title":"The spring servlet can now handle spring type resources.","user":{"login":"caalador","id":2726090,"node_id":"MDQ6VXNlcjI3MjYwOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2726090?v=4","gravatar_id":"","url":"https://api.github.com/users/caalador","html_url":"https://github.com/caalador","followers_url":"https://api.github.com/users/caalador/followers","following_url":"https://api.github.com/users/caalador/following{/other_user}","gists_url":"https://api.github.com/users/caalador/gists{/gist_id}","starred_url":"https://api.github.com/users/caalador/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caalador/subscriptions","organizations_url":"https://api.github.com/users/caalador/orgs","repos_url":"https://api.github.com/users/caalador/repos","events_url":"https://api.github.com/users/caalador/events{/privacy}","received_events_url":"https://api.github.com/users/caalador/received_events","type":"User","site_admin":false},"body":"This will enable us to package spring-boot as a jar.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/spring/317)\n<!-- Reviewable:end -->\n","created_at":"2018-06-05T06:26:40Z","updated_at":"2018-06-05T09:09:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46da4e3df4df973c5b9fb0eb92009a48fd0fbca3","assignee":{"login":"caalador","id":2726090,"node_id":"MDQ6VXNlcjI3MjYwOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2726090?v=4","gravatar_id":"","url":"https://api.github.com/users/caalador","html_url":"https://github.com/caalador","followers_url":"https://api.github.com/users/caalador/followers","following_url":"https://api.github.com/users/caalador/following{/other_user}","gists_url":"https://api.github.com/users/caalador/gists{/gist_id}","starred_url":"https://api.github.com/users/caalador/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caalador/subscriptions","organizations_url":"https://api.github.com/users/caalador/orgs","repos_url":"https://api.github.com/users/caalador/repos","events_url":"https://api.github.com/users/caalador/events{/privacy}","received_events_url":"https://api.github.com/users/caalador/received_events","type":"User","site_admin":false},"assignees":[{"login":"caalador","id":2726090,"node_id":"MDQ6VXNlcjI3MjYwOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2726090?v=4","gravatar_id":"","url":"https://api.github.com/users/caalador","html_url":"https://github.com/caalador","followers_url":"https://api.github.com/users/caalador/followers","following_url":"https://api.github.com/users/caalador/following{/other_user}","gists_url":"https://api.github.com/users/caalador/gists{/gist_id}","starred_url":"https://api.github.com/users/caalador/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caalador/subscriptions","organizations_url":"https://api.github.com/users/caalador/orgs","repos_url":"https://api.github.com/users/caalador/repos","events_url":"https://api.github.com/users/caalador/events{/privacy}","received_events_url":"https://api.github.com/users/caalador/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vaadin/spring/pulls/317/commits","review_comments_url":"https://api.github.com/repos/vaadin/spring/pulls/317/comments","review_comment_url":"https://api.github.com/repos/vaadin/spring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vaadin/spring/issues/317/comments","statuses_url":"https://api.github.com/repos/vaadin/spring/statuses/5c9df635d25c4f92ab28d1f02d7511ab332e127b","head":{"label":"vaadin:issues/spring_resources","ref":"issues/spring_resources","sha":"5c9df635d25c4f92ab28d1f02d7511ab332e127b","user":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":30295072,"node_id":"MDEwOlJlcG9zaXRvcnkzMDI5NTA3Mg==","name":"spring","full_name":"vaadin/spring","owner":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/spring","description":"Spring integration for Vaadin","fork":false,"url":"https://api.github.com/repos/vaadin/spring","forks_url":"https://api.github.com/repos/vaadin/spring/forks","keys_url":"https://api.github.com/repos/vaadin/spring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/spring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/spring/teams","hooks_url":"https://api.github.com/repos/vaadin/spring/hooks","issue_events_url":"https://api.github.com/repos/vaadin/spring/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/spring/events","assignees_url":"https://api.github.com/repos/vaadin/spring/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/spring/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/spring/tags","blobs_url":"https://api.github.com/repos/vaadin/spring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/spring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/spring/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/spring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/spring/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/spring/languages","stargazers_url":"https://api.github.com/repos/vaadin/spring/stargazers","contributors_url":"https://api.github.com/repos/vaadin/spring/contributors","subscribers_url":"https://api.github.com/repos/vaadin/spring/subscribers","subscription_url":"https://api.github.com/repos/vaadin/spring/subscription","commits_url":"https://api.github.com/repos/vaadin/spring/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/spring/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/spring/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/spring/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/spring/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/spring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/spring/merges","archive_url":"https://api.github.com/repos/vaadin/spring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/spring/downloads","issues_url":"https://api.github.com/repos/vaadin/spring/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/spring/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/spring/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/spring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/spring/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/spring/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/spring/deployments","created_at":"2015-02-04T11:11:27Z","updated_at":"2018-06-01T05:04:14Z","pushed_at":"2018-06-05T09:02:35Z","git_url":"git://github.com/vaadin/spring.git","ssh_url":"git@github.com:vaadin/spring.git","clone_url":"https://github.com/vaadin/spring.git","svn_url":"https://github.com/vaadin/spring","homepage":"https://vaadin.com/start","size":631,"stargazers_count":114,"watchers_count":114,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":81,"license":null,"forks":76,"open_issues":81,"watchers":114,"default_branch":"master"}},"base":{"label":"vaadin:master","ref":"master","sha":"553d8a5d09892dbcbc3b447c37a5babb70444b4c","user":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":30295072,"node_id":"MDEwOlJlcG9zaXRvcnkzMDI5NTA3Mg==","name":"spring","full_name":"vaadin/spring","owner":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/spring","description":"Spring integration for Vaadin","fork":false,"url":"https://api.github.com/repos/vaadin/spring","forks_url":"https://api.github.com/repos/vaadin/spring/forks","keys_url":"https://api.github.com/repos/vaadin/spring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/spring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/spring/teams","hooks_url":"https://api.github.com/repos/vaadin/spring/hooks","issue_events_url":"https://api.github.com/repos/vaadin/spring/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/spring/events","assignees_url":"https://api.github.com/repos/vaadin/spring/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/spring/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/spring/tags","blobs_url":"https://api.github.com/repos/vaadin/spring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/spring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/spring/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/spring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/spring/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/spring/languages","stargazers_url":"https://api.github.com/repos/vaadin/spring/stargazers","contributors_url":"https://api.github.com/repos/vaadin/spring/contributors","subscribers_url":"https://api.github.com/repos/vaadin/spring/subscribers","subscription_url":"https://api.github.com/repos/vaadin/spring/subscription","commits_url":"https://api.github.com/repos/vaadin/spring/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/spring/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/spring/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/spring/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/spring/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/spring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/spring/merges","archive_url":"https://api.github.com/repos/vaadin/spring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/spring/downloads","issues_url":"https://api.github.com/repos/vaadin/spring/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/spring/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/spring/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/spring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/spring/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/spring/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/spring/deployments","created_at":"2015-02-04T11:11:27Z","updated_at":"2018-06-01T05:04:14Z","pushed_at":"2018-06-05T09:02:35Z","git_url":"git://github.com/vaadin/spring.git","ssh_url":"git@github.com:vaadin/spring.git","clone_url":"https://github.com/vaadin/spring.git","svn_url":"https://github.com/vaadin/spring","homepage":"https://vaadin.com/start","size":631,"stargazers_count":114,"watchers_count":114,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":81,"license":null,"forks":76,"open_issues":81,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vaadin/spring/pulls/317"},"html":{"href":"https://github.com/vaadin/spring/pull/317"},"issue":{"href":"https://api.github.com/repos/vaadin/spring/issues/317"},"comments":{"href":"https://api.github.com/repos/vaadin/spring/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/vaadin/spring/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/vaadin/spring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vaadin/spring/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/vaadin/spring/statuses/5c9df635d25c4f92ab28d1f02d7511ab332e127b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vaadin-bot"}}