{"action":"created","issue":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/13261","repository_url":"https://api.github.com/repos/brave/browser-laptop","labels_url":"https://api.github.com/repos/brave/browser-laptop/issues/13261/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/13261/comments","events_url":"https://api.github.com/repos/brave/browser-laptop/issues/13261/events","html_url":"https://github.com/brave/browser-laptop/issues/13261","id":299534262,"number":13261,"title":"bad session state can result in permanently borked profile","user":{"login":"LaurenWags","id":28145373,"avatar_url":"https://avatars1.githubusercontent.com/u/28145373?v=4","gravatar_id":"","url":"https://api.github.com/users/LaurenWags","html_url":"https://github.com/LaurenWags","followers_url":"https://api.github.com/users/LaurenWags/followers","following_url":"https://api.github.com/users/LaurenWags/following{/other_user}","gists_url":"https://api.github.com/users/LaurenWags/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurenWags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurenWags/subscriptions","organizations_url":"https://api.github.com/users/LaurenWags/orgs","repos_url":"https://api.github.com/users/LaurenWags/repos","events_url":"https://api.github.com/users/LaurenWags/events{/privacy}","received_events_url":"https://api.github.com/users/LaurenWags/received_events","type":"User","site_admin":false},"labels":[{"id":739983710,"url":"https://api.github.com/repos/brave/browser-laptop/labels/0.22.x","name":"0.22.x","color":"f9d0c4","default":false},{"id":291742587,"url":"https://api.github.com/repos/brave/browser-laptop/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":{"login":"petemill","id":741836,"avatar_url":"https://avatars1.githubusercontent.com/u/741836?v=4","gravatar_id":"","url":"https://api.github.com/users/petemill","html_url":"https://github.com/petemill","followers_url":"https://api.github.com/users/petemill/followers","following_url":"https://api.github.com/users/petemill/following{/other_user}","gists_url":"https://api.github.com/users/petemill/gists{/gist_id}","starred_url":"https://api.github.com/users/petemill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petemill/subscriptions","organizations_url":"https://api.github.com/users/petemill/orgs","repos_url":"https://api.github.com/users/petemill/repos","events_url":"https://api.github.com/users/petemill/events{/privacy}","received_events_url":"https://api.github.com/users/petemill/received_events","type":"User","site_admin":false},"assignees":[{"login":"petemill","id":741836,"avatar_url":"https://avatars1.githubusercontent.com/u/741836?v=4","gravatar_id":"","url":"https://api.github.com/users/petemill","html_url":"https://github.com/petemill","followers_url":"https://api.github.com/users/petemill/followers","following_url":"https://api.github.com/users/petemill/following{/other_user}","gists_url":"https://api.github.com/users/petemill/gists{/gist_id}","starred_url":"https://api.github.com/users/petemill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petemill/subscriptions","organizations_url":"https://api.github.com/users/petemill/orgs","repos_url":"https://api.github.com/users/petemill/repos","events_url":"https://api.github.com/users/petemill/events{/privacy}","received_events_url":"https://api.github.com/users/petemill/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/78","html_url":"https://github.com/brave/browser-laptop/milestone/78","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/78/labels","id":2639972,"number":78,"title":"0.22.x (Beta Channel)","description":"Tab discarding, Windows are now buffered and open faster, Save/Dialog fixes, EV Certificate status shown, fix Google cookie mismatch, U2F support, IME fixes for international users, Not single-webview 😸 \r\n","creator":{"login":"alexwykoff","id":1434040,"avatar_url":"https://avatars0.githubusercontent.com/u/1434040?v=4","gravatar_id":"","url":"https://api.github.com/users/alexwykoff","html_url":"https://github.com/alexwykoff","followers_url":"https://api.github.com/users/alexwykoff/followers","following_url":"https://api.github.com/users/alexwykoff/following{/other_user}","gists_url":"https://api.github.com/users/alexwykoff/gists{/gist_id}","starred_url":"https://api.github.com/users/alexwykoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexwykoff/subscriptions","organizations_url":"https://api.github.com/users/alexwykoff/orgs","repos_url":"https://api.github.com/users/alexwykoff/repos","events_url":"https://api.github.com/users/alexwykoff/events{/privacy}","received_events_url":"https://api.github.com/users/alexwykoff/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":160,"state":"open","created_at":"2017-07-13T18:49:47Z","updated_at":"2018-03-23T06:16:32Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-02-22T22:37:22Z","updated_at":"2018-03-23T13:20:20Z","closed_at":"2018-03-01T20:07:06Z","author_association":"NONE","body":"<!--\r\nHave you searched for similar issues? We have received a lot of feedback and bug reports that we have closed as duplicates. Before submitting this issue, please visit our community site for common ones: https://community.brave.com/c/common-issues\r\n-->\r\n\r\n### Description\r\nI haven't reproduced yet, but I was following the test plans set out in https://github.com/brave/browser-laptop/pull/11313 for the keyboard shortcuts. I close Brave and reopened near the end to see if my tab order was preserved and that's when I discovered that my profile is borked. I can't reload existing tabs, new windows are useless, my pinned tabs spin, I can't open new tabs.\r\n\r\n\r\n### Steps to Reproduce\r\n<!--\r\nPlease add a series of steps to reproduce the problem. See https://stackoverflow.com/help/mcve for in depth information on how to create a minimal, complete, and verifiable example.\r\n-->\r\nI don't have exact steps yet, I was using a clean profile to follow the test cases in the PR referenced above. Generally this is what I did:\r\n  1.  Clean profile using 0.21.11\r\n  2. Open several tabs with sites. Use keyboard shortcut ctrl+shift+pg up/down to move tabs around.\r\n  3. Open a second window. Repeat step 2.\r\n  4. In second window, pin some of the tabs. Open some new tabs with different sites.\r\n  5. In second window, move pinned tabs around with keyboard shortcut. \r\n  6. In second window, move normal (not pinned) tabs around with keyboard shortcut.\r\n  7. Open prefs, change tab count to 6 per tab page.\r\n  8. Close/Reopen Brave.\r\n\r\n#### Another STR from #13339\r\n(steps 2 and 3 don't seem required to reproduce, and can reproduce on 0.20)\r\n  1. Clean install 0.21.17\r\n  2. Launch browser with `LEDGER_ENVIRONMENT=staging` (not sure if this makes any difference but issue found when launched with this env variable\r\n  3. Enable payments and add some funds\r\n  4. Open a new tab and type a wrong URL ( i had typed http://epcohconverter.com)\r\n  5. Console shows error \r\n  6. Try entering correct URL, doesn't work\r\n  7. Try opening a new tab, doesn't load a new tab\r\n  8. Unable to close browser have to kill the app\r\n\r\n**Actual result:**\r\nProfile borked. Error in console shows:\r\n\r\nUncaught TypeError: Cannot read property 'filterNot' of undefined\r\n    at R (gen/app.entry.js:1)\r\n    at callbacks.forEach (gen/app.entry.js:1)\r\n    at Array.forEach (<anonymous>)\r\n    at Object.dispatchToOwnRegisteredCallbacks (gen/app.entry.js:1)\r\n    at Object.dispatchInternal (gen/app.entry.js:1)\r\n    at n.cargo (gen/app.entry.js:1)\r\n    at Object.process (gen/app.entry.js:1)\r\n    at gen/app.entry.js:1\r\n    at gen/app.entry.js:1\r\n    at gen/lib.devTools.js:1\r\n\r\n\r\n**Expected result:**\r\nProfile should not be borked\r\n\r\n**Reproduces how often:**\r\nUnknown\r\n\r\n\r\n### Brave Version\r\n\r\n**about:brave info:**\r\n0.21.11\r\n\r\n\r\n**Reproducible on current live release:**\r\nyes\r\n\r\n\r\n### Additional Information\r\nI did this with a testing profile, I can provide it if it will be helpful.\r\n"},"comment":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/comments/375662495","html_url":"https://github.com/brave/browser-laptop/issues/13261#issuecomment-375662495","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/13261","id":375662495,"user":{"login":"LaurenWags","id":28145373,"avatar_url":"https://avatars1.githubusercontent.com/u/28145373?v=4","gravatar_id":"","url":"https://api.github.com/users/LaurenWags","html_url":"https://github.com/LaurenWags","followers_url":"https://api.github.com/users/LaurenWags/followers","following_url":"https://api.github.com/users/LaurenWags/following{/other_user}","gists_url":"https://api.github.com/users/LaurenWags/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurenWags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurenWags/subscriptions","organizations_url":"https://api.github.com/users/LaurenWags/orgs","repos_url":"https://api.github.com/users/LaurenWags/repos","events_url":"https://api.github.com/users/LaurenWags/events{/privacy}","received_events_url":"https://api.github.com/users/LaurenWags/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T13:20:20Z","updated_at":"2018-03-23T13:20:20Z","author_association":"NONE","body":"@petemill  - if I launch the borked profile with 0.21.24 it's definitely screwed up as I would expect and when I launch with 0.22.7 all my tabs seem to be restored and functional which is awesome. However, I also get two blank about:error tabs each time I launch the profile in 0.22.7 - no errors in terminal though. Is there somewhere else I can look for information?"}}
{"actor":{"display_login":"LaurenWags"}}