{"action":"created","comment":{"url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls/comments/177788276","pull_request_review_id":107721868,"id":177788276,"diff_hunk":"@@ -0,0 +1,127 @@\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+variable \"tag_service_name\" {\n+  type        = \"string\"\n+  description = \"the name of the service\"\n+}\n+\n+variable \"tag_cluster_role\" {\n+  default     = \"app\"\n+  description = \"primary role/function of the cluster\"\n+}\n+\n+variable \"tag_environment\" {\n+  type        = \"string\"\n+  description = \"the created resources will belong to this infrastructure environment\"\n+}\n+\n+variable \"asg_vpc_zone_identifier\" {\n+  type        = \"list\"\n+  description = \"the created ASGs will spawn instances to these subnet IDs\"\n+}\n+\n+variable \"asg_lb_target_group_arn\" {\n+  type        = \"string\"\n+  description = \"the created ASGs will be attached to this target group\"\n+}\n+\n+variable \"asg_min_capacity\" {\n+  default     = 1\n+  description = \"the created ASGs will have this number of instances at minimum\"\n+}\n+\n+variable \"asg_desired_capacity\" {\n+  type        = \"string\"\n+  description = \"the created ASGs will be spawned initially with this capacity\"\n+}\n+\n+variable \"asg_max_capacity\" {\n+  default     = 5\n+  description = \"the created ASGs will have this number of instances at maximum\"\n+}\n+\n+variable \"asg_wait_timeout\" {\n+  type        = \"string\"\n+  description = \"A maximum duration that Terraform should wait for ASG instances to be healthy before timing out\"\n+}\n+\n+variable \"asg_health_check_type\" {\n+  type        = \"string\"\n+  default     = \"ELB\"\n+  description = \"controls how ASG health checking is done\"\n+}\n+\n+variable \"asg_health_check_grace_period\" {\n+  type        = \"string\"\n+  default     = \"300\"\n+  description = \"Time, in seconds, to wait for new instances before checking their health\"\n+}\n+\n+variable \"asg_service_linked_role_arn\" {\n+  default     = \"\"\n+  description = \"The ARN of the service-linked role that the ASG will use to call other AWS services\"\n+}\n+\n+variable \"asg_termination_policies\" {\n+  default = [\n+    \"OldestLaunchConfiguration\",\n+    \"Default\",\n+  ]\n+\n+  description = \"Specify policies that the auto scaling group should use to terminate its instances\"\n+}\n+\n+variable \"asg_tags\" {\n+  default     = []\n+  description = \"the created ASGs will have these tags\"\n+}\n+\n+variable \"lc_instance_sgs\" {\n+  type        = \"list\"\n+  description = \"the created instances will spawn instances with these security groups\"\n+}\n+\n+variable \"lc_instance_profile\" {\n+  type        = \"string\"\n+  description = \"the created instances will spawn instances with this IAM profile\"\n+}\n+\n+variable \"lc_instance_key_name\" {\n+  default     = \"\"\n+  description = \"the created instances will spawn instances with this SSH key name\"\n+}\n+\n+variable \"lc_instance_type\" {\n+  type        = \"string\"\n+  description = \"the created instances will spawn instances with this type\"\n+}\n+\n+variable \"lc_instance_ami_id\" {\n+  type        = \"string\"\n+  description = \"the created instances will spawn instances with this AMI\"\n+}\n+\n+variable \"lc_instance_monitoring\" {\n+  default     = true\n+  description = \"the created instances will spawn instances with enhanced monitoring if enabled\"\n+}\n+\n+variable \"lc_instance_ebs_optimized\" {\n+  default     = true","path":"variables.tf","position":120,"original_position":120,"commit_id":"4bbf42ea80d0ab997555c3fd9533b4f44c55214d","original_commit_id":"4bbf42ea80d0ab997555c3fd9533b4f44c55214d","user":{"login":"andysaputra","id":36985644,"avatar_url":"https://avatars1.githubusercontent.com/u/36985644?v=4","gravatar_id":"","url":"https://api.github.com/users/andysaputra","html_url":"https://github.com/andysaputra","followers_url":"https://api.github.com/users/andysaputra/followers","following_url":"https://api.github.com/users/andysaputra/following{/other_user}","gists_url":"https://api.github.com/users/andysaputra/gists{/gist_id}","starred_url":"https://api.github.com/users/andysaputra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andysaputra/subscriptions","organizations_url":"https://api.github.com/users/andysaputra/orgs","repos_url":"https://api.github.com/users/andysaputra/repos","events_url":"https://api.github.com/users/andysaputra/events{/privacy}","received_events_url":"https://api.github.com/users/andysaputra/received_events","type":"User","site_admin":false},"body":"any reason why the default is true?","created_at":"2018-03-28T15:20:34Z","updated_at":"2018-03-28T15:20:49Z","html_url":"https://github.com/traveloka/terraform-aws-autoscaling/pull/1#discussion_r177788276","pull_request_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls/comments/177788276"},"html":{"href":"https://github.com/traveloka/terraform-aws-autoscaling/pull/1#discussion_r177788276"},"pull_request":{"href":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls/1","id":177948120,"html_url":"https://github.com/traveloka/terraform-aws-autoscaling/pull/1","diff_url":"https://github.com/traveloka/terraform-aws-autoscaling/pull/1.diff","patch_url":"https://github.com/traveloka/terraform-aws-autoscaling/pull/1.patch","issue_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/issues/1","number":1,"state":"open","locked":false,"title":"First implementation of terraform-aws-autoscaling","user":{"login":"salvianreynaldi","id":5778914,"avatar_url":"https://avatars2.githubusercontent.com/u/5778914?v=4","gravatar_id":"","url":"https://api.github.com/users/salvianreynaldi","html_url":"https://github.com/salvianreynaldi","followers_url":"https://api.github.com/users/salvianreynaldi/followers","following_url":"https://api.github.com/users/salvianreynaldi/following{/other_user}","gists_url":"https://api.github.com/users/salvianreynaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/salvianreynaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salvianreynaldi/subscriptions","organizations_url":"https://api.github.com/users/salvianreynaldi/orgs","repos_url":"https://api.github.com/users/salvianreynaldi/repos","events_url":"https://api.github.com/users/salvianreynaldi/events{/privacy}","received_events_url":"https://api.github.com/users/salvianreynaldi/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-28T07:11:48Z","updated_at":"2018-03-28T15:20:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3261b1e926671893c176c5ac8aa5cb0eff5254e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"site-infra","id":2145466,"slug":"site-infra","description":"Site-Infra Team","privacy":"closed","url":"https://api.github.com/teams/2145466","members_url":"https://api.github.com/teams/2145466/members{/member}","repositories_url":"https://api.github.com/teams/2145466/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls/1/commits","review_comments_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls/1/comments","review_comment_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/issues/1/comments","statuses_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/statuses/4bbf42ea80d0ab997555c3fd9533b4f44c55214d","head":{"label":"salvianreynaldi:first-commit","ref":"first-commit","sha":"4bbf42ea80d0ab997555c3fd9533b4f44c55214d","user":{"login":"salvianreynaldi","id":5778914,"avatar_url":"https://avatars2.githubusercontent.com/u/5778914?v=4","gravatar_id":"","url":"https://api.github.com/users/salvianreynaldi","html_url":"https://github.com/salvianreynaldi","followers_url":"https://api.github.com/users/salvianreynaldi/followers","following_url":"https://api.github.com/users/salvianreynaldi/following{/other_user}","gists_url":"https://api.github.com/users/salvianreynaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/salvianreynaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salvianreynaldi/subscriptions","organizations_url":"https://api.github.com/users/salvianreynaldi/orgs","repos_url":"https://api.github.com/users/salvianreynaldi/repos","events_url":"https://api.github.com/users/salvianreynaldi/events{/privacy}","received_events_url":"https://api.github.com/users/salvianreynaldi/received_events","type":"User","site_admin":false},"repo":{"id":127097373,"name":"terraform-aws-autoscaling","full_name":"salvianreynaldi/terraform-aws-autoscaling","owner":{"login":"salvianreynaldi","id":5778914,"avatar_url":"https://avatars2.githubusercontent.com/u/5778914?v=4","gravatar_id":"","url":"https://api.github.com/users/salvianreynaldi","html_url":"https://github.com/salvianreynaldi","followers_url":"https://api.github.com/users/salvianreynaldi/followers","following_url":"https://api.github.com/users/salvianreynaldi/following{/other_user}","gists_url":"https://api.github.com/users/salvianreynaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/salvianreynaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salvianreynaldi/subscriptions","organizations_url":"https://api.github.com/users/salvianreynaldi/orgs","repos_url":"https://api.github.com/users/salvianreynaldi/repos","events_url":"https://api.github.com/users/salvianreynaldi/events{/privacy}","received_events_url":"https://api.github.com/users/salvianreynaldi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/salvianreynaldi/terraform-aws-autoscaling","description":"A terraform module which provisions an auto scaling group along with its launch configuration","fork":true,"url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling","forks_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/forks","keys_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/teams","hooks_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/hooks","issue_events_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/issues/events{/number}","events_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/events","assignees_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/assignees{/user}","branches_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/branches{/branch}","tags_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/tags","blobs_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/git/refs{/sha}","trees_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/statuses/{sha}","languages_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/languages","stargazers_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/stargazers","contributors_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/contributors","subscribers_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/subscribers","subscription_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/subscription","commits_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/commits{/sha}","git_commits_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/git/commits{/sha}","comments_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/comments{/number}","issue_comment_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/issues/comments{/number}","contents_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/contents/{+path}","compare_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/merges","archive_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/downloads","issues_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/issues{/number}","pulls_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/pulls{/number}","milestones_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/milestones{/number}","notifications_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/labels{/name}","releases_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/releases{/id}","deployments_url":"https://api.github.com/repos/salvianreynaldi/terraform-aws-autoscaling/deployments","created_at":"2018-03-28T06:54:53Z","updated_at":"2018-03-28T06:54:55Z","pushed_at":"2018-03-28T07:46:11Z","git_url":"git://github.com/salvianreynaldi/terraform-aws-autoscaling.git","ssh_url":"git@github.com:salvianreynaldi/terraform-aws-autoscaling.git","clone_url":"https://github.com/salvianreynaldi/terraform-aws-autoscaling.git","svn_url":"https://github.com/salvianreynaldi/terraform-aws-autoscaling","homepage":"","size":12,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"traveloka:master","ref":"master","sha":"d9bd3119baa9dda42678857b4f9141cd24d5937f","user":{"login":"traveloka","id":1683964,"avatar_url":"https://avatars1.githubusercontent.com/u/1683964?v=4","gravatar_id":"","url":"https://api.github.com/users/traveloka","html_url":"https://github.com/traveloka","followers_url":"https://api.github.com/users/traveloka/followers","following_url":"https://api.github.com/users/traveloka/following{/other_user}","gists_url":"https://api.github.com/users/traveloka/gists{/gist_id}","starred_url":"https://api.github.com/users/traveloka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traveloka/subscriptions","organizations_url":"https://api.github.com/users/traveloka/orgs","repos_url":"https://api.github.com/users/traveloka/repos","events_url":"https://api.github.com/users/traveloka/events{/privacy}","received_events_url":"https://api.github.com/users/traveloka/received_events","type":"Organization","site_admin":false},"repo":{"id":127091582,"name":"terraform-aws-autoscaling","full_name":"traveloka/terraform-aws-autoscaling","owner":{"login":"traveloka","id":1683964,"avatar_url":"https://avatars1.githubusercontent.com/u/1683964?v=4","gravatar_id":"","url":"https://api.github.com/users/traveloka","html_url":"https://github.com/traveloka","followers_url":"https://api.github.com/users/traveloka/followers","following_url":"https://api.github.com/users/traveloka/following{/other_user}","gists_url":"https://api.github.com/users/traveloka/gists{/gist_id}","starred_url":"https://api.github.com/users/traveloka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traveloka/subscriptions","organizations_url":"https://api.github.com/users/traveloka/orgs","repos_url":"https://api.github.com/users/traveloka/repos","events_url":"https://api.github.com/users/traveloka/events{/privacy}","received_events_url":"https://api.github.com/users/traveloka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/traveloka/terraform-aws-autoscaling","description":"A terraform module which provisions an auto scaling group along with its launch configuration","fork":false,"url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling","forks_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/forks","keys_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/teams","hooks_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/hooks","issue_events_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/issues/events{/number}","events_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/events","assignees_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/assignees{/user}","branches_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/branches{/branch}","tags_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/tags","blobs_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/git/refs{/sha}","trees_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/statuses/{sha}","languages_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/languages","stargazers_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/stargazers","contributors_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/contributors","subscribers_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/subscribers","subscription_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/subscription","commits_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/commits{/sha}","git_commits_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/git/commits{/sha}","comments_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/comments{/number}","issue_comment_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/issues/comments{/number}","contents_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/contents/{+path}","compare_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/merges","archive_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/downloads","issues_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/issues{/number}","pulls_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls{/number}","milestones_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/milestones{/number}","notifications_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/labels{/name}","releases_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/releases{/id}","deployments_url":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/deployments","created_at":"2018-03-28T06:04:10Z","updated_at":"2018-03-28T06:04:13Z","pushed_at":"2018-03-28T07:46:12Z","git_url":"git://github.com/traveloka/terraform-aws-autoscaling.git","ssh_url":"git@github.com:traveloka/terraform-aws-autoscaling.git","clone_url":"https://github.com/traveloka/terraform-aws-autoscaling.git","svn_url":"https://github.com/traveloka/terraform-aws-autoscaling","homepage":"","size":5,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls/1"},"html":{"href":"https://github.com/traveloka/terraform-aws-autoscaling/pull/1"},"issue":{"href":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/issues/1"},"comments":{"href":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/traveloka/terraform-aws-autoscaling/statuses/4bbf42ea80d0ab997555c3fd9533b4f44c55214d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"andysaputra"}}