{"action":"closed","number":4805,"pull_request":{"url":"https://api.github.com/repos/reactioncommerce/reaction/pulls/4805","id":230995593,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTk1NTkz","html_url":"https://github.com/reactioncommerce/reaction/pull/4805","diff_url":"https://github.com/reactioncommerce/reaction/pull/4805.diff","patch_url":"https://github.com/reactioncommerce/reaction/pull/4805.patch","issue_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4805","number":4805,"state":"closed","locked":false,"title":"feat: Put mongo on the streams network","user":{"login":"focusaurus","id":482377,"node_id":"MDQ6VXNlcjQ4MjM3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/482377?v=4","gravatar_id":"","url":"https://api.github.com/users/focusaurus","html_url":"https://github.com/focusaurus","followers_url":"https://api.github.com/users/focusaurus/followers","following_url":"https://api.github.com/users/focusaurus/following{/other_user}","gists_url":"https://api.github.com/users/focusaurus/gists{/gist_id}","starred_url":"https://api.github.com/users/focusaurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/focusaurus/subscriptions","organizations_url":"https://api.github.com/users/focusaurus/orgs","repos_url":"https://api.github.com/users/focusaurus/repos","events_url":"https://api.github.com/users/focusaurus/events{/privacy}","received_events_url":"https://api.github.com/users/focusaurus/received_events","type":"User","site_admin":false},"body":"Impact: **minor**  \r\nType: **feature**\r\n\r\n## Issue\r\n\r\nWe are building some data integrations for a separate project and need connectivity to mongo, so putting it on the streams network for local development. This doesn't affect production deployments. The related PR into reaction-platform for the `streams` network is [PR 28](https://github.com/reactioncommerce/reaction-platform/pull/28). It would be best to merge the PR into reaction-platform first then merge this PR.\r\n\r\n## Solution\r\nPut mongo onto the `streams` network, adjust as needed in the config and code. I also removed an additional hard coding in `waitForMongo.js` so more code is properly using the `MONGO_URL` environment variable.\r\n\r\n## Breaking changes\r\n\r\nThis will require the docker network `streams.reaction.localhost` to be created, which developers can do by pulling down the latest `reaction-platform` and running `make` (or `make network-create` if they want to be surgical about it).\r\n\r\n\r\n## Testing\r\n\r\n- Unit tests still pass\r\n- I manually ran eslint on `waitForMongo.js` as it's normally excluded\r\n- I ran reaction locally and confirmed I could still read and write to mongo via the reaction web app\r\n- I manually tested `waitForMongo.js`","created_at":"2018-11-14T21:56:50Z","updated_at":"2018-11-20T23:31:28Z","closed_at":"2018-11-20T23:31:28Z","merged_at":"2018-11-20T23:31:28Z","merge_commit_sha":"27674475191299524e6cfa8024fc5cd7927b6553","assignee":{"login":"focusaurus","id":482377,"node_id":"MDQ6VXNlcjQ4MjM3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/482377?v=4","gravatar_id":"","url":"https://api.github.com/users/focusaurus","html_url":"https://github.com/focusaurus","followers_url":"https://api.github.com/users/focusaurus/followers","following_url":"https://api.github.com/users/focusaurus/following{/other_user}","gists_url":"https://api.github.com/users/focusaurus/gists{/gist_id}","starred_url":"https://api.github.com/users/focusaurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/focusaurus/subscriptions","organizations_url":"https://api.github.com/users/focusaurus/orgs","repos_url":"https://api.github.com/users/focusaurus/repos","events_url":"https://api.github.com/users/focusaurus/events{/privacy}","received_events_url":"https://api.github.com/users/focusaurus/received_events","type":"User","site_admin":false},"assignees":[{"login":"focusaurus","id":482377,"node_id":"MDQ6VXNlcjQ4MjM3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/482377?v=4","gravatar_id":"","url":"https://api.github.com/users/focusaurus","html_url":"https://github.com/focusaurus","followers_url":"https://api.github.com/users/focusaurus/followers","following_url":"https://api.github.com/users/focusaurus/following{/other_user}","gists_url":"https://api.github.com/users/focusaurus/gists{/gist_id}","starred_url":"https://api.github.com/users/focusaurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/focusaurus/subscriptions","organizations_url":"https://api.github.com/users/focusaurus/orgs","repos_url":"https://api.github.com/users/focusaurus/repos","events_url":"https://api.github.com/users/focusaurus/events{/privacy}","received_events_url":"https://api.github.com/users/focusaurus/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":603853069,"node_id":"MDU6TGFiZWw2MDM4NTMwNjk=","url":"https://api.github.com/repos/reactioncommerce/reaction/labels/enhancements","name":"enhancements","color":"FF69B4","default":false},{"id":695680443,"node_id":"MDU6TGFiZWw2OTU2ODA0NDM=","url":"https://api.github.com/repos/reactioncommerce/reaction/labels/impact-minor","name":"impact-minor","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/reactioncommerce/reaction/pulls/4805/commits","review_comments_url":"https://api.github.com/repos/reactioncommerce/reaction/pulls/4805/comments","review_comment_url":"https://api.github.com/repos/reactioncommerce/reaction/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4805/comments","statuses_url":"https://api.github.com/repos/reactioncommerce/reaction/statuses/cdb8a0f76214381be56b9af6e631ca08b91eb5b1","head":{"label":"reactioncommerce:feat-pete-reaction-search-2","ref":"feat-pete-reaction-search-2","sha":"cdb8a0f76214381be56b9af6e631ca08b91eb5b1","user":{"login":"reactioncommerce","id":5605462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDU0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5605462?v=4","gravatar_id":"","url":"https://api.github.com/users/reactioncommerce","html_url":"https://github.com/reactioncommerce","followers_url":"https://api.github.com/users/reactioncommerce/followers","following_url":"https://api.github.com/users/reactioncommerce/following{/other_user}","gists_url":"https://api.github.com/users/reactioncommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/reactioncommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactioncommerce/subscriptions","organizations_url":"https://api.github.com/users/reactioncommerce/orgs","repos_url":"https://api.github.com/users/reactioncommerce/repos","events_url":"https://api.github.com/users/reactioncommerce/events{/privacy}","received_events_url":"https://api.github.com/users/reactioncommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":12926963,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyNjk2Mw==","name":"reaction","full_name":"reactioncommerce/reaction","private":false,"owner":{"login":"reactioncommerce","id":5605462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDU0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5605462?v=4","gravatar_id":"","url":"https://api.github.com/users/reactioncommerce","html_url":"https://github.com/reactioncommerce","followers_url":"https://api.github.com/users/reactioncommerce/followers","following_url":"https://api.github.com/users/reactioncommerce/following{/other_user}","gists_url":"https://api.github.com/users/reactioncommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/reactioncommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactioncommerce/subscriptions","organizations_url":"https://api.github.com/users/reactioncommerce/orgs","repos_url":"https://api.github.com/users/reactioncommerce/repos","events_url":"https://api.github.com/users/reactioncommerce/events{/privacy}","received_events_url":"https://api.github.com/users/reactioncommerce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactioncommerce/reaction","description":"Reaction is a customizable, real-time reactive, JavaScript commerce platform.","fork":false,"url":"https://api.github.com/repos/reactioncommerce/reaction","forks_url":"https://api.github.com/repos/reactioncommerce/reaction/forks","keys_url":"https://api.github.com/repos/reactioncommerce/reaction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactioncommerce/reaction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactioncommerce/reaction/teams","hooks_url":"https://api.github.com/repos/reactioncommerce/reaction/hooks","issue_events_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/events{/number}","events_url":"https://api.github.com/repos/reactioncommerce/reaction/events","assignees_url":"https://api.github.com/repos/reactioncommerce/reaction/assignees{/user}","branches_url":"https://api.github.com/repos/reactioncommerce/reaction/branches{/branch}","tags_url":"https://api.github.com/repos/reactioncommerce/reaction/tags","blobs_url":"https://api.github.com/repos/reactioncommerce/reaction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactioncommerce/reaction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactioncommerce/reaction/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactioncommerce/reaction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactioncommerce/reaction/statuses/{sha}","languages_url":"https://api.github.com/repos/reactioncommerce/reaction/languages","stargazers_url":"https://api.github.com/repos/reactioncommerce/reaction/stargazers","contributors_url":"https://api.github.com/repos/reactioncommerce/reaction/contributors","subscribers_url":"https://api.github.com/repos/reactioncommerce/reaction/subscribers","subscription_url":"https://api.github.com/repos/reactioncommerce/reaction/subscription","commits_url":"https://api.github.com/repos/reactioncommerce/reaction/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactioncommerce/reaction/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactioncommerce/reaction/contents/{+path}","compare_url":"https://api.github.com/repos/reactioncommerce/reaction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactioncommerce/reaction/merges","archive_url":"https://api.github.com/repos/reactioncommerce/reaction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactioncommerce/reaction/downloads","issues_url":"https://api.github.com/repos/reactioncommerce/reaction/issues{/number}","pulls_url":"https://api.github.com/repos/reactioncommerce/reaction/pulls{/number}","milestones_url":"https://api.github.com/repos/reactioncommerce/reaction/milestones{/number}","notifications_url":"https://api.github.com/repos/reactioncommerce/reaction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactioncommerce/reaction/labels{/name}","releases_url":"https://api.github.com/repos/reactioncommerce/reaction/releases{/id}","deployments_url":"https://api.github.com/repos/reactioncommerce/reaction/deployments","created_at":"2013-09-18T15:30:36Z","updated_at":"2018-11-20T21:24:16Z","pushed_at":"2018-11-20T23:31:28Z","git_url":"git://github.com/reactioncommerce/reaction.git","ssh_url":"git@github.com:reactioncommerce/reaction.git","clone_url":"https://github.com/reactioncommerce/reaction.git","svn_url":"https://github.com/reactioncommerce/reaction","homepage":"https://reactioncommerce.com/","size":73591,"stargazers_count":8025,"watchers_count":8025,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1506,"mirror_url":null,"archived":false,"open_issues_count":382,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1506,"open_issues":382,"watchers":8025,"default_branch":"master"}},"base":{"label":"reactioncommerce:release-2.0.0-rc.7","ref":"release-2.0.0-rc.7","sha":"8138a615d87efff9951669eaf116454b0a92976e","user":{"login":"reactioncommerce","id":5605462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDU0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5605462?v=4","gravatar_id":"","url":"https://api.github.com/users/reactioncommerce","html_url":"https://github.com/reactioncommerce","followers_url":"https://api.github.com/users/reactioncommerce/followers","following_url":"https://api.github.com/users/reactioncommerce/following{/other_user}","gists_url":"https://api.github.com/users/reactioncommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/reactioncommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactioncommerce/subscriptions","organizations_url":"https://api.github.com/users/reactioncommerce/orgs","repos_url":"https://api.github.com/users/reactioncommerce/repos","events_url":"https://api.github.com/users/reactioncommerce/events{/privacy}","received_events_url":"https://api.github.com/users/reactioncommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":12926963,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyNjk2Mw==","name":"reaction","full_name":"reactioncommerce/reaction","private":false,"owner":{"login":"reactioncommerce","id":5605462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDU0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5605462?v=4","gravatar_id":"","url":"https://api.github.com/users/reactioncommerce","html_url":"https://github.com/reactioncommerce","followers_url":"https://api.github.com/users/reactioncommerce/followers","following_url":"https://api.github.com/users/reactioncommerce/following{/other_user}","gists_url":"https://api.github.com/users/reactioncommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/reactioncommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactioncommerce/subscriptions","organizations_url":"https://api.github.com/users/reactioncommerce/orgs","repos_url":"https://api.github.com/users/reactioncommerce/repos","events_url":"https://api.github.com/users/reactioncommerce/events{/privacy}","received_events_url":"https://api.github.com/users/reactioncommerce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactioncommerce/reaction","description":"Reaction is a customizable, real-time reactive, JavaScript commerce platform.","fork":false,"url":"https://api.github.com/repos/reactioncommerce/reaction","forks_url":"https://api.github.com/repos/reactioncommerce/reaction/forks","keys_url":"https://api.github.com/repos/reactioncommerce/reaction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactioncommerce/reaction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactioncommerce/reaction/teams","hooks_url":"https://api.github.com/repos/reactioncommerce/reaction/hooks","issue_events_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/events{/number}","events_url":"https://api.github.com/repos/reactioncommerce/reaction/events","assignees_url":"https://api.github.com/repos/reactioncommerce/reaction/assignees{/user}","branches_url":"https://api.github.com/repos/reactioncommerce/reaction/branches{/branch}","tags_url":"https://api.github.com/repos/reactioncommerce/reaction/tags","blobs_url":"https://api.github.com/repos/reactioncommerce/reaction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactioncommerce/reaction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactioncommerce/reaction/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactioncommerce/reaction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactioncommerce/reaction/statuses/{sha}","languages_url":"https://api.github.com/repos/reactioncommerce/reaction/languages","stargazers_url":"https://api.github.com/repos/reactioncommerce/reaction/stargazers","contributors_url":"https://api.github.com/repos/reactioncommerce/reaction/contributors","subscribers_url":"https://api.github.com/repos/reactioncommerce/reaction/subscribers","subscription_url":"https://api.github.com/repos/reactioncommerce/reaction/subscription","commits_url":"https://api.github.com/repos/reactioncommerce/reaction/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactioncommerce/reaction/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactioncommerce/reaction/contents/{+path}","compare_url":"https://api.github.com/repos/reactioncommerce/reaction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactioncommerce/reaction/merges","archive_url":"https://api.github.com/repos/reactioncommerce/reaction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactioncommerce/reaction/downloads","issues_url":"https://api.github.com/repos/reactioncommerce/reaction/issues{/number}","pulls_url":"https://api.github.com/repos/reactioncommerce/reaction/pulls{/number}","milestones_url":"https://api.github.com/repos/reactioncommerce/reaction/milestones{/number}","notifications_url":"https://api.github.com/repos/reactioncommerce/reaction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactioncommerce/reaction/labels{/name}","releases_url":"https://api.github.com/repos/reactioncommerce/reaction/releases{/id}","deployments_url":"https://api.github.com/repos/reactioncommerce/reaction/deployments","created_at":"2013-09-18T15:30:36Z","updated_at":"2018-11-20T21:24:16Z","pushed_at":"2018-11-20T23:31:28Z","git_url":"git://github.com/reactioncommerce/reaction.git","ssh_url":"git@github.com:reactioncommerce/reaction.git","clone_url":"https://github.com/reactioncommerce/reaction.git","svn_url":"https://github.com/reactioncommerce/reaction","homepage":"https://reactioncommerce.com/","size":73591,"stargazers_count":8025,"watchers_count":8025,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1506,"mirror_url":null,"archived":false,"open_issues_count":382,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1506,"open_issues":382,"watchers":8025,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactioncommerce/reaction/pulls/4805"},"html":{"href":"https://github.com/reactioncommerce/reaction/pull/4805"},"issue":{"href":"https://api.github.com/repos/reactioncommerce/reaction/issues/4805"},"comments":{"href":"https://api.github.com/repos/reactioncommerce/reaction/issues/4805/comments"},"review_comments":{"href":"https://api.github.com/repos/reactioncommerce/reaction/pulls/4805/comments"},"review_comment":{"href":"https://api.github.com/repos/reactioncommerce/reaction/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactioncommerce/reaction/pulls/4805/commits"},"statuses":{"href":"https://api.github.com/repos/reactioncommerce/reaction/statuses/cdb8a0f76214381be56b9af6e631ca08b91eb5b1"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"aldeed","id":3012067,"node_id":"MDQ6VXNlcjMwMTIwNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3012067?v=4","gravatar_id":"","url":"https://api.github.com/users/aldeed","html_url":"https://github.com/aldeed","followers_url":"https://api.github.com/users/aldeed/followers","following_url":"https://api.github.com/users/aldeed/following{/other_user}","gists_url":"https://api.github.com/users/aldeed/gists{/gist_id}","starred_url":"https://api.github.com/users/aldeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldeed/subscriptions","organizations_url":"https://api.github.com/users/aldeed/orgs","repos_url":"https://api.github.com/users/aldeed/repos","events_url":"https://api.github.com/users/aldeed/events{/privacy}","received_events_url":"https://api.github.com/users/aldeed/received_events","type":"User","site_admin":false},"comments":5,"review_comments":6,"maintainer_can_modify":false,"commits":2,"additions":19,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"aldeed"}}