{"action":"created","comment":{"url":"https://api.github.com/repos/bbc/simorgh/pulls/comments/205033764","pull_request_review_id":140222096,"id":205033764,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTAzMzc2NA==","diff_hunk":"@@ -0,0 +1,15 @@\n+import {\n+  smartPhoneScreenWidthMin,","path":"src/app/helpers/mediaQueries.js","position":2,"original_position":2,"commit_id":"40d289172c012bcb50e3cad209457d908d0ad24b","original_commit_id":"40d289172c012bcb50e3cad209457d908d0ad24b","user":{"login":"benjaminhobbs","id":15235276,"node_id":"MDQ6VXNlcjE1MjM1Mjc2","avatar_url":"https://avatars0.githubusercontent.com/u/15235276?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminhobbs","html_url":"https://github.com/benjaminhobbs","followers_url":"https://api.github.com/users/benjaminhobbs/followers","following_url":"https://api.github.com/users/benjaminhobbs/following{/other_user}","gists_url":"https://api.github.com/users/benjaminhobbs/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminhobbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminhobbs/subscriptions","organizations_url":"https://api.github.com/users/benjaminhobbs/orgs","repos_url":"https://api.github.com/users/benjaminhobbs/repos","events_url":"https://api.github.com/users/benjaminhobbs/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminhobbs/received_events","type":"User","site_admin":false},"body":"We should discuss this.","created_at":"2018-07-25T09:04:27Z","updated_at":"2018-07-25T09:04:27Z","html_url":"https://github.com/bbc/simorgh/pull/370#discussion_r205033764","pull_request_url":"https://api.github.com/repos/bbc/simorgh/pulls/370","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bbc/simorgh/pulls/comments/205033764"},"html":{"href":"https://github.com/bbc/simorgh/pull/370#discussion_r205033764"},"pull_request":{"href":"https://api.github.com/repos/bbc/simorgh/pulls/370"}},"in_reply_to_id":205028285},"pull_request":{"url":"https://api.github.com/repos/bbc/simorgh/pulls/370","id":203656879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjU2ODc5","html_url":"https://github.com/bbc/simorgh/pull/370","diff_url":"https://github.com/bbc/simorgh/pull/370.diff","patch_url":"https://github.com/bbc/simorgh/pull/370.patch","issue_url":"https://api.github.com/repos/bbc/simorgh/issues/370","number":370,"state":"open","locked":false,"title":"Font size + line height: typography with styled-components","user":{"login":"benjaminhobbs","id":15235276,"node_id":"MDQ6VXNlcjE1MjM1Mjc2","avatar_url":"https://avatars0.githubusercontent.com/u/15235276?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminhobbs","html_url":"https://github.com/benjaminhobbs","followers_url":"https://api.github.com/users/benjaminhobbs/followers","following_url":"https://api.github.com/users/benjaminhobbs/following{/other_user}","gists_url":"https://api.github.com/users/benjaminhobbs/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminhobbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminhobbs/subscriptions","organizations_url":"https://api.github.com/users/benjaminhobbs/orgs","repos_url":"https://api.github.com/users/benjaminhobbs/repos","events_url":"https://api.github.com/users/benjaminhobbs/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminhobbs/received_events","type":"User","site_admin":false},"body":"font size and lie height implementation using styled components and media queries across all components that have font size or line height.\r\n\r\nNB this also removes the font styling from the header component to make it clear that this will not be implemented this way (as it will be an svg)\r\n\r\n* [x] Part 1 of 2 of https://github.com/bbc/simorgh/issues/184 - Part 2 will check for touch.\r\n* [x] Tests added for new features\r\n\r\n* [ ] Test engineer approval\r\n","created_at":"2018-07-24T21:14:05Z","updated_at":"2018-07-25T09:04:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"932f276a55e4d241f1716dca07ef1287a9696c1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bbc/simorgh/pulls/370/commits","review_comments_url":"https://api.github.com/repos/bbc/simorgh/pulls/370/comments","review_comment_url":"https://api.github.com/repos/bbc/simorgh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbc/simorgh/issues/370/comments","statuses_url":"https://api.github.com/repos/bbc/simorgh/statuses/40d289172c012bcb50e3cad209457d908d0ad24b","head":{"label":"bbc:font-s+lh","ref":"font-s+lh","sha":"40d289172c012bcb50e3cad209457d908d0ad24b","user":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"repo":{"id":133968906,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Njg5MDY=","name":"simorgh","full_name":"bbc/simorgh","owner":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bbc/simorgh","description":"The BBC's new article (soon... we hope)","fork":false,"url":"https://api.github.com/repos/bbc/simorgh","forks_url":"https://api.github.com/repos/bbc/simorgh/forks","keys_url":"https://api.github.com/repos/bbc/simorgh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbc/simorgh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbc/simorgh/teams","hooks_url":"https://api.github.com/repos/bbc/simorgh/hooks","issue_events_url":"https://api.github.com/repos/bbc/simorgh/issues/events{/number}","events_url":"https://api.github.com/repos/bbc/simorgh/events","assignees_url":"https://api.github.com/repos/bbc/simorgh/assignees{/user}","branches_url":"https://api.github.com/repos/bbc/simorgh/branches{/branch}","tags_url":"https://api.github.com/repos/bbc/simorgh/tags","blobs_url":"https://api.github.com/repos/bbc/simorgh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbc/simorgh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbc/simorgh/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbc/simorgh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbc/simorgh/statuses/{sha}","languages_url":"https://api.github.com/repos/bbc/simorgh/languages","stargazers_url":"https://api.github.com/repos/bbc/simorgh/stargazers","contributors_url":"https://api.github.com/repos/bbc/simorgh/contributors","subscribers_url":"https://api.github.com/repos/bbc/simorgh/subscribers","subscription_url":"https://api.github.com/repos/bbc/simorgh/subscription","commits_url":"https://api.github.com/repos/bbc/simorgh/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbc/simorgh/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbc/simorgh/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbc/simorgh/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbc/simorgh/contents/{+path}","compare_url":"https://api.github.com/repos/bbc/simorgh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbc/simorgh/merges","archive_url":"https://api.github.com/repos/bbc/simorgh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbc/simorgh/downloads","issues_url":"https://api.github.com/repos/bbc/simorgh/issues{/number}","pulls_url":"https://api.github.com/repos/bbc/simorgh/pulls{/number}","milestones_url":"https://api.github.com/repos/bbc/simorgh/milestones{/number}","notifications_url":"https://api.github.com/repos/bbc/simorgh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbc/simorgh/labels{/name}","releases_url":"https://api.github.com/repos/bbc/simorgh/releases{/id}","deployments_url":"https://api.github.com/repos/bbc/simorgh/deployments","created_at":"2018-05-18T14:59:42Z","updated_at":"2018-07-24T16:15:10Z","pushed_at":"2018-07-25T08:49:32Z","git_url":"git://github.com/bbc/simorgh.git","ssh_url":"git@github.com:bbc/simorgh.git","clone_url":"https://github.com/bbc/simorgh.git","svn_url":"https://github.com/bbc/simorgh","homepage":"https://www.bbc.com","size":7364,"stargazers_count":11,"watchers_count":11,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":61,"watchers":11,"default_branch":"latest"}},"base":{"label":"bbc:latest","ref":"latest","sha":"fd9fbdaf261069b05664a4895eb1f78070d986e4","user":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"repo":{"id":133968906,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Njg5MDY=","name":"simorgh","full_name":"bbc/simorgh","owner":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bbc/simorgh","description":"The BBC's new article (soon... we hope)","fork":false,"url":"https://api.github.com/repos/bbc/simorgh","forks_url":"https://api.github.com/repos/bbc/simorgh/forks","keys_url":"https://api.github.com/repos/bbc/simorgh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbc/simorgh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbc/simorgh/teams","hooks_url":"https://api.github.com/repos/bbc/simorgh/hooks","issue_events_url":"https://api.github.com/repos/bbc/simorgh/issues/events{/number}","events_url":"https://api.github.com/repos/bbc/simorgh/events","assignees_url":"https://api.github.com/repos/bbc/simorgh/assignees{/user}","branches_url":"https://api.github.com/repos/bbc/simorgh/branches{/branch}","tags_url":"https://api.github.com/repos/bbc/simorgh/tags","blobs_url":"https://api.github.com/repos/bbc/simorgh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbc/simorgh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbc/simorgh/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbc/simorgh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbc/simorgh/statuses/{sha}","languages_url":"https://api.github.com/repos/bbc/simorgh/languages","stargazers_url":"https://api.github.com/repos/bbc/simorgh/stargazers","contributors_url":"https://api.github.com/repos/bbc/simorgh/contributors","subscribers_url":"https://api.github.com/repos/bbc/simorgh/subscribers","subscription_url":"https://api.github.com/repos/bbc/simorgh/subscription","commits_url":"https://api.github.com/repos/bbc/simorgh/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbc/simorgh/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbc/simorgh/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbc/simorgh/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbc/simorgh/contents/{+path}","compare_url":"https://api.github.com/repos/bbc/simorgh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbc/simorgh/merges","archive_url":"https://api.github.com/repos/bbc/simorgh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbc/simorgh/downloads","issues_url":"https://api.github.com/repos/bbc/simorgh/issues{/number}","pulls_url":"https://api.github.com/repos/bbc/simorgh/pulls{/number}","milestones_url":"https://api.github.com/repos/bbc/simorgh/milestones{/number}","notifications_url":"https://api.github.com/repos/bbc/simorgh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbc/simorgh/labels{/name}","releases_url":"https://api.github.com/repos/bbc/simorgh/releases{/id}","deployments_url":"https://api.github.com/repos/bbc/simorgh/deployments","created_at":"2018-05-18T14:59:42Z","updated_at":"2018-07-24T16:15:10Z","pushed_at":"2018-07-25T08:49:32Z","git_url":"git://github.com/bbc/simorgh.git","ssh_url":"git@github.com:bbc/simorgh.git","clone_url":"https://github.com/bbc/simorgh.git","svn_url":"https://github.com/bbc/simorgh","homepage":"https://www.bbc.com","size":7364,"stargazers_count":11,"watchers_count":11,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":61,"watchers":11,"default_branch":"latest"}},"_links":{"self":{"href":"https://api.github.com/repos/bbc/simorgh/pulls/370"},"html":{"href":"https://github.com/bbc/simorgh/pull/370"},"issue":{"href":"https://api.github.com/repos/bbc/simorgh/issues/370"},"comments":{"href":"https://api.github.com/repos/bbc/simorgh/issues/370/comments"},"review_comments":{"href":"https://api.github.com/repos/bbc/simorgh/pulls/370/comments"},"review_comment":{"href":"https://api.github.com/repos/bbc/simorgh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbc/simorgh/pulls/370/commits"},"statuses":{"href":"https://api.github.com/repos/bbc/simorgh/statuses/40d289172c012bcb50e3cad209457d908d0ad24b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benjaminhobbs"}}