{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/186453129","pull_request_review_id":118032892,"id":186453129,"diff_hunk":"@@ -0,0 +1,5 @@\n+import FWCore.ParameterSet.Config as cms\n+\n+pfCandidatesBadHadRecalibrated = cms.EDProducer(\"PFCandidateRecalibrator\",","path":"CommonTools/ParticleFlow/python/pfCandidatesBadHadRecalibrated_cfi.py","position":3,"original_position":3,"commit_id":"78037e498fb473b25812ff0687bc47d6f6f980ac","original_commit_id":"a9715873a120cc9ef62f8c4994fad6a6e2dd07f9","user":{"login":"gpetruc","id":4643655,"avatar_url":"https://avatars0.githubusercontent.com/u/4643655?v=4","gravatar_id":"","url":"https://api.github.com/users/gpetruc","html_url":"https://github.com/gpetruc","followers_url":"https://api.github.com/users/gpetruc/followers","following_url":"https://api.github.com/users/gpetruc/following{/other_user}","gists_url":"https://api.github.com/users/gpetruc/gists{/gist_id}","starred_url":"https://api.github.com/users/gpetruc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpetruc/subscriptions","organizations_url":"https://api.github.com/users/gpetruc/orgs","repos_url":"https://api.github.com/users/gpetruc/repos","events_url":"https://api.github.com/users/gpetruc/events{/privacy}","received_events_url":"https://api.github.com/users/gpetruc/received_events","type":"User","site_admin":false},"body":"I would prefer to keep the implementation as it is now, i.e. with a new label for the new output, as we did for the 03Feb2017 re-miniAOD.","created_at":"2018-05-07T15:09:30Z","updated_at":"2018-05-07T15:09:30Z","html_url":"https://github.com/cms-sw/cmssw/pull/22941#discussion_r186453129","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22941","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/186453129"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/22941#discussion_r186453129"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22941"}},"in_reply_to_id":182105918},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22941","id":181121547,"html_url":"https://github.com/cms-sw/cmssw/pull/22941","diff_url":"https://github.com/cms-sw/cmssw/pull/22941.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/22941.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22941","number":22941,"state":"open","locked":false,"title":"Fix hot HCAL channels in legacy 2016","user":{"login":"deguio","id":3207679,"avatar_url":"https://avatars1.githubusercontent.com/u/3207679?v=4","gravatar_id":"","url":"https://api.github.com/users/deguio","html_url":"https://github.com/deguio","followers_url":"https://api.github.com/users/deguio/followers","following_url":"https://api.github.com/users/deguio/following{/other_user}","gists_url":"https://api.github.com/users/deguio/gists{/gist_id}","starred_url":"https://api.github.com/users/deguio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deguio/subscriptions","organizations_url":"https://api.github.com/users/deguio/orgs","repos_url":"https://api.github.com/users/deguio/repos","events_url":"https://api.github.com/users/deguio/events{/privacy}","received_events_url":"https://api.github.com/users/deguio/received_events","type":"User","site_admin":false},"body":"same content as in #22713\r\n\r\nthis development is relevant for the re-miniAODv2 of the 2016 legacy rereco that will happen in 94x.\r\n\r\nfor reference, here is the effect of the recipe on HE:\r\n- left plot in slide 2 at: https://indico.cern.ch/event/713034/contributions/2936595/attachments/1617731/2571895/15Mar2018_Legacy_HCALfixV2.pdf\r\n- slides up to 8 at: https://www.dropbox.com/s/g75uiiod37a7qvg/2018-03-04_MET-HCALfix_3rd_2016legacy.pdf?dl=0","created_at":"2018-04-12T08:10:09Z","updated_at":"2018-05-07T15:09:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c306542b4a20c31d4c3ea63b6b8e6d152bcfb817","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":52881179,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04","default":false},{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":149441623,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pdmv-approved","name":"pdmv-approved","color":"2cbe4e","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false},{"id":530655448,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/upgrade-pending","name":"upgrade-pending","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":53,"closed_issues":259,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-05-07T14:03:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22941/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22941/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22941/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/78037e498fb473b25812ff0687bc47d6f6f980ac","head":{"label":"deguio:fixLegacy2016_102x","ref":"fixLegacy2016_102x","sha":"78037e498fb473b25812ff0687bc47d6f6f980ac","user":{"login":"deguio","id":3207679,"avatar_url":"https://avatars1.githubusercontent.com/u/3207679?v=4","gravatar_id":"","url":"https://api.github.com/users/deguio","html_url":"https://github.com/deguio","followers_url":"https://api.github.com/users/deguio/followers","following_url":"https://api.github.com/users/deguio/following{/other_user}","gists_url":"https://api.github.com/users/deguio/gists{/gist_id}","starred_url":"https://api.github.com/users/deguio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deguio/subscriptions","organizations_url":"https://api.github.com/users/deguio/orgs","repos_url":"https://api.github.com/users/deguio/repos","events_url":"https://api.github.com/users/deguio/events{/privacy}","received_events_url":"https://api.github.com/users/deguio/received_events","type":"User","site_admin":false},"repo":{"id":11000804,"name":"cmssw","full_name":"deguio/cmssw","owner":{"login":"deguio","id":3207679,"avatar_url":"https://avatars1.githubusercontent.com/u/3207679?v=4","gravatar_id":"","url":"https://api.github.com/users/deguio","html_url":"https://github.com/deguio","followers_url":"https://api.github.com/users/deguio/followers","following_url":"https://api.github.com/users/deguio/following{/other_user}","gists_url":"https://api.github.com/users/deguio/gists{/gist_id}","starred_url":"https://api.github.com/users/deguio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deguio/subscriptions","organizations_url":"https://api.github.com/users/deguio/orgs","repos_url":"https://api.github.com/users/deguio/repos","events_url":"https://api.github.com/users/deguio/events{/privacy}","received_events_url":"https://api.github.com/users/deguio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deguio/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/deguio/cmssw","forks_url":"https://api.github.com/repos/deguio/cmssw/forks","keys_url":"https://api.github.com/repos/deguio/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deguio/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deguio/cmssw/teams","hooks_url":"https://api.github.com/repos/deguio/cmssw/hooks","issue_events_url":"https://api.github.com/repos/deguio/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/deguio/cmssw/events","assignees_url":"https://api.github.com/repos/deguio/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/deguio/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/deguio/cmssw/tags","blobs_url":"https://api.github.com/repos/deguio/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deguio/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deguio/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/deguio/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deguio/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/deguio/cmssw/languages","stargazers_url":"https://api.github.com/repos/deguio/cmssw/stargazers","contributors_url":"https://api.github.com/repos/deguio/cmssw/contributors","subscribers_url":"https://api.github.com/repos/deguio/cmssw/subscribers","subscription_url":"https://api.github.com/repos/deguio/cmssw/subscription","commits_url":"https://api.github.com/repos/deguio/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/deguio/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/deguio/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/deguio/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/deguio/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/deguio/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deguio/cmssw/merges","archive_url":"https://api.github.com/repos/deguio/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deguio/cmssw/downloads","issues_url":"https://api.github.com/repos/deguio/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/deguio/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/deguio/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/deguio/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deguio/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/deguio/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/deguio/cmssw/deployments","created_at":"2013-06-27T15:37:36Z","updated_at":"2014-06-25T05:14:53Z","pushed_at":"2018-04-30T21:56:23Z","git_url":"git://github.com/deguio/cmssw.git","ssh_url":"git@github.com:deguio/cmssw.git","clone_url":"https://github.com/deguio/cmssw.git","svn_url":"https://github.com/deguio/cmssw","homepage":null,"size":944557,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:master","ref":"master","sha":"db217d8aac6706e4e9f51aba21afec58aeab0d63","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-05-07T14:04:10Z","pushed_at":"2018-05-07T15:08:14Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":999613,"stargazers_count":547,"watchers_count":547,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2558,"mirror_url":null,"archived":false,"open_issues_count":455,"license":null,"forks":2558,"open_issues":455,"watchers":547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22941"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/22941"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/22941"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/22941/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22941/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22941/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/78037e498fb473b25812ff0687bc47d6f6f980ac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gpetruc"}}