{"action":"opened","issue":{"url":"https://api.github.com/repos/dotnet/arcade/issues/1362","repository_url":"https://api.github.com/repos/dotnet/arcade","labels_url":"https://api.github.com/repos/dotnet/arcade/issues/1362/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/arcade/issues/1362/comments","events_url":"https://api.github.com/repos/dotnet/arcade/issues/1362/events","html_url":"https://github.com/dotnet/arcade/issues/1362","id":382366676,"node_id":"MDU6SXNzdWUzODIzNjY2NzY=","number":1362,"title":"SignCheck --verify-strongname fails on native .dll/.exe files","user":{"login":"natemcmaster","id":2696087,"node_id":"MDQ6VXNlcjI2OTYwODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2696087?v=4","gravatar_id":"","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-19T19:47:30Z","updated_at":"2018-11-19T19:47:30Z","closed_at":null,"author_association":"MEMBER","body":"The `--verify-strongname` flag on SignCheck creates a false-positive error on native .dll/.exe files. These don't have a strong name because they are not .NET binaries.\r\n\r\n**Repro:**\r\nDownload https://www.nuget.org/api/v2/package/dotnet-ef/2.1.4\r\nRun sign check on it:\r\n```\r\nmicrosoft.dotnet.signcheck.exe -i .\\dotnet-ef.2.1.4.nupkg --recursive --verify-strongname\r\n```\r\n\r\n**Expected**\r\nSign check only produces strong-name errors for managed, .NET assemblies that are missing a strong name.\r\n\r\n**Actual**\r\nSign check flags the `dotnet-ef.exe` files, which are non-.NET native executables.\r\n```\r\n[File] dotnet-ef.2.1.4.nupkg, Signed: True\r\n  [File] 54f9627c062431c5c1718eeb471f84ca.exe, Signed: False, Full Name: tools/netcoreapp2.1/any/shims/win-x64/dotnet-ef.exe\r\n  [File] 696221522c7f479ed2955bd6c11079f7.exe, Signed: False, Full Name: tools/netcoreapp2.1/any/shims/win-x86/dotnet-ef.exe\r\n```\r\n\r\ncc @bricelam @Eilon  @joeloff "}}
{"actor":{"display_login":"natemcmaster"}}