{"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/dstmath/profilo/pulls/15","id":188895224,"html_url":"https://github.com/dstmath/profilo/pull/15","diff_url":"https://github.com/dstmath/profilo/pull/15.diff","patch_url":"https://github.com/dstmath/profilo/pull/15.patch","issue_url":"https://api.github.com/repos/dstmath/profilo/issues/15","number":15,"state":"closed","locked":false,"title":"Pretty much completely re-write //native/linker","user":{"login":"dstmath","id":2055240,"avatar_url":"https://avatars2.githubusercontent.com/u/2055240?v=4","gravatar_id":"","url":"https://api.github.com/users/dstmath","html_url":"https://github.com/dstmath","followers_url":"https://api.github.com/users/dstmath/followers","following_url":"https://api.github.com/users/dstmath/following{/other_user}","gists_url":"https://api.github.com/users/dstmath/gists{/gist_id}","starred_url":"https://api.github.com/users/dstmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstmath/subscriptions","organizations_url":"https://api.github.com/users/dstmath/orgs","repos_url":"https://api.github.com/users/dstmath/repos","events_url":"https://api.github.com/users/dstmath/events{/privacy}","received_events_url":"https://api.github.com/users/dstmath/received_events","type":"User","site_admin":false},"body":"Summary:\r\n* Support for x86-64, aarch64\r\n  * Replaced specific-width types with architecture-dependent-width macros\r\n* Support for `RELA` relocations, not just `REL`\r\n  * 64-bit uses `RELA`\r\n* Support for all dynamic relocations, not just PLT relocations\r\n* Support for GNU symbol hashing\r\n  * Beginning with Android 6.0, GNU hash tables are supported and common\r\n* `dladdr1` implementation\r\n  * For some inane reason Bionic provides this on *some* architectures but not all\r\n\r\n* Code split up into multiple TUs according to responsibility\r\n* Much simpler thread-safety and locking model\r\n  * Global data is now wrapped in accessor methods that take appropriate read and write locks. Data is returned by value, rather than by reference, to enable atomic \"snapshot\" behavior.\r\n* `CALL_PREV` macro is now C99-safe again\r\n  * Callers must now pass in a reference to the *hook*, not the hook *target*, when calling `CALL_PREV`. Enables simpler and more reliable chained-function lookup and is less confusing.\r\n  * C99 callers must now manually pass in the hook signature as well as a reference to the hook itself. (As opposed to having not ever been able to use it at all, so, still an improvement lol)\r\n* Consolidated library naming behavior across Android versions; now only the library basename is required\r\n  * Sometime between API 16 and 19, `dlopen` began correctly adding `/data/data/<app>/lib/` to the LD search path.\r\n* `hook_plt_method`, `hook_single_lib`, and `hook_all_libs` now have more consistent return values.\r\n* `plt_hook_spec::hook_result` is now meaningfully filled in after a hook operation.\r\n* In fatal erroneous situations, an error message will now be logged to Logcat at `FATAL` priority the process is `abort`'ed.\r\n* `bionic_linker.h` now much more accurate to the Android versions it is relevant for\r\n  * Previous code was pulled from a version of AOSP that it wasn't actually being used against\r\n\r\nReviewed By: ricardorey10\r\n\r\nDifferential Revision: D7823322\r\n\r\nfbshipit-source-id: 9f93e87ab2b7439236ad1600f209a885a9b08be5","created_at":"2018-05-18T00:37:38Z","updated_at":"2018-05-18T00:37:46Z","closed_at":"2018-05-18T00:37:46Z","merged_at":"2018-05-18T00:37:46Z","merge_commit_sha":"7ed95278596ebf4917aa290232a990a88b3de190","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dstmath/profilo/pulls/15/commits","review_comments_url":"https://api.github.com/repos/dstmath/profilo/pulls/15/comments","review_comment_url":"https://api.github.com/repos/dstmath/profilo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dstmath/profilo/issues/15/comments","statuses_url":"https://api.github.com/repos/dstmath/profilo/statuses/b84909341f5076c4a35a6459b2ab0deada4afec3","head":{"label":"facebookincubator:master","ref":"master","sha":"b84909341f5076c4a35a6459b2ab0deada4afec3","user":{"login":"facebookincubator","id":19538647,"avatar_url":"https://avatars2.githubusercontent.com/u/19538647?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookincubator","html_url":"https://github.com/facebookincubator","followers_url":"https://api.github.com/users/facebookincubator/followers","following_url":"https://api.github.com/users/facebookincubator/following{/other_user}","gists_url":"https://api.github.com/users/facebookincubator/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookincubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookincubator/subscriptions","organizations_url":"https://api.github.com/users/facebookincubator/orgs","repos_url":"https://api.github.com/users/facebookincubator/repos","events_url":"https://api.github.com/users/facebookincubator/events{/privacy}","received_events_url":"https://api.github.com/users/facebookincubator/received_events","type":"Organization","site_admin":false},"repo":{"id":103603776,"name":"profilo","full_name":"facebookincubator/profilo","owner":{"login":"facebookincubator","id":19538647,"avatar_url":"https://avatars2.githubusercontent.com/u/19538647?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookincubator","html_url":"https://github.com/facebookincubator","followers_url":"https://api.github.com/users/facebookincubator/followers","following_url":"https://api.github.com/users/facebookincubator/following{/other_user}","gists_url":"https://api.github.com/users/facebookincubator/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookincubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookincubator/subscriptions","organizations_url":"https://api.github.com/users/facebookincubator/orgs","repos_url":"https://api.github.com/users/facebookincubator/repos","events_url":"https://api.github.com/users/facebookincubator/events{/privacy}","received_events_url":"https://api.github.com/users/facebookincubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookincubator/profilo","description":"A library for performance traces from production.","fork":false,"url":"https://api.github.com/repos/facebookincubator/profilo","forks_url":"https://api.github.com/repos/facebookincubator/profilo/forks","keys_url":"https://api.github.com/repos/facebookincubator/profilo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookincubator/profilo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookincubator/profilo/teams","hooks_url":"https://api.github.com/repos/facebookincubator/profilo/hooks","issue_events_url":"https://api.github.com/repos/facebookincubator/profilo/issues/events{/number}","events_url":"https://api.github.com/repos/facebookincubator/profilo/events","assignees_url":"https://api.github.com/repos/facebookincubator/profilo/assignees{/user}","branches_url":"https://api.github.com/repos/facebookincubator/profilo/branches{/branch}","tags_url":"https://api.github.com/repos/facebookincubator/profilo/tags","blobs_url":"https://api.github.com/repos/facebookincubator/profilo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookincubator/profilo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookincubator/profilo/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookincubator/profilo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookincubator/profilo/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookincubator/profilo/languages","stargazers_url":"https://api.github.com/repos/facebookincubator/profilo/stargazers","contributors_url":"https://api.github.com/repos/facebookincubator/profilo/contributors","subscribers_url":"https://api.github.com/repos/facebookincubator/profilo/subscribers","subscription_url":"https://api.github.com/repos/facebookincubator/profilo/subscription","commits_url":"https://api.github.com/repos/facebookincubator/profilo/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookincubator/profilo/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookincubator/profilo/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookincubator/profilo/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookincubator/profilo/contents/{+path}","compare_url":"https://api.github.com/repos/facebookincubator/profilo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookincubator/profilo/merges","archive_url":"https://api.github.com/repos/facebookincubator/profilo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookincubator/profilo/downloads","issues_url":"https://api.github.com/repos/facebookincubator/profilo/issues{/number}","pulls_url":"https://api.github.com/repos/facebookincubator/profilo/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookincubator/profilo/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookincubator/profilo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookincubator/profilo/labels{/name}","releases_url":"https://api.github.com/repos/facebookincubator/profilo/releases{/id}","deployments_url":"https://api.github.com/repos/facebookincubator/profilo/deployments","created_at":"2017-09-15T02:18:28Z","updated_at":"2018-05-17T20:52:26Z","pushed_at":"2018-05-17T21:10:29Z","git_url":"git://github.com/facebookincubator/profilo.git","ssh_url":"git@github.com:facebookincubator/profilo.git","clone_url":"https://github.com/facebookincubator/profilo.git","svn_url":"https://github.com/facebookincubator/profilo","homepage":"https://facebookincubator.github.io/profilo","size":9632,"stargazers_count":357,"watchers_count":357,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":21,"open_issues":0,"watchers":357,"default_branch":"master"}},"base":{"label":"dstmath:master","ref":"master","sha":"baf5dc872507b42907dd4d06f38be4d519872b35","user":{"login":"dstmath","id":2055240,"avatar_url":"https://avatars2.githubusercontent.com/u/2055240?v=4","gravatar_id":"","url":"https://api.github.com/users/dstmath","html_url":"https://github.com/dstmath","followers_url":"https://api.github.com/users/dstmath/followers","following_url":"https://api.github.com/users/dstmath/following{/other_user}","gists_url":"https://api.github.com/users/dstmath/gists{/gist_id}","starred_url":"https://api.github.com/users/dstmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstmath/subscriptions","organizations_url":"https://api.github.com/users/dstmath/orgs","repos_url":"https://api.github.com/users/dstmath/repos","events_url":"https://api.github.com/users/dstmath/events{/privacy}","received_events_url":"https://api.github.com/users/dstmath/received_events","type":"User","site_admin":false},"repo":{"id":125155273,"name":"profilo","full_name":"dstmath/profilo","owner":{"login":"dstmath","id":2055240,"avatar_url":"https://avatars2.githubusercontent.com/u/2055240?v=4","gravatar_id":"","url":"https://api.github.com/users/dstmath","html_url":"https://github.com/dstmath","followers_url":"https://api.github.com/users/dstmath/followers","following_url":"https://api.github.com/users/dstmath/following{/other_user}","gists_url":"https://api.github.com/users/dstmath/gists{/gist_id}","starred_url":"https://api.github.com/users/dstmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstmath/subscriptions","organizations_url":"https://api.github.com/users/dstmath/orgs","repos_url":"https://api.github.com/users/dstmath/repos","events_url":"https://api.github.com/users/dstmath/events{/privacy}","received_events_url":"https://api.github.com/users/dstmath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dstmath/profilo","description":"A library for performance traces from production.","fork":true,"url":"https://api.github.com/repos/dstmath/profilo","forks_url":"https://api.github.com/repos/dstmath/profilo/forks","keys_url":"https://api.github.com/repos/dstmath/profilo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dstmath/profilo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dstmath/profilo/teams","hooks_url":"https://api.github.com/repos/dstmath/profilo/hooks","issue_events_url":"https://api.github.com/repos/dstmath/profilo/issues/events{/number}","events_url":"https://api.github.com/repos/dstmath/profilo/events","assignees_url":"https://api.github.com/repos/dstmath/profilo/assignees{/user}","branches_url":"https://api.github.com/repos/dstmath/profilo/branches{/branch}","tags_url":"https://api.github.com/repos/dstmath/profilo/tags","blobs_url":"https://api.github.com/repos/dstmath/profilo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dstmath/profilo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dstmath/profilo/git/refs{/sha}","trees_url":"https://api.github.com/repos/dstmath/profilo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dstmath/profilo/statuses/{sha}","languages_url":"https://api.github.com/repos/dstmath/profilo/languages","stargazers_url":"https://api.github.com/repos/dstmath/profilo/stargazers","contributors_url":"https://api.github.com/repos/dstmath/profilo/contributors","subscribers_url":"https://api.github.com/repos/dstmath/profilo/subscribers","subscription_url":"https://api.github.com/repos/dstmath/profilo/subscription","commits_url":"https://api.github.com/repos/dstmath/profilo/commits{/sha}","git_commits_url":"https://api.github.com/repos/dstmath/profilo/git/commits{/sha}","comments_url":"https://api.github.com/repos/dstmath/profilo/comments{/number}","issue_comment_url":"https://api.github.com/repos/dstmath/profilo/issues/comments{/number}","contents_url":"https://api.github.com/repos/dstmath/profilo/contents/{+path}","compare_url":"https://api.github.com/repos/dstmath/profilo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dstmath/profilo/merges","archive_url":"https://api.github.com/repos/dstmath/profilo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dstmath/profilo/downloads","issues_url":"https://api.github.com/repos/dstmath/profilo/issues{/number}","pulls_url":"https://api.github.com/repos/dstmath/profilo/pulls{/number}","milestones_url":"https://api.github.com/repos/dstmath/profilo/milestones{/number}","notifications_url":"https://api.github.com/repos/dstmath/profilo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dstmath/profilo/labels{/name}","releases_url":"https://api.github.com/repos/dstmath/profilo/releases{/id}","deployments_url":"https://api.github.com/repos/dstmath/profilo/deployments","created_at":"2018-03-14T04:30:10Z","updated_at":"2018-05-17T07:36:49Z","pushed_at":"2018-05-18T00:37:46Z","git_url":"git://github.com/dstmath/profilo.git","ssh_url":"git@github.com:dstmath/profilo.git","clone_url":"https://github.com/dstmath/profilo.git","svn_url":"https://github.com/dstmath/profilo","homepage":null,"size":9592,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dstmath/profilo/pulls/15"},"html":{"href":"https://github.com/dstmath/profilo/pull/15"},"issue":{"href":"https://api.github.com/repos/dstmath/profilo/issues/15"},"comments":{"href":"https://api.github.com/repos/dstmath/profilo/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/dstmath/profilo/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/dstmath/profilo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dstmath/profilo/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/dstmath/profilo/statuses/b84909341f5076c4a35a6459b2ab0deada4afec3"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dstmath","id":2055240,"avatar_url":"https://avatars2.githubusercontent.com/u/2055240?v=4","gravatar_id":"","url":"https://api.github.com/users/dstmath","html_url":"https://github.com/dstmath","followers_url":"https://api.github.com/users/dstmath/followers","following_url":"https://api.github.com/users/dstmath/following{/other_user}","gists_url":"https://api.github.com/users/dstmath/gists{/gist_id}","starred_url":"https://api.github.com/users/dstmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstmath/subscriptions","organizations_url":"https://api.github.com/users/dstmath/orgs","repos_url":"https://api.github.com/users/dstmath/repos","events_url":"https://api.github.com/users/dstmath/events{/privacy}","received_events_url":"https://api.github.com/users/dstmath/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1704,"deletions":925,"changed_files":26}}
{"actor":{"display_login":"dstmath"}}