{"action":"closed","number":420,"pull_request":{"url":"https://api.github.com/repos/sky-uk/toolkit/pulls/420","id":188378097,"html_url":"https://github.com/sky-uk/toolkit/pull/420","diff_url":"https://github.com/sky-uk/toolkit/pull/420.diff","patch_url":"https://github.com/sky-uk/toolkit/pull/420.patch","issue_url":"https://api.github.com/repos/sky-uk/toolkit/issues/420","number":420,"state":"closed","locked":false,"title":"Import `sky-toolkit-core/tools` in Modal ","user":{"login":"joebell93","id":7349341,"avatar_url":"https://avatars3.githubusercontent.com/u/7349341?v=4","gravatar_id":"","url":"https://api.github.com/users/joebell93","html_url":"https://github.com/joebell93","followers_url":"https://api.github.com/users/joebell93/followers","following_url":"https://api.github.com/users/joebell93/following{/other_user}","gists_url":"https://api.github.com/users/joebell93/gists{/gist_id}","starred_url":"https://api.github.com/users/joebell93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joebell93/subscriptions","organizations_url":"https://api.github.com/users/joebell93/orgs","repos_url":"https://api.github.com/users/joebell93/repos","events_url":"https://api.github.com/users/joebell93/events{/privacy}","received_events_url":"https://api.github.com/users/joebell93/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nAll of our components should begin with a `sky-toolkit-core/tools` import for ease-of-use. Looks like this component slipped through the review process.\r\n\r\n## Related Issue\r\n\r\n#419 \r\n\r\n\r\n## Motivation and Context\r\n\r\nCausing import issues for consumers who are expecting each component to contain the necessary core settings/tools.\r\n\r\n## How Has This Been Tested?\r\n\r\nAll tests pass, no change in outputted markup.\r\n\r\nThis should present no breaking change due to `tools` containing no outputted styles.\r\n\r\n## Types of Changes\r\n\r\nWhat types of changes does your code introduce? Put an `x` in all the boxes that apply:\r\n\r\n- [ ] Internal *(framework-only)*\r\n- [x] Bug Fix *(non-breaking change which fixes an issue)*\r\n- [ ] New Feature *(non-breaking change which adds functionality)*\r\n- [ ] Breaking change *(fix or feature that would cause existing functionality to change)*\r\n\r\n## Browser Support\r\n\r\nN/A\r\n\r\n## Checklist\r\n\r\n- [x] All **design and code** conforms to the [Design Contribution Guidelines](https://github.com/sky-uk/toolkit/blob/develop/CONTRIBUTING.md#design-contributions).\r\n- [x] New functions and mixins have appropriate tests.\r\n- [x] All new and existing tests passed.\r\n- [x] I have added instructions on how to test my changes.\r\n","created_at":"2018-05-16T09:55:18Z","updated_at":"2018-05-16T10:13:27Z","closed_at":"2018-05-16T10:13:26Z","merged_at":"2018-05-16T10:13:26Z","merge_commit_sha":"5fc4c982b240f4e4bb3dbab5e7be1797145a27da","assignee":{"login":"joebell93","id":7349341,"avatar_url":"https://avatars3.githubusercontent.com/u/7349341?v=4","gravatar_id":"","url":"https://api.github.com/users/joebell93","html_url":"https://github.com/joebell93","followers_url":"https://api.github.com/users/joebell93/followers","following_url":"https://api.github.com/users/joebell93/following{/other_user}","gists_url":"https://api.github.com/users/joebell93/gists{/gist_id}","starred_url":"https://api.github.com/users/joebell93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joebell93/subscriptions","organizations_url":"https://api.github.com/users/joebell93/orgs","repos_url":"https://api.github.com/users/joebell93/repos","events_url":"https://api.github.com/users/joebell93/events{/privacy}","received_events_url":"https://api.github.com/users/joebell93/received_events","type":"User","site_admin":false},"assignees":[{"login":"joebell93","id":7349341,"avatar_url":"https://avatars3.githubusercontent.com/u/7349341?v=4","gravatar_id":"","url":"https://api.github.com/users/joebell93","html_url":"https://github.com/joebell93","followers_url":"https://api.github.com/users/joebell93/followers","following_url":"https://api.github.com/users/joebell93/following{/other_user}","gists_url":"https://api.github.com/users/joebell93/gists{/gist_id}","starred_url":"https://api.github.com/users/joebell93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joebell93/subscriptions","organizations_url":"https://api.github.com/users/joebell93/orgs","repos_url":"https://api.github.com/users/joebell93/repos","events_url":"https://api.github.com/users/joebell93/events{/privacy}","received_events_url":"https://api.github.com/users/joebell93/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":321966438,"url":"https://api.github.com/repos/sky-uk/toolkit/labels/bug","name":"bug","color":"e99695","default":true},{"id":554261334,"url":"https://api.github.com/repos/sky-uk/toolkit/labels/toolkit-ui","name":"toolkit-ui","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sky-uk/toolkit/pulls/420/commits","review_comments_url":"https://api.github.com/repos/sky-uk/toolkit/pulls/420/comments","review_comment_url":"https://api.github.com/repos/sky-uk/toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sky-uk/toolkit/issues/420/comments","statuses_url":"https://api.github.com/repos/sky-uk/toolkit/statuses/d90bd08f5d1aa01efcc2c81b9b3be7d7143c9a23","head":{"label":"sky-uk:tkt-419","ref":"tkt-419","sha":"d90bd08f5d1aa01efcc2c81b9b3be7d7143c9a23","user":{"login":"sky-uk","id":1391938,"avatar_url":"https://avatars1.githubusercontent.com/u/1391938?v=4","gravatar_id":"","url":"https://api.github.com/users/sky-uk","html_url":"https://github.com/sky-uk","followers_url":"https://api.github.com/users/sky-uk/followers","following_url":"https://api.github.com/users/sky-uk/following{/other_user}","gists_url":"https://api.github.com/users/sky-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/sky-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sky-uk/subscriptions","organizations_url":"https://api.github.com/users/sky-uk/orgs","repos_url":"https://api.github.com/users/sky-uk/repos","events_url":"https://api.github.com/users/sky-uk/events{/privacy}","received_events_url":"https://api.github.com/users/sky-uk/received_events","type":"Organization","site_admin":false},"repo":{"id":51140534,"name":"toolkit","full_name":"sky-uk/toolkit","owner":{"login":"sky-uk","id":1391938,"avatar_url":"https://avatars1.githubusercontent.com/u/1391938?v=4","gravatar_id":"","url":"https://api.github.com/users/sky-uk","html_url":"https://github.com/sky-uk","followers_url":"https://api.github.com/users/sky-uk/followers","following_url":"https://api.github.com/users/sky-uk/following{/other_user}","gists_url":"https://api.github.com/users/sky-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/sky-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sky-uk/subscriptions","organizations_url":"https://api.github.com/users/sky-uk/orgs","repos_url":"https://api.github.com/users/sky-uk/repos","events_url":"https://api.github.com/users/sky-uk/events{/privacy}","received_events_url":"https://api.github.com/users/sky-uk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sky-uk/toolkit","description":"Sky's CSS Toolkit","fork":false,"url":"https://api.github.com/repos/sky-uk/toolkit","forks_url":"https://api.github.com/repos/sky-uk/toolkit/forks","keys_url":"https://api.github.com/repos/sky-uk/toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sky-uk/toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sky-uk/toolkit/teams","hooks_url":"https://api.github.com/repos/sky-uk/toolkit/hooks","issue_events_url":"https://api.github.com/repos/sky-uk/toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/sky-uk/toolkit/events","assignees_url":"https://api.github.com/repos/sky-uk/toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/sky-uk/toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/sky-uk/toolkit/tags","blobs_url":"https://api.github.com/repos/sky-uk/toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sky-uk/toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sky-uk/toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/sky-uk/toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sky-uk/toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/sky-uk/toolkit/languages","stargazers_url":"https://api.github.com/repos/sky-uk/toolkit/stargazers","contributors_url":"https://api.github.com/repos/sky-uk/toolkit/contributors","subscribers_url":"https://api.github.com/repos/sky-uk/toolkit/subscribers","subscription_url":"https://api.github.com/repos/sky-uk/toolkit/subscription","commits_url":"https://api.github.com/repos/sky-uk/toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/sky-uk/toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/sky-uk/toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/sky-uk/toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/sky-uk/toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/sky-uk/toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sky-uk/toolkit/merges","archive_url":"https://api.github.com/repos/sky-uk/toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sky-uk/toolkit/downloads","issues_url":"https://api.github.com/repos/sky-uk/toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/sky-uk/toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/sky-uk/toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/sky-uk/toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sky-uk/toolkit/labels{/name}","releases_url":"https://api.github.com/repos/sky-uk/toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/sky-uk/toolkit/deployments","created_at":"2016-02-05T10:35:04Z","updated_at":"2018-05-16T09:38:38Z","pushed_at":"2018-05-16T10:13:26Z","git_url":"git://github.com/sky-uk/toolkit.git","ssh_url":"git@github.com:sky-uk/toolkit.git","clone_url":"https://github.com/sky-uk/toolkit.git","svn_url":"https://github.com/sky-uk/toolkit","homepage":"http://sky.com/toolkit","size":1558,"stargazers_count":89,"watchers_count":89,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":8,"open_issues":28,"watchers":89,"default_branch":"develop"}},"base":{"label":"sky-uk:develop","ref":"develop","sha":"1b10cf86ce2cb670876f99dbc71c0622e002c991","user":{"login":"sky-uk","id":1391938,"avatar_url":"https://avatars1.githubusercontent.com/u/1391938?v=4","gravatar_id":"","url":"https://api.github.com/users/sky-uk","html_url":"https://github.com/sky-uk","followers_url":"https://api.github.com/users/sky-uk/followers","following_url":"https://api.github.com/users/sky-uk/following{/other_user}","gists_url":"https://api.github.com/users/sky-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/sky-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sky-uk/subscriptions","organizations_url":"https://api.github.com/users/sky-uk/orgs","repos_url":"https://api.github.com/users/sky-uk/repos","events_url":"https://api.github.com/users/sky-uk/events{/privacy}","received_events_url":"https://api.github.com/users/sky-uk/received_events","type":"Organization","site_admin":false},"repo":{"id":51140534,"name":"toolkit","full_name":"sky-uk/toolkit","owner":{"login":"sky-uk","id":1391938,"avatar_url":"https://avatars1.githubusercontent.com/u/1391938?v=4","gravatar_id":"","url":"https://api.github.com/users/sky-uk","html_url":"https://github.com/sky-uk","followers_url":"https://api.github.com/users/sky-uk/followers","following_url":"https://api.github.com/users/sky-uk/following{/other_user}","gists_url":"https://api.github.com/users/sky-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/sky-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sky-uk/subscriptions","organizations_url":"https://api.github.com/users/sky-uk/orgs","repos_url":"https://api.github.com/users/sky-uk/repos","events_url":"https://api.github.com/users/sky-uk/events{/privacy}","received_events_url":"https://api.github.com/users/sky-uk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sky-uk/toolkit","description":"Sky's CSS Toolkit","fork":false,"url":"https://api.github.com/repos/sky-uk/toolkit","forks_url":"https://api.github.com/repos/sky-uk/toolkit/forks","keys_url":"https://api.github.com/repos/sky-uk/toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sky-uk/toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sky-uk/toolkit/teams","hooks_url":"https://api.github.com/repos/sky-uk/toolkit/hooks","issue_events_url":"https://api.github.com/repos/sky-uk/toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/sky-uk/toolkit/events","assignees_url":"https://api.github.com/repos/sky-uk/toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/sky-uk/toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/sky-uk/toolkit/tags","blobs_url":"https://api.github.com/repos/sky-uk/toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sky-uk/toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sky-uk/toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/sky-uk/toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sky-uk/toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/sky-uk/toolkit/languages","stargazers_url":"https://api.github.com/repos/sky-uk/toolkit/stargazers","contributors_url":"https://api.github.com/repos/sky-uk/toolkit/contributors","subscribers_url":"https://api.github.com/repos/sky-uk/toolkit/subscribers","subscription_url":"https://api.github.com/repos/sky-uk/toolkit/subscription","commits_url":"https://api.github.com/repos/sky-uk/toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/sky-uk/toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/sky-uk/toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/sky-uk/toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/sky-uk/toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/sky-uk/toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sky-uk/toolkit/merges","archive_url":"https://api.github.com/repos/sky-uk/toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sky-uk/toolkit/downloads","issues_url":"https://api.github.com/repos/sky-uk/toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/sky-uk/toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/sky-uk/toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/sky-uk/toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sky-uk/toolkit/labels{/name}","releases_url":"https://api.github.com/repos/sky-uk/toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/sky-uk/toolkit/deployments","created_at":"2016-02-05T10:35:04Z","updated_at":"2018-05-16T09:38:38Z","pushed_at":"2018-05-16T10:13:26Z","git_url":"git://github.com/sky-uk/toolkit.git","ssh_url":"git@github.com:sky-uk/toolkit.git","clone_url":"https://github.com/sky-uk/toolkit.git","svn_url":"https://github.com/sky-uk/toolkit","homepage":"http://sky.com/toolkit","size":1558,"stargazers_count":89,"watchers_count":89,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":8,"open_issues":28,"watchers":89,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sky-uk/toolkit/pulls/420"},"html":{"href":"https://github.com/sky-uk/toolkit/pull/420"},"issue":{"href":"https://api.github.com/repos/sky-uk/toolkit/issues/420"},"comments":{"href":"https://api.github.com/repos/sky-uk/toolkit/issues/420/comments"},"review_comments":{"href":"https://api.github.com/repos/sky-uk/toolkit/pulls/420/comments"},"review_comment":{"href":"https://api.github.com/repos/sky-uk/toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sky-uk/toolkit/pulls/420/commits"},"statuses":{"href":"https://api.github.com/repos/sky-uk/toolkit/statuses/d90bd08f5d1aa01efcc2c81b9b3be7d7143c9a23"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"joebell93","id":7349341,"avatar_url":"https://avatars3.githubusercontent.com/u/7349341?v=4","gravatar_id":"","url":"https://api.github.com/users/joebell93","html_url":"https://github.com/joebell93","followers_url":"https://api.github.com/users/joebell93/followers","following_url":"https://api.github.com/users/joebell93/following{/other_user}","gists_url":"https://api.github.com/users/joebell93/gists{/gist_id}","starred_url":"https://api.github.com/users/joebell93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joebell93/subscriptions","organizations_url":"https://api.github.com/users/joebell93/orgs","repos_url":"https://api.github.com/users/joebell93/repos","events_url":"https://api.github.com/users/joebell93/events{/privacy}","received_events_url":"https://api.github.com/users/joebell93/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"joebell93"}}