{"action":"created","issue":{"url":"https://api.github.com/repos/faucetsdn/faucet/issues/2541","repository_url":"https://api.github.com/repos/faucetsdn/faucet","labels_url":"https://api.github.com/repos/faucetsdn/faucet/issues/2541/labels{/name}","comments_url":"https://api.github.com/repos/faucetsdn/faucet/issues/2541/comments","events_url":"https://api.github.com/repos/faucetsdn/faucet/issues/2541/events","html_url":"https://github.com/faucetsdn/faucet/pull/2541","id":365189304,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTgyOTgx","number":2541,"title":"Manager base","user":{"login":"KitL","id":1981461,"node_id":"MDQ6VXNlcjE5ODE0NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1981461?v=4","gravatar_id":"","url":"https://api.github.com/users/KitL","html_url":"https://github.com/KitL","followers_url":"https://api.github.com/users/KitL/followers","following_url":"https://api.github.com/users/KitL/following{/other_user}","gists_url":"https://api.github.com/users/KitL/gists{/gist_id}","starred_url":"https://api.github.com/users/KitL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KitL/subscriptions","organizations_url":"https://api.github.com/users/KitL/orgs","repos_url":"https://api.github.com/users/KitL/repos","events_url":"https://api.github.com/users/KitL/events{/privacy}","received_events_url":"https://api.github.com/users/KitL/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-30T03:51:26Z","updated_at":"2018-09-30T05:00:52Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/faucetsdn/faucet/pulls/2541","html_url":"https://github.com/faucetsdn/faucet/pull/2541","diff_url":"https://github.com/faucetsdn/faucet/pull/2541.diff","patch_url":"https://github.com/faucetsdn/faucet/pull/2541.patch"},"body":"Builds on https://github.com/faucetsdn/faucet/pull/2540\r\n\r\nCreates a base class for ValveManager classes.\r\n\r\nCall initialise_tables on all ValveManagers\r\n\r\nin valve_host initialise the eth_src table with a single match all rule for mac learning rather than individual rules for each vlan."},"comment":{"url":"https://api.github.com/repos/faucetsdn/faucet/issues/comments/425694922","html_url":"https://github.com/faucetsdn/faucet/pull/2541#issuecomment-425694922","issue_url":"https://api.github.com/repos/faucetsdn/faucet/issues/2541","id":425694922,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTY5NDkyMg==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-09-30T05:00:52Z","updated_at":"2018-09-30T05:00:52Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/faucetsdn/faucet/pull/2541?src=pr&el=h1) Report\n> Merging [#2541](https://codecov.io/gh/faucetsdn/faucet/pull/2541?src=pr&el=desc) into [master](https://codecov.io/gh/faucetsdn/faucet/commit/1f11ffe521ea54a45f58d9ebd7ce67a2c95a7159?src=pr&el=desc) will **increase** coverage by `0.04%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/faucetsdn/faucet/pull/2541/graphs/tree.svg?width=650&token=hM3y5STxWR&height=150&src=pr)](https://codecov.io/gh/faucetsdn/faucet/pull/2541?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #2541      +/-   ##\n==========================================\n+ Coverage   92.31%   92.35%   +0.04%     \n==========================================\n  Files          41       42       +1     \n  Lines        5984     6007      +23     \n==========================================\n+ Hits         5524     5548      +24     \n+ Misses        460      459       -1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/faucetsdn/faucet/pull/2541?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [faucet/valve\\_manager\\_base.py](https://codecov.io/gh/faucetsdn/faucet/pull/2541/diff?src=pr&el=tree#diff-ZmF1Y2V0L3ZhbHZlX21hbmFnZXJfYmFzZS5weQ==) | `100% <100%> (ø)` | |\n| [faucet/valve\\_host.py](https://codecov.io/gh/faucetsdn/faucet/pull/2541/diff?src=pr&el=tree#diff-ZmF1Y2V0L3ZhbHZlX2hvc3QucHk=) | `93.06% <100%> (+0.04%)` | :arrow_up: |\n| [faucet/valve\\_route.py](https://codecov.io/gh/faucetsdn/faucet/pull/2541/diff?src=pr&el=tree#diff-ZmF1Y2V0L3ZhbHZlX3JvdXRlLnB5) | `94.61% <100%> (+0.01%)` | :arrow_up: |\n| [faucet/valve\\_flood.py](https://codecov.io/gh/faucetsdn/faucet/pull/2541/diff?src=pr&el=tree#diff-ZmF1Y2V0L3ZhbHZlX2Zsb29kLnB5) | `87.44% <100%> (+0.36%)` | :arrow_up: |\n| [faucet/valve.py](https://codecov.io/gh/faucetsdn/faucet/pull/2541/diff?src=pr&el=tree#diff-ZmF1Y2V0L3ZhbHZlLnB5) | `94.65% <100%> (-0.04%)` | :arrow_down: |\n| [faucet/valve\\_pipeline.py](https://codecov.io/gh/faucetsdn/faucet/pull/2541/diff?src=pr&el=tree#diff-ZmF1Y2V0L3ZhbHZlX3BpcGVsaW5lLnB5) | `97.56% <100%> (+6.25%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/faucetsdn/faucet/pull/2541?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/faucetsdn/faucet/pull/2541?src=pr&el=footer). Last update [1f11ffe...88facdf](https://codecov.io/gh/faucetsdn/faucet/pull/2541?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}