{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/18514","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/18514/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/18514/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/18514/events","html_url":"https://github.com/facebook/react-native/pull/18514","id":307910566,"number":18514,"title":"Fixes facebook/react-native#9777 Add support for resource-id","user":{"login":"lightboys22","id":4530782,"avatar_url":"https://avatars3.githubusercontent.com/u/4530782?v=4","gravatar_id":"","url":"https://api.github.com/users/lightboys22","html_url":"https://github.com/lightboys22","followers_url":"https://api.github.com/users/lightboys22/followers","following_url":"https://api.github.com/users/lightboys22/following{/other_user}","gists_url":"https://api.github.com/users/lightboys22/gists{/gist_id}","starred_url":"https://api.github.com/users/lightboys22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightboys22/subscriptions","organizations_url":"https://api.github.com/users/lightboys22/orgs","repos_url":"https://api.github.com/users/lightboys22/repos","events_url":"https://api.github.com/users/lightboys22/events{/privacy}","received_events_url":"https://api.github.com/users/lightboys22/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-23T05:52:06Z","updated_at":"2018-03-23T05:52:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/18514","html_url":"https://github.com/facebook/react-native/pull/18514","diff_url":"https://github.com/facebook/react-native/pull/18514.diff","patch_url":"https://github.com/facebook/react-native/pull/18514.patch"},"body":"Track react tag using android.view.View.tag.  Allow developers to set resource id by setting component.testID\r\n\r\nThank you for sending the PR! We appreciate you spending the time to work on these changes. \r\nHelp us understand your motivation by explaining why you decided to make this change.\r\n\r\nThis pull request fixes the following issue.\r\nhttps://github.com/facebook/react-native/issues/9777\r\n\r\n## Test Plan\r\n\r\nFirst, you need to declare the resource id by creating /_your_android_studio_folder_/res/values/ids.xml\r\n\r\n```\r\n<?xml version=\"1.0\" encoding=\"utf-8\"?>\r\n<resources>\r\n    <item type=\"id\" name=\"my_test_id\"/>\r\n</resources>\r\n```\r\n\r\nSecond, set the testID of your component to a resource name.\r\n\r\n```\r\n<Button\r\n    onPress={onButtonPress}\r\n    title=\"Press Me\"\r\n    testID='test_id'\r\n    />\r\n```\r\n\r\nThird, run the app and observe the resource id using UIAutomator viewer (/Android/sdk/tools/bin/uiautomatorviewer)\r\n\r\n## Related PRs\r\n\r\nThis PR doesn't require a documentation change.\r\n\r\n## Release Notes\r\n\r\n[ANDROID] [BUGFIX] [com/facebook/react/uimanager/BaseViewManager] - Allow developers to set resource id by setting component.testID"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/375552718","html_url":"https://github.com/facebook/react-native/pull/18514#issuecomment-375552718","issue_url":"https://api.github.com/repos/facebook/react-native/issues/18514","id":375552718,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars3.githubusercontent.com/u/6422482?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T05:52:29Z","updated_at":"2018-03-23T05:52:29Z","author_association":"NONE","body":"Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need the corporate CLA signed.\n\nIf you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Freact-native%20%2318514). Thanks!"}}
{"actor":{"display_login":"facebook-github-bot"}}