{"action":"closed","issue":{"url":"https://api.github.com/repos/modelica/fmi-standard/issues/74","repository_url":"https://api.github.com/repos/modelica/fmi-standard","labels_url":"https://api.github.com/repos/modelica/fmi-standard/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/modelica/fmi-standard/issues/74/comments","events_url":"https://api.github.com/repos/modelica/fmi-standard/issues/74/events","html_url":"https://github.com/modelica/fmi-standard/issues/74","id":370752544,"node_id":"MDU6SXNzdWUzNzA3NTI1NDQ=","number":74,"title":"Error in displayUnit definition in FMI 1.0 standard","user":{"login":"modelica-trac-importer","id":22202507,"node_id":"MDQ6VXNlcjIyMjAyNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/22202507?v=4","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"labels":[{"id":1093397692,"node_id":"MDU6TGFiZWwxMDkzMzk3Njky","url":"https://api.github.com/repos/modelica/fmi-standard/labels/P:%20minor","name":"P: minor","color":"dcffff","default":false},{"id":1046392991,"node_id":"MDU6TGFiZWwxMDQ2MzkyOTkx","url":"https://api.github.com/repos/modelica/fmi-standard/labels/bug","name":"bug","color":"d73a4a","default":true},{"id":1093395658,"node_id":"MDU6TGFiZWwxMDkzMzk1NjU4","url":"https://api.github.com/repos/modelica/fmi-standard/labels/specification","name":"specification","color":"0000aa","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/modelica/fmi-standard/milestones/8","html_url":"https://github.com/modelica/fmi-standard/milestone/8","labels_url":"https://api.github.com/repos/modelica/fmi-standard/milestones/8/labels","id":3743796,"node_id":"MDk6TWlsZXN0b25lMzc0Mzc5Ng==","number":8,"title":"FMI 1.0.1","description":"","creator":{"login":"modelica-trac-importer","id":22202507,"node_id":"MDQ6VXNlcjIyMjAyNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/22202507?v=4","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"closed","created_at":"2018-10-16T17:11:26Z","updated_at":"2018-10-16T19:00:56Z","due_on":null,"closed_at":"2018-10-16T17:11:26Z"},"comments":10,"created_at":"2018-10-16T18:57:40Z","updated_at":"2018-10-16T19:00:56Z","closed_at":"2018-10-16T19:00:56Z","author_association":"COLLABORATOR","body":"**Modified by andreas&#x2e;junghanns on 27 Mar 2014 08:08 UTC**\nDisplay unit definition in FMI 1.0 is incorrect. Section 3.1 FMI ME specification says:\n  a set of displayUnits is defined together with the conversion to the base unit according to the equation: \n  ```\n  unit = gain*displayUnit + offset \n  ```\n  `offset` is, e.g., needed for temperature units. The displayUnit definitions are used in the _ModelVariable_ element. Example for a definition: \n  ```\n  <BaseUnit unit=\"rad/s\"> \n  <DisplayUnitDefinition displayUnit=\"deg/s\" gain=57.2957795130823/>\n  ```\n\nThe provided equation is misleading and incorrect. It should read:\n```\ndisplayUnit = gain*unit + offset \n```\nThe issue had been fixed in FMI 2.0 specification and the attribute `gain` was renamed into `factor`. Section 2.2.2 of FMI 2.0 contains the equation:\n```\nDisplayUnit_value = factor*Unit_value + offset\n```\n\nIf updating the released specification is not desirable, I suggest that an errata document (or at least a web-page) is created and provided next to the released specification for FMI 1.0. \nI also suggest to change the attribute name `factor` in FMI 2.0 back to  `gain` to make the standards compatible.\n\n\n----\n\n**Reported by iakov&#x2e;nakhimovski on 5 Mar 2012 09:38 UTC**\nDisplay unit definition in FMI 1.0 is incorrect. Section 3.1 FMI ME specification says:\n  a set of displayUnits is defined together with the conversion to the base unit according to the equation: \n  ```\n  unit = gain*displayUnit + offset \n  ```\n  `offset` is, e.g., needed for temperature units. The displayUnit definitions are used in the _ModelVariable_ element. Example for a definition: \n  ```\n  <BaseUnit unit=\"rad/s\"> \n  <DisplayUnitDefinition displayUnit=\"deg/s\" gain=57.2957795130823/>\n  ```\n\nThe provided equation is misleading and incorrect. It should read:\n```\ndisplayUnit = gain*unit + offset \n```\nThe issue had been fixed in FMI 2.0 specification and the attribute `gain` was renamed into `factor`. Section 2.2.2 of FMI 2.0 contains the equation:\n```\nDisplayUnit_value = factor*Unit_value + offset\n```\n\nIf updating the released specification is not desirable, I suggest that an errata document (or at least a web-page) is created and provided next to the released specification for FMI 1.0. \nI also suggest to change the attribute name `factor` in FMI 2.0 back to  `gain` to make the standards compatible.\n\n\n----\n\nMigrated-From: https://trac.fmi-standard.org/ticket/74"}}
{"actor":{"display_login":"modelica-trac-importer"}}