{"action":"created","issue":{"url":"https://api.github.com/repos/BVLC/caffe/issues/1264","repository_url":"https://api.github.com/repos/BVLC/caffe","labels_url":"https://api.github.com/repos/BVLC/caffe/issues/1264/labels{/name}","comments_url":"https://api.github.com/repos/BVLC/caffe/issues/1264/comments","events_url":"https://api.github.com/repos/BVLC/caffe/issues/1264/events","html_url":"https://github.com/BVLC/caffe/pull/1264","id":45560312,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDc1NTY=","number":1264,"title":"Clean flaky code","user":{"login":"Yangqing","id":551151,"node_id":"MDQ6VXNlcjU1MTE1MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/551151?v=4","gravatar_id":"","url":"https://api.github.com/users/Yangqing","html_url":"https://github.com/Yangqing","followers_url":"https://api.github.com/users/Yangqing/followers","following_url":"https://api.github.com/users/Yangqing/following{/other_user}","gists_url":"https://api.github.com/users/Yangqing/gists{/gist_id}","starred_url":"https://api.github.com/users/Yangqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yangqing/subscriptions","organizations_url":"https://api.github.com/users/Yangqing/orgs","repos_url":"https://api.github.com/users/Yangqing/repos","events_url":"https://api.github.com/users/Yangqing/events{/privacy}","received_events_url":"https://api.github.com/users/Yangqing/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2014-10-11T19:43:03Z","updated_at":"2018-10-29T12:08:49Z","closed_at":"2014-10-12T00:41:48Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/BVLC/caffe/pulls/1264","html_url":"https://github.com/BVLC/caffe/pull/1264","diff_url":"https://github.com/BVLC/caffe/pull/1264.diff","patch_url":"https://github.com/BVLC/caffe/pull/1264.patch"},"body":"(1) Whether char is signed or unsigned is not defined by c++ standard, so it makes more sense to use int8_t to get sign values.\n\n(2) signbit returns a non-zero value when the sign bit is set, and we can't implicitly assume that it will be 1. This will cause problem when we directly assign it to e.g. a float value. Need to static cast the value to bool first.\n\n(3) Explicit instantiation is not needed when the whole function is defined in the header file.\n\n(4) Don't do EXPECT_EQ for float values. Always assume that there is numerical instability.\n"},"comment":{"url":"https://api.github.com/repos/BVLC/caffe/issues/comments/433886567","html_url":"https://github.com/BVLC/caffe/pull/1264#issuecomment-433886567","issue_url":"https://api.github.com/repos/BVLC/caffe/issues/1264","id":433886567,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzg4NjU2Nw==","user":{"login":"yulijun1234","id":35755920,"node_id":"MDQ6VXNlcjM1NzU1OTIw","avatar_url":"https://avatars0.githubusercontent.com/u/35755920?v=4","gravatar_id":"","url":"https://api.github.com/users/yulijun1234","html_url":"https://github.com/yulijun1234","followers_url":"https://api.github.com/users/yulijun1234/followers","following_url":"https://api.github.com/users/yulijun1234/following{/other_user}","gists_url":"https://api.github.com/users/yulijun1234/gists{/gist_id}","starred_url":"https://api.github.com/users/yulijun1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yulijun1234/subscriptions","organizations_url":"https://api.github.com/users/yulijun1234/orgs","repos_url":"https://api.github.com/users/yulijun1234/repos","events_url":"https://api.github.com/users/yulijun1234/events{/privacy}","received_events_url":"https://api.github.com/users/yulijun1234/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T12:08:49Z","updated_at":"2018-10-29T12:08:49Z","author_association":"NONE","body":"Makefile:427: target '.build_release/src/caffe/util/math_functions' doesn't match the target pattern\r\nmake: *** No rule to make target 'include/caffe/util/math_functions', needed by '.build_release/src/caffe/common.o'.  Stop.\r\n\r\nI have changed as mentioned above,but it comes with this problem. Can you give me some advice?"}}
{"actor":{"display_login":"yulijun1234"}}