{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/6871","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6871/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6871/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6871/events","html_url":"https://github.com/WordPress/gutenberg/pull/6871","id":324923673,"number":6871,"title":"Core blocks: Refactor Gallery and Image blocks to avoid RichText warnings","user":{"login":"gziolo","id":699132,"avatar_url":"https://avatars2.githubusercontent.com/u/699132?v=4","gravatar_id":"","url":"https://api.github.com/users/gziolo","html_url":"https://github.com/gziolo","followers_url":"https://api.github.com/users/gziolo/followers","following_url":"https://api.github.com/users/gziolo/following{/other_user}","gists_url":"https://api.github.com/users/gziolo/gists{/gist_id}","starred_url":"https://api.github.com/users/gziolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gziolo/subscriptions","organizations_url":"https://api.github.com/users/gziolo/orgs","repos_url":"https://api.github.com/users/gziolo/repos","events_url":"https://api.github.com/users/gziolo/events{/privacy}","received_events_url":"https://api.github.com/users/gziolo/received_events","type":"User","site_admin":false},"labels":[{"id":570263070,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/Blocks","name":"Blocks","color":"fbca04","default":false},{"id":930001208,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/Code%20Quality","name":"Code Quality","color":"e5e04b","default":false},{"id":598548627,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Component]%20Rich%20Text","name":"[Component] Rich Text","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"gziolo","id":699132,"avatar_url":"https://avatars2.githubusercontent.com/u/699132?v=4","gravatar_id":"","url":"https://api.github.com/users/gziolo","html_url":"https://github.com/gziolo","followers_url":"https://api.github.com/users/gziolo/followers","following_url":"https://api.github.com/users/gziolo/following{/other_user}","gists_url":"https://api.github.com/users/gziolo/gists{/gist_id}","starred_url":"https://api.github.com/users/gziolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gziolo/subscriptions","organizations_url":"https://api.github.com/users/gziolo/orgs","repos_url":"https://api.github.com/users/gziolo/repos","events_url":"https://api.github.com/users/gziolo/events{/privacy}","received_events_url":"https://api.github.com/users/gziolo/received_events","type":"User","site_admin":false},"assignees":[{"login":"gziolo","id":699132,"avatar_url":"https://avatars2.githubusercontent.com/u/699132?v=4","gravatar_id":"","url":"https://api.github.com/users/gziolo","html_url":"https://github.com/gziolo","followers_url":"https://api.github.com/users/gziolo/followers","following_url":"https://api.github.com/users/gziolo/following{/other_user}","gists_url":"https://api.github.com/users/gziolo/gists{/gist_id}","starred_url":"https://api.github.com/users/gziolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gziolo/subscriptions","organizations_url":"https://api.github.com/users/gziolo/orgs","repos_url":"https://api.github.com/users/gziolo/repos","events_url":"https://api.github.com/users/gziolo/events{/privacy}","received_events_url":"https://api.github.com/users/gziolo/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/WordPress/gutenberg/milestones/54","html_url":"https://github.com/WordPress/gutenberg/milestone/54","labels_url":"https://api.github.com/repos/WordPress/gutenberg/milestones/54/labels","id":3350800,"number":54,"title":"3.0","description":"","creator":{"login":"gziolo","id":699132,"avatar_url":"https://avatars2.githubusercontent.com/u/699132?v=4","gravatar_id":"","url":"https://api.github.com/users/gziolo","html_url":"https://github.com/gziolo","followers_url":"https://api.github.com/users/gziolo/followers","following_url":"https://api.github.com/users/gziolo/following{/other_user}","gists_url":"https://api.github.com/users/gziolo/gists{/gist_id}","starred_url":"https://api.github.com/users/gziolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gziolo/subscriptions","organizations_url":"https://api.github.com/users/gziolo/orgs","repos_url":"https://api.github.com/users/gziolo/repos","events_url":"https://api.github.com/users/gziolo/events{/privacy}","received_events_url":"https://api.github.com/users/gziolo/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":53,"state":"open","created_at":"2018-05-16T07:11:53Z","updated_at":"2018-05-29T15:14:17Z","due_on":"2018-05-31T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-05-21T13:51:17Z","updated_at":"2018-05-29T18:50:36Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/6871","html_url":"https://github.com/WordPress/gutenberg/pull/6871","diff_url":"https://github.com/WordPress/gutenberg/pull/6871.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/6871.patch"},"body":"## Description\r\nWith #6286 we have deprecated event proxying. \r\n\r\n@youknowriad discovered the following:\r\n> I wonder if we should introduce an explicit onFocus prop, it seems to be something commonly used across blocks even after #5039\r\n\r\nThis PR tries to fix it.\r\n\r\n## How has this been tested?\r\nMake sure that Image and Gallery blocks work like before and there are no warnings on JS console related to `RichText` component.\r\n\r\n## Types of changes\r\nRefactoring.\r\n\r\n## Checklist:\r\n- [x] My code is tested.\r\n- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->\r\n- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->\r\n- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->\r\n"},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/392895193","html_url":"https://github.com/WordPress/gutenberg/pull/6871#issuecomment-392895193","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6871","id":392895193,"user":{"login":"youknowriad","id":272444,"avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T18:50:36Z","updated_at":"2018-05-29T18:50:36Z","author_association":"CONTRIBUTOR","body":">  why not should we support automatic blur detection (complications therein notwithstanding), rather than putting the impetus on the developer (particularly when they've come to expect onFocus to be managed automatically)?\r\n\r\nThe issue is that sometimes RichText loses the focus but we still want to keep it selected. (Link modal, toolbar buttons), It's probably doable but not simple because of the fact that popovers show outside the RichText's node."}}
{"actor":{"display_login":"youknowriad"}}