{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/22361","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/22361/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/22361/comments","events_url":"https://api.github.com/repos/apache/spark/issues/22361/events","html_url":"https://github.com/apache/spark/pull/22361","id":358179121,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDE0NzY0","number":22361,"title":"Revert [SPARK-10399] [SPARK-23879] [SPARK-23762] [SPARK-25317]","user":{"login":"gatorsmile","id":11567269,"node_id":"MDQ6VXNlcjExNTY3MjY5","avatar_url":"https://avatars1.githubusercontent.com/u/11567269?v=4","gravatar_id":"","url":"https://api.github.com/users/gatorsmile","html_url":"https://github.com/gatorsmile","followers_url":"https://api.github.com/users/gatorsmile/followers","following_url":"https://api.github.com/users/gatorsmile/following{/other_user}","gists_url":"https://api.github.com/users/gatorsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gatorsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatorsmile/subscriptions","organizations_url":"https://api.github.com/users/gatorsmile/orgs","repos_url":"https://api.github.com/users/gatorsmile/repos","events_url":"https://api.github.com/users/gatorsmile/events{/privacy}","received_events_url":"https://api.github.com/users/gatorsmile/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-07T19:08:16Z","updated_at":"2018-09-08T02:43:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22361","html_url":"https://github.com/apache/spark/pull/22361","diff_url":"https://github.com/apache/spark/pull/22361.diff","patch_url":"https://github.com/apache/spark/pull/22361.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nWhen running TPC-DS benchmarks on 2.4 release, @npoggi and @winglungngai  saw more than 10% performance regression on the following queries: q67, q24a and q24b. After we applying the PR https://github.com/apache/spark/pull/22338, the performance regression still exists. If we revert the changes in https://github.com/apache/spark/pull/19222, @npoggi and @winglungngai  found the performance regression was resolved. Thus, this PR is to revert the related changes for unblocking the 2.4 release. \r\n\r\nIn the future release, we still can continue the investigation and find out the root cause of the regression. \r\n\r\n## How was this patch tested?\r\n\r\nThe existing test cases"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/419607024","html_url":"https://github.com/apache/spark/pull/22361#issuecomment-419607024","issue_url":"https://api.github.com/repos/apache/spark/issues/22361","id":419607024,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTYwNzAyNA==","user":{"login":"kiszk","id":1315079,"node_id":"MDQ6VXNlcjEzMTUwNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1315079?v=4","gravatar_id":"","url":"https://api.github.com/users/kiszk","html_url":"https://github.com/kiszk","followers_url":"https://api.github.com/users/kiszk/followers","following_url":"https://api.github.com/users/kiszk/following{/other_user}","gists_url":"https://api.github.com/users/kiszk/gists{/gist_id}","starred_url":"https://api.github.com/users/kiszk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiszk/subscriptions","organizations_url":"https://api.github.com/users/kiszk/orgs","repos_url":"https://api.github.com/users/kiszk/repos","events_url":"https://api.github.com/users/kiszk/events{/privacy}","received_events_url":"https://api.github.com/users/kiszk/received_events","type":"User","site_admin":false},"created_at":"2018-09-08T02:43:39Z","updated_at":"2018-09-08T02:43:39Z","author_association":"CONTRIBUTOR","body":"@gatorsmile Overall, I agree with revert since performance degradation is confirmed.\r\n\r\nWhen I run the TPC-DS in #19222, I have not seen such a performance regression as [here](https://github.com/apache/spark/pull/19222#issuecomment-378154854). For future analysis, I am very interested in \r\n* execution time of each query\r\n* environment (machine, os, jvm, cluster or local, ...)\r\n* scaling factor,\r\n* # of repeats per query\r\n* others\r\n\r\n@npoggi and @winglungngai Thanks for your investigations. Would it be possible to share the avobe information?"}}
{"actor":{"display_login":"kiszk"}}