{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/218515188","pull_request_review_id":156471123,"id":218515188,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODUxNTE4OA==","diff_hunk":"@@ -52,6 +52,10 @@ static llvm::cl::opt<bool> TFPromoteGlobalVariables(\n         \"If enabled, promote global variables into SSA with a best \"\n         \"effort to minimize sends/recvs. This is a performance optimization.\"));\n \n+namespace llvm {\n+  extern cl::opt<bool> TFDynamicCompilation;","path":"lib/SILOptimizer/Mandatory/TFDeabstraction.cpp","position":5,"original_position":5,"commit_id":"56fedec6f39bc506e51c00d58dd238c235173495","original_commit_id":"56fedec6f39bc506e51c00d58dd238c235173495","user":{"login":"lattner","id":15152540,"node_id":"MDQ6VXNlcjE1MTUyNTQw","avatar_url":"https://avatars0.githubusercontent.com/u/15152540?v=4","gravatar_id":"","url":"https://api.github.com/users/lattner","html_url":"https://github.com/lattner","followers_url":"https://api.github.com/users/lattner/followers","following_url":"https://api.github.com/users/lattner/following{/other_user}","gists_url":"https://api.github.com/users/lattner/gists{/gist_id}","starred_url":"https://api.github.com/users/lattner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lattner/subscriptions","organizations_url":"https://api.github.com/users/lattner/orgs","repos_url":"https://api.github.com/users/lattner/repos","events_url":"https://api.github.com/users/lattner/events{/privacy}","received_events_url":"https://api.github.com/users/lattner/received_events","type":"User","site_admin":false},"body":"Is there a header file (in SILOpt/Mandatory) this can live in?","created_at":"2018-09-18T17:02:40Z","updated_at":"2018-09-18T17:02:40Z","html_url":"https://github.com/apple/swift/pull/19361#discussion_r218515188","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/19361","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/218515188"},"html":{"href":"https://github.com/apple/swift/pull/19361#discussion_r218515188"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/19361"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/19361","id":216196302,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MTk2MzAy","html_url":"https://github.com/apple/swift/pull/19361","diff_url":"https://github.com/apple/swift/pull/19361.diff","patch_url":"https://github.com/apple/swift/pull/19361.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/19361","number":19361,"state":"open","locked":false,"title":"enable named operands in graph_op","user":{"login":"marcrasi","id":5945760,"node_id":"MDQ6VXNlcjU5NDU3NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5945760?v=4","gravatar_id":"","url":"https://api.github.com/users/marcrasi","html_url":"https://github.com/marcrasi","followers_url":"https://api.github.com/users/marcrasi/followers","following_url":"https://api.github.com/users/marcrasi/following{/other_user}","gists_url":"https://api.github.com/users/marcrasi/gists{/gist_id}","starred_url":"https://api.github.com/users/marcrasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcrasi/subscriptions","organizations_url":"https://api.github.com/users/marcrasi/orgs","repos_url":"https://api.github.com/users/marcrasi/repos","events_url":"https://api.github.com/users/marcrasi/events{/privacy}","received_events_url":"https://api.github.com/users/marcrasi/received_events","type":"User","site_admin":false},"body":"* Enables named operands in graph_op, by extending graph_op's existing name mangling to handle named operands.\r\n* Makes tfdeabstraction emit named operands for unknown attributes, when -tf-dynamic-compilation is on.\r\n* Adds a dummy test to make sure that the named operand is getting all the way into the dynamic compilation IRGen.\r\n\r\nFuture work, for which I have just filed JIRAs, includes:\r\n1. Make the textual SIL nicer: e.g. `graph_op \"Foo\"(%0 : $Tensor<Float>, [ %1 : $Tensor<Float>, %2 : $Tensor<Float> ], value$tensor %3 : Float` instead of `graph_op \"Foo,i,L,e,e,ivalue$tensor\" (%0 : $Tensor<Float>, %1 : $Tensor<Float>, %2 : $Tensor<Float>, %3 : Float)`. (https://bugs.swift.org/browse/SR-8783)\r\n2. Make a nicer C++ interface to GraphOperationInst so that we don't have to deal with the mangling everywhere. (https://bugs.swift.org/browse/SR-8784)\r\n3. Nested lists of `graph_op` operands. Do we need this? (https://bugs.swift.org/browse/SR-8785)\r\n4. Make SILGen generate `graph_op`s directly, and delete \"__tfop\" builtins. Change `formGraphOp` into a `graph_op` -> `graph_op` transformation. (https://bugs.swift.org/browse/SR-8786)","created_at":"2018-09-18T06:29:57Z","updated_at":"2018-09-18T17:02:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec17b03d6ffee1fdc9e3221e870e261cb88ef115","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mhong","id":969799,"node_id":"MDQ6VXNlcjk2OTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/969799?v=4","gravatar_id":"","url":"https://api.github.com/users/mhong","html_url":"https://github.com/mhong","followers_url":"https://api.github.com/users/mhong/followers","following_url":"https://api.github.com/users/mhong/following{/other_user}","gists_url":"https://api.github.com/users/mhong/gists{/gist_id}","starred_url":"https://api.github.com/users/mhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhong/subscriptions","organizations_url":"https://api.github.com/users/mhong/orgs","repos_url":"https://api.github.com/users/mhong/repos","events_url":"https://api.github.com/users/mhong/events{/privacy}","received_events_url":"https://api.github.com/users/mhong/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/19361/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/19361/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/19361/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/56fedec6f39bc506e51c00d58dd238c235173495","head":{"label":"marcrasi:graph-op-named-inputs","ref":"graph-op-named-inputs","sha":"56fedec6f39bc506e51c00d58dd238c235173495","user":{"login":"marcrasi","id":5945760,"node_id":"MDQ6VXNlcjU5NDU3NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5945760?v=4","gravatar_id":"","url":"https://api.github.com/users/marcrasi","html_url":"https://github.com/marcrasi","followers_url":"https://api.github.com/users/marcrasi/followers","following_url":"https://api.github.com/users/marcrasi/following{/other_user}","gists_url":"https://api.github.com/users/marcrasi/gists{/gist_id}","starred_url":"https://api.github.com/users/marcrasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcrasi/subscriptions","organizations_url":"https://api.github.com/users/marcrasi/orgs","repos_url":"https://api.github.com/users/marcrasi/repos","events_url":"https://api.github.com/users/marcrasi/events{/privacy}","received_events_url":"https://api.github.com/users/marcrasi/received_events","type":"User","site_admin":false},"repo":{"id":135738994,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3Mzg5OTQ=","name":"swift","full_name":"marcrasi/swift","private":false,"owner":{"login":"marcrasi","id":5945760,"node_id":"MDQ6VXNlcjU5NDU3NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5945760?v=4","gravatar_id":"","url":"https://api.github.com/users/marcrasi","html_url":"https://github.com/marcrasi","followers_url":"https://api.github.com/users/marcrasi/followers","following_url":"https://api.github.com/users/marcrasi/following{/other_user}","gists_url":"https://api.github.com/users/marcrasi/gists{/gist_id}","starred_url":"https://api.github.com/users/marcrasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcrasi/subscriptions","organizations_url":"https://api.github.com/users/marcrasi/orgs","repos_url":"https://api.github.com/users/marcrasi/repos","events_url":"https://api.github.com/users/marcrasi/events{/privacy}","received_events_url":"https://api.github.com/users/marcrasi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marcrasi/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/marcrasi/swift","forks_url":"https://api.github.com/repos/marcrasi/swift/forks","keys_url":"https://api.github.com/repos/marcrasi/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcrasi/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcrasi/swift/teams","hooks_url":"https://api.github.com/repos/marcrasi/swift/hooks","issue_events_url":"https://api.github.com/repos/marcrasi/swift/issues/events{/number}","events_url":"https://api.github.com/repos/marcrasi/swift/events","assignees_url":"https://api.github.com/repos/marcrasi/swift/assignees{/user}","branches_url":"https://api.github.com/repos/marcrasi/swift/branches{/branch}","tags_url":"https://api.github.com/repos/marcrasi/swift/tags","blobs_url":"https://api.github.com/repos/marcrasi/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcrasi/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcrasi/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcrasi/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcrasi/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/marcrasi/swift/languages","stargazers_url":"https://api.github.com/repos/marcrasi/swift/stargazers","contributors_url":"https://api.github.com/repos/marcrasi/swift/contributors","subscribers_url":"https://api.github.com/repos/marcrasi/swift/subscribers","subscription_url":"https://api.github.com/repos/marcrasi/swift/subscription","commits_url":"https://api.github.com/repos/marcrasi/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcrasi/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcrasi/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcrasi/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcrasi/swift/contents/{+path}","compare_url":"https://api.github.com/repos/marcrasi/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcrasi/swift/merges","archive_url":"https://api.github.com/repos/marcrasi/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcrasi/swift/downloads","issues_url":"https://api.github.com/repos/marcrasi/swift/issues{/number}","pulls_url":"https://api.github.com/repos/marcrasi/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/marcrasi/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/marcrasi/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcrasi/swift/labels{/name}","releases_url":"https://api.github.com/repos/marcrasi/swift/releases{/id}","deployments_url":"https://api.github.com/repos/marcrasi/swift/deployments","created_at":"2018-06-01T16:13:26Z","updated_at":"2018-06-01T16:13:59Z","pushed_at":"2018-09-18T06:01:23Z","git_url":"git://github.com/marcrasi/swift.git","ssh_url":"git@github.com:marcrasi/swift.git","clone_url":"https://github.com/marcrasi/swift.git","svn_url":"https://github.com/marcrasi/swift","homepage":"https://swift.org/","size":324756,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:tensorflow","ref":"tensorflow","sha":"bc3dbcda29cf542879d0dc925588949570425ea3","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-09-18T16:20:51Z","pushed_at":"2018-09-18T16:57:56Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":339207,"stargazers_count":45227,"watchers_count":45227,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7141,"mirror_url":null,"archived":false,"open_issues_count":382,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7141,"open_issues":382,"watchers":45227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/19361"},"html":{"href":"https://github.com/apple/swift/pull/19361"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/19361"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/19361/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/19361/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/19361/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/56fedec6f39bc506e51c00d58dd238c235173495"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lattner"}}