{"action":"created","comment":{"url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments/201077359","pull_request_review_id":135508514,"id":201077359,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTA3NzM1OQ==","diff_hunk":"@@ -16,16 +16,14 @@\n \n */\n \n-pragma solidity ^0.4.10;\n+pragma solidity 0.4.10;","path":"packages/contracts/src/2.0.0/protocol/AssetProxyOwner/AssetProxyOwner.sol","position":5,"original_position":5,"commit_id":"cbf17255b94e2888b10259c229db37174d8fd3d5","original_commit_id":"cbf17255b94e2888b10259c229db37174d8fd3d5","user":{"login":"abandeali1","id":18060168,"node_id":"MDQ6VXNlcjE4MDYwMTY4","avatar_url":"https://avatars0.githubusercontent.com/u/18060168?v=4","gravatar_id":"","url":"https://api.github.com/users/abandeali1","html_url":"https://github.com/abandeali1","followers_url":"https://api.github.com/users/abandeali1/followers","following_url":"https://api.github.com/users/abandeali1/following{/other_user}","gists_url":"https://api.github.com/users/abandeali1/gists{/gist_id}","starred_url":"https://api.github.com/users/abandeali1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abandeali1/subscriptions","organizations_url":"https://api.github.com/users/abandeali1/orgs","repos_url":"https://api.github.com/users/abandeali1/repos","events_url":"https://api.github.com/users/abandeali1/events{/privacy}","received_events_url":"https://api.github.com/users/abandeali1/received_events","type":"User","site_admin":false},"body":"The MultiSigWallet contracts have all been thoroughly audited with 0.4.10, so I'd rather not make any changes to their bytecode. Not really concerned about the efficiency of this contract since it will be used very infrequently.","created_at":"2018-07-09T17:03:33Z","updated_at":"2018-07-09T17:03:33Z","html_url":"https://github.com/0xProject/0x-monorepo/pull/837#discussion_r201077359","pull_request_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/837","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments/201077359"},"html":{"href":"https://github.com/0xProject/0x-monorepo/pull/837#discussion_r201077359"},"pull_request":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/837"}},"in_reply_to_id":201024029},"pull_request":{"url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/837","id":199849009,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODQ5MDA5","html_url":"https://github.com/0xProject/0x-monorepo/pull/837","diff_url":"https://github.com/0xProject/0x-monorepo/pull/837.diff","patch_url":"https://github.com/0xProject/0x-monorepo/pull/837.patch","issue_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/837","number":837,"state":"open","locked":false,"title":"Use 0.4.10 in AssetProxyOwner","user":{"login":"abandeali1","id":18060168,"node_id":"MDQ6VXNlcjE4MDYwMTY4","avatar_url":"https://avatars0.githubusercontent.com/u/18060168?v=4","gravatar_id":"","url":"https://api.github.com/users/abandeali1","html_url":"https://github.com/abandeali1","followers_url":"https://api.github.com/users/abandeali1/followers","following_url":"https://api.github.com/users/abandeali1/following{/other_user}","gists_url":"https://api.github.com/users/abandeali1/gists{/gist_id}","starred_url":"https://api.github.com/users/abandeali1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abandeali1/subscriptions","organizations_url":"https://api.github.com/users/abandeali1/orgs","repos_url":"https://api.github.com/users/abandeali1/repos","events_url":"https://api.github.com/users/abandeali1/events{/privacy}","received_events_url":"https://api.github.com/users/abandeali1/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\n- Hard codes Solidity 0.4.10 in `AssetProxyOwner`\r\n- Removes use of `LibBytes` and adds `readBytes4` function (`LibBytes` does not compile with 0.4.10)\r\n\r\n<!--- Describe your changes in detail -->\r\n\r\n## Testing instructions\r\n\r\n<!--- Please describe how reviewers can test your changes -->\r\n\r\n## Types of changes\r\n\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n\r\n*   [ ] Bug fix (non-breaking change which fixes an issue)\r\n*   [ ] New feature (non-breaking change which adds functionality)\r\n*   [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n*   [ ] Change requires a change to the documentation.\r\n*   [ ] Added tests to cover my changes.\r\n*   [ ] Added new entries to the relevant CHANGELOG.jsons.\r\n*   [ ] Labeled this PR with the 'WIP' label if it is a work in progress.\r\n*   [ ] Labeled this PR with the labels corresponding to the changed package.\r\n","created_at":"2018-07-06T21:15:04Z","updated_at":"2018-07-09T17:03:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82872a72f7617addd2ecaedb4298a72a3df62a91","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dekz","id":27389,"node_id":"MDQ6VXNlcjI3Mzg5","avatar_url":"https://avatars0.githubusercontent.com/u/27389?v=4","gravatar_id":"","url":"https://api.github.com/users/dekz","html_url":"https://github.com/dekz","followers_url":"https://api.github.com/users/dekz/followers","following_url":"https://api.github.com/users/dekz/following{/other_user}","gists_url":"https://api.github.com/users/dekz/gists{/gist_id}","starred_url":"https://api.github.com/users/dekz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dekz/subscriptions","organizations_url":"https://api.github.com/users/dekz/orgs","repos_url":"https://api.github.com/users/dekz/repos","events_url":"https://api.github.com/users/dekz/events{/privacy}","received_events_url":"https://api.github.com/users/dekz/received_events","type":"User","site_admin":false},{"login":"hysz","id":4369805,"node_id":"MDQ6VXNlcjQzNjk4MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/4369805?v=4","gravatar_id":"","url":"https://api.github.com/users/hysz","html_url":"https://github.com/hysz","followers_url":"https://api.github.com/users/hysz/followers","following_url":"https://api.github.com/users/hysz/following{/other_user}","gists_url":"https://api.github.com/users/hysz/gists{/gist_id}","starred_url":"https://api.github.com/users/hysz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hysz/subscriptions","organizations_url":"https://api.github.com/users/hysz/orgs","repos_url":"https://api.github.com/users/hysz/repos","events_url":"https://api.github.com/users/hysz/events{/privacy}","received_events_url":"https://api.github.com/users/hysz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/837/commits","review_comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/837/comments","review_comment_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/837/comments","statuses_url":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/cbf17255b94e2888b10259c229db37174d8fd3d5","head":{"label":"0xProject:fix/contracts/assetProxyOwnerVersion","ref":"fix/contracts/assetProxyOwnerVersion","sha":"cbf17255b94e2888b10259c229db37174d8fd3d5","user":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"node_id":"MDEwOlJlcG9zaXRvcnk5MjE4MTM3MQ==","name":"0x-monorepo","full_name":"0xProject/0x-monorepo","owner":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0xProject/0x-monorepo","description":"0x protocol monorepo - includes our smart contracts and many developer tools","fork":false,"url":"https://api.github.com/repos/0xProject/0x-monorepo","forks_url":"https://api.github.com/repos/0xProject/0x-monorepo/forks","keys_url":"https://api.github.com/repos/0xProject/0x-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x-monorepo/teams","hooks_url":"https://api.github.com/repos/0xProject/0x-monorepo/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x-monorepo/events","assignees_url":"https://api.github.com/repos/0xProject/0x-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/tags","blobs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x-monorepo/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x-monorepo/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x-monorepo/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscription","commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x-monorepo/merges","archive_url":"https://api.github.com/repos/0xProject/0x-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x-monorepo/downloads","issues_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x-monorepo/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2018-07-09T13:49:38Z","pushed_at":"2018-07-09T16:55:36Z","git_url":"git://github.com/0xProject/0x-monorepo.git","ssh_url":"git@github.com:0xProject/0x-monorepo.git","clone_url":"https://github.com/0xProject/0x-monorepo.git","svn_url":"https://github.com/0xProject/0x-monorepo","homepage":"","size":51605,"stargazers_count":718,"watchers_count":718,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":188,"open_issues":35,"watchers":718,"default_branch":"v2-prototype"}},"base":{"label":"0xProject:v2-prototype","ref":"v2-prototype","sha":"d22cff09765dd0f886f8933d2f7d3d53515c6beb","user":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"node_id":"MDEwOlJlcG9zaXRvcnk5MjE4MTM3MQ==","name":"0x-monorepo","full_name":"0xProject/0x-monorepo","owner":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0xProject/0x-monorepo","description":"0x protocol monorepo - includes our smart contracts and many developer tools","fork":false,"url":"https://api.github.com/repos/0xProject/0x-monorepo","forks_url":"https://api.github.com/repos/0xProject/0x-monorepo/forks","keys_url":"https://api.github.com/repos/0xProject/0x-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x-monorepo/teams","hooks_url":"https://api.github.com/repos/0xProject/0x-monorepo/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x-monorepo/events","assignees_url":"https://api.github.com/repos/0xProject/0x-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/tags","blobs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x-monorepo/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x-monorepo/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x-monorepo/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscription","commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x-monorepo/merges","archive_url":"https://api.github.com/repos/0xProject/0x-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x-monorepo/downloads","issues_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x-monorepo/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2018-07-09T13:49:38Z","pushed_at":"2018-07-09T16:55:36Z","git_url":"git://github.com/0xProject/0x-monorepo.git","ssh_url":"git@github.com:0xProject/0x-monorepo.git","clone_url":"https://github.com/0xProject/0x-monorepo.git","svn_url":"https://github.com/0xProject/0x-monorepo","homepage":"","size":51605,"stargazers_count":718,"watchers_count":718,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":188,"open_issues":35,"watchers":718,"default_branch":"v2-prototype"}},"_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/837"},"html":{"href":"https://github.com/0xProject/0x-monorepo/pull/837"},"issue":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/issues/837"},"comments":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/issues/837/comments"},"review_comments":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/837/comments"},"review_comment":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/837/commits"},"statuses":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/cbf17255b94e2888b10259c229db37174d8fd3d5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"abandeali1"}}