{"action":"created","issue":{"url":"https://api.github.com/repos/dnouri/skorch/issues/175","repository_url":"https://api.github.com/repos/dnouri/skorch","labels_url":"https://api.github.com/repos/dnouri/skorch/issues/175/labels{/name}","comments_url":"https://api.github.com/repos/dnouri/skorch/issues/175/comments","events_url":"https://api.github.com/repos/dnouri/skorch/issues/175/events","html_url":"https://github.com/dnouri/skorch/issues/175","id":313225575,"number":175,"title":"set_params with unknown attribute does not raise","user":{"login":"benjamin-work","id":29862381,"avatar_url":"https://avatars1.githubusercontent.com/u/29862381?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamin-work","html_url":"https://github.com/benjamin-work","followers_url":"https://api.github.com/users/benjamin-work/followers","following_url":"https://api.github.com/users/benjamin-work/following{/other_user}","gists_url":"https://api.github.com/users/benjamin-work/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamin-work/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamin-work/subscriptions","organizations_url":"https://api.github.com/users/benjamin-work/orgs","repos_url":"https://api.github.com/users/benjamin-work/repos","events_url":"https://api.github.com/users/benjamin-work/events{/privacy}","received_events_url":"https://api.github.com/users/benjamin-work/received_events","type":"User","site_admin":false},"labels":[{"id":649156582,"url":"https://api.github.com/repos/dnouri/skorch/labels/bug","name":"bug","color":"ee0701","default":true},{"id":914793957,"url":"https://api.github.com/repos/dnouri/skorch/labels/r0.3.0","name":"r0.3.0","color":"9ae577","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-11T08:39:41Z","updated_at":"2018-04-26T12:55:45Z","closed_at":null,"author_association":"COLLABORATOR","body":"We have an inconsistency with sklearn, namely that calling ~~a `NeuralNet`'s or~~ a `Callback`'s `set_params` with an unknown attribute just sets this attribute. In sklearn, a `ValueError` is raised:\r\n\r\n```ValueError: Invalid parameter foo for estimator LogisticRegression. Check the list of available parameters with `estimator.get_params().keys()`.```"},"comment":{"url":"https://api.github.com/repos/dnouri/skorch/issues/comments/384631004","html_url":"https://github.com/dnouri/skorch/issues/175#issuecomment-384631004","issue_url":"https://api.github.com/repos/dnouri/skorch/issues/175","id":384631004,"user":{"login":"ottonemo","id":29305596,"avatar_url":"https://avatars2.githubusercontent.com/u/29305596?v=4","gravatar_id":"","url":"https://api.github.com/users/ottonemo","html_url":"https://github.com/ottonemo","followers_url":"https://api.github.com/users/ottonemo/followers","following_url":"https://api.github.com/users/ottonemo/following{/other_user}","gists_url":"https://api.github.com/users/ottonemo/gists{/gist_id}","starred_url":"https://api.github.com/users/ottonemo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ottonemo/subscriptions","organizations_url":"https://api.github.com/users/ottonemo/orgs","repos_url":"https://api.github.com/users/ottonemo/repos","events_url":"https://api.github.com/users/ottonemo/events{/privacy}","received_events_url":"https://api.github.com/users/ottonemo/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T12:55:45Z","updated_at":"2018-04-26T12:55:45Z","author_association":"COLLABORATOR","body":"Waiting for an answer @ sklearn."}}
{"actor":{"display_login":"ottonemo"}}