{"action":"created","comment":{"url":"https://api.github.com/repos/deeptools/HiCExplorer/pulls/comments/205184625","pull_request_review_id":140405085,"id":205184625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTE4NDYyNQ==","diff_hunk":"@@ -54,39 +54,39 @@ jobs:\n       install:\n         - conda install --yes python=2.7 flake8\n       script:\n-        - if [[ \"$LINT\" == \"1\" ]]; then flake8 . --exclude=.venv,.build,planemo_test_env,build --ignore=E501,F403,E402,F999,F405,E712 ; fi\n+        - if [[ \"$LINT\" == \"1\" ]]; then flake8 . --exclude=.venv,.build,planemo_test_env,build --ignore=E501,F401,F403,E402,F999,F405,E712 ; fi\n     - stage: test\n       os: linux\n       env: TRAVIS_PYTHON_VERSION=2.7\n-      script: py.test hicexplorer/test/long_run/test_build_matrix_trivial_runs.py\n+      script: py.test hicexplorer/test/long_run/test_hicBuildMatrix_trivial_runs.py\n     - stage: test\n       os: osx\n       env: TRAVIS_PYTHON_VERSION=2.7\n-      script: py.test hicexplorer/test/long_run/test_build_matrix_trivial_runs.py\n+      script: py.test hicexplorer/test/long_run/test_hicBuildMatrix_trivial_runs.py\n     - stage: test\n       os: linux\n       env: TRAVIS_PYTHON_VERSION=3.6\n-      script: py.test hicexplorer/test/long_run/test_build_matrix_trivial_runs.py\n+      script: py.test hicexplorer/test/long_run/test_hicBuildMatrix_trivial_runs.py\n     - stage: test\n       os: osx\n       env: TRAVIS_PYTHON_VERSION=3.6\n-      script: py.test hicexplorer/test/long_run/test_build_matrix_trivial_runs.py\n+      script: py.test hicexplorer/test/long_run/test_hicBuildMatrix_trivial_runs.py\n     - stage: test\n       os: linux\n       env: TRAVIS_PYTHON_VERSION=2.7\n-      script: py.test hicexplorer/test/long_run/test_buildMatrix.py\n+      script: py.test hicexplorer/test/long_run/test_hicBuildMatrix.py\n     - stage: test\n       os: osx\n       env: TRAVIS_PYTHON_VERSION=2.7\n-      script: py.test hicexplorer/test/long_run/test_buildMatrix.py\n+      script: py.test hicexplorer/test/long_run/test_hicBuildMatrix.py\n     - stage: test\n       os: linux\n       env: TRAVIS_PYTHON_VERSION=3.6\n-      script: py.test hicexplorer/test/long_run/test_buildMatrix.py\n+      script: py.test hicexplorer/test/long_run/test_hicBuildMatrix.py\n     - stage: test\n       os: osx\n       env: TRAVIS_PYTHON_VERSION=3.6\n-      script: py.test hicexplorer/test/long_run/test_buildMatrix.py\n+      script: py.test hicexplorer/test/long_run/test_hicBuildMatrix.py\n     - stage: test","path":".travis.yml","position":46,"original_position":46,"commit_id":"121e420ee38c2a2066fd3a9ba1c8807b5f5526cf","original_commit_id":"121e420ee38c2a2066fd3a9ba1c8807b5f5526cf","user":{"login":"joachimwolff","id":13435136,"node_id":"MDQ6VXNlcjEzNDM1MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/13435136?v=4","gravatar_id":"","url":"https://api.github.com/users/joachimwolff","html_url":"https://github.com/joachimwolff","followers_url":"https://api.github.com/users/joachimwolff/followers","following_url":"https://api.github.com/users/joachimwolff/following{/other_user}","gists_url":"https://api.github.com/users/joachimwolff/gists{/gist_id}","starred_url":"https://api.github.com/users/joachimwolff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joachimwolff/subscriptions","organizations_url":"https://api.github.com/users/joachimwolff/orgs","repos_url":"https://api.github.com/users/joachimwolff/repos","events_url":"https://api.github.com/users/joachimwolff/events{/privacy}","received_events_url":"https://api.github.com/users/joachimwolff/received_events","type":"User","site_admin":false},"body":"With the separate runs the test cases are executed (more or less) in parallel and we fulfill the time limits of travis per job. If we don't do this the test cases would be quitted by travis after 40 - 50 minutes.","created_at":"2018-07-25T16:52:50Z","updated_at":"2018-07-25T16:52:50Z","html_url":"https://github.com/deeptools/HiCExplorer/pull/267#discussion_r205184625","pull_request_url":"https://api.github.com/repos/deeptools/HiCExplorer/pulls/267","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/deeptools/HiCExplorer/pulls/comments/205184625"},"html":{"href":"https://github.com/deeptools/HiCExplorer/pull/267#discussion_r205184625"},"pull_request":{"href":"https://api.github.com/repos/deeptools/HiCExplorer/pulls/267"}},"in_reply_to_id":205178820},"pull_request":{"url":"https://api.github.com/repos/deeptools/HiCExplorer/pulls/267","id":202825344,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODI1MzQ0","html_url":"https://github.com/deeptools/HiCExplorer/pull/267","diff_url":"https://github.com/deeptools/HiCExplorer/pull/267.diff","patch_url":"https://github.com/deeptools/HiCExplorer/pull/267.patch","issue_url":"https://api.github.com/repos/deeptools/HiCExplorer/issues/267","number":267,"state":"closed","locked":false,"title":"File format","user":{"login":"joachimwolff","id":13435136,"node_id":"MDQ6VXNlcjEzNDM1MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/13435136?v=4","gravatar_id":"","url":"https://api.github.com/users/joachimwolff","html_url":"https://github.com/joachimwolff","followers_url":"https://api.github.com/users/joachimwolff/followers","following_url":"https://api.github.com/users/joachimwolff/following{/other_user}","gists_url":"https://api.github.com/users/joachimwolff/gists{/gist_id}","starred_url":"https://api.github.com/users/joachimwolff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joachimwolff/subscriptions","organizations_url":"https://api.github.com/users/joachimwolff/orgs","repos_url":"https://api.github.com/users/joachimwolff/repos","events_url":"https://api.github.com/users/joachimwolff/events{/privacy}","received_events_url":"https://api.github.com/users/joachimwolff/received_events","type":"User","site_admin":false},"body":"* [x] Flake8 passes (`flake8 . --exclude=.venv,.build,planemo_test_env,build --ignore=E501,F403,E402,F999,F405,E712`)\r\n* [x] Local tests pass (`py.test hicexplorer --doctest-modules`)\r\n\r\nThis PR reorganizes how file formats are handled to an object oriented structure. It makes it easier to extend and the code better readable. \r\n\r\n- All handling is in the folder `lib`, the class hiCMatrix is using only the `MatrixFileHandler` to read/write matrices and does not have any source code handling read or write in it anymore. \r\n- Supported file formats for all tools are `h5` and `cool`. The support for all other file formats is dropped.\r\n- `hicExport` is replaced by `hicConvertFileFormats`. \r\n- `hicConvertFileFormats` supports the transfer of `homer`, `h5` and `hicpro` to `cool` and with help of the library `hic2cool` an export of the `hic` format to `cool`. \r\n- Unused source code was deleted. I hope I did not delete any non-dead src, the test cases pass all, but maybe we have to add deleted src in the future again. \r\n- Static functions within the class hiCMatrix were reorganized as regular functions of this class. \r\n- A small fix in hicPlotTads to check if `tracks` in line 1102 is not None. \r\n- Integration of the test cases from my HiWi, they do not pass so far in the develop branch but they do this here.  ","created_at":"2018-07-20T11:43:41Z","updated_at":"2018-07-25T16:52:50Z","closed_at":"2018-07-20T13:29:22Z","merged_at":"2018-07-20T13:29:22Z","merge_commit_sha":"f815383456222d0abb59e860a8ee34515dbec30e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/deeptools/HiCExplorer/pulls/267/commits","review_comments_url":"https://api.github.com/repos/deeptools/HiCExplorer/pulls/267/comments","review_comment_url":"https://api.github.com/repos/deeptools/HiCExplorer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deeptools/HiCExplorer/issues/267/comments","statuses_url":"https://api.github.com/repos/deeptools/HiCExplorer/statuses/121e420ee38c2a2066fd3a9ba1c8807b5f5526cf","head":{"label":"deeptools:file_format","ref":"file_format","sha":"121e420ee38c2a2066fd3a9ba1c8807b5f5526cf","user":{"login":"deeptools","id":6528975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1Mjg5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6528975?v=4","gravatar_id":"","url":"https://api.github.com/users/deeptools","html_url":"https://github.com/deeptools","followers_url":"https://api.github.com/users/deeptools/followers","following_url":"https://api.github.com/users/deeptools/following{/other_user}","gists_url":"https://api.github.com/users/deeptools/gists{/gist_id}","starred_url":"https://api.github.com/users/deeptools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeptools/subscriptions","organizations_url":"https://api.github.com/users/deeptools/orgs","repos_url":"https://api.github.com/users/deeptools/repos","events_url":"https://api.github.com/users/deeptools/events{/privacy}","received_events_url":"https://api.github.com/users/deeptools/received_events","type":"Organization","site_admin":false},"repo":{"id":30869542,"node_id":"MDEwOlJlcG9zaXRvcnkzMDg2OTU0Mg==","name":"HiCExplorer","full_name":"deeptools/HiCExplorer","owner":{"login":"deeptools","id":6528975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1Mjg5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6528975?v=4","gravatar_id":"","url":"https://api.github.com/users/deeptools","html_url":"https://github.com/deeptools","followers_url":"https://api.github.com/users/deeptools/followers","following_url":"https://api.github.com/users/deeptools/following{/other_user}","gists_url":"https://api.github.com/users/deeptools/gists{/gist_id}","starred_url":"https://api.github.com/users/deeptools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeptools/subscriptions","organizations_url":"https://api.github.com/users/deeptools/orgs","repos_url":"https://api.github.com/users/deeptools/repos","events_url":"https://api.github.com/users/deeptools/events{/privacy}","received_events_url":"https://api.github.com/users/deeptools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deeptools/HiCExplorer","description":"HiCExplorer is a powerful and easy to use set of tools to process, normalize and visualize Hi-C data.","fork":false,"url":"https://api.github.com/repos/deeptools/HiCExplorer","forks_url":"https://api.github.com/repos/deeptools/HiCExplorer/forks","keys_url":"https://api.github.com/repos/deeptools/HiCExplorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deeptools/HiCExplorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deeptools/HiCExplorer/teams","hooks_url":"https://api.github.com/repos/deeptools/HiCExplorer/hooks","issue_events_url":"https://api.github.com/repos/deeptools/HiCExplorer/issues/events{/number}","events_url":"https://api.github.com/repos/deeptools/HiCExplorer/events","assignees_url":"https://api.github.com/repos/deeptools/HiCExplorer/assignees{/user}","branches_url":"https://api.github.com/repos/deeptools/HiCExplorer/branches{/branch}","tags_url":"https://api.github.com/repos/deeptools/HiCExplorer/tags","blobs_url":"https://api.github.com/repos/deeptools/HiCExplorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deeptools/HiCExplorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deeptools/HiCExplorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/deeptools/HiCExplorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deeptools/HiCExplorer/statuses/{sha}","languages_url":"https://api.github.com/repos/deeptools/HiCExplorer/languages","stargazers_url":"https://api.github.com/repos/deeptools/HiCExplorer/stargazers","contributors_url":"https://api.github.com/repos/deeptools/HiCExplorer/contributors","subscribers_url":"https://api.github.com/repos/deeptools/HiCExplorer/subscribers","subscription_url":"https://api.github.com/repos/deeptools/HiCExplorer/subscription","commits_url":"https://api.github.com/repos/deeptools/HiCExplorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/deeptools/HiCExplorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/deeptools/HiCExplorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/deeptools/HiCExplorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/deeptools/HiCExplorer/contents/{+path}","compare_url":"https://api.github.com/repos/deeptools/HiCExplorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deeptools/HiCExplorer/merges","archive_url":"https://api.github.com/repos/deeptools/HiCExplorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deeptools/HiCExplorer/downloads","issues_url":"https://api.github.com/repos/deeptools/HiCExplorer/issues{/number}","pulls_url":"https://api.github.com/repos/deeptools/HiCExplorer/pulls{/number}","milestones_url":"https://api.github.com/repos/deeptools/HiCExplorer/milestones{/number}","notifications_url":"https://api.github.com/repos/deeptools/HiCExplorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deeptools/HiCExplorer/labels{/name}","releases_url":"https://api.github.com/repos/deeptools/HiCExplorer/releases{/id}","deployments_url":"https://api.github.com/repos/deeptools/HiCExplorer/deployments","created_at":"2015-02-16T13:31:19Z","updated_at":"2018-07-22T08:50:04Z","pushed_at":"2018-07-25T14:44:01Z","git_url":"git://github.com/deeptools/HiCExplorer.git","ssh_url":"git@github.com:deeptools/HiCExplorer.git","clone_url":"https://github.com/deeptools/HiCExplorer.git","svn_url":"https://github.com/deeptools/HiCExplorer","homepage":"http://hicexplorer.readthedocs.org","size":231896,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":20,"open_issues":35,"watchers":38,"default_branch":"master"}},"base":{"label":"deeptools:develop","ref":"develop","sha":"932e21b33b72cf80ac442e1edbda6fca7613152f","user":{"login":"deeptools","id":6528975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1Mjg5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6528975?v=4","gravatar_id":"","url":"https://api.github.com/users/deeptools","html_url":"https://github.com/deeptools","followers_url":"https://api.github.com/users/deeptools/followers","following_url":"https://api.github.com/users/deeptools/following{/other_user}","gists_url":"https://api.github.com/users/deeptools/gists{/gist_id}","starred_url":"https://api.github.com/users/deeptools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeptools/subscriptions","organizations_url":"https://api.github.com/users/deeptools/orgs","repos_url":"https://api.github.com/users/deeptools/repos","events_url":"https://api.github.com/users/deeptools/events{/privacy}","received_events_url":"https://api.github.com/users/deeptools/received_events","type":"Organization","site_admin":false},"repo":{"id":30869542,"node_id":"MDEwOlJlcG9zaXRvcnkzMDg2OTU0Mg==","name":"HiCExplorer","full_name":"deeptools/HiCExplorer","owner":{"login":"deeptools","id":6528975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1Mjg5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6528975?v=4","gravatar_id":"","url":"https://api.github.com/users/deeptools","html_url":"https://github.com/deeptools","followers_url":"https://api.github.com/users/deeptools/followers","following_url":"https://api.github.com/users/deeptools/following{/other_user}","gists_url":"https://api.github.com/users/deeptools/gists{/gist_id}","starred_url":"https://api.github.com/users/deeptools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeptools/subscriptions","organizations_url":"https://api.github.com/users/deeptools/orgs","repos_url":"https://api.github.com/users/deeptools/repos","events_url":"https://api.github.com/users/deeptools/events{/privacy}","received_events_url":"https://api.github.com/users/deeptools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deeptools/HiCExplorer","description":"HiCExplorer is a powerful and easy to use set of tools to process, normalize and visualize Hi-C data.","fork":false,"url":"https://api.github.com/repos/deeptools/HiCExplorer","forks_url":"https://api.github.com/repos/deeptools/HiCExplorer/forks","keys_url":"https://api.github.com/repos/deeptools/HiCExplorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deeptools/HiCExplorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deeptools/HiCExplorer/teams","hooks_url":"https://api.github.com/repos/deeptools/HiCExplorer/hooks","issue_events_url":"https://api.github.com/repos/deeptools/HiCExplorer/issues/events{/number}","events_url":"https://api.github.com/repos/deeptools/HiCExplorer/events","assignees_url":"https://api.github.com/repos/deeptools/HiCExplorer/assignees{/user}","branches_url":"https://api.github.com/repos/deeptools/HiCExplorer/branches{/branch}","tags_url":"https://api.github.com/repos/deeptools/HiCExplorer/tags","blobs_url":"https://api.github.com/repos/deeptools/HiCExplorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deeptools/HiCExplorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deeptools/HiCExplorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/deeptools/HiCExplorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deeptools/HiCExplorer/statuses/{sha}","languages_url":"https://api.github.com/repos/deeptools/HiCExplorer/languages","stargazers_url":"https://api.github.com/repos/deeptools/HiCExplorer/stargazers","contributors_url":"https://api.github.com/repos/deeptools/HiCExplorer/contributors","subscribers_url":"https://api.github.com/repos/deeptools/HiCExplorer/subscribers","subscription_url":"https://api.github.com/repos/deeptools/HiCExplorer/subscription","commits_url":"https://api.github.com/repos/deeptools/HiCExplorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/deeptools/HiCExplorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/deeptools/HiCExplorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/deeptools/HiCExplorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/deeptools/HiCExplorer/contents/{+path}","compare_url":"https://api.github.com/repos/deeptools/HiCExplorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deeptools/HiCExplorer/merges","archive_url":"https://api.github.com/repos/deeptools/HiCExplorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deeptools/HiCExplorer/downloads","issues_url":"https://api.github.com/repos/deeptools/HiCExplorer/issues{/number}","pulls_url":"https://api.github.com/repos/deeptools/HiCExplorer/pulls{/number}","milestones_url":"https://api.github.com/repos/deeptools/HiCExplorer/milestones{/number}","notifications_url":"https://api.github.com/repos/deeptools/HiCExplorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deeptools/HiCExplorer/labels{/name}","releases_url":"https://api.github.com/repos/deeptools/HiCExplorer/releases{/id}","deployments_url":"https://api.github.com/repos/deeptools/HiCExplorer/deployments","created_at":"2015-02-16T13:31:19Z","updated_at":"2018-07-22T08:50:04Z","pushed_at":"2018-07-25T14:44:01Z","git_url":"git://github.com/deeptools/HiCExplorer.git","ssh_url":"git@github.com:deeptools/HiCExplorer.git","clone_url":"https://github.com/deeptools/HiCExplorer.git","svn_url":"https://github.com/deeptools/HiCExplorer","homepage":"http://hicexplorer.readthedocs.org","size":231896,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":20,"open_issues":35,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deeptools/HiCExplorer/pulls/267"},"html":{"href":"https://github.com/deeptools/HiCExplorer/pull/267"},"issue":{"href":"https://api.github.com/repos/deeptools/HiCExplorer/issues/267"},"comments":{"href":"https://api.github.com/repos/deeptools/HiCExplorer/issues/267/comments"},"review_comments":{"href":"https://api.github.com/repos/deeptools/HiCExplorer/pulls/267/comments"},"review_comment":{"href":"https://api.github.com/repos/deeptools/HiCExplorer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deeptools/HiCExplorer/pulls/267/commits"},"statuses":{"href":"https://api.github.com/repos/deeptools/HiCExplorer/statuses/121e420ee38c2a2066fd3a9ba1c8807b5f5526cf"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"joachimwolff"}}