{"action":"closed","number":1749,"pull_request":{"url":"https://api.github.com/repos/sinonjs/sinon/pulls/1749","id":176926597,"html_url":"https://github.com/sinonjs/sinon/pull/1749","diff_url":"https://github.com/sinonjs/sinon/pull/1749.diff","patch_url":"https://github.com/sinonjs/sinon/pull/1749.patch","issue_url":"https://api.github.com/repos/sinonjs/sinon/issues/1749","number":1749,"state":"closed","locked":false,"title":"Fix #1746 by removing library","user":{"login":"fatso83","id":618076,"avatar_url":"https://avatars2.githubusercontent.com/u/618076?v=4","gravatar_id":"","url":"https://api.github.com/users/fatso83","html_url":"https://github.com/fatso83","followers_url":"https://api.github.com/users/fatso83/followers","following_url":"https://api.github.com/users/fatso83/following{/other_user}","gists_url":"https://api.github.com/users/fatso83/gists{/gist_id}","starred_url":"https://api.github.com/users/fatso83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatso83/subscriptions","organizations_url":"https://api.github.com/users/fatso83/orgs","repos_url":"https://api.github.com/users/fatso83/repos","events_url":"https://api.github.com/users/fatso83/events{/privacy}","received_events_url":"https://api.github.com/users/fatso83/received_events","type":"User","site_admin":false},"body":"Basically fixes #1746 by removing a library dependency in the postinstall to avoid\r\nbreaking installs on Node versions < 4.\r\n\r\n*Also* (and this is up for concideration), supports a use case where users can disable the support message, in case they rely on formatting being consistent in the output for parsing. This would be used like: `NO_SUPPORT_MESSAGE='' npm run postinstall -s`. I can remove this commit, but I think this strikes an ok compromise, as you _know_ people have read the message in case they explicitly want to turn it off. Unless this just turns into a standard flag convention in other packages, but that is getting ahead of things :smile: ","created_at":"2018-03-22T22:26:23Z","updated_at":"2018-03-23T10:43:38Z","closed_at":"2018-03-23T10:43:38Z","merged_at":null,"merge_commit_sha":"199191252edb8df7e0d3b21404531154bac8797d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mroderick","id":20321,"avatar_url":"https://avatars2.githubusercontent.com/u/20321?v=4","gravatar_id":"","url":"https://api.github.com/users/mroderick","html_url":"https://github.com/mroderick","followers_url":"https://api.github.com/users/mroderick/followers","following_url":"https://api.github.com/users/mroderick/following{/other_user}","gists_url":"https://api.github.com/users/mroderick/gists{/gist_id}","starred_url":"https://api.github.com/users/mroderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroderick/subscriptions","organizations_url":"https://api.github.com/users/mroderick/orgs","repos_url":"https://api.github.com/users/mroderick/repos","events_url":"https://api.github.com/users/mroderick/events{/privacy}","received_events_url":"https://api.github.com/users/mroderick/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sinonjs/sinon/pulls/1749/commits","review_comments_url":"https://api.github.com/repos/sinonjs/sinon/pulls/1749/comments","review_comment_url":"https://api.github.com/repos/sinonjs/sinon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sinonjs/sinon/issues/1749/comments","statuses_url":"https://api.github.com/repos/sinonjs/sinon/statuses/cbd05797a740b5b880ac4f3f6123855f2cce4090","head":{"label":"fatso83:fix-1746","ref":"fix-1746","sha":"cbd05797a740b5b880ac4f3f6123855f2cce4090","user":{"login":"fatso83","id":618076,"avatar_url":"https://avatars2.githubusercontent.com/u/618076?v=4","gravatar_id":"","url":"https://api.github.com/users/fatso83","html_url":"https://github.com/fatso83","followers_url":"https://api.github.com/users/fatso83/followers","following_url":"https://api.github.com/users/fatso83/following{/other_user}","gists_url":"https://api.github.com/users/fatso83/gists{/gist_id}","starred_url":"https://api.github.com/users/fatso83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatso83/subscriptions","organizations_url":"https://api.github.com/users/fatso83/orgs","repos_url":"https://api.github.com/users/fatso83/repos","events_url":"https://api.github.com/users/fatso83/events{/privacy}","received_events_url":"https://api.github.com/users/fatso83/received_events","type":"User","site_admin":false},"repo":{"id":41426291,"name":"sinon","full_name":"fatso83/sinon","owner":{"login":"fatso83","id":618076,"avatar_url":"https://avatars2.githubusercontent.com/u/618076?v=4","gravatar_id":"","url":"https://api.github.com/users/fatso83","html_url":"https://github.com/fatso83","followers_url":"https://api.github.com/users/fatso83/followers","following_url":"https://api.github.com/users/fatso83/following{/other_user}","gists_url":"https://api.github.com/users/fatso83/gists{/gist_id}","starred_url":"https://api.github.com/users/fatso83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatso83/subscriptions","organizations_url":"https://api.github.com/users/fatso83/orgs","repos_url":"https://api.github.com/users/fatso83/repos","events_url":"https://api.github.com/users/fatso83/events{/privacy}","received_events_url":"https://api.github.com/users/fatso83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fatso83/sinon","description":"Test spies, stubs and mocks for JavaScript.","fork":true,"url":"https://api.github.com/repos/fatso83/sinon","forks_url":"https://api.github.com/repos/fatso83/sinon/forks","keys_url":"https://api.github.com/repos/fatso83/sinon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fatso83/sinon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fatso83/sinon/teams","hooks_url":"https://api.github.com/repos/fatso83/sinon/hooks","issue_events_url":"https://api.github.com/repos/fatso83/sinon/issues/events{/number}","events_url":"https://api.github.com/repos/fatso83/sinon/events","assignees_url":"https://api.github.com/repos/fatso83/sinon/assignees{/user}","branches_url":"https://api.github.com/repos/fatso83/sinon/branches{/branch}","tags_url":"https://api.github.com/repos/fatso83/sinon/tags","blobs_url":"https://api.github.com/repos/fatso83/sinon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fatso83/sinon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fatso83/sinon/git/refs{/sha}","trees_url":"https://api.github.com/repos/fatso83/sinon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fatso83/sinon/statuses/{sha}","languages_url":"https://api.github.com/repos/fatso83/sinon/languages","stargazers_url":"https://api.github.com/repos/fatso83/sinon/stargazers","contributors_url":"https://api.github.com/repos/fatso83/sinon/contributors","subscribers_url":"https://api.github.com/repos/fatso83/sinon/subscribers","subscription_url":"https://api.github.com/repos/fatso83/sinon/subscription","commits_url":"https://api.github.com/repos/fatso83/sinon/commits{/sha}","git_commits_url":"https://api.github.com/repos/fatso83/sinon/git/commits{/sha}","comments_url":"https://api.github.com/repos/fatso83/sinon/comments{/number}","issue_comment_url":"https://api.github.com/repos/fatso83/sinon/issues/comments{/number}","contents_url":"https://api.github.com/repos/fatso83/sinon/contents/{+path}","compare_url":"https://api.github.com/repos/fatso83/sinon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fatso83/sinon/merges","archive_url":"https://api.github.com/repos/fatso83/sinon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fatso83/sinon/downloads","issues_url":"https://api.github.com/repos/fatso83/sinon/issues{/number}","pulls_url":"https://api.github.com/repos/fatso83/sinon/pulls{/number}","milestones_url":"https://api.github.com/repos/fatso83/sinon/milestones{/number}","notifications_url":"https://api.github.com/repos/fatso83/sinon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fatso83/sinon/labels{/name}","releases_url":"https://api.github.com/repos/fatso83/sinon/releases{/id}","deployments_url":"https://api.github.com/repos/fatso83/sinon/deployments","created_at":"2015-08-26T13:11:06Z","updated_at":"2017-09-18T10:15:10Z","pushed_at":"2018-03-22T22:34:05Z","git_url":"git://github.com/fatso83/sinon.git","ssh_url":"git@github.com:fatso83/sinon.git","clone_url":"https://github.com/fatso83/sinon.git","svn_url":"https://github.com/fatso83/sinon","homepage":"http://sinonjs.org/","size":16427,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sinonjs:master","ref":"master","sha":"224084b89d072d2b34cace7e1b20cb708e63ddd3","user":{"login":"sinonjs","id":6570253,"avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"repo":{"id":747698,"name":"sinon","full_name":"sinonjs/sinon","owner":{"login":"sinonjs","id":6570253,"avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sinonjs/sinon","description":"Test spies, stubs and mocks for JavaScript.","fork":false,"url":"https://api.github.com/repos/sinonjs/sinon","forks_url":"https://api.github.com/repos/sinonjs/sinon/forks","keys_url":"https://api.github.com/repos/sinonjs/sinon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinonjs/sinon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinonjs/sinon/teams","hooks_url":"https://api.github.com/repos/sinonjs/sinon/hooks","issue_events_url":"https://api.github.com/repos/sinonjs/sinon/issues/events{/number}","events_url":"https://api.github.com/repos/sinonjs/sinon/events","assignees_url":"https://api.github.com/repos/sinonjs/sinon/assignees{/user}","branches_url":"https://api.github.com/repos/sinonjs/sinon/branches{/branch}","tags_url":"https://api.github.com/repos/sinonjs/sinon/tags","blobs_url":"https://api.github.com/repos/sinonjs/sinon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinonjs/sinon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinonjs/sinon/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinonjs/sinon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinonjs/sinon/statuses/{sha}","languages_url":"https://api.github.com/repos/sinonjs/sinon/languages","stargazers_url":"https://api.github.com/repos/sinonjs/sinon/stargazers","contributors_url":"https://api.github.com/repos/sinonjs/sinon/contributors","subscribers_url":"https://api.github.com/repos/sinonjs/sinon/subscribers","subscription_url":"https://api.github.com/repos/sinonjs/sinon/subscription","commits_url":"https://api.github.com/repos/sinonjs/sinon/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinonjs/sinon/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinonjs/sinon/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinonjs/sinon/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinonjs/sinon/contents/{+path}","compare_url":"https://api.github.com/repos/sinonjs/sinon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinonjs/sinon/merges","archive_url":"https://api.github.com/repos/sinonjs/sinon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinonjs/sinon/downloads","issues_url":"https://api.github.com/repos/sinonjs/sinon/issues{/number}","pulls_url":"https://api.github.com/repos/sinonjs/sinon/pulls{/number}","milestones_url":"https://api.github.com/repos/sinonjs/sinon/milestones{/number}","notifications_url":"https://api.github.com/repos/sinonjs/sinon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinonjs/sinon/labels{/name}","releases_url":"https://api.github.com/repos/sinonjs/sinon/releases{/id}","deployments_url":"https://api.github.com/repos/sinonjs/sinon/deployments","created_at":"2010-06-29T21:15:32Z","updated_at":"2018-03-23T09:37:32Z","pushed_at":"2018-03-22T22:34:06Z","git_url":"git://github.com/sinonjs/sinon.git","ssh_url":"git@github.com:sinonjs/sinon.git","clone_url":"https://github.com/sinonjs/sinon.git","svn_url":"https://github.com/sinonjs/sinon","homepage":"http://sinonjs.org/","size":18656,"stargazers_count":5612,"watchers_count":5612,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":619,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":619,"open_issues":36,"watchers":5612,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/1749"},"html":{"href":"https://github.com/sinonjs/sinon/pull/1749"},"issue":{"href":"https://api.github.com/repos/sinonjs/sinon/issues/1749"},"comments":{"href":"https://api.github.com/repos/sinonjs/sinon/issues/1749/comments"},"review_comments":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/1749/comments"},"review_comment":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/1749/commits"},"statuses":{"href":"https://api.github.com/repos/sinonjs/sinon/statuses/cbd05797a740b5b880ac4f3f6123855f2cce4090"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":15,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"fatso83"}}