{"action":"created","comment":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/comments/232464494","pull_request_review_id":173673819,"id":232464494,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQ2NDQ5NA==","diff_hunk":"@@ -207,19 +255,19 @@ def download_png(self, date, image_scale, layers, directory=None,\n         >>> from sunpy.net.helioviewer import HelioviewerClient\n         >>> import datetime\n         >>> hv = HelioviewerClient()  # doctest: +REMOTE_DATA\n-        >>> file = hv.download_png('2012/07/16 10:08:00', 2.4, \"[SDO,AIA,AIA,171,1,100]\", x0=0, y0=0, width=1024, height=1024)   # doctest: +REMOTE_DATA\n-        >>> file = hv.download_png('2012/07/16 10:08:00', 4.8, \"[SDO,AIA,AIA,171,1,100],[SOHO,LASCO,C2,white-light,1,100]\", x1=-2800, x2=2800, y1=-2800, y2=2800)   # doctest: +REMOTE_DATA\n-        >>> file = hv.download_jp2(datetime.datetime.now(), observatory='SDO', instrument='HMI', detector='HMI', measurement='continuum')   # doctest: +REMOTE_DATA\n+        >>> file = hv.download_png('2012/07/16 10:08:00', 2.4, \"[SDO,AIA,AIA,171,1,100]\", False, x0=0, y0=0, width=1024, height=1024)   # doctest: +REMOTE_DATA\n+        >>> file = hv.download_png('2012/07/16 10:08:00', 4.8, \"[SDO,AIA,AIA,171,1,100],[SOHO,LASCO,C2,white-light,1,100]\", True, x1=-2800, x2=2800, y1=-2800, y2=2800)   # doctest: +REMOTE_DATA\n         \"\"\"\n         params = {\n             \"action\": \"takeScreenshot\",\n             \"date\": self._format_date(date),\n             \"imageScale\": image_scale,\n             \"layers\": layers,\n+            \"eventLabels\": eventLabels,\n             \"display\": True\n         }\n-        params.update(kwargs)\n \n+        params.update(kwargs)","path":"sunpy/net/helioviewer.py","position":267,"original_position":267,"commit_id":"0b5205e123eb32b75eaa3348272dcd9d48c14e72","original_commit_id":"0b5205e123eb32b75eaa3348272dcd9d48c14e72","user":{"login":"nabobalis","id":1392107,"node_id":"MDQ6VXNlcjEzOTIxMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1392107?v=4","gravatar_id":"","url":"https://api.github.com/users/nabobalis","html_url":"https://github.com/nabobalis","followers_url":"https://api.github.com/users/nabobalis/followers","following_url":"https://api.github.com/users/nabobalis/following{/other_user}","gists_url":"https://api.github.com/users/nabobalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nabobalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nabobalis/subscriptions","organizations_url":"https://api.github.com/users/nabobalis/orgs","repos_url":"https://api.github.com/users/nabobalis/repos","events_url":"https://api.github.com/users/nabobalis/events{/privacy}","received_events_url":"https://api.github.com/users/nabobalis/received_events","type":"User","site_admin":false},"body":"I was against it at first since I thought if you want to use any keywords we should support them explicitly. But there are parts of the API we never want to actually support. But might be useful to someone who had more knowledge of the API and we can support that via kwargs","created_at":"2018-11-10T20:10:26Z","updated_at":"2018-11-10T20:10:26Z","html_url":"https://github.com/sunpy/sunpy/pull/2801#discussion_r232464494","pull_request_url":"https://api.github.com/repos/sunpy/sunpy/pulls/2801","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/comments/232464494"},"html":{"href":"https://github.com/sunpy/sunpy/pull/2801#discussion_r232464494"},"pull_request":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/2801"}},"in_reply_to_id":232458683},"pull_request":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/2801","id":224030524,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDMwNTI0","html_url":"https://github.com/sunpy/sunpy/pull/2801","diff_url":"https://github.com/sunpy/sunpy/pull/2801.diff","patch_url":"https://github.com/sunpy/sunpy/pull/2801.patch","issue_url":"https://api.github.com/repos/sunpy/sunpy/issues/2801","number":2801,"state":"open","locked":false,"title":"Ensures that Helioviewer client uses Helioviewer API version 2 exclusively","user":{"login":"Naman9639","id":31286078,"node_id":"MDQ6VXNlcjMxMjg2MDc4","avatar_url":"https://avatars3.githubusercontent.com/u/31286078?v=4","gravatar_id":"","url":"https://api.github.com/users/Naman9639","html_url":"https://github.com/Naman9639","followers_url":"https://api.github.com/users/Naman9639/followers","following_url":"https://api.github.com/users/Naman9639/following{/other_user}","gists_url":"https://api.github.com/users/Naman9639/gists{/gist_id}","starred_url":"https://api.github.com/users/Naman9639/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Naman9639/subscriptions","organizations_url":"https://api.github.com/users/Naman9639/orgs","repos_url":"https://api.github.com/users/Naman9639/repos","events_url":"https://api.github.com/users/Naman9639/events{/privacy}","received_events_url":"https://api.github.com/users/Naman9639/received_events","type":"User","site_admin":false},"body":"<!-- This comments are hidden when you submit the pull request, so you do not need to remove them!\r\nPlease be sure to check out our contributing guidelines, https://github.com/sunpy/sunpy/blob/master/CONTRIBUTING.rst.\r\nPlease be sure to check out our code of conduct, https://github.com/sunpy/sunpy/blob/master/CODE_OF_CONDUCT.rst. -->\r\n\r\n<!-- Please just have a quick search on GitHub to see if a similar pull request has already been posted.\r\nWe have old closed pull requests that might provide useful code or ideas that directly tie in with your pull request. -->\r\n\r\n<!-- We have several automatic features that run when a pull request is open.\r\nThey can appear daunting but do not worry about them!\r\nWe have a brief explanation of them in the documentation, http://docs.sunpy.org/en/latest/dev_guide/pr_review_procedure.html#continuous-integration. -->\r\n\r\n### Description\r\n<!-- Provide a general description of what your pull request does. -->\r\n\r\n<!-- If the pull request closes any open issues you can add this.\r\nIf you replace <Issue Number> with a number GitHub will automatically link it.\r\nIf it doesn't, please remove the following line. -->\r\n\r\nFixes #2280 \r\n","created_at":"2018-10-18T17:02:41Z","updated_at":"2018-11-10T20:10:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15c3e7a00f9a7aff791655667c3046bb7954e737","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wafels","id":983575,"node_id":"MDQ6VXNlcjk4MzU3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/983575?v=4","gravatar_id":"","url":"https://api.github.com/users/wafels","html_url":"https://github.com/wafels","followers_url":"https://api.github.com/users/wafels/followers","following_url":"https://api.github.com/users/wafels/following{/other_user}","gists_url":"https://api.github.com/users/wafels/gists{/gist_id}","starred_url":"https://api.github.com/users/wafels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wafels/subscriptions","organizations_url":"https://api.github.com/users/wafels/orgs","repos_url":"https://api.github.com/users/wafels/repos","events_url":"https://api.github.com/users/wafels/events{/privacy}","received_events_url":"https://api.github.com/users/wafels/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":123240217,"node_id":"MDU6TGFiZWwxMjMyNDAyMTc=","url":"https://api.github.com/repos/sunpy/sunpy/labels/net","name":"net","color":"c7def8","default":false}],"milestone":{"url":"https://api.github.com/repos/sunpy/sunpy/milestones/17","html_url":"https://github.com/sunpy/sunpy/milestone/17","labels_url":"https://api.github.com/repos/sunpy/sunpy/milestones/17/labels","id":2692290,"node_id":"MDk6TWlsZXN0b25lMjY5MjI5MA==","number":17,"title":"1.0","description":"","creator":{"login":"nabobalis","id":1392107,"node_id":"MDQ6VXNlcjEzOTIxMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1392107?v=4","gravatar_id":"","url":"https://api.github.com/users/nabobalis","html_url":"https://github.com/nabobalis","followers_url":"https://api.github.com/users/nabobalis/followers","following_url":"https://api.github.com/users/nabobalis/following{/other_user}","gists_url":"https://api.github.com/users/nabobalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nabobalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nabobalis/subscriptions","organizations_url":"https://api.github.com/users/nabobalis/orgs","repos_url":"https://api.github.com/users/nabobalis/repos","events_url":"https://api.github.com/users/nabobalis/events{/privacy}","received_events_url":"https://api.github.com/users/nabobalis/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":50,"state":"open","created_at":"2017-08-09T16:27:19Z","updated_at":"2018-11-09T11:00:52Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/sunpy/sunpy/pulls/2801/commits","review_comments_url":"https://api.github.com/repos/sunpy/sunpy/pulls/2801/comments","review_comment_url":"https://api.github.com/repos/sunpy/sunpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sunpy/sunpy/issues/2801/comments","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/0b5205e123eb32b75eaa3348272dcd9d48c14e72","head":{"label":"Naman9639:issue#2280","ref":"issue#2280","sha":"0b5205e123eb32b75eaa3348272dcd9d48c14e72","user":{"login":"Naman9639","id":31286078,"node_id":"MDQ6VXNlcjMxMjg2MDc4","avatar_url":"https://avatars3.githubusercontent.com/u/31286078?v=4","gravatar_id":"","url":"https://api.github.com/users/Naman9639","html_url":"https://github.com/Naman9639","followers_url":"https://api.github.com/users/Naman9639/followers","following_url":"https://api.github.com/users/Naman9639/following{/other_user}","gists_url":"https://api.github.com/users/Naman9639/gists{/gist_id}","starred_url":"https://api.github.com/users/Naman9639/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Naman9639/subscriptions","organizations_url":"https://api.github.com/users/Naman9639/orgs","repos_url":"https://api.github.com/users/Naman9639/repos","events_url":"https://api.github.com/users/Naman9639/events{/privacy}","received_events_url":"https://api.github.com/users/Naman9639/received_events","type":"User","site_admin":false},"repo":{"id":152638452,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI2Mzg0NTI=","name":"sunpy","full_name":"Naman9639/sunpy","private":false,"owner":{"login":"Naman9639","id":31286078,"node_id":"MDQ6VXNlcjMxMjg2MDc4","avatar_url":"https://avatars3.githubusercontent.com/u/31286078?v=4","gravatar_id":"","url":"https://api.github.com/users/Naman9639","html_url":"https://github.com/Naman9639","followers_url":"https://api.github.com/users/Naman9639/followers","following_url":"https://api.github.com/users/Naman9639/following{/other_user}","gists_url":"https://api.github.com/users/Naman9639/gists{/gist_id}","starred_url":"https://api.github.com/users/Naman9639/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Naman9639/subscriptions","organizations_url":"https://api.github.com/users/Naman9639/orgs","repos_url":"https://api.github.com/users/Naman9639/repos","events_url":"https://api.github.com/users/Naman9639/events{/privacy}","received_events_url":"https://api.github.com/users/Naman9639/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Naman9639/sunpy","description":"SunPy - Python for Solar Physics","fork":true,"url":"https://api.github.com/repos/Naman9639/sunpy","forks_url":"https://api.github.com/repos/Naman9639/sunpy/forks","keys_url":"https://api.github.com/repos/Naman9639/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Naman9639/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Naman9639/sunpy/teams","hooks_url":"https://api.github.com/repos/Naman9639/sunpy/hooks","issue_events_url":"https://api.github.com/repos/Naman9639/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/Naman9639/sunpy/events","assignees_url":"https://api.github.com/repos/Naman9639/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/Naman9639/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/Naman9639/sunpy/tags","blobs_url":"https://api.github.com/repos/Naman9639/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Naman9639/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Naman9639/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Naman9639/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Naman9639/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/Naman9639/sunpy/languages","stargazers_url":"https://api.github.com/repos/Naman9639/sunpy/stargazers","contributors_url":"https://api.github.com/repos/Naman9639/sunpy/contributors","subscribers_url":"https://api.github.com/repos/Naman9639/sunpy/subscribers","subscription_url":"https://api.github.com/repos/Naman9639/sunpy/subscription","commits_url":"https://api.github.com/repos/Naman9639/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Naman9639/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Naman9639/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Naman9639/sunpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Naman9639/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/Naman9639/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Naman9639/sunpy/merges","archive_url":"https://api.github.com/repos/Naman9639/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Naman9639/sunpy/downloads","issues_url":"https://api.github.com/repos/Naman9639/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/Naman9639/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/Naman9639/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/Naman9639/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Naman9639/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/Naman9639/sunpy/releases{/id}","deployments_url":"https://api.github.com/repos/Naman9639/sunpy/deployments","created_at":"2018-10-11T18:37:11Z","updated_at":"2018-11-03T17:47:51Z","pushed_at":"2018-11-09T17:12:37Z","git_url":"git://github.com/Naman9639/sunpy.git","ssh_url":"git@github.com:Naman9639/sunpy.git","clone_url":"https://github.com/Naman9639/sunpy.git","svn_url":"https://github.com/Naman9639/sunpy","homepage":"http://www.sunpy.org","size":42780,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sunpy:master","ref":"master","sha":"de0e176f6a38c8d2356436fd19f66683ef59b44c","user":{"login":"sunpy","id":963197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MzE5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/963197?v=4","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"repo":{"id":2165383,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY1Mzgz","name":"sunpy","full_name":"sunpy/sunpy","private":false,"owner":{"login":"sunpy","id":963197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MzE5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/963197?v=4","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sunpy/sunpy","description":"SunPy - Python for Solar Physics","fork":false,"url":"https://api.github.com/repos/sunpy/sunpy","forks_url":"https://api.github.com/repos/sunpy/sunpy/forks","keys_url":"https://api.github.com/repos/sunpy/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunpy/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunpy/sunpy/teams","hooks_url":"https://api.github.com/repos/sunpy/sunpy/hooks","issue_events_url":"https://api.github.com/repos/sunpy/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/sunpy/sunpy/events","assignees_url":"https://api.github.com/repos/sunpy/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/sunpy/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/sunpy/sunpy/tags","blobs_url":"https://api.github.com/repos/sunpy/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunpy/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunpy/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunpy/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/sunpy/sunpy/languages","stargazers_url":"https://api.github.com/repos/sunpy/sunpy/stargazers","contributors_url":"https://api.github.com/repos/sunpy/sunpy/contributors","subscribers_url":"https://api.github.com/repos/sunpy/sunpy/subscribers","subscription_url":"https://api.github.com/repos/sunpy/sunpy/subscription","commits_url":"https://api.github.com/repos/sunpy/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunpy/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunpy/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunpy/sunpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunpy/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/sunpy/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunpy/sunpy/merges","archive_url":"https://api.github.com/repos/sunpy/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunpy/sunpy/downloads","issues_url":"https://api.github.com/repos/sunpy/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/sunpy/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/sunpy/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/sunpy/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunpy/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/sunpy/sunpy/releases{/id}","deployments_url":"https://api.github.com/repos/sunpy/sunpy/deployments","created_at":"2011-08-06T15:34:08Z","updated_at":"2018-11-10T00:59:43Z","pushed_at":"2018-11-09T17:12:37Z","git_url":"git://github.com/sunpy/sunpy.git","ssh_url":"git@github.com:sunpy/sunpy.git","clone_url":"https://github.com/sunpy/sunpy.git","svn_url":"https://github.com/sunpy/sunpy","homepage":"http://www.sunpy.org","size":42772,"stargazers_count":370,"watchers_count":370,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":292,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":292,"open_issues":246,"watchers":370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/2801"},"html":{"href":"https://github.com/sunpy/sunpy/pull/2801"},"issue":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/2801"},"comments":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/2801/comments"},"review_comments":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/2801/comments"},"review_comment":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/2801/commits"},"statuses":{"href":"https://api.github.com/repos/sunpy/sunpy/statuses/0b5205e123eb32b75eaa3348272dcd9d48c14e72"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nabobalis"}}