{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments/175854129","pull_request_review_id":105453938,"id":175854129,"diff_hunk":"@@ -216,6 +216,10 @@ message HttpConnectionManager {\n     // XFCC header comma separated from other values with the value Cert=\"PEM\".\n     // Defaults to false.\n     bool cert = 3;\n+\n+    // [#not-implemented-hide:] Whether to forward the DNS SAN entries of the client cert. Defaults\n+    // to false.\n+    bool dns_san = 4;","path":"envoy/config/filter/network/http_connection_manager/v2/http_connection_manager.proto","position":7,"original_position":7,"commit_id":"5178d52866fb3f7b5d666ccd0cfc34ece7e03799","original_commit_id":"5178d52866fb3f7b5d666ccd0cfc34ece7e03799","user":{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"body":"@shakti-das can just potentially capture some of this in the docs? I think users will be confused with the different SAN settings with the docs as is. Thank you!","created_at":"2018-03-20T17:22:15Z","updated_at":"2018-03-20T17:22:15Z","html_url":"https://github.com/envoyproxy/data-plane-api/pull/564#discussion_r175854129","pull_request_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/564","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments/175854129"},"html":{"href":"https://github.com/envoyproxy/data-plane-api/pull/564#discussion_r175854129"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/564"}},"in_reply_to_id":175526955},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/564","id":175970061,"html_url":"https://github.com/envoyproxy/data-plane-api/pull/564","diff_url":"https://github.com/envoyproxy/data-plane-api/pull/564.diff","patch_url":"https://github.com/envoyproxy/data-plane-api/pull/564.patch","issue_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/564","number":564,"state":"open","locked":false,"title":"http connection manager: adding support for dns san entries. Fixes #2535","user":{"login":"shakti-das","id":19265455,"avatar_url":"https://avatars1.githubusercontent.com/u/19265455?v=4","gravatar_id":"","url":"https://api.github.com/users/shakti-das","html_url":"https://github.com/shakti-das","followers_url":"https://api.github.com/users/shakti-das/followers","following_url":"https://api.github.com/users/shakti-das/following{/other_user}","gists_url":"https://api.github.com/users/shakti-das/gists{/gist_id}","starred_url":"https://api.github.com/users/shakti-das/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakti-das/subscriptions","organizations_url":"https://api.github.com/users/shakti-das/orgs","repos_url":"https://api.github.com/users/shakti-das/repos","events_url":"https://api.github.com/users/shakti-das/events{/privacy}","received_events_url":"https://api.github.com/users/shakti-das/received_events","type":"User","site_admin":false},"body":"This will add a flag, which if enabled, dns san entries will be appended to the XFCC header.\r\n\r\nSigned-off-by: Shakti <shaktiprakash.das@salesforce.com>\r\n\r\nRelated to: https://github.com/envoyproxy/envoy/issues/2535","created_at":"2018-03-19T17:23:37Z","updated_at":"2018-03-20T17:22:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1915ac469ca5cab938314fb9b6554241a2224a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/564/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/564/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/564/comments","statuses_url":"https://api.github.com/repos/envoyproxy/data-plane-api/statuses/5178d52866fb3f7b5d666ccd0cfc34ece7e03799","head":{"label":"shakti-das:shakti/xfcc-dns","ref":"shakti/xfcc-dns","sha":"5178d52866fb3f7b5d666ccd0cfc34ece7e03799","user":{"login":"shakti-das","id":19265455,"avatar_url":"https://avatars1.githubusercontent.com/u/19265455?v=4","gravatar_id":"","url":"https://api.github.com/users/shakti-das","html_url":"https://github.com/shakti-das","followers_url":"https://api.github.com/users/shakti-das/followers","following_url":"https://api.github.com/users/shakti-das/following{/other_user}","gists_url":"https://api.github.com/users/shakti-das/gists{/gist_id}","starred_url":"https://api.github.com/users/shakti-das/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakti-das/subscriptions","organizations_url":"https://api.github.com/users/shakti-das/orgs","repos_url":"https://api.github.com/users/shakti-das/repos","events_url":"https://api.github.com/users/shakti-das/events{/privacy}","received_events_url":"https://api.github.com/users/shakti-das/received_events","type":"User","site_admin":false},"repo":{"id":125233577,"name":"data-plane-api","full_name":"shakti-das/data-plane-api","owner":{"login":"shakti-das","id":19265455,"avatar_url":"https://avatars1.githubusercontent.com/u/19265455?v=4","gravatar_id":"","url":"https://api.github.com/users/shakti-das","html_url":"https://github.com/shakti-das","followers_url":"https://api.github.com/users/shakti-das/followers","following_url":"https://api.github.com/users/shakti-das/following{/other_user}","gists_url":"https://api.github.com/users/shakti-das/gists{/gist_id}","starred_url":"https://api.github.com/users/shakti-das/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakti-das/subscriptions","organizations_url":"https://api.github.com/users/shakti-das/orgs","repos_url":"https://api.github.com/users/shakti-das/repos","events_url":"https://api.github.com/users/shakti-das/events{/privacy}","received_events_url":"https://api.github.com/users/shakti-das/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shakti-das/data-plane-api","description":"Envoy REST/proto API definitions and documentation","fork":true,"url":"https://api.github.com/repos/shakti-das/data-plane-api","forks_url":"https://api.github.com/repos/shakti-das/data-plane-api/forks","keys_url":"https://api.github.com/repos/shakti-das/data-plane-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shakti-das/data-plane-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shakti-das/data-plane-api/teams","hooks_url":"https://api.github.com/repos/shakti-das/data-plane-api/hooks","issue_events_url":"https://api.github.com/repos/shakti-das/data-plane-api/issues/events{/number}","events_url":"https://api.github.com/repos/shakti-das/data-plane-api/events","assignees_url":"https://api.github.com/repos/shakti-das/data-plane-api/assignees{/user}","branches_url":"https://api.github.com/repos/shakti-das/data-plane-api/branches{/branch}","tags_url":"https://api.github.com/repos/shakti-das/data-plane-api/tags","blobs_url":"https://api.github.com/repos/shakti-das/data-plane-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shakti-das/data-plane-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shakti-das/data-plane-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/shakti-das/data-plane-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shakti-das/data-plane-api/statuses/{sha}","languages_url":"https://api.github.com/repos/shakti-das/data-plane-api/languages","stargazers_url":"https://api.github.com/repos/shakti-das/data-plane-api/stargazers","contributors_url":"https://api.github.com/repos/shakti-das/data-plane-api/contributors","subscribers_url":"https://api.github.com/repos/shakti-das/data-plane-api/subscribers","subscription_url":"https://api.github.com/repos/shakti-das/data-plane-api/subscription","commits_url":"https://api.github.com/repos/shakti-das/data-plane-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/shakti-das/data-plane-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/shakti-das/data-plane-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/shakti-das/data-plane-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/shakti-das/data-plane-api/contents/{+path}","compare_url":"https://api.github.com/repos/shakti-das/data-plane-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shakti-das/data-plane-api/merges","archive_url":"https://api.github.com/repos/shakti-das/data-plane-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shakti-das/data-plane-api/downloads","issues_url":"https://api.github.com/repos/shakti-das/data-plane-api/issues{/number}","pulls_url":"https://api.github.com/repos/shakti-das/data-plane-api/pulls{/number}","milestones_url":"https://api.github.com/repos/shakti-das/data-plane-api/milestones{/number}","notifications_url":"https://api.github.com/repos/shakti-das/data-plane-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shakti-das/data-plane-api/labels{/name}","releases_url":"https://api.github.com/repos/shakti-das/data-plane-api/releases{/id}","deployments_url":"https://api.github.com/repos/shakti-das/data-plane-api/deployments","created_at":"2018-03-14T15:25:19Z","updated_at":"2018-03-18T15:09:48Z","pushed_at":"2018-03-19T17:48:12Z","git_url":"git://github.com/shakti-das/data-plane-api.git","ssh_url":"git@github.com:shakti-das/data-plane-api.git","clone_url":"https://github.com/shakti-das/data-plane-api.git","svn_url":"https://github.com/shakti-das/data-plane-api","homepage":"","size":1283,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"756f8140ed16d96126aa406694a2353a56d1d2ba","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":90675549,"name":"data-plane-api","full_name":"envoyproxy/data-plane-api","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/data-plane-api","description":"Envoy REST/proto API definitions and documentation","fork":false,"url":"https://api.github.com/repos/envoyproxy/data-plane-api","forks_url":"https://api.github.com/repos/envoyproxy/data-plane-api/forks","keys_url":"https://api.github.com/repos/envoyproxy/data-plane-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/data-plane-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/data-plane-api/teams","hooks_url":"https://api.github.com/repos/envoyproxy/data-plane-api/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/data-plane-api/events","assignees_url":"https://api.github.com/repos/envoyproxy/data-plane-api/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/data-plane-api/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/data-plane-api/tags","blobs_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/data-plane-api/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/data-plane-api/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/data-plane-api/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/data-plane-api/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/data-plane-api/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/data-plane-api/subscription","commits_url":"https://api.github.com/repos/envoyproxy/data-plane-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/data-plane-api/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/data-plane-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/data-plane-api/merges","archive_url":"https://api.github.com/repos/envoyproxy/data-plane-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/data-plane-api/downloads","issues_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/data-plane-api/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/data-plane-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/data-plane-api/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/data-plane-api/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/deployments","created_at":"2017-05-08T21:50:29Z","updated_at":"2018-03-19T20:46:29Z","pushed_at":"2018-03-20T17:00:45Z","git_url":"git://github.com/envoyproxy/data-plane-api.git","ssh_url":"git@github.com:envoyproxy/data-plane-api.git","clone_url":"https://github.com/envoyproxy/data-plane-api.git","svn_url":"https://github.com/envoyproxy/data-plane-api","homepage":"","size":1294,"stargazers_count":93,"watchers_count":93,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":108,"open_issues":26,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/564"},"html":{"href":"https://github.com/envoyproxy/data-plane-api/pull/564"},"issue":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/564"},"comments":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/564/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/564/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/564/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/statuses/5178d52866fb3f7b5d666ccd0cfc34ece7e03799"}},"author_association":"NONE"}}
{"actor":{"display_login":"mattklein123"}}