{"action":"created","comment":{"url":"https://api.github.com/repos/unicode-org/icu/pulls/comments/211445068","pull_request_review_id":147866191,"id":211445068,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTQ0NTA2OA==","diff_hunk":"@@ -18,7 +18,7 @@\n \n // This file contains only desktop windows behavior\n // Windows UWP calls Windows::Globalization directly, so this isn't needed there.\n-#if U_PLATFORM_USES_ONLY_WIN32_API && (U_PLATFORM_HAS_WINUWP_API == 0)\n+#if U_PLATFORM_USES_ONLY_WIN32_API || U_PLATFORM_HAS_WINUWP_API\n ","path":"icu4c/source/common/wintz.h","position":6,"original_position":6,"commit_id":"eba9e56d09fbe33c442b79638dce48e0a639afd4","original_commit_id":"eba9e56d09fbe33c442b79638dce48e0a639afd4","user":{"login":"jefgen","id":29107334,"node_id":"MDQ6VXNlcjI5MTA3MzM0","avatar_url":"https://avatars2.githubusercontent.com/u/29107334?v=4","gravatar_id":"","url":"https://api.github.com/users/jefgen","html_url":"https://github.com/jefgen","followers_url":"https://api.github.com/users/jefgen/followers","following_url":"https://api.github.com/users/jefgen/following{/other_user}","gists_url":"https://api.github.com/users/jefgen/gists{/gist_id}","starred_url":"https://api.github.com/users/jefgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefgen/subscriptions","organizations_url":"https://api.github.com/users/jefgen/orgs","repos_url":"https://api.github.com/users/jefgen/repos","events_url":"https://api.github.com/users/jefgen/events{/privacy}","received_events_url":"https://api.github.com/users/jefgen/received_events","type":"User","site_admin":false},"body":"I think this could probably be changed to just `U_PLATFORM_HAS_WIN32_API` .","created_at":"2018-08-21T00:10:28Z","updated_at":"2018-08-21T00:10:28Z","html_url":"https://github.com/unicode-org/icu/pull/55#discussion_r211445068","pull_request_url":"https://api.github.com/repos/unicode-org/icu/pulls/55","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/comments/211445068"},"html":{"href":"https://github.com/unicode-org/icu/pull/55#discussion_r211445068"},"pull_request":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/unicode-org/icu/pulls/55","id":208077669,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDc3NjY5","html_url":"https://github.com/unicode-org/icu/pull/55","diff_url":"https://github.com/unicode-org/icu/pull/55.diff","patch_url":"https://github.com/unicode-org/icu/pull/55.patch","issue_url":"https://api.github.com/repos/unicode-org/icu/issues/55","number":55,"state":"open","locked":false,"title":"ICU-13842 Use GetDynamicTimeZoneInformation instead of Windows registry access in wintz.cpp","user":{"login":"mingyzha","id":39807811,"node_id":"MDQ6VXNlcjM5ODA3ODEx","avatar_url":"https://avatars2.githubusercontent.com/u/39807811?v=4","gravatar_id":"","url":"https://api.github.com/users/mingyzha","html_url":"https://github.com/mingyzha","followers_url":"https://api.github.com/users/mingyzha/followers","following_url":"https://api.github.com/users/mingyzha/following{/other_user}","gists_url":"https://api.github.com/users/mingyzha/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyzha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyzha/subscriptions","organizations_url":"https://api.github.com/users/mingyzha/orgs","repos_url":"https://api.github.com/users/mingyzha/repos","events_url":"https://api.github.com/users/mingyzha/events{/privacy}","received_events_url":"https://api.github.com/users/mingyzha/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request.\r\nPlease see http://site.icu-project.org/processes/contribute for general\r\ninformation on contributing to ICU.\r\n\r\nYou will be automatically asked to sign the contributors license before the PR is accepted.\r\n- sign: https://cla-assistant.io/unicode-org/icu\r\n- license: http://www.unicode.org/copyright.html#License\r\n-->\r\n\r\nUse GetDynamicTimeZoneInformation instead of accessing the Windows registries so that it does not rely on COM in wintz. So that UWP apps could also use this code. \r\n\r\n##### Checklist\r\n\r\n- [x] Issue filed at https://unicode-org.atlassian.net :  ICU-13842\r\n- [x] Update PR title to include Issue number\r\n- [x] Issue accepted\r\n- [ ] Tests included\r\n- [ ] Documentation is changed or added\r\n\r\n","created_at":"2018-08-13T19:24:29Z","updated_at":"2018-08-21T00:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"066c3f8e4bf1dd56809574367865aee618f49d5a","assignee":{"login":"jefgen","id":29107334,"node_id":"MDQ6VXNlcjI5MTA3MzM0","avatar_url":"https://avatars2.githubusercontent.com/u/29107334?v=4","gravatar_id":"","url":"https://api.github.com/users/jefgen","html_url":"https://github.com/jefgen","followers_url":"https://api.github.com/users/jefgen/followers","following_url":"https://api.github.com/users/jefgen/following{/other_user}","gists_url":"https://api.github.com/users/jefgen/gists{/gist_id}","starred_url":"https://api.github.com/users/jefgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefgen/subscriptions","organizations_url":"https://api.github.com/users/jefgen/orgs","repos_url":"https://api.github.com/users/jefgen/repos","events_url":"https://api.github.com/users/jefgen/events{/privacy}","received_events_url":"https://api.github.com/users/jefgen/received_events","type":"User","site_admin":false},"assignees":[{"login":"jefgen","id":29107334,"node_id":"MDQ6VXNlcjI5MTA3MzM0","avatar_url":"https://avatars2.githubusercontent.com/u/29107334?v=4","gravatar_id":"","url":"https://api.github.com/users/jefgen","html_url":"https://github.com/jefgen","followers_url":"https://api.github.com/users/jefgen/followers","following_url":"https://api.github.com/users/jefgen/following{/other_user}","gists_url":"https://api.github.com/users/jefgen/gists{/gist_id}","starred_url":"https://api.github.com/users/jefgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefgen/subscriptions","organizations_url":"https://api.github.com/users/jefgen/orgs","repos_url":"https://api.github.com/users/jefgen/repos","events_url":"https://api.github.com/users/jefgen/events{/privacy}","received_events_url":"https://api.github.com/users/jefgen/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ShawnSteele","id":12376133,"node_id":"MDQ6VXNlcjEyMzc2MTMz","avatar_url":"https://avatars1.githubusercontent.com/u/12376133?v=4","gravatar_id":"","url":"https://api.github.com/users/ShawnSteele","html_url":"https://github.com/ShawnSteele","followers_url":"https://api.github.com/users/ShawnSteele/followers","following_url":"https://api.github.com/users/ShawnSteele/following{/other_user}","gists_url":"https://api.github.com/users/ShawnSteele/gists{/gist_id}","starred_url":"https://api.github.com/users/ShawnSteele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShawnSteele/subscriptions","organizations_url":"https://api.github.com/users/ShawnSteele/orgs","repos_url":"https://api.github.com/users/ShawnSteele/repos","events_url":"https://api.github.com/users/ShawnSteele/events{/privacy}","received_events_url":"https://api.github.com/users/ShawnSteele/received_events","type":"User","site_admin":false},{"login":"daniel-ju","id":41210545,"node_id":"MDQ6VXNlcjQxMjEwNTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/41210545?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-ju","html_url":"https://github.com/daniel-ju","followers_url":"https://api.github.com/users/daniel-ju/followers","following_url":"https://api.github.com/users/daniel-ju/following{/other_user}","gists_url":"https://api.github.com/users/daniel-ju/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-ju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-ju/subscriptions","organizations_url":"https://api.github.com/users/daniel-ju/orgs","repos_url":"https://api.github.com/users/daniel-ju/repos","events_url":"https://api.github.com/users/daniel-ju/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-ju/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unicode-org/icu/pulls/55/commits","review_comments_url":"https://api.github.com/repos/unicode-org/icu/pulls/55/comments","review_comment_url":"https://api.github.com/repos/unicode-org/icu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unicode-org/icu/issues/55/comments","statuses_url":"https://api.github.com/repos/unicode-org/icu/statuses/eba9e56d09fbe33c442b79638dce48e0a639afd4","head":{"label":"mingyzha:mingyzha/13842-wintz-dynamictimezoneinfo","ref":"mingyzha/13842-wintz-dynamictimezoneinfo","sha":"eba9e56d09fbe33c442b79638dce48e0a639afd4","user":{"login":"mingyzha","id":39807811,"node_id":"MDQ6VXNlcjM5ODA3ODEx","avatar_url":"https://avatars2.githubusercontent.com/u/39807811?v=4","gravatar_id":"","url":"https://api.github.com/users/mingyzha","html_url":"https://github.com/mingyzha","followers_url":"https://api.github.com/users/mingyzha/followers","following_url":"https://api.github.com/users/mingyzha/following{/other_user}","gists_url":"https://api.github.com/users/mingyzha/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyzha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyzha/subscriptions","organizations_url":"https://api.github.com/users/mingyzha/orgs","repos_url":"https://api.github.com/users/mingyzha/repos","events_url":"https://api.github.com/users/mingyzha/events{/privacy}","received_events_url":"https://api.github.com/users/mingyzha/received_events","type":"User","site_admin":false},"repo":{"id":144069963,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQwNjk5NjM=","name":"icu","full_name":"mingyzha/icu","owner":{"login":"mingyzha","id":39807811,"node_id":"MDQ6VXNlcjM5ODA3ODEx","avatar_url":"https://avatars2.githubusercontent.com/u/39807811?v=4","gravatar_id":"","url":"https://api.github.com/users/mingyzha","html_url":"https://github.com/mingyzha","followers_url":"https://api.github.com/users/mingyzha/followers","following_url":"https://api.github.com/users/mingyzha/following{/other_user}","gists_url":"https://api.github.com/users/mingyzha/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyzha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyzha/subscriptions","organizations_url":"https://api.github.com/users/mingyzha/orgs","repos_url":"https://api.github.com/users/mingyzha/repos","events_url":"https://api.github.com/users/mingyzha/events{/privacy}","received_events_url":"https://api.github.com/users/mingyzha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mingyzha/icu","description":"The new home of the ICU project source code.","fork":true,"url":"https://api.github.com/repos/mingyzha/icu","forks_url":"https://api.github.com/repos/mingyzha/icu/forks","keys_url":"https://api.github.com/repos/mingyzha/icu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mingyzha/icu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mingyzha/icu/teams","hooks_url":"https://api.github.com/repos/mingyzha/icu/hooks","issue_events_url":"https://api.github.com/repos/mingyzha/icu/issues/events{/number}","events_url":"https://api.github.com/repos/mingyzha/icu/events","assignees_url":"https://api.github.com/repos/mingyzha/icu/assignees{/user}","branches_url":"https://api.github.com/repos/mingyzha/icu/branches{/branch}","tags_url":"https://api.github.com/repos/mingyzha/icu/tags","blobs_url":"https://api.github.com/repos/mingyzha/icu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mingyzha/icu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mingyzha/icu/git/refs{/sha}","trees_url":"https://api.github.com/repos/mingyzha/icu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mingyzha/icu/statuses/{sha}","languages_url":"https://api.github.com/repos/mingyzha/icu/languages","stargazers_url":"https://api.github.com/repos/mingyzha/icu/stargazers","contributors_url":"https://api.github.com/repos/mingyzha/icu/contributors","subscribers_url":"https://api.github.com/repos/mingyzha/icu/subscribers","subscription_url":"https://api.github.com/repos/mingyzha/icu/subscription","commits_url":"https://api.github.com/repos/mingyzha/icu/commits{/sha}","git_commits_url":"https://api.github.com/repos/mingyzha/icu/git/commits{/sha}","comments_url":"https://api.github.com/repos/mingyzha/icu/comments{/number}","issue_comment_url":"https://api.github.com/repos/mingyzha/icu/issues/comments{/number}","contents_url":"https://api.github.com/repos/mingyzha/icu/contents/{+path}","compare_url":"https://api.github.com/repos/mingyzha/icu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mingyzha/icu/merges","archive_url":"https://api.github.com/repos/mingyzha/icu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mingyzha/icu/downloads","issues_url":"https://api.github.com/repos/mingyzha/icu/issues{/number}","pulls_url":"https://api.github.com/repos/mingyzha/icu/pulls{/number}","milestones_url":"https://api.github.com/repos/mingyzha/icu/milestones{/number}","notifications_url":"https://api.github.com/repos/mingyzha/icu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mingyzha/icu/labels{/name}","releases_url":"https://api.github.com/repos/mingyzha/icu/releases{/id}","deployments_url":"https://api.github.com/repos/mingyzha/icu/deployments","created_at":"2018-08-08T21:36:05Z","updated_at":"2018-08-08T21:36:32Z","pushed_at":"2018-08-20T22:44:23Z","git_url":"git://github.com/mingyzha/icu.git","ssh_url":"git@github.com:mingyzha/icu.git","clone_url":"https://github.com/mingyzha/icu.git","svn_url":"https://github.com/mingyzha/icu","homepage":"http://icu-project.org","size":225645,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unicode-org:master","ref":"master","sha":"cff53a1fe0d156a9b0c0e85f8a4c35e3170c6953","user":{"login":"unicode-org","id":13873561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODczNTYx","avatar_url":"https://avatars2.githubusercontent.com/u/13873561?v=4","gravatar_id":"","url":"https://api.github.com/users/unicode-org","html_url":"https://github.com/unicode-org","followers_url":"https://api.github.com/users/unicode-org/followers","following_url":"https://api.github.com/users/unicode-org/following{/other_user}","gists_url":"https://api.github.com/users/unicode-org/gists{/gist_id}","starred_url":"https://api.github.com/users/unicode-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicode-org/subscriptions","organizations_url":"https://api.github.com/users/unicode-org/orgs","repos_url":"https://api.github.com/users/unicode-org/repos","events_url":"https://api.github.com/users/unicode-org/events{/privacy}","received_events_url":"https://api.github.com/users/unicode-org/received_events","type":"Organization","site_admin":false},"repo":{"id":49244766,"node_id":"MDEwOlJlcG9zaXRvcnk0OTI0NDc2Ng==","name":"icu","full_name":"unicode-org/icu","owner":{"login":"unicode-org","id":13873561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODczNTYx","avatar_url":"https://avatars2.githubusercontent.com/u/13873561?v=4","gravatar_id":"","url":"https://api.github.com/users/unicode-org","html_url":"https://github.com/unicode-org","followers_url":"https://api.github.com/users/unicode-org/followers","following_url":"https://api.github.com/users/unicode-org/following{/other_user}","gists_url":"https://api.github.com/users/unicode-org/gists{/gist_id}","starred_url":"https://api.github.com/users/unicode-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicode-org/subscriptions","organizations_url":"https://api.github.com/users/unicode-org/orgs","repos_url":"https://api.github.com/users/unicode-org/repos","events_url":"https://api.github.com/users/unicode-org/events{/privacy}","received_events_url":"https://api.github.com/users/unicode-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unicode-org/icu","description":"The new home of the ICU project source code.","fork":false,"url":"https://api.github.com/repos/unicode-org/icu","forks_url":"https://api.github.com/repos/unicode-org/icu/forks","keys_url":"https://api.github.com/repos/unicode-org/icu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unicode-org/icu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unicode-org/icu/teams","hooks_url":"https://api.github.com/repos/unicode-org/icu/hooks","issue_events_url":"https://api.github.com/repos/unicode-org/icu/issues/events{/number}","events_url":"https://api.github.com/repos/unicode-org/icu/events","assignees_url":"https://api.github.com/repos/unicode-org/icu/assignees{/user}","branches_url":"https://api.github.com/repos/unicode-org/icu/branches{/branch}","tags_url":"https://api.github.com/repos/unicode-org/icu/tags","blobs_url":"https://api.github.com/repos/unicode-org/icu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unicode-org/icu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unicode-org/icu/git/refs{/sha}","trees_url":"https://api.github.com/repos/unicode-org/icu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unicode-org/icu/statuses/{sha}","languages_url":"https://api.github.com/repos/unicode-org/icu/languages","stargazers_url":"https://api.github.com/repos/unicode-org/icu/stargazers","contributors_url":"https://api.github.com/repos/unicode-org/icu/contributors","subscribers_url":"https://api.github.com/repos/unicode-org/icu/subscribers","subscription_url":"https://api.github.com/repos/unicode-org/icu/subscription","commits_url":"https://api.github.com/repos/unicode-org/icu/commits{/sha}","git_commits_url":"https://api.github.com/repos/unicode-org/icu/git/commits{/sha}","comments_url":"https://api.github.com/repos/unicode-org/icu/comments{/number}","issue_comment_url":"https://api.github.com/repos/unicode-org/icu/issues/comments{/number}","contents_url":"https://api.github.com/repos/unicode-org/icu/contents/{+path}","compare_url":"https://api.github.com/repos/unicode-org/icu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unicode-org/icu/merges","archive_url":"https://api.github.com/repos/unicode-org/icu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unicode-org/icu/downloads","issues_url":"https://api.github.com/repos/unicode-org/icu/issues{/number}","pulls_url":"https://api.github.com/repos/unicode-org/icu/pulls{/number}","milestones_url":"https://api.github.com/repos/unicode-org/icu/milestones{/number}","notifications_url":"https://api.github.com/repos/unicode-org/icu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unicode-org/icu/labels{/name}","releases_url":"https://api.github.com/repos/unicode-org/icu/releases{/id}","deployments_url":"https://api.github.com/repos/unicode-org/icu/deployments","created_at":"2016-01-08T02:42:32Z","updated_at":"2018-08-20T23:40:51Z","pushed_at":"2018-08-20T23:40:47Z","git_url":"git://github.com/unicode-org/icu.git","ssh_url":"git@github.com:unicode-org/icu.git","clone_url":"https://github.com/unicode-org/icu.git","svn_url":"https://github.com/unicode-org/icu","homepage":"http://icu-project.org","size":238534,"stargazers_count":123,"watchers_count":123,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":45,"open_issues":16,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/55"},"html":{"href":"https://github.com/unicode-org/icu/pull/55"},"issue":{"href":"https://api.github.com/repos/unicode-org/icu/issues/55"},"comments":{"href":"https://api.github.com/repos/unicode-org/icu/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/unicode-org/icu/statuses/eba9e56d09fbe33c442b79638dce48e0a639afd4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jefgen"}}