{"action":"created","comment":{"url":"https://api.github.com/repos/minishift/minishift/pulls/comments/204983810","pull_request_review_id":140163384,"id":204983810,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDk4MzgxMA==","diff_hunk":"@@ -72,6 +74,45 @@ func (m *Minishift) profileShouldHaveState(profile string, expected string) erro\n \treturn nil\n }\n \n+func (m *Minishift) ShouldHaveNoOfProcessors(noOfprocessor int) error {\n+\tcpuInfo, err := m.runner.CpuInfo()\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\tcpuString := \"processor\\\\s*:\\\\s*\\\\d\"\n+\tre := regexp.MustCompile(cpuString)\n+\tlistItems := re.FindAllString(cpuInfo, -1)\n+\tif len(listItems) != noOfprocessor {\n+\t\treturn fmt.Errorf(\"The vm is running with %d no. of cpus. Expected: %d\", len(listItems), noOfprocessor)\n+\t}\n+\treturn nil\n+}\n+\n+//This function is only applicable for validating disk size between 11-98(GB/G/gb/g)\n+//applied through minishift disk-size flag\n+func (m *Minishift) ShouldHaveDiskSize(diskSizeString string) error {","path":"test/integration/testsuite/minishift.go","position":29,"original_position":29,"commit_id":"4040f804b09cb9b2a5b01bd5b514d1311fbab0db","original_commit_id":"4040f804b09cb9b2a5b01bd5b514d1311fbab0db","user":{"login":"amitkrout","id":19851115,"node_id":"MDQ6VXNlcjE5ODUxMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/19851115?v=4","gravatar_id":"","url":"https://api.github.com/users/amitkrout","html_url":"https://github.com/amitkrout","followers_url":"https://api.github.com/users/amitkrout/followers","following_url":"https://api.github.com/users/amitkrout/following{/other_user}","gists_url":"https://api.github.com/users/amitkrout/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkrout/subscriptions","organizations_url":"https://api.github.com/users/amitkrout/orgs","repos_url":"https://api.github.com/users/amitkrout/repos","events_url":"https://api.github.com/users/amitkrout/events{/privacy}","received_events_url":"https://api.github.com/users/amitkrout/received_events","type":"User","site_admin":false},"body":"Looks good and simple.  ","created_at":"2018-07-25T05:19:58Z","updated_at":"2018-07-25T05:19:59Z","html_url":"https://github.com/minishift/minishift/pull/2614#discussion_r204983810","pull_request_url":"https://api.github.com/repos/minishift/minishift/pulls/2614","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments/204983810"},"html":{"href":"https://github.com/minishift/minishift/pull/2614#discussion_r204983810"},"pull_request":{"href":"https://api.github.com/repos/minishift/minishift/pulls/2614"}},"in_reply_to_id":204377706},"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/2614","id":202258089,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjU4MDg5","html_url":"https://github.com/minishift/minishift/pull/2614","diff_url":"https://github.com/minishift/minishift/pull/2614.diff","patch_url":"https://github.com/minishift/minishift/pull/2614.patch","issue_url":"https://api.github.com/repos/minishift/minishift/issues/2614","number":2614,"state":"open","locked":false,"title":"[WIP] Issue #1722 implement step definition of cpu and disk size check","user":{"login":"amitkrout","id":19851115,"node_id":"MDQ6VXNlcjE5ODUxMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/19851115?v=4","gravatar_id":"","url":"https://api.github.com/users/amitkrout","html_url":"https://github.com/amitkrout","followers_url":"https://api.github.com/users/amitkrout/followers","following_url":"https://api.github.com/users/amitkrout/following{/other_user}","gists_url":"https://api.github.com/users/amitkrout/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkrout/subscriptions","organizations_url":"https://api.github.com/users/amitkrout/orgs","repos_url":"https://api.github.com/users/amitkrout/repos","events_url":"https://api.github.com/users/amitkrout/events{/privacy}","received_events_url":"https://api.github.com/users/amitkrout/received_events","type":"User","site_admin":false},"body":"Fix : #1722","created_at":"2018-07-18T13:44:06Z","updated_at":"2018-07-25T05:19:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8191417a35b3577ed4d1e71c6e66ad7abc0fb49c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minishift/minishift/pulls/2614/commits","review_comments_url":"https://api.github.com/repos/minishift/minishift/pulls/2614/comments","review_comment_url":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/2614/comments","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/4040f804b09cb9b2a5b01bd5b514d1311fbab0db","head":{"label":"amitkrout:Issue_1722","ref":"Issue_1722","sha":"4040f804b09cb9b2a5b01bd5b514d1311fbab0db","user":{"login":"amitkrout","id":19851115,"node_id":"MDQ6VXNlcjE5ODUxMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/19851115?v=4","gravatar_id":"","url":"https://api.github.com/users/amitkrout","html_url":"https://github.com/amitkrout","followers_url":"https://api.github.com/users/amitkrout/followers","following_url":"https://api.github.com/users/amitkrout/following{/other_user}","gists_url":"https://api.github.com/users/amitkrout/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkrout/subscriptions","organizations_url":"https://api.github.com/users/amitkrout/orgs","repos_url":"https://api.github.com/users/amitkrout/repos","events_url":"https://api.github.com/users/amitkrout/events{/privacy}","received_events_url":"https://api.github.com/users/amitkrout/received_events","type":"User","site_admin":false},"repo":{"id":106280447,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYyODA0NDc=","name":"minishift","full_name":"amitkrout/minishift","owner":{"login":"amitkrout","id":19851115,"node_id":"MDQ6VXNlcjE5ODUxMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/19851115?v=4","gravatar_id":"","url":"https://api.github.com/users/amitkrout","html_url":"https://github.com/amitkrout","followers_url":"https://api.github.com/users/amitkrout/followers","following_url":"https://api.github.com/users/amitkrout/following{/other_user}","gists_url":"https://api.github.com/users/amitkrout/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkrout/subscriptions","organizations_url":"https://api.github.com/users/amitkrout/orgs","repos_url":"https://api.github.com/users/amitkrout/repos","events_url":"https://api.github.com/users/amitkrout/events{/privacy}","received_events_url":"https://api.github.com/users/amitkrout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amitkrout/minishift","description":"Run OpenShift locally","fork":true,"url":"https://api.github.com/repos/amitkrout/minishift","forks_url":"https://api.github.com/repos/amitkrout/minishift/forks","keys_url":"https://api.github.com/repos/amitkrout/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amitkrout/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amitkrout/minishift/teams","hooks_url":"https://api.github.com/repos/amitkrout/minishift/hooks","issue_events_url":"https://api.github.com/repos/amitkrout/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/amitkrout/minishift/events","assignees_url":"https://api.github.com/repos/amitkrout/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/amitkrout/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/amitkrout/minishift/tags","blobs_url":"https://api.github.com/repos/amitkrout/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amitkrout/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amitkrout/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/amitkrout/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amitkrout/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/amitkrout/minishift/languages","stargazers_url":"https://api.github.com/repos/amitkrout/minishift/stargazers","contributors_url":"https://api.github.com/repos/amitkrout/minishift/contributors","subscribers_url":"https://api.github.com/repos/amitkrout/minishift/subscribers","subscription_url":"https://api.github.com/repos/amitkrout/minishift/subscription","commits_url":"https://api.github.com/repos/amitkrout/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/amitkrout/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/amitkrout/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/amitkrout/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/amitkrout/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/amitkrout/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amitkrout/minishift/merges","archive_url":"https://api.github.com/repos/amitkrout/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amitkrout/minishift/downloads","issues_url":"https://api.github.com/repos/amitkrout/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/amitkrout/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/amitkrout/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/amitkrout/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amitkrout/minishift/labels{/name}","releases_url":"https://api.github.com/repos/amitkrout/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/amitkrout/minishift/deployments","created_at":"2017-10-09T12:25:39Z","updated_at":"2018-07-24T06:44:24Z","pushed_at":"2018-07-24T06:44:20Z","git_url":"git://github.com/amitkrout/minishift.git","ssh_url":"git@github.com:amitkrout/minishift.git","clone_url":"https://github.com/amitkrout/minishift.git","svn_url":"https://github.com/amitkrout/minishift","homepage":"","size":173692,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minishift:master","ref":"master","sha":"6ab47995d27567c996508e04081a0c34c75589cf","user":{"login":"minishift","id":23212309,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjEyMzA5","avatar_url":"https://avatars1.githubusercontent.com/u/23212309?v=4","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"repo":{"id":62728051,"node_id":"MDEwOlJlcG9zaXRvcnk2MjcyODA1MQ==","name":"minishift","full_name":"minishift/minishift","owner":{"login":"minishift","id":23212309,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjEyMzA5","avatar_url":"https://avatars1.githubusercontent.com/u/23212309?v=4","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minishift/minishift","description":"Run OpenShift locally","fork":false,"url":"https://api.github.com/repos/minishift/minishift","forks_url":"https://api.github.com/repos/minishift/minishift/forks","keys_url":"https://api.github.com/repos/minishift/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minishift/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minishift/minishift/teams","hooks_url":"https://api.github.com/repos/minishift/minishift/hooks","issue_events_url":"https://api.github.com/repos/minishift/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/minishift/minishift/events","assignees_url":"https://api.github.com/repos/minishift/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/minishift/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/minishift/minishift/tags","blobs_url":"https://api.github.com/repos/minishift/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minishift/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minishift/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/minishift/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/minishift/minishift/languages","stargazers_url":"https://api.github.com/repos/minishift/minishift/stargazers","contributors_url":"https://api.github.com/repos/minishift/minishift/contributors","subscribers_url":"https://api.github.com/repos/minishift/minishift/subscribers","subscription_url":"https://api.github.com/repos/minishift/minishift/subscription","commits_url":"https://api.github.com/repos/minishift/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/minishift/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/minishift/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/minishift/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/minishift/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/minishift/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minishift/minishift/merges","archive_url":"https://api.github.com/repos/minishift/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minishift/minishift/downloads","issues_url":"https://api.github.com/repos/minishift/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/minishift/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/minishift/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/minishift/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minishift/minishift/labels{/name}","releases_url":"https://api.github.com/repos/minishift/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/minishift/minishift/deployments","created_at":"2016-07-06T14:37:20Z","updated_at":"2018-07-24T14:04:12Z","pushed_at":"2018-07-24T13:28:32Z","git_url":"git://github.com/minishift/minishift.git","ssh_url":"git@github.com:minishift/minishift.git","clone_url":"https://github.com/minishift/minishift.git","svn_url":"https://github.com/minishift/minishift","homepage":"","size":174816,"stargazers_count":1169,"watchers_count":1169,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":230,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":250,"open_issues":230,"watchers":1169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/2614"},"html":{"href":"https://github.com/minishift/minishift/pull/2614"},"issue":{"href":"https://api.github.com/repos/minishift/minishift/issues/2614"},"comments":{"href":"https://api.github.com/repos/minishift/minishift/issues/2614/comments"},"review_comments":{"href":"https://api.github.com/repos/minishift/minishift/pulls/2614/comments"},"review_comment":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minishift/minishift/pulls/2614/commits"},"statuses":{"href":"https://api.github.com/repos/minishift/minishift/statuses/4040f804b09cb9b2a5b01bd5b514d1311fbab0db"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"amitkrout"}}