{"action":"created","comment":{"url":"https://api.github.com/repos/pmodels/mpich/pulls/comments/229300581","pull_request_review_id":169765656,"id":229300581,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTMwMDU4MQ==","diff_hunk":"@@ -607,6 +607,92 @@ static int network_split_by_minsize(MPIR_Comm * comm_ptr, int key, int subcomm_m\n   fn_fail:\n     goto fn_exit;\n }\n+\n+static int network_split_by_min_memsize(MPIR_Comm * comm_ptr, int key, long min_mem_size,\n+                                        MPIR_Comm ** newcomm_ptr)","path":"src/mpi/comm/comm_split_type.c","position":170,"original_position":6,"commit_id":"4db62ceedb74826bf0d1aeefa20355fdd3089736","original_commit_id":"1417e24a2a03c83d5ad518e79b87213e06abf169","user":{"login":"pavanbalaji","id":4279602,"node_id":"MDQ6VXNlcjQyNzk2MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/4279602?v=4","gravatar_id":"","url":"https://api.github.com/users/pavanbalaji","html_url":"https://github.com/pavanbalaji","followers_url":"https://api.github.com/users/pavanbalaji/followers","following_url":"https://api.github.com/users/pavanbalaji/following{/other_user}","gists_url":"https://api.github.com/users/pavanbalaji/gists{/gist_id}","starred_url":"https://api.github.com/users/pavanbalaji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavanbalaji/subscriptions","organizations_url":"https://api.github.com/users/pavanbalaji/orgs","repos_url":"https://api.github.com/users/pavanbalaji/repos","events_url":"https://api.github.com/users/pavanbalaji/events{/privacy}","received_events_url":"https://api.github.com/users/pavanbalaji/received_events","type":"User","site_admin":false},"body":"I think it's reasonable to assume that.  I don't know of any reasonable system where that's not true, and I'm sure we'll run into a number of other weird problems if that weren't true.","created_at":"2018-10-30T13:18:44Z","updated_at":"2018-10-30T13:18:45Z","html_url":"https://github.com/pmodels/mpich/pull/3204#discussion_r229300581","pull_request_url":"https://api.github.com/repos/pmodels/mpich/pulls/3204","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/comments/229300581"},"html":{"href":"https://github.com/pmodels/mpich/pull/3204#discussion_r229300581"},"pull_request":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/3204"}},"in_reply_to_id":229143250},"pull_request":{"url":"https://api.github.com/repos/pmodels/mpich/pulls/3204","id":197971413,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTcxNDEz","html_url":"https://github.com/pmodels/mpich/pull/3204","diff_url":"https://github.com/pmodels/mpich/pull/3204.diff","patch_url":"https://github.com/pmodels/mpich/pull/3204.patch","issue_url":"https://api.github.com/repos/pmodels/mpich/issues/3204","number":3204,"state":"open","locked":false,"title":"#Network level hints 4: Torus network detection and split hints for torus topology","user":{"login":"KavithaTipturMadhu","id":1934591,"node_id":"MDQ6VXNlcjE5MzQ1OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1934591?v=4","gravatar_id":"","url":"https://api.github.com/users/KavithaTipturMadhu","html_url":"https://github.com/KavithaTipturMadhu","followers_url":"https://api.github.com/users/KavithaTipturMadhu/followers","following_url":"https://api.github.com/users/KavithaTipturMadhu/following{/other_user}","gists_url":"https://api.github.com/users/KavithaTipturMadhu/gists{/gist_id}","starred_url":"https://api.github.com/users/KavithaTipturMadhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KavithaTipturMadhu/subscriptions","organizations_url":"https://api.github.com/users/KavithaTipturMadhu/orgs","repos_url":"https://api.github.com/users/KavithaTipturMadhu/repos","events_url":"https://api.github.com/users/KavithaTipturMadhu/events{/privacy}","received_events_url":"https://api.github.com/users/KavithaTipturMadhu/received_events","type":"User","site_admin":false},"body":"This PR adds support to check if the input network topology file is a torus/mesh graph and computes the relative coordinates of the nodes in the network graph, and adds support for both minimum communicator size and minimum memory size split hints. Known limitation of the type classification algorithm is that torus links must be omitted when generating the input network topology file.  Test graph files are attached in the PR.\r\n[meshgraphs.zip](https://github.com/pmodels/mpich/files/2477651/meshgraphs.zip)\r\n","created_at":"2018-06-28T09:36:25Z","updated_at":"2018-10-30T13:18:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"485fa05a2e2392d41aa8dca2e6b56fc60bfc01f8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"raffenet","id":1410792,"node_id":"MDQ6VXNlcjE0MTA3OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1410792?v=4","gravatar_id":"","url":"https://api.github.com/users/raffenet","html_url":"https://github.com/raffenet","followers_url":"https://api.github.com/users/raffenet/followers","following_url":"https://api.github.com/users/raffenet/following{/other_user}","gists_url":"https://api.github.com/users/raffenet/gists{/gist_id}","starred_url":"https://api.github.com/users/raffenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raffenet/subscriptions","organizations_url":"https://api.github.com/users/raffenet/orgs","repos_url":"https://api.github.com/users/raffenet/repos","events_url":"https://api.github.com/users/raffenet/events{/privacy}","received_events_url":"https://api.github.com/users/raffenet/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pmodels/mpich/pulls/3204/commits","review_comments_url":"https://api.github.com/repos/pmodels/mpich/pulls/3204/comments","review_comment_url":"https://api.github.com/repos/pmodels/mpich/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmodels/mpich/issues/3204/comments","statuses_url":"https://api.github.com/repos/pmodels/mpich/statuses/4db62ceedb74826bf0d1aeefa20355fdd3089736","head":{"label":"KavithaTipturMadhu:torus","ref":"torus","sha":"4db62ceedb74826bf0d1aeefa20355fdd3089736","user":{"login":"KavithaTipturMadhu","id":1934591,"node_id":"MDQ6VXNlcjE5MzQ1OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1934591?v=4","gravatar_id":"","url":"https://api.github.com/users/KavithaTipturMadhu","html_url":"https://github.com/KavithaTipturMadhu","followers_url":"https://api.github.com/users/KavithaTipturMadhu/followers","following_url":"https://api.github.com/users/KavithaTipturMadhu/following{/other_user}","gists_url":"https://api.github.com/users/KavithaTipturMadhu/gists{/gist_id}","starred_url":"https://api.github.com/users/KavithaTipturMadhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KavithaTipturMadhu/subscriptions","organizations_url":"https://api.github.com/users/KavithaTipturMadhu/orgs","repos_url":"https://api.github.com/users/KavithaTipturMadhu/repos","events_url":"https://api.github.com/users/KavithaTipturMadhu/events{/privacy}","received_events_url":"https://api.github.com/users/KavithaTipturMadhu/received_events","type":"User","site_admin":false},"repo":{"id":101928017,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE5MjgwMTc=","name":"mpich","full_name":"KavithaTipturMadhu/mpich","private":false,"owner":{"login":"KavithaTipturMadhu","id":1934591,"node_id":"MDQ6VXNlcjE5MzQ1OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1934591?v=4","gravatar_id":"","url":"https://api.github.com/users/KavithaTipturMadhu","html_url":"https://github.com/KavithaTipturMadhu","followers_url":"https://api.github.com/users/KavithaTipturMadhu/followers","following_url":"https://api.github.com/users/KavithaTipturMadhu/following{/other_user}","gists_url":"https://api.github.com/users/KavithaTipturMadhu/gists{/gist_id}","starred_url":"https://api.github.com/users/KavithaTipturMadhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KavithaTipturMadhu/subscriptions","organizations_url":"https://api.github.com/users/KavithaTipturMadhu/orgs","repos_url":"https://api.github.com/users/KavithaTipturMadhu/repos","events_url":"https://api.github.com/users/KavithaTipturMadhu/events{/privacy}","received_events_url":"https://api.github.com/users/KavithaTipturMadhu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KavithaTipturMadhu/mpich","description":"Official MPICH Repository","fork":true,"url":"https://api.github.com/repos/KavithaTipturMadhu/mpich","forks_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/forks","keys_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/teams","hooks_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/hooks","issue_events_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/issues/events{/number}","events_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/events","assignees_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/assignees{/user}","branches_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/branches{/branch}","tags_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/tags","blobs_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/git/refs{/sha}","trees_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/statuses/{sha}","languages_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/languages","stargazers_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/stargazers","contributors_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/contributors","subscribers_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/subscribers","subscription_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/subscription","commits_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/commits{/sha}","git_commits_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/git/commits{/sha}","comments_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/comments{/number}","issue_comment_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/issues/comments{/number}","contents_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/contents/{+path}","compare_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/merges","archive_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/downloads","issues_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/issues{/number}","pulls_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/pulls{/number}","milestones_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/milestones{/number}","notifications_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/labels{/name}","releases_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/releases{/id}","deployments_url":"https://api.github.com/repos/KavithaTipturMadhu/mpich/deployments","created_at":"2017-08-30T20:56:16Z","updated_at":"2018-05-22T01:40:38Z","pushed_at":"2018-10-30T03:02:27Z","git_url":"git://github.com/KavithaTipturMadhu/mpich.git","ssh_url":"git@github.com:KavithaTipturMadhu/mpich.git","clone_url":"https://github.com/KavithaTipturMadhu/mpich.git","svn_url":"https://github.com/KavithaTipturMadhu/mpich","homepage":"http://www.mpich.org","size":57803,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pmodels:master","ref":"master","sha":"dfc0f563475d6ab8f8568cd1035c221c068fa051","user":{"login":"pmodels","id":15700567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NzAwNTY3","avatar_url":"https://avatars2.githubusercontent.com/u/15700567?v=4","gravatar_id":"","url":"https://api.github.com/users/pmodels","html_url":"https://github.com/pmodels","followers_url":"https://api.github.com/users/pmodels/followers","following_url":"https://api.github.com/users/pmodels/following{/other_user}","gists_url":"https://api.github.com/users/pmodels/gists{/gist_id}","starred_url":"https://api.github.com/users/pmodels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmodels/subscriptions","organizations_url":"https://api.github.com/users/pmodels/orgs","repos_url":"https://api.github.com/users/pmodels/repos","events_url":"https://api.github.com/users/pmodels/events{/privacy}","received_events_url":"https://api.github.com/users/pmodels/received_events","type":"Organization","site_admin":false},"repo":{"id":70918679,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkxODY3OQ==","name":"mpich","full_name":"pmodels/mpich","private":false,"owner":{"login":"pmodels","id":15700567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NzAwNTY3","avatar_url":"https://avatars2.githubusercontent.com/u/15700567?v=4","gravatar_id":"","url":"https://api.github.com/users/pmodels","html_url":"https://github.com/pmodels","followers_url":"https://api.github.com/users/pmodels/followers","following_url":"https://api.github.com/users/pmodels/following{/other_user}","gists_url":"https://api.github.com/users/pmodels/gists{/gist_id}","starred_url":"https://api.github.com/users/pmodels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmodels/subscriptions","organizations_url":"https://api.github.com/users/pmodels/orgs","repos_url":"https://api.github.com/users/pmodels/repos","events_url":"https://api.github.com/users/pmodels/events{/privacy}","received_events_url":"https://api.github.com/users/pmodels/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pmodels/mpich","description":"Official MPICH Repository","fork":false,"url":"https://api.github.com/repos/pmodels/mpich","forks_url":"https://api.github.com/repos/pmodels/mpich/forks","keys_url":"https://api.github.com/repos/pmodels/mpich/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmodels/mpich/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmodels/mpich/teams","hooks_url":"https://api.github.com/repos/pmodels/mpich/hooks","issue_events_url":"https://api.github.com/repos/pmodels/mpich/issues/events{/number}","events_url":"https://api.github.com/repos/pmodels/mpich/events","assignees_url":"https://api.github.com/repos/pmodels/mpich/assignees{/user}","branches_url":"https://api.github.com/repos/pmodels/mpich/branches{/branch}","tags_url":"https://api.github.com/repos/pmodels/mpich/tags","blobs_url":"https://api.github.com/repos/pmodels/mpich/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmodels/mpich/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmodels/mpich/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmodels/mpich/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmodels/mpich/statuses/{sha}","languages_url":"https://api.github.com/repos/pmodels/mpich/languages","stargazers_url":"https://api.github.com/repos/pmodels/mpich/stargazers","contributors_url":"https://api.github.com/repos/pmodels/mpich/contributors","subscribers_url":"https://api.github.com/repos/pmodels/mpich/subscribers","subscription_url":"https://api.github.com/repos/pmodels/mpich/subscription","commits_url":"https://api.github.com/repos/pmodels/mpich/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmodels/mpich/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmodels/mpich/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmodels/mpich/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmodels/mpich/contents/{+path}","compare_url":"https://api.github.com/repos/pmodels/mpich/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmodels/mpich/merges","archive_url":"https://api.github.com/repos/pmodels/mpich/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmodels/mpich/downloads","issues_url":"https://api.github.com/repos/pmodels/mpich/issues{/number}","pulls_url":"https://api.github.com/repos/pmodels/mpich/pulls{/number}","milestones_url":"https://api.github.com/repos/pmodels/mpich/milestones{/number}","notifications_url":"https://api.github.com/repos/pmodels/mpich/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmodels/mpich/labels{/name}","releases_url":"https://api.github.com/repos/pmodels/mpich/releases{/id}","deployments_url":"https://api.github.com/repos/pmodels/mpich/deployments","created_at":"2016-10-14T14:39:42Z","updated_at":"2018-10-30T00:19:19Z","pushed_at":"2018-10-30T13:18:35Z","git_url":"git://github.com/pmodels/mpich.git","ssh_url":"git@github.com:pmodels/mpich.git","clone_url":"https://github.com/pmodels/mpich.git","svn_url":"https://github.com/pmodels/mpich","homepage":"http://www.mpich.org","size":57875,"stargazers_count":120,"watchers_count":120,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":406,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":109,"open_issues":406,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/3204"},"html":{"href":"https://github.com/pmodels/mpich/pull/3204"},"issue":{"href":"https://api.github.com/repos/pmodels/mpich/issues/3204"},"comments":{"href":"https://api.github.com/repos/pmodels/mpich/issues/3204/comments"},"review_comments":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/3204/comments"},"review_comment":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/3204/commits"},"statuses":{"href":"https://api.github.com/repos/pmodels/mpich/statuses/4db62ceedb74826bf0d1aeefa20355fdd3089736"}},"author_association":"NONE"}}
{"actor":{"display_login":"pavanbalaji"}}