{"action":"opened","number":1024,"pull_request":{"url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/pulls/1024","id":225529242,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTI5MjQy","html_url":"https://github.com/Microsoft/BotFramework-Emulator/pull/1024","diff_url":"https://github.com/Microsoft/BotFramework-Emulator/pull/1024.diff","patch_url":"https://github.com/Microsoft/BotFramework-Emulator/pull/1024.patch","issue_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/issues/1024","number":1024,"state":"open","locked":false,"title":"Ngrok bypass: simple fix to have the bypass setting up to date with the state.","user":{"login":"carlosscastro","id":21318528,"node_id":"MDQ6VXNlcjIxMzE4NTI4","avatar_url":"https://avatars3.githubusercontent.com/u/21318528?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosscastro","html_url":"https://github.com/carlosscastro","followers_url":"https://api.github.com/users/carlosscastro/followers","following_url":"https://api.github.com/users/carlosscastro/following{/other_user}","gists_url":"https://api.github.com/users/carlosscastro/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosscastro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosscastro/subscriptions","organizations_url":"https://api.github.com/users/carlosscastro/orgs","repos_url":"https://api.github.com/users/carlosscastro/repos","events_url":"https://api.github.com/users/carlosscastro/events{/privacy}","received_events_url":"https://api.github.com/users/carlosscastro/received_events","type":"User","site_admin":false},"body":"Currently, bypass is `undefined` when the `getServiceUrl(botUrl: string): string` method is called. Reusing the logic we use to keep address and port in sync with the state. *This entire piece of logic should be refactored, adding a surgical fix for now. *","created_at":"2018-10-24T19:51:39Z","updated_at":"2018-10-24T19:51:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/pulls/1024/commits","review_comments_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/pulls/1024/comments","review_comment_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/issues/1024/comments","statuses_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/statuses/bf2d5bc64ab3fa876f5b5c1ef5f8963f214b209c","head":{"label":"Microsoft:ccastro/fix-ngrok-bypass-local","ref":"ccastro/fix-ngrok-bypass-local","sha":"bf2d5bc64ab3fa876f5b5c1ef5f8963f214b209c","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":73518607,"node_id":"MDEwOlJlcG9zaXRvcnk3MzUxODYwNw==","name":"BotFramework-Emulator","full_name":"Microsoft/BotFramework-Emulator","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/BotFramework-Emulator","description":"Bot Framework Emulator","fork":false,"url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator","forks_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/forks","keys_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/teams","hooks_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/events","assignees_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/tags","blobs_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/languages","stargazers_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/subscription","commits_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/merges","archive_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/downloads","issues_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/deployments","created_at":"2016-11-11T23:15:09Z","updated_at":"2018-10-24T14:34:34Z","pushed_at":"2018-10-24T19:49:53Z","git_url":"git://github.com/Microsoft/BotFramework-Emulator.git","ssh_url":"git@github.com:Microsoft/BotFramework-Emulator.git","clone_url":"https://github.com/Microsoft/BotFramework-Emulator.git","svn_url":"https://github.com/Microsoft/BotFramework-Emulator","homepage":"https://aka.ms/botemulator","size":37811,"stargazers_count":811,"watchers_count":811,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":347,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":347,"open_issues":136,"watchers":811,"default_branch":"v4"}},"base":{"label":"Microsoft:v4","ref":"v4","sha":"bc1aeac1ad8a47eb7084d7537a82e5be6ba5f9d9","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":73518607,"node_id":"MDEwOlJlcG9zaXRvcnk3MzUxODYwNw==","name":"BotFramework-Emulator","full_name":"Microsoft/BotFramework-Emulator","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/BotFramework-Emulator","description":"Bot Framework Emulator","fork":false,"url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator","forks_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/forks","keys_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/teams","hooks_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/events","assignees_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/tags","blobs_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/languages","stargazers_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/subscription","commits_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/merges","archive_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/downloads","issues_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/deployments","created_at":"2016-11-11T23:15:09Z","updated_at":"2018-10-24T14:34:34Z","pushed_at":"2018-10-24T19:49:53Z","git_url":"git://github.com/Microsoft/BotFramework-Emulator.git","ssh_url":"git@github.com:Microsoft/BotFramework-Emulator.git","clone_url":"https://github.com/Microsoft/BotFramework-Emulator.git","svn_url":"https://github.com/Microsoft/BotFramework-Emulator","homepage":"https://aka.ms/botemulator","size":37811,"stargazers_count":811,"watchers_count":811,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":347,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":347,"open_issues":136,"watchers":811,"default_branch":"v4"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/pulls/1024"},"html":{"href":"https://github.com/Microsoft/BotFramework-Emulator/pull/1024"},"issue":{"href":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/issues/1024"},"comments":{"href":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/issues/1024/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/pulls/1024/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/pulls/1024/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/BotFramework-Emulator/statuses/bf2d5bc64ab3fa876f5b5c1ef5f8963f214b209c"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"carlosscastro"}}