{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/33279","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/33279/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/33279/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/33279/events","html_url":"https://github.com/owncloud/core/pull/33279","id":373381397,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzIyOTYy","number":33279,"title":"ignore shared storages when listing versions","user":{"login":"butonic","id":956847,"node_id":"MDQ6VXNlcjk1Njg0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/956847?v=4","gravatar_id":"","url":"https://api.github.com/users/butonic","html_url":"https://github.com/butonic","followers_url":"https://api.github.com/users/butonic/followers","following_url":"https://api.github.com/users/butonic/following{/other_user}","gists_url":"https://api.github.com/users/butonic/gists{/gist_id}","starred_url":"https://api.github.com/users/butonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/butonic/subscriptions","organizations_url":"https://api.github.com/users/butonic/orgs","repos_url":"https://api.github.com/users/butonic/repos","events_url":"https://api.github.com/users/butonic/events{/privacy}","received_events_url":"https://api.github.com/users/butonic/received_events","type":"User","site_admin":false},"labels":[{"id":17709846,"node_id":"MDU6TGFiZWwxNzcwOTg0Ng==","url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed","default":false},{"id":32695114,"node_id":"MDU6TGFiZWwzMjY5NTExNA==","url":"https://api.github.com/repos/owncloud/core/labels/app:files_versions","name":"app:files_versions","color":"02d7e1","default":false},{"id":132150275,"node_id":"MDU6TGFiZWwxMzIxNTAyNzU=","url":"https://api.github.com/repos/owncloud/core/labels/backport-request","name":"backport-request","color":"006b75","default":false}],"state":"open","locked":false,"assignee":{"login":"butonic","id":956847,"node_id":"MDQ6VXNlcjk1Njg0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/956847?v=4","gravatar_id":"","url":"https://api.github.com/users/butonic","html_url":"https://github.com/butonic","followers_url":"https://api.github.com/users/butonic/followers","following_url":"https://api.github.com/users/butonic/following{/other_user}","gists_url":"https://api.github.com/users/butonic/gists{/gist_id}","starred_url":"https://api.github.com/users/butonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/butonic/subscriptions","organizations_url":"https://api.github.com/users/butonic/orgs","repos_url":"https://api.github.com/users/butonic/repos","events_url":"https://api.github.com/users/butonic/events{/privacy}","received_events_url":"https://api.github.com/users/butonic/received_events","type":"User","site_admin":false},"assignees":[{"login":"butonic","id":956847,"node_id":"MDQ6VXNlcjk1Njg0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/956847?v=4","gravatar_id":"","url":"https://api.github.com/users/butonic","html_url":"https://github.com/butonic","followers_url":"https://api.github.com/users/butonic/followers","following_url":"https://api.github.com/users/butonic/following{/other_user}","gists_url":"https://api.github.com/users/butonic/gists{/gist_id}","starred_url":"https://api.github.com/users/butonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/butonic/subscriptions","organizations_url":"https://api.github.com/users/butonic/orgs","repos_url":"https://api.github.com/users/butonic/repos","events_url":"https://api.github.com/users/butonic/events{/privacy}","received_events_url":"https://api.github.com/users/butonic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-24T09:11:36Z","updated_at":"2018-10-24T14:07:42Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/33279","html_url":"https://github.com/owncloud/core/pull/33279","diff_url":"https://github.com/owncloud/core/pull/33279.diff","patch_url":"https://github.com/owncloud/core/pull/33279.patch"},"body":"otherwise the wrong storage might be used to look up the path, leading to an empty versions list. might also help a little with slow versions responses because it now skips shared storages\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/432672378","html_url":"https://github.com/owncloud/core/pull/33279#issuecomment-432672378","issue_url":"https://api.github.com/repos/owncloud/core/issues/33279","id":432672378,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjY3MjM3OA==","user":{"login":"jmdeboer-surfsara","id":23337494,"node_id":"MDQ6VXNlcjIzMzM3NDk0","avatar_url":"https://avatars2.githubusercontent.com/u/23337494?v=4","gravatar_id":"","url":"https://api.github.com/users/jmdeboer-surfsara","html_url":"https://github.com/jmdeboer-surfsara","followers_url":"https://api.github.com/users/jmdeboer-surfsara/followers","following_url":"https://api.github.com/users/jmdeboer-surfsara/following{/other_user}","gists_url":"https://api.github.com/users/jmdeboer-surfsara/gists{/gist_id}","starred_url":"https://api.github.com/users/jmdeboer-surfsara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmdeboer-surfsara/subscriptions","organizations_url":"https://api.github.com/users/jmdeboer-surfsara/orgs","repos_url":"https://api.github.com/users/jmdeboer-surfsara/repos","events_url":"https://api.github.com/users/jmdeboer-surfsara/events{/privacy}","received_events_url":"https://api.github.com/users/jmdeboer-surfsara/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T14:07:42Z","updated_at":"2018-10-24T14:07:42Z","author_association":"NONE","body":"From testing, I can see this does have a positive effect.\r\n\r\nThis is before the change:\r\n```\r\n{\"type\":\"SUMMARY\",\"reqId\":\"W9A99X145MsVrx8R1CLNjgAAAAA\",\"time\":\"2018-10-24T11:40:09+02:00\",\"remoteAddr\":\"172.16.0.191\",\"user\":\"xxx@xxx.xx\",\"method\":\"PROPFIND\",\"url\":\"\\/files1009\\/remote.php\\/dav\\/meta\\/4167839355\\/v\",\"diagnostics\":{\"totalSQLQueries\":3102,\"totalSQLDurationmsec\":751.38664245605469,\"totalSQLParams\":5911,\"totalEvents\":15,\"totalEventsDurationmsec\":77.86870002746582}}\r\n```\r\nAnd this is after:\r\n```\r\n{\"type\":\"SUMMARY\",\"reqId\":\"W9Bn3XytKdtBuY82Yk4TAAAAABo\",\"time\":\"2018-10-24T14:38:55+02:00\",\"remoteAddr\":\"172.16.0.191\",\"user\":xxx@xxx.xx\",\"method\":\"PROPFIND\",\"url\":\"\\/files1009\\/remote.php\\/dav\\/meta\\/4167839355\\/v\",\"diagnostics\":{\"totalSQLQueries\":1035,\"totalSQLDurationmsec\":247.71213531494141,\"totalSQLParams\":1816,\"totalEvents\":15,\"totalEventsDurationmsec\":127.16984748840332}}\r\n```\r\n"}}
{"actor":{"display_login":"jmdeboer-surfsara"}}