{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/docfx/pulls/comments/245207845","pull_request_review_id":189264812,"id":245207845,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTIwNzg0NQ==","diff_hunk":"@@ -31,7 +35,14 @@ internal sealed class Config\n         /// <summary>\n         /// Gets the file glob patterns excluded from this docset.\n         /// </summary>\n-        public readonly string[] Exclude = s_defaultExclude;\n+        public readonly string[] Exclude = Array.Empty<string>();\n+\n+        /// <summary>\n+        /// Gets the default file glob patterns excluded from this docset.\n+        /// This typically contains system reserved exclude patterns,\n+        /// users are recommended to use <see cref=\"Exclude\"/> to exclude files.\n+        /// </summary>\n+        public readonly string[] DefaultExclude = s_defaultExclude;","path":"src/docfx/config/Config.cs","position":27,"original_position":27,"commit_id":"432f76e851865aad294a0bb8a1d923e363bbaaed","original_commit_id":"432f76e851865aad294a0bb8a1d923e363bbaaed","user":{"login":"superyyrrzz","id":3831744,"node_id":"MDQ6VXNlcjM4MzE3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3831744?v=4","gravatar_id":"","url":"https://api.github.com/users/superyyrrzz","html_url":"https://github.com/superyyrrzz","followers_url":"https://api.github.com/users/superyyrrzz/followers","following_url":"https://api.github.com/users/superyyrrzz/following{/other_user}","gists_url":"https://api.github.com/users/superyyrrzz/gists{/gist_id}","starred_url":"https://api.github.com/users/superyyrrzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superyyrrzz/subscriptions","organizations_url":"https://api.github.com/users/superyyrrzz/orgs","repos_url":"https://api.github.com/users/superyyrrzz/repos","events_url":"https://api.github.com/users/superyyrrzz/events{/privacy}","received_events_url":"https://api.github.com/users/superyyrrzz/received_events","type":"User","site_admin":false},"body":"`defaultExclude` has been limited to docfx reserved folders like `_site`, `localization`, which should not be overwrittern by user. It may confuse user whether to use `exclude` or `defaultExclude`, so we can only expose `exclude`","created_at":"2019-01-04T05:19:52Z","updated_at":"2019-01-04T05:19:52Z","html_url":"https://github.com/dotnet/docfx/pull/3860#discussion_r245207845","pull_request_url":"https://api.github.com/repos/dotnet/docfx/pulls/3860","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/docfx/pulls/comments/245207845"},"html":{"href":"https://github.com/dotnet/docfx/pull/3860#discussion_r245207845"},"pull_request":{"href":"https://api.github.com/repos/dotnet/docfx/pulls/3860"}},"in_reply_to_id":245206071},"pull_request":{"url":"https://api.github.com/repos/dotnet/docfx/pulls/3860","id":241903913,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxOTAzOTEz","html_url":"https://github.com/dotnet/docfx/pull/3860","diff_url":"https://github.com/dotnet/docfx/pull/3860.diff","patch_url":"https://github.com/dotnet/docfx/pull/3860.patch","issue_url":"https://api.github.com/repos/dotnet/docfx/issues/3860","number":3860,"state":"open","locked":false,"title":"Include all markdown, yml, json files by default","user":{"login":"yufeih","id":511355,"node_id":"MDQ6VXNlcjUxMTM1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/511355?v=4","gravatar_id":"","url":"https://api.github.com/users/yufeih","html_url":"https://github.com/yufeih","followers_url":"https://api.github.com/users/yufeih/followers","following_url":"https://api.github.com/users/yufeih/following{/other_user}","gists_url":"https://api.github.com/users/yufeih/gists{/gist_id}","starred_url":"https://api.github.com/users/yufeih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yufeih/subscriptions","organizations_url":"https://api.github.com/users/yufeih/orgs","repos_url":"https://api.github.com/users/yufeih/repos","events_url":"https://api.github.com/users/yufeih/events{/privacy}","received_events_url":"https://api.github.com/users/yufeih/received_events","type":"User","site_admin":false},"body":"Implements #3687 ","created_at":"2019-01-03T04:36:27Z","updated_at":"2019-01-04T05:19:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e16d9f2e1ff8acd4b1f499661562581f3e7da2f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"herohua","id":2174068,"node_id":"MDQ6VXNlcjIxNzQwNjg=","avatar_url":"https://avatars3.githubusercontent.com/u/2174068?v=4","gravatar_id":"","url":"https://api.github.com/users/herohua","html_url":"https://github.com/herohua","followers_url":"https://api.github.com/users/herohua/followers","following_url":"https://api.github.com/users/herohua/following{/other_user}","gists_url":"https://api.github.com/users/herohua/gists{/gist_id}","starred_url":"https://api.github.com/users/herohua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herohua/subscriptions","organizations_url":"https://api.github.com/users/herohua/orgs","repos_url":"https://api.github.com/users/herohua/repos","events_url":"https://api.github.com/users/herohua/events{/privacy}","received_events_url":"https://api.github.com/users/herohua/received_events","type":"User","site_admin":false},{"login":"superyyrrzz","id":3831744,"node_id":"MDQ6VXNlcjM4MzE3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3831744?v=4","gravatar_id":"","url":"https://api.github.com/users/superyyrrzz","html_url":"https://github.com/superyyrrzz","followers_url":"https://api.github.com/users/superyyrrzz/followers","following_url":"https://api.github.com/users/superyyrrzz/following{/other_user}","gists_url":"https://api.github.com/users/superyyrrzz/gists{/gist_id}","starred_url":"https://api.github.com/users/superyyrrzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superyyrrzz/subscriptions","organizations_url":"https://api.github.com/users/superyyrrzz/orgs","repos_url":"https://api.github.com/users/superyyrrzz/repos","events_url":"https://api.github.com/users/superyyrrzz/events{/privacy}","received_events_url":"https://api.github.com/users/superyyrrzz/received_events","type":"User","site_admin":false},{"login":"928PJY","id":17958546,"node_id":"MDQ6VXNlcjE3OTU4NTQ2","avatar_url":"https://avatars1.githubusercontent.com/u/17958546?v=4","gravatar_id":"","url":"https://api.github.com/users/928PJY","html_url":"https://github.com/928PJY","followers_url":"https://api.github.com/users/928PJY/followers","following_url":"https://api.github.com/users/928PJY/following{/other_user}","gists_url":"https://api.github.com/users/928PJY/gists{/gist_id}","starred_url":"https://api.github.com/users/928PJY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/928PJY/subscriptions","organizations_url":"https://api.github.com/users/928PJY/orgs","repos_url":"https://api.github.com/users/928PJY/repos","events_url":"https://api.github.com/users/928PJY/events{/privacy}","received_events_url":"https://api.github.com/users/928PJY/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":666587409,"node_id":"MDU6TGFiZWw2NjY1ODc0MDk=","url":"https://api.github.com/repos/dotnet/docfx/labels/v3","name":"v3","color":"C594C5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/docfx/pulls/3860/commits","review_comments_url":"https://api.github.com/repos/dotnet/docfx/pulls/3860/comments","review_comment_url":"https://api.github.com/repos/dotnet/docfx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/docfx/issues/3860/comments","statuses_url":"https://api.github.com/repos/dotnet/docfx/statuses/432f76e851865aad294a0bb8a1d923e363bbaaed","head":{"label":"yufeih:default-exclude","ref":"default-exclude","sha":"432f76e851865aad294a0bb8a1d923e363bbaaed","user":{"login":"yufeih","id":511355,"node_id":"MDQ6VXNlcjUxMTM1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/511355?v=4","gravatar_id":"","url":"https://api.github.com/users/yufeih","html_url":"https://github.com/yufeih","followers_url":"https://api.github.com/users/yufeih/followers","following_url":"https://api.github.com/users/yufeih/following{/other_user}","gists_url":"https://api.github.com/users/yufeih/gists{/gist_id}","starred_url":"https://api.github.com/users/yufeih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yufeih/subscriptions","organizations_url":"https://api.github.com/users/yufeih/orgs","repos_url":"https://api.github.com/users/yufeih/repos","events_url":"https://api.github.com/users/yufeih/events{/privacy}","received_events_url":"https://api.github.com/users/yufeih/received_events","type":"User","site_admin":false},"repo":{"id":77028436,"node_id":"MDEwOlJlcG9zaXRvcnk3NzAyODQzNg==","name":"docfx","full_name":"yufeih/docfx","private":false,"owner":{"login":"yufeih","id":511355,"node_id":"MDQ6VXNlcjUxMTM1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/511355?v=4","gravatar_id":"","url":"https://api.github.com/users/yufeih","html_url":"https://github.com/yufeih","followers_url":"https://api.github.com/users/yufeih/followers","following_url":"https://api.github.com/users/yufeih/following{/other_user}","gists_url":"https://api.github.com/users/yufeih/gists{/gist_id}","starred_url":"https://api.github.com/users/yufeih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yufeih/subscriptions","organizations_url":"https://api.github.com/users/yufeih/orgs","repos_url":"https://api.github.com/users/yufeih/repos","events_url":"https://api.github.com/users/yufeih/events{/privacy}","received_events_url":"https://api.github.com/users/yufeih/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yufeih/docfx","description":"Tools for building and publishing API documentation for .NET projects","fork":true,"url":"https://api.github.com/repos/yufeih/docfx","forks_url":"https://api.github.com/repos/yufeih/docfx/forks","keys_url":"https://api.github.com/repos/yufeih/docfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yufeih/docfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yufeih/docfx/teams","hooks_url":"https://api.github.com/repos/yufeih/docfx/hooks","issue_events_url":"https://api.github.com/repos/yufeih/docfx/issues/events{/number}","events_url":"https://api.github.com/repos/yufeih/docfx/events","assignees_url":"https://api.github.com/repos/yufeih/docfx/assignees{/user}","branches_url":"https://api.github.com/repos/yufeih/docfx/branches{/branch}","tags_url":"https://api.github.com/repos/yufeih/docfx/tags","blobs_url":"https://api.github.com/repos/yufeih/docfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yufeih/docfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yufeih/docfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/yufeih/docfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yufeih/docfx/statuses/{sha}","languages_url":"https://api.github.com/repos/yufeih/docfx/languages","stargazers_url":"https://api.github.com/repos/yufeih/docfx/stargazers","contributors_url":"https://api.github.com/repos/yufeih/docfx/contributors","subscribers_url":"https://api.github.com/repos/yufeih/docfx/subscribers","subscription_url":"https://api.github.com/repos/yufeih/docfx/subscription","commits_url":"https://api.github.com/repos/yufeih/docfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/yufeih/docfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/yufeih/docfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/yufeih/docfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/yufeih/docfx/contents/{+path}","compare_url":"https://api.github.com/repos/yufeih/docfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yufeih/docfx/merges","archive_url":"https://api.github.com/repos/yufeih/docfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yufeih/docfx/downloads","issues_url":"https://api.github.com/repos/yufeih/docfx/issues{/number}","pulls_url":"https://api.github.com/repos/yufeih/docfx/pulls{/number}","milestones_url":"https://api.github.com/repos/yufeih/docfx/milestones{/number}","notifications_url":"https://api.github.com/repos/yufeih/docfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yufeih/docfx/labels{/name}","releases_url":"https://api.github.com/repos/yufeih/docfx/releases{/id}","deployments_url":"https://api.github.com/repos/yufeih/docfx/deployments","created_at":"2016-12-21T07:24:17Z","updated_at":"2018-08-25T02:22:02Z","pushed_at":"2019-01-04T04:51:34Z","git_url":"git://github.com/yufeih/docfx.git","ssh_url":"git@github.com:yufeih/docfx.git","clone_url":"https://github.com/yufeih/docfx.git","svn_url":"https://github.com/yufeih/docfx","homepage":"http://dotnet.github.io/docfx/","size":105314,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"dotnet:v3","ref":"v3","sha":"3a0eda558bc21a890f5c860ee50ac0aab0b94730","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":38007053,"node_id":"MDEwOlJlcG9zaXRvcnkzODAwNzA1Mw==","name":"docfx","full_name":"dotnet/docfx","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/docfx","description":"Tools for building and publishing API documentation for .NET projects","fork":false,"url":"https://api.github.com/repos/dotnet/docfx","forks_url":"https://api.github.com/repos/dotnet/docfx/forks","keys_url":"https://api.github.com/repos/dotnet/docfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/docfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/docfx/teams","hooks_url":"https://api.github.com/repos/dotnet/docfx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/docfx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/docfx/events","assignees_url":"https://api.github.com/repos/dotnet/docfx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/docfx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/docfx/tags","blobs_url":"https://api.github.com/repos/dotnet/docfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/docfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/docfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/docfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/docfx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/docfx/languages","stargazers_url":"https://api.github.com/repos/dotnet/docfx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/docfx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/docfx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/docfx/subscription","commits_url":"https://api.github.com/repos/dotnet/docfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/docfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/docfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/docfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/docfx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/docfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/docfx/merges","archive_url":"https://api.github.com/repos/dotnet/docfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/docfx/downloads","issues_url":"https://api.github.com/repos/dotnet/docfx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/docfx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/docfx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/docfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/docfx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/docfx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/docfx/deployments","created_at":"2015-06-24T19:43:53Z","updated_at":"2019-01-04T03:42:02Z","pushed_at":"2019-01-04T05:12:13Z","git_url":"git://github.com/dotnet/docfx.git","ssh_url":"git@github.com:dotnet/docfx.git","clone_url":"https://github.com/dotnet/docfx.git","svn_url":"https://github.com/dotnet/docfx","homepage":"https://dotnet.github.io/docfx/","size":339395,"stargazers_count":1475,"watchers_count":1475,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":398,"mirror_url":null,"archived":false,"open_issues_count":338,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":398,"open_issues":338,"watchers":1475,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/docfx/pulls/3860"},"html":{"href":"https://github.com/dotnet/docfx/pull/3860"},"issue":{"href":"https://api.github.com/repos/dotnet/docfx/issues/3860"},"comments":{"href":"https://api.github.com/repos/dotnet/docfx/issues/3860/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/docfx/pulls/3860/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/docfx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/docfx/pulls/3860/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/docfx/statuses/432f76e851865aad294a0bb8a1d923e363bbaaed"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"superyyrrzz"}}