{"action":"closed","issue":{"url":"https://api.github.com/repos/killbill/killbill/issues/1014","repository_url":"https://api.github.com/repos/killbill/killbill","labels_url":"https://api.github.com/repos/killbill/killbill/issues/1014/labels{/name}","comments_url":"https://api.github.com/repos/killbill/killbill/issues/1014/comments","events_url":"https://api.github.com/repos/killbill/killbill/issues/1014/events","html_url":"https://github.com/killbill/killbill/issues/1014","id":336418784,"node_id":"MDU6SXNzdWUzMzY0MTg3ODQ=","number":1014,"title":"InvoicePaymentResource#getInvoicePayment should look at unsuccessful payments","user":{"login":"pierre","id":51940,"node_id":"MDQ6VXNlcjUxOTQw","avatar_url":"https://avatars2.githubusercontent.com/u/51940?v=4","gravatar_id":"","url":"https://api.github.com/users/pierre","html_url":"https://github.com/pierre","followers_url":"https://api.github.com/users/pierre/followers","following_url":"https://api.github.com/users/pierre/following{/other_user}","gists_url":"https://api.github.com/users/pierre/gists{/gist_id}","starred_url":"https://api.github.com/users/pierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierre/subscriptions","organizations_url":"https://api.github.com/users/pierre/orgs","repos_url":"https://api.github.com/users/pierre/repos","events_url":"https://api.github.com/users/pierre/events{/privacy}","received_events_url":"https://api.github.com/users/pierre/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"pierre","id":51940,"node_id":"MDQ6VXNlcjUxOTQw","avatar_url":"https://avatars2.githubusercontent.com/u/51940?v=4","gravatar_id":"","url":"https://api.github.com/users/pierre","html_url":"https://github.com/pierre","followers_url":"https://api.github.com/users/pierre/followers","following_url":"https://api.github.com/users/pierre/following{/other_user}","gists_url":"https://api.github.com/users/pierre/gists{/gist_id}","starred_url":"https://api.github.com/users/pierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierre/subscriptions","organizations_url":"https://api.github.com/users/pierre/orgs","repos_url":"https://api.github.com/users/pierre/repos","events_url":"https://api.github.com/users/pierre/events{/privacy}","received_events_url":"https://api.github.com/users/pierre/received_events","type":"User","site_admin":false},"assignees":[{"login":"pierre","id":51940,"node_id":"MDQ6VXNlcjUxOTQw","avatar_url":"https://avatars2.githubusercontent.com/u/51940?v=4","gravatar_id":"","url":"https://api.github.com/users/pierre","html_url":"https://github.com/pierre","followers_url":"https://api.github.com/users/pierre/followers","following_url":"https://api.github.com/users/pierre/following{/other_user}","gists_url":"https://api.github.com/users/pierre/gists{/gist_id}","starred_url":"https://api.github.com/users/pierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierre/subscriptions","organizations_url":"https://api.github.com/users/pierre/orgs","repos_url":"https://api.github.com/users/pierre/repos","events_url":"https://api.github.com/users/pierre/events{/privacy}","received_events_url":"https://api.github.com/users/pierre/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/killbill/killbill/milestones/50","html_url":"https://github.com/killbill/killbill/milestone/50","labels_url":"https://api.github.com/repos/killbill/killbill/milestones/50/labels","id":2369862,"node_id":"MDk6TWlsZXN0b25lMjM2OTg2Mg==","number":50,"title":"Release-0.20.0","description":"","creator":{"login":"pierre","id":51940,"node_id":"MDQ6VXNlcjUxOTQw","avatar_url":"https://avatars2.githubusercontent.com/u/51940?v=4","gravatar_id":"","url":"https://api.github.com/users/pierre","html_url":"https://github.com/pierre","followers_url":"https://api.github.com/users/pierre/followers","following_url":"https://api.github.com/users/pierre/following{/other_user}","gists_url":"https://api.github.com/users/pierre/gists{/gist_id}","starred_url":"https://api.github.com/users/pierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierre/subscriptions","organizations_url":"https://api.github.com/users/pierre/orgs","repos_url":"https://api.github.com/users/pierre/repos","events_url":"https://api.github.com/users/pierre/events{/privacy}","received_events_url":"https://api.github.com/users/pierre/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":95,"state":"open","created_at":"2017-03-07T18:17:37Z","updated_at":"2018-07-08T10:47:16Z","due_on":"2018-07-14T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-06-27T23:11:04Z","updated_at":"2018-07-08T10:47:16Z","closed_at":"2018-07-08T10:47:16Z","author_association":"MEMBER","body":"1. Regardless of the outcome of the payment, we want the `invoiceId` to be populated. It seems that the check `&& input.isSuccess()` should be relaxed\r\n2. Verify that with this fix, the Kaui invoice screen (e.g. `/accounts/f003d04d-9647-4f61-b2e3-0818f845a2d4/invoices/973f345b-6c69-474a-ad73-e335462a1b72`) displays the bottom table with failed (payment failure, unknown, etc.) payments."}}
{"actor":{"display_login":"pierre"}}