{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/machinelearning/issues/593","repository_url":"https://api.github.com/repos/dotnet/machinelearning","labels_url":"https://api.github.com/repos/dotnet/machinelearning/issues/593/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/593/comments","events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/593/events","html_url":"https://github.com/dotnet/machinelearning/issues/593","id":345356862,"node_id":"MDU6SXNzdWUzNDUzNTY4NjI=","number":593,"title":"DataCommand classes shouldn't be part of the API","user":{"login":"eerhardt","id":8291187,"node_id":"MDQ6VXNlcjgyOTExODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8291187?v=4","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"labels":[{"id":923215346,"node_id":"MDU6TGFiZWw5MjMyMTUzNDY=","url":"https://api.github.com/repos/dotnet/machinelearning/labels/api","name":"api","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-27T20:28:52Z","updated_at":"2018-07-28T13:29:53Z","closed_at":null,"author_association":"MEMBER","body":"Today we have classes like:\r\n\r\n* [TrainCommand](https://github.com/dotnet/machinelearning/blob/5e08fa1ea7bfb54f28ed0815cb6413e0068e6dd1/src/Microsoft.ML.Data/Commands/TrainCommand.cs#L35)\r\n* [CrossValidationCommand](https://github.com/dotnet/machinelearning/blob/0e37508501b974cd4779014e6319438d33845dbd/src/Microsoft.ML.Data/Commands/CrossValidationCommand.cs#L22)\r\n* Etc\r\n\r\nThese classes are meant to be invoked from the MAML command line, and not from a normal \"API\" user.\r\n\r\nHowever, this isn't possible to tell these shouldn't be used because these classes are in the same assembly as the \"TextLoader\" class (`Microsoft.ML.Data.dll`), which is obviously part of the core API and is shown in almost all examples.\r\n\r\nWe should decide what to do with these classes. If we should move them out into a separate assembly/nuget package/etc, so users aren't confused that they shouldn't be using them.\r\n\r\n/cc @TomFinley @Zruty0 "},"comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments/408608093","html_url":"https://github.com/dotnet/machinelearning/issues/593#issuecomment-408608093","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/593","id":408608093,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODYwODA5Mw==","user":{"login":"eerhardt","id":8291187,"node_id":"MDQ6VXNlcjgyOTExODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8291187?v=4","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"created_at":"2018-07-28T13:29:52Z","updated_at":"2018-07-28T13:29:52Z","author_association":"MEMBER","body":"> It also necessarily makes these components more conspicuous, not less, to have a nuget whose description is \"don't use this please\" vs. an invisible internal class buried in the assembly.\r\n\r\nThe thinking is they would live with the command line and/or GUI implementation.  They wouldn’t be a regular NuGet package that a consumer would install."}}
{"actor":{"display_login":"eerhardt"}}