{"action":"created","comment":{"url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls/comments/221742518","pull_request_review_id":160467440,"id":221742518,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTc0MjUxOA==","diff_hunk":"@@ -1,14 +1,22 @@\n import pyarrow.parquet as pq\n-import s3fs\n+import s3fs, datetime, os, s3, local\n \n (ceph_key, ceph_secret, ceph_endpoint) = (os.getenv('CEPH_KEY'), os.getenv('CEPH_SECRET'), os.getenv('CEPH_ENDPOINT'))\n client_kwargs = {'endpoint_url': ceph_endpoint}\n \n \n def get_dataset(key):\n-    s3 = s3fs.S3FileSystem(secret=ceph_secret, key=ceph_key, client_kwargs=client_kwargs)\n-    return pq.ParquetDataset(key, filesystem=s3).read_pandas().to_pandas()\n+    filesystem = s3fs.S3FileSystem(secret=ceph_secret, key=ceph_key, client_kwargs=client_kwargs)","path":"storage/ceph.py","position":12,"original_position":12,"commit_id":"2a67bf3f27fa16dd4e297d21c090de66ab2e3600","original_commit_id":"2a67bf3f27fa16dd4e297d21c090de66ab2e3600","user":{"login":"durandom","id":161888,"node_id":"MDQ6VXNlcjE2MTg4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/161888?v=4","gravatar_id":"","url":"https://api.github.com/users/durandom","html_url":"https://github.com/durandom","followers_url":"https://api.github.com/users/durandom/followers","following_url":"https://api.github.com/users/durandom/following{/other_user}","gists_url":"https://api.github.com/users/durandom/gists{/gist_id}","starred_url":"https://api.github.com/users/durandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durandom/subscriptions","organizations_url":"https://api.github.com/users/durandom/orgs","repos_url":"https://api.github.com/users/durandom/repos","events_url":"https://api.github.com/users/durandom/events{/privacy}","received_events_url":"https://api.github.com/users/durandom/received_events","type":"User","site_admin":false},"body":"Oh, my bad. those 2 changes seem to be fine. ","created_at":"2018-10-01T20:17:46Z","updated_at":"2018-10-01T20:17:46Z","html_url":"https://github.com/RedHatInsights/aicoe-insights-clustering/pull/12#discussion_r221742518","pull_request_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls/12","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls/comments/221742518"},"html":{"href":"https://github.com/RedHatInsights/aicoe-insights-clustering/pull/12#discussion_r221742518"},"pull_request":{"href":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls/12"}},"in_reply_to_id":221735809},"pull_request":{"url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls/12","id":219465049,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDY1MDQ5","html_url":"https://github.com/RedHatInsights/aicoe-insights-clustering/pull/12","diff_url":"https://github.com/RedHatInsights/aicoe-insights-clustering/pull/12.diff","patch_url":"https://github.com/RedHatInsights/aicoe-insights-clustering/pull/12.patch","issue_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/issues/12","number":12,"state":"open","locked":false,"title":"[WIP] Integrate Clustering Code","user":{"login":"ch3njust1n","id":3211697,"node_id":"MDQ6VXNlcjMyMTE2OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3211697?v=4","gravatar_id":"","url":"https://api.github.com/users/ch3njust1n","html_url":"https://github.com/ch3njust1n","followers_url":"https://api.github.com/users/ch3njust1n/followers","following_url":"https://api.github.com/users/ch3njust1n/following{/other_user}","gists_url":"https://api.github.com/users/ch3njust1n/gists{/gist_id}","starred_url":"https://api.github.com/users/ch3njust1n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ch3njust1n/subscriptions","organizations_url":"https://api.github.com/users/ch3njust1n/orgs","repos_url":"https://api.github.com/users/ch3njust1n/repos","events_url":"https://api.github.com/users/ch3njust1n/events{/privacy}","received_events_url":"https://api.github.com/users/ch3njust1n/received_events","type":"User","site_admin":false},"body":"1. Added condition to check if MLFLOW_TRACKING_URI env variable is set. If True, run clustering.\r\n2. Created a new module called metric_tracking to host all the code\r\n3. Updated ceph and clustering code to use the local storage module","created_at":"2018-10-01T18:05:28Z","updated_at":"2018-10-01T20:17:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93ec7d58c40c0240690a8bd618217a30eac85f9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls/12/commits","review_comments_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls/12/comments","review_comment_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/issues/12/comments","statuses_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/statuses/2a67bf3f27fa16dd4e297d21c090de66ab2e3600","head":{"label":"ch3njust1n:dev","ref":"dev","sha":"2a67bf3f27fa16dd4e297d21c090de66ab2e3600","user":{"login":"ch3njust1n","id":3211697,"node_id":"MDQ6VXNlcjMyMTE2OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3211697?v=4","gravatar_id":"","url":"https://api.github.com/users/ch3njust1n","html_url":"https://github.com/ch3njust1n","followers_url":"https://api.github.com/users/ch3njust1n/followers","following_url":"https://api.github.com/users/ch3njust1n/following{/other_user}","gists_url":"https://api.github.com/users/ch3njust1n/gists{/gist_id}","starred_url":"https://api.github.com/users/ch3njust1n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ch3njust1n/subscriptions","organizations_url":"https://api.github.com/users/ch3njust1n/orgs","repos_url":"https://api.github.com/users/ch3njust1n/repos","events_url":"https://api.github.com/users/ch3njust1n/events{/privacy}","received_events_url":"https://api.github.com/users/ch3njust1n/received_events","type":"User","site_admin":false},"repo":{"id":150783580,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA3ODM1ODA=","name":"aicoe-insights-clustering","full_name":"ch3njust1n/aicoe-insights-clustering","private":false,"owner":{"login":"ch3njust1n","id":3211697,"node_id":"MDQ6VXNlcjMyMTE2OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3211697?v=4","gravatar_id":"","url":"https://api.github.com/users/ch3njust1n","html_url":"https://github.com/ch3njust1n","followers_url":"https://api.github.com/users/ch3njust1n/followers","following_url":"https://api.github.com/users/ch3njust1n/following{/other_user}","gists_url":"https://api.github.com/users/ch3njust1n/gists{/gist_id}","starred_url":"https://api.github.com/users/ch3njust1n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ch3njust1n/subscriptions","organizations_url":"https://api.github.com/users/ch3njust1n/orgs","repos_url":"https://api.github.com/users/ch3njust1n/repos","events_url":"https://api.github.com/users/ch3njust1n/events{/privacy}","received_events_url":"https://api.github.com/users/ch3njust1n/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ch3njust1n/aicoe-insights-clustering","description":"Clustering of systems","fork":true,"url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering","forks_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/forks","keys_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/teams","hooks_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/hooks","issue_events_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/issues/events{/number}","events_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/events","assignees_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/assignees{/user}","branches_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/branches{/branch}","tags_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/tags","blobs_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/git/refs{/sha}","trees_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/statuses/{sha}","languages_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/languages","stargazers_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/stargazers","contributors_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/contributors","subscribers_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/subscribers","subscription_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/subscription","commits_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/commits{/sha}","git_commits_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/git/commits{/sha}","comments_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/comments{/number}","issue_comment_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/issues/comments{/number}","contents_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/contents/{+path}","compare_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/merges","archive_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/downloads","issues_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/issues{/number}","pulls_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/pulls{/number}","milestones_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/milestones{/number}","notifications_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/labels{/name}","releases_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/releases{/id}","deployments_url":"https://api.github.com/repos/ch3njust1n/aicoe-insights-clustering/deployments","created_at":"2018-09-28T19:03:02Z","updated_at":"2018-09-28T19:12:49Z","pushed_at":"2018-10-01T18:01:31Z","git_url":"git://github.com/ch3njust1n/aicoe-insights-clustering.git","ssh_url":"git@github.com:ch3njust1n/aicoe-insights-clustering.git","clone_url":"https://github.com/ch3njust1n/aicoe-insights-clustering.git","svn_url":"https://github.com/ch3njust1n/aicoe-insights-clustering","homepage":null,"size":56,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RedHatInsights:master","ref":"master","sha":"8e280d6f824ab2a77661db26119f458e2c28a9c3","user":{"login":"RedHatInsights","id":24939818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTM5ODE4","avatar_url":"https://avatars2.githubusercontent.com/u/24939818?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatInsights","html_url":"https://github.com/RedHatInsights","followers_url":"https://api.github.com/users/RedHatInsights/followers","following_url":"https://api.github.com/users/RedHatInsights/following{/other_user}","gists_url":"https://api.github.com/users/RedHatInsights/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatInsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatInsights/subscriptions","organizations_url":"https://api.github.com/users/RedHatInsights/orgs","repos_url":"https://api.github.com/users/RedHatInsights/repos","events_url":"https://api.github.com/users/RedHatInsights/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatInsights/received_events","type":"Organization","site_admin":false},"repo":{"id":139453828,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0NTM4Mjg=","name":"aicoe-insights-clustering","full_name":"RedHatInsights/aicoe-insights-clustering","private":false,"owner":{"login":"RedHatInsights","id":24939818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTM5ODE4","avatar_url":"https://avatars2.githubusercontent.com/u/24939818?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatInsights","html_url":"https://github.com/RedHatInsights","followers_url":"https://api.github.com/users/RedHatInsights/followers","following_url":"https://api.github.com/users/RedHatInsights/following{/other_user}","gists_url":"https://api.github.com/users/RedHatInsights/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatInsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatInsights/subscriptions","organizations_url":"https://api.github.com/users/RedHatInsights/orgs","repos_url":"https://api.github.com/users/RedHatInsights/repos","events_url":"https://api.github.com/users/RedHatInsights/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatInsights/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RedHatInsights/aicoe-insights-clustering","description":"Clustering of systems","fork":false,"url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering","forks_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/forks","keys_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/teams","hooks_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/hooks","issue_events_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/issues/events{/number}","events_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/events","assignees_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/assignees{/user}","branches_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/branches{/branch}","tags_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/tags","blobs_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/languages","stargazers_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/stargazers","contributors_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/contributors","subscribers_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/subscribers","subscription_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/subscription","commits_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/contents/{+path}","compare_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/merges","archive_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/downloads","issues_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/issues{/number}","pulls_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/labels{/name}","releases_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/releases{/id}","deployments_url":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/deployments","created_at":"2018-07-02T14:22:28Z","updated_at":"2018-09-22T17:40:42Z","pushed_at":"2018-10-01T18:05:28Z","git_url":"git://github.com/RedHatInsights/aicoe-insights-clustering.git","ssh_url":"git@github.com:RedHatInsights/aicoe-insights-clustering.git","clone_url":"https://github.com/RedHatInsights/aicoe-insights-clustering.git","svn_url":"https://github.com/RedHatInsights/aicoe-insights-clustering","homepage":null,"size":48,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":8,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls/12"},"html":{"href":"https://github.com/RedHatInsights/aicoe-insights-clustering/pull/12"},"issue":{"href":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/issues/12"},"comments":{"href":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/RedHatInsights/aicoe-insights-clustering/statuses/2a67bf3f27fa16dd4e297d21c090de66ab2e3600"}},"author_association":"NONE"}}
{"actor":{"display_login":"durandom"}}