{"action":"created","issue":{"url":"https://api.github.com/repos/pattern-lab/patternlab-node/issues/897","repository_url":"https://api.github.com/repos/pattern-lab/patternlab-node","labels_url":"https://api.github.com/repos/pattern-lab/patternlab-node/issues/897/labels{/name}","comments_url":"https://api.github.com/repos/pattern-lab/patternlab-node/issues/897/comments","events_url":"https://api.github.com/repos/pattern-lab/patternlab-node/issues/897/events","html_url":"https://github.com/pattern-lab/patternlab-node/pull/897","id":341759750,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODIwMTUx","number":897,"title":"Twig PHP Engine in Pattern Lab node","user":{"login":"EvanLovely","id":569699,"node_id":"MDQ6VXNlcjU2OTY5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/569699?v=4","gravatar_id":"","url":"https://api.github.com/users/EvanLovely","html_url":"https://github.com/EvanLovely","followers_url":"https://api.github.com/users/EvanLovely/followers","following_url":"https://api.github.com/users/EvanLovely/following{/other_user}","gists_url":"https://api.github.com/users/EvanLovely/gists{/gist_id}","starred_url":"https://api.github.com/users/EvanLovely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvanLovely/subscriptions","organizations_url":"https://api.github.com/users/EvanLovely/orgs","repos_url":"https://api.github.com/users/EvanLovely/repos","events_url":"https://api.github.com/users/EvanLovely/events{/privacy}","received_events_url":"https://api.github.com/users/EvanLovely/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bmuenzenmeyer","id":298435,"node_id":"MDQ6VXNlcjI5ODQzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/298435?v=4","gravatar_id":"","url":"https://api.github.com/users/bmuenzenmeyer","html_url":"https://github.com/bmuenzenmeyer","followers_url":"https://api.github.com/users/bmuenzenmeyer/followers","following_url":"https://api.github.com/users/bmuenzenmeyer/following{/other_user}","gists_url":"https://api.github.com/users/bmuenzenmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/bmuenzenmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmuenzenmeyer/subscriptions","organizations_url":"https://api.github.com/users/bmuenzenmeyer/orgs","repos_url":"https://api.github.com/users/bmuenzenmeyer/repos","events_url":"https://api.github.com/users/bmuenzenmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/bmuenzenmeyer/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmuenzenmeyer","id":298435,"node_id":"MDQ6VXNlcjI5ODQzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/298435?v=4","gravatar_id":"","url":"https://api.github.com/users/bmuenzenmeyer","html_url":"https://github.com/bmuenzenmeyer","followers_url":"https://api.github.com/users/bmuenzenmeyer/followers","following_url":"https://api.github.com/users/bmuenzenmeyer/following{/other_user}","gists_url":"https://api.github.com/users/bmuenzenmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/bmuenzenmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmuenzenmeyer/subscriptions","organizations_url":"https://api.github.com/users/bmuenzenmeyer/orgs","repos_url":"https://api.github.com/users/bmuenzenmeyer/repos","events_url":"https://api.github.com/users/bmuenzenmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/bmuenzenmeyer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2018-07-17T04:15:46Z","updated_at":"2018-07-21T23:41:55Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pattern-lab/patternlab-node/pulls/897","html_url":"https://github.com/pattern-lab/patternlab-node/pull/897","diff_url":"https://github.com/pattern-lab/patternlab-node/pull/897.diff","patch_url":"https://github.com/pattern-lab/patternlab-node/pull/897.patch"},"body":"🎉 OK, here we go! This adds a Twig PHP Engine and implements it in the Twig Edition. This is really sweet because this will let us [Unify Pattern Lab Core](https://github.com/pattern-lab/the-spec/issues/37) by bringing the most essential part of the PHP Pattern Lab world in: a real Twig environment using the actual engine. \r\n\r\nI'll have to get into more later, but I've created [`@basalt/twig-renderer`](https://github.com/basaltinc/twig-renderer) which is a JS module that takes config and gives back a render JS function that when called spins up an internal PHP server that exposes an API endpoint that renders Twig templates. It's all async and it can render [1,000 simple Twig templates in about 5s](https://github.com/basaltinc/twig-renderer/tree/master/__tests__/volume) - and only spins up 1 PHP server for that @aleksip 😉  \r\n\r\nTake a peak @pattern-lab/devs and tell me what you think!\r\n\r\nTo test:\r\n\r\n```bash\r\nnpm install\r\nnpm run bootstrap\r\ncd packages/edition-twig\r\nnpm start\r\n```\r\n\r\nBugs to fix:\r\n\r\n- [ ] Header & foote `_meta` patterns not rendering on individual pattern page (but do on view all pages)"},"comment":{"url":"https://api.github.com/repos/pattern-lab/patternlab-node/issues/comments/406830292","html_url":"https://github.com/pattern-lab/patternlab-node/pull/897#issuecomment-406830292","issue_url":"https://api.github.com/repos/pattern-lab/patternlab-node/issues/897","id":406830292,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjgzMDI5Mg==","user":{"login":"EvanLovely","id":569699,"node_id":"MDQ6VXNlcjU2OTY5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/569699?v=4","gravatar_id":"","url":"https://api.github.com/users/EvanLovely","html_url":"https://github.com/EvanLovely","followers_url":"https://api.github.com/users/EvanLovely/followers","following_url":"https://api.github.com/users/EvanLovely/following{/other_user}","gists_url":"https://api.github.com/users/EvanLovely/gists{/gist_id}","starred_url":"https://api.github.com/users/EvanLovely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvanLovely/subscriptions","organizations_url":"https://api.github.com/users/EvanLovely/orgs","repos_url":"https://api.github.com/users/EvanLovely/repos","events_url":"https://api.github.com/users/EvanLovely/events{/privacy}","received_events_url":"https://api.github.com/users/EvanLovely/received_events","type":"User","site_admin":false},"created_at":"2018-07-21T23:41:55Z","updated_at":"2018-07-21T23:41:55Z","author_association":"MEMBER","body":"I’ve also had issues with Firefox and believe it to not be from this PR. Strangely enough, Inspeciting Element in it changes it from all white to rendering properly. \r\n\r\n@aleksip @sghoweri - I really appreciate you checking this and helping. Let’s make this happen!"}}
{"actor":{"display_login":"EvanLovely"}}