{"action":"created","issue":{"url":"https://api.github.com/repos/chartjs/Chart.js/issues/5629","repository_url":"https://api.github.com/repos/chartjs/Chart.js","labels_url":"https://api.github.com/repos/chartjs/Chart.js/issues/5629/labels{/name}","comments_url":"https://api.github.com/repos/chartjs/Chart.js/issues/5629/comments","events_url":"https://api.github.com/repos/chartjs/Chart.js/issues/5629/events","html_url":"https://github.com/chartjs/Chart.js/pull/5629","id":339592393,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMjA4NDc1","number":5629,"title":"Add \"point style\" image tests","user":{"login":"simonbrunel","id":3874900,"node_id":"MDQ6VXNlcjM4NzQ5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3874900?v=4","gravatar_id":"","url":"https://api.github.com/users/simonbrunel","html_url":"https://github.com/simonbrunel","followers_url":"https://api.github.com/users/simonbrunel/followers","following_url":"https://api.github.com/users/simonbrunel/following{/other_user}","gists_url":"https://api.github.com/users/simonbrunel/gists{/gist_id}","starred_url":"https://api.github.com/users/simonbrunel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonbrunel/subscriptions","organizations_url":"https://api.github.com/users/simonbrunel/orgs","repos_url":"https://api.github.com/users/simonbrunel/repos","events_url":"https://api.github.com/users/simonbrunel/events{/privacy}","received_events_url":"https://api.github.com/users/simonbrunel/received_events","type":"User","site_admin":false},"labels":[{"id":112537860,"node_id":"MDU6TGFiZWwxMTI1Mzc4NjA=","url":"https://api.github.com/repos/chartjs/Chart.js/labels/type:%20infrastructure","name":"type: infrastructure","color":"2B303B","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/chartjs/Chart.js/milestones/17","html_url":"https://github.com/chartjs/Chart.js/milestone/17","labels_url":"https://api.github.com/repos/chartjs/Chart.js/milestones/17/labels","id":3033022,"node_id":"MDk6TWlsZXN0b25lMzAzMzAyMg==","number":17,"title":"Version 2.8","description":"[Release Notes](/chartjs/Chart.js/releases/tag/v2.8.0)","creator":{"login":"simonbrunel","id":3874900,"node_id":"MDQ6VXNlcjM4NzQ5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3874900?v=4","gravatar_id":"","url":"https://api.github.com/users/simonbrunel","html_url":"https://github.com/simonbrunel","followers_url":"https://api.github.com/users/simonbrunel/followers","following_url":"https://api.github.com/users/simonbrunel/following{/other_user}","gists_url":"https://api.github.com/users/simonbrunel/gists{/gist_id}","starred_url":"https://api.github.com/users/simonbrunel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonbrunel/subscriptions","organizations_url":"https://api.github.com/users/simonbrunel/orgs","repos_url":"https://api.github.com/users/simonbrunel/repos","events_url":"https://api.github.com/users/simonbrunel/events{/privacy}","received_events_url":"https://api.github.com/users/simonbrunel/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":31,"state":"open","created_at":"2018-01-13T13:36:33Z","updated_at":"2018-07-09T20:18:31Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-07-09T20:18:31Z","updated_at":"2018-07-09T20:48:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/chartjs/Chart.js/pulls/5629","html_url":"https://github.com/chartjs/Chart.js/pull/5629","diff_url":"https://github.com/chartjs/Chart.js/pull/5629.diff","patch_url":"https://github.com/chartjs/Chart.js/pull/5629.patch"},"body":"We are receiving a few PRs related to the point style, so it could be better to replace the old style canvas \"mock\" context checks by image based unit tests which are easier to maintain and allow more flexibility in the drawing logic since we are not testing the context calls but the final painted result.\r\n\r\nRelated to #4811 #5180 #5623 \r\n"},"comment":{"url":"https://api.github.com/repos/chartjs/Chart.js/issues/comments/403615188","html_url":"https://github.com/chartjs/Chart.js/pull/5629#issuecomment-403615188","issue_url":"https://api.github.com/repos/chartjs/Chart.js/issues/5629","id":403615188,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzYxNTE4OA==","user":{"login":"simonbrunel","id":3874900,"node_id":"MDQ6VXNlcjM4NzQ5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3874900?v=4","gravatar_id":"","url":"https://api.github.com/users/simonbrunel","html_url":"https://github.com/simonbrunel","followers_url":"https://api.github.com/users/simonbrunel/followers","following_url":"https://api.github.com/users/simonbrunel/following{/other_user}","gists_url":"https://api.github.com/users/simonbrunel/gists{/gist_id}","starred_url":"https://api.github.com/users/simonbrunel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonbrunel/subscriptions","organizations_url":"https://api.github.com/users/simonbrunel/orgs","repos_url":"https://api.github.com/users/simonbrunel/repos","events_url":"https://api.github.com/users/simonbrunel/events{/privacy}","received_events_url":"https://api.github.com/users/simonbrunel/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T20:48:08Z","updated_at":"2018-07-09T20:48:08Z","author_association":"MEMBER","body":"Tests didn't run as smooth as I expected, I think the diff come from border aliasing. Anyone on Linux able to screenshot the image diff errors using `gulp unittest --watch`?\r\n\r\nI don't know if Travis allows to store artifact for each build."}}
{"actor":{"display_login":"simonbrunel"}}