{"action":"created","issue":{"url":"https://api.github.com/repos/tangrams/bubble-wrap/issues/274","repository_url":"https://api.github.com/repos/tangrams/bubble-wrap","labels_url":"https://api.github.com/repos/tangrams/bubble-wrap/issues/274/labels{/name}","comments_url":"https://api.github.com/repos/tangrams/bubble-wrap/issues/274/comments","events_url":"https://api.github.com/repos/tangrams/bubble-wrap/issues/274/events","html_url":"https://github.com/tangrams/bubble-wrap/pull/274","id":388936105,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDc2NzEy","number":274,"title":"Refactor shield functions:","user":{"login":"hjanetzek","id":1747,"node_id":"MDQ6VXNlcjE3NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1747?v=4","gravatar_id":"","url":"https://api.github.com/users/hjanetzek","html_url":"https://github.com/hjanetzek","followers_url":"https://api.github.com/users/hjanetzek/followers","following_url":"https://api.github.com/users/hjanetzek/following{/other_user}","gists_url":"https://api.github.com/users/hjanetzek/gists{/gist_id}","starred_url":"https://api.github.com/users/hjanetzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjanetzek/subscriptions","organizations_url":"https://api.github.com/users/hjanetzek/orgs","repos_url":"https://api.github.com/users/hjanetzek/repos","events_url":"https://api.github.com/users/hjanetzek/events{/privacy}","received_events_url":"https://api.github.com/users/hjanetzek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-08T16:25:30Z","updated_at":"2018-12-12T14:40:01Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/tangrams/bubble-wrap/pulls/274","html_url":"https://github.com/tangrams/bubble-wrap/pull/274","diff_url":"https://github.com/tangrams/bubble-wrap/pull/274.diff","patch_url":"https://github.com/tangrams/bubble-wrap/pull/274.patch"},"body":"Some optimization to reduce the work of js-functios: \r\n- Use text_source sequence for shield text instead of function.\r\n- To discard shields when text is too long return no sprite instead of using an additional js call to filter them\r\n- Don't allocate memory for building strings\r\n- Don't spend cpu cycles on building strings, hashing and storing them."},"comment":{"url":"https://api.github.com/repos/tangrams/bubble-wrap/issues/comments/446610362","html_url":"https://github.com/tangrams/bubble-wrap/pull/274#issuecomment-446610362","issue_url":"https://api.github.com/repos/tangrams/bubble-wrap/issues/274","id":446610362,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjYxMDM2Mg==","user":{"login":"hjanetzek","id":1747,"node_id":"MDQ6VXNlcjE3NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1747?v=4","gravatar_id":"","url":"https://api.github.com/users/hjanetzek","html_url":"https://github.com/hjanetzek","followers_url":"https://api.github.com/users/hjanetzek/followers","following_url":"https://api.github.com/users/hjanetzek/following{/other_user}","gists_url":"https://api.github.com/users/hjanetzek/gists{/gist_id}","starred_url":"https://api.github.com/users/hjanetzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjanetzek/subscriptions","organizations_url":"https://api.github.com/users/hjanetzek/orgs","repos_url":"https://api.github.com/users/hjanetzek/repos","events_url":"https://api.github.com/users/hjanetzek/events{/privacy}","received_events_url":"https://api.github.com/users/hjanetzek/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T14:40:01Z","updated_at":"2018-12-12T14:40:01Z","author_association":"MEMBER","body":"@bcamper What I meant was that Tangram can provide these helper functions for all implementations. Then we can recommend using `stringbuilder()` over `+` or `[].join(\"\")`"}}
{"actor":{"display_login":"hjanetzek"}}