{"action":"created","issue":{"url":"https://api.github.com/repos/google/ggrc-core/issues/8173","repository_url":"https://api.github.com/repos/google/ggrc-core","labels_url":"https://api.github.com/repos/google/ggrc-core/issues/8173/labels{/name}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/8173/comments","events_url":"https://api.github.com/repos/google/ggrc-core/issues/8173/events","html_url":"https://github.com/google/ggrc-core/pull/8173","id":343086255,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODMyNzI0","number":8173,"title":"GGRC-5347 Fix hash fragment for object versions","user":{"login":"zakhar98","id":25991270,"node_id":"MDQ6VXNlcjI1OTkxMjcw","avatar_url":"https://avatars3.githubusercontent.com/u/25991270?v=4","gravatar_id":"","url":"https://api.github.com/users/zakhar98","html_url":"https://github.com/zakhar98","followers_url":"https://api.github.com/users/zakhar98/followers","following_url":"https://api.github.com/users/zakhar98/following{/other_user}","gists_url":"https://api.github.com/users/zakhar98/gists{/gist_id}","starred_url":"https://api.github.com/users/zakhar98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zakhar98/subscriptions","organizations_url":"https://api.github.com/users/zakhar98/orgs","repos_url":"https://api.github.com/users/zakhar98/repos","events_url":"https://api.github.com/users/zakhar98/events{/privacy}","received_events_url":"https://api.github.com/users/zakhar98/received_events","type":"User","site_admin":false},"labels":[{"id":653911749,"node_id":"MDU6TGFiZWw2NTM5MTE3NDk=","url":"https://api.github.com/repos/google/ggrc-core/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":835304430,"node_id":"MDU6TGFiZWw4MzUzMDQ0MzA=","url":"https://api.github.com/repos/google/ggrc-core/labels/needs%20selenium%20fix","name":"needs selenium fix","color":"f75be2","default":false}],"state":"open","locked":false,"assignee":{"login":"YuriChupyrkin","id":4204416,"node_id":"MDQ6VXNlcjQyMDQ0MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/4204416?v=4","gravatar_id":"","url":"https://api.github.com/users/YuriChupyrkin","html_url":"https://github.com/YuriChupyrkin","followers_url":"https://api.github.com/users/YuriChupyrkin/followers","following_url":"https://api.github.com/users/YuriChupyrkin/following{/other_user}","gists_url":"https://api.github.com/users/YuriChupyrkin/gists{/gist_id}","starred_url":"https://api.github.com/users/YuriChupyrkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuriChupyrkin/subscriptions","organizations_url":"https://api.github.com/users/YuriChupyrkin/orgs","repos_url":"https://api.github.com/users/YuriChupyrkin/repos","events_url":"https://api.github.com/users/YuriChupyrkin/events{/privacy}","received_events_url":"https://api.github.com/users/YuriChupyrkin/received_events","type":"User","site_admin":false},"assignees":[{"login":"YuriChupyrkin","id":4204416,"node_id":"MDQ6VXNlcjQyMDQ0MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/4204416?v=4","gravatar_id":"","url":"https://api.github.com/users/YuriChupyrkin","html_url":"https://github.com/YuriChupyrkin","followers_url":"https://api.github.com/users/YuriChupyrkin/followers","following_url":"https://api.github.com/users/YuriChupyrkin/following{/other_user}","gists_url":"https://api.github.com/users/YuriChupyrkin/gists{/gist_id}","starred_url":"https://api.github.com/users/YuriChupyrkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuriChupyrkin/subscriptions","organizations_url":"https://api.github.com/users/YuriChupyrkin/orgs","repos_url":"https://api.github.com/users/YuriChupyrkin/repos","events_url":"https://api.github.com/users/YuriChupyrkin/events{/privacy}","received_events_url":"https://api.github.com/users/YuriChupyrkin/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/101","html_url":"https://github.com/google/ggrc-core/milestone/101","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/101/labels","id":3505863,"node_id":"MDk6TWlsZXN0b25lMzUwNTg2Mw==","number":101,"title":"1.17.0-Strawberry","description":"","creator":{"login":"IlyaTsupryk","id":9151434,"node_id":"MDQ6VXNlcjkxNTE0MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9151434?v=4","gravatar_id":"","url":"https://api.github.com/users/IlyaTsupryk","html_url":"https://github.com/IlyaTsupryk","followers_url":"https://api.github.com/users/IlyaTsupryk/followers","following_url":"https://api.github.com/users/IlyaTsupryk/following{/other_user}","gists_url":"https://api.github.com/users/IlyaTsupryk/gists{/gist_id}","starred_url":"https://api.github.com/users/IlyaTsupryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlyaTsupryk/subscriptions","organizations_url":"https://api.github.com/users/IlyaTsupryk/orgs","repos_url":"https://api.github.com/users/IlyaTsupryk/repos","events_url":"https://api.github.com/users/IlyaTsupryk/events{/privacy}","received_events_url":"https://api.github.com/users/IlyaTsupryk/received_events","type":"User","site_admin":false},"open_issues":46,"closed_issues":18,"state":"open","created_at":"2018-07-18T13:52:43Z","updated_at":"2018-07-25T08:33:14Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-07-20T12:18:26Z","updated_at":"2018-07-25T09:40:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/8173","html_url":"https://github.com/google/ggrc-core/pull/8173","diff_url":"https://github.com/google/ggrc-core/pull/8173.diff","patch_url":"https://github.com/google/ggrc-core/pull/8173.patch"},"body":"<!-- If your PR depends on other tickets or PRs, you can list them here\r\n# Dependencies\r\n\r\nThis PR is `on hold` until the dependencies are merged:\r\n\r\n- [ ] GGRC-1234\r\n- [ ] #1234\r\n-->\r\n\r\n# Issue description\r\n\r\nIncorrect hash fragment for object versions.\r\n\r\n# Steps to test the changes\r\n\r\n1. Open Issue with mapped control snapshot.\r\n2. Open 'Controls Versions' tab.\r\n3. Look at the hash fragment in the browser address bar.\r\n\r\nActual state: issues/610#!Control_versions\r\nExpected state: issues/610#!control_version\r\n\r\n# Solution description\r\n\r\nApply lower case and change versions to version.\r\n\r\n# Sanity checklist\r\n\r\n- [x] I have clicked through the app to make sure my changes work and not break the app.\r\n- [x] I have applied the correct milestone and labels.\r\n- [x] My changes fix the issue described in the description (and do nothing else). 🤞\r\n- [ ] My changes are covered by tests.\r\n- [x] My changes follow our [performance guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/performance.rst).\r\n- [x] My changes follow our [js](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/javascript.rst) and/or [python](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/python.rst) guidelines.\r\n- [x] My commits follow our [commit guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/how_to_write_a_commit_message.rst).\r\n\r\n<!-- If your PR includes a migration include the additional checklist items\r\n# Migration checklist\r\n- [ ] Migration passes all checks from our [PR review guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/reviewing_pull_requests.rst#reviewing-a-pr-containing-database-migration-scripts)\r\n-->\r\n\r\n# PR Review checklist\r\n\r\n- [ ] The changes fix the issue and don't cause any apparent regressions.\r\n- [ ] Labels and milestone are correctly set.\r\n- [ ] The solution description matches the changes in the code.\r\n- [ ] There is no apparent way to improve the performance & design of the new code.\r\n- [ ] The pull request is opened against the correct base branch.\r\n- [ ] Upon merging, the Jira ticket's fixversion is correctly set and the ticket is moved to \"QA - In Progress\".\r\n\r\n<!-- If your code is not finished yet can include a TODO check list\r\n# TODO\r\n\r\n- [ ] First item on the TODO\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/google/ggrc-core/issues/comments/407696585","html_url":"https://github.com/google/ggrc-core/pull/8173#issuecomment-407696585","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/8173","id":407696585,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzY5NjU4NQ==","user":{"login":"googlebot","id":5384588,"node_id":"MDQ6VXNlcjUzODQ1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5384588?v=4","gravatar_id":"","url":"https://api.github.com/users/googlebot","html_url":"https://github.com/googlebot","followers_url":"https://api.github.com/users/googlebot/followers","following_url":"https://api.github.com/users/googlebot/following{/other_user}","gists_url":"https://api.github.com/users/googlebot/gists{/gist_id}","starred_url":"https://api.github.com/users/googlebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlebot/subscriptions","organizations_url":"https://api.github.com/users/googlebot/orgs","repos_url":"https://api.github.com/users/googlebot/repos","events_url":"https://api.github.com/users/googlebot/events{/privacy}","received_events_url":"https://api.github.com/users/googlebot/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T09:40:29Z","updated_at":"2018-07-25T09:40:29Z","author_association":"NONE","body":"So there's good news and bad news.\n\n:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so.  Everything is all good there.\n\n:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter.  We need to confirm that all authors are ok with their commits being contributed to this project.  Please have them confirm that here in the pull request.\n\n*Note to project maintainer: This is a terminal state, meaning the `cla/google` commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.*\n\n<!-- need_author_consent -->"}}
{"actor":{"display_login":"googlebot"}}