{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/comments/231242486","pull_request_review_id":172170453,"id":231242486,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTI0MjQ4Ng==","diff_hunk":"@@ -1394,9 +1394,47 @@ def __init__(self, *args, **kwargs):\n \n \n class IntegerProperty(Property):\n+    \"\"\"A property that contains values of type integer.\"\"\"","path":"ndb/src/google/cloud/ndb/model.py","position":4,"original_position":4,"commit_id":"16133052d993e42f0ef4291eb56e8eec61343a34","original_commit_id":"ebb649a6aa336818a219561c662fdce75611cf27","user":{"login":"chrisrossi","id":148267,"node_id":"MDQ6VXNlcjE0ODI2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/148267?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisrossi","html_url":"https://github.com/chrisrossi","followers_url":"https://api.github.com/users/chrisrossi/followers","following_url":"https://api.github.com/users/chrisrossi/following{/other_user}","gists_url":"https://api.github.com/users/chrisrossi/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisrossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisrossi/subscriptions","organizations_url":"https://api.github.com/users/chrisrossi/orgs","repos_url":"https://api.github.com/users/chrisrossi/repos","events_url":"https://api.github.com/users/chrisrossi/events{/privacy}","received_events_url":"https://api.github.com/users/chrisrossi/received_events","type":"User","site_admin":false},"body":"Good point. I guess if we want to be thorough, we should continue to document `_validate`.","created_at":"2018-11-06T18:39:30Z","updated_at":"2018-11-06T18:39:30Z","html_url":"https://github.com/googleapis/google-cloud-python/pull/6395#discussion_r231242486","pull_request_url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/6395","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/comments/231242486"},"html":{"href":"https://github.com/googleapis/google-cloud-python/pull/6395#discussion_r231242486"},"pull_request":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/6395"}},"in_reply_to_id":230918734},"pull_request":{"url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/6395","id":228496594,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NDk2NTk0","html_url":"https://github.com/googleapis/google-cloud-python/pull/6395","diff_url":"https://github.com/googleapis/google-cloud-python/pull/6395.diff","patch_url":"https://github.com/googleapis/google-cloud-python/pull/6395.patch","issue_url":"https://api.github.com/repos/googleapis/google-cloud-python/issues/6395","number":6395,"state":"open","locked":false,"title":"Implementing `IntegerProperty` in `ndb`.","user":{"login":"dhermes","id":520669,"node_id":"MDQ6VXNlcjUyMDY2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/520669?v=4","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"body":"The `_db_set_value()` and `_db_get_value()` methods are just helpers for `Property._serialize()` and `Property._deserialize()`. As in #6389, I'm fairly certain that this won't be needed so for now I'm not implementing. (The previous implementation relies on the old protobuf definition, which is \"stuck\" inside Google App Engine standard.)","created_at":"2018-11-05T21:25:48Z","updated_at":"2018-11-06T18:39:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c64965e556473835856f06021095c8c77fb95b6b","assignee":{"login":"chrisrossi","id":148267,"node_id":"MDQ6VXNlcjE0ODI2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/148267?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisrossi","html_url":"https://github.com/chrisrossi","followers_url":"https://api.github.com/users/chrisrossi/followers","following_url":"https://api.github.com/users/chrisrossi/following{/other_user}","gists_url":"https://api.github.com/users/chrisrossi/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisrossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisrossi/subscriptions","organizations_url":"https://api.github.com/users/chrisrossi/orgs","repos_url":"https://api.github.com/users/chrisrossi/repos","events_url":"https://api.github.com/users/chrisrossi/events{/privacy}","received_events_url":"https://api.github.com/users/chrisrossi/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrisrossi","id":148267,"node_id":"MDQ6VXNlcjE0ODI2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/148267?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisrossi","html_url":"https://github.com/chrisrossi","followers_url":"https://api.github.com/users/chrisrossi/followers","following_url":"https://api.github.com/users/chrisrossi/following{/other_user}","gists_url":"https://api.github.com/users/chrisrossi/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisrossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisrossi/subscriptions","organizations_url":"https://api.github.com/users/chrisrossi/orgs","repos_url":"https://api.github.com/users/chrisrossi/repos","events_url":"https://api.github.com/users/chrisrossi/events{/privacy}","received_events_url":"https://api.github.com/users/chrisrossi/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"chrisrossi","id":148267,"node_id":"MDQ6VXNlcjE0ODI2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/148267?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisrossi","html_url":"https://github.com/chrisrossi","followers_url":"https://api.github.com/users/chrisrossi/followers","following_url":"https://api.github.com/users/chrisrossi/following{/other_user}","gists_url":"https://api.github.com/users/chrisrossi/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisrossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisrossi/subscriptions","organizations_url":"https://api.github.com/users/chrisrossi/orgs","repos_url":"https://api.github.com/users/chrisrossi/repos","events_url":"https://api.github.com/users/chrisrossi/events{/privacy}","received_events_url":"https://api.github.com/users/chrisrossi/received_events","type":"User","site_admin":false},{"login":"crwilcox","id":638797,"node_id":"MDQ6VXNlcjYzODc5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/638797?v=4","gravatar_id":"","url":"https://api.github.com/users/crwilcox","html_url":"https://github.com/crwilcox","followers_url":"https://api.github.com/users/crwilcox/followers","following_url":"https://api.github.com/users/crwilcox/following{/other_user}","gists_url":"https://api.github.com/users/crwilcox/gists{/gist_id}","starred_url":"https://api.github.com/users/crwilcox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crwilcox/subscriptions","organizations_url":"https://api.github.com/users/crwilcox/orgs","repos_url":"https://api.github.com/users/crwilcox/repos","events_url":"https://api.github.com/users/crwilcox/events{/privacy}","received_events_url":"https://api.github.com/users/crwilcox/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1094971474,"node_id":"MDU6TGFiZWwxMDk0OTcxNDc0","url":"https://api.github.com/repos/googleapis/google-cloud-python/labels/api:%20ndb","name":"api: ndb","color":"f8f8f8","default":false},{"id":131682747,"node_id":"MDU6TGFiZWwxMzE2ODI3NDc=","url":"https://api.github.com/repos/googleapis/google-cloud-python/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/6395/commits","review_comments_url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/6395/comments","review_comment_url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/google-cloud-python/issues/6395/comments","statuses_url":"https://api.github.com/repos/googleapis/google-cloud-python/statuses/16133052d993e42f0ef4291eb56e8eec61343a34","head":{"label":"dhermes:ndb-add-IntegerProperty","ref":"ndb-add-IntegerProperty","sha":"16133052d993e42f0ef4291eb56e8eec61343a34","user":{"login":"dhermes","id":520669,"node_id":"MDQ6VXNlcjUyMDY2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/520669?v=4","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"repo":{"id":23001795,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAwMTc5NQ==","name":"google-cloud-python","full_name":"dhermes/google-cloud-python","private":false,"owner":{"login":"dhermes","id":520669,"node_id":"MDQ6VXNlcjUyMDY2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/520669?v=4","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dhermes/google-cloud-python","description":"Google Cloud Python Client Library","fork":true,"url":"https://api.github.com/repos/dhermes/google-cloud-python","forks_url":"https://api.github.com/repos/dhermes/google-cloud-python/forks","keys_url":"https://api.github.com/repos/dhermes/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhermes/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhermes/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/dhermes/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/dhermes/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/dhermes/google-cloud-python/events","assignees_url":"https://api.github.com/repos/dhermes/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/dhermes/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/dhermes/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhermes/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dhermes/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/dhermes/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/dhermes/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/dhermes/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/dhermes/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/dhermes/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhermes/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhermes/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhermes/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/dhermes/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhermes/google-cloud-python/merges","archive_url":"https://api.github.com/repos/dhermes/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhermes/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/dhermes/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/dhermes/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dhermes/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dhermes/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhermes/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/dhermes/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/dhermes/google-cloud-python/deployments","created_at":"2014-08-15T20:18:30Z","updated_at":"2018-11-06T16:38:16Z","pushed_at":"2018-11-06T17:55:07Z","git_url":"git://github.com/dhermes/google-cloud-python.git","ssh_url":"git@github.com:dhermes/google-cloud-python.git","clone_url":"https://github.com/dhermes/google-cloud-python.git","svn_url":"https://github.com/dhermes/google-cloud-python","homepage":"http://googlecloudplatform.github.io/gcloud-python/","size":31931,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"53968080a6d0ba55a35bfa9f5efe1c7a15e633f3","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"node_id":"MDEwOlJlcG9zaXRvcnkxNjMxNjQ1MQ==","name":"google-cloud-python","full_name":"googleapis/google-cloud-python","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/google-cloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/googleapis/google-cloud-python","forks_url":"https://api.github.com/repos/googleapis/google-cloud-python/forks","keys_url":"https://api.github.com/repos/googleapis/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/googleapis/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/googleapis/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/google-cloud-python/events","assignees_url":"https://api.github.com/repos/googleapis/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/googleapis/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/googleapis/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/googleapis/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/googleapis/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/googleapis/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/googleapis/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/google-cloud-python/merges","archive_url":"https://api.github.com/repos/googleapis/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/googleapis/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/google-cloud-python/deployments","created_at":"2014-01-28T15:51:47Z","updated_at":"2018-11-06T17:55:12Z","pushed_at":"2018-11-06T17:59:05Z","git_url":"git://github.com/googleapis/google-cloud-python.git","ssh_url":"git@github.com:googleapis/google-cloud-python.git","clone_url":"https://github.com/googleapis/google-cloud-python.git","svn_url":"https://github.com/googleapis/google-cloud-python","homepage":"https://googlecloudplatform.github.io/google-cloud-python/","size":476251,"stargazers_count":1868,"watchers_count":1868,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":805,"mirror_url":null,"archived":false,"open_issues_count":151,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":805,"open_issues":151,"watchers":1868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/6395"},"html":{"href":"https://github.com/googleapis/google-cloud-python/pull/6395"},"issue":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/issues/6395"},"comments":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/issues/6395/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/6395/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/pulls/6395/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/google-cloud-python/statuses/16133052d993e42f0ef4291eb56e8eec61343a34"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chrisrossi"}}