{"action":"closed","number":1607,"pull_request":{"url":"https://api.github.com/repos/jwilm/alacritty/pulls/1607","id":219134014,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTM0MDE0","html_url":"https://github.com/jwilm/alacritty/pull/1607","diff_url":"https://github.com/jwilm/alacritty/pull/1607.diff","patch_url":"https://github.com/jwilm/alacritty/pull/1607.patch","issue_url":"https://api.github.com/repos/jwilm/alacritty/issues/1607","number":1607,"state":"closed","locked":false,"title":"Store grid cells in renderer and drop terminal lock before rendering","user":{"login":"trimental","id":40879396,"node_id":"MDQ6VXNlcjQwODc5Mzk2","avatar_url":"https://avatars0.githubusercontent.com/u/40879396?v=4","gravatar_id":"","url":"https://api.github.com/users/trimental","html_url":"https://github.com/trimental","followers_url":"https://api.github.com/users/trimental/followers","following_url":"https://api.github.com/users/trimental/following{/other_user}","gists_url":"https://api.github.com/users/trimental/gists{/gist_id}","starred_url":"https://api.github.com/users/trimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trimental/subscriptions","organizations_url":"https://api.github.com/users/trimental/orgs","repos_url":"https://api.github.com/users/trimental/repos","events_url":"https://api.github.com/users/trimental/events{/privacy}","received_events_url":"https://api.github.com/users/trimental/received_events","type":"User","site_admin":false},"body":"This PR stores grid cells in the renderer when `fn draw()` is called and then releases the terminal lock so that rendering can be done without the terminal locked.\r\n\r\nThis also creates a new function `fn render_grid()` which is almost the exact same as `fn render_cells()` but uses the reference to the grid passed by the renderer to the render api, I think this might be the only way to do it without copying the entire grid to turn it into an iterator.\r\n\r\n`RenderableCell` derives debug so it can be stored in the renderer\r\n\r\nThese changes give me about a 400ms speedup when rendering a 500mb alt-screen-random-write file with cat.\r\n\r\nFixes https://github.com/jwilm/alacritty/issues/1535\r\nHopefully fixes https://github.com/jwilm/alacritty/issues/1529 (can't test on macos)","created_at":"2018-09-29T08:15:16Z","updated_at":"2018-09-30T21:54:09Z","closed_at":"2018-09-30T21:54:09Z","merged_at":"2018-09-30T21:54:09Z","merge_commit_sha":"b22999f1e7b39c1341caf797a98facb9010f89cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jwilm/alacritty/pulls/1607/commits","review_comments_url":"https://api.github.com/repos/jwilm/alacritty/pulls/1607/comments","review_comment_url":"https://api.github.com/repos/jwilm/alacritty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jwilm/alacritty/issues/1607/comments","statuses_url":"https://api.github.com/repos/jwilm/alacritty/statuses/0ad862d3b33e2c47a59476eb920f5b721d5d81ee","head":{"label":"trimental:store-grid-cells","ref":"store-grid-cells","sha":"0ad862d3b33e2c47a59476eb920f5b721d5d81ee","user":{"login":"trimental","id":40879396,"node_id":"MDQ6VXNlcjQwODc5Mzk2","avatar_url":"https://avatars0.githubusercontent.com/u/40879396?v=4","gravatar_id":"","url":"https://api.github.com/users/trimental","html_url":"https://github.com/trimental","followers_url":"https://api.github.com/users/trimental/followers","following_url":"https://api.github.com/users/trimental/following{/other_user}","gists_url":"https://api.github.com/users/trimental/gists{/gist_id}","starred_url":"https://api.github.com/users/trimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trimental/subscriptions","organizations_url":"https://api.github.com/users/trimental/orgs","repos_url":"https://api.github.com/users/trimental/repos","events_url":"https://api.github.com/users/trimental/events{/privacy}","received_events_url":"https://api.github.com/users/trimental/received_events","type":"User","site_admin":false},"repo":{"id":139983431,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5ODM0MzE=","name":"alacritty","full_name":"trimental/alacritty","private":false,"owner":{"login":"trimental","id":40879396,"node_id":"MDQ6VXNlcjQwODc5Mzk2","avatar_url":"https://avatars0.githubusercontent.com/u/40879396?v=4","gravatar_id":"","url":"https://api.github.com/users/trimental","html_url":"https://github.com/trimental","followers_url":"https://api.github.com/users/trimental/followers","following_url":"https://api.github.com/users/trimental/following{/other_user}","gists_url":"https://api.github.com/users/trimental/gists{/gist_id}","starred_url":"https://api.github.com/users/trimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trimental/subscriptions","organizations_url":"https://api.github.com/users/trimental/orgs","repos_url":"https://api.github.com/users/trimental/repos","events_url":"https://api.github.com/users/trimental/events{/privacy}","received_events_url":"https://api.github.com/users/trimental/received_events","type":"User","site_admin":false},"html_url":"https://github.com/trimental/alacritty","description":"A cross-platform, GPU-accelerated terminal emulator","fork":true,"url":"https://api.github.com/repos/trimental/alacritty","forks_url":"https://api.github.com/repos/trimental/alacritty/forks","keys_url":"https://api.github.com/repos/trimental/alacritty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trimental/alacritty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trimental/alacritty/teams","hooks_url":"https://api.github.com/repos/trimental/alacritty/hooks","issue_events_url":"https://api.github.com/repos/trimental/alacritty/issues/events{/number}","events_url":"https://api.github.com/repos/trimental/alacritty/events","assignees_url":"https://api.github.com/repos/trimental/alacritty/assignees{/user}","branches_url":"https://api.github.com/repos/trimental/alacritty/branches{/branch}","tags_url":"https://api.github.com/repos/trimental/alacritty/tags","blobs_url":"https://api.github.com/repos/trimental/alacritty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trimental/alacritty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trimental/alacritty/git/refs{/sha}","trees_url":"https://api.github.com/repos/trimental/alacritty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trimental/alacritty/statuses/{sha}","languages_url":"https://api.github.com/repos/trimental/alacritty/languages","stargazers_url":"https://api.github.com/repos/trimental/alacritty/stargazers","contributors_url":"https://api.github.com/repos/trimental/alacritty/contributors","subscribers_url":"https://api.github.com/repos/trimental/alacritty/subscribers","subscription_url":"https://api.github.com/repos/trimental/alacritty/subscription","commits_url":"https://api.github.com/repos/trimental/alacritty/commits{/sha}","git_commits_url":"https://api.github.com/repos/trimental/alacritty/git/commits{/sha}","comments_url":"https://api.github.com/repos/trimental/alacritty/comments{/number}","issue_comment_url":"https://api.github.com/repos/trimental/alacritty/issues/comments{/number}","contents_url":"https://api.github.com/repos/trimental/alacritty/contents/{+path}","compare_url":"https://api.github.com/repos/trimental/alacritty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trimental/alacritty/merges","archive_url":"https://api.github.com/repos/trimental/alacritty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trimental/alacritty/downloads","issues_url":"https://api.github.com/repos/trimental/alacritty/issues{/number}","pulls_url":"https://api.github.com/repos/trimental/alacritty/pulls{/number}","milestones_url":"https://api.github.com/repos/trimental/alacritty/milestones{/number}","notifications_url":"https://api.github.com/repos/trimental/alacritty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trimental/alacritty/labels{/name}","releases_url":"https://api.github.com/repos/trimental/alacritty/releases{/id}","deployments_url":"https://api.github.com/repos/trimental/alacritty/deployments","created_at":"2018-07-06T12:41:12Z","updated_at":"2018-09-20T20:56:31Z","pushed_at":"2018-09-29T14:32:07Z","git_url":"git://github.com/trimental/alacritty.git","ssh_url":"git@github.com:trimental/alacritty.git","clone_url":"https://github.com/trimental/alacritty.git","svn_url":"https://github.com/trimental/alacritty","homepage":"","size":3723,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jwilm:master","ref":"master","sha":"1887722ef5b6ac1c1f0e4e4f62cbb02b609c1d4b","user":{"login":"jwilm","id":4285147,"node_id":"MDQ6VXNlcjQyODUxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/4285147?v=4","gravatar_id":"","url":"https://api.github.com/users/jwilm","html_url":"https://github.com/jwilm","followers_url":"https://api.github.com/users/jwilm/followers","following_url":"https://api.github.com/users/jwilm/following{/other_user}","gists_url":"https://api.github.com/users/jwilm/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilm/subscriptions","organizations_url":"https://api.github.com/users/jwilm/orgs","repos_url":"https://api.github.com/users/jwilm/repos","events_url":"https://api.github.com/users/jwilm/events{/privacy}","received_events_url":"https://api.github.com/users/jwilm/received_events","type":"User","site_admin":false},"repo":{"id":51980455,"node_id":"MDEwOlJlcG9zaXRvcnk1MTk4MDQ1NQ==","name":"alacritty","full_name":"jwilm/alacritty","private":false,"owner":{"login":"jwilm","id":4285147,"node_id":"MDQ6VXNlcjQyODUxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/4285147?v=4","gravatar_id":"","url":"https://api.github.com/users/jwilm","html_url":"https://github.com/jwilm","followers_url":"https://api.github.com/users/jwilm/followers","following_url":"https://api.github.com/users/jwilm/following{/other_user}","gists_url":"https://api.github.com/users/jwilm/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilm/subscriptions","organizations_url":"https://api.github.com/users/jwilm/orgs","repos_url":"https://api.github.com/users/jwilm/repos","events_url":"https://api.github.com/users/jwilm/events{/privacy}","received_events_url":"https://api.github.com/users/jwilm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jwilm/alacritty","description":"A cross-platform, GPU-accelerated terminal emulator","fork":false,"url":"https://api.github.com/repos/jwilm/alacritty","forks_url":"https://api.github.com/repos/jwilm/alacritty/forks","keys_url":"https://api.github.com/repos/jwilm/alacritty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwilm/alacritty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwilm/alacritty/teams","hooks_url":"https://api.github.com/repos/jwilm/alacritty/hooks","issue_events_url":"https://api.github.com/repos/jwilm/alacritty/issues/events{/number}","events_url":"https://api.github.com/repos/jwilm/alacritty/events","assignees_url":"https://api.github.com/repos/jwilm/alacritty/assignees{/user}","branches_url":"https://api.github.com/repos/jwilm/alacritty/branches{/branch}","tags_url":"https://api.github.com/repos/jwilm/alacritty/tags","blobs_url":"https://api.github.com/repos/jwilm/alacritty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwilm/alacritty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwilm/alacritty/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwilm/alacritty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwilm/alacritty/statuses/{sha}","languages_url":"https://api.github.com/repos/jwilm/alacritty/languages","stargazers_url":"https://api.github.com/repos/jwilm/alacritty/stargazers","contributors_url":"https://api.github.com/repos/jwilm/alacritty/contributors","subscribers_url":"https://api.github.com/repos/jwilm/alacritty/subscribers","subscription_url":"https://api.github.com/repos/jwilm/alacritty/subscription","commits_url":"https://api.github.com/repos/jwilm/alacritty/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwilm/alacritty/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwilm/alacritty/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwilm/alacritty/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwilm/alacritty/contents/{+path}","compare_url":"https://api.github.com/repos/jwilm/alacritty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwilm/alacritty/merges","archive_url":"https://api.github.com/repos/jwilm/alacritty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwilm/alacritty/downloads","issues_url":"https://api.github.com/repos/jwilm/alacritty/issues{/number}","pulls_url":"https://api.github.com/repos/jwilm/alacritty/pulls{/number}","milestones_url":"https://api.github.com/repos/jwilm/alacritty/milestones{/number}","notifications_url":"https://api.github.com/repos/jwilm/alacritty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwilm/alacritty/labels{/name}","releases_url":"https://api.github.com/repos/jwilm/alacritty/releases{/id}","deployments_url":"https://api.github.com/repos/jwilm/alacritty/deployments","created_at":"2016-02-18T05:02:30Z","updated_at":"2018-09-30T21:00:51Z","pushed_at":"2018-09-30T21:54:09Z","git_url":"git://github.com/jwilm/alacritty.git","ssh_url":"git@github.com:jwilm/alacritty.git","clone_url":"https://github.com/jwilm/alacritty.git","svn_url":"https://github.com/jwilm/alacritty","homepage":"","size":3807,"stargazers_count":12373,"watchers_count":12373,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":518,"mirror_url":null,"archived":false,"open_issues_count":338,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":518,"open_issues":338,"watchers":12373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jwilm/alacritty/pulls/1607"},"html":{"href":"https://github.com/jwilm/alacritty/pull/1607"},"issue":{"href":"https://api.github.com/repos/jwilm/alacritty/issues/1607"},"comments":{"href":"https://api.github.com/repos/jwilm/alacritty/issues/1607/comments"},"review_comments":{"href":"https://api.github.com/repos/jwilm/alacritty/pulls/1607/comments"},"review_comment":{"href":"https://api.github.com/repos/jwilm/alacritty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jwilm/alacritty/pulls/1607/commits"},"statuses":{"href":"https://api.github.com/repos/jwilm/alacritty/statuses/0ad862d3b33e2c47a59476eb920f5b721d5d81ee"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"chrisduerr","id":8886672,"node_id":"MDQ6VXNlcjg4ODY2NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/8886672?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisduerr","html_url":"https://github.com/chrisduerr","followers_url":"https://api.github.com/users/chrisduerr/followers","following_url":"https://api.github.com/users/chrisduerr/following{/other_user}","gists_url":"https://api.github.com/users/chrisduerr/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisduerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisduerr/subscriptions","organizations_url":"https://api.github.com/users/chrisduerr/orgs","repos_url":"https://api.github.com/users/chrisduerr/repos","events_url":"https://api.github.com/users/chrisduerr/events{/privacy}","received_events_url":"https://api.github.com/users/chrisduerr/received_events","type":"User","site_admin":false},"comments":4,"review_comments":2,"maintainer_can_modify":false,"commits":5,"additions":32,"deletions":37,"changed_files":4}}
{"actor":{"display_login":"chrisduerr"}}