{"action":"created","comment":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/241115985","pull_request_review_id":184307369,"id":241115985,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTExNTk4NQ==","diff_hunk":"@@ -52,10 +52,12 @@ updateobjs:\n \n .PHONY: cleanlibs\n cleanlibs: updateobjs\n-\trm -f $(OBJS)\n+\trm -f $(OBJS) $(LIBS)\n \n clean: cleanlibs\n \n+all: cleanlibs","path":"targets/nuttx-stm32f4/Makefile","position":9,"original_position":9,"commit_id":"2fa6a66fd53246964aa38ad3daa0272e4d311aa5","original_commit_id":"2fa6a66fd53246964aa38ad3daa0272e4d311aa5","user":{"login":"akosthekiss","id":9976482,"node_id":"MDQ6VXNlcjk5NzY0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/9976482?v=4","gravatar_id":"","url":"https://api.github.com/users/akosthekiss","html_url":"https://github.com/akosthekiss","followers_url":"https://api.github.com/users/akosthekiss/followers","following_url":"https://api.github.com/users/akosthekiss/following{/other_user}","gists_url":"https://api.github.com/users/akosthekiss/gists{/gist_id}","starred_url":"https://api.github.com/users/akosthekiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akosthekiss/subscriptions","organizations_url":"https://api.github.com/users/akosthekiss/orgs","repos_url":"https://api.github.com/users/akosthekiss/repos","events_url":"https://api.github.com/users/akosthekiss/events{/privacy}","received_events_url":"https://api.github.com/users/akosthekiss/received_events","type":"User","site_admin":false},"body":"Some random thoughts:\r\n- Having libjerry-port-default.a and libjerry-port-default-minimal.a in LIBS is strange and suspicious.\r\n- Extracting the objects from the libs is also somewhat strange. The build system is already working with libs. So why extract them when they will be re-packaged right after that?\r\n- If untracked files are the problem, then .gitignore should be updated, not the build system.\r\n\r\nSo, I still think that this PR shouldn't mix `all` and `clean` targets. But it should update `clean` if it does not clean up things properly. And it may add items to top level gitignore (or add a subdir level gitifgnore) if there are build artefacts that should be hidden from git status.","created_at":"2018-12-12T17:42:12Z","updated_at":"2018-12-12T17:42:13Z","html_url":"https://github.com/jerryscript-project/jerryscript/pull/2635#discussion_r241115985","pull_request_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2635","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/241115985"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/2635#discussion_r241115985"},"pull_request":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2635"}},"in_reply_to_id":240693417},"pull_request":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2635","id":237599654,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NTk5NjU0","html_url":"https://github.com/jerryscript-project/jerryscript/pull/2635","diff_url":"https://github.com/jerryscript-project/jerryscript/pull/2635.diff","patch_url":"https://github.com/jerryscript-project/jerryscript/pull/2635.patch","issue_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2635","number":2635,"state":"open","locked":false,"title":"Clean all copied files from the nuttx directory after building","user":{"login":"pmarkee","id":33598886,"node_id":"MDQ6VXNlcjMzNTk4ODg2","avatar_url":"https://avatars1.githubusercontent.com/u/33598886?v=4","gravatar_id":"","url":"https://api.github.com/users/pmarkee","html_url":"https://github.com/pmarkee","followers_url":"https://api.github.com/users/pmarkee/followers","following_url":"https://api.github.com/users/pmarkee/following{/other_user}","gists_url":"https://api.github.com/users/pmarkee/gists{/gist_id}","starred_url":"https://api.github.com/users/pmarkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmarkee/subscriptions","organizations_url":"https://api.github.com/users/pmarkee/orgs","repos_url":"https://api.github.com/users/pmarkee/repos","events_url":"https://api.github.com/users/pmarkee/events{/privacy}","received_events_url":"https://api.github.com/users/pmarkee/received_events","type":"User","site_admin":false},"body":"JerryScript-DCO-1.0-Signed-off-by: marpeter@inf.u-szeged.hu","created_at":"2018-12-11T09:10:33Z","updated_at":"2018-12-12T17:42:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"310f5f89fe72a0b9d65423a3d2acbf80f46f6759","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2635/commits","review_comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2635/comments","review_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2635/comments","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/2fa6a66fd53246964aa38ad3daa0272e4d311aa5","head":{"label":"pmarkee:nuttx-cleanlibs","ref":"nuttx-cleanlibs","sha":"2fa6a66fd53246964aa38ad3daa0272e4d311aa5","user":{"login":"pmarkee","id":33598886,"node_id":"MDQ6VXNlcjMzNTk4ODg2","avatar_url":"https://avatars1.githubusercontent.com/u/33598886?v=4","gravatar_id":"","url":"https://api.github.com/users/pmarkee","html_url":"https://github.com/pmarkee","followers_url":"https://api.github.com/users/pmarkee/followers","following_url":"https://api.github.com/users/pmarkee/following{/other_user}","gists_url":"https://api.github.com/users/pmarkee/gists{/gist_id}","starred_url":"https://api.github.com/users/pmarkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmarkee/subscriptions","organizations_url":"https://api.github.com/users/pmarkee/orgs","repos_url":"https://api.github.com/users/pmarkee/repos","events_url":"https://api.github.com/users/pmarkee/events{/privacy}","received_events_url":"https://api.github.com/users/pmarkee/received_events","type":"User","site_admin":false},"repo":{"id":122205895,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIyMDU4OTU=","name":"jerryscript","full_name":"pmarkee/jerryscript","private":false,"owner":{"login":"pmarkee","id":33598886,"node_id":"MDQ6VXNlcjMzNTk4ODg2","avatar_url":"https://avatars1.githubusercontent.com/u/33598886?v=4","gravatar_id":"","url":"https://api.github.com/users/pmarkee","html_url":"https://github.com/pmarkee","followers_url":"https://api.github.com/users/pmarkee/followers","following_url":"https://api.github.com/users/pmarkee/following{/other_user}","gists_url":"https://api.github.com/users/pmarkee/gists{/gist_id}","starred_url":"https://api.github.com/users/pmarkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmarkee/subscriptions","organizations_url":"https://api.github.com/users/pmarkee/orgs","repos_url":"https://api.github.com/users/pmarkee/repos","events_url":"https://api.github.com/users/pmarkee/events{/privacy}","received_events_url":"https://api.github.com/users/pmarkee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pmarkee/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things.","fork":true,"url":"https://api.github.com/repos/pmarkee/jerryscript","forks_url":"https://api.github.com/repos/pmarkee/jerryscript/forks","keys_url":"https://api.github.com/repos/pmarkee/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmarkee/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmarkee/jerryscript/teams","hooks_url":"https://api.github.com/repos/pmarkee/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/pmarkee/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/pmarkee/jerryscript/events","assignees_url":"https://api.github.com/repos/pmarkee/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/pmarkee/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/pmarkee/jerryscript/tags","blobs_url":"https://api.github.com/repos/pmarkee/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmarkee/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmarkee/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmarkee/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmarkee/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/pmarkee/jerryscript/languages","stargazers_url":"https://api.github.com/repos/pmarkee/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/pmarkee/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/pmarkee/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/pmarkee/jerryscript/subscription","commits_url":"https://api.github.com/repos/pmarkee/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmarkee/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmarkee/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmarkee/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmarkee/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/pmarkee/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmarkee/jerryscript/merges","archive_url":"https://api.github.com/repos/pmarkee/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmarkee/jerryscript/downloads","issues_url":"https://api.github.com/repos/pmarkee/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/pmarkee/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/pmarkee/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/pmarkee/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmarkee/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/pmarkee/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/pmarkee/jerryscript/deployments","created_at":"2018-02-20T14:04:11Z","updated_at":"2018-12-06T09:37:38Z","pushed_at":"2018-12-11T09:18:27Z","git_url":"git://github.com/pmarkee/jerryscript.git","ssh_url":"git@github.com:pmarkee/jerryscript.git","clone_url":"https://github.com/pmarkee/jerryscript.git","svn_url":"https://github.com/pmarkee/jerryscript","homepage":"http://jerryscript.net","size":46060,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jerryscript-project:master","ref":"master","sha":"101f62ce9d6ad1ba212719713a0a760e801eee3f","user":{"login":"jerryscript-project","id":23194380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTk0Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/23194380?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"node_id":"MDEwOlJlcG9zaXRvcnkzMzMzOTY2MA==","name":"jerryscript","full_name":"jerryscript-project/jerryscript","private":false,"owner":{"login":"jerryscript-project","id":23194380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTk0Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/23194380?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jerryscript-project/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things.","fork":false,"url":"https://api.github.com/repos/jerryscript-project/jerryscript","forks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/forks","keys_url":"https://api.github.com/repos/jerryscript-project/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryscript-project/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryscript-project/jerryscript/teams","hooks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/events","assignees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/jerryscript-project/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/tags","blobs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryscript-project/jerryscript/languages","stargazers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscription","commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/jerryscript-project/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryscript-project/jerryscript/merges","archive_url":"https://api.github.com/repos/jerryscript-project/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryscript-project/jerryscript/downloads","issues_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryscript-project/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryscript-project/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryscript-project/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/jerryscript-project/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/deployments","created_at":"2015-04-03T01:10:31Z","updated_at":"2018-12-12T14:41:48Z","pushed_at":"2018-12-12T15:17:11Z","git_url":"git://github.com/jerryscript-project/jerryscript.git","ssh_url":"git@github.com:jerryscript-project/jerryscript.git","clone_url":"https://github.com/jerryscript-project/jerryscript.git","svn_url":"https://github.com/jerryscript-project/jerryscript","homepage":"http://jerryscript.net","size":47269,"stargazers_count":3360,"watchers_count":3360,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":391,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":391,"open_issues":67,"watchers":3360,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2635"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/2635"},"issue":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2635"},"comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2635/comments"},"review_comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2635/comments"},"review_comment":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2635/commits"},"statuses":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/2fa6a66fd53246964aa38ad3daa0272e4d311aa5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"akosthekiss"}}