{"action":"closed","number":4504,"pull_request":{"url":"https://api.github.com/repos/wagtail/wagtail/pulls/4504","id":184926081,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0OTI2MDgx","html_url":"https://github.com/wagtail/wagtail/pull/4504","diff_url":"https://github.com/wagtail/wagtail/pull/4504.diff","patch_url":"https://github.com/wagtail/wagtail/pull/4504.patch","issue_url":"https://api.github.com/repos/wagtail/wagtail/issues/4504","number":4504,"state":"closed","locked":false,"title":"Validates EmbedBlock URLs against providers.","user":{"login":"BertrandBordage","id":1119169,"node_id":"MDQ6VXNlcjExMTkxNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1119169?v=4","gravatar_id":"","url":"https://api.github.com/users/BertrandBordage","html_url":"https://github.com/BertrandBordage","followers_url":"https://api.github.com/users/BertrandBordage/followers","following_url":"https://api.github.com/users/BertrandBordage/following{/other_user}","gists_url":"https://api.github.com/users/BertrandBordage/gists{/gist_id}","starred_url":"https://api.github.com/users/BertrandBordage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertrandBordage/subscriptions","organizations_url":"https://api.github.com/users/BertrandBordage/orgs","repos_url":"https://api.github.com/users/BertrandBordage/repos","events_url":"https://api.github.com/users/BertrandBordage/events{/privacy}","received_events_url":"https://api.github.com/users/BertrandBordage/received_events","type":"User","site_admin":false},"body":"Currently, `EmbedBlock` accepts any URL, even when no provider is related.\r\n\r\nWith this pull request, not only `EmbedBlock` checks that the URL is valid, but it also checks whether it corresponds to existing data on the third-party site by fetching data on validation instead of doing it on front-end rendering.\r\n\r\nAs a side effect, this speeds up the first front-end page load after an `EmbedBlock` value change.","created_at":"2018-04-30T10:45:05Z","updated_at":"2018-08-16T11:35:17Z","closed_at":"2018-08-16T11:35:16Z","merged_at":null,"merge_commit_sha":"4fbc528a72029fce0952b7064ebb33911fa87518","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":779476086,"node_id":"MDU6TGFiZWw3Nzk0NzYwODY=","url":"https://api.github.com/repos/wagtail/wagtail/labels/component:Embeds","name":"component:Embeds","color":"daa6ea","default":false},{"id":78418438,"node_id":"MDU6TGFiZWw3ODQxODQzOA==","url":"https://api.github.com/repos/wagtail/wagtail/labels/type:Bug","name":"type:Bug","color":"ff0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wagtail/wagtail/pulls/4504/commits","review_comments_url":"https://api.github.com/repos/wagtail/wagtail/pulls/4504/comments","review_comment_url":"https://api.github.com/repos/wagtail/wagtail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wagtail/wagtail/issues/4504/comments","statuses_url":"https://api.github.com/repos/wagtail/wagtail/statuses/20e1e6dbeefefc3ee2c00015a12fe9786c2d3972","head":{"label":"BertrandBordage:validate-embedblock","ref":"validate-embedblock","sha":"20e1e6dbeefefc3ee2c00015a12fe9786c2d3972","user":{"login":"BertrandBordage","id":1119169,"node_id":"MDQ6VXNlcjExMTkxNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1119169?v=4","gravatar_id":"","url":"https://api.github.com/users/BertrandBordage","html_url":"https://github.com/BertrandBordage","followers_url":"https://api.github.com/users/BertrandBordage/followers","following_url":"https://api.github.com/users/BertrandBordage/following{/other_user}","gists_url":"https://api.github.com/users/BertrandBordage/gists{/gist_id}","starred_url":"https://api.github.com/users/BertrandBordage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertrandBordage/subscriptions","organizations_url":"https://api.github.com/users/BertrandBordage/orgs","repos_url":"https://api.github.com/users/BertrandBordage/repos","events_url":"https://api.github.com/users/BertrandBordage/events{/privacy}","received_events_url":"https://api.github.com/users/BertrandBordage/received_events","type":"User","site_admin":false},"repo":{"id":68384292,"node_id":"MDEwOlJlcG9zaXRvcnk2ODM4NDI5Mg==","name":"wagtail","full_name":"BertrandBordage/wagtail","owner":{"login":"BertrandBordage","id":1119169,"node_id":"MDQ6VXNlcjExMTkxNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1119169?v=4","gravatar_id":"","url":"https://api.github.com/users/BertrandBordage","html_url":"https://github.com/BertrandBordage","followers_url":"https://api.github.com/users/BertrandBordage/followers","following_url":"https://api.github.com/users/BertrandBordage/following{/other_user}","gists_url":"https://api.github.com/users/BertrandBordage/gists{/gist_id}","starred_url":"https://api.github.com/users/BertrandBordage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertrandBordage/subscriptions","organizations_url":"https://api.github.com/users/BertrandBordage/orgs","repos_url":"https://api.github.com/users/BertrandBordage/repos","events_url":"https://api.github.com/users/BertrandBordage/events{/privacy}","received_events_url":"https://api.github.com/users/BertrandBordage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BertrandBordage/wagtail","description":"A Django content management system focused on flexibility and user experience","fork":true,"url":"https://api.github.com/repos/BertrandBordage/wagtail","forks_url":"https://api.github.com/repos/BertrandBordage/wagtail/forks","keys_url":"https://api.github.com/repos/BertrandBordage/wagtail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BertrandBordage/wagtail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BertrandBordage/wagtail/teams","hooks_url":"https://api.github.com/repos/BertrandBordage/wagtail/hooks","issue_events_url":"https://api.github.com/repos/BertrandBordage/wagtail/issues/events{/number}","events_url":"https://api.github.com/repos/BertrandBordage/wagtail/events","assignees_url":"https://api.github.com/repos/BertrandBordage/wagtail/assignees{/user}","branches_url":"https://api.github.com/repos/BertrandBordage/wagtail/branches{/branch}","tags_url":"https://api.github.com/repos/BertrandBordage/wagtail/tags","blobs_url":"https://api.github.com/repos/BertrandBordage/wagtail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BertrandBordage/wagtail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BertrandBordage/wagtail/git/refs{/sha}","trees_url":"https://api.github.com/repos/BertrandBordage/wagtail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BertrandBordage/wagtail/statuses/{sha}","languages_url":"https://api.github.com/repos/BertrandBordage/wagtail/languages","stargazers_url":"https://api.github.com/repos/BertrandBordage/wagtail/stargazers","contributors_url":"https://api.github.com/repos/BertrandBordage/wagtail/contributors","subscribers_url":"https://api.github.com/repos/BertrandBordage/wagtail/subscribers","subscription_url":"https://api.github.com/repos/BertrandBordage/wagtail/subscription","commits_url":"https://api.github.com/repos/BertrandBordage/wagtail/commits{/sha}","git_commits_url":"https://api.github.com/repos/BertrandBordage/wagtail/git/commits{/sha}","comments_url":"https://api.github.com/repos/BertrandBordage/wagtail/comments{/number}","issue_comment_url":"https://api.github.com/repos/BertrandBordage/wagtail/issues/comments{/number}","contents_url":"https://api.github.com/repos/BertrandBordage/wagtail/contents/{+path}","compare_url":"https://api.github.com/repos/BertrandBordage/wagtail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BertrandBordage/wagtail/merges","archive_url":"https://api.github.com/repos/BertrandBordage/wagtail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BertrandBordage/wagtail/downloads","issues_url":"https://api.github.com/repos/BertrandBordage/wagtail/issues{/number}","pulls_url":"https://api.github.com/repos/BertrandBordage/wagtail/pulls{/number}","milestones_url":"https://api.github.com/repos/BertrandBordage/wagtail/milestones{/number}","notifications_url":"https://api.github.com/repos/BertrandBordage/wagtail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BertrandBordage/wagtail/labels{/name}","releases_url":"https://api.github.com/repos/BertrandBordage/wagtail/releases{/id}","deployments_url":"https://api.github.com/repos/BertrandBordage/wagtail/deployments","created_at":"2016-09-16T13:57:44Z","updated_at":"2018-06-20T13:24:23Z","pushed_at":"2018-08-10T11:53:21Z","git_url":"git://github.com/BertrandBordage/wagtail.git","ssh_url":"git@github.com:BertrandBordage/wagtail.git","clone_url":"https://github.com/BertrandBordage/wagtail.git","svn_url":"https://github.com/BertrandBordage/wagtail","homepage":"wagtail.io","size":71409,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wagtail:master","ref":"master","sha":"fa27773d168636be41df5e6710fc4343607ca4bf","user":{"login":"wagtail","id":23708009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzA4MDA5","avatar_url":"https://avatars3.githubusercontent.com/u/23708009?v=4","gravatar_id":"","url":"https://api.github.com/users/wagtail","html_url":"https://github.com/wagtail","followers_url":"https://api.github.com/users/wagtail/followers","following_url":"https://api.github.com/users/wagtail/following{/other_user}","gists_url":"https://api.github.com/users/wagtail/gists{/gist_id}","starred_url":"https://api.github.com/users/wagtail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagtail/subscriptions","organizations_url":"https://api.github.com/users/wagtail/orgs","repos_url":"https://api.github.com/users/wagtail/repos","events_url":"https://api.github.com/users/wagtail/events{/privacy}","received_events_url":"https://api.github.com/users/wagtail/received_events","type":"Organization","site_admin":false},"repo":{"id":16479108,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ3OTEwOA==","name":"wagtail","full_name":"wagtail/wagtail","owner":{"login":"wagtail","id":23708009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzA4MDA5","avatar_url":"https://avatars3.githubusercontent.com/u/23708009?v=4","gravatar_id":"","url":"https://api.github.com/users/wagtail","html_url":"https://github.com/wagtail","followers_url":"https://api.github.com/users/wagtail/followers","following_url":"https://api.github.com/users/wagtail/following{/other_user}","gists_url":"https://api.github.com/users/wagtail/gists{/gist_id}","starred_url":"https://api.github.com/users/wagtail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagtail/subscriptions","organizations_url":"https://api.github.com/users/wagtail/orgs","repos_url":"https://api.github.com/users/wagtail/repos","events_url":"https://api.github.com/users/wagtail/events{/privacy}","received_events_url":"https://api.github.com/users/wagtail/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wagtail/wagtail","description":"A Django content management system focused on flexibility and user experience","fork":false,"url":"https://api.github.com/repos/wagtail/wagtail","forks_url":"https://api.github.com/repos/wagtail/wagtail/forks","keys_url":"https://api.github.com/repos/wagtail/wagtail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wagtail/wagtail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wagtail/wagtail/teams","hooks_url":"https://api.github.com/repos/wagtail/wagtail/hooks","issue_events_url":"https://api.github.com/repos/wagtail/wagtail/issues/events{/number}","events_url":"https://api.github.com/repos/wagtail/wagtail/events","assignees_url":"https://api.github.com/repos/wagtail/wagtail/assignees{/user}","branches_url":"https://api.github.com/repos/wagtail/wagtail/branches{/branch}","tags_url":"https://api.github.com/repos/wagtail/wagtail/tags","blobs_url":"https://api.github.com/repos/wagtail/wagtail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wagtail/wagtail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wagtail/wagtail/git/refs{/sha}","trees_url":"https://api.github.com/repos/wagtail/wagtail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wagtail/wagtail/statuses/{sha}","languages_url":"https://api.github.com/repos/wagtail/wagtail/languages","stargazers_url":"https://api.github.com/repos/wagtail/wagtail/stargazers","contributors_url":"https://api.github.com/repos/wagtail/wagtail/contributors","subscribers_url":"https://api.github.com/repos/wagtail/wagtail/subscribers","subscription_url":"https://api.github.com/repos/wagtail/wagtail/subscription","commits_url":"https://api.github.com/repos/wagtail/wagtail/commits{/sha}","git_commits_url":"https://api.github.com/repos/wagtail/wagtail/git/commits{/sha}","comments_url":"https://api.github.com/repos/wagtail/wagtail/comments{/number}","issue_comment_url":"https://api.github.com/repos/wagtail/wagtail/issues/comments{/number}","contents_url":"https://api.github.com/repos/wagtail/wagtail/contents/{+path}","compare_url":"https://api.github.com/repos/wagtail/wagtail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wagtail/wagtail/merges","archive_url":"https://api.github.com/repos/wagtail/wagtail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wagtail/wagtail/downloads","issues_url":"https://api.github.com/repos/wagtail/wagtail/issues{/number}","pulls_url":"https://api.github.com/repos/wagtail/wagtail/pulls{/number}","milestones_url":"https://api.github.com/repos/wagtail/wagtail/milestones{/number}","notifications_url":"https://api.github.com/repos/wagtail/wagtail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wagtail/wagtail/labels{/name}","releases_url":"https://api.github.com/repos/wagtail/wagtail/releases{/id}","deployments_url":"https://api.github.com/repos/wagtail/wagtail/deployments","created_at":"2014-02-03T12:41:59Z","updated_at":"2018-08-16T11:29:04Z","pushed_at":"2018-08-16T11:32:25Z","git_url":"git://github.com/wagtail/wagtail.git","ssh_url":"git@github.com:wagtail/wagtail.git","clone_url":"https://github.com/wagtail/wagtail.git","svn_url":"https://github.com/wagtail/wagtail","homepage":"https://wagtail.io","size":73827,"stargazers_count":5803,"watchers_count":5803,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1298,"mirror_url":null,"archived":false,"open_issues_count":641,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1298,"open_issues":641,"watchers":5803,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wagtail/wagtail/pulls/4504"},"html":{"href":"https://github.com/wagtail/wagtail/pull/4504"},"issue":{"href":"https://api.github.com/repos/wagtail/wagtail/issues/4504"},"comments":{"href":"https://api.github.com/repos/wagtail/wagtail/issues/4504/comments"},"review_comments":{"href":"https://api.github.com/repos/wagtail/wagtail/pulls/4504/comments"},"review_comment":{"href":"https://api.github.com/repos/wagtail/wagtail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wagtail/wagtail/pulls/4504/commits"},"statuses":{"href":"https://api.github.com/repos/wagtail/wagtail/statuses/20e1e6dbeefefc3ee2c00015a12fe9786c2d3972"}},"author_association":"MEMBER","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":14,"maintainer_can_modify":false,"commits":2,"additions":43,"deletions":13,"changed_files":2}}
{"actor":{"display_login":"gasman"}}