{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/8632","repository_url":"https://api.github.com/repos/netty/netty","labels_url":"https://api.github.com/repos/netty/netty/issues/8632/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/8632/comments","events_url":"https://api.github.com/repos/netty/netty/issues/8632/events","html_url":"https://github.com/netty/netty/pull/8632","id":388226200,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTM5NTg1","number":8632,"title":"Correct respect auto read configuration when using HTTP/2","user":{"login":"normanmaurer","id":439362,"node_id":"MDQ6VXNlcjQzOTM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-06T13:59:50Z","updated_at":"2018-12-06T14:01:27Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/8632","html_url":"https://github.com/netty/netty/pull/8632","diff_url":"https://github.com/netty/netty/pull/8632.diff","patch_url":"https://github.com/netty/netty/pull/8632.patch"},"body":"Motivation:\r\n\r\nWe did not correctly respect auto read when HTTP/2 is used. This was due the fact that we extended ByteToMessageDecoder but not use the out List to put decoded messages in. This lead to the situation that we will trigger a ctx.read() in channelReadComplete() as we assume we was not able to decode any data.\r\n\r\nModifications:\r\n\r\n- Correctly keep track of if we were able to decode a frame and only if not trigger a read if auto read is off.\r\n- Fix handling in Http2FrameCodec as well\r\n- Add unit test.\r\n\r\nResult:\r\n\r\nCorrectly respect auto read also when using HTTP2"},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/444880103","html_url":"https://github.com/netty/netty/pull/8632#issuecomment-444880103","issue_url":"https://api.github.com/repos/netty/netty/issues/8632","id":444880103,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDg4MDEwMw==","user":{"login":"normanmaurer","id":439362,"node_id":"MDQ6VXNlcjQzOTM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T14:01:27Z","updated_at":"2018-12-06T14:01:27Z","author_association":"MEMBER","body":"This was reported by @rschmitt here https://github.com/netty/netty/pull/8617#discussion_r238801970.\r\n\r\nThis is the first part of the fix to correctly handles it for `Http2ConnectHandler` and `Http2FrameCodec`. Once this is merged I will look into `Http2MultiplexCodec`"}}
{"actor":{"display_login":"normanmaurer"}}