{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/pulls/25","id":198971667,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4OTcxNjY3","html_url":"https://github.com/hannesmuehleisen/MonetDBLite-R/pull/25","diff_url":"https://github.com/hannesmuehleisen/MonetDBLite-R/pull/25.diff","patch_url":"https://github.com/hannesmuehleisen/MonetDBLite-R/pull/25.patch","issue_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/issues/25","number":25,"state":"closed","locked":false,"title":"mark window median as missing so dplyr doesn't throw warnings (fixes #19)","user":{"login":"gergness","id":2104579,"node_id":"MDQ6VXNlcjIxMDQ1Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2104579?v=4","gravatar_id":"","url":"https://api.github.com/users/gergness","html_url":"https://github.com/gergness","followers_url":"https://api.github.com/users/gergness/followers","following_url":"https://api.github.com/users/gergness/following{/other_user}","gists_url":"https://api.github.com/users/gergness/gists{/gist_id}","starred_url":"https://api.github.com/users/gergness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gergness/subscriptions","organizations_url":"https://api.github.com/users/gergness/orgs","repos_url":"https://api.github.com/users/gergness/repos","events_url":"https://api.github.com/users/gergness/events{/privacy}","received_events_url":"https://api.github.com/users/gergness/received_events","type":"User","site_admin":false},"body":"Hoping to sneak this in to the 0.6 release it looks like you're preparing for. The comments in #19 made me think this is an easy fix, but I'm sorry if I'm missing something.\r\n\r\nBefore this PR, most queries using dbplyr have a warning about missing window median function\r\n``` r\r\nlibrary(MonetDBLite)\r\nlibrary(dplyr)\r\n\r\nsrc <- src_monetdblite(dbdir = tempdir())\r\ncopy_to(src, mtcars)\r\n\r\ntbl(src, \"mtcars\") %>%\r\n  filter(mpg > 21)\r\n#> Warning: Translator is missing window variants of the following aggregate functions:\r\n#> * median\r\n\r\n#> Warning: Translator is missing window variants of the following aggregate functions:\r\n#> * median\r\n#> # Source:   lazy query [?? x 11]\r\n#> # Database: MonetDBEmbeddedConnection\r\n#>      mpg   cyl  disp    hp  drat    wt  qsec    vs    am  gear  carb\r\n#>    <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl>\r\n#>  1  22.8     4 108      93  3.85  2.32  18.6     1     1     4     1\r\n#>  2  21.4     6 258     110  3.08  3.22  19.4     1     0     3     1\r\n#>  3  24.4     4 147.     62  3.69  3.19  20       1     0     4     2\r\n#>  4  22.8     4 141.     95  3.92  3.15  22.9     1     0     4     2\r\n#>  5  32.4     4  78.7    66  4.08  2.2   19.5     1     1     4     1\r\n#>  6  30.4     4  75.7    52  4.93  1.62  18.5     1     1     4     2\r\n#>  7  33.9     4  71.1    65  4.22  1.84  19.9     1     1     4     1\r\n#>  8  21.5     4 120.     97  3.7   2.46  20.0     1     0     3     1\r\n#>  9  27.3     4  79      66  4.08  1.94  18.9     1     1     4     1\r\n#> 10  26       4 120.     91  4.43  2.14  16.7     0     1     5     2\r\n#> # ... with more rows\r\n```\r\n\r\nAfter PR no warning, and here's the error when you try to a windowed median:\r\n```r\r\ntbl(src, \"mtcars\") %>%\r\n  group_by(cyl) %>%\r\n  mutate(mpg = median(mpg))\r\n#> Error: Window function `MEDIAN()` is not supported by this database\r\n```","created_at":"2018-07-03T13:54:50Z","updated_at":"2018-07-03T15:20:17Z","closed_at":"2018-07-03T15:20:17Z","merged_at":"2018-07-03T15:20:17Z","merge_commit_sha":"501d85556c0cf6a4e97fd9452fbb0641fcde67ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/pulls/25/commits","review_comments_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/pulls/25/comments","review_comment_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/issues/25/comments","statuses_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/statuses/6662c43a162d2fb3931c76f4af7599464e690df7","head":{"label":"gergness:dplyr-win-median","ref":"dplyr-win-median","sha":"6662c43a162d2fb3931c76f4af7599464e690df7","user":{"login":"gergness","id":2104579,"node_id":"MDQ6VXNlcjIxMDQ1Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2104579?v=4","gravatar_id":"","url":"https://api.github.com/users/gergness","html_url":"https://github.com/gergness","followers_url":"https://api.github.com/users/gergness/followers","following_url":"https://api.github.com/users/gergness/following{/other_user}","gists_url":"https://api.github.com/users/gergness/gists{/gist_id}","starred_url":"https://api.github.com/users/gergness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gergness/subscriptions","organizations_url":"https://api.github.com/users/gergness/orgs","repos_url":"https://api.github.com/users/gergness/repos","events_url":"https://api.github.com/users/gergness/events{/privacy}","received_events_url":"https://api.github.com/users/gergness/received_events","type":"User","site_admin":false},"repo":{"id":139500661,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1MDA2NjE=","name":"MonetDBLite-R","full_name":"gergness/MonetDBLite-R","owner":{"login":"gergness","id":2104579,"node_id":"MDQ6VXNlcjIxMDQ1Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2104579?v=4","gravatar_id":"","url":"https://api.github.com/users/gergness","html_url":"https://github.com/gergness","followers_url":"https://api.github.com/users/gergness/followers","following_url":"https://api.github.com/users/gergness/following{/other_user}","gists_url":"https://api.github.com/users/gergness/gists{/gist_id}","starred_url":"https://api.github.com/users/gergness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gergness/subscriptions","organizations_url":"https://api.github.com/users/gergness/orgs","repos_url":"https://api.github.com/users/gergness/repos","events_url":"https://api.github.com/users/gergness/events{/privacy}","received_events_url":"https://api.github.com/users/gergness/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gergness/MonetDBLite-R","description":"MonetDB reconfigured as an R package - See below for an introduction. Edit","fork":true,"url":"https://api.github.com/repos/gergness/MonetDBLite-R","forks_url":"https://api.github.com/repos/gergness/MonetDBLite-R/forks","keys_url":"https://api.github.com/repos/gergness/MonetDBLite-R/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gergness/MonetDBLite-R/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gergness/MonetDBLite-R/teams","hooks_url":"https://api.github.com/repos/gergness/MonetDBLite-R/hooks","issue_events_url":"https://api.github.com/repos/gergness/MonetDBLite-R/issues/events{/number}","events_url":"https://api.github.com/repos/gergness/MonetDBLite-R/events","assignees_url":"https://api.github.com/repos/gergness/MonetDBLite-R/assignees{/user}","branches_url":"https://api.github.com/repos/gergness/MonetDBLite-R/branches{/branch}","tags_url":"https://api.github.com/repos/gergness/MonetDBLite-R/tags","blobs_url":"https://api.github.com/repos/gergness/MonetDBLite-R/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gergness/MonetDBLite-R/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gergness/MonetDBLite-R/git/refs{/sha}","trees_url":"https://api.github.com/repos/gergness/MonetDBLite-R/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gergness/MonetDBLite-R/statuses/{sha}","languages_url":"https://api.github.com/repos/gergness/MonetDBLite-R/languages","stargazers_url":"https://api.github.com/repos/gergness/MonetDBLite-R/stargazers","contributors_url":"https://api.github.com/repos/gergness/MonetDBLite-R/contributors","subscribers_url":"https://api.github.com/repos/gergness/MonetDBLite-R/subscribers","subscription_url":"https://api.github.com/repos/gergness/MonetDBLite-R/subscription","commits_url":"https://api.github.com/repos/gergness/MonetDBLite-R/commits{/sha}","git_commits_url":"https://api.github.com/repos/gergness/MonetDBLite-R/git/commits{/sha}","comments_url":"https://api.github.com/repos/gergness/MonetDBLite-R/comments{/number}","issue_comment_url":"https://api.github.com/repos/gergness/MonetDBLite-R/issues/comments{/number}","contents_url":"https://api.github.com/repos/gergness/MonetDBLite-R/contents/{+path}","compare_url":"https://api.github.com/repos/gergness/MonetDBLite-R/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gergness/MonetDBLite-R/merges","archive_url":"https://api.github.com/repos/gergness/MonetDBLite-R/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gergness/MonetDBLite-R/downloads","issues_url":"https://api.github.com/repos/gergness/MonetDBLite-R/issues{/number}","pulls_url":"https://api.github.com/repos/gergness/MonetDBLite-R/pulls{/number}","milestones_url":"https://api.github.com/repos/gergness/MonetDBLite-R/milestones{/number}","notifications_url":"https://api.github.com/repos/gergness/MonetDBLite-R/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gergness/MonetDBLite-R/labels{/name}","releases_url":"https://api.github.com/repos/gergness/MonetDBLite-R/releases{/id}","deployments_url":"https://api.github.com/repos/gergness/MonetDBLite-R/deployments","created_at":"2018-07-02T22:21:25Z","updated_at":"2018-07-02T22:21:29Z","pushed_at":"2018-07-02T22:38:34Z","git_url":"git://github.com/gergness/MonetDBLite-R.git","ssh_url":"git@github.com:gergness/MonetDBLite-R.git","clone_url":"https://github.com/gergness/MonetDBLite-R.git","svn_url":"https://github.com/gergness/MonetDBLite-R","homepage":"","size":2628,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hannesmuehleisen:master","ref":"master","sha":"e8d545322c37aeaa4bcefd97ab07bc5497475e4c","user":{"login":"hannesmuehleisen","id":227792,"node_id":"MDQ6VXNlcjIyNzc5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/227792?v=4","gravatar_id":"","url":"https://api.github.com/users/hannesmuehleisen","html_url":"https://github.com/hannesmuehleisen","followers_url":"https://api.github.com/users/hannesmuehleisen/followers","following_url":"https://api.github.com/users/hannesmuehleisen/following{/other_user}","gists_url":"https://api.github.com/users/hannesmuehleisen/gists{/gist_id}","starred_url":"https://api.github.com/users/hannesmuehleisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannesmuehleisen/subscriptions","organizations_url":"https://api.github.com/users/hannesmuehleisen/orgs","repos_url":"https://api.github.com/users/hannesmuehleisen/repos","events_url":"https://api.github.com/users/hannesmuehleisen/events{/privacy}","received_events_url":"https://api.github.com/users/hannesmuehleisen/received_events","type":"User","site_admin":false},"repo":{"id":103245827,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMyNDU4Mjc=","name":"MonetDBLite-R","full_name":"hannesmuehleisen/MonetDBLite-R","owner":{"login":"hannesmuehleisen","id":227792,"node_id":"MDQ6VXNlcjIyNzc5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/227792?v=4","gravatar_id":"","url":"https://api.github.com/users/hannesmuehleisen","html_url":"https://github.com/hannesmuehleisen","followers_url":"https://api.github.com/users/hannesmuehleisen/followers","following_url":"https://api.github.com/users/hannesmuehleisen/following{/other_user}","gists_url":"https://api.github.com/users/hannesmuehleisen/gists{/gist_id}","starred_url":"https://api.github.com/users/hannesmuehleisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannesmuehleisen/subscriptions","organizations_url":"https://api.github.com/users/hannesmuehleisen/orgs","repos_url":"https://api.github.com/users/hannesmuehleisen/repos","events_url":"https://api.github.com/users/hannesmuehleisen/events{/privacy}","received_events_url":"https://api.github.com/users/hannesmuehleisen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hannesmuehleisen/MonetDBLite-R","description":"MonetDB reconfigured as an R package - See below for an introduction. Edit","fork":false,"url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R","forks_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/forks","keys_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/teams","hooks_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/hooks","issue_events_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/issues/events{/number}","events_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/events","assignees_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/assignees{/user}","branches_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/branches{/branch}","tags_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/tags","blobs_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/git/refs{/sha}","trees_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/statuses/{sha}","languages_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/languages","stargazers_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/stargazers","contributors_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/contributors","subscribers_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/subscribers","subscription_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/subscription","commits_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/commits{/sha}","git_commits_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/git/commits{/sha}","comments_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/comments{/number}","issue_comment_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/issues/comments{/number}","contents_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/contents/{+path}","compare_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/merges","archive_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/downloads","issues_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/issues{/number}","pulls_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/pulls{/number}","milestones_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/milestones{/number}","notifications_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/labels{/name}","releases_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/releases{/id}","deployments_url":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/deployments","created_at":"2017-09-12T08:49:13Z","updated_at":"2018-07-03T14:08:16Z","pushed_at":"2018-07-03T15:20:17Z","git_url":"git://github.com/hannesmuehleisen/MonetDBLite-R.git","ssh_url":"git@github.com:hannesmuehleisen/MonetDBLite-R.git","clone_url":"https://github.com/hannesmuehleisen/MonetDBLite-R.git","svn_url":"https://github.com/hannesmuehleisen/MonetDBLite-R","homepage":"","size":2628,"stargazers_count":29,"watchers_count":29,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":4,"open_issues":6,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/pulls/25"},"html":{"href":"https://github.com/hannesmuehleisen/MonetDBLite-R/pull/25"},"issue":{"href":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/issues/25"},"comments":{"href":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/hannesmuehleisen/MonetDBLite-R/statuses/6662c43a162d2fb3931c76f4af7599464e690df7"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hannesmuehleisen","id":227792,"node_id":"MDQ6VXNlcjIyNzc5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/227792?v=4","gravatar_id":"","url":"https://api.github.com/users/hannesmuehleisen","html_url":"https://github.com/hannesmuehleisen","followers_url":"https://api.github.com/users/hannesmuehleisen/followers","following_url":"https://api.github.com/users/hannesmuehleisen/following{/other_user}","gists_url":"https://api.github.com/users/hannesmuehleisen/gists{/gist_id}","starred_url":"https://api.github.com/users/hannesmuehleisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannesmuehleisen/subscriptions","organizations_url":"https://api.github.com/users/hannesmuehleisen/orgs","repos_url":"https://api.github.com/users/hannesmuehleisen/repos","events_url":"https://api.github.com/users/hannesmuehleisen/events{/privacy}","received_events_url":"https://api.github.com/users/hannesmuehleisen/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"hannesmuehleisen"}}