{"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/235756822","pull_request_review_id":177696587,"id":235756822,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTc1NjgyMg==","diff_hunk":"@@ -517,7 +517,8 @@ LIBVIRT_DBUS_PROVIDER = {\n                         props.available = poolInfo[0][3];\n \n                         dispatch(updateOrAddStoragePool(Object.assign({}, dumpxmlParams, props)));\n-                        dispatch(getStorageVolumes({ connectionName, poolName: dumpxmlParams.name }));\n+                        if (props.active)\n+                            dispatch(getStorageVolumes({ connectionName, poolName: dumpxmlParams.name }));","path":"pkg/machines/libvirt-dbus.es6","position":56,"original_position":6,"commit_id":"2d61da32abb89edbb189588bed7a6f50380cdfb3","original_commit_id":"beced290e7fe678997d61789f94aaef8f3b79b2d","user":{"login":"KKoukiou","id":14921356,"node_id":"MDQ6VXNlcjE0OTIxMzU2","avatar_url":"https://avatars1.githubusercontent.com/u/14921356?v=4","gravatar_id":"","url":"https://api.github.com/users/KKoukiou","html_url":"https://github.com/KKoukiou","followers_url":"https://api.github.com/users/KKoukiou/followers","following_url":"https://api.github.com/users/KKoukiou/following{/other_user}","gists_url":"https://api.github.com/users/KKoukiou/gists{/gist_id}","starred_url":"https://api.github.com/users/KKoukiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KKoukiou/subscriptions","organizations_url":"https://api.github.com/users/KKoukiou/orgs","repos_url":"https://api.github.com/users/KKoukiou/repos","events_url":"https://api.github.com/users/KKoukiou/events{/privacy}","received_events_url":"https://api.github.com/users/KKoukiou/received_events","type":"User","site_admin":false},"body":"Theoretically we can trigger parts of the test-suite as well but we don't do that and it works perfect so far. And having some fixes for the same package inside a PR that was meant to mainly do something else is not a great deal - it makes things quicker without making the commit history dirty.","created_at":"2018-11-22T15:09:31Z","updated_at":"2018-11-22T15:09:31Z","html_url":"https://github.com/cockpit-project/cockpit/pull/10631#discussion_r235756822","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10631","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/235756822"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/10631#discussion_r235756822"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10631"}},"in_reply_to_id":235735588},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10631","id":232632538,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjMyNTM4","html_url":"https://github.com/cockpit-project/cockpit/pull/10631","diff_url":"https://github.com/cockpit-project/cockpit/pull/10631.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/10631.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10631","number":10631,"state":"open","locked":false,"title":"WIP: Introduce create storage pools action","user":{"login":"KKoukiou","id":14921356,"node_id":"MDQ6VXNlcjE0OTIxMzU2","avatar_url":"https://avatars1.githubusercontent.com/u/14921356?v=4","gravatar_id":"","url":"https://api.github.com/users/KKoukiou","html_url":"https://github.com/KKoukiou","followers_url":"https://api.github.com/users/KKoukiou/followers","following_url":"https://api.github.com/users/KKoukiou/following{/other_user}","gists_url":"https://api.github.com/users/KKoukiou/gists{/gist_id}","starred_url":"https://api.github.com/users/KKoukiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KKoukiou/subscriptions","organizations_url":"https://api.github.com/users/KKoukiou/orgs","repos_url":"https://api.github.com/users/KKoukiou/repos","events_url":"https://api.github.com/users/KKoukiou/events{/privacy}","received_events_url":"https://api.github.com/users/KKoukiou/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-21T11:39:30Z","updated_at":"2018-11-22T15:09:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63f3b25e3ae1fac2592a1c81b77a436cabf0a05f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":88467047,"node_id":"MDU6TGFiZWw4ODQ2NzA0Nw==","url":"https://api.github.com/repos/cockpit-project/cockpit/labels/needswork","name":"needswork","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10631/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10631/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10631/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/2d61da32abb89edbb189588bed7a6f50380cdfb3","head":{"label":"KKoukiou:storage-pools-actions","ref":"storage-pools-actions","sha":"2d61da32abb89edbb189588bed7a6f50380cdfb3","user":{"login":"KKoukiou","id":14921356,"node_id":"MDQ6VXNlcjE0OTIxMzU2","avatar_url":"https://avatars1.githubusercontent.com/u/14921356?v=4","gravatar_id":"","url":"https://api.github.com/users/KKoukiou","html_url":"https://github.com/KKoukiou","followers_url":"https://api.github.com/users/KKoukiou/followers","following_url":"https://api.github.com/users/KKoukiou/following{/other_user}","gists_url":"https://api.github.com/users/KKoukiou/gists{/gist_id}","starred_url":"https://api.github.com/users/KKoukiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KKoukiou/subscriptions","organizations_url":"https://api.github.com/users/KKoukiou/orgs","repos_url":"https://api.github.com/users/KKoukiou/repos","events_url":"https://api.github.com/users/KKoukiou/events{/privacy}","received_events_url":"https://api.github.com/users/KKoukiou/received_events","type":"User","site_admin":false},"repo":{"id":134564753,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ1NjQ3NTM=","name":"cockpit","full_name":"KKoukiou/cockpit","private":false,"owner":{"login":"KKoukiou","id":14921356,"node_id":"MDQ6VXNlcjE0OTIxMzU2","avatar_url":"https://avatars1.githubusercontent.com/u/14921356?v=4","gravatar_id":"","url":"https://api.github.com/users/KKoukiou","html_url":"https://github.com/KKoukiou","followers_url":"https://api.github.com/users/KKoukiou/followers","following_url":"https://api.github.com/users/KKoukiou/following{/other_user}","gists_url":"https://api.github.com/users/KKoukiou/gists{/gist_id}","starred_url":"https://api.github.com/users/KKoukiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KKoukiou/subscriptions","organizations_url":"https://api.github.com/users/KKoukiou/orgs","repos_url":"https://api.github.com/users/KKoukiou/repos","events_url":"https://api.github.com/users/KKoukiou/events{/privacy}","received_events_url":"https://api.github.com/users/KKoukiou/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KKoukiou/cockpit","description":"There's code a goin' on","fork":true,"url":"https://api.github.com/repos/KKoukiou/cockpit","forks_url":"https://api.github.com/repos/KKoukiou/cockpit/forks","keys_url":"https://api.github.com/repos/KKoukiou/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KKoukiou/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KKoukiou/cockpit/teams","hooks_url":"https://api.github.com/repos/KKoukiou/cockpit/hooks","issue_events_url":"https://api.github.com/repos/KKoukiou/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/KKoukiou/cockpit/events","assignees_url":"https://api.github.com/repos/KKoukiou/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/KKoukiou/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/KKoukiou/cockpit/tags","blobs_url":"https://api.github.com/repos/KKoukiou/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KKoukiou/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KKoukiou/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/KKoukiou/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KKoukiou/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/KKoukiou/cockpit/languages","stargazers_url":"https://api.github.com/repos/KKoukiou/cockpit/stargazers","contributors_url":"https://api.github.com/repos/KKoukiou/cockpit/contributors","subscribers_url":"https://api.github.com/repos/KKoukiou/cockpit/subscribers","subscription_url":"https://api.github.com/repos/KKoukiou/cockpit/subscription","commits_url":"https://api.github.com/repos/KKoukiou/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/KKoukiou/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/KKoukiou/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/KKoukiou/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/KKoukiou/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/KKoukiou/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KKoukiou/cockpit/merges","archive_url":"https://api.github.com/repos/KKoukiou/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KKoukiou/cockpit/downloads","issues_url":"https://api.github.com/repos/KKoukiou/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/KKoukiou/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/KKoukiou/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/KKoukiou/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KKoukiou/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/KKoukiou/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/KKoukiou/cockpit/deployments","created_at":"2018-05-23T12:15:33Z","updated_at":"2018-05-23T12:15:40Z","pushed_at":"2018-11-21T11:38:47Z","git_url":"git://github.com/KKoukiou/cockpit.git","ssh_url":"git@github.com:KKoukiou/cockpit.git","clone_url":"https://github.com/KKoukiou/cockpit.git","svn_url":"https://github.com/KKoukiou/cockpit","homepage":"http://www.cockpit-project.org/","size":59005,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"46f55f52c9461fb8ddfe5e5517b5b43ee9b77519","user":{"login":"cockpit-project","id":5765104,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NjUxMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5765104?v=4","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0OTIxNg==","name":"cockpit","full_name":"cockpit-project/cockpit","private":false,"owner":{"login":"cockpit-project","id":5765104,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NjUxMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5765104?v=4","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cockpit-project/cockpit","description":"There's code a goin' on","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/cockpit-project/cockpit/deployments","created_at":"2013-11-01T17:36:46Z","updated_at":"2018-11-22T13:58:57Z","pushed_at":"2018-11-22T14:35:58Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":59090,"stargazers_count":3517,"watchers_count":3517,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":460,"mirror_url":null,"archived":false,"open_issues_count":668,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":460,"open_issues":668,"watchers":3517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10631"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/10631"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/10631"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/10631/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10631/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10631/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/2d61da32abb89edbb189588bed7a6f50380cdfb3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KKoukiou"}}