{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/adorsys/document-scanner-ios/pulls/12","id":222885487,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyODg1NDg3","html_url":"https://github.com/adorsys/document-scanner-ios/pull/12","diff_url":"https://github.com/adorsys/document-scanner-ios/pull/12.diff","patch_url":"https://github.com/adorsys/document-scanner-ios/pull/12.patch","issue_url":"https://api.github.com/repos/adorsys/document-scanner-ios/issues/12","number":12,"state":"closed","locked":false,"title":"Fix Carthage","user":{"login":"xaverlohmueller","id":16212751,"node_id":"MDQ6VXNlcjE2MjEyNzUx","avatar_url":"https://avatars2.githubusercontent.com/u/16212751?v=4","gravatar_id":"","url":"https://api.github.com/users/xaverlohmueller","html_url":"https://github.com/xaverlohmueller","followers_url":"https://api.github.com/users/xaverlohmueller/followers","following_url":"https://api.github.com/users/xaverlohmueller/following{/other_user}","gists_url":"https://api.github.com/users/xaverlohmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/xaverlohmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xaverlohmueller/subscriptions","organizations_url":"https://api.github.com/users/xaverlohmueller/orgs","repos_url":"https://api.github.com/users/xaverlohmueller/repos","events_url":"https://api.github.com/users/xaverlohmueller/events{/privacy}","received_events_url":"https://api.github.com/users/xaverlohmueller/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nI added installation instructions for Carthage users.\r\n\r\nChecking this, I noticed that currently v1.0.3 crashes due to the resource bundle handling when installed with Carthage.\r\n\r\nI read up on the specifications of .podspec files and realized that `s.resource_bundles` is the wrong abstraction for including asset catalogs: `s.resources` is a better fit for our use case.\r\n\r\nTo debug this, I added a trivial test case. Instead of deleting it afterwards, I kept it to lay the groundwork for further testing.\r\nThe test case now runs every time `pod lib lint` is executed (which is part of our Travis checks).","created_at":"2018-10-15T12:19:50Z","updated_at":"2018-10-15T12:55:32Z","closed_at":"2018-10-15T12:55:32Z","merged_at":"2018-10-15T12:55:32Z","merge_commit_sha":"f160026bf8bad32811255865b74d7a1721947f0e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adorsys/document-scanner-ios/pulls/12/commits","review_comments_url":"https://api.github.com/repos/adorsys/document-scanner-ios/pulls/12/comments","review_comment_url":"https://api.github.com/repos/adorsys/document-scanner-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adorsys/document-scanner-ios/issues/12/comments","statuses_url":"https://api.github.com/repos/adorsys/document-scanner-ios/statuses/28a06377ba6eda4da2ad348fbbc6c0d001da5724","head":{"label":"adorsys:carthage-install-instructions","ref":"carthage-install-instructions","sha":"28a06377ba6eda4da2ad348fbbc6c0d001da5724","user":{"login":"adorsys","id":1760904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjA5MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1760904?v=4","gravatar_id":"","url":"https://api.github.com/users/adorsys","html_url":"https://github.com/adorsys","followers_url":"https://api.github.com/users/adorsys/followers","following_url":"https://api.github.com/users/adorsys/following{/other_user}","gists_url":"https://api.github.com/users/adorsys/gists{/gist_id}","starred_url":"https://api.github.com/users/adorsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adorsys/subscriptions","organizations_url":"https://api.github.com/users/adorsys/orgs","repos_url":"https://api.github.com/users/adorsys/repos","events_url":"https://api.github.com/users/adorsys/events{/privacy}","received_events_url":"https://api.github.com/users/adorsys/received_events","type":"Organization","site_admin":false},"repo":{"id":131003630,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwMDM2MzA=","name":"document-scanner-ios","full_name":"adorsys/document-scanner-ios","private":false,"owner":{"login":"adorsys","id":1760904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjA5MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1760904?v=4","gravatar_id":"","url":"https://api.github.com/users/adorsys","html_url":"https://github.com/adorsys","followers_url":"https://api.github.com/users/adorsys/followers","following_url":"https://api.github.com/users/adorsys/following{/other_user}","gists_url":"https://api.github.com/users/adorsys/gists{/gist_id}","starred_url":"https://api.github.com/users/adorsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adorsys/subscriptions","organizations_url":"https://api.github.com/users/adorsys/orgs","repos_url":"https://api.github.com/users/adorsys/repos","events_url":"https://api.github.com/users/adorsys/events{/privacy}","received_events_url":"https://api.github.com/users/adorsys/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/adorsys/document-scanner-ios","description":"A library with a ready to use view controller for document scanning","fork":false,"url":"https://api.github.com/repos/adorsys/document-scanner-ios","forks_url":"https://api.github.com/repos/adorsys/document-scanner-ios/forks","keys_url":"https://api.github.com/repos/adorsys/document-scanner-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adorsys/document-scanner-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adorsys/document-scanner-ios/teams","hooks_url":"https://api.github.com/repos/adorsys/document-scanner-ios/hooks","issue_events_url":"https://api.github.com/repos/adorsys/document-scanner-ios/issues/events{/number}","events_url":"https://api.github.com/repos/adorsys/document-scanner-ios/events","assignees_url":"https://api.github.com/repos/adorsys/document-scanner-ios/assignees{/user}","branches_url":"https://api.github.com/repos/adorsys/document-scanner-ios/branches{/branch}","tags_url":"https://api.github.com/repos/adorsys/document-scanner-ios/tags","blobs_url":"https://api.github.com/repos/adorsys/document-scanner-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adorsys/document-scanner-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adorsys/document-scanner-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/adorsys/document-scanner-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adorsys/document-scanner-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/adorsys/document-scanner-ios/languages","stargazers_url":"https://api.github.com/repos/adorsys/document-scanner-ios/stargazers","contributors_url":"https://api.github.com/repos/adorsys/document-scanner-ios/contributors","subscribers_url":"https://api.github.com/repos/adorsys/document-scanner-ios/subscribers","subscription_url":"https://api.github.com/repos/adorsys/document-scanner-ios/subscription","commits_url":"https://api.github.com/repos/adorsys/document-scanner-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/adorsys/document-scanner-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/adorsys/document-scanner-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/adorsys/document-scanner-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/adorsys/document-scanner-ios/contents/{+path}","compare_url":"https://api.github.com/repos/adorsys/document-scanner-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adorsys/document-scanner-ios/merges","archive_url":"https://api.github.com/repos/adorsys/document-scanner-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adorsys/document-scanner-ios/downloads","issues_url":"https://api.github.com/repos/adorsys/document-scanner-ios/issues{/number}","pulls_url":"https://api.github.com/repos/adorsys/document-scanner-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/adorsys/document-scanner-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/adorsys/document-scanner-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adorsys/document-scanner-ios/labels{/name}","releases_url":"https://api.github.com/repos/adorsys/document-scanner-ios/releases{/id}","deployments_url":"https://api.github.com/repos/adorsys/document-scanner-ios/deployments","created_at":"2018-04-25T12:34:20Z","updated_at":"2018-10-15T12:25:03Z","pushed_at":"2018-10-15T12:55:32Z","git_url":"git://github.com/adorsys/document-scanner-ios.git","ssh_url":"git@github.com:adorsys/document-scanner-ios.git","clone_url":"https://github.com/adorsys/document-scanner-ios.git","svn_url":"https://github.com/adorsys/document-scanner-ios","homepage":"","size":1973,"stargazers_count":4,"watchers_count":4,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"adorsys:master","ref":"master","sha":"cbc88a961cd8f744731c473f8e1d7ec7a419574d","user":{"login":"adorsys","id":1760904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjA5MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1760904?v=4","gravatar_id":"","url":"https://api.github.com/users/adorsys","html_url":"https://github.com/adorsys","followers_url":"https://api.github.com/users/adorsys/followers","following_url":"https://api.github.com/users/adorsys/following{/other_user}","gists_url":"https://api.github.com/users/adorsys/gists{/gist_id}","starred_url":"https://api.github.com/users/adorsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adorsys/subscriptions","organizations_url":"https://api.github.com/users/adorsys/orgs","repos_url":"https://api.github.com/users/adorsys/repos","events_url":"https://api.github.com/users/adorsys/events{/privacy}","received_events_url":"https://api.github.com/users/adorsys/received_events","type":"Organization","site_admin":false},"repo":{"id":131003630,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwMDM2MzA=","name":"document-scanner-ios","full_name":"adorsys/document-scanner-ios","private":false,"owner":{"login":"adorsys","id":1760904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjA5MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1760904?v=4","gravatar_id":"","url":"https://api.github.com/users/adorsys","html_url":"https://github.com/adorsys","followers_url":"https://api.github.com/users/adorsys/followers","following_url":"https://api.github.com/users/adorsys/following{/other_user}","gists_url":"https://api.github.com/users/adorsys/gists{/gist_id}","starred_url":"https://api.github.com/users/adorsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adorsys/subscriptions","organizations_url":"https://api.github.com/users/adorsys/orgs","repos_url":"https://api.github.com/users/adorsys/repos","events_url":"https://api.github.com/users/adorsys/events{/privacy}","received_events_url":"https://api.github.com/users/adorsys/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/adorsys/document-scanner-ios","description":"A library with a ready to use view controller for document scanning","fork":false,"url":"https://api.github.com/repos/adorsys/document-scanner-ios","forks_url":"https://api.github.com/repos/adorsys/document-scanner-ios/forks","keys_url":"https://api.github.com/repos/adorsys/document-scanner-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adorsys/document-scanner-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adorsys/document-scanner-ios/teams","hooks_url":"https://api.github.com/repos/adorsys/document-scanner-ios/hooks","issue_events_url":"https://api.github.com/repos/adorsys/document-scanner-ios/issues/events{/number}","events_url":"https://api.github.com/repos/adorsys/document-scanner-ios/events","assignees_url":"https://api.github.com/repos/adorsys/document-scanner-ios/assignees{/user}","branches_url":"https://api.github.com/repos/adorsys/document-scanner-ios/branches{/branch}","tags_url":"https://api.github.com/repos/adorsys/document-scanner-ios/tags","blobs_url":"https://api.github.com/repos/adorsys/document-scanner-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adorsys/document-scanner-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adorsys/document-scanner-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/adorsys/document-scanner-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adorsys/document-scanner-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/adorsys/document-scanner-ios/languages","stargazers_url":"https://api.github.com/repos/adorsys/document-scanner-ios/stargazers","contributors_url":"https://api.github.com/repos/adorsys/document-scanner-ios/contributors","subscribers_url":"https://api.github.com/repos/adorsys/document-scanner-ios/subscribers","subscription_url":"https://api.github.com/repos/adorsys/document-scanner-ios/subscription","commits_url":"https://api.github.com/repos/adorsys/document-scanner-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/adorsys/document-scanner-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/adorsys/document-scanner-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/adorsys/document-scanner-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/adorsys/document-scanner-ios/contents/{+path}","compare_url":"https://api.github.com/repos/adorsys/document-scanner-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adorsys/document-scanner-ios/merges","archive_url":"https://api.github.com/repos/adorsys/document-scanner-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adorsys/document-scanner-ios/downloads","issues_url":"https://api.github.com/repos/adorsys/document-scanner-ios/issues{/number}","pulls_url":"https://api.github.com/repos/adorsys/document-scanner-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/adorsys/document-scanner-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/adorsys/document-scanner-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adorsys/document-scanner-ios/labels{/name}","releases_url":"https://api.github.com/repos/adorsys/document-scanner-ios/releases{/id}","deployments_url":"https://api.github.com/repos/adorsys/document-scanner-ios/deployments","created_at":"2018-04-25T12:34:20Z","updated_at":"2018-10-15T12:25:03Z","pushed_at":"2018-10-15T12:55:32Z","git_url":"git://github.com/adorsys/document-scanner-ios.git","ssh_url":"git@github.com:adorsys/document-scanner-ios.git","clone_url":"https://github.com/adorsys/document-scanner-ios.git","svn_url":"https://github.com/adorsys/document-scanner-ios","homepage":"","size":1973,"stargazers_count":4,"watchers_count":4,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adorsys/document-scanner-ios/pulls/12"},"html":{"href":"https://github.com/adorsys/document-scanner-ios/pull/12"},"issue":{"href":"https://api.github.com/repos/adorsys/document-scanner-ios/issues/12"},"comments":{"href":"https://api.github.com/repos/adorsys/document-scanner-ios/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/adorsys/document-scanner-ios/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/adorsys/document-scanner-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adorsys/document-scanner-ios/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/adorsys/document-scanner-ios/statuses/28a06377ba6eda4da2ad348fbbc6c0d001da5724"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"fbernutz","id":26111180,"node_id":"MDQ6VXNlcjI2MTExMTgw","avatar_url":"https://avatars2.githubusercontent.com/u/26111180?v=4","gravatar_id":"","url":"https://api.github.com/users/fbernutz","html_url":"https://github.com/fbernutz","followers_url":"https://api.github.com/users/fbernutz/followers","following_url":"https://api.github.com/users/fbernutz/following{/other_user}","gists_url":"https://api.github.com/users/fbernutz/gists{/gist_id}","starred_url":"https://api.github.com/users/fbernutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbernutz/subscriptions","organizations_url":"https://api.github.com/users/fbernutz/orgs","repos_url":"https://api.github.com/users/fbernutz/repos","events_url":"https://api.github.com/users/fbernutz/events{/privacy}","received_events_url":"https://api.github.com/users/fbernutz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":83,"deletions":24,"changed_files":8}}
{"actor":{"display_login":"fbernutz"}}