{"action":"created","comment":{"url":"https://api.github.com/repos/ant-design/ant-design/pulls/comments/210468383","pull_request_review_id":146688834,"id":210468383,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDQ2ODM4Mw==","diff_hunk":"@@ -37,14 +38,30 @@ class Tag extends React.Component<TagProps, TagState> {\n     closable: false,\n   };\n \n-  static getDerivedStateFromProps(nextProps: TagProps) {\n-    return  ('visible' in nextProps) ? { visible: nextProps.visible } : null;\n+  static getDerivedStateFromProps(nextProps: TagProps, state: TagState) {\n+    if ('visible' in nextProps) {\n+      let newState: Partial<TagState> = {\n+        visible: nextProps.visible,\n+        mounted: true,\n+      };\n+\n+      if (!state.mounted) {","path":"components/tag/index.tsx","position":21,"original_position":21,"commit_id":"aaea7aa788b1a85bee989cb5bd6f602eabbbe05c","original_commit_id":"aaea7aa788b1a85bee989cb5bd6f602eabbbe05c","user":{"login":"picodoth","id":1731837,"node_id":"MDQ6VXNlcjE3MzE4Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1731837?v=4","gravatar_id":"","url":"https://api.github.com/users/picodoth","html_url":"https://github.com/picodoth","followers_url":"https://api.github.com/users/picodoth/followers","following_url":"https://api.github.com/users/picodoth/following{/other_user}","gists_url":"https://api.github.com/users/picodoth/gists{/gist_id}","starred_url":"https://api.github.com/users/picodoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picodoth/subscriptions","organizations_url":"https://api.github.com/users/picodoth/orgs","repos_url":"https://api.github.com/users/picodoth/repos","events_url":"https://api.github.com/users/picodoth/events{/privacy}","received_events_url":"https://api.github.com/users/picodoth/received_events","type":"User","site_admin":false},"body":"only set closed state in component mounting phase","created_at":"2018-08-16T03:28:56Z","updated_at":"2018-08-16T03:28:56Z","html_url":"https://github.com/ant-design/ant-design/pull/11761#discussion_r210468383","pull_request_url":"https://api.github.com/repos/ant-design/ant-design/pulls/11761","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/comments/210468383"},"html":{"href":"https://github.com/ant-design/ant-design/pull/11761#discussion_r210468383"},"pull_request":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/11761"}}},"pull_request":{"url":"https://api.github.com/repos/ant-design/ant-design/pulls/11761","id":208736070,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NzM2MDcw","html_url":"https://github.com/ant-design/ant-design/pull/11761","diff_url":"https://github.com/ant-design/ant-design/pull/11761.diff","patch_url":"https://github.com/ant-design/ant-design/pull/11761.patch","issue_url":"https://api.github.com/repos/ant-design/ant-design/issues/11761","number":11761,"state":"open","locked":false,"title":"fix: tags initially hidden, closing #11757","user":{"login":"picodoth","id":1731837,"node_id":"MDQ6VXNlcjE3MzE4Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1731837?v=4","gravatar_id":"","url":"https://api.github.com/users/picodoth","html_url":"https://github.com/picodoth","followers_url":"https://api.github.com/users/picodoth/followers","following_url":"https://api.github.com/users/picodoth/following{/other_user}","gists_url":"https://api.github.com/users/picodoth/gists{/gist_id}","starred_url":"https://api.github.com/users/picodoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picodoth/subscriptions","organizations_url":"https://api.github.com/users/picodoth/orgs","repos_url":"https://api.github.com/users/picodoth/repos","events_url":"https://api.github.com/users/picodoth/events{/privacy}","received_events_url":"https://api.github.com/users/picodoth/received_events","type":"User","site_admin":false},"body":"First of all, thank you for your contribution! :-)\r\n\r\nPlease makes sure that these checkboxes are checked before submitting your PR, thank you!\r\n\r\n* [ ] Make sure that you propose PR to right branch: bugfix for `master`, feature for latest active branch `feature-x.x`.\r\n* [ ] Make sure that you follow antd's [code convention](https://github.com/ant-design/ant-design/wiki/Code-convention-for-antd).\r\n* [ ] Run `npm run lint` and fix those errors before submitting in order to keep consistent code style.\r\n* [ ] Rebase before creating a PR to keep commit history clear.\r\n* [ ] Add some descriptions and refer relative issues for you PR.\r\n\r\nExtra checklist:\r\n\r\n**if** *isBugFix* **:**\r\n\r\n  * [ ] Make sure that you add at least one unit test for the bug which you had fixed.\r\n\r\n**elif** *isNewFeature* **:**\r\n\r\n  * [ ] Update API docs for the component.\r\n  * [ ] Update/Add demo to demonstrate new feature.\r\n  * [ ] Update TypeScript definition for the component.\r\n  * [ ] Add unit tests for the feature.\r\n","created_at":"2018-08-16T03:26:30Z","updated_at":"2018-08-16T03:28:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ce8616b880044d51c633cd9a3074594ef4a6aec","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yesmeck","id":465125,"node_id":"MDQ6VXNlcjQ2NTEyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/465125?v=4","gravatar_id":"","url":"https://api.github.com/users/yesmeck","html_url":"https://github.com/yesmeck","followers_url":"https://api.github.com/users/yesmeck/followers","following_url":"https://api.github.com/users/yesmeck/following{/other_user}","gists_url":"https://api.github.com/users/yesmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/yesmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesmeck/subscriptions","organizations_url":"https://api.github.com/users/yesmeck/orgs","repos_url":"https://api.github.com/users/yesmeck/repos","events_url":"https://api.github.com/users/yesmeck/events{/privacy}","received_events_url":"https://api.github.com/users/yesmeck/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ant-design/ant-design/pulls/11761/commits","review_comments_url":"https://api.github.com/repos/ant-design/ant-design/pulls/11761/comments","review_comment_url":"https://api.github.com/repos/ant-design/ant-design/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ant-design/ant-design/issues/11761/comments","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/aaea7aa788b1a85bee989cb5bd6f602eabbbe05c","head":{"label":"ant-design:issue-11757","ref":"issue-11757","sha":"aaea7aa788b1a85bee989cb5bd6f602eabbbe05c","user":{"login":"ant-design","id":12101536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAxNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"repo":{"id":34526884,"node_id":"MDEwOlJlcG9zaXRvcnkzNDUyNjg4NA==","name":"ant-design","full_name":"ant-design/ant-design","owner":{"login":"ant-design","id":12101536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAxNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ant-design/ant-design","description":"🐜 A UI Design Language","fork":false,"url":"https://api.github.com/repos/ant-design/ant-design","forks_url":"https://api.github.com/repos/ant-design/ant-design/forks","keys_url":"https://api.github.com/repos/ant-design/ant-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ant-design/ant-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ant-design/ant-design/teams","hooks_url":"https://api.github.com/repos/ant-design/ant-design/hooks","issue_events_url":"https://api.github.com/repos/ant-design/ant-design/issues/events{/number}","events_url":"https://api.github.com/repos/ant-design/ant-design/events","assignees_url":"https://api.github.com/repos/ant-design/ant-design/assignees{/user}","branches_url":"https://api.github.com/repos/ant-design/ant-design/branches{/branch}","tags_url":"https://api.github.com/repos/ant-design/ant-design/tags","blobs_url":"https://api.github.com/repos/ant-design/ant-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ant-design/ant-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ant-design/ant-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/ant-design/ant-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/{sha}","languages_url":"https://api.github.com/repos/ant-design/ant-design/languages","stargazers_url":"https://api.github.com/repos/ant-design/ant-design/stargazers","contributors_url":"https://api.github.com/repos/ant-design/ant-design/contributors","subscribers_url":"https://api.github.com/repos/ant-design/ant-design/subscribers","subscription_url":"https://api.github.com/repos/ant-design/ant-design/subscription","commits_url":"https://api.github.com/repos/ant-design/ant-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/ant-design/ant-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/ant-design/ant-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/ant-design/ant-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/ant-design/ant-design/contents/{+path}","compare_url":"https://api.github.com/repos/ant-design/ant-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ant-design/ant-design/merges","archive_url":"https://api.github.com/repos/ant-design/ant-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ant-design/ant-design/downloads","issues_url":"https://api.github.com/repos/ant-design/ant-design/issues{/number}","pulls_url":"https://api.github.com/repos/ant-design/ant-design/pulls{/number}","milestones_url":"https://api.github.com/repos/ant-design/ant-design/milestones{/number}","notifications_url":"https://api.github.com/repos/ant-design/ant-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ant-design/ant-design/labels{/name}","releases_url":"https://api.github.com/repos/ant-design/ant-design/releases{/id}","deployments_url":"https://api.github.com/repos/ant-design/ant-design/deployments","created_at":"2015-04-24T15:37:24Z","updated_at":"2018-08-16T03:18:48Z","pushed_at":"2018-08-16T03:26:31Z","git_url":"git://github.com/ant-design/ant-design.git","ssh_url":"git@github.com:ant-design/ant-design.git","clone_url":"https://github.com/ant-design/ant-design.git","svn_url":"https://github.com/ant-design/ant-design","homepage":"http://ant.design","size":264472,"stargazers_count":32199,"watchers_count":32199,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10281,"mirror_url":null,"archived":false,"open_issues_count":290,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10281,"open_issues":290,"watchers":32199,"default_branch":"master"}},"base":{"label":"ant-design:master","ref":"master","sha":"b126b23b2d2bbf79767df5c0d07f7758093fb5f7","user":{"login":"ant-design","id":12101536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAxNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"repo":{"id":34526884,"node_id":"MDEwOlJlcG9zaXRvcnkzNDUyNjg4NA==","name":"ant-design","full_name":"ant-design/ant-design","owner":{"login":"ant-design","id":12101536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAxNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ant-design/ant-design","description":"🐜 A UI Design Language","fork":false,"url":"https://api.github.com/repos/ant-design/ant-design","forks_url":"https://api.github.com/repos/ant-design/ant-design/forks","keys_url":"https://api.github.com/repos/ant-design/ant-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ant-design/ant-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ant-design/ant-design/teams","hooks_url":"https://api.github.com/repos/ant-design/ant-design/hooks","issue_events_url":"https://api.github.com/repos/ant-design/ant-design/issues/events{/number}","events_url":"https://api.github.com/repos/ant-design/ant-design/events","assignees_url":"https://api.github.com/repos/ant-design/ant-design/assignees{/user}","branches_url":"https://api.github.com/repos/ant-design/ant-design/branches{/branch}","tags_url":"https://api.github.com/repos/ant-design/ant-design/tags","blobs_url":"https://api.github.com/repos/ant-design/ant-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ant-design/ant-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ant-design/ant-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/ant-design/ant-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/{sha}","languages_url":"https://api.github.com/repos/ant-design/ant-design/languages","stargazers_url":"https://api.github.com/repos/ant-design/ant-design/stargazers","contributors_url":"https://api.github.com/repos/ant-design/ant-design/contributors","subscribers_url":"https://api.github.com/repos/ant-design/ant-design/subscribers","subscription_url":"https://api.github.com/repos/ant-design/ant-design/subscription","commits_url":"https://api.github.com/repos/ant-design/ant-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/ant-design/ant-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/ant-design/ant-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/ant-design/ant-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/ant-design/ant-design/contents/{+path}","compare_url":"https://api.github.com/repos/ant-design/ant-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ant-design/ant-design/merges","archive_url":"https://api.github.com/repos/ant-design/ant-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ant-design/ant-design/downloads","issues_url":"https://api.github.com/repos/ant-design/ant-design/issues{/number}","pulls_url":"https://api.github.com/repos/ant-design/ant-design/pulls{/number}","milestones_url":"https://api.github.com/repos/ant-design/ant-design/milestones{/number}","notifications_url":"https://api.github.com/repos/ant-design/ant-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ant-design/ant-design/labels{/name}","releases_url":"https://api.github.com/repos/ant-design/ant-design/releases{/id}","deployments_url":"https://api.github.com/repos/ant-design/ant-design/deployments","created_at":"2015-04-24T15:37:24Z","updated_at":"2018-08-16T03:18:48Z","pushed_at":"2018-08-16T03:26:31Z","git_url":"git://github.com/ant-design/ant-design.git","ssh_url":"git@github.com:ant-design/ant-design.git","clone_url":"https://github.com/ant-design/ant-design.git","svn_url":"https://github.com/ant-design/ant-design","homepage":"http://ant.design","size":264472,"stargazers_count":32199,"watchers_count":32199,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10281,"mirror_url":null,"archived":false,"open_issues_count":290,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10281,"open_issues":290,"watchers":32199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/11761"},"html":{"href":"https://github.com/ant-design/ant-design/pull/11761"},"issue":{"href":"https://api.github.com/repos/ant-design/ant-design/issues/11761"},"comments":{"href":"https://api.github.com/repos/ant-design/ant-design/issues/11761/comments"},"review_comments":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/11761/comments"},"review_comment":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/11761/commits"},"statuses":{"href":"https://api.github.com/repos/ant-design/ant-design/statuses/aaea7aa788b1a85bee989cb5bd6f602eabbbe05c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"picodoth"}}