{"action":"created","comment":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/172358990","pull_request_review_id":101362715,"id":172358990,"diff_hunk":"@@ -723,17 +734,27 @@ namespace {\n                 popup->AddMenuItem(GG::MenuItem(UserString(\"PAUSE\"),            false, false, pause_action));\n             }\n \n-            if (queue_row && queue_row->elem.allowed_imperial_stockpile_use) {\n-                popup->AddMenuItem(GG::MenuItem(UserString(\"DISALLOW_IMPERIAL_PP_STOCKPILE_USE\"), false, false, disallow_stockpile_action));\n-            } else {\n-                popup->AddMenuItem(GG::MenuItem(UserString(\"ALLOW_IMPERIAL_PP_STOCKPILE_USE\"), false, false, allow_stockpile_action));\n+            switch (build_type) {","path":"UI/ProductionWnd.cpp","position":42,"original_position":42,"commit_id":"4c836af6556f5d65111f01f687c2dd93ce6f6f85","original_commit_id":"4c836af6556f5d65111f01f687c2dd93ce6f6f85","user":{"login":"dbenage-cx","id":17205519,"avatar_url":"https://avatars2.githubusercontent.com/u/17205519?v=4","gravatar_id":"","url":"https://api.github.com/users/dbenage-cx","html_url":"https://github.com/dbenage-cx","followers_url":"https://api.github.com/users/dbenage-cx/followers","following_url":"https://api.github.com/users/dbenage-cx/following{/other_user}","gists_url":"https://api.github.com/users/dbenage-cx/gists{/gist_id}","starred_url":"https://api.github.com/users/dbenage-cx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbenage-cx/subscriptions","organizations_url":"https://api.github.com/users/dbenage-cx/orgs","repos_url":"https://api.github.com/users/dbenage-cx/repos","events_url":"https://api.github.com/users/dbenage-cx/events{/privacy}","received_events_url":"https://api.github.com/users/dbenage-cx/received_events","type":"User","site_admin":false},"body":"Since there was a post-merge review: needs to catch other types/default, though it would probably read easier to replace the switch block with `if (build_type != BT_STOCKPILE) {`","created_at":"2018-03-05T23:02:04Z","updated_at":"2018-03-05T23:02:04Z","html_url":"https://github.com/freeorion/freeorion/pull/2023#discussion_r172358990","pull_request_url":"https://api.github.com/repos/freeorion/freeorion/pulls/2023","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/172358990"},"html":{"href":"https://github.com/freeorion/freeorion/pull/2023#discussion_r172358990"},"pull_request":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/2023"}}},"pull_request":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/2023","id":171390689,"html_url":"https://github.com/freeorion/freeorion/pull/2023","diff_url":"https://github.com/freeorion/freeorion/pull/2023.diff","patch_url":"https://github.com/freeorion/freeorion/pull/2023.patch","issue_url":"https://api.github.com/repos/freeorion/freeorion/issues/2023","number":2023,"state":"closed","locked":false,"title":"BT_STOCKPILE","user":{"login":"agrrr3","id":3252041,"avatar_url":"https://avatars3.githubusercontent.com/u/3252041?v=4","gravatar_id":"","url":"https://api.github.com/users/agrrr3","html_url":"https://github.com/agrrr3","followers_url":"https://api.github.com/users/agrrr3/followers","following_url":"https://api.github.com/users/agrrr3/following{/other_user}","gists_url":"https://api.github.com/users/agrrr3/gists{/gist_id}","starred_url":"https://api.github.com/users/agrrr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrrr3/subscriptions","organizations_url":"https://api.github.com/users/agrrr3/orgs","repos_url":"https://api.github.com/users/agrrr3/repos","events_url":"https://api.github.com/users/agrrr3/events{/privacy}","received_events_url":"https://api.github.com/users/agrrr3/received_events","type":"User","site_admin":false},"body":"The aim of this branch to make the [stockpile \"project\" build item](http://www.freeorion.org/forum/viewtopic.php?f=9&t=10892) work.\r\n\r\nState: functional. So \"make it work\" is done\r\n\r\n- stockpiling projects have a quantity and a repetition count\r\n- basic cost of a stockpiling project is 1PP and 1 turn\r\n- stockpiling projects are not allowed to draw from the imperial stockpile and the menu option for enabling is only shown for ships and buildings\r\n- PP spent on a stockpiling project are added to the next turns imperial stockpile\r\n- there is nothing special happening when a stockpiling project is finished\r\n\r\nGeneral next steps:\r\n* Fix issue: encyclopedia entry for stockpiling (not sure what i did wrong, help wanted); probably open a issue after merging\r\n* code review, cleanup, squash, merge (discussion on github)\r\n* playtesting (help wanted)\r\n* maybe refactor build item structure (suggestions welcome)\r\n\r\nFor \"make it right\" - I am not completely happy with having another overloaded version of build item type on so many different levels. Open for suggestions.\r\n","created_at":"2018-02-26T14:32:57Z","updated_at":"2018-03-05T23:02:04Z","closed_at":"2018-03-05T01:08:48Z","merged_at":"2018-03-05T01:08:47Z","merge_commit_sha":"1520438c245476dd6854a07530198deb25352c3c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":194101995,"url":"https://api.github.com/repos/freeorion/freeorion/labels/category:feature","name":"category:feature","color":"5319e7","default":false},{"id":428806784,"url":"https://api.github.com/repos/freeorion/freeorion/labels/component:game%20mechanic","name":"component:game mechanic","color":"d93f0b","default":false},{"id":428892136,"url":"https://api.github.com/repos/freeorion/freeorion/labels/status:merged","name":"status:merged","color":"c5def5","default":false}],"milestone":{"url":"https://api.github.com/repos/freeorion/freeorion/milestones/18","html_url":"https://github.com/freeorion/freeorion/milestone/18","labels_url":"https://api.github.com/repos/freeorion/freeorion/milestones/18/labels","id":2316533,"number":18,"title":"v0.4.8 (mandatory)","description":"Bugs, features and pull requests that *must* be fixed/finalized for the 0.4.8 release. All issues and PRs assigned to this milestone are considered release-blocking.","creator":{"login":"Vezzra","id":10279417,"avatar_url":"https://avatars2.githubusercontent.com/u/10279417?v=4","gravatar_id":"","url":"https://api.github.com/users/Vezzra","html_url":"https://github.com/Vezzra","followers_url":"https://api.github.com/users/Vezzra/followers","following_url":"https://api.github.com/users/Vezzra/following{/other_user}","gists_url":"https://api.github.com/users/Vezzra/gists{/gist_id}","starred_url":"https://api.github.com/users/Vezzra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vezzra/subscriptions","organizations_url":"https://api.github.com/users/Vezzra/orgs","repos_url":"https://api.github.com/users/Vezzra/repos","events_url":"https://api.github.com/users/Vezzra/events{/privacy}","received_events_url":"https://api.github.com/users/Vezzra/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":321,"state":"open","created_at":"2017-02-12T13:01:43Z","updated_at":"2018-03-05T06:55:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/freeorion/freeorion/pulls/2023/commits","review_comments_url":"https://api.github.com/repos/freeorion/freeorion/pulls/2023/comments","review_comment_url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeorion/freeorion/issues/2023/comments","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/4c836af6556f5d65111f01f687c2dd93ce6f6f85","head":{"label":"agrrr3:bt_stockpile","ref":"bt_stockpile","sha":"4c836af6556f5d65111f01f687c2dd93ce6f6f85","user":{"login":"agrrr3","id":3252041,"avatar_url":"https://avatars3.githubusercontent.com/u/3252041?v=4","gravatar_id":"","url":"https://api.github.com/users/agrrr3","html_url":"https://github.com/agrrr3","followers_url":"https://api.github.com/users/agrrr3/followers","following_url":"https://api.github.com/users/agrrr3/following{/other_user}","gists_url":"https://api.github.com/users/agrrr3/gists{/gist_id}","starred_url":"https://api.github.com/users/agrrr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrrr3/subscriptions","organizations_url":"https://api.github.com/users/agrrr3/orgs","repos_url":"https://api.github.com/users/agrrr3/repos","events_url":"https://api.github.com/users/agrrr3/events{/privacy}","received_events_url":"https://api.github.com/users/agrrr3/received_events","type":"User","site_admin":false},"repo":{"id":65853125,"name":"freeorion","full_name":"agrrr3/freeorion","owner":{"login":"agrrr3","id":3252041,"avatar_url":"https://avatars3.githubusercontent.com/u/3252041?v=4","gravatar_id":"","url":"https://api.github.com/users/agrrr3","html_url":"https://github.com/agrrr3","followers_url":"https://api.github.com/users/agrrr3/followers","following_url":"https://api.github.com/users/agrrr3/following{/other_user}","gists_url":"https://api.github.com/users/agrrr3/gists{/gist_id}","starred_url":"https://api.github.com/users/agrrr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrrr3/subscriptions","organizations_url":"https://api.github.com/users/agrrr3/orgs","repos_url":"https://api.github.com/users/agrrr3/repos","events_url":"https://api.github.com/users/agrrr3/events{/privacy}","received_events_url":"https://api.github.com/users/agrrr3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agrrr3/freeorion","description":"Source code repository of the FreeOrion project.","fork":true,"url":"https://api.github.com/repos/agrrr3/freeorion","forks_url":"https://api.github.com/repos/agrrr3/freeorion/forks","keys_url":"https://api.github.com/repos/agrrr3/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agrrr3/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agrrr3/freeorion/teams","hooks_url":"https://api.github.com/repos/agrrr3/freeorion/hooks","issue_events_url":"https://api.github.com/repos/agrrr3/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/agrrr3/freeorion/events","assignees_url":"https://api.github.com/repos/agrrr3/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/agrrr3/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/agrrr3/freeorion/tags","blobs_url":"https://api.github.com/repos/agrrr3/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agrrr3/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agrrr3/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/agrrr3/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agrrr3/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/agrrr3/freeorion/languages","stargazers_url":"https://api.github.com/repos/agrrr3/freeorion/stargazers","contributors_url":"https://api.github.com/repos/agrrr3/freeorion/contributors","subscribers_url":"https://api.github.com/repos/agrrr3/freeorion/subscribers","subscription_url":"https://api.github.com/repos/agrrr3/freeorion/subscription","commits_url":"https://api.github.com/repos/agrrr3/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/agrrr3/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/agrrr3/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/agrrr3/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/agrrr3/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/agrrr3/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agrrr3/freeorion/merges","archive_url":"https://api.github.com/repos/agrrr3/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agrrr3/freeorion/downloads","issues_url":"https://api.github.com/repos/agrrr3/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/agrrr3/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/agrrr3/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/agrrr3/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agrrr3/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/agrrr3/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/agrrr3/freeorion/deployments","created_at":"2016-08-16T20:56:32Z","updated_at":"2016-08-16T20:56:39Z","pushed_at":"2018-03-03T23:09:10Z","git_url":"git://github.com/agrrr3/freeorion.git","ssh_url":"git@github.com:agrrr3/freeorion.git","clone_url":"https://github.com/agrrr3/freeorion.git","svn_url":"https://github.com/agrrr3/freeorion","homepage":"http://www.freeorion.org/","size":546264,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeorion:master","ref":"master","sha":"7adcbdd06c991230a456be5d2abb9f6039f0f102","user":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars1.githubusercontent.com/u/1025550?v=4","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"repo":{"id":33066062,"name":"freeorion","full_name":"freeorion/freeorion","owner":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars1.githubusercontent.com/u/1025550?v=4","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeorion/freeorion","description":"Source code repository of the FreeOrion project.","fork":false,"url":"https://api.github.com/repos/freeorion/freeorion","forks_url":"https://api.github.com/repos/freeorion/freeorion/forks","keys_url":"https://api.github.com/repos/freeorion/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeorion/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeorion/freeorion/teams","hooks_url":"https://api.github.com/repos/freeorion/freeorion/hooks","issue_events_url":"https://api.github.com/repos/freeorion/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/freeorion/freeorion/events","assignees_url":"https://api.github.com/repos/freeorion/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/freeorion/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/freeorion/freeorion/tags","blobs_url":"https://api.github.com/repos/freeorion/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeorion/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeorion/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeorion/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/freeorion/freeorion/languages","stargazers_url":"https://api.github.com/repos/freeorion/freeorion/stargazers","contributors_url":"https://api.github.com/repos/freeorion/freeorion/contributors","subscribers_url":"https://api.github.com/repos/freeorion/freeorion/subscribers","subscription_url":"https://api.github.com/repos/freeorion/freeorion/subscription","commits_url":"https://api.github.com/repos/freeorion/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeorion/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeorion/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeorion/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeorion/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/freeorion/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeorion/freeorion/merges","archive_url":"https://api.github.com/repos/freeorion/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeorion/freeorion/downloads","issues_url":"https://api.github.com/repos/freeorion/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/freeorion/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/freeorion/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/freeorion/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeorion/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/freeorion/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/freeorion/freeorion/deployments","created_at":"2015-03-29T08:22:20Z","updated_at":"2018-03-05T22:29:34Z","pushed_at":"2018-03-05T22:43:53Z","git_url":"git://github.com/freeorion/freeorion.git","ssh_url":"git@github.com:freeorion/freeorion.git","clone_url":"https://github.com/freeorion/freeorion.git","svn_url":"https://github.com/freeorion/freeorion","homepage":"http://www.freeorion.org/","size":546185,"stargazers_count":273,"watchers_count":273,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":185,"license":null,"forks":94,"open_issues":185,"watchers":273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/2023"},"html":{"href":"https://github.com/freeorion/freeorion/pull/2023"},"issue":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/2023"},"comments":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/2023/comments"},"review_comments":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/2023/comments"},"review_comment":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/2023/commits"},"statuses":{"href":"https://api.github.com/repos/freeorion/freeorion/statuses/4c836af6556f5d65111f01f687c2dd93ce6f6f85"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dbenage-cx"}}