{"action":"created","issue":{"url":"https://api.github.com/repos/teusink/Home-Security-by-Pi/issues/33","repository_url":"https://api.github.com/repos/teusink/Home-Security-by-Pi","labels_url":"https://api.github.com/repos/teusink/Home-Security-by-Pi/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/teusink/Home-Security-by-Pi/issues/33/comments","events_url":"https://api.github.com/repos/teusink/Home-Security-by-Pi/issues/33/events","html_url":"https://github.com/teusink/Home-Security-by-Pi/issues/33","id":300682745,"number":33,"title":"Documetation Improvements","user":{"login":"thexmanxyz","id":17965908,"avatar_url":"https://avatars2.githubusercontent.com/u/17965908?v=4","gravatar_id":"","url":"https://api.github.com/users/thexmanxyz","html_url":"https://github.com/thexmanxyz","followers_url":"https://api.github.com/users/thexmanxyz/followers","following_url":"https://api.github.com/users/thexmanxyz/following{/other_user}","gists_url":"https://api.github.com/users/thexmanxyz/gists{/gist_id}","starred_url":"https://api.github.com/users/thexmanxyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thexmanxyz/subscriptions","organizations_url":"https://api.github.com/users/thexmanxyz/orgs","repos_url":"https://api.github.com/users/thexmanxyz/repos","events_url":"https://api.github.com/users/thexmanxyz/events{/privacy}","received_events_url":"https://api.github.com/users/thexmanxyz/received_events","type":"User","site_admin":false},"labels":[{"id":599843762,"url":"https://api.github.com/repos/teusink/Home-Security-by-Pi/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"teusink","id":3344108,"avatar_url":"https://avatars2.githubusercontent.com/u/3344108?v=4","gravatar_id":"","url":"https://api.github.com/users/teusink","html_url":"https://github.com/teusink","followers_url":"https://api.github.com/users/teusink/followers","following_url":"https://api.github.com/users/teusink/following{/other_user}","gists_url":"https://api.github.com/users/teusink/gists{/gist_id}","starred_url":"https://api.github.com/users/teusink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teusink/subscriptions","organizations_url":"https://api.github.com/users/teusink/orgs","repos_url":"https://api.github.com/users/teusink/repos","events_url":"https://api.github.com/users/teusink/events{/privacy}","received_events_url":"https://api.github.com/users/teusink/received_events","type":"User","site_admin":false},"assignees":[{"login":"teusink","id":3344108,"avatar_url":"https://avatars2.githubusercontent.com/u/3344108?v=4","gravatar_id":"","url":"https://api.github.com/users/teusink","html_url":"https://github.com/teusink","followers_url":"https://api.github.com/users/teusink/followers","following_url":"https://api.github.com/users/teusink/following{/other_user}","gists_url":"https://api.github.com/users/teusink/gists{/gist_id}","starred_url":"https://api.github.com/users/teusink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teusink/subscriptions","organizations_url":"https://api.github.com/users/teusink/orgs","repos_url":"https://api.github.com/users/teusink/repos","events_url":"https://api.github.com/users/teusink/events{/privacy}","received_events_url":"https://api.github.com/users/teusink/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2018-02-27T15:44:15Z","updated_at":"2018-02-27T19:32:08Z","closed_at":null,"author_association":"NONE","body":"Hey there,\r\n\r\nfirst of all I have to thank you for your great documentation. Even thought I set up my PI in a similar setup before you created the Githup repo, there were still a lot of interesting and helpful things in your repo and docs which also were very useful for me. Especially the `cron`, `ssmtp` and maintance steps.\r\n\r\nHowever I noticed a few things which do not work, are not up to date anymore or need some sort of rework. \r\n\r\n2-Configuration:\r\n* Pi-hole: https://www.malwaredomainlist.com/hostslist/hosts.txt I'm not sure why but the list is not available / accessible anymore. But however I would remove and skip this step because the Pi-hole team is really into managing the default block lists and I personally would leave the management of the lists to them. It might be just useful to state that lists can be changed and where.\r\n* PiVPN (OpenVPN): `interface=tun0` is not necessary anymore as config for `dnsmasq` so the whole step concerning this can be skipped. The `interface=eth0` is also gone from the default configuration and it works flawlessly without I verified that on my PI ;). \r\n* PiVPN (OpenVPN): There is a duplication in the documentation which is also confusing and misleading. Even before the Pi-hole changes it wasn't necessary to specify `interface=tun0` in `02-addint.conf` and `01-pihole.conf` at one of the files would have been enough. Also `01-pihole.conf` is overriden on updates so not the best place anyway.\r\n\r\n3-Hardening:\r\n- Screenlock protection with xscreensaver: On my setup xscreensaver caused a lot of trouble and I would at least state my findings here. As soon as I installed and configured it it caused a very high load on the PI can't really explain myself but I had to remove it because it was not worth the benefit.\r\n\r\n- E-mail capabilities: I would here also do some modifications because the file `/etc/default/cron` is deprecated and should no be used anymore. I don't know whether this is even necessary because it should be enough to simply set `MAILTO=` only for `root` and the default user e.g. `pi` everything else sound to me a bit of an overload. Because all of the cron jobs within the docs are explicitly done for one of those users. Moreover it would also state here how to exclude the cron mail notification for certain cron tasks because this is necessary if you have some sort of very frequent job which would result in an high amount of emails send to the admin.\r\n\r\n- E-mail capabilities: Secondly I would leave beside the `crontab -e` command a little note that it might be necessary to change the `MAILTO=` setting for the `pi` a/o `root` user with `crontab -u pi -e` or `crontab -u root -e` command. This is obvious but would be the right place to state.  \r\n\r\n- E-mail capabilities: Last but not least I would leave a note that the `/etc/ssmtp/ssmtp.conf` permissions have to be checked carefully because it contains the credentials for the mail login so it should be in group `mail` and owned by user `root` under permissions `0640`.\r\n\r\nPS.: This is just a draft I will change that one if I have read everything. I already forked the repo and will prepare a PR so you don't have to worry on modifications right now."},"comment":{"url":"https://api.github.com/repos/teusink/Home-Security-by-Pi/issues/comments/368998200","html_url":"https://github.com/teusink/Home-Security-by-Pi/issues/33#issuecomment-368998200","issue_url":"https://api.github.com/repos/teusink/Home-Security-by-Pi/issues/33","id":368998200,"user":{"login":"teusink","id":3344108,"avatar_url":"https://avatars2.githubusercontent.com/u/3344108?v=4","gravatar_id":"","url":"https://api.github.com/users/teusink","html_url":"https://github.com/teusink","followers_url":"https://api.github.com/users/teusink/followers","following_url":"https://api.github.com/users/teusink/following{/other_user}","gists_url":"https://api.github.com/users/teusink/gists{/gist_id}","starred_url":"https://api.github.com/users/teusink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teusink/subscriptions","organizations_url":"https://api.github.com/users/teusink/orgs","repos_url":"https://api.github.com/users/teusink/repos","events_url":"https://api.github.com/users/teusink/events{/privacy}","received_events_url":"https://api.github.com/users/teusink/received_events","type":"User","site_admin":false},"created_at":"2018-02-27T19:32:08Z","updated_at":"2018-02-27T19:32:08Z","author_association":"OWNER","body":"Please keep me posted on further findings! And please say when ready, I'll merge the suggestions. Thanks!"}}
{"actor":{"display_login":"teusink"}}