{"action":"created","issue":{"url":"https://api.github.com/repos/radare/radare2/issues/12063","repository_url":"https://api.github.com/repos/radare/radare2","labels_url":"https://api.github.com/repos/radare/radare2/issues/12063/labels{/name}","comments_url":"https://api.github.com/repos/radare/radare2/issues/12063/comments","events_url":"https://api.github.com/repos/radare/radare2/issues/12063/events","html_url":"https://github.com/radare/radare2/pull/12063","id":377601953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTA2NTUz","number":12063,"title":"Use ht to query strings for the cfstrings ##bin","user":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/radare/radare2/milestones/33","html_url":"https://github.com/radare/radare2/milestone/33","labels_url":"https://api.github.com/repos/radare/radare2/milestones/33/labels","id":3611763,"node_id":"MDk6TWlsZXN0b25lMzYxMTc2Mw==","number":33,"title":"3.1.0","description":"","creator":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"open_issues":76,"closed_issues":59,"state":"open","created_at":"2018-08-31T00:20:51Z","updated_at":"2018-11-07T22:57:25Z","due_on":"2018-11-24T08:00:00Z","closed_at":null},"comments":5,"created_at":"2018-11-05T22:03:03Z","updated_at":"2018-11-07T23:15:12Z","closed_at":"2018-11-07T22:57:25Z","author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/12063","html_url":"https://github.com/radare/radare2/pull/12063","diff_url":"https://github.com/radare/radare2/pull/12063.diff","patch_url":"https://github.com/radare/radare2/pull/12063.patch"},"body":"0m47s vs 4m56s"},"comment":{"url":"https://api.github.com/repos/radare/radare2/issues/comments/436812866","html_url":"https://github.com/radare/radare2/pull/12063#issuecomment-436812866","issue_url":"https://api.github.com/repos/radare/radare2/issues/12063","id":436812866,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjgxMjg2Ng==","user":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T23:15:12Z","updated_at":"2018-11-07T23:15:12Z","author_association":"OWNER","body":"I think this kind of issues are related to thw problwm of strings not working in fat binaries. I have opened an issue with a reproducer. If i change this to true there are 28 XX\n\n> On 7 Nov 2018, at 23:53, Riccardo Schirone <notifications@github.com> wrote:\n> \n> @ret2libc commented on this pull request.\n> \n> In libr/bin/bfile.c:\n> \n> > @@ -82,6 +91,11 @@ static int string_scan_range(RList *list, RBinFile *bf, int min,\n>  \t\tfree (buf);\n>  \t\treturn -1;\n>  \t}\n> +\tRBinSection *s = r_bin_get_section_at (bf->o, from, false);\n> But you are using s->vaddr few lines below this...\n> \n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n"}}
{"actor":{"display_login":"radare"}}