{"action":"created","issue":{"url":"https://api.github.com/repos/AlexPikalov/cdrs/issues/202","repository_url":"https://api.github.com/repos/AlexPikalov/cdrs","labels_url":"https://api.github.com/repos/AlexPikalov/cdrs/issues/202/labels{/name}","comments_url":"https://api.github.com/repos/AlexPikalov/cdrs/issues/202/comments","events_url":"https://api.github.com/repos/AlexPikalov/cdrs/issues/202/events","html_url":"https://github.com/AlexPikalov/cdrs/pull/202","id":295320157,"number":202,"title":"Use a RefCell to provide external immutability for Session","user":{"login":"bfrog","id":135839,"avatar_url":"https://avatars0.githubusercontent.com/u/135839?v=4","gravatar_id":"","url":"https://api.github.com/users/bfrog","html_url":"https://github.com/bfrog","followers_url":"https://api.github.com/users/bfrog/followers","following_url":"https://api.github.com/users/bfrog/following{/other_user}","gists_url":"https://api.github.com/users/bfrog/gists{/gist_id}","starred_url":"https://api.github.com/users/bfrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfrog/subscriptions","organizations_url":"https://api.github.com/users/bfrog/orgs","repos_url":"https://api.github.com/users/bfrog/repos","events_url":"https://api.github.com/users/bfrog/events{/privacy}","received_events_url":"https://api.github.com/users/bfrog/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-07T22:41:50Z","updated_at":"2018-02-12T19:16:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/AlexPikalov/cdrs/pulls/202","html_url":"https://github.com/AlexPikalov/cdrs/pull/202","diff_url":"https://github.com/AlexPikalov/cdrs/pull/202.diff","patch_url":"https://github.com/AlexPikalov/cdrs/pull/202.patch"},"body":"As the title says this renames Session to InternalSession, then provides a RefCell wrapper for Session that allows for external mutability. This allows, much like the postgres crate, an immutable shared reference to be used by crate users.\r\n\r\nFor comparison:\r\nhttps://github.com/sfackler/rust-postgres/blob/master/postgres/src/lib.rs#L951\r\n\r\nThis fixes #201 \r\n\r\nNotably when running tests or compiling code rustc will warn about not needing mut anymore, but no breaking changes are required for this!"},"comment":{"url":"https://api.github.com/repos/AlexPikalov/cdrs/issues/comments/365031123","html_url":"https://github.com/AlexPikalov/cdrs/pull/202#issuecomment-365031123","issue_url":"https://api.github.com/repos/AlexPikalov/cdrs/issues/202","id":365031123,"user":{"login":"AlexPikalov","id":2776286,"avatar_url":"https://avatars1.githubusercontent.com/u/2776286?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexPikalov","html_url":"https://github.com/AlexPikalov","followers_url":"https://api.github.com/users/AlexPikalov/followers","following_url":"https://api.github.com/users/AlexPikalov/following{/other_user}","gists_url":"https://api.github.com/users/AlexPikalov/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexPikalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexPikalov/subscriptions","organizations_url":"https://api.github.com/users/AlexPikalov/orgs","repos_url":"https://api.github.com/users/AlexPikalov/repos","events_url":"https://api.github.com/users/AlexPikalov/events{/privacy}","received_events_url":"https://api.github.com/users/AlexPikalov/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T19:16:06Z","updated_at":"2018-02-12T19:16:06Z","author_association":"OWNER","body":"@bfrog Perfect! I'm going include this enhancement into next release which will occur this weekend. \r\nThank you."}}
{"actor":{"display_login":"AlexPikalov"}}