{"action":"closed","number":11745,"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/11745","id":186769384,"html_url":"https://github.com/neo4j/neo4j/pull/11745","diff_url":"https://github.com/neo4j/neo4j/pull/11745.diff","patch_url":"https://github.com/neo4j/neo4j/pull/11745.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/11745","number":11745,"state":"closed","locked":false,"title":"Avoid generating consecutive failure messages","user":{"login":"ali-ince","id":24190262,"avatar_url":"https://avatars0.githubusercontent.com/u/24190262?v=4","gravatar_id":"","url":"https://api.github.com/users/ali-ince","html_url":"https://github.com/ali-ince","followers_url":"https://api.github.com/users/ali-ince/followers","following_url":"https://api.github.com/users/ali-ince/following{/other_user}","gists_url":"https://api.github.com/users/ali-ince/gists{/gist_id}","starred_url":"https://api.github.com/users/ali-ince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ali-ince/subscriptions","organizations_url":"https://api.github.com/users/ali-ince/orgs","repos_url":"https://api.github.com/users/ali-ince/repos","events_url":"https://api.github.com/users/ali-ince/events{/privacy}","received_events_url":"https://api.github.com/users/ali-ince/received_events","type":"User","site_admin":false},"body":"Bolt thread pool triggers a `FAILURE` message when there are no available threads to schedule the incoming message. In peak load of thread pool, it is possible that consecutive messages won't be scheduled and `FAILURE` messages be generated for each non-scheduled incoming message. \r\n\r\nIt is a bolt protocol breach to generate `FAILURE` message when the state machine is already in `FAILED` state. Instead, we should respond with `IGNORED` messages until state machine enters back to a healthy state (i.e. by acknowledging failure or reset).\r\n\r\nThis PR fixes the issue by checking whether existing state is `FAILED` and generates response messages (either `FAILED` or `IGNORED`) accordingly.","created_at":"2018-05-08T22:09:25Z","updated_at":"2018-05-21T13:06:41Z","closed_at":"2018-05-21T13:06:41Z","merged_at":"2018-05-21T13:06:41Z","merge_commit_sha":"f691b0744493aff41281c05546b95661fc061fbe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":914551060,"url":"https://api.github.com/repos/neo4j/neo4j/labels/3.4.1","name":"3.4.1","color":"5e88f2","default":false},{"id":207302707,"url":"https://api.github.com/repos/neo4j/neo4j/labels/bolt%20server","name":"bolt server","color":"d4c5f9","default":false},{"id":647068027,"url":"https://api.github.com/repos/neo4j/neo4j/labels/team-drivers","name":"team-drivers","color":"cccccc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11745/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11745/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/11745/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/2eacd171e545f2aaa684c769ba9677bf26aa2708","head":{"label":"ali-ince:3.4.1-fix-consecutive-failure-messages","ref":"3.4.1-fix-consecutive-failure-messages","sha":"2eacd171e545f2aaa684c769ba9677bf26aa2708","user":{"login":"ali-ince","id":24190262,"avatar_url":"https://avatars0.githubusercontent.com/u/24190262?v=4","gravatar_id":"","url":"https://api.github.com/users/ali-ince","html_url":"https://github.com/ali-ince","followers_url":"https://api.github.com/users/ali-ince/followers","following_url":"https://api.github.com/users/ali-ince/following{/other_user}","gists_url":"https://api.github.com/users/ali-ince/gists{/gist_id}","starred_url":"https://api.github.com/users/ali-ince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ali-ince/subscriptions","organizations_url":"https://api.github.com/users/ali-ince/orgs","repos_url":"https://api.github.com/users/ali-ince/repos","events_url":"https://api.github.com/users/ali-ince/events{/privacy}","received_events_url":"https://api.github.com/users/ali-ince/received_events","type":"User","site_admin":false},"repo":{"id":94448277,"name":"neo4j","full_name":"ali-ince/neo4j","owner":{"login":"ali-ince","id":24190262,"avatar_url":"https://avatars0.githubusercontent.com/u/24190262?v=4","gravatar_id":"","url":"https://api.github.com/users/ali-ince","html_url":"https://github.com/ali-ince","followers_url":"https://api.github.com/users/ali-ince/followers","following_url":"https://api.github.com/users/ali-ince/following{/other_user}","gists_url":"https://api.github.com/users/ali-ince/gists{/gist_id}","starred_url":"https://api.github.com/users/ali-ince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ali-ince/subscriptions","organizations_url":"https://api.github.com/users/ali-ince/orgs","repos_url":"https://api.github.com/users/ali-ince/repos","events_url":"https://api.github.com/users/ali-ince/events{/privacy}","received_events_url":"https://api.github.com/users/ali-ince/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ali-ince/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/ali-ince/neo4j","forks_url":"https://api.github.com/repos/ali-ince/neo4j/forks","keys_url":"https://api.github.com/repos/ali-ince/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ali-ince/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ali-ince/neo4j/teams","hooks_url":"https://api.github.com/repos/ali-ince/neo4j/hooks","issue_events_url":"https://api.github.com/repos/ali-ince/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/ali-ince/neo4j/events","assignees_url":"https://api.github.com/repos/ali-ince/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/ali-ince/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/ali-ince/neo4j/tags","blobs_url":"https://api.github.com/repos/ali-ince/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ali-ince/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ali-ince/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/ali-ince/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ali-ince/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/ali-ince/neo4j/languages","stargazers_url":"https://api.github.com/repos/ali-ince/neo4j/stargazers","contributors_url":"https://api.github.com/repos/ali-ince/neo4j/contributors","subscribers_url":"https://api.github.com/repos/ali-ince/neo4j/subscribers","subscription_url":"https://api.github.com/repos/ali-ince/neo4j/subscription","commits_url":"https://api.github.com/repos/ali-ince/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/ali-ince/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/ali-ince/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/ali-ince/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/ali-ince/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/ali-ince/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ali-ince/neo4j/merges","archive_url":"https://api.github.com/repos/ali-ince/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ali-ince/neo4j/downloads","issues_url":"https://api.github.com/repos/ali-ince/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/ali-ince/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/ali-ince/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/ali-ince/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ali-ince/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/ali-ince/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/ali-ince/neo4j/deployments","created_at":"2017-06-15T14:36:31Z","updated_at":"2018-05-21T08:10:20Z","pushed_at":"2018-05-21T08:43:26Z","git_url":"git://github.com/ali-ince/neo4j.git","ssh_url":"git@github.com:ali-ince/neo4j.git","clone_url":"https://github.com/ali-ince/neo4j.git","svn_url":"https://github.com/ali-ince/neo4j","homepage":"http://neo4j.com","size":416124,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.4"}},"base":{"label":"neo4j:3.4","ref":"3.4","sha":"668975ddbce1f3556c2c8257bccbe16692d64b4e","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2018-05-21T12:46:32Z","pushed_at":"2018-05-21T13:06:41Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":415965,"stargazers_count":5075,"watchers_count":5075,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1351,"mirror_url":null,"archived":false,"open_issues_count":355,"license":null,"forks":1351,"open_issues":355,"watchers":5075,"default_branch":"3.5"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11745"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11745"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11745"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11745/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11745/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11745/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/2eacd171e545f2aaa684c769ba9677bf26aa2708"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars2.githubusercontent.com/u/1638145?v=4","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":166,"deletions":29,"changed_files":2}}
{"actor":{"display_login":"lutovich"}}