{"action":"created","comment":{"url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/comments/208770712","pull_request_review_id":144645252,"id":208770712,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODc3MDcxMg==","diff_hunk":"@@ -537,7 +537,7 @@ if(BUILD_CAFFE2 OR BUILD_ATEN)\n     hip_include_directories(${Caffe2_HIP_INCLUDES})\n \n     set(Caffe2_HIP_DEPENDENCY_LIBS\n-      ${rocrand_LIBRARIES} ${hiprand_LIBRARIES} ${PYTORCH_HIP_HCC_LIBRARIES} ${PYTORCH_MIOPEN_LIBRARIES} ${hipblas_LIBRARIES})\n+      ${rocrand_LIBRARIES} ${hiprand_LIBRARIES} ${PYTORCH_HIP_HCC_LIBRARIES} ${PYTORCH_MIOPEN_LIBRARIES})","path":"cmake/Dependencies.cmake","position":5,"original_position":5,"commit_id":"7bad6b3726ce4b6eec5d0f0c229e292d41aa5ab0","original_commit_id":"7bad6b3726ce4b6eec5d0f0c229e292d41aa5ab0","user":{"login":"jithunnair-amd","id":37884920,"node_id":"MDQ6VXNlcjM3ODg0OTIw","avatar_url":"https://avatars1.githubusercontent.com/u/37884920?v=4","gravatar_id":"","url":"https://api.github.com/users/jithunnair-amd","html_url":"https://github.com/jithunnair-amd","followers_url":"https://api.github.com/users/jithunnair-amd/followers","following_url":"https://api.github.com/users/jithunnair-amd/following{/other_user}","gists_url":"https://api.github.com/users/jithunnair-amd/gists{/gist_id}","starred_url":"https://api.github.com/users/jithunnair-amd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jithunnair-amd/subscriptions","organizations_url":"https://api.github.com/users/jithunnair-amd/orgs","repos_url":"https://api.github.com/users/jithunnair-amd/repos","events_url":"https://api.github.com/users/jithunnair-amd/events{/privacy}","received_events_url":"https://api.github.com/users/jithunnair-amd/received_events","type":"User","site_admin":false},"body":"We don't need a `${rocblas_LIBRARIES}` here?","created_at":"2018-08-08T23:53:11Z","updated_at":"2018-08-08T23:57:03Z","html_url":"https://github.com/ROCmSoftwarePlatform/pytorch/pull/109#discussion_r208770712","pull_request_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/109","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/comments/208770712"},"html":{"href":"https://github.com/ROCmSoftwarePlatform/pytorch/pull/109#discussion_r208770712"},"pull_request":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/109","id":207153456,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTUzNDU2","html_url":"https://github.com/ROCmSoftwarePlatform/pytorch/pull/109","diff_url":"https://github.com/ROCmSoftwarePlatform/pytorch/pull/109.diff","patch_url":"https://github.com/ROCmSoftwarePlatform/pytorch/pull/109.patch","issue_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/109","number":109,"state":"open","locked":false,"title":"Replace hipblas API with rocBLAS","user":{"login":"iotamudelta","id":12565466,"node_id":"MDQ6VXNlcjEyNTY1NDY2","avatar_url":"https://avatars2.githubusercontent.com/u/12565466?v=4","gravatar_id":"","url":"https://api.github.com/users/iotamudelta","html_url":"https://github.com/iotamudelta","followers_url":"https://api.github.com/users/iotamudelta/followers","following_url":"https://api.github.com/users/iotamudelta/following{/other_user}","gists_url":"https://api.github.com/users/iotamudelta/gists{/gist_id}","starred_url":"https://api.github.com/users/iotamudelta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotamudelta/subscriptions","organizations_url":"https://api.github.com/users/iotamudelta/orgs","repos_url":"https://api.github.com/users/iotamudelta/repos","events_url":"https://api.github.com/users/iotamudelta/events{/privacy}","received_events_url":"https://api.github.com/users/iotamudelta/received_events","type":"User","site_admin":false},"body":"Requires some minor code changes to support rocBLAS's actual strided_batched API (the batched gemm API in HIP was only a loop over individual rocblas_gemm calls....). Still no fp16 support.\r\n\r\n@petrex and @dagamayank for awareness","created_at":"2018-08-08T22:17:22Z","updated_at":"2018-08-08T23:57:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b340394e7b59f5cb4bbad7435020017bd0e5cdb2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ezyang","id":13564,"node_id":"MDQ6VXNlcjEzNTY0","avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/109/commits","review_comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/109/comments","review_comment_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/109/comments","statuses_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/statuses/7bad6b3726ce4b6eec5d0f0c229e292d41aa5ab0","head":{"label":"iotamudelta:rocblas","ref":"rocblas","sha":"7bad6b3726ce4b6eec5d0f0c229e292d41aa5ab0","user":{"login":"iotamudelta","id":12565466,"node_id":"MDQ6VXNlcjEyNTY1NDY2","avatar_url":"https://avatars2.githubusercontent.com/u/12565466?v=4","gravatar_id":"","url":"https://api.github.com/users/iotamudelta","html_url":"https://github.com/iotamudelta","followers_url":"https://api.github.com/users/iotamudelta/followers","following_url":"https://api.github.com/users/iotamudelta/following{/other_user}","gists_url":"https://api.github.com/users/iotamudelta/gists{/gist_id}","starred_url":"https://api.github.com/users/iotamudelta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotamudelta/subscriptions","organizations_url":"https://api.github.com/users/iotamudelta/orgs","repos_url":"https://api.github.com/users/iotamudelta/repos","events_url":"https://api.github.com/users/iotamudelta/events{/privacy}","received_events_url":"https://api.github.com/users/iotamudelta/received_events","type":"User","site_admin":false},"repo":{"id":136206721,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyMDY3MjE=","name":"pytorch","full_name":"iotamudelta/pytorch","owner":{"login":"iotamudelta","id":12565466,"node_id":"MDQ6VXNlcjEyNTY1NDY2","avatar_url":"https://avatars2.githubusercontent.com/u/12565466?v=4","gravatar_id":"","url":"https://api.github.com/users/iotamudelta","html_url":"https://github.com/iotamudelta","followers_url":"https://api.github.com/users/iotamudelta/followers","following_url":"https://api.github.com/users/iotamudelta/following{/other_user}","gists_url":"https://api.github.com/users/iotamudelta/gists{/gist_id}","starred_url":"https://api.github.com/users/iotamudelta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotamudelta/subscriptions","organizations_url":"https://api.github.com/users/iotamudelta/orgs","repos_url":"https://api.github.com/users/iotamudelta/repos","events_url":"https://api.github.com/users/iotamudelta/events{/privacy}","received_events_url":"https://api.github.com/users/iotamudelta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iotamudelta/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/iotamudelta/pytorch","forks_url":"https://api.github.com/repos/iotamudelta/pytorch/forks","keys_url":"https://api.github.com/repos/iotamudelta/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotamudelta/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotamudelta/pytorch/teams","hooks_url":"https://api.github.com/repos/iotamudelta/pytorch/hooks","issue_events_url":"https://api.github.com/repos/iotamudelta/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/iotamudelta/pytorch/events","assignees_url":"https://api.github.com/repos/iotamudelta/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/iotamudelta/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/iotamudelta/pytorch/tags","blobs_url":"https://api.github.com/repos/iotamudelta/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotamudelta/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotamudelta/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotamudelta/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotamudelta/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/iotamudelta/pytorch/languages","stargazers_url":"https://api.github.com/repos/iotamudelta/pytorch/stargazers","contributors_url":"https://api.github.com/repos/iotamudelta/pytorch/contributors","subscribers_url":"https://api.github.com/repos/iotamudelta/pytorch/subscribers","subscription_url":"https://api.github.com/repos/iotamudelta/pytorch/subscription","commits_url":"https://api.github.com/repos/iotamudelta/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotamudelta/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotamudelta/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotamudelta/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotamudelta/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/iotamudelta/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotamudelta/pytorch/merges","archive_url":"https://api.github.com/repos/iotamudelta/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotamudelta/pytorch/downloads","issues_url":"https://api.github.com/repos/iotamudelta/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/iotamudelta/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/iotamudelta/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/iotamudelta/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotamudelta/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/iotamudelta/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/iotamudelta/pytorch/deployments","created_at":"2018-06-05T16:40:18Z","updated_at":"2018-08-08T21:44:45Z","pushed_at":"2018-08-08T21:45:06Z","git_url":"git://github.com/iotamudelta/pytorch.git","ssh_url":"git@github.com:iotamudelta/pytorch.git","clone_url":"https://github.com/iotamudelta/pytorch.git","svn_url":"https://github.com/iotamudelta/pytorch","homepage":"http://pytorch.org","size":67680,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ROCmSoftwarePlatform:master","ref":"master","sha":"90cbc01e7b5d77155b37035b73400db569a272c2","user":{"login":"ROCmSoftwarePlatform","id":16900697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTAwNjk3","avatar_url":"https://avatars0.githubusercontent.com/u/16900697?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCmSoftwarePlatform","html_url":"https://github.com/ROCmSoftwarePlatform","followers_url":"https://api.github.com/users/ROCmSoftwarePlatform/followers","following_url":"https://api.github.com/users/ROCmSoftwarePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ROCmSoftwarePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCmSoftwarePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCmSoftwarePlatform/subscriptions","organizations_url":"https://api.github.com/users/ROCmSoftwarePlatform/orgs","repos_url":"https://api.github.com/users/ROCmSoftwarePlatform/repos","events_url":"https://api.github.com/users/ROCmSoftwarePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ROCmSoftwarePlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":128132891,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxMzI4OTE=","name":"pytorch","full_name":"ROCmSoftwarePlatform/pytorch","owner":{"login":"ROCmSoftwarePlatform","id":16900697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTAwNjk3","avatar_url":"https://avatars0.githubusercontent.com/u/16900697?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCmSoftwarePlatform","html_url":"https://github.com/ROCmSoftwarePlatform","followers_url":"https://api.github.com/users/ROCmSoftwarePlatform/followers","following_url":"https://api.github.com/users/ROCmSoftwarePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ROCmSoftwarePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCmSoftwarePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCmSoftwarePlatform/subscriptions","organizations_url":"https://api.github.com/users/ROCmSoftwarePlatform/orgs","repos_url":"https://api.github.com/users/ROCmSoftwarePlatform/repos","events_url":"https://api.github.com/users/ROCmSoftwarePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ROCmSoftwarePlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ROCmSoftwarePlatform/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch","forks_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/forks","keys_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/teams","hooks_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/hooks","issue_events_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/events","assignees_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/tags","blobs_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/languages","stargazers_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/stargazers","contributors_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/contributors","subscribers_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/subscribers","subscription_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/subscription","commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/merges","archive_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/downloads","issues_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/deployments","created_at":"2018-04-04T23:08:21Z","updated_at":"2018-08-08T21:36:13Z","pushed_at":"2018-08-08T22:17:23Z","git_url":"git://github.com/ROCmSoftwarePlatform/pytorch.git","ssh_url":"git@github.com:ROCmSoftwarePlatform/pytorch.git","clone_url":"https://github.com/ROCmSoftwarePlatform/pytorch.git","svn_url":"https://github.com/ROCmSoftwarePlatform/pytorch","homepage":"http://pytorch.org","size":68029,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":24,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/109"},"html":{"href":"https://github.com/ROCmSoftwarePlatform/pytorch/pull/109"},"issue":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/109"},"comments":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/statuses/7bad6b3726ce4b6eec5d0f0c229e292d41aa5ab0"}},"author_association":"NONE"}}
{"actor":{"display_login":"jithunnair-amd"}}