{"action":"created","issue":{"url":"https://api.github.com/repos/opensim-org/opensim-core/issues/2059","repository_url":"https://api.github.com/repos/opensim-org/opensim-core","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/2059/labels{/name}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/2059/comments","events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/2059/events","html_url":"https://github.com/opensim-org/opensim-core/pull/2059","id":291401421,"number":2059,"title":"Computing marker RMS uses the number of non-NaN values","user":{"login":"aseth1","id":6494122,"avatar_url":"https://avatars0.githubusercontent.com/u/6494122?v=4","gravatar_id":"","url":"https://api.github.com/users/aseth1","html_url":"https://github.com/aseth1","followers_url":"https://api.github.com/users/aseth1/followers","following_url":"https://api.github.com/users/aseth1/following{/other_user}","gists_url":"https://api.github.com/users/aseth1/gists{/gist_id}","starred_url":"https://api.github.com/users/aseth1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseth1/subscriptions","organizations_url":"https://api.github.com/users/aseth1/orgs","repos_url":"https://api.github.com/users/aseth1/repos","events_url":"https://api.github.com/users/aseth1/events{/privacy}","received_events_url":"https://api.github.com/users/aseth1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-01-24T23:45:43Z","updated_at":"2018-02-05T21:30:29Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2059","html_url":"https://github.com/opensim-org/opensim-core/pull/2059","diff_url":"https://github.com/opensim-org/opensim-core/pull/2059.diff","patch_url":"https://github.com/opensim-org/opensim-core/pull/2059.patch"},"body":"Fixes issue #2058\r\n\r\n### Brief summary of changes\r\nAdded methods to access the marker reference values from the `InverseKinematicsSolver`.\r\nUsing this to check if any reference value is NaN when accounting for it when reporting marker RMS errors. \r\n\r\n### Testing I've completed\r\nAdded conditions to testInverseKinematicsSolver to check that NaN reference values are being returned and correspond to the correct marker.\r\n\r\nThere isn't an explicit test for running the IKTool with with experimental data with NaNs.\r\n\r\n### Looking for feedback on...\r\n @jimmyDunne , @chrisdembia , @apoorvar perhaps you have a model and data handy for me to use as a test case?\r\n\r\n### CHANGELOG.md (choose one)\r\n- no need to update because this a bug fix\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments/363227722","html_url":"https://github.com/opensim-org/opensim-core/pull/2059#issuecomment-363227722","issue_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/2059","id":363227722,"user":{"login":"aseth1","id":6494122,"avatar_url":"https://avatars0.githubusercontent.com/u/6494122?v=4","gravatar_id":"","url":"https://api.github.com/users/aseth1","html_url":"https://github.com/aseth1","followers_url":"https://api.github.com/users/aseth1/followers","following_url":"https://api.github.com/users/aseth1/following{/other_user}","gists_url":"https://api.github.com/users/aseth1/gists{/gist_id}","starred_url":"https://api.github.com/users/aseth1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseth1/subscriptions","organizations_url":"https://api.github.com/users/aseth1/orgs","repos_url":"https://api.github.com/users/aseth1/repos","events_url":"https://api.github.com/users/aseth1/events{/privacy}","received_events_url":"https://api.github.com/users/aseth1/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T21:30:29Z","updated_at":"2018-02-05T21:30:29Z","author_association":"OWNER","body":"@jimmyDunne do you have a trial with NaNs handy? We need to verify that the RMS error reported increases when markers drop out (instead of getting more accurate, which was wrong)."}}
{"actor":{"display_login":"aseth1"}}