{"action":"created","comment":{"url":"https://api.github.com/repos/linagora/james-project/pulls/comments/240961574","pull_request_review_id":184111251,"id":240961574,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDk2MTU3NA==","diff_hunk":"@@ -314,65 +324,96 @@ public MetaDataHoldingEvent(MailboxSession.SessionId sessionId, User user, Mailb\n \n     }\n \n-    abstract class Expunged extends MetaDataHoldingEvent {\n+    class Expunged extends MetaDataHoldingEvent {\n \n         /**\n          *\n          */\n         private static final long serialVersionUID = 1L;\n \n-        public Expunged(MailboxSession.SessionId sessionId, User user, MailboxPath path, MailboxId mailboxId) {\n+        private final Map<MessageUid, MessageMetaData> uids;\n+\n+        public Expunged(MailboxSession.SessionId sessionId, User user, MailboxPath path, MailboxId mailboxId, Map<MessageUid, MessageMetaData> uids) {\n             super(sessionId, user, path, mailboxId);\n+            this.uids = uids;\n+        }\n+\n+        @Override\n+        public List<MessageUid> getUids() {\n+            return ImmutableList.copyOf(uids.keySet());\n         }\n \n         /**\n          * Return the flags which were set for the added message\n          *\n          * @return flags\n+         *\n          */\n         @Override\n-        public abstract MessageMetaData getMetaData(MessageUid uid);\n+        public MessageMetaData getMetaData(MessageUid uid) {\n+            return uids.get(uid);\n+        }\n     }\n \n     /**\n      * A mailbox event related to updated flags\n      */\n-    abstract class FlagsUpdated extends MessageEvent {\n+     class FlagsUpdated extends MessageEvent {\n \n         /**\n          *\n          */","path":"mailbox/api/src/main/java/org/apache/james/mailbox/MailboxListener.java","position":123,"original_position":97,"commit_id":"0bbfb8b4d5ea6f8a5ad19dd5b0b78f5082cf6b2f","original_commit_id":"73879ce935977e7429eee03424742537ce11f3a6","user":{"login":"chibenwa","id":6928740,"node_id":"MDQ6VXNlcjY5Mjg3NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6928740?v=4","gravatar_id":"","url":"https://api.github.com/users/chibenwa","html_url":"https://github.com/chibenwa","followers_url":"https://api.github.com/users/chibenwa/followers","following_url":"https://api.github.com/users/chibenwa/following{/other_user}","gists_url":"https://api.github.com/users/chibenwa/gists{/gist_id}","starred_url":"https://api.github.com/users/chibenwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibenwa/subscriptions","organizations_url":"https://api.github.com/users/chibenwa/orgs","repos_url":"https://api.github.com/users/chibenwa/repos","events_url":"https://api.github.com/users/chibenwa/events{/privacy}","received_events_url":"https://api.github.com/users/chibenwa/received_events","type":"User","site_admin":false},"body":"Can you remove empty comments?","created_at":"2018-12-12T10:39:17Z","updated_at":"2018-12-12T10:39:18Z","html_url":"https://github.com/linagora/james-project/pull/2026#discussion_r240961574","pull_request_url":"https://api.github.com/repos/linagora/james-project/pulls/2026","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments/240961574"},"html":{"href":"https://github.com/linagora/james-project/pull/2026#discussion_r240961574"},"pull_request":{"href":"https://api.github.com/repos/linagora/james-project/pulls/2026"}}},"pull_request":{"url":"https://api.github.com/repos/linagora/james-project/pulls/2026","id":237982830,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3OTgyODMw","html_url":"https://github.com/linagora/james-project/pull/2026","diff_url":"https://github.com/linagora/james-project/pull/2026.diff","patch_url":"https://github.com/linagora/james-project/pull/2026.patch","issue_url":"https://api.github.com/repos/linagora/james-project/issues/2026","number":2026,"state":"open","locked":false,"title":"MAILBOX-358 Get ride of store events","user":{"login":"hoangdat","id":6462404,"node_id":"MDQ6VXNlcjY0NjI0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6462404?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangdat","html_url":"https://github.com/hoangdat","followers_url":"https://api.github.com/users/hoangdat/followers","following_url":"https://api.github.com/users/hoangdat/following{/other_user}","gists_url":"https://api.github.com/users/hoangdat/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangdat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangdat/subscriptions","organizations_url":"https://api.github.com/users/hoangdat/orgs","repos_url":"https://api.github.com/users/hoangdat/repos","events_url":"https://api.github.com/users/hoangdat/events{/privacy}","received_events_url":"https://api.github.com/users/hoangdat/received_events","type":"User","site_admin":false},"body":"- Introduce POJO implementation for MailboxEvent in MailboxListener\r\n\r\n- Remove EventImpl in EventFactory\r\n\r\n- Generating API events in EventFactory \r\n\r\nJira: https://issues.apache.org/jira/projects/MAILBOX/issues/MAILBOX-358","created_at":"2018-12-12T10:22:04Z","updated_at":"2018-12-12T10:39:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d7d5ec3951bc1ccf2a5fa87fe68131de6f5ffc4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/linagora/james-project/milestones/13","html_url":"https://github.com/linagora/james-project/milestone/13","labels_url":"https://api.github.com/repos/linagora/james-project/milestones/13/labels","id":3888170,"node_id":"MDk6TWlsZXN0b25lMzg4ODE3MA==","number":13,"title":"Sprint 2 - Robusta beans","description":"","creator":{"login":"chibenwa","id":6928740,"node_id":"MDQ6VXNlcjY5Mjg3NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6928740?v=4","gravatar_id":"","url":"https://api.github.com/users/chibenwa","html_url":"https://github.com/chibenwa","followers_url":"https://api.github.com/users/chibenwa/followers","following_url":"https://api.github.com/users/chibenwa/following{/other_user}","gists_url":"https://api.github.com/users/chibenwa/gists{/gist_id}","starred_url":"https://api.github.com/users/chibenwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibenwa/subscriptions","organizations_url":"https://api.github.com/users/chibenwa/orgs","repos_url":"https://api.github.com/users/chibenwa/repos","events_url":"https://api.github.com/users/chibenwa/events{/privacy}","received_events_url":"https://api.github.com/users/chibenwa/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2018-12-11T01:29:00Z","updated_at":"2018-12-12T10:36:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/linagora/james-project/pulls/2026/commits","review_comments_url":"https://api.github.com/repos/linagora/james-project/pulls/2026/comments","review_comment_url":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linagora/james-project/issues/2026/comments","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/0bbfb8b4d5ea6f8a5ad19dd5b0b78f5082cf6b2f","head":{"label":"hoangdat:MAILBOX-358-store-event","ref":"MAILBOX-358-store-event","sha":"0bbfb8b4d5ea6f8a5ad19dd5b0b78f5082cf6b2f","user":{"login":"hoangdat","id":6462404,"node_id":"MDQ6VXNlcjY0NjI0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6462404?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangdat","html_url":"https://github.com/hoangdat","followers_url":"https://api.github.com/users/hoangdat/followers","following_url":"https://api.github.com/users/hoangdat/following{/other_user}","gists_url":"https://api.github.com/users/hoangdat/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangdat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangdat/subscriptions","organizations_url":"https://api.github.com/users/hoangdat/orgs","repos_url":"https://api.github.com/users/hoangdat/repos","events_url":"https://api.github.com/users/hoangdat/events{/privacy}","received_events_url":"https://api.github.com/users/hoangdat/received_events","type":"User","site_admin":false},"repo":{"id":155144672,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUxNDQ2NzI=","name":"james-project","full_name":"hoangdat/james-project","private":false,"owner":{"login":"hoangdat","id":6462404,"node_id":"MDQ6VXNlcjY0NjI0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6462404?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangdat","html_url":"https://github.com/hoangdat","followers_url":"https://api.github.com/users/hoangdat/followers","following_url":"https://api.github.com/users/hoangdat/following{/other_user}","gists_url":"https://api.github.com/users/hoangdat/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangdat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangdat/subscriptions","organizations_url":"https://api.github.com/users/hoangdat/orgs","repos_url":"https://api.github.com/users/hoangdat/repos","events_url":"https://api.github.com/users/hoangdat/events{/privacy}","received_events_url":"https://api.github.com/users/hoangdat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hoangdat/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/hoangdat/james-project","forks_url":"https://api.github.com/repos/hoangdat/james-project/forks","keys_url":"https://api.github.com/repos/hoangdat/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoangdat/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoangdat/james-project/teams","hooks_url":"https://api.github.com/repos/hoangdat/james-project/hooks","issue_events_url":"https://api.github.com/repos/hoangdat/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/hoangdat/james-project/events","assignees_url":"https://api.github.com/repos/hoangdat/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/hoangdat/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/hoangdat/james-project/tags","blobs_url":"https://api.github.com/repos/hoangdat/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoangdat/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoangdat/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoangdat/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoangdat/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/hoangdat/james-project/languages","stargazers_url":"https://api.github.com/repos/hoangdat/james-project/stargazers","contributors_url":"https://api.github.com/repos/hoangdat/james-project/contributors","subscribers_url":"https://api.github.com/repos/hoangdat/james-project/subscribers","subscription_url":"https://api.github.com/repos/hoangdat/james-project/subscription","commits_url":"https://api.github.com/repos/hoangdat/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoangdat/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoangdat/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoangdat/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoangdat/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/hoangdat/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoangdat/james-project/merges","archive_url":"https://api.github.com/repos/hoangdat/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoangdat/james-project/downloads","issues_url":"https://api.github.com/repos/hoangdat/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/hoangdat/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/hoangdat/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/hoangdat/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoangdat/james-project/labels{/name}","releases_url":"https://api.github.com/repos/hoangdat/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/hoangdat/james-project/deployments","created_at":"2018-10-29T03:11:30Z","updated_at":"2018-11-27T05:16:32Z","pushed_at":"2018-12-12T10:17:55Z","git_url":"git://github.com/hoangdat/james-project.git","ssh_url":"git@github.com:hoangdat/james-project.git","clone_url":"https://github.com/hoangdat/james-project.git","svn_url":"https://github.com/hoangdat/james-project","homepage":null,"size":38295,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linagora:master","ref":"master","sha":"b0687e850bcdc858a9ff970a5aff6bb0d76c48c3","user":{"login":"linagora","id":1230365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAzNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1230365?v=4","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"repo":{"id":39182136,"node_id":"MDEwOlJlcG9zaXRvcnkzOTE4MjEzNg==","name":"james-project","full_name":"linagora/james-project","private":false,"owner":{"login":"linagora","id":1230365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAzNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1230365?v=4","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linagora/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/linagora/james-project","forks_url":"https://api.github.com/repos/linagora/james-project/forks","keys_url":"https://api.github.com/repos/linagora/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linagora/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linagora/james-project/teams","hooks_url":"https://api.github.com/repos/linagora/james-project/hooks","issue_events_url":"https://api.github.com/repos/linagora/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/linagora/james-project/events","assignees_url":"https://api.github.com/repos/linagora/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/linagora/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/linagora/james-project/tags","blobs_url":"https://api.github.com/repos/linagora/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linagora/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linagora/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/linagora/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/linagora/james-project/languages","stargazers_url":"https://api.github.com/repos/linagora/james-project/stargazers","contributors_url":"https://api.github.com/repos/linagora/james-project/contributors","subscribers_url":"https://api.github.com/repos/linagora/james-project/subscribers","subscription_url":"https://api.github.com/repos/linagora/james-project/subscription","commits_url":"https://api.github.com/repos/linagora/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/linagora/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/linagora/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/linagora/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/linagora/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/linagora/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linagora/james-project/merges","archive_url":"https://api.github.com/repos/linagora/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linagora/james-project/downloads","issues_url":"https://api.github.com/repos/linagora/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/linagora/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/linagora/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/linagora/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linagora/james-project/labels{/name}","releases_url":"https://api.github.com/repos/linagora/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/linagora/james-project/deployments","created_at":"2015-07-16T07:04:59Z","updated_at":"2018-12-12T09:53:18Z","pushed_at":"2018-12-12T10:36:57Z","git_url":"git://github.com/linagora/james-project.git","ssh_url":"git@github.com:linagora/james-project.git","clone_url":"https://github.com/linagora/james-project.git","svn_url":"https://github.com/linagora/james-project","homepage":null,"size":38508,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":112,"license":null,"forks":33,"open_issues":112,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/2026"},"html":{"href":"https://github.com/linagora/james-project/pull/2026"},"issue":{"href":"https://api.github.com/repos/linagora/james-project/issues/2026"},"comments":{"href":"https://api.github.com/repos/linagora/james-project/issues/2026/comments"},"review_comments":{"href":"https://api.github.com/repos/linagora/james-project/pulls/2026/comments"},"review_comment":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linagora/james-project/pulls/2026/commits"},"statuses":{"href":"https://api.github.com/repos/linagora/james-project/statuses/0bbfb8b4d5ea6f8a5ad19dd5b0b78f5082cf6b2f"}},"author_association":"NONE"}}
{"actor":{"display_login":"chibenwa"}}