{"action":"created","issue":{"url":"https://api.github.com/repos/rspec/rspec-expectations/issues/1073","repository_url":"https://api.github.com/repos/rspec/rspec-expectations","labels_url":"https://api.github.com/repos/rspec/rspec-expectations/issues/1073/labels{/name}","comments_url":"https://api.github.com/repos/rspec/rspec-expectations/issues/1073/comments","events_url":"https://api.github.com/repos/rspec/rspec-expectations/issues/1073/events","html_url":"https://github.com/rspec/rspec-expectations/pull/1073","id":360558741,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1Nzc5NjYx","number":1073,"title":"Only call to_hash when actual object does not respond to include?","user":{"login":"jkowens","id":585943,"node_id":"MDQ6VXNlcjU4NTk0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/585943?v=4","gravatar_id":"","url":"https://api.github.com/users/jkowens","html_url":"https://github.com/jkowens","followers_url":"https://api.github.com/users/jkowens/followers","following_url":"https://api.github.com/users/jkowens/following{/other_user}","gists_url":"https://api.github.com/users/jkowens/gists{/gist_id}","starred_url":"https://api.github.com/users/jkowens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkowens/subscriptions","organizations_url":"https://api.github.com/users/jkowens/orgs","repos_url":"https://api.github.com/users/jkowens/repos","events_url":"https://api.github.com/users/jkowens/events{/privacy}","received_events_url":"https://api.github.com/users/jkowens/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-15T17:20:03Z","updated_at":"2018-09-17T19:54:25Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rspec/rspec-expectations/pulls/1073","html_url":"https://github.com/rspec/rspec-expectations/pull/1073","diff_url":"https://github.com/rspec/rspec-expectations/pull/1073.diff","patch_url":"https://github.com/rspec/rspec-expectations/pull/1073.patch"},"body":"According to the docs for the built-in include matcher, if an object responds to `#include?` that method will be called. Currently, if an object implements `#to_hash`, the `#include?` method on the returned `Hash` is called instead (unless the object is already a Hash).\r\n\r\nThis change in behavior was introduced in https://github.com/rspec/rspec-expectations/commit/a0c39589979befc8279c2d4f78579a504d7dfcff."},"comment":{"url":"https://api.github.com/repos/rspec/rspec-expectations/issues/comments/422148199","html_url":"https://github.com/rspec/rspec-expectations/pull/1073#issuecomment-422148199","issue_url":"https://api.github.com/repos/rspec/rspec-expectations/issues/1073","id":422148199,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjE0ODE5OQ==","user":{"login":"jkowens","id":585943,"node_id":"MDQ6VXNlcjU4NTk0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/585943?v=4","gravatar_id":"","url":"https://api.github.com/users/jkowens","html_url":"https://github.com/jkowens","followers_url":"https://api.github.com/users/jkowens/followers","following_url":"https://api.github.com/users/jkowens/following{/other_user}","gists_url":"https://api.github.com/users/jkowens/gists{/gist_id}","starred_url":"https://api.github.com/users/jkowens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkowens/subscriptions","organizations_url":"https://api.github.com/users/jkowens/orgs","repos_url":"https://api.github.com/users/jkowens/repos","events_url":"https://api.github.com/users/jkowens/events{/privacy}","received_events_url":"https://api.github.com/users/jkowens/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T19:54:25Z","updated_at":"2018-09-17T19:54:25Z","author_association":"NONE","body":"@JonRowe #1069 came with spec coverage. I don't think this should regress that change...but this is my first time sending up a PR for rspec. Is there something more you think should be considered?\r\n\r\nhttps://github.com/rspec/rspec-expectations/blob/31f108eae68e31ee65f0622c9ef4a488a1602943/spec/rspec/matchers/built_in/include_spec.rb#L191"}}
{"actor":{"display_login":"jkowens"}}