{"action":"created","issue":{"url":"https://api.github.com/repos/4Catalyzer/found-relay/issues/111","repository_url":"https://api.github.com/repos/4Catalyzer/found-relay","labels_url":"https://api.github.com/repos/4Catalyzer/found-relay/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/4Catalyzer/found-relay/issues/111/comments","events_url":"https://api.github.com/repos/4Catalyzer/found-relay/issues/111/events","html_url":"https://github.com/4Catalyzer/found-relay/issues/111","id":291920711,"number":111,"title":"Resolver should not swallow errors from the Relay Network Calls","user":{"login":"jpbarela","id":1527339,"avatar_url":"https://avatars2.githubusercontent.com/u/1527339?v=4","gravatar_id":"","url":"https://api.github.com/users/jpbarela","html_url":"https://github.com/jpbarela","followers_url":"https://api.github.com/users/jpbarela/followers","following_url":"https://api.github.com/users/jpbarela/following{/other_user}","gists_url":"https://api.github.com/users/jpbarela/gists{/gist_id}","starred_url":"https://api.github.com/users/jpbarela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpbarela/subscriptions","organizations_url":"https://api.github.com/users/jpbarela/orgs","repos_url":"https://api.github.com/users/jpbarela/repos","events_url":"https://api.github.com/users/jpbarela/events{/privacy}","received_events_url":"https://api.github.com/users/jpbarela/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-01-26T14:39:49Z","updated_at":"2018-02-06T17:49:33Z","closed_at":"2018-01-26T17:51:50Z","author_association":"NONE","body":"The current resolver appears to swallow all of errors coming from the network layer leading to behavior that isn't similar to a standard found router or a relay-modern QueryRenderer. A developer can turn on error handling by explicitly including a render in each route but this seems error prone.\r\n\r\nI seems like three possible solutions might make sense:\r\n\r\n1. Enable the resolver to receive an error component that is called if the GraphQL network layer returns an error similar to a QueryRenderer\r\n2. Throw the error to enable the FarceRouter to receive the error and let the developer work at that layer\r\n3. Enable the resolver to receive an optional render so that the resolver behavior more similarly to a standard found router.\r\n\r\nI think there's some merit in each approach and I'd be happy to take the first crack at implementing any of these and submitting a PR or working on another solution if these don't seem right."},"comment":{"url":"https://api.github.com/repos/4Catalyzer/found-relay/issues/comments/363506739","html_url":"https://github.com/4Catalyzer/found-relay/issues/111#issuecomment-363506739","issue_url":"https://api.github.com/repos/4Catalyzer/found-relay/issues/111","id":363506739,"user":{"login":"dminkovsky","id":218725,"avatar_url":"https://avatars1.githubusercontent.com/u/218725?v=4","gravatar_id":"","url":"https://api.github.com/users/dminkovsky","html_url":"https://github.com/dminkovsky","followers_url":"https://api.github.com/users/dminkovsky/followers","following_url":"https://api.github.com/users/dminkovsky/following{/other_user}","gists_url":"https://api.github.com/users/dminkovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/dminkovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dminkovsky/subscriptions","organizations_url":"https://api.github.com/users/dminkovsky/orgs","repos_url":"https://api.github.com/users/dminkovsky/repos","events_url":"https://api.github.com/users/dminkovsky/events{/privacy}","received_events_url":"https://api.github.com/users/dminkovsky/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T17:49:33Z","updated_at":"2018-02-06T17:49:33Z","author_association":"CONTRIBUTOR","body":"Following up with https://github.com/4Catalyzer/found-relay/issues/86#issuecomment-363504388 (just found this issue after posting that comment):\r\n\r\n> The idea is that the render you pass into each route is roughly the same as the one you'd pass into <QueryRenderer>.\r\n\r\nThat sounds good. Since `<QueryRenderer>` gives you access to the errors that resulted from the query, shouldn't the errors also be available in a route's `render()` or `Component#render()`?\r\n"}}
{"actor":{"display_login":"dminkovsky"}}