{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/233263712","pull_request_review_id":174637849,"id":233263712,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzI2MzcxMg==","diff_hunk":"@@ -76,4 +76,24 @@ message OutlierDetection {\n   // used to disable ejection or to ramp it up slowly. Defaults to 0.\n   google.protobuf.UInt32Value enforcing_consecutive_gateway_failure = 11\n       [(validate.rules).uint32.lte = 100];\n+\n+  // The number of consecutive connect failures before ejection\n+  // occurs. Defaults to 5.\n+  google.protobuf.UInt32Value consecutive_connect_failure = 12;\n+\n+  // The % chance that a host will be actually ejected when an outlier status\n+  // is detected through consecutive connect failures. This setting can be\n+  // used to disable ejection or to ramp it up slowly. Defaults to 100.\n+  google.protobuf.UInt32Value enforcing_consecutive_connect_failure = 13\n+      [(validate.rules).uint32.lte = 100];\n+\n+  // The number of consecutive server transaction failures before ejection occurs.","path":"api/envoy/api/v2/cluster/outlier_detection.proto","position":15,"original_position":15,"commit_id":"1954b03f58a64fa258af4dda4ae6881d33bbfdaa","original_commit_id":"1954b03f58a64fa258af4dda4ae6881d33bbfdaa","user":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"body":"Just from reading this documentation, I'm not sure what a server transaction failure is. I will keep reading the PR but can we update that to make it more clear?\r\n\r\nEdit: OK So the idea here is this is an upstream server failure for non-HTTP servers? Is that right? If so I think that makes sense.","created_at":"2018-11-13T23:31:31Z","updated_at":"2018-11-13T23:37:03Z","html_url":"https://github.com/envoyproxy/envoy/pull/4822#discussion_r233263712","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4822","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/233263712"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4822#discussion_r233263712"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4822"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4822","id":224799011,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Nzk5MDEx","html_url":"https://github.com/envoyproxy/envoy/pull/4822","diff_url":"https://github.com/envoyproxy/envoy/pull/4822.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4822.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4822","number":4822,"state":"open","locked":false,"title":"upstream: outlier detector - distinguish upstream from internal errors","user":{"login":"cpakulski","id":36484366,"node_id":"MDQ6VXNlcjM2NDg0MzY2","avatar_url":"https://avatars3.githubusercontent.com/u/36484366?v=4","gravatar_id":"","url":"https://api.github.com/users/cpakulski","html_url":"https://github.com/cpakulski","followers_url":"https://api.github.com/users/cpakulski/followers","following_url":"https://api.github.com/users/cpakulski/following{/other_user}","gists_url":"https://api.github.com/users/cpakulski/gists{/gist_id}","starred_url":"https://api.github.com/users/cpakulski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpakulski/subscriptions","organizations_url":"https://api.github.com/users/cpakulski/orgs","repos_url":"https://api.github.com/users/cpakulski/repos","events_url":"https://api.github.com/users/cpakulski/events{/privacy}","received_events_url":"https://api.github.com/users/cpakulski/received_events","type":"User","site_admin":false},"body":"Description: Outlier detector has specific handlers for 5xx errors. Internal errors, like connect failures, timeout, resets have been mapped to 5xx errors and handled by the same logic in outlier detector as upstream's 5xx errors. This PR introduces separate handlers for internal errors (connect failures, timeout, resets). New internal counters and new config items have been added. \r\n\r\nRisk Level: Low\r\n\r\nTesting: Unit tests.\r\n\r\nDocs Changes: Yes - new config items have been added to config reference and section about outlier detector.\r\n\r\nRelease Notes: N/A\r\nFixes #3643 ","created_at":"2018-10-22T20:11:46Z","updated_at":"2018-11-13T23:37:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2774621bea20b64fdfdd5902c4271e4c8115f529","assignee":{"login":"dnoe","id":1183641,"node_id":"MDQ6VXNlcjExODM2NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1183641?v=4","gravatar_id":"","url":"https://api.github.com/users/dnoe","html_url":"https://github.com/dnoe","followers_url":"https://api.github.com/users/dnoe/followers","following_url":"https://api.github.com/users/dnoe/following{/other_user}","gists_url":"https://api.github.com/users/dnoe/gists{/gist_id}","starred_url":"https://api.github.com/users/dnoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnoe/subscriptions","organizations_url":"https://api.github.com/users/dnoe/orgs","repos_url":"https://api.github.com/users/dnoe/repos","events_url":"https://api.github.com/users/dnoe/events{/privacy}","received_events_url":"https://api.github.com/users/dnoe/received_events","type":"User","site_admin":false},"assignees":[{"login":"dnoe","id":1183641,"node_id":"MDQ6VXNlcjExODM2NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1183641?v=4","gravatar_id":"","url":"https://api.github.com/users/dnoe","html_url":"https://github.com/dnoe","followers_url":"https://api.github.com/users/dnoe/followers","following_url":"https://api.github.com/users/dnoe/following{/other_user}","gists_url":"https://api.github.com/users/dnoe/gists{/gist_id}","starred_url":"https://api.github.com/users/dnoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnoe/subscriptions","organizations_url":"https://api.github.com/users/dnoe/orgs","repos_url":"https://api.github.com/users/dnoe/repos","events_url":"https://api.github.com/users/dnoe/events{/privacy}","received_events_url":"https://api.github.com/users/dnoe/received_events","type":"User","site_admin":false},{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4822/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4822/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4822/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/1954b03f58a64fa258af4dda4ae6881d33bbfdaa","head":{"label":"cpakulski:issue/3643","ref":"issue/3643","sha":"1954b03f58a64fa258af4dda4ae6881d33bbfdaa","user":{"login":"cpakulski","id":36484366,"node_id":"MDQ6VXNlcjM2NDg0MzY2","avatar_url":"https://avatars3.githubusercontent.com/u/36484366?v=4","gravatar_id":"","url":"https://api.github.com/users/cpakulski","html_url":"https://github.com/cpakulski","followers_url":"https://api.github.com/users/cpakulski/followers","following_url":"https://api.github.com/users/cpakulski/following{/other_user}","gists_url":"https://api.github.com/users/cpakulski/gists{/gist_id}","starred_url":"https://api.github.com/users/cpakulski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpakulski/subscriptions","organizations_url":"https://api.github.com/users/cpakulski/orgs","repos_url":"https://api.github.com/users/cpakulski/repos","events_url":"https://api.github.com/users/cpakulski/events{/privacy}","received_events_url":"https://api.github.com/users/cpakulski/received_events","type":"User","site_admin":false},"repo":{"id":122646496,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NDY0OTY=","name":"envoy","full_name":"cpakulski/envoy","private":false,"owner":{"login":"cpakulski","id":36484366,"node_id":"MDQ6VXNlcjM2NDg0MzY2","avatar_url":"https://avatars3.githubusercontent.com/u/36484366?v=4","gravatar_id":"","url":"https://api.github.com/users/cpakulski","html_url":"https://github.com/cpakulski","followers_url":"https://api.github.com/users/cpakulski/followers","following_url":"https://api.github.com/users/cpakulski/following{/other_user}","gists_url":"https://api.github.com/users/cpakulski/gists{/gist_id}","starred_url":"https://api.github.com/users/cpakulski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpakulski/subscriptions","organizations_url":"https://api.github.com/users/cpakulski/orgs","repos_url":"https://api.github.com/users/cpakulski/repos","events_url":"https://api.github.com/users/cpakulski/events{/privacy}","received_events_url":"https://api.github.com/users/cpakulski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cpakulski/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/cpakulski/envoy","forks_url":"https://api.github.com/repos/cpakulski/envoy/forks","keys_url":"https://api.github.com/repos/cpakulski/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpakulski/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpakulski/envoy/teams","hooks_url":"https://api.github.com/repos/cpakulski/envoy/hooks","issue_events_url":"https://api.github.com/repos/cpakulski/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/cpakulski/envoy/events","assignees_url":"https://api.github.com/repos/cpakulski/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/cpakulski/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/cpakulski/envoy/tags","blobs_url":"https://api.github.com/repos/cpakulski/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpakulski/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpakulski/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpakulski/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpakulski/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/cpakulski/envoy/languages","stargazers_url":"https://api.github.com/repos/cpakulski/envoy/stargazers","contributors_url":"https://api.github.com/repos/cpakulski/envoy/contributors","subscribers_url":"https://api.github.com/repos/cpakulski/envoy/subscribers","subscription_url":"https://api.github.com/repos/cpakulski/envoy/subscription","commits_url":"https://api.github.com/repos/cpakulski/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpakulski/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpakulski/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpakulski/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpakulski/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/cpakulski/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpakulski/envoy/merges","archive_url":"https://api.github.com/repos/cpakulski/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpakulski/envoy/downloads","issues_url":"https://api.github.com/repos/cpakulski/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/cpakulski/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/cpakulski/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/cpakulski/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpakulski/envoy/labels{/name}","releases_url":"https://api.github.com/repos/cpakulski/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/cpakulski/envoy/deployments","created_at":"2018-02-23T16:37:32Z","updated_at":"2018-03-29T19:55:34Z","pushed_at":"2018-11-12T17:44:26Z","git_url":"git://github.com/cpakulski/envoy.git","ssh_url":"git@github.com:cpakulski/envoy.git","clone_url":"https://github.com/cpakulski/envoy.git","svn_url":"https://github.com/cpakulski/envoy","homepage":"https://envoyproxy.github.io/","size":22372,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"7f4c6fff2419623e88e799fd39da7871c6ac3399","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","private":false,"owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-11-13T23:05:50Z","pushed_at":"2018-11-13T23:05:42Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":23457,"stargazers_count":7162,"watchers_count":7162,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":991,"mirror_url":null,"archived":false,"open_issues_count":359,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":991,"open_issues":359,"watchers":7162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4822"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4822"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4822"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4822/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4822/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4822/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/1954b03f58a64fa258af4dda4ae6881d33bbfdaa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mattklein123"}}