{"action":"closed","issue":{"url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/1702","repository_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead","labels_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/1702/labels{/name}","comments_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/1702/comments","events_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/1702/events","html_url":"https://github.com/DevExpress/testcafe-hammerhead/issues/1702","id":345432353,"node_id":"MDU6SXNzdWUzNDU0MzIzNTM=","number":1702,"title":"Cookie domain validation rule on client side is strange","user":{"login":"b12031106","id":2063566,"node_id":"MDQ6VXNlcjIwNjM1NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/2063566?v=4","gravatar_id":"","url":"https://api.github.com/users/b12031106","html_url":"https://github.com/b12031106","followers_url":"https://api.github.com/users/b12031106/followers","following_url":"https://api.github.com/users/b12031106/following{/other_user}","gists_url":"https://api.github.com/users/b12031106/gists{/gist_id}","starred_url":"https://api.github.com/users/b12031106/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b12031106/subscriptions","organizations_url":"https://api.github.com/users/b12031106/orgs","repos_url":"https://api.github.com/users/b12031106/repos","events_url":"https://api.github.com/users/b12031106/events{/privacy}","received_events_url":"https://api.github.com/users/b12031106/received_events","type":"User","site_admin":false},"labels":[{"id":243969449,"node_id":"MDU6TGFiZWwyNDM5Njk0NDk=","url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/labels/AREA:%20client","name":"AREA: client","color":"fef2c0","default":false},{"id":243970245,"node_id":"MDU6TGFiZWwyNDM5NzAyNDU=","url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/labels/SYSTEM:%20sandbox","name":"SYSTEM: sandbox","color":"bfe5bf","default":false},{"id":220536252,"node_id":"MDU6TGFiZWwyMjA1MzYyNTI=","url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/labels/TYPE:%20bug","name":"TYPE: bug","color":"f7c6c7","default":false}],"state":"closed","locked":false,"assignee":{"login":"LavrovArtem","id":5373460,"node_id":"MDQ6VXNlcjUzNzM0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/5373460?v=4","gravatar_id":"","url":"https://api.github.com/users/LavrovArtem","html_url":"https://github.com/LavrovArtem","followers_url":"https://api.github.com/users/LavrovArtem/followers","following_url":"https://api.github.com/users/LavrovArtem/following{/other_user}","gists_url":"https://api.github.com/users/LavrovArtem/gists{/gist_id}","starred_url":"https://api.github.com/users/LavrovArtem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LavrovArtem/subscriptions","organizations_url":"https://api.github.com/users/LavrovArtem/orgs","repos_url":"https://api.github.com/users/LavrovArtem/repos","events_url":"https://api.github.com/users/LavrovArtem/events{/privacy}","received_events_url":"https://api.github.com/users/LavrovArtem/received_events","type":"User","site_admin":false},"assignees":[{"login":"LavrovArtem","id":5373460,"node_id":"MDQ6VXNlcjUzNzM0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/5373460?v=4","gravatar_id":"","url":"https://api.github.com/users/LavrovArtem","html_url":"https://github.com/LavrovArtem","followers_url":"https://api.github.com/users/LavrovArtem/followers","following_url":"https://api.github.com/users/LavrovArtem/following{/other_user}","gists_url":"https://api.github.com/users/LavrovArtem/gists{/gist_id}","starred_url":"https://api.github.com/users/LavrovArtem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LavrovArtem/subscriptions","organizations_url":"https://api.github.com/users/LavrovArtem/orgs","repos_url":"https://api.github.com/users/LavrovArtem/repos","events_url":"https://api.github.com/users/LavrovArtem/events{/privacy}","received_events_url":"https://api.github.com/users/LavrovArtem/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/milestones/21","html_url":"https://github.com/DevExpress/testcafe-hammerhead/milestone/21","labels_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/milestones/21/labels","id":3527588,"node_id":"MDk6TWlsZXN0b25lMzUyNzU4OA==","number":21,"title":"Sprint #15","description":"","creator":{"login":"LavrovArtem","id":5373460,"node_id":"MDQ6VXNlcjUzNzM0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/5373460?v=4","gravatar_id":"","url":"https://api.github.com/users/LavrovArtem","html_url":"https://github.com/LavrovArtem","followers_url":"https://api.github.com/users/LavrovArtem/followers","following_url":"https://api.github.com/users/LavrovArtem/following{/other_user}","gists_url":"https://api.github.com/users/LavrovArtem/gists{/gist_id}","starred_url":"https://api.github.com/users/LavrovArtem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LavrovArtem/subscriptions","organizations_url":"https://api.github.com/users/LavrovArtem/orgs","repos_url":"https://api.github.com/users/LavrovArtem/repos","events_url":"https://api.github.com/users/LavrovArtem/events{/privacy}","received_events_url":"https://api.github.com/users/LavrovArtem/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":4,"state":"open","created_at":"2018-07-27T09:38:30Z","updated_at":"2018-08-03T15:06:15Z","due_on":"2018-08-13T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-07-28T08:41:58Z","updated_at":"2018-08-03T15:06:15Z","closed_at":"2018-08-03T15:06:15Z","author_association":"CONTRIBUTOR","body":"for example,\r\n\r\nif current domain is `https://www.google.com`,\r\nand you try set cookie with domain `.google.com`：\r\n```js\r\ndocument.cookie = 'a=b; domain=.google.com;';\r\n```\r\nIn normal browser, this code is working fine,\r\nI can get this cookie value by access `document.cookie`,\r\n\r\nbut in Testcafe browser, this code is not working,\r\nand I find out maybe is because client side cookie validation is strange:\r\n\r\nhttps://github.com/DevExpress/testcafe-hammerhead/blob/master/src/client/sandbox/cookie/index.js#L85\r\n```js\r\nreturn !parsedCookie.domain || parsedDestLocation.hostname === parsedCookie.domain;\r\n```\r\n\r\nthis line means that when you set a cookie with domain attribute,\r\nit should be **exactly the same** with current hostname,\r\nbut this behavior is different to a normal browser."}}
{"actor":{"display_login":"LavrovArtem"}}