{"action":"created","issue":{"url":"https://api.github.com/repos/mendersoftware/meta-mender-community/issues/15","repository_url":"https://api.github.com/repos/mendersoftware/meta-mender-community","labels_url":"https://api.github.com/repos/mendersoftware/meta-mender-community/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/mendersoftware/meta-mender-community/issues/15/comments","events_url":"https://api.github.com/repos/mendersoftware/meta-mender-community/issues/15/events","html_url":"https://github.com/mendersoftware/meta-mender-community/pull/15","id":379440498,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTAxMDY3","number":15,"title":"Add NVIDIA tegra support","user":{"login":"dwalkes","id":227565,"node_id":"MDQ6VXNlcjIyNzU2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/227565?v=4","gravatar_id":"","url":"https://api.github.com/users/dwalkes","html_url":"https://github.com/dwalkes","followers_url":"https://api.github.com/users/dwalkes/followers","following_url":"https://api.github.com/users/dwalkes/following{/other_user}","gists_url":"https://api.github.com/users/dwalkes/gists{/gist_id}","starred_url":"https://api.github.com/users/dwalkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwalkes/subscriptions","organizations_url":"https://api.github.com/users/dwalkes/orgs","repos_url":"https://api.github.com/users/dwalkes/repos","events_url":"https://api.github.com/users/dwalkes/events{/privacy}","received_events_url":"https://api.github.com/users/dwalkes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-10T17:14:04Z","updated_at":"2018-11-11T20:15:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mendersoftware/meta-mender-community/pulls/15","html_url":"https://github.com/mendersoftware/meta-mender-community/pull/15","diff_url":"https://github.com/mendersoftware/meta-mender-community/pull/15.diff","patch_url":"https://github.com/mendersoftware/meta-mender-community/pull/15.patch"},"body":"Thanks for creating this project!\r\n\r\nThis pull request adds support for NVIDIA tegra, as discussed [in the forum](https://groups.google.com/a/lists.mender.io/forum/#!topic/mender/ISaA1ll9Fbo) and [mender hub page](https://hub.mender.io/t/nvidia-tegra-jetson-tx2/123).\r\n\r\nTo test before the pull request is complete you can use\r\n```\r\nrepo init \\\r\n        -u https://github.com/Trellis-Logic/meta-mender-community \\\r\n        -m meta-mender-tegra/scripts/manifest-tegra.xml \\\r\n        -b add-tegra\r\nrepo sync\r\n```\r\n\r\nBased on Mirza's recommendations in the forum and the recommendations in the [meta-tegra pull request](https://github.com/madisongh/meta-tegra/pull/114) I haven't tried to update partitioning or moving u-boot environment out of a dedicated sector.  Although I'd expect these patches to support any NVIDIA platforms supported by meta-tegra there will be partition layout related work to do which I've summarized in the README.  I only have access to a TX 2 development board today and can't test on other platforms, therefore I'll avoid trying to add untested work with the initial PR.\r\n\r\nThis was my first time setting up a yocto project with the repo tool and I think it's a cool way to setup a project.  A few observations:\r\n\r\n* I think the mkdir mender-<vendor/soc name> would really be setting up your yocto based project, so a directory name like yocto-yourprojectname might be more appropriate.\r\n* I think the README.md instructions in the root folder are missing a repo sync command after repo init.\r\n* Some detail about the workflow in the README might be warranted.  I don't think repo upload works unless you have a gerrit server for instance, so it's likely anyone not using gerrit will want to add git submodules and also add their conf/local.conf and bblayers.conf files to share their project with others on the local team.  Let me know if you have a different workflow in mind.  If this is the workflow you expect people to use often it might be handy to add a script which can create git submodules and adds appropriate .gitignore files.\r\n* I added a helper meta-mender-tegra/scripts/deploy.sh script but couldn't figure out how to add this to the root directory of the project on init.  I needed to back out my first attempt in f3f0537791722cf4aaff9b60233c1cfd80b3cf3f because the repo init command was failing with:\r\n```\r\nfatal: manifest 'meta-mender-tegra/scripts/manifest-tegra.xml' not available\r\nfatal: duplicate path sources/meta-mender-community in /home/dan/yocto-tegra-2/.repo/manifests/meta-mender-tegra/scripts/manifest-tegra.xml\r\n```\r\nprobably because I had duplicated the same project attribute from [scripts/mender.xml](scripts/mender.xml).  Let me know if you have ideas about how I could accomplish this.\r\n* Related to the comment above, I like to put really simple scripts in the base directory of projects so team members, even ones who don't know yocto or bitbake workflow, are comfortable doing simple tasks like building and deploying software.  For this reason I typically add a ./build.sh script with content like [this one](https://github.com/Trellis-Logic/yocto-tegra/blob/master/build.sh) in the root of a project directory.  This could be shared with all projects and would be useful after the first setup-environment step for future builds.  Just an idea and no worries if you'd rather not.  I'd be interested in any reasons this is not a good idea from your perspective.\r\n\r\nI'm happy to incorporate any of the changes above into this or a new PR, and equally happy to just let the project be as-is, just let me know.\r\n\r\nThanks again for creating this project!"},"comment":{"url":"https://api.github.com/repos/mendersoftware/meta-mender-community/issues/comments/437700947","html_url":"https://github.com/mendersoftware/meta-mender-community/pull/15#issuecomment-437700947","issue_url":"https://api.github.com/repos/mendersoftware/meta-mender-community/issues/15","id":437700947,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzcwMDk0Nw==","user":{"login":"mirzak","id":5717557,"node_id":"MDQ6VXNlcjU3MTc1NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5717557?v=4","gravatar_id":"","url":"https://api.github.com/users/mirzak","html_url":"https://github.com/mirzak","followers_url":"https://api.github.com/users/mirzak/followers","following_url":"https://api.github.com/users/mirzak/following{/other_user}","gists_url":"https://api.github.com/users/mirzak/gists{/gist_id}","starred_url":"https://api.github.com/users/mirzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirzak/subscriptions","organizations_url":"https://api.github.com/users/mirzak/orgs","repos_url":"https://api.github.com/users/mirzak/repos","events_url":"https://api.github.com/users/mirzak/events{/privacy}","received_events_url":"https://api.github.com/users/mirzak/received_events","type":"User","site_admin":false},"created_at":"2018-11-11T20:15:46Z","updated_at":"2018-11-11T20:15:46Z","author_association":"COLLABORATOR","body":"> I think the README.md instructions in the root folder are missing a repo sync command after repo init.\r\n\r\nYes they are :). Feel free to fix that.\r\n\r\n> Some detail about the workflow in the README might be warranted.\r\n\r\n`repo` is only intended to be used to fetch the sources, and is a somewhat simple way of doing so instead of keeping separate \"git clone\" commands. For most people this will be enough.\r\n\r\nDevelopment workflow might be a good idea to add later on, but I do not see why you would need git sub-modules for that? I normally just use \"repo\" to fetch and then you have the individual git repos locally and I can work on them how ever I would like.\r\n\r\n> I like to put really simple scripts in the base directory of projects so team members, , even ones who don't know yocto or bitbake workflow, are comfortable doing simple tasks like building and deploying software\r\n\r\nThis might be out of scope for meta-mender-community, as we have the Mender Hub which are a couple of copy/paste commands to get an image built and do not really require any knowledge of Yocto nor Bitbake if it works :P.\r\n\r\nOne downside with these type of scripts is that we will get more files to maintain and it will be hard to cover all corner cases. \r\n\r\n> One other comment about potential README changes: you could consider a TODO section linking to building-for-production instructions so people doing their first deployment are aware of the work remaining to get the solution ready for production, also a section linking the partition layout section which discusses the need to move persistent data into the /data partition.\r\n\r\nGreat ideas. I would rather see this to be part of the template we have on Mender Hub for Yocto project, as we are trying to keep the README here minimal (see my other comment)\r\n"}}
{"actor":{"display_login":"mirzak"}}