{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/scenery/issues/870","repository_url":"https://api.github.com/repos/phetsims/scenery","labels_url":"https://api.github.com/repos/phetsims/scenery/issues/870/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/scenery/issues/870/comments","events_url":"https://api.github.com/repos/phetsims/scenery/issues/870/events","html_url":"https://github.com/phetsims/scenery/issues/870","id":365000832,"node_id":"MDU6SXNzdWUzNjUwMDA4MzI=","number":870,"title":"add accessibleAttribute option to treat as javascript property vs setAttribute","user":{"login":"zepumph","id":6856943,"node_id":"MDQ6VXNlcjY4NTY5NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/6856943?v=4","gravatar_id":"","url":"https://api.github.com/users/zepumph","html_url":"https://github.com/zepumph","followers_url":"https://api.github.com/users/zepumph/followers","following_url":"https://api.github.com/users/zepumph/following{/other_user}","gists_url":"https://api.github.com/users/zepumph/gists{/gist_id}","starred_url":"https://api.github.com/users/zepumph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zepumph/subscriptions","organizations_url":"https://api.github.com/users/zepumph/orgs","repos_url":"https://api.github.com/users/zepumph/repos","events_url":"https://api.github.com/users/zepumph/events{/privacy}","received_events_url":"https://api.github.com/users/zepumph/received_events","type":"User","site_admin":false},"labels":[{"id":39319737,"node_id":"MDU6TGFiZWwzOTMxOTczNw==","url":"https://api.github.com/repos/phetsims/scenery/labels/dev:a11y","name":"dev:a11y","color":"008080","default":false}],"state":"open","locked":false,"assignee":{"login":"jessegreenberg","id":6396244,"node_id":"MDQ6VXNlcjYzOTYyNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6396244?v=4","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false},"assignees":[{"login":"jessegreenberg","id":6396244,"node_id":"MDQ6VXNlcjYzOTYyNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6396244?v=4","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-09-28T18:48:19Z","updated_at":"2018-11-14T16:21:42Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"From https://github.com/phetsims/scenery/issues/832#issuecomment-423770701\r\n\r\n>Discuss when to have a convenience mixin function call to accessibleAttribute api (like containerAriaRole), and when it should be its own thing completely (inputType).\r\n\r\nThere are potentially three different ways of setting these on a DOMElement:\r\n```js\r\nelement.hidden = true;\r\nelement.setAttribute( 'hidden'); // ????????\r\nelement.setAttribute( 'hidden', 'true' );\r\n```\r\n\r\nIt seems like screen readers and browsers treat these values differently depending on how we set them, see https://github.com/phetsims/sun/issues/397.  We should either support both, or decide which one is best and always use that. (I think we need to support both, likely with an option to `setAccessibleAttribute`)."},"comment":{"url":"https://api.github.com/repos/phetsims/scenery/issues/comments/438723045","html_url":"https://github.com/phetsims/scenery/issues/870#issuecomment-438723045","issue_url":"https://api.github.com/repos/phetsims/scenery/issues/870","id":438723045,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODcyMzA0NQ==","user":{"login":"jessegreenberg","id":6396244,"node_id":"MDQ6VXNlcjYzOTYyNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6396244?v=4","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T16:21:42Z","updated_at":"2018-11-14T16:21:42Z","author_association":"CONTRIBUTOR","body":"element.setAttribute( hidden, \"\" ); makes the hidden attribute show up on MathML elements, but the Math is still visible in the viewport, and https://developer.mozilla.org/en-US/docs/Web/MathML/Attribute doesn't list hidden or any of the attributes of HTML elements. I am going to revert changes because handling attributes for MathML will be a larger issue. To hide MathML maybe we will have to wrap the math with an HTML element that can receive `hidden`."}}
{"actor":{"display_login":"jessegreenberg"}}