{"action":"created","issue":{"url":"https://api.github.com/repos/storybooks/storybook/issues/5048","repository_url":"https://api.github.com/repos/storybooks/storybook","labels_url":"https://api.github.com/repos/storybooks/storybook/issues/5048/labels{/name}","comments_url":"https://api.github.com/repos/storybooks/storybook/issues/5048/comments","events_url":"https://api.github.com/repos/storybooks/storybook/issues/5048/events","html_url":"https://github.com/storybooks/storybook/issues/5048","id":392547326,"node_id":"MDU6SXNzdWUzOTI1NDczMjY=","number":5048,"title":"Vue, Decorators and Knobs","user":{"login":"backbone87","id":1196313,"node_id":"MDQ6VXNlcjExOTYzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1196313?v=4","gravatar_id":"","url":"https://api.github.com/users/backbone87","html_url":"https://github.com/backbone87","followers_url":"https://api.github.com/users/backbone87/followers","following_url":"https://api.github.com/users/backbone87/following{/other_user}","gists_url":"https://api.github.com/users/backbone87/gists{/gist_id}","starred_url":"https://api.github.com/users/backbone87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backbone87/subscriptions","organizations_url":"https://api.github.com/users/backbone87/orgs","repos_url":"https://api.github.com/users/backbone87/repos","events_url":"https://api.github.com/users/backbone87/events{/privacy}","received_events_url":"https://api.github.com/users/backbone87/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-19T11:00:26Z","updated_at":"2018-12-21T02:07:37Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Describe the bug**\r\nIf you are using Vue and a decorator (`<div style=\"margin:10px;\"><story /></div>`) then knobs wont work. The knobs will be there, but value changes wont be applied to the story.\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Setup a Storybook + Vue project\r\n2. Write a story for some component with knobs\r\n3. Add a decorator to that story: `() => '<div style=\"margin:10px;\"><story /></div>'`\r\n4. Launch Storybook and change the knob value in the UI\r\n5. Story wont change\r\n\r\n**Expected behavior**\r\nDecorated stories update when knob value changes.\r\nproblem.\r\n\r\n**System:**\r\n - Browser: Chrome\r\n - Framework: Vue\r\n - Addons: Knobs\r\n - Version: 4.1\r\n\r\n**Additional context**\r\nThe problem is here: https://github.com/storybooks/storybook/blob/next/app/vue/src/client/preview/render.js#L52\r\nAt this line, the components props will be read, but if you decorate a story, you read the props of the decorator component and not the props of the actual story component.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/storybooks/storybook/issues/comments/449216118","html_url":"https://github.com/storybooks/storybook/issues/5048#issuecomment-449216118","issue_url":"https://api.github.com/repos/storybooks/storybook/issues/5048","id":449216118,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTIxNjExOA==","user":{"login":"shilman","id":488689,"node_id":"MDQ6VXNlcjQ4ODY4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/488689?v=4","gravatar_id":"","url":"https://api.github.com/users/shilman","html_url":"https://github.com/shilman","followers_url":"https://api.github.com/users/shilman/followers","following_url":"https://api.github.com/users/shilman/following{/other_user}","gists_url":"https://api.github.com/users/shilman/gists{/gist_id}","starred_url":"https://api.github.com/users/shilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shilman/subscriptions","organizations_url":"https://api.github.com/users/shilman/orgs","repos_url":"https://api.github.com/users/shilman/repos","events_url":"https://api.github.com/users/shilman/events{/privacy}","received_events_url":"https://api.github.com/users/shilman/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T02:07:37Z","updated_at":"2018-12-21T02:07:37Z","author_association":"MEMBER","body":"Whoopee!! I just released https://github.com/storybooks/storybook/releases/tag/v4.2.0-alpha.6 containing PR #5057 that references this issue. Upgrade today to try it out!\n\nBecause this release is a pre-release you can find it on the `@next` NPM tag.\n\nClosing this issue now--please re-open if you think there's still more to do."}}
{"actor":{"display_login":"shilman"}}