{"action":"closed","issue":{"url":"https://api.github.com/repos/phase-0/phase-0/issues/4225","repository_url":"https://api.github.com/repos/phase-0/phase-0","labels_url":"https://api.github.com/repos/phase-0/phase-0/issues/4225/labels{/name}","comments_url":"https://api.github.com/repos/phase-0/phase-0/issues/4225/comments","events_url":"https://api.github.com/repos/phase-0/phase-0/issues/4225/events","html_url":"https://github.com/phase-0/phase-0/issues/4225","id":340480219,"node_id":"MDU6SXNzdWUzNDA0ODAyMTk=","number":4225,"title":"2.5 Pay off some technical debt","user":{"login":"engie15","id":34586511,"node_id":"MDQ6VXNlcjM0NTg2NTEx","avatar_url":"https://avatars3.githubusercontent.com/u/34586511?v=4","gravatar_id":"","url":"https://api.github.com/users/engie15","html_url":"https://github.com/engie15","followers_url":"https://api.github.com/users/engie15/followers","following_url":"https://api.github.com/users/engie15/following{/other_user}","gists_url":"https://api.github.com/users/engie15/gists{/gist_id}","starred_url":"https://api.github.com/users/engie15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engie15/subscriptions","organizations_url":"https://api.github.com/users/engie15/orgs","repos_url":"https://api.github.com/users/engie15/repos","events_url":"https://api.github.com/users/engie15/events{/privacy}","received_events_url":"https://api.github.com/users/engie15/received_events","type":"User","site_admin":false},"labels":[{"id":797676345,"node_id":"MDU6TGFiZWw3OTc2NzYzNDU=","url":"https://api.github.com/repos/phase-0/phase-0/labels/done","name":"done","color":"e6e6e6","default":false},{"id":797672176,"node_id":"MDU6TGFiZWw3OTc2NzIxNzY=","url":"https://api.github.com/repos/phase-0/phase-0/labels/sprint-2","name":"sprint-2","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":{"login":"Sungmiii","id":38752966,"node_id":"MDQ6VXNlcjM4NzUyOTY2","avatar_url":"https://avatars0.githubusercontent.com/u/38752966?v=4","gravatar_id":"","url":"https://api.github.com/users/Sungmiii","html_url":"https://github.com/Sungmiii","followers_url":"https://api.github.com/users/Sungmiii/followers","following_url":"https://api.github.com/users/Sungmiii/following{/other_user}","gists_url":"https://api.github.com/users/Sungmiii/gists{/gist_id}","starred_url":"https://api.github.com/users/Sungmiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sungmiii/subscriptions","organizations_url":"https://api.github.com/users/Sungmiii/orgs","repos_url":"https://api.github.com/users/Sungmiii/repos","events_url":"https://api.github.com/users/Sungmiii/events{/privacy}","received_events_url":"https://api.github.com/users/Sungmiii/received_events","type":"User","site_admin":false},"assignees":[{"login":"Sungmiii","id":38752966,"node_id":"MDQ6VXNlcjM4NzUyOTY2","avatar_url":"https://avatars0.githubusercontent.com/u/38752966?v=4","gravatar_id":"","url":"https://api.github.com/users/Sungmiii","html_url":"https://github.com/Sungmiii","followers_url":"https://api.github.com/users/Sungmiii/followers","following_url":"https://api.github.com/users/Sungmiii/following{/other_user}","gists_url":"https://api.github.com/users/Sungmiii/gists{/gist_id}","starred_url":"https://api.github.com/users/Sungmiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sungmiii/subscriptions","organizations_url":"https://api.github.com/users/Sungmiii/orgs","repos_url":"https://api.github.com/users/Sungmiii/repos","events_url":"https://api.github.com/users/Sungmiii/events{/privacy}","received_events_url":"https://api.github.com/users/Sungmiii/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-07-12T03:53:28Z","updated_at":"2018-08-01T22:01:16Z","closed_at":"2018-08-01T22:01:16Z","author_association":"CONTRIBUTOR","body":"# 2.5 Pay off some technical debt\n\nThis assignment combines:\n- HTML and CSS best practices\n- GitHub branching, merging and pull requests\n\nLet's pretend that [CSS Zen Garden](http://www.csszengarden.com/) want to add some more features to their homepage.\nLet's also pretend that the junior developer Sam who wrote the HTML for their page didn't have the habit of being tidy.\nBefore Zen Garden can add any features, they need to clean up their HTML indentation so they can see where and how to add new elements, and make sure they don't make the mess worse.\n\n## 1. Pay off Sam's technical debt\n- [x] Start your Toggl timer.\n- [x] In Github, create a new repository called `sprint-2`.\n- [x] Clone the repository down to the `workspace` directory (or wherever you usually keep your repos).\n- [x] Checkout a new branch called `tidying` (`git checkout -b tidying`) - this time, you'll not be pushing to the master branch. The HTML you'll be cleaning is messy, but it works. Zen Garden want to review your work to check you've not broken anything before they merge into the master branch.\n- [x] In your sprint-2 repo, add a file called `pristine-zen-garden.html`.\n- [x] Copy the [messy zen-garden html](https://github.com/dev-academy-programme/curriculum/blob/master/resources/html-with-technical-debt-CHALLENGE/zen-garden-with-debt.html) into `pristine-zen-garden.html`.\n- [x] Tidy all the indentation. There are some parts of the HTML that you'll likely not understand yet, that's ok. Your objective is just to sort out the indentation of the elements to reveal the structure of the HTML content.\n    - Take a look at [Formatting & Indenting HTML](https://www.granneman.com/webdev/coding/formatting-and-indenting-your-html/) for a guide on good HTML indentation.\n- [x] Push your `tidying` branch to GitHub.\n- [x] In Github, create a 'pull request' from your `tidying` branch to the `master` branch, with a description of the tidying you've done. Don't accept your own pull request!\n- [x] **Optional:** Find another student from your campus-specific Slack channel to review and approve your pull request. You'll need to add their github name as a collaborator in your repo's settings\n- [x] Post a link to your pull request in your campus-specific Slack channel.\n\n## 2. Reflection\n- [x] Get the time it took to get to complete section '1. Pay off Sam's technical debt' from your toggl timer. At $30/hr, how much did this little piece of technical debt cost Zen Garden? Post the $ cost in the comments section below.\n- [x] Sam wasn't tidy with indentation, but miraculously Sam built beautifully structured 'semantic' HTML (normally poor structure flows from poor indentation - the resulting poor structure creates much more severe technical debt). Take 5 minutes to review Sam's HTML.\n\n## 3. Roleplay\nLet's pretend that you're now the technical lead on the Zen Garden 'spring tidy' project. Your job is to review 'pull requests' - to check the code is up to standard and still functioning before it is accepted onto the master branch.\n- [x] Find one other person's pull request in your campus-specific Slack channel.\n- [x] Read through their submitted HTML code.\n- [x] If you see errors, make a comment on the pull request, asking them to resolve the issue you see and to mention you when they have pushed up a commit that resolves the issue you raised.\n- [x] Wait for a GitHub notification from them, review the pull request, and accept it if the indentation is perfect.\n- [x] Tidy their repository by deleting the `tidying` branch (they'll still have a copy locally if they need it).\n"}}
{"actor":{"display_login":"engie15"}}