{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/186352369","pull_request_review_id":117909404,"id":186352369,"diff_hunk":"@@ -166,6 +170,30 @@ static void init_vfp_sec(void)\n }\n #endif\n \n+#ifdef CFG_INIT_CNTFRQ\n+static void main_init_cntfrq(void)\n+{\n+\tassert(cntfrq == 0);\n+\tassert(get_core_pos() == 0);\n+\tcntfrq = read_cntfrq();","path":"core/arch/arm/kernel/generic_boot.c","position":20,"original_position":20,"commit_id":"b82be6722feb01226c46555caa3cef60dcf0c28d","original_commit_id":"b82be6722feb01226c46555caa3cef60dcf0c28d","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars0.githubusercontent.com/u/6150306?v=4","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"body":"This solves the problem of syncing CNTFRQ during boot. However, it doesn't initialize CNTFRQ, but it depends on CNTFRQ being initialized. Is this supposed to be done in earlier boot stages or am I missing something?","created_at":"2018-05-07T07:58:59Z","updated_at":"2018-05-07T07:59:03Z","html_url":"https://github.com/OP-TEE/optee_os/pull/2301#discussion_r186352369","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2301","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/186352369"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2301#discussion_r186352369"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2301"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2301","id":186106728,"html_url":"https://github.com/OP-TEE/optee_os/pull/2301","diff_url":"https://github.com/OP-TEE/optee_os/pull/2301.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/2301.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2301","number":2301,"state":"open","locked":false,"title":"Use common helper routines to initialize cntfrq on secondary cores","user":{"login":"jordanrh1","id":11446053,"avatar_url":"https://avatars1.githubusercontent.com/u/11446053?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanrh1","html_url":"https://github.com/jordanrh1","followers_url":"https://api.github.com/users/jordanrh1/followers","following_url":"https://api.github.com/users/jordanrh1/following{/other_user}","gists_url":"https://api.github.com/users/jordanrh1/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanrh1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanrh1/subscriptions","organizations_url":"https://api.github.com/users/jordanrh1/orgs","repos_url":"https://api.github.com/users/jordanrh1/repos","events_url":"https://api.github.com/users/jordanrh1/events{/privacy}","received_events_url":"https://api.github.com/users/jordanrh1/received_events","type":"User","site_admin":false},"body":"This is an alternate proposal to #2296 that uses generic code and a configuration option to initialize CNTFRQ on secondary cores.\r\n\r\n<!--\r\n    If you are new to submitting pull requests to OP-TEE, then please have a\r\n    look at the list below and tick them off before submitting the pull request.\r\n\r\n    1. Read our contribution guidelines:\r\n         documentation/github.md.\r\n\r\n    2. Read the contribution section in Notice.md and pay extra attention to the\r\n       \"Developer Certificate of Origin\" part:\r\n         https://github.com/OP-TEE/optee_os/blob/master/Notice.md#contributions.\r\n\r\n    3. You should run checkpatch preferably before submitting the pull request.\r\n\r\n    4. When everything has been reviewed, you will need to squash, rebase and\r\n       add tags like `Reviewed-by`, `Acked-by`, `Tested-by` etc.\r\n\r\n    NOTE: This comment will not be shown in the pull request, so no harm keeping\r\n    it, but feel free to remove it if you like.\r\n-->\r\n","created_at":"2018-05-04T21:19:58Z","updated_at":"2018-05-07T07:59:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80e9e5a97e44001c5a8a2a5e665641c94997eebe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2301/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2301/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2301/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/b82be6722feb01226c46555caa3cef60dcf0c28d","head":{"label":"jordanrh1:fix-cntfrq-generic","ref":"fix-cntfrq-generic","sha":"b82be6722feb01226c46555caa3cef60dcf0c28d","user":{"login":"jordanrh1","id":11446053,"avatar_url":"https://avatars1.githubusercontent.com/u/11446053?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanrh1","html_url":"https://github.com/jordanrh1","followers_url":"https://api.github.com/users/jordanrh1/followers","following_url":"https://api.github.com/users/jordanrh1/following{/other_user}","gists_url":"https://api.github.com/users/jordanrh1/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanrh1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanrh1/subscriptions","organizations_url":"https://api.github.com/users/jordanrh1/orgs","repos_url":"https://api.github.com/users/jordanrh1/repos","events_url":"https://api.github.com/users/jordanrh1/events{/privacy}","received_events_url":"https://api.github.com/users/jordanrh1/received_events","type":"User","site_admin":false},"repo":{"id":123195938,"name":"optee_os-public","full_name":"jordanrh1/optee_os-public","owner":{"login":"jordanrh1","id":11446053,"avatar_url":"https://avatars1.githubusercontent.com/u/11446053?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanrh1","html_url":"https://github.com/jordanrh1","followers_url":"https://api.github.com/users/jordanrh1/followers","following_url":"https://api.github.com/users/jordanrh1/following{/other_user}","gists_url":"https://api.github.com/users/jordanrh1/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanrh1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanrh1/subscriptions","organizations_url":"https://api.github.com/users/jordanrh1/orgs","repos_url":"https://api.github.com/users/jordanrh1/repos","events_url":"https://api.github.com/users/jordanrh1/events{/privacy}","received_events_url":"https://api.github.com/users/jordanrh1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jordanrh1/optee_os-public","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/jordanrh1/optee_os-public","forks_url":"https://api.github.com/repos/jordanrh1/optee_os-public/forks","keys_url":"https://api.github.com/repos/jordanrh1/optee_os-public/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jordanrh1/optee_os-public/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jordanrh1/optee_os-public/teams","hooks_url":"https://api.github.com/repos/jordanrh1/optee_os-public/hooks","issue_events_url":"https://api.github.com/repos/jordanrh1/optee_os-public/issues/events{/number}","events_url":"https://api.github.com/repos/jordanrh1/optee_os-public/events","assignees_url":"https://api.github.com/repos/jordanrh1/optee_os-public/assignees{/user}","branches_url":"https://api.github.com/repos/jordanrh1/optee_os-public/branches{/branch}","tags_url":"https://api.github.com/repos/jordanrh1/optee_os-public/tags","blobs_url":"https://api.github.com/repos/jordanrh1/optee_os-public/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jordanrh1/optee_os-public/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jordanrh1/optee_os-public/git/refs{/sha}","trees_url":"https://api.github.com/repos/jordanrh1/optee_os-public/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jordanrh1/optee_os-public/statuses/{sha}","languages_url":"https://api.github.com/repos/jordanrh1/optee_os-public/languages","stargazers_url":"https://api.github.com/repos/jordanrh1/optee_os-public/stargazers","contributors_url":"https://api.github.com/repos/jordanrh1/optee_os-public/contributors","subscribers_url":"https://api.github.com/repos/jordanrh1/optee_os-public/subscribers","subscription_url":"https://api.github.com/repos/jordanrh1/optee_os-public/subscription","commits_url":"https://api.github.com/repos/jordanrh1/optee_os-public/commits{/sha}","git_commits_url":"https://api.github.com/repos/jordanrh1/optee_os-public/git/commits{/sha}","comments_url":"https://api.github.com/repos/jordanrh1/optee_os-public/comments{/number}","issue_comment_url":"https://api.github.com/repos/jordanrh1/optee_os-public/issues/comments{/number}","contents_url":"https://api.github.com/repos/jordanrh1/optee_os-public/contents/{+path}","compare_url":"https://api.github.com/repos/jordanrh1/optee_os-public/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jordanrh1/optee_os-public/merges","archive_url":"https://api.github.com/repos/jordanrh1/optee_os-public/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jordanrh1/optee_os-public/downloads","issues_url":"https://api.github.com/repos/jordanrh1/optee_os-public/issues{/number}","pulls_url":"https://api.github.com/repos/jordanrh1/optee_os-public/pulls{/number}","milestones_url":"https://api.github.com/repos/jordanrh1/optee_os-public/milestones{/number}","notifications_url":"https://api.github.com/repos/jordanrh1/optee_os-public/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jordanrh1/optee_os-public/labels{/name}","releases_url":"https://api.github.com/repos/jordanrh1/optee_os-public/releases{/id}","deployments_url":"https://api.github.com/repos/jordanrh1/optee_os-public/deployments","created_at":"2018-02-27T22:21:49Z","updated_at":"2018-02-27T22:22:07Z","pushed_at":"2018-05-04T21:18:42Z","git_url":"git://github.com/jordanrh1/optee_os-public.git","ssh_url":"git@github.com:jordanrh1/optee_os-public.git","clone_url":"https://github.com/jordanrh1/optee_os-public.git","svn_url":"https://github.com/jordanrh1/optee_os-public","homepage":null,"size":13034,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"c27907e1bc5a46f3f95e72f901d7b0dfa3fa577f","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/optee_os/deployments","created_at":"2014-05-26T17:18:57Z","updated_at":"2018-05-05T09:31:26Z","pushed_at":"2018-05-04T21:19:59Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":13004,"stargazers_count":387,"watchers_count":387,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":337,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":337,"open_issues":180,"watchers":387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2301"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2301"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2301"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2301/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2301/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2301/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/b82be6722feb01226c46555caa3cef60dcf0c28d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jenswi-linaro"}}