{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/13504","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/13504/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/13504/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/13504/events","html_url":"https://github.com/highfidelity/hifi/pull/13504","id":336839974,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTk4NzM0","number":13504,"title":"RC69: fix case where vegas congestion control would not re-send lost ACK","user":{"login":"birarda","id":724069,"node_id":"MDQ6VXNlcjcyNDA2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/724069?v=4","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"labels":[{"id":314155368,"node_id":"MDU6TGFiZWwzMTQxNTUzNjg=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Development%20Approved","name":"Development Approved","color":"009800","default":false},{"id":313595519,"node_id":"MDU6TGFiZWwzMTM1OTU1MTk=","url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false},{"id":794364211,"node_id":"MDU6TGFiZWw3OTQzNjQyMTE=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Server%20&%20Network","name":"Server & Network","color":"f2bf8a","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/25","html_url":"https://github.com/highfidelity/hifi/milestone/25","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/25/labels","id":3163239,"node_id":"MDk6TWlsZXN0b25lMzE2MzIzOQ==","number":25,"title":"RC69","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":138,"state":"open","created_at":"2018-03-05T19:58:14Z","updated_at":"2018-06-29T17:44:13Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-06-29T02:19:17Z","updated_at":"2018-06-29T21:52:51Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/13504","html_url":"https://github.com/highfidelity/hifi/pull/13504","diff_url":"https://github.com/highfidelity/hifi/pull/13504.diff","patch_url":"https://github.com/highfidelity/hifi/pull/13504.patch"},"body":"This fixes an issue that affects all reliable connections but most notably was sometimes causing invisible avatars or stuck avatar entities."},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/401483359","html_url":"https://github.com/highfidelity/hifi/pull/13504#issuecomment-401483359","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/13504","id":401483359,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTQ4MzM1OQ==","user":{"login":"qlipdahlin","id":39308688,"node_id":"MDQ6VXNlcjM5MzA4Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/39308688?v=4","gravatar_id":"","url":"https://api.github.com/users/qlipdahlin","html_url":"https://github.com/qlipdahlin","followers_url":"https://api.github.com/users/qlipdahlin/followers","following_url":"https://api.github.com/users/qlipdahlin/following{/other_user}","gists_url":"https://api.github.com/users/qlipdahlin/gists{/gist_id}","starred_url":"https://api.github.com/users/qlipdahlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlipdahlin/subscriptions","organizations_url":"https://api.github.com/users/qlipdahlin/orgs","repos_url":"https://api.github.com/users/qlipdahlin/repos","events_url":"https://api.github.com/users/qlipdahlin/events{/privacy}","received_events_url":"https://api.github.com/users/qlipdahlin/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T21:52:51Z","updated_at":"2018-06-29T21:52:51Z","author_association":"NONE","body":"@conklin94122 PASS\r\n\r\nProceeded to DS Canada and worked with Birarda to reproduce the issue of stuck avatar entities. After a bit of work, reproduced 5 of 5 times fairly quickly. He would use clapp app rapidly and then change avatar, this would result in particle effects not appearing and when avatar is changed, the avatar would change its position to the position of the new avatar but would not change to the new avatar (being of light, artemis, small skeleton).\r\n\r\nInstalled new PR13504 build and using same steps, the system quickly (1-4 seconds) recovered 5 of 5 times. Avatar would change appropriately and particle effects would occasionally reappear.\r\n\r\nBirarda confirmed things were good on his end."}}
{"actor":{"display_login":"qlipdahlin"}}