{"action":"created","comment":{"url":"https://api.github.com/repos/rchain/rchain/pulls/comments/231040477","pull_request_review_id":171913773,"id":231040477,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTA0MDQ3Nw==","diff_hunk":"@@ -981,7 +988,7 @@ object ProcNormalizeMatcher {\n             case _: BundleWrite     => Bundle(targetResult.par, writeFlag = true, readFlag = false)\n             case _: BundleEquiv     => Bundle(targetResult.par, writeFlag = false, readFlag = false)\n           }\n-          res <- if (targetResult.par.connectiveUsed) {\n+          res <- if (targetResult.par.connectiveUsed && !isSimpleType(targetResult.par.connectives)) {","path":"rholang/src/main/scala/coop/rchain/rholang/interpreter/normalize.scala","position":19,"original_position":19,"commit_id":"16ffbc05fd6c72b1bc137f48bb7cf134774a3b37","original_commit_id":"16ffbc05fd6c72b1bc137f48bb7cf134774a3b37","user":{"login":"ArturGajowy","id":460141,"node_id":"MDQ6VXNlcjQ2MDE0MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460141?v=4","gravatar_id":"","url":"https://api.github.com/users/ArturGajowy","html_url":"https://github.com/ArturGajowy","followers_url":"https://api.github.com/users/ArturGajowy/followers","following_url":"https://api.github.com/users/ArturGajowy/following{/other_user}","gists_url":"https://api.github.com/users/ArturGajowy/gists{/gist_id}","starred_url":"https://api.github.com/users/ArturGajowy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArturGajowy/subscriptions","organizations_url":"https://api.github.com/users/ArturGajowy/orgs","repos_url":"https://api.github.com/users/ArturGajowy/repos","events_url":"https://api.github.com/users/ArturGajowy/events{/privacy}","received_events_url":"https://api.github.com/users/ArturGajowy/received_events","type":"User","site_admin":false},"body":"I think the root cause of this bug is using different data to check `if` there's a bug (`outputs.par.connectiveUsed`), and different to check `what's` the bug (`outputs.knwonFree.*`). I think what we should do is rely on `knownFree`, just as `Interpreter` does in `normalizeTerm`.\r\n\r\nThe only question that remains is whether we should at all allow connectives in the top level of a bundle. My examples above do that, but I'm not sure if they should be allowed.\r\n\r\n@pyrocto @guardbotmk3 Should we allow `logical connectives` in top level of a bundle? How about `simple type connectives`?","created_at":"2018-11-06T08:57:06Z","updated_at":"2018-11-06T08:57:07Z","html_url":"https://github.com/rchain/rchain/pull/1701#discussion_r231040477","pull_request_url":"https://api.github.com/repos/rchain/rchain/pulls/1701","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments/231040477"},"html":{"href":"https://github.com/rchain/rchain/pull/1701#discussion_r231040477"},"pull_request":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1701"}},"in_reply_to_id":226947162},"pull_request":{"url":"https://api.github.com/repos/rchain/rchain/pulls/1701","id":223544439,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNTQ0NDM5","html_url":"https://github.com/rchain/rchain/pull/1701","diff_url":"https://github.com/rchain/rchain/pull/1701.diff","patch_url":"https://github.com/rchain/rchain/pull/1701.patch","issue_url":"https://api.github.com/repos/rchain/rchain/issues/1701","number":1701,"state":"open","locked":false,"title":"RHOL-969: Make bundled simple types compile","user":{"login":"tymm","id":28924,"node_id":"MDQ6VXNlcjI4OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/28924?v=4","gravatar_id":"","url":"https://api.github.com/users/tymm","html_url":"https://github.com/tymm","followers_url":"https://api.github.com/users/tymm/followers","following_url":"https://api.github.com/users/tymm/following{/other_user}","gists_url":"https://api.github.com/users/tymm/gists{/gist_id}","starred_url":"https://api.github.com/users/tymm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tymm/subscriptions","organizations_url":"https://api.github.com/users/tymm/orgs","repos_url":"https://api.github.com/users/tymm/repos","events_url":"https://api.github.com/users/tymm/events{/privacy}","received_events_url":"https://api.github.com/users/tymm/received_events","type":"User","site_admin":false},"body":"## Overview\r\nBundling a simple type should compile.\r\n\r\n### Which JIRA issue does this PR relate to? If there is not a JIRA issue addressing this work, please create one now and add the link here.\r\nhttps://rchain.atlassian.net/browse/RHOL-969\r\n\r\n### Complete this checklist before you submit the PR\r\n- [x] This PR contains no more than 200 lines of code, excluding test code.\r\n- [x] This PR meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards).\r\n- [x] If this PR adds a new feature, this PR includes tests related to this feature.\r\n- [x] You assigned one person to review this PR","created_at":"2018-10-17T10:13:01Z","updated_at":"2018-11-06T08:57:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1a44d22b25ba80fc643a8eeb7dd2c1946ebe798","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rchain/rchain/pulls/1701/commits","review_comments_url":"https://api.github.com/repos/rchain/rchain/pulls/1701/comments","review_comment_url":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rchain/rchain/issues/1701/comments","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/16ffbc05fd6c72b1bc137f48bb7cf134774a3b37","head":{"label":"tymm:RHOL-969","ref":"RHOL-969","sha":"16ffbc05fd6c72b1bc137f48bb7cf134774a3b37","user":{"login":"tymm","id":28924,"node_id":"MDQ6VXNlcjI4OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/28924?v=4","gravatar_id":"","url":"https://api.github.com/users/tymm","html_url":"https://github.com/tymm","followers_url":"https://api.github.com/users/tymm/followers","following_url":"https://api.github.com/users/tymm/following{/other_user}","gists_url":"https://api.github.com/users/tymm/gists{/gist_id}","starred_url":"https://api.github.com/users/tymm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tymm/subscriptions","organizations_url":"https://api.github.com/users/tymm/orgs","repos_url":"https://api.github.com/users/tymm/repos","events_url":"https://api.github.com/users/tymm/events{/privacy}","received_events_url":"https://api.github.com/users/tymm/received_events","type":"User","site_admin":false},"repo":{"id":110008283,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwMDgyODM=","name":"rchain","full_name":"tymm/rchain","private":false,"owner":{"login":"tymm","id":28924,"node_id":"MDQ6VXNlcjI4OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/28924?v=4","gravatar_id":"","url":"https://api.github.com/users/tymm","html_url":"https://github.com/tymm","followers_url":"https://api.github.com/users/tymm/followers","following_url":"https://api.github.com/users/tymm/following{/other_user}","gists_url":"https://api.github.com/users/tymm/gists{/gist_id}","starred_url":"https://api.github.com/users/tymm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tymm/subscriptions","organizations_url":"https://api.github.com/users/tymm/orgs","repos_url":"https://api.github.com/users/tymm/repos","events_url":"https://api.github.com/users/tymm/events{/privacy}","received_events_url":"https://api.github.com/users/tymm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tymm/rchain","description":null,"fork":true,"url":"https://api.github.com/repos/tymm/rchain","forks_url":"https://api.github.com/repos/tymm/rchain/forks","keys_url":"https://api.github.com/repos/tymm/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tymm/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tymm/rchain/teams","hooks_url":"https://api.github.com/repos/tymm/rchain/hooks","issue_events_url":"https://api.github.com/repos/tymm/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/tymm/rchain/events","assignees_url":"https://api.github.com/repos/tymm/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/tymm/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/tymm/rchain/tags","blobs_url":"https://api.github.com/repos/tymm/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tymm/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tymm/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/tymm/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tymm/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/tymm/rchain/languages","stargazers_url":"https://api.github.com/repos/tymm/rchain/stargazers","contributors_url":"https://api.github.com/repos/tymm/rchain/contributors","subscribers_url":"https://api.github.com/repos/tymm/rchain/subscribers","subscription_url":"https://api.github.com/repos/tymm/rchain/subscription","commits_url":"https://api.github.com/repos/tymm/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/tymm/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/tymm/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/tymm/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/tymm/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/tymm/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tymm/rchain/merges","archive_url":"https://api.github.com/repos/tymm/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tymm/rchain/downloads","issues_url":"https://api.github.com/repos/tymm/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/tymm/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/tymm/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/tymm/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tymm/rchain/labels{/name}","releases_url":"https://api.github.com/repos/tymm/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/tymm/rchain/deployments","created_at":"2017-11-08T17:30:54Z","updated_at":"2017-11-08T17:30:57Z","pushed_at":"2018-10-29T10:41:19Z","git_url":"git://github.com/tymm/rchain.git","ssh_url":"git@github.com:tymm/rchain.git","clone_url":"https://github.com/tymm/rchain.git","svn_url":"https://github.com/tymm/rchain","homepage":null,"size":18922,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rchain:dev","ref":"dev","sha":"c302231310c5c78887820e072c6dcebee79660d6","user":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"repo":{"id":84493691,"node_id":"MDEwOlJlcG9zaXRvcnk4NDQ5MzY5MQ==","name":"rchain","full_name":"rchain/rchain","private":false,"owner":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rchain/rchain","description":null,"fork":false,"url":"https://api.github.com/repos/rchain/rchain","forks_url":"https://api.github.com/repos/rchain/rchain/forks","keys_url":"https://api.github.com/repos/rchain/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchain/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchain/rchain/teams","hooks_url":"https://api.github.com/repos/rchain/rchain/hooks","issue_events_url":"https://api.github.com/repos/rchain/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/rchain/rchain/events","assignees_url":"https://api.github.com/repos/rchain/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/rchain/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/rchain/rchain/tags","blobs_url":"https://api.github.com/repos/rchain/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchain/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchain/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchain/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/rchain/rchain/languages","stargazers_url":"https://api.github.com/repos/rchain/rchain/stargazers","contributors_url":"https://api.github.com/repos/rchain/rchain/contributors","subscribers_url":"https://api.github.com/repos/rchain/rchain/subscribers","subscription_url":"https://api.github.com/repos/rchain/rchain/subscription","commits_url":"https://api.github.com/repos/rchain/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchain/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchain/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchain/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchain/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/rchain/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchain/rchain/merges","archive_url":"https://api.github.com/repos/rchain/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchain/rchain/downloads","issues_url":"https://api.github.com/repos/rchain/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/rchain/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/rchain/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/rchain/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchain/rchain/labels{/name}","releases_url":"https://api.github.com/repos/rchain/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/rchain/rchain/deployments","created_at":"2017-03-09T22:15:35Z","updated_at":"2018-11-05T16:15:53Z","pushed_at":"2018-11-06T06:56:09Z","git_url":"git://github.com/rchain/rchain.git","ssh_url":"git@github.com:rchain/rchain.git","clone_url":"https://github.com/rchain/rchain.git","svn_url":"https://github.com/rchain/rchain","homepage":null,"size":19255,"stargazers_count":470,"watchers_count":470,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":139,"open_issues":62,"watchers":470,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1701"},"html":{"href":"https://github.com/rchain/rchain/pull/1701"},"issue":{"href":"https://api.github.com/repos/rchain/rchain/issues/1701"},"comments":{"href":"https://api.github.com/repos/rchain/rchain/issues/1701/comments"},"review_comments":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1701/comments"},"review_comment":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1701/commits"},"statuses":{"href":"https://api.github.com/repos/rchain/rchain/statuses/16ffbc05fd6c72b1bc137f48bb7cf134774a3b37"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ArturGajowy"}}