{"action":"created","comment":{"url":"https://api.github.com/repos/Uninett/nav/pulls/comments/241029346","pull_request_review_id":184196916,"id":241029346,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTAyOTM0Ng==","diff_hunk":"@@ -117,6 +117,11 @@ class AlertHistoryFilterBackend(filters.BaseFilterBackend):\n     }\n \n     def filter_queryset(self, request, queryset, view):\n+        if view.is_single_alert_by_primary_key():\n+            # no really, the client asked for a specific single alert, screw","path":"python/nav/web/api/v1/filter_backends.py","position":5,"original_position":5,"commit_id":"6ccbc02c8e4b01d5e8235c849c7b1f65da8fa825","original_commit_id":"6ccbc02c8e4b01d5e8235c849c7b1f65da8fa825","user":{"login":"lunkwill42","id":100995,"node_id":"MDQ6VXNlcjEwMDk5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/100995?v=4","gravatar_id":"","url":"https://api.github.com/users/lunkwill42","html_url":"https://github.com/lunkwill42","followers_url":"https://api.github.com/users/lunkwill42/followers","following_url":"https://api.github.com/users/lunkwill42/following{/other_user}","gists_url":"https://api.github.com/users/lunkwill42/gists{/gist_id}","starred_url":"https://api.github.com/users/lunkwill42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunkwill42/subscriptions","organizations_url":"https://api.github.com/users/lunkwill42/orgs","repos_url":"https://api.github.com/users/lunkwill42/repos","events_url":"https://api.github.com/users/lunkwill42/events{/privacy}","received_events_url":"https://api.github.com/users/lunkwill42/received_events","type":"User","site_admin":false},"body":";-)","created_at":"2018-12-12T14:15:43Z","updated_at":"2018-12-12T14:15:43Z","html_url":"https://github.com/Uninett/nav/pull/1809#discussion_r241029346","pull_request_url":"https://api.github.com/repos/Uninett/nav/pulls/1809","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Uninett/nav/pulls/comments/241029346"},"html":{"href":"https://github.com/Uninett/nav/pull/1809#discussion_r241029346"},"pull_request":{"href":"https://api.github.com/repos/Uninett/nav/pulls/1809"}},"in_reply_to_id":241027647},"pull_request":{"url":"https://api.github.com/repos/Uninett/nav/pulls/1809","id":236109814,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MTA5ODE0","html_url":"https://github.com/Uninett/nav/pull/1809","diff_url":"https://github.com/Uninett/nav/pull/1809.diff","patch_url":"https://github.com/Uninett/nav/pull/1809.patch","issue_url":"https://api.github.com/repos/Uninett/nav/issues/1809","number":1809,"state":"open","locked":false,"title":"The /alert API endpoint crashes with a TypeError","user":{"login":"lunkwill42","id":100995,"node_id":"MDQ6VXNlcjEwMDk5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/100995?v=4","gravatar_id":"","url":"https://api.github.com/users/lunkwill42","html_url":"https://github.com/lunkwill42","followers_url":"https://api.github.com/users/lunkwill42/followers","following_url":"https://api.github.com/users/lunkwill42/following{/other_user}","gists_url":"https://api.github.com/users/lunkwill42/gists{/gist_id}","starred_url":"https://api.github.com/users/lunkwill42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunkwill42/subscriptions","organizations_url":"https://api.github.com/users/lunkwill42/orgs","repos_url":"https://api.github.com/users/lunkwill42/repos","events_url":"https://api.github.com/users/lunkwill42/events{/privacy}","received_events_url":"https://api.github.com/users/lunkwill42/received_events","type":"User","site_admin":false},"body":"The problem seems to stem from upgrading the Django REST Framework dependency on the _master_ branch.\r\n\r\nI'm not entirely sure of how to solve this quite yet, but  I'm adding a test to expose the issue here.","created_at":"2018-12-05T09:54:13Z","updated_at":"2018-12-12T14:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f46ba9a9235be5f9bc224670644fe36a30498b0","assignee":{"login":"lunkwill42","id":100995,"node_id":"MDQ6VXNlcjEwMDk5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/100995?v=4","gravatar_id":"","url":"https://api.github.com/users/lunkwill42","html_url":"https://github.com/lunkwill42","followers_url":"https://api.github.com/users/lunkwill42/followers","following_url":"https://api.github.com/users/lunkwill42/following{/other_user}","gists_url":"https://api.github.com/users/lunkwill42/gists{/gist_id}","starred_url":"https://api.github.com/users/lunkwill42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunkwill42/subscriptions","organizations_url":"https://api.github.com/users/lunkwill42/orgs","repos_url":"https://api.github.com/users/lunkwill42/repos","events_url":"https://api.github.com/users/lunkwill42/events{/privacy}","received_events_url":"https://api.github.com/users/lunkwill42/received_events","type":"User","site_admin":false},"assignees":[{"login":"lunkwill42","id":100995,"node_id":"MDQ6VXNlcjEwMDk5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/100995?v=4","gravatar_id":"","url":"https://api.github.com/users/lunkwill42","html_url":"https://github.com/lunkwill42","followers_url":"https://api.github.com/users/lunkwill42/followers","following_url":"https://api.github.com/users/lunkwill42/following{/other_user}","gists_url":"https://api.github.com/users/lunkwill42/gists{/gist_id}","starred_url":"https://api.github.com/users/lunkwill42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunkwill42/subscriptions","organizations_url":"https://api.github.com/users/lunkwill42/orgs","repos_url":"https://api.github.com/users/lunkwill42/repos","events_url":"https://api.github.com/users/lunkwill42/events{/privacy}","received_events_url":"https://api.github.com/users/lunkwill42/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":520064765,"node_id":"MDU6TGFiZWw1MjAwNjQ3NjU=","url":"https://api.github.com/repos/Uninett/nav/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/Uninett/nav/pulls/1809/commits","review_comments_url":"https://api.github.com/repos/Uninett/nav/pulls/1809/comments","review_comment_url":"https://api.github.com/repos/Uninett/nav/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Uninett/nav/issues/1809/comments","statuses_url":"https://api.github.com/repos/Uninett/nav/statuses/6ccbc02c8e4b01d5e8235c849c7b1f65da8fa825","head":{"label":"lunkwill42:bugfix/alert-api-typeerror","ref":"bugfix/alert-api-typeerror","sha":"6ccbc02c8e4b01d5e8235c849c7b1f65da8fa825","user":{"login":"lunkwill42","id":100995,"node_id":"MDQ6VXNlcjEwMDk5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/100995?v=4","gravatar_id":"","url":"https://api.github.com/users/lunkwill42","html_url":"https://github.com/lunkwill42","followers_url":"https://api.github.com/users/lunkwill42/followers","following_url":"https://api.github.com/users/lunkwill42/following{/other_user}","gists_url":"https://api.github.com/users/lunkwill42/gists{/gist_id}","starred_url":"https://api.github.com/users/lunkwill42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunkwill42/subscriptions","organizations_url":"https://api.github.com/users/lunkwill42/orgs","repos_url":"https://api.github.com/users/lunkwill42/repos","events_url":"https://api.github.com/users/lunkwill42/events{/privacy}","received_events_url":"https://api.github.com/users/lunkwill42/received_events","type":"User","site_admin":false},"repo":{"id":80608543,"node_id":"MDEwOlJlcG9zaXRvcnk4MDYwODU0Mw==","name":"nav","full_name":"lunkwill42/nav","private":false,"owner":{"login":"lunkwill42","id":100995,"node_id":"MDQ6VXNlcjEwMDk5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/100995?v=4","gravatar_id":"","url":"https://api.github.com/users/lunkwill42","html_url":"https://github.com/lunkwill42","followers_url":"https://api.github.com/users/lunkwill42/followers","following_url":"https://api.github.com/users/lunkwill42/following{/other_user}","gists_url":"https://api.github.com/users/lunkwill42/gists{/gist_id}","starred_url":"https://api.github.com/users/lunkwill42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunkwill42/subscriptions","organizations_url":"https://api.github.com/users/lunkwill42/orgs","repos_url":"https://api.github.com/users/lunkwill42/repos","events_url":"https://api.github.com/users/lunkwill42/events{/privacy}","received_events_url":"https://api.github.com/users/lunkwill42/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lunkwill42/nav","description":"Network Administration Visualized","fork":true,"url":"https://api.github.com/repos/lunkwill42/nav","forks_url":"https://api.github.com/repos/lunkwill42/nav/forks","keys_url":"https://api.github.com/repos/lunkwill42/nav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lunkwill42/nav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lunkwill42/nav/teams","hooks_url":"https://api.github.com/repos/lunkwill42/nav/hooks","issue_events_url":"https://api.github.com/repos/lunkwill42/nav/issues/events{/number}","events_url":"https://api.github.com/repos/lunkwill42/nav/events","assignees_url":"https://api.github.com/repos/lunkwill42/nav/assignees{/user}","branches_url":"https://api.github.com/repos/lunkwill42/nav/branches{/branch}","tags_url":"https://api.github.com/repos/lunkwill42/nav/tags","blobs_url":"https://api.github.com/repos/lunkwill42/nav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lunkwill42/nav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lunkwill42/nav/git/refs{/sha}","trees_url":"https://api.github.com/repos/lunkwill42/nav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lunkwill42/nav/statuses/{sha}","languages_url":"https://api.github.com/repos/lunkwill42/nav/languages","stargazers_url":"https://api.github.com/repos/lunkwill42/nav/stargazers","contributors_url":"https://api.github.com/repos/lunkwill42/nav/contributors","subscribers_url":"https://api.github.com/repos/lunkwill42/nav/subscribers","subscription_url":"https://api.github.com/repos/lunkwill42/nav/subscription","commits_url":"https://api.github.com/repos/lunkwill42/nav/commits{/sha}","git_commits_url":"https://api.github.com/repos/lunkwill42/nav/git/commits{/sha}","comments_url":"https://api.github.com/repos/lunkwill42/nav/comments{/number}","issue_comment_url":"https://api.github.com/repos/lunkwill42/nav/issues/comments{/number}","contents_url":"https://api.github.com/repos/lunkwill42/nav/contents/{+path}","compare_url":"https://api.github.com/repos/lunkwill42/nav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lunkwill42/nav/merges","archive_url":"https://api.github.com/repos/lunkwill42/nav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lunkwill42/nav/downloads","issues_url":"https://api.github.com/repos/lunkwill42/nav/issues{/number}","pulls_url":"https://api.github.com/repos/lunkwill42/nav/pulls{/number}","milestones_url":"https://api.github.com/repos/lunkwill42/nav/milestones{/number}","notifications_url":"https://api.github.com/repos/lunkwill42/nav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lunkwill42/nav/labels{/name}","releases_url":"https://api.github.com/repos/lunkwill42/nav/releases{/id}","deployments_url":"https://api.github.com/repos/lunkwill42/nav/deployments","created_at":"2017-02-01T10:10:10Z","updated_at":"2018-11-30T10:17:34Z","pushed_at":"2018-12-06T09:40:57Z","git_url":"git://github.com/lunkwill42/nav.git","ssh_url":"git@github.com:lunkwill42/nav.git","clone_url":"https://github.com/lunkwill42/nav.git","svn_url":"https://github.com/lunkwill42/nav","homepage":null,"size":104237,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Uninett:master","ref":"master","sha":"5e0a1faab6632abe52108a7c8a6037458d8531b4","user":{"login":"Uninett","id":778970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODk3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/778970?v=4","gravatar_id":"","url":"https://api.github.com/users/Uninett","html_url":"https://github.com/Uninett","followers_url":"https://api.github.com/users/Uninett/followers","following_url":"https://api.github.com/users/Uninett/following{/other_user}","gists_url":"https://api.github.com/users/Uninett/gists{/gist_id}","starred_url":"https://api.github.com/users/Uninett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Uninett/subscriptions","organizations_url":"https://api.github.com/users/Uninett/orgs","repos_url":"https://api.github.com/users/Uninett/repos","events_url":"https://api.github.com/users/Uninett/events{/privacy}","received_events_url":"https://api.github.com/users/Uninett/received_events","type":"Organization","site_admin":false},"repo":{"id":79214421,"node_id":"MDEwOlJlcG9zaXRvcnk3OTIxNDQyMQ==","name":"nav","full_name":"Uninett/nav","private":false,"owner":{"login":"Uninett","id":778970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODk3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/778970?v=4","gravatar_id":"","url":"https://api.github.com/users/Uninett","html_url":"https://github.com/Uninett","followers_url":"https://api.github.com/users/Uninett/followers","following_url":"https://api.github.com/users/Uninett/following{/other_user}","gists_url":"https://api.github.com/users/Uninett/gists{/gist_id}","starred_url":"https://api.github.com/users/Uninett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Uninett/subscriptions","organizations_url":"https://api.github.com/users/Uninett/orgs","repos_url":"https://api.github.com/users/Uninett/repos","events_url":"https://api.github.com/users/Uninett/events{/privacy}","received_events_url":"https://api.github.com/users/Uninett/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Uninett/nav","description":"Network Administration Visualized","fork":false,"url":"https://api.github.com/repos/Uninett/nav","forks_url":"https://api.github.com/repos/Uninett/nav/forks","keys_url":"https://api.github.com/repos/Uninett/nav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Uninett/nav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Uninett/nav/teams","hooks_url":"https://api.github.com/repos/Uninett/nav/hooks","issue_events_url":"https://api.github.com/repos/Uninett/nav/issues/events{/number}","events_url":"https://api.github.com/repos/Uninett/nav/events","assignees_url":"https://api.github.com/repos/Uninett/nav/assignees{/user}","branches_url":"https://api.github.com/repos/Uninett/nav/branches{/branch}","tags_url":"https://api.github.com/repos/Uninett/nav/tags","blobs_url":"https://api.github.com/repos/Uninett/nav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Uninett/nav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Uninett/nav/git/refs{/sha}","trees_url":"https://api.github.com/repos/Uninett/nav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Uninett/nav/statuses/{sha}","languages_url":"https://api.github.com/repos/Uninett/nav/languages","stargazers_url":"https://api.github.com/repos/Uninett/nav/stargazers","contributors_url":"https://api.github.com/repos/Uninett/nav/contributors","subscribers_url":"https://api.github.com/repos/Uninett/nav/subscribers","subscription_url":"https://api.github.com/repos/Uninett/nav/subscription","commits_url":"https://api.github.com/repos/Uninett/nav/commits{/sha}","git_commits_url":"https://api.github.com/repos/Uninett/nav/git/commits{/sha}","comments_url":"https://api.github.com/repos/Uninett/nav/comments{/number}","issue_comment_url":"https://api.github.com/repos/Uninett/nav/issues/comments{/number}","contents_url":"https://api.github.com/repos/Uninett/nav/contents/{+path}","compare_url":"https://api.github.com/repos/Uninett/nav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Uninett/nav/merges","archive_url":"https://api.github.com/repos/Uninett/nav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Uninett/nav/downloads","issues_url":"https://api.github.com/repos/Uninett/nav/issues{/number}","pulls_url":"https://api.github.com/repos/Uninett/nav/pulls{/number}","milestones_url":"https://api.github.com/repos/Uninett/nav/milestones{/number}","notifications_url":"https://api.github.com/repos/Uninett/nav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Uninett/nav/labels{/name}","releases_url":"https://api.github.com/repos/Uninett/nav/releases{/id}","deployments_url":"https://api.github.com/repos/Uninett/nav/deployments","created_at":"2017-01-17T10:05:09Z","updated_at":"2018-12-07T07:16:15Z","pushed_at":"2018-12-12T14:13:38Z","git_url":"git://github.com/Uninett/nav.git","ssh_url":"git@github.com:Uninett/nav.git","clone_url":"https://github.com/Uninett/nav.git","svn_url":"https://github.com/Uninett/nav","homepage":null,"size":104225,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":123,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":17,"open_issues":123,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Uninett/nav/pulls/1809"},"html":{"href":"https://github.com/Uninett/nav/pull/1809"},"issue":{"href":"https://api.github.com/repos/Uninett/nav/issues/1809"},"comments":{"href":"https://api.github.com/repos/Uninett/nav/issues/1809/comments"},"review_comments":{"href":"https://api.github.com/repos/Uninett/nav/pulls/1809/comments"},"review_comment":{"href":"https://api.github.com/repos/Uninett/nav/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Uninett/nav/pulls/1809/commits"},"statuses":{"href":"https://api.github.com/repos/Uninett/nav/statuses/6ccbc02c8e4b01d5e8235c849c7b1f65da8fa825"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lunkwill42"}}