{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/22308","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22308/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22308/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22308/events","html_url":"https://github.com/cms-sw/cmssw/pull/22308","id":299452149,"number":22308,"title":"EGMiniAODV2 : 10_1_X","user":{"login":"Sam-Harper","id":5021403,"avatar_url":"https://avatars2.githubusercontent.com/u/5021403?v=4","gravatar_id":"","url":"https://api.github.com/users/Sam-Harper","html_url":"https://github.com/Sam-Harper","followers_url":"https://api.github.com/users/Sam-Harper/followers","following_url":"https://api.github.com/users/Sam-Harper/following{/other_user}","gists_url":"https://api.github.com/users/Sam-Harper/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam-Harper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam-Harper/subscriptions","organizations_url":"https://api.github.com/users/Sam-Harper/orgs","repos_url":"https://api.github.com/users/Sam-Harper/repos","events_url":"https://api.github.com/users/Sam-Harper/events{/privacy}","received_events_url":"https://api.github.com/users/Sam-Harper/received_events","type":"User","site_admin":false},"labels":[{"id":52881179,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04","default":false},{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"009800","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":170521617,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/73","html_url":"https://github.com/cms-sw/cmssw/milestone/73","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/73/labels","id":3060828,"number":73,"title":"CMSSW_10_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":82,"closed_issues":312,"state":"open","created_at":"2018-01-24T11:24:59Z","updated_at":"2018-02-28T20:16:01Z","due_on":null,"closed_at":null},"comments":86,"created_at":"2018-02-22T18:03:31Z","updated_at":"2018-02-28T21:47:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22308","html_url":"https://github.com/cms-sw/cmssw/pull/22308","diff_url":"https://github.com/cms-sw/cmssw/pull/22308.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/22308.patch"},"body":"Dear All,\r\n\r\nThis is the miniAOD V2 PR in a 10_1_X flavour. \r\n\r\nIt mostly involves adapting the Energy Scale & Smearing code to be able to put it into the pat::Electron. I freely admit, the design is not the best, I had to work with what I had. \r\n\r\nThis PR does two things\r\n1) enables 2016/2017 IDs in the miniAOD and also stores the bit maps of the cuts for the cut based IDs, everything is embeded in pat::Electron,pat::Photon as well as removing all old IDs. This is the more or less trival bit\r\n2) lays the ground work to apply the residual scale and smearing corrections to electrons. As these scale and smearing are only appropriate to 2017 Fall17 re-reco, these corrections are not actually enabled in the sequence as I dont want them run in the release. The 94X flavour of this does of course enable it.\r\n\r\nThe scale and smearing is the bigger of the two. First @shervin86  enabled this to be gain dependent and updated to the latest way of doing the corrections. Then I modified this code to fit the needs better, I made the CalibratedElectronRun2 and CalibratedPhotonRun2 producers more robust, wrote out some more variables and generally made the code more compact. I also added two modes, one where it does not write out the calibrated electrons/photons, just the value maps with the energy + sys errors and another where it now has a deterministic random number based on the event nr, runnr, lumiSec, supercluster seed id and number of crystals in the supercluster. This means the electron and photon get the same random number when they are the same object. If there is no stored supercluster, I fall back to a modified method @gpetruc had already implemented (in fact it was highly inspired by his code). \r\n\r\nIn order to deal with all the value maps,  the best option was to calibrate inside the reducedEgammaProducer. This producer also gathers up all the calibrated energy ValueMaps keyed to the gsfElectrons/gedPhotons in the same way it does for the other valuemaps.\r\n\r\nThen in the slimming stage, these can be embeded in the pat::Electron/Photon via the normal means. \r\n\r\nThe only thing I'm not sure of is I need some files data files in EgammaAnalysis/ElectronTools/data, but there is no repo for this in cms-data, who do I contact to deal with that. \r\n\r\n@lsoffi @varuns23 @jainshilpi @shervin86 "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/369394525","html_url":"https://github.com/cms-sw/cmssw/pull/22308#issuecomment-369394525","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22308","id":369394525,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2018-02-28T21:47:47Z","updated_at":"2018-02-28T21:47:47Z","author_association":"CONTRIBUTOR","body":"-1\n\nTested at: 7a27eab0bf4aae561ca84573e7e95bf2d278c2c7\n\nYou can see the results of the tests here:\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22308/26384/summary.html\n\nI found follow errors while testing this PR\n\n**Failed tests:  UnitTests  RelVals**\n\n* **Unit Tests**:\n\nI found errors in the following unit tests: \n \n ---> test runtestPhysicsToolsNanoAOD had ERRORS\n\n\n* **RelVals**:\n\nWhen I ran the RelVals I found an error in the following worklfows:\n1325.7 step2\n<pre>runTheMatrix-results/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017/step2_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017.log\n\n</pre>136.8311 step2\n<pre>runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log\n\n</pre>\n"}}
{"actor":{"display_login":"cmsbuild"}}