{"action":"created","issue":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/549","repository_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase","labels_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/549/labels{/name}","comments_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/549/comments","events_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/549/events","html_url":"https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/549","id":275808341,"number":549,"title":"Basic integration of Crashlytics for iOS...","user":{"login":"DickSmith","id":6675511,"avatar_url":"https://avatars0.githubusercontent.com/u/6675511?v=4","gravatar_id":"","url":"https://api.github.com/users/DickSmith","html_url":"https://github.com/DickSmith","followers_url":"https://api.github.com/users/DickSmith/followers","following_url":"https://api.github.com/users/DickSmith/following{/other_user}","gists_url":"https://api.github.com/users/DickSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/DickSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DickSmith/subscriptions","organizations_url":"https://api.github.com/users/DickSmith/orgs","repos_url":"https://api.github.com/users/DickSmith/repos","events_url":"https://api.github.com/users/DickSmith/events{/privacy}","received_events_url":"https://api.github.com/users/DickSmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2017-11-21T18:04:26Z","updated_at":"2018-03-07T19:49:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/pulls/549","html_url":"https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/549","diff_url":"https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/549.diff","patch_url":"https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/549.patch"},"body":"...including automatic dSYM uploads. Based on @hypery2k 's `nativescript-fabric` plugin.\r\n\r\nSince it is only for iOS right now, both original Firebase `crash_reporting` and `crashlytics` can be enabled. If `crashlytics` is enabled, then `crash_reporting` is disabled for iOS, but still enabled for Android.\r\nI prioritized Crashlytics for iOS since the original `crash_reporting` works well enough for Android issues (even with uglify on, but no obfuscation on proguard), but for iOS without dSYM it's almost impossible to decode most of them. The Crashlytics for Firebase offered the easiest solution for automatic dSYM uploading. For Crashlytics dSYM to be properly generated, bitcode must be disabled, which is done via the podfile for all targets.\r\n\r\nI have this running in Prod with 30,000+ daily users.\r\n\r\nTODOs: implement Android; integrate custom logging"},"comment":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/comments/371262240","html_url":"https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/549#issuecomment-371262240","issue_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/549","id":371262240,"user":{"login":"DickSmith","id":6675511,"avatar_url":"https://avatars0.githubusercontent.com/u/6675511?v=4","gravatar_id":"","url":"https://api.github.com/users/DickSmith","html_url":"https://github.com/DickSmith","followers_url":"https://api.github.com/users/DickSmith/followers","following_url":"https://api.github.com/users/DickSmith/following{/other_user}","gists_url":"https://api.github.com/users/DickSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/DickSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DickSmith/subscriptions","organizations_url":"https://api.github.com/users/DickSmith/orgs","repos_url":"https://api.github.com/users/DickSmith/repos","events_url":"https://api.github.com/users/DickSmith/events{/privacy}","received_events_url":"https://api.github.com/users/DickSmith/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T19:49:44Z","updated_at":"2018-03-07T19:49:44Z","author_association":"NONE","body":"@EddyVerbruggen \r\nIt also looks like this commit ended up on this PR which fixes an issue I was seeing in Android: https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/549/commits/bb5bb5e25bc4cdf53838241134d47ccc25b1af81\r\n\r\nIf you want I can revert it and submit it in another PR, or leave it."}}
{"actor":{"display_login":"DickSmith"}}