{"action":"created","issue":{"url":"https://api.github.com/repos/coyote-team/coyote/issues/314","repository_url":"https://api.github.com/repos/coyote-team/coyote","labels_url":"https://api.github.com/repos/coyote-team/coyote/issues/314/labels{/name}","comments_url":"https://api.github.com/repos/coyote-team/coyote/issues/314/comments","events_url":"https://api.github.com/repos/coyote-team/coyote/issues/314/events","html_url":"https://github.com/coyote-team/coyote/pull/314","id":366183866,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTIxMTYz","number":314,"title":"fix select all feature on representations view, closes #202","user":{"login":"stacietaylorcima","id":25017973,"node_id":"MDQ6VXNlcjI1MDE3OTcz","avatar_url":"https://avatars0.githubusercontent.com/u/25017973?v=4","gravatar_id":"","url":"https://api.github.com/users/stacietaylorcima","html_url":"https://github.com/stacietaylorcima","followers_url":"https://api.github.com/users/stacietaylorcima/followers","following_url":"https://api.github.com/users/stacietaylorcima/following{/other_user}","gists_url":"https://api.github.com/users/stacietaylorcima/gists{/gist_id}","starred_url":"https://api.github.com/users/stacietaylorcima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stacietaylorcima/subscriptions","organizations_url":"https://api.github.com/users/stacietaylorcima/orgs","repos_url":"https://api.github.com/users/stacietaylorcima/repos","events_url":"https://api.github.com/users/stacietaylorcima/events{/privacy}","received_events_url":"https://api.github.com/users/stacietaylorcima/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-03T05:46:20Z","updated_at":"2018-10-03T15:13:12Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/coyote-team/coyote/pulls/314","html_url":"https://github.com/coyote-team/coyote/pull/314","diff_url":"https://github.com/coyote-team/coyote/pull/314.diff","patch_url":"https://github.com/coyote-team/coyote/pull/314.patch"},"body":"Ok, so the fix was to remove the `non-mobile-only` class from the toolbar-item. I cannot explain it, but that did the trick. So 2 questions: \r\n\r\n1. Any idea why that was messing it up? \r\n\r\n2. Can you think of a way we can still apply that class and not have it affect the functionality of the select all? \r\n\r\n@flipsasser "},"comment":{"url":"https://api.github.com/repos/coyote-team/coyote/issues/comments/426674712","html_url":"https://github.com/coyote-team/coyote/pull/314#issuecomment-426674712","issue_url":"https://api.github.com/repos/coyote-team/coyote/issues/314","id":426674712,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjY3NDcxMg==","user":{"login":"sinabahram","id":1811181,"node_id":"MDQ6VXNlcjE4MTExODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1811181?v=4","gravatar_id":"","url":"https://api.github.com/users/sinabahram","html_url":"https://github.com/sinabahram","followers_url":"https://api.github.com/users/sinabahram/followers","following_url":"https://api.github.com/users/sinabahram/following{/other_user}","gists_url":"https://api.github.com/users/sinabahram/gists{/gist_id}","starred_url":"https://api.github.com/users/sinabahram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinabahram/subscriptions","organizations_url":"https://api.github.com/users/sinabahram/orgs","repos_url":"https://api.github.com/users/sinabahram/repos","events_url":"https://api.github.com/users/sinabahram/events{/privacy}","received_events_url":"https://api.github.com/users/sinabahram/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T15:13:12Z","updated_at":"2018-10-03T15:13:12Z","author_association":"COLLABORATOR","body":"So I can understand, you are saying that removing this class from the toolbar, and only doing that one change, resulted in “Select All” no longer selecting all possible objects, but only those on the currently displayed screen through pagination?\n\n \n\nYou have tested this on data spanning multiple pages, and for example, on each of the first three pages and last page, just to make sure there’s no edge conditions, and only removing that class, resulted in “select all” working how we want?\n\n \n\nI agree that, if that’s the case, that’s beyond super odd.\n\n \n\n@FlipSasser?\n\n"}}
{"actor":{"display_login":"sinabahram"}}