{"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/zend-http/pulls/comments/209715933","pull_request_review_id":145783115,"id":209715933,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTcxNTkzMw==","diff_hunk":"@@ -524,4 +524,59 @@ public function testFormUrlEncodeSeparator()\n         $rawRequest = $client->getLastRawRequest();\n         $this->assertContains('foo=bar&baz=foo', $rawRequest);\n     }\n+\n+    public function uriDataProvider()\n+    {\n+        return [\n+            ['/example', true],\n+            ['http://localhost/example', false]\n+        ];\n+    }\n+\n+    /**\n+     * @dataProvider uriDataProvider\n+     */\n+    public function testValidRelativeURI($uri, $isValidRelativeURI)","path":"test/ClientTest.php","position":16,"original_position":16,"commit_id":"b4e1344f03752c0cfdb4edbf08d38d12a2d8d577","original_commit_id":"b4e1344f03752c0cfdb4edbf08d38d12a2d8d577","user":{"login":"weierophinney","id":25943,"node_id":"MDQ6VXNlcjI1OTQz","avatar_url":"https://avatars1.githubusercontent.com/u/25943?v=4","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"body":"What _behavior_ is this testing, exactly? This should likely be \"testUriCorrectlyDeterminesWhetherOrNotItIsAValidRelativeUri\".","created_at":"2018-08-13T18:41:19Z","updated_at":"2018-08-13T18:44:53Z","html_url":"https://github.com/zendframework/zend-http/pull/149#discussion_r209715933","pull_request_url":"https://api.github.com/repos/zendframework/zend-http/pulls/149","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-http/pulls/comments/209715933"},"html":{"href":"https://github.com/zendframework/zend-http/pull/149#discussion_r209715933"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zend-http/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-http/pulls/149","id":186186294,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2MTg2Mjk0","html_url":"https://github.com/zendframework/zend-http/pull/149","diff_url":"https://github.com/zendframework/zend-http/pull/149.diff","patch_url":"https://github.com/zendframework/zend-http/pull/149.patch","issue_url":"https://api.github.com/repos/zendframework/zend-http/issues/149","number":149,"state":"open","locked":false,"title":"Fixes #36 Client::setUri() should keep relative uri status","user":{"login":"samsonasik","id":459648,"node_id":"MDQ6VXNlcjQ1OTY0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/459648?v=4","gravatar_id":"","url":"https://api.github.com/users/samsonasik","html_url":"https://github.com/samsonasik","followers_url":"https://api.github.com/users/samsonasik/followers","following_url":"https://api.github.com/users/samsonasik/following{/other_user}","gists_url":"https://api.github.com/users/samsonasik/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonasik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonasik/subscriptions","organizations_url":"https://api.github.com/users/samsonasik/orgs","repos_url":"https://api.github.com/users/samsonasik/repos","events_url":"https://api.github.com/users/samsonasik/events{/privacy}","received_events_url":"https://api.github.com/users/samsonasik/received_events","type":"User","site_admin":false},"body":"Provide a narrative description of what you are trying to accomplish:\r\n\r\n- [x] Are you fixing a bug?\r\n  - [x] Detail how the bug is invoked currently.\r\n          Supply relative uri to `Client::setUri()`\r\n  - [x] Detail the original, incorrect behavior.\r\n          It convert to absolute uri\r\n  - [x] Detail the new, expected behavior.\r\n          It should keep as relative uri \r\n  - [x] Base your feature on the `master` branch, and submit against that branch.\r\n  - [x] Add a regression test that demonstrates the bug, and proves the fix.\r\n  - [x] Add a `CHANGELOG.md` entry for the fix.\r\n\r\n","created_at":"2018-05-06T03:26:43Z","updated_at":"2018-08-13T18:44:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f08a4e0e4e02406edef42894a59c176e4e1a9228","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zendframework/zend-http/pulls/149/commits","review_comments_url":"https://api.github.com/repos/zendframework/zend-http/pulls/149/comments","review_comment_url":"https://api.github.com/repos/zendframework/zend-http/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/zend-http/issues/149/comments","statuses_url":"https://api.github.com/repos/zendframework/zend-http/statuses/b4e1344f03752c0cfdb4edbf08d38d12a2d8d577","head":{"label":"samsonasik:fix-36","ref":"fix-36","sha":"b4e1344f03752c0cfdb4edbf08d38d12a2d8d577","user":{"login":"samsonasik","id":459648,"node_id":"MDQ6VXNlcjQ1OTY0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/459648?v=4","gravatar_id":"","url":"https://api.github.com/users/samsonasik","html_url":"https://github.com/samsonasik","followers_url":"https://api.github.com/users/samsonasik/followers","following_url":"https://api.github.com/users/samsonasik/following{/other_user}","gists_url":"https://api.github.com/users/samsonasik/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonasik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonasik/subscriptions","organizations_url":"https://api.github.com/users/samsonasik/orgs","repos_url":"https://api.github.com/users/samsonasik/repos","events_url":"https://api.github.com/users/samsonasik/events{/privacy}","received_events_url":"https://api.github.com/users/samsonasik/received_events","type":"User","site_admin":false},"repo":{"id":36901069,"node_id":"MDEwOlJlcG9zaXRvcnkzNjkwMTA2OQ==","name":"zend-http","full_name":"samsonasik/zend-http","owner":{"login":"samsonasik","id":459648,"node_id":"MDQ6VXNlcjQ1OTY0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/459648?v=4","gravatar_id":"","url":"https://api.github.com/users/samsonasik","html_url":"https://github.com/samsonasik","followers_url":"https://api.github.com/users/samsonasik/followers","following_url":"https://api.github.com/users/samsonasik/following{/other_user}","gists_url":"https://api.github.com/users/samsonasik/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonasik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonasik/subscriptions","organizations_url":"https://api.github.com/users/samsonasik/orgs","repos_url":"https://api.github.com/users/samsonasik/repos","events_url":"https://api.github.com/users/samsonasik/events{/privacy}","received_events_url":"https://api.github.com/users/samsonasik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samsonasik/zend-http","description":"Http component from Zend Framework","fork":true,"url":"https://api.github.com/repos/samsonasik/zend-http","forks_url":"https://api.github.com/repos/samsonasik/zend-http/forks","keys_url":"https://api.github.com/repos/samsonasik/zend-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsonasik/zend-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsonasik/zend-http/teams","hooks_url":"https://api.github.com/repos/samsonasik/zend-http/hooks","issue_events_url":"https://api.github.com/repos/samsonasik/zend-http/issues/events{/number}","events_url":"https://api.github.com/repos/samsonasik/zend-http/events","assignees_url":"https://api.github.com/repos/samsonasik/zend-http/assignees{/user}","branches_url":"https://api.github.com/repos/samsonasik/zend-http/branches{/branch}","tags_url":"https://api.github.com/repos/samsonasik/zend-http/tags","blobs_url":"https://api.github.com/repos/samsonasik/zend-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsonasik/zend-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsonasik/zend-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsonasik/zend-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsonasik/zend-http/statuses/{sha}","languages_url":"https://api.github.com/repos/samsonasik/zend-http/languages","stargazers_url":"https://api.github.com/repos/samsonasik/zend-http/stargazers","contributors_url":"https://api.github.com/repos/samsonasik/zend-http/contributors","subscribers_url":"https://api.github.com/repos/samsonasik/zend-http/subscribers","subscription_url":"https://api.github.com/repos/samsonasik/zend-http/subscription","commits_url":"https://api.github.com/repos/samsonasik/zend-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsonasik/zend-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsonasik/zend-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsonasik/zend-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/samsonasik/zend-http/contents/{+path}","compare_url":"https://api.github.com/repos/samsonasik/zend-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsonasik/zend-http/merges","archive_url":"https://api.github.com/repos/samsonasik/zend-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsonasik/zend-http/downloads","issues_url":"https://api.github.com/repos/samsonasik/zend-http/issues{/number}","pulls_url":"https://api.github.com/repos/samsonasik/zend-http/pulls{/number}","milestones_url":"https://api.github.com/repos/samsonasik/zend-http/milestones{/number}","notifications_url":"https://api.github.com/repos/samsonasik/zend-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsonasik/zend-http/labels{/name}","releases_url":"https://api.github.com/repos/samsonasik/zend-http/releases{/id}","deployments_url":"https://api.github.com/repos/samsonasik/zend-http/deployments","created_at":"2015-06-04T23:23:59Z","updated_at":"2015-06-04T23:24:00Z","pushed_at":"2018-08-13T18:37:37Z","git_url":"git://github.com/samsonasik/zend-http.git","ssh_url":"git@github.com:samsonasik/zend-http.git","clone_url":"https://github.com/samsonasik/zend-http.git","svn_url":"https://github.com/samsonasik/zend-http","homepage":null,"size":36087,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"9812b6e14b8e94ac0bfaece955bc863df2fcf309","user":{"login":"zendframework","id":296074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjA3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/296074?v=4","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":35640139,"node_id":"MDEwOlJlcG9zaXRvcnkzNTY0MDEzOQ==","name":"zend-http","full_name":"zendframework/zend-http","owner":{"login":"zendframework","id":296074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjA3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/296074?v=4","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zend-http","description":"Http component from Zend Framework","fork":false,"url":"https://api.github.com/repos/zendframework/zend-http","forks_url":"https://api.github.com/repos/zendframework/zend-http/forks","keys_url":"https://api.github.com/repos/zendframework/zend-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zend-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zend-http/teams","hooks_url":"https://api.github.com/repos/zendframework/zend-http/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zend-http/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zend-http/events","assignees_url":"https://api.github.com/repos/zendframework/zend-http/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zend-http/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zend-http/tags","blobs_url":"https://api.github.com/repos/zendframework/zend-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zend-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zend-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zend-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zend-http/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zend-http/languages","stargazers_url":"https://api.github.com/repos/zendframework/zend-http/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zend-http/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zend-http/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zend-http/subscription","commits_url":"https://api.github.com/repos/zendframework/zend-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zend-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zend-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zend-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/zend-http/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zend-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zend-http/merges","archive_url":"https://api.github.com/repos/zendframework/zend-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zend-http/downloads","issues_url":"https://api.github.com/repos/zendframework/zend-http/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zend-http/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zend-http/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zend-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zend-http/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zend-http/releases{/id}","deployments_url":"https://api.github.com/repos/zendframework/zend-http/deployments","created_at":"2015-05-14T22:23:50Z","updated_at":"2018-08-13T18:37:22Z","pushed_at":"2018-08-13T18:37:22Z","git_url":"git://github.com/zendframework/zend-http.git","ssh_url":"git@github.com:zendframework/zend-http.git","clone_url":"https://github.com/zendframework/zend-http.git","svn_url":"https://github.com/zendframework/zend-http","homepage":null,"size":37578,"stargazers_count":70,"watchers_count":70,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":71,"open_issues":38,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-http/pulls/149"},"html":{"href":"https://github.com/zendframework/zend-http/pull/149"},"issue":{"href":"https://api.github.com/repos/zendframework/zend-http/issues/149"},"comments":{"href":"https://api.github.com/repos/zendframework/zend-http/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zend-http/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zend-http/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zend-http/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zend-http/statuses/b4e1344f03752c0cfdb4edbf08d38d12a2d8d577"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"weierophinney"}}