{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/174312041","pull_request_review_id":103645363,"id":174312041,"diff_hunk":"@@ -527,6 +585,7 @@ class RegisterDomainStep extends React.Component {\n \t\t\ttld_weight_overrides: null,\n \t\t\tvendor: 'wpcom',\n \t\t\tvertical: this.props.surveyVertical,\n+\t\t\t...this.getSetFilters(),","path":"client/components/domains/register-domain-step/index.jsx","position":165,"original_position":165,"commit_id":"bf994f85f4cebffe06c977124d907b7e5d46ffea","original_commit_id":"bf994f85f4cebffe06c977124d907b7e5d46ffea","user":{"login":"klimeryk","id":3392497,"avatar_url":"https://avatars0.githubusercontent.com/u/3392497?v=4","gravatar_id":"","url":"https://api.github.com/users/klimeryk","html_url":"https://github.com/klimeryk","followers_url":"https://api.github.com/users/klimeryk/followers","following_url":"https://api.github.com/users/klimeryk/following{/other_user}","gists_url":"https://api.github.com/users/klimeryk/gists{/gist_id}","starred_url":"https://api.github.com/users/klimeryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klimeryk/subscriptions","organizations_url":"https://api.github.com/users/klimeryk/orgs","repos_url":"https://api.github.com/users/klimeryk/repos","events_url":"https://api.github.com/users/klimeryk/events{/privacy}","received_events_url":"https://api.github.com/users/klimeryk/received_events","type":"User","site_admin":false},"body":"When we send queries to the backend, we use `snake_case`, not `camelCase` - it'd be great for consistency to stick to that convention. lodash has a [nifty utility function called, well, `snakeCase`](https://lodash.com/docs/#snakeCase) that should make this easy.","created_at":"2018-03-13T23:06:12Z","updated_at":"2018-03-13T23:06:12Z","html_url":"https://github.com/Automattic/wp-calypso/pull/22965#discussion_r174312041","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22965","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/174312041"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/22965#discussion_r174312041"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22965"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22965","id":172639473,"html_url":"https://github.com/Automattic/wp-calypso/pull/22965","diff_url":"https://github.com/Automattic/wp-calypso/pull/22965.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/22965.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/22965","number":22965,"state":"open","locked":false,"title":"Implement domain search filters: \"More Filters\"","user":{"login":"jsnmoon","id":4044428,"avatar_url":"https://avatars2.githubusercontent.com/u/4044428?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnmoon","html_url":"https://github.com/jsnmoon","followers_url":"https://api.github.com/users/jsnmoon/followers","following_url":"https://api.github.com/users/jsnmoon/following{/other_user}","gists_url":"https://api.github.com/users/jsnmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnmoon/subscriptions","organizations_url":"https://api.github.com/users/jsnmoon/orgs","repos_url":"https://api.github.com/users/jsnmoon/repos","events_url":"https://api.github.com/users/jsnmoon/events{/privacy}","received_events_url":"https://api.github.com/users/jsnmoon/received_events","type":"User","site_admin":false},"body":"This change adds the first domain filters to the `/start/domains` section of the user signup experience. It adds a `<SearchFilters>` component to `<RegisterDomainStep>` signup component. `SearchFilters` is designed to hold multiple search filter components and currently holds `<MoreFiltersControl>` for managing max character, exact match, and exclude dashes filters.\r\n\r\n![domain_search_filters](https://user-images.githubusercontent.com/4044428/37312070-32aa483e-260f-11e8-9619-2a06754922ba.png)\r\n \r\n### Testing instructions\r\n1. Spin up this branch locally.\r\n2. Navigate to [`/start/domains`](http://calypso.localhost:3000/start/domains).\r\n3. Ensure presence of the `More Filters` popover button.\r\n4. Ensure that clicking the button spawns a popover with the following controls:\r\n    - Max characters filter, defaulting to empty.\r\n    - Exact matches filter, defaulting to unchecked (false).\r\n    - Exclude dashes filter, defaulting to checked (true).\r\n5. Ensure that enacting any of the filters by clicking `Apply` refreshes the domain search with a corresponding network request. Two things to note:\r\n    - The results will not actually be filtered since such functionality has not yet been implemented in the server.\r\n    - In its current design, the network request will only contain filter values that are defined. Currently, that means either a true/false boolean or a lengthy string containing numbers.\r\n\r\n![wordpress_com](https://user-images.githubusercontent.com/4044428/37312781-0b00bae0-2612-11e8-8e82-1c70e8c8ca0c.png)\r\n\r\n6. Ensure that resetting the filters by clicking `Reset` refreshes the domain search results with a corresponding network request.\r\n\r\n7. Ensure that no other behavioral changes have been introduced to the page.","created_at":"2018-03-03T01:00:48Z","updated_at":"2018-03-13T23:06:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdd9d5607c201bc1a8586b160131577d8955a3c4","assignee":{"login":"jsnmoon","id":4044428,"avatar_url":"https://avatars2.githubusercontent.com/u/4044428?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnmoon","html_url":"https://github.com/jsnmoon","followers_url":"https://api.github.com/users/jsnmoon/followers","following_url":"https://api.github.com/users/jsnmoon/following{/other_user}","gists_url":"https://api.github.com/users/jsnmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnmoon/subscriptions","organizations_url":"https://api.github.com/users/jsnmoon/orgs","repos_url":"https://api.github.com/users/jsnmoon/repos","events_url":"https://api.github.com/users/jsnmoon/events{/privacy}","received_events_url":"https://api.github.com/users/jsnmoon/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsnmoon","id":4044428,"avatar_url":"https://avatars2.githubusercontent.com/u/4044428?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnmoon","html_url":"https://github.com/jsnmoon","followers_url":"https://api.github.com/users/jsnmoon/followers","following_url":"https://api.github.com/users/jsnmoon/following{/other_user}","gists_url":"https://api.github.com/users/jsnmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnmoon/subscriptions","organizations_url":"https://api.github.com/users/jsnmoon/orgs","repos_url":"https://api.github.com/users/jsnmoon/repos","events_url":"https://api.github.com/users/jsnmoon/events{/privacy}","received_events_url":"https://api.github.com/users/jsnmoon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":289076660,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Domains","name":"Domains","color":"006b75","default":false},{"id":285010018,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22965/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22965/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/22965/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/bf994f85f4cebffe06c977124d907b7e5d46ffea","head":{"label":"Automattic:update/domains/kracken/filter-etc","ref":"update/domains/kracken/filter-etc","sha":"bf994f85f4cebffe06c977124d907b7e5d46ffea","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The JavaScript and API powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2018-03-13T22:13:12Z","pushed_at":"2018-03-13T22:37:12Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":80173,"stargazers_count":9792,"watchers_count":9792,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1368,"mirror_url":null,"archived":false,"open_issues_count":1475,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1368,"open_issues":1475,"watchers":9792,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"6aeedd708f15b43a476f008909a00389d38b577b","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The JavaScript and API powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2018-03-13T22:13:12Z","pushed_at":"2018-03-13T22:37:12Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":80173,"stargazers_count":9792,"watchers_count":9792,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1368,"mirror_url":null,"archived":false,"open_issues_count":1475,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1368,"open_issues":1475,"watchers":9792,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22965"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/22965"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/22965"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/22965/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22965/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22965/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/bf994f85f4cebffe06c977124d907b7e5d46ffea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"klimeryk"}}