{"action":"created","comment":{"url":"https://api.github.com/repos/topbox-rci/rci-components/pulls/comments/205160205","pull_request_review_id":140375155,"id":205160205,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTE2MDIwNQ==","diff_hunk":"@@ -434,7 +434,7 @@ renderHtml(\n \n     <hr id=\"timepicker_2\" />\n     <h2>Timepicker v2</h2>\n-    <Timepicker />\n+    <Timepicker onUpdate={e => print(e, `Timepicker: { ${e.value} }`, false)} />","path":"assets/js/components.js","position":5,"original_position":5,"commit_id":"e480479642fe9d186e700d4c2bcd559312e7f987","original_commit_id":"e480479642fe9d186e700d4c2bcd559312e7f987","user":{"login":"tVeratti","id":6993836,"node_id":"MDQ6VXNlcjY5OTM4MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/6993836?v=4","gravatar_id":"","url":"https://api.github.com/users/tVeratti","html_url":"https://github.com/tVeratti","followers_url":"https://api.github.com/users/tVeratti/followers","following_url":"https://api.github.com/users/tVeratti/following{/other_user}","gists_url":"https://api.github.com/users/tVeratti/gists{/gist_id}","starred_url":"https://api.github.com/users/tVeratti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tVeratti/subscriptions","organizations_url":"https://api.github.com/users/tVeratti/orgs","repos_url":"https://api.github.com/users/tVeratti/repos","events_url":"https://api.github.com/users/tVeratti/events{/privacy}","received_events_url":"https://api.github.com/users/tVeratti/received_events","type":"User","site_admin":false},"body":"Hmm yeah, I like consistency. My only argument is that `onChange` is more globally consistent with natural elements. If we want to explicitly separate those concepts then sure, but otherwise `onUpdate` is always going to create inconsistency. So whichever way we choose I'm cool with sticking to in the future.","created_at":"2018-07-25T15:40:40Z","updated_at":"2018-07-25T15:40:40Z","html_url":"https://github.com/topbox-rci/rci-components/pull/653#discussion_r205160205","pull_request_url":"https://api.github.com/repos/topbox-rci/rci-components/pulls/653","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/topbox-rci/rci-components/pulls/comments/205160205"},"html":{"href":"https://github.com/topbox-rci/rci-components/pull/653#discussion_r205160205"},"pull_request":{"href":"https://api.github.com/repos/topbox-rci/rci-components/pulls/653"}},"in_reply_to_id":205158916},"pull_request":{"url":"https://api.github.com/repos/topbox-rci/rci-components/pulls/653","id":203878645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzODc4NjQ1","html_url":"https://github.com/topbox-rci/rci-components/pull/653","diff_url":"https://github.com/topbox-rci/rci-components/pull/653.diff","patch_url":"https://github.com/topbox-rci/rci-components/pull/653.patch","issue_url":"https://api.github.com/repos/topbox-rci/rci-components/issues/653","number":653,"state":"open","locked":false,"title":"TRW-1537 - time picker is now selectable.","user":{"login":"troyblank","id":996725,"node_id":"MDQ6VXNlcjk5NjcyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/996725?v=4","gravatar_id":"","url":"https://api.github.com/users/troyblank","html_url":"https://github.com/troyblank","followers_url":"https://api.github.com/users/troyblank/followers","following_url":"https://api.github.com/users/troyblank/following{/other_user}","gists_url":"https://api.github.com/users/troyblank/gists{/gist_id}","starred_url":"https://api.github.com/users/troyblank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troyblank/subscriptions","organizations_url":"https://api.github.com/users/troyblank/orgs","repos_url":"https://api.github.com/users/troyblank/repos","events_url":"https://api.github.com/users/troyblank/events{/privacy}","received_events_url":"https://api.github.com/users/troyblank/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-25T15:35:22Z","updated_at":"2018-07-25T15:40:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99faf19e6a540dfb30cd099c42d30a407d97414e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jasonhale","id":3496073,"node_id":"MDQ6VXNlcjM0OTYwNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3496073?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonhale","html_url":"https://github.com/jasonhale","followers_url":"https://api.github.com/users/jasonhale/followers","following_url":"https://api.github.com/users/jasonhale/following{/other_user}","gists_url":"https://api.github.com/users/jasonhale/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonhale/subscriptions","organizations_url":"https://api.github.com/users/jasonhale/orgs","repos_url":"https://api.github.com/users/jasonhale/repos","events_url":"https://api.github.com/users/jasonhale/events{/privacy}","received_events_url":"https://api.github.com/users/jasonhale/received_events","type":"User","site_admin":false},{"login":"tVeratti","id":6993836,"node_id":"MDQ6VXNlcjY5OTM4MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/6993836?v=4","gravatar_id":"","url":"https://api.github.com/users/tVeratti","html_url":"https://github.com/tVeratti","followers_url":"https://api.github.com/users/tVeratti/followers","following_url":"https://api.github.com/users/tVeratti/following{/other_user}","gists_url":"https://api.github.com/users/tVeratti/gists{/gist_id}","starred_url":"https://api.github.com/users/tVeratti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tVeratti/subscriptions","organizations_url":"https://api.github.com/users/tVeratti/orgs","repos_url":"https://api.github.com/users/tVeratti/repos","events_url":"https://api.github.com/users/tVeratti/events{/privacy}","received_events_url":"https://api.github.com/users/tVeratti/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/topbox-rci/rci-components/pulls/653/commits","review_comments_url":"https://api.github.com/repos/topbox-rci/rci-components/pulls/653/comments","review_comment_url":"https://api.github.com/repos/topbox-rci/rci-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/topbox-rci/rci-components/issues/653/comments","statuses_url":"https://api.github.com/repos/topbox-rci/rci-components/statuses/e480479642fe9d186e700d4c2bcd559312e7f987","head":{"label":"topbox-rci:TRW-1537","ref":"TRW-1537","sha":"e480479642fe9d186e700d4c2bcd559312e7f987","user":{"login":"topbox-rci","id":12717371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzE3Mzcx","avatar_url":"https://avatars0.githubusercontent.com/u/12717371?v=4","gravatar_id":"","url":"https://api.github.com/users/topbox-rci","html_url":"https://github.com/topbox-rci","followers_url":"https://api.github.com/users/topbox-rci/followers","following_url":"https://api.github.com/users/topbox-rci/following{/other_user}","gists_url":"https://api.github.com/users/topbox-rci/gists{/gist_id}","starred_url":"https://api.github.com/users/topbox-rci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topbox-rci/subscriptions","organizations_url":"https://api.github.com/users/topbox-rci/orgs","repos_url":"https://api.github.com/users/topbox-rci/repos","events_url":"https://api.github.com/users/topbox-rci/events{/privacy}","received_events_url":"https://api.github.com/users/topbox-rci/received_events","type":"Organization","site_admin":false},"repo":{"id":76394133,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM5NDEzMw==","name":"rci-components","full_name":"topbox-rci/rci-components","owner":{"login":"topbox-rci","id":12717371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzE3Mzcx","avatar_url":"https://avatars0.githubusercontent.com/u/12717371?v=4","gravatar_id":"","url":"https://api.github.com/users/topbox-rci","html_url":"https://github.com/topbox-rci","followers_url":"https://api.github.com/users/topbox-rci/followers","following_url":"https://api.github.com/users/topbox-rci/following{/other_user}","gists_url":"https://api.github.com/users/topbox-rci/gists{/gist_id}","starred_url":"https://api.github.com/users/topbox-rci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topbox-rci/subscriptions","organizations_url":"https://api.github.com/users/topbox-rci/orgs","repos_url":"https://api.github.com/users/topbox-rci/repos","events_url":"https://api.github.com/users/topbox-rci/events{/privacy}","received_events_url":"https://api.github.com/users/topbox-rci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/topbox-rci/rci-components","description":"React components for the RCI project","fork":false,"url":"https://api.github.com/repos/topbox-rci/rci-components","forks_url":"https://api.github.com/repos/topbox-rci/rci-components/forks","keys_url":"https://api.github.com/repos/topbox-rci/rci-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/topbox-rci/rci-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/topbox-rci/rci-components/teams","hooks_url":"https://api.github.com/repos/topbox-rci/rci-components/hooks","issue_events_url":"https://api.github.com/repos/topbox-rci/rci-components/issues/events{/number}","events_url":"https://api.github.com/repos/topbox-rci/rci-components/events","assignees_url":"https://api.github.com/repos/topbox-rci/rci-components/assignees{/user}","branches_url":"https://api.github.com/repos/topbox-rci/rci-components/branches{/branch}","tags_url":"https://api.github.com/repos/topbox-rci/rci-components/tags","blobs_url":"https://api.github.com/repos/topbox-rci/rci-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/topbox-rci/rci-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/topbox-rci/rci-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/topbox-rci/rci-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/topbox-rci/rci-components/statuses/{sha}","languages_url":"https://api.github.com/repos/topbox-rci/rci-components/languages","stargazers_url":"https://api.github.com/repos/topbox-rci/rci-components/stargazers","contributors_url":"https://api.github.com/repos/topbox-rci/rci-components/contributors","subscribers_url":"https://api.github.com/repos/topbox-rci/rci-components/subscribers","subscription_url":"https://api.github.com/repos/topbox-rci/rci-components/subscription","commits_url":"https://api.github.com/repos/topbox-rci/rci-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/topbox-rci/rci-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/topbox-rci/rci-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/topbox-rci/rci-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/topbox-rci/rci-components/contents/{+path}","compare_url":"https://api.github.com/repos/topbox-rci/rci-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/topbox-rci/rci-components/merges","archive_url":"https://api.github.com/repos/topbox-rci/rci-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/topbox-rci/rci-components/downloads","issues_url":"https://api.github.com/repos/topbox-rci/rci-components/issues{/number}","pulls_url":"https://api.github.com/repos/topbox-rci/rci-components/pulls{/number}","milestones_url":"https://api.github.com/repos/topbox-rci/rci-components/milestones{/number}","notifications_url":"https://api.github.com/repos/topbox-rci/rci-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/topbox-rci/rci-components/labels{/name}","releases_url":"https://api.github.com/repos/topbox-rci/rci-components/releases{/id}","deployments_url":"https://api.github.com/repos/topbox-rci/rci-components/deployments","created_at":"2016-12-13T20:05:28Z","updated_at":"2018-07-11T22:38:47Z","pushed_at":"2018-07-25T15:35:22Z","git_url":"git://github.com/topbox-rci/rci-components.git","ssh_url":"git@github.com:topbox-rci/rci-components.git","clone_url":"https://github.com/topbox-rci/rci-components.git","svn_url":"https://github.com/topbox-rci/rci-components","homepage":null,"size":2248,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"topbox-rci:develop","ref":"develop","sha":"17889c00c7fe276a4b4e8b55ac08529de8f7667e","user":{"login":"topbox-rci","id":12717371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzE3Mzcx","avatar_url":"https://avatars0.githubusercontent.com/u/12717371?v=4","gravatar_id":"","url":"https://api.github.com/users/topbox-rci","html_url":"https://github.com/topbox-rci","followers_url":"https://api.github.com/users/topbox-rci/followers","following_url":"https://api.github.com/users/topbox-rci/following{/other_user}","gists_url":"https://api.github.com/users/topbox-rci/gists{/gist_id}","starred_url":"https://api.github.com/users/topbox-rci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topbox-rci/subscriptions","organizations_url":"https://api.github.com/users/topbox-rci/orgs","repos_url":"https://api.github.com/users/topbox-rci/repos","events_url":"https://api.github.com/users/topbox-rci/events{/privacy}","received_events_url":"https://api.github.com/users/topbox-rci/received_events","type":"Organization","site_admin":false},"repo":{"id":76394133,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM5NDEzMw==","name":"rci-components","full_name":"topbox-rci/rci-components","owner":{"login":"topbox-rci","id":12717371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzE3Mzcx","avatar_url":"https://avatars0.githubusercontent.com/u/12717371?v=4","gravatar_id":"","url":"https://api.github.com/users/topbox-rci","html_url":"https://github.com/topbox-rci","followers_url":"https://api.github.com/users/topbox-rci/followers","following_url":"https://api.github.com/users/topbox-rci/following{/other_user}","gists_url":"https://api.github.com/users/topbox-rci/gists{/gist_id}","starred_url":"https://api.github.com/users/topbox-rci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topbox-rci/subscriptions","organizations_url":"https://api.github.com/users/topbox-rci/orgs","repos_url":"https://api.github.com/users/topbox-rci/repos","events_url":"https://api.github.com/users/topbox-rci/events{/privacy}","received_events_url":"https://api.github.com/users/topbox-rci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/topbox-rci/rci-components","description":"React components for the RCI project","fork":false,"url":"https://api.github.com/repos/topbox-rci/rci-components","forks_url":"https://api.github.com/repos/topbox-rci/rci-components/forks","keys_url":"https://api.github.com/repos/topbox-rci/rci-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/topbox-rci/rci-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/topbox-rci/rci-components/teams","hooks_url":"https://api.github.com/repos/topbox-rci/rci-components/hooks","issue_events_url":"https://api.github.com/repos/topbox-rci/rci-components/issues/events{/number}","events_url":"https://api.github.com/repos/topbox-rci/rci-components/events","assignees_url":"https://api.github.com/repos/topbox-rci/rci-components/assignees{/user}","branches_url":"https://api.github.com/repos/topbox-rci/rci-components/branches{/branch}","tags_url":"https://api.github.com/repos/topbox-rci/rci-components/tags","blobs_url":"https://api.github.com/repos/topbox-rci/rci-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/topbox-rci/rci-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/topbox-rci/rci-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/topbox-rci/rci-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/topbox-rci/rci-components/statuses/{sha}","languages_url":"https://api.github.com/repos/topbox-rci/rci-components/languages","stargazers_url":"https://api.github.com/repos/topbox-rci/rci-components/stargazers","contributors_url":"https://api.github.com/repos/topbox-rci/rci-components/contributors","subscribers_url":"https://api.github.com/repos/topbox-rci/rci-components/subscribers","subscription_url":"https://api.github.com/repos/topbox-rci/rci-components/subscription","commits_url":"https://api.github.com/repos/topbox-rci/rci-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/topbox-rci/rci-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/topbox-rci/rci-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/topbox-rci/rci-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/topbox-rci/rci-components/contents/{+path}","compare_url":"https://api.github.com/repos/topbox-rci/rci-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/topbox-rci/rci-components/merges","archive_url":"https://api.github.com/repos/topbox-rci/rci-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/topbox-rci/rci-components/downloads","issues_url":"https://api.github.com/repos/topbox-rci/rci-components/issues{/number}","pulls_url":"https://api.github.com/repos/topbox-rci/rci-components/pulls{/number}","milestones_url":"https://api.github.com/repos/topbox-rci/rci-components/milestones{/number}","notifications_url":"https://api.github.com/repos/topbox-rci/rci-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/topbox-rci/rci-components/labels{/name}","releases_url":"https://api.github.com/repos/topbox-rci/rci-components/releases{/id}","deployments_url":"https://api.github.com/repos/topbox-rci/rci-components/deployments","created_at":"2016-12-13T20:05:28Z","updated_at":"2018-07-11T22:38:47Z","pushed_at":"2018-07-25T15:35:22Z","git_url":"git://github.com/topbox-rci/rci-components.git","ssh_url":"git@github.com:topbox-rci/rci-components.git","clone_url":"https://github.com/topbox-rci/rci-components.git","svn_url":"https://github.com/topbox-rci/rci-components","homepage":null,"size":2248,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/topbox-rci/rci-components/pulls/653"},"html":{"href":"https://github.com/topbox-rci/rci-components/pull/653"},"issue":{"href":"https://api.github.com/repos/topbox-rci/rci-components/issues/653"},"comments":{"href":"https://api.github.com/repos/topbox-rci/rci-components/issues/653/comments"},"review_comments":{"href":"https://api.github.com/repos/topbox-rci/rci-components/pulls/653/comments"},"review_comment":{"href":"https://api.github.com/repos/topbox-rci/rci-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/topbox-rci/rci-components/pulls/653/commits"},"statuses":{"href":"https://api.github.com/repos/topbox-rci/rci-components/statuses/e480479642fe9d186e700d4c2bcd559312e7f987"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tVeratti"}}