{"action":"created","comment":{"url":"https://api.github.com/repos/travis-ci/travis-build/pulls/comments/209846132","pull_request_review_id":145936672,"id":209846132,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTg0NjEzMg==","diff_hunk":"@@ -83,8 +83,14 @@ ${ANSI_RED}For more information, see https://docs.travis-ci.com/user/encryption-\n   fi\n \n   if [[ -n \"$assert\" ]]; then\n+    if [[ $travis_build_step = script && $travis_func_index > 0 ]]; then\n+      echo -e \"${ANSI_RED} We show an error message because this is the second (or later) command in 'script' and it failed.${ANSI_CLEAR}\"","path":"lib/travis/build/templates/header.sh","position":5,"original_position":5,"commit_id":"a2e35fc1309327fb7ba802ee0114e5b6180c37be","original_commit_id":"a2e35fc1309327fb7ba802ee0114e5b6180c37be","user":{"login":"joshk","id":8701,"node_id":"MDQ6VXNlcjg3MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/8701?v=4","gravatar_id":"","url":"https://api.github.com/users/joshk","html_url":"https://github.com/joshk","followers_url":"https://api.github.com/users/joshk/followers","following_url":"https://api.github.com/users/joshk/following{/other_user}","gists_url":"https://api.github.com/users/joshk/gists{/gist_id}","starred_url":"https://api.github.com/users/joshk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshk/subscriptions","organizations_url":"https://api.github.com/users/joshk/orgs","repos_url":"https://api.github.com/users/joshk/repos","events_url":"https://api.github.com/users/joshk/events{/privacy}","received_events_url":"https://api.github.com/users/joshk/received_events","type":"User","site_admin":false},"body":"Sorry, what is this message trying to explain to the user?","created_at":"2018-08-14T06:59:52Z","updated_at":"2018-08-14T06:59:57Z","html_url":"https://github.com/travis-ci/travis-build/pull/1178#discussion_r209846132","pull_request_url":"https://api.github.com/repos/travis-ci/travis-build/pulls/1178","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/travis-ci/travis-build/pulls/comments/209846132"},"html":{"href":"https://github.com/travis-ci/travis-build/pull/1178#discussion_r209846132"},"pull_request":{"href":"https://api.github.com/repos/travis-ci/travis-build/pulls/1178"}}},"pull_request":{"url":"https://api.github.com/repos/travis-ci/travis-build/pulls/1178","id":141073320,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQxMDczMzIw","html_url":"https://github.com/travis-ci/travis-build/pull/1178","diff_url":"https://github.com/travis-ci/travis-build/pull/1178.diff","patch_url":"https://github.com/travis-ci/travis-build/pull/1178.patch","issue_url":"https://api.github.com/repos/travis-ci/travis-build/issues/1178","number":1178,"state":"open","locked":false,"title":"Assert all commands in the `script` step, and warn if the second (and later) command fails","user":{"login":"BanzaiMan","id":25666,"node_id":"MDQ6VXNlcjI1NjY2","avatar_url":"https://avatars3.githubusercontent.com/u/25666?v=4","gravatar_id":"","url":"https://api.github.com/users/BanzaiMan","html_url":"https://github.com/BanzaiMan","followers_url":"https://api.github.com/users/BanzaiMan/followers","following_url":"https://api.github.com/users/BanzaiMan/following{/other_user}","gists_url":"https://api.github.com/users/BanzaiMan/gists{/gist_id}","starred_url":"https://api.github.com/users/BanzaiMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BanzaiMan/subscriptions","organizations_url":"https://api.github.com/users/BanzaiMan/orgs","repos_url":"https://api.github.com/users/BanzaiMan/repos","events_url":"https://api.github.com/users/BanzaiMan/events{/privacy}","received_events_url":"https://api.github.com/users/BanzaiMan/received_events","type":"User","site_admin":false},"body":"Users often find it confusing that the first failure in the `script` step does not stop the build. This PR changes this.","created_at":"2017-09-14T13:24:17Z","updated_at":"2018-08-14T06:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"131c97ce2fcd14251a832820e92eaae639ea1383","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/travis-ci/travis-build/pulls/1178/commits","review_comments_url":"https://api.github.com/repos/travis-ci/travis-build/pulls/1178/comments","review_comment_url":"https://api.github.com/repos/travis-ci/travis-build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/travis-ci/travis-build/issues/1178/comments","statuses_url":"https://api.github.com/repos/travis-ci/travis-build/statuses/a2e35fc1309327fb7ba802ee0114e5b6180c37be","head":{"label":"travis-ci:ha-script-assert","ref":"ha-script-assert","sha":"a2e35fc1309327fb7ba802ee0114e5b6180c37be","user":{"login":"travis-ci","id":639823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":2508083,"node_id":"MDEwOlJlcG9zaXRvcnkyNTA4MDgz","name":"travis-build","full_name":"travis-ci/travis-build","owner":{"login":"travis-ci","id":639823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/travis-ci/travis-build","description":".travis.yml => build.sh converter","fork":false,"url":"https://api.github.com/repos/travis-ci/travis-build","forks_url":"https://api.github.com/repos/travis-ci/travis-build/forks","keys_url":"https://api.github.com/repos/travis-ci/travis-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travis-ci/travis-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travis-ci/travis-build/teams","hooks_url":"https://api.github.com/repos/travis-ci/travis-build/hooks","issue_events_url":"https://api.github.com/repos/travis-ci/travis-build/issues/events{/number}","events_url":"https://api.github.com/repos/travis-ci/travis-build/events","assignees_url":"https://api.github.com/repos/travis-ci/travis-build/assignees{/user}","branches_url":"https://api.github.com/repos/travis-ci/travis-build/branches{/branch}","tags_url":"https://api.github.com/repos/travis-ci/travis-build/tags","blobs_url":"https://api.github.com/repos/travis-ci/travis-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travis-ci/travis-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travis-ci/travis-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/travis-ci/travis-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travis-ci/travis-build/statuses/{sha}","languages_url":"https://api.github.com/repos/travis-ci/travis-build/languages","stargazers_url":"https://api.github.com/repos/travis-ci/travis-build/stargazers","contributors_url":"https://api.github.com/repos/travis-ci/travis-build/contributors","subscribers_url":"https://api.github.com/repos/travis-ci/travis-build/subscribers","subscription_url":"https://api.github.com/repos/travis-ci/travis-build/subscription","commits_url":"https://api.github.com/repos/travis-ci/travis-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/travis-ci/travis-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/travis-ci/travis-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/travis-ci/travis-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/travis-ci/travis-build/contents/{+path}","compare_url":"https://api.github.com/repos/travis-ci/travis-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travis-ci/travis-build/merges","archive_url":"https://api.github.com/repos/travis-ci/travis-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travis-ci/travis-build/downloads","issues_url":"https://api.github.com/repos/travis-ci/travis-build/issues{/number}","pulls_url":"https://api.github.com/repos/travis-ci/travis-build/pulls{/number}","milestones_url":"https://api.github.com/repos/travis-ci/travis-build/milestones{/number}","notifications_url":"https://api.github.com/repos/travis-ci/travis-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travis-ci/travis-build/labels{/name}","releases_url":"https://api.github.com/repos/travis-ci/travis-build/releases{/id}","deployments_url":"https://api.github.com/repos/travis-ci/travis-build/deployments","created_at":"2011-10-03T21:46:00Z","updated_at":"2018-08-12T22:50:56Z","pushed_at":"2018-08-13T16:45:48Z","git_url":"git://github.com/travis-ci/travis-build.git","ssh_url":"git@github.com:travis-ci/travis-build.git","clone_url":"https://github.com/travis-ci/travis-build.git","svn_url":"https://github.com/travis-ci/travis-build","homepage":"","size":5879,"stargazers_count":467,"watchers_count":467,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":347,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":347,"open_issues":84,"watchers":467,"default_branch":"master"}},"base":{"label":"travis-ci:master","ref":"master","sha":"ec7da37512cc2667b1381eea9f832a7bc984cf29","user":{"login":"travis-ci","id":639823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":2508083,"node_id":"MDEwOlJlcG9zaXRvcnkyNTA4MDgz","name":"travis-build","full_name":"travis-ci/travis-build","owner":{"login":"travis-ci","id":639823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/travis-ci/travis-build","description":".travis.yml => build.sh converter","fork":false,"url":"https://api.github.com/repos/travis-ci/travis-build","forks_url":"https://api.github.com/repos/travis-ci/travis-build/forks","keys_url":"https://api.github.com/repos/travis-ci/travis-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travis-ci/travis-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travis-ci/travis-build/teams","hooks_url":"https://api.github.com/repos/travis-ci/travis-build/hooks","issue_events_url":"https://api.github.com/repos/travis-ci/travis-build/issues/events{/number}","events_url":"https://api.github.com/repos/travis-ci/travis-build/events","assignees_url":"https://api.github.com/repos/travis-ci/travis-build/assignees{/user}","branches_url":"https://api.github.com/repos/travis-ci/travis-build/branches{/branch}","tags_url":"https://api.github.com/repos/travis-ci/travis-build/tags","blobs_url":"https://api.github.com/repos/travis-ci/travis-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travis-ci/travis-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travis-ci/travis-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/travis-ci/travis-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travis-ci/travis-build/statuses/{sha}","languages_url":"https://api.github.com/repos/travis-ci/travis-build/languages","stargazers_url":"https://api.github.com/repos/travis-ci/travis-build/stargazers","contributors_url":"https://api.github.com/repos/travis-ci/travis-build/contributors","subscribers_url":"https://api.github.com/repos/travis-ci/travis-build/subscribers","subscription_url":"https://api.github.com/repos/travis-ci/travis-build/subscription","commits_url":"https://api.github.com/repos/travis-ci/travis-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/travis-ci/travis-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/travis-ci/travis-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/travis-ci/travis-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/travis-ci/travis-build/contents/{+path}","compare_url":"https://api.github.com/repos/travis-ci/travis-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travis-ci/travis-build/merges","archive_url":"https://api.github.com/repos/travis-ci/travis-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travis-ci/travis-build/downloads","issues_url":"https://api.github.com/repos/travis-ci/travis-build/issues{/number}","pulls_url":"https://api.github.com/repos/travis-ci/travis-build/pulls{/number}","milestones_url":"https://api.github.com/repos/travis-ci/travis-build/milestones{/number}","notifications_url":"https://api.github.com/repos/travis-ci/travis-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travis-ci/travis-build/labels{/name}","releases_url":"https://api.github.com/repos/travis-ci/travis-build/releases{/id}","deployments_url":"https://api.github.com/repos/travis-ci/travis-build/deployments","created_at":"2011-10-03T21:46:00Z","updated_at":"2018-08-12T22:50:56Z","pushed_at":"2018-08-13T16:45:48Z","git_url":"git://github.com/travis-ci/travis-build.git","ssh_url":"git@github.com:travis-ci/travis-build.git","clone_url":"https://github.com/travis-ci/travis-build.git","svn_url":"https://github.com/travis-ci/travis-build","homepage":"","size":5879,"stargazers_count":467,"watchers_count":467,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":347,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":347,"open_issues":84,"watchers":467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/travis-ci/travis-build/pulls/1178"},"html":{"href":"https://github.com/travis-ci/travis-build/pull/1178"},"issue":{"href":"https://api.github.com/repos/travis-ci/travis-build/issues/1178"},"comments":{"href":"https://api.github.com/repos/travis-ci/travis-build/issues/1178/comments"},"review_comments":{"href":"https://api.github.com/repos/travis-ci/travis-build/pulls/1178/comments"},"review_comment":{"href":"https://api.github.com/repos/travis-ci/travis-build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/travis-ci/travis-build/pulls/1178/commits"},"statuses":{"href":"https://api.github.com/repos/travis-ci/travis-build/statuses/a2e35fc1309327fb7ba802ee0114e5b6180c37be"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"joshk"}}