{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka-grpc/pulls/comments/221237723","pull_request_review_id":159839743,"id":221237723,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTIzNzcyMw==","diff_hunk":"@@ -24,16 +24,21 @@ object SelfSigned {\n   lazy val (sslContext, trustManager): (SSLContext, X509TrustManager) = {\n     val keyStore: KeyStore = FakeKeyStore.generateKeyStore\n \n-    val kmf: KeyManagerFactory = KeyManagerFactory.getInstance(\"SunX509\")\n-    kmf.init(keyStore, \"\".toCharArray)\n-    val kms: Array[KeyManager] = kmf.getKeyManagers\n+    buildContextAndTrust(keyStore)\n+  }\n+\n+  // TODO: this should be moved to `ssl-config`\n+  private def buildContextAndTrust(keyStore: KeyStore) = {\n \n-    val tmf: TrustManagerFactory = TrustManagerFactory\n-      .getInstance(TrustManagerFactory.getDefaultAlgorithm())\n+    val tmf: TrustManagerFactory = TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm)\n     tmf.init(keyStore)\n     val tms: Array[TrustManager] = tmf.getTrustManagers\n     val x509TrustManager: X509TrustManager = tms(0).asInstanceOf[X509TrustManager]\n \n+    val kmf: KeyManagerFactory = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm)","path":"play-testkit/src/main/scala/play/api/test/SelfSigned.scala","position":20,"original_position":20,"commit_id":"9902c9ecb0db8c46cc8fcfb2aa53069d6262ace1","original_commit_id":"9902c9ecb0db8c46cc8fcfb2aa53069d6262ace1","user":{"login":"dwijnand","id":344610,"node_id":"MDQ6VXNlcjM0NDYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"body":"Moreover, is it significant?","created_at":"2018-09-28T12:36:03Z","updated_at":"2018-09-28T12:36:04Z","html_url":"https://github.com/akka/akka-grpc/pull/411#discussion_r221237723","pull_request_url":"https://api.github.com/repos/akka/akka-grpc/pulls/411","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/akka/akka-grpc/pulls/comments/221237723"},"html":{"href":"https://github.com/akka/akka-grpc/pull/411#discussion_r221237723"},"pull_request":{"href":"https://api.github.com/repos/akka/akka-grpc/pulls/411"}},"in_reply_to_id":221237134},"pull_request":{"url":"https://api.github.com/repos/akka/akka-grpc/pulls/411","id":217277068,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Mjc3MDY4","html_url":"https://github.com/akka/akka-grpc/pull/411","diff_url":"https://github.com/akka/akka-grpc/pull/411.diff","patch_url":"https://github.com/akka/akka-grpc/pull/411.patch","issue_url":"https://api.github.com/repos/akka/akka-grpc/issues/411","number":411,"state":"closed","locked":false,"title":"Extract method in SelfSigned","user":{"login":"ignasi35","id":762126,"node_id":"MDQ6VXNlcjc2MjEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"body":"This is a noop change. extracts a method in preparation for a refactor that will eventually move this code to ssl-config.","created_at":"2018-09-21T13:03:26Z","updated_at":"2018-09-28T12:36:04Z","closed_at":"2018-09-21T14:02:40Z","merged_at":"2018-09-21T14:02:40Z","merge_commit_sha":"78cd120c2d346648bbd47586a4c0927f8413a8d0","assignee":{"login":"ignasi35","id":762126,"node_id":"MDQ6VXNlcjc2MjEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"assignees":[{"login":"ignasi35","id":762126,"node_id":"MDQ6VXNlcjc2MjEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka-grpc/pulls/411/commits","review_comments_url":"https://api.github.com/repos/akka/akka-grpc/pulls/411/comments","review_comment_url":"https://api.github.com/repos/akka/akka-grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka-grpc/issues/411/comments","statuses_url":"https://api.github.com/repos/akka/akka-grpc/statuses/9902c9ecb0db8c46cc8fcfb2aa53069d6262ace1","head":{"label":"ignasi35:refactors-selfsigned","ref":"refactors-selfsigned","sha":"9902c9ecb0db8c46cc8fcfb2aa53069d6262ace1","user":{"login":"ignasi35","id":762126,"node_id":"MDQ6VXNlcjc2MjEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"repo":{"id":128243172,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgyNDMxNzI=","name":"akka-grpc","full_name":"ignasi35/akka-grpc","private":false,"owner":{"login":"ignasi35","id":762126,"node_id":"MDQ6VXNlcjc2MjEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ignasi35/akka-grpc","description":"Akka gRPC","fork":true,"url":"https://api.github.com/repos/ignasi35/akka-grpc","forks_url":"https://api.github.com/repos/ignasi35/akka-grpc/forks","keys_url":"https://api.github.com/repos/ignasi35/akka-grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ignasi35/akka-grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ignasi35/akka-grpc/teams","hooks_url":"https://api.github.com/repos/ignasi35/akka-grpc/hooks","issue_events_url":"https://api.github.com/repos/ignasi35/akka-grpc/issues/events{/number}","events_url":"https://api.github.com/repos/ignasi35/akka-grpc/events","assignees_url":"https://api.github.com/repos/ignasi35/akka-grpc/assignees{/user}","branches_url":"https://api.github.com/repos/ignasi35/akka-grpc/branches{/branch}","tags_url":"https://api.github.com/repos/ignasi35/akka-grpc/tags","blobs_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ignasi35/akka-grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/ignasi35/akka-grpc/languages","stargazers_url":"https://api.github.com/repos/ignasi35/akka-grpc/stargazers","contributors_url":"https://api.github.com/repos/ignasi35/akka-grpc/contributors","subscribers_url":"https://api.github.com/repos/ignasi35/akka-grpc/subscribers","subscription_url":"https://api.github.com/repos/ignasi35/akka-grpc/subscription","commits_url":"https://api.github.com/repos/ignasi35/akka-grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ignasi35/akka-grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ignasi35/akka-grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ignasi35/akka-grpc/contents/{+path}","compare_url":"https://api.github.com/repos/ignasi35/akka-grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ignasi35/akka-grpc/merges","archive_url":"https://api.github.com/repos/ignasi35/akka-grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ignasi35/akka-grpc/downloads","issues_url":"https://api.github.com/repos/ignasi35/akka-grpc/issues{/number}","pulls_url":"https://api.github.com/repos/ignasi35/akka-grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/ignasi35/akka-grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/ignasi35/akka-grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ignasi35/akka-grpc/labels{/name}","releases_url":"https://api.github.com/repos/ignasi35/akka-grpc/releases{/id}","deployments_url":"https://api.github.com/repos/ignasi35/akka-grpc/deployments","created_at":"2018-04-05T17:49:23Z","updated_at":"2018-04-05T17:49:25Z","pushed_at":"2018-09-21T13:02:49Z","git_url":"git://github.com/ignasi35/akka-grpc.git","ssh_url":"git@github.com:ignasi35/akka-grpc.git","clone_url":"https://github.com/ignasi35/akka-grpc.git","svn_url":"https://github.com/ignasi35/akka-grpc","homepage":"https://akka.io","size":1209,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"b0a8f638583847d210c5f27c209aae684bc7d3f2","user":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":120786720,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA3ODY3MjA=","name":"akka-grpc","full_name":"akka/akka-grpc","private":false,"owner":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/akka/akka-grpc","description":"Akka gRPC","fork":false,"url":"https://api.github.com/repos/akka/akka-grpc","forks_url":"https://api.github.com/repos/akka/akka-grpc/forks","keys_url":"https://api.github.com/repos/akka/akka-grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka-grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka-grpc/teams","hooks_url":"https://api.github.com/repos/akka/akka-grpc/hooks","issue_events_url":"https://api.github.com/repos/akka/akka-grpc/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka-grpc/events","assignees_url":"https://api.github.com/repos/akka/akka-grpc/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka-grpc/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka-grpc/tags","blobs_url":"https://api.github.com/repos/akka/akka-grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka-grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka-grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka-grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka-grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka-grpc/languages","stargazers_url":"https://api.github.com/repos/akka/akka-grpc/stargazers","contributors_url":"https://api.github.com/repos/akka/akka-grpc/contributors","subscribers_url":"https://api.github.com/repos/akka/akka-grpc/subscribers","subscription_url":"https://api.github.com/repos/akka/akka-grpc/subscription","commits_url":"https://api.github.com/repos/akka/akka-grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka-grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka-grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka-grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka-grpc/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka-grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka-grpc/merges","archive_url":"https://api.github.com/repos/akka/akka-grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka-grpc/downloads","issues_url":"https://api.github.com/repos/akka/akka-grpc/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka-grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka-grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka-grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka-grpc/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka-grpc/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka-grpc/deployments","created_at":"2018-02-08T16:28:56Z","updated_at":"2018-09-27T19:06:44Z","pushed_at":"2018-09-27T13:08:09Z","git_url":"git://github.com/akka/akka-grpc.git","ssh_url":"git@github.com:akka/akka-grpc.git","clone_url":"https://github.com/akka/akka-grpc.git","svn_url":"https://github.com/akka/akka-grpc","homepage":"https://developer.lightbend.com/docs/akka-grpc/current/","size":1212,"stargazers_count":141,"watchers_count":141,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":73,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka-grpc/pulls/411"},"html":{"href":"https://github.com/akka/akka-grpc/pull/411"},"issue":{"href":"https://api.github.com/repos/akka/akka-grpc/issues/411"},"comments":{"href":"https://api.github.com/repos/akka/akka-grpc/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka-grpc/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka-grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka-grpc/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka-grpc/statuses/9902c9ecb0db8c46cc8fcfb2aa53069d6262ace1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dwijnand"}}