{"action":"created","issue":{"url":"https://api.github.com/repos/scionproto/scion/issues/1513","repository_url":"https://api.github.com/repos/scionproto/scion","labels_url":"https://api.github.com/repos/scionproto/scion/issues/1513/labels{/name}","comments_url":"https://api.github.com/repos/scionproto/scion/issues/1513/comments","events_url":"https://api.github.com/repos/scionproto/scion/issues/1513/events","html_url":"https://github.com/scionproto/scion/pull/1513","id":313646589,"number":1513,"title":"Rework of the revocation authentication","user":{"login":"worxli","id":2504856,"avatar_url":"https://avatars0.githubusercontent.com/u/2504856?v=4","gravatar_id":"","url":"https://api.github.com/users/worxli","html_url":"https://github.com/worxli","followers_url":"https://api.github.com/users/worxli/followers","following_url":"https://api.github.com/users/worxli/following{/other_user}","gists_url":"https://api.github.com/users/worxli/gists{/gist_id}","starred_url":"https://api.github.com/users/worxli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worxli/subscriptions","organizations_url":"https://api.github.com/users/worxli/orgs","repos_url":"https://api.github.com/users/worxli/repos","events_url":"https://api.github.com/users/worxli/events{/privacy}","received_events_url":"https://api.github.com/users/worxli/received_events","type":"User","site_admin":false},"labels":[{"id":869561334,"url":"https://api.github.com/repos/scionproto/scion/labels/Breaking%20Change","name":"Breaking Change","color":"ff9c32","default":false}],"state":"open","locked":false,"assignee":{"login":"worxli","id":2504856,"avatar_url":"https://avatars0.githubusercontent.com/u/2504856?v=4","gravatar_id":"","url":"https://api.github.com/users/worxli","html_url":"https://github.com/worxli","followers_url":"https://api.github.com/users/worxli/followers","following_url":"https://api.github.com/users/worxli/following{/other_user}","gists_url":"https://api.github.com/users/worxli/gists{/gist_id}","starred_url":"https://api.github.com/users/worxli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worxli/subscriptions","organizations_url":"https://api.github.com/users/worxli/orgs","repos_url":"https://api.github.com/users/worxli/repos","events_url":"https://api.github.com/users/worxli/events{/privacy}","received_events_url":"https://api.github.com/users/worxli/received_events","type":"User","site_admin":false},"assignees":[{"login":"worxli","id":2504856,"avatar_url":"https://avatars0.githubusercontent.com/u/2504856?v=4","gravatar_id":"","url":"https://api.github.com/users/worxli","html_url":"https://github.com/worxli","followers_url":"https://api.github.com/users/worxli/followers","following_url":"https://api.github.com/users/worxli/following{/other_user}","gists_url":"https://api.github.com/users/worxli/gists{/gist_id}","starred_url":"https://api.github.com/users/worxli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worxli/subscriptions","organizations_url":"https://api.github.com/users/worxli/orgs","repos_url":"https://api.github.com/users/worxli/repos","events_url":"https://api.github.com/users/worxli/events{/privacy}","received_events_url":"https://api.github.com/users/worxli/received_events","type":"User","site_admin":false}],"milestone":null,"comments":29,"created_at":"2018-04-12T09:29:25Z","updated_at":"2018-05-07T08:58:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scionproto/scion/pulls/1513","html_url":"https://github.com/scionproto/scion/pull/1513","diff_url":"https://github.com/scionproto/scion/pull/1513.diff","patch_url":"https://github.com/scionproto/scion/pull/1513.patch"},"body":"This PR includes changes in:\r\n- Border Router\r\n- SCIOND\r\n- Path Server\r\n- Beacon Server\r\n\r\nThe hashtree based revocation has been replaced by signed messages.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/scionproto/scion/1513)\r\n<!-- Reviewable:end -->\r\n\r\n## Benchmarks\r\n**Hashtree**\r\nValid proof: `ConnectedHashTree.verify(proof, root)` -  24.05us/op\r\nInvalid proof: `ConnectedHashTree.verify(proof, root)` - 27.50us/op\r\n\r\n**Signature**\r\nValid signature: `srev_info.verify(vk)` -  104.28us/op\r\nValid signature: `try: srev_info.verify(vk) except: pass` -  126.79us/op\r\nInvalid signature: `try: srev_info.verify(vk) except: pass` - 131.24us/op"},"comment":{"url":"https://api.github.com/repos/scionproto/scion/issues/comments/387003289","html_url":"https://github.com/scionproto/scion/pull/1513#issuecomment-387003289","issue_url":"https://api.github.com/repos/scionproto/scion/issues/1513","id":387003289,"user":{"login":"kormat","id":6919822,"avatar_url":"https://avatars2.githubusercontent.com/u/6919822?v=4","gravatar_id":"","url":"https://api.github.com/users/kormat","html_url":"https://github.com/kormat","followers_url":"https://api.github.com/users/kormat/followers","following_url":"https://api.github.com/users/kormat/following{/other_user}","gists_url":"https://api.github.com/users/kormat/gists{/gist_id}","starred_url":"https://api.github.com/users/kormat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kormat/subscriptions","organizations_url":"https://api.github.com/users/kormat/orgs","repos_url":"https://api.github.com/users/kormat/repos","events_url":"https://api.github.com/users/kormat/events{/privacy}","received_events_url":"https://api.github.com/users/kormat/received_events","type":"User","site_admin":false},"created_at":"2018-05-07T08:58:57Z","updated_at":"2018-05-07T08:58:57Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReviewed 8 of 8 files at r8.\nReview status: all files reviewed at latest revision, 17 unresolved discussions.\n\n---\n\n*[go/border/rpkt/path.go, line 114 at r8](https://reviewable.io/reviews/scionproto/scion/1513#-LBtkMkRDV46xySyKDG-:-LBtkMkRDV46xySyKDG0:bzckpcl) ([raw file](https://github.com/scionproto/scion/blob/5dac9b59551b0f3029ed3d86be58f28ca01e4290/go/border/rpkt/path.go#L114)):*\n> ```Go\n> \t\treturn nil\n> \t}\n> \t// Check that the revocation timestamp is within the TTL.\n> ```\n\nThat's an odd phrasing. I'm not sure that a comment is needed in any case, as `revInfo.Active()` is fairly self-explanatory. \n\n---\n\n*[proto/rev_info.capnp, line 12 at r2](https://reviewable.io/reviews/scionproto/scion/1513#-LACTkQl-sVmVQmZX-0x:-LBtm0zaDEq9RU7eMyzb:b7a5iip) ([raw file](https://github.com/scionproto/scion/blob/18bdf4850be5cab322652bcc93ab86be78653a43/proto/rev_info.capnp#L12)):*\n<details><summary><i>Previously, worxli (Lukas Bischofberger) wrote…</i></summary><blockquote>\n\nThough, I checked other timestamps in capnp and they also seem to be seconds and UInt64.\n</blockquote></details>\n\n@worxli : i had a quick look, and that's fair, we're pretty inconsistent on this. We should really fix that. I'll file an issue, we can leave this as UInt64 for now.\n\n(Filed https://github.com/scionproto/scion/issues/1548)\n\n---\n\n*[python/beacon_server/base.py, line 145 at r7](https://reviewable.io/reviews/scionproto/scion/1513#-LBeKS0M5RA98kXnP3Sb:-LBtkeLp2Gsw7lm6mloG:bo5rr6s) ([raw file](https://github.com/scionproto/scion/blob/66988dc47b7bd4dbe41543aa3e8b9122c400cca5/python/beacon_server/base.py#L145)):*\n<details><summary><i>Previously, worxli (Lukas Bischofberger) wrote…</i></summary><blockquote>\n\nDone.\n</blockquote></details>\n\n` = {}` is more common.\n\n---\n\n*[python/path_server/base.py, line 216 at r7](https://reviewable.io/reviews/scionproto/scion/1513#-LBeJKIvCsMQjM_okbYl:-LBtoLaEDfsLtVPUvvvo:b-prmryj) ([raw file](https://github.com/scionproto/scion/blob/66988dc47b7bd4dbe41543aa3e8b9122c400cca5/python/path_server/base.py#L216)):*\n<details><summary><i>Previously, shitz wrote…</i></summary><blockquote>\n\nIt seems that revocations that are issued from the BS to the PS are sent as part of an `IFStatePayload` object, instead of just a raw `RevInfo`. I don't see any reason of using `IFStatePayload` over `RevInfo` except simpler code in the BS, since it already creates the `IFStatePayloads` for the border routers. If needed/desired, this can be changed to a BS issuing a revocation towards the PS in form of a `RevInfo`\n</blockquote></details>\n\nFiled https://github.com/scionproto/scion/issues/1549\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/scionproto/scion/1513)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"kormat"}}