{"action":"created","comment":{"url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls/comments/197507156","pull_request_review_id":131270107,"id":197507156,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzUwNzE1Ng==","diff_hunk":"@@ -39,24 +39,22 @@ class Logging {\n             }));\n         }\n \n-        if(config.files === undefined) {\n-            return;\n-        }\n-\n-        let i = 0;\n-        for (let file of config.files) {\n-            const filename = Object.keys(file)[0];\n-            const level = file[filename];\n-            i++;\n-            this.transports.push(new (winston.transports.DailyRotateFile)({\n-                filename,\n-                datePattern: \"YYYY-MM-DD\",\n-                name: `logfile` + i,\n-                formatter: formatterFn,\n-                level,\n-                timestamp: timestampFn,\n-                maxFiles: config.maxFiles > 0 ? config.maxFiles : undefined\n-            }));\n+        if(config.files !== undefined) {","path":"lib/Logging.js","position":28,"original_position":22,"commit_id":"29838fa2977a429890d24452597d89ac6cfa6bc5","original_commit_id":"29838fa2977a429890d24452597d89ac6cfa6bc5","user":{"login":"lukebarnard1","id":6750344,"node_id":"MDQ6VXNlcjY3NTAzNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6750344?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebarnard1","html_url":"https://github.com/lukebarnard1","followers_url":"https://api.github.com/users/lukebarnard1/followers","following_url":"https://api.github.com/users/lukebarnard1/following{/other_user}","gists_url":"https://api.github.com/users/lukebarnard1/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebarnard1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebarnard1/subscriptions","organizations_url":"https://api.github.com/users/lukebarnard1/orgs","repos_url":"https://api.github.com/users/lukebarnard1/repos","events_url":"https://api.github.com/users/lukebarnard1/events{/privacy}","received_events_url":"https://api.github.com/users/lukebarnard1/received_events","type":"User","site_admin":false},"body":"Is this actually a functional change? It doesn't seem like it.","created_at":"2018-06-22T16:57:03Z","updated_at":"2018-06-22T16:57:08Z","html_url":"https://github.com/matrix-org/matrix-appservice-gitter/pull/60#discussion_r197507156","pull_request_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls/60","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls/comments/197507156"},"html":{"href":"https://github.com/matrix-org/matrix-appservice-gitter/pull/60#discussion_r197507156"},"pull_request":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls/60","id":196732552,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NzMyNTUy","html_url":"https://github.com/matrix-org/matrix-appservice-gitter/pull/60","diff_url":"https://github.com/matrix-org/matrix-appservice-gitter/pull/60.diff","patch_url":"https://github.com/matrix-org/matrix-appservice-gitter/pull/60.patch","issue_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/issues/60","number":60,"state":"open","locked":false,"title":"Use util.inspect on objects being logged.","user":{"login":"Half-Shot","id":2072976,"node_id":"MDQ6VXNlcjIwNzI5NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2072976?v=4","gravatar_id":"","url":"https://api.github.com/users/Half-Shot","html_url":"https://github.com/Half-Shot","followers_url":"https://api.github.com/users/Half-Shot/followers","following_url":"https://api.github.com/users/Half-Shot/following{/other_user}","gists_url":"https://api.github.com/users/Half-Shot/gists{/gist_id}","starred_url":"https://api.github.com/users/Half-Shot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Half-Shot/subscriptions","organizations_url":"https://api.github.com/users/Half-Shot/orgs","repos_url":"https://api.github.com/users/Half-Shot/repos","events_url":"https://api.github.com/users/Half-Shot/events{/privacy}","received_events_url":"https://api.github.com/users/Half-Shot/received_events","type":"User","site_admin":false},"body":"This came about because we used to use ``console.log``, which did this implicitly but winston does not. I think this is a fairly sane suggestion as long as we don't try to rapidly log lots of objects, though I don't think ``util.inspect`` has any extreme performance penalties.","created_at":"2018-06-22T13:04:18Z","updated_at":"2018-06-22T16:57:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ee268f232e3aca5820b6204b2eb2dcae46d7ce3","assignee":{"login":"lukebarnard1","id":6750344,"node_id":"MDQ6VXNlcjY3NTAzNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6750344?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebarnard1","html_url":"https://github.com/lukebarnard1","followers_url":"https://api.github.com/users/lukebarnard1/followers","following_url":"https://api.github.com/users/lukebarnard1/following{/other_user}","gists_url":"https://api.github.com/users/lukebarnard1/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebarnard1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebarnard1/subscriptions","organizations_url":"https://api.github.com/users/lukebarnard1/orgs","repos_url":"https://api.github.com/users/lukebarnard1/repos","events_url":"https://api.github.com/users/lukebarnard1/events{/privacy}","received_events_url":"https://api.github.com/users/lukebarnard1/received_events","type":"User","site_admin":false},"assignees":[{"login":"lukebarnard1","id":6750344,"node_id":"MDQ6VXNlcjY3NTAzNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6750344?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebarnard1","html_url":"https://github.com/lukebarnard1","followers_url":"https://api.github.com/users/lukebarnard1/followers","following_url":"https://api.github.com/users/lukebarnard1/following{/other_user}","gists_url":"https://api.github.com/users/lukebarnard1/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebarnard1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebarnard1/subscriptions","organizations_url":"https://api.github.com/users/lukebarnard1/orgs","repos_url":"https://api.github.com/users/lukebarnard1/repos","events_url":"https://api.github.com/users/lukebarnard1/events{/privacy}","received_events_url":"https://api.github.com/users/lukebarnard1/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls/60/commits","review_comments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls/60/comments","review_comment_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/issues/60/comments","statuses_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/statuses/29838fa2977a429890d24452597d89ac6cfa6bc5","head":{"label":"matrix-org:hs/logging","ref":"hs/logging","sha":"29838fa2977a429890d24452597d89ac6cfa6bc5","user":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":51444654,"node_id":"MDEwOlJlcG9zaXRvcnk1MTQ0NDY1NA==","name":"matrix-appservice-gitter","full_name":"matrix-org/matrix-appservice-gitter","owner":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/matrix-appservice-gitter","description":null,"fork":false,"url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter","forks_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/forks","keys_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/teams","hooks_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/events","assignees_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/tags","blobs_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/languages","stargazers_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/subscription","commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/merges","archive_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/downloads","issues_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/deployments","created_at":"2016-02-10T14:05:19Z","updated_at":"2018-06-15T17:25:09Z","pushed_at":"2018-06-22T16:23:09Z","git_url":"git://github.com/matrix-org/matrix-appservice-gitter.git","ssh_url":"git@github.com:matrix-org/matrix-appservice-gitter.git","clone_url":"https://github.com/matrix-org/matrix-appservice-gitter.git","svn_url":"https://github.com/matrix-org/matrix-appservice-gitter","homepage":null,"size":350,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":38,"license":null,"forks":4,"open_issues":38,"watchers":15,"default_branch":"master"}},"base":{"label":"matrix-org:master","ref":"master","sha":"3e3381b13f67cb734c40bf232c2927547cf89fbb","user":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":51444654,"node_id":"MDEwOlJlcG9zaXRvcnk1MTQ0NDY1NA==","name":"matrix-appservice-gitter","full_name":"matrix-org/matrix-appservice-gitter","owner":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/matrix-appservice-gitter","description":null,"fork":false,"url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter","forks_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/forks","keys_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/teams","hooks_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/events","assignees_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/tags","blobs_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/languages","stargazers_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/subscription","commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/merges","archive_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/downloads","issues_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/deployments","created_at":"2016-02-10T14:05:19Z","updated_at":"2018-06-15T17:25:09Z","pushed_at":"2018-06-22T16:23:09Z","git_url":"git://github.com/matrix-org/matrix-appservice-gitter.git","ssh_url":"git@github.com:matrix-org/matrix-appservice-gitter.git","clone_url":"https://github.com/matrix-org/matrix-appservice-gitter.git","svn_url":"https://github.com/matrix-org/matrix-appservice-gitter","homepage":null,"size":350,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":38,"license":null,"forks":4,"open_issues":38,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls/60"},"html":{"href":"https://github.com/matrix-org/matrix-appservice-gitter/pull/60"},"issue":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/issues/60"},"comments":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-gitter/statuses/29838fa2977a429890d24452597d89ac6cfa6bc5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lukebarnard1"}}