{"action":"created","issue":{"url":"https://api.github.com/repos/diana-hep/pyhf/issues/159","repository_url":"https://api.github.com/repos/diana-hep/pyhf","labels_url":"https://api.github.com/repos/diana-hep/pyhf/issues/159/labels{/name}","comments_url":"https://api.github.com/repos/diana-hep/pyhf/issues/159/comments","events_url":"https://api.github.com/repos/diana-hep/pyhf/issues/159/events","html_url":"https://github.com/diana-hep/pyhf/pull/159","id":320626435,"number":159,"title":"[WIP] Fix simple_broadcast()","user":{"login":"matthewfeickert","id":5142394,"avatar_url":"https://avatars3.githubusercontent.com/u/5142394?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewfeickert","html_url":"https://github.com/matthewfeickert","followers_url":"https://api.github.com/users/matthewfeickert/followers","following_url":"https://api.github.com/users/matthewfeickert/following{/other_user}","gists_url":"https://api.github.com/users/matthewfeickert/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewfeickert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewfeickert/subscriptions","organizations_url":"https://api.github.com/users/matthewfeickert/orgs","repos_url":"https://api.github.com/users/matthewfeickert/repos","events_url":"https://api.github.com/users/matthewfeickert/events{/privacy}","received_events_url":"https://api.github.com/users/matthewfeickert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"matthewfeickert","id":5142394,"avatar_url":"https://avatars3.githubusercontent.com/u/5142394?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewfeickert","html_url":"https://github.com/matthewfeickert","followers_url":"https://api.github.com/users/matthewfeickert/followers","following_url":"https://api.github.com/users/matthewfeickert/following{/other_user}","gists_url":"https://api.github.com/users/matthewfeickert/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewfeickert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewfeickert/subscriptions","organizations_url":"https://api.github.com/users/matthewfeickert/orgs","repos_url":"https://api.github.com/users/matthewfeickert/repos","events_url":"https://api.github.com/users/matthewfeickert/events{/privacy}","received_events_url":"https://api.github.com/users/matthewfeickert/received_events","type":"User","site_admin":false},"assignees":[{"login":"matthewfeickert","id":5142394,"avatar_url":"https://avatars3.githubusercontent.com/u/5142394?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewfeickert","html_url":"https://github.com/matthewfeickert","followers_url":"https://api.github.com/users/matthewfeickert/followers","following_url":"https://api.github.com/users/matthewfeickert/following{/other_user}","gists_url":"https://api.github.com/users/matthewfeickert/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewfeickert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewfeickert/subscriptions","organizations_url":"https://api.github.com/users/matthewfeickert/orgs","repos_url":"https://api.github.com/users/matthewfeickert/repos","events_url":"https://api.github.com/users/matthewfeickert/events{/privacy}","received_events_url":"https://api.github.com/users/matthewfeickert/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-05-06T20:41:30Z","updated_at":"2018-05-07T15:31:44Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/diana-hep/pyhf/pulls/159","html_url":"https://github.com/diana-hep/pyhf/pull/159","diff_url":"https://github.com/diana-hep/pyhf/pull/159.diff","patch_url":"https://github.com/diana-hep/pyhf/pull/159.patch"},"body":"Resolves #158\r\n\r\n- [ ] Fix `simple_broadcast()` for NumPy backend\r\n- [x] Fix `simple_broadcast()` for PyTorch backend\r\n- [ ] Fix `simple_broadcast()` for TensorFlow backend\r\n- [ ] Fix `simple_broadcast()` for MXNet backend\r\n- [x] Add test for `tensorlib.simple_broadcast()`\r\n- [x] Add tests that fail when number of non-lenght-1 arrays is greater than 1\r\n \r\n# Checklist Before Requesting Approver\r\n\r\n- [ ] Tests are passing\r\n- [ ] \"WIP\" removed from the title of the pull request\r\n"},"comment":{"url":"https://api.github.com/repos/diana-hep/pyhf/issues/comments/387103858","html_url":"https://github.com/diana-hep/pyhf/pull/159#issuecomment-387103858","issue_url":"https://api.github.com/repos/diana-hep/pyhf/issues/159","id":387103858,"user":{"login":"matthewfeickert","id":5142394,"avatar_url":"https://avatars3.githubusercontent.com/u/5142394?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewfeickert","html_url":"https://github.com/matthewfeickert","followers_url":"https://api.github.com/users/matthewfeickert/followers","following_url":"https://api.github.com/users/matthewfeickert/following{/other_user}","gists_url":"https://api.github.com/users/matthewfeickert/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewfeickert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewfeickert/subscriptions","organizations_url":"https://api.github.com/users/matthewfeickert/orgs","repos_url":"https://api.github.com/users/matthewfeickert/repos","events_url":"https://api.github.com/users/matthewfeickert/events{/privacy}","received_events_url":"https://api.github.com/users/matthewfeickert/received_events","type":"User","site_admin":false},"created_at":"2018-05-07T15:31:44Z","updated_at":"2018-05-07T15:31:44Z","author_association":"COLLABORATOR","body":"> Not entirely sure one would want to accept lists. This will break the lazy evaluation such as in tensorflow which builds up tensors for passing around, no? We should encourage tensors where possible to keep consistency.\r\n\r\n@kratsg Yeah, I mean we would wrap the inputs in `astensor`, so that should keep things from breaking (right?). I don't have strong feelings on this, as I assume that anywhere it is going to get called tensor objects will already have been constructed, so I'll just implement whatever you and @lukasheinrich agree on."}}
{"actor":{"display_login":"matthewfeickert"}}