{"action":"created","issue":{"url":"https://api.github.com/repos/aces/Loris/issues/3898","repository_url":"https://api.github.com/repos/aces/Loris","labels_url":"https://api.github.com/repos/aces/Loris/issues/3898/labels{/name}","comments_url":"https://api.github.com/repos/aces/Loris/issues/3898/comments","events_url":"https://api.github.com/repos/aces/Loris/issues/3898/events","html_url":"https://github.com/aces/Loris/pull/3898","id":353569831,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTg4MDM4","number":3898,"title":"[Core: Login, User Accounts] Allow certain users to access the system in a time window basis","user":{"login":"racostas","id":37309344,"node_id":"MDQ6VXNlcjM3MzA5MzQ0","avatar_url":"https://avatars0.githubusercontent.com/u/37309344?v=4","gravatar_id":"","url":"https://api.github.com/users/racostas","html_url":"https://github.com/racostas","followers_url":"https://api.github.com/users/racostas/followers","following_url":"https://api.github.com/users/racostas/following{/other_user}","gists_url":"https://api.github.com/users/racostas/gists{/gist_id}","starred_url":"https://api.github.com/users/racostas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racostas/subscriptions","organizations_url":"https://api.github.com/users/racostas/orgs","repos_url":"https://api.github.com/users/racostas/repos","events_url":"https://api.github.com/users/racostas/events{/privacy}","received_events_url":"https://api.github.com/users/racostas/received_events","type":"User","site_admin":false},"labels":[{"id":152305520,"node_id":"MDU6TGFiZWwxNTIzMDU1MjA=","url":"https://api.github.com/repos/aces/Loris/labels/Feature","name":"Feature","color":"1d76db","default":false},{"id":345188265,"node_id":"MDU6TGFiZWwzNDUxODgyNjU=","url":"https://api.github.com/repos/aces/Loris/labels/Needs%20Work","name":"Needs Work","color":"eb6420","default":false},{"id":153844577,"node_id":"MDU6TGFiZWwxNTM4NDQ1Nzc=","url":"https://api.github.com/repos/aces/Loris/labels/SQL","name":"SQL","color":"bfe5bf","default":false},{"id":708895955,"node_id":"MDU6TGFiZWw3MDg4OTU5NTU=","url":"https://api.github.com/repos/aces/Loris/labels/[branch]%20minor","name":"[branch] minor","color":"996633","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/aces/Loris/milestones/31","html_url":"https://github.com/aces/Loris/milestone/31","labels_url":"https://api.github.com/repos/aces/Loris/milestones/31/labels","id":3439094,"node_id":"MDk6TWlsZXN0b25lMzQzOTA5NA==","number":31,"title":"20.1.0","description":"","creator":{"login":"ridz1208","id":15268287,"node_id":"MDQ6VXNlcjE1MjY4Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/15268287?v=4","gravatar_id":"","url":"https://api.github.com/users/ridz1208","html_url":"https://github.com/ridz1208","followers_url":"https://api.github.com/users/ridz1208/followers","following_url":"https://api.github.com/users/ridz1208/following{/other_user}","gists_url":"https://api.github.com/users/ridz1208/gists{/gist_id}","starred_url":"https://api.github.com/users/ridz1208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridz1208/subscriptions","organizations_url":"https://api.github.com/users/ridz1208/orgs","repos_url":"https://api.github.com/users/ridz1208/repos","events_url":"https://api.github.com/users/ridz1208/events{/privacy}","received_events_url":"https://api.github.com/users/ridz1208/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":8,"state":"open","created_at":"2018-06-20T15:52:15Z","updated_at":"2018-08-30T14:28:55Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-08-23T22:00:53Z","updated_at":"2018-09-05T12:08:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aces/Loris/pulls/3898","html_url":"https://github.com/aces/Loris/pull/3898","diff_url":"https://github.com/aces/Loris/pull/3898.diff","patch_url":"https://github.com/aces/Loris/pull/3898.patch"},"body":"### Brief summary of changes\r\n\r\nFor the project we are working at CHU Sainte-Justine we realize we will need to set (for a given user) access to the system but only for a given time window (due to policies of data access and privacy). It's a specific requirement of our project that could be useful for others. \r\nThe way it was implemented (following @ridz1208 recommendations. Very helpful!! Thanks!) should not break/interfere others functionalities of the system. \r\n\r\nThe changes are all additions limited to the following files:\r\n\r\nphp/libraries/SinglePointLogin.class.inc\r\nmodules/user_accounts/templates/form_edit_user.tpl\r\nmodules/user_accounts/php/edit_user.class.inc\r\n\r\nAlso it's necessary to add two fields on the Users table:\r\n\r\nSQL/New_patches/2018-08-22_user_activeFrom-activeTo.sql\r\n\r\n### This resolves issue...\r\n\r\n- [ ] Redmine? # -\r\n\r\n- [ ] Github? # -\r\n\r\n### To test this change...\r\n\r\n1. To access the system with a user with permissions to add/modify another.\r\n2. To modify the user access time windows filling the new fields 'Active from' and/or 'Active to' that should shows up between the fields 'Active' and 'Pending approval'. NULLs are allowed, which will mean that there is not restrictions.\r\n3. According to the dates set the user modified should not be able to access the system (due to expired/no yet active user).\r\n\r\n![image](https://user-images.githubusercontent.com/37309344/44554134-c6614400-a6fd-11e8-92d6-80934e8b2af3.png)\r\n\r\n![image2](https://user-images.githubusercontent.com/37309344/44554143-ceb97f00-a6fd-11e8-88af-9c946a970dba.png)\r\n\r\nAll suggestions/modifications are very welcome! Thanks.\r\nCSJ team."},"comment":{"url":"https://api.github.com/repos/aces/Loris/issues/comments/418706759","html_url":"https://github.com/aces/Loris/pull/3898#issuecomment-418706759","issue_url":"https://api.github.com/repos/aces/Loris/issues/3898","id":418706759,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODcwNjc1OQ==","user":{"login":"racostas","id":37309344,"node_id":"MDQ6VXNlcjM3MzA5MzQ0","avatar_url":"https://avatars0.githubusercontent.com/u/37309344?v=4","gravatar_id":"","url":"https://api.github.com/users/racostas","html_url":"https://github.com/racostas","followers_url":"https://api.github.com/users/racostas/followers","following_url":"https://api.github.com/users/racostas/following{/other_user}","gists_url":"https://api.github.com/users/racostas/gists{/gist_id}","starred_url":"https://api.github.com/users/racostas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racostas/subscriptions","organizations_url":"https://api.github.com/users/racostas/orgs","repos_url":"https://api.github.com/users/racostas/repos","events_url":"https://api.github.com/users/racostas/events{/privacy}","received_events_url":"https://api.github.com/users/racostas/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T12:08:10Z","updated_at":"2018-09-05T12:08:10Z","author_association":"NONE","body":" Hi @kongtiaowang. Travis test passed now thank to your insights. Great help! Thank you very much!"}}
{"actor":{"display_login":"racostas"}}