{"action":"created","comment":{"url":"https://api.github.com/repos/libopenstorage/secrets/pulls/comments/174959618","pull_request_review_id":104412115,"id":174959618,"diff_hunk":"@@ -42,31 +60,26 @@ func NewAwsSecretTest(secretConfig map[string]interface{}) (test.SecretTest, err\n func (a *awsSecretTest) TestPutSecret(t *testing.T) error {","path":"aws/aws_kms_test.go","position":55,"original_position":54,"commit_id":"39e79617eef070314a7fc2ec2f0b5c2ad4195195","original_commit_id":"8c851eaa4afec022438cb47f46b9801e4044378f","user":{"login":"adityadani","id":313611,"avatar_url":"https://avatars3.githubusercontent.com/u/313611?v=4","gravatar_id":"","url":"https://api.github.com/users/adityadani","html_url":"https://github.com/adityadani","followers_url":"https://api.github.com/users/adityadani/followers","following_url":"https://api.github.com/users/adityadani/following{/other_user}","gists_url":"https://api.github.com/users/adityadani/gists{/gist_id}","starred_url":"https://api.github.com/users/adityadani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityadani/subscriptions","organizations_url":"https://api.github.com/users/adityadani/orgs","repos_url":"https://api.github.com/users/adityadani/repos","events_url":"https://api.github.com/users/adityadani/events{/privacy}","received_events_url":"https://api.github.com/users/adityadani/received_events","type":"User","site_admin":false},"body":"we are testing filePersistenceStore. I have removed the part where we used to pass in the cipherBlob itself in the API and then compare what was returned from KMS.","created_at":"2018-03-15T23:11:32Z","updated_at":"2018-03-15T23:11:32Z","html_url":"https://github.com/libopenstorage/secrets/pull/7#discussion_r174959618","pull_request_url":"https://api.github.com/repos/libopenstorage/secrets/pulls/7","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/libopenstorage/secrets/pulls/comments/174959618"},"html":{"href":"https://github.com/libopenstorage/secrets/pull/7#discussion_r174959618"},"pull_request":{"href":"https://api.github.com/repos/libopenstorage/secrets/pulls/7"}},"in_reply_to_id":174938486},"pull_request":{"url":"https://api.github.com/repos/libopenstorage/secrets/pulls/7","id":175128125,"html_url":"https://github.com/libopenstorage/secrets/pull/7","diff_url":"https://github.com/libopenstorage/secrets/pull/7.diff","patch_url":"https://github.com/libopenstorage/secrets/pull/7.patch","issue_url":"https://api.github.com/repos/libopenstorage/secrets/issues/7","number":7,"state":"open","locked":false,"title":"Revamp the AWS KMS implementation of the Secrets interface.","user":{"login":"adityadani","id":313611,"avatar_url":"https://avatars3.githubusercontent.com/u/313611?v=4","gravatar_id":"","url":"https://api.github.com/users/adityadani","html_url":"https://github.com/adityadani","followers_url":"https://api.github.com/users/adityadani/followers","following_url":"https://api.github.com/users/adityadani/following{/other_user}","gists_url":"https://api.github.com/users/adityadani/gists{/gist_id}","starred_url":"https://api.github.com/users/adityadani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityadani/subscriptions","organizations_url":"https://api.github.com/users/adityadani/orgs","repos_url":"https://api.github.com/users/adityadani/repos","events_url":"https://api.github.com/users/adityadani/events{/privacy}","received_events_url":"https://api.github.com/users/adityadani/received_events","type":"User","site_admin":false},"body":"AWS KMS cannot act as a secret store where we can store user data.\r\nIt provides a mechanism to generate DataKeys that could be used\r\nfor encrypting user data. In KMS when you generate a DataKey it returns\r\n1. [Private Key]: PlainText which should be used for encrypting data.\r\n2. [Public Key]: CipherText which should be used for subsequent calls to KMS to fetch the private key.\r\n\r\n- Add two persistence stores for AWS KMS to store the public key\r\n  - filePersistenceStore - uses files on host\r\n  - kvdbPersistenceStore - uses a key value database using portworx/kvdb\r\n\r\n- Add support for storing user data in a secret store\r\n  - AWS KMS in conjunction with kvdb can store user data.\r\n  - For every secretData to be stored, a new DataKey is generated in KMS.\r\n  - PutSecret -> Using the private key and AES+GCM algorithm, the user data is encrypted and then stored in kvdb.\r\n  - GetSecret -> Using the public key, the private key is fetched from KMS. The encrypted data stored in kvdb is then fetched\r\n                 and using the same AES with GCM algorithm is used to decrypt the user data.","created_at":"2018-03-15T01:40:13Z","updated_at":"2018-03-15T23:11:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75aba7722bceb91a58407ec528086729c7233bd7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libopenstorage/secrets/pulls/7/commits","review_comments_url":"https://api.github.com/repos/libopenstorage/secrets/pulls/7/comments","review_comment_url":"https://api.github.com/repos/libopenstorage/secrets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libopenstorage/secrets/issues/7/comments","statuses_url":"https://api.github.com/repos/libopenstorage/secrets/statuses/39e79617eef070314a7fc2ec2f0b5c2ad4195195","head":{"label":"libopenstorage:aws_kms_revamp","ref":"aws_kms_revamp","sha":"39e79617eef070314a7fc2ec2f0b5c2ad4195195","user":{"login":"libopenstorage","id":13478636,"avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":79288223,"name":"secrets","full_name":"libopenstorage/secrets","owner":{"login":"libopenstorage","id":13478636,"avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libopenstorage/secrets","description":"Openstorage support for Key Management Systems","fork":false,"url":"https://api.github.com/repos/libopenstorage/secrets","forks_url":"https://api.github.com/repos/libopenstorage/secrets/forks","keys_url":"https://api.github.com/repos/libopenstorage/secrets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libopenstorage/secrets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libopenstorage/secrets/teams","hooks_url":"https://api.github.com/repos/libopenstorage/secrets/hooks","issue_events_url":"https://api.github.com/repos/libopenstorage/secrets/issues/events{/number}","events_url":"https://api.github.com/repos/libopenstorage/secrets/events","assignees_url":"https://api.github.com/repos/libopenstorage/secrets/assignees{/user}","branches_url":"https://api.github.com/repos/libopenstorage/secrets/branches{/branch}","tags_url":"https://api.github.com/repos/libopenstorage/secrets/tags","blobs_url":"https://api.github.com/repos/libopenstorage/secrets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libopenstorage/secrets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libopenstorage/secrets/git/refs{/sha}","trees_url":"https://api.github.com/repos/libopenstorage/secrets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libopenstorage/secrets/statuses/{sha}","languages_url":"https://api.github.com/repos/libopenstorage/secrets/languages","stargazers_url":"https://api.github.com/repos/libopenstorage/secrets/stargazers","contributors_url":"https://api.github.com/repos/libopenstorage/secrets/contributors","subscribers_url":"https://api.github.com/repos/libopenstorage/secrets/subscribers","subscription_url":"https://api.github.com/repos/libopenstorage/secrets/subscription","commits_url":"https://api.github.com/repos/libopenstorage/secrets/commits{/sha}","git_commits_url":"https://api.github.com/repos/libopenstorage/secrets/git/commits{/sha}","comments_url":"https://api.github.com/repos/libopenstorage/secrets/comments{/number}","issue_comment_url":"https://api.github.com/repos/libopenstorage/secrets/issues/comments{/number}","contents_url":"https://api.github.com/repos/libopenstorage/secrets/contents/{+path}","compare_url":"https://api.github.com/repos/libopenstorage/secrets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libopenstorage/secrets/merges","archive_url":"https://api.github.com/repos/libopenstorage/secrets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libopenstorage/secrets/downloads","issues_url":"https://api.github.com/repos/libopenstorage/secrets/issues{/number}","pulls_url":"https://api.github.com/repos/libopenstorage/secrets/pulls{/number}","milestones_url":"https://api.github.com/repos/libopenstorage/secrets/milestones{/number}","notifications_url":"https://api.github.com/repos/libopenstorage/secrets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libopenstorage/secrets/labels{/name}","releases_url":"https://api.github.com/repos/libopenstorage/secrets/releases{/id}","deployments_url":"https://api.github.com/repos/libopenstorage/secrets/deployments","created_at":"2017-01-18T00:49:47Z","updated_at":"2017-12-15T22:14:36Z","pushed_at":"2018-03-15T23:10:27Z","git_url":"git://github.com/libopenstorage/secrets.git","ssh_url":"git@github.com:libopenstorage/secrets.git","clone_url":"https://github.com/libopenstorage/secrets.git","svn_url":"https://github.com/libopenstorage/secrets","homepage":null,"size":41,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"libopenstorage:master","ref":"master","sha":"9a48e0bd61b89967d13b0b5c4a1b8dd956582396","user":{"login":"libopenstorage","id":13478636,"avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":79288223,"name":"secrets","full_name":"libopenstorage/secrets","owner":{"login":"libopenstorage","id":13478636,"avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libopenstorage/secrets","description":"Openstorage support for Key Management Systems","fork":false,"url":"https://api.github.com/repos/libopenstorage/secrets","forks_url":"https://api.github.com/repos/libopenstorage/secrets/forks","keys_url":"https://api.github.com/repos/libopenstorage/secrets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libopenstorage/secrets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libopenstorage/secrets/teams","hooks_url":"https://api.github.com/repos/libopenstorage/secrets/hooks","issue_events_url":"https://api.github.com/repos/libopenstorage/secrets/issues/events{/number}","events_url":"https://api.github.com/repos/libopenstorage/secrets/events","assignees_url":"https://api.github.com/repos/libopenstorage/secrets/assignees{/user}","branches_url":"https://api.github.com/repos/libopenstorage/secrets/branches{/branch}","tags_url":"https://api.github.com/repos/libopenstorage/secrets/tags","blobs_url":"https://api.github.com/repos/libopenstorage/secrets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libopenstorage/secrets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libopenstorage/secrets/git/refs{/sha}","trees_url":"https://api.github.com/repos/libopenstorage/secrets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libopenstorage/secrets/statuses/{sha}","languages_url":"https://api.github.com/repos/libopenstorage/secrets/languages","stargazers_url":"https://api.github.com/repos/libopenstorage/secrets/stargazers","contributors_url":"https://api.github.com/repos/libopenstorage/secrets/contributors","subscribers_url":"https://api.github.com/repos/libopenstorage/secrets/subscribers","subscription_url":"https://api.github.com/repos/libopenstorage/secrets/subscription","commits_url":"https://api.github.com/repos/libopenstorage/secrets/commits{/sha}","git_commits_url":"https://api.github.com/repos/libopenstorage/secrets/git/commits{/sha}","comments_url":"https://api.github.com/repos/libopenstorage/secrets/comments{/number}","issue_comment_url":"https://api.github.com/repos/libopenstorage/secrets/issues/comments{/number}","contents_url":"https://api.github.com/repos/libopenstorage/secrets/contents/{+path}","compare_url":"https://api.github.com/repos/libopenstorage/secrets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libopenstorage/secrets/merges","archive_url":"https://api.github.com/repos/libopenstorage/secrets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libopenstorage/secrets/downloads","issues_url":"https://api.github.com/repos/libopenstorage/secrets/issues{/number}","pulls_url":"https://api.github.com/repos/libopenstorage/secrets/pulls{/number}","milestones_url":"https://api.github.com/repos/libopenstorage/secrets/milestones{/number}","notifications_url":"https://api.github.com/repos/libopenstorage/secrets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libopenstorage/secrets/labels{/name}","releases_url":"https://api.github.com/repos/libopenstorage/secrets/releases{/id}","deployments_url":"https://api.github.com/repos/libopenstorage/secrets/deployments","created_at":"2017-01-18T00:49:47Z","updated_at":"2017-12-15T22:14:36Z","pushed_at":"2018-03-15T23:10:27Z","git_url":"git://github.com/libopenstorage/secrets.git","ssh_url":"git@github.com:libopenstorage/secrets.git","clone_url":"https://github.com/libopenstorage/secrets.git","svn_url":"https://github.com/libopenstorage/secrets","homepage":null,"size":41,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libopenstorage/secrets/pulls/7"},"html":{"href":"https://github.com/libopenstorage/secrets/pull/7"},"issue":{"href":"https://api.github.com/repos/libopenstorage/secrets/issues/7"},"comments":{"href":"https://api.github.com/repos/libopenstorage/secrets/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/libopenstorage/secrets/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/libopenstorage/secrets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libopenstorage/secrets/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/libopenstorage/secrets/statuses/39e79617eef070314a7fc2ec2f0b5c2ad4195195"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"adityadani"}}