{"action":"created","comment":{"url":"https://api.github.com/repos/uber/nebula.gl/pulls/comments/198886379","pull_request_review_id":132899034,"id":198886379,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODg4NjM3OQ==","diff_hunk":"@@ -119,21 +168,23 @@ export default class Example extends Component<\n           }\n         });\n       },\n-      onStopDraggingPoint: ({ coordinateIndexes }) => {\n-        // eslint-disable-next-line no-console, no-undef\n-        console.log(`Stop dragging point`, coordinateIndexes);\n+      onStopDraggingPoint: ({ featureIndex, coordinateIndexes }) => {\n+        console.log(`Stop dragging point`, featureIndex, coordinateIndexes); // eslint-disable-line\n       },\n \n-      // Can specify GeoJsonLayer props\n-      getFillColor: () => [0x00, 0x20, 0x70, 0x30],\n-      getLineColor: () => [0x00, 0x20, 0x70, 0xc0],\n-      getLineWidth: () => 30,\n+      // Specify the same GeoJsonLayer props\n       lineWidthMinPixels: 2,\n-      lineWidthMaxPixels: 10,\n \n-      // As well as point layer props\n-      getPointColor: () => [0x00, 0x20, 0x70, 0xff],\n-      pointHighlightColor: [0xff, 0xff, 0xff, 0xff]\n+      // Accessors receive an isSelected argument\n+      getFillColor: (feature, isSelected) => {\n+        return isSelected ? [0x20, 0x40, 0x90, 0xc0] : [0x20, 0x20, 0x20, 0x30];","path":"examples/deck/example.js","position":168,"original_position":168,"commit_id":"331471c2ddae7cf5f02bf0898e07218096e9386a","original_commit_id":"331471c2ddae7cf5f02bf0898e07218096e9386a","user":{"login":"supersonicclay","id":469582,"node_id":"MDQ6VXNlcjQ2OTU4Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/469582?v=4","gravatar_id":"","url":"https://api.github.com/users/supersonicclay","html_url":"https://github.com/supersonicclay","followers_url":"https://api.github.com/users/supersonicclay/followers","following_url":"https://api.github.com/users/supersonicclay/following{/other_user}","gists_url":"https://api.github.com/users/supersonicclay/gists{/gist_id}","starred_url":"https://api.github.com/users/supersonicclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supersonicclay/subscriptions","organizations_url":"https://api.github.com/users/supersonicclay/orgs","repos_url":"https://api.github.com/users/supersonicclay/repos","events_url":"https://api.github.com/users/supersonicclay/events{/privacy}","received_events_url":"https://api.github.com/users/supersonicclay/received_events","type":"User","site_admin":false},"body":"that's in `EditableGeoJsonLayer` itself","created_at":"2018-06-28T15:31:41Z","updated_at":"2018-06-28T15:31:41Z","html_url":"https://github.com/uber/nebula.gl/pull/11#discussion_r198886379","pull_request_url":"https://api.github.com/repos/uber/nebula.gl/pulls/11","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/uber/nebula.gl/pulls/comments/198886379"},"html":{"href":"https://github.com/uber/nebula.gl/pull/11#discussion_r198886379"},"pull_request":{"href":"https://api.github.com/repos/uber/nebula.gl/pulls/11"}},"in_reply_to_id":198837626},"pull_request":{"url":"https://api.github.com/repos/uber/nebula.gl/pulls/11","id":197907356,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTA3MzU2","html_url":"https://github.com/uber/nebula.gl/pull/11","diff_url":"https://github.com/uber/nebula.gl/pull/11.diff","patch_url":"https://github.com/uber/nebula.gl/pull/11.patch","issue_url":"https://api.github.com/repos/uber/nebula.gl/issues/11","number":11,"state":"open","locked":false,"title":"Refactor EditablePolygonsLayer into generic EditableGeoJsonLayer","user":{"login":"supersonicclay","id":469582,"node_id":"MDQ6VXNlcjQ2OTU4Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/469582?v=4","gravatar_id":"","url":"https://api.github.com/users/supersonicclay","html_url":"https://github.com/supersonicclay","followers_url":"https://api.github.com/users/supersonicclay/followers","following_url":"https://api.github.com/users/supersonicclay/following{/other_user}","gists_url":"https://api.github.com/users/supersonicclay/gists{/gist_id}","starred_url":"https://api.github.com/users/supersonicclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supersonicclay/subscriptions","organizations_url":"https://api.github.com/users/supersonicclay/orgs","repos_url":"https://api.github.com/users/supersonicclay/repos","events_url":"https://api.github.com/users/supersonicclay/events{/privacy}","received_events_url":"https://api.github.com/users/supersonicclay/received_events","type":"User","site_admin":false},"body":"`EditableGeoJsonLayer` has the ability to edit any feature in a `FeatureCollection` with any of the following types of geometry:\r\n\r\n* Point\r\n* MultiPoint\r\n* LineString\r\n* MultiLineString\r\n* Polygon\r\n* MultiPolygon\r\n\r\n_Note: there are a couple known issues with this until we upgrade it to use deck 6.0_\r\n\r\n* highlighting of selected feature doesn't always work\r\n* clicking a feature to select it doesn't always work\r\n","created_at":"2018-06-28T03:23:48Z","updated_at":"2018-06-28T15:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0e120f58ffc11e8502ac1223d8daea8b87b2477","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/nebula.gl/pulls/11/commits","review_comments_url":"https://api.github.com/repos/uber/nebula.gl/pulls/11/comments","review_comment_url":"https://api.github.com/repos/uber/nebula.gl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/nebula.gl/issues/11/comments","statuses_url":"https://api.github.com/repos/uber/nebula.gl/statuses/331471c2ddae7cf5f02bf0898e07218096e9386a","head":{"label":"uber:editable-geojson","ref":"editable-geojson","sha":"331471c2ddae7cf5f02bf0898e07218096e9386a","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":121664013,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE2NjQwMTM=","name":"nebula.gl","full_name":"uber/nebula.gl","owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/nebula.gl","description":"A suite of 3D-enabled data editing overlays, suitable for deck.gl","fork":false,"url":"https://api.github.com/repos/uber/nebula.gl","forks_url":"https://api.github.com/repos/uber/nebula.gl/forks","keys_url":"https://api.github.com/repos/uber/nebula.gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/nebula.gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/nebula.gl/teams","hooks_url":"https://api.github.com/repos/uber/nebula.gl/hooks","issue_events_url":"https://api.github.com/repos/uber/nebula.gl/issues/events{/number}","events_url":"https://api.github.com/repos/uber/nebula.gl/events","assignees_url":"https://api.github.com/repos/uber/nebula.gl/assignees{/user}","branches_url":"https://api.github.com/repos/uber/nebula.gl/branches{/branch}","tags_url":"https://api.github.com/repos/uber/nebula.gl/tags","blobs_url":"https://api.github.com/repos/uber/nebula.gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/nebula.gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/nebula.gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/nebula.gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/nebula.gl/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/nebula.gl/languages","stargazers_url":"https://api.github.com/repos/uber/nebula.gl/stargazers","contributors_url":"https://api.github.com/repos/uber/nebula.gl/contributors","subscribers_url":"https://api.github.com/repos/uber/nebula.gl/subscribers","subscription_url":"https://api.github.com/repos/uber/nebula.gl/subscription","commits_url":"https://api.github.com/repos/uber/nebula.gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/nebula.gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/nebula.gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/nebula.gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/nebula.gl/contents/{+path}","compare_url":"https://api.github.com/repos/uber/nebula.gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/nebula.gl/merges","archive_url":"https://api.github.com/repos/uber/nebula.gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/nebula.gl/downloads","issues_url":"https://api.github.com/repos/uber/nebula.gl/issues{/number}","pulls_url":"https://api.github.com/repos/uber/nebula.gl/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/nebula.gl/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/nebula.gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/nebula.gl/labels{/name}","releases_url":"https://api.github.com/repos/uber/nebula.gl/releases{/id}","deployments_url":"https://api.github.com/repos/uber/nebula.gl/deployments","created_at":"2018-02-15T18:15:02Z","updated_at":"2018-06-27T22:07:42Z","pushed_at":"2018-06-28T03:45:27Z","git_url":"git://github.com/uber/nebula.gl.git","ssh_url":"git@github.com:uber/nebula.gl.git","clone_url":"https://github.com/uber/nebula.gl.git","svn_url":"https://github.com/uber/nebula.gl","homepage":"http://neb.gl/","size":2230,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":4,"watchers":15,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"80907b1377453721c76617cdd7e972c835af780b","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":121664013,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE2NjQwMTM=","name":"nebula.gl","full_name":"uber/nebula.gl","owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/nebula.gl","description":"A suite of 3D-enabled data editing overlays, suitable for deck.gl","fork":false,"url":"https://api.github.com/repos/uber/nebula.gl","forks_url":"https://api.github.com/repos/uber/nebula.gl/forks","keys_url":"https://api.github.com/repos/uber/nebula.gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/nebula.gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/nebula.gl/teams","hooks_url":"https://api.github.com/repos/uber/nebula.gl/hooks","issue_events_url":"https://api.github.com/repos/uber/nebula.gl/issues/events{/number}","events_url":"https://api.github.com/repos/uber/nebula.gl/events","assignees_url":"https://api.github.com/repos/uber/nebula.gl/assignees{/user}","branches_url":"https://api.github.com/repos/uber/nebula.gl/branches{/branch}","tags_url":"https://api.github.com/repos/uber/nebula.gl/tags","blobs_url":"https://api.github.com/repos/uber/nebula.gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/nebula.gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/nebula.gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/nebula.gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/nebula.gl/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/nebula.gl/languages","stargazers_url":"https://api.github.com/repos/uber/nebula.gl/stargazers","contributors_url":"https://api.github.com/repos/uber/nebula.gl/contributors","subscribers_url":"https://api.github.com/repos/uber/nebula.gl/subscribers","subscription_url":"https://api.github.com/repos/uber/nebula.gl/subscription","commits_url":"https://api.github.com/repos/uber/nebula.gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/nebula.gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/nebula.gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/nebula.gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/nebula.gl/contents/{+path}","compare_url":"https://api.github.com/repos/uber/nebula.gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/nebula.gl/merges","archive_url":"https://api.github.com/repos/uber/nebula.gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/nebula.gl/downloads","issues_url":"https://api.github.com/repos/uber/nebula.gl/issues{/number}","pulls_url":"https://api.github.com/repos/uber/nebula.gl/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/nebula.gl/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/nebula.gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/nebula.gl/labels{/name}","releases_url":"https://api.github.com/repos/uber/nebula.gl/releases{/id}","deployments_url":"https://api.github.com/repos/uber/nebula.gl/deployments","created_at":"2018-02-15T18:15:02Z","updated_at":"2018-06-27T22:07:42Z","pushed_at":"2018-06-28T03:45:27Z","git_url":"git://github.com/uber/nebula.gl.git","ssh_url":"git@github.com:uber/nebula.gl.git","clone_url":"https://github.com/uber/nebula.gl.git","svn_url":"https://github.com/uber/nebula.gl","homepage":"http://neb.gl/","size":2230,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":4,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/nebula.gl/pulls/11"},"html":{"href":"https://github.com/uber/nebula.gl/pull/11"},"issue":{"href":"https://api.github.com/repos/uber/nebula.gl/issues/11"},"comments":{"href":"https://api.github.com/repos/uber/nebula.gl/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/nebula.gl/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/nebula.gl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/nebula.gl/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/uber/nebula.gl/statuses/331471c2ddae7cf5f02bf0898e07218096e9386a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"supersonicclay"}}