{"action":"closed","number":250,"pull_request":{"url":"https://api.github.com/repos/clj-time/clj-time/pulls/250","id":201576722,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTc2NzIy","html_url":"https://github.com/clj-time/clj-time/pull/250","diff_url":"https://github.com/clj-time/clj-time/pull/250.diff","patch_url":"https://github.com/clj-time/clj-time/pull/250.patch","issue_url":"https://api.github.com/repos/clj-time/clj-time/issues/250","number":250,"state":"closed","locked":false,"title":"Convert to local datetime during timezone conversion","user":{"login":"mourjo","id":10502323,"node_id":"MDQ6VXNlcjEwNTAyMzIz","avatar_url":"https://avatars0.githubusercontent.com/u/10502323?v=4","gravatar_id":"","url":"https://api.github.com/users/mourjo","html_url":"https://github.com/mourjo","followers_url":"https://api.github.com/users/mourjo/followers","following_url":"https://api.github.com/users/mourjo/following{/other_user}","gists_url":"https://api.github.com/users/mourjo/gists{/gist_id}","starred_url":"https://api.github.com/users/mourjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mourjo/subscriptions","organizations_url":"https://api.github.com/users/mourjo/orgs","repos_url":"https://api.github.com/users/mourjo/repos","events_url":"https://api.github.com/users/mourjo/events{/privacy}","received_events_url":"https://api.github.com/users/mourjo/received_events","type":"User","site_admin":false},"body":"When we convert a DateTime to another timezone, there could be a case\r\nthat the daylight savings starts or ends during the course of that\r\nday. In this case, the changed daylight savings time should apply only\r\nafter that point in the day. This is achieved by converting the\r\ndate-time object to a local-date-time object and then converting it\r\nback to a date-time-object.\r\n\r\nFor example, in Asia/Amman, daylight savings ends on 26 Oct at 1 am,\r\nand the timezone offset becomes +03:00 from +02:00.\r\n;; Older behaviour:\r\n(let [dtz ^DateTimeZone (clj-time.core/time-zone-for-id \"Asia/Amman\")]\r\n  (-> (clj-time.core/date-time 2018 3 26)\r\n      (clj-time.core/from-time-zone dtz) str))\r\n;; => 2018-10-26T00:00:00.000+02:00\r\n\r\nThe above should not be in the +02:00 timezone, but in the +03:00\r\ntimezone\r\n;; Altered behaviour:\r\n(let [dtz ^DateTimeZone (clj-time.core/time-zone-for-id \"Asia/Amman\")]\r\n  (-> (clj-time.core/date-time 2018 10 26)\r\n      (clj-time.core/from-time-zone dtz)))\r\n;; => 2018-10-26T00:00:00.000+03:00","created_at":"2018-07-16T09:06:13Z","updated_at":"2018-08-02T23:47:55Z","closed_at":"2018-08-02T23:47:55Z","merged_at":null,"merge_commit_sha":"8051ee5657971ac22bbb9543e5134c3574facd9e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clj-time/clj-time/pulls/250/commits","review_comments_url":"https://api.github.com/repos/clj-time/clj-time/pulls/250/comments","review_comment_url":"https://api.github.com/repos/clj-time/clj-time/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clj-time/clj-time/issues/250/comments","statuses_url":"https://api.github.com/repos/clj-time/clj-time/statuses/d911e6883dc9cb78c03195d299acb5d8e918428b","head":{"label":"mourjo:local-date-time-for-tz-conversion","ref":"local-date-time-for-tz-conversion","sha":"d911e6883dc9cb78c03195d299acb5d8e918428b","user":{"login":"mourjo","id":10502323,"node_id":"MDQ6VXNlcjEwNTAyMzIz","avatar_url":"https://avatars0.githubusercontent.com/u/10502323?v=4","gravatar_id":"","url":"https://api.github.com/users/mourjo","html_url":"https://github.com/mourjo","followers_url":"https://api.github.com/users/mourjo/followers","following_url":"https://api.github.com/users/mourjo/following{/other_user}","gists_url":"https://api.github.com/users/mourjo/gists{/gist_id}","starred_url":"https://api.github.com/users/mourjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mourjo/subscriptions","organizations_url":"https://api.github.com/users/mourjo/orgs","repos_url":"https://api.github.com/users/mourjo/repos","events_url":"https://api.github.com/users/mourjo/events{/privacy}","received_events_url":"https://api.github.com/users/mourjo/received_events","type":"User","site_admin":false},"repo":{"id":141109324,"node_id":"MDEwOlJlcG9zaXRvcnkxNDExMDkzMjQ=","name":"clj-time","full_name":"mourjo/clj-time","owner":{"login":"mourjo","id":10502323,"node_id":"MDQ6VXNlcjEwNTAyMzIz","avatar_url":"https://avatars0.githubusercontent.com/u/10502323?v=4","gravatar_id":"","url":"https://api.github.com/users/mourjo","html_url":"https://github.com/mourjo","followers_url":"https://api.github.com/users/mourjo/followers","following_url":"https://api.github.com/users/mourjo/following{/other_user}","gists_url":"https://api.github.com/users/mourjo/gists{/gist_id}","starred_url":"https://api.github.com/users/mourjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mourjo/subscriptions","organizations_url":"https://api.github.com/users/mourjo/orgs","repos_url":"https://api.github.com/users/mourjo/repos","events_url":"https://api.github.com/users/mourjo/events{/privacy}","received_events_url":"https://api.github.com/users/mourjo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mourjo/clj-time","description":"A date and time library for Clojure, wrapping the Joda Time library.","fork":true,"url":"https://api.github.com/repos/mourjo/clj-time","forks_url":"https://api.github.com/repos/mourjo/clj-time/forks","keys_url":"https://api.github.com/repos/mourjo/clj-time/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mourjo/clj-time/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mourjo/clj-time/teams","hooks_url":"https://api.github.com/repos/mourjo/clj-time/hooks","issue_events_url":"https://api.github.com/repos/mourjo/clj-time/issues/events{/number}","events_url":"https://api.github.com/repos/mourjo/clj-time/events","assignees_url":"https://api.github.com/repos/mourjo/clj-time/assignees{/user}","branches_url":"https://api.github.com/repos/mourjo/clj-time/branches{/branch}","tags_url":"https://api.github.com/repos/mourjo/clj-time/tags","blobs_url":"https://api.github.com/repos/mourjo/clj-time/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mourjo/clj-time/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mourjo/clj-time/git/refs{/sha}","trees_url":"https://api.github.com/repos/mourjo/clj-time/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mourjo/clj-time/statuses/{sha}","languages_url":"https://api.github.com/repos/mourjo/clj-time/languages","stargazers_url":"https://api.github.com/repos/mourjo/clj-time/stargazers","contributors_url":"https://api.github.com/repos/mourjo/clj-time/contributors","subscribers_url":"https://api.github.com/repos/mourjo/clj-time/subscribers","subscription_url":"https://api.github.com/repos/mourjo/clj-time/subscription","commits_url":"https://api.github.com/repos/mourjo/clj-time/commits{/sha}","git_commits_url":"https://api.github.com/repos/mourjo/clj-time/git/commits{/sha}","comments_url":"https://api.github.com/repos/mourjo/clj-time/comments{/number}","issue_comment_url":"https://api.github.com/repos/mourjo/clj-time/issues/comments{/number}","contents_url":"https://api.github.com/repos/mourjo/clj-time/contents/{+path}","compare_url":"https://api.github.com/repos/mourjo/clj-time/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mourjo/clj-time/merges","archive_url":"https://api.github.com/repos/mourjo/clj-time/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mourjo/clj-time/downloads","issues_url":"https://api.github.com/repos/mourjo/clj-time/issues{/number}","pulls_url":"https://api.github.com/repos/mourjo/clj-time/pulls{/number}","milestones_url":"https://api.github.com/repos/mourjo/clj-time/milestones{/number}","notifications_url":"https://api.github.com/repos/mourjo/clj-time/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mourjo/clj-time/labels{/name}","releases_url":"https://api.github.com/repos/mourjo/clj-time/releases{/id}","deployments_url":"https://api.github.com/repos/mourjo/clj-time/deployments","created_at":"2018-07-16T08:25:16Z","updated_at":"2018-07-16T08:25:18Z","pushed_at":"2018-07-16T09:05:32Z","git_url":"git://github.com/mourjo/clj-time.git","ssh_url":"git@github.com:mourjo/clj-time.git","clone_url":"https://github.com/mourjo/clj-time.git","svn_url":"https://github.com/mourjo/clj-time","homepage":"","size":572,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clj-time:master","ref":"master","sha":"b9227ef978f5b878d251c9401a41656f7d8a11eb","user":{"login":"clj-time","id":4021010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMjEwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4021010?v=4","gravatar_id":"","url":"https://api.github.com/users/clj-time","html_url":"https://github.com/clj-time","followers_url":"https://api.github.com/users/clj-time/followers","following_url":"https://api.github.com/users/clj-time/following{/other_user}","gists_url":"https://api.github.com/users/clj-time/gists{/gist_id}","starred_url":"https://api.github.com/users/clj-time/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clj-time/subscriptions","organizations_url":"https://api.github.com/users/clj-time/orgs","repos_url":"https://api.github.com/users/clj-time/repos","events_url":"https://api.github.com/users/clj-time/events{/privacy}","received_events_url":"https://api.github.com/users/clj-time/received_events","type":"Organization","site_admin":false},"repo":{"id":2581048,"node_id":"MDEwOlJlcG9zaXRvcnkyNTgxMDQ4","name":"clj-time","full_name":"clj-time/clj-time","owner":{"login":"clj-time","id":4021010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMjEwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4021010?v=4","gravatar_id":"","url":"https://api.github.com/users/clj-time","html_url":"https://github.com/clj-time","followers_url":"https://api.github.com/users/clj-time/followers","following_url":"https://api.github.com/users/clj-time/following{/other_user}","gists_url":"https://api.github.com/users/clj-time/gists{/gist_id}","starred_url":"https://api.github.com/users/clj-time/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clj-time/subscriptions","organizations_url":"https://api.github.com/users/clj-time/orgs","repos_url":"https://api.github.com/users/clj-time/repos","events_url":"https://api.github.com/users/clj-time/events{/privacy}","received_events_url":"https://api.github.com/users/clj-time/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clj-time/clj-time","description":"A date and time library for Clojure, wrapping the Joda Time library.","fork":true,"url":"https://api.github.com/repos/clj-time/clj-time","forks_url":"https://api.github.com/repos/clj-time/clj-time/forks","keys_url":"https://api.github.com/repos/clj-time/clj-time/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clj-time/clj-time/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clj-time/clj-time/teams","hooks_url":"https://api.github.com/repos/clj-time/clj-time/hooks","issue_events_url":"https://api.github.com/repos/clj-time/clj-time/issues/events{/number}","events_url":"https://api.github.com/repos/clj-time/clj-time/events","assignees_url":"https://api.github.com/repos/clj-time/clj-time/assignees{/user}","branches_url":"https://api.github.com/repos/clj-time/clj-time/branches{/branch}","tags_url":"https://api.github.com/repos/clj-time/clj-time/tags","blobs_url":"https://api.github.com/repos/clj-time/clj-time/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clj-time/clj-time/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clj-time/clj-time/git/refs{/sha}","trees_url":"https://api.github.com/repos/clj-time/clj-time/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clj-time/clj-time/statuses/{sha}","languages_url":"https://api.github.com/repos/clj-time/clj-time/languages","stargazers_url":"https://api.github.com/repos/clj-time/clj-time/stargazers","contributors_url":"https://api.github.com/repos/clj-time/clj-time/contributors","subscribers_url":"https://api.github.com/repos/clj-time/clj-time/subscribers","subscription_url":"https://api.github.com/repos/clj-time/clj-time/subscription","commits_url":"https://api.github.com/repos/clj-time/clj-time/commits{/sha}","git_commits_url":"https://api.github.com/repos/clj-time/clj-time/git/commits{/sha}","comments_url":"https://api.github.com/repos/clj-time/clj-time/comments{/number}","issue_comment_url":"https://api.github.com/repos/clj-time/clj-time/issues/comments{/number}","contents_url":"https://api.github.com/repos/clj-time/clj-time/contents/{+path}","compare_url":"https://api.github.com/repos/clj-time/clj-time/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clj-time/clj-time/merges","archive_url":"https://api.github.com/repos/clj-time/clj-time/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clj-time/clj-time/downloads","issues_url":"https://api.github.com/repos/clj-time/clj-time/issues{/number}","pulls_url":"https://api.github.com/repos/clj-time/clj-time/pulls{/number}","milestones_url":"https://api.github.com/repos/clj-time/clj-time/milestones{/number}","notifications_url":"https://api.github.com/repos/clj-time/clj-time/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clj-time/clj-time/labels{/name}","releases_url":"https://api.github.com/repos/clj-time/clj-time/releases{/id}","deployments_url":"https://api.github.com/repos/clj-time/clj-time/deployments","created_at":"2011-10-15T09:12:46Z","updated_at":"2018-07-31T12:46:59Z","pushed_at":"2018-07-16T09:06:14Z","git_url":"git://github.com/clj-time/clj-time.git","ssh_url":"git@github.com:clj-time/clj-time.git","clone_url":"https://github.com/clj-time/clj-time.git","svn_url":"https://github.com/clj-time/clj-time","homepage":"","size":579,"stargazers_count":632,"watchers_count":632,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":149,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":149,"open_issues":1,"watchers":632,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clj-time/clj-time/pulls/250"},"html":{"href":"https://github.com/clj-time/clj-time/pull/250"},"issue":{"href":"https://api.github.com/repos/clj-time/clj-time/issues/250"},"comments":{"href":"https://api.github.com/repos/clj-time/clj-time/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/clj-time/clj-time/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/clj-time/clj-time/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clj-time/clj-time/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/clj-time/clj-time/statuses/d911e6883dc9cb78c03195d299acb5d8e918428b"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"michaelklishin"}}