{"action":"created","comment":{"url":"https://api.github.com/repos/spatie/laravel-csp/pulls/comments/184933776","pull_request_review_id":116223115,"id":184933776,"diff_hunk":"@@ -174,6 +174,51 @@ public function configure()\n         );\n     }\n \n+    /** @test */\n+    public function it_will_automatically_quote_hashed_value()","path":"tests/AddCspHeadersTest.php","position":5,"original_position":5,"commit_id":"6e122984557bfe298e711865bf7622b2e094e38e","original_commit_id":"6e122984557bfe298e711865bf7622b2e094e38e","user":{"login":"freekmurze","id":483853,"avatar_url":"https://avatars2.githubusercontent.com/u/483853?v=4","gravatar_id":"","url":"https://api.github.com/users/freekmurze","html_url":"https://github.com/freekmurze","followers_url":"https://api.github.com/users/freekmurze/followers","following_url":"https://api.github.com/users/freekmurze/following{/other_user}","gists_url":"https://api.github.com/users/freekmurze/gists{/gist_id}","starred_url":"https://api.github.com/users/freekmurze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freekmurze/subscriptions","organizations_url":"https://api.github.com/users/freekmurze/orgs","repos_url":"https://api.github.com/users/freekmurze/repos","events_url":"https://api.github.com/users/freekmurze/events{/privacy}","received_events_url":"https://api.github.com/users/freekmurze/received_events","type":"User","site_admin":false},"body":"rename to `it_will_automatically_quote_hashed_values`","created_at":"2018-04-30T08:36:08Z","updated_at":"2018-04-30T08:36:26Z","html_url":"https://github.com/spatie/laravel-csp/pull/35#discussion_r184933776","pull_request_url":"https://api.github.com/repos/spatie/laravel-csp/pulls/35","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/spatie/laravel-csp/pulls/comments/184933776"},"html":{"href":"https://github.com/spatie/laravel-csp/pull/35#discussion_r184933776"},"pull_request":{"href":"https://api.github.com/repos/spatie/laravel-csp/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/spatie/laravel-csp/pulls/35","id":184419657,"html_url":"https://github.com/spatie/laravel-csp/pull/35","diff_url":"https://github.com/spatie/laravel-csp/pull/35.diff","patch_url":"https://github.com/spatie/laravel-csp/pull/35.patch","issue_url":"https://api.github.com/repos/spatie/laravel-csp/issues/35","number":35,"state":"open","locked":false,"title":"Hashes auto-enclosed into quotes","user":{"login":"IlCallo","id":10036108,"avatar_url":"https://avatars0.githubusercontent.com/u/10036108?v=4","gravatar_id":"","url":"https://api.github.com/users/IlCallo","html_url":"https://github.com/IlCallo","followers_url":"https://api.github.com/users/IlCallo/followers","following_url":"https://api.github.com/users/IlCallo/following{/other_user}","gists_url":"https://api.github.com/users/IlCallo/gists{/gist_id}","starred_url":"https://api.github.com/users/IlCallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlCallo/subscriptions","organizations_url":"https://api.github.com/users/IlCallo/orgs","repos_url":"https://api.github.com/users/IlCallo/repos","events_url":"https://api.github.com/users/IlCallo/events{/privacy}","received_events_url":"https://api.github.com/users/IlCallo/received_events","type":"User","site_admin":false},"body":"#33 \r\n\r\nAs described in the title **PLUS** the fact that now it's possible to give multiple options separated by one or more spaces and they'll still be examined atomically, which came natural to me to prevent possible errors with hash detection: the string `sha256-hash some random text` would have been all enclosed in a single couple of quotes without this feature.\r\n\r\nIt can be easily removed if that feature isn't welcome, even if I think it can help to provide more flexibility and usability.","created_at":"2018-04-26T18:01:39Z","updated_at":"2018-04-30T08:36:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5744a332e3f2ce07a097b46ef22f2dafd7299c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spatie/laravel-csp/pulls/35/commits","review_comments_url":"https://api.github.com/repos/spatie/laravel-csp/pulls/35/comments","review_comment_url":"https://api.github.com/repos/spatie/laravel-csp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatie/laravel-csp/issues/35/comments","statuses_url":"https://api.github.com/repos/spatie/laravel-csp/statuses/6e122984557bfe298e711865bf7622b2e094e38e","head":{"label":"IlCallo:master","ref":"master","sha":"6e122984557bfe298e711865bf7622b2e094e38e","user":{"login":"IlCallo","id":10036108,"avatar_url":"https://avatars0.githubusercontent.com/u/10036108?v=4","gravatar_id":"","url":"https://api.github.com/users/IlCallo","html_url":"https://github.com/IlCallo","followers_url":"https://api.github.com/users/IlCallo/followers","following_url":"https://api.github.com/users/IlCallo/following{/other_user}","gists_url":"https://api.github.com/users/IlCallo/gists{/gist_id}","starred_url":"https://api.github.com/users/IlCallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlCallo/subscriptions","organizations_url":"https://api.github.com/users/IlCallo/orgs","repos_url":"https://api.github.com/users/IlCallo/repos","events_url":"https://api.github.com/users/IlCallo/events{/privacy}","received_events_url":"https://api.github.com/users/IlCallo/received_events","type":"User","site_admin":false},"repo":{"id":131167752,"name":"laravel-csp","full_name":"IlCallo/laravel-csp","owner":{"login":"IlCallo","id":10036108,"avatar_url":"https://avatars0.githubusercontent.com/u/10036108?v=4","gravatar_id":"","url":"https://api.github.com/users/IlCallo","html_url":"https://github.com/IlCallo","followers_url":"https://api.github.com/users/IlCallo/followers","following_url":"https://api.github.com/users/IlCallo/following{/other_user}","gists_url":"https://api.github.com/users/IlCallo/gists{/gist_id}","starred_url":"https://api.github.com/users/IlCallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlCallo/subscriptions","organizations_url":"https://api.github.com/users/IlCallo/orgs","repos_url":"https://api.github.com/users/IlCallo/repos","events_url":"https://api.github.com/users/IlCallo/events{/privacy}","received_events_url":"https://api.github.com/users/IlCallo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IlCallo/laravel-csp","description":"Set content security policy headers in a Laravel app","fork":true,"url":"https://api.github.com/repos/IlCallo/laravel-csp","forks_url":"https://api.github.com/repos/IlCallo/laravel-csp/forks","keys_url":"https://api.github.com/repos/IlCallo/laravel-csp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IlCallo/laravel-csp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IlCallo/laravel-csp/teams","hooks_url":"https://api.github.com/repos/IlCallo/laravel-csp/hooks","issue_events_url":"https://api.github.com/repos/IlCallo/laravel-csp/issues/events{/number}","events_url":"https://api.github.com/repos/IlCallo/laravel-csp/events","assignees_url":"https://api.github.com/repos/IlCallo/laravel-csp/assignees{/user}","branches_url":"https://api.github.com/repos/IlCallo/laravel-csp/branches{/branch}","tags_url":"https://api.github.com/repos/IlCallo/laravel-csp/tags","blobs_url":"https://api.github.com/repos/IlCallo/laravel-csp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IlCallo/laravel-csp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IlCallo/laravel-csp/git/refs{/sha}","trees_url":"https://api.github.com/repos/IlCallo/laravel-csp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IlCallo/laravel-csp/statuses/{sha}","languages_url":"https://api.github.com/repos/IlCallo/laravel-csp/languages","stargazers_url":"https://api.github.com/repos/IlCallo/laravel-csp/stargazers","contributors_url":"https://api.github.com/repos/IlCallo/laravel-csp/contributors","subscribers_url":"https://api.github.com/repos/IlCallo/laravel-csp/subscribers","subscription_url":"https://api.github.com/repos/IlCallo/laravel-csp/subscription","commits_url":"https://api.github.com/repos/IlCallo/laravel-csp/commits{/sha}","git_commits_url":"https://api.github.com/repos/IlCallo/laravel-csp/git/commits{/sha}","comments_url":"https://api.github.com/repos/IlCallo/laravel-csp/comments{/number}","issue_comment_url":"https://api.github.com/repos/IlCallo/laravel-csp/issues/comments{/number}","contents_url":"https://api.github.com/repos/IlCallo/laravel-csp/contents/{+path}","compare_url":"https://api.github.com/repos/IlCallo/laravel-csp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IlCallo/laravel-csp/merges","archive_url":"https://api.github.com/repos/IlCallo/laravel-csp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IlCallo/laravel-csp/downloads","issues_url":"https://api.github.com/repos/IlCallo/laravel-csp/issues{/number}","pulls_url":"https://api.github.com/repos/IlCallo/laravel-csp/pulls{/number}","milestones_url":"https://api.github.com/repos/IlCallo/laravel-csp/milestones{/number}","notifications_url":"https://api.github.com/repos/IlCallo/laravel-csp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IlCallo/laravel-csp/labels{/name}","releases_url":"https://api.github.com/repos/IlCallo/laravel-csp/releases{/id}","deployments_url":"https://api.github.com/repos/IlCallo/laravel-csp/deployments","created_at":"2018-04-26T14:27:42Z","updated_at":"2018-04-27T08:21:28Z","pushed_at":"2018-04-27T08:21:27Z","git_url":"git://github.com/IlCallo/laravel-csp.git","ssh_url":"git@github.com:IlCallo/laravel-csp.git","clone_url":"https://github.com/IlCallo/laravel-csp.git","svn_url":"https://github.com/IlCallo/laravel-csp","homepage":"https://murze.be/using-content-security-policy-headers-in-a-laravel-app","size":119,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spatie:master","ref":"master","sha":"ef4351fdfce16fc7fe9c095c48fedf69732dfed4","user":{"login":"spatie","id":7535935,"avatar_url":"https://avatars0.githubusercontent.com/u/7535935?v=4","gravatar_id":"","url":"https://api.github.com/users/spatie","html_url":"https://github.com/spatie","followers_url":"https://api.github.com/users/spatie/followers","following_url":"https://api.github.com/users/spatie/following{/other_user}","gists_url":"https://api.github.com/users/spatie/gists{/gist_id}","starred_url":"https://api.github.com/users/spatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatie/subscriptions","organizations_url":"https://api.github.com/users/spatie/orgs","repos_url":"https://api.github.com/users/spatie/repos","events_url":"https://api.github.com/users/spatie/events{/privacy}","received_events_url":"https://api.github.com/users/spatie/received_events","type":"Organization","site_admin":false},"repo":{"id":119958264,"name":"laravel-csp","full_name":"spatie/laravel-csp","owner":{"login":"spatie","id":7535935,"avatar_url":"https://avatars0.githubusercontent.com/u/7535935?v=4","gravatar_id":"","url":"https://api.github.com/users/spatie","html_url":"https://github.com/spatie","followers_url":"https://api.github.com/users/spatie/followers","following_url":"https://api.github.com/users/spatie/following{/other_user}","gists_url":"https://api.github.com/users/spatie/gists{/gist_id}","starred_url":"https://api.github.com/users/spatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatie/subscriptions","organizations_url":"https://api.github.com/users/spatie/orgs","repos_url":"https://api.github.com/users/spatie/repos","events_url":"https://api.github.com/users/spatie/events{/privacy}","received_events_url":"https://api.github.com/users/spatie/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatie/laravel-csp","description":"Set content security policy headers in a Laravel app","fork":false,"url":"https://api.github.com/repos/spatie/laravel-csp","forks_url":"https://api.github.com/repos/spatie/laravel-csp/forks","keys_url":"https://api.github.com/repos/spatie/laravel-csp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatie/laravel-csp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatie/laravel-csp/teams","hooks_url":"https://api.github.com/repos/spatie/laravel-csp/hooks","issue_events_url":"https://api.github.com/repos/spatie/laravel-csp/issues/events{/number}","events_url":"https://api.github.com/repos/spatie/laravel-csp/events","assignees_url":"https://api.github.com/repos/spatie/laravel-csp/assignees{/user}","branches_url":"https://api.github.com/repos/spatie/laravel-csp/branches{/branch}","tags_url":"https://api.github.com/repos/spatie/laravel-csp/tags","blobs_url":"https://api.github.com/repos/spatie/laravel-csp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatie/laravel-csp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatie/laravel-csp/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatie/laravel-csp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatie/laravel-csp/statuses/{sha}","languages_url":"https://api.github.com/repos/spatie/laravel-csp/languages","stargazers_url":"https://api.github.com/repos/spatie/laravel-csp/stargazers","contributors_url":"https://api.github.com/repos/spatie/laravel-csp/contributors","subscribers_url":"https://api.github.com/repos/spatie/laravel-csp/subscribers","subscription_url":"https://api.github.com/repos/spatie/laravel-csp/subscription","commits_url":"https://api.github.com/repos/spatie/laravel-csp/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatie/laravel-csp/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatie/laravel-csp/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatie/laravel-csp/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatie/laravel-csp/contents/{+path}","compare_url":"https://api.github.com/repos/spatie/laravel-csp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatie/laravel-csp/merges","archive_url":"https://api.github.com/repos/spatie/laravel-csp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatie/laravel-csp/downloads","issues_url":"https://api.github.com/repos/spatie/laravel-csp/issues{/number}","pulls_url":"https://api.github.com/repos/spatie/laravel-csp/pulls{/number}","milestones_url":"https://api.github.com/repos/spatie/laravel-csp/milestones{/number}","notifications_url":"https://api.github.com/repos/spatie/laravel-csp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatie/laravel-csp/labels{/name}","releases_url":"https://api.github.com/repos/spatie/laravel-csp/releases{/id}","deployments_url":"https://api.github.com/repos/spatie/laravel-csp/deployments","created_at":"2018-02-02T09:01:58Z","updated_at":"2018-04-29T12:20:43Z","pushed_at":"2018-04-27T08:21:28Z","git_url":"git://github.com/spatie/laravel-csp.git","ssh_url":"git@github.com:spatie/laravel-csp.git","clone_url":"https://github.com/spatie/laravel-csp.git","svn_url":"https://github.com/spatie/laravel-csp","homepage":"https://murze.be/using-content-security-policy-headers-in-a-laravel-app","size":116,"stargazers_count":157,"watchers_count":157,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":11,"open_issues":1,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatie/laravel-csp/pulls/35"},"html":{"href":"https://github.com/spatie/laravel-csp/pull/35"},"issue":{"href":"https://api.github.com/repos/spatie/laravel-csp/issues/35"},"comments":{"href":"https://api.github.com/repos/spatie/laravel-csp/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/spatie/laravel-csp/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/spatie/laravel-csp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatie/laravel-csp/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/spatie/laravel-csp/statuses/6e122984557bfe298e711865bf7622b2e094e38e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"freekmurze"}}