{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/235429512","pull_request_review_id":177292314,"id":235429512,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTQyOTUxMg==","diff_hunk":"@@ -0,0 +1,19 @@\n+{ lib , buildPythonPackage , fetchPypi }:\n+\n+buildPythonPackage rec {\n+  pname = \"simplekml\";\n+  version = \"1.3.1\";\n+  name = \"simplekml-${version}\";","path":"pkgs/development/python-modules/simplekml/default.nix","position":6,"original_position":6,"commit_id":"31579a65ac62797983347506f5e6b54edf6df427","original_commit_id":"31579a65ac62797983347506f5e6b54edf6df427","user":{"login":"FRidh","id":2129135,"node_id":"MDQ6VXNlcjIxMjkxMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/2129135?v=4","gravatar_id":"","url":"https://api.github.com/users/FRidh","html_url":"https://github.com/FRidh","followers_url":"https://api.github.com/users/FRidh/followers","following_url":"https://api.github.com/users/FRidh/following{/other_user}","gists_url":"https://api.github.com/users/FRidh/gists{/gist_id}","starred_url":"https://api.github.com/users/FRidh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRidh/subscriptions","organizations_url":"https://api.github.com/users/FRidh/orgs","repos_url":"https://api.github.com/users/FRidh/repos","events_url":"https://api.github.com/users/FRidh/events{/privacy}","received_events_url":"https://api.github.com/users/FRidh/received_events","type":"User","site_admin":false},"body":"The `name` attribute is added by `buildPython*` and should therefore be removed.","created_at":"2018-11-21T15:22:03Z","updated_at":"2018-11-21T15:22:26Z","html_url":"https://github.com/NixOS/nixpkgs/pull/50883#discussion_r235429512","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50883","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/235429512"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/50883#discussion_r235429512"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50883"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50883","id":232685699,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjg1Njk5","html_url":"https://github.com/NixOS/nixpkgs/pull/50883","diff_url":"https://github.com/NixOS/nixpkgs/pull/50883.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/50883.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50883","number":50883,"state":"open","locked":false,"title":"pythonPackages.simplekml: Init at 1.3.1","user":{"login":"rvolosatovs","id":12877905,"node_id":"MDQ6VXNlcjEyODc3OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/12877905?v=4","gravatar_id":"","url":"https://api.github.com/users/rvolosatovs","html_url":"https://github.com/rvolosatovs","followers_url":"https://api.github.com/users/rvolosatovs/followers","following_url":"https://api.github.com/users/rvolosatovs/following{/other_user}","gists_url":"https://api.github.com/users/rvolosatovs/gists{/gist_id}","starred_url":"https://api.github.com/users/rvolosatovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvolosatovs/subscriptions","organizations_url":"https://api.github.com/users/rvolosatovs/orgs","repos_url":"https://api.github.com/users/rvolosatovs/repos","events_url":"https://api.github.com/users/rvolosatovs/events{/privacy}","received_events_url":"https://api.github.com/users/rvolosatovs/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-11-21T14:35:09Z","updated_at":"2018-11-21T15:22:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a47b68bef6e5a9b5f36849b07f9363746ea5edc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":9820195,"node_id":"MDU6TGFiZWw5ODIwMTk1","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20python","name":"6.topic: python","color":"fef2c0","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50883/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50883/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50883/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/31579a65ac62797983347506f5e6b54edf6df427","head":{"label":"rvolosatovs:init/simplekml","ref":"init/simplekml","sha":"31579a65ac62797983347506f5e6b54edf6df427","user":{"login":"rvolosatovs","id":12877905,"node_id":"MDQ6VXNlcjEyODc3OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/12877905?v=4","gravatar_id":"","url":"https://api.github.com/users/rvolosatovs","html_url":"https://github.com/rvolosatovs","followers_url":"https://api.github.com/users/rvolosatovs/followers","following_url":"https://api.github.com/users/rvolosatovs/following{/other_user}","gists_url":"https://api.github.com/users/rvolosatovs/gists{/gist_id}","starred_url":"https://api.github.com/users/rvolosatovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvolosatovs/subscriptions","organizations_url":"https://api.github.com/users/rvolosatovs/orgs","repos_url":"https://api.github.com/users/rvolosatovs/repos","events_url":"https://api.github.com/users/rvolosatovs/events{/privacy}","received_events_url":"https://api.github.com/users/rvolosatovs/received_events","type":"User","site_admin":false},"repo":{"id":94003109,"node_id":"MDEwOlJlcG9zaXRvcnk5NDAwMzEwOQ==","name":"nixpkgs","full_name":"rvolosatovs/nixpkgs","private":false,"owner":{"login":"rvolosatovs","id":12877905,"node_id":"MDQ6VXNlcjEyODc3OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/12877905?v=4","gravatar_id":"","url":"https://api.github.com/users/rvolosatovs","html_url":"https://github.com/rvolosatovs","followers_url":"https://api.github.com/users/rvolosatovs/followers","following_url":"https://api.github.com/users/rvolosatovs/following{/other_user}","gists_url":"https://api.github.com/users/rvolosatovs/gists{/gist_id}","starred_url":"https://api.github.com/users/rvolosatovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvolosatovs/subscriptions","organizations_url":"https://api.github.com/users/rvolosatovs/orgs","repos_url":"https://api.github.com/users/rvolosatovs/repos","events_url":"https://api.github.com/users/rvolosatovs/events{/privacy}","received_events_url":"https://api.github.com/users/rvolosatovs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rvolosatovs/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/rvolosatovs/nixpkgs","forks_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/forks","keys_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/teams","hooks_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/events","assignees_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/tags","blobs_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/subscription","commits_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/merges","archive_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/downloads","issues_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/rvolosatovs/nixpkgs/deployments","created_at":"2017-06-11T12:30:45Z","updated_at":"2018-11-21T14:21:38Z","pushed_at":"2018-11-21T14:34:36Z","git_url":"git://github.com/rvolosatovs/nixpkgs.git","ssh_url":"git@github.com:rvolosatovs/nixpkgs.git","clone_url":"https://github.com/rvolosatovs/nixpkgs.git","svn_url":"https://github.com/rvolosatovs/nixpkgs","homepage":null,"size":794545,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"nixos-18.09"}},"base":{"label":"NixOS:master","ref":"master","sha":"09cbfea2edd8a525f54d96a45c0edc2fe3c94e56","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-11-21T15:11:18Z","pushed_at":"2018-11-21T15:21:51Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":887697,"stargazers_count":3018,"watchers_count":3018,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3205,"mirror_url":null,"archived":false,"open_issues_count":3411,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3205,"open_issues":3411,"watchers":3018,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50883"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/50883"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/50883"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/50883/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50883/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50883/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/31579a65ac62797983347506f5e6b54edf6df427"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"FRidh"}}