{"action":"created","comment":{"url":"https://api.github.com/repos/humbug/box/pulls/comments/219670974","pull_request_review_id":157909289,"id":219670974,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTY3MDk3NA==","diff_hunk":"@@ -53,21 +58,55 @@ protected function configure(): void\n             InputArgument::OPTIONAL,\n             'The configuration file. (default: box.json, box.json.dist)'\n         );\n+        $this->addOption(\n+            self::IGNORE_MESSAGES_OPTION,\n+            'i',\n+            InputOption::VALUE_NONE,\n+            'Will not return a faulty code when a recommendation or warning is found'\n+        );\n     }\n \n     /**\n      * {@inheritdoc}\n      */\n     protected function execute(InputInterface $input, OutputInterface $output): int\n     {\n+        $io = new SymfonyStyle($input, $output);\n+\n+        OutputConfigurator::configure($output);\n+\n         try {\n-            $this->getConfig($input, $output);\n+            $config = $this->getConfig($input, $output);\n+\n+            $recommendations = $config->getRecommendations();\n+            $warnings = $config->getWarnings();\n+\n+            if ([] === $recommendations) {","path":"src/Console/Command/Validate.php","position":null,"original_position":51,"commit_id":"7e9d0b196bf4f10f304bdea56394cf9645926371","original_commit_id":"9553b823611786f0ccb898d47f9df7bb217703b8","user":{"login":"theofidry","id":5175937,"node_id":"MDQ6VXNlcjUxNzU5Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5175937?v=4","gravatar_id":"","url":"https://api.github.com/users/theofidry","html_url":"https://github.com/theofidry","followers_url":"https://api.github.com/users/theofidry/followers","following_url":"https://api.github.com/users/theofidry/following{/other_user}","gists_url":"https://api.github.com/users/theofidry/gists{/gist_id}","starred_url":"https://api.github.com/users/theofidry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theofidry/subscriptions","organizations_url":"https://api.github.com/users/theofidry/orgs","repos_url":"https://api.github.com/users/theofidry/repos","events_url":"https://api.github.com/users/theofidry/events{/privacy}","received_events_url":"https://api.github.com/users/theofidry/received_events","type":"User","site_admin":false},"body":"I extracted it in a dedicated class. It doesn't change how hard it is to mock it but I don't mock the commands since the integration tests are cheap enough and more reliable in our current case","created_at":"2018-09-22T12:59:58Z","updated_at":"2018-09-22T12:59:58Z","html_url":"https://github.com/humbug/box/pull/283#discussion_r219670974","pull_request_url":"https://api.github.com/repos/humbug/box/pulls/283","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/humbug/box/pulls/comments/219670974"},"html":{"href":"https://github.com/humbug/box/pull/283#discussion_r219670974"},"pull_request":{"href":"https://api.github.com/repos/humbug/box/pulls/283"}},"in_reply_to_id":219556945},"pull_request":{"url":"https://api.github.com/repos/humbug/box/pulls/283","id":217328256,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzI4MjU2","html_url":"https://github.com/humbug/box/pull/283","diff_url":"https://github.com/humbug/box/pull/283.diff","patch_url":"https://github.com/humbug/box/pull/283.patch","issue_url":"https://api.github.com/repos/humbug/box/issues/283","number":283,"state":"open","locked":false,"title":"Add recommendations and warnings","user":{"login":"theofidry","id":5175937,"node_id":"MDQ6VXNlcjUxNzU5Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5175937?v=4","gravatar_id":"","url":"https://api.github.com/users/theofidry","html_url":"https://github.com/theofidry","followers_url":"https://api.github.com/users/theofidry/followers","following_url":"https://api.github.com/users/theofidry/following{/other_user}","gists_url":"https://api.github.com/users/theofidry/gists{/gist_id}","starred_url":"https://api.github.com/users/theofidry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theofidry/subscriptions","organizations_url":"https://api.github.com/users/theofidry/orgs","repos_url":"https://api.github.com/users/theofidry/repos","events_url":"https://api.github.com/users/theofidry/events{/privacy}","received_events_url":"https://api.github.com/users/theofidry/received_events","type":"User","site_admin":false},"body":"Related to #123","created_at":"2018-09-21T15:53:06Z","updated_at":"2018-09-22T12:59:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19fc1fe3145d312b8851883d6954d528883c2dd5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/humbug/box/pulls/283/commits","review_comments_url":"https://api.github.com/repos/humbug/box/pulls/283/comments","review_comment_url":"https://api.github.com/repos/humbug/box/pulls/comments{/number}","comments_url":"https://api.github.com/repos/humbug/box/issues/283/comments","statuses_url":"https://api.github.com/repos/humbug/box/statuses/7e9d0b196bf4f10f304bdea56394cf9645926371","head":{"label":"theofidry:feature/warning-messages","ref":"feature/warning-messages","sha":"7e9d0b196bf4f10f304bdea56394cf9645926371","user":{"login":"theofidry","id":5175937,"node_id":"MDQ6VXNlcjUxNzU5Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5175937?v=4","gravatar_id":"","url":"https://api.github.com/users/theofidry","html_url":"https://github.com/theofidry","followers_url":"https://api.github.com/users/theofidry/followers","following_url":"https://api.github.com/users/theofidry/following{/other_user}","gists_url":"https://api.github.com/users/theofidry/gists{/gist_id}","starred_url":"https://api.github.com/users/theofidry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theofidry/subscriptions","organizations_url":"https://api.github.com/users/theofidry/orgs","repos_url":"https://api.github.com/users/theofidry/repos","events_url":"https://api.github.com/users/theofidry/events{/privacy}","received_events_url":"https://api.github.com/users/theofidry/received_events","type":"User","site_admin":false},"repo":{"id":109533798,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk1MzM3OTg=","name":"box","full_name":"theofidry/box","private":false,"owner":{"login":"theofidry","id":5175937,"node_id":"MDQ6VXNlcjUxNzU5Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5175937?v=4","gravatar_id":"","url":"https://api.github.com/users/theofidry","html_url":"https://github.com/theofidry","followers_url":"https://api.github.com/users/theofidry/followers","following_url":"https://api.github.com/users/theofidry/following{/other_user}","gists_url":"https://api.github.com/users/theofidry/gists{/gist_id}","starred_url":"https://api.github.com/users/theofidry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theofidry/subscriptions","organizations_url":"https://api.github.com/users/theofidry/orgs","repos_url":"https://api.github.com/users/theofidry/repos","events_url":"https://api.github.com/users/theofidry/events{/privacy}","received_events_url":"https://api.github.com/users/theofidry/received_events","type":"User","site_admin":false},"html_url":"https://github.com/theofidry/box","description":"An application for building and managing Phars.","fork":true,"url":"https://api.github.com/repos/theofidry/box","forks_url":"https://api.github.com/repos/theofidry/box/forks","keys_url":"https://api.github.com/repos/theofidry/box/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theofidry/box/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theofidry/box/teams","hooks_url":"https://api.github.com/repos/theofidry/box/hooks","issue_events_url":"https://api.github.com/repos/theofidry/box/issues/events{/number}","events_url":"https://api.github.com/repos/theofidry/box/events","assignees_url":"https://api.github.com/repos/theofidry/box/assignees{/user}","branches_url":"https://api.github.com/repos/theofidry/box/branches{/branch}","tags_url":"https://api.github.com/repos/theofidry/box/tags","blobs_url":"https://api.github.com/repos/theofidry/box/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theofidry/box/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theofidry/box/git/refs{/sha}","trees_url":"https://api.github.com/repos/theofidry/box/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theofidry/box/statuses/{sha}","languages_url":"https://api.github.com/repos/theofidry/box/languages","stargazers_url":"https://api.github.com/repos/theofidry/box/stargazers","contributors_url":"https://api.github.com/repos/theofidry/box/contributors","subscribers_url":"https://api.github.com/repos/theofidry/box/subscribers","subscription_url":"https://api.github.com/repos/theofidry/box/subscription","commits_url":"https://api.github.com/repos/theofidry/box/commits{/sha}","git_commits_url":"https://api.github.com/repos/theofidry/box/git/commits{/sha}","comments_url":"https://api.github.com/repos/theofidry/box/comments{/number}","issue_comment_url":"https://api.github.com/repos/theofidry/box/issues/comments{/number}","contents_url":"https://api.github.com/repos/theofidry/box/contents/{+path}","compare_url":"https://api.github.com/repos/theofidry/box/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theofidry/box/merges","archive_url":"https://api.github.com/repos/theofidry/box/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theofidry/box/downloads","issues_url":"https://api.github.com/repos/theofidry/box/issues{/number}","pulls_url":"https://api.github.com/repos/theofidry/box/pulls{/number}","milestones_url":"https://api.github.com/repos/theofidry/box/milestones{/number}","notifications_url":"https://api.github.com/repos/theofidry/box/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theofidry/box/labels{/name}","releases_url":"https://api.github.com/repos/theofidry/box/releases{/id}","deployments_url":"https://api.github.com/repos/theofidry/box/deployments","created_at":"2017-11-04T22:07:09Z","updated_at":"2018-05-07T19:27:01Z","pushed_at":"2018-09-22T12:58:24Z","git_url":"git://github.com/theofidry/box.git","ssh_url":"git@github.com:theofidry/box.git","clone_url":"https://github.com/theofidry/box.git","svn_url":"https://github.com/theofidry/box","homepage":"https://box-project.github.io/box2/","size":3367,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"humbug:master","ref":"master","sha":"0e87fa8897ff608204a205d06c133f8b00ef73cc","user":{"login":"humbug","id":27455162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDU1MTYy","avatar_url":"https://avatars0.githubusercontent.com/u/27455162?v=4","gravatar_id":"","url":"https://api.github.com/users/humbug","html_url":"https://github.com/humbug","followers_url":"https://api.github.com/users/humbug/followers","following_url":"https://api.github.com/users/humbug/following{/other_user}","gists_url":"https://api.github.com/users/humbug/gists{/gist_id}","starred_url":"https://api.github.com/users/humbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humbug/subscriptions","organizations_url":"https://api.github.com/users/humbug/orgs","repos_url":"https://api.github.com/users/humbug/repos","events_url":"https://api.github.com/users/humbug/events{/privacy}","received_events_url":"https://api.github.com/users/humbug/received_events","type":"Organization","site_admin":false},"repo":{"id":109533757,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk1MzM3NTc=","name":"box","full_name":"humbug/box","private":false,"owner":{"login":"humbug","id":27455162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDU1MTYy","avatar_url":"https://avatars0.githubusercontent.com/u/27455162?v=4","gravatar_id":"","url":"https://api.github.com/users/humbug","html_url":"https://github.com/humbug","followers_url":"https://api.github.com/users/humbug/followers","following_url":"https://api.github.com/users/humbug/following{/other_user}","gists_url":"https://api.github.com/users/humbug/gists{/gist_id}","starred_url":"https://api.github.com/users/humbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humbug/subscriptions","organizations_url":"https://api.github.com/users/humbug/orgs","repos_url":"https://api.github.com/users/humbug/repos","events_url":"https://api.github.com/users/humbug/events{/privacy}","received_events_url":"https://api.github.com/users/humbug/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/humbug/box","description":"📦🚀 Fast, zero config application bundler with PHARs.","fork":true,"url":"https://api.github.com/repos/humbug/box","forks_url":"https://api.github.com/repos/humbug/box/forks","keys_url":"https://api.github.com/repos/humbug/box/keys{/key_id}","collaborators_url":"https://api.github.com/repos/humbug/box/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/humbug/box/teams","hooks_url":"https://api.github.com/repos/humbug/box/hooks","issue_events_url":"https://api.github.com/repos/humbug/box/issues/events{/number}","events_url":"https://api.github.com/repos/humbug/box/events","assignees_url":"https://api.github.com/repos/humbug/box/assignees{/user}","branches_url":"https://api.github.com/repos/humbug/box/branches{/branch}","tags_url":"https://api.github.com/repos/humbug/box/tags","blobs_url":"https://api.github.com/repos/humbug/box/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/humbug/box/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/humbug/box/git/refs{/sha}","trees_url":"https://api.github.com/repos/humbug/box/git/trees{/sha}","statuses_url":"https://api.github.com/repos/humbug/box/statuses/{sha}","languages_url":"https://api.github.com/repos/humbug/box/languages","stargazers_url":"https://api.github.com/repos/humbug/box/stargazers","contributors_url":"https://api.github.com/repos/humbug/box/contributors","subscribers_url":"https://api.github.com/repos/humbug/box/subscribers","subscription_url":"https://api.github.com/repos/humbug/box/subscription","commits_url":"https://api.github.com/repos/humbug/box/commits{/sha}","git_commits_url":"https://api.github.com/repos/humbug/box/git/commits{/sha}","comments_url":"https://api.github.com/repos/humbug/box/comments{/number}","issue_comment_url":"https://api.github.com/repos/humbug/box/issues/comments{/number}","contents_url":"https://api.github.com/repos/humbug/box/contents/{+path}","compare_url":"https://api.github.com/repos/humbug/box/compare/{base}...{head}","merges_url":"https://api.github.com/repos/humbug/box/merges","archive_url":"https://api.github.com/repos/humbug/box/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/humbug/box/downloads","issues_url":"https://api.github.com/repos/humbug/box/issues{/number}","pulls_url":"https://api.github.com/repos/humbug/box/pulls{/number}","milestones_url":"https://api.github.com/repos/humbug/box/milestones{/number}","notifications_url":"https://api.github.com/repos/humbug/box/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/humbug/box/labels{/name}","releases_url":"https://api.github.com/repos/humbug/box/releases{/id}","deployments_url":"https://api.github.com/repos/humbug/box/deployments","created_at":"2017-11-04T22:06:27Z","updated_at":"2018-09-22T11:01:41Z","pushed_at":"2018-09-22T12:58:25Z","git_url":"git://github.com/humbug/box.git","ssh_url":"git@github.com:humbug/box.git","clone_url":"https://github.com/humbug/box.git","svn_url":"https://github.com/humbug/box","homepage":"","size":3395,"stargazers_count":118,"watchers_count":118,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":11,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/humbug/box/pulls/283"},"html":{"href":"https://github.com/humbug/box/pull/283"},"issue":{"href":"https://api.github.com/repos/humbug/box/issues/283"},"comments":{"href":"https://api.github.com/repos/humbug/box/issues/283/comments"},"review_comments":{"href":"https://api.github.com/repos/humbug/box/pulls/283/comments"},"review_comment":{"href":"https://api.github.com/repos/humbug/box/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/humbug/box/pulls/283/commits"},"statuses":{"href":"https://api.github.com/repos/humbug/box/statuses/7e9d0b196bf4f10f304bdea56394cf9645926371"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"theofidry"}}