{"action":"created","issue":{"url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/119","repository_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning","labels_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/119/comments","events_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/119/events","html_url":"https://github.com/rust-bitcoin/rust-lightning/pull/119","id":351794095,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Mjk2NDk0","number":119,"title":"writers/readers #62 based on io::Write/Read","user":{"login":"yuntai","id":371172,"node_id":"MDQ6VXNlcjM3MTE3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/371172?v=4","gravatar_id":"","url":"https://api.github.com/users/yuntai","html_url":"https://github.com/yuntai","followers_url":"https://api.github.com/users/yuntai/followers","following_url":"https://api.github.com/users/yuntai/following{/other_user}","gists_url":"https://api.github.com/users/yuntai/gists{/gist_id}","starred_url":"https://api.github.com/users/yuntai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuntai/subscriptions","organizations_url":"https://api.github.com/users/yuntai/orgs","repos_url":"https://api.github.com/users/yuntai/repos","events_url":"https://api.github.com/users/yuntai/events{/privacy}","received_events_url":"https://api.github.com/users/yuntai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-08-18T05:56:12Z","updated_at":"2018-09-09T15:33:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/119","html_url":"https://github.com/rust-bitcoin/rust-lightning/pull/119","diff_url":"https://github.com/rust-bitcoin/rust-lightning/pull/119.diff","patch_url":"https://github.com/rust-bitcoin/rust-lightning/pull/119.patch"},"body":"Implement issue #62. I started writing some generic routines for #55 and then found lots of them are already done in rust-bitcoin. I was thinking of importing them directly but I saw some conversation about restructuring serialization routines in the rust-bitcoin repo so I just adopted them here. \r\n\r\nIf this approach looks good I can go ahead putting a fuzz testing.\r\n"},"comment":{"url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/comments/419723971","html_url":"https://github.com/rust-bitcoin/rust-lightning/pull/119#issuecomment-419723971","issue_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/119","id":419723971,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTcyMzk3MQ==","user":{"login":"TheBlueMatt","id":649246,"node_id":"MDQ6VXNlcjY0OTI0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/649246?v=4","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"created_at":"2018-09-09T15:33:48Z","updated_at":"2018-09-09T15:33:48Z","author_association":"MEMBER","body":"- For the raw stream at the bottom, we don't want to rely in it being TCP - one potential use-case of the library is abstracting the networking stuff and running rust-lightning on selaed hardware and communicate messages across a serial interface or so. I think best to continue with the existing peer_handling interface (which probably requires we keep the Vec's of u8 for reading data there)\r\n- For the decryption side of things, we could move to no-copy decryption and just pipe the resulting blocks out to the serialization layer, but that is a pretty steep refactor, and can come later, so I'd say just do it on streams coming off of [u8]s for now. Encryption we probably want to keep encrypting into Vecs. At least for network messages they're all pretty small so I dont think the performance concerns are worth it."}}
{"actor":{"display_login":"TheBlueMatt"}}