{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/comments/192242149","pull_request_review_id":124977180,"id":192242149,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjI0MjE0OQ==","diff_hunk":"@@ -16,4 +16,21 @@\n   }\n \n   .padded-bottom { @include rem-fallback(padding-bottom, 24px); }\n+\n+  .rule-status-error {\n+    border: 1px transparent solid;\n+    @include rem-fallback(margin, 12px 0px);","path":"src/components/pages/rules/flyouts/ruleStatus/ruleStatus.scss","position":7,"original_position":7,"commit_id":"71cf0c8838398ccf34600418043422be56a85279","original_commit_id":"71cf0c8838398ccf34600418043422be56a85279","user":{"login":"spryor","id":1734193,"node_id":"MDQ6VXNlcjE3MzQxOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1734193?v=4","gravatar_id":"","url":"https://api.github.com/users/spryor","html_url":"https://github.com/spryor","followers_url":"https://api.github.com/users/spryor/followers","following_url":"https://api.github.com/users/spryor/following{/other_user}","gists_url":"https://api.github.com/users/spryor/gists{/gist_id}","starred_url":"https://api.github.com/users/spryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryor/subscriptions","organizations_url":"https://api.github.com/users/spryor/orgs","repos_url":"https://api.github.com/users/spryor/repos","events_url":"https://api.github.com/users/spryor/events{/privacy}","received_events_url":"https://api.github.com/users/spryor/received_events","type":"User","site_admin":false},"body":"missing comma","created_at":"2018-05-31T21:23:51Z","updated_at":"2018-05-31T21:27:44Z","html_url":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/1024#discussion_r192242149","pull_request_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/1024","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/comments/192242149"},"html":{"href":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/1024#discussion_r192242149"},"pull_request":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/1024"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/1024","id":191609438,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjA5NDM4","html_url":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/1024","diff_url":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/1024.diff","patch_url":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/1024.patch","issue_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/1024","number":1024,"state":"open","locked":false,"title":"Modify interaction model for device and rule flyouts","user":{"login":"mechaffin","id":16829221,"node_id":"MDQ6VXNlcjE2ODI5MjIx","avatar_url":"https://avatars3.githubusercontent.com/u/16829221?v=4","gravatar_id":"","url":"https://api.github.com/users/mechaffin","html_url":"https://github.com/mechaffin","followers_url":"https://api.github.com/users/mechaffin/followers","following_url":"https://api.github.com/users/mechaffin/following{/other_user}","gists_url":"https://api.github.com/users/mechaffin/gists{/gist_id}","starred_url":"https://api.github.com/users/mechaffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mechaffin/subscriptions","organizations_url":"https://api.github.com/users/mechaffin/orgs","repos_url":"https://api.github.com/users/mechaffin/repos","events_url":"https://api.github.com/users/mechaffin/events{/privacy}","received_events_url":"https://api.github.com/users/mechaffin/received_events","type":"User","site_admin":false},"body":"# Type of change? <!-- [x] all the boxes that apply -->\r\n\r\n- [ ] Bug fix\r\n- [ ] New feature\r\n- [x] Enhancement\r\n- [ ] Breaking change (breaks backward compatibility)\r\n\r\n# Description, Context, Motivation <!-- Please help us reviewing your PR -->\r\n\r\n1. Flyouts should stay open once their action has been completed (Save, Apply, Delete, etc).\r\n2. The redux store should be updated directly instead of causing a refresh from the server.\r\n3. The SummarySection should show a round indicator when the action is in progress. Then show a checkmark when completed successfully. If an error occurs instead, show the error message.\r\n4. If the user makes changes to fields on the flyout, then the action button should be re-enabled.\r\n\r\nThis applies to all device and rule flyouts.\r\n","created_at":"2018-05-30T23:43:48Z","updated_at":"2018-05-31T21:27:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a436c692ad7603f183e1df1b86ed937f21b9d1f0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jillcary","id":3317135,"node_id":"MDQ6VXNlcjMzMTcxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3317135?v=4","gravatar_id":"","url":"https://api.github.com/users/jillcary","html_url":"https://github.com/jillcary","followers_url":"https://api.github.com/users/jillcary/followers","following_url":"https://api.github.com/users/jillcary/following{/other_user}","gists_url":"https://api.github.com/users/jillcary/gists{/gist_id}","starred_url":"https://api.github.com/users/jillcary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jillcary/subscriptions","organizations_url":"https://api.github.com/users/jillcary/orgs","repos_url":"https://api.github.com/users/jillcary/repos","events_url":"https://api.github.com/users/jillcary/events{/privacy}","received_events_url":"https://api.github.com/users/jillcary/received_events","type":"User","site_admin":false},{"login":"ppathan","id":16170750,"node_id":"MDQ6VXNlcjE2MTcwNzUw","avatar_url":"https://avatars2.githubusercontent.com/u/16170750?v=4","gravatar_id":"","url":"https://api.github.com/users/ppathan","html_url":"https://github.com/ppathan","followers_url":"https://api.github.com/users/ppathan/followers","following_url":"https://api.github.com/users/ppathan/following{/other_user}","gists_url":"https://api.github.com/users/ppathan/gists{/gist_id}","starred_url":"https://api.github.com/users/ppathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppathan/subscriptions","organizations_url":"https://api.github.com/users/ppathan/orgs","repos_url":"https://api.github.com/users/ppathan/repos","events_url":"https://api.github.com/users/ppathan/events{/privacy}","received_events_url":"https://api.github.com/users/ppathan/received_events","type":"User","site_admin":false},{"login":"isaac73","id":22013837,"node_id":"MDQ6VXNlcjIyMDEzODM3","avatar_url":"https://avatars3.githubusercontent.com/u/22013837?v=4","gravatar_id":"","url":"https://api.github.com/users/isaac73","html_url":"https://github.com/isaac73","followers_url":"https://api.github.com/users/isaac73/followers","following_url":"https://api.github.com/users/isaac73/following{/other_user}","gists_url":"https://api.github.com/users/isaac73/gists{/gist_id}","starred_url":"https://api.github.com/users/isaac73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaac73/subscriptions","organizations_url":"https://api.github.com/users/isaac73/orgs","repos_url":"https://api.github.com/users/isaac73/repos","events_url":"https://api.github.com/users/isaac73/events{/privacy}","received_events_url":"https://api.github.com/users/isaac73/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/1024/commits","review_comments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/1024/comments","review_comment_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/1024/comments","statuses_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/statuses/71cf0c8838398ccf34600418043422be56a85279","head":{"label":"Azure:flyout-interaction-mod","ref":"flyout-interaction-mod","sha":"71cf0c8838398ccf34600418043422be56a85279","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":89969457,"node_id":"MDEwOlJlcG9zaXRvcnk4OTk2OTQ1Nw==","name":"pcs-remote-monitoring-webui","full_name":"Azure/pcs-remote-monitoring-webui","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/pcs-remote-monitoring-webui","description":"Azure IoT PCS Remote Monitoring Web UI","fork":false,"url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui","forks_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/forks","keys_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/teams","hooks_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/hooks","issue_events_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/events","assignees_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/tags","blobs_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/languages","stargazers_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/stargazers","contributors_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/contributors","subscribers_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/subscribers","subscription_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/subscription","commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/merges","archive_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/downloads","issues_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/labels{/name}","releases_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/deployments","created_at":"2017-05-01T22:47:49Z","updated_at":"2018-05-31T21:13:29Z","pushed_at":"2018-05-31T21:19:16Z","git_url":"git://github.com/Azure/pcs-remote-monitoring-webui.git","ssh_url":"git@github.com:Azure/pcs-remote-monitoring-webui.git","clone_url":"https://github.com/Azure/pcs-remote-monitoring-webui.git","svn_url":"https://github.com/Azure/pcs-remote-monitoring-webui","homepage":null,"size":3022,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":129,"watchers":28,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"37fde10939b6fc000aac3bf2aee44c4950e419c7","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":89969457,"node_id":"MDEwOlJlcG9zaXRvcnk4OTk2OTQ1Nw==","name":"pcs-remote-monitoring-webui","full_name":"Azure/pcs-remote-monitoring-webui","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/pcs-remote-monitoring-webui","description":"Azure IoT PCS Remote Monitoring Web UI","fork":false,"url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui","forks_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/forks","keys_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/teams","hooks_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/hooks","issue_events_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/events","assignees_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/tags","blobs_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/languages","stargazers_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/stargazers","contributors_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/contributors","subscribers_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/subscribers","subscription_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/subscription","commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/merges","archive_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/downloads","issues_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/labels{/name}","releases_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/deployments","created_at":"2017-05-01T22:47:49Z","updated_at":"2018-05-31T21:13:29Z","pushed_at":"2018-05-31T21:19:16Z","git_url":"git://github.com/Azure/pcs-remote-monitoring-webui.git","ssh_url":"git@github.com:Azure/pcs-remote-monitoring-webui.git","clone_url":"https://github.com/Azure/pcs-remote-monitoring-webui.git","svn_url":"https://github.com/Azure/pcs-remote-monitoring-webui","homepage":null,"size":3022,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":129,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/1024"},"html":{"href":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/1024"},"issue":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/1024"},"comments":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/1024/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/1024/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/1024/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/statuses/71cf0c8838398ccf34600418043422be56a85279"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"spryor"}}