{"action":"closed","issue":{"url":"https://api.github.com/repos/Blazebit/blaze-persistence/issues/711","repository_url":"https://api.github.com/repos/Blazebit/blaze-persistence","labels_url":"https://api.github.com/repos/Blazebit/blaze-persistence/issues/711/labels{/name}","comments_url":"https://api.github.com/repos/Blazebit/blaze-persistence/issues/711/comments","events_url":"https://api.github.com/repos/Blazebit/blaze-persistence/issues/711/events","html_url":"https://github.com/Blazebit/blaze-persistence/issues/711","id":393102371,"node_id":"MDU6SXNzdWUzOTMxMDIzNzE=","number":711,"title":"Include constantified expression predicates in pagination object query","user":{"login":"beikov","id":358916,"node_id":"MDQ6VXNlcjM1ODkxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/358916?v=4","gravatar_id":"","url":"https://api.github.com/users/beikov","html_url":"https://github.com/beikov","followers_url":"https://api.github.com/users/beikov/followers","following_url":"https://api.github.com/users/beikov/following{/other_user}","gists_url":"https://api.github.com/users/beikov/gists{/gist_id}","starred_url":"https://api.github.com/users/beikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beikov/subscriptions","organizations_url":"https://api.github.com/users/beikov/orgs","repos_url":"https://api.github.com/users/beikov/repos","events_url":"https://api.github.com/users/beikov/events{/privacy}","received_events_url":"https://api.github.com/users/beikov/received_events","type":"User","site_admin":false},"labels":[{"id":113480786,"node_id":"MDU6TGFiZWwxMTM0ODA3ODY=","url":"https://api.github.com/repos/Blazebit/blaze-persistence/labels/bug","name":"bug","color":"fc2929","default":true},{"id":515512048,"node_id":"MDU6TGFiZWw1MTU1MTIwNDg=","url":"https://api.github.com/repos/Blazebit/blaze-persistence/labels/core","name":"core","color":"e99695","default":false}],"state":"closed","locked":false,"assignee":{"login":"beikov","id":358916,"node_id":"MDQ6VXNlcjM1ODkxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/358916?v=4","gravatar_id":"","url":"https://api.github.com/users/beikov","html_url":"https://github.com/beikov","followers_url":"https://api.github.com/users/beikov/followers","following_url":"https://api.github.com/users/beikov/following{/other_user}","gists_url":"https://api.github.com/users/beikov/gists{/gist_id}","starred_url":"https://api.github.com/users/beikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beikov/subscriptions","organizations_url":"https://api.github.com/users/beikov/orgs","repos_url":"https://api.github.com/users/beikov/repos","events_url":"https://api.github.com/users/beikov/events{/privacy}","received_events_url":"https://api.github.com/users/beikov/received_events","type":"User","site_admin":false},"assignees":[{"login":"beikov","id":358916,"node_id":"MDQ6VXNlcjM1ODkxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/358916?v=4","gravatar_id":"","url":"https://api.github.com/users/beikov","html_url":"https://github.com/beikov","followers_url":"https://api.github.com/users/beikov/followers","following_url":"https://api.github.com/users/beikov/following{/other_user}","gists_url":"https://api.github.com/users/beikov/gists{/gist_id}","starred_url":"https://api.github.com/users/beikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beikov/subscriptions","organizations_url":"https://api.github.com/users/beikov/orgs","repos_url":"https://api.github.com/users/beikov/repos","events_url":"https://api.github.com/users/beikov/events{/privacy}","received_events_url":"https://api.github.com/users/beikov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Blazebit/blaze-persistence/milestones/18","html_url":"https://github.com/Blazebit/blaze-persistence/milestone/18","labels_url":"https://api.github.com/repos/Blazebit/blaze-persistence/milestones/18/labels","id":3069145,"node_id":"MDk6TWlsZXN0b25lMzA2OTE0NQ==","number":18,"title":"1.4.0","description":"* Returning clause emulation\r\n* Safety net for buggy H2 CTE implementation\r\n* Entity view lifecycle listeners","creator":{"login":"beikov","id":358916,"node_id":"MDQ6VXNlcjM1ODkxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/358916?v=4","gravatar_id":"","url":"https://api.github.com/users/beikov","html_url":"https://github.com/beikov","followers_url":"https://api.github.com/users/beikov/followers","following_url":"https://api.github.com/users/beikov/following{/other_user}","gists_url":"https://api.github.com/users/beikov/gists{/gist_id}","starred_url":"https://api.github.com/users/beikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beikov/subscriptions","organizations_url":"https://api.github.com/users/beikov/orgs","repos_url":"https://api.github.com/users/beikov/repos","events_url":"https://api.github.com/users/beikov/events{/privacy}","received_events_url":"https://api.github.com/users/beikov/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":14,"state":"open","created_at":"2018-01-28T16:43:11Z","updated_at":"2019-01-03T08:44:37Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-12-20T15:47:10Z","updated_at":"2019-01-03T08:44:37Z","closed_at":"2019-01-03T08:44:37Z","author_association":"MEMBER","body":"<!--- This template is for bugs. Remove it for other issues. -->\r\n\r\n<!--- Choose an expressive title -->\r\n### Description\r\n<!--- Explain what you did and maybe show some code excerpts -->\r\nThe optimization for only using the expressions needed for uniqueness for pagination broke a case when we omitted a part of the id due to it being constantified. I'm not entierly sure if we should just include the predicate or if it's better to include the full id in the pagination handling. The latter is the behavior that we had before.\r\n\r\n### Expected behavior\r\n<!--- What outcome would you expect? -->\r\n\r\n### Actual behavior\r\n<!--- What happened that you didn't expect? -->\r\n\r\n### Steps to reproduce\r\n<!--- Give us enough details so we can create a testcase that reproduces this problem -->\r\n<!--- Idealy you would create a test case based on the template project from: https://github.com/Blazebit/blaze-persistence-test-case-template -->\r\n<!--- Either attach a ZIP containing the test case or create a pull request against the test-case-template repository and put the link to the PR here -->\r\n\r\n### Environment\r\n<!--- Environment info like e.g.\t\t\t\t\t-->\r\n<!--- Version:            1.2.0-Alpha1\t\t\t\t-->\r\n<!--- JPA-Provider:       Hibernate 5.2.7.Final\t\t-->\r\n<!--- DBMS:               PostgreSQL 9.6.2\t\t\t-->\r\n<!--- Application Server: Java SE\t\t\t\t\t-->\r\n\r\nVersion:            1.3.0\r\nJPA-Provider:       \r\nDBMS:               \r\nApplication Server: \r\n"}}
{"actor":{"display_login":"beikov"}}