{"action":"created","comment":{"url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/comments/234046770","pull_request_review_id":175604668,"id":234046770,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDA0Njc3MA==","diff_hunk":"@@ -0,0 +1,69 @@\n+/*\n+ * Copyright 2018 ConsenSys AG.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on\n+ * an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations under the License.\n+ */\n+package tech.pegasys.pantheon.consensus.ibftlegacy;\n+\n+import tech.pegasys.pantheon.consensus.common.CastVote;\n+import tech.pegasys.pantheon.consensus.common.ValidatorVotePolarity;\n+import tech.pegasys.pantheon.consensus.common.VoteBlockInterface;\n+import tech.pegasys.pantheon.ethereum.core.Address;\n+import tech.pegasys.pantheon.ethereum.core.BlockHeader;\n+import tech.pegasys.pantheon.ethereum.core.BlockHeaderBuilder;\n+import tech.pegasys.pantheon.util.bytes.BytesValue;\n+\n+import java.util.List;\n+import java.util.Optional;\n+\n+import com.google.common.collect.ImmutableBiMap;\n+\n+public class IbftLegacyVoteBlockInterface implements VoteBlockInterface {\n+\n+  private static final Address NO_VOTE_SUBJECT = Address.wrap(BytesValue.wrap(new byte[20]));","path":"consensus/ibftlegacy/src/main/java/tech/pegasys/pantheon/consensus/ibftlegacy/IbftLegacyVoteBlockInterface.java","position":30,"original_position":30,"commit_id":"e60138f129dc6a65b47f96ebd0c84350fc4622cc","original_commit_id":"e60138f129dc6a65b47f96ebd0c84350fc4622cc","user":{"login":"rain-on","id":37158202,"node_id":"MDQ6VXNlcjM3MTU4MjAy","avatar_url":"https://avatars2.githubusercontent.com/u/37158202?v=4","gravatar_id":"","url":"https://api.github.com/users/rain-on","html_url":"https://github.com/rain-on","followers_url":"https://api.github.com/users/rain-on/followers","following_url":"https://api.github.com/users/rain-on/following{/other_user}","gists_url":"https://api.github.com/users/rain-on/gists{/gist_id}","starred_url":"https://api.github.com/users/rain-on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rain-on/subscriptions","organizations_url":"https://api.github.com/users/rain-on/orgs","repos_url":"https://api.github.com/users/rain-on/repos","events_url":"https://api.github.com/users/rain-on/events{/privacy}","received_events_url":"https://api.github.com/users/rain-on/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2018-11-15T23:32:02Z","updated_at":"2018-11-15T23:32:02Z","html_url":"https://github.com/PegaSysEng/pantheon/pull/263#discussion_r234046770","pull_request_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/263","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/comments/234046770"},"html":{"href":"https://github.com/PegaSysEng/pantheon/pull/263#discussion_r234046770"},"pull_request":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/263"}},"in_reply_to_id":233712042},"pull_request":{"url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/263","id":231055034,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDU1MDM0","html_url":"https://github.com/PegaSysEng/pantheon/pull/263","diff_url":"https://github.com/PegaSysEng/pantheon/pull/263.diff","patch_url":"https://github.com/PegaSysEng/pantheon/pull/263.patch","issue_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues/263","number":263,"state":"open","locked":false,"title":"Separating Validator voting from block serialisation values","user":{"login":"rain-on","id":37158202,"node_id":"MDQ6VXNlcjM3MTU4MjAy","avatar_url":"https://avatars2.githubusercontent.com/u/37158202?v=4","gravatar_id":"","url":"https://api.github.com/users/rain-on","html_url":"https://github.com/rain-on","followers_url":"https://api.github.com/users/rain-on/followers","following_url":"https://api.github.com/users/rain-on/following{/other_user}","gists_url":"https://api.github.com/users/rain-on/gists{/gist_id}","starred_url":"https://api.github.com/users/rain-on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rain-on/subscriptions","organizations_url":"https://api.github.com/users/rain-on/orgs","repos_url":"https://api.github.com/users/rain-on/repos","events_url":"https://api.github.com/users/rain-on/events{/privacy}","received_events_url":"https://api.github.com/users/rain-on/received_events","type":"User","site_admin":false},"body":"The consensus-mechanism specific block values have been separated\r\nfrom the VoteTallyUpdater such that there is a single updater rather\r\nthan one per consensus mechanism.\r\n\r\nThis has necessitated the creation of a custom serialiser/\r\ndeserialiser for each mechanism instead.\r\n\r\nThis change will ultimatley bleed through to the proposed votes and\r\ntheir insertion to mined blocks.\r\n\r\n<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->\r\n<!-- https://github.com/PegaSysEng/pantheon/blob/master/CONTRIBUTING.md -->\r\n\r\n## PR description\r\n\r\n## Fixed Issue(s)\r\n<!-- Please link to fixed issue(s) here using format: fixes #<issue number> -->\r\n<!-- Example: \"fixes #2\" -->\r\n","created_at":"2018-11-15T03:16:23Z","updated_at":"2018-11-15T23:32:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c3e1ceae77f466f187066c22d76a4c616f26f63","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/263/commits","review_comments_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/263/comments","review_comment_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues/263/comments","statuses_url":"https://api.github.com/repos/PegaSysEng/pantheon/statuses/e60138f129dc6a65b47f96ebd0c84350fc4622cc","head":{"label":"rain-on:consensus_voting","ref":"consensus_voting","sha":"e60138f129dc6a65b47f96ebd0c84350fc4622cc","user":{"login":"rain-on","id":37158202,"node_id":"MDQ6VXNlcjM3MTU4MjAy","avatar_url":"https://avatars2.githubusercontent.com/u/37158202?v=4","gravatar_id":"","url":"https://api.github.com/users/rain-on","html_url":"https://github.com/rain-on","followers_url":"https://api.github.com/users/rain-on/followers","following_url":"https://api.github.com/users/rain-on/following{/other_user}","gists_url":"https://api.github.com/users/rain-on/gists{/gist_id}","starred_url":"https://api.github.com/users/rain-on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rain-on/subscriptions","organizations_url":"https://api.github.com/users/rain-on/orgs","repos_url":"https://api.github.com/users/rain-on/repos","events_url":"https://api.github.com/users/rain-on/events{/privacy}","received_events_url":"https://api.github.com/users/rain-on/received_events","type":"User","site_admin":false},"repo":{"id":154781654,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ3ODE2NTQ=","name":"pantheon","full_name":"rain-on/pantheon","private":false,"owner":{"login":"rain-on","id":37158202,"node_id":"MDQ6VXNlcjM3MTU4MjAy","avatar_url":"https://avatars2.githubusercontent.com/u/37158202?v=4","gravatar_id":"","url":"https://api.github.com/users/rain-on","html_url":"https://github.com/rain-on","followers_url":"https://api.github.com/users/rain-on/followers","following_url":"https://api.github.com/users/rain-on/following{/other_user}","gists_url":"https://api.github.com/users/rain-on/gists{/gist_id}","starred_url":"https://api.github.com/users/rain-on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rain-on/subscriptions","organizations_url":"https://api.github.com/users/rain-on/orgs","repos_url":"https://api.github.com/users/rain-on/repos","events_url":"https://api.github.com/users/rain-on/events{/privacy}","received_events_url":"https://api.github.com/users/rain-on/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rain-on/pantheon","description":"PegaSys' Enterprise Blockchain Client","fork":true,"url":"https://api.github.com/repos/rain-on/pantheon","forks_url":"https://api.github.com/repos/rain-on/pantheon/forks","keys_url":"https://api.github.com/repos/rain-on/pantheon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rain-on/pantheon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rain-on/pantheon/teams","hooks_url":"https://api.github.com/repos/rain-on/pantheon/hooks","issue_events_url":"https://api.github.com/repos/rain-on/pantheon/issues/events{/number}","events_url":"https://api.github.com/repos/rain-on/pantheon/events","assignees_url":"https://api.github.com/repos/rain-on/pantheon/assignees{/user}","branches_url":"https://api.github.com/repos/rain-on/pantheon/branches{/branch}","tags_url":"https://api.github.com/repos/rain-on/pantheon/tags","blobs_url":"https://api.github.com/repos/rain-on/pantheon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rain-on/pantheon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rain-on/pantheon/git/refs{/sha}","trees_url":"https://api.github.com/repos/rain-on/pantheon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rain-on/pantheon/statuses/{sha}","languages_url":"https://api.github.com/repos/rain-on/pantheon/languages","stargazers_url":"https://api.github.com/repos/rain-on/pantheon/stargazers","contributors_url":"https://api.github.com/repos/rain-on/pantheon/contributors","subscribers_url":"https://api.github.com/repos/rain-on/pantheon/subscribers","subscription_url":"https://api.github.com/repos/rain-on/pantheon/subscription","commits_url":"https://api.github.com/repos/rain-on/pantheon/commits{/sha}","git_commits_url":"https://api.github.com/repos/rain-on/pantheon/git/commits{/sha}","comments_url":"https://api.github.com/repos/rain-on/pantheon/comments{/number}","issue_comment_url":"https://api.github.com/repos/rain-on/pantheon/issues/comments{/number}","contents_url":"https://api.github.com/repos/rain-on/pantheon/contents/{+path}","compare_url":"https://api.github.com/repos/rain-on/pantheon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rain-on/pantheon/merges","archive_url":"https://api.github.com/repos/rain-on/pantheon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rain-on/pantheon/downloads","issues_url":"https://api.github.com/repos/rain-on/pantheon/issues{/number}","pulls_url":"https://api.github.com/repos/rain-on/pantheon/pulls{/number}","milestones_url":"https://api.github.com/repos/rain-on/pantheon/milestones{/number}","notifications_url":"https://api.github.com/repos/rain-on/pantheon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rain-on/pantheon/labels{/name}","releases_url":"https://api.github.com/repos/rain-on/pantheon/releases{/id}","deployments_url":"https://api.github.com/repos/rain-on/pantheon/deployments","created_at":"2018-10-26T05:26:07Z","updated_at":"2018-10-26T05:26:12Z","pushed_at":"2018-11-15T03:24:27Z","git_url":"git://github.com/rain-on/pantheon.git","ssh_url":"git@github.com:rain-on/pantheon.git","clone_url":"https://github.com/rain-on/pantheon.git","svn_url":"https://github.com/rain-on/pantheon","homepage":"","size":6481,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PegaSysEng:master","ref":"master","sha":"22ed03518d98511818ce0fb46d9efac214387e3d","user":{"login":"PegaSysEng","id":41842516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxODQyNTE2","avatar_url":"https://avatars0.githubusercontent.com/u/41842516?v=4","gravatar_id":"","url":"https://api.github.com/users/PegaSysEng","html_url":"https://github.com/PegaSysEng","followers_url":"https://api.github.com/users/PegaSysEng/followers","following_url":"https://api.github.com/users/PegaSysEng/following{/other_user}","gists_url":"https://api.github.com/users/PegaSysEng/gists{/gist_id}","starred_url":"https://api.github.com/users/PegaSysEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PegaSysEng/subscriptions","organizations_url":"https://api.github.com/users/PegaSysEng/orgs","repos_url":"https://api.github.com/users/PegaSysEng/repos","events_url":"https://api.github.com/users/PegaSysEng/events{/privacy}","received_events_url":"https://api.github.com/users/PegaSysEng/received_events","type":"Organization","site_admin":false},"repo":{"id":152270344,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIyNzAzNDQ=","name":"pantheon","full_name":"PegaSysEng/pantheon","private":false,"owner":{"login":"PegaSysEng","id":41842516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxODQyNTE2","avatar_url":"https://avatars0.githubusercontent.com/u/41842516?v=4","gravatar_id":"","url":"https://api.github.com/users/PegaSysEng","html_url":"https://github.com/PegaSysEng","followers_url":"https://api.github.com/users/PegaSysEng/followers","following_url":"https://api.github.com/users/PegaSysEng/following{/other_user}","gists_url":"https://api.github.com/users/PegaSysEng/gists{/gist_id}","starred_url":"https://api.github.com/users/PegaSysEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PegaSysEng/subscriptions","organizations_url":"https://api.github.com/users/PegaSysEng/orgs","repos_url":"https://api.github.com/users/PegaSysEng/repos","events_url":"https://api.github.com/users/PegaSysEng/events{/privacy}","received_events_url":"https://api.github.com/users/PegaSysEng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PegaSysEng/pantheon","description":"An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client","fork":false,"url":"https://api.github.com/repos/PegaSysEng/pantheon","forks_url":"https://api.github.com/repos/PegaSysEng/pantheon/forks","keys_url":"https://api.github.com/repos/PegaSysEng/pantheon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PegaSysEng/pantheon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PegaSysEng/pantheon/teams","hooks_url":"https://api.github.com/repos/PegaSysEng/pantheon/hooks","issue_events_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues/events{/number}","events_url":"https://api.github.com/repos/PegaSysEng/pantheon/events","assignees_url":"https://api.github.com/repos/PegaSysEng/pantheon/assignees{/user}","branches_url":"https://api.github.com/repos/PegaSysEng/pantheon/branches{/branch}","tags_url":"https://api.github.com/repos/PegaSysEng/pantheon/tags","blobs_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/refs{/sha}","trees_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PegaSysEng/pantheon/statuses/{sha}","languages_url":"https://api.github.com/repos/PegaSysEng/pantheon/languages","stargazers_url":"https://api.github.com/repos/PegaSysEng/pantheon/stargazers","contributors_url":"https://api.github.com/repos/PegaSysEng/pantheon/contributors","subscribers_url":"https://api.github.com/repos/PegaSysEng/pantheon/subscribers","subscription_url":"https://api.github.com/repos/PegaSysEng/pantheon/subscription","commits_url":"https://api.github.com/repos/PegaSysEng/pantheon/commits{/sha}","git_commits_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/commits{/sha}","comments_url":"https://api.github.com/repos/PegaSysEng/pantheon/comments{/number}","issue_comment_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues/comments{/number}","contents_url":"https://api.github.com/repos/PegaSysEng/pantheon/contents/{+path}","compare_url":"https://api.github.com/repos/PegaSysEng/pantheon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PegaSysEng/pantheon/merges","archive_url":"https://api.github.com/repos/PegaSysEng/pantheon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PegaSysEng/pantheon/downloads","issues_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues{/number}","pulls_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls{/number}","milestones_url":"https://api.github.com/repos/PegaSysEng/pantheon/milestones{/number}","notifications_url":"https://api.github.com/repos/PegaSysEng/pantheon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PegaSysEng/pantheon/labels{/name}","releases_url":"https://api.github.com/repos/PegaSysEng/pantheon/releases{/id}","deployments_url":"https://api.github.com/repos/PegaSysEng/pantheon/deployments","created_at":"2018-10-09T14:54:59Z","updated_at":"2018-11-15T20:48:12Z","pushed_at":"2018-11-15T21:39:04Z","git_url":"git://github.com/PegaSysEng/pantheon.git","ssh_url":"git@github.com:PegaSysEng/pantheon.git","clone_url":"https://github.com/PegaSysEng/pantheon.git","svn_url":"https://github.com/PegaSysEng/pantheon","homepage":"","size":6558,"stargazers_count":153,"watchers_count":153,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":35,"open_issues":17,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/263"},"html":{"href":"https://github.com/PegaSysEng/pantheon/pull/263"},"issue":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/issues/263"},"comments":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/statuses/e60138f129dc6a65b47f96ebd0c84350fc4622cc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rain-on"}}