{"action":"created","comment":{"url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/comments/172205595","pull_request_review_id":101182417,"id":172205595,"diff_hunk":"@@ -49,9 +48,23 @@ <h3 style=\"margin: 0;\">[[ title ]]</h3>\n \t\t\t],\n \n \t\t\tproperties: {\n-\t\t\t\tdefaultCurrency: {\n-\t\t\t\t\ttype: String,\n-\t\t\t\t\tvalue: 'SEK'\n+\n+\t\t\t\t/**\n+\t\t\t\t *  Base Currency used in filters\n+\t\t\t\t */\n+\t\t\t\tcurrency: {\n+\t\t\t\t\ttype: String\n+\t\t\t\t},\n+\n+\t\t\t\t/**\n+\t\t\t\t *  If this is set true then currency property will be the currency with highest occurrence in values\n+\t\t\t\t */\n+\t\t\t\tautodetect: {\n+\t\t\t\t\ttype: Boolean,\n+\t\t\t\t\tvalue: false\n+\t\t\t\t},\n+\t\t\t\trates: {","path":"cosmoz-omnitable-column-amount.html","position":39,"original_position":39,"commit_id":"0f7195866f6dff39ae8afd62aea3d1eac731cc49","original_commit_id":"0f7195866f6dff39ae8afd62aea3d1eac731cc49","user":{"login":"plequang","id":5500311,"avatar_url":"https://avatars1.githubusercontent.com/u/5500311?v=4","gravatar_id":"","url":"https://api.github.com/users/plequang","html_url":"https://github.com/plequang","followers_url":"https://api.github.com/users/plequang/followers","following_url":"https://api.github.com/users/plequang/following{/other_user}","gists_url":"https://api.github.com/users/plequang/gists{/gist_id}","starred_url":"https://api.github.com/users/plequang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plequang/subscriptions","organizations_url":"https://api.github.com/users/plequang/orgs","repos_url":"https://api.github.com/users/plequang/repos","events_url":"https://api.github.com/users/plequang/events{/privacy}","received_events_url":"https://api.github.com/users/plequang/received_events","type":"User","site_admin":false},"body":"Yes I was thinking of a code comment that would appear in the api http://127.0.0.1:8081/components/cosmoz-omnitable/#/elements/cosmoz-omnitable-column-amount","created_at":"2018-03-05T14:36:09Z","updated_at":"2018-03-05T14:36:09Z","html_url":"https://github.com/Neovici/cosmoz-omnitable/pull/143#discussion_r172205595","pull_request_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/143","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/comments/172205595"},"html":{"href":"https://github.com/Neovici/cosmoz-omnitable/pull/143#discussion_r172205595"},"pull_request":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/143"}},"in_reply_to_id":172195579},"pull_request":{"url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/143","id":163951169,"html_url":"https://github.com/Neovici/cosmoz-omnitable/pull/143","diff_url":"https://github.com/Neovici/cosmoz-omnitable/pull/143.diff","patch_url":"https://github.com/Neovici/cosmoz-omnitable/pull/143.patch","issue_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues/143","number":143,"state":"open","locked":false,"title":"Currency management in column amount","user":{"login":"programmer4web","id":6841184,"avatar_url":"https://avatars3.githubusercontent.com/u/6841184?v=4","gravatar_id":"","url":"https://api.github.com/users/programmer4web","html_url":"https://github.com/programmer4web","followers_url":"https://api.github.com/users/programmer4web/followers","following_url":"https://api.github.com/users/programmer4web/following{/other_user}","gists_url":"https://api.github.com/users/programmer4web/gists{/gist_id}","starred_url":"https://api.github.com/users/programmer4web/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/programmer4web/subscriptions","organizations_url":"https://api.github.com/users/programmer4web/orgs","repos_url":"https://api.github.com/users/programmer4web/repos","events_url":"https://api.github.com/users/programmer4web/events{/privacy}","received_events_url":"https://api.github.com/users/programmer4web/received_events","type":"User","site_admin":false},"body":"1. Rates object, getComparableValue updated ( sorting and filtering are now based on amount value ).  added tests with rates.\r\n2. Configurable 'currency' property used in filters menu, added test.\r\n3. Auto-detect 'currency' property if not configured.\r\n4. If 'autodetect' property is true then 'currency' with be the currency with the highest occurrence ( implemented in function _valuesChanged ). added tests.\r\n5. formatters optimization: when data changes get only formatters that are not already created from the old set of values.\r\n\r\nfixes https://github.com/Neovici/cosmoz-omnitable/issues/24","created_at":"2018-01-19T11:52:33Z","updated_at":"2018-03-05T14:36:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91b240c3e08a8774f6a054d103d893ddf0531a43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/143/commits","review_comments_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/143/comments","review_comment_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues/143/comments","statuses_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/statuses/0f7195866f6dff39ae8afd62aea3d1eac731cc49","head":{"label":"plumelo:feature/NEOV-107-currency-rates","ref":"feature/NEOV-107-currency-rates","sha":"0f7195866f6dff39ae8afd62aea3d1eac731cc49","user":{"login":"plumelo","id":15955263,"avatar_url":"https://avatars0.githubusercontent.com/u/15955263?v=4","gravatar_id":"","url":"https://api.github.com/users/plumelo","html_url":"https://github.com/plumelo","followers_url":"https://api.github.com/users/plumelo/followers","following_url":"https://api.github.com/users/plumelo/following{/other_user}","gists_url":"https://api.github.com/users/plumelo/gists{/gist_id}","starred_url":"https://api.github.com/users/plumelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plumelo/subscriptions","organizations_url":"https://api.github.com/users/plumelo/orgs","repos_url":"https://api.github.com/users/plumelo/repos","events_url":"https://api.github.com/users/plumelo/events{/privacy}","received_events_url":"https://api.github.com/users/plumelo/received_events","type":"Organization","site_admin":false},"repo":{"id":107093066,"name":"cosmoz-omnitable","full_name":"plumelo/cosmoz-omnitable","owner":{"login":"plumelo","id":15955263,"avatar_url":"https://avatars0.githubusercontent.com/u/15955263?v=4","gravatar_id":"","url":"https://api.github.com/users/plumelo","html_url":"https://github.com/plumelo","followers_url":"https://api.github.com/users/plumelo/followers","following_url":"https://api.github.com/users/plumelo/following{/other_user}","gists_url":"https://api.github.com/users/plumelo/gists{/gist_id}","starred_url":"https://api.github.com/users/plumelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plumelo/subscriptions","organizations_url":"https://api.github.com/users/plumelo/orgs","repos_url":"https://api.github.com/users/plumelo/repos","events_url":"https://api.github.com/users/plumelo/events{/privacy}","received_events_url":"https://api.github.com/users/plumelo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plumelo/cosmoz-omnitable","description":"The Cosmoz Omnitable","fork":true,"url":"https://api.github.com/repos/plumelo/cosmoz-omnitable","forks_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/forks","keys_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/teams","hooks_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/hooks","issue_events_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/issues/events{/number}","events_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/events","assignees_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/assignees{/user}","branches_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/branches{/branch}","tags_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/tags","blobs_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/git/refs{/sha}","trees_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/statuses/{sha}","languages_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/languages","stargazers_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/stargazers","contributors_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/contributors","subscribers_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/subscribers","subscription_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/subscription","commits_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/commits{/sha}","git_commits_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/git/commits{/sha}","comments_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/comments{/number}","issue_comment_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/issues/comments{/number}","contents_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/contents/{+path}","compare_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/merges","archive_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/downloads","issues_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/issues{/number}","pulls_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/pulls{/number}","milestones_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/milestones{/number}","notifications_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/labels{/name}","releases_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/releases{/id}","deployments_url":"https://api.github.com/repos/plumelo/cosmoz-omnitable/deployments","created_at":"2017-10-16T07:31:26Z","updated_at":"2017-10-16T07:31:28Z","pushed_at":"2018-03-05T13:44:55Z","git_url":"git://github.com/plumelo/cosmoz-omnitable.git","ssh_url":"git@github.com:plumelo/cosmoz-omnitable.git","clone_url":"https://github.com/plumelo/cosmoz-omnitable.git","svn_url":"https://github.com/plumelo/cosmoz-omnitable","homepage":null,"size":4701,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Neovici:master","ref":"master","sha":"81b3fa3ef860b1682f4bdacd4a1b41d6752af799","user":{"login":"Neovici","id":10965763,"avatar_url":"https://avatars0.githubusercontent.com/u/10965763?v=4","gravatar_id":"","url":"https://api.github.com/users/Neovici","html_url":"https://github.com/Neovici","followers_url":"https://api.github.com/users/Neovici/followers","following_url":"https://api.github.com/users/Neovici/following{/other_user}","gists_url":"https://api.github.com/users/Neovici/gists{/gist_id}","starred_url":"https://api.github.com/users/Neovici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neovici/subscriptions","organizations_url":"https://api.github.com/users/Neovici/orgs","repos_url":"https://api.github.com/users/Neovici/repos","events_url":"https://api.github.com/users/Neovici/events{/privacy}","received_events_url":"https://api.github.com/users/Neovici/received_events","type":"Organization","site_admin":false},"repo":{"id":45485652,"name":"cosmoz-omnitable","full_name":"Neovici/cosmoz-omnitable","owner":{"login":"Neovici","id":10965763,"avatar_url":"https://avatars0.githubusercontent.com/u/10965763?v=4","gravatar_id":"","url":"https://api.github.com/users/Neovici","html_url":"https://github.com/Neovici","followers_url":"https://api.github.com/users/Neovici/followers","following_url":"https://api.github.com/users/Neovici/following{/other_user}","gists_url":"https://api.github.com/users/Neovici/gists{/gist_id}","starred_url":"https://api.github.com/users/Neovici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neovici/subscriptions","organizations_url":"https://api.github.com/users/Neovici/orgs","repos_url":"https://api.github.com/users/Neovici/repos","events_url":"https://api.github.com/users/Neovici/events{/privacy}","received_events_url":"https://api.github.com/users/Neovici/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Neovici/cosmoz-omnitable","description":"The Cosmoz Omnitable","fork":false,"url":"https://api.github.com/repos/Neovici/cosmoz-omnitable","forks_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/forks","keys_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/teams","hooks_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/hooks","issue_events_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues/events{/number}","events_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/events","assignees_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/assignees{/user}","branches_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/branches{/branch}","tags_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/tags","blobs_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/statuses/{sha}","languages_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/languages","stargazers_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/stargazers","contributors_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/contributors","subscribers_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/subscribers","subscription_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/subscription","commits_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/contents/{+path}","compare_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/merges","archive_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/downloads","issues_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues{/number}","pulls_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls{/number}","milestones_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/milestones{/number}","notifications_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/labels{/name}","releases_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/releases{/id}","deployments_url":"https://api.github.com/repos/Neovici/cosmoz-omnitable/deployments","created_at":"2015-11-03T18:08:36Z","updated_at":"2018-01-05T08:10:53Z","pushed_at":"2018-03-05T13:44:05Z","git_url":"git://github.com/Neovici/cosmoz-omnitable.git","ssh_url":"git@github.com:Neovici/cosmoz-omnitable.git","clone_url":"https://github.com/Neovici/cosmoz-omnitable.git","svn_url":"https://github.com/Neovici/cosmoz-omnitable","homepage":null,"size":4658,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":30,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/143"},"html":{"href":"https://github.com/Neovici/cosmoz-omnitable/pull/143"},"issue":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues/143"},"comments":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/Neovici/cosmoz-omnitable/statuses/0f7195866f6dff39ae8afd62aea3d1eac731cc49"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"plequang"}}