{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/172628933","pull_request_review_id":101679107,"id":172628933,"diff_hunk":"@@ -17,6 +17,23 @@\n  */\n public class Diagnosis extends BaseChangeableOpenmrsData {\n \n+\t/**\n+\t * The diagnosis order shows if a diagnosis is primary or secondary diagnosis\n+\t *\n+\t * @since 2.2\n+\t */\n+\tpublic enum DiagnosisOrder {","path":"api/src/main/java/org/openmrs/Diagnosis.java","position":9,"original_position":9,"commit_id":"84bd47115012e879021451fbf46eea8727e341e2","original_commit_id":"84bd47115012e879021451fbf46eea8727e341e2","user":{"login":"djazayeri","id":1165236,"avatar_url":"https://avatars0.githubusercontent.com/u/1165236?v=4","gravatar_id":"","url":"https://api.github.com/users/djazayeri","html_url":"https://github.com/djazayeri","followers_url":"https://api.github.com/users/djazayeri/followers","following_url":"https://api.github.com/users/djazayeri/following{/other_user}","gists_url":"https://api.github.com/users/djazayeri/gists{/gist_id}","starred_url":"https://api.github.com/users/djazayeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djazayeri/subscriptions","organizations_url":"https://api.github.com/users/djazayeri/orgs","repos_url":"https://api.github.com/users/djazayeri/repos","events_url":"https://api.github.com/users/djazayeri/events{/privacy}","received_events_url":"https://api.github.com/users/djazayeri/received_events","type":"User","site_admin":false},"body":"This should not be included\r\n\r\nThe old implementation in the emrapi module has an enum for this, but now that we're implementing it openmrs-core we want to be more flexible, so the \"Integer rank\" field replaces diagnosisOrder.\r\n\r\nSee the parent JIRA issue.","created_at":"2018-03-06T19:17:25Z","updated_at":"2018-03-06T19:17:32Z","html_url":"https://github.com/openmrs/openmrs-core/pull/2610#discussion_r172628933","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2610","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/172628933"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/2610#discussion_r172628933"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2610"}}},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2610","id":172200248,"html_url":"https://github.com/openmrs/openmrs-core/pull/2610","diff_url":"https://github.com/openmrs/openmrs-core/pull/2610.diff","patch_url":"https://github.com/openmrs/openmrs-core/pull/2610.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2610","number":2610,"state":"open","locked":false,"title":"TRUNK-5353: Create an implementation of the DiagnosisService interface.","user":{"login":"pluwum","id":3184113,"avatar_url":"https://avatars3.githubusercontent.com/u/3184113?v=4","gravatar_id":"","url":"https://api.github.com/users/pluwum","html_url":"https://github.com/pluwum","followers_url":"https://api.github.com/users/pluwum/followers","following_url":"https://api.github.com/users/pluwum/following{/other_user}","gists_url":"https://api.github.com/users/pluwum/gists{/gist_id}","starred_url":"https://api.github.com/users/pluwum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluwum/subscriptions","organizations_url":"https://api.github.com/users/pluwum/orgs","repos_url":"https://api.github.com/users/pluwum/repos","events_url":"https://api.github.com/users/pluwum/events{/privacy}","received_events_url":"https://api.github.com/users/pluwum/received_events","type":"User","site_admin":false},"body":"## Description of what I changed\r\nThis PR is an implementation of the DiagnosisService interface named DiagnosisServiceImpl.java and delivers tests for the newly added functionality.\r\n\r\n## Issue I worked on\r\nsee https://issues.openmrs.org/browse/TRUNK-5353\r\n\r\n## Checklist: I completed these to help reviewers :)\r\n<!--- Put an `x` in the box if you did the task -->\r\n<!--- If you forgot a task please follow the instructions below -->\r\n- [x] My pull request only contains **ONE single commit**\r\n(the number above, next to the 'Commits' tab is 1).\r\n\r\n- [x] My IDE is configured to follow the [**code style**](https://wiki.openmrs.org/display/docs/Java+Conventions) of this project.\r\n\r\n- [ ] I have **added tests** to cover my changes. (If you refactored\r\n  existing code that was well tested you do not have to add tests)\r\n\r\n- [x] I ran `mvn clean package` right before creating this pull request and\r\n  added all formatting changes to my commit.\r\n\r\n- [ ] All new and existing **tests passed**.\r\n\r\n- [x] My pull request is **based on the latest changes** of the master branch.\r\n\r\n","created_at":"2018-03-01T10:40:56Z","updated_at":"2018-03-06T19:17:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0abe3a8ca15e7331462b6d1a38b1d05d567f9114","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2610/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2610/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2610/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/84bd47115012e879021451fbf46eea8727e341e2","head":{"label":"pluwum:TRUNK-5353","ref":"TRUNK-5353","sha":"84bd47115012e879021451fbf46eea8727e341e2","user":{"login":"pluwum","id":3184113,"avatar_url":"https://avatars3.githubusercontent.com/u/3184113?v=4","gravatar_id":"","url":"https://api.github.com/users/pluwum","html_url":"https://github.com/pluwum","followers_url":"https://api.github.com/users/pluwum/followers","following_url":"https://api.github.com/users/pluwum/following{/other_user}","gists_url":"https://api.github.com/users/pluwum/gists{/gist_id}","starred_url":"https://api.github.com/users/pluwum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluwum/subscriptions","organizations_url":"https://api.github.com/users/pluwum/orgs","repos_url":"https://api.github.com/users/pluwum/repos","events_url":"https://api.github.com/users/pluwum/events{/privacy}","received_events_url":"https://api.github.com/users/pluwum/received_events","type":"User","site_admin":false},"repo":{"id":121360212,"name":"openmrs-core","full_name":"pluwum/openmrs-core","owner":{"login":"pluwum","id":3184113,"avatar_url":"https://avatars3.githubusercontent.com/u/3184113?v=4","gravatar_id":"","url":"https://api.github.com/users/pluwum","html_url":"https://github.com/pluwum","followers_url":"https://api.github.com/users/pluwum/followers","following_url":"https://api.github.com/users/pluwum/following{/other_user}","gists_url":"https://api.github.com/users/pluwum/gists{/gist_id}","starred_url":"https://api.github.com/users/pluwum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluwum/subscriptions","organizations_url":"https://api.github.com/users/pluwum/orgs","repos_url":"https://api.github.com/users/pluwum/repos","events_url":"https://api.github.com/users/pluwum/events{/privacy}","received_events_url":"https://api.github.com/users/pluwum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pluwum/openmrs-core","description":"OpenMRS API and web application code","fork":true,"url":"https://api.github.com/repos/pluwum/openmrs-core","forks_url":"https://api.github.com/repos/pluwum/openmrs-core/forks","keys_url":"https://api.github.com/repos/pluwum/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pluwum/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pluwum/openmrs-core/teams","hooks_url":"https://api.github.com/repos/pluwum/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/pluwum/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/pluwum/openmrs-core/events","assignees_url":"https://api.github.com/repos/pluwum/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/pluwum/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/pluwum/openmrs-core/tags","blobs_url":"https://api.github.com/repos/pluwum/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pluwum/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pluwum/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/pluwum/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pluwum/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/pluwum/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/pluwum/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/pluwum/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/pluwum/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/pluwum/openmrs-core/subscription","commits_url":"https://api.github.com/repos/pluwum/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/pluwum/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/pluwum/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/pluwum/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/pluwum/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/pluwum/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pluwum/openmrs-core/merges","archive_url":"https://api.github.com/repos/pluwum/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pluwum/openmrs-core/downloads","issues_url":"https://api.github.com/repos/pluwum/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/pluwum/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/pluwum/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/pluwum/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pluwum/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/pluwum/openmrs-core/releases{/id}","deployments_url":"https://api.github.com/repos/pluwum/openmrs-core/deployments","created_at":"2018-02-13T08:57:52Z","updated_at":"2018-02-13T08:58:00Z","pushed_at":"2018-03-06T16:47:00Z","git_url":"git://github.com/pluwum/openmrs-core.git","ssh_url":"git@github.com:pluwum/openmrs-core.git","clone_url":"https://github.com/pluwum/openmrs-core.git","svn_url":"https://github.com/pluwum/openmrs-core","homepage":"http://openmrs.org","size":227420,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"c3f3df88157db4b4d84b9b6880859c1f8a3c9120","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":5187976,"name":"openmrs-core","full_name":"openmrs/openmrs-core","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-core","description":"OpenMRS API and web application code","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-core","forks_url":"https://api.github.com/repos/openmrs/openmrs-core/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-core/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-core/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-core/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-core/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-core/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-core/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-core/releases{/id}","deployments_url":"https://api.github.com/repos/openmrs/openmrs-core/deployments","created_at":"2012-07-26T04:54:29Z","updated_at":"2018-03-05T08:27:55Z","pushed_at":"2018-03-06T19:15:19Z","git_url":"git://github.com/openmrs/openmrs-core.git","ssh_url":"git@github.com:openmrs/openmrs-core.git","clone_url":"https://github.com/openmrs/openmrs-core.git","svn_url":"https://github.com/openmrs/openmrs-core","homepage":"http://openmrs.org","size":227421,"stargazers_count":623,"watchers_count":623,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2056,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2056,"open_issues":23,"watchers":623,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2610"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/2610"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/2610"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/2610/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2610/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2610/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-core/statuses/84bd47115012e879021451fbf46eea8727e341e2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"djazayeri"}}