{"action":"created","comment":{"url":"https://api.github.com/repos/aeternity/epoch/pulls/comments/227690739","pull_request_review_id":167788133,"id":227690739,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzY5MDczOQ==","diff_hunk":"@@ -38,18 +38,17 @@\n       OogResource :: any(),\n       OogGas :: pos_integer().\n %% Wrapper function for logging error in tests.\n-call(Value, Data, State) ->\n-    case call_(Value, Data, State) of\n+call(Gas, Value, Data, State) ->\n+    case call_(Gas, Value, Data, State) of\n         {ok, _, _, _} = Ok ->\n             Ok;\n         {error, _} = Err ->\n-            ?TEST_LOG(\"Primop call error ~p~n~p:~p(~p, ~p, State)\",\n-                      [Err, ?MODULE, ?FUNCTION_NAME, Value, Data]),\n+            ?TEST_LOG(\"Primop call error ~p~n~p:~p(~p, ~p, ~p, State)\",\n+                      [Err, ?MODULE, ?FUNCTION_NAME, Gas, Value, Data]),\n             Err\n     end.\n \n-call_(Value, Data, StateIn) ->\n-    Gas = aevm_eeevm_state:gas(StateIn),","path":"apps/aevm/src/aevm_ae_primops.erl","position":43,"original_position":37,"commit_id":"de6648c292309ee0b06e6f7b065604756c074b26","original_commit_id":"b00763207927139b658f20b788e983c3f98a3d5f","user":{"login":"lucafavatella","id":1344255,"node_id":"MDQ6VXNlcjEzNDQyNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1344255?v=4","gravatar_id":"","url":"https://api.github.com/users/lucafavatella","html_url":"https://github.com/lucafavatella","followers_url":"https://api.github.com/users/lucafavatella/followers","following_url":"https://api.github.com/users/lucafavatella/following{/other_user}","gists_url":"https://api.github.com/users/lucafavatella/gists{/gist_id}","starred_url":"https://api.github.com/users/lucafavatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucafavatella/subscriptions","organizations_url":"https://api.github.com/users/lucafavatella/orgs","repos_url":"https://api.github.com/users/lucafavatella/repos","events_url":"https://api.github.com/users/lucafavatella/events{/privacy}","received_events_url":"https://api.github.com/users/lucafavatella/received_events","type":"User","site_admin":false},"body":"I see added.","created_at":"2018-10-24T08:35:27Z","updated_at":"2018-10-24T08:35:27Z","html_url":"https://github.com/aeternity/epoch/pull/1682#discussion_r227690739","pull_request_url":"https://api.github.com/repos/aeternity/epoch/pulls/1682","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/comments/227690739"},"html":{"href":"https://github.com/aeternity/epoch/pull/1682#discussion_r227690739"},"pull_request":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/1682"}},"in_reply_to_id":227445419},"pull_request":{"url":"https://api.github.com/repos/aeternity/epoch/pulls/1682","id":224928080,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTI4MDgw","html_url":"https://github.com/aeternity/epoch/pull/1682","diff_url":"https://github.com/aeternity/epoch/pull/1682.diff","patch_url":"https://github.com/aeternity/epoch/pull/1682.patch","issue_url":"https://api.github.com/repos/aeternity/epoch/issues/1682","number":1682,"state":"open","locked":false,"title":"PT-161093359 Size gas in primops","user":{"login":"jur0","id":1114009,"node_id":"MDQ6VXNlcjExMTQwMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1114009?v=4","gravatar_id":"","url":"https://api.github.com/users/jur0","html_url":"https://github.com/jur0","followers_url":"https://api.github.com/users/jur0/followers","following_url":"https://api.github.com/users/jur0/following{/other_user}","gists_url":"https://api.github.com/users/jur0/gists{/gist_id}","starred_url":"https://api.github.com/users/jur0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jur0/subscriptions","organizations_url":"https://api.github.com/users/jur0/orgs","repos_url":"https://api.github.com/users/jur0/repos","events_url":"https://api.github.com/users/jur0/events{/privacy}","received_events_url":"https://api.github.com/users/jur0/received_events","type":"User","site_admin":false},"body":"[PT-161093359](https://www.pivotaltracker.com/n/projects/2124891/stories/161093359)\r\n[PT-161340434](https://www.pivotaltracker.com/n/projects/2124891/stories/161340434) - Also included in this PR.\r\n\r\nThis PR adds size gas to the primops. Before, the primops had only state gas (computed from TTL). The primops have higher gas now, it's sum of the state gas and size gas. Size gas is computed from a related serialized transaction.\r\n\r\nThe protocol PR will follow.\r\n\r\nTODO:\r\n\r\n- [x] decide how to compute size gas - `aetx:size(Tx) * aec_governance:byte_gas()` should be good enough basic solution\r\n- [x] add release note\r\n","created_at":"2018-10-23T07:39:48Z","updated_at":"2018-10-24T08:35:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da5a118e88bea6dba5be5e3016b0b6b7fabedfd7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"velzevur","id":4035918,"node_id":"MDQ6VXNlcjQwMzU5MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4035918?v=4","gravatar_id":"","url":"https://api.github.com/users/velzevur","html_url":"https://github.com/velzevur","followers_url":"https://api.github.com/users/velzevur/followers","following_url":"https://api.github.com/users/velzevur/following{/other_user}","gists_url":"https://api.github.com/users/velzevur/gists{/gist_id}","starred_url":"https://api.github.com/users/velzevur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/velzevur/subscriptions","organizations_url":"https://api.github.com/users/velzevur/orgs","repos_url":"https://api.github.com/users/velzevur/repos","events_url":"https://api.github.com/users/velzevur/events{/privacy}","received_events_url":"https://api.github.com/users/velzevur/received_events","type":"User","site_admin":false},{"login":"gorillainduction","id":7676988,"node_id":"MDQ6VXNlcjc2NzY5ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/7676988?v=4","gravatar_id":"","url":"https://api.github.com/users/gorillainduction","html_url":"https://github.com/gorillainduction","followers_url":"https://api.github.com/users/gorillainduction/followers","following_url":"https://api.github.com/users/gorillainduction/following{/other_user}","gists_url":"https://api.github.com/users/gorillainduction/gists{/gist_id}","starred_url":"https://api.github.com/users/gorillainduction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorillainduction/subscriptions","organizations_url":"https://api.github.com/users/gorillainduction/orgs","repos_url":"https://api.github.com/users/gorillainduction/repos","events_url":"https://api.github.com/users/gorillainduction/events{/privacy}","received_events_url":"https://api.github.com/users/gorillainduction/received_events","type":"User","site_admin":false},{"login":"sennui","id":16958765,"node_id":"MDQ6VXNlcjE2OTU4NzY1","avatar_url":"https://avatars3.githubusercontent.com/u/16958765?v=4","gravatar_id":"","url":"https://api.github.com/users/sennui","html_url":"https://github.com/sennui","followers_url":"https://api.github.com/users/sennui/followers","following_url":"https://api.github.com/users/sennui/following{/other_user}","gists_url":"https://api.github.com/users/sennui/gists{/gist_id}","starred_url":"https://api.github.com/users/sennui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sennui/subscriptions","organizations_url":"https://api.github.com/users/sennui/orgs","repos_url":"https://api.github.com/users/sennui/repos","events_url":"https://api.github.com/users/sennui/events{/privacy}","received_events_url":"https://api.github.com/users/sennui/received_events","type":"User","site_admin":false},{"login":"zp-sd","id":28924437,"node_id":"MDQ6VXNlcjI4OTI0NDM3","avatar_url":"https://avatars1.githubusercontent.com/u/28924437?v=4","gravatar_id":"","url":"https://api.github.com/users/zp-sd","html_url":"https://github.com/zp-sd","followers_url":"https://api.github.com/users/zp-sd/followers","following_url":"https://api.github.com/users/zp-sd/following{/other_user}","gists_url":"https://api.github.com/users/zp-sd/gists{/gist_id}","starred_url":"https://api.github.com/users/zp-sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zp-sd/subscriptions","organizations_url":"https://api.github.com/users/zp-sd/orgs","repos_url":"https://api.github.com/users/zp-sd/repos","events_url":"https://api.github.com/users/zp-sd/events{/privacy}","received_events_url":"https://api.github.com/users/zp-sd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aeternity/epoch/pulls/1682/commits","review_comments_url":"https://api.github.com/repos/aeternity/epoch/pulls/1682/comments","review_comment_url":"https://api.github.com/repos/aeternity/epoch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aeternity/epoch/issues/1682/comments","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/de6648c292309ee0b06e6f7b065604756c074b26","head":{"label":"aeternity:PT-161093359-primops-gas--fix-call-gas","ref":"PT-161093359-primops-gas--fix-call-gas","sha":"de6648c292309ee0b06e6f7b065604756c074b26","user":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":99802036,"node_id":"MDEwOlJlcG9zaXRvcnk5OTgwMjAzNg==","name":"epoch","full_name":"aeternity/epoch","private":false,"owner":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aeternity/epoch","description":"æternity testnet: solving scalability problems by making sense of state-channels ","fork":false,"url":"https://api.github.com/repos/aeternity/epoch","forks_url":"https://api.github.com/repos/aeternity/epoch/forks","keys_url":"https://api.github.com/repos/aeternity/epoch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/epoch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/epoch/teams","hooks_url":"https://api.github.com/repos/aeternity/epoch/hooks","issue_events_url":"https://api.github.com/repos/aeternity/epoch/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/epoch/events","assignees_url":"https://api.github.com/repos/aeternity/epoch/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/epoch/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/epoch/tags","blobs_url":"https://api.github.com/repos/aeternity/epoch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/epoch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/epoch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/epoch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/epoch/languages","stargazers_url":"https://api.github.com/repos/aeternity/epoch/stargazers","contributors_url":"https://api.github.com/repos/aeternity/epoch/contributors","subscribers_url":"https://api.github.com/repos/aeternity/epoch/subscribers","subscription_url":"https://api.github.com/repos/aeternity/epoch/subscription","commits_url":"https://api.github.com/repos/aeternity/epoch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/epoch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/epoch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/epoch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/epoch/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/epoch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/epoch/merges","archive_url":"https://api.github.com/repos/aeternity/epoch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/epoch/downloads","issues_url":"https://api.github.com/repos/aeternity/epoch/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/epoch/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/epoch/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/epoch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/epoch/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/epoch/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/epoch/deployments","created_at":"2017-08-09T11:44:30Z","updated_at":"2018-10-23T17:10:58Z","pushed_at":"2018-10-24T08:32:33Z","git_url":"git://github.com/aeternity/epoch.git","ssh_url":"git@github.com:aeternity/epoch.git","clone_url":"https://github.com/aeternity/epoch.git","svn_url":"https://github.com/aeternity/epoch","homepage":"http://www.aeternity.com","size":10757,"stargazers_count":666,"watchers_count":666,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":121,"open_issues":18,"watchers":666,"default_branch":"master"}},"base":{"label":"aeternity:master","ref":"master","sha":"2af0ce3e2b9e155f155564eae3ecd7a7004508cd","user":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":99802036,"node_id":"MDEwOlJlcG9zaXRvcnk5OTgwMjAzNg==","name":"epoch","full_name":"aeternity/epoch","private":false,"owner":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aeternity/epoch","description":"æternity testnet: solving scalability problems by making sense of state-channels ","fork":false,"url":"https://api.github.com/repos/aeternity/epoch","forks_url":"https://api.github.com/repos/aeternity/epoch/forks","keys_url":"https://api.github.com/repos/aeternity/epoch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/epoch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/epoch/teams","hooks_url":"https://api.github.com/repos/aeternity/epoch/hooks","issue_events_url":"https://api.github.com/repos/aeternity/epoch/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/epoch/events","assignees_url":"https://api.github.com/repos/aeternity/epoch/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/epoch/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/epoch/tags","blobs_url":"https://api.github.com/repos/aeternity/epoch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/epoch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/epoch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/epoch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/epoch/languages","stargazers_url":"https://api.github.com/repos/aeternity/epoch/stargazers","contributors_url":"https://api.github.com/repos/aeternity/epoch/contributors","subscribers_url":"https://api.github.com/repos/aeternity/epoch/subscribers","subscription_url":"https://api.github.com/repos/aeternity/epoch/subscription","commits_url":"https://api.github.com/repos/aeternity/epoch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/epoch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/epoch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/epoch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/epoch/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/epoch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/epoch/merges","archive_url":"https://api.github.com/repos/aeternity/epoch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/epoch/downloads","issues_url":"https://api.github.com/repos/aeternity/epoch/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/epoch/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/epoch/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/epoch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/epoch/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/epoch/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/epoch/deployments","created_at":"2017-08-09T11:44:30Z","updated_at":"2018-10-23T17:10:58Z","pushed_at":"2018-10-24T08:32:33Z","git_url":"git://github.com/aeternity/epoch.git","ssh_url":"git@github.com:aeternity/epoch.git","clone_url":"https://github.com/aeternity/epoch.git","svn_url":"https://github.com/aeternity/epoch","homepage":"http://www.aeternity.com","size":10757,"stargazers_count":666,"watchers_count":666,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":121,"open_issues":18,"watchers":666,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/1682"},"html":{"href":"https://github.com/aeternity/epoch/pull/1682"},"issue":{"href":"https://api.github.com/repos/aeternity/epoch/issues/1682"},"comments":{"href":"https://api.github.com/repos/aeternity/epoch/issues/1682/comments"},"review_comments":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/1682/comments"},"review_comment":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/1682/commits"},"statuses":{"href":"https://api.github.com/repos/aeternity/epoch/statuses/de6648c292309ee0b06e6f7b065604756c074b26"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lucafavatella"}}