{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/flow/issues/4288","repository_url":"https://api.github.com/repos/vaadin/flow","labels_url":"https://api.github.com/repos/vaadin/flow/issues/4288/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/flow/issues/4288/comments","events_url":"https://api.github.com/repos/vaadin/flow/issues/4288/events","html_url":"https://github.com/vaadin/flow/pull/4288","id":332292047,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODA4Mjg5","number":4288,"title":"Extract module to be able to enable production mode","user":{"login":"denis-anisimov","id":11425472,"node_id":"MDQ6VXNlcjExNDI1NDcy","avatar_url":"https://avatars0.githubusercontent.com/u/11425472?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-anisimov","html_url":"https://github.com/denis-anisimov","followers_url":"https://api.github.com/users/denis-anisimov/followers","following_url":"https://api.github.com/users/denis-anisimov/following{/other_user}","gists_url":"https://api.github.com/users/denis-anisimov/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-anisimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-anisimov/subscriptions","organizations_url":"https://api.github.com/users/denis-anisimov/orgs","repos_url":"https://api.github.com/users/denis-anisimov/repos","events_url":"https://api.github.com/users/denis-anisimov/events{/privacy}","received_events_url":"https://api.github.com/users/denis-anisimov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-14T08:01:42Z","updated_at":"2018-06-15T11:02:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vaadin/flow/pulls/4288","html_url":"https://github.com/vaadin/flow/pull/4288","diff_url":"https://github.com/vaadin/flow/pull/4288.diff","patch_url":"https://github.com/vaadin/flow/pull/4288.patch"},"body":"* Enable production mode for root-context module\r\n* Extract dev mode tests to the separate module\r\n* Extract common UI classes to the common module\r\n\r\nFix for #4266\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/flow/4288)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/flow/issues/comments/397587795","html_url":"https://github.com/vaadin/flow/pull/4288#issuecomment-397587795","issue_url":"https://api.github.com/repos/vaadin/flow/issues/4288","id":397587795,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzU4Nzc5NQ==","user":{"login":"denis-anisimov","id":11425472,"node_id":"MDQ6VXNlcjExNDI1NDcy","avatar_url":"https://avatars0.githubusercontent.com/u/11425472?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-anisimov","html_url":"https://github.com/denis-anisimov","followers_url":"https://api.github.com/users/denis-anisimov/followers","following_url":"https://api.github.com/users/denis-anisimov/following{/other_user}","gists_url":"https://api.github.com/users/denis-anisimov/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-anisimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-anisimov/subscriptions","organizations_url":"https://api.github.com/users/denis-anisimov/orgs","repos_url":"https://api.github.com/users/denis-anisimov/repos","events_url":"https://api.github.com/users/denis-anisimov/events{/privacy}","received_events_url":"https://api.github.com/users/denis-anisimov/received_events","type":"User","site_admin":false},"created_at":"2018-06-15T11:02:37Z","updated_at":"2018-06-15T11:02:37Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 1 unresolved discussion, 0 of 1 LGTMs obtained\n\n---\n\n*[a discussion](https://reviewable.io/reviews/vaadin/flow/4288#-LF1KNKQ4KTjptaiGPRC:-LF24KHnB2AyVR6mWCFO:bvhraum) (no related file):*\n<details><summary><i>Previously, pekam (Pekka Maanpää) wrote…</i></summary><blockquote>\n\nI know. Let me re-phrase it a bit:\nI tried just for lulz how does it work now if I run the tests in production mode.\nI noticed that there are some failing tests, many with the word `development mode` in it.\nYour PR moves dev mode related tests to a new module: `flow-test-dev-mode`.\nSo as a consequence I get a concern that are maybe some tests are still in the wrong package. I'm not saying that they are, but I'm asking you to check because the names of those tests sound suspicious.\n</blockquote></details>\n\nThe \"dev mode\" related test in this PR are: the tests which cannot be anyhow kept in this module because our maven plugin just fails (so the build won't be successful). \nI haven't run any test in dev mode.\n\nThe UI/View classes that break the maven plugin execution have been moved out from the module.\nSo now the production mode transpiles the module sources.\n\nIt might be that there are a number of other classes which needs to be moved to the `dev-mode` module.\nTo know that we need to run them in production mode at least once (all the test).\nThis is another task. (end every such test needs its decision : whether it should be corrected or just moved out)\n\nSo yes, only one part is done. But this part fixes the ticket. \nEven if there are other tests that should be executed only in dev mode I care only about classes which allows to transpile.\n\nIt's not worth do to everything at once.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/vaadin/flow/4288)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"denis-anisimov"}}