{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/177990816","pull_request_review_id":107966010,"id":177990816,"diff_hunk":"@@ -23,7 +23,6 @@\n namespace iroha {","path":"irohad/torii/processor/impl/transaction_processor_impl.cpp","position":1,"original_position":1,"commit_id":"b548ce7dcbce5cffdef4fb146c5ee7d711b7f198","original_commit_id":"b548ce7dcbce5cffdef4fb146c5ee7d711b7f198","user":{"login":"victordrobny","id":9118241,"avatar_url":"https://avatars1.githubusercontent.com/u/9118241?v=4","gravatar_id":"","url":"https://api.github.com/users/victordrobny","html_url":"https://github.com/victordrobny","followers_url":"https://api.github.com/users/victordrobny/followers","following_url":"https://api.github.com/users/victordrobny/following{/other_user}","gists_url":"https://api.github.com/users/victordrobny/gists{/gist_id}","starred_url":"https://api.github.com/users/victordrobny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victordrobny/subscriptions","organizations_url":"https://api.github.com/users/victordrobny/orgs","repos_url":"https://api.github.com/users/victordrobny/repos","events_url":"https://api.github.com/users/victordrobny/events{/privacy}","received_events_url":"https://api.github.com/users/victordrobny/received_events","type":"User","site_admin":false},"body":"Same\r\n","created_at":"2018-03-29T08:50:05Z","updated_at":"2018-03-29T08:50:57Z","html_url":"https://github.com/hyperledger/iroha/pull/1146#discussion_r177990816","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1146","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/177990816"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1146#discussion_r177990816"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1146"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/1146","id":178261418,"html_url":"https://github.com/hyperledger/iroha/pull/1146","diff_url":"https://github.com/hyperledger/iroha/pull/1146.diff","patch_url":"https://github.com/hyperledger/iroha/pull/1146.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/1146","number":1146,"state":"open","locked":false,"title":"Feature/move to shared model smallfixes","user":{"login":"Alexey-N-Chernyshov","id":495478,"avatar_url":"https://avatars0.githubusercontent.com/u/495478?v=4","gravatar_id":"","url":"https://api.github.com/users/Alexey-N-Chernyshov","html_url":"https://github.com/Alexey-N-Chernyshov","followers_url":"https://api.github.com/users/Alexey-N-Chernyshov/followers","following_url":"https://api.github.com/users/Alexey-N-Chernyshov/following{/other_user}","gists_url":"https://api.github.com/users/Alexey-N-Chernyshov/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexey-N-Chernyshov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexey-N-Chernyshov/subscriptions","organizations_url":"https://api.github.com/users/Alexey-N-Chernyshov/orgs","repos_url":"https://api.github.com/users/Alexey-N-Chernyshov/repos","events_url":"https://api.github.com/users/Alexey-N-Chernyshov/events{/privacy}","received_events_url":"https://api.github.com/users/Alexey-N-Chernyshov/received_events","type":"User","site_admin":false},"body":"<!-- You will not see HTML commented line in Pull Request body -->\r\n<!-- Optional sections may be omitted. Just remove them or write None -->\r\n\r\n<!-- ### Requirements -->\r\n<!-- * Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. -->\r\n<!-- * All new code must have code coverage above 70% (https://docs.codecov.io/docs/about-code-coverage). -->\r\n<!-- * CircleCI builds must be passed. -->\r\n<!-- * Critical and blocker issues reported by Sorabot must be fixed. -->\r\n<!-- * Branch must be rebased onto base branch (https://soramitsu.atlassian.net/wiki/spaces/IS/pages/11173889/Rebase+and+merge+guide). -->\r\n\r\n\r\n### Description of the Change\r\nRemove unused includes and forward declarations.\r\n<!-- We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. -->\r\n<!-- Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts. -->\r\n\r\n### Benefits\r\nno unused code\r\n<!-- What benefits will be realized by the code change? -->\r\n\r\n### Possible Drawbacks \r\nno\r\n<!-- What are the possible side-effects or negative impacts of the code change? -->\r\n<!-- If no drawbacks, explicitly mention this (write None) -->\r\n\r\n### Usage Examples or Tests *[optional]*\r\nno\r\n<!-- Point reviewers to the test, code example or documentation which shows usage example of this feature -->\r\n\r\n### Alternate Designs *[optional]*\r\nno\r\n<!-- Explain what other alternates were considered and why the proposed version was selected -->\r\n","created_at":"2018-03-29T08:37:47Z","updated_at":"2018-03-29T08:50:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"538e6aebbeb3090134e8a4cbe75cf960d7a6cac3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":881359116,"url":"https://api.github.com/repos/hyperledger/iroha/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1146/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1146/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/1146/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/b548ce7dcbce5cffdef4fb146c5ee7d711b7f198","head":{"label":"hyperledger:feature/move-to-shared_model-smallfixes","ref":"feature/move-to-shared_model-smallfixes","sha":"b548ce7dcbce5cffdef4fb146c5ee7d711b7f198","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-03-29T06:26:03Z","pushed_at":"2018-03-29T08:37:47Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":45501,"stargazers_count":706,"watchers_count":706,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":221,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":221,"open_issues":35,"watchers":706,"default_branch":"master"}},"base":{"label":"hyperledger:develop","ref":"develop","sha":"4966ad9994f613a0c24ab5a2e277b521ff10fdbd","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-03-29T06:26:03Z","pushed_at":"2018-03-29T08:37:47Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":45501,"stargazers_count":706,"watchers_count":706,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":221,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":221,"open_issues":35,"watchers":706,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1146"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1146"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1146"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1146/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1146/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1146/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/b548ce7dcbce5cffdef4fb146c5ee7d711b7f198"}},"author_association":"NONE"}}
{"actor":{"display_login":"victordrobny"}}