{"action":"created","issue":{"url":"https://api.github.com/repos/video-dev/hls.js/issues/1554","repository_url":"https://api.github.com/repos/video-dev/hls.js","labels_url":"https://api.github.com/repos/video-dev/hls.js/issues/1554/labels{/name}","comments_url":"https://api.github.com/repos/video-dev/hls.js/issues/1554/comments","events_url":"https://api.github.com/repos/video-dev/hls.js/issues/1554/events","html_url":"https://github.com/video-dev/hls.js/pull/1554","id":295582572,"number":1554,"title":"Remove maxSeekHole and relax constraints around gap jumping, allowing arbitratily sized start gap jumps","user":{"login":"johnBartos","id":5042276,"avatar_url":"https://avatars1.githubusercontent.com/u/5042276?v=4","gravatar_id":"","url":"https://api.github.com/users/johnBartos","html_url":"https://github.com/johnBartos","followers_url":"https://api.github.com/users/johnBartos/followers","following_url":"https://api.github.com/users/johnBartos/following{/other_user}","gists_url":"https://api.github.com/users/johnBartos/gists{/gist_id}","starred_url":"https://api.github.com/users/johnBartos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnBartos/subscriptions","organizations_url":"https://api.github.com/users/johnBartos/orgs","repos_url":"https://api.github.com/users/johnBartos/repos","events_url":"https://api.github.com/users/johnBartos/events{/privacy}","received_events_url":"https://api.github.com/users/johnBartos/received_events","type":"User","site_admin":false},"labels":[{"id":171943033,"url":"https://api.github.com/repos/video-dev/hls.js/labels/Bug","name":"Bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-08T16:40:54Z","updated_at":"2018-02-26T16:43:15Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/video-dev/hls.js/pulls/1554","html_url":"https://github.com/video-dev/hls.js/pull/1554","diff_url":"https://github.com/video-dev/hls.js/pull/1554.diff","patch_url":"https://github.com/video-dev/hls.js/pull/1554.patch"},"body":"### Description of the Changes\r\n- Applies the changes revert from the FragmentTracker's original work: https://github.com/video-dev/hls.js/pull/1466/commits/53876edbdcfcc39e18ed061bd51c949a38ee035d#diff-92ec9c117a188d62ae4becd0540933d6L1368\r\n- Adds `readyState > 1` condition to the `expectedPlaying` condition. If we're stuck in an unbuffered region (e.g. the stream starts buffering at `t=10`), `media.paused` will be true without the user actually pausing; and therefore we *should* expect to play. `readyState > 1` and `paused` is a more positive signal of an actual pause.\r\n\r\n@davidkim9 Was this your intention with removing `seekHole`? Not entirely sure if this is safe but it does resolve an issue starting this stream: https://s3.amazonaws.com/bob.jwplayer.com/~alex/123633/new_master.m3u8\r\n\r\n### CheckLists\r\n\r\n- [x] changes have been done against master branch, and PR does not conflict\r\n- [x] no commits have been done in dist folder (we will take care of updating it)\r\n- [x] new unit / functional tests have been added (whenever applicable)\r\n- [] Travis tests are passing (or test results are not worse than on master branch :))\r\n- [x] API or design changes are documented in API.md\r\n"},"comment":{"url":"https://api.github.com/repos/video-dev/hls.js/issues/comments/368565846","html_url":"https://github.com/video-dev/hls.js/pull/1554#issuecomment-368565846","issue_url":"https://api.github.com/repos/video-dev/hls.js/issues/1554","id":368565846,"user":{"login":"davidkim9","id":2999143,"avatar_url":"https://avatars2.githubusercontent.com/u/2999143?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkim9","html_url":"https://github.com/davidkim9","followers_url":"https://api.github.com/users/davidkim9/followers","following_url":"https://api.github.com/users/davidkim9/following{/other_user}","gists_url":"https://api.github.com/users/davidkim9/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkim9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkim9/subscriptions","organizations_url":"https://api.github.com/users/davidkim9/orgs","repos_url":"https://api.github.com/users/davidkim9/repos","events_url":"https://api.github.com/users/davidkim9/events{/privacy}","received_events_url":"https://api.github.com/users/davidkim9/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T16:43:15Z","updated_at":"2018-02-26T16:43:15Z","author_association":"CONTRIBUTOR","body":"lgtm"}}
{"actor":{"display_login":"davidkim9"}}