{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/comments/239177786","pull_request_review_id":181896066,"id":239177786,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTE3Nzc4Ng==","diff_hunk":"@@ -861,34 +859,32 @@ describe('Datastore', () => {\n               },\n             ]);\n \n-            transaction.commit(err => {\n+            transaction.commit(async err => {","path":"system-test/datastore.ts","position":62,"original_position":62,"commit_id":"761261e3842891ac03b17bc36328ef96736f4052","original_commit_id":"761261e3842891ac03b17bc36328ef96736f4052","user":{"login":"JustinBeckwith","id":534619,"node_id":"MDQ6VXNlcjUzNDYxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/534619?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinBeckwith","html_url":"https://github.com/JustinBeckwith","followers_url":"https://api.github.com/users/JustinBeckwith/followers","following_url":"https://api.github.com/users/JustinBeckwith/following{/other_user}","gists_url":"https://api.github.com/users/JustinBeckwith/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinBeckwith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinBeckwith/subscriptions","organizations_url":"https://api.github.com/users/JustinBeckwith/orgs","repos_url":"https://api.github.com/users/JustinBeckwith/repos","events_url":"https://api.github.com/users/JustinBeckwith/events{/privacy}","received_events_url":"https://api.github.com/users/JustinBeckwith/received_events","type":"User","site_admin":false},"body":"Having an async callback method is super weird.  I believe `transaction.commit` is an async function.  Can you just `await` the result of that?","created_at":"2018-12-05T18:11:26Z","updated_at":"2018-12-05T18:13:27Z","html_url":"https://github.com/googleapis/nodejs-datastore/pull/272#discussion_r239177786","pull_request_url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/272","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/comments/239177786"},"html":{"href":"https://github.com/googleapis/nodejs-datastore/pull/272#discussion_r239177786"},"pull_request":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/272"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/272","id":236265857,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjY1ODU3","html_url":"https://github.com/googleapis/nodejs-datastore/pull/272","diff_url":"https://github.com/googleapis/nodejs-datastore/pull/272.diff","patch_url":"https://github.com/googleapis/nodejs-datastore/pull/272.patch","issue_url":"https://api.github.com/repos/googleapis/nodejs-datastore/issues/272","number":272,"state":"open","locked":false,"title":"remove async module usage","user":{"login":"vijay-qlogic","id":36055624,"node_id":"MDQ6VXNlcjM2MDU1NjI0","avatar_url":"https://avatars1.githubusercontent.com/u/36055624?v=4","gravatar_id":"","url":"https://api.github.com/users/vijay-qlogic","html_url":"https://github.com/vijay-qlogic","followers_url":"https://api.github.com/users/vijay-qlogic/followers","following_url":"https://api.github.com/users/vijay-qlogic/following{/other_user}","gists_url":"https://api.github.com/users/vijay-qlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/vijay-qlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijay-qlogic/subscriptions","organizations_url":"https://api.github.com/users/vijay-qlogic/orgs","repos_url":"https://api.github.com/users/vijay-qlogic/repos","events_url":"https://api.github.com/users/vijay-qlogic/events{/privacy}","received_events_url":"https://api.github.com/users/vijay-qlogic/received_events","type":"User","site_admin":false},"body":"Fixes #[2883](https://github.com/googleapis/google-cloud-node/issues/2883) partially for nodejs-datastore (it's a good idea to open an issue first for discussion)\r\n\r\n- [ ] Tests and linter pass\r\n- [ ] Code coverage does not decrease (if any source code was changed)\r\n- [ ] Appropriate docs were updated (if necessary)\r\n","created_at":"2018-12-05T17:47:41Z","updated_at":"2018-12-05T18:13:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3858dcadb6c8b62b0e938d4c3647ef3391516607","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1016504629,"node_id":"MDU6TGFiZWwxMDE2NTA0NjI5","url":"https://api.github.com/repos/googleapis/nodejs-datastore/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/272/commits","review_comments_url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/272/comments","review_comment_url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/nodejs-datastore/issues/272/comments","statuses_url":"https://api.github.com/repos/googleapis/nodejs-datastore/statuses/761261e3842891ac03b17bc36328ef96736f4052","head":{"label":"vijay-qlogic:rmv-async-module","ref":"rmv-async-module","sha":"761261e3842891ac03b17bc36328ef96736f4052","user":{"login":"vijay-qlogic","id":36055624,"node_id":"MDQ6VXNlcjM2MDU1NjI0","avatar_url":"https://avatars1.githubusercontent.com/u/36055624?v=4","gravatar_id":"","url":"https://api.github.com/users/vijay-qlogic","html_url":"https://github.com/vijay-qlogic","followers_url":"https://api.github.com/users/vijay-qlogic/followers","following_url":"https://api.github.com/users/vijay-qlogic/following{/other_user}","gists_url":"https://api.github.com/users/vijay-qlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/vijay-qlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijay-qlogic/subscriptions","organizations_url":"https://api.github.com/users/vijay-qlogic/orgs","repos_url":"https://api.github.com/users/vijay-qlogic/repos","events_url":"https://api.github.com/users/vijay-qlogic/events{/privacy}","received_events_url":"https://api.github.com/users/vijay-qlogic/received_events","type":"User","site_admin":false},"repo":{"id":159350753,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzNTA3NTM=","name":"nodejs-datastore","full_name":"vijay-qlogic/nodejs-datastore","private":false,"owner":{"login":"vijay-qlogic","id":36055624,"node_id":"MDQ6VXNlcjM2MDU1NjI0","avatar_url":"https://avatars1.githubusercontent.com/u/36055624?v=4","gravatar_id":"","url":"https://api.github.com/users/vijay-qlogic","html_url":"https://github.com/vijay-qlogic","followers_url":"https://api.github.com/users/vijay-qlogic/followers","following_url":"https://api.github.com/users/vijay-qlogic/following{/other_user}","gists_url":"https://api.github.com/users/vijay-qlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/vijay-qlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijay-qlogic/subscriptions","organizations_url":"https://api.github.com/users/vijay-qlogic/orgs","repos_url":"https://api.github.com/users/vijay-qlogic/repos","events_url":"https://api.github.com/users/vijay-qlogic/events{/privacy}","received_events_url":"https://api.github.com/users/vijay-qlogic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vijay-qlogic/nodejs-datastore","description":"Node.js client for Google Cloud Datastore: a highly-scalable NoSQL database for your web and mobile applications.","fork":true,"url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore","forks_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/forks","keys_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/teams","hooks_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/hooks","issue_events_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/issues/events{/number}","events_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/events","assignees_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/assignees{/user}","branches_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/branches{/branch}","tags_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/tags","blobs_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/git/refs{/sha}","trees_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/statuses/{sha}","languages_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/languages","stargazers_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/stargazers","contributors_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/contributors","subscribers_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/subscribers","subscription_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/subscription","commits_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/commits{/sha}","git_commits_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/git/commits{/sha}","comments_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/comments{/number}","issue_comment_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/issues/comments{/number}","contents_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/contents/{+path}","compare_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/merges","archive_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/downloads","issues_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/issues{/number}","pulls_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/pulls{/number}","milestones_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/milestones{/number}","notifications_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/labels{/name}","releases_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/releases{/id}","deployments_url":"https://api.github.com/repos/vijay-qlogic/nodejs-datastore/deployments","created_at":"2018-11-27T14:46:01Z","updated_at":"2018-12-05T17:49:59Z","pushed_at":"2018-12-05T17:50:48Z","git_url":"git://github.com/vijay-qlogic/nodejs-datastore.git","ssh_url":"git@github.com:vijay-qlogic/nodejs-datastore.git","clone_url":"https://github.com/vijay-qlogic/nodejs-datastore.git","svn_url":"https://github.com/vijay-qlogic/nodejs-datastore","homepage":"https://cloud.google.com/datastore/","size":1711,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"bba96409bf03166d11f157c7dfd36f25c2ae4ede","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":98463536,"node_id":"MDEwOlJlcG9zaXRvcnk5ODQ2MzUzNg==","name":"nodejs-datastore","full_name":"googleapis/nodejs-datastore","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/nodejs-datastore","description":"Node.js client for Google Cloud Datastore: a highly-scalable NoSQL database for your web and mobile applications.","fork":false,"url":"https://api.github.com/repos/googleapis/nodejs-datastore","forks_url":"https://api.github.com/repos/googleapis/nodejs-datastore/forks","keys_url":"https://api.github.com/repos/googleapis/nodejs-datastore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/nodejs-datastore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/nodejs-datastore/teams","hooks_url":"https://api.github.com/repos/googleapis/nodejs-datastore/hooks","issue_events_url":"https://api.github.com/repos/googleapis/nodejs-datastore/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/nodejs-datastore/events","assignees_url":"https://api.github.com/repos/googleapis/nodejs-datastore/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/nodejs-datastore/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/nodejs-datastore/tags","blobs_url":"https://api.github.com/repos/googleapis/nodejs-datastore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/nodejs-datastore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/nodejs-datastore/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/nodejs-datastore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/nodejs-datastore/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/nodejs-datastore/languages","stargazers_url":"https://api.github.com/repos/googleapis/nodejs-datastore/stargazers","contributors_url":"https://api.github.com/repos/googleapis/nodejs-datastore/contributors","subscribers_url":"https://api.github.com/repos/googleapis/nodejs-datastore/subscribers","subscription_url":"https://api.github.com/repos/googleapis/nodejs-datastore/subscription","commits_url":"https://api.github.com/repos/googleapis/nodejs-datastore/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/nodejs-datastore/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/nodejs-datastore/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/nodejs-datastore/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/nodejs-datastore/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/nodejs-datastore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/nodejs-datastore/merges","archive_url":"https://api.github.com/repos/googleapis/nodejs-datastore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/nodejs-datastore/downloads","issues_url":"https://api.github.com/repos/googleapis/nodejs-datastore/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/nodejs-datastore/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/nodejs-datastore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/nodejs-datastore/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/nodejs-datastore/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/nodejs-datastore/deployments","created_at":"2017-07-26T20:32:42Z","updated_at":"2018-12-04T17:25:04Z","pushed_at":"2018-12-05T17:50:49Z","git_url":"git://github.com/googleapis/nodejs-datastore.git","ssh_url":"git@github.com:googleapis/nodejs-datastore.git","clone_url":"https://github.com/googleapis/nodejs-datastore.git","svn_url":"https://github.com/googleapis/nodejs-datastore","homepage":"https://cloud.google.com/datastore/","size":1714,"stargazers_count":66,"watchers_count":66,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":40,"open_issues":23,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/272"},"html":{"href":"https://github.com/googleapis/nodejs-datastore/pull/272"},"issue":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/issues/272"},"comments":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/nodejs-datastore/statuses/761261e3842891ac03b17bc36328ef96736f4052"}},"author_association":"NONE"}}
{"actor":{"display_login":"JustinBeckwith"}}