{"action":"closed","number":2208,"pull_request":{"url":"https://api.github.com/repos/scionproto/scion/pulls/2208","id":236781972,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NzgxOTcy","html_url":"https://github.com/scionproto/scion/pull/2208","diff_url":"https://github.com/scionproto/scion/pull/2208.diff","patch_url":"https://github.com/scionproto/scion/pull/2208.patch","issue_url":"https://api.github.com/repos/scionproto/scion/issues/2208","number":2208,"state":"closed","locked":false,"title":"Use fatal library in path_srv, cert_srv and sciond","user":{"login":"sustrik","id":305718,"node_id":"MDQ6VXNlcjMwNTcxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/305718?v=4","gravatar_id":"","url":"https://api.github.com/users/sustrik","html_url":"https://github.com/sustrik","followers_url":"https://api.github.com/users/sustrik/followers","following_url":"https://api.github.com/users/sustrik/following{/other_user}","gists_url":"https://api.github.com/users/sustrik/gists{/gist_id}","starred_url":"https://api.github.com/users/sustrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sustrik/subscriptions","organizations_url":"https://api.github.com/users/sustrik/orgs","repos_url":"https://api.github.com/users/sustrik/repos","events_url":"https://api.github.com/users/sustrik/events{/privacy}","received_events_url":"https://api.github.com/users/sustrik/received_events","type":"User","site_admin":false},"body":"This patch also moves logging the fatal condition into the failing\r\ngoroutine and makes servers wait for 1 second before exiting. This\r\nway we can collect multiple fatal errors in the log in case the\r\nfirst one is not the most informative one.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/scionproto/scion/2208)\n<!-- Reviewable:end -->\n","created_at":"2018-12-07T07:53:34Z","updated_at":"2018-12-12T13:39:08Z","closed_at":"2018-12-12T13:39:08Z","merged_at":"2018-12-12T13:39:08Z","merge_commit_sha":"4164178b2657bfb64ae25ba11930e5428e031b54","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scionproto/scion/pulls/2208/commits","review_comments_url":"https://api.github.com/repos/scionproto/scion/pulls/2208/comments","review_comment_url":"https://api.github.com/repos/scionproto/scion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scionproto/scion/issues/2208/comments","statuses_url":"https://api.github.com/repos/scionproto/scion/statuses/2e44df363ee8e259d67f9aa079f32eb16675f42d","head":{"label":"sustrik:fatal","ref":"fatal","sha":"2e44df363ee8e259d67f9aa079f32eb16675f42d","user":{"login":"sustrik","id":305718,"node_id":"MDQ6VXNlcjMwNTcxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/305718?v=4","gravatar_id":"","url":"https://api.github.com/users/sustrik","html_url":"https://github.com/sustrik","followers_url":"https://api.github.com/users/sustrik/followers","following_url":"https://api.github.com/users/sustrik/following{/other_user}","gists_url":"https://api.github.com/users/sustrik/gists{/gist_id}","starred_url":"https://api.github.com/users/sustrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sustrik/subscriptions","organizations_url":"https://api.github.com/users/sustrik/orgs","repos_url":"https://api.github.com/users/sustrik/repos","events_url":"https://api.github.com/users/sustrik/events{/privacy}","received_events_url":"https://api.github.com/users/sustrik/received_events","type":"User","site_admin":false},"repo":{"id":156349337,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYzNDkzMzc=","name":"scion","full_name":"sustrik/scion","private":false,"owner":{"login":"sustrik","id":305718,"node_id":"MDQ6VXNlcjMwNTcxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/305718?v=4","gravatar_id":"","url":"https://api.github.com/users/sustrik","html_url":"https://github.com/sustrik","followers_url":"https://api.github.com/users/sustrik/followers","following_url":"https://api.github.com/users/sustrik/following{/other_user}","gists_url":"https://api.github.com/users/sustrik/gists{/gist_id}","starred_url":"https://api.github.com/users/sustrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sustrik/subscriptions","organizations_url":"https://api.github.com/users/sustrik/orgs","repos_url":"https://api.github.com/users/sustrik/repos","events_url":"https://api.github.com/users/sustrik/events{/privacy}","received_events_url":"https://api.github.com/users/sustrik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sustrik/scion","description":"SCION Internet Architecture","fork":true,"url":"https://api.github.com/repos/sustrik/scion","forks_url":"https://api.github.com/repos/sustrik/scion/forks","keys_url":"https://api.github.com/repos/sustrik/scion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sustrik/scion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sustrik/scion/teams","hooks_url":"https://api.github.com/repos/sustrik/scion/hooks","issue_events_url":"https://api.github.com/repos/sustrik/scion/issues/events{/number}","events_url":"https://api.github.com/repos/sustrik/scion/events","assignees_url":"https://api.github.com/repos/sustrik/scion/assignees{/user}","branches_url":"https://api.github.com/repos/sustrik/scion/branches{/branch}","tags_url":"https://api.github.com/repos/sustrik/scion/tags","blobs_url":"https://api.github.com/repos/sustrik/scion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sustrik/scion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sustrik/scion/git/refs{/sha}","trees_url":"https://api.github.com/repos/sustrik/scion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sustrik/scion/statuses/{sha}","languages_url":"https://api.github.com/repos/sustrik/scion/languages","stargazers_url":"https://api.github.com/repos/sustrik/scion/stargazers","contributors_url":"https://api.github.com/repos/sustrik/scion/contributors","subscribers_url":"https://api.github.com/repos/sustrik/scion/subscribers","subscription_url":"https://api.github.com/repos/sustrik/scion/subscription","commits_url":"https://api.github.com/repos/sustrik/scion/commits{/sha}","git_commits_url":"https://api.github.com/repos/sustrik/scion/git/commits{/sha}","comments_url":"https://api.github.com/repos/sustrik/scion/comments{/number}","issue_comment_url":"https://api.github.com/repos/sustrik/scion/issues/comments{/number}","contents_url":"https://api.github.com/repos/sustrik/scion/contents/{+path}","compare_url":"https://api.github.com/repos/sustrik/scion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sustrik/scion/merges","archive_url":"https://api.github.com/repos/sustrik/scion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sustrik/scion/downloads","issues_url":"https://api.github.com/repos/sustrik/scion/issues{/number}","pulls_url":"https://api.github.com/repos/sustrik/scion/pulls{/number}","milestones_url":"https://api.github.com/repos/sustrik/scion/milestones{/number}","notifications_url":"https://api.github.com/repos/sustrik/scion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sustrik/scion/labels{/name}","releases_url":"https://api.github.com/repos/sustrik/scion/releases{/id}","deployments_url":"https://api.github.com/repos/sustrik/scion/deployments","created_at":"2018-11-06T08:16:19Z","updated_at":"2018-12-12T09:03:19Z","pushed_at":"2018-12-12T12:54:02Z","git_url":"git://github.com/sustrik/scion.git","ssh_url":"git@github.com:sustrik/scion.git","clone_url":"https://github.com/sustrik/scion.git","svn_url":"https://github.com/sustrik/scion","homepage":"https://www.scion-architecture.net/","size":25974,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scionproto:master","ref":"master","sha":"1ab44bf9faa322ee69c3f9d6e6b43538b4872f31","user":{"login":"scionproto","id":34136243,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTM2MjQz","avatar_url":"https://avatars1.githubusercontent.com/u/34136243?v=4","gravatar_id":"","url":"https://api.github.com/users/scionproto","html_url":"https://github.com/scionproto","followers_url":"https://api.github.com/users/scionproto/followers","following_url":"https://api.github.com/users/scionproto/following{/other_user}","gists_url":"https://api.github.com/users/scionproto/gists{/gist_id}","starred_url":"https://api.github.com/users/scionproto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scionproto/subscriptions","organizations_url":"https://api.github.com/users/scionproto/orgs","repos_url":"https://api.github.com/users/scionproto/repos","events_url":"https://api.github.com/users/scionproto/events{/privacy}","received_events_url":"https://api.github.com/users/scionproto/received_events","type":"Organization","site_admin":false},"repo":{"id":21826148,"node_id":"MDEwOlJlcG9zaXRvcnkyMTgyNjE0OA==","name":"scion","full_name":"scionproto/scion","private":false,"owner":{"login":"scionproto","id":34136243,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTM2MjQz","avatar_url":"https://avatars1.githubusercontent.com/u/34136243?v=4","gravatar_id":"","url":"https://api.github.com/users/scionproto","html_url":"https://github.com/scionproto","followers_url":"https://api.github.com/users/scionproto/followers","following_url":"https://api.github.com/users/scionproto/following{/other_user}","gists_url":"https://api.github.com/users/scionproto/gists{/gist_id}","starred_url":"https://api.github.com/users/scionproto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scionproto/subscriptions","organizations_url":"https://api.github.com/users/scionproto/orgs","repos_url":"https://api.github.com/users/scionproto/repos","events_url":"https://api.github.com/users/scionproto/events{/privacy}","received_events_url":"https://api.github.com/users/scionproto/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scionproto/scion","description":"SCION Internet Architecture","fork":false,"url":"https://api.github.com/repos/scionproto/scion","forks_url":"https://api.github.com/repos/scionproto/scion/forks","keys_url":"https://api.github.com/repos/scionproto/scion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scionproto/scion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scionproto/scion/teams","hooks_url":"https://api.github.com/repos/scionproto/scion/hooks","issue_events_url":"https://api.github.com/repos/scionproto/scion/issues/events{/number}","events_url":"https://api.github.com/repos/scionproto/scion/events","assignees_url":"https://api.github.com/repos/scionproto/scion/assignees{/user}","branches_url":"https://api.github.com/repos/scionproto/scion/branches{/branch}","tags_url":"https://api.github.com/repos/scionproto/scion/tags","blobs_url":"https://api.github.com/repos/scionproto/scion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scionproto/scion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scionproto/scion/git/refs{/sha}","trees_url":"https://api.github.com/repos/scionproto/scion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scionproto/scion/statuses/{sha}","languages_url":"https://api.github.com/repos/scionproto/scion/languages","stargazers_url":"https://api.github.com/repos/scionproto/scion/stargazers","contributors_url":"https://api.github.com/repos/scionproto/scion/contributors","subscribers_url":"https://api.github.com/repos/scionproto/scion/subscribers","subscription_url":"https://api.github.com/repos/scionproto/scion/subscription","commits_url":"https://api.github.com/repos/scionproto/scion/commits{/sha}","git_commits_url":"https://api.github.com/repos/scionproto/scion/git/commits{/sha}","comments_url":"https://api.github.com/repos/scionproto/scion/comments{/number}","issue_comment_url":"https://api.github.com/repos/scionproto/scion/issues/comments{/number}","contents_url":"https://api.github.com/repos/scionproto/scion/contents/{+path}","compare_url":"https://api.github.com/repos/scionproto/scion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scionproto/scion/merges","archive_url":"https://api.github.com/repos/scionproto/scion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scionproto/scion/downloads","issues_url":"https://api.github.com/repos/scionproto/scion/issues{/number}","pulls_url":"https://api.github.com/repos/scionproto/scion/pulls{/number}","milestones_url":"https://api.github.com/repos/scionproto/scion/milestones{/number}","notifications_url":"https://api.github.com/repos/scionproto/scion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scionproto/scion/labels{/name}","releases_url":"https://api.github.com/repos/scionproto/scion/releases{/id}","deployments_url":"https://api.github.com/repos/scionproto/scion/deployments","created_at":"2014-07-14T16:11:02Z","updated_at":"2018-12-11T16:29:07Z","pushed_at":"2018-12-12T13:39:08Z","git_url":"git://github.com/scionproto/scion.git","ssh_url":"git@github.com:scionproto/scion.git","clone_url":"https://github.com/scionproto/scion.git","svn_url":"https://github.com/scionproto/scion","homepage":"https://www.scion-architecture.net/","size":49170,"stargazers_count":97,"watchers_count":97,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":201,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":50,"open_issues":201,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scionproto/scion/pulls/2208"},"html":{"href":"https://github.com/scionproto/scion/pull/2208"},"issue":{"href":"https://api.github.com/repos/scionproto/scion/issues/2208"},"comments":{"href":"https://api.github.com/repos/scionproto/scion/issues/2208/comments"},"review_comments":{"href":"https://api.github.com/repos/scionproto/scion/pulls/2208/comments"},"review_comment":{"href":"https://api.github.com/repos/scionproto/scion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scionproto/scion/pulls/2208/commits"},"statuses":{"href":"https://api.github.com/repos/scionproto/scion/statuses/2e44df363ee8e259d67f9aa079f32eb16675f42d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sustrik","id":305718,"node_id":"MDQ6VXNlcjMwNTcxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/305718?v=4","gravatar_id":"","url":"https://api.github.com/users/sustrik","html_url":"https://github.com/sustrik","followers_url":"https://api.github.com/users/sustrik/followers","following_url":"https://api.github.com/users/sustrik/following{/other_user}","gists_url":"https://api.github.com/users/sustrik/gists{/gist_id}","starred_url":"https://api.github.com/users/sustrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sustrik/subscriptions","organizations_url":"https://api.github.com/users/sustrik/orgs","repos_url":"https://api.github.com/users/sustrik/repos","events_url":"https://api.github.com/users/sustrik/events{/privacy}","received_events_url":"https://api.github.com/users/sustrik/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":72,"deletions":44,"changed_files":8}}
{"actor":{"display_login":"sustrik"}}