{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls/comments/193497898","pull_request_review_id":126481584,"id":193497898,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQ5Nzg5OA==","diff_hunk":"@@ -32,7 +32,7 @@ func makeLocations(cdn string, db *sql.DB) (map[string]tc.CRConfigLatitudeLongit\n \n \t// TODO test whether it's faster to do a single query, joining lat/lon into servers\n \tq := `\n-select cg.name, t.name as type, cg.latitude, cg.longitude from cachegroup as cg\n+select cg.name, cg.id, t.name as type, cg.latitude, cg.longitude from cachegroup as cg","path":"traffic_ops/traffic_ops_golang/crconfig/edgelocations.go","position":5,"original_position":5,"commit_id":"5f6524498b740ddba011155355a6b1fb5b0fdb69","original_commit_id":"5f6524498b740ddba011155355a6b1fb5b0fdb69","user":{"login":"rawlinp","id":6724053,"node_id":"MDQ6VXNlcjY3MjQwNTM=","avatar_url":"https://avatars2.githubusercontent.com/u/6724053?v=4","gravatar_id":"","url":"https://api.github.com/users/rawlinp","html_url":"https://github.com/rawlinp","followers_url":"https://api.github.com/users/rawlinp/followers","following_url":"https://api.github.com/users/rawlinp/following{/other_user}","gists_url":"https://api.github.com/users/rawlinp/gists{/gist_id}","starred_url":"https://api.github.com/users/rawlinp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawlinp/subscriptions","organizations_url":"https://api.github.com/users/rawlinp/orgs","repos_url":"https://api.github.com/users/rawlinp/repos","events_url":"https://api.github.com/users/rawlinp/events{/privacy}","received_events_url":"https://api.github.com/users/rawlinp/received_events","type":"User","site_admin":false},"body":"You need to select cg.fallback_to_closest here and scan the value into a `var fallbackToClosest *bool`. If it's null, set `BackupLocations.FallbackToClosest` below to false. Otherwise, set it to the dereferenced value.\r\n\r\nAlso, I noticed the CRConfig generated sets the value of `fallbackToClosest` to a string rather than a boolean. Since booleans are an actual type in Go, I'm thinking we should set the values to booleans rather than strings and make sure Traffic Router handles that properly.","created_at":"2018-06-06T17:40:33Z","updated_at":"2018-06-06T17:45:33Z","html_url":"https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r193497898","pull_request_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls/2029","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls/comments/193497898"},"html":{"href":"https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r193497898"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls/2029"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls/2029","id":176600773,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc2NjAwNzcz","html_url":"https://github.com/apache/incubator-trafficcontrol/pull/2029","diff_url":"https://github.com/apache/incubator-trafficcontrol/pull/2029.diff","patch_url":"https://github.com/apache/incubator-trafficcontrol/pull/2029.patch","issue_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/issues/2029","number":2029,"state":"open","locked":false,"title":"[Issue 1907] TO API for backup edge cachegroup","user":{"login":"Vijay-1","id":14352008,"node_id":"MDQ6VXNlcjE0MzUyMDA4","avatar_url":"https://avatars1.githubusercontent.com/u/14352008?v=4","gravatar_id":"","url":"https://api.github.com/users/Vijay-1","html_url":"https://github.com/Vijay-1","followers_url":"https://api.github.com/users/Vijay-1/followers","following_url":"https://api.github.com/users/Vijay-1/following{/other_user}","gists_url":"https://api.github.com/users/Vijay-1/gists{/gist_id}","starred_url":"https://api.github.com/users/Vijay-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vijay-1/subscriptions","organizations_url":"https://api.github.com/users/Vijay-1/orgs","repos_url":"https://api.github.com/users/Vijay-1/repos","events_url":"https://api.github.com/users/Vijay-1/events{/privacy}","received_events_url":"https://api.github.com/users/Vijay-1/received_events","type":"User","site_admin":false},"body":"[Issue 1907] Backup edge cache group TO API / TR cr-config changes\r\n\r\nhttps://github.com/apache/incubator-trafficcontrol/issues/1907\r\n\r\nContains the following changes:\r\nTraffic Router - Backup edge configuration parsing and decision making code changes\r\nTraffic Ops - Mojolicious Perl CRUD APIs\r\n\r\nThis is the initial version of code. Only minimal testing has been done. Will run more cases and update. Hosting it in advance to get review comments :-)","created_at":"2018-03-21T20:29:42Z","updated_at":"2018-06-06T17:45:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1a0127d00b5a73414719b754a4c05ea5bda3761","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":678937359,"node_id":"MDU6TGFiZWw2Nzg5MzczNTk=","url":"https://api.github.com/repos/apache/incubator-trafficcontrol/labels/Traffic%20Ops%20API","name":"Traffic Ops API","color":"808080","default":false},{"id":675814956,"node_id":"MDU6TGFiZWw2NzU4MTQ5NTY=","url":"https://api.github.com/repos/apache/incubator-trafficcontrol/labels/Traffic%20Router","name":"Traffic Router","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls/2029/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls/2029/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/issues/2029/comments","statuses_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/statuses/5f6524498b740ddba011155355a6b1fb5b0fdb69","head":{"label":"Vijay-1:cachegroup-failover","ref":"cachegroup-failover","sha":"5f6524498b740ddba011155355a6b1fb5b0fdb69","user":{"login":"Vijay-1","id":14352008,"node_id":"MDQ6VXNlcjE0MzUyMDA4","avatar_url":"https://avatars1.githubusercontent.com/u/14352008?v=4","gravatar_id":"","url":"https://api.github.com/users/Vijay-1","html_url":"https://github.com/Vijay-1","followers_url":"https://api.github.com/users/Vijay-1/followers","following_url":"https://api.github.com/users/Vijay-1/following{/other_user}","gists_url":"https://api.github.com/users/Vijay-1/gists{/gist_id}","starred_url":"https://api.github.com/users/Vijay-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vijay-1/subscriptions","organizations_url":"https://api.github.com/users/Vijay-1/orgs","repos_url":"https://api.github.com/users/Vijay-1/repos","events_url":"https://api.github.com/users/Vijay-1/events{/privacy}","received_events_url":"https://api.github.com/users/Vijay-1/received_events","type":"User","site_admin":false},"repo":{"id":126173046,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxNzMwNDY=","name":"incubator-trafficcontrol","full_name":"Vijay-1/incubator-trafficcontrol","owner":{"login":"Vijay-1","id":14352008,"node_id":"MDQ6VXNlcjE0MzUyMDA4","avatar_url":"https://avatars1.githubusercontent.com/u/14352008?v=4","gravatar_id":"","url":"https://api.github.com/users/Vijay-1","html_url":"https://github.com/Vijay-1","followers_url":"https://api.github.com/users/Vijay-1/followers","following_url":"https://api.github.com/users/Vijay-1/following{/other_user}","gists_url":"https://api.github.com/users/Vijay-1/gists{/gist_id}","starred_url":"https://api.github.com/users/Vijay-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vijay-1/subscriptions","organizations_url":"https://api.github.com/users/Vijay-1/orgs","repos_url":"https://api.github.com/users/Vijay-1/repos","events_url":"https://api.github.com/users/Vijay-1/events{/privacy}","received_events_url":"https://api.github.com/users/Vijay-1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vijay-1/incubator-trafficcontrol","description":"Mirror of Apache Traffic Control (incubating)","fork":true,"url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol","forks_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/forks","keys_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/teams","hooks_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/hooks","issue_events_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/events","assignees_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/tags","blobs_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/languages","stargazers_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/stargazers","contributors_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/contributors","subscribers_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/subscribers","subscription_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/subscription","commits_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/merges","archive_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/downloads","issues_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/labels{/name}","releases_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/releases{/id}","deployments_url":"https://api.github.com/repos/Vijay-1/incubator-trafficcontrol/deployments","created_at":"2018-03-21T12:09:16Z","updated_at":"2018-03-21T12:09:25Z","pushed_at":"2018-06-01T15:48:42Z","git_url":"git://github.com/Vijay-1/incubator-trafficcontrol.git","ssh_url":"git@github.com:Vijay-1/incubator-trafficcontrol.git","clone_url":"https://github.com/Vijay-1/incubator-trafficcontrol.git","svn_url":"https://github.com/Vijay-1/incubator-trafficcontrol","homepage":null,"size":72384,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8e4b8fe720a666e9bcde34444166db32327dbeb1","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":67198520,"node_id":"MDEwOlJlcG9zaXRvcnk2NzE5ODUyMA==","name":"incubator-trafficcontrol","full_name":"apache/incubator-trafficcontrol","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-trafficcontrol","description":"Mirror of Apache Traffic Control (incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-trafficcontrol","forks_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/forks","keys_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/teams","hooks_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/events","assignees_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/tags","blobs_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/subscription","commits_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/merges","archive_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/downloads","issues_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-trafficcontrol/deployments","created_at":"2016-09-02T07:00:06Z","updated_at":"2018-06-06T14:12:13Z","pushed_at":"2018-06-06T14:23:04Z","git_url":"git://github.com/apache/incubator-trafficcontrol.git","ssh_url":"git@github.com:apache/incubator-trafficcontrol.git","clone_url":"https://github.com/apache/incubator-trafficcontrol.git","svn_url":"https://github.com/apache/incubator-trafficcontrol","homepage":null,"size":74428,"stargazers_count":163,"watchers_count":163,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":460,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":112,"open_issues":460,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls/2029"},"html":{"href":"https://github.com/apache/incubator-trafficcontrol/pull/2029"},"issue":{"href":"https://api.github.com/repos/apache/incubator-trafficcontrol/issues/2029"},"comments":{"href":"https://api.github.com/repos/apache/incubator-trafficcontrol/issues/2029/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls/2029/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-trafficcontrol/pulls/2029/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-trafficcontrol/statuses/5f6524498b740ddba011155355a6b1fb5b0fdb69"}},"author_association":"NONE"}}
{"actor":{"display_login":"rawlinp"}}