{"action":"created","issue":{"url":"https://api.github.com/repos/mangoszero/server/issues/62","repository_url":"https://api.github.com/repos/mangoszero/server","labels_url":"https://api.github.com/repos/mangoszero/server/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/mangoszero/server/issues/62/comments","events_url":"https://api.github.com/repos/mangoszero/server/issues/62/events","html_url":"https://github.com/mangoszero/server/pull/62","id":285165281,"number":62,"title":"[Patch] Add Support Intel Parallel Studio XE 2018","user":{"login":"evacomaroski","id":6966515,"avatar_url":"https://avatars1.githubusercontent.com/u/6966515?v=4","gravatar_id":"","url":"https://api.github.com/users/evacomaroski","html_url":"https://github.com/evacomaroski","followers_url":"https://api.github.com/users/evacomaroski/followers","following_url":"https://api.github.com/users/evacomaroski/following{/other_user}","gists_url":"https://api.github.com/users/evacomaroski/gists{/gist_id}","starred_url":"https://api.github.com/users/evacomaroski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evacomaroski/subscriptions","organizations_url":"https://api.github.com/users/evacomaroski/orgs","repos_url":"https://api.github.com/users/evacomaroski/repos","events_url":"https://api.github.com/users/evacomaroski/events{/privacy}","received_events_url":"https://api.github.com/users/evacomaroski/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-12-29T22:43:22Z","updated_at":"2018-03-29T14:01:04Z","closed_at":"2018-03-29T14:01:04Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mangoszero/server/pulls/62","html_url":"https://github.com/mangoszero/server/pull/62","diff_url":"https://github.com/mangoszero/server/pull/62.diff","patch_url":"https://github.com/mangoszero/server/pull/62.patch"},"body":"Hello!\r\n\r\nThe following changes add support for compiling mangos zero with Intel Parallel Studio XE (2018). Roughly, the changes include adding some extra includes and creating a branch for `COMPILER_INTEL` that checks for major version 18 (version 18.0.1 was used) and beyond.\r\n    \r\nConcerning, the compiler branching, I have decided to branch instead of replacing the existing code for the Intel Compiler because it is not clear whether this change applies universally to all compilers or not - however, I would like to note that `std::hash_map` and `std::hash_set` are not ubiquitous and that the standard would imply that `std::unordered_map` and `std::unordered_set` should be used instead. If I understand the C++ implementation correctly, an unordered map/set is equivalent to a hash map/set: if needed, and someone has the capability to verify, the entire Intel branching could be replaced later to make the compilation succeed for all Intel compilers.\r\n    \r\nRegarding the results, the following commands, executed in the server source directory:\r\n    \r\n```\r\nmkdir build\r\n. /opt/intel/bin/compilervars.sh intel64\r\ncmake ../ -DCMAKE_INSTALL_PREFIX=/home/mangos/zero -DBUILD_TOOLS=1 -DCMAKE_C_COMPILER=icc -DCMAKE_CXX_COMPILER=icpc -DSCRIPT_LIB_ELUNA=1 -DSCRIPT_LIB_SD3=1\r\nmake\r\n```\r\n\r\nyielded a successful compilation, including the compilation of the map extraction tools. Unfortunately, to get the playerbots working as well, further and, apparently, more intrusive changes are needed. It may require some rewrites and I would gladly yield that task to the creator and would not like to step on anyone's toes - playerbots are not used on our shard. In case there is interest, I could gladly create a separate pull request and attempt to make the playbots code compile under the Intel compiler as well.\r\n\r\nThe patch requires an additional modification to be made to ScriptDev3 (another include has to be added), for which a pull request has already been made: mangos/ScriptDev3#71 \r\n    \r\nIf useful, please apply.\r\n    \r\nRegards,\r\nEva"},"comment":{"url":"https://api.github.com/repos/mangoszero/server/issues/comments/377244609","html_url":"https://github.com/mangoszero/server/pull/62#issuecomment-377244609","issue_url":"https://api.github.com/repos/mangoszero/server/issues/62","id":377244609,"user":{"login":"H0zen","id":10201568,"avatar_url":"https://avatars3.githubusercontent.com/u/10201568?v=4","gravatar_id":"","url":"https://api.github.com/users/H0zen","html_url":"https://github.com/H0zen","followers_url":"https://api.github.com/users/H0zen/followers","following_url":"https://api.github.com/users/H0zen/following{/other_user}","gists_url":"https://api.github.com/users/H0zen/gists{/gist_id}","starred_url":"https://api.github.com/users/H0zen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/H0zen/subscriptions","organizations_url":"https://api.github.com/users/H0zen/orgs","repos_url":"https://api.github.com/users/H0zen/repos","events_url":"https://api.github.com/users/H0zen/events{/privacy}","received_events_url":"https://api.github.com/users/H0zen/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T14:01:04Z","updated_at":"2018-03-29T14:01:04Z","author_association":"COLLABORATOR","body":"All changes are now part of master banch. Thank you!"}}
{"actor":{"display_login":"H0zen"}}