{"action":"created","comment":{"url":"https://api.github.com/repos/square/okhttp/pulls/comments/197622103","pull_request_review_id":131405164,"id":197622103,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzYyMjEwMw==","diff_hunk":"@@ -0,0 +1,57 @@\n+/*\n+ * Copyright (C) 2014 Square, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package okhttp3.dnsoverhttps;\n+\n+import java.util.Arrays;\n+import java.util.Collections;\n+import java.util.List;\n+\n+import static okhttp3.dnsoverhttps.DnsOverHttps.isPrivateHost;\n+\n+/**\n+ * A strategy for handling DNS lookup failures for DNS over HTTPS.\n+ */\n+public interface DnsFallbackStrategy {","path":"okhttp-dnsoverhttps/src/main/java/okhttp3/dnsoverhttps/DnsFallbackStrategy.java","position":null,"original_position":27,"commit_id":"782940612d10c3025222a0b7e8895514f4d7d06e","original_commit_id":"d1ad6c432f83a3dd6f894af6ec9c268feddc829b","user":{"login":"yschimke","id":231923,"node_id":"MDQ6VXNlcjIzMTkyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/231923?v=4","gravatar_id":"","url":"https://api.github.com/users/yschimke","html_url":"https://github.com/yschimke","followers_url":"https://api.github.com/users/yschimke/followers","following_url":"https://api.github.com/users/yschimke/following{/other_user}","gists_url":"https://api.github.com/users/yschimke/gists{/gist_id}","starred_url":"https://api.github.com/users/yschimke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yschimke/subscriptions","organizations_url":"https://api.github.com/users/yschimke/orgs","repos_url":"https://api.github.com/users/yschimke/repos","events_url":"https://api.github.com/users/yschimke/events{/privacy}","received_events_url":"https://api.github.com/users/yschimke/received_events","type":"User","site_admin":false},"body":"removed any notion of fallback for now, we aren't firefox, we don't need to *just* work for anything the user types in.  So supporting only the default happy path is reasonable for a mobile client, and probably better than a choose your own adventure of different strategies that may ultimately leak DNS traffic in response to a DOS attack.","created_at":"2018-06-23T20:41:09Z","updated_at":"2018-06-23T20:41:10Z","html_url":"https://github.com/square/okhttp/pull/3972#discussion_r197622103","pull_request_url":"https://api.github.com/repos/square/okhttp/pulls/3972","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/square/okhttp/pulls/comments/197622103"},"html":{"href":"https://github.com/square/okhttp/pull/3972#discussion_r197622103"},"pull_request":{"href":"https://api.github.com/repos/square/okhttp/pulls/3972"}},"in_reply_to_id":196622198},"pull_request":{"url":"https://api.github.com/repos/square/okhttp/pulls/3972","id":182672652,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgyNjcyNjUy","html_url":"https://github.com/square/okhttp/pull/3972","diff_url":"https://github.com/square/okhttp/pull/3972.diff","patch_url":"https://github.com/square/okhttp/pull/3972.patch","issue_url":"https://api.github.com/repos/square/okhttp/issues/3972","number":3972,"state":"open","locked":false,"title":"DNS over HTTPS","user":{"login":"yschimke","id":231923,"node_id":"MDQ6VXNlcjIzMTkyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/231923?v=4","gravatar_id":"","url":"https://api.github.com/users/yschimke","html_url":"https://github.com/yschimke","followers_url":"https://api.github.com/users/yschimke/followers","following_url":"https://api.github.com/users/yschimke/following{/other_user}","gists_url":"https://api.github.com/users/yschimke/gists{/gist_id}","starred_url":"https://api.github.com/users/yschimke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yschimke/subscriptions","organizations_url":"https://api.github.com/users/yschimke/orgs","repos_url":"https://api.github.com/users/yschimke/repos","events_url":"https://api.github.com/users/yschimke/events{/privacy}","received_events_url":"https://api.github.com/users/yschimke/received_events","type":"User","site_admin":false},"body":"DNS over HTTPS DRAFT-11 implementation\r\n\r\nhttps://github.com/square/okhttp/issues/3969\r\nhttps://tools.ietf.org/html/draft-ietf-doh-dns-over-https-11","created_at":"2018-04-19T05:53:36Z","updated_at":"2018-06-23T20:41:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71a223dd41d2d63b1936632e91d8f712a535c95f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/square/okhttp/pulls/3972/commits","review_comments_url":"https://api.github.com/repos/square/okhttp/pulls/3972/comments","review_comment_url":"https://api.github.com/repos/square/okhttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/okhttp/issues/3972/comments","statuses_url":"https://api.github.com/repos/square/okhttp/statuses/782940612d10c3025222a0b7e8895514f4d7d06e","head":{"label":"yschimke:dnsoverhttps","ref":"dnsoverhttps","sha":"782940612d10c3025222a0b7e8895514f4d7d06e","user":{"login":"yschimke","id":231923,"node_id":"MDQ6VXNlcjIzMTkyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/231923?v=4","gravatar_id":"","url":"https://api.github.com/users/yschimke","html_url":"https://github.com/yschimke","followers_url":"https://api.github.com/users/yschimke/followers","following_url":"https://api.github.com/users/yschimke/following{/other_user}","gists_url":"https://api.github.com/users/yschimke/gists{/gist_id}","starred_url":"https://api.github.com/users/yschimke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yschimke/subscriptions","organizations_url":"https://api.github.com/users/yschimke/orgs","repos_url":"https://api.github.com/users/yschimke/repos","events_url":"https://api.github.com/users/yschimke/events{/privacy}","received_events_url":"https://api.github.com/users/yschimke/received_events","type":"User","site_admin":false},"repo":{"id":42286486,"node_id":"MDEwOlJlcG9zaXRvcnk0MjI4NjQ4Ng==","name":"okhttp","full_name":"yschimke/okhttp","owner":{"login":"yschimke","id":231923,"node_id":"MDQ6VXNlcjIzMTkyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/231923?v=4","gravatar_id":"","url":"https://api.github.com/users/yschimke","html_url":"https://github.com/yschimke","followers_url":"https://api.github.com/users/yschimke/followers","following_url":"https://api.github.com/users/yschimke/following{/other_user}","gists_url":"https://api.github.com/users/yschimke/gists{/gist_id}","starred_url":"https://api.github.com/users/yschimke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yschimke/subscriptions","organizations_url":"https://api.github.com/users/yschimke/orgs","repos_url":"https://api.github.com/users/yschimke/repos","events_url":"https://api.github.com/users/yschimke/events{/privacy}","received_events_url":"https://api.github.com/users/yschimke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yschimke/okhttp","description":"An HTTP+SPDY client for Android and Java applications.","fork":true,"url":"https://api.github.com/repos/yschimke/okhttp","forks_url":"https://api.github.com/repos/yschimke/okhttp/forks","keys_url":"https://api.github.com/repos/yschimke/okhttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yschimke/okhttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yschimke/okhttp/teams","hooks_url":"https://api.github.com/repos/yschimke/okhttp/hooks","issue_events_url":"https://api.github.com/repos/yschimke/okhttp/issues/events{/number}","events_url":"https://api.github.com/repos/yschimke/okhttp/events","assignees_url":"https://api.github.com/repos/yschimke/okhttp/assignees{/user}","branches_url":"https://api.github.com/repos/yschimke/okhttp/branches{/branch}","tags_url":"https://api.github.com/repos/yschimke/okhttp/tags","blobs_url":"https://api.github.com/repos/yschimke/okhttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yschimke/okhttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yschimke/okhttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/yschimke/okhttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yschimke/okhttp/statuses/{sha}","languages_url":"https://api.github.com/repos/yschimke/okhttp/languages","stargazers_url":"https://api.github.com/repos/yschimke/okhttp/stargazers","contributors_url":"https://api.github.com/repos/yschimke/okhttp/contributors","subscribers_url":"https://api.github.com/repos/yschimke/okhttp/subscribers","subscription_url":"https://api.github.com/repos/yschimke/okhttp/subscription","commits_url":"https://api.github.com/repos/yschimke/okhttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/yschimke/okhttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/yschimke/okhttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/yschimke/okhttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/yschimke/okhttp/contents/{+path}","compare_url":"https://api.github.com/repos/yschimke/okhttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yschimke/okhttp/merges","archive_url":"https://api.github.com/repos/yschimke/okhttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yschimke/okhttp/downloads","issues_url":"https://api.github.com/repos/yschimke/okhttp/issues{/number}","pulls_url":"https://api.github.com/repos/yschimke/okhttp/pulls{/number}","milestones_url":"https://api.github.com/repos/yschimke/okhttp/milestones{/number}","notifications_url":"https://api.github.com/repos/yschimke/okhttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yschimke/okhttp/labels{/name}","releases_url":"https://api.github.com/repos/yschimke/okhttp/releases{/id}","deployments_url":"https://api.github.com/repos/yschimke/okhttp/deployments","created_at":"2015-09-11T03:55:14Z","updated_at":"2016-04-20T05:51:09Z","pushed_at":"2018-06-23T20:39:15Z","git_url":"git://github.com/yschimke/okhttp.git","ssh_url":"git@github.com:yschimke/okhttp.git","clone_url":"https://github.com/yschimke/okhttp.git","svn_url":"https://github.com/yschimke/okhttp","homepage":"http://square.github.io/okhttp/","size":11713,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"f6502e89f9bb96c4b76800c5245170a76b60e60c","user":{"login":"square","id":82592,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTky","avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":5152285,"node_id":"MDEwOlJlcG9zaXRvcnk1MTUyMjg1","name":"okhttp","full_name":"square/okhttp","owner":{"login":"square","id":82592,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTky","avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/okhttp","description":"An HTTP+HTTP/2 client for Android and Java applications.","fork":false,"url":"https://api.github.com/repos/square/okhttp","forks_url":"https://api.github.com/repos/square/okhttp/forks","keys_url":"https://api.github.com/repos/square/okhttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/okhttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/okhttp/teams","hooks_url":"https://api.github.com/repos/square/okhttp/hooks","issue_events_url":"https://api.github.com/repos/square/okhttp/issues/events{/number}","events_url":"https://api.github.com/repos/square/okhttp/events","assignees_url":"https://api.github.com/repos/square/okhttp/assignees{/user}","branches_url":"https://api.github.com/repos/square/okhttp/branches{/branch}","tags_url":"https://api.github.com/repos/square/okhttp/tags","blobs_url":"https://api.github.com/repos/square/okhttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/okhttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/okhttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/okhttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/okhttp/statuses/{sha}","languages_url":"https://api.github.com/repos/square/okhttp/languages","stargazers_url":"https://api.github.com/repos/square/okhttp/stargazers","contributors_url":"https://api.github.com/repos/square/okhttp/contributors","subscribers_url":"https://api.github.com/repos/square/okhttp/subscribers","subscription_url":"https://api.github.com/repos/square/okhttp/subscription","commits_url":"https://api.github.com/repos/square/okhttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/okhttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/okhttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/okhttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/okhttp/contents/{+path}","compare_url":"https://api.github.com/repos/square/okhttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/okhttp/merges","archive_url":"https://api.github.com/repos/square/okhttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/okhttp/downloads","issues_url":"https://api.github.com/repos/square/okhttp/issues{/number}","pulls_url":"https://api.github.com/repos/square/okhttp/pulls{/number}","milestones_url":"https://api.github.com/repos/square/okhttp/milestones{/number}","notifications_url":"https://api.github.com/repos/square/okhttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/okhttp/labels{/name}","releases_url":"https://api.github.com/repos/square/okhttp/releases{/id}","deployments_url":"https://api.github.com/repos/square/okhttp/deployments","created_at":"2012-07-23T13:42:55Z","updated_at":"2018-06-23T20:22:26Z","pushed_at":"2018-06-23T20:39:17Z","git_url":"git://github.com/square/okhttp.git","ssh_url":"git@github.com:square/okhttp.git","clone_url":"https://github.com/square/okhttp.git","svn_url":"https://github.com/square/okhttp","homepage":"http://square.github.io/okhttp/","size":17296,"stargazers_count":27230,"watchers_count":27230,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6309,"mirror_url":null,"archived":false,"open_issues_count":148,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6309,"open_issues":148,"watchers":27230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/okhttp/pulls/3972"},"html":{"href":"https://github.com/square/okhttp/pull/3972"},"issue":{"href":"https://api.github.com/repos/square/okhttp/issues/3972"},"comments":{"href":"https://api.github.com/repos/square/okhttp/issues/3972/comments"},"review_comments":{"href":"https://api.github.com/repos/square/okhttp/pulls/3972/comments"},"review_comment":{"href":"https://api.github.com/repos/square/okhttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/okhttp/pulls/3972/commits"},"statuses":{"href":"https://api.github.com/repos/square/okhttp/statuses/782940612d10c3025222a0b7e8895514f4d7d06e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"yschimke"}}