{"action":"created","comment":{"url":"https://api.github.com/repos/bjornbytes/lovr/pulls/comments/233239336","pull_request_review_id":174608954,"id":233239336,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzIzOTMzNg==","diff_hunk":"@@ -263,7 +263,8 @@ static int l_lovrFilesystemMount(lua_State* L) {\n   const char* path = luaL_checkstring(L, 1);\n   const char* mountpoint = luaL_optstring(L, 2, NULL);\n   bool append = lua_isnoneornil(L, 3) ? 0 : lua_toboolean(L, 3);\n-  lua_pushboolean(L, !lovrFilesystemMount(path, mountpoint, append));\n+  const char* mountpointInner = luaL_optstring(L, 4, NULL);","path":"src/api/filesystem.c","position":5,"original_position":5,"commit_id":"2213b3bcfd0e9558fb63a21bd059f48cdff144e5","original_commit_id":"2213b3bcfd0e9558fb63a21bd059f48cdff144e5","user":{"login":"bjornbytes","id":784805,"node_id":"MDQ6VXNlcjc4NDgwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/784805?v=4","gravatar_id":"","url":"https://api.github.com/users/bjornbytes","html_url":"https://github.com/bjornbytes","followers_url":"https://api.github.com/users/bjornbytes/followers","following_url":"https://api.github.com/users/bjornbytes/following{/other_user}","gists_url":"https://api.github.com/users/bjornbytes/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornbytes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornbytes/subscriptions","organizations_url":"https://api.github.com/users/bjornbytes/orgs","repos_url":"https://api.github.com/users/bjornbytes/repos","events_url":"https://api.github.com/users/bjornbytes/events{/privacy}","received_events_url":"https://api.github.com/users/bjornbytes/received_events","type":"User","site_admin":false},"body":"minor: I think this would be easier to understand if it was named \"root\" (it seems to also match up with the PhysFS terminology).","created_at":"2018-11-13T22:02:40Z","updated_at":"2018-11-13T22:02:40Z","html_url":"https://github.com/bjornbytes/lovr/pull/71#discussion_r233239336","pull_request_url":"https://api.github.com/repos/bjornbytes/lovr/pulls/71","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bjornbytes/lovr/pulls/comments/233239336"},"html":{"href":"https://github.com/bjornbytes/lovr/pull/71#discussion_r233239336"},"pull_request":{"href":"https://api.github.com/repos/bjornbytes/lovr/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/bjornbytes/lovr/pulls/71","id":230632360,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjMyMzYw","html_url":"https://github.com/bjornbytes/lovr/pull/71","diff_url":"https://github.com/bjornbytes/lovr/pull/71.diff","patch_url":"https://github.com/bjornbytes/lovr/pull/71.patch","issue_url":"https://api.github.com/repos/bjornbytes/lovr/issues/71","number":71,"state":"open","locked":false,"title":"\"Fix\" arg standard and allow mounting inside a zip file","user":{"login":"mcclure","id":277318,"node_id":"MDQ6VXNlcjI3NzMxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/277318?v=4","gravatar_id":"","url":"https://api.github.com/users/mcclure","html_url":"https://github.com/mcclure","followers_url":"https://api.github.com/users/mcclure/followers","following_url":"https://api.github.com/users/mcclure/following{/other_user}","gists_url":"https://api.github.com/users/mcclure/gists{/gist_id}","starred_url":"https://api.github.com/users/mcclure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcclure/subscriptions","organizations_url":"https://api.github.com/users/mcclure/orgs","repos_url":"https://api.github.com/users/mcclure/repos","events_url":"https://api.github.com/users/mcclure/events{/privacy}","received_events_url":"https://api.github.com/users/mcclure/received_events","type":"User","site_admin":false},"body":"The intent of this PR is to allow a --inside or -i argument, which specifies a path \"inside\" the gamepath which is actually mounted. This is pointless if the gamepath is a directory, but useful if the gamepath is a .zip file, and required if the gamepath is an .apk file on android.\r\n\r\nI want to stress I have no opinions what to name this argument. Other options would be --innerPath or --nested.\r\n\r\nAs this is the first/only argument taken by lovr other than the gamepath, major changes were made to argument parsing to make this possible.\r\n\r\nPlease see commit messages for more detail.","created_at":"2018-11-13T21:33:06Z","updated_at":"2018-11-13T22:02:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"962d1ccba1d4ae61b9ad3946cf0fa9791b667edd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bjornbytes/lovr/pulls/71/commits","review_comments_url":"https://api.github.com/repos/bjornbytes/lovr/pulls/71/comments","review_comment_url":"https://api.github.com/repos/bjornbytes/lovr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bjornbytes/lovr/issues/71/comments","statuses_url":"https://api.github.com/repos/bjornbytes/lovr/statuses/2213b3bcfd0e9558fb63a21bd059f48cdff144e5","head":{"label":"mcclure:args-and-physfs","ref":"args-and-physfs","sha":"2213b3bcfd0e9558fb63a21bd059f48cdff144e5","user":{"login":"mcclure","id":277318,"node_id":"MDQ6VXNlcjI3NzMxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/277318?v=4","gravatar_id":"","url":"https://api.github.com/users/mcclure","html_url":"https://github.com/mcclure","followers_url":"https://api.github.com/users/mcclure/followers","following_url":"https://api.github.com/users/mcclure/following{/other_user}","gists_url":"https://api.github.com/users/mcclure/gists{/gist_id}","starred_url":"https://api.github.com/users/mcclure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcclure/subscriptions","organizations_url":"https://api.github.com/users/mcclure/orgs","repos_url":"https://api.github.com/users/mcclure/repos","events_url":"https://api.github.com/users/mcclure/events{/privacy}","received_events_url":"https://api.github.com/users/mcclure/received_events","type":"User","site_admin":false},"repo":{"id":116063138,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYwNjMxMzg=","name":"lovr","full_name":"mcclure/lovr","private":false,"owner":{"login":"mcclure","id":277318,"node_id":"MDQ6VXNlcjI3NzMxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/277318?v=4","gravatar_id":"","url":"https://api.github.com/users/mcclure","html_url":"https://github.com/mcclure","followers_url":"https://api.github.com/users/mcclure/followers","following_url":"https://api.github.com/users/mcclure/following{/other_user}","gists_url":"https://api.github.com/users/mcclure/gists{/gist_id}","starred_url":"https://api.github.com/users/mcclure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcclure/subscriptions","organizations_url":"https://api.github.com/users/mcclure/orgs","repos_url":"https://api.github.com/users/mcclure/repos","events_url":"https://api.github.com/users/mcclure/events{/privacy}","received_events_url":"https://api.github.com/users/mcclure/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mcclure/lovr","description":"Virtual Reality for Lua","fork":true,"url":"https://api.github.com/repos/mcclure/lovr","forks_url":"https://api.github.com/repos/mcclure/lovr/forks","keys_url":"https://api.github.com/repos/mcclure/lovr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcclure/lovr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcclure/lovr/teams","hooks_url":"https://api.github.com/repos/mcclure/lovr/hooks","issue_events_url":"https://api.github.com/repos/mcclure/lovr/issues/events{/number}","events_url":"https://api.github.com/repos/mcclure/lovr/events","assignees_url":"https://api.github.com/repos/mcclure/lovr/assignees{/user}","branches_url":"https://api.github.com/repos/mcclure/lovr/branches{/branch}","tags_url":"https://api.github.com/repos/mcclure/lovr/tags","blobs_url":"https://api.github.com/repos/mcclure/lovr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcclure/lovr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcclure/lovr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcclure/lovr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcclure/lovr/statuses/{sha}","languages_url":"https://api.github.com/repos/mcclure/lovr/languages","stargazers_url":"https://api.github.com/repos/mcclure/lovr/stargazers","contributors_url":"https://api.github.com/repos/mcclure/lovr/contributors","subscribers_url":"https://api.github.com/repos/mcclure/lovr/subscribers","subscription_url":"https://api.github.com/repos/mcclure/lovr/subscription","commits_url":"https://api.github.com/repos/mcclure/lovr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcclure/lovr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcclure/lovr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcclure/lovr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcclure/lovr/contents/{+path}","compare_url":"https://api.github.com/repos/mcclure/lovr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcclure/lovr/merges","archive_url":"https://api.github.com/repos/mcclure/lovr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcclure/lovr/downloads","issues_url":"https://api.github.com/repos/mcclure/lovr/issues{/number}","pulls_url":"https://api.github.com/repos/mcclure/lovr/pulls{/number}","milestones_url":"https://api.github.com/repos/mcclure/lovr/milestones{/number}","notifications_url":"https://api.github.com/repos/mcclure/lovr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcclure/lovr/labels{/name}","releases_url":"https://api.github.com/repos/mcclure/lovr/releases{/id}","deployments_url":"https://api.github.com/repos/mcclure/lovr/deployments","created_at":"2018-01-02T22:22:00Z","updated_at":"2018-01-02T22:22:02Z","pushed_at":"2018-11-13T21:29:57Z","git_url":"git://github.com/mcclure/lovr.git","ssh_url":"git@github.com:mcclure/lovr.git","clone_url":"https://github.com/mcclure/lovr.git","svn_url":"https://github.com/mcclure/lovr","homepage":"","size":4565,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bjornbytes:master","ref":"master","sha":"a1237029de6f07ee431e1d977e87715745f06005","user":{"login":"bjornbytes","id":784805,"node_id":"MDQ6VXNlcjc4NDgwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/784805?v=4","gravatar_id":"","url":"https://api.github.com/users/bjornbytes","html_url":"https://github.com/bjornbytes","followers_url":"https://api.github.com/users/bjornbytes/followers","following_url":"https://api.github.com/users/bjornbytes/following{/other_user}","gists_url":"https://api.github.com/users/bjornbytes/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornbytes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornbytes/subscriptions","organizations_url":"https://api.github.com/users/bjornbytes/orgs","repos_url":"https://api.github.com/users/bjornbytes/repos","events_url":"https://api.github.com/users/bjornbytes/events{/privacy}","received_events_url":"https://api.github.com/users/bjornbytes/received_events","type":"User","site_admin":false},"repo":{"id":62519414,"node_id":"MDEwOlJlcG9zaXRvcnk2MjUxOTQxNA==","name":"lovr","full_name":"bjornbytes/lovr","private":false,"owner":{"login":"bjornbytes","id":784805,"node_id":"MDQ6VXNlcjc4NDgwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/784805?v=4","gravatar_id":"","url":"https://api.github.com/users/bjornbytes","html_url":"https://github.com/bjornbytes","followers_url":"https://api.github.com/users/bjornbytes/followers","following_url":"https://api.github.com/users/bjornbytes/following{/other_user}","gists_url":"https://api.github.com/users/bjornbytes/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornbytes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornbytes/subscriptions","organizations_url":"https://api.github.com/users/bjornbytes/orgs","repos_url":"https://api.github.com/users/bjornbytes/repos","events_url":"https://api.github.com/users/bjornbytes/events{/privacy}","received_events_url":"https://api.github.com/users/bjornbytes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bjornbytes/lovr","description":"Virtual Reality for Lua","fork":false,"url":"https://api.github.com/repos/bjornbytes/lovr","forks_url":"https://api.github.com/repos/bjornbytes/lovr/forks","keys_url":"https://api.github.com/repos/bjornbytes/lovr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjornbytes/lovr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjornbytes/lovr/teams","hooks_url":"https://api.github.com/repos/bjornbytes/lovr/hooks","issue_events_url":"https://api.github.com/repos/bjornbytes/lovr/issues/events{/number}","events_url":"https://api.github.com/repos/bjornbytes/lovr/events","assignees_url":"https://api.github.com/repos/bjornbytes/lovr/assignees{/user}","branches_url":"https://api.github.com/repos/bjornbytes/lovr/branches{/branch}","tags_url":"https://api.github.com/repos/bjornbytes/lovr/tags","blobs_url":"https://api.github.com/repos/bjornbytes/lovr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjornbytes/lovr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjornbytes/lovr/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjornbytes/lovr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjornbytes/lovr/statuses/{sha}","languages_url":"https://api.github.com/repos/bjornbytes/lovr/languages","stargazers_url":"https://api.github.com/repos/bjornbytes/lovr/stargazers","contributors_url":"https://api.github.com/repos/bjornbytes/lovr/contributors","subscribers_url":"https://api.github.com/repos/bjornbytes/lovr/subscribers","subscription_url":"https://api.github.com/repos/bjornbytes/lovr/subscription","commits_url":"https://api.github.com/repos/bjornbytes/lovr/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjornbytes/lovr/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjornbytes/lovr/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjornbytes/lovr/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjornbytes/lovr/contents/{+path}","compare_url":"https://api.github.com/repos/bjornbytes/lovr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjornbytes/lovr/merges","archive_url":"https://api.github.com/repos/bjornbytes/lovr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjornbytes/lovr/downloads","issues_url":"https://api.github.com/repos/bjornbytes/lovr/issues{/number}","pulls_url":"https://api.github.com/repos/bjornbytes/lovr/pulls{/number}","milestones_url":"https://api.github.com/repos/bjornbytes/lovr/milestones{/number}","notifications_url":"https://api.github.com/repos/bjornbytes/lovr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjornbytes/lovr/labels{/name}","releases_url":"https://api.github.com/repos/bjornbytes/lovr/releases{/id}","deployments_url":"https://api.github.com/repos/bjornbytes/lovr/deployments","created_at":"2016-07-03T23:36:45Z","updated_at":"2018-11-13T03:28:49Z","pushed_at":"2018-11-13T21:33:07Z","git_url":"git://github.com/bjornbytes/lovr.git","ssh_url":"git@github.com:bjornbytes/lovr.git","clone_url":"https://github.com/bjornbytes/lovr.git","svn_url":"https://github.com/bjornbytes/lovr","homepage":"https://lovr.org","size":4626,"stargazers_count":342,"watchers_count":342,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":8,"watchers":342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bjornbytes/lovr/pulls/71"},"html":{"href":"https://github.com/bjornbytes/lovr/pull/71"},"issue":{"href":"https://api.github.com/repos/bjornbytes/lovr/issues/71"},"comments":{"href":"https://api.github.com/repos/bjornbytes/lovr/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/bjornbytes/lovr/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/bjornbytes/lovr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bjornbytes/lovr/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/bjornbytes/lovr/statuses/2213b3bcfd0e9558fb63a21bd059f48cdff144e5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bjornbytes"}}