{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/pulls/19","id":168313002,"html_url":"https://github.com/samsung-cnct/chart-fluent-bit/pull/19","diff_url":"https://github.com/samsung-cnct/chart-fluent-bit/pull/19.diff","patch_url":"https://github.com/samsung-cnct/chart-fluent-bit/pull/19.patch","issue_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/issues/19","number":19,"state":"closed","locked":false,"title":"[BAC-160] - cleanup namespaces in templates","user":{"login":"alika","id":1708067,"avatar_url":"https://avatars2.githubusercontent.com/u/1708067?v=4","gravatar_id":"","url":"https://api.github.com/users/alika","html_url":"https://github.com/alika","followers_url":"https://api.github.com/users/alika/followers","following_url":"https://api.github.com/users/alika/following{/other_user}","gists_url":"https://api.github.com/users/alika/gists{/gist_id}","starred_url":"https://api.github.com/users/alika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alika/subscriptions","organizations_url":"https://api.github.com/users/alika/orgs","repos_url":"https://api.github.com/users/alika/repos","events_url":"https://api.github.com/users/alika/events{/privacy}","received_events_url":"https://api.github.com/users/alika/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**: This PR removes the explicitly created namespace template value in favor of the helm provided namespace. This should be set on the helm install command. Additionally the templates can refer to `{{.Release.Namespace}}` when explicitly needed. Such as the ClusterRoleBinding resource.\r\n\r\n**Which issue this PR fixes**:\r\nThis is part of [BAC-160][160]\r\n\r\n**Verification Notes**:\r\n\r\nTo verify this you can install this chart into a dev cluster:\r\n```\r\nhelm install --name fluent-bit-0 --namespace fluent-bit-test ./fluent-bit\r\nkubectl -n fluent-bit-test get all\r\n```\r\n\r\n[160]: https://samsung-cnct.atlassian.net/browse/BAC-160","created_at":"2018-02-09T18:39:57Z","updated_at":"2018-02-09T22:13:36Z","closed_at":"2018-02-09T22:13:36Z","merged_at":"2018-02-09T22:13:36Z","merge_commit_sha":"1a550ceca7c34ee23aa0bbfbdceadd872c82c795","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/pulls/19/commits","review_comments_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/pulls/19/comments","review_comment_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/issues/19/comments","statuses_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/statuses/40ff2463812efe0b4ab3d6cc5c427236bd83ecbf","head":{"label":"alika:BAC-160/cleanup-namespaces","ref":"BAC-160/cleanup-namespaces","sha":"40ff2463812efe0b4ab3d6cc5c427236bd83ecbf","user":{"login":"alika","id":1708067,"avatar_url":"https://avatars2.githubusercontent.com/u/1708067?v=4","gravatar_id":"","url":"https://api.github.com/users/alika","html_url":"https://github.com/alika","followers_url":"https://api.github.com/users/alika/followers","following_url":"https://api.github.com/users/alika/following{/other_user}","gists_url":"https://api.github.com/users/alika/gists{/gist_id}","starred_url":"https://api.github.com/users/alika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alika/subscriptions","organizations_url":"https://api.github.com/users/alika/orgs","repos_url":"https://api.github.com/users/alika/repos","events_url":"https://api.github.com/users/alika/events{/privacy}","received_events_url":"https://api.github.com/users/alika/received_events","type":"User","site_admin":false},"repo":{"id":120938031,"name":"chart-fluent-bit","full_name":"alika/chart-fluent-bit","owner":{"login":"alika","id":1708067,"avatar_url":"https://avatars2.githubusercontent.com/u/1708067?v=4","gravatar_id":"","url":"https://api.github.com/users/alika","html_url":"https://github.com/alika","followers_url":"https://api.github.com/users/alika/followers","following_url":"https://api.github.com/users/alika/following{/other_user}","gists_url":"https://api.github.com/users/alika/gists{/gist_id}","starred_url":"https://api.github.com/users/alika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alika/subscriptions","organizations_url":"https://api.github.com/users/alika/orgs","repos_url":"https://api.github.com/users/alika/repos","events_url":"https://api.github.com/users/alika/events{/privacy}","received_events_url":"https://api.github.com/users/alika/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alika/chart-fluent-bit","description":"Kraken logging using fluent-bit for kubernetes","fork":true,"url":"https://api.github.com/repos/alika/chart-fluent-bit","forks_url":"https://api.github.com/repos/alika/chart-fluent-bit/forks","keys_url":"https://api.github.com/repos/alika/chart-fluent-bit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alika/chart-fluent-bit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alika/chart-fluent-bit/teams","hooks_url":"https://api.github.com/repos/alika/chart-fluent-bit/hooks","issue_events_url":"https://api.github.com/repos/alika/chart-fluent-bit/issues/events{/number}","events_url":"https://api.github.com/repos/alika/chart-fluent-bit/events","assignees_url":"https://api.github.com/repos/alika/chart-fluent-bit/assignees{/user}","branches_url":"https://api.github.com/repos/alika/chart-fluent-bit/branches{/branch}","tags_url":"https://api.github.com/repos/alika/chart-fluent-bit/tags","blobs_url":"https://api.github.com/repos/alika/chart-fluent-bit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alika/chart-fluent-bit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alika/chart-fluent-bit/git/refs{/sha}","trees_url":"https://api.github.com/repos/alika/chart-fluent-bit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alika/chart-fluent-bit/statuses/{sha}","languages_url":"https://api.github.com/repos/alika/chart-fluent-bit/languages","stargazers_url":"https://api.github.com/repos/alika/chart-fluent-bit/stargazers","contributors_url":"https://api.github.com/repos/alika/chart-fluent-bit/contributors","subscribers_url":"https://api.github.com/repos/alika/chart-fluent-bit/subscribers","subscription_url":"https://api.github.com/repos/alika/chart-fluent-bit/subscription","commits_url":"https://api.github.com/repos/alika/chart-fluent-bit/commits{/sha}","git_commits_url":"https://api.github.com/repos/alika/chart-fluent-bit/git/commits{/sha}","comments_url":"https://api.github.com/repos/alika/chart-fluent-bit/comments{/number}","issue_comment_url":"https://api.github.com/repos/alika/chart-fluent-bit/issues/comments{/number}","contents_url":"https://api.github.com/repos/alika/chart-fluent-bit/contents/{+path}","compare_url":"https://api.github.com/repos/alika/chart-fluent-bit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alika/chart-fluent-bit/merges","archive_url":"https://api.github.com/repos/alika/chart-fluent-bit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alika/chart-fluent-bit/downloads","issues_url":"https://api.github.com/repos/alika/chart-fluent-bit/issues{/number}","pulls_url":"https://api.github.com/repos/alika/chart-fluent-bit/pulls{/number}","milestones_url":"https://api.github.com/repos/alika/chart-fluent-bit/milestones{/number}","notifications_url":"https://api.github.com/repos/alika/chart-fluent-bit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alika/chart-fluent-bit/labels{/name}","releases_url":"https://api.github.com/repos/alika/chart-fluent-bit/releases{/id}","deployments_url":"https://api.github.com/repos/alika/chart-fluent-bit/deployments","created_at":"2018-02-09T17:58:18Z","updated_at":"2018-02-09T17:58:20Z","pushed_at":"2018-02-09T18:30:14Z","git_url":"git://github.com/alika/chart-fluent-bit.git","ssh_url":"git@github.com:alika/chart-fluent-bit.git","clone_url":"https://github.com/alika/chart-fluent-bit.git","svn_url":"https://github.com/alika/chart-fluent-bit","homepage":null,"size":1553,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samsung-cnct:master","ref":"master","sha":"5880e92c1faaa5f42743052b53bd90402b1b4527","user":{"login":"samsung-cnct","id":11511065,"avatar_url":"https://avatars3.githubusercontent.com/u/11511065?v=4","gravatar_id":"","url":"https://api.github.com/users/samsung-cnct","html_url":"https://github.com/samsung-cnct","followers_url":"https://api.github.com/users/samsung-cnct/followers","following_url":"https://api.github.com/users/samsung-cnct/following{/other_user}","gists_url":"https://api.github.com/users/samsung-cnct/gists{/gist_id}","starred_url":"https://api.github.com/users/samsung-cnct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsung-cnct/subscriptions","organizations_url":"https://api.github.com/users/samsung-cnct/orgs","repos_url":"https://api.github.com/users/samsung-cnct/repos","events_url":"https://api.github.com/users/samsung-cnct/events{/privacy}","received_events_url":"https://api.github.com/users/samsung-cnct/received_events","type":"Organization","site_admin":false},"repo":{"id":103970219,"name":"chart-fluent-bit","full_name":"samsung-cnct/chart-fluent-bit","owner":{"login":"samsung-cnct","id":11511065,"avatar_url":"https://avatars3.githubusercontent.com/u/11511065?v=4","gravatar_id":"","url":"https://api.github.com/users/samsung-cnct","html_url":"https://github.com/samsung-cnct","followers_url":"https://api.github.com/users/samsung-cnct/followers","following_url":"https://api.github.com/users/samsung-cnct/following{/other_user}","gists_url":"https://api.github.com/users/samsung-cnct/gists{/gist_id}","starred_url":"https://api.github.com/users/samsung-cnct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsung-cnct/subscriptions","organizations_url":"https://api.github.com/users/samsung-cnct/orgs","repos_url":"https://api.github.com/users/samsung-cnct/repos","events_url":"https://api.github.com/users/samsung-cnct/events{/privacy}","received_events_url":"https://api.github.com/users/samsung-cnct/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/samsung-cnct/chart-fluent-bit","description":"Kraken logging using fluent-bit for kubernetes","fork":false,"url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit","forks_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/forks","keys_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/teams","hooks_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/hooks","issue_events_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/issues/events{/number}","events_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/events","assignees_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/assignees{/user}","branches_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/branches{/branch}","tags_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/tags","blobs_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/statuses/{sha}","languages_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/languages","stargazers_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/stargazers","contributors_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/contributors","subscribers_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/subscribers","subscription_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/subscription","commits_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/issues/comments{/number}","contents_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/contents/{+path}","compare_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/merges","archive_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/downloads","issues_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/issues{/number}","pulls_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/pulls{/number}","milestones_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/milestones{/number}","notifications_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/labels{/name}","releases_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/releases{/id}","deployments_url":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/deployments","created_at":"2017-09-18T17:29:30Z","updated_at":"2017-12-12T21:21:06Z","pushed_at":"2018-02-09T22:13:36Z","git_url":"git://github.com/samsung-cnct/chart-fluent-bit.git","ssh_url":"git@github.com:samsung-cnct/chart-fluent-bit.git","clone_url":"https://github.com/samsung-cnct/chart-fluent-bit.git","svn_url":"https://github.com/samsung-cnct/chart-fluent-bit","homepage":null,"size":1551,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/pulls/19"},"html":{"href":"https://github.com/samsung-cnct/chart-fluent-bit/pull/19"},"issue":{"href":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/issues/19"},"comments":{"href":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/samsung-cnct/chart-fluent-bit/statuses/40ff2463812efe0b4ab3d6cc5c427236bd83ecbf"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"guineveresaenger","id":13116240,"avatar_url":"https://avatars3.githubusercontent.com/u/13116240?v=4","gravatar_id":"","url":"https://api.github.com/users/guineveresaenger","html_url":"https://github.com/guineveresaenger","followers_url":"https://api.github.com/users/guineveresaenger/followers","following_url":"https://api.github.com/users/guineveresaenger/following{/other_user}","gists_url":"https://api.github.com/users/guineveresaenger/gists{/gist_id}","starred_url":"https://api.github.com/users/guineveresaenger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guineveresaenger/subscriptions","organizations_url":"https://api.github.com/users/guineveresaenger/orgs","repos_url":"https://api.github.com/users/guineveresaenger/repos","events_url":"https://api.github.com/users/guineveresaenger/events{/privacy}","received_events_url":"https://api.github.com/users/guineveresaenger/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":2,"additions":15,"deletions":4,"changed_files":5}}
{"actor":{"display_login":"guineveresaenger"}}