{"action":"created","issue":{"url":"https://api.github.com/repos/badges/shields/issues/1965","repository_url":"https://api.github.com/repos/badges/shields","labels_url":"https://api.github.com/repos/badges/shields/issues/1965/labels{/name}","comments_url":"https://api.github.com/repos/badges/shields/issues/1965/comments","events_url":"https://api.github.com/repos/badges/shields/issues/1965/events","html_url":"https://github.com/badges/shields/pull/1965","id":353544558,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTY5MzMy","number":1965,"title":"[WIP] new badge: f-droid ","user":{"login":"niccokunzmann","id":564768,"node_id":"MDQ6VXNlcjU2NDc2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/564768?v=4","gravatar_id":"","url":"https://api.github.com/users/niccokunzmann","html_url":"https://github.com/niccokunzmann","followers_url":"https://api.github.com/users/niccokunzmann/followers","following_url":"https://api.github.com/users/niccokunzmann/following{/other_user}","gists_url":"https://api.github.com/users/niccokunzmann/gists{/gist_id}","starred_url":"https://api.github.com/users/niccokunzmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niccokunzmann/subscriptions","organizations_url":"https://api.github.com/users/niccokunzmann/orgs","repos_url":"https://api.github.com/users/niccokunzmann/repos","events_url":"https://api.github.com/users/niccokunzmann/events{/privacy}","received_events_url":"https://api.github.com/users/niccokunzmann/received_events","type":"User","site_admin":false},"labels":[{"id":316395868,"node_id":"MDU6TGFiZWwzMTYzOTU4Njg=","url":"https://api.github.com/repos/badges/shields/labels/service-badge","name":"service-badge","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-23T20:38:57Z","updated_at":"2018-08-23T23:14:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/badges/shields/pulls/1965","html_url":"https://github.com/badges/shields/pull/1965","diff_url":"https://github.com/badges/shields/pull/1965.diff","patch_url":"https://github.com/badges/shields/pull/1965.patch"},"body":"I document the progress here as an imperfect PR and ask for review once I am confident it works.\r\n\r\n- edit server.js\r\n- first untested version\r\n  - get the website\r\n  - regex query as string\r\n  - get version info\r\n\r\nfixes #1963 "},"comment":{"url":"https://api.github.com/repos/badges/shields/issues/comments/415602453","html_url":"https://github.com/badges/shields/pull/1965#issuecomment-415602453","issue_url":"https://api.github.com/repos/badges/shields/issues/1965","id":415602453,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTYwMjQ1Mw==","user":{"login":"niccokunzmann","id":564768,"node_id":"MDQ6VXNlcjU2NDc2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/564768?v=4","gravatar_id":"","url":"https://api.github.com/users/niccokunzmann","html_url":"https://github.com/niccokunzmann","followers_url":"https://api.github.com/users/niccokunzmann/followers","following_url":"https://api.github.com/users/niccokunzmann/following{/other_user}","gists_url":"https://api.github.com/users/niccokunzmann/gists{/gist_id}","starred_url":"https://api.github.com/users/niccokunzmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niccokunzmann/subscriptions","organizations_url":"https://api.github.com/users/niccokunzmann/orgs","repos_url":"https://api.github.com/users/niccokunzmann/repos","events_url":"https://api.github.com/users/niccokunzmann/events{/privacy}","received_events_url":"https://api.github.com/users/niccokunzmann/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T23:14:44Z","updated_at":"2018-08-23T23:14:44Z","author_association":"CONTRIBUTOR","body":"Now, I have the problem, that the nock data is not delivered as website. The HTTP get always returns an empty website.\r\n\r\n\r\n```\r\n$ npm run test:services -- --grep F-Droid\r\n\r\n> gh-badges@1.3.0 test:services /home/user/shields\r\n> HANDLE_INTERNAL_ERRORS=false mocha --delay lib/service-test-runner/cli.js \"--grep\" \"F-Droid\"\r\n\r\nRunning all service tests.\r\n\r\n\r\nNo secret data found at /home/user/shields/private/secret.json (see lib/server-secrets.js)\r\nraven@2.4.2 alert: no DSN provided, error reporting disabled\r\n0823231217 FsTokenPersistence configured with /home/user/shields/private/github-user-tokens.json\r\n0823231217 Server is starting up: http://lib/service-test-runner/cli.js:80/\r\nNo fallback font set.\r\nUnable to load fallback font. Using Helvetica-Bold instead.\r\n  F-Droid\r\n    Package is found\r\nwebsite\r\n\r\nGET /version/org.pacien.tincapp.json has FAILED with the following response:\r\n      1) \r\n\t[ GET /version/org.pacien.tincapp.json ]\r\n    Package is not found\r\nwebsite\r\n\r\nGET /version/org.pacien.tincapp.json has FAILED with the following response:\r\n      2) \r\n\t[ GET /version/org.pacien.tincapp.json ]\r\n\r\n\r\n  0 passing (810ms)\r\n  2 failing\r\n\r\n  1) F-Droid\r\n       Package is found\r\n         \r\n\t[ GET /version/org.pacien.tincapp.json ]:\r\n\r\n      AssertionError: expected { Object (name, value) } to deeply equal { name: 'F-Droid', value: 'v0.19' }\r\n      + expected - actual\r\n\r\n       {\r\n         \"name\": \"F-Droid\"\r\n      -  \"value\": \"fix this badge\"\r\n      +  \"value\": \"v0.19\"\r\n       }\r\n      \r\n      at Object.pathMatch.matchJSON (node_modules/icedfrisby/lib/pathMatch.js:138:38)\r\n      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:583:10)\r\n      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)\r\n      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)\r\n      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)\r\n      at Request.self.callback (node_modules/request/request.js:185:22)\r\n      at Request.<anonymous> (node_modules/request/request.js:1161:10)\r\n      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)\r\n      at endReadableNT (_stream_readable.js:1056:12)\r\n      at _combinedTickCallback (internal/process/next_tick.js:138:11)\r\n      at process._tickDomainCallback (internal/process/next_tick.js:218:9)\r\n\r\n  2) F-Droid\r\n       Package is not found\r\n         \r\n\t[ GET /version/org.pacien.tincapp.json ]:\r\n\r\n      AssertionError: expected { Object (name, value) } to deeply equal { Object (name, value) }\r\n      + expected - actual\r\n\r\n       {\r\n         \"name\": \"F-Droid\"\r\n      -  \"value\": \"fix this badge\"\r\n      +  \"value\": \"app not found\"\r\n       }\r\n      \r\n      at Object.pathMatch.matchJSON (node_modules/icedfrisby/lib/pathMatch.js:138:38)\r\n      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:583:10)\r\n      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)\r\n      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)\r\n      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)\r\n      at Request.self.callback (node_modules/request/request.js:185:22)\r\n      at Request.<anonymous> (node_modules/request/request.js:1161:10)\r\n      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)\r\n      at endReadableNT (_stream_readable.js:1056:12)\r\n      at _combinedTickCallback (internal/process/next_tick.js:138:11)\r\n      at process._tickDomainCallback (internal/process/next_tick.js:218:9)\r\n\r\n\r\n```"}}
{"actor":{"display_login":"niccokunzmann"}}