{"action":"opened","issue":{"url":"https://api.github.com/repos/uwnlp/piqa/issues/1","repository_url":"https://api.github.com/repos/uwnlp/piqa","labels_url":"https://api.github.com/repos/uwnlp/piqa/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/uwnlp/piqa/issues/1/comments","events_url":"https://api.github.com/repos/uwnlp/piqa/issues/1/events","html_url":"https://github.com/uwnlp/piqa/issues/1","id":364978368,"node_id":"MDU6SXNzdWUzNjQ5NzgzNjg=","number":1,"title":"About computation of Elmo","user":{"login":"bdhingra","id":8645980,"node_id":"MDQ6VXNlcjg2NDU5ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/8645980?v=4","gravatar_id":"","url":"https://api.github.com/users/bdhingra","html_url":"https://github.com/bdhingra","followers_url":"https://api.github.com/users/bdhingra/followers","following_url":"https://api.github.com/users/bdhingra/following{/other_user}","gists_url":"https://api.github.com/users/bdhingra/gists{/gist_id}","starred_url":"https://api.github.com/users/bdhingra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdhingra/subscriptions","organizations_url":"https://api.github.com/users/bdhingra/orgs","repos_url":"https://api.github.com/users/bdhingra/repos","events_url":"https://api.github.com/users/bdhingra/events{/privacy}","received_events_url":"https://api.github.com/users/bdhingra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-28T17:33:27Z","updated_at":"2018-09-28T17:33:27Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\n\r\nThanks for uploading the code!\r\n\r\nIt seems that in [model.py](https://github.com/uwnlp/piqa/blob/master/model.py#L71) you are maintaining the scale and mixing parameters for computing the averaged Elmo representation. However, from my understanding of `[allennlp.modules.elmo.Elmo](https://github.com/allenai/allennlp/blob/master/allennlp/modules/elmo.py#L34)` this should be already taken care of by the `Elmo` class. \r\n\r\nIs there any reason for re-mixing the already mixed Elmo representations returned? Or am I misunderstanding something?\r\n\r\nThanks!\r\nBhuwan"}}
{"actor":{"display_login":"bdhingra"}}