{"action":"created","comment":{"url":"https://api.github.com/repos/linuxboot/fiano/pulls/comments/191556836","pull_request_review_id":124149853,"id":191556836,"diff_hunk":"@@ -12,14 +13,26 @@ const FlashRegionSectionSize = 36\n \n // FlashRegionSection holds the metadata of all the different flash regions like PDR, Gbe and the Bios region.\n type FlashRegionSection struct {\n-\tReserved            uint16\n+\tReserved            uint16 `json:\"-\"`\n \tFlashBlockEraseSize uint16\n \tBiosBase, BiosLimit uint16","path":"uefi/flashregionsection.go","position":15,"original_position":15,"commit_id":"85aa723c5cd5375ba7f20e066e18cfc6a7d139d9","original_commit_id":"85aa723c5cd5375ba7f20e066e18cfc6a7d139d9","user":{"login":"hugelgupf","id":1994130,"avatar_url":"https://avatars2.githubusercontent.com/u/1994130?v=4","gravatar_id":"","url":"https://api.github.com/users/hugelgupf","html_url":"https://github.com/hugelgupf","followers_url":"https://api.github.com/users/hugelgupf/followers","following_url":"https://api.github.com/users/hugelgupf/following{/other_user}","gists_url":"https://api.github.com/users/hugelgupf/gists{/gist_id}","starred_url":"https://api.github.com/users/hugelgupf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugelgupf/subscriptions","organizations_url":"https://api.github.com/users/hugelgupf/orgs","repos_url":"https://api.github.com/users/hugelgupf/repos","events_url":"https://api.github.com/users/hugelgupf/events{/privacy}","received_events_url":"https://api.github.com/users/hugelgupf/received_events","type":"User","site_admin":false},"body":"How about something like\r\n\r\n```go\r\ntype Region struct {\r\n  Base  uint16\r\n  Limit uint16\r\n}\r\n\r\nfunc (r Region) Available() bool {\r\n  return r.Limit != 0\r\n}\r\n\r\nfunc (r Region) String() string {\r\n  return fmt.Sprintf(\"[%d, %d)\", r.Base, r.Limit)\r\n}\r\n\r\ntype FlashRegionSection struct {\r\n  BIOS Region\r\n  ME   Region\r\n  GBE  Region\r\n  PDR  Region\r\n}\r\n```","created_at":"2018-05-29T20:07:19Z","updated_at":"2018-05-29T20:10:28Z","html_url":"https://github.com/linuxboot/fiano/pull/4#discussion_r191556836","pull_request_url":"https://api.github.com/repos/linuxboot/fiano/pulls/4","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/linuxboot/fiano/pulls/comments/191556836"},"html":{"href":"https://github.com/linuxboot/fiano/pull/4#discussion_r191556836"},"pull_request":{"href":"https://api.github.com/repos/linuxboot/fiano/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/linuxboot/fiano/pulls/4","id":191207568,"html_url":"https://github.com/linuxboot/fiano/pull/4","diff_url":"https://github.com/linuxboot/fiano/pull/4.diff","patch_url":"https://github.com/linuxboot/fiano/pull/4.patch","issue_url":"https://api.github.com/repos/linuxboot/fiano/issues/4","number":4,"state":"open","locked":false,"title":"Replace Summary() functions with JSON marshalling","user":{"login":"GanShun","id":3449939,"avatar_url":"https://avatars3.githubusercontent.com/u/3449939?v=4","gravatar_id":"","url":"https://api.github.com/users/GanShun","html_url":"https://github.com/GanShun","followers_url":"https://api.github.com/users/GanShun/followers","following_url":"https://api.github.com/users/GanShun/following{/other_user}","gists_url":"https://api.github.com/users/GanShun/gists{/gist_id}","starred_url":"https://api.github.com/users/GanShun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GanShun/subscriptions","organizations_url":"https://api.github.com/users/GanShun/orgs","repos_url":"https://api.github.com/users/GanShun/repos","events_url":"https://api.github.com/users/GanShun/events{/privacy}","received_events_url":"https://api.github.com/users/GanShun/received_events","type":"User","site_admin":false},"body":"This allows us to prepare to serialize out metadata into files for easy parsing, and we can remove the Summary calls as I've made the Json print out similar fields to the Summary calls","created_at":"2018-05-29T16:46:31Z","updated_at":"2018-05-29T20:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87d22f28bec076102fd27f9c4975eeb15328edeb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rminnich","id":74928,"avatar_url":"https://avatars0.githubusercontent.com/u/74928?v=4","gravatar_id":"","url":"https://api.github.com/users/rminnich","html_url":"https://github.com/rminnich","followers_url":"https://api.github.com/users/rminnich/followers","following_url":"https://api.github.com/users/rminnich/following{/other_user}","gists_url":"https://api.github.com/users/rminnich/gists{/gist_id}","starred_url":"https://api.github.com/users/rminnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rminnich/subscriptions","organizations_url":"https://api.github.com/users/rminnich/orgs","repos_url":"https://api.github.com/users/rminnich/repos","events_url":"https://api.github.com/users/rminnich/events{/privacy}","received_events_url":"https://api.github.com/users/rminnich/received_events","type":"User","site_admin":false},{"login":"insomniacslk","id":2356960,"avatar_url":"https://avatars3.githubusercontent.com/u/2356960?v=4","gravatar_id":"","url":"https://api.github.com/users/insomniacslk","html_url":"https://github.com/insomniacslk","followers_url":"https://api.github.com/users/insomniacslk/followers","following_url":"https://api.github.com/users/insomniacslk/following{/other_user}","gists_url":"https://api.github.com/users/insomniacslk/gists{/gist_id}","starred_url":"https://api.github.com/users/insomniacslk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insomniacslk/subscriptions","organizations_url":"https://api.github.com/users/insomniacslk/orgs","repos_url":"https://api.github.com/users/insomniacslk/repos","events_url":"https://api.github.com/users/insomniacslk/events{/privacy}","received_events_url":"https://api.github.com/users/insomniacslk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linuxboot/fiano/pulls/4/commits","review_comments_url":"https://api.github.com/repos/linuxboot/fiano/pulls/4/comments","review_comment_url":"https://api.github.com/repos/linuxboot/fiano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linuxboot/fiano/issues/4/comments","statuses_url":"https://api.github.com/repos/linuxboot/fiano/statuses/85aa723c5cd5375ba7f20e066e18cfc6a7d139d9","head":{"label":"GanShun:json","ref":"json","sha":"85aa723c5cd5375ba7f20e066e18cfc6a7d139d9","user":{"login":"GanShun","id":3449939,"avatar_url":"https://avatars3.githubusercontent.com/u/3449939?v=4","gravatar_id":"","url":"https://api.github.com/users/GanShun","html_url":"https://github.com/GanShun","followers_url":"https://api.github.com/users/GanShun/followers","following_url":"https://api.github.com/users/GanShun/following{/other_user}","gists_url":"https://api.github.com/users/GanShun/gists{/gist_id}","starred_url":"https://api.github.com/users/GanShun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GanShun/subscriptions","organizations_url":"https://api.github.com/users/GanShun/orgs","repos_url":"https://api.github.com/users/GanShun/repos","events_url":"https://api.github.com/users/GanShun/events{/privacy}","received_events_url":"https://api.github.com/users/GanShun/received_events","type":"User","site_admin":false},"repo":{"id":134618877,"name":"fiano","full_name":"GanShun/fiano","owner":{"login":"GanShun","id":3449939,"avatar_url":"https://avatars3.githubusercontent.com/u/3449939?v=4","gravatar_id":"","url":"https://api.github.com/users/GanShun","html_url":"https://github.com/GanShun","followers_url":"https://api.github.com/users/GanShun/followers","following_url":"https://api.github.com/users/GanShun/following{/other_user}","gists_url":"https://api.github.com/users/GanShun/gists{/gist_id}","starred_url":"https://api.github.com/users/GanShun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GanShun/subscriptions","organizations_url":"https://api.github.com/users/GanShun/orgs","repos_url":"https://api.github.com/users/GanShun/repos","events_url":"https://api.github.com/users/GanShun/events{/privacy}","received_events_url":"https://api.github.com/users/GanShun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GanShun/fiano","description":"reworked EDK2 tools and code we need in a form the open source community is used to","fork":true,"url":"https://api.github.com/repos/GanShun/fiano","forks_url":"https://api.github.com/repos/GanShun/fiano/forks","keys_url":"https://api.github.com/repos/GanShun/fiano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GanShun/fiano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GanShun/fiano/teams","hooks_url":"https://api.github.com/repos/GanShun/fiano/hooks","issue_events_url":"https://api.github.com/repos/GanShun/fiano/issues/events{/number}","events_url":"https://api.github.com/repos/GanShun/fiano/events","assignees_url":"https://api.github.com/repos/GanShun/fiano/assignees{/user}","branches_url":"https://api.github.com/repos/GanShun/fiano/branches{/branch}","tags_url":"https://api.github.com/repos/GanShun/fiano/tags","blobs_url":"https://api.github.com/repos/GanShun/fiano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GanShun/fiano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GanShun/fiano/git/refs{/sha}","trees_url":"https://api.github.com/repos/GanShun/fiano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GanShun/fiano/statuses/{sha}","languages_url":"https://api.github.com/repos/GanShun/fiano/languages","stargazers_url":"https://api.github.com/repos/GanShun/fiano/stargazers","contributors_url":"https://api.github.com/repos/GanShun/fiano/contributors","subscribers_url":"https://api.github.com/repos/GanShun/fiano/subscribers","subscription_url":"https://api.github.com/repos/GanShun/fiano/subscription","commits_url":"https://api.github.com/repos/GanShun/fiano/commits{/sha}","git_commits_url":"https://api.github.com/repos/GanShun/fiano/git/commits{/sha}","comments_url":"https://api.github.com/repos/GanShun/fiano/comments{/number}","issue_comment_url":"https://api.github.com/repos/GanShun/fiano/issues/comments{/number}","contents_url":"https://api.github.com/repos/GanShun/fiano/contents/{+path}","compare_url":"https://api.github.com/repos/GanShun/fiano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GanShun/fiano/merges","archive_url":"https://api.github.com/repos/GanShun/fiano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GanShun/fiano/downloads","issues_url":"https://api.github.com/repos/GanShun/fiano/issues{/number}","pulls_url":"https://api.github.com/repos/GanShun/fiano/pulls{/number}","milestones_url":"https://api.github.com/repos/GanShun/fiano/milestones{/number}","notifications_url":"https://api.github.com/repos/GanShun/fiano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GanShun/fiano/labels{/name}","releases_url":"https://api.github.com/repos/GanShun/fiano/releases{/id}","deployments_url":"https://api.github.com/repos/GanShun/fiano/deployments","created_at":"2018-05-23T19:54:18Z","updated_at":"2018-05-29T17:23:42Z","pushed_at":"2018-05-29T19:55:07Z","git_url":"git://github.com/GanShun/fiano.git","ssh_url":"git@github.com:GanShun/fiano.git","clone_url":"https://github.com/GanShun/fiano.git","svn_url":"https://github.com/GanShun/fiano","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linuxboot:master","ref":"master","sha":"cb7bc813b398d9cf5a10042a496ab477b7e88617","user":{"login":"linuxboot","id":33524907,"avatar_url":"https://avatars2.githubusercontent.com/u/33524907?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxboot","html_url":"https://github.com/linuxboot","followers_url":"https://api.github.com/users/linuxboot/followers","following_url":"https://api.github.com/users/linuxboot/following{/other_user}","gists_url":"https://api.github.com/users/linuxboot/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxboot/subscriptions","organizations_url":"https://api.github.com/users/linuxboot/orgs","repos_url":"https://api.github.com/users/linuxboot/repos","events_url":"https://api.github.com/users/linuxboot/events{/privacy}","received_events_url":"https://api.github.com/users/linuxboot/received_events","type":"Organization","site_admin":false},"repo":{"id":122654287,"name":"fiano","full_name":"linuxboot/fiano","owner":{"login":"linuxboot","id":33524907,"avatar_url":"https://avatars2.githubusercontent.com/u/33524907?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxboot","html_url":"https://github.com/linuxboot","followers_url":"https://api.github.com/users/linuxboot/followers","following_url":"https://api.github.com/users/linuxboot/following{/other_user}","gists_url":"https://api.github.com/users/linuxboot/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxboot/subscriptions","organizations_url":"https://api.github.com/users/linuxboot/orgs","repos_url":"https://api.github.com/users/linuxboot/repos","events_url":"https://api.github.com/users/linuxboot/events{/privacy}","received_events_url":"https://api.github.com/users/linuxboot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linuxboot/fiano","description":"reworked EDK2 tools and code we need in a form the open source community is used to","fork":false,"url":"https://api.github.com/repos/linuxboot/fiano","forks_url":"https://api.github.com/repos/linuxboot/fiano/forks","keys_url":"https://api.github.com/repos/linuxboot/fiano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linuxboot/fiano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linuxboot/fiano/teams","hooks_url":"https://api.github.com/repos/linuxboot/fiano/hooks","issue_events_url":"https://api.github.com/repos/linuxboot/fiano/issues/events{/number}","events_url":"https://api.github.com/repos/linuxboot/fiano/events","assignees_url":"https://api.github.com/repos/linuxboot/fiano/assignees{/user}","branches_url":"https://api.github.com/repos/linuxboot/fiano/branches{/branch}","tags_url":"https://api.github.com/repos/linuxboot/fiano/tags","blobs_url":"https://api.github.com/repos/linuxboot/fiano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linuxboot/fiano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linuxboot/fiano/git/refs{/sha}","trees_url":"https://api.github.com/repos/linuxboot/fiano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linuxboot/fiano/statuses/{sha}","languages_url":"https://api.github.com/repos/linuxboot/fiano/languages","stargazers_url":"https://api.github.com/repos/linuxboot/fiano/stargazers","contributors_url":"https://api.github.com/repos/linuxboot/fiano/contributors","subscribers_url":"https://api.github.com/repos/linuxboot/fiano/subscribers","subscription_url":"https://api.github.com/repos/linuxboot/fiano/subscription","commits_url":"https://api.github.com/repos/linuxboot/fiano/commits{/sha}","git_commits_url":"https://api.github.com/repos/linuxboot/fiano/git/commits{/sha}","comments_url":"https://api.github.com/repos/linuxboot/fiano/comments{/number}","issue_comment_url":"https://api.github.com/repos/linuxboot/fiano/issues/comments{/number}","contents_url":"https://api.github.com/repos/linuxboot/fiano/contents/{+path}","compare_url":"https://api.github.com/repos/linuxboot/fiano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linuxboot/fiano/merges","archive_url":"https://api.github.com/repos/linuxboot/fiano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linuxboot/fiano/downloads","issues_url":"https://api.github.com/repos/linuxboot/fiano/issues{/number}","pulls_url":"https://api.github.com/repos/linuxboot/fiano/pulls{/number}","milestones_url":"https://api.github.com/repos/linuxboot/fiano/milestones{/number}","notifications_url":"https://api.github.com/repos/linuxboot/fiano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linuxboot/fiano/labels{/name}","releases_url":"https://api.github.com/repos/linuxboot/fiano/releases{/id}","deployments_url":"https://api.github.com/repos/linuxboot/fiano/deployments","created_at":"2018-02-23T17:50:49Z","updated_at":"2018-05-24T19:17:48Z","pushed_at":"2018-05-29T16:46:32Z","git_url":"git://github.com/linuxboot/fiano.git","ssh_url":"git@github.com:linuxboot/fiano.git","clone_url":"https://github.com/linuxboot/fiano.git","svn_url":"https://github.com/linuxboot/fiano","homepage":null,"size":14,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linuxboot/fiano/pulls/4"},"html":{"href":"https://github.com/linuxboot/fiano/pull/4"},"issue":{"href":"https://api.github.com/repos/linuxboot/fiano/issues/4"},"comments":{"href":"https://api.github.com/repos/linuxboot/fiano/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/linuxboot/fiano/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/linuxboot/fiano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linuxboot/fiano/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/linuxboot/fiano/statuses/85aa723c5cd5375ba7f20e066e18cfc6a7d139d9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hugelgupf"}}