{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/kvm-operator/pulls/comments/180746366","pull_request_review_id":111219291,"id":180746366,"diff_hunk":"@@ -43,7 +38,7 @@ func NewFramework(config FrameworkConfig) (*framework.Framework, error) {\n \t\t\tWatcher: config.K8sClient.CoreV1().Pods(\"\"),\n \n \t\t\tListOptions: apismetav1.ListOptions{\n-\t\t\t\tLabelSelector: fmt.Sprintf(\"%s=%s\", PodWatcherLabel, config.ProjectName),\n+\t\t\t\tLabelSelector: fmt.Sprintf(\"%s=%s\", key.PodWatcherLabel, config.ProjectName),","path":"service/kvmconfig/drainer_framework.go","position":44,"original_position":44,"commit_id":"b22eec3835de18b626af9502301299f5db7fc314","original_commit_id":"b22eec3835de18b626af9502301299f5db7fc314","user":{"login":"xh3b4sd","id":552769,"avatar_url":"https://avatars3.githubusercontent.com/u/552769?v=4","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false},"body":"So the cool thing is everything is versioned together and the key package can be reused across the resources without diverging further. ","created_at":"2018-04-11T13:07:17Z","updated_at":"2018-04-11T13:09:10Z","html_url":"https://github.com/giantswarm/kvm-operator/pull/458#discussion_r180746366","pull_request_url":"https://api.github.com/repos/giantswarm/kvm-operator/pulls/458","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/kvm-operator/pulls/comments/180746366"},"html":{"href":"https://github.com/giantswarm/kvm-operator/pull/458#discussion_r180746366"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/kvm-operator/pulls/458"}}},"pull_request":{"url":"https://api.github.com/repos/giantswarm/kvm-operator/pulls/458","id":180896747,"html_url":"https://github.com/giantswarm/kvm-operator/pull/458","diff_url":"https://github.com/giantswarm/kvm-operator/pull/458.diff","patch_url":"https://github.com/giantswarm/kvm-operator/pull/458.patch","issue_url":"https://api.github.com/repos/giantswarm/kvm-operator/issues/458","number":458,"state":"open","locked":false,"title":"moves pod resource to improve versioning","user":{"login":"xh3b4sd","id":552769,"avatar_url":"https://avatars3.githubusercontent.com/u/552769?v=4","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false},"body":"Towards https://github.com/giantswarm/giantswarm/issues/2956. ","created_at":"2018-04-11T13:05:27Z","updated_at":"2018-04-11T13:09:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdef658702376de1260528682a074792c9bf65fd","assignee":{"login":"xh3b4sd","id":552769,"avatar_url":"https://avatars3.githubusercontent.com/u/552769?v=4","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false},"assignees":[{"login":"xh3b4sd","id":552769,"avatar_url":"https://avatars3.githubusercontent.com/u/552769?v=4","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/kvm-operator/pulls/458/commits","review_comments_url":"https://api.github.com/repos/giantswarm/kvm-operator/pulls/458/comments","review_comment_url":"https://api.github.com/repos/giantswarm/kvm-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/kvm-operator/issues/458/comments","statuses_url":"https://api.github.com/repos/giantswarm/kvm-operator/statuses/b22eec3835de18b626af9502301299f5db7fc314","head":{"label":"giantswarm:structure","ref":"structure","sha":"b22eec3835de18b626af9502301299f5db7fc314","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":74021543,"name":"kvm-operator","full_name":"giantswarm/kvm-operator","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/kvm-operator","description":"Handles Kubernetes clusters running on a Kubernetes cluster with workers and masters in KVMs on bare metal","fork":false,"url":"https://api.github.com/repos/giantswarm/kvm-operator","forks_url":"https://api.github.com/repos/giantswarm/kvm-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/kvm-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/kvm-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/kvm-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/kvm-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/kvm-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/kvm-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/kvm-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/kvm-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/kvm-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/kvm-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/kvm-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/kvm-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/kvm-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/kvm-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/kvm-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/kvm-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/kvm-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/kvm-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/kvm-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/kvm-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/kvm-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/kvm-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/kvm-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/kvm-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/kvm-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/kvm-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/kvm-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/kvm-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/kvm-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/kvm-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/kvm-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/kvm-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/kvm-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/kvm-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/kvm-operator/deployments","created_at":"2016-11-17T11:40:50Z","updated_at":"2018-04-11T08:21:01Z","pushed_at":"2018-04-11T13:05:28Z","git_url":"git://github.com/giantswarm/kvm-operator.git","ssh_url":"git@github.com:giantswarm/kvm-operator.git","clone_url":"https://github.com/giantswarm/kvm-operator.git","svn_url":"https://github.com/giantswarm/kvm-operator","homepage":"https://giantswarm.io","size":44256,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":9,"watchers":15,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"13f2f9fc98ed4701bcfb18fcced06b65ea8a915a","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":74021543,"name":"kvm-operator","full_name":"giantswarm/kvm-operator","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/kvm-operator","description":"Handles Kubernetes clusters running on a Kubernetes cluster with workers and masters in KVMs on bare metal","fork":false,"url":"https://api.github.com/repos/giantswarm/kvm-operator","forks_url":"https://api.github.com/repos/giantswarm/kvm-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/kvm-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/kvm-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/kvm-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/kvm-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/kvm-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/kvm-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/kvm-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/kvm-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/kvm-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/kvm-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/kvm-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/kvm-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/kvm-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/kvm-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/kvm-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/kvm-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/kvm-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/kvm-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/kvm-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/kvm-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/kvm-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/kvm-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/kvm-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/kvm-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/kvm-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/kvm-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/kvm-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/kvm-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/kvm-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/kvm-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/kvm-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/kvm-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/kvm-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/kvm-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/kvm-operator/deployments","created_at":"2016-11-17T11:40:50Z","updated_at":"2018-04-11T08:21:01Z","pushed_at":"2018-04-11T13:05:28Z","git_url":"git://github.com/giantswarm/kvm-operator.git","ssh_url":"git@github.com:giantswarm/kvm-operator.git","clone_url":"https://github.com/giantswarm/kvm-operator.git","svn_url":"https://github.com/giantswarm/kvm-operator","homepage":"https://giantswarm.io","size":44256,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":9,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/kvm-operator/pulls/458"},"html":{"href":"https://github.com/giantswarm/kvm-operator/pull/458"},"issue":{"href":"https://api.github.com/repos/giantswarm/kvm-operator/issues/458"},"comments":{"href":"https://api.github.com/repos/giantswarm/kvm-operator/issues/458/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/kvm-operator/pulls/458/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/kvm-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/kvm-operator/pulls/458/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/kvm-operator/statuses/b22eec3835de18b626af9502301299f5db7fc314"}},"author_association":"OWNER"}}
{"actor":{"display_login":"xh3b4sd"}}