{"action":"opened","number":14,"pull_request":{"url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/pulls/14","id":210529477,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTI5NDc3","html_url":"https://github.com/kentcdodds/cypress-testing-library/pull/14","diff_url":"https://github.com/kentcdodds/cypress-testing-library/pull/14.diff","patch_url":"https://github.com/kentcdodds/cypress-testing-library/pull/14.patch","issue_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues/14","number":14,"state":"open","locked":false,"title":"upgrade dom-testing-library","user":{"login":"gnapse","id":15199,"node_id":"MDQ6VXNlcjE1MTk5","avatar_url":"https://avatars0.githubusercontent.com/u/15199?v=4","gravatar_id":"","url":"https://api.github.com/users/gnapse","html_url":"https://github.com/gnapse","followers_url":"https://api.github.com/users/gnapse/followers","following_url":"https://api.github.com/users/gnapse/following{/other_user}","gists_url":"https://api.github.com/users/gnapse/gists{/gist_id}","starred_url":"https://api.github.com/users/gnapse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnapse/subscriptions","organizations_url":"https://api.github.com/users/gnapse/orgs","repos_url":"https://api.github.com/users/gnapse/repos","events_url":"https://api.github.com/users/gnapse/events{/privacy}","received_events_url":"https://api.github.com/users/gnapse/received_events","type":"User","site_admin":false},"body":"**What**:\r\n\r\n- Upgrade `dom-testing-library`\r\n- Upgrade `serve`, mainly because it was printing a warning about a newer version.\r\n- In the process I added a jest config setting without which I got weird errors. See [this](https://stackoverflow.com/a/51554619/621809) for details. Not sure why it has not been an issue for others so far.\r\n\r\n**Why**:\r\n\r\nThe main motivation was upgrading `dom-testing-library` just to keep it up to date with the latest and greatest.\r\n\r\n**How**:\r\n\r\nBy updating the dependency version numbers in `package.json`.\r\n\r\n**Checklist**:\r\n\r\n<!-- add \"N/A\" to the end of each line that's irrelevant to your changes -->\r\n\r\n<!-- to check an item, place an \"x\" in the box like so: \"- [x] Documentation\" -->\r\n\r\n* [ ] Documentation N/A\r\n* [ ] Tests N/A\r\n* [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->\r\n* [x] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->\r\n\r\n<!-- feel free to add additional comments -->","created_at":"2018-08-23T18:01:40Z","updated_at":"2018-08-23T18:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/pulls/14/commits","review_comments_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/pulls/14/comments","review_comment_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues/14/comments","statuses_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/statuses/fd497f061fa64448a09167043a43dd0cb2ff59c2","head":{"label":"gnapse:f/upgrade-some-dependencies","ref":"f/upgrade-some-dependencies","sha":"fd497f061fa64448a09167043a43dd0cb2ff59c2","user":{"login":"gnapse","id":15199,"node_id":"MDQ6VXNlcjE1MTk5","avatar_url":"https://avatars0.githubusercontent.com/u/15199?v=4","gravatar_id":"","url":"https://api.github.com/users/gnapse","html_url":"https://github.com/gnapse","followers_url":"https://api.github.com/users/gnapse/followers","following_url":"https://api.github.com/users/gnapse/following{/other_user}","gists_url":"https://api.github.com/users/gnapse/gists{/gist_id}","starred_url":"https://api.github.com/users/gnapse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnapse/subscriptions","organizations_url":"https://api.github.com/users/gnapse/orgs","repos_url":"https://api.github.com/users/gnapse/repos","events_url":"https://api.github.com/users/gnapse/events{/privacy}","received_events_url":"https://api.github.com/users/gnapse/received_events","type":"User","site_admin":false},"repo":{"id":145887468,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4ODc0Njg=","name":"cypress-testing-library","full_name":"gnapse/cypress-testing-library","owner":{"login":"gnapse","id":15199,"node_id":"MDQ6VXNlcjE1MTk5","avatar_url":"https://avatars0.githubusercontent.com/u/15199?v=4","gravatar_id":"","url":"https://api.github.com/users/gnapse","html_url":"https://github.com/gnapse","followers_url":"https://api.github.com/users/gnapse/followers","following_url":"https://api.github.com/users/gnapse/following{/other_user}","gists_url":"https://api.github.com/users/gnapse/gists{/gist_id}","starred_url":"https://api.github.com/users/gnapse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnapse/subscriptions","organizations_url":"https://api.github.com/users/gnapse/orgs","repos_url":"https://api.github.com/users/gnapse/repos","events_url":"https://api.github.com/users/gnapse/events{/privacy}","received_events_url":"https://api.github.com/users/gnapse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gnapse/cypress-testing-library","description":"🐅 Simple and complete custom Cypress commands and utilities that encourage good testing practices.","fork":true,"url":"https://api.github.com/repos/gnapse/cypress-testing-library","forks_url":"https://api.github.com/repos/gnapse/cypress-testing-library/forks","keys_url":"https://api.github.com/repos/gnapse/cypress-testing-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnapse/cypress-testing-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnapse/cypress-testing-library/teams","hooks_url":"https://api.github.com/repos/gnapse/cypress-testing-library/hooks","issue_events_url":"https://api.github.com/repos/gnapse/cypress-testing-library/issues/events{/number}","events_url":"https://api.github.com/repos/gnapse/cypress-testing-library/events","assignees_url":"https://api.github.com/repos/gnapse/cypress-testing-library/assignees{/user}","branches_url":"https://api.github.com/repos/gnapse/cypress-testing-library/branches{/branch}","tags_url":"https://api.github.com/repos/gnapse/cypress-testing-library/tags","blobs_url":"https://api.github.com/repos/gnapse/cypress-testing-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnapse/cypress-testing-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnapse/cypress-testing-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnapse/cypress-testing-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnapse/cypress-testing-library/statuses/{sha}","languages_url":"https://api.github.com/repos/gnapse/cypress-testing-library/languages","stargazers_url":"https://api.github.com/repos/gnapse/cypress-testing-library/stargazers","contributors_url":"https://api.github.com/repos/gnapse/cypress-testing-library/contributors","subscribers_url":"https://api.github.com/repos/gnapse/cypress-testing-library/subscribers","subscription_url":"https://api.github.com/repos/gnapse/cypress-testing-library/subscription","commits_url":"https://api.github.com/repos/gnapse/cypress-testing-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnapse/cypress-testing-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnapse/cypress-testing-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnapse/cypress-testing-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnapse/cypress-testing-library/contents/{+path}","compare_url":"https://api.github.com/repos/gnapse/cypress-testing-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnapse/cypress-testing-library/merges","archive_url":"https://api.github.com/repos/gnapse/cypress-testing-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnapse/cypress-testing-library/downloads","issues_url":"https://api.github.com/repos/gnapse/cypress-testing-library/issues{/number}","pulls_url":"https://api.github.com/repos/gnapse/cypress-testing-library/pulls{/number}","milestones_url":"https://api.github.com/repos/gnapse/cypress-testing-library/milestones{/number}","notifications_url":"https://api.github.com/repos/gnapse/cypress-testing-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnapse/cypress-testing-library/labels{/name}","releases_url":"https://api.github.com/repos/gnapse/cypress-testing-library/releases{/id}","deployments_url":"https://api.github.com/repos/gnapse/cypress-testing-library/deployments","created_at":"2018-08-23T17:39:19Z","updated_at":"2018-08-23T17:39:21Z","pushed_at":"2018-08-23T17:56:24Z","git_url":"git://github.com/gnapse/cypress-testing-library.git","ssh_url":"git@github.com:gnapse/cypress-testing-library.git","clone_url":"https://github.com/gnapse/cypress-testing-library.git","svn_url":"https://github.com/gnapse/cypress-testing-library","homepage":"http://npm.im/cypress-testing-library","size":33,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kentcdodds:master","ref":"master","sha":"d105706ef175fb7bf0b898ad6de8c899c6fcce20","user":{"login":"kentcdodds","id":1500684,"node_id":"MDQ6VXNlcjE1MDA2ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"repo":{"id":128405915,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0MDU5MTU=","name":"cypress-testing-library","full_name":"kentcdodds/cypress-testing-library","owner":{"login":"kentcdodds","id":1500684,"node_id":"MDQ6VXNlcjE1MDA2ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kentcdodds/cypress-testing-library","description":"🐅 Simple and complete custom Cypress commands and utilities that encourage good testing practices.","fork":false,"url":"https://api.github.com/repos/kentcdodds/cypress-testing-library","forks_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/forks","keys_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/teams","hooks_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/hooks","issue_events_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues/events{/number}","events_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/events","assignees_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/assignees{/user}","branches_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/branches{/branch}","tags_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/tags","blobs_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/statuses/{sha}","languages_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/languages","stargazers_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/stargazers","contributors_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/contributors","subscribers_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/subscribers","subscription_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/subscription","commits_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/contents/{+path}","compare_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/merges","archive_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/downloads","issues_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues{/number}","pulls_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/pulls{/number}","milestones_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/milestones{/number}","notifications_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/labels{/name}","releases_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/releases{/id}","deployments_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/deployments","created_at":"2018-04-06T14:31:43Z","updated_at":"2018-08-23T16:09:10Z","pushed_at":"2018-06-05T18:09:44Z","git_url":"git://github.com/kentcdodds/cypress-testing-library.git","ssh_url":"git@github.com:kentcdodds/cypress-testing-library.git","clone_url":"https://github.com/kentcdodds/cypress-testing-library.git","svn_url":"https://github.com/kentcdodds/cypress-testing-library","homepage":"http://npm.im/cypress-testing-library","size":33,"stargazers_count":173,"watchers_count":173,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":3,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kentcdodds/cypress-testing-library/pulls/14"},"html":{"href":"https://github.com/kentcdodds/cypress-testing-library/pull/14"},"issue":{"href":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues/14"},"comments":{"href":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/kentcdodds/cypress-testing-library/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/kentcdodds/cypress-testing-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kentcdodds/cypress-testing-library/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/kentcdodds/cypress-testing-library/statuses/fd497f061fa64448a09167043a43dd0cb2ff59c2"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":3,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"gnapse"}}