{"action":"created","comment":{"url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls/comments/167329250","pull_request_review_id":95541863,"id":167329250,"diff_hunk":"@@ -560,10 +560,10 @@ export declare abstract class Model<T extends Model<T>> extends Hooks {\n    * @param options.reset Clear all previously set data values\n    */\n   set(key: string, value: any, options?: InstanceSetOptions): this;\n-  set(keys: Object, options?: InstanceSetOptions): this;\n+  set(keys: Partial<T>, options?: InstanceSetOptions): this;\n \n   setAttributes(key: string, value: any, options?: InstanceSetOptions): this;\n-  setAttributes(keys: Object, options?: InstanceSetOptions): this;\n+  setAttributes(keys: Partial<T>, options?: InstanceSetOptions): this;","path":"lib/models/Model.d.ts","position":9,"original_position":9,"commit_id":"513b5ff9d46053b2e817341dc01d887c230b8c8e","original_commit_id":"513b5ff9d46053b2e817341dc01d887c230b8c8e","user":{"login":"RobinBuschmann","id":5270739,"avatar_url":"https://avatars0.githubusercontent.com/u/5270739?v=4","gravatar_id":"","url":"https://api.github.com/users/RobinBuschmann","html_url":"https://github.com/RobinBuschmann","followers_url":"https://api.github.com/users/RobinBuschmann/followers","following_url":"https://api.github.com/users/RobinBuschmann/following{/other_user}","gists_url":"https://api.github.com/users/RobinBuschmann/gists{/gist_id}","starred_url":"https://api.github.com/users/RobinBuschmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobinBuschmann/subscriptions","organizations_url":"https://api.github.com/users/RobinBuschmann/orgs","repos_url":"https://api.github.com/users/RobinBuschmann/repos","events_url":"https://api.github.com/users/RobinBuschmann/events{/privacy}","received_events_url":"https://api.github.com/users/RobinBuschmann/received_events","type":"User","site_admin":false},"body":"same here..","created_at":"2018-02-09T19:51:30Z","updated_at":"2018-02-09T19:52:01Z","html_url":"https://github.com/RobinBuschmann/sequelize-typescript/pull/293#discussion_r167329250","pull_request_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls/293","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls/comments/167329250"},"html":{"href":"https://github.com/RobinBuschmann/sequelize-typescript/pull/293#discussion_r167329250"},"pull_request":{"href":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls/293"}}},"pull_request":{"url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls/293","id":167556878,"html_url":"https://github.com/RobinBuschmann/sequelize-typescript/pull/293","diff_url":"https://github.com/RobinBuschmann/sequelize-typescript/pull/293.diff","patch_url":"https://github.com/RobinBuschmann/sequelize-typescript/pull/293.patch","issue_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/issues/293","number":293,"state":"open","locked":false,"title":"Use Partial<T> for set and update keys","user":{"login":"omidkrad","id":767147,"avatar_url":"https://avatars3.githubusercontent.com/u/767147?v=4","gravatar_id":"","url":"https://api.github.com/users/omidkrad","html_url":"https://github.com/omidkrad","followers_url":"https://api.github.com/users/omidkrad/followers","following_url":"https://api.github.com/users/omidkrad/following{/other_user}","gists_url":"https://api.github.com/users/omidkrad/gists{/gist_id}","starred_url":"https://api.github.com/users/omidkrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omidkrad/subscriptions","organizations_url":"https://api.github.com/users/omidkrad/orgs","repos_url":"https://api.github.com/users/omidkrad/repos","events_url":"https://api.github.com/users/omidkrad/events{/privacy}","received_events_url":"https://api.github.com/users/omidkrad/received_events","type":"User","site_admin":false},"body":"This allows typescript to check only the model properties are passed to `set` and `update` methods.","created_at":"2018-02-06T23:18:38Z","updated_at":"2018-02-09T19:52:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"974c348d9dae3caf569efec43509727c91c8168c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls/293/commits","review_comments_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls/293/comments","review_comment_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/issues/293/comments","statuses_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/statuses/513b5ff9d46053b2e817341dc01d887c230b8c8e","head":{"label":"omidkrad:patch-2","ref":"patch-2","sha":"513b5ff9d46053b2e817341dc01d887c230b8c8e","user":{"login":"omidkrad","id":767147,"avatar_url":"https://avatars3.githubusercontent.com/u/767147?v=4","gravatar_id":"","url":"https://api.github.com/users/omidkrad","html_url":"https://github.com/omidkrad","followers_url":"https://api.github.com/users/omidkrad/followers","following_url":"https://api.github.com/users/omidkrad/following{/other_user}","gists_url":"https://api.github.com/users/omidkrad/gists{/gist_id}","starred_url":"https://api.github.com/users/omidkrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omidkrad/subscriptions","organizations_url":"https://api.github.com/users/omidkrad/orgs","repos_url":"https://api.github.com/users/omidkrad/repos","events_url":"https://api.github.com/users/omidkrad/events{/privacy}","received_events_url":"https://api.github.com/users/omidkrad/received_events","type":"User","site_admin":false},"repo":{"id":115669832,"name":"sequelize-typescript","full_name":"omidkrad/sequelize-typescript","owner":{"login":"omidkrad","id":767147,"avatar_url":"https://avatars3.githubusercontent.com/u/767147?v=4","gravatar_id":"","url":"https://api.github.com/users/omidkrad","html_url":"https://github.com/omidkrad","followers_url":"https://api.github.com/users/omidkrad/followers","following_url":"https://api.github.com/users/omidkrad/following{/other_user}","gists_url":"https://api.github.com/users/omidkrad/gists{/gist_id}","starred_url":"https://api.github.com/users/omidkrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omidkrad/subscriptions","organizations_url":"https://api.github.com/users/omidkrad/orgs","repos_url":"https://api.github.com/users/omidkrad/repos","events_url":"https://api.github.com/users/omidkrad/events{/privacy}","received_events_url":"https://api.github.com/users/omidkrad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omidkrad/sequelize-typescript","description":"Decorators and some other features for sequelize (v3 + v4)","fork":true,"url":"https://api.github.com/repos/omidkrad/sequelize-typescript","forks_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/forks","keys_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/teams","hooks_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/hooks","issue_events_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/issues/events{/number}","events_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/events","assignees_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/assignees{/user}","branches_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/branches{/branch}","tags_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/tags","blobs_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/languages","stargazers_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/stargazers","contributors_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/contributors","subscribers_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/subscribers","subscription_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/subscription","commits_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/contents/{+path}","compare_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/merges","archive_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/downloads","issues_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/issues{/number}","pulls_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/labels{/name}","releases_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/releases{/id}","deployments_url":"https://api.github.com/repos/omidkrad/sequelize-typescript/deployments","created_at":"2017-12-29T00:20:11Z","updated_at":"2017-12-29T00:20:13Z","pushed_at":"2018-02-06T23:18:08Z","git_url":"git://github.com/omidkrad/sequelize-typescript.git","ssh_url":"git@github.com:omidkrad/sequelize-typescript.git","clone_url":"https://github.com/omidkrad/sequelize-typescript.git","svn_url":"https://github.com/omidkrad/sequelize-typescript","homepage":"","size":3364,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RobinBuschmann:master","ref":"master","sha":"4302356c452bfc27b1ba0117cc8abae170dd1e35","user":{"login":"RobinBuschmann","id":5270739,"avatar_url":"https://avatars0.githubusercontent.com/u/5270739?v=4","gravatar_id":"","url":"https://api.github.com/users/RobinBuschmann","html_url":"https://github.com/RobinBuschmann","followers_url":"https://api.github.com/users/RobinBuschmann/followers","following_url":"https://api.github.com/users/RobinBuschmann/following{/other_user}","gists_url":"https://api.github.com/users/RobinBuschmann/gists{/gist_id}","starred_url":"https://api.github.com/users/RobinBuschmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobinBuschmann/subscriptions","organizations_url":"https://api.github.com/users/RobinBuschmann/orgs","repos_url":"https://api.github.com/users/RobinBuschmann/repos","events_url":"https://api.github.com/users/RobinBuschmann/events{/privacy}","received_events_url":"https://api.github.com/users/RobinBuschmann/received_events","type":"User","site_admin":false},"repo":{"id":50502690,"name":"sequelize-typescript","full_name":"RobinBuschmann/sequelize-typescript","owner":{"login":"RobinBuschmann","id":5270739,"avatar_url":"https://avatars0.githubusercontent.com/u/5270739?v=4","gravatar_id":"","url":"https://api.github.com/users/RobinBuschmann","html_url":"https://github.com/RobinBuschmann","followers_url":"https://api.github.com/users/RobinBuschmann/followers","following_url":"https://api.github.com/users/RobinBuschmann/following{/other_user}","gists_url":"https://api.github.com/users/RobinBuschmann/gists{/gist_id}","starred_url":"https://api.github.com/users/RobinBuschmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobinBuschmann/subscriptions","organizations_url":"https://api.github.com/users/RobinBuschmann/orgs","repos_url":"https://api.github.com/users/RobinBuschmann/repos","events_url":"https://api.github.com/users/RobinBuschmann/events{/privacy}","received_events_url":"https://api.github.com/users/RobinBuschmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RobinBuschmann/sequelize-typescript","description":"Decorators and some other features for sequelize (v3 + v4)","fork":false,"url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript","forks_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/forks","keys_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/teams","hooks_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/hooks","issue_events_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/issues/events{/number}","events_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/events","assignees_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/assignees{/user}","branches_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/branches{/branch}","tags_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/tags","blobs_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/languages","stargazers_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/stargazers","contributors_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/contributors","subscribers_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/subscribers","subscription_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/subscription","commits_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/contents/{+path}","compare_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/merges","archive_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/downloads","issues_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/issues{/number}","pulls_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/labels{/name}","releases_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/releases{/id}","deployments_url":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/deployments","created_at":"2016-01-27T11:25:52Z","updated_at":"2018-02-09T16:19:53Z","pushed_at":"2018-02-09T14:28:21Z","git_url":"git://github.com/RobinBuschmann/sequelize-typescript.git","ssh_url":"git@github.com:RobinBuschmann/sequelize-typescript.git","clone_url":"https://github.com/RobinBuschmann/sequelize-typescript.git","svn_url":"https://github.com/RobinBuschmann/sequelize-typescript","homepage":"","size":3344,"stargazers_count":367,"watchers_count":367,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":54,"open_issues":53,"watchers":367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls/293"},"html":{"href":"https://github.com/RobinBuschmann/sequelize-typescript/pull/293"},"issue":{"href":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/issues/293"},"comments":{"href":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/RobinBuschmann/sequelize-typescript/statuses/513b5ff9d46053b2e817341dc01d887c230b8c8e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RobinBuschmann"}}