{"action":"created","comment":{"url":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments/213997665","pull_request_review_id":150944232,"id":213997665,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzk5NzY2NQ==","diff_hunk":"@@ -2523,23 +2586,27 @@ void StreamIndexedIO::Index::commitNodeToSubIndex( DirectoryNode *n )\n \tif ( n->subindex() == DirectoryNode::NoSubIndex )\n \t{\n \t\tMemoryStreamSink sink;\n-\t\tio::filtering_ostream compressingStream;\n-\t\tcompressingStream.push( io::gzip_compressor() );\n-\t\tcompressingStream.push( sink );\n-\t\tassert( compressingStream.is_complete() );\n+\t\tio::filtering_ostream outIndexStream;\n+\t\toutIndexStream.push( sink );\n+\t\tassert( outIndexStream.is_complete() );\n \n-\t\twriteNodeChildren( n, compressingStream );\n+\t\twriteNodeChildren( n, outIndexStream );\n \n-\t\tcompressingStream.pop();\n-\t\tcompressingStream.pop();\n+\t\toutIndexStream.pop();\n \n-\t\tchar *data=nullptr;\n-\t\tstd::streamsize sz;\n-\t\tsink.get( data, sz );\n-\t\tuint32_t subindexSize = sz;\n+\t\t// compress the output stream using blosc before writing\n+\t\tchar* indexData = nullptr;\n+\t\tstd::streamsize indexDataSize;\n+\n+\t\tsink.get(indexData, indexDataSize);\n+\n+\t\tstd::vector<char> compressedIndex;\n+\t\tcompress( indexData, indexDataSize, compressedIndex, 9, \"lz4\", 1, BLOSC_MAX_BUFFERSIZE, 0);","path":"src/IECore/StreamIndexedIO.cpp","position":null,"original_position":222,"commit_id":"f7e348425a93c1f36729b4e40a424078134c5794","original_commit_id":"770f6ed113336dbcf02abc7e4f4f29ba5c7a911e","user":{"login":"johnhaddon","id":1133871,"node_id":"MDQ6VXNlcjExMzM4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1133871?v=4","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"body":"Should this be using `m_compressor`, `m_compressionLevel` etc? I guess the problem is that those default to no compression, but we've always had compression unconditionally on for the index?","created_at":"2018-08-30T11:41:59Z","updated_at":"2018-08-30T11:49:18Z","html_url":"https://github.com/ImageEngine/cortex/pull/813#discussion_r213997665","pull_request_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/813","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments/213997665"},"html":{"href":"https://github.com/ImageEngine/cortex/pull/813#discussion_r213997665"},"pull_request":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/813"}}},"pull_request":{"url":"https://api.github.com/repos/ImageEngine/cortex/pulls/813","id":200525408,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTI1NDA4","html_url":"https://github.com/ImageEngine/cortex/pull/813","diff_url":"https://github.com/ImageEngine/cortex/pull/813.diff","patch_url":"https://github.com/ImageEngine/cortex/pull/813.patch","issue_url":"https://api.github.com/repos/ImageEngine/cortex/issues/813","number":813,"state":"open","locked":false,"title":"Indexed io blosc index","user":{"login":"donboie","id":25311256,"node_id":"MDQ6VXNlcjI1MzExMjU2","avatar_url":"https://avatars1.githubusercontent.com/u/25311256?v=4","gravatar_id":"","url":"https://api.github.com/users/donboie","html_url":"https://github.com/donboie","followers_url":"https://api.github.com/users/donboie/followers","following_url":"https://api.github.com/users/donboie/following{/other_user}","gists_url":"https://api.github.com/users/donboie/gists{/gist_id}","starred_url":"https://api.github.com/users/donboie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donboie/subscriptions","organizations_url":"https://api.github.com/users/donboie/orgs","repos_url":"https://api.github.com/users/donboie/repos","events_url":"https://api.github.com/users/donboie/events{/privacy}","received_events_url":"https://api.github.com/users/donboie/received_events","type":"User","site_admin":false},"body":"Improves scene cache write performance in location heavy scenes by 20%","created_at":"2018-07-10T21:13:48Z","updated_at":"2018-08-30T11:49:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c678d6a77e816b918894ab0917dd9e75a7aae286","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/813/commits","review_comments_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/813/comments","review_comment_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ImageEngine/cortex/issues/813/comments","statuses_url":"https://api.github.com/repos/ImageEngine/cortex/statuses/f7e348425a93c1f36729b4e40a424078134c5794","head":{"label":"donboie:IndexedIOBloscIndex","ref":"IndexedIOBloscIndex","sha":"f7e348425a93c1f36729b4e40a424078134c5794","user":{"login":"donboie","id":25311256,"node_id":"MDQ6VXNlcjI1MzExMjU2","avatar_url":"https://avatars1.githubusercontent.com/u/25311256?v=4","gravatar_id":"","url":"https://api.github.com/users/donboie","html_url":"https://github.com/donboie","followers_url":"https://api.github.com/users/donboie/followers","following_url":"https://api.github.com/users/donboie/following{/other_user}","gists_url":"https://api.github.com/users/donboie/gists{/gist_id}","starred_url":"https://api.github.com/users/donboie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donboie/subscriptions","organizations_url":"https://api.github.com/users/donboie/orgs","repos_url":"https://api.github.com/users/donboie/repos","events_url":"https://api.github.com/users/donboie/events{/privacy}","received_events_url":"https://api.github.com/users/donboie/received_events","type":"User","site_admin":false},"repo":{"id":80573606,"node_id":"MDEwOlJlcG9zaXRvcnk4MDU3MzYwNg==","name":"cortex","full_name":"donboie/cortex","owner":{"login":"donboie","id":25311256,"node_id":"MDQ6VXNlcjI1MzExMjU2","avatar_url":"https://avatars1.githubusercontent.com/u/25311256?v=4","gravatar_id":"","url":"https://api.github.com/users/donboie","html_url":"https://github.com/donboie","followers_url":"https://api.github.com/users/donboie/followers","following_url":"https://api.github.com/users/donboie/following{/other_user}","gists_url":"https://api.github.com/users/donboie/gists{/gist_id}","starred_url":"https://api.github.com/users/donboie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donboie/subscriptions","organizations_url":"https://api.github.com/users/donboie/orgs","repos_url":"https://api.github.com/users/donboie/repos","events_url":"https://api.github.com/users/donboie/events{/privacy}","received_events_url":"https://api.github.com/users/donboie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/donboie/cortex","description":"Libraries for visual effects software development","fork":true,"url":"https://api.github.com/repos/donboie/cortex","forks_url":"https://api.github.com/repos/donboie/cortex/forks","keys_url":"https://api.github.com/repos/donboie/cortex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donboie/cortex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donboie/cortex/teams","hooks_url":"https://api.github.com/repos/donboie/cortex/hooks","issue_events_url":"https://api.github.com/repos/donboie/cortex/issues/events{/number}","events_url":"https://api.github.com/repos/donboie/cortex/events","assignees_url":"https://api.github.com/repos/donboie/cortex/assignees{/user}","branches_url":"https://api.github.com/repos/donboie/cortex/branches{/branch}","tags_url":"https://api.github.com/repos/donboie/cortex/tags","blobs_url":"https://api.github.com/repos/donboie/cortex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donboie/cortex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donboie/cortex/git/refs{/sha}","trees_url":"https://api.github.com/repos/donboie/cortex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donboie/cortex/statuses/{sha}","languages_url":"https://api.github.com/repos/donboie/cortex/languages","stargazers_url":"https://api.github.com/repos/donboie/cortex/stargazers","contributors_url":"https://api.github.com/repos/donboie/cortex/contributors","subscribers_url":"https://api.github.com/repos/donboie/cortex/subscribers","subscription_url":"https://api.github.com/repos/donboie/cortex/subscription","commits_url":"https://api.github.com/repos/donboie/cortex/commits{/sha}","git_commits_url":"https://api.github.com/repos/donboie/cortex/git/commits{/sha}","comments_url":"https://api.github.com/repos/donboie/cortex/comments{/number}","issue_comment_url":"https://api.github.com/repos/donboie/cortex/issues/comments{/number}","contents_url":"https://api.github.com/repos/donboie/cortex/contents/{+path}","compare_url":"https://api.github.com/repos/donboie/cortex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donboie/cortex/merges","archive_url":"https://api.github.com/repos/donboie/cortex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donboie/cortex/downloads","issues_url":"https://api.github.com/repos/donboie/cortex/issues{/number}","pulls_url":"https://api.github.com/repos/donboie/cortex/pulls{/number}","milestones_url":"https://api.github.com/repos/donboie/cortex/milestones{/number}","notifications_url":"https://api.github.com/repos/donboie/cortex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donboie/cortex/labels{/name}","releases_url":"https://api.github.com/repos/donboie/cortex/releases{/id}","deployments_url":"https://api.github.com/repos/donboie/cortex/deployments","created_at":"2017-01-31T23:39:09Z","updated_at":"2018-04-20T03:14:07Z","pushed_at":"2018-08-29T21:43:40Z","git_url":"git://github.com/donboie/cortex.git","ssh_url":"git@github.com:donboie/cortex.git","clone_url":"https://github.com/donboie/cortex.git","svn_url":"https://github.com/donboie/cortex","homepage":null,"size":105522,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ImageEngine:master","ref":"master","sha":"1755aef1712520db0280e53c59e9d4f6fa60f0f1","user":{"login":"ImageEngine","id":3976662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzY2NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/3976662?v=4","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":10654465,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY1NDQ2NQ==","name":"cortex","full_name":"ImageEngine/cortex","owner":{"login":"ImageEngine","id":3976662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzY2NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/3976662?v=4","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ImageEngine/cortex","description":"Libraries for visual effects software development","fork":false,"url":"https://api.github.com/repos/ImageEngine/cortex","forks_url":"https://api.github.com/repos/ImageEngine/cortex/forks","keys_url":"https://api.github.com/repos/ImageEngine/cortex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ImageEngine/cortex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ImageEngine/cortex/teams","hooks_url":"https://api.github.com/repos/ImageEngine/cortex/hooks","issue_events_url":"https://api.github.com/repos/ImageEngine/cortex/issues/events{/number}","events_url":"https://api.github.com/repos/ImageEngine/cortex/events","assignees_url":"https://api.github.com/repos/ImageEngine/cortex/assignees{/user}","branches_url":"https://api.github.com/repos/ImageEngine/cortex/branches{/branch}","tags_url":"https://api.github.com/repos/ImageEngine/cortex/tags","blobs_url":"https://api.github.com/repos/ImageEngine/cortex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ImageEngine/cortex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ImageEngine/cortex/git/refs{/sha}","trees_url":"https://api.github.com/repos/ImageEngine/cortex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ImageEngine/cortex/statuses/{sha}","languages_url":"https://api.github.com/repos/ImageEngine/cortex/languages","stargazers_url":"https://api.github.com/repos/ImageEngine/cortex/stargazers","contributors_url":"https://api.github.com/repos/ImageEngine/cortex/contributors","subscribers_url":"https://api.github.com/repos/ImageEngine/cortex/subscribers","subscription_url":"https://api.github.com/repos/ImageEngine/cortex/subscription","commits_url":"https://api.github.com/repos/ImageEngine/cortex/commits{/sha}","git_commits_url":"https://api.github.com/repos/ImageEngine/cortex/git/commits{/sha}","comments_url":"https://api.github.com/repos/ImageEngine/cortex/comments{/number}","issue_comment_url":"https://api.github.com/repos/ImageEngine/cortex/issues/comments{/number}","contents_url":"https://api.github.com/repos/ImageEngine/cortex/contents/{+path}","compare_url":"https://api.github.com/repos/ImageEngine/cortex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ImageEngine/cortex/merges","archive_url":"https://api.github.com/repos/ImageEngine/cortex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ImageEngine/cortex/downloads","issues_url":"https://api.github.com/repos/ImageEngine/cortex/issues{/number}","pulls_url":"https://api.github.com/repos/ImageEngine/cortex/pulls{/number}","milestones_url":"https://api.github.com/repos/ImageEngine/cortex/milestones{/number}","notifications_url":"https://api.github.com/repos/ImageEngine/cortex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ImageEngine/cortex/labels{/name}","releases_url":"https://api.github.com/repos/ImageEngine/cortex/releases{/id}","deployments_url":"https://api.github.com/repos/ImageEngine/cortex/deployments","created_at":"2013-06-12T23:12:28Z","updated_at":"2018-08-24T13:33:04Z","pushed_at":"2018-08-29T21:43:41Z","git_url":"git://github.com/ImageEngine/cortex.git","ssh_url":"git@github.com:ImageEngine/cortex.git","clone_url":"https://github.com/ImageEngine/cortex.git","svn_url":"https://github.com/ImageEngine/cortex","homepage":null,"size":105376,"stargazers_count":276,"watchers_count":276,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":82,"open_issues":45,"watchers":276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/813"},"html":{"href":"https://github.com/ImageEngine/cortex/pull/813"},"issue":{"href":"https://api.github.com/repos/ImageEngine/cortex/issues/813"},"comments":{"href":"https://api.github.com/repos/ImageEngine/cortex/issues/813/comments"},"review_comments":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/813/comments"},"review_comment":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/813/commits"},"statuses":{"href":"https://api.github.com/repos/ImageEngine/cortex/statuses/f7e348425a93c1f36729b4e40a424078134c5794"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"johnhaddon"}}