{"action":"created","comment":{"url":"https://api.github.com/repos/google/haskell-indexer/pulls/comments/235752631","pull_request_review_id":177690958,"id":235752631,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTc1MjYzMQ==","diff_hunk":"@@ -0,0 +1,56 @@\n+{-# LANGUAGE BangPatterns #-}\n+{-# LANGUAGE OverloadedStrings #-}\n+module Haskell.Indexer.Plugin where\n+\n+import GhcPlugins hiding (($$))\n+import TcRnTypes\n+\n+import TcRnMonad\n+import TcRnDriver\n+import GhcMonad\n+import Data.IORef\n+\n+import Language.Haskell.Indexer.Backend.Ghc\n+import Language.Haskell.Indexer.Backend.GhcEnv\n+import Language.Haskell.Indexer.Translate\n+import Language.Haskell.Indexer.Args\n+\n+import System.IO\n+import System.FilePath\n+import System.Directory\n+\n+plugin :: Plugin\n+plugin = defaultPlugin\n+          { renamedResultAction   = keepRenamedSource\n+          , typeCheckResultAction = install }\n+\n+mkPath :: FilePath -> Module -> FilePath\n+mkPath fp m\n+  = fp </> (moduleNameString (moduleName m) ++ (show (moduleUnitId m)))","path":"haskell-indexer-plugin/src/Haskell/Indexer/Plugin.hs","position":29,"original_position":29,"commit_id":"7622691f8fb9ebb020edf08679c41fcb7698f39d","original_commit_id":"7622691f8fb9ebb020edf08679c41fcb7698f39d","user":{"login":"facundominguez","id":1200667,"node_id":"MDQ6VXNlcjEyMDA2Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/1200667?v=4","gravatar_id":"","url":"https://api.github.com/users/facundominguez","html_url":"https://github.com/facundominguez","followers_url":"https://api.github.com/users/facundominguez/followers","following_url":"https://api.github.com/users/facundominguez/following{/other_user}","gists_url":"https://api.github.com/users/facundominguez/gists{/gist_id}","starred_url":"https://api.github.com/users/facundominguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facundominguez/subscriptions","organizations_url":"https://api.github.com/users/facundominguez/orgs","repos_url":"https://api.github.com/users/facundominguez/repos","events_url":"https://api.github.com/users/facundominguez/events{/privacy}","received_events_url":"https://api.github.com/users/facundominguez/received_events","type":"User","site_admin":false},"body":"Does `serve.sh` expect these to be called `*.entries`? It looks like either the script needs to be amended, or the plugin needs to change the names.","created_at":"2018-11-22T14:55:01Z","updated_at":"2018-11-22T14:55:01Z","html_url":"https://github.com/google/haskell-indexer/pull/89#discussion_r235752631","pull_request_url":"https://api.github.com/repos/google/haskell-indexer/pulls/89","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/google/haskell-indexer/pulls/comments/235752631"},"html":{"href":"https://github.com/google/haskell-indexer/pull/89#discussion_r235752631"},"pull_request":{"href":"https://api.github.com/repos/google/haskell-indexer/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/google/haskell-indexer/pulls/89","id":232122221,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTIyMjIx","html_url":"https://github.com/google/haskell-indexer/pull/89","diff_url":"https://github.com/google/haskell-indexer/pull/89.diff","patch_url":"https://github.com/google/haskell-indexer/pull/89.patch","issue_url":"https://api.github.com/repos/google/haskell-indexer/issues/89","number":89,"state":"open","locked":false,"title":"WIP: Implement a Source Plugin","user":{"login":"mpickering","id":1216657,"node_id":"MDQ6VXNlcjEyMTY2NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1216657?v=4","gravatar_id":"","url":"https://api.github.com/users/mpickering","html_url":"https://github.com/mpickering","followers_url":"https://api.github.com/users/mpickering/followers","following_url":"https://api.github.com/users/mpickering/following{/other_user}","gists_url":"https://api.github.com/users/mpickering/gists{/gist_id}","starred_url":"https://api.github.com/users/mpickering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpickering/subscriptions","organizations_url":"https://api.github.com/users/mpickering/orgs","repos_url":"https://api.github.com/users/mpickering/repos","events_url":"https://api.github.com/users/mpickering/events{/privacy}","received_events_url":"https://api.github.com/users/mpickering/received_events","type":"User","site_admin":false},"body":"There are some issues with not as many things being cross-referenced but it mostly works as expected. I'm putting it up here now for early review and if anyone else wants to try it.\r\n\r\nCloses #88 \r\n\r\ncc/ @facundominguez @nh2\r\n\r\nTODO:\r\n\r\n- [x] Investigate why type signatures are not indexed\r\n- [ ] Fix verifier errors\r\n- [ ] Properly emit the module tick information\r\n- [ ] Add documentation\r\n- [ ] Respond to Robin's code review","created_at":"2018-11-19T21:47:40Z","updated_at":"2018-11-22T14:55:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b3a0a7f9ac6e1bae510156e9f26331e6b73e934","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/haskell-indexer/pulls/89/commits","review_comments_url":"https://api.github.com/repos/google/haskell-indexer/pulls/89/comments","review_comment_url":"https://api.github.com/repos/google/haskell-indexer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/haskell-indexer/issues/89/comments","statuses_url":"https://api.github.com/repos/google/haskell-indexer/statuses/7622691f8fb9ebb020edf08679c41fcb7698f39d","head":{"label":"mpickering:source-plugin","ref":"source-plugin","sha":"7622691f8fb9ebb020edf08679c41fcb7698f39d","user":{"login":"mpickering","id":1216657,"node_id":"MDQ6VXNlcjEyMTY2NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1216657?v=4","gravatar_id":"","url":"https://api.github.com/users/mpickering","html_url":"https://github.com/mpickering","followers_url":"https://api.github.com/users/mpickering/followers","following_url":"https://api.github.com/users/mpickering/following{/other_user}","gists_url":"https://api.github.com/users/mpickering/gists{/gist_id}","starred_url":"https://api.github.com/users/mpickering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpickering/subscriptions","organizations_url":"https://api.github.com/users/mpickering/orgs","repos_url":"https://api.github.com/users/mpickering/repos","events_url":"https://api.github.com/users/mpickering/events{/privacy}","received_events_url":"https://api.github.com/users/mpickering/received_events","type":"User","site_admin":false},"repo":{"id":97728740,"node_id":"MDEwOlJlcG9zaXRvcnk5NzcyODc0MA==","name":"haskell-indexer","full_name":"mpickering/haskell-indexer","private":false,"owner":{"login":"mpickering","id":1216657,"node_id":"MDQ6VXNlcjEyMTY2NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1216657?v=4","gravatar_id":"","url":"https://api.github.com/users/mpickering","html_url":"https://github.com/mpickering","followers_url":"https://api.github.com/users/mpickering/followers","following_url":"https://api.github.com/users/mpickering/following{/other_user}","gists_url":"https://api.github.com/users/mpickering/gists{/gist_id}","starred_url":"https://api.github.com/users/mpickering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpickering/subscriptions","organizations_url":"https://api.github.com/users/mpickering/orgs","repos_url":"https://api.github.com/users/mpickering/repos","events_url":"https://api.github.com/users/mpickering/events{/privacy}","received_events_url":"https://api.github.com/users/mpickering/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mpickering/haskell-indexer","description":"Emits code crossreference data for Haskell sources.","fork":true,"url":"https://api.github.com/repos/mpickering/haskell-indexer","forks_url":"https://api.github.com/repos/mpickering/haskell-indexer/forks","keys_url":"https://api.github.com/repos/mpickering/haskell-indexer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpickering/haskell-indexer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpickering/haskell-indexer/teams","hooks_url":"https://api.github.com/repos/mpickering/haskell-indexer/hooks","issue_events_url":"https://api.github.com/repos/mpickering/haskell-indexer/issues/events{/number}","events_url":"https://api.github.com/repos/mpickering/haskell-indexer/events","assignees_url":"https://api.github.com/repos/mpickering/haskell-indexer/assignees{/user}","branches_url":"https://api.github.com/repos/mpickering/haskell-indexer/branches{/branch}","tags_url":"https://api.github.com/repos/mpickering/haskell-indexer/tags","blobs_url":"https://api.github.com/repos/mpickering/haskell-indexer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpickering/haskell-indexer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpickering/haskell-indexer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpickering/haskell-indexer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpickering/haskell-indexer/statuses/{sha}","languages_url":"https://api.github.com/repos/mpickering/haskell-indexer/languages","stargazers_url":"https://api.github.com/repos/mpickering/haskell-indexer/stargazers","contributors_url":"https://api.github.com/repos/mpickering/haskell-indexer/contributors","subscribers_url":"https://api.github.com/repos/mpickering/haskell-indexer/subscribers","subscription_url":"https://api.github.com/repos/mpickering/haskell-indexer/subscription","commits_url":"https://api.github.com/repos/mpickering/haskell-indexer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpickering/haskell-indexer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpickering/haskell-indexer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpickering/haskell-indexer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpickering/haskell-indexer/contents/{+path}","compare_url":"https://api.github.com/repos/mpickering/haskell-indexer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpickering/haskell-indexer/merges","archive_url":"https://api.github.com/repos/mpickering/haskell-indexer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpickering/haskell-indexer/downloads","issues_url":"https://api.github.com/repos/mpickering/haskell-indexer/issues{/number}","pulls_url":"https://api.github.com/repos/mpickering/haskell-indexer/pulls{/number}","milestones_url":"https://api.github.com/repos/mpickering/haskell-indexer/milestones{/number}","notifications_url":"https://api.github.com/repos/mpickering/haskell-indexer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpickering/haskell-indexer/labels{/name}","releases_url":"https://api.github.com/repos/mpickering/haskell-indexer/releases{/id}","deployments_url":"https://api.github.com/repos/mpickering/haskell-indexer/deployments","created_at":"2017-07-19T14:53:04Z","updated_at":"2017-07-19T14:53:06Z","pushed_at":"2018-11-21T12:35:48Z","git_url":"git://github.com/mpickering/haskell-indexer.git","ssh_url":"git@github.com:mpickering/haskell-indexer.git","clone_url":"https://github.com/mpickering/haskell-indexer.git","svn_url":"https://github.com/mpickering/haskell-indexer","homepage":"","size":261,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"2f2b98e5614ed05c632e7590ad9b696d1ac4652b","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":92573821,"node_id":"MDEwOlJlcG9zaXRvcnk5MjU3MzgyMQ==","name":"haskell-indexer","full_name":"google/haskell-indexer","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/haskell-indexer","description":"Emits code crossreference data for Haskell sources.","fork":false,"url":"https://api.github.com/repos/google/haskell-indexer","forks_url":"https://api.github.com/repos/google/haskell-indexer/forks","keys_url":"https://api.github.com/repos/google/haskell-indexer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/haskell-indexer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/haskell-indexer/teams","hooks_url":"https://api.github.com/repos/google/haskell-indexer/hooks","issue_events_url":"https://api.github.com/repos/google/haskell-indexer/issues/events{/number}","events_url":"https://api.github.com/repos/google/haskell-indexer/events","assignees_url":"https://api.github.com/repos/google/haskell-indexer/assignees{/user}","branches_url":"https://api.github.com/repos/google/haskell-indexer/branches{/branch}","tags_url":"https://api.github.com/repos/google/haskell-indexer/tags","blobs_url":"https://api.github.com/repos/google/haskell-indexer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/haskell-indexer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/haskell-indexer/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/haskell-indexer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/haskell-indexer/statuses/{sha}","languages_url":"https://api.github.com/repos/google/haskell-indexer/languages","stargazers_url":"https://api.github.com/repos/google/haskell-indexer/stargazers","contributors_url":"https://api.github.com/repos/google/haskell-indexer/contributors","subscribers_url":"https://api.github.com/repos/google/haskell-indexer/subscribers","subscription_url":"https://api.github.com/repos/google/haskell-indexer/subscription","commits_url":"https://api.github.com/repos/google/haskell-indexer/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/haskell-indexer/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/haskell-indexer/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/haskell-indexer/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/haskell-indexer/contents/{+path}","compare_url":"https://api.github.com/repos/google/haskell-indexer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/haskell-indexer/merges","archive_url":"https://api.github.com/repos/google/haskell-indexer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/haskell-indexer/downloads","issues_url":"https://api.github.com/repos/google/haskell-indexer/issues{/number}","pulls_url":"https://api.github.com/repos/google/haskell-indexer/pulls{/number}","milestones_url":"https://api.github.com/repos/google/haskell-indexer/milestones{/number}","notifications_url":"https://api.github.com/repos/google/haskell-indexer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/haskell-indexer/labels{/name}","releases_url":"https://api.github.com/repos/google/haskell-indexer/releases{/id}","deployments_url":"https://api.github.com/repos/google/haskell-indexer/deployments","created_at":"2017-05-27T05:39:45Z","updated_at":"2018-11-21T13:34:25Z","pushed_at":"2018-11-21T12:35:50Z","git_url":"git://github.com/google/haskell-indexer.git","ssh_url":"git@github.com:google/haskell-indexer.git","clone_url":"https://github.com/google/haskell-indexer.git","svn_url":"https://github.com/google/haskell-indexer","homepage":"","size":234,"stargazers_count":69,"watchers_count":69,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":48,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/haskell-indexer/pulls/89"},"html":{"href":"https://github.com/google/haskell-indexer/pull/89"},"issue":{"href":"https://api.github.com/repos/google/haskell-indexer/issues/89"},"comments":{"href":"https://api.github.com/repos/google/haskell-indexer/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/google/haskell-indexer/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/google/haskell-indexer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/haskell-indexer/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/google/haskell-indexer/statuses/7622691f8fb9ebb020edf08679c41fcb7698f39d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"facundominguez"}}