{"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls/comments/176966403","pull_request_review_id":106756849,"id":176966403,"diff_hunk":"@@ -339,3 +412,42 @@ function Test-DailyBuild\n \n     return $false\n }\n+function Publish-ModuleArtifacts {\n+\n+    if(Test-Path -Path $ArtifactRoot) {\n+        Remove-Item -Path $ArtifactRoot -Recurse -Force\n+    }\n+\n+    New-Item -Path $ArtifactRoot -ItemType Directory | Out-Null\n+\n+    # Copy the module into the dist folder\n+    Copy-Item -Path $ModuleRoot -Destination $ArtifactRoot -Recurse","path":"tools/build.psm1","position":157,"original_position":157,"commit_id":"bcda230c1caaa6beec1bfa3a6b9120c39efd8f05","original_commit_id":"bcda230c1caaa6beec1bfa3a6b9120c39efd8f05","user":{"login":"bmanikm","id":5000058,"avatar_url":"https://avatars3.githubusercontent.com/u/5000058?v=4","gravatar_id":"","url":"https://api.github.com/users/bmanikm","html_url":"https://github.com/bmanikm","followers_url":"https://api.github.com/users/bmanikm/followers","following_url":"https://api.github.com/users/bmanikm/following{/other_user}","gists_url":"https://api.github.com/users/bmanikm/gists{/gist_id}","starred_url":"https://api.github.com/users/bmanikm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmanikm/subscriptions","organizations_url":"https://api.github.com/users/bmanikm/orgs","repos_url":"https://api.github.com/users/bmanikm/repos","events_url":"https://api.github.com/users/bmanikm/events{/privacy}","received_events_url":"https://api.github.com/users/bmanikm/received_events","type":"User","site_admin":false},"body":"@Benny1007 CI test runs should validate the generated module under /dist, right? otherwise, we are not sure /dist module is working fine or not. One such example is above mentioned Import-LocalizedData error.\r\n\r\nI think, we need to move some portion of the Invoke-PowerShellGetTest function to a new function and handle additional logic for copying the generated PowerShellGet module /dist during CI test runs. During local dev testing, I am fine with executing the tests on /PowerShellGet folder instead of /dist/PowerShellGet folder.","created_at":"2018-03-26T02:05:38Z","updated_at":"2018-03-26T02:05:38Z","html_url":"https://github.com/PowerShell/PowerShellGet/pull/242#discussion_r176966403","pull_request_url":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls/242","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls/comments/176966403"},"html":{"href":"https://github.com/PowerShell/PowerShellGet/pull/242#discussion_r176966403"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls/242"}},"in_reply_to_id":176927347},"pull_request":{"url":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls/242","id":174167092,"html_url":"https://github.com/PowerShell/PowerShellGet/pull/242","diff_url":"https://github.com/PowerShell/PowerShellGet/pull/242.diff","patch_url":"https://github.com/PowerShell/PowerShellGet/pull/242.patch","issue_url":"https://api.github.com/repos/PowerShell/PowerShellGet/issues/242","number":242,"state":"open","locked":false,"title":"Fix#240/add build step to construct psm1","user":{"login":"Benny1007","id":32260961,"avatar_url":"https://avatars0.githubusercontent.com/u/32260961?v=4","gravatar_id":"","url":"https://api.github.com/users/Benny1007","html_url":"https://github.com/Benny1007","followers_url":"https://api.github.com/users/Benny1007/followers","following_url":"https://api.github.com/users/Benny1007/following{/other_user}","gists_url":"https://api.github.com/users/Benny1007/gists{/gist_id}","starred_url":"https://api.github.com/users/Benny1007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benny1007/subscriptions","organizations_url":"https://api.github.com/users/Benny1007/orgs","repos_url":"https://api.github.com/users/Benny1007/repos","events_url":"https://api.github.com/users/Benny1007/events{/privacy}","received_events_url":"https://api.github.com/users/Benny1007/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-10T11:55:34Z","updated_at":"2018-03-26T02:05:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"519637b3972c4e9f6fcc68484b1477a19aee6a4b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls/242/commits","review_comments_url":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls/242/comments","review_comment_url":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/PowerShellGet/issues/242/comments","statuses_url":"https://api.github.com/repos/PowerShell/PowerShellGet/statuses/bcda230c1caaa6beec1bfa3a6b9120c39efd8f05","head":{"label":"Benny1007:fix#240/Add-build-step-to-construct-psm1","ref":"fix#240/Add-build-step-to-construct-psm1","sha":"bcda230c1caaa6beec1bfa3a6b9120c39efd8f05","user":{"login":"Benny1007","id":32260961,"avatar_url":"https://avatars0.githubusercontent.com/u/32260961?v=4","gravatar_id":"","url":"https://api.github.com/users/Benny1007","html_url":"https://github.com/Benny1007","followers_url":"https://api.github.com/users/Benny1007/followers","following_url":"https://api.github.com/users/Benny1007/following{/other_user}","gists_url":"https://api.github.com/users/Benny1007/gists{/gist_id}","starred_url":"https://api.github.com/users/Benny1007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benny1007/subscriptions","organizations_url":"https://api.github.com/users/Benny1007/orgs","repos_url":"https://api.github.com/users/Benny1007/repos","events_url":"https://api.github.com/users/Benny1007/events{/privacy}","received_events_url":"https://api.github.com/users/Benny1007/received_events","type":"User","site_admin":false},"repo":{"id":121234178,"name":"PowerShellGet","full_name":"Benny1007/PowerShellGet","owner":{"login":"Benny1007","id":32260961,"avatar_url":"https://avatars0.githubusercontent.com/u/32260961?v=4","gravatar_id":"","url":"https://api.github.com/users/Benny1007","html_url":"https://github.com/Benny1007","followers_url":"https://api.github.com/users/Benny1007/followers","following_url":"https://api.github.com/users/Benny1007/following{/other_user}","gists_url":"https://api.github.com/users/Benny1007/gists{/gist_id}","starred_url":"https://api.github.com/users/Benny1007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benny1007/subscriptions","organizations_url":"https://api.github.com/users/Benny1007/orgs","repos_url":"https://api.github.com/users/Benny1007/repos","events_url":"https://api.github.com/users/Benny1007/events{/privacy}","received_events_url":"https://api.github.com/users/Benny1007/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Benny1007/PowerShellGet","description":"PowerShellGet is the Package Manager for PowerShell","fork":true,"url":"https://api.github.com/repos/Benny1007/PowerShellGet","forks_url":"https://api.github.com/repos/Benny1007/PowerShellGet/forks","keys_url":"https://api.github.com/repos/Benny1007/PowerShellGet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Benny1007/PowerShellGet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Benny1007/PowerShellGet/teams","hooks_url":"https://api.github.com/repos/Benny1007/PowerShellGet/hooks","issue_events_url":"https://api.github.com/repos/Benny1007/PowerShellGet/issues/events{/number}","events_url":"https://api.github.com/repos/Benny1007/PowerShellGet/events","assignees_url":"https://api.github.com/repos/Benny1007/PowerShellGet/assignees{/user}","branches_url":"https://api.github.com/repos/Benny1007/PowerShellGet/branches{/branch}","tags_url":"https://api.github.com/repos/Benny1007/PowerShellGet/tags","blobs_url":"https://api.github.com/repos/Benny1007/PowerShellGet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Benny1007/PowerShellGet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Benny1007/PowerShellGet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Benny1007/PowerShellGet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Benny1007/PowerShellGet/statuses/{sha}","languages_url":"https://api.github.com/repos/Benny1007/PowerShellGet/languages","stargazers_url":"https://api.github.com/repos/Benny1007/PowerShellGet/stargazers","contributors_url":"https://api.github.com/repos/Benny1007/PowerShellGet/contributors","subscribers_url":"https://api.github.com/repos/Benny1007/PowerShellGet/subscribers","subscription_url":"https://api.github.com/repos/Benny1007/PowerShellGet/subscription","commits_url":"https://api.github.com/repos/Benny1007/PowerShellGet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Benny1007/PowerShellGet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Benny1007/PowerShellGet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Benny1007/PowerShellGet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Benny1007/PowerShellGet/contents/{+path}","compare_url":"https://api.github.com/repos/Benny1007/PowerShellGet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Benny1007/PowerShellGet/merges","archive_url":"https://api.github.com/repos/Benny1007/PowerShellGet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Benny1007/PowerShellGet/downloads","issues_url":"https://api.github.com/repos/Benny1007/PowerShellGet/issues{/number}","pulls_url":"https://api.github.com/repos/Benny1007/PowerShellGet/pulls{/number}","milestones_url":"https://api.github.com/repos/Benny1007/PowerShellGet/milestones{/number}","notifications_url":"https://api.github.com/repos/Benny1007/PowerShellGet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Benny1007/PowerShellGet/labels{/name}","releases_url":"https://api.github.com/repos/Benny1007/PowerShellGet/releases{/id}","deployments_url":"https://api.github.com/repos/Benny1007/PowerShellGet/deployments","created_at":"2018-02-12T10:42:24Z","updated_at":"2018-02-12T10:42:27Z","pushed_at":"2018-03-25T00:58:55Z","git_url":"git://github.com/Benny1007/PowerShellGet.git","ssh_url":"git@github.com:Benny1007/PowerShellGet.git","clone_url":"https://github.com/Benny1007/PowerShellGet.git","svn_url":"https://github.com/Benny1007/PowerShellGet","homepage":"https://www.PowerShellGallery.com","size":1200,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"PowerShell:development","ref":"development","sha":"88d3d9e73e2af67460262b5c4fb291b853ca74c8","user":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":57910460,"name":"PowerShellGet","full_name":"PowerShell/PowerShellGet","owner":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/PowerShellGet","description":"PowerShellGet is the Package Manager for PowerShell","fork":false,"url":"https://api.github.com/repos/PowerShell/PowerShellGet","forks_url":"https://api.github.com/repos/PowerShell/PowerShellGet/forks","keys_url":"https://api.github.com/repos/PowerShell/PowerShellGet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/PowerShellGet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/PowerShellGet/teams","hooks_url":"https://api.github.com/repos/PowerShell/PowerShellGet/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/PowerShellGet/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/PowerShellGet/events","assignees_url":"https://api.github.com/repos/PowerShell/PowerShellGet/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/PowerShellGet/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/PowerShellGet/tags","blobs_url":"https://api.github.com/repos/PowerShell/PowerShellGet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/PowerShellGet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/PowerShellGet/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/PowerShellGet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/PowerShellGet/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/PowerShellGet/languages","stargazers_url":"https://api.github.com/repos/PowerShell/PowerShellGet/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/PowerShellGet/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/PowerShellGet/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/PowerShellGet/subscription","commits_url":"https://api.github.com/repos/PowerShell/PowerShellGet/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/PowerShellGet/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/PowerShellGet/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/PowerShellGet/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/PowerShellGet/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/PowerShellGet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/PowerShellGet/merges","archive_url":"https://api.github.com/repos/PowerShell/PowerShellGet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/PowerShellGet/downloads","issues_url":"https://api.github.com/repos/PowerShell/PowerShellGet/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/PowerShellGet/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/PowerShellGet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/PowerShellGet/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/PowerShellGet/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/PowerShellGet/deployments","created_at":"2016-05-02T18:13:31Z","updated_at":"2018-03-18T21:35:13Z","pushed_at":"2018-03-25T00:58:57Z","git_url":"git://github.com/PowerShell/PowerShellGet.git","ssh_url":"git@github.com:PowerShell/PowerShellGet.git","clone_url":"https://github.com/PowerShell/PowerShellGet.git","svn_url":"https://github.com/PowerShell/PowerShellGet","homepage":"https://www.PowerShellGallery.com","size":1099,"stargazers_count":153,"watchers_count":153,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":71,"open_issues":98,"watchers":153,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls/242"},"html":{"href":"https://github.com/PowerShell/PowerShellGet/pull/242"},"issue":{"href":"https://api.github.com/repos/PowerShell/PowerShellGet/issues/242"},"comments":{"href":"https://api.github.com/repos/PowerShell/PowerShellGet/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/PowerShellGet/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/PowerShellGet/statuses/bcda230c1caaa6beec1bfa3a6b9120c39efd8f05"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bmanikm"}}