{"action":"created","issue":{"url":"https://api.github.com/repos/project-everest/hacl-star/issues/130","repository_url":"https://api.github.com/repos/project-everest/hacl-star","labels_url":"https://api.github.com/repos/project-everest/hacl-star/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/project-everest/hacl-star/issues/130/comments","events_url":"https://api.github.com/repos/project-everest/hacl-star/issues/130/events","html_url":"https://github.com/project-everest/hacl-star/pull/130","id":374388806,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTAyMDY2","number":130,"title":"Updated AESNI detection","user":{"login":"wintersteiger","id":10155819,"node_id":"MDQ6VXNlcjEwMTU1ODE5","avatar_url":"https://avatars1.githubusercontent.com/u/10155819?v=4","gravatar_id":"","url":"https://api.github.com/users/wintersteiger","html_url":"https://github.com/wintersteiger","followers_url":"https://api.github.com/users/wintersteiger/followers","following_url":"https://api.github.com/users/wintersteiger/following{/other_user}","gists_url":"https://api.github.com/users/wintersteiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wintersteiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wintersteiger/subscriptions","organizations_url":"https://api.github.com/users/wintersteiger/orgs","repos_url":"https://api.github.com/users/wintersteiger/repos","events_url":"https://api.github.com/users/wintersteiger/events{/privacy}","received_events_url":"https://api.github.com/users/wintersteiger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-26T13:40:13Z","updated_at":"2018-12-05T23:22:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/project-everest/hacl-star/pulls/130","html_url":"https://github.com/project-everest/hacl-star/pull/130","diff_url":"https://github.com/project-everest/hacl-star/pull/130.diff","patch_url":"https://github.com/project-everest/hacl-star/pull/130.patch"},"body":"@protz I can't tell which `cpuid.h` EverCrypt is supposed to #include. I currently need this to work with clang-7 on Ubuntu 16.04 and 18.04. Below is the bit if AESNI detection from Amaury, which, I think, should work for more systems, but I don't know what systems you need this to work with. "},"comment":{"url":"https://api.github.com/repos/project-everest/hacl-star/issues/comments/444689749","html_url":"https://github.com/project-everest/hacl-star/pull/130#issuecomment-444689749","issue_url":"https://api.github.com/repos/project-everest/hacl-star/issues/130","id":444689749,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDY4OTc0OQ==","user":{"login":"msprotz","id":10673049,"node_id":"MDQ6VXNlcjEwNjczMDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/10673049?v=4","gravatar_id":"","url":"https://api.github.com/users/msprotz","html_url":"https://github.com/msprotz","followers_url":"https://api.github.com/users/msprotz/followers","following_url":"https://api.github.com/users/msprotz/following{/other_user}","gists_url":"https://api.github.com/users/msprotz/gists{/gist_id}","starred_url":"https://api.github.com/users/msprotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msprotz/subscriptions","organizations_url":"https://api.github.com/users/msprotz/orgs","repos_url":"https://api.github.com/users/msprotz/repos","events_url":"https://api.github.com/users/msprotz/events{/privacy}","received_events_url":"https://api.github.com/users/msprotz/received_events","type":"User","site_admin":false},"created_at":"2018-12-05T23:22:39Z","updated_at":"2018-12-05T23:22:39Z","author_association":"MEMBER","body":"Correct. This can be closed and this code will cease to exist as soon as I merge.\n\n~ jonathan\n________________________________\nFrom: Bryan Parno <notifications@github.com>\nSent: Wednesday, December 5, 2018 2:14:21 PM\nTo: project-everest/hacl-star\nCc: Jonathan Protzenko; Review requested\nSubject: Re: [project-everest/hacl-star] Updated AESNI detection (#130)\n\n\nI think this is all being handled by verified Vale code as part of EverCrypt, thanks to @protz<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fprotz&data=02%7C01%7Cprotz%40microsoft.com%7C87cd5acd883549486fee08d65aff0205%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636796448633603431&sdata=hm9ner8MhTQAkMIpZvusg%2FgoEuC8Eo0xoQlRLduXsqY%3D&reserved=0> .\n\n—\nYou are receiving this because your review was requested.\nReply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fproject-everest%2Fhacl-star%2Fpull%2F130%23issuecomment-444671905&data=02%7C01%7Cprotz%40microsoft.com%7C87cd5acd883549486fee08d65aff0205%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636796448633603431&sdata=HvAVwyzM6lIlNhhdSOFCj77%2BGb2m5hBLguIOpe6bt%2Bk%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKLbmc6Fu0PCWX6gmWECdwJBglFxLc-8ks5u2EU9gaJpZM4X8QZM&data=02%7C01%7Cprotz%40microsoft.com%7C87cd5acd883549486fee08d65aff0205%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636796448633613440&sdata=VO0%2FaRrQmJN9BbS4WC8cNAIMBImUnEm4R3BVV0Yhawo%3D&reserved=0>.\n"}}
{"actor":{"display_login":"msprotz"}}