{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments/204616449","pull_request_review_id":139726299,"id":204616449,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDYxNjQ0OQ==","diff_hunk":"@@ -59,4 +59,18 @@ var (\n \n \t// RouteCalcDelayStdDev is standard deviation\n \tRouteCalcDelayStdDev = RouteCalcDelay / 4\n+\n+\t// Port settings, can be overwritten from command line\n+\n+\t// Customer Service Port\n+\tCustomerPort = 8081","path":"examples/hotrod/services/config/config.go","position":8,"original_position":8,"commit_id":"8cef0fe43bf917b51482bd5352e89ee75defd319","original_commit_id":"8cef0fe43bf917b51482bd5352e89ee75defd319","user":{"login":"yurishkuro","id":3523016,"node_id":"MDQ6VXNlcjM1MjMwMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3523016?v=4","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"body":"Q: why do we need these in the config? The variables that hold the parsed flag values are already in the same package as the commands for services, so we can access the variables directly.","created_at":"2018-07-24T03:49:07Z","updated_at":"2018-07-24T03:49:07Z","html_url":"https://github.com/jaegertracing/jaeger/pull/951#discussion_r204616449","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/951","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments/204616449"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/951#discussion_r204616449"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/951"}}},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/951","id":203342939,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzQyOTM5","html_url":"https://github.com/jaegertracing/jaeger/pull/951","diff_url":"https://github.com/jaegertracing/jaeger/pull/951.diff","patch_url":"https://github.com/jaegertracing/jaeger/pull/951.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/951","number":951,"state":"open","locked":false,"title":"Add flags to allow changing ports for HotROD services","user":{"login":"cboornaz17","id":33240499,"node_id":"MDQ6VXNlcjMzMjQwNDk5","avatar_url":"https://avatars2.githubusercontent.com/u/33240499?v=4","gravatar_id":"","url":"https://api.github.com/users/cboornaz17","html_url":"https://github.com/cboornaz17","followers_url":"https://api.github.com/users/cboornaz17/followers","following_url":"https://api.github.com/users/cboornaz17/following{/other_user}","gists_url":"https://api.github.com/users/cboornaz17/gists{/gist_id}","starred_url":"https://api.github.com/users/cboornaz17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cboornaz17/subscriptions","organizations_url":"https://api.github.com/users/cboornaz17/orgs","repos_url":"https://api.github.com/users/cboornaz17/repos","events_url":"https://api.github.com/users/cboornaz17/events{/privacy}","received_events_url":"https://api.github.com/users/cboornaz17/received_events","type":"User","site_admin":false},"body":"<!--\r\nWe appreciate your contribution to the Jaeger project! 👋🎉\r\n\r\nBefore creating a pull request, please make sure:\r\n- Your PR is solving one problem\r\n- You have read the guide for contributing\r\n  - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md\r\n- You signed all your commits (otherwise we won't be able to merge the PR)\r\n  - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md#sign-your-work\r\n- You added unit tests for the new functionality\r\n- You mention in the PR description which issue it is addressing, e.g. \"Resolves #123\"\r\n-->\r\n\r\n## Which problem is this PR solving?\r\nResolves #948 \r\n\r\n## Short description of the changes\r\nAdded four flags, one for each service (driver \"-d\", route \"-r\", customer \"-c\", and frontend \"-f\") so that a user can specify on the command line which port they want each service to be run on. The ports get added to the services/config file and are checked before starting each server. The default port values are still used if the user does not add these flags.\r\n\r\nSigned-off-by: Corey Boornazian <coreyb220@gmail.com>","created_at":"2018-07-23T21:03:19Z","updated_at":"2018-07-24T03:49:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec94945f386cbe2977e31f88ee8c875d229e75db","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},{"login":"black-adder","id":791791,"node_id":"MDQ6VXNlcjc5MTc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/791791?v=4","gravatar_id":"","url":"https://api.github.com/users/black-adder","html_url":"https://github.com/black-adder","followers_url":"https://api.github.com/users/black-adder/followers","following_url":"https://api.github.com/users/black-adder/following{/other_user}","gists_url":"https://api.github.com/users/black-adder/gists{/gist_id}","starred_url":"https://api.github.com/users/black-adder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/black-adder/subscriptions","organizations_url":"https://api.github.com/users/black-adder/orgs","repos_url":"https://api.github.com/users/black-adder/repos","events_url":"https://api.github.com/users/black-adder/events{/privacy}","received_events_url":"https://api.github.com/users/black-adder/received_events","type":"User","site_admin":false},{"login":"vprithvi","id":833009,"node_id":"MDQ6VXNlcjgzMzAwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/833009?v=4","gravatar_id":"","url":"https://api.github.com/users/vprithvi","html_url":"https://github.com/vprithvi","followers_url":"https://api.github.com/users/vprithvi/followers","following_url":"https://api.github.com/users/vprithvi/following{/other_user}","gists_url":"https://api.github.com/users/vprithvi/gists{/gist_id}","starred_url":"https://api.github.com/users/vprithvi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vprithvi/subscriptions","organizations_url":"https://api.github.com/users/vprithvi/orgs","repos_url":"https://api.github.com/users/vprithvi/repos","events_url":"https://api.github.com/users/vprithvi/events{/privacy}","received_events_url":"https://api.github.com/users/vprithvi/received_events","type":"User","site_admin":false},{"login":"pavolloffay","id":5618424,"node_id":"MDQ6VXNlcjU2MTg0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/951/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/951/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/951/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/8cef0fe43bf917b51482bd5352e89ee75defd319","head":{"label":"cboornaz17:add-cmd-flags-hotrod-ports","ref":"add-cmd-flags-hotrod-ports","sha":"8cef0fe43bf917b51482bd5352e89ee75defd319","user":{"login":"cboornaz17","id":33240499,"node_id":"MDQ6VXNlcjMzMjQwNDk5","avatar_url":"https://avatars2.githubusercontent.com/u/33240499?v=4","gravatar_id":"","url":"https://api.github.com/users/cboornaz17","html_url":"https://github.com/cboornaz17","followers_url":"https://api.github.com/users/cboornaz17/followers","following_url":"https://api.github.com/users/cboornaz17/following{/other_user}","gists_url":"https://api.github.com/users/cboornaz17/gists{/gist_id}","starred_url":"https://api.github.com/users/cboornaz17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cboornaz17/subscriptions","organizations_url":"https://api.github.com/users/cboornaz17/orgs","repos_url":"https://api.github.com/users/cboornaz17/repos","events_url":"https://api.github.com/users/cboornaz17/events{/privacy}","received_events_url":"https://api.github.com/users/cboornaz17/received_events","type":"User","site_admin":false},"repo":{"id":142065766,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwNjU3NjY=","name":"jaeger","full_name":"cboornaz17/jaeger","owner":{"login":"cboornaz17","id":33240499,"node_id":"MDQ6VXNlcjMzMjQwNDk5","avatar_url":"https://avatars2.githubusercontent.com/u/33240499?v=4","gravatar_id":"","url":"https://api.github.com/users/cboornaz17","html_url":"https://github.com/cboornaz17","followers_url":"https://api.github.com/users/cboornaz17/followers","following_url":"https://api.github.com/users/cboornaz17/following{/other_user}","gists_url":"https://api.github.com/users/cboornaz17/gists{/gist_id}","starred_url":"https://api.github.com/users/cboornaz17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cboornaz17/subscriptions","organizations_url":"https://api.github.com/users/cboornaz17/orgs","repos_url":"https://api.github.com/users/cboornaz17/repos","events_url":"https://api.github.com/users/cboornaz17/events{/privacy}","received_events_url":"https://api.github.com/users/cboornaz17/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cboornaz17/jaeger","description":"CNCF Jaeger, a Distributed Tracing System","fork":true,"url":"https://api.github.com/repos/cboornaz17/jaeger","forks_url":"https://api.github.com/repos/cboornaz17/jaeger/forks","keys_url":"https://api.github.com/repos/cboornaz17/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cboornaz17/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cboornaz17/jaeger/teams","hooks_url":"https://api.github.com/repos/cboornaz17/jaeger/hooks","issue_events_url":"https://api.github.com/repos/cboornaz17/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/cboornaz17/jaeger/events","assignees_url":"https://api.github.com/repos/cboornaz17/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/cboornaz17/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/cboornaz17/jaeger/tags","blobs_url":"https://api.github.com/repos/cboornaz17/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cboornaz17/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cboornaz17/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/cboornaz17/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cboornaz17/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/cboornaz17/jaeger/languages","stargazers_url":"https://api.github.com/repos/cboornaz17/jaeger/stargazers","contributors_url":"https://api.github.com/repos/cboornaz17/jaeger/contributors","subscribers_url":"https://api.github.com/repos/cboornaz17/jaeger/subscribers","subscription_url":"https://api.github.com/repos/cboornaz17/jaeger/subscription","commits_url":"https://api.github.com/repos/cboornaz17/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/cboornaz17/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/cboornaz17/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/cboornaz17/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/cboornaz17/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/cboornaz17/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cboornaz17/jaeger/merges","archive_url":"https://api.github.com/repos/cboornaz17/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cboornaz17/jaeger/downloads","issues_url":"https://api.github.com/repos/cboornaz17/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/cboornaz17/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/cboornaz17/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/cboornaz17/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cboornaz17/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/cboornaz17/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/cboornaz17/jaeger/deployments","created_at":"2018-07-23T20:27:33Z","updated_at":"2018-07-23T20:27:36Z","pushed_at":"2018-07-24T03:12:41Z","git_url":"git://github.com/cboornaz17/jaeger.git","ssh_url":"git@github.com:cboornaz17/jaeger.git","clone_url":"https://github.com/cboornaz17/jaeger.git","svn_url":"https://github.com/cboornaz17/jaeger","homepage":"https://jaegertracing.io/","size":3144,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"fe43631958b87b656f7c0a281f3235d1ea1882a7","user":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":56342508,"node_id":"MDEwOlJlcG9zaXRvcnk1NjM0MjUwOA==","name":"jaeger","full_name":"jaegertracing/jaeger","owner":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/jaeger","description":"CNCF Jaeger, a Distributed Tracing System","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger","forks_url":"https://api.github.com/repos/jaegertracing/jaeger/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger/deployments","created_at":"2016-04-15T18:49:02Z","updated_at":"2018-07-24T03:07:36Z","pushed_at":"2018-07-24T03:35:11Z","git_url":"git://github.com/jaegertracing/jaeger.git","ssh_url":"git@github.com:jaegertracing/jaeger.git","clone_url":"https://github.com/jaegertracing/jaeger.git","svn_url":"https://github.com/jaegertracing/jaeger","homepage":"https://jaegertracing.io/","size":3141,"stargazers_count":5198,"watchers_count":5198,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":416,"mirror_url":null,"archived":false,"open_issues_count":198,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":416,"open_issues":198,"watchers":5198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/951"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/951"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/951"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/951/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/951/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/951/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger/statuses/8cef0fe43bf917b51482bd5352e89ee75defd319"}},"author_association":"NONE"}}
{"actor":{"display_login":"yurishkuro"}}