{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/230726309","pull_request_review_id":171523707,"id":230726309,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDcyNjMwOQ==","diff_hunk":"@@ -208,12 +219,19 @@ def __init__(self):\n             )\n         self.api = fastparquet\n \n-    def write(self, df, path, compression='snappy', index=None, **kwargs):\n+    def write(self, df, path, compression='snappy', index=None,\n+              partition_cols=None, **kwargs):\n         self.validate_dataframe(df)\n         # thriftpy/protocol/compact.py:339:\n         # DeprecationWarning: tostring() is deprecated.\n         # Use tobytes() instead.\n \n+        if 'partition_on' in kwargs:\n+            partition_cols = kwargs.pop('partition_on')","path":"pandas/io/parquet.py","position":53,"original_position":53,"commit_id":"a5164b874487beb2b5d3246cd8fb8e530732a0de","original_commit_id":"a5164b874487beb2b5d3246cd8fb8e530732a0de","user":{"login":"TomAugspurger","id":1312546,"node_id":"MDQ6VXNlcjEzMTI1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"body":"Should check that `partition_cols` is None before doing this. We would want to raise on\r\n\r\n```python\r\ndf.to_parquet(engine='fastparquet', partition_cols=['a', 'b'], partition_on=['b', 'c'])\r\n```","created_at":"2018-11-05T12:04:32Z","updated_at":"2018-11-05T12:05:53Z","html_url":"https://github.com/pandas-dev/pandas/pull/23321#discussion_r230726309","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23321","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/230726309"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23321#discussion_r230726309"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23321"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23321","id":225501915,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTAxOTE1","html_url":"https://github.com/pandas-dev/pandas/pull/23321","diff_url":"https://github.com/pandas-dev/pandas/pull/23321.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/23321.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23321","number":23321,"state":"open","locked":false,"title":"Support for partition_cols in to_parquet","user":{"login":"anjsudh","id":2052424,"node_id":"MDQ6VXNlcjIwNTI0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2052424?v=4","gravatar_id":"","url":"https://api.github.com/users/anjsudh","html_url":"https://github.com/anjsudh","followers_url":"https://api.github.com/users/anjsudh/followers","following_url":"https://api.github.com/users/anjsudh/following{/other_user}","gists_url":"https://api.github.com/users/anjsudh/gists{/gist_id}","starred_url":"https://api.github.com/users/anjsudh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjsudh/subscriptions","organizations_url":"https://api.github.com/users/anjsudh/orgs","repos_url":"https://api.github.com/users/anjsudh/repos","events_url":"https://api.github.com/users/anjsudh/events{/privacy}","received_events_url":"https://api.github.com/users/anjsudh/received_events","type":"User","site_admin":false},"body":"- [x] closes [#23283](https://github.com/pandas-dev/pandas/issues/23283)\r\n- [x] tests passed\r\n- [x] passes git diff upstream/master -u -- \"*.py\" | flake8 --diff\r\n- [x] whatsnew entry","created_at":"2018-10-24T18:17:23Z","updated_at":"2018-11-05T12:05:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15385d72b7e445c16f6106a249b3cd294acade05","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":685114413,"node_id":"MDU6TGFiZWw2ODUxMTQ0MTM=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/IO%20Parquet","name":"IO Parquet","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/55","html_url":"https://github.com/pandas-dev/pandas/milestone/55","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/55/labels","id":3228419,"node_id":"MDk6TWlsZXN0b25lMzIyODQxOQ==","number":55,"title":"0.24.0","description":"","creator":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"open_issues":176,"closed_issues":1069,"state":"open","created_at":"2018-03-29T12:00:12Z","updated_at":"2018-11-05T11:02:43Z","due_on":"2018-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23321/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23321/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23321/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/a5164b874487beb2b5d3246cd8fb8e530732a0de","head":{"label":"anjsudh:master","ref":"master","sha":"a5164b874487beb2b5d3246cd8fb8e530732a0de","user":{"login":"anjsudh","id":2052424,"node_id":"MDQ6VXNlcjIwNTI0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2052424?v=4","gravatar_id":"","url":"https://api.github.com/users/anjsudh","html_url":"https://github.com/anjsudh","followers_url":"https://api.github.com/users/anjsudh/followers","following_url":"https://api.github.com/users/anjsudh/following{/other_user}","gists_url":"https://api.github.com/users/anjsudh/gists{/gist_id}","starred_url":"https://api.github.com/users/anjsudh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjsudh/subscriptions","organizations_url":"https://api.github.com/users/anjsudh/orgs","repos_url":"https://api.github.com/users/anjsudh/repos","events_url":"https://api.github.com/users/anjsudh/events{/privacy}","received_events_url":"https://api.github.com/users/anjsudh/received_events","type":"User","site_admin":false},"repo":{"id":154544770,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1NDQ3NzA=","name":"pandas","full_name":"anjsudh/pandas","private":false,"owner":{"login":"anjsudh","id":2052424,"node_id":"MDQ6VXNlcjIwNTI0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2052424?v=4","gravatar_id":"","url":"https://api.github.com/users/anjsudh","html_url":"https://github.com/anjsudh","followers_url":"https://api.github.com/users/anjsudh/followers","following_url":"https://api.github.com/users/anjsudh/following{/other_user}","gists_url":"https://api.github.com/users/anjsudh/gists{/gist_id}","starred_url":"https://api.github.com/users/anjsudh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjsudh/subscriptions","organizations_url":"https://api.github.com/users/anjsudh/orgs","repos_url":"https://api.github.com/users/anjsudh/repos","events_url":"https://api.github.com/users/anjsudh/events{/privacy}","received_events_url":"https://api.github.com/users/anjsudh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anjsudh/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/anjsudh/pandas","forks_url":"https://api.github.com/repos/anjsudh/pandas/forks","keys_url":"https://api.github.com/repos/anjsudh/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anjsudh/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anjsudh/pandas/teams","hooks_url":"https://api.github.com/repos/anjsudh/pandas/hooks","issue_events_url":"https://api.github.com/repos/anjsudh/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/anjsudh/pandas/events","assignees_url":"https://api.github.com/repos/anjsudh/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/anjsudh/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/anjsudh/pandas/tags","blobs_url":"https://api.github.com/repos/anjsudh/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anjsudh/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anjsudh/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/anjsudh/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anjsudh/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/anjsudh/pandas/languages","stargazers_url":"https://api.github.com/repos/anjsudh/pandas/stargazers","contributors_url":"https://api.github.com/repos/anjsudh/pandas/contributors","subscribers_url":"https://api.github.com/repos/anjsudh/pandas/subscribers","subscription_url":"https://api.github.com/repos/anjsudh/pandas/subscription","commits_url":"https://api.github.com/repos/anjsudh/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/anjsudh/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/anjsudh/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/anjsudh/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/anjsudh/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/anjsudh/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anjsudh/pandas/merges","archive_url":"https://api.github.com/repos/anjsudh/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anjsudh/pandas/downloads","issues_url":"https://api.github.com/repos/anjsudh/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/anjsudh/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/anjsudh/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/anjsudh/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anjsudh/pandas/labels{/name}","releases_url":"https://api.github.com/repos/anjsudh/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/anjsudh/pandas/deployments","created_at":"2018-10-24T17:54:36Z","updated_at":"2018-11-05T11:18:52Z","pushed_at":"2018-11-05T11:18:48Z","git_url":"git://github.com/anjsudh/pandas.git","ssh_url":"git@github.com:anjsudh/pandas.git","clone_url":"https://github.com/anjsudh/pandas.git","svn_url":"https://github.com/anjsudh/pandas","homepage":"https://pandas.pydata.org","size":133872,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"64c34913696f4266184bcac9b16d488f66589491","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-11-05T11:48:17Z","pushed_at":"2018-11-05T11:18:51Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":133910,"stargazers_count":16755,"watchers_count":16755,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6757,"mirror_url":null,"archived":false,"open_issues_count":2873,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6757,"open_issues":2873,"watchers":16755,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23321"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23321"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23321"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23321/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23321/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23321/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/a5164b874487beb2b5d3246cd8fb8e530732a0de"}},"author_association":"NONE"}}
{"actor":{"display_login":"TomAugspurger"}}