{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/2475","repository_url":"https://api.github.com/repos/ripple/rippled","labels_url":"https://api.github.com/repos/ripple/rippled/issues/2475/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/2475/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/2475/events","html_url":"https://github.com/ripple/rippled/pull/2475","id":313066477,"number":2475,"title":"Fixes for PerfLog unit test in a Docker container","user":{"login":"scottschurr","id":7840379,"avatar_url":"https://avatars0.githubusercontent.com/u/7840379?v=4","gravatar_id":"","url":"https://api.github.com/users/scottschurr","html_url":"https://github.com/scottschurr","followers_url":"https://api.github.com/users/scottschurr/followers","following_url":"https://api.github.com/users/scottschurr/following{/other_user}","gists_url":"https://api.github.com/users/scottschurr/gists{/gist_id}","starred_url":"https://api.github.com/users/scottschurr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottschurr/subscriptions","organizations_url":"https://api.github.com/users/scottschurr/orgs","repos_url":"https://api.github.com/users/scottschurr/repos","events_url":"https://api.github.com/users/scottschurr/events{/privacy}","received_events_url":"https://api.github.com/users/scottschurr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mellery451","id":463430,"avatar_url":"https://avatars1.githubusercontent.com/u/463430?v=4","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"assignees":[{"login":"mellery451","id":463430,"avatar_url":"https://avatars1.githubusercontent.com/u/463430?v=4","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},{"login":"seelabs","id":5853458,"avatar_url":"https://avatars0.githubusercontent.com/u/5853458?v=4","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-04-10T19:53:43Z","updated_at":"2018-04-10T23:49:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/2475","html_url":"https://github.com/ripple/rippled/pull/2475","diff_url":"https://github.com/ripple/rippled/pull/2475.diff","patch_url":"https://github.com/ripple/rippled/pull/2475.patch"},"body":"Apparently when we build the RPM the process runs the unit tests as root.  That caused one of the PerfLog tests to fail because root can write to a file even if the file is write protected.\r\n\r\nThe test now verifies that removing write permissions on a file actually makes the file unwritable, and skips the test if the file is writable.\r\n"},"comment":{"url":"https://api.github.com/repos/ripple/rippled/issues/comments/380282502","html_url":"https://github.com/ripple/rippled/pull/2475#issuecomment-380282502","issue_url":"https://api.github.com/repos/ripple/rippled/issues/2475","id":380282502,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T23:49:37Z","updated_at":"2018-04-10T23:49:37Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/ripple/rippled/pull/2475?src=pr&el=h1) Report\n> Merging [#2475](https://codecov.io/gh/ripple/rippled/pull/2475?src=pr&el=desc) into [develop](https://codecov.io/gh/ripple/rippled/commit/1eece9b1fdbf58b8a4b52b738f53be4fd39dd37e?src=pr&el=desc) will **decrease** coverage by `<.01%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/ripple/rippled/pull/2475/graphs/tree.svg?height=150&width=650&token=y0OgJuslsq&src=pr)](https://codecov.io/gh/ripple/rippled/pull/2475?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff             @@\n##           develop    #2475      +/-   ##\n===========================================\n- Coverage    70.67%   70.67%   -0.01%     \n===========================================\n  Files          696      696              \n  Lines        54436    54436              \n===========================================\n- Hits         38473    38470       -3     \n- Misses       15963    15966       +3\n```\n\n\n| [Impacted Files](https://codecov.io/gh/ripple/rippled/pull/2475?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/ripple/basics/DecayingSample.h](https://codecov.io/gh/ripple/rippled/pull/2475/diff?src=pr&el=tree#diff-c3JjL3JpcHBsZS9iYXNpY3MvRGVjYXlpbmdTYW1wbGUuaA==) | `77.77% <0%> (-8.34%)` | :arrow_down: |\n| [src/ripple/core/impl/JobQueue.cpp](https://codecov.io/gh/ripple/rippled/pull/2475/diff?src=pr&el=tree#diff-c3JjL3JpcHBsZS9jb3JlL2ltcGwvSm9iUXVldWUuY3Bw) | `89.04% <0%> (-0.48%)` | :arrow_down: |\n| [src/ripple/app/misc/SHAMapStoreImp.cpp](https://codecov.io/gh/ripple/rippled/pull/2475/diff?src=pr&el=tree#diff-c3JjL3JpcHBsZS9hcHAvbWlzYy9TSEFNYXBTdG9yZUltcC5jcHA=) | `75.29% <0%> (+0.23%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/ripple/rippled/pull/2475?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/ripple/rippled/pull/2475?src=pr&el=footer). Last update [1eece9b...e74a1f7](https://codecov.io/gh/ripple/rippled/pull/2475?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}