{"action":"created","issue":{"url":"https://api.github.com/repos/theappbusiness/MasterFastfile/issues/43","repository_url":"https://api.github.com/repos/theappbusiness/MasterFastfile","labels_url":"https://api.github.com/repos/theappbusiness/MasterFastfile/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/theappbusiness/MasterFastfile/issues/43/comments","events_url":"https://api.github.com/repos/theappbusiness/MasterFastfile/issues/43/events","html_url":"https://github.com/theappbusiness/MasterFastfile/pull/43","id":293181394,"number":43,"title":"Feature/remove provfile","user":{"login":"KaneCheshire","id":10811515,"avatar_url":"https://avatars0.githubusercontent.com/u/10811515?v=4","gravatar_id":"","url":"https://api.github.com/users/KaneCheshire","html_url":"https://github.com/KaneCheshire","followers_url":"https://api.github.com/users/KaneCheshire/followers","following_url":"https://api.github.com/users/KaneCheshire/following{/other_user}","gists_url":"https://api.github.com/users/KaneCheshire/gists{/gist_id}","starred_url":"https://api.github.com/users/KaneCheshire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaneCheshire/subscriptions","organizations_url":"https://api.github.com/users/KaneCheshire/orgs","repos_url":"https://api.github.com/users/KaneCheshire/repos","events_url":"https://api.github.com/users/KaneCheshire/events{/privacy}","received_events_url":"https://api.github.com/users/KaneCheshire/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-01-31T14:39:34Z","updated_at":"2018-02-08T14:56:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/theappbusiness/MasterFastfile/pulls/43","html_url":"https://github.com/theappbusiness/MasterFastfile/pull/43","diff_url":"https://github.com/theappbusiness/MasterFastfile/pull/43.diff","patch_url":"https://github.com/theappbusiness/MasterFastfile/pull/43.patch"},"body":"- This PR removes the need to include a Provfile, instead opting to take advantage of the fact all projects now require an export options plist.\r\n- Previously, the xcconfig file was created by parsing the Provfile, essentially the same thing is happening except now it maps bundle IDs from the export options to targets in the Xcode project.\r\n- Additionally, `TAB_PROVISIONING_PROFILE` can technically be removed now I think, but leaving it in for the time being as it's not really related to this PR. `TAB_PROVISIONING_PROFILE` is still used in the `install_provisioning_profile` action, however I think this needs to be revisited because it only installs one profile for the main target (or whatever you have `TAB_PROVISIONING_PROFILE` set to). So my understanding is the MasterFastfile wouldn't work with multiple targets if you don't install the profiles manually."},"comment":{"url":"https://api.github.com/repos/theappbusiness/MasterFastfile/issues/comments/364136585","html_url":"https://github.com/theappbusiness/MasterFastfile/pull/43#issuecomment-364136585","issue_url":"https://api.github.com/repos/theappbusiness/MasterFastfile/issues/43","id":364136585,"user":{"login":"Neil3079","id":2815318,"avatar_url":"https://avatars0.githubusercontent.com/u/2815318?v=4","gravatar_id":"","url":"https://api.github.com/users/Neil3079","html_url":"https://github.com/Neil3079","followers_url":"https://api.github.com/users/Neil3079/followers","following_url":"https://api.github.com/users/Neil3079/following{/other_user}","gists_url":"https://api.github.com/users/Neil3079/gists{/gist_id}","starred_url":"https://api.github.com/users/Neil3079/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neil3079/subscriptions","organizations_url":"https://api.github.com/users/Neil3079/orgs","repos_url":"https://api.github.com/users/Neil3079/repos","events_url":"https://api.github.com/users/Neil3079/events{/privacy}","received_events_url":"https://api.github.com/users/Neil3079/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T14:56:15Z","updated_at":"2018-02-08T14:56:15Z","author_association":"COLLABORATOR","body":"solves #33 "}}
{"actor":{"display_login":"Neil3079"}}