{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/pulls/9","id":202230348,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjMwMzQ4","html_url":"https://github.com/companieshouse/company-accounts.api.ch.gov.uk/pull/9","diff_url":"https://github.com/companieshouse/company-accounts.api.ch.gov.uk/pull/9.diff","patch_url":"https://github.com/companieshouse/company-accounts.api.ch.gov.uk/pull/9.patch","issue_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/issues/9","number":9,"state":"closed","locked":false,"title":"Adds transaction interceptor","user":{"login":"cburns93","id":29541485,"node_id":"MDQ6VXNlcjI5NTQxNDg1","avatar_url":"https://avatars2.githubusercontent.com/u/29541485?v=4","gravatar_id":"","url":"https://api.github.com/users/cburns93","html_url":"https://github.com/cburns93","followers_url":"https://api.github.com/users/cburns93/followers","following_url":"https://api.github.com/users/cburns93/following{/other_user}","gists_url":"https://api.github.com/users/cburns93/gists{/gist_id}","starred_url":"https://api.github.com/users/cburns93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburns93/subscriptions","organizations_url":"https://api.github.com/users/cburns93/orgs","repos_url":"https://api.github.com/users/cburns93/repos","events_url":"https://api.github.com/users/cburns93/events{/privacy}","received_events_url":"https://api.github.com/users/cburns93/received_events","type":"User","site_admin":false},"body":"Adds transaction interceptor that deals with the validating of the transaction and its details. This PR includes:\r\n- transaction interceptor and the paths it intercepts\r\n- adds the transactions-api interfacing code that communicates with the transactions-api regarding retrieving transactions. It is important to note that this will be removed and replaced by the private java sdk once it has been done. To replace the transaction interfacing code, simply replace the `getTransaction` line in the transaction interceptor with the sdk code and subsequently delete the `transaction` package. We have done it this way because we still want to develop the API without being blocked by another piece of work - which when done, will slot right in.\r\n- adds transaction interceptor junit tests\r\n\r\nResolves:\r\n[SFA-465]","created_at":"2018-07-18T12:04:18Z","updated_at":"2018-07-20T10:53:01Z","closed_at":"2018-07-20T10:53:01Z","merged_at":"2018-07-20T10:53:01Z","merge_commit_sha":"1b80b8b93fbd38d73619f4dcba0f6e227a303fdb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":977231343,"node_id":"MDU6TGFiZWw5NzcyMzEzNDM=","url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/labels/New","name":"New","color":"FF9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/pulls/9/commits","review_comments_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/pulls/9/comments","review_comment_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/issues/9/comments","statuses_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/statuses/674047348cf9868e6d54bd60abd3b7d53c9a1e42","head":{"label":"companieshouse:feature/add-transaction-interceptor","ref":"feature/add-transaction-interceptor","sha":"674047348cf9868e6d54bd60abd3b7d53c9a1e42","user":{"login":"companieshouse","id":4947323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDczMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4947323?v=4","gravatar_id":"","url":"https://api.github.com/users/companieshouse","html_url":"https://github.com/companieshouse","followers_url":"https://api.github.com/users/companieshouse/followers","following_url":"https://api.github.com/users/companieshouse/following{/other_user}","gists_url":"https://api.github.com/users/companieshouse/gists{/gist_id}","starred_url":"https://api.github.com/users/companieshouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/companieshouse/subscriptions","organizations_url":"https://api.github.com/users/companieshouse/orgs","repos_url":"https://api.github.com/users/companieshouse/repos","events_url":"https://api.github.com/users/companieshouse/events{/privacy}","received_events_url":"https://api.github.com/users/companieshouse/received_events","type":"Organization","site_admin":false},"repo":{"id":137176372,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxNzYzNzI=","name":"company-accounts.api.ch.gov.uk","full_name":"companieshouse/company-accounts.api.ch.gov.uk","owner":{"login":"companieshouse","id":4947323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDczMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4947323?v=4","gravatar_id":"","url":"https://api.github.com/users/companieshouse","html_url":"https://github.com/companieshouse","followers_url":"https://api.github.com/users/companieshouse/followers","following_url":"https://api.github.com/users/companieshouse/following{/other_user}","gists_url":"https://api.github.com/users/companieshouse/gists{/gist_id}","starred_url":"https://api.github.com/users/companieshouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/companieshouse/subscriptions","organizations_url":"https://api.github.com/users/companieshouse/orgs","repos_url":"https://api.github.com/users/companieshouse/repos","events_url":"https://api.github.com/users/companieshouse/events{/privacy}","received_events_url":"https://api.github.com/users/companieshouse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/companieshouse/company-accounts.api.ch.gov.uk","description":"The Companies House API for handling company accounts","fork":false,"url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk","forks_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/forks","keys_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/teams","hooks_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/hooks","issue_events_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/issues/events{/number}","events_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/events","assignees_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/assignees{/user}","branches_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/branches{/branch}","tags_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/tags","blobs_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/git/refs{/sha}","trees_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/statuses/{sha}","languages_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/languages","stargazers_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/stargazers","contributors_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/contributors","subscribers_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/subscribers","subscription_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/subscription","commits_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/commits{/sha}","git_commits_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/git/commits{/sha}","comments_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/comments{/number}","issue_comment_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/issues/comments{/number}","contents_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/contents/{+path}","compare_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/merges","archive_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/downloads","issues_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/issues{/number}","pulls_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/pulls{/number}","milestones_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/milestones{/number}","notifications_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/labels{/name}","releases_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/releases{/id}","deployments_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/deployments","created_at":"2018-06-13T07:06:55Z","updated_at":"2018-07-16T12:11:25Z","pushed_at":"2018-07-20T10:53:01Z","git_url":"git://github.com/companieshouse/company-accounts.api.ch.gov.uk.git","ssh_url":"git@github.com:companieshouse/company-accounts.api.ch.gov.uk.git","clone_url":"https://github.com/companieshouse/company-accounts.api.ch.gov.uk.git","svn_url":"https://github.com/companieshouse/company-accounts.api.ch.gov.uk","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"companieshouse:develop","ref":"develop","sha":"67b3bf572e5783c181174a88c70e76af14b21e9f","user":{"login":"companieshouse","id":4947323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDczMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4947323?v=4","gravatar_id":"","url":"https://api.github.com/users/companieshouse","html_url":"https://github.com/companieshouse","followers_url":"https://api.github.com/users/companieshouse/followers","following_url":"https://api.github.com/users/companieshouse/following{/other_user}","gists_url":"https://api.github.com/users/companieshouse/gists{/gist_id}","starred_url":"https://api.github.com/users/companieshouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/companieshouse/subscriptions","organizations_url":"https://api.github.com/users/companieshouse/orgs","repos_url":"https://api.github.com/users/companieshouse/repos","events_url":"https://api.github.com/users/companieshouse/events{/privacy}","received_events_url":"https://api.github.com/users/companieshouse/received_events","type":"Organization","site_admin":false},"repo":{"id":137176372,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxNzYzNzI=","name":"company-accounts.api.ch.gov.uk","full_name":"companieshouse/company-accounts.api.ch.gov.uk","owner":{"login":"companieshouse","id":4947323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDczMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4947323?v=4","gravatar_id":"","url":"https://api.github.com/users/companieshouse","html_url":"https://github.com/companieshouse","followers_url":"https://api.github.com/users/companieshouse/followers","following_url":"https://api.github.com/users/companieshouse/following{/other_user}","gists_url":"https://api.github.com/users/companieshouse/gists{/gist_id}","starred_url":"https://api.github.com/users/companieshouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/companieshouse/subscriptions","organizations_url":"https://api.github.com/users/companieshouse/orgs","repos_url":"https://api.github.com/users/companieshouse/repos","events_url":"https://api.github.com/users/companieshouse/events{/privacy}","received_events_url":"https://api.github.com/users/companieshouse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/companieshouse/company-accounts.api.ch.gov.uk","description":"The Companies House API for handling company accounts","fork":false,"url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk","forks_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/forks","keys_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/teams","hooks_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/hooks","issue_events_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/issues/events{/number}","events_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/events","assignees_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/assignees{/user}","branches_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/branches{/branch}","tags_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/tags","blobs_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/git/refs{/sha}","trees_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/statuses/{sha}","languages_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/languages","stargazers_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/stargazers","contributors_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/contributors","subscribers_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/subscribers","subscription_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/subscription","commits_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/commits{/sha}","git_commits_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/git/commits{/sha}","comments_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/comments{/number}","issue_comment_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/issues/comments{/number}","contents_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/contents/{+path}","compare_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/merges","archive_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/downloads","issues_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/issues{/number}","pulls_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/pulls{/number}","milestones_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/milestones{/number}","notifications_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/labels{/name}","releases_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/releases{/id}","deployments_url":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/deployments","created_at":"2018-06-13T07:06:55Z","updated_at":"2018-07-16T12:11:25Z","pushed_at":"2018-07-20T10:53:01Z","git_url":"git://github.com/companieshouse/company-accounts.api.ch.gov.uk.git","ssh_url":"git@github.com:companieshouse/company-accounts.api.ch.gov.uk.git","clone_url":"https://github.com/companieshouse/company-accounts.api.ch.gov.uk.git","svn_url":"https://github.com/companieshouse/company-accounts.api.ch.gov.uk","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/pulls/9"},"html":{"href":"https://github.com/companieshouse/company-accounts.api.ch.gov.uk/pull/9"},"issue":{"href":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/issues/9"},"comments":{"href":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/companieshouse/company-accounts.api.ch.gov.uk/statuses/674047348cf9868e6d54bd60abd3b7d53c9a1e42"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cburns93","id":29541485,"node_id":"MDQ6VXNlcjI5NTQxNDg1","avatar_url":"https://avatars2.githubusercontent.com/u/29541485?v=4","gravatar_id":"","url":"https://api.github.com/users/cburns93","html_url":"https://github.com/cburns93","followers_url":"https://api.github.com/users/cburns93/followers","following_url":"https://api.github.com/users/cburns93/following{/other_user}","gists_url":"https://api.github.com/users/cburns93/gists{/gist_id}","starred_url":"https://api.github.com/users/cburns93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburns93/subscriptions","organizations_url":"https://api.github.com/users/cburns93/orgs","repos_url":"https://api.github.com/users/cburns93/repos","events_url":"https://api.github.com/users/cburns93/events{/privacy}","received_events_url":"https://api.github.com/users/cburns93/received_events","type":"User","site_admin":false},"comments":1,"review_comments":18,"maintainer_can_modify":false,"commits":14,"additions":604,"deletions":2,"changed_files":12}}
{"actor":{"display_login":"cburns93"}}