{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/167358623","pull_request_review_id":95577951,"id":167358623,"diff_hunk":"@@ -143,8 +144,17 @@ class Manifest {\n     let tags = options.tags || [];\n     let subtype = options.subtype || false;\n     function typePredicate(view) {\n+      let resolvedType = type;\n+      let primitiveType = type.isSetView ? type.primitiveType() : type;\n+      if (primitiveType.isVariable) {\n+        if (!primitiveType.data.isResolved) {\n+          return true;","path":"runtime/manifest.js","position":null,"original_position":16,"commit_id":"ee422a0440c9dcde13b1840426ec8d0eb135fff8","original_commit_id":"020b35a4e20fde223b611c502fcb06265c97f068","user":{"login":"mmandlis","id":25067830,"avatar_url":"https://avatars3.githubusercontent.com/u/25067830?v=4","gravatar_id":"","url":"https://api.github.com/users/mmandlis","html_url":"https://github.com/mmandlis","followers_url":"https://api.github.com/users/mmandlis/followers","following_url":"https://api.github.com/users/mmandlis/following{/other_user}","gists_url":"https://api.github.com/users/mmandlis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmandlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmandlis/subscriptions","organizations_url":"https://api.github.com/users/mmandlis/orgs","repos_url":"https://api.github.com/users/mmandlis/repos","events_url":"https://api.github.com/users/mmandlis/events{/privacy}","received_events_url":"https://api.github.com/users/mmandlis/received_events","type":"User","site_admin":false},"body":"updated the code and added test cases where \r\n[~a] won't accept Thing\r\nand\r\n~a won't accept [Thing]","created_at":"2018-02-09T22:07:17Z","updated_at":"2018-02-09T22:07:17Z","html_url":"https://github.com/PolymerLabs/arcs/pull/675#discussion_r167358623","pull_request_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/675","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/167358623"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/675#discussion_r167358623"},"pull_request":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/675"}},"in_reply_to_id":165555063},"pull_request":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/675","id":166687198,"html_url":"https://github.com/PolymerLabs/arcs/pull/675","diff_url":"https://github.com/PolymerLabs/arcs/pull/675.diff","patch_url":"https://github.com/PolymerLabs/arcs/pull/675.patch","issue_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/675","number":675,"state":"open","locked":false,"title":"Resolve type var","user":{"login":"mmandlis","id":25067830,"avatar_url":"https://avatars3.githubusercontent.com/u/25067830?v=4","gravatar_id":"","url":"https://api.github.com/users/mmandlis","html_url":"https://github.com/mmandlis","followers_url":"https://api.github.com/users/mmandlis/followers","following_url":"https://api.github.com/users/mmandlis/following{/other_user}","gists_url":"https://api.github.com/users/mmandlis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmandlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmandlis/subscriptions","organizations_url":"https://api.github.com/users/mmandlis/orgs","repos_url":"https://api.github.com/users/mmandlis/repos","events_url":"https://api.github.com/users/mmandlis/events{/privacy}","received_events_url":"https://api.github.com/users/mmandlis/received_events","type":"User","site_admin":false},"body":"This PR includes also https://github.com/PolymerLabs/arcs/pull/670 in it.\r\n\r\nAso, I'm still seeing this error:\r\n`Has Invalid Views 'map 'manifest:browser/demo/recipes.manifest:immediateArrivinator' as undefined // SHAAAAPE'`\r\nwhich i need to investigate.\r\n\r\nBut I'd appreciate if you could take a look and tell me what you think.","created_at":"2018-02-02T00:12:21Z","updated_at":"2018-02-09T22:07:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaa7aceb71e8837f290c7a5a92c0151735c31492","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/675/commits","review_comments_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/675/comments","review_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/675/comments","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/ee422a0440c9dcde13b1840426ec8d0eb135fff8","head":{"label":"mmandlis:resolve-type-var-min","ref":"resolve-type-var-min","sha":"ee422a0440c9dcde13b1840426ec8d0eb135fff8","user":{"login":"mmandlis","id":25067830,"avatar_url":"https://avatars3.githubusercontent.com/u/25067830?v=4","gravatar_id":"","url":"https://api.github.com/users/mmandlis","html_url":"https://github.com/mmandlis","followers_url":"https://api.github.com/users/mmandlis/followers","following_url":"https://api.github.com/users/mmandlis/following{/other_user}","gists_url":"https://api.github.com/users/mmandlis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmandlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmandlis/subscriptions","organizations_url":"https://api.github.com/users/mmandlis/orgs","repos_url":"https://api.github.com/users/mmandlis/repos","events_url":"https://api.github.com/users/mmandlis/events{/privacy}","received_events_url":"https://api.github.com/users/mmandlis/received_events","type":"User","site_admin":false},"repo":{"id":90201520,"name":"arcs","full_name":"mmandlis/arcs","owner":{"login":"mmandlis","id":25067830,"avatar_url":"https://avatars3.githubusercontent.com/u/25067830?v=4","gravatar_id":"","url":"https://api.github.com/users/mmandlis","html_url":"https://github.com/mmandlis","followers_url":"https://api.github.com/users/mmandlis/followers","following_url":"https://api.github.com/users/mmandlis/following{/other_user}","gists_url":"https://api.github.com/users/mmandlis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmandlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmandlis/subscriptions","organizations_url":"https://api.github.com/users/mmandlis/orgs","repos_url":"https://api.github.com/users/mmandlis/repos","events_url":"https://api.github.com/users/mmandlis/events{/privacy}","received_events_url":"https://api.github.com/users/mmandlis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmandlis/arcs","description":null,"fork":true,"url":"https://api.github.com/repos/mmandlis/arcs","forks_url":"https://api.github.com/repos/mmandlis/arcs/forks","keys_url":"https://api.github.com/repos/mmandlis/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmandlis/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmandlis/arcs/teams","hooks_url":"https://api.github.com/repos/mmandlis/arcs/hooks","issue_events_url":"https://api.github.com/repos/mmandlis/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/mmandlis/arcs/events","assignees_url":"https://api.github.com/repos/mmandlis/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/mmandlis/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/mmandlis/arcs/tags","blobs_url":"https://api.github.com/repos/mmandlis/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmandlis/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmandlis/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmandlis/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmandlis/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/mmandlis/arcs/languages","stargazers_url":"https://api.github.com/repos/mmandlis/arcs/stargazers","contributors_url":"https://api.github.com/repos/mmandlis/arcs/contributors","subscribers_url":"https://api.github.com/repos/mmandlis/arcs/subscribers","subscription_url":"https://api.github.com/repos/mmandlis/arcs/subscription","commits_url":"https://api.github.com/repos/mmandlis/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmandlis/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmandlis/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmandlis/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmandlis/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/mmandlis/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmandlis/arcs/merges","archive_url":"https://api.github.com/repos/mmandlis/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmandlis/arcs/downloads","issues_url":"https://api.github.com/repos/mmandlis/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/mmandlis/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/mmandlis/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/mmandlis/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmandlis/arcs/labels{/name}","releases_url":"https://api.github.com/repos/mmandlis/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/mmandlis/arcs/deployments","created_at":"2017-05-03T23:20:21Z","updated_at":"2017-05-03T23:20:22Z","pushed_at":"2018-02-09T22:06:09Z","git_url":"git://github.com/mmandlis/arcs.git","ssh_url":"git@github.com:mmandlis/arcs.git","clone_url":"https://github.com/mmandlis/arcs.git","svn_url":"https://github.com/mmandlis/arcs","homepage":null,"size":14973,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolymerLabs:master","ref":"master","sha":"69a698d595bd9a42e0ae3ed55f5b578f2a6833b4","user":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":80783122,"name":"arcs","full_name":"PolymerLabs/arcs","owner":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerLabs/arcs","description":null,"fork":false,"url":"https://api.github.com/repos/PolymerLabs/arcs","forks_url":"https://api.github.com/repos/PolymerLabs/arcs/forks","keys_url":"https://api.github.com/repos/PolymerLabs/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerLabs/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerLabs/arcs/teams","hooks_url":"https://api.github.com/repos/PolymerLabs/arcs/hooks","issue_events_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerLabs/arcs/events","assignees_url":"https://api.github.com/repos/PolymerLabs/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerLabs/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerLabs/arcs/tags","blobs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerLabs/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerLabs/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerLabs/arcs/languages","stargazers_url":"https://api.github.com/repos/PolymerLabs/arcs/stargazers","contributors_url":"https://api.github.com/repos/PolymerLabs/arcs/contributors","subscribers_url":"https://api.github.com/repos/PolymerLabs/arcs/subscribers","subscription_url":"https://api.github.com/repos/PolymerLabs/arcs/subscription","commits_url":"https://api.github.com/repos/PolymerLabs/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerLabs/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerLabs/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerLabs/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerLabs/arcs/merges","archive_url":"https://api.github.com/repos/PolymerLabs/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerLabs/arcs/downloads","issues_url":"https://api.github.com/repos/PolymerLabs/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerLabs/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerLabs/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerLabs/arcs/labels{/name}","releases_url":"https://api.github.com/repos/PolymerLabs/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerLabs/arcs/deployments","created_at":"2017-02-03T00:32:19Z","updated_at":"2018-01-31T13:47:58Z","pushed_at":"2018-02-09T22:06:11Z","git_url":"git://github.com/PolymerLabs/arcs.git","ssh_url":"git@github.com:PolymerLabs/arcs.git","clone_url":"https://github.com/PolymerLabs/arcs.git","svn_url":"https://github.com/PolymerLabs/arcs","homepage":null,"size":14919,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":77,"license":null,"forks":12,"open_issues":77,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/675"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/675"},"issue":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/675"},"comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/675/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/675/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/675/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerLabs/arcs/statuses/ee422a0440c9dcde13b1840426ec8d0eb135fff8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mmandlis"}}