{"action":"closed","number":2419,"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2419","id":228894451,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODk0NDUx","html_url":"https://github.com/knative/serving/pull/2419","diff_url":"https://github.com/knative/serving/pull/2419.diff","patch_url":"https://github.com/knative/serving/pull/2419.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/2419","number":2419,"state":"closed","locked":false,"title":"[RELEASE 0.2] Cherry pick #2382","user":{"login":"adrcunha","id":35786489,"node_id":"MDQ6VXNlcjM1Nzg2NDg5","avatar_url":"https://avatars3.githubusercontent.com/u/35786489?v=4","gravatar_id":"","url":"https://api.github.com/users/adrcunha","html_url":"https://github.com/adrcunha","followers_url":"https://api.github.com/users/adrcunha/followers","following_url":"https://api.github.com/users/adrcunha/following{/other_user}","gists_url":"https://api.github.com/users/adrcunha/gists{/gist_id}","starred_url":"https://api.github.com/users/adrcunha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrcunha/subscriptions","organizations_url":"https://api.github.com/users/adrcunha/orgs","repos_url":"https://api.github.com/users/adrcunha/repos","events_url":"https://api.github.com/users/adrcunha/events{/privacy}","received_events_url":"https://api.github.com/users/adrcunha/received_events","type":"User","site_admin":false},"body":"From #2382\r\n\r\nNow `cluster.sh` will use the same artifacts generated by `release.sh` to test Knative Serving. This will avoid surprises in the future due to having slightly different manifests for Serving when testing or releasing.\r\n\r\nAlso fixes #2354.","created_at":"2018-11-07T02:00:45Z","updated_at":"2018-11-07T04:16:37Z","closed_at":"2018-11-07T04:16:37Z","merged_at":"2018-11-07T04:16:36Z","merge_commit_sha":"1036f34badadfa711d88378a1c09a3527bb1584b","assignee":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tcnghia","id":138266,"node_id":"MDQ6VXNlcjEzODI2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/138266?v=4","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":873831452,"node_id":"MDU6TGFiZWw4NzM4MzE0NTI=","url":"https://api.github.com/repos/knative/serving/labels/approved","name":"approved","color":"ededed","default":false},{"id":864751607,"node_id":"MDU6TGFiZWw4NjQ3NTE2MDc=","url":"https://api.github.com/repos/knative/serving/labels/lgtm","name":"lgtm","color":"ededed","default":false},{"id":862145007,"node_id":"MDU6TGFiZWw4NjIxNDUwMDc=","url":"https://api.github.com/repos/knative/serving/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/2419/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/2419/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/2419/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/1183e3604c768ab8207ce13b98bda4e849b8bb23","head":{"label":"adrcunha:release-0.2","ref":"release-0.2","sha":"1183e3604c768ab8207ce13b98bda4e849b8bb23","user":{"login":"adrcunha","id":35786489,"node_id":"MDQ6VXNlcjM1Nzg2NDg5","avatar_url":"https://avatars3.githubusercontent.com/u/35786489?v=4","gravatar_id":"","url":"https://api.github.com/users/adrcunha","html_url":"https://github.com/adrcunha","followers_url":"https://api.github.com/users/adrcunha/followers","following_url":"https://api.github.com/users/adrcunha/following{/other_user}","gists_url":"https://api.github.com/users/adrcunha/gists{/gist_id}","starred_url":"https://api.github.com/users/adrcunha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrcunha/subscriptions","organizations_url":"https://api.github.com/users/adrcunha/orgs","repos_url":"https://api.github.com/users/adrcunha/repos","events_url":"https://api.github.com/users/adrcunha/events{/privacy}","received_events_url":"https://api.github.com/users/adrcunha/received_events","type":"User","site_admin":false},"repo":{"id":148223951,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyMjM5NTE=","name":"serving","full_name":"adrcunha/serving","private":false,"owner":{"login":"adrcunha","id":35786489,"node_id":"MDQ6VXNlcjM1Nzg2NDg5","avatar_url":"https://avatars3.githubusercontent.com/u/35786489?v=4","gravatar_id":"","url":"https://api.github.com/users/adrcunha","html_url":"https://github.com/adrcunha","followers_url":"https://api.github.com/users/adrcunha/followers","following_url":"https://api.github.com/users/adrcunha/following{/other_user}","gists_url":"https://api.github.com/users/adrcunha/gists{/gist_id}","starred_url":"https://api.github.com/users/adrcunha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrcunha/subscriptions","organizations_url":"https://api.github.com/users/adrcunha/orgs","repos_url":"https://api.github.com/users/adrcunha/repos","events_url":"https://api.github.com/users/adrcunha/events{/privacy}","received_events_url":"https://api.github.com/users/adrcunha/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adrcunha/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/adrcunha/serving","forks_url":"https://api.github.com/repos/adrcunha/serving/forks","keys_url":"https://api.github.com/repos/adrcunha/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrcunha/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrcunha/serving/teams","hooks_url":"https://api.github.com/repos/adrcunha/serving/hooks","issue_events_url":"https://api.github.com/repos/adrcunha/serving/issues/events{/number}","events_url":"https://api.github.com/repos/adrcunha/serving/events","assignees_url":"https://api.github.com/repos/adrcunha/serving/assignees{/user}","branches_url":"https://api.github.com/repos/adrcunha/serving/branches{/branch}","tags_url":"https://api.github.com/repos/adrcunha/serving/tags","blobs_url":"https://api.github.com/repos/adrcunha/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrcunha/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrcunha/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrcunha/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrcunha/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/adrcunha/serving/languages","stargazers_url":"https://api.github.com/repos/adrcunha/serving/stargazers","contributors_url":"https://api.github.com/repos/adrcunha/serving/contributors","subscribers_url":"https://api.github.com/repos/adrcunha/serving/subscribers","subscription_url":"https://api.github.com/repos/adrcunha/serving/subscription","commits_url":"https://api.github.com/repos/adrcunha/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrcunha/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrcunha/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrcunha/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrcunha/serving/contents/{+path}","compare_url":"https://api.github.com/repos/adrcunha/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrcunha/serving/merges","archive_url":"https://api.github.com/repos/adrcunha/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrcunha/serving/downloads","issues_url":"https://api.github.com/repos/adrcunha/serving/issues{/number}","pulls_url":"https://api.github.com/repos/adrcunha/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/adrcunha/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/adrcunha/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrcunha/serving/labels{/name}","releases_url":"https://api.github.com/repos/adrcunha/serving/releases{/id}","deployments_url":"https://api.github.com/repos/adrcunha/serving/deployments","created_at":"2018-09-10T21:54:41Z","updated_at":"2018-11-07T01:40:32Z","pushed_at":"2018-11-07T01:59:52Z","git_url":"git://github.com/adrcunha/serving.git","ssh_url":"git@github.com:adrcunha/serving.git","clone_url":"https://github.com/adrcunha/serving.git","svn_url":"https://github.com/adrcunha/serving","homepage":"","size":24048,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:release-0.2","ref":"release-0.2","sha":"0a54a724b9226262609aeb736890d185f398532b","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2018-11-07T02:12:43Z","pushed_at":"2018-11-07T04:16:36Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"","size":24046,"stargazers_count":832,"watchers_count":832,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":163,"mirror_url":null,"archived":false,"open_issues_count":300,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":163,"open_issues":300,"watchers":832,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/2419"},"html":{"href":"https://github.com/knative/serving/pull/2419"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/2419"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/2419/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/2419/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/2419/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/1183e3604c768ab8207ce13b98bda4e849b8bb23"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"knative-prow-robot","id":41213312,"node_id":"MDQ6VXNlcjQxMjEzMzEy","avatar_url":"https://avatars2.githubusercontent.com/u/41213312?v=4","gravatar_id":"","url":"https://api.github.com/users/knative-prow-robot","html_url":"https://github.com/knative-prow-robot","followers_url":"https://api.github.com/users/knative-prow-robot/followers","following_url":"https://api.github.com/users/knative-prow-robot/following{/other_user}","gists_url":"https://api.github.com/users/knative-prow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/knative-prow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative-prow-robot/subscriptions","organizations_url":"https://api.github.com/users/knative-prow-robot/orgs","repos_url":"https://api.github.com/users/knative-prow-robot/repos","events_url":"https://api.github.com/users/knative-prow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/knative-prow-robot/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":319,"deletions":203,"changed_files":12}}
{"actor":{"display_login":"knative-prow-robot"}}