{"action":"created","issue":{"url":"https://api.github.com/repos/nextcloud/server/issues/8373","repository_url":"https://api.github.com/repos/nextcloud/server","labels_url":"https://api.github.com/repos/nextcloud/server/issues/8373/labels{/name}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/8373/comments","events_url":"https://api.github.com/repos/nextcloud/server/issues/8373/events","html_url":"https://github.com/nextcloud/server/pull/8373","id":297399847,"number":8373,"title":"New standard for top right header","user":{"login":"skjnldsv","id":14975046,"avatar_url":"https://avatars0.githubusercontent.com/u/14975046?v=4","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false},"labels":[{"id":389003640,"url":"https://api.github.com/repos/nextcloud/server/labels/2.%20developing","name":"2. developing","color":"0052cc","default":false},{"id":388630313,"url":"https://api.github.com/repos/nextcloud/server/labels/design","name":"design","color":"cc317c","default":false},{"id":386379233,"url":"https://api.github.com/repos/nextcloud/server/labels/enhancement","name":"enhancement","color":"0e8a16","default":true},{"id":838057076,"url":"https://api.github.com/repos/nextcloud/server/labels/standardisation","name":"standardisation","color":"fcabad","default":false}],"state":"open","locked":false,"assignee":{"login":"skjnldsv","id":14975046,"avatar_url":"https://avatars0.githubusercontent.com/u/14975046?v=4","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false},"assignees":[{"login":"skjnldsv","id":14975046,"avatar_url":"https://avatars0.githubusercontent.com/u/14975046?v=4","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/nextcloud/server/milestones/31","html_url":"https://github.com/nextcloud/server/milestone/31","labels_url":"https://api.github.com/repos/nextcloud/server/milestones/31/labels","id":2759863,"number":31,"title":"Nextcloud 14","description":"","creator":{"login":"jancborchardt","id":925062,"avatar_url":"https://avatars2.githubusercontent.com/u/925062?v=4","gravatar_id":"","url":"https://api.github.com/users/jancborchardt","html_url":"https://github.com/jancborchardt","followers_url":"https://api.github.com/users/jancborchardt/followers","following_url":"https://api.github.com/users/jancborchardt/following{/other_user}","gists_url":"https://api.github.com/users/jancborchardt/gists{/gist_id}","starred_url":"https://api.github.com/users/jancborchardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancborchardt/subscriptions","organizations_url":"https://api.github.com/users/jancborchardt/orgs","repos_url":"https://api.github.com/users/jancborchardt/repos","events_url":"https://api.github.com/users/jancborchardt/events{/privacy}","received_events_url":"https://api.github.com/users/jancborchardt/received_events","type":"User","site_admin":false},"open_issues":168,"closed_issues":216,"state":"open","created_at":"2017-09-12T11:43:02Z","updated_at":"2018-02-21T12:30:15Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2018-02-15T10:44:03Z","updated_at":"2018-02-21T12:51:51Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/8373","html_url":"https://github.com/nextcloud/server/pull/8373","diff_url":"https://github.com/nextcloud/server/pull/8373.diff","patch_url":"https://github.com/nextcloud/server/pull/8373.patch"},"body":"### The goal:\r\n- Create a simple way to add icons in the top right header with the minimum amount of css hacks (e.g: none!)\r\n\r\n### Changed:\r\n- The menus are now relative to the icons they belong to\r\n- The width is now based on the browser viewport width (using px units or percent is not possible because of the relative position of the menu and its parent: the icon)\r\n- The arrow is now automatically positioned. Before every app had to HARDCODE the right positioning (which was a nonsense) preventing new apps to add their own menus and therefore messing with the right positioning of all of this mess)\r\n\r\n### Structure:\r\n```\r\n<div class=\"header-right\">\r\n\t<div class=\"xxxxxxxxxx\">\r\n\t\t<div class=\"xxxxxxxxxx-button menutoggle\"></div>\r\n\t\t<div class=\"xxxxxxxxxx-container menu\">\r\n\t\t\t<!-- ALL YOUR MENU CONTENT HERE 🎉 -->\r\n\t\t</div>\r\n\t</div>\r\n</div>\r\n```\r\n\r\nIt's as simple as that! :)\r\n@nextcloud/designers \r\n"},"comment":{"url":"https://api.github.com/repos/nextcloud/server/issues/comments/367316040","html_url":"https://github.com/nextcloud/server/pull/8373#issuecomment-367316040","issue_url":"https://api.github.com/repos/nextcloud/server/issues/8373","id":367316040,"user":{"login":"skjnldsv","id":14975046,"avatar_url":"https://avatars0.githubusercontent.com/u/14975046?v=4","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T12:51:51Z","updated_at":"2018-02-21T12:51:51Z","author_association":"MEMBER","body":"Okay, then we'll have no choices but to either\r\n1. use a div for the arrow and not ::after (so we can set its visibility with the sibling selector)\r\n2. edit the registerMenu function to add a class on open to the top right menu icon container\r\n3. use some arbitrary width values which lead to an uneven visual due to the uneven distance-to-right of the icons menutoggle"}}
{"actor":{"display_login":"skjnldsv"}}