{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/addon-check/pulls/comments/180461983","pull_request_review_id":110885651,"id":180461983,"diff_hunk":"@@ -66,7 +67,7 @@ def main():\n         for directory in args.dir:\n             report.add(check_artifact(directory, args))","path":"kodi_addon_checker/__main__.py","position":18,"original_position":18,"commit_id":"f21a5865029a46d4a5de3acc011371f348f77421","original_commit_id":"f21a5865029a46d4a5de3acc011371f348f77421","user":{"login":"mzfr","id":16623935,"avatar_url":"https://avatars3.githubusercontent.com/u/16623935?v=4","gravatar_id":"","url":"https://api.github.com/users/mzfr","html_url":"https://github.com/mzfr","followers_url":"https://api.github.com/users/mzfr/followers","following_url":"https://api.github.com/users/mzfr/following{/other_user}","gists_url":"https://api.github.com/users/mzfr/gists{/gist_id}","starred_url":"https://api.github.com/users/mzfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzfr/subscriptions","organizations_url":"https://api.github.com/users/mzfr/orgs","repos_url":"https://api.github.com/users/mzfr/repos","events_url":"https://api.github.com/users/mzfr/events{/privacy}","received_events_url":"https://api.github.com/users/mzfr/received_events","type":"User","site_admin":false},"body":"yes and actually I have also missed to add another argument in `check_artifact` function.\r\n\r\n But what I am now finding contradictory is that if we pass single addon  [this](https://github.com/xbmc/addon-check/blob/master/kodi_addon_checker/__main__.py#L41) will directly call the start function. But we are getting [`repo_addons`](https://github.com/xbmc/addon-check/pull/63/files#diff-87cbf8a463aa7f67c8382bdac08ec809R15) from `check_repo` function. So I'll have to do this within the start function but if I do that then we'll have the same issue of having multiple requests for same repo i.e caching addon.xml.\r\n\r\n@Razzeee Am I on the right track or have I missed something here ?","created_at":"2018-04-10T15:20:02Z","updated_at":"2018-04-10T15:20:03Z","html_url":"https://github.com/xbmc/addon-check/pull/63#discussion_r180461983","pull_request_url":"https://api.github.com/repos/xbmc/addon-check/pulls/63","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xbmc/addon-check/pulls/comments/180461983"},"html":{"href":"https://github.com/xbmc/addon-check/pull/63#discussion_r180461983"},"pull_request":{"href":"https://api.github.com/repos/xbmc/addon-check/pulls/63"}},"in_reply_to_id":180451590},"pull_request":{"url":"https://api.github.com/repos/xbmc/addon-check/pulls/63","id":179445887,"html_url":"https://github.com/xbmc/addon-check/pull/63","diff_url":"https://github.com/xbmc/addon-check/pull/63.diff","patch_url":"https://github.com/xbmc/addon-check/pull/63.patch","issue_url":"https://api.github.com/repos/xbmc/addon-check/issues/63","number":63,"state":"open","locked":false,"title":"[WIP]Add check for dependencies within addon.xml","user":{"login":"mzfr","id":16623935,"avatar_url":"https://avatars3.githubusercontent.com/u/16623935?v=4","gravatar_id":"","url":"https://api.github.com/users/mzfr","html_url":"https://github.com/mzfr","followers_url":"https://api.github.com/users/mzfr/followers","following_url":"https://api.github.com/users/mzfr/following{/other_user}","gists_url":"https://api.github.com/users/mzfr/gists{/gist_id}","starred_url":"https://api.github.com/users/mzfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzfr/subscriptions","organizations_url":"https://api.github.com/users/mzfr/orgs","repos_url":"https://api.github.com/users/mzfr/repos","events_url":"https://api.github.com/users/mzfr/events{/privacy}","received_events_url":"https://api.github.com/users/mzfr/received_events","type":"User","site_admin":false},"body":"Sorry, I messed up #51 by merging the branches (via GitHub) into it instead of re-basing (I will keep that in mind) and when I later squashed the commits, **something** went wrong.\r\n\r\nI am working on the changes @Rechi requested i.e\r\n* request addons.xml only once (for a repo check)\r\n* xbmc.(addon|gui|json|metadata|python) dependencies either have to be skipped, or somehow added as available\r\n\r\n","created_at":"2018-04-04T16:29:50Z","updated_at":"2018-04-10T15:20:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c87dc452ef4cc9efc8f858780e5b3c15082e2457","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/addon-check/pulls/63/commits","review_comments_url":"https://api.github.com/repos/xbmc/addon-check/pulls/63/comments","review_comment_url":"https://api.github.com/repos/xbmc/addon-check/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/addon-check/issues/63/comments","statuses_url":"https://api.github.com/repos/xbmc/addon-check/statuses/f21a5865029a46d4a5de3acc011371f348f77421","head":{"label":"mzfr:dependency","ref":"dependency","sha":"f21a5865029a46d4a5de3acc011371f348f77421","user":{"login":"mzfr","id":16623935,"avatar_url":"https://avatars3.githubusercontent.com/u/16623935?v=4","gravatar_id":"","url":"https://api.github.com/users/mzfr","html_url":"https://github.com/mzfr","followers_url":"https://api.github.com/users/mzfr/followers","following_url":"https://api.github.com/users/mzfr/following{/other_user}","gists_url":"https://api.github.com/users/mzfr/gists{/gist_id}","starred_url":"https://api.github.com/users/mzfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzfr/subscriptions","organizations_url":"https://api.github.com/users/mzfr/orgs","repos_url":"https://api.github.com/users/mzfr/repos","events_url":"https://api.github.com/users/mzfr/events{/privacy}","received_events_url":"https://api.github.com/users/mzfr/received_events","type":"User","site_admin":false},"repo":{"id":120640993,"name":"addon-check","full_name":"mzfr/addon-check","owner":{"login":"mzfr","id":16623935,"avatar_url":"https://avatars3.githubusercontent.com/u/16623935?v=4","gravatar_id":"","url":"https://api.github.com/users/mzfr","html_url":"https://github.com/mzfr","followers_url":"https://api.github.com/users/mzfr/followers","following_url":"https://api.github.com/users/mzfr/following{/other_user}","gists_url":"https://api.github.com/users/mzfr/gists{/gist_id}","starred_url":"https://api.github.com/users/mzfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzfr/subscriptions","organizations_url":"https://api.github.com/users/mzfr/orgs","repos_url":"https://api.github.com/users/mzfr/repos","events_url":"https://api.github.com/users/mzfr/events{/privacy}","received_events_url":"https://api.github.com/users/mzfr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mzfr/addon-check","description":"Automatic checks for new repository submissions","fork":true,"url":"https://api.github.com/repos/mzfr/addon-check","forks_url":"https://api.github.com/repos/mzfr/addon-check/forks","keys_url":"https://api.github.com/repos/mzfr/addon-check/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mzfr/addon-check/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mzfr/addon-check/teams","hooks_url":"https://api.github.com/repos/mzfr/addon-check/hooks","issue_events_url":"https://api.github.com/repos/mzfr/addon-check/issues/events{/number}","events_url":"https://api.github.com/repos/mzfr/addon-check/events","assignees_url":"https://api.github.com/repos/mzfr/addon-check/assignees{/user}","branches_url":"https://api.github.com/repos/mzfr/addon-check/branches{/branch}","tags_url":"https://api.github.com/repos/mzfr/addon-check/tags","blobs_url":"https://api.github.com/repos/mzfr/addon-check/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mzfr/addon-check/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mzfr/addon-check/git/refs{/sha}","trees_url":"https://api.github.com/repos/mzfr/addon-check/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mzfr/addon-check/statuses/{sha}","languages_url":"https://api.github.com/repos/mzfr/addon-check/languages","stargazers_url":"https://api.github.com/repos/mzfr/addon-check/stargazers","contributors_url":"https://api.github.com/repos/mzfr/addon-check/contributors","subscribers_url":"https://api.github.com/repos/mzfr/addon-check/subscribers","subscription_url":"https://api.github.com/repos/mzfr/addon-check/subscription","commits_url":"https://api.github.com/repos/mzfr/addon-check/commits{/sha}","git_commits_url":"https://api.github.com/repos/mzfr/addon-check/git/commits{/sha}","comments_url":"https://api.github.com/repos/mzfr/addon-check/comments{/number}","issue_comment_url":"https://api.github.com/repos/mzfr/addon-check/issues/comments{/number}","contents_url":"https://api.github.com/repos/mzfr/addon-check/contents/{+path}","compare_url":"https://api.github.com/repos/mzfr/addon-check/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mzfr/addon-check/merges","archive_url":"https://api.github.com/repos/mzfr/addon-check/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mzfr/addon-check/downloads","issues_url":"https://api.github.com/repos/mzfr/addon-check/issues{/number}","pulls_url":"https://api.github.com/repos/mzfr/addon-check/pulls{/number}","milestones_url":"https://api.github.com/repos/mzfr/addon-check/milestones{/number}","notifications_url":"https://api.github.com/repos/mzfr/addon-check/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mzfr/addon-check/labels{/name}","releases_url":"https://api.github.com/repos/mzfr/addon-check/releases{/id}","deployments_url":"https://api.github.com/repos/mzfr/addon-check/deployments","created_at":"2018-02-07T16:30:37Z","updated_at":"2018-03-28T14:51:36Z","pushed_at":"2018-04-10T14:43:02Z","git_url":"git://github.com/mzfr/addon-check.git","ssh_url":"git@github.com:mzfr/addon-check.git","clone_url":"https://github.com/mzfr/addon-check.git","svn_url":"https://github.com/mzfr/addon-check","homepage":"","size":226,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"15fd7e49cca295a75fb86b60cc3394d9da4c522f","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":109441339,"name":"addon-check","full_name":"xbmc/addon-check","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/addon-check","description":"Automatic checks for new repository submissions","fork":false,"url":"https://api.github.com/repos/xbmc/addon-check","forks_url":"https://api.github.com/repos/xbmc/addon-check/forks","keys_url":"https://api.github.com/repos/xbmc/addon-check/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/addon-check/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/addon-check/teams","hooks_url":"https://api.github.com/repos/xbmc/addon-check/hooks","issue_events_url":"https://api.github.com/repos/xbmc/addon-check/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/addon-check/events","assignees_url":"https://api.github.com/repos/xbmc/addon-check/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/addon-check/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/addon-check/tags","blobs_url":"https://api.github.com/repos/xbmc/addon-check/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/addon-check/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/addon-check/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/addon-check/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/addon-check/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/addon-check/languages","stargazers_url":"https://api.github.com/repos/xbmc/addon-check/stargazers","contributors_url":"https://api.github.com/repos/xbmc/addon-check/contributors","subscribers_url":"https://api.github.com/repos/xbmc/addon-check/subscribers","subscription_url":"https://api.github.com/repos/xbmc/addon-check/subscription","commits_url":"https://api.github.com/repos/xbmc/addon-check/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/addon-check/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/addon-check/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/addon-check/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/addon-check/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/addon-check/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/addon-check/merges","archive_url":"https://api.github.com/repos/xbmc/addon-check/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/addon-check/downloads","issues_url":"https://api.github.com/repos/xbmc/addon-check/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/addon-check/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/addon-check/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/addon-check/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/addon-check/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/addon-check/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/addon-check/deployments","created_at":"2017-11-03T20:46:35Z","updated_at":"2018-04-10T14:20:33Z","pushed_at":"2018-04-10T14:43:04Z","git_url":"git://github.com/xbmc/addon-check.git","ssh_url":"git@github.com:xbmc/addon-check.git","clone_url":"https://github.com/xbmc/addon-check.git","svn_url":"https://github.com/xbmc/addon-check","homepage":"","size":207,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":14,"open_issues":20,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/addon-check/pulls/63"},"html":{"href":"https://github.com/xbmc/addon-check/pull/63"},"issue":{"href":"https://api.github.com/repos/xbmc/addon-check/issues/63"},"comments":{"href":"https://api.github.com/repos/xbmc/addon-check/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/addon-check/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/addon-check/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/addon-check/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/addon-check/statuses/f21a5865029a46d4a5de3acc011371f348f77421"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mzfr"}}