{"action":"created","comment":{"url":"https://api.github.com/repos/ExchangeUnion/xud/pulls/comments/207071740","pull_request_review_id":142610184,"id":207071740,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzA3MTc0MA==","diff_hunk":"@@ -54,6 +54,13 @@ class Pool extends EventEmitter {\n       return;\n     }\n \n+    // TODO differentiate between testnet & mainnet\n+    this.logger.info('Connecting to Seed Peers');\n+    this.addOutbound(new SocketAddress('xud1.test.exchangeunion.com', 8885));\n+    this.addOutbound(new SocketAddress('xud2.test.exchangeunion.com', 8885));\n+    this.addOutbound(new SocketAddress('xud3.test.exchangeunion.com', 8885));","path":"lib/p2p/Pool.ts","position":8,"original_position":8,"commit_id":"6a350aad3bda66fc83287be8becb83d96af1b8b3","original_commit_id":"6a350aad3bda66fc83287be8becb83d96af1b8b3","user":{"login":"moshababo","id":17073733,"node_id":"MDQ6VXNlcjE3MDczNzMz","avatar_url":"https://avatars2.githubusercontent.com/u/17073733?v=4","gravatar_id":"","url":"https://api.github.com/users/moshababo","html_url":"https://github.com/moshababo","followers_url":"https://api.github.com/users/moshababo/followers","following_url":"https://api.github.com/users/moshababo/following{/other_user}","gists_url":"https://api.github.com/users/moshababo/gists{/gist_id}","starred_url":"https://api.github.com/users/moshababo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moshababo/subscriptions","organizations_url":"https://api.github.com/users/moshababo/orgs","repos_url":"https://api.github.com/users/moshababo/repos","events_url":"https://api.github.com/users/moshababo/events{/privacy}","received_events_url":"https://api.github.com/users/moshababo/received_events","type":"User","site_admin":false},"body":"That's Bitcoin Core. Other implementations usually implement it as a param, for the obvious reasons. But that's nothing major. \r\nIn our case, we have a separate RDBMS, and we manage host identities, so I think we should just use that, unless we can think of a reason for not doing so. \r\n","created_at":"2018-08-02T00:31:17Z","updated_at":"2018-08-02T00:31:17Z","html_url":"https://github.com/ExchangeUnion/xud/pull/244#discussion_r207071740","pull_request_url":"https://api.github.com/repos/ExchangeUnion/xud/pulls/244","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ExchangeUnion/xud/pulls/comments/207071740"},"html":{"href":"https://github.com/ExchangeUnion/xud/pull/244#discussion_r207071740"},"pull_request":{"href":"https://api.github.com/repos/ExchangeUnion/xud/pulls/244"}},"in_reply_to_id":207058655},"pull_request":{"url":"https://api.github.com/repos/ExchangeUnion/xud/pulls/244","id":205335924,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MzM1OTI0","html_url":"https://github.com/ExchangeUnion/xud/pull/244","diff_url":"https://github.com/ExchangeUnion/xud/pull/244.diff","patch_url":"https://github.com/ExchangeUnion/xud/pull/244.patch","issue_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/244","number":244,"state":"open","locked":false,"title":"P2P Seeding","user":{"login":"itsbalamurali","id":1926303,"node_id":"MDQ6VXNlcjE5MjYzMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1926303?v=4","gravatar_id":"","url":"https://api.github.com/users/itsbalamurali","html_url":"https://github.com/itsbalamurali","followers_url":"https://api.github.com/users/itsbalamurali/followers","following_url":"https://api.github.com/users/itsbalamurali/following{/other_user}","gists_url":"https://api.github.com/users/itsbalamurali/gists{/gist_id}","starred_url":"https://api.github.com/users/itsbalamurali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsbalamurali/subscriptions","organizations_url":"https://api.github.com/users/itsbalamurali/orgs","repos_url":"https://api.github.com/users/itsbalamurali/repos","events_url":"https://api.github.com/users/itsbalamurali/events{/privacy}","received_events_url":"https://api.github.com/users/itsbalamurali/received_events","type":"User","site_admin":false},"body":"This pr implements:\r\n- seeding from official bootstrap XU Nodes (#233) .\r\n  - xud1.test.exchangeunion.com\r\n  - xud2.test.exchangeunion.com\r\n  - xud3.test.exchangeunion.com\r\n- disconnected peer message logging (#231)\r\n- duplication of hosts uniqueness issue in database (#226)","created_at":"2018-08-01T07:44:15Z","updated_at":"2018-08-02T00:31:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e39fd76b8fe7b121f90c244dd1456597d8fe68f5","assignee":{"login":"itsbalamurali","id":1926303,"node_id":"MDQ6VXNlcjE5MjYzMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1926303?v=4","gravatar_id":"","url":"https://api.github.com/users/itsbalamurali","html_url":"https://github.com/itsbalamurali","followers_url":"https://api.github.com/users/itsbalamurali/followers","following_url":"https://api.github.com/users/itsbalamurali/following{/other_user}","gists_url":"https://api.github.com/users/itsbalamurali/gists{/gist_id}","starred_url":"https://api.github.com/users/itsbalamurali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsbalamurali/subscriptions","organizations_url":"https://api.github.com/users/itsbalamurali/orgs","repos_url":"https://api.github.com/users/itsbalamurali/repos","events_url":"https://api.github.com/users/itsbalamurali/events{/privacy}","received_events_url":"https://api.github.com/users/itsbalamurali/received_events","type":"User","site_admin":false},"assignees":[{"login":"itsbalamurali","id":1926303,"node_id":"MDQ6VXNlcjE5MjYzMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1926303?v=4","gravatar_id":"","url":"https://api.github.com/users/itsbalamurali","html_url":"https://github.com/itsbalamurali","followers_url":"https://api.github.com/users/itsbalamurali/followers","following_url":"https://api.github.com/users/itsbalamurali/following{/other_user}","gists_url":"https://api.github.com/users/itsbalamurali/gists{/gist_id}","starred_url":"https://api.github.com/users/itsbalamurali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsbalamurali/subscriptions","organizations_url":"https://api.github.com/users/itsbalamurali/orgs","repos_url":"https://api.github.com/users/itsbalamurali/repos","events_url":"https://api.github.com/users/itsbalamurali/events{/privacy}","received_events_url":"https://api.github.com/users/itsbalamurali/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":930952990,"node_id":"MDU6TGFiZWw5MzA5NTI5OTA=","url":"https://api.github.com/repos/ExchangeUnion/xud/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ExchangeUnion/xud/pulls/244/commits","review_comments_url":"https://api.github.com/repos/ExchangeUnion/xud/pulls/244/comments","review_comment_url":"https://api.github.com/repos/ExchangeUnion/xud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/244/comments","statuses_url":"https://api.github.com/repos/ExchangeUnion/xud/statuses/6a350aad3bda66fc83287be8becb83d96af1b8b3","head":{"label":"ExchangeUnion:p2p-seeding","ref":"p2p-seeding","sha":"6a350aad3bda66fc83287be8becb83d96af1b8b3","user":{"login":"ExchangeUnion","id":32665502,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjY1NTAy","avatar_url":"https://avatars3.githubusercontent.com/u/32665502?v=4","gravatar_id":"","url":"https://api.github.com/users/ExchangeUnion","html_url":"https://github.com/ExchangeUnion","followers_url":"https://api.github.com/users/ExchangeUnion/followers","following_url":"https://api.github.com/users/ExchangeUnion/following{/other_user}","gists_url":"https://api.github.com/users/ExchangeUnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ExchangeUnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExchangeUnion/subscriptions","organizations_url":"https://api.github.com/users/ExchangeUnion/orgs","repos_url":"https://api.github.com/users/ExchangeUnion/repos","events_url":"https://api.github.com/users/ExchangeUnion/events{/privacy}","received_events_url":"https://api.github.com/users/ExchangeUnion/received_events","type":"Organization","site_admin":false},"repo":{"id":120945739,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NDU3Mzk=","name":"xud","full_name":"ExchangeUnion/xud","owner":{"login":"ExchangeUnion","id":32665502,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjY1NTAy","avatar_url":"https://avatars3.githubusercontent.com/u/32665502?v=4","gravatar_id":"","url":"https://api.github.com/users/ExchangeUnion","html_url":"https://github.com/ExchangeUnion","followers_url":"https://api.github.com/users/ExchangeUnion/followers","following_url":"https://api.github.com/users/ExchangeUnion/following{/other_user}","gists_url":"https://api.github.com/users/ExchangeUnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ExchangeUnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExchangeUnion/subscriptions","organizations_url":"https://api.github.com/users/ExchangeUnion/orgs","repos_url":"https://api.github.com/users/ExchangeUnion/repos","events_url":"https://api.github.com/users/ExchangeUnion/events{/privacy}","received_events_url":"https://api.github.com/users/ExchangeUnion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ExchangeUnion/xud","description":"Exchange Union Daemon - Connecting Cryptocurrency Exchanges","fork":false,"url":"https://api.github.com/repos/ExchangeUnion/xud","forks_url":"https://api.github.com/repos/ExchangeUnion/xud/forks","keys_url":"https://api.github.com/repos/ExchangeUnion/xud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ExchangeUnion/xud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ExchangeUnion/xud/teams","hooks_url":"https://api.github.com/repos/ExchangeUnion/xud/hooks","issue_events_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/events{/number}","events_url":"https://api.github.com/repos/ExchangeUnion/xud/events","assignees_url":"https://api.github.com/repos/ExchangeUnion/xud/assignees{/user}","branches_url":"https://api.github.com/repos/ExchangeUnion/xud/branches{/branch}","tags_url":"https://api.github.com/repos/ExchangeUnion/xud/tags","blobs_url":"https://api.github.com/repos/ExchangeUnion/xud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ExchangeUnion/xud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ExchangeUnion/xud/git/refs{/sha}","trees_url":"https://api.github.com/repos/ExchangeUnion/xud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ExchangeUnion/xud/statuses/{sha}","languages_url":"https://api.github.com/repos/ExchangeUnion/xud/languages","stargazers_url":"https://api.github.com/repos/ExchangeUnion/xud/stargazers","contributors_url":"https://api.github.com/repos/ExchangeUnion/xud/contributors","subscribers_url":"https://api.github.com/repos/ExchangeUnion/xud/subscribers","subscription_url":"https://api.github.com/repos/ExchangeUnion/xud/subscription","commits_url":"https://api.github.com/repos/ExchangeUnion/xud/commits{/sha}","git_commits_url":"https://api.github.com/repos/ExchangeUnion/xud/git/commits{/sha}","comments_url":"https://api.github.com/repos/ExchangeUnion/xud/comments{/number}","issue_comment_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/comments{/number}","contents_url":"https://api.github.com/repos/ExchangeUnion/xud/contents/{+path}","compare_url":"https://api.github.com/repos/ExchangeUnion/xud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ExchangeUnion/xud/merges","archive_url":"https://api.github.com/repos/ExchangeUnion/xud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ExchangeUnion/xud/downloads","issues_url":"https://api.github.com/repos/ExchangeUnion/xud/issues{/number}","pulls_url":"https://api.github.com/repos/ExchangeUnion/xud/pulls{/number}","milestones_url":"https://api.github.com/repos/ExchangeUnion/xud/milestones{/number}","notifications_url":"https://api.github.com/repos/ExchangeUnion/xud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ExchangeUnion/xud/labels{/name}","releases_url":"https://api.github.com/repos/ExchangeUnion/xud/releases{/id}","deployments_url":"https://api.github.com/repos/ExchangeUnion/xud/deployments","created_at":"2018-02-09T19:18:54Z","updated_at":"2018-08-01T23:10:05Z","pushed_at":"2018-08-01T23:54:18Z","git_url":"git://github.com/ExchangeUnion/xud.git","ssh_url":"git@github.com:ExchangeUnion/xud.git","clone_url":"https://github.com/ExchangeUnion/xud.git","svn_url":"https://github.com/ExchangeUnion/xud","homepage":"https://exchangeunion.com","size":1321,"stargazers_count":26,"watchers_count":26,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":12,"open_issues":72,"watchers":26,"default_branch":"master"}},"base":{"label":"ExchangeUnion:master","ref":"master","sha":"42328550cb91ec5acfe17796e468f05ff081299f","user":{"login":"ExchangeUnion","id":32665502,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjY1NTAy","avatar_url":"https://avatars3.githubusercontent.com/u/32665502?v=4","gravatar_id":"","url":"https://api.github.com/users/ExchangeUnion","html_url":"https://github.com/ExchangeUnion","followers_url":"https://api.github.com/users/ExchangeUnion/followers","following_url":"https://api.github.com/users/ExchangeUnion/following{/other_user}","gists_url":"https://api.github.com/users/ExchangeUnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ExchangeUnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExchangeUnion/subscriptions","organizations_url":"https://api.github.com/users/ExchangeUnion/orgs","repos_url":"https://api.github.com/users/ExchangeUnion/repos","events_url":"https://api.github.com/users/ExchangeUnion/events{/privacy}","received_events_url":"https://api.github.com/users/ExchangeUnion/received_events","type":"Organization","site_admin":false},"repo":{"id":120945739,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NDU3Mzk=","name":"xud","full_name":"ExchangeUnion/xud","owner":{"login":"ExchangeUnion","id":32665502,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjY1NTAy","avatar_url":"https://avatars3.githubusercontent.com/u/32665502?v=4","gravatar_id":"","url":"https://api.github.com/users/ExchangeUnion","html_url":"https://github.com/ExchangeUnion","followers_url":"https://api.github.com/users/ExchangeUnion/followers","following_url":"https://api.github.com/users/ExchangeUnion/following{/other_user}","gists_url":"https://api.github.com/users/ExchangeUnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ExchangeUnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExchangeUnion/subscriptions","organizations_url":"https://api.github.com/users/ExchangeUnion/orgs","repos_url":"https://api.github.com/users/ExchangeUnion/repos","events_url":"https://api.github.com/users/ExchangeUnion/events{/privacy}","received_events_url":"https://api.github.com/users/ExchangeUnion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ExchangeUnion/xud","description":"Exchange Union Daemon - Connecting Cryptocurrency Exchanges","fork":false,"url":"https://api.github.com/repos/ExchangeUnion/xud","forks_url":"https://api.github.com/repos/ExchangeUnion/xud/forks","keys_url":"https://api.github.com/repos/ExchangeUnion/xud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ExchangeUnion/xud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ExchangeUnion/xud/teams","hooks_url":"https://api.github.com/repos/ExchangeUnion/xud/hooks","issue_events_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/events{/number}","events_url":"https://api.github.com/repos/ExchangeUnion/xud/events","assignees_url":"https://api.github.com/repos/ExchangeUnion/xud/assignees{/user}","branches_url":"https://api.github.com/repos/ExchangeUnion/xud/branches{/branch}","tags_url":"https://api.github.com/repos/ExchangeUnion/xud/tags","blobs_url":"https://api.github.com/repos/ExchangeUnion/xud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ExchangeUnion/xud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ExchangeUnion/xud/git/refs{/sha}","trees_url":"https://api.github.com/repos/ExchangeUnion/xud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ExchangeUnion/xud/statuses/{sha}","languages_url":"https://api.github.com/repos/ExchangeUnion/xud/languages","stargazers_url":"https://api.github.com/repos/ExchangeUnion/xud/stargazers","contributors_url":"https://api.github.com/repos/ExchangeUnion/xud/contributors","subscribers_url":"https://api.github.com/repos/ExchangeUnion/xud/subscribers","subscription_url":"https://api.github.com/repos/ExchangeUnion/xud/subscription","commits_url":"https://api.github.com/repos/ExchangeUnion/xud/commits{/sha}","git_commits_url":"https://api.github.com/repos/ExchangeUnion/xud/git/commits{/sha}","comments_url":"https://api.github.com/repos/ExchangeUnion/xud/comments{/number}","issue_comment_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/comments{/number}","contents_url":"https://api.github.com/repos/ExchangeUnion/xud/contents/{+path}","compare_url":"https://api.github.com/repos/ExchangeUnion/xud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ExchangeUnion/xud/merges","archive_url":"https://api.github.com/repos/ExchangeUnion/xud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ExchangeUnion/xud/downloads","issues_url":"https://api.github.com/repos/ExchangeUnion/xud/issues{/number}","pulls_url":"https://api.github.com/repos/ExchangeUnion/xud/pulls{/number}","milestones_url":"https://api.github.com/repos/ExchangeUnion/xud/milestones{/number}","notifications_url":"https://api.github.com/repos/ExchangeUnion/xud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ExchangeUnion/xud/labels{/name}","releases_url":"https://api.github.com/repos/ExchangeUnion/xud/releases{/id}","deployments_url":"https://api.github.com/repos/ExchangeUnion/xud/deployments","created_at":"2018-02-09T19:18:54Z","updated_at":"2018-08-01T23:10:05Z","pushed_at":"2018-08-01T23:54:18Z","git_url":"git://github.com/ExchangeUnion/xud.git","ssh_url":"git@github.com:ExchangeUnion/xud.git","clone_url":"https://github.com/ExchangeUnion/xud.git","svn_url":"https://github.com/ExchangeUnion/xud","homepage":"https://exchangeunion.com","size":1321,"stargazers_count":26,"watchers_count":26,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":12,"open_issues":72,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ExchangeUnion/xud/pulls/244"},"html":{"href":"https://github.com/ExchangeUnion/xud/pull/244"},"issue":{"href":"https://api.github.com/repos/ExchangeUnion/xud/issues/244"},"comments":{"href":"https://api.github.com/repos/ExchangeUnion/xud/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/ExchangeUnion/xud/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/ExchangeUnion/xud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ExchangeUnion/xud/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/ExchangeUnion/xud/statuses/6a350aad3bda66fc83287be8becb83d96af1b8b3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"moshababo"}}