{"action":"created","comment":{"url":"https://api.github.com/repos/php-twinfield/twinfield/pulls/comments/203636290","pull_request_review_id":138563477,"id":203636290,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzYzNjI5MA==","diff_hunk":"@@ -338,6 +338,16 @@ public function addAddress(CustomerAddress $address)\n         return $this;\n     }\n \n+    public function removeAddress($index)\n+    {\n+        if (array_key_exists($index, $this->addresses)) {\n+            unset($this->addresses[$index]);\n+            return true;\n+        } else {","path":"src/Customer.php","position":9,"original_position":9,"commit_id":"e8c137d1f7238fc4c6959e3d0aeb527bdfae8fe2","original_commit_id":"e8c137d1f7238fc4c6959e3d0aeb527bdfae8fe2","user":{"login":"willemstuursma","id":701299,"node_id":"MDQ6VXNlcjcwMTI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/701299?v=4","gravatar_id":"","url":"https://api.github.com/users/willemstuursma","html_url":"https://github.com/willemstuursma","followers_url":"https://api.github.com/users/willemstuursma/followers","following_url":"https://api.github.com/users/willemstuursma/following{/other_user}","gists_url":"https://api.github.com/users/willemstuursma/gists{/gist_id}","starred_url":"https://api.github.com/users/willemstuursma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willemstuursma/subscriptions","organizations_url":"https://api.github.com/users/willemstuursma/orgs","repos_url":"https://api.github.com/users/willemstuursma/repos","events_url":"https://api.github.com/users/willemstuursma/events{/privacy}","received_events_url":"https://api.github.com/users/willemstuursma/received_events","type":"User","site_admin":false},"body":"No `else` is needed here, because of the return. \r\n\r\nCan you add type hints, e.g. int for the parameter index and bool for the method return value. ","created_at":"2018-07-19T08:11:24Z","updated_at":"2018-07-19T08:11:25Z","html_url":"https://github.com/php-twinfield/twinfield/pull/115#discussion_r203636290","pull_request_url":"https://api.github.com/repos/php-twinfield/twinfield/pulls/115","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/php-twinfield/twinfield/pulls/comments/203636290"},"html":{"href":"https://github.com/php-twinfield/twinfield/pull/115#discussion_r203636290"},"pull_request":{"href":"https://api.github.com/repos/php-twinfield/twinfield/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/php-twinfield/twinfield/pulls/115","id":201921755,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxOTIxNzU1","html_url":"https://github.com/php-twinfield/twinfield/pull/115","diff_url":"https://github.com/php-twinfield/twinfield/pull/115.diff","patch_url":"https://github.com/php-twinfield/twinfield/pull/115.patch","issue_url":"https://api.github.com/repos/php-twinfield/twinfield/issues/115","number":115,"state":"open","locked":false,"title":"removeAddress() method in the Customer class.","user":{"login":"mikedutchtelco","id":40169614,"node_id":"MDQ6VXNlcjQwMTY5NjE0","avatar_url":"https://avatars3.githubusercontent.com/u/40169614?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedutchtelco","html_url":"https://github.com/mikedutchtelco","followers_url":"https://api.github.com/users/mikedutchtelco/followers","following_url":"https://api.github.com/users/mikedutchtelco/following{/other_user}","gists_url":"https://api.github.com/users/mikedutchtelco/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedutchtelco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedutchtelco/subscriptions","organizations_url":"https://api.github.com/users/mikedutchtelco/orgs","repos_url":"https://api.github.com/users/mikedutchtelco/repos","events_url":"https://api.github.com/users/mikedutchtelco/events{/privacy}","received_events_url":"https://api.github.com/users/mikedutchtelco/received_events","type":"User","site_admin":false},"body":"I would like to use the removeAddress() method in the Customer class but when I try to use it, it give me an error. After searching in the method I noticed that the 'addresses' property in this method was misspelled two times (two different ways).\r\n\r\nI've changed the name of the properties and it now works fine for me.","created_at":"2018-07-17T12:17:24Z","updated_at":"2018-07-19T08:11:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f9223f82d30cba9ca1623f2612919bdbdb95930","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/php-twinfield/twinfield/pulls/115/commits","review_comments_url":"https://api.github.com/repos/php-twinfield/twinfield/pulls/115/comments","review_comment_url":"https://api.github.com/repos/php-twinfield/twinfield/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-twinfield/twinfield/issues/115/comments","statuses_url":"https://api.github.com/repos/php-twinfield/twinfield/statuses/e8c137d1f7238fc4c6959e3d0aeb527bdfae8fe2","head":{"label":"mikedutchtelco:bugfix_removeAddress","ref":"bugfix_removeAddress","sha":"e8c137d1f7238fc4c6959e3d0aeb527bdfae8fe2","user":{"login":"mikedutchtelco","id":40169614,"node_id":"MDQ6VXNlcjQwMTY5NjE0","avatar_url":"https://avatars3.githubusercontent.com/u/40169614?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedutchtelco","html_url":"https://github.com/mikedutchtelco","followers_url":"https://api.github.com/users/mikedutchtelco/followers","following_url":"https://api.github.com/users/mikedutchtelco/following{/other_user}","gists_url":"https://api.github.com/users/mikedutchtelco/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedutchtelco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedutchtelco/subscriptions","organizations_url":"https://api.github.com/users/mikedutchtelco/orgs","repos_url":"https://api.github.com/users/mikedutchtelco/repos","events_url":"https://api.github.com/users/mikedutchtelco/events{/privacy}","received_events_url":"https://api.github.com/users/mikedutchtelco/received_events","type":"User","site_admin":false},"repo":{"id":141284071,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyODQwNzE=","name":"twinfield","full_name":"mikedutchtelco/twinfield","owner":{"login":"mikedutchtelco","id":40169614,"node_id":"MDQ6VXNlcjQwMTY5NjE0","avatar_url":"https://avatars3.githubusercontent.com/u/40169614?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedutchtelco","html_url":"https://github.com/mikedutchtelco","followers_url":"https://api.github.com/users/mikedutchtelco/followers","following_url":"https://api.github.com/users/mikedutchtelco/following{/other_user}","gists_url":"https://api.github.com/users/mikedutchtelco/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedutchtelco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedutchtelco/subscriptions","organizations_url":"https://api.github.com/users/mikedutchtelco/orgs","repos_url":"https://api.github.com/users/mikedutchtelco/repos","events_url":"https://api.github.com/users/mikedutchtelco/events{/privacy}","received_events_url":"https://api.github.com/users/mikedutchtelco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikedutchtelco/twinfield","description":"PHP 7.1+ Library for using the Twinfield API.","fork":true,"url":"https://api.github.com/repos/mikedutchtelco/twinfield","forks_url":"https://api.github.com/repos/mikedutchtelco/twinfield/forks","keys_url":"https://api.github.com/repos/mikedutchtelco/twinfield/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikedutchtelco/twinfield/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikedutchtelco/twinfield/teams","hooks_url":"https://api.github.com/repos/mikedutchtelco/twinfield/hooks","issue_events_url":"https://api.github.com/repos/mikedutchtelco/twinfield/issues/events{/number}","events_url":"https://api.github.com/repos/mikedutchtelco/twinfield/events","assignees_url":"https://api.github.com/repos/mikedutchtelco/twinfield/assignees{/user}","branches_url":"https://api.github.com/repos/mikedutchtelco/twinfield/branches{/branch}","tags_url":"https://api.github.com/repos/mikedutchtelco/twinfield/tags","blobs_url":"https://api.github.com/repos/mikedutchtelco/twinfield/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikedutchtelco/twinfield/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikedutchtelco/twinfield/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikedutchtelco/twinfield/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikedutchtelco/twinfield/statuses/{sha}","languages_url":"https://api.github.com/repos/mikedutchtelco/twinfield/languages","stargazers_url":"https://api.github.com/repos/mikedutchtelco/twinfield/stargazers","contributors_url":"https://api.github.com/repos/mikedutchtelco/twinfield/contributors","subscribers_url":"https://api.github.com/repos/mikedutchtelco/twinfield/subscribers","subscription_url":"https://api.github.com/repos/mikedutchtelco/twinfield/subscription","commits_url":"https://api.github.com/repos/mikedutchtelco/twinfield/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikedutchtelco/twinfield/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikedutchtelco/twinfield/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikedutchtelco/twinfield/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikedutchtelco/twinfield/contents/{+path}","compare_url":"https://api.github.com/repos/mikedutchtelco/twinfield/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikedutchtelco/twinfield/merges","archive_url":"https://api.github.com/repos/mikedutchtelco/twinfield/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikedutchtelco/twinfield/downloads","issues_url":"https://api.github.com/repos/mikedutchtelco/twinfield/issues{/number}","pulls_url":"https://api.github.com/repos/mikedutchtelco/twinfield/pulls{/number}","milestones_url":"https://api.github.com/repos/mikedutchtelco/twinfield/milestones{/number}","notifications_url":"https://api.github.com/repos/mikedutchtelco/twinfield/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikedutchtelco/twinfield/labels{/name}","releases_url":"https://api.github.com/repos/mikedutchtelco/twinfield/releases{/id}","deployments_url":"https://api.github.com/repos/mikedutchtelco/twinfield/deployments","created_at":"2018-07-17T12:03:29Z","updated_at":"2018-07-17T12:03:31Z","pushed_at":"2018-07-17T12:09:09Z","git_url":"git://github.com/mikedutchtelco/twinfield.git","ssh_url":"git@github.com:mikedutchtelco/twinfield.git","clone_url":"https://github.com/mikedutchtelco/twinfield.git","svn_url":"https://github.com/mikedutchtelco/twinfield","homepage":"https://c3.twinfield.com/webservices/documentation/#/","size":791,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php-twinfield:master","ref":"master","sha":"861bb3be988cbac361d6671d2c29af0163f0bc03","user":{"login":"php-twinfield","id":7997233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5OTcyMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/7997233?v=4","gravatar_id":"","url":"https://api.github.com/users/php-twinfield","html_url":"https://github.com/php-twinfield","followers_url":"https://api.github.com/users/php-twinfield/followers","following_url":"https://api.github.com/users/php-twinfield/following{/other_user}","gists_url":"https://api.github.com/users/php-twinfield/gists{/gist_id}","starred_url":"https://api.github.com/users/php-twinfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-twinfield/subscriptions","organizations_url":"https://api.github.com/users/php-twinfield/orgs","repos_url":"https://api.github.com/users/php-twinfield/repos","events_url":"https://api.github.com/users/php-twinfield/events{/privacy}","received_events_url":"https://api.github.com/users/php-twinfield/received_events","type":"Organization","site_admin":false},"repo":{"id":110521756,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1MjE3NTY=","name":"twinfield","full_name":"php-twinfield/twinfield","owner":{"login":"php-twinfield","id":7997233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5OTcyMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/7997233?v=4","gravatar_id":"","url":"https://api.github.com/users/php-twinfield","html_url":"https://github.com/php-twinfield","followers_url":"https://api.github.com/users/php-twinfield/followers","following_url":"https://api.github.com/users/php-twinfield/following{/other_user}","gists_url":"https://api.github.com/users/php-twinfield/gists{/gist_id}","starred_url":"https://api.github.com/users/php-twinfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-twinfield/subscriptions","organizations_url":"https://api.github.com/users/php-twinfield/orgs","repos_url":"https://api.github.com/users/php-twinfield/repos","events_url":"https://api.github.com/users/php-twinfield/events{/privacy}","received_events_url":"https://api.github.com/users/php-twinfield/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-twinfield/twinfield","description":"PHP 7.1+ Library for using the Twinfield API.","fork":false,"url":"https://api.github.com/repos/php-twinfield/twinfield","forks_url":"https://api.github.com/repos/php-twinfield/twinfield/forks","keys_url":"https://api.github.com/repos/php-twinfield/twinfield/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-twinfield/twinfield/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-twinfield/twinfield/teams","hooks_url":"https://api.github.com/repos/php-twinfield/twinfield/hooks","issue_events_url":"https://api.github.com/repos/php-twinfield/twinfield/issues/events{/number}","events_url":"https://api.github.com/repos/php-twinfield/twinfield/events","assignees_url":"https://api.github.com/repos/php-twinfield/twinfield/assignees{/user}","branches_url":"https://api.github.com/repos/php-twinfield/twinfield/branches{/branch}","tags_url":"https://api.github.com/repos/php-twinfield/twinfield/tags","blobs_url":"https://api.github.com/repos/php-twinfield/twinfield/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-twinfield/twinfield/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-twinfield/twinfield/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-twinfield/twinfield/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-twinfield/twinfield/statuses/{sha}","languages_url":"https://api.github.com/repos/php-twinfield/twinfield/languages","stargazers_url":"https://api.github.com/repos/php-twinfield/twinfield/stargazers","contributors_url":"https://api.github.com/repos/php-twinfield/twinfield/contributors","subscribers_url":"https://api.github.com/repos/php-twinfield/twinfield/subscribers","subscription_url":"https://api.github.com/repos/php-twinfield/twinfield/subscription","commits_url":"https://api.github.com/repos/php-twinfield/twinfield/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-twinfield/twinfield/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-twinfield/twinfield/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-twinfield/twinfield/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-twinfield/twinfield/contents/{+path}","compare_url":"https://api.github.com/repos/php-twinfield/twinfield/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-twinfield/twinfield/merges","archive_url":"https://api.github.com/repos/php-twinfield/twinfield/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-twinfield/twinfield/downloads","issues_url":"https://api.github.com/repos/php-twinfield/twinfield/issues{/number}","pulls_url":"https://api.github.com/repos/php-twinfield/twinfield/pulls{/number}","milestones_url":"https://api.github.com/repos/php-twinfield/twinfield/milestones{/number}","notifications_url":"https://api.github.com/repos/php-twinfield/twinfield/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-twinfield/twinfield/labels{/name}","releases_url":"https://api.github.com/repos/php-twinfield/twinfield/releases{/id}","deployments_url":"https://api.github.com/repos/php-twinfield/twinfield/deployments","created_at":"2017-11-13T08:37:36Z","updated_at":"2018-07-17T15:41:44Z","pushed_at":"2018-07-17T15:41:42Z","git_url":"git://github.com/php-twinfield/twinfield.git","ssh_url":"git@github.com:php-twinfield/twinfield.git","clone_url":"https://github.com/php-twinfield/twinfield.git","svn_url":"https://github.com/php-twinfield/twinfield","homepage":"https://c3.twinfield.com/webservices/documentation/#/","size":794,"stargazers_count":13,"watchers_count":13,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":7,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-twinfield/twinfield/pulls/115"},"html":{"href":"https://github.com/php-twinfield/twinfield/pull/115"},"issue":{"href":"https://api.github.com/repos/php-twinfield/twinfield/issues/115"},"comments":{"href":"https://api.github.com/repos/php-twinfield/twinfield/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/php-twinfield/twinfield/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/php-twinfield/twinfield/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-twinfield/twinfield/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/php-twinfield/twinfield/statuses/e8c137d1f7238fc4c6959e3d0aeb527bdfae8fe2"}},"author_association":"NONE"}}
{"actor":{"display_login":"willemstuursma"}}