{"action":"created","comment":{"url":"https://api.github.com/repos/coq/coq/pulls/comments/172857595","pull_request_review_id":101945895,"id":172857595,"diff_hunk":"@@ -13,12 +13,11 @@ Notation \"0\" := (trunc_S minus_one) : trunc_scope.\n Class IsTrunc (n : trunc_index) (A : Type) : Type := Trunc_is_trunc : IsTrunc_internal n A.\n Notation IsHProp := (IsTrunc minus_one).\n Notation IsHSet := (IsTrunc 0).\n-Set Refolding Reduction.\n Goal forall (A : Type) (a b : A) (H' : IsHSet A), { x : Type & IsHProp x }.\n Proof.\n intros.\n eexists.\n (* exact (H' a b). *)\n (* Undo. *)\n-apply (H' a b).\n+now simpl; apply (H' a b).","path":"test-suite/bugs/closed/3424.v","position":12,"original_position":12,"commit_id":"0cd65aa66b5b96042bdd1fc91d04657ed3fc54ae","original_commit_id":"0cd65aa66b5b96042bdd1fc91d04657ed3fc54ae","user":{"login":"gares","id":1013846,"avatar_url":"https://avatars2.githubusercontent.com/u/1013846?v=4","gravatar_id":"","url":"https://api.github.com/users/gares","html_url":"https://github.com/gares","followers_url":"https://api.github.com/users/gares/followers","following_url":"https://api.github.com/users/gares/following{/other_user}","gists_url":"https://api.github.com/users/gares/gists{/gist_id}","starred_url":"https://api.github.com/users/gares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gares/subscriptions","organizations_url":"https://api.github.com/users/gares/orgs","repos_url":"https://api.github.com/users/gares/repos","events_url":"https://api.github.com/users/gares/events{/privacy}","received_events_url":"https://api.github.com/users/gares/received_events","type":"User","site_admin":false},"body":"This bug has nothing to do with refonding. Refolding Reduction did probably enable some reduction/contraction in `apply` that is now disabled.\r\n\r\nThe real bug is in `apply` using a broken unification engine.\r\n\r\nIf you use `refine` or `apply:` it works fine. Probably `exact` uses a different unification engine (than apply; I tried to track it down, but I got lost in the `_gen` programming style).\r\n\r\nSo yes the bug is open, the diagnosis is bogus and, IMO, the flag can go.","created_at":"2018-03-07T14:26:52Z","updated_at":"2018-03-07T14:26:52Z","html_url":"https://github.com/coq/coq/pull/6895#discussion_r172857595","pull_request_url":"https://api.github.com/repos/coq/coq/pulls/6895","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/comments/172857595"},"html":{"href":"https://github.com/coq/coq/pull/6895#discussion_r172857595"},"pull_request":{"href":"https://api.github.com/repos/coq/coq/pulls/6895"}},"in_reply_to_id":172445594},"pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/6895","id":172637969,"html_url":"https://github.com/coq/coq/pull/6895","diff_url":"https://github.com/coq/coq/pull/6895.diff","patch_url":"https://github.com/coq/coq/pull/6895.patch","issue_url":"https://api.github.com/repos/coq/coq/issues/6895","number":6895,"state":"open","locked":false,"title":"[compat] Remove \"Refolding Reduction\" option.","user":{"login":"ejgallego","id":7192257,"avatar_url":"https://avatars2.githubusercontent.com/u/7192257?v=4","gravatar_id":"","url":"https://api.github.com/users/ejgallego","html_url":"https://github.com/ejgallego","followers_url":"https://api.github.com/users/ejgallego/followers","following_url":"https://api.github.com/users/ejgallego/following{/other_user}","gists_url":"https://api.github.com/users/ejgallego/gists{/gist_id}","starred_url":"https://api.github.com/users/ejgallego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejgallego/subscriptions","organizations_url":"https://api.github.com/users/ejgallego/orgs","repos_url":"https://api.github.com/users/ejgallego/repos","events_url":"https://api.github.com/users/ejgallego/events{/privacy}","received_events_url":"https://api.github.com/users/ejgallego/received_events","type":"User","site_admin":false},"body":"Following up on #6791, we remove support refolding in reduction.\r\n","created_at":"2018-03-03T00:44:36Z","updated_at":"2018-03-07T14:26:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d1187d7566eb32d60aa6e406d3407d6a70e3a16","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":485985791,"url":"https://api.github.com/repos/coq/coq/labels/kind:%20cleanup","name":"kind: cleanup","color":"3366ff","default":false}],"milestone":{"url":"https://api.github.com/repos/coq/coq/milestones/5","html_url":"https://github.com/coq/coq/milestone/5","labels_url":"https://api.github.com/repos/coq/coq/milestones/5/labels","id":2550427,"number":5,"title":"8.8+beta1","description":"","creator":{"login":"maximedenes","id":647105,"avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"open_issues":78,"closed_issues":436,"state":"open","created_at":"2017-05-30T13:02:47Z","updated_at":"2018-03-07T13:45:29Z","due_on":"2018-03-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coq/coq/pulls/6895/commits","review_comments_url":"https://api.github.com/repos/coq/coq/pulls/6895/comments","review_comment_url":"https://api.github.com/repos/coq/coq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coq/coq/issues/6895/comments","statuses_url":"https://api.github.com/repos/coq/coq/statuses/0cd65aa66b5b96042bdd1fc91d04657ed3fc54ae","head":{"label":"ejgallego:pretyping+remove_refolding_in_resolution","ref":"pretyping+remove_refolding_in_resolution","sha":"0cd65aa66b5b96042bdd1fc91d04657ed3fc54ae","user":{"login":"ejgallego","id":7192257,"avatar_url":"https://avatars2.githubusercontent.com/u/7192257?v=4","gravatar_id":"","url":"https://api.github.com/users/ejgallego","html_url":"https://github.com/ejgallego","followers_url":"https://api.github.com/users/ejgallego/followers","following_url":"https://api.github.com/users/ejgallego/following{/other_user}","gists_url":"https://api.github.com/users/ejgallego/gists{/gist_id}","starred_url":"https://api.github.com/users/ejgallego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejgallego/subscriptions","organizations_url":"https://api.github.com/users/ejgallego/orgs","repos_url":"https://api.github.com/users/ejgallego/repos","events_url":"https://api.github.com/users/ejgallego/events{/privacy}","received_events_url":"https://api.github.com/users/ejgallego/received_events","type":"User","site_admin":false},"repo":{"id":40771167,"name":"coq","full_name":"ejgallego/coq","owner":{"login":"ejgallego","id":7192257,"avatar_url":"https://avatars2.githubusercontent.com/u/7192257?v=4","gravatar_id":"","url":"https://api.github.com/users/ejgallego","html_url":"https://github.com/ejgallego","followers_url":"https://api.github.com/users/ejgallego/followers","following_url":"https://api.github.com/users/ejgallego/following{/other_user}","gists_url":"https://api.github.com/users/ejgallego/gists{/gist_id}","starred_url":"https://api.github.com/users/ejgallego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejgallego/subscriptions","organizations_url":"https://api.github.com/users/ejgallego/orgs","repos_url":"https://api.github.com/users/ejgallego/repos","events_url":"https://api.github.com/users/ejgallego/events{/privacy}","received_events_url":"https://api.github.com/users/ejgallego/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ejgallego/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":true,"url":"https://api.github.com/repos/ejgallego/coq","forks_url":"https://api.github.com/repos/ejgallego/coq/forks","keys_url":"https://api.github.com/repos/ejgallego/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ejgallego/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ejgallego/coq/teams","hooks_url":"https://api.github.com/repos/ejgallego/coq/hooks","issue_events_url":"https://api.github.com/repos/ejgallego/coq/issues/events{/number}","events_url":"https://api.github.com/repos/ejgallego/coq/events","assignees_url":"https://api.github.com/repos/ejgallego/coq/assignees{/user}","branches_url":"https://api.github.com/repos/ejgallego/coq/branches{/branch}","tags_url":"https://api.github.com/repos/ejgallego/coq/tags","blobs_url":"https://api.github.com/repos/ejgallego/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ejgallego/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ejgallego/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ejgallego/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ejgallego/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/ejgallego/coq/languages","stargazers_url":"https://api.github.com/repos/ejgallego/coq/stargazers","contributors_url":"https://api.github.com/repos/ejgallego/coq/contributors","subscribers_url":"https://api.github.com/repos/ejgallego/coq/subscribers","subscription_url":"https://api.github.com/repos/ejgallego/coq/subscription","commits_url":"https://api.github.com/repos/ejgallego/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ejgallego/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ejgallego/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ejgallego/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ejgallego/coq/contents/{+path}","compare_url":"https://api.github.com/repos/ejgallego/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ejgallego/coq/merges","archive_url":"https://api.github.com/repos/ejgallego/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ejgallego/coq/downloads","issues_url":"https://api.github.com/repos/ejgallego/coq/issues{/number}","pulls_url":"https://api.github.com/repos/ejgallego/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/ejgallego/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/ejgallego/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ejgallego/coq/labels{/name}","releases_url":"https://api.github.com/repos/ejgallego/coq/releases{/id}","deployments_url":"https://api.github.com/repos/ejgallego/coq/deployments","created_at":"2015-08-15T16:34:17Z","updated_at":"2016-04-15T09:11:04Z","pushed_at":"2018-03-07T02:04:23Z","git_url":"git://github.com/ejgallego/coq.git","ssh_url":"git@github.com:ejgallego/coq.git","clone_url":"https://github.com/ejgallego/coq.git","svn_url":"https://github.com/ejgallego/coq","homepage":"http://coq.inria.fr/","size":95186,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coq:master","ref":"master","sha":"78551857a41a57607ecfb3fd010e0a9755f47cea","user":{"login":"coq","id":621198,"avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"repo":{"id":1377159,"name":"coq","full_name":"coq/coq","owner":{"login":"coq","id":621198,"avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coq/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":false,"url":"https://api.github.com/repos/coq/coq","forks_url":"https://api.github.com/repos/coq/coq/forks","keys_url":"https://api.github.com/repos/coq/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coq/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coq/coq/teams","hooks_url":"https://api.github.com/repos/coq/coq/hooks","issue_events_url":"https://api.github.com/repos/coq/coq/issues/events{/number}","events_url":"https://api.github.com/repos/coq/coq/events","assignees_url":"https://api.github.com/repos/coq/coq/assignees{/user}","branches_url":"https://api.github.com/repos/coq/coq/branches{/branch}","tags_url":"https://api.github.com/repos/coq/coq/tags","blobs_url":"https://api.github.com/repos/coq/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coq/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coq/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/coq/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coq/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/coq/coq/languages","stargazers_url":"https://api.github.com/repos/coq/coq/stargazers","contributors_url":"https://api.github.com/repos/coq/coq/contributors","subscribers_url":"https://api.github.com/repos/coq/coq/subscribers","subscription_url":"https://api.github.com/repos/coq/coq/subscription","commits_url":"https://api.github.com/repos/coq/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/coq/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/coq/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/coq/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/coq/coq/contents/{+path}","compare_url":"https://api.github.com/repos/coq/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coq/coq/merges","archive_url":"https://api.github.com/repos/coq/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coq/coq/downloads","issues_url":"https://api.github.com/repos/coq/coq/issues{/number}","pulls_url":"https://api.github.com/repos/coq/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/coq/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/coq/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coq/coq/labels{/name}","releases_url":"https://api.github.com/repos/coq/coq/releases{/id}","deployments_url":"https://api.github.com/repos/coq/coq/deployments","created_at":"2011-02-17T05:49:37Z","updated_at":"2018-03-07T12:15:00Z","pushed_at":"2018-03-07T14:09:45Z","git_url":"git://github.com/coq/coq.git","ssh_url":"git@github.com:coq/coq.git","clone_url":"https://github.com/coq/coq.git","svn_url":"https://github.com/coq/coq","homepage":"https://coq.inria.fr/","size":106057,"stargazers_count":1049,"watchers_count":1049,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":229,"mirror_url":null,"archived":false,"open_issues_count":1459,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":229,"open_issues":1459,"watchers":1049,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/6895"},"html":{"href":"https://github.com/coq/coq/pull/6895"},"issue":{"href":"https://api.github.com/repos/coq/coq/issues/6895"},"comments":{"href":"https://api.github.com/repos/coq/coq/issues/6895/comments"},"review_comments":{"href":"https://api.github.com/repos/coq/coq/pulls/6895/comments"},"review_comment":{"href":"https://api.github.com/repos/coq/coq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coq/coq/pulls/6895/commits"},"statuses":{"href":"https://api.github.com/repos/coq/coq/statuses/0cd65aa66b5b96042bdd1fc91d04657ed3fc54ae"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gares"}}