{"action":"created","issue":{"url":"https://api.github.com/repos/freifunk-gluon/gluon/issues/1558","repository_url":"https://api.github.com/repos/freifunk-gluon/gluon","labels_url":"https://api.github.com/repos/freifunk-gluon/gluon/issues/1558/labels{/name}","comments_url":"https://api.github.com/repos/freifunk-gluon/gluon/issues/1558/comments","events_url":"https://api.github.com/repos/freifunk-gluon/gluon/issues/1558/events","html_url":"https://github.com/freifunk-gluon/gluon/pull/1558","id":373380313,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzIyMTEx","number":1558,"title":"RFC: Replace hardcoded targets/patches paths with appropriate GLUON_ make variables","user":{"login":"ynezz","id":43848,"node_id":"MDQ6VXNlcjQzODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/43848?v=4","gravatar_id":"","url":"https://api.github.com/users/ynezz","html_url":"https://github.com/ynezz","followers_url":"https://api.github.com/users/ynezz/followers","following_url":"https://api.github.com/users/ynezz/following{/other_user}","gists_url":"https://api.github.com/users/ynezz/gists{/gist_id}","starred_url":"https://api.github.com/users/ynezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynezz/subscriptions","organizations_url":"https://api.github.com/users/ynezz/orgs","repos_url":"https://api.github.com/users/ynezz/repos","events_url":"https://api.github.com/users/ynezz/events{/privacy}","received_events_url":"https://api.github.com/users/ynezz/received_events","type":"User","site_admin":false},"labels":[{"id":384301838,"node_id":"MDU6TGFiZWwzODQzMDE4Mzg=","url":"https://api.github.com/repos/freifunk-gluon/gluon/labels/RFC","name":"RFC","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-24T09:08:50Z","updated_at":"2018-11-12T08:15:47Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/freifunk-gluon/gluon/pulls/1558","html_url":"https://github.com/freifunk-gluon/gluon/pull/1558","diff_url":"https://github.com/freifunk-gluon/gluon/pull/1558.diff","patch_url":"https://github.com/freifunk-gluon/gluon/pull/1558.patch"},"body":"Proposed changes allows me to have have custom `patches` and `targets` in the site repository. As a bonus, it removes bunch of hardcoded paths, making the build system more flexible. I'm wondering if such changes would be accepted.\r\n\r\n```\r\n$ cat site/site.mk\r\n...\r\nGLUON_PATCHESDIR ?= $(GLUON_SITEDIR)/patches\r\nGLUON_TARGETSDIR ?= $(GLUON_SITEDIR)/targets\r\n...\r\n```"},"comment":{"url":"https://api.github.com/repos/freifunk-gluon/gluon/issues/comments/437792666","html_url":"https://github.com/freifunk-gluon/gluon/pull/1558#issuecomment-437792666","issue_url":"https://api.github.com/repos/freifunk-gluon/gluon/issues/1558","id":437792666,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzc5MjY2Ng==","user":{"login":"ynezz","id":43848,"node_id":"MDQ6VXNlcjQzODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/43848?v=4","gravatar_id":"","url":"https://api.github.com/users/ynezz","html_url":"https://github.com/ynezz","followers_url":"https://api.github.com/users/ynezz/followers","following_url":"https://api.github.com/users/ynezz/following{/other_user}","gists_url":"https://api.github.com/users/ynezz/gists{/gist_id}","starred_url":"https://api.github.com/users/ynezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynezz/subscriptions","organizations_url":"https://api.github.com/users/ynezz/orgs","repos_url":"https://api.github.com/users/ynezz/repos","events_url":"https://api.github.com/users/ynezz/events{/privacy}","received_events_url":"https://api.github.com/users/ynezz/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T08:15:47Z","updated_at":"2018-11-12T08:15:47Z","author_association":"NONE","body":"> Easy enough, fork gluon, merge your patch, build away. Then remember to rebase early and often.\r\n\r\nThose are exactly the steps I would like to avoid. With this small patchset I could just use upstream Gluon, with custom `site` repository where I've all the custom bits."}}
{"actor":{"display_login":"ynezz"}}