{"action":"created","issue":{"url":"https://api.github.com/repos/minio/minio/issues/5511","repository_url":"https://api.github.com/repos/minio/minio","labels_url":"https://api.github.com/repos/minio/minio/issues/5511/labels{/name}","comments_url":"https://api.github.com/repos/minio/minio/issues/5511/comments","events_url":"https://api.github.com/repos/minio/minio/issues/5511/events","html_url":"https://github.com/minio/minio/issues/5511","id":296142455,"number":5511,"title":"Server should fail if SSE-C headers are provided but backend does not support encryption","user":{"login":"aead","id":20368805,"avatar_url":"https://avatars0.githubusercontent.com/u/20368805?v=4","gravatar_id":"","url":"https://api.github.com/users/aead","html_url":"https://github.com/aead","followers_url":"https://api.github.com/users/aead/followers","following_url":"https://api.github.com/users/aead/following{/other_user}","gists_url":"https://api.github.com/users/aead/gists{/gist_id}","starred_url":"https://api.github.com/users/aead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aead/subscriptions","organizations_url":"https://api.github.com/users/aead/orgs","repos_url":"https://api.github.com/users/aead/repos","events_url":"https://api.github.com/users/aead/events{/privacy}","received_events_url":"https://api.github.com/users/aead/received_events","type":"User","site_admin":false},"labels":[{"id":574010253,"url":"https://api.github.com/repos/minio/minio/labels/priority:%20medium","name":"priority: medium","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"aead","id":20368805,"avatar_url":"https://avatars0.githubusercontent.com/u/20368805?v=4","gravatar_id":"","url":"https://api.github.com/users/aead","html_url":"https://github.com/aead","followers_url":"https://api.github.com/users/aead/followers","following_url":"https://api.github.com/users/aead/following{/other_user}","gists_url":"https://api.github.com/users/aead/gists{/gist_id}","starred_url":"https://api.github.com/users/aead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aead/subscriptions","organizations_url":"https://api.github.com/users/aead/orgs","repos_url":"https://api.github.com/users/aead/repos","events_url":"https://api.github.com/users/aead/events{/privacy}","received_events_url":"https://api.github.com/users/aead/received_events","type":"User","site_admin":false},"assignees":[{"login":"aead","id":20368805,"avatar_url":"https://avatars0.githubusercontent.com/u/20368805?v=4","gravatar_id":"","url":"https://api.github.com/users/aead","html_url":"https://github.com/aead","followers_url":"https://api.github.com/users/aead/followers","following_url":"https://api.github.com/users/aead/following{/other_user}","gists_url":"https://api.github.com/users/aead/gists{/gist_id}","starred_url":"https://api.github.com/users/aead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aead/subscriptions","organizations_url":"https://api.github.com/users/aead/orgs","repos_url":"https://api.github.com/users/aead/repos","events_url":"https://api.github.com/users/aead/events{/privacy}","received_events_url":"https://api.github.com/users/aead/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/minio/minio/milestones/14","html_url":"https://github.com/minio/minio/milestone/14","labels_url":"https://api.github.com/repos/minio/minio/milestones/14/labels","id":2426550,"number":14,"title":"Future","description":"This is like the backlog.  Its more near future than prototype milestone which is a long running milestone for exploratory work. \r\nWe pull items out of this milestone and include in ongoing releases.","creator":{"login":"deekoder","id":1700901,"avatar_url":"https://avatars1.githubusercontent.com/u/1700901?v=4","gravatar_id":"","url":"https://api.github.com/users/deekoder","html_url":"https://github.com/deekoder","followers_url":"https://api.github.com/users/deekoder/followers","following_url":"https://api.github.com/users/deekoder/following{/other_user}","gists_url":"https://api.github.com/users/deekoder/gists{/gist_id}","starred_url":"https://api.github.com/users/deekoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deekoder/subscriptions","organizations_url":"https://api.github.com/users/deekoder/orgs","repos_url":"https://api.github.com/users/deekoder/repos","events_url":"https://api.github.com/users/deekoder/events{/privacy}","received_events_url":"https://api.github.com/users/deekoder/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":90,"state":"open","created_at":"2017-04-01T00:22:30Z","updated_at":"2018-02-10T23:05:41Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"comments":4,"created_at":"2018-02-10T23:05:41Z","updated_at":"2018-02-11T10:51:00Z","closed_at":null,"author_association":"COLLABORATOR","body":"## Expected Behavior\r\nThe server should fail if the backend does not support encryption *but* SSE-C headers are provided.\r\n\r\n## Current Behavior\r\nThe server stores the object unencrypted.\r\n\r\n## Possible Solution\r\nAdd check in object handler layer (S3 -layer)\r\n\r\n## Steps to Reproduce (for bugs)\r\n1.  Disable encryption for e.g. FS backend.\r\n2. Build and start server (with TLS) on FS\r\n3.  `aws s3api put-object --no-verify-ssl --endpoint-url https://localhost:9000 --bucket my-bucket --key my-secret-diary --sse-customer-algorithm AES256 --sse-customer-key MzJieXRlc2xvbmdzZWNyZXRrZXltdXN0cHJvdmlkZWQ= --sse-customer-key-md5 7PpPLAK26ONlVUGOWlusfg== --body ~/my-diary.txt`\r\n\r\n## Context\r\nEncryption, SSE-C\r\n\r\n## Your Environment\r\nmaster"},"comment":{"url":"https://api.github.com/repos/minio/minio/issues/comments/364742105","html_url":"https://github.com/minio/minio/issues/5511#issuecomment-364742105","issue_url":"https://api.github.com/repos/minio/minio/issues/5511","id":364742105,"user":{"login":"aead","id":20368805,"avatar_url":"https://avatars0.githubusercontent.com/u/20368805?v=4","gravatar_id":"","url":"https://api.github.com/users/aead","html_url":"https://github.com/aead","followers_url":"https://api.github.com/users/aead/followers","following_url":"https://api.github.com/users/aead/following{/other_user}","gists_url":"https://api.github.com/users/aead/gists{/gist_id}","starred_url":"https://api.github.com/users/aead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aead/subscriptions","organizations_url":"https://api.github.com/users/aead/orgs","repos_url":"https://api.github.com/users/aead/repos","events_url":"https://api.github.com/users/aead/events{/privacy}","received_events_url":"https://api.github.com/users/aead/received_events","type":"User","site_admin":false},"created_at":"2018-02-11T10:51:00Z","updated_at":"2018-02-11T10:51:00Z","author_association":"COLLABORATOR","body":"@harshavardhana What I'm saying is that if we add a backend implementation that does not support encryption (currently there is none) we will trigger this issue. The current code relies on the fact that there is no backend which does not support encryption. So I'm suggesting to add a check since the current code contains a (hidden) bug.\r\nOn Gateway we don't do SSE-C at right now as fas as I know... (haven't checked...)  "}}
{"actor":{"display_login":"aead"}}