{"action":"created","issue":{"url":"https://api.github.com/repos/moby/buildkit/issues/323","repository_url":"https://api.github.com/repos/moby/buildkit","labels_url":"https://api.github.com/repos/moby/buildkit/issues/323/labels{/name}","comments_url":"https://api.github.com/repos/moby/buildkit/issues/323/comments","events_url":"https://api.github.com/repos/moby/buildkit/issues/323/events","html_url":"https://github.com/moby/buildkit/pull/323","id":308528599,"number":323,"title":"Validation and (controlled) generation for go generate'd files.","user":{"login":"ijc","id":12985729,"avatar_url":"https://avatars0.githubusercontent.com/u/12985729?v=4","gravatar_id":"","url":"https://api.github.com/users/ijc","html_url":"https://github.com/ijc","followers_url":"https://api.github.com/users/ijc/followers","following_url":"https://api.github.com/users/ijc/following{/other_user}","gists_url":"https://api.github.com/users/ijc/gists{/gist_id}","starred_url":"https://api.github.com/users/ijc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijc/subscriptions","organizations_url":"https://api.github.com/users/ijc/orgs","repos_url":"https://api.github.com/users/ijc/repos","events_url":"https://api.github.com/users/ijc/events{/privacy}","received_events_url":"https://api.github.com/users/ijc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-26T11:11:05Z","updated_at":"2018-03-27T17:02:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/moby/buildkit/pulls/323","html_url":"https://github.com/moby/buildkit/pull/323","diff_url":"https://github.com/moby/buildkit/pull/323.diff","patch_url":"https://github.com/moby/buildkit/pull/323.patch"},"body":"Modelled after the vendor support provide a validator and an updator for files\r\nproduced by `go generate` (which today just means `*.pb.go`).\r\n\r\nMain difference from the vendor support is that we are no longer simply nuking\r\nand replacing a single directory, so I ended up hardcoding `*.pb.go` in a bunch\r\nof places which I don't like but cannot see a way around which doesn't risk\r\nnuking people's other local changes.\r\n\r\nThe run in `frontend/gateway/pb/generate.go` was missing an include so fix\r\nthat.\r\n\r\nThe versions of `protoc` and the gogo plugins were chosen to regenerate the\r\nexisting code as closely as possible. The updates to `*.pg.go` here are all the\r\nresult of regenerating with go1.9 which fixed\r\nhttps://github.com/golang/go/issues/17663 and replaced an invalid timestamp in\r\nthe gzip header of the data encoded in `fileDescriptor*`, and adopted a new\r\nstandard for marking generated files.\r\n\r\nCloses: #322\r\n\r\nSigned-off-by: Ian Campbell <ijc@docker.com>"},"comment":{"url":"https://api.github.com/repos/moby/buildkit/issues/comments/376599967","html_url":"https://github.com/moby/buildkit/pull/323#issuecomment-376599967","issue_url":"https://api.github.com/repos/moby/buildkit/issues/323","id":376599967,"user":{"login":"ijc","id":12985729,"avatar_url":"https://avatars0.githubusercontent.com/u/12985729?v=4","gravatar_id":"","url":"https://api.github.com/users/ijc","html_url":"https://github.com/ijc","followers_url":"https://api.github.com/users/ijc/followers","following_url":"https://api.github.com/users/ijc/following{/other_user}","gists_url":"https://api.github.com/users/ijc/gists{/gist_id}","starred_url":"https://api.github.com/users/ijc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijc/subscriptions","organizations_url":"https://api.github.com/users/ijc/orgs","repos_url":"https://api.github.com/users/ijc/repos","events_url":"https://api.github.com/users/ijc/events{/privacy}","received_events_url":"https://api.github.com/users/ijc/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T17:02:14Z","updated_at":"2018-03-27T17:02:14Z","author_association":"CONTRIBUTOR","body":"I've made most changes apart from the https://github.com/moby/buildkit/pull/323#discussion_r177493049 one (move the `git status` into the `Dockerfile`) due to https://github.com/moby/buildkit/pull/323#discussion_r177498476 (the resulting output is pretty ugly) and squashed."}}
{"actor":{"display_login":"ijc"}}