{"action":"closed","number":359,"pull_request":{"url":"https://api.github.com/repos/paypal/downshift/pulls/359","id":173021108,"html_url":"https://github.com/paypal/downshift/pull/359","diff_url":"https://github.com/paypal/downshift/pull/359.diff","patch_url":"https://github.com/paypal/downshift/pull/359.patch","issue_url":"https://api.github.com/repos/paypal/downshift/issues/359","number":359,"state":"closed","locked":false,"title":"[Typescript] Fix return type for itemToString under Actions interface","user":{"login":"franklixuefei","id":1334982,"avatar_url":"https://avatars1.githubusercontent.com/u/1334982?v=4","gravatar_id":"","url":"https://api.github.com/users/franklixuefei","html_url":"https://github.com/franklixuefei","followers_url":"https://api.github.com/users/franklixuefei/followers","following_url":"https://api.github.com/users/franklixuefei/following{/other_user}","gists_url":"https://api.github.com/users/franklixuefei/gists{/gist_id}","starred_url":"https://api.github.com/users/franklixuefei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franklixuefei/subscriptions","organizations_url":"https://api.github.com/users/franklixuefei/orgs","repos_url":"https://api.github.com/users/franklixuefei/repos","events_url":"https://api.github.com/users/franklixuefei/events{/privacy}","received_events_url":"https://api.github.com/users/franklixuefei/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for your interest in the project. Bugs filed and PRs submitted are appreciated!\r\n\r\nPlease make sure that you are familiar with and follow the Code of Conduct for\r\nthis project (found in the CODE_OF_CONDUCT.md file).\r\n\r\nAlso, please make sure you're familiar with and follow the instructions in the\r\ncontributing guidelines (found in the CONTRIBUTING.md file).\r\n\r\nIf you're new to contributing to open source projects, you might find this free\r\nvideo course helpful: http://kcd.im/pull-request\r\n\r\nPlease fill out the information below to expedite the review and (hopefully)\r\nmerge of your pull request!\r\n-->\r\n\r\n<!-- What changes are being made? (What feature/bug is being fixed here?) -->\r\n\r\n**What**:\r\n[Typescript] Fixed the return type for itemToString under Actions interface\r\n<!-- Why are these changes necessary? -->\r\n\r\n**Why**:\r\nTypes for itemToString() between DownshiftProps and Actions are not consistent.\r\n<!-- How were these changes implemented? -->\r\n\r\n**How**:\r\nChanged the return type from `void` to `string`\r\n<!-- Have you done all of these things?  -->\r\n\r\n**Checklist**:\r\n\r\n<!-- add \"N/A\" to the end of each line that's irrelevant to your changes -->\r\n\r\n<!-- to check an item, place an \"x\" in the box like so: \"- [x] Documentation\" -->\r\n\r\n* [ ] Documentation\r\n* [ ] Tests\r\n* [ ] Ready to be merged\r\n      <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->\r\n* [ ] Added myself to contributors table\r\n      <!-- this is optional, see the contributing guidelines for instructions -->\r\n\r\n<!-- feel free to add additional comments -->\r\n","created_at":"2018-03-05T23:54:03Z","updated_at":"2018-03-06T00:02:51Z","closed_at":"2018-03-06T00:02:50Z","merged_at":"2018-03-06T00:02:50Z","merge_commit_sha":"1a80733298d78f84fc473f825e21706551e5813e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paypal/downshift/pulls/359/commits","review_comments_url":"https://api.github.com/repos/paypal/downshift/pulls/359/comments","review_comment_url":"https://api.github.com/repos/paypal/downshift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paypal/downshift/issues/359/comments","statuses_url":"https://api.github.com/repos/paypal/downshift/statuses/570eb23674d8231bb5026ac1c1020143467f0953","head":{"label":"franklixuefei:franklixuefei/typescript","ref":"franklixuefei/typescript","sha":"570eb23674d8231bb5026ac1c1020143467f0953","user":{"login":"franklixuefei","id":1334982,"avatar_url":"https://avatars1.githubusercontent.com/u/1334982?v=4","gravatar_id":"","url":"https://api.github.com/users/franklixuefei","html_url":"https://github.com/franklixuefei","followers_url":"https://api.github.com/users/franklixuefei/followers","following_url":"https://api.github.com/users/franklixuefei/following{/other_user}","gists_url":"https://api.github.com/users/franklixuefei/gists{/gist_id}","starred_url":"https://api.github.com/users/franklixuefei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franklixuefei/subscriptions","organizations_url":"https://api.github.com/users/franklixuefei/orgs","repos_url":"https://api.github.com/users/franklixuefei/repos","events_url":"https://api.github.com/users/franklixuefei/events{/privacy}","received_events_url":"https://api.github.com/users/franklixuefei/received_events","type":"User","site_admin":false},"repo":{"id":123904158,"name":"downshift","full_name":"franklixuefei/downshift","owner":{"login":"franklixuefei","id":1334982,"avatar_url":"https://avatars1.githubusercontent.com/u/1334982?v=4","gravatar_id":"","url":"https://api.github.com/users/franklixuefei","html_url":"https://github.com/franklixuefei","followers_url":"https://api.github.com/users/franklixuefei/followers","following_url":"https://api.github.com/users/franklixuefei/following{/other_user}","gists_url":"https://api.github.com/users/franklixuefei/gists{/gist_id}","starred_url":"https://api.github.com/users/franklixuefei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franklixuefei/subscriptions","organizations_url":"https://api.github.com/users/franklixuefei/orgs","repos_url":"https://api.github.com/users/franklixuefei/repos","events_url":"https://api.github.com/users/franklixuefei/events{/privacy}","received_events_url":"https://api.github.com/users/franklixuefei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/franklixuefei/downshift","description":"🏎 Primitives to build simple, flexible, WAI-ARIA compliant enhanced input React components","fork":true,"url":"https://api.github.com/repos/franklixuefei/downshift","forks_url":"https://api.github.com/repos/franklixuefei/downshift/forks","keys_url":"https://api.github.com/repos/franklixuefei/downshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/franklixuefei/downshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/franklixuefei/downshift/teams","hooks_url":"https://api.github.com/repos/franklixuefei/downshift/hooks","issue_events_url":"https://api.github.com/repos/franklixuefei/downshift/issues/events{/number}","events_url":"https://api.github.com/repos/franklixuefei/downshift/events","assignees_url":"https://api.github.com/repos/franklixuefei/downshift/assignees{/user}","branches_url":"https://api.github.com/repos/franklixuefei/downshift/branches{/branch}","tags_url":"https://api.github.com/repos/franklixuefei/downshift/tags","blobs_url":"https://api.github.com/repos/franklixuefei/downshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/franklixuefei/downshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/franklixuefei/downshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/franklixuefei/downshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/franklixuefei/downshift/statuses/{sha}","languages_url":"https://api.github.com/repos/franklixuefei/downshift/languages","stargazers_url":"https://api.github.com/repos/franklixuefei/downshift/stargazers","contributors_url":"https://api.github.com/repos/franklixuefei/downshift/contributors","subscribers_url":"https://api.github.com/repos/franklixuefei/downshift/subscribers","subscription_url":"https://api.github.com/repos/franklixuefei/downshift/subscription","commits_url":"https://api.github.com/repos/franklixuefei/downshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/franklixuefei/downshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/franklixuefei/downshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/franklixuefei/downshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/franklixuefei/downshift/contents/{+path}","compare_url":"https://api.github.com/repos/franklixuefei/downshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/franklixuefei/downshift/merges","archive_url":"https://api.github.com/repos/franklixuefei/downshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/franklixuefei/downshift/downloads","issues_url":"https://api.github.com/repos/franklixuefei/downshift/issues{/number}","pulls_url":"https://api.github.com/repos/franklixuefei/downshift/pulls{/number}","milestones_url":"https://api.github.com/repos/franklixuefei/downshift/milestones{/number}","notifications_url":"https://api.github.com/repos/franklixuefei/downshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/franklixuefei/downshift/labels{/name}","releases_url":"https://api.github.com/repos/franklixuefei/downshift/releases{/id}","deployments_url":"https://api.github.com/repos/franklixuefei/downshift/deployments","created_at":"2018-03-05T10:34:22Z","updated_at":"2018-03-05T10:34:24Z","pushed_at":"2018-03-05T23:52:43Z","git_url":"git://github.com/franklixuefei/downshift.git","ssh_url":"git@github.com:franklixuefei/downshift.git","clone_url":"https://github.com/franklixuefei/downshift.git","svn_url":"https://github.com/franklixuefei/downshift","homepage":"http://downshift.netlify.com/","size":603,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"paypal:master","ref":"master","sha":"ba1b4394c84eb48811807906c8c794eeb06ba45a","user":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"repo":{"id":98315735,"name":"downshift","full_name":"paypal/downshift","owner":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paypal/downshift","description":"🏎 Primitives to build simple, flexible, WAI-ARIA compliant enhanced input React components","fork":false,"url":"https://api.github.com/repos/paypal/downshift","forks_url":"https://api.github.com/repos/paypal/downshift/forks","keys_url":"https://api.github.com/repos/paypal/downshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paypal/downshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paypal/downshift/teams","hooks_url":"https://api.github.com/repos/paypal/downshift/hooks","issue_events_url":"https://api.github.com/repos/paypal/downshift/issues/events{/number}","events_url":"https://api.github.com/repos/paypal/downshift/events","assignees_url":"https://api.github.com/repos/paypal/downshift/assignees{/user}","branches_url":"https://api.github.com/repos/paypal/downshift/branches{/branch}","tags_url":"https://api.github.com/repos/paypal/downshift/tags","blobs_url":"https://api.github.com/repos/paypal/downshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paypal/downshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paypal/downshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/paypal/downshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paypal/downshift/statuses/{sha}","languages_url":"https://api.github.com/repos/paypal/downshift/languages","stargazers_url":"https://api.github.com/repos/paypal/downshift/stargazers","contributors_url":"https://api.github.com/repos/paypal/downshift/contributors","subscribers_url":"https://api.github.com/repos/paypal/downshift/subscribers","subscription_url":"https://api.github.com/repos/paypal/downshift/subscription","commits_url":"https://api.github.com/repos/paypal/downshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/paypal/downshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/paypal/downshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/paypal/downshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/paypal/downshift/contents/{+path}","compare_url":"https://api.github.com/repos/paypal/downshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paypal/downshift/merges","archive_url":"https://api.github.com/repos/paypal/downshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paypal/downshift/downloads","issues_url":"https://api.github.com/repos/paypal/downshift/issues{/number}","pulls_url":"https://api.github.com/repos/paypal/downshift/pulls{/number}","milestones_url":"https://api.github.com/repos/paypal/downshift/milestones{/number}","notifications_url":"https://api.github.com/repos/paypal/downshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paypal/downshift/labels{/name}","releases_url":"https://api.github.com/repos/paypal/downshift/releases{/id}","deployments_url":"https://api.github.com/repos/paypal/downshift/deployments","created_at":"2017-07-25T14:31:42Z","updated_at":"2018-03-05T23:01:45Z","pushed_at":"2018-03-06T00:02:50Z","git_url":"git://github.com/paypal/downshift.git","ssh_url":"git@github.com:paypal/downshift.git","clone_url":"https://github.com/paypal/downshift.git","svn_url":"https://github.com/paypal/downshift","homepage":"http://downshift.netlify.com/","size":623,"stargazers_count":3538,"watchers_count":3538,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":217,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":217,"open_issues":14,"watchers":3538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paypal/downshift/pulls/359"},"html":{"href":"https://github.com/paypal/downshift/pull/359"},"issue":{"href":"https://api.github.com/repos/paypal/downshift/issues/359"},"comments":{"href":"https://api.github.com/repos/paypal/downshift/issues/359/comments"},"review_comments":{"href":"https://api.github.com/repos/paypal/downshift/pulls/359/comments"},"review_comment":{"href":"https://api.github.com/repos/paypal/downshift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paypal/downshift/pulls/359/commits"},"statuses":{"href":"https://api.github.com/repos/paypal/downshift/statuses/570eb23674d8231bb5026ac1c1020143467f0953"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kentcdodds","id":1500684,"avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"kentcdodds"}}