{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/200836934","pull_request_review_id":135229384,"id":200836934,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDgzNjkzNA==","diff_hunk":"@@ -680,7 +702,77 @@ public Long getCountOfPatients(String query, boolean includeVoided) {\n     private List<Patient> findPatients(String query, boolean includeVoided) {\n \t\treturn findPatients(query, includeVoided, null, null);\n \t}\n-\n+\t\n+\tprivate List<Patient> findPatients(String query, List<PatientIdentifierType> identifierTypes, boolean matchExactly, Integer start, Integer length) {","path":"api/src/main/java/org/openmrs/api/db/hibernate/HibernatePatientDAO.java","position":44,"original_position":44,"commit_id":"111336af094ac62074080e5d68bb20aa50c0ef1a","original_commit_id":"111336af094ac62074080e5d68bb20aa50c0ef1a","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused method parameters such as 'matchExactly'.](https://app.codacy.com/app/openmrs/openmrs-core/pullRequest?prid=1874633)","created_at":"2018-07-08T11:04:29Z","updated_at":"2018-07-08T11:04:29Z","html_url":"https://github.com/openmrs/openmrs-core/pull/2688#discussion_r200836934","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2688","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/200836934"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/2688#discussion_r200836934"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2688"}}},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2688","id":199935669,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTM1NjY5","html_url":"https://github.com/openmrs/openmrs-core/pull/2688","diff_url":"https://github.com/openmrs/openmrs-core/pull/2688.diff","patch_url":"https://github.com/openmrs/openmrs-core/pull/2688.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2688","number":2688,"state":"open","locked":false,"title":"Trunk 5395","user":{"login":"fruether","id":1591040,"node_id":"MDQ6VXNlcjE1OTEwNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1591040?v=4","gravatar_id":"","url":"https://api.github.com/users/fruether","html_url":"https://github.com/fruether","followers_url":"https://api.github.com/users/fruether/followers","following_url":"https://api.github.com/users/fruether/following{/other_user}","gists_url":"https://api.github.com/users/fruether/gists{/gist_id}","starred_url":"https://api.github.com/users/fruether/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fruether/subscriptions","organizations_url":"https://api.github.com/users/fruether/orgs","repos_url":"https://api.github.com/users/fruether/repos","events_url":"https://api.github.com/users/fruether/events{/privacy}","received_events_url":"https://api.github.com/users/fruether/received_events","type":"User","site_admin":false},"body":"<!--- Add a pull request title above in this format -->\r\n<!--- real example: 'TRUNK-5395 Replace use of deprecated isVoided' -->\r\n<!--- 'TRUNK-5395 PatientService getPatients(name, identifier, types, matchIdentifierExactly) does not restrict by identifierType' -->\r\n## Description of what I changed\r\n<!--- (1) Set the test \"shouldGetPatientsByIdentifierAndIdentifierType\" live   -->\r\n<!--- (2)  Added into HibernatePatientDAO the method findPatients(String query, List<PatientIdentifierType> identifierTypes,.....)\"-->\r\n<!--- (3) Refactored a bit of code of the methods getPatientIdentifierLuceneQuery   -->\r\n<!--- (4) Some merges seem to be added -->\r\n<!--- It can simply be your commit message, which you must have -->\r\n\r\n\r\n## Issue I worked on\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- Want a new feature or change? Discuss it in an issue first -->\r\n<!--- Found a bug? Point us to the issue/or create one so we can reproduce it -->\r\n<!--- Just add the issue number at the end: -->\r\nsee https://issues.openmrs.org/browse/TRUNK-5395\r\n\r\n## Checklist: I completed these to help reviewers :)\r\n<!--- Put an `x` in the box if you did the task -->\r\n<!--- If you forgot a task please follow the instructions below -->\r\n- [ ] My pull request only contains **ONE single commit**\r\n(the number above, next to the 'Commits' tab is 1).\r\n\r\n  No? -> [read here](https://wiki.openmrs.org/display/docs/Pull+Request+Tips) on how to squash multiple commits into one\r\n\r\n- [ ] My IDE is configured to follow the [**code style**](https://wiki.openmrs.org/display/docs/Java+Conventions) of this project.\r\n\r\n  No? Unsure? -> [configure your IDE](https://wiki.openmrs.org/display/docs/How-To+Setup+And+Use+Your+IDE), format the code and add the changes with `git add . && git commit --amend`\r\n\r\n- [ ] I have **added tests** to cover my changes. (If you refactored\r\n  existing code that was well tested you do not have to add tests)\r\n\r\n  No? -> write tests and add them to this commit `git add . && git commit --amend`\r\n\r\n- [ ] I ran `mvn clean package` right before creating this pull request and\r\n  added all formatting changes to my commit.\r\n\r\n  No? -> execute above command\r\n\r\n- [ ] All new and existing **tests passed**.\r\n\r\n  No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.\r\n\r\n- [ ] My pull request is **based on the latest changes** of the master branch.\r\n\r\n  No? Unsure? -> execute command `git pull --rebase upstream master`\r\n\r\n","created_at":"2018-07-08T10:35:11Z","updated_at":"2018-07-08T11:04:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb3e4fc1ca7d5981115670646a8f9fefefd53e43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2688/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2688/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2688/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/111336af094ac62074080e5d68bb20aa50c0ef1a","head":{"label":"fruether:TRUNK-5395","ref":"TRUNK-5395","sha":"111336af094ac62074080e5d68bb20aa50c0ef1a","user":{"login":"fruether","id":1591040,"node_id":"MDQ6VXNlcjE1OTEwNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1591040?v=4","gravatar_id":"","url":"https://api.github.com/users/fruether","html_url":"https://github.com/fruether","followers_url":"https://api.github.com/users/fruether/followers","following_url":"https://api.github.com/users/fruether/following{/other_user}","gists_url":"https://api.github.com/users/fruether/gists{/gist_id}","starred_url":"https://api.github.com/users/fruether/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fruether/subscriptions","organizations_url":"https://api.github.com/users/fruether/orgs","repos_url":"https://api.github.com/users/fruether/repos","events_url":"https://api.github.com/users/fruether/events{/privacy}","received_events_url":"https://api.github.com/users/fruether/received_events","type":"User","site_admin":false},"repo":{"id":86981076,"node_id":"MDEwOlJlcG9zaXRvcnk4Njk4MTA3Ng==","name":"openmrs-core","full_name":"fruether/openmrs-core","owner":{"login":"fruether","id":1591040,"node_id":"MDQ6VXNlcjE1OTEwNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1591040?v=4","gravatar_id":"","url":"https://api.github.com/users/fruether","html_url":"https://github.com/fruether","followers_url":"https://api.github.com/users/fruether/followers","following_url":"https://api.github.com/users/fruether/following{/other_user}","gists_url":"https://api.github.com/users/fruether/gists{/gist_id}","starred_url":"https://api.github.com/users/fruether/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fruether/subscriptions","organizations_url":"https://api.github.com/users/fruether/orgs","repos_url":"https://api.github.com/users/fruether/repos","events_url":"https://api.github.com/users/fruether/events{/privacy}","received_events_url":"https://api.github.com/users/fruether/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fruether/openmrs-core","description":"OpenMRS API and web application code","fork":true,"url":"https://api.github.com/repos/fruether/openmrs-core","forks_url":"https://api.github.com/repos/fruether/openmrs-core/forks","keys_url":"https://api.github.com/repos/fruether/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fruether/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fruether/openmrs-core/teams","hooks_url":"https://api.github.com/repos/fruether/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/fruether/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/fruether/openmrs-core/events","assignees_url":"https://api.github.com/repos/fruether/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/fruether/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/fruether/openmrs-core/tags","blobs_url":"https://api.github.com/repos/fruether/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fruether/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fruether/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/fruether/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fruether/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/fruether/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/fruether/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/fruether/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/fruether/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/fruether/openmrs-core/subscription","commits_url":"https://api.github.com/repos/fruether/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/fruether/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/fruether/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/fruether/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/fruether/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/fruether/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fruether/openmrs-core/merges","archive_url":"https://api.github.com/repos/fruether/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fruether/openmrs-core/downloads","issues_url":"https://api.github.com/repos/fruether/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/fruether/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/fruether/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/fruether/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fruether/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/fruether/openmrs-core/releases{/id}","deployments_url":"https://api.github.com/repos/fruether/openmrs-core/deployments","created_at":"2017-04-02T11:11:56Z","updated_at":"2018-05-21T13:55:37Z","pushed_at":"2018-07-08T11:01:35Z","git_url":"git://github.com/fruether/openmrs-core.git","ssh_url":"git@github.com:fruether/openmrs-core.git","clone_url":"https://github.com/fruether/openmrs-core.git","svn_url":"https://github.com/fruether/openmrs-core","homepage":"http://openmrs.org","size":227475,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"4a0feb8da351088f25fdc4e6d324a1f277aa3410","user":{"login":"openmrs","id":860776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MDc3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":5187976,"node_id":"MDEwOlJlcG9zaXRvcnk1MTg3OTc2","name":"openmrs-core","full_name":"openmrs/openmrs-core","owner":{"login":"openmrs","id":860776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MDc3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-core","description":"OpenMRS API and web application code","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-core","forks_url":"https://api.github.com/repos/openmrs/openmrs-core/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-core/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-core/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-core/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-core/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-core/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-core/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-core/releases{/id}","deployments_url":"https://api.github.com/repos/openmrs/openmrs-core/deployments","created_at":"2012-07-26T04:54:29Z","updated_at":"2018-07-06T13:34:09Z","pushed_at":"2018-07-08T11:01:37Z","git_url":"git://github.com/openmrs/openmrs-core.git","ssh_url":"git@github.com:openmrs/openmrs-core.git","clone_url":"https://github.com/openmrs/openmrs-core.git","svn_url":"https://github.com/openmrs/openmrs-core","homepage":"http://openmrs.org","size":227818,"stargazers_count":661,"watchers_count":661,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2132,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2132,"open_issues":25,"watchers":661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2688"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/2688"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/2688"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/2688/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2688/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2688/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-core/statuses/111336af094ac62074080e5d68bb20aa50c0ef1a"}},"author_association":"NONE"}}
{"actor":{"display_login":"codacy-bot"}}