{"action":"opened","number":6309,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-security/pulls/6309","id":239733832,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NzMzODMy","html_url":"https://github.com/spring-projects/spring-security/pull/6309","diff_url":"https://github.com/spring-projects/spring-security/pull/6309.diff","patch_url":"https://github.com/spring-projects/spring-security/pull/6309.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-security/issues/6309","number":6309,"state":"open","locked":false,"title":"JdbcUserDetailsManager handles extra UserDetails attributes","user":{"login":"pvliss","id":2188969,"node_id":"MDQ6VXNlcjIxODg5Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/2188969?v=4","gravatar_id":"","url":"https://api.github.com/users/pvliss","html_url":"https://github.com/pvliss","followers_url":"https://api.github.com/users/pvliss/followers","following_url":"https://api.github.com/users/pvliss/following{/other_user}","gists_url":"https://api.github.com/users/pvliss/gists{/gist_id}","starred_url":"https://api.github.com/users/pvliss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvliss/subscriptions","organizations_url":"https://api.github.com/users/pvliss/orgs","repos_url":"https://api.github.com/users/pvliss/repos","events_url":"https://api.github.com/users/pvliss/events{/privacy}","received_events_url":"https://api.github.com/users/pvliss/received_events","type":"User","site_admin":false},"body":"Check `ResutSetMetaData` to see if extra columns are present in order to also handle the `UserDetails` attributes: `accountNonExpired`, `accountNonLocked` and `credentialsNonExpired`.\r\n\r\n`JdbcUserDetailsManager` API Changes:\r\n- The following methods are now public:\r\n   - `insertUserAuthorities()`\r\n   - `deleteUserAuthorities()`\r\n- The following methods are now protected:\r\n   - `validateUserDetails()`\r\n   - `validateAuthorities()`\r\n\r\nFixes gh-4399\r\n\r\n<!--\r\nFor Security Vulnerabilities, please use https://pivotal.io/security#reporting\r\n-->\r\n\r\n<!--\r\nThanks for contributing to Spring Security. Please provide a brief description of your pull-request and reference any related issue numbers (prefix references with #).\r\n-->\r\n","created_at":"2018-12-19T07:15:46Z","updated_at":"2018-12-19T07:15:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-security/pulls/6309/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-security/pulls/6309/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-security/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-security/issues/6309/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-security/statuses/40e50ff0d93b2c1ae163523f87b5778667147c2b","head":{"label":"pvliss:gh-4399","ref":"gh-4399","sha":"40e50ff0d93b2c1ae163523f87b5778667147c2b","user":{"login":"pvliss","id":2188969,"node_id":"MDQ6VXNlcjIxODg5Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/2188969?v=4","gravatar_id":"","url":"https://api.github.com/users/pvliss","html_url":"https://github.com/pvliss","followers_url":"https://api.github.com/users/pvliss/followers","following_url":"https://api.github.com/users/pvliss/following{/other_user}","gists_url":"https://api.github.com/users/pvliss/gists{/gist_id}","starred_url":"https://api.github.com/users/pvliss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvliss/subscriptions","organizations_url":"https://api.github.com/users/pvliss/orgs","repos_url":"https://api.github.com/users/pvliss/repos","events_url":"https://api.github.com/users/pvliss/events{/privacy}","received_events_url":"https://api.github.com/users/pvliss/received_events","type":"User","site_admin":false},"repo":{"id":160624929,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA2MjQ5Mjk=","name":"spring-security","full_name":"pvliss/spring-security","private":false,"owner":{"login":"pvliss","id":2188969,"node_id":"MDQ6VXNlcjIxODg5Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/2188969?v=4","gravatar_id":"","url":"https://api.github.com/users/pvliss","html_url":"https://github.com/pvliss","followers_url":"https://api.github.com/users/pvliss/followers","following_url":"https://api.github.com/users/pvliss/following{/other_user}","gists_url":"https://api.github.com/users/pvliss/gists{/gist_id}","starred_url":"https://api.github.com/users/pvliss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvliss/subscriptions","organizations_url":"https://api.github.com/users/pvliss/orgs","repos_url":"https://api.github.com/users/pvliss/repos","events_url":"https://api.github.com/users/pvliss/events{/privacy}","received_events_url":"https://api.github.com/users/pvliss/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pvliss/spring-security","description":"Spring Security","fork":true,"url":"https://api.github.com/repos/pvliss/spring-security","forks_url":"https://api.github.com/repos/pvliss/spring-security/forks","keys_url":"https://api.github.com/repos/pvliss/spring-security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvliss/spring-security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvliss/spring-security/teams","hooks_url":"https://api.github.com/repos/pvliss/spring-security/hooks","issue_events_url":"https://api.github.com/repos/pvliss/spring-security/issues/events{/number}","events_url":"https://api.github.com/repos/pvliss/spring-security/events","assignees_url":"https://api.github.com/repos/pvliss/spring-security/assignees{/user}","branches_url":"https://api.github.com/repos/pvliss/spring-security/branches{/branch}","tags_url":"https://api.github.com/repos/pvliss/spring-security/tags","blobs_url":"https://api.github.com/repos/pvliss/spring-security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvliss/spring-security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvliss/spring-security/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvliss/spring-security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvliss/spring-security/statuses/{sha}","languages_url":"https://api.github.com/repos/pvliss/spring-security/languages","stargazers_url":"https://api.github.com/repos/pvliss/spring-security/stargazers","contributors_url":"https://api.github.com/repos/pvliss/spring-security/contributors","subscribers_url":"https://api.github.com/repos/pvliss/spring-security/subscribers","subscription_url":"https://api.github.com/repos/pvliss/spring-security/subscription","commits_url":"https://api.github.com/repos/pvliss/spring-security/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvliss/spring-security/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvliss/spring-security/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvliss/spring-security/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvliss/spring-security/contents/{+path}","compare_url":"https://api.github.com/repos/pvliss/spring-security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvliss/spring-security/merges","archive_url":"https://api.github.com/repos/pvliss/spring-security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvliss/spring-security/downloads","issues_url":"https://api.github.com/repos/pvliss/spring-security/issues{/number}","pulls_url":"https://api.github.com/repos/pvliss/spring-security/pulls{/number}","milestones_url":"https://api.github.com/repos/pvliss/spring-security/milestones{/number}","notifications_url":"https://api.github.com/repos/pvliss/spring-security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvliss/spring-security/labels{/name}","releases_url":"https://api.github.com/repos/pvliss/spring-security/releases{/id}","deployments_url":"https://api.github.com/repos/pvliss/spring-security/deployments","created_at":"2018-12-06T05:43:44Z","updated_at":"2018-12-19T06:47:10Z","pushed_at":"2018-12-19T07:09:48Z","git_url":"git://github.com/pvliss/spring-security.git","ssh_url":"git@github.com:pvliss/spring-security.git","clone_url":"https://github.com/pvliss/spring-security.git","svn_url":"https://github.com/pvliss/spring-security","homepage":"http://spring.io/spring-security","size":33330,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"a919b4e916586db3629937cccd1c650673932da3","user":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":3148979,"node_id":"MDEwOlJlcG9zaXRvcnkzMTQ4OTc5","name":"spring-security","full_name":"spring-projects/spring-security","private":false,"owner":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spring-projects/spring-security","description":"Spring Security","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-security","forks_url":"https://api.github.com/repos/spring-projects/spring-security/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-security/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-security/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-security/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-security/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-security/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-security/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-security/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-security/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-security/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-security/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-security/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-security/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-security/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-security/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-security/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-security/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-security/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-security/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-security/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-security/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-security/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-security/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-security/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-security/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-security/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-security/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-security/deployments","created_at":"2012-01-10T21:50:57Z","updated_at":"2018-12-18T20:41:34Z","pushed_at":"2018-12-19T06:26:28Z","git_url":"git://github.com/spring-projects/spring-security.git","ssh_url":"git@github.com:spring-projects/spring-security.git","clone_url":"https://github.com/spring-projects/spring-security.git","svn_url":"https://github.com/spring-projects/spring-security","homepage":"http://spring.io/spring-security","size":33343,"stargazers_count":3041,"watchers_count":3041,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2814,"mirror_url":null,"archived":false,"open_issues_count":900,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2814,"open_issues":900,"watchers":3041,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/6309"},"html":{"href":"https://github.com/spring-projects/spring-security/pull/6309"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-security/issues/6309"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-security/issues/6309/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/6309/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/6309/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-security/statuses/40e50ff0d93b2c1ae163523f87b5778667147c2b"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":105,"deletions":9,"changed_files":3}}
{"actor":{"display_login":"pvliss"}}