{"action":"created","comment":{"url":"https://api.github.com/repos/apache/lucene-solr/pulls/comments/205121128","pull_request_review_id":140324727,"id":205121128,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTEyMTEyOA==","diff_hunk":"@@ -132,54 +126,49 @@ public void transform(SolrDocument rootDoc, int rootDocId) {\n             // load the doc\n             SolrDocument doc = DocsStreamer.convertLuceneDocToSolrDoc(docFetcher.doc(docId),\n                 schema, new SolrReturnFields());\n-            doc.setField(NEST_PATH_FIELD_NAME, fullDocPath);\n             if (shouldDecorateWithDVs) {\n               docFetcher.decorateDocValueFields(doc, docId, dvFieldsToReturn);\n             }\n             // get parent path\n             // put into pending\n             String parentDocPath = lookupParentPath(fullDocPath);\n-            pendingParentPathsToChildren.put(parentDocPath, doc); // multimap add (won't replace)\n \n-            // if this path has pending child docs, add them.\n-            if (isAncestor) {\n-              addChildrenToParent(doc, pendingParentPathsToChildren.get(fullDocPath));\n-              pendingParentPathsToChildren.removeAll(fullDocPath); // no longer pending\n+            if(isAncestor) {\n+              // if this path has pending child docs, add them.\n+              addChildrenToParent(doc, pendingParentPathsToChildren.remove(fullDocPath)); // no longer pending\n             }\n+            pendingParentPathsToChildren.computeIfAbsent(parentDocPath, x -> ArrayListMultimap.create())\n+                .put(trimIfSingleDoc(getLastPath(fullDocPath)), doc); // multimap add (won't replace)","path":"solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java","position":null,"original_position":62,"commit_id":"49cf74979a63e129e547be55a7d213c77219114d","original_commit_id":"49cf74979a63e129e547be55a7d213c77219114d","user":{"login":"dsmiley","id":377295,"node_id":"MDQ6VXNlcjM3NzI5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/377295?v=4","gravatar_id":"","url":"https://api.github.com/users/dsmiley","html_url":"https://github.com/dsmiley","followers_url":"https://api.github.com/users/dsmiley/followers","following_url":"https://api.github.com/users/dsmiley/following{/other_user}","gists_url":"https://api.github.com/users/dsmiley/gists{/gist_id}","starred_url":"https://api.github.com/users/dsmiley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsmiley/subscriptions","organizations_url":"https://api.github.com/users/dsmiley/orgs","repos_url":"https://api.github.com/users/dsmiley/repos","events_url":"https://api.github.com/users/dsmiley/events{/privacy}","received_events_url":"https://api.github.com/users/dsmiley/received_events","type":"User","site_admin":false},"body":"I believe we simply want the label here; maybe add a method getLeafLabel() that takes a path and returns the leaf label.  It would trim off any \"#\" with digits no matter if it's a single doc or not.","created_at":"2018-07-25T14:03:29Z","updated_at":"2018-07-25T14:07:15Z","html_url":"https://github.com/apache/lucene-solr/pull/416#discussion_r205121128","pull_request_url":"https://api.github.com/repos/apache/lucene-solr/pulls/416","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/comments/205121128"},"html":{"href":"https://github.com/apache/lucene-solr/pull/416#discussion_r205121128"},"pull_request":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/416"}}},"pull_request":{"url":"https://api.github.com/repos/apache/lucene-solr/pulls/416","id":200967677,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwOTY3Njc3","html_url":"https://github.com/apache/lucene-solr/pull/416","diff_url":"https://github.com/apache/lucene-solr/pull/416.diff","patch_url":"https://github.com/apache/lucene-solr/pull/416.patch","issue_url":"https://api.github.com/repos/apache/lucene-solr/issues/416","number":416,"state":"open","locked":false,"title":"WIP: SOLR-12519","user":{"login":"moshebla","id":38935306,"node_id":"MDQ6VXNlcjM4OTM1MzA2","avatar_url":"https://avatars3.githubusercontent.com/u/38935306?v=4","gravatar_id":"","url":"https://api.github.com/users/moshebla","html_url":"https://github.com/moshebla","followers_url":"https://api.github.com/users/moshebla/followers","following_url":"https://api.github.com/users/moshebla/following{/other_user}","gists_url":"https://api.github.com/users/moshebla/gists{/gist_id}","starred_url":"https://api.github.com/users/moshebla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moshebla/subscriptions","organizations_url":"https://api.github.com/users/moshebla/orgs","repos_url":"https://api.github.com/users/moshebla/repos","events_url":"https://api.github.com/users/moshebla/events{/privacy}","received_events_url":"https://api.github.com/users/moshebla/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-12T11:15:43Z","updated_at":"2018-07-25T14:07:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32dbf7b7a7d6113263f0b5389ad2069f34e95eda","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/lucene-solr/pulls/416/commits","review_comments_url":"https://api.github.com/repos/apache/lucene-solr/pulls/416/comments","review_comment_url":"https://api.github.com/repos/apache/lucene-solr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/lucene-solr/issues/416/comments","statuses_url":"https://api.github.com/repos/apache/lucene-solr/statuses/49cf74979a63e129e547be55a7d213c77219114d","head":{"label":"moshebla:SOLR-12519-3","ref":"SOLR-12519-3","sha":"49cf74979a63e129e547be55a7d213c77219114d","user":{"login":"moshebla","id":38935306,"node_id":"MDQ6VXNlcjM4OTM1MzA2","avatar_url":"https://avatars3.githubusercontent.com/u/38935306?v=4","gravatar_id":"","url":"https://api.github.com/users/moshebla","html_url":"https://github.com/moshebla","followers_url":"https://api.github.com/users/moshebla/followers","following_url":"https://api.github.com/users/moshebla/following{/other_user}","gists_url":"https://api.github.com/users/moshebla/gists{/gist_id}","starred_url":"https://api.github.com/users/moshebla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moshebla/subscriptions","organizations_url":"https://api.github.com/users/moshebla/orgs","repos_url":"https://api.github.com/users/moshebla/repos","events_url":"https://api.github.com/users/moshebla/events{/privacy}","received_events_url":"https://api.github.com/users/moshebla/received_events","type":"User","site_admin":false},"repo":{"id":131951586,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE5NTE1ODY=","name":"lucene-solr","full_name":"moshebla/lucene-solr","owner":{"login":"moshebla","id":38935306,"node_id":"MDQ6VXNlcjM4OTM1MzA2","avatar_url":"https://avatars3.githubusercontent.com/u/38935306?v=4","gravatar_id":"","url":"https://api.github.com/users/moshebla","html_url":"https://github.com/moshebla","followers_url":"https://api.github.com/users/moshebla/followers","following_url":"https://api.github.com/users/moshebla/following{/other_user}","gists_url":"https://api.github.com/users/moshebla/gists{/gist_id}","starred_url":"https://api.github.com/users/moshebla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moshebla/subscriptions","organizations_url":"https://api.github.com/users/moshebla/orgs","repos_url":"https://api.github.com/users/moshebla/repos","events_url":"https://api.github.com/users/moshebla/events{/privacy}","received_events_url":"https://api.github.com/users/moshebla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moshebla/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":true,"url":"https://api.github.com/repos/moshebla/lucene-solr","forks_url":"https://api.github.com/repos/moshebla/lucene-solr/forks","keys_url":"https://api.github.com/repos/moshebla/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moshebla/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moshebla/lucene-solr/teams","hooks_url":"https://api.github.com/repos/moshebla/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/moshebla/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/moshebla/lucene-solr/events","assignees_url":"https://api.github.com/repos/moshebla/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/moshebla/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/moshebla/lucene-solr/tags","blobs_url":"https://api.github.com/repos/moshebla/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moshebla/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moshebla/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/moshebla/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moshebla/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/moshebla/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/moshebla/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/moshebla/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/moshebla/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/moshebla/lucene-solr/subscription","commits_url":"https://api.github.com/repos/moshebla/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/moshebla/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/moshebla/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/moshebla/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/moshebla/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/moshebla/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moshebla/lucene-solr/merges","archive_url":"https://api.github.com/repos/moshebla/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moshebla/lucene-solr/downloads","issues_url":"https://api.github.com/repos/moshebla/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/moshebla/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/moshebla/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/moshebla/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moshebla/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/moshebla/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/moshebla/lucene-solr/deployments","created_at":"2018-05-03T06:30:25Z","updated_at":"2018-05-06T05:49:56Z","pushed_at":"2018-07-25T13:52:47Z","git_url":"git://github.com/moshebla/lucene-solr.git","ssh_url":"git@github.com:moshebla/lucene-solr.git","clone_url":"https://github.com/moshebla/lucene-solr.git","svn_url":"https://github.com/moshebla/lucene-solr","homepage":null,"size":356926,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d010cdd87eec89bf6308351b817d9ec1d5c6e14e","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50229487,"node_id":"MDEwOlJlcG9zaXRvcnk1MDIyOTQ4Nw==","name":"lucene-solr","full_name":"apache/lucene-solr","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":false,"url":"https://api.github.com/repos/apache/lucene-solr","forks_url":"https://api.github.com/repos/apache/lucene-solr/forks","keys_url":"https://api.github.com/repos/apache/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/lucene-solr/teams","hooks_url":"https://api.github.com/repos/apache/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/apache/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/lucene-solr/events","assignees_url":"https://api.github.com/repos/apache/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/lucene-solr/tags","blobs_url":"https://api.github.com/repos/apache/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/apache/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/apache/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/apache/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/apache/lucene-solr/subscription","commits_url":"https://api.github.com/repos/apache/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/lucene-solr/merges","archive_url":"https://api.github.com/repos/apache/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/lucene-solr/downloads","issues_url":"https://api.github.com/repos/apache/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/apache/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/apache/lucene-solr/deployments","created_at":"2016-01-23T08:00:06Z","updated_at":"2018-07-25T10:05:24Z","pushed_at":"2018-07-25T13:52:55Z","git_url":"git://github.com/apache/lucene-solr.git","ssh_url":"git@github.com:apache/lucene-solr.git","clone_url":"https://github.com/apache/lucene-solr.git","svn_url":"https://github.com/apache/lucene-solr","homepage":null,"size":367392,"stargazers_count":1818,"watchers_count":1818,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1450,"mirror_url":null,"archived":false,"open_issues_count":230,"license":null,"forks":1450,"open_issues":230,"watchers":1818,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/416"},"html":{"href":"https://github.com/apache/lucene-solr/pull/416"},"issue":{"href":"https://api.github.com/repos/apache/lucene-solr/issues/416"},"comments":{"href":"https://api.github.com/repos/apache/lucene-solr/issues/416/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/416/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/416/commits"},"statuses":{"href":"https://api.github.com/repos/apache/lucene-solr/statuses/49cf74979a63e129e547be55a7d213c77219114d"}},"author_association":"NONE"}}
{"actor":{"display_login":"dsmiley"}}