{"action":"created","issue":{"url":"https://api.github.com/repos/pimoroni/enviro-phat/issues/27","repository_url":"https://api.github.com/repos/pimoroni/enviro-phat","labels_url":"https://api.github.com/repos/pimoroni/enviro-phat/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/pimoroni/enviro-phat/issues/27/comments","events_url":"https://api.github.com/repos/pimoroni/enviro-phat/issues/27/events","html_url":"https://github.com/pimoroni/enviro-phat/issues/27","id":291688964,"number":27,"title":"QNH defined","user":{"login":"John-Matty","id":8416499,"avatar_url":"https://avatars2.githubusercontent.com/u/8416499?v=4","gravatar_id":"","url":"https://api.github.com/users/John-Matty","html_url":"https://github.com/John-Matty","followers_url":"https://api.github.com/users/John-Matty/followers","following_url":"https://api.github.com/users/John-Matty/following{/other_user}","gists_url":"https://api.github.com/users/John-Matty/gists{/gist_id}","starred_url":"https://api.github.com/users/John-Matty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/John-Matty/subscriptions","organizations_url":"https://api.github.com/users/John-Matty/orgs","repos_url":"https://api.github.com/users/John-Matty/repos","events_url":"https://api.github.com/users/John-Matty/events{/privacy}","received_events_url":"https://api.github.com/users/John-Matty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-01-25T19:33:40Z","updated_at":"2018-02-06T12:29:41Z","closed_at":null,"author_association":"NONE","body":"Am I missing something here - I am at a loss to understand why you have defined QNH as 1020 hPa when the ISO standard atmosphere has 1013.25 hPa as the average pressure at msl at 15 degrees C.\r\nSure you can provide the local QNH if known, but if you use the default 1020 hPa your altitude will be off by around 61.5 m or 202 feet. Explain please."},"comment":{"url":"https://api.github.com/repos/pimoroni/enviro-phat/issues/comments/363407947","html_url":"https://github.com/pimoroni/enviro-phat/issues/27#issuecomment-363407947","issue_url":"https://api.github.com/repos/pimoroni/enviro-phat/issues/27","id":363407947,"user":{"login":"Gadgetoid","id":1746967,"avatar_url":"https://avatars3.githubusercontent.com/u/1746967?v=4","gravatar_id":"","url":"https://api.github.com/users/Gadgetoid","html_url":"https://github.com/Gadgetoid","followers_url":"https://api.github.com/users/Gadgetoid/followers","following_url":"https://api.github.com/users/Gadgetoid/following{/other_user}","gists_url":"https://api.github.com/users/Gadgetoid/gists{/gist_id}","starred_url":"https://api.github.com/users/Gadgetoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gadgetoid/subscriptions","organizations_url":"https://api.github.com/users/Gadgetoid/orgs","repos_url":"https://api.github.com/users/Gadgetoid/repos","events_url":"https://api.github.com/users/Gadgetoid/events{/privacy}","received_events_url":"https://api.github.com/users/Gadgetoid/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T12:29:41Z","updated_at":"2018-02-06T12:29:41Z","author_association":"OWNER","body":"I can't recall where the 1020 value came from, I suspect it was the value for Sheffield, UK at time-of-writing.\r\n\r\nMy concern is that for anyone simply assuming altitude to \"just work\" and not supplying a regional QNH value, the ISO/ISA standard is still going to result in an incorrect local altitude.\r\n\r\nIt seems like the only sensible approach is to make QNH a *required* parameter, and store the standard value as something like \"ISO_SEA_LEVEL = 1013.25\" so the user has to make a conscious choice to supply their own, or use a standard value. This constitutes a breaking change to the API though, which is somewhat controversial and in a similar vein to: #25\r\n\r\nPerhaps if these two changes were batched into a version 1.0.0 (since the major version number tends to indicate significant/potentially breaking changes) we could better justify the shift.\r\n\r\n"}}
{"actor":{"display_login":"Gadgetoid"}}