{"action":"closed","number":106,"pull_request":{"url":"https://api.github.com/repos/cirope/mawidabp/pulls/106","id":223442982,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDQyOTgy","html_url":"https://github.com/cirope/mawidabp/pull/106","diff_url":"https://github.com/cirope/mawidabp/pull/106.diff","patch_url":"https://github.com/cirope/mawidabp/pull/106.patch","issue_url":"https://api.github.com/repos/cirope/mawidabp/issues/106","number":106,"state":"closed","locked":false,"title":"Fix for distinct findings ordered by readings","user":{"login":"Shelvak","id":873323,"node_id":"MDQ6VXNlcjg3MzMyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/873323?v=4","gravatar_id":"","url":"https://api.github.com/users/Shelvak","html_url":"https://github.com/Shelvak","followers_url":"https://api.github.com/users/Shelvak/followers","following_url":"https://api.github.com/users/Shelvak/following{/other_user}","gists_url":"https://api.github.com/users/Shelvak/gists{/gist_id}","starred_url":"https://api.github.com/users/Shelvak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shelvak/subscriptions","organizations_url":"https://api.github.com/users/Shelvak/orgs","repos_url":"https://api.github.com/users/Shelvak/repos","events_url":"https://api.github.com/users/Shelvak/events{/privacy}","received_events_url":"https://api.github.com/users/Shelvak/received_events","type":"User","site_admin":false},"body":"Tomamos \"otra\" estrategia al buscar y ordenar por comentarios sin leer.\r\n- La magia se termina haciendo cambiando includes => left joins ya que el includes agrega un millón de alias de tablas.columnas y eso te obliga a agregar todas las tablas en el group by.\r\n\r\nRaw Sql para corroborar el orden:\r\nhttps://gist.github.com/Shelvak/d63df57fcaeedf09a7b9a3cc79aa06f9","created_at":"2018-10-17T01:30:49Z","updated_at":"2018-10-19T12:19:59Z","closed_at":"2018-10-19T12:19:59Z","merged_at":"2018-10-19T12:19:59Z","merge_commit_sha":"35dc95c8d4bee7ae11ea313156972849b2c8d8fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":23640083,"node_id":"MDU6TGFiZWwyMzY0MDA4Mw==","url":"https://api.github.com/repos/cirope/mawidabp/labels/bug","name":"bug","color":"e10c02","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/cirope/mawidabp/pulls/106/commits","review_comments_url":"https://api.github.com/repos/cirope/mawidabp/pulls/106/comments","review_comment_url":"https://api.github.com/repos/cirope/mawidabp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cirope/mawidabp/issues/106/comments","statuses_url":"https://api.github.com/repos/cirope/mawidabp/statuses/4ce2dbe0726c54eee5fa54a4585f4137b290d6a9","head":{"label":"cirope:paginate_issue","ref":"paginate_issue","sha":"4ce2dbe0726c54eee5fa54a4585f4137b290d6a9","user":{"login":"cirope","id":2007113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDcxMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2007113?v=4","gravatar_id":"","url":"https://api.github.com/users/cirope","html_url":"https://github.com/cirope","followers_url":"https://api.github.com/users/cirope/followers","following_url":"https://api.github.com/users/cirope/following{/other_user}","gists_url":"https://api.github.com/users/cirope/gists{/gist_id}","starred_url":"https://api.github.com/users/cirope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirope/subscriptions","organizations_url":"https://api.github.com/users/cirope/orgs","repos_url":"https://api.github.com/users/cirope/repos","events_url":"https://api.github.com/users/cirope/events{/privacy}","received_events_url":"https://api.github.com/users/cirope/received_events","type":"Organization","site_admin":false},"repo":{"id":1271571,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcxNTcx","name":"mawidabp","full_name":"cirope/mawidabp","private":false,"owner":{"login":"cirope","id":2007113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDcxMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2007113?v=4","gravatar_id":"","url":"https://api.github.com/users/cirope","html_url":"https://github.com/cirope","followers_url":"https://api.github.com/users/cirope/followers","following_url":"https://api.github.com/users/cirope/following{/other_user}","gists_url":"https://api.github.com/users/cirope/gists{/gist_id}","starred_url":"https://api.github.com/users/cirope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirope/subscriptions","organizations_url":"https://api.github.com/users/cirope/orgs","repos_url":"https://api.github.com/users/cirope/repos","events_url":"https://api.github.com/users/cirope/events{/privacy}","received_events_url":"https://api.github.com/users/cirope/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cirope/mawidabp","description":"Audit asistant web application","fork":false,"url":"https://api.github.com/repos/cirope/mawidabp","forks_url":"https://api.github.com/repos/cirope/mawidabp/forks","keys_url":"https://api.github.com/repos/cirope/mawidabp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cirope/mawidabp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cirope/mawidabp/teams","hooks_url":"https://api.github.com/repos/cirope/mawidabp/hooks","issue_events_url":"https://api.github.com/repos/cirope/mawidabp/issues/events{/number}","events_url":"https://api.github.com/repos/cirope/mawidabp/events","assignees_url":"https://api.github.com/repos/cirope/mawidabp/assignees{/user}","branches_url":"https://api.github.com/repos/cirope/mawidabp/branches{/branch}","tags_url":"https://api.github.com/repos/cirope/mawidabp/tags","blobs_url":"https://api.github.com/repos/cirope/mawidabp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cirope/mawidabp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cirope/mawidabp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cirope/mawidabp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cirope/mawidabp/statuses/{sha}","languages_url":"https://api.github.com/repos/cirope/mawidabp/languages","stargazers_url":"https://api.github.com/repos/cirope/mawidabp/stargazers","contributors_url":"https://api.github.com/repos/cirope/mawidabp/contributors","subscribers_url":"https://api.github.com/repos/cirope/mawidabp/subscribers","subscription_url":"https://api.github.com/repos/cirope/mawidabp/subscription","commits_url":"https://api.github.com/repos/cirope/mawidabp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cirope/mawidabp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cirope/mawidabp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cirope/mawidabp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cirope/mawidabp/contents/{+path}","compare_url":"https://api.github.com/repos/cirope/mawidabp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cirope/mawidabp/merges","archive_url":"https://api.github.com/repos/cirope/mawidabp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cirope/mawidabp/downloads","issues_url":"https://api.github.com/repos/cirope/mawidabp/issues{/number}","pulls_url":"https://api.github.com/repos/cirope/mawidabp/pulls{/number}","milestones_url":"https://api.github.com/repos/cirope/mawidabp/milestones{/number}","notifications_url":"https://api.github.com/repos/cirope/mawidabp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cirope/mawidabp/labels{/name}","releases_url":"https://api.github.com/repos/cirope/mawidabp/releases{/id}","deployments_url":"https://api.github.com/repos/cirope/mawidabp/deployments","created_at":"2011-01-19T17:09:32Z","updated_at":"2018-10-18T16:28:34Z","pushed_at":"2018-10-19T12:19:59Z","git_url":"git://github.com/cirope/mawidabp.git","ssh_url":"git@github.com:cirope/mawidabp.git","clone_url":"https://github.com/cirope/mawidabp.git","svn_url":"https://github.com/cirope/mawidabp","homepage":"","size":16875,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":13,"watchers":1,"default_branch":"master"}},"base":{"label":"cirope:master","ref":"master","sha":"0ce5b1a896e3c566a558e412dff35dea5b639c58","user":{"login":"cirope","id":2007113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDcxMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2007113?v=4","gravatar_id":"","url":"https://api.github.com/users/cirope","html_url":"https://github.com/cirope","followers_url":"https://api.github.com/users/cirope/followers","following_url":"https://api.github.com/users/cirope/following{/other_user}","gists_url":"https://api.github.com/users/cirope/gists{/gist_id}","starred_url":"https://api.github.com/users/cirope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirope/subscriptions","organizations_url":"https://api.github.com/users/cirope/orgs","repos_url":"https://api.github.com/users/cirope/repos","events_url":"https://api.github.com/users/cirope/events{/privacy}","received_events_url":"https://api.github.com/users/cirope/received_events","type":"Organization","site_admin":false},"repo":{"id":1271571,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcxNTcx","name":"mawidabp","full_name":"cirope/mawidabp","private":false,"owner":{"login":"cirope","id":2007113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDcxMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2007113?v=4","gravatar_id":"","url":"https://api.github.com/users/cirope","html_url":"https://github.com/cirope","followers_url":"https://api.github.com/users/cirope/followers","following_url":"https://api.github.com/users/cirope/following{/other_user}","gists_url":"https://api.github.com/users/cirope/gists{/gist_id}","starred_url":"https://api.github.com/users/cirope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirope/subscriptions","organizations_url":"https://api.github.com/users/cirope/orgs","repos_url":"https://api.github.com/users/cirope/repos","events_url":"https://api.github.com/users/cirope/events{/privacy}","received_events_url":"https://api.github.com/users/cirope/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cirope/mawidabp","description":"Audit asistant web application","fork":false,"url":"https://api.github.com/repos/cirope/mawidabp","forks_url":"https://api.github.com/repos/cirope/mawidabp/forks","keys_url":"https://api.github.com/repos/cirope/mawidabp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cirope/mawidabp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cirope/mawidabp/teams","hooks_url":"https://api.github.com/repos/cirope/mawidabp/hooks","issue_events_url":"https://api.github.com/repos/cirope/mawidabp/issues/events{/number}","events_url":"https://api.github.com/repos/cirope/mawidabp/events","assignees_url":"https://api.github.com/repos/cirope/mawidabp/assignees{/user}","branches_url":"https://api.github.com/repos/cirope/mawidabp/branches{/branch}","tags_url":"https://api.github.com/repos/cirope/mawidabp/tags","blobs_url":"https://api.github.com/repos/cirope/mawidabp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cirope/mawidabp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cirope/mawidabp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cirope/mawidabp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cirope/mawidabp/statuses/{sha}","languages_url":"https://api.github.com/repos/cirope/mawidabp/languages","stargazers_url":"https://api.github.com/repos/cirope/mawidabp/stargazers","contributors_url":"https://api.github.com/repos/cirope/mawidabp/contributors","subscribers_url":"https://api.github.com/repos/cirope/mawidabp/subscribers","subscription_url":"https://api.github.com/repos/cirope/mawidabp/subscription","commits_url":"https://api.github.com/repos/cirope/mawidabp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cirope/mawidabp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cirope/mawidabp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cirope/mawidabp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cirope/mawidabp/contents/{+path}","compare_url":"https://api.github.com/repos/cirope/mawidabp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cirope/mawidabp/merges","archive_url":"https://api.github.com/repos/cirope/mawidabp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cirope/mawidabp/downloads","issues_url":"https://api.github.com/repos/cirope/mawidabp/issues{/number}","pulls_url":"https://api.github.com/repos/cirope/mawidabp/pulls{/number}","milestones_url":"https://api.github.com/repos/cirope/mawidabp/milestones{/number}","notifications_url":"https://api.github.com/repos/cirope/mawidabp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cirope/mawidabp/labels{/name}","releases_url":"https://api.github.com/repos/cirope/mawidabp/releases{/id}","deployments_url":"https://api.github.com/repos/cirope/mawidabp/deployments","created_at":"2011-01-19T17:09:32Z","updated_at":"2018-10-18T16:28:34Z","pushed_at":"2018-10-19T12:19:59Z","git_url":"git://github.com/cirope/mawidabp.git","ssh_url":"git@github.com:cirope/mawidabp.git","clone_url":"https://github.com/cirope/mawidabp.git","svn_url":"https://github.com/cirope/mawidabp","homepage":"","size":16875,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/106"},"html":{"href":"https://github.com/cirope/mawidabp/pull/106"},"issue":{"href":"https://api.github.com/repos/cirope/mawidabp/issues/106"},"comments":{"href":"https://api.github.com/repos/cirope/mawidabp/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cirope/mawidabp/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/cirope/mawidabp/statuses/4ce2dbe0726c54eee5fa54a4585f4137b290d6a9"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"francocatena","id":85371,"node_id":"MDQ6VXNlcjg1Mzcx","avatar_url":"https://avatars3.githubusercontent.com/u/85371?v=4","gravatar_id":"","url":"https://api.github.com/users/francocatena","html_url":"https://github.com/francocatena","followers_url":"https://api.github.com/users/francocatena/followers","following_url":"https://api.github.com/users/francocatena/following{/other_user}","gists_url":"https://api.github.com/users/francocatena/gists{/gist_id}","starred_url":"https://api.github.com/users/francocatena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francocatena/subscriptions","organizations_url":"https://api.github.com/users/francocatena/orgs","repos_url":"https://api.github.com/users/francocatena/repos","events_url":"https://api.github.com/users/francocatena/events{/privacy}","received_events_url":"https://api.github.com/users/francocatena/received_events","type":"User","site_admin":false},"comments":2,"review_comments":20,"maintainer_can_modify":false,"commits":11,"additions":85,"deletions":43,"changed_files":6}}
{"actor":{"display_login":"francocatena"}}