{"action":"created","comment":{"url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/comments/186451260","pull_request_review_id":118027569,"id":186451260,"diff_hunk":"@@ -75,6 +76,12 @@ def load(filename, relative_to_module=None, compound=None, coords_only=False,\n     if compound is None:\n         compound = Compound()\n \n+    # Handle the case of a xyz file, which must use an internal reader\n+    extension = os.path.splitext(filename)[-1]\n+    if extension == '.xyz':","path":"mbuild/compound.py","position":14,"original_position":14,"commit_id":"b319a4b12697a8f136cb61bfc306c88d0f0b0618","original_commit_id":"b319a4b12697a8f136cb61bfc306c88d0f0b0618","user":{"login":"summeraz","id":5833414,"avatar_url":"https://avatars1.githubusercontent.com/u/5833414?v=4","gravatar_id":"","url":"https://api.github.com/users/summeraz","html_url":"https://github.com/summeraz","followers_url":"https://api.github.com/users/summeraz/followers","following_url":"https://api.github.com/users/summeraz/following{/other_user}","gists_url":"https://api.github.com/users/summeraz/gists{/gist_id}","starred_url":"https://api.github.com/users/summeraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/summeraz/subscriptions","organizations_url":"https://api.github.com/users/summeraz/orgs","repos_url":"https://api.github.com/users/summeraz/repos","events_url":"https://api.github.com/users/summeraz/events{/privacy}","received_events_url":"https://api.github.com/users/summeraz/received_events","type":"User","site_admin":false},"body":"We might want this to be `if extension == '.xyz' and not 'top' in kwargs:`. That way we can still use MDTraj's XYZ reader if a topology is also provided (and we should have unit tests covering both cases).","created_at":"2018-05-07T15:03:01Z","updated_at":"2018-05-07T15:04:26Z","html_url":"https://github.com/mosdef-hub/mbuild/pull/423#discussion_r186451260","pull_request_url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/423","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/comments/186451260"},"html":{"href":"https://github.com/mosdef-hub/mbuild/pull/423#discussion_r186451260"},"pull_request":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/423"}}},"pull_request":{"url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/423","id":183570914,"html_url":"https://github.com/mosdef-hub/mbuild/pull/423","diff_url":"https://github.com/mosdef-hub/mbuild/pull/423.diff","patch_url":"https://github.com/mosdef-hub/mbuild/pull/423.patch","issue_url":"https://api.github.com/repos/mosdef-hub/mbuild/issues/423","number":423,"state":"open","locked":false,"title":"Add simple xyz reader","user":{"login":"mattwthompson","id":7935382,"avatar_url":"https://avatars3.githubusercontent.com/u/7935382?v=4","gravatar_id":"","url":"https://api.github.com/users/mattwthompson","html_url":"https://github.com/mattwthompson","followers_url":"https://api.github.com/users/mattwthompson/followers","following_url":"https://api.github.com/users/mattwthompson/following{/other_user}","gists_url":"https://api.github.com/users/mattwthompson/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwthompson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwthompson/subscriptions","organizations_url":"https://api.github.com/users/mattwthompson/orgs","repos_url":"https://api.github.com/users/mattwthompson/repos","events_url":"https://api.github.com/users/mattwthompson/events{/privacy}","received_events_url":"https://api.github.com/users/mattwthompson/received_events","type":"User","site_admin":false},"body":"This might help with some of the packmol issues we've been running into #420 #422 \r\n\r\nLargely code that @mikemhenry has contributed in #422 but with some extra lines to ensure a sane compound is returned, meaning its use should be sufficiently general to the few people who actually want to read in an xyz file.","created_at":"2018-04-23T22:08:10Z","updated_at":"2018-05-07T15:04:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dc8335abc76c753760227559d0ee1d382a0720f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/423/commits","review_comments_url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/423/comments","review_comment_url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mosdef-hub/mbuild/issues/423/comments","statuses_url":"https://api.github.com/repos/mosdef-hub/mbuild/statuses/b319a4b12697a8f136cb61bfc306c88d0f0b0618","head":{"label":"mattwthompson:read_xyz","ref":"read_xyz","sha":"b319a4b12697a8f136cb61bfc306c88d0f0b0618","user":{"login":"mattwthompson","id":7935382,"avatar_url":"https://avatars3.githubusercontent.com/u/7935382?v=4","gravatar_id":"","url":"https://api.github.com/users/mattwthompson","html_url":"https://github.com/mattwthompson","followers_url":"https://api.github.com/users/mattwthompson/followers","following_url":"https://api.github.com/users/mattwthompson/following{/other_user}","gists_url":"https://api.github.com/users/mattwthompson/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwthompson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwthompson/subscriptions","organizations_url":"https://api.github.com/users/mattwthompson/orgs","repos_url":"https://api.github.com/users/mattwthompson/repos","events_url":"https://api.github.com/users/mattwthompson/events{/privacy}","received_events_url":"https://api.github.com/users/mattwthompson/received_events","type":"User","site_admin":false},"repo":{"id":81871837,"name":"mbuild","full_name":"mattwthompson/mbuild","owner":{"login":"mattwthompson","id":7935382,"avatar_url":"https://avatars3.githubusercontent.com/u/7935382?v=4","gravatar_id":"","url":"https://api.github.com/users/mattwthompson","html_url":"https://github.com/mattwthompson","followers_url":"https://api.github.com/users/mattwthompson/followers","following_url":"https://api.github.com/users/mattwthompson/following{/other_user}","gists_url":"https://api.github.com/users/mattwthompson/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwthompson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwthompson/subscriptions","organizations_url":"https://api.github.com/users/mattwthompson/orgs","repos_url":"https://api.github.com/users/mattwthompson/repos","events_url":"https://api.github.com/users/mattwthompson/events{/privacy}","received_events_url":"https://api.github.com/users/mattwthompson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattwthompson/mbuild","description":"A hierarchical, component based molecule builder","fork":true,"url":"https://api.github.com/repos/mattwthompson/mbuild","forks_url":"https://api.github.com/repos/mattwthompson/mbuild/forks","keys_url":"https://api.github.com/repos/mattwthompson/mbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattwthompson/mbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattwthompson/mbuild/teams","hooks_url":"https://api.github.com/repos/mattwthompson/mbuild/hooks","issue_events_url":"https://api.github.com/repos/mattwthompson/mbuild/issues/events{/number}","events_url":"https://api.github.com/repos/mattwthompson/mbuild/events","assignees_url":"https://api.github.com/repos/mattwthompson/mbuild/assignees{/user}","branches_url":"https://api.github.com/repos/mattwthompson/mbuild/branches{/branch}","tags_url":"https://api.github.com/repos/mattwthompson/mbuild/tags","blobs_url":"https://api.github.com/repos/mattwthompson/mbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattwthompson/mbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattwthompson/mbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattwthompson/mbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattwthompson/mbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/mattwthompson/mbuild/languages","stargazers_url":"https://api.github.com/repos/mattwthompson/mbuild/stargazers","contributors_url":"https://api.github.com/repos/mattwthompson/mbuild/contributors","subscribers_url":"https://api.github.com/repos/mattwthompson/mbuild/subscribers","subscription_url":"https://api.github.com/repos/mattwthompson/mbuild/subscription","commits_url":"https://api.github.com/repos/mattwthompson/mbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattwthompson/mbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattwthompson/mbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattwthompson/mbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattwthompson/mbuild/contents/{+path}","compare_url":"https://api.github.com/repos/mattwthompson/mbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattwthompson/mbuild/merges","archive_url":"https://api.github.com/repos/mattwthompson/mbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattwthompson/mbuild/downloads","issues_url":"https://api.github.com/repos/mattwthompson/mbuild/issues{/number}","pulls_url":"https://api.github.com/repos/mattwthompson/mbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/mattwthompson/mbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/mattwthompson/mbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattwthompson/mbuild/labels{/name}","releases_url":"https://api.github.com/repos/mattwthompson/mbuild/releases{/id}","deployments_url":"https://api.github.com/repos/mattwthompson/mbuild/deployments","created_at":"2017-02-13T21:08:48Z","updated_at":"2017-02-13T21:08:50Z","pushed_at":"2018-04-24T04:31:25Z","git_url":"git://github.com/mattwthompson/mbuild.git","ssh_url":"git@github.com:mattwthompson/mbuild.git","clone_url":"https://github.com/mattwthompson/mbuild.git","svn_url":"https://github.com/mattwthompson/mbuild","homepage":"http://imodels.github.io/mbuild/","size":72112,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mosdef-hub:master","ref":"master","sha":"61f621d9f691bfe98d56af34733db45a8df5ff8f","user":{"login":"mosdef-hub","id":25673981,"avatar_url":"https://avatars2.githubusercontent.com/u/25673981?v=4","gravatar_id":"","url":"https://api.github.com/users/mosdef-hub","html_url":"https://github.com/mosdef-hub","followers_url":"https://api.github.com/users/mosdef-hub/followers","following_url":"https://api.github.com/users/mosdef-hub/following{/other_user}","gists_url":"https://api.github.com/users/mosdef-hub/gists{/gist_id}","starred_url":"https://api.github.com/users/mosdef-hub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosdef-hub/subscriptions","organizations_url":"https://api.github.com/users/mosdef-hub/orgs","repos_url":"https://api.github.com/users/mosdef-hub/repos","events_url":"https://api.github.com/users/mosdef-hub/events{/privacy}","received_events_url":"https://api.github.com/users/mosdef-hub/received_events","type":"Organization","site_admin":false},"repo":{"id":13804874,"name":"mbuild","full_name":"mosdef-hub/mbuild","owner":{"login":"mosdef-hub","id":25673981,"avatar_url":"https://avatars2.githubusercontent.com/u/25673981?v=4","gravatar_id":"","url":"https://api.github.com/users/mosdef-hub","html_url":"https://github.com/mosdef-hub","followers_url":"https://api.github.com/users/mosdef-hub/followers","following_url":"https://api.github.com/users/mosdef-hub/following{/other_user}","gists_url":"https://api.github.com/users/mosdef-hub/gists{/gist_id}","starred_url":"https://api.github.com/users/mosdef-hub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosdef-hub/subscriptions","organizations_url":"https://api.github.com/users/mosdef-hub/orgs","repos_url":"https://api.github.com/users/mosdef-hub/repos","events_url":"https://api.github.com/users/mosdef-hub/events{/privacy}","received_events_url":"https://api.github.com/users/mosdef-hub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mosdef-hub/mbuild","description":"A hierarchical, component based molecule builder","fork":false,"url":"https://api.github.com/repos/mosdef-hub/mbuild","forks_url":"https://api.github.com/repos/mosdef-hub/mbuild/forks","keys_url":"https://api.github.com/repos/mosdef-hub/mbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mosdef-hub/mbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mosdef-hub/mbuild/teams","hooks_url":"https://api.github.com/repos/mosdef-hub/mbuild/hooks","issue_events_url":"https://api.github.com/repos/mosdef-hub/mbuild/issues/events{/number}","events_url":"https://api.github.com/repos/mosdef-hub/mbuild/events","assignees_url":"https://api.github.com/repos/mosdef-hub/mbuild/assignees{/user}","branches_url":"https://api.github.com/repos/mosdef-hub/mbuild/branches{/branch}","tags_url":"https://api.github.com/repos/mosdef-hub/mbuild/tags","blobs_url":"https://api.github.com/repos/mosdef-hub/mbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mosdef-hub/mbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mosdef-hub/mbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/mosdef-hub/mbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mosdef-hub/mbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/mosdef-hub/mbuild/languages","stargazers_url":"https://api.github.com/repos/mosdef-hub/mbuild/stargazers","contributors_url":"https://api.github.com/repos/mosdef-hub/mbuild/contributors","subscribers_url":"https://api.github.com/repos/mosdef-hub/mbuild/subscribers","subscription_url":"https://api.github.com/repos/mosdef-hub/mbuild/subscription","commits_url":"https://api.github.com/repos/mosdef-hub/mbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/mosdef-hub/mbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/mosdef-hub/mbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/mosdef-hub/mbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/mosdef-hub/mbuild/contents/{+path}","compare_url":"https://api.github.com/repos/mosdef-hub/mbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mosdef-hub/mbuild/merges","archive_url":"https://api.github.com/repos/mosdef-hub/mbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mosdef-hub/mbuild/downloads","issues_url":"https://api.github.com/repos/mosdef-hub/mbuild/issues{/number}","pulls_url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/mosdef-hub/mbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/mosdef-hub/mbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mosdef-hub/mbuild/labels{/name}","releases_url":"https://api.github.com/repos/mosdef-hub/mbuild/releases{/id}","deployments_url":"https://api.github.com/repos/mosdef-hub/mbuild/deployments","created_at":"2013-10-23T14:24:18Z","updated_at":"2018-05-02T23:00:55Z","pushed_at":"2018-05-02T21:36:31Z","git_url":"git://github.com/mosdef-hub/mbuild.git","ssh_url":"git@github.com:mosdef-hub/mbuild.git","clone_url":"https://github.com/mosdef-hub/mbuild.git","svn_url":"https://github.com/mosdef-hub/mbuild","homepage":"http://mosdef-hub.github.io/mbuild/","size":76564,"stargazers_count":35,"watchers_count":35,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":32,"open_issues":55,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/423"},"html":{"href":"https://github.com/mosdef-hub/mbuild/pull/423"},"issue":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/issues/423"},"comments":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/issues/423/comments"},"review_comments":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/423/comments"},"review_comment":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/423/commits"},"statuses":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/statuses/b319a4b12697a8f136cb61bfc306c88d0f0b0618"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"summeraz"}}