{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/12557","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-native","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/12557/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/12557/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/12557/events","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/12557","id":348110062,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTM4NjMx","number":12557,"title":"[ios] Add experimental frame rate measurements to MGLMapView","user":{"login":"friedbunny","id":1198851,"node_id":"MDQ6VXNlcjExOTg4NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1198851?v=4","gravatar_id":"","url":"https://api.github.com/users/friedbunny","html_url":"https://github.com/friedbunny","followers_url":"https://api.github.com/users/friedbunny/followers","following_url":"https://api.github.com/users/friedbunny/following{/other_user}","gists_url":"https://api.github.com/users/friedbunny/gists{/gist_id}","starred_url":"https://api.github.com/users/friedbunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedbunny/subscriptions","organizations_url":"https://api.github.com/users/friedbunny/orgs","repos_url":"https://api.github.com/users/friedbunny/repos","events_url":"https://api.github.com/users/friedbunny/events{/privacy}","received_events_url":"https://api.github.com/users/friedbunny/received_events","type":"User","site_admin":false},"labels":[{"id":77259310,"node_id":"MDU6TGFiZWw3NzI1OTMxMA==","url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/feature","name":"feature","color":"0052cc","default":false},{"id":92400707,"node_id":"MDU6TGFiZWw5MjQwMDcwNw==","url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/iOS","name":"iOS","color":"000000","default":false},{"id":101435202,"node_id":"MDU6TGFiZWwxMDE0MzUyMDI=","url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/performance","name":"performance","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"friedbunny","id":1198851,"node_id":"MDQ6VXNlcjExOTg4NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1198851?v=4","gravatar_id":"","url":"https://api.github.com/users/friedbunny","html_url":"https://github.com/friedbunny","followers_url":"https://api.github.com/users/friedbunny/followers","following_url":"https://api.github.com/users/friedbunny/following{/other_user}","gists_url":"https://api.github.com/users/friedbunny/gists{/gist_id}","starred_url":"https://api.github.com/users/friedbunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedbunny/subscriptions","organizations_url":"https://api.github.com/users/friedbunny/orgs","repos_url":"https://api.github.com/users/friedbunny/repos","events_url":"https://api.github.com/users/friedbunny/events{/privacy}","received_events_url":"https://api.github.com/users/friedbunny/received_events","type":"User","site_admin":false},"assignees":[{"login":"friedbunny","id":1198851,"node_id":"MDQ6VXNlcjExOTg4NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1198851?v=4","gravatar_id":"","url":"https://api.github.com/users/friedbunny","html_url":"https://github.com/friedbunny","followers_url":"https://api.github.com/users/friedbunny/followers","following_url":"https://api.github.com/users/friedbunny/following{/other_user}","gists_url":"https://api.github.com/users/friedbunny/gists{/gist_id}","starred_url":"https://api.github.com/users/friedbunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedbunny/subscriptions","organizations_url":"https://api.github.com/users/friedbunny/orgs","repos_url":"https://api.github.com/users/friedbunny/repos","events_url":"https://api.github.com/users/friedbunny/events{/privacy}","received_events_url":"https://api.github.com/users/friedbunny/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/123","html_url":"https://github.com/mapbox/mapbox-gl-native/milestone/123","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/123/labels","id":3556989,"node_id":"MDk6TWlsZXN0b25lMzU1Njk4OQ==","number":123,"title":"ios-v4.4.0","description":null,"creator":{"login":"friedbunny","id":1198851,"node_id":"MDQ6VXNlcjExOTg4NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1198851?v=4","gravatar_id":"","url":"https://api.github.com/users/friedbunny","html_url":"https://github.com/friedbunny","followers_url":"https://api.github.com/users/friedbunny/followers","following_url":"https://api.github.com/users/friedbunny/following{/other_user}","gists_url":"https://api.github.com/users/friedbunny/gists{/gist_id}","starred_url":"https://api.github.com/users/friedbunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedbunny/subscriptions","organizations_url":"https://api.github.com/users/friedbunny/orgs","repos_url":"https://api.github.com/users/friedbunny/repos","events_url":"https://api.github.com/users/friedbunny/events{/privacy}","received_events_url":"https://api.github.com/users/friedbunny/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2018-08-08T22:51:20Z","updated_at":"2018-08-10T16:09:17Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-08-06T23:02:27Z","updated_at":"2018-08-10T21:44:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/12557","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/12557","diff_url":"https://github.com/mapbox/mapbox-gl-native/pull/12557.diff","patch_url":"https://github.com/mapbox/mapbox-gl-native/pull/12557.patch"},"body":"Adds new properties on `MGLMapView` for average frame rate, average frame render duration, and instantaneous frame render duration (useful for producing graphs and benchmarks).\r\n\r\n### Feature flag strategy\r\nThese measurements happen once per frame and therefore shouldn’t be enabled by default. I went with a simple private `BOOL` that’s settable at run-time, but we should profile this to make sure it’s not impacting regular performance. If it is, I’d suppose a compile-time flag would be more appropriate (but less convenient, as external apps would need custom builds).\r\n\r\nI also added `MGLMapView_Experimental.h`, which declares read-only properties for `iosapp` but isn’t included as a public header in the SDK.\r\n\r\nThis is the first time we’re added anything feature flag'y in the iOS SDK, so we should probably discuss guidelines around internal documentation, implementation, etc.\r\n\r\n### How to use\r\nIn `iosapp`, you can enable these measurements via the “Show Map Info HUD” setting.\r\n\r\n![img_a91c6db70cd6-1](https://user-images.githubusercontent.com/1198851/43744769-a5bcee04-99a9-11e8-9df1-b3f701eff126.jpeg)\r\n\r\n/cc @mapbox/maps-ios "},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments/412214559","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/12557#issuecomment-412214559","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/12557","id":412214559,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjIxNDU1OQ==","user":{"login":"friedbunny","id":1198851,"node_id":"MDQ6VXNlcjExOTg4NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1198851?v=4","gravatar_id":"","url":"https://api.github.com/users/friedbunny","html_url":"https://github.com/friedbunny","followers_url":"https://api.github.com/users/friedbunny/followers","following_url":"https://api.github.com/users/friedbunny/following{/other_user}","gists_url":"https://api.github.com/users/friedbunny/gists{/gist_id}","starred_url":"https://api.github.com/users/friedbunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedbunny/subscriptions","organizations_url":"https://api.github.com/users/friedbunny/orgs","repos_url":"https://api.github.com/users/friedbunny/repos","events_url":"https://api.github.com/users/friedbunny/events{/privacy}","received_events_url":"https://api.github.com/users/friedbunny/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T21:44:12Z","updated_at":"2018-08-10T21:44:12Z","author_association":"MEMBER","body":"> Do you have in mind other benchmark/debug options that devs can take advantage of?\r\n\r\nAs far as rendering performance goes, eventually adding a frame rate/duration graph would be useful. For performance and SDK size reasons, though, I think those kinds of developer power features should probably be external or not included in the standard SDK.\r\n\r\n> Would it be better to rename this to `MGLMapView_DevTools`?\r\n\r\nI see `MGLMapView_Experimental` as a place to stash any feature-flagged thing, not just developer tools. Things shouldn’t remain experimental forever, though, so `MGLMapView_DevTools` could be a good place for these to live once they’re stable.\r\n\r\n> If we have more cases for 'dev tools' I think we should add a new category to our documentation with these changes and how to use them.\r\n\r\nI agree, but I don’t expect these particular properties to be publicly exposed for a while (if ever?). Internal docs should definitely exist and I’ll add some inline comments for these properties."}}
{"actor":{"display_login":"friedbunny"}}