{"action":"closed","number":696,"pull_request":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/696","id":192646025,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNjQ2MDI1","html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/696","diff_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/696.diff","patch_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/696.patch","issue_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/696","number":696,"state":"closed","locked":false,"title":"Sort DAE table numerically","user":{"login":"Tom-Willemsen","id":24375813,"node_id":"MDQ6VXNlcjI0Mzc1ODEz","avatar_url":"https://avatars1.githubusercontent.com/u/24375813?v=4","gravatar_id":"","url":"https://api.github.com/users/Tom-Willemsen","html_url":"https://github.com/Tom-Willemsen","followers_url":"https://api.github.com/users/Tom-Willemsen/followers","following_url":"https://api.github.com/users/Tom-Willemsen/following{/other_user}","gists_url":"https://api.github.com/users/Tom-Willemsen/gists{/gist_id}","starred_url":"https://api.github.com/users/Tom-Willemsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tom-Willemsen/subscriptions","organizations_url":"https://api.github.com/users/Tom-Willemsen/orgs","repos_url":"https://api.github.com/users/Tom-Willemsen/repos","events_url":"https://api.github.com/users/Tom-Willemsen/events{/privacy}","received_events_url":"https://api.github.com/users/Tom-Willemsen/received_events","type":"User","site_admin":false},"body":"### Description of work\r\n\r\nSorts DAE detector diagnostics tables purely numerically rather than string based\r\n\r\n### Ticket\r\n\r\nhttps://github.com/ISISComputingGroup/IBEX/issues/3186\r\n\r\n### Acceptance criteria\r\n\r\nTable sorts correctly\r\n\r\n### Unit tests\r\n\r\nThis is quite hard to test, the sorting logic is quite deep down in SWT layers, this change just passes it the correct comparator to use.\r\n\r\n### System tests\r\n\r\nNone added, minimal change\r\n\r\n### Documentation\r\n\r\nNone\r\n\r\n---\r\n\r\n#### Code Review\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Do the changes function as described and is it robust?\r\n- [x] Have the changes been documented in the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev)?\r\n\r\n### Final Steps\r\n- [x] Reviewer has moved the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev) entry for this ticket in the \"Changes merged into master\" section\r\n\r\n","created_at":"2018-06-05T09:36:36Z","updated_at":"2018-06-05T12:50:42Z","closed_at":"2018-06-05T12:50:42Z","merged_at":"2018-06-05T12:50:41Z","merge_commit_sha":"fdc6f7563be84a76992be7adaea3801677595297","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/696/commits","review_comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/696/comments","review_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/696/comments","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/295b60dcca86f191a0ff0be608a2b0a6520ca74b","head":{"label":"ISISComputingGroup:Ticket3186","ref":"Ticket3186","sha":"295b60dcca86f191a0ff0be608a2b0a6520ca74b","user":{"login":"ISISComputingGroup","id":7941980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":36387668,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4NzY2OA==","name":"ibex_gui","full_name":"ISISComputingGroup/ibex_gui","owner":{"login":"ISISComputingGroup","id":7941980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISISComputingGroup/ibex_gui","description":"The IBEX GUI repository","fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui","forks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/deployments","created_at":"2015-05-27T18:37:00Z","updated_at":"2018-06-05T09:49:43Z","pushed_at":"2018-06-05T12:50:41Z","git_url":"git://github.com/ISISComputingGroup/ibex_gui.git","ssh_url":"git@github.com:ISISComputingGroup/ibex_gui.git","clone_url":"https://github.com/ISISComputingGroup/ibex_gui.git","svn_url":"https://github.com/ISISComputingGroup/ibex_gui","homepage":"","size":29682,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"ISISComputingGroup:master","ref":"master","sha":"368414f10691cb2f263a4aaf02b1232ccd9f964a","user":{"login":"ISISComputingGroup","id":7941980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":36387668,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4NzY2OA==","name":"ibex_gui","full_name":"ISISComputingGroup/ibex_gui","owner":{"login":"ISISComputingGroup","id":7941980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISISComputingGroup/ibex_gui","description":"The IBEX GUI repository","fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui","forks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/deployments","created_at":"2015-05-27T18:37:00Z","updated_at":"2018-06-05T09:49:43Z","pushed_at":"2018-06-05T12:50:41Z","git_url":"git://github.com/ISISComputingGroup/ibex_gui.git","ssh_url":"git@github.com:ISISComputingGroup/ibex_gui.git","clone_url":"https://github.com/ISISComputingGroup/ibex_gui.git","svn_url":"https://github.com/ISISComputingGroup/ibex_gui","homepage":"","size":29682,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/696"},"html":{"href":"https://github.com/ISISComputingGroup/ibex_gui/pull/696"},"issue":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/696"},"comments":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/696/comments"},"review_comments":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/696/comments"},"review_comment":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/696/commits"},"statuses":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/295b60dcca86f191a0ff0be608a2b0a6520ca74b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jeremyspencer39171","id":21057792,"node_id":"MDQ6VXNlcjIxMDU3Nzky","avatar_url":"https://avatars3.githubusercontent.com/u/21057792?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyspencer39171","html_url":"https://github.com/jeremyspencer39171","followers_url":"https://api.github.com/users/jeremyspencer39171/followers","following_url":"https://api.github.com/users/jeremyspencer39171/following{/other_user}","gists_url":"https://api.github.com/users/jeremyspencer39171/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyspencer39171/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyspencer39171/subscriptions","organizations_url":"https://api.github.com/users/jeremyspencer39171/orgs","repos_url":"https://api.github.com/users/jeremyspencer39171/repos","events_url":"https://api.github.com/users/jeremyspencer39171/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyspencer39171/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":56,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"jeremyspencer39171"}}