{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/dune/pulls/comments/169629564","pull_request_review_id":98184295,"id":169629564,"diff_hunk":"@@ -26,7 +26,33 @@ module Static_deps = struct\n     }\n end\n \n-let static_deps t ~all_targets =\n+type file_kind = Reg | Dir\n+\n+let inspect_path file_tree path =\n+  match Path.drop_build_context path with\n+  | None ->\n+    if not (Path.exists path) then\n+      None\n+    else if Path.is_directory path then\n+      Some Dir\n+    else\n+      Some Reg\n+  | Some path ->\n+    match File_tree.find_dir file_tree path with\n+    | Some _ ->\n+      (* diml: we should probably warn in this case *)","path":"src/build_interpret.ml","position":19,"original_position":19,"commit_id":"50c30c7ba2615cfc180ca4bb817a30ac30403481","original_commit_id":"50c30c7ba2615cfc180ca4bb817a30ac30403481","user":{"login":"rgrinberg","id":139003,"avatar_url":"https://avatars3.githubusercontent.com/u/139003?v=4","gravatar_id":"","url":"https://api.github.com/users/rgrinberg","html_url":"https://github.com/rgrinberg","followers_url":"https://api.github.com/users/rgrinberg/followers","following_url":"https://api.github.com/users/rgrinberg/following{/other_user}","gists_url":"https://api.github.com/users/rgrinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrinberg/subscriptions","organizations_url":"https://api.github.com/users/rgrinberg/orgs","repos_url":"https://api.github.com/users/rgrinberg/repos","events_url":"https://api.github.com/users/rgrinberg/events{/privacy}","received_events_url":"https://api.github.com/users/rgrinberg/received_events","type":"User","site_admin":false},"body":"Why is this a warning?","created_at":"2018-02-21T13:05:53Z","updated_at":"2018-02-21T13:05:58Z","html_url":"https://github.com/ocaml/dune/pull/536#discussion_r169629564","pull_request_url":"https://api.github.com/repos/ocaml/dune/pulls/536","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ocaml/dune/pulls/comments/169629564"},"html":{"href":"https://github.com/ocaml/dune/pull/536#discussion_r169629564"},"pull_request":{"href":"https://api.github.com/repos/ocaml/dune/pulls/536"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/dune/pulls/536","id":170436092,"html_url":"https://github.com/ocaml/dune/pull/536","diff_url":"https://github.com/ocaml/dune/pull/536.diff","patch_url":"https://github.com/ocaml/dune/pull/536.patch","issue_url":"https://api.github.com/repos/ocaml/dune/issues/536","number":536,"state":"open","locked":false,"title":"Fix #534","user":{"login":"diml","id":1251584,"avatar_url":"https://avatars1.githubusercontent.com/u/1251584?v=4","gravatar_id":"","url":"https://api.github.com/users/diml","html_url":"https://github.com/diml","followers_url":"https://api.github.com/users/diml/followers","following_url":"https://api.github.com/users/diml/following{/other_user}","gists_url":"https://api.github.com/users/diml/gists{/gist_id}","starred_url":"https://api.github.com/users/diml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diml/subscriptions","organizations_url":"https://api.github.com/users/diml/orgs","repos_url":"https://api.github.com/users/diml/repos","events_url":"https://api.github.com/users/diml/events{/privacy}","received_events_url":"https://api.github.com/users/diml/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-21T10:58:21Z","updated_at":"2018-02-21T13:05:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0753258612518ebe3a22db9846dd9273c186c5cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/dune/pulls/536/commits","review_comments_url":"https://api.github.com/repos/ocaml/dune/pulls/536/comments","review_comment_url":"https://api.github.com/repos/ocaml/dune/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/dune/issues/536/comments","statuses_url":"https://api.github.com/repos/ocaml/dune/statuses/50c30c7ba2615cfc180ca4bb817a30ac30403481","head":{"label":"diml:fix-534","ref":"fix-534","sha":"50c30c7ba2615cfc180ca4bb817a30ac30403481","user":{"login":"diml","id":1251584,"avatar_url":"https://avatars1.githubusercontent.com/u/1251584?v=4","gravatar_id":"","url":"https://api.github.com/users/diml","html_url":"https://github.com/diml","followers_url":"https://api.github.com/users/diml/followers","following_url":"https://api.github.com/users/diml/following{/other_user}","gists_url":"https://api.github.com/users/diml/gists{/gist_id}","starred_url":"https://api.github.com/users/diml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diml/subscriptions","organizations_url":"https://api.github.com/users/diml/orgs","repos_url":"https://api.github.com/users/diml/repos","events_url":"https://api.github.com/users/diml/events{/privacy}","received_events_url":"https://api.github.com/users/diml/received_events","type":"User","site_admin":false},"repo":{"id":113104882,"name":"dune","full_name":"diml/dune","owner":{"login":"diml","id":1251584,"avatar_url":"https://avatars1.githubusercontent.com/u/1251584?v=4","gravatar_id":"","url":"https://api.github.com/users/diml","html_url":"https://github.com/diml","followers_url":"https://api.github.com/users/diml/followers","following_url":"https://api.github.com/users/diml/following{/other_user}","gists_url":"https://api.github.com/users/diml/gists{/gist_id}","starred_url":"https://api.github.com/users/diml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diml/subscriptions","organizations_url":"https://api.github.com/users/diml/orgs","repos_url":"https://api.github.com/users/diml/repos","events_url":"https://api.github.com/users/diml/events{/privacy}","received_events_url":"https://api.github.com/users/diml/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diml/dune","description":"A composable build system for OCaml","fork":true,"url":"https://api.github.com/repos/diml/dune","forks_url":"https://api.github.com/repos/diml/dune/forks","keys_url":"https://api.github.com/repos/diml/dune/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diml/dune/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diml/dune/teams","hooks_url":"https://api.github.com/repos/diml/dune/hooks","issue_events_url":"https://api.github.com/repos/diml/dune/issues/events{/number}","events_url":"https://api.github.com/repos/diml/dune/events","assignees_url":"https://api.github.com/repos/diml/dune/assignees{/user}","branches_url":"https://api.github.com/repos/diml/dune/branches{/branch}","tags_url":"https://api.github.com/repos/diml/dune/tags","blobs_url":"https://api.github.com/repos/diml/dune/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diml/dune/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diml/dune/git/refs{/sha}","trees_url":"https://api.github.com/repos/diml/dune/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diml/dune/statuses/{sha}","languages_url":"https://api.github.com/repos/diml/dune/languages","stargazers_url":"https://api.github.com/repos/diml/dune/stargazers","contributors_url":"https://api.github.com/repos/diml/dune/contributors","subscribers_url":"https://api.github.com/repos/diml/dune/subscribers","subscription_url":"https://api.github.com/repos/diml/dune/subscription","commits_url":"https://api.github.com/repos/diml/dune/commits{/sha}","git_commits_url":"https://api.github.com/repos/diml/dune/git/commits{/sha}","comments_url":"https://api.github.com/repos/diml/dune/comments{/number}","issue_comment_url":"https://api.github.com/repos/diml/dune/issues/comments{/number}","contents_url":"https://api.github.com/repos/diml/dune/contents/{+path}","compare_url":"https://api.github.com/repos/diml/dune/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diml/dune/merges","archive_url":"https://api.github.com/repos/diml/dune/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diml/dune/downloads","issues_url":"https://api.github.com/repos/diml/dune/issues{/number}","pulls_url":"https://api.github.com/repos/diml/dune/pulls{/number}","milestones_url":"https://api.github.com/repos/diml/dune/milestones{/number}","notifications_url":"https://api.github.com/repos/diml/dune/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diml/dune/labels{/name}","releases_url":"https://api.github.com/repos/diml/dune/releases{/id}","deployments_url":"https://api.github.com/repos/diml/dune/deployments","created_at":"2017-12-04T22:59:40Z","updated_at":"2018-02-05T09:39:07Z","pushed_at":"2018-02-21T11:00:25Z","git_url":"git://github.com/diml/dune.git","ssh_url":"git@github.com:diml/dune.git","clone_url":"https://github.com/diml/dune.git","svn_url":"https://github.com/diml/dune","homepage":"","size":2709,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocaml:master","ref":"master","sha":"7bd693ed3bcfaa86939bda5fdcdaa4d769c17cdb","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":72368050,"name":"dune","full_name":"ocaml/dune","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/dune","description":"A composable build system for OCaml","fork":false,"url":"https://api.github.com/repos/ocaml/dune","forks_url":"https://api.github.com/repos/ocaml/dune/forks","keys_url":"https://api.github.com/repos/ocaml/dune/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/dune/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/dune/teams","hooks_url":"https://api.github.com/repos/ocaml/dune/hooks","issue_events_url":"https://api.github.com/repos/ocaml/dune/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/dune/events","assignees_url":"https://api.github.com/repos/ocaml/dune/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/dune/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/dune/tags","blobs_url":"https://api.github.com/repos/ocaml/dune/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/dune/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/dune/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/dune/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/dune/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/dune/languages","stargazers_url":"https://api.github.com/repos/ocaml/dune/stargazers","contributors_url":"https://api.github.com/repos/ocaml/dune/contributors","subscribers_url":"https://api.github.com/repos/ocaml/dune/subscribers","subscription_url":"https://api.github.com/repos/ocaml/dune/subscription","commits_url":"https://api.github.com/repos/ocaml/dune/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/dune/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/dune/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/dune/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/dune/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/dune/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/dune/merges","archive_url":"https://api.github.com/repos/ocaml/dune/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/dune/downloads","issues_url":"https://api.github.com/repos/ocaml/dune/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/dune/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/dune/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/dune/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/dune/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/dune/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/dune/deployments","created_at":"2016-10-30T18:42:23Z","updated_at":"2018-02-17T15:33:44Z","pushed_at":"2018-02-21T11:35:24Z","git_url":"git://github.com/ocaml/dune.git","ssh_url":"git@github.com:ocaml/dune.git","clone_url":"https://github.com/ocaml/dune.git","svn_url":"https://github.com/ocaml/dune","homepage":"","size":2679,"stargazers_count":274,"watchers_count":274,"language":"OCaml","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":55,"open_issues":118,"watchers":274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/dune/pulls/536"},"html":{"href":"https://github.com/ocaml/dune/pull/536"},"issue":{"href":"https://api.github.com/repos/ocaml/dune/issues/536"},"comments":{"href":"https://api.github.com/repos/ocaml/dune/issues/536/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/dune/pulls/536/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/dune/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/dune/pulls/536/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/dune/statuses/50c30c7ba2615cfc180ca4bb817a30ac30403481"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rgrinberg"}}