{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls/comments/188114739","pull_request_review_id":120029374,"id":188114739,"diff_hunk":"@@ -14,6 +14,18 @@\n LOG = logging.getLogger(__name__)\n \n \n+class CaseInsensitiveDict(dict):","path":"samcli/local/apigw/service.py","position":4,"original_position":4,"commit_id":"fbb0f0735f0448f86dfaf107d653516738a59a8a","original_commit_id":"e5d3f9188ec19f861f97093f80bfbcbb2dc473aa","user":{"login":"jfuss","id":32497805,"avatar_url":"https://avatars2.githubusercontent.com/u/32497805?v=4","gravatar_id":"","url":"https://api.github.com/users/jfuss","html_url":"https://github.com/jfuss","followers_url":"https://api.github.com/users/jfuss/followers","following_url":"https://api.github.com/users/jfuss/following{/other_user}","gists_url":"https://api.github.com/users/jfuss/gists{/gist_id}","starred_url":"https://api.github.com/users/jfuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfuss/subscriptions","organizations_url":"https://api.github.com/users/jfuss/orgs","repos_url":"https://api.github.com/users/jfuss/repos","events_url":"https://api.github.com/users/jfuss/events{/privacy}","received_events_url":"https://api.github.com/users/jfuss/received_events","type":"User","site_admin":false},"body":"We should have both unit and functional. We need to make sure we are unit testing everything. The CodeCoverage show branch 22-23 missing and we are not really testing the other paths, it just so happens we execute those paths by creating the object. Ideally, we would mock out this class in the other tests, and then add explicit tests for this class.","created_at":"2018-05-14T22:14:24Z","updated_at":"2018-05-14T22:14:24Z","html_url":"https://github.com/awslabs/aws-sam-cli/pull/398#discussion_r188114739","pull_request_url":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls/398","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls/comments/188114739"},"html":{"href":"https://github.com/awslabs/aws-sam-cli/pull/398#discussion_r188114739"},"pull_request":{"href":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls/398"}},"in_reply_to_id":187987910},"pull_request":{"url":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls/398","id":187086937,"html_url":"https://github.com/awslabs/aws-sam-cli/pull/398","diff_url":"https://github.com/awslabs/aws-sam-cli/pull/398.diff","patch_url":"https://github.com/awslabs/aws-sam-cli/pull/398.patch","issue_url":"https://api.github.com/repos/awslabs/aws-sam-cli/issues/398","number":398,"state":"open","locked":false,"title":"Allow for case insensitve header names","user":{"login":"koblas","id":219934,"avatar_url":"https://avatars3.githubusercontent.com/u/219934?v=4","gravatar_id":"","url":"https://api.github.com/users/koblas","html_url":"https://github.com/koblas","followers_url":"https://api.github.com/users/koblas/followers","following_url":"https://api.github.com/users/koblas/following{/other_user}","gists_url":"https://api.github.com/users/koblas/gists{/gist_id}","starred_url":"https://api.github.com/users/koblas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koblas/subscriptions","organizations_url":"https://api.github.com/users/koblas/orgs","repos_url":"https://api.github.com/users/koblas/repos","events_url":"https://api.github.com/users/koblas/events{/privacy}","received_events_url":"https://api.github.com/users/koblas/received_events","type":"User","site_admin":false},"body":"In testing with a local served files, I noted that Content-Type headers were being compared in a case-sensitive way.  Which means that for an express application which is serving headers up in lowercase, sam local was adding a second 'Content-Type: application/json header.\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-05-10T02:37:03Z","updated_at":"2018-05-14T22:14:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a5e20f42029710fc99b67eec1eabca677176735","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":797200208,"url":"https://api.github.com/repos/awslabs/aws-sam-cli/labels/stage/in-progress","name":"stage/in-progress","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls/398/commits","review_comments_url":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls/398/comments","review_comment_url":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/aws-sam-cli/issues/398/comments","statuses_url":"https://api.github.com/repos/awslabs/aws-sam-cli/statuses/fbb0f0735f0448f86dfaf107d653516738a59a8a","head":{"label":"koblas:develop","ref":"develop","sha":"fbb0f0735f0448f86dfaf107d653516738a59a8a","user":{"login":"koblas","id":219934,"avatar_url":"https://avatars3.githubusercontent.com/u/219934?v=4","gravatar_id":"","url":"https://api.github.com/users/koblas","html_url":"https://github.com/koblas","followers_url":"https://api.github.com/users/koblas/followers","following_url":"https://api.github.com/users/koblas/following{/other_user}","gists_url":"https://api.github.com/users/koblas/gists{/gist_id}","starred_url":"https://api.github.com/users/koblas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koblas/subscriptions","organizations_url":"https://api.github.com/users/koblas/orgs","repos_url":"https://api.github.com/users/koblas/repos","events_url":"https://api.github.com/users/koblas/events{/privacy}","received_events_url":"https://api.github.com/users/koblas/received_events","type":"User","site_admin":false},"repo":{"id":132837953,"name":"aws-sam-cli","full_name":"koblas/aws-sam-cli","owner":{"login":"koblas","id":219934,"avatar_url":"https://avatars3.githubusercontent.com/u/219934?v=4","gravatar_id":"","url":"https://api.github.com/users/koblas","html_url":"https://github.com/koblas","followers_url":"https://api.github.com/users/koblas/followers","following_url":"https://api.github.com/users/koblas/following{/other_user}","gists_url":"https://api.github.com/users/koblas/gists{/gist_id}","starred_url":"https://api.github.com/users/koblas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koblas/subscriptions","organizations_url":"https://api.github.com/users/koblas/orgs","repos_url":"https://api.github.com/users/koblas/repos","events_url":"https://api.github.com/users/koblas/events{/privacy}","received_events_url":"https://api.github.com/users/koblas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koblas/aws-sam-cli","description":"AWS SAM CLI 🐿 is a CLI tool for local development and testing of Serverless applications","fork":true,"url":"https://api.github.com/repos/koblas/aws-sam-cli","forks_url":"https://api.github.com/repos/koblas/aws-sam-cli/forks","keys_url":"https://api.github.com/repos/koblas/aws-sam-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koblas/aws-sam-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koblas/aws-sam-cli/teams","hooks_url":"https://api.github.com/repos/koblas/aws-sam-cli/hooks","issue_events_url":"https://api.github.com/repos/koblas/aws-sam-cli/issues/events{/number}","events_url":"https://api.github.com/repos/koblas/aws-sam-cli/events","assignees_url":"https://api.github.com/repos/koblas/aws-sam-cli/assignees{/user}","branches_url":"https://api.github.com/repos/koblas/aws-sam-cli/branches{/branch}","tags_url":"https://api.github.com/repos/koblas/aws-sam-cli/tags","blobs_url":"https://api.github.com/repos/koblas/aws-sam-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koblas/aws-sam-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koblas/aws-sam-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/koblas/aws-sam-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koblas/aws-sam-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/koblas/aws-sam-cli/languages","stargazers_url":"https://api.github.com/repos/koblas/aws-sam-cli/stargazers","contributors_url":"https://api.github.com/repos/koblas/aws-sam-cli/contributors","subscribers_url":"https://api.github.com/repos/koblas/aws-sam-cli/subscribers","subscription_url":"https://api.github.com/repos/koblas/aws-sam-cli/subscription","commits_url":"https://api.github.com/repos/koblas/aws-sam-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/koblas/aws-sam-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/koblas/aws-sam-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/koblas/aws-sam-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/koblas/aws-sam-cli/contents/{+path}","compare_url":"https://api.github.com/repos/koblas/aws-sam-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koblas/aws-sam-cli/merges","archive_url":"https://api.github.com/repos/koblas/aws-sam-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koblas/aws-sam-cli/downloads","issues_url":"https://api.github.com/repos/koblas/aws-sam-cli/issues{/number}","pulls_url":"https://api.github.com/repos/koblas/aws-sam-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/koblas/aws-sam-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/koblas/aws-sam-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koblas/aws-sam-cli/labels{/name}","releases_url":"https://api.github.com/repos/koblas/aws-sam-cli/releases{/id}","deployments_url":"https://api.github.com/repos/koblas/aws-sam-cli/deployments","created_at":"2018-05-10T02:30:00Z","updated_at":"2018-05-14T19:20:32Z","pushed_at":"2018-05-14T19:20:30Z","git_url":"git://github.com/koblas/aws-sam-cli.git","ssh_url":"git@github.com:koblas/aws-sam-cli.git","clone_url":"https://github.com/koblas/aws-sam-cli.git","svn_url":"https://github.com/koblas/aws-sam-cli","homepage":"","size":14190,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"awslabs:develop","ref":"develop","sha":"85f611cf1d51b56240a54d8e7536fc6c2ee272e7","user":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":92205085,"name":"aws-sam-cli","full_name":"awslabs/aws-sam-cli","owner":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/aws-sam-cli","description":"AWS SAM CLI 🐿 is a CLI tool for local development and testing of Serverless applications","fork":false,"url":"https://api.github.com/repos/awslabs/aws-sam-cli","forks_url":"https://api.github.com/repos/awslabs/aws-sam-cli/forks","keys_url":"https://api.github.com/repos/awslabs/aws-sam-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-sam-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-sam-cli/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-sam-cli/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-sam-cli/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-sam-cli/events","assignees_url":"https://api.github.com/repos/awslabs/aws-sam-cli/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-sam-cli/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-sam-cli/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-sam-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-sam-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-sam-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-sam-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-sam-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-sam-cli/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-sam-cli/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-sam-cli/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-sam-cli/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-sam-cli/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-sam-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-sam-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-sam-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-sam-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-sam-cli/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-sam-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-sam-cli/merges","archive_url":"https://api.github.com/repos/awslabs/aws-sam-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-sam-cli/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-sam-cli/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-sam-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-sam-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-sam-cli/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-sam-cli/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-sam-cli/deployments","created_at":"2017-05-23T18:16:23Z","updated_at":"2018-05-14T22:00:53Z","pushed_at":"2018-05-14T21:17:06Z","git_url":"git://github.com/awslabs/aws-sam-cli.git","ssh_url":"git@github.com:awslabs/aws-sam-cli.git","clone_url":"https://github.com/awslabs/aws-sam-cli.git","svn_url":"https://github.com/awslabs/aws-sam-cli","homepage":"","size":14199,"stargazers_count":2388,"watchers_count":2388,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":261,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":261,"open_issues":114,"watchers":2388,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls/398"},"html":{"href":"https://github.com/awslabs/aws-sam-cli/pull/398"},"issue":{"href":"https://api.github.com/repos/awslabs/aws-sam-cli/issues/398"},"comments":{"href":"https://api.github.com/repos/awslabs/aws-sam-cli/issues/398/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls/398/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/aws-sam-cli/pulls/398/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/aws-sam-cli/statuses/fbb0f0735f0448f86dfaf107d653516738a59a8a"}},"author_association":"NONE"}}
{"actor":{"display_login":"jfuss"}}