{"action":"created","comment":{"url":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls/comments/218796039","pull_request_review_id":156810772,"id":218796039,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODc5NjAzOQ==","diff_hunk":"@@ -85,12 +90,36 @@ void SerialPortBridgeGeneric::init()\n {\n     checkConnection();\n \n+    // To remove before v19.0 of the plugin\n+    msg_warning() << \"An old implementation was using 245 as the default header for sentData. This is not the case anymore. The default header is now equal to 255.\";","path":"component/controller/SerialPortBridgeGeneric.cpp","position":27,"original_position":27,"commit_id":"7b23c80094f1e094b0bda3ad4ec14145bccfa5e6","original_commit_id":"7b23c80094f1e094b0bda3ad4ec14145bccfa5e6","user":{"login":"EulalieCoevoet","id":12150715,"node_id":"MDQ6VXNlcjEyMTUwNzE1","avatar_url":"https://avatars0.githubusercontent.com/u/12150715?v=4","gravatar_id":"","url":"https://api.github.com/users/EulalieCoevoet","html_url":"https://github.com/EulalieCoevoet","followers_url":"https://api.github.com/users/EulalieCoevoet/followers","following_url":"https://api.github.com/users/EulalieCoevoet/following{/other_user}","gists_url":"https://api.github.com/users/EulalieCoevoet/gists{/gist_id}","starred_url":"https://api.github.com/users/EulalieCoevoet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EulalieCoevoet/subscriptions","organizations_url":"https://api.github.com/users/EulalieCoevoet/orgs","repos_url":"https://api.github.com/users/EulalieCoevoet/repos","events_url":"https://api.github.com/users/EulalieCoevoet/events{/privacy}","received_events_url":"https://api.github.com/users/EulalieCoevoet/received_events","type":"User","site_admin":false},"body":"Here are the warnings","created_at":"2018-09-19T13:10:44Z","updated_at":"2018-09-19T13:10:44Z","html_url":"https://github.com/SofaDefrost/SoftRobots/pull/15#discussion_r218796039","pull_request_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls/15","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls/comments/218796039"},"html":{"href":"https://github.com/SofaDefrost/SoftRobots/pull/15#discussion_r218796039"},"pull_request":{"href":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls/15","id":194551027,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTUxMDI3","html_url":"https://github.com/SofaDefrost/SoftRobots/pull/15","diff_url":"https://github.com/SofaDefrost/SoftRobots/pull/15.diff","patch_url":"https://github.com/SofaDefrost/SoftRobots/pull/15.patch","issue_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/issues/15","number":15,"state":"open","locked":false,"title":"[controller] added more info about the datas and cleaned the code","user":{"login":"EulalieCoevoet","id":12150715,"node_id":"MDQ6VXNlcjEyMTUwNzE1","avatar_url":"https://avatars0.githubusercontent.com/u/12150715?v=4","gravatar_id":"","url":"https://api.github.com/users/EulalieCoevoet","html_url":"https://github.com/EulalieCoevoet","followers_url":"https://api.github.com/users/EulalieCoevoet/followers","following_url":"https://api.github.com/users/EulalieCoevoet/following{/other_user}","gists_url":"https://api.github.com/users/EulalieCoevoet/gists{/gist_id}","starred_url":"https://api.github.com/users/EulalieCoevoet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EulalieCoevoet/subscriptions","organizations_url":"https://api.github.com/users/EulalieCoevoet/orgs","repos_url":"https://api.github.com/users/EulalieCoevoet/repos","events_url":"https://api.github.com/users/EulalieCoevoet/events{/privacy}","received_events_url":"https://api.github.com/users/EulalieCoevoet/received_events","type":"User","site_admin":false},"body":"This PR includes:\r\n1- removed a convertion of the datas from meter to millimeter that was hidden from users, and only done in the particular case of precise=true. \r\n2- added a warning about that\r\n3- more detailed informations about the datas\r\n4- minor cleaning such as removed some untruth comments.\r\n\r\nThis PR lacks:\r\n1- changes in simulation and arduino code of existing prototypes that will be impacted by these changes...\r\n\r\nI would really like the opinions and advices of @MarioSanz  on this PR. And maybe a list of simulations and arduino codes that should be updated.","created_at":"2018-06-13T11:13:16Z","updated_at":"2018-09-19T13:10:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f01885b19c1e8e33cc256aca7327ad8c70f2a90","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bcarrez","id":18696238,"node_id":"MDQ6VXNlcjE4Njk2MjM4","avatar_url":"https://avatars3.githubusercontent.com/u/18696238?v=4","gravatar_id":"","url":"https://api.github.com/users/bcarrez","html_url":"https://github.com/bcarrez","followers_url":"https://api.github.com/users/bcarrez/followers","following_url":"https://api.github.com/users/bcarrez/following{/other_user}","gists_url":"https://api.github.com/users/bcarrez/gists{/gist_id}","starred_url":"https://api.github.com/users/bcarrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcarrez/subscriptions","organizations_url":"https://api.github.com/users/bcarrez/orgs","repos_url":"https://api.github.com/users/bcarrez/repos","events_url":"https://api.github.com/users/bcarrez/events{/privacy}","received_events_url":"https://api.github.com/users/bcarrez/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls/15/commits","review_comments_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls/15/comments","review_comment_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/issues/15/comments","statuses_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/statuses/7b23c80094f1e094b0bda3ad4ec14145bccfa5e6","head":{"label":"SofaDefrost:cleaningSerialPortBridgeGeneric","ref":"cleaningSerialPortBridgeGeneric","sha":"7b23c80094f1e094b0bda3ad4ec14145bccfa5e6","user":{"login":"SofaDefrost","id":23094510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDk0NTEw","avatar_url":"https://avatars1.githubusercontent.com/u/23094510?v=4","gravatar_id":"","url":"https://api.github.com/users/SofaDefrost","html_url":"https://github.com/SofaDefrost","followers_url":"https://api.github.com/users/SofaDefrost/followers","following_url":"https://api.github.com/users/SofaDefrost/following{/other_user}","gists_url":"https://api.github.com/users/SofaDefrost/gists{/gist_id}","starred_url":"https://api.github.com/users/SofaDefrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SofaDefrost/subscriptions","organizations_url":"https://api.github.com/users/SofaDefrost/orgs","repos_url":"https://api.github.com/users/SofaDefrost/repos","events_url":"https://api.github.com/users/SofaDefrost/events{/privacy}","received_events_url":"https://api.github.com/users/SofaDefrost/received_events","type":"Organization","site_admin":false},"repo":{"id":119060114,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkwNjAxMTQ=","name":"SoftRobots","full_name":"SofaDefrost/SoftRobots","private":false,"owner":{"login":"SofaDefrost","id":23094510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDk0NTEw","avatar_url":"https://avatars1.githubusercontent.com/u/23094510?v=4","gravatar_id":"","url":"https://api.github.com/users/SofaDefrost","html_url":"https://github.com/SofaDefrost","followers_url":"https://api.github.com/users/SofaDefrost/followers","following_url":"https://api.github.com/users/SofaDefrost/following{/other_user}","gists_url":"https://api.github.com/users/SofaDefrost/gists{/gist_id}","starred_url":"https://api.github.com/users/SofaDefrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SofaDefrost/subscriptions","organizations_url":"https://api.github.com/users/SofaDefrost/orgs","repos_url":"https://api.github.com/users/SofaDefrost/repos","events_url":"https://api.github.com/users/SofaDefrost/events{/privacy}","received_events_url":"https://api.github.com/users/SofaDefrost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SofaDefrost/SoftRobots","description":"This Sofa plugin contains components & method for soft robotics.  ","fork":false,"url":"https://api.github.com/repos/SofaDefrost/SoftRobots","forks_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/forks","keys_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/teams","hooks_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/hooks","issue_events_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/issues/events{/number}","events_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/events","assignees_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/assignees{/user}","branches_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/branches{/branch}","tags_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/tags","blobs_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/git/refs{/sha}","trees_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/statuses/{sha}","languages_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/languages","stargazers_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/stargazers","contributors_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/contributors","subscribers_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/subscribers","subscription_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/subscription","commits_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/commits{/sha}","git_commits_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/git/commits{/sha}","comments_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/comments{/number}","issue_comment_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/issues/comments{/number}","contents_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/contents/{+path}","compare_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/merges","archive_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/downloads","issues_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/issues{/number}","pulls_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls{/number}","milestones_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/milestones{/number}","notifications_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/labels{/name}","releases_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/releases{/id}","deployments_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/deployments","created_at":"2018-01-26T14:21:10Z","updated_at":"2018-09-07T09:02:47Z","pushed_at":"2018-09-19T12:34:16Z","git_url":"git://github.com/SofaDefrost/SoftRobots.git","ssh_url":"git@github.com:SofaDefrost/SoftRobots.git","clone_url":"https://github.com/SofaDefrost/SoftRobots.git","svn_url":"https://github.com/SofaDefrost/SoftRobots","homepage":null,"size":17900,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":7,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"SofaDefrost:master","ref":"master","sha":"c45bc3fa69f337cc2d7bc0b66a7c954ba0428d22","user":{"login":"SofaDefrost","id":23094510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDk0NTEw","avatar_url":"https://avatars1.githubusercontent.com/u/23094510?v=4","gravatar_id":"","url":"https://api.github.com/users/SofaDefrost","html_url":"https://github.com/SofaDefrost","followers_url":"https://api.github.com/users/SofaDefrost/followers","following_url":"https://api.github.com/users/SofaDefrost/following{/other_user}","gists_url":"https://api.github.com/users/SofaDefrost/gists{/gist_id}","starred_url":"https://api.github.com/users/SofaDefrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SofaDefrost/subscriptions","organizations_url":"https://api.github.com/users/SofaDefrost/orgs","repos_url":"https://api.github.com/users/SofaDefrost/repos","events_url":"https://api.github.com/users/SofaDefrost/events{/privacy}","received_events_url":"https://api.github.com/users/SofaDefrost/received_events","type":"Organization","site_admin":false},"repo":{"id":119060114,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkwNjAxMTQ=","name":"SoftRobots","full_name":"SofaDefrost/SoftRobots","private":false,"owner":{"login":"SofaDefrost","id":23094510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDk0NTEw","avatar_url":"https://avatars1.githubusercontent.com/u/23094510?v=4","gravatar_id":"","url":"https://api.github.com/users/SofaDefrost","html_url":"https://github.com/SofaDefrost","followers_url":"https://api.github.com/users/SofaDefrost/followers","following_url":"https://api.github.com/users/SofaDefrost/following{/other_user}","gists_url":"https://api.github.com/users/SofaDefrost/gists{/gist_id}","starred_url":"https://api.github.com/users/SofaDefrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SofaDefrost/subscriptions","organizations_url":"https://api.github.com/users/SofaDefrost/orgs","repos_url":"https://api.github.com/users/SofaDefrost/repos","events_url":"https://api.github.com/users/SofaDefrost/events{/privacy}","received_events_url":"https://api.github.com/users/SofaDefrost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SofaDefrost/SoftRobots","description":"This Sofa plugin contains components & method for soft robotics.  ","fork":false,"url":"https://api.github.com/repos/SofaDefrost/SoftRobots","forks_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/forks","keys_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/teams","hooks_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/hooks","issue_events_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/issues/events{/number}","events_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/events","assignees_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/assignees{/user}","branches_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/branches{/branch}","tags_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/tags","blobs_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/git/refs{/sha}","trees_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/statuses/{sha}","languages_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/languages","stargazers_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/stargazers","contributors_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/contributors","subscribers_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/subscribers","subscription_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/subscription","commits_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/commits{/sha}","git_commits_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/git/commits{/sha}","comments_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/comments{/number}","issue_comment_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/issues/comments{/number}","contents_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/contents/{+path}","compare_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/merges","archive_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/downloads","issues_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/issues{/number}","pulls_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls{/number}","milestones_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/milestones{/number}","notifications_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/labels{/name}","releases_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/releases{/id}","deployments_url":"https://api.github.com/repos/SofaDefrost/SoftRobots/deployments","created_at":"2018-01-26T14:21:10Z","updated_at":"2018-09-07T09:02:47Z","pushed_at":"2018-09-19T12:34:16Z","git_url":"git://github.com/SofaDefrost/SoftRobots.git","ssh_url":"git@github.com:SofaDefrost/SoftRobots.git","clone_url":"https://github.com/SofaDefrost/SoftRobots.git","svn_url":"https://github.com/SofaDefrost/SoftRobots","homepage":null,"size":17900,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":7,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls/15"},"html":{"href":"https://github.com/SofaDefrost/SoftRobots/pull/15"},"issue":{"href":"https://api.github.com/repos/SofaDefrost/SoftRobots/issues/15"},"comments":{"href":"https://api.github.com/repos/SofaDefrost/SoftRobots/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SofaDefrost/SoftRobots/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/SofaDefrost/SoftRobots/statuses/7b23c80094f1e094b0bda3ad4ec14145bccfa5e6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"EulalieCoevoet"}}