{"action":"created","comment":{"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments/226296987","pull_request_review_id":166082734,"id":226296987,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjI5Njk4Nw==","diff_hunk":"@@ -4,24 +4,21 @@\n import java.util.Collection;\n import java.util.List;\n \n-import org.kuali.kfs.fp.document.service.DisbursementVoucherPayeeService;\n import org.kuali.kfs.fp.document.service.impl.DisbursementVoucherPaymentReasonServiceImpl;\n-import org.kuali.kfs.sys.context.SpringContext;\n \n public class CuDisbursementVoucherPaymentReasonServiceImpl extends DisbursementVoucherPaymentReasonServiceImpl {\n-\n+    \n+    @Override\n     protected String getDescriptivePayeeTypesAsString(Collection<String> payeeTypeCodes) {\n         List<String> payeeTypeDescriptions = new ArrayList<>();\n \n         for (String payeeTypeCode : payeeTypeCodes) {\n-            String description = SpringContext.getBean(DisbursementVoucherPayeeService.class).getPayeeTypeDescription(payeeTypeCode);\n+            String description = disbursementVoucherPayeeService.getPayeeTypeDescription(payeeTypeCode);\n             if (payeeTypeDescriptions.indexOf(description) == -1) {\n                 payeeTypeDescriptions.add(description);\n             }\n         }\n \n         return this.convertListToString(payeeTypeDescriptions);","path":"src/main/java/edu/cornell/kfs/fp/document/service/impl/CuDisbursementVoucherPaymentReasonServiceImpl.java","position":23,"original_position":23,"commit_id":"a803d9778937e2e6f1aaf1e7d61208b5b579944c","original_commit_id":"a803d9778937e2e6f1aaf1e7d61208b5b579944c","user":{"login":"nkimble","id":6460968,"node_id":"MDQ6VXNlcjY0NjA5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/6460968?v=4","gravatar_id":"","url":"https://api.github.com/users/nkimble","html_url":"https://github.com/nkimble","followers_url":"https://api.github.com/users/nkimble/followers","following_url":"https://api.github.com/users/nkimble/following{/other_user}","gists_url":"https://api.github.com/users/nkimble/gists{/gist_id}","starred_url":"https://api.github.com/users/nkimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkimble/subscriptions","organizations_url":"https://api.github.com/users/nkimble/orgs","repos_url":"https://api.github.com/users/nkimble/repos","events_url":"https://api.github.com/users/nkimble/events{/privacy}","received_events_url":"https://api.github.com/users/nkimble/received_events","type":"User","site_admin":false},"body":"Is \"this\" needed here?","created_at":"2018-10-18T13:09:33Z","updated_at":"2018-10-18T13:11:24Z","html_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/663#discussion_r226296987","pull_request_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/663","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments/226296987"},"html":{"href":"https://github.com/CU-CommunityApps/cu-kfs/pull/663#discussion_r226296987"},"pull_request":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/663"}}},"pull_request":{"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/663","id":223683249,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjgzMjQ5","html_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/663","diff_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/663.diff","patch_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/663.patch","issue_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/663","number":663,"state":"open","locked":false,"title":" KFSPTS-5546 remove spring context calls from CuDisbursementVoucherPaymentReasonServiceImpl","user":{"login":"jhulslander","id":5121156,"node_id":"MDQ6VXNlcjUxMjExNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5121156?v=4","gravatar_id":"","url":"https://api.github.com/users/jhulslander","html_url":"https://github.com/jhulslander","followers_url":"https://api.github.com/users/jhulslander/followers","following_url":"https://api.github.com/users/jhulslander/following{/other_user}","gists_url":"https://api.github.com/users/jhulslander/gists{/gist_id}","starred_url":"https://api.github.com/users/jhulslander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhulslander/subscriptions","organizations_url":"https://api.github.com/users/jhulslander/orgs","repos_url":"https://api.github.com/users/jhulslander/repos","events_url":"https://api.github.com/users/jhulslander/events{/privacy}","received_events_url":"https://api.github.com/users/jhulslander/received_events","type":"User","site_admin":false},"body":"CuDisbursementVoucherPaymentReasonServiceImpl already had the service injected via Spring, but the function still called out to SpringConext get an instance.  It seems to be working correctly with this change","created_at":"2018-10-17T17:04:27Z","updated_at":"2018-10-18T13:11:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcecf32767ec47ec00898abc9fc38d7dc960c6d3","assignee":{"login":"nkimble","id":6460968,"node_id":"MDQ6VXNlcjY0NjA5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/6460968?v=4","gravatar_id":"","url":"https://api.github.com/users/nkimble","html_url":"https://github.com/nkimble","followers_url":"https://api.github.com/users/nkimble/followers","following_url":"https://api.github.com/users/nkimble/following{/other_user}","gists_url":"https://api.github.com/users/nkimble/gists{/gist_id}","starred_url":"https://api.github.com/users/nkimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkimble/subscriptions","organizations_url":"https://api.github.com/users/nkimble/orgs","repos_url":"https://api.github.com/users/nkimble/repos","events_url":"https://api.github.com/users/nkimble/events{/privacy}","received_events_url":"https://api.github.com/users/nkimble/received_events","type":"User","site_admin":false},"assignees":[{"login":"nkimble","id":6460968,"node_id":"MDQ6VXNlcjY0NjA5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/6460968?v=4","gravatar_id":"","url":"https://api.github.com/users/nkimble","html_url":"https://github.com/nkimble","followers_url":"https://api.github.com/users/nkimble/followers","following_url":"https://api.github.com/users/nkimble/following{/other_user}","gists_url":"https://api.github.com/users/nkimble/gists{/gist_id}","starred_url":"https://api.github.com/users/nkimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkimble/subscriptions","organizations_url":"https://api.github.com/users/nkimble/orgs","repos_url":"https://api.github.com/users/nkimble/repos","events_url":"https://api.github.com/users/nkimble/events{/privacy}","received_events_url":"https://api.github.com/users/nkimble/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/663/commits","review_comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/663/comments","review_comment_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/663/comments","statuses_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/a803d9778937e2e6f1aaf1e7d61208b5b579944c","head":{"label":"CU-CommunityApps:KFSPTS-5546","ref":"KFSPTS-5546","sha":"a803d9778937e2e6f1aaf1e7d61208b5b579944c","user":{"login":"CU-CommunityApps","id":5115848,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTU4NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5115848?v=4","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"repo":{"id":12188834,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4ODgzNA==","name":"cu-kfs","full_name":"CU-CommunityApps/cu-kfs","private":false,"owner":{"login":"CU-CommunityApps","id":5115848,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTU4NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5115848?v=4","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CU-CommunityApps/cu-kfs","description":null,"fork":false,"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs","forks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/forks","keys_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/teams","hooks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/hooks","issue_events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/events{/number}","events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/events","assignees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/assignees{/user}","branches_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/branches{/branch}","tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/tags","blobs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/{sha}","languages_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/languages","stargazers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/stargazers","contributors_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contributors","subscribers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscribers","subscription_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscription","commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contents/{+path}","compare_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/merges","archive_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/downloads","issues_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues{/number}","pulls_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls{/number}","milestones_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/milestones{/number}","notifications_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/labels{/name}","releases_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/releases{/id}","deployments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/deployments","created_at":"2013-08-18T01:55:18Z","updated_at":"2018-10-16T17:12:55Z","pushed_at":"2018-10-18T12:11:30Z","git_url":"git://github.com/CU-CommunityApps/cu-kfs.git","ssh_url":"git@github.com:CU-CommunityApps/cu-kfs.git","clone_url":"https://github.com/CU-CommunityApps/cu-kfs.git","svn_url":"https://github.com/CU-CommunityApps/cu-kfs","homepage":null,"size":22343,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"CU-CommunityApps:develop","ref":"develop","sha":"8cb5de4249be490163cbb79516675560090bce47","user":{"login":"CU-CommunityApps","id":5115848,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTU4NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5115848?v=4","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"repo":{"id":12188834,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4ODgzNA==","name":"cu-kfs","full_name":"CU-CommunityApps/cu-kfs","private":false,"owner":{"login":"CU-CommunityApps","id":5115848,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTU4NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5115848?v=4","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CU-CommunityApps/cu-kfs","description":null,"fork":false,"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs","forks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/forks","keys_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/teams","hooks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/hooks","issue_events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/events{/number}","events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/events","assignees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/assignees{/user}","branches_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/branches{/branch}","tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/tags","blobs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/{sha}","languages_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/languages","stargazers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/stargazers","contributors_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contributors","subscribers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscribers","subscription_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscription","commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contents/{+path}","compare_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/merges","archive_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/downloads","issues_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues{/number}","pulls_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls{/number}","milestones_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/milestones{/number}","notifications_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/labels{/name}","releases_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/releases{/id}","deployments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/deployments","created_at":"2013-08-18T01:55:18Z","updated_at":"2018-10-16T17:12:55Z","pushed_at":"2018-10-18T12:11:30Z","git_url":"git://github.com/CU-CommunityApps/cu-kfs.git","ssh_url":"git@github.com:CU-CommunityApps/cu-kfs.git","clone_url":"https://github.com/CU-CommunityApps/cu-kfs.git","svn_url":"https://github.com/CU-CommunityApps/cu-kfs","homepage":null,"size":22343,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/663"},"html":{"href":"https://github.com/CU-CommunityApps/cu-kfs/pull/663"},"issue":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/663"},"comments":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/663/comments"},"review_comments":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/663/comments"},"review_comment":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/663/commits"},"statuses":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/a803d9778937e2e6f1aaf1e7d61208b5b579944c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nkimble"}}