{"action":"created","comment":{"url":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls/comments/175571516","pull_request_review_id":105122986,"id":175571516,"diff_hunk":"@@ -161,7 +163,12 @@ void Kernel_Task_Create_At(PD *p, taskfuncptr f) {\n void Kernel_Task_Create() {\n     if (Tasks >= MAXTHREAD) {\n         /* Too many tasks! */\n-        OS_Abort(NO_DEAD_PROCESS);\n+        /* OS_Abort(NO_DEAD_PROCESS); */","path":"project2/kernel.c","position":51,"original_position":51,"commit_id":"78c16d4dfd0c3b7693e0302bc8e347ad452c237b","original_commit_id":"78c16d4dfd0c3b7693e0302bc8e347ad452c237b","user":{"login":"zevisert","id":11222441,"avatar_url":"https://avatars0.githubusercontent.com/u/11222441?v=4","gravatar_id":"","url":"https://api.github.com/users/zevisert","html_url":"https://github.com/zevisert","followers_url":"https://api.github.com/users/zevisert/followers","following_url":"https://api.github.com/users/zevisert/following{/other_user}","gists_url":"https://api.github.com/users/zevisert/gists{/gist_id}","starred_url":"https://api.github.com/users/zevisert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zevisert/subscriptions","organizations_url":"https://api.github.com/users/zevisert/orgs","repos_url":"https://api.github.com/users/zevisert/repos","events_url":"https://api.github.com/users/zevisert/events{/privacy}","received_events_url":"https://api.github.com/users/zevisert/received_events","type":"User","site_admin":false},"body":"Should comment here why we don't abort for later","created_at":"2018-03-19T20:19:22Z","updated_at":"2018-03-19T20:19:23Z","html_url":"https://github.com/coffee-cup/uvic-csc460/pull/27#discussion_r175571516","pull_request_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls/27","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls/comments/175571516"},"html":{"href":"https://github.com/coffee-cup/uvic-csc460/pull/27#discussion_r175571516"},"pull_request":{"href":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls/27","id":175793279,"html_url":"https://github.com/coffee-cup/uvic-csc460/pull/27","diff_url":"https://github.com/coffee-cup/uvic-csc460/pull/27.diff","patch_url":"https://github.com/coffee-cup/uvic-csc460/pull/27.patch","issue_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/issues/27","number":27,"state":"open","locked":false,"title":"Message Queue and Priority Tests","user":{"login":"coffee-cup","id":3044853,"avatar_url":"https://avatars0.githubusercontent.com/u/3044853?v=4","gravatar_id":"","url":"https://api.github.com/users/coffee-cup","html_url":"https://github.com/coffee-cup","followers_url":"https://api.github.com/users/coffee-cup/followers","following_url":"https://api.github.com/users/coffee-cup/following{/other_user}","gists_url":"https://api.github.com/users/coffee-cup/gists{/gist_id}","starred_url":"https://api.github.com/users/coffee-cup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffee-cup/subscriptions","organizations_url":"https://api.github.com/users/coffee-cup/orgs","repos_url":"https://api.github.com/users/coffee-cup/repos","events_url":"https://api.github.com/users/coffee-cup/events{/privacy}","received_events_url":"https://api.github.com/users/coffee-cup/received_events","type":"User","site_admin":false},"body":"## Changes\r\n\r\n- Added a message queue so that message receiving is fair and FIFO\r\n- Allow `wcet = 0`\r\n- **Abort with timing violation if a periodic task does not start on ttns**\r\n- Dispatch after task creation\r\n- Added more message trace tests for testing FIFO\r\n- Added task tests to check task priority is respected\r\n- Add `lights.c`\r\n\r\n## Closes\r\n\r\n- https://github.com/coffee-cup/uvic-csc460/issues/18\r\n- https://github.com/coffee-cup/uvic-csc460/issues/8\r\n- https://github.com/coffee-cup/uvic-csc460/issues/16","created_at":"2018-03-19T02:46:17Z","updated_at":"2018-03-19T20:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffe343ebc624cad4709d925d7330992eaa4f9dc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls/27/commits","review_comments_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls/27/comments","review_comment_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/issues/27/comments","statuses_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/statuses/78c16d4dfd0c3b7693e0302bc8e347ad452c237b","head":{"label":"coffee-cup:jake/project2","ref":"jake/project2","sha":"78c16d4dfd0c3b7693e0302bc8e347ad452c237b","user":{"login":"coffee-cup","id":3044853,"avatar_url":"https://avatars0.githubusercontent.com/u/3044853?v=4","gravatar_id":"","url":"https://api.github.com/users/coffee-cup","html_url":"https://github.com/coffee-cup","followers_url":"https://api.github.com/users/coffee-cup/followers","following_url":"https://api.github.com/users/coffee-cup/following{/other_user}","gists_url":"https://api.github.com/users/coffee-cup/gists{/gist_id}","starred_url":"https://api.github.com/users/coffee-cup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffee-cup/subscriptions","organizations_url":"https://api.github.com/users/coffee-cup/orgs","repos_url":"https://api.github.com/users/coffee-cup/repos","events_url":"https://api.github.com/users/coffee-cup/events{/privacy}","received_events_url":"https://api.github.com/users/coffee-cup/received_events","type":"User","site_admin":false},"repo":{"id":117294218,"name":"uvic-csc460","full_name":"coffee-cup/uvic-csc460","owner":{"login":"coffee-cup","id":3044853,"avatar_url":"https://avatars0.githubusercontent.com/u/3044853?v=4","gravatar_id":"","url":"https://api.github.com/users/coffee-cup","html_url":"https://github.com/coffee-cup","followers_url":"https://api.github.com/users/coffee-cup/followers","following_url":"https://api.github.com/users/coffee-cup/following{/other_user}","gists_url":"https://api.github.com/users/coffee-cup/gists{/gist_id}","starred_url":"https://api.github.com/users/coffee-cup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffee-cup/subscriptions","organizations_url":"https://api.github.com/users/coffee-cup/orgs","repos_url":"https://api.github.com/users/coffee-cup/repos","events_url":"https://api.github.com/users/coffee-cup/events{/privacy}","received_events_url":"https://api.github.com/users/coffee-cup/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coffee-cup/uvic-csc460","description":"UVIC CSC 460 Project","fork":false,"url":"https://api.github.com/repos/coffee-cup/uvic-csc460","forks_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/forks","keys_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/teams","hooks_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/hooks","issue_events_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/issues/events{/number}","events_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/events","assignees_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/assignees{/user}","branches_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/branches{/branch}","tags_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/tags","blobs_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/git/refs{/sha}","trees_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/statuses/{sha}","languages_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/languages","stargazers_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/stargazers","contributors_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/contributors","subscribers_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/subscribers","subscription_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/subscription","commits_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/commits{/sha}","git_commits_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/git/commits{/sha}","comments_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/comments{/number}","issue_comment_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/issues/comments{/number}","contents_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/contents/{+path}","compare_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/merges","archive_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/downloads","issues_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/issues{/number}","pulls_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls{/number}","milestones_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/milestones{/number}","notifications_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/labels{/name}","releases_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/releases{/id}","deployments_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/deployments","created_at":"2018-01-12T22:34:17Z","updated_at":"2018-03-18T22:14:03Z","pushed_at":"2018-03-19T08:19:30Z","git_url":"git://github.com/coffee-cup/uvic-csc460.git","ssh_url":"git@github.com:coffee-cup/uvic-csc460.git","clone_url":"https://github.com/coffee-cup/uvic-csc460.git","svn_url":"https://github.com/coffee-cup/uvic-csc460","homepage":null,"size":264,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"coffee-cup:master","ref":"master","sha":"55fc0b771c9573bd438f788af64ec7e865361db2","user":{"login":"coffee-cup","id":3044853,"avatar_url":"https://avatars0.githubusercontent.com/u/3044853?v=4","gravatar_id":"","url":"https://api.github.com/users/coffee-cup","html_url":"https://github.com/coffee-cup","followers_url":"https://api.github.com/users/coffee-cup/followers","following_url":"https://api.github.com/users/coffee-cup/following{/other_user}","gists_url":"https://api.github.com/users/coffee-cup/gists{/gist_id}","starred_url":"https://api.github.com/users/coffee-cup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffee-cup/subscriptions","organizations_url":"https://api.github.com/users/coffee-cup/orgs","repos_url":"https://api.github.com/users/coffee-cup/repos","events_url":"https://api.github.com/users/coffee-cup/events{/privacy}","received_events_url":"https://api.github.com/users/coffee-cup/received_events","type":"User","site_admin":false},"repo":{"id":117294218,"name":"uvic-csc460","full_name":"coffee-cup/uvic-csc460","owner":{"login":"coffee-cup","id":3044853,"avatar_url":"https://avatars0.githubusercontent.com/u/3044853?v=4","gravatar_id":"","url":"https://api.github.com/users/coffee-cup","html_url":"https://github.com/coffee-cup","followers_url":"https://api.github.com/users/coffee-cup/followers","following_url":"https://api.github.com/users/coffee-cup/following{/other_user}","gists_url":"https://api.github.com/users/coffee-cup/gists{/gist_id}","starred_url":"https://api.github.com/users/coffee-cup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffee-cup/subscriptions","organizations_url":"https://api.github.com/users/coffee-cup/orgs","repos_url":"https://api.github.com/users/coffee-cup/repos","events_url":"https://api.github.com/users/coffee-cup/events{/privacy}","received_events_url":"https://api.github.com/users/coffee-cup/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coffee-cup/uvic-csc460","description":"UVIC CSC 460 Project","fork":false,"url":"https://api.github.com/repos/coffee-cup/uvic-csc460","forks_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/forks","keys_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/teams","hooks_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/hooks","issue_events_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/issues/events{/number}","events_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/events","assignees_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/assignees{/user}","branches_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/branches{/branch}","tags_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/tags","blobs_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/git/refs{/sha}","trees_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/statuses/{sha}","languages_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/languages","stargazers_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/stargazers","contributors_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/contributors","subscribers_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/subscribers","subscription_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/subscription","commits_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/commits{/sha}","git_commits_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/git/commits{/sha}","comments_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/comments{/number}","issue_comment_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/issues/comments{/number}","contents_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/contents/{+path}","compare_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/merges","archive_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/downloads","issues_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/issues{/number}","pulls_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls{/number}","milestones_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/milestones{/number}","notifications_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/labels{/name}","releases_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/releases{/id}","deployments_url":"https://api.github.com/repos/coffee-cup/uvic-csc460/deployments","created_at":"2018-01-12T22:34:17Z","updated_at":"2018-03-18T22:14:03Z","pushed_at":"2018-03-19T08:19:30Z","git_url":"git://github.com/coffee-cup/uvic-csc460.git","ssh_url":"git@github.com:coffee-cup/uvic-csc460.git","clone_url":"https://github.com/coffee-cup/uvic-csc460.git","svn_url":"https://github.com/coffee-cup/uvic-csc460","homepage":null,"size":264,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls/27"},"html":{"href":"https://github.com/coffee-cup/uvic-csc460/pull/27"},"issue":{"href":"https://api.github.com/repos/coffee-cup/uvic-csc460/issues/27"},"comments":{"href":"https://api.github.com/repos/coffee-cup/uvic-csc460/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coffee-cup/uvic-csc460/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/coffee-cup/uvic-csc460/statuses/78c16d4dfd0c3b7693e0302bc8e347ad452c237b"}},"author_association":"OWNER"}}
{"actor":{"display_login":"zevisert"}}