{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/217894364","pull_request_review_id":155723997,"id":217894364,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzg5NDM2NA==","diff_hunk":"@@ -233,26 +233,23 @@ _public_ struct udev_monitor *udev_monitor_new_from_netlink(struct udev *udev, c\n         return udev_monitor_new_from_netlink_fd(udev, name, -1);\n }\n \n-static inline void bpf_stmt(struct sock_filter *inss, unsigned *i,\n-                            unsigned short code, unsigned data) {\n-        struct sock_filter *ins = &inss[*i];\n-\n-        ins->code = code;\n-        ins->k = data;\n-        (*i)++;\n+static void bpf_stmt(struct sock_filter *ins, unsigned *i,\n+                     unsigned short code, unsigned data) {\n+        ins[(*i)++] = (struct sock_filter) {\n+                .code = code,\n+                .k = data,\n+        };","path":"src/libudev/libudev-monitor.c","position":256,"original_position":16,"commit_id":"8aae9a66fae7aa7f1f7563f0bf14f9ab3de916bd","original_commit_id":"3d01fa902c3804417126c2b846f671c710669ce8","user":{"login":"keszybz","id":349618,"node_id":"MDQ6VXNlcjM0OTYxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/349618?v=4","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"body":"We might even want to simply get rid of those two helpers, I don't think they help much at this point.","created_at":"2018-09-15T20:16:43Z","updated_at":"2018-09-15T20:36:32Z","html_url":"https://github.com/systemd/systemd/pull/9928#discussion_r217894364","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/9928","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/217894364"},"html":{"href":"https://github.com/systemd/systemd/pull/9928#discussion_r217894364"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/9928"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/9928","id":210670154,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjcwMTU0","html_url":"https://github.com/systemd/systemd/pull/9928","diff_url":"https://github.com/systemd/systemd/pull/9928.diff","patch_url":"https://github.com/systemd/systemd/pull/9928.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/9928","number":9928,"state":"open","locked":false,"title":"libudev: coding style updates","user":{"login":"yuwata","id":14157143,"node_id":"MDQ6VXNlcjE0MTU3MTQz","avatar_url":"https://avatars3.githubusercontent.com/u/14157143?v=4","gravatar_id":"","url":"https://api.github.com/users/yuwata","html_url":"https://github.com/yuwata","followers_url":"https://api.github.com/users/yuwata/followers","following_url":"https://api.github.com/users/yuwata/following{/other_user}","gists_url":"https://api.github.com/users/yuwata/gists{/gist_id}","starred_url":"https://api.github.com/users/yuwata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuwata/subscriptions","organizations_url":"https://api.github.com/users/yuwata/orgs","repos_url":"https://api.github.com/users/yuwata/repos","events_url":"https://api.github.com/users/yuwata/events{/privacy}","received_events_url":"https://api.github.com/users/yuwata/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-24T08:15:39Z","updated_at":"2018-09-15T20:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7967d0437b667c3047d81af38d996b80ed2bb32c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":219549617,"node_id":"MDU6TGFiZWwyMTk1NDk2MTc=","url":"https://api.github.com/repos/systemd/systemd/labels/udev","name":"udev","color":"f7c6c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/9928/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/9928/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/9928/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/8aae9a66fae7aa7f1f7563f0bf14f9ab3de916bd","head":{"label":"yuwata:libudev-cleanups","ref":"libudev-cleanups","sha":"8aae9a66fae7aa7f1f7563f0bf14f9ab3de916bd","user":{"login":"yuwata","id":14157143,"node_id":"MDQ6VXNlcjE0MTU3MTQz","avatar_url":"https://avatars3.githubusercontent.com/u/14157143?v=4","gravatar_id":"","url":"https://api.github.com/users/yuwata","html_url":"https://github.com/yuwata","followers_url":"https://api.github.com/users/yuwata/followers","following_url":"https://api.github.com/users/yuwata/following{/other_user}","gists_url":"https://api.github.com/users/yuwata/gists{/gist_id}","starred_url":"https://api.github.com/users/yuwata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuwata/subscriptions","organizations_url":"https://api.github.com/users/yuwata/orgs","repos_url":"https://api.github.com/users/yuwata/repos","events_url":"https://api.github.com/users/yuwata/events{/privacy}","received_events_url":"https://api.github.com/users/yuwata/received_events","type":"User","site_admin":false},"repo":{"id":47944207,"node_id":"MDEwOlJlcG9zaXRvcnk0Nzk0NDIwNw==","name":"systemd","full_name":"yuwata/systemd","private":false,"owner":{"login":"yuwata","id":14157143,"node_id":"MDQ6VXNlcjE0MTU3MTQz","avatar_url":"https://avatars3.githubusercontent.com/u/14157143?v=4","gravatar_id":"","url":"https://api.github.com/users/yuwata","html_url":"https://github.com/yuwata","followers_url":"https://api.github.com/users/yuwata/followers","following_url":"https://api.github.com/users/yuwata/following{/other_user}","gists_url":"https://api.github.com/users/yuwata/gists{/gist_id}","starred_url":"https://api.github.com/users/yuwata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuwata/subscriptions","organizations_url":"https://api.github.com/users/yuwata/orgs","repos_url":"https://api.github.com/users/yuwata/repos","events_url":"https://api.github.com/users/yuwata/events{/privacy}","received_events_url":"https://api.github.com/users/yuwata/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yuwata/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/yuwata/systemd","forks_url":"https://api.github.com/repos/yuwata/systemd/forks","keys_url":"https://api.github.com/repos/yuwata/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuwata/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuwata/systemd/teams","hooks_url":"https://api.github.com/repos/yuwata/systemd/hooks","issue_events_url":"https://api.github.com/repos/yuwata/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/yuwata/systemd/events","assignees_url":"https://api.github.com/repos/yuwata/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/yuwata/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/yuwata/systemd/tags","blobs_url":"https://api.github.com/repos/yuwata/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuwata/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuwata/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuwata/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuwata/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/yuwata/systemd/languages","stargazers_url":"https://api.github.com/repos/yuwata/systemd/stargazers","contributors_url":"https://api.github.com/repos/yuwata/systemd/contributors","subscribers_url":"https://api.github.com/repos/yuwata/systemd/subscribers","subscription_url":"https://api.github.com/repos/yuwata/systemd/subscription","commits_url":"https://api.github.com/repos/yuwata/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuwata/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuwata/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuwata/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuwata/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/yuwata/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuwata/systemd/merges","archive_url":"https://api.github.com/repos/yuwata/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuwata/systemd/downloads","issues_url":"https://api.github.com/repos/yuwata/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/yuwata/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/yuwata/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/yuwata/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuwata/systemd/labels{/name}","releases_url":"https://api.github.com/repos/yuwata/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/yuwata/systemd/deployments","created_at":"2015-12-14T01:01:35Z","updated_at":"2018-09-15T07:40:35Z","pushed_at":"2018-09-15T15:13:29Z","git_url":"git://github.com/yuwata/systemd.git","ssh_url":"git@github.com:yuwata/systemd.git","clone_url":"https://github.com/yuwata/systemd.git","svn_url":"https://github.com/yuwata/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":97741,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"a507737e5c440dae56102b6b8d0e68b68e624d00","user":{"login":"systemd","id":1918868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTg4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"node_id":"MDEwOlJlcG9zaXRvcnkzMjg3MzMxMw==","name":"systemd","full_name":"systemd/systemd","private":false,"owner":{"login":"systemd","id":1918868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTg4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/systemd/systemd","description":"⚙️ 🐧 systemd System and Service Manager ","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2018-09-15T16:33:36Z","pushed_at":"2018-09-15T18:08:49Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"https://www.freedesktop.org/wiki/Software/systemd/","size":97717,"stargazers_count":3584,"watchers_count":3584,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1365,"mirror_url":null,"archived":false,"open_issues_count":1041,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1365,"open_issues":1041,"watchers":3584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/9928"},"html":{"href":"https://github.com/systemd/systemd/pull/9928"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/9928"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/9928/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/9928/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/9928/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/8aae9a66fae7aa7f1f7563f0bf14f9ab3de916bd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"keszybz"}}