{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/166876838","pull_request_review_id":95006230,"id":166876838,"diff_hunk":"@@ -147,10 +149,9 @@ void test_ucp_peer_failure::init() {\n     wrap_errors();\n \n     ucp_ep_params_t ep_params_mod = {0};\n-    ep_params_mod.field_mask = UCP_EP_PARAM_FIELD_ERR_HANDLER_CB |\n-                               UCP_EP_PARAM_FIELD_USER_DATA;\n-    ep_params_mod.err_handler_cb = err_cb_mod;\n-    ep_params_mod.user_data      = reinterpret_cast<void *>(uintptr_t(MAGIC));\n+    ep_params_mod.field_mask = UCP_EP_PARAM_FIELD_ERR_HANDLER;\n+    ep_params_mod.err_handler.cb = err_cb_mod;\n+    ep_params_mod.err_handler.arg = reinterpret_cast<void *>(uintptr_t(MAGIC));","path":"test/gtest/ucp/test_ucp_peer_failure.cc","position":31,"original_position":31,"commit_id":"d11dff422055292e0bb217747b5a39149919bd39","original_commit_id":"d11dff422055292e0bb217747b5a39149919bd39","user":{"login":"yosefe","id":2255631,"avatar_url":"https://avatars0.githubusercontent.com/u/2255631?v=4","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"body":"maybe should use USER_DATA here as well, as in other tests?","created_at":"2018-02-08T09:39:11Z","updated_at":"2018-02-08T09:40:58Z","html_url":"https://github.com/openucx/ucx/pull/2281#discussion_r166876838","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/2281","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/166876838"},"html":{"href":"https://github.com/openucx/ucx/pull/2281#discussion_r166876838"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2281"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/2281","id":167896475,"html_url":"https://github.com/openucx/ucx/pull/2281","diff_url":"https://github.com/openucx/ucx/pull/2281.diff","patch_url":"https://github.com/openucx/ucx/pull/2281.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/2281","number":2281,"state":"open","locked":false,"title":"UCP/API: restore ucp_ep_params_t compatibility 1.3.x","user":{"login":"evgeny-leksikov","id":15216359,"avatar_url":"https://avatars3.githubusercontent.com/u/15216359?v=4","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"body":"Cherry-picked from https://github.com/openucx/ucx/pull/2280\r\n@yosefe @shamisp ","created_at":"2018-02-08T07:32:35Z","updated_at":"2018-02-08T09:40:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3af76349bba25e76e059e7f794f2c99769ccf347","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/2281/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/2281/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/2281/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/d11dff422055292e0bb217747b5a39149919bd39","head":{"label":"evgeny-leksikov:ucp_ep_params_compat_13","ref":"ucp_ep_params_compat_13","sha":"d11dff422055292e0bb217747b5a39149919bd39","user":{"login":"evgeny-leksikov","id":15216359,"avatar_url":"https://avatars3.githubusercontent.com/u/15216359?v=4","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"repo":{"id":77319416,"name":"ucx","full_name":"evgeny-leksikov/ucx","owner":{"login":"evgeny-leksikov","id":15216359,"avatar_url":"https://avatars3.githubusercontent.com/u/15216359?v=4","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evgeny-leksikov/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":true,"url":"https://api.github.com/repos/evgeny-leksikov/ucx","forks_url":"https://api.github.com/repos/evgeny-leksikov/ucx/forks","keys_url":"https://api.github.com/repos/evgeny-leksikov/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evgeny-leksikov/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evgeny-leksikov/ucx/teams","hooks_url":"https://api.github.com/repos/evgeny-leksikov/ucx/hooks","issue_events_url":"https://api.github.com/repos/evgeny-leksikov/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/evgeny-leksikov/ucx/events","assignees_url":"https://api.github.com/repos/evgeny-leksikov/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/evgeny-leksikov/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/evgeny-leksikov/ucx/tags","blobs_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evgeny-leksikov/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/evgeny-leksikov/ucx/languages","stargazers_url":"https://api.github.com/repos/evgeny-leksikov/ucx/stargazers","contributors_url":"https://api.github.com/repos/evgeny-leksikov/ucx/contributors","subscribers_url":"https://api.github.com/repos/evgeny-leksikov/ucx/subscribers","subscription_url":"https://api.github.com/repos/evgeny-leksikov/ucx/subscription","commits_url":"https://api.github.com/repos/evgeny-leksikov/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/evgeny-leksikov/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/evgeny-leksikov/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/evgeny-leksikov/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/evgeny-leksikov/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evgeny-leksikov/ucx/merges","archive_url":"https://api.github.com/repos/evgeny-leksikov/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evgeny-leksikov/ucx/downloads","issues_url":"https://api.github.com/repos/evgeny-leksikov/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/evgeny-leksikov/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/evgeny-leksikov/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/evgeny-leksikov/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evgeny-leksikov/ucx/labels{/name}","releases_url":"https://api.github.com/repos/evgeny-leksikov/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/evgeny-leksikov/ucx/deployments","created_at":"2016-12-25T09:34:08Z","updated_at":"2016-12-25T09:34:12Z","pushed_at":"2018-02-08T07:31:18Z","git_url":"git://github.com/evgeny-leksikov/ucx.git","ssh_url":"git@github.com:evgeny-leksikov/ucx.git","clone_url":"https://github.com/evgeny-leksikov/ucx.git","svn_url":"https://github.com/evgeny-leksikov/ucx","homepage":"http://www.openucx.org","size":11472,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:v1.3.x","ref":"v1.3.x","sha":"070c326ed640731fa3998f7512674b74a542b3d6","user":{"login":"openucx","id":13118737,"avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"name":"ucx","full_name":"openucx/ucx","owner":{"login":"openucx","id":13118737,"avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2018-01-20T18:26:38Z","pushed_at":"2018-02-08T09:40:31Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":"http://www.openucx.org","size":11523,"stargazers_count":96,"watchers_count":96,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":131,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":64,"open_issues":131,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2281"},"html":{"href":"https://github.com/openucx/ucx/pull/2281"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/2281"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/2281/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2281/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2281/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/d11dff422055292e0bb217747b5a39149919bd39"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yosefe"}}