{"action":"created","issue":{"url":"https://api.github.com/repos/m-labs/smoltcp/issues/153","repository_url":"https://api.github.com/repos/m-labs/smoltcp","labels_url":"https://api.github.com/repos/m-labs/smoltcp/issues/153/labels{/name}","comments_url":"https://api.github.com/repos/m-labs/smoltcp/issues/153/comments","events_url":"https://api.github.com/repos/m-labs/smoltcp/issues/153/events","html_url":"https://github.com/m-labs/smoltcp/pull/153","id":294667061,"number":153,"title":"Relax type constraints on payload_mut methods","user":{"login":"canndrew","id":5555066,"avatar_url":"https://avatars3.githubusercontent.com/u/5555066?v=4","gravatar_id":"","url":"https://api.github.com/users/canndrew","html_url":"https://github.com/canndrew","followers_url":"https://api.github.com/users/canndrew/followers","following_url":"https://api.github.com/users/canndrew/following{/other_user}","gists_url":"https://api.github.com/users/canndrew/gists{/gist_id}","starred_url":"https://api.github.com/users/canndrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canndrew/subscriptions","organizations_url":"https://api.github.com/users/canndrew/orgs","repos_url":"https://api.github.com/users/canndrew/repos","events_url":"https://api.github.com/users/canndrew/events{/privacy}","received_events_url":"https://api.github.com/users/canndrew/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-06T08:12:54Z","updated_at":"2018-02-06T08:17:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/m-labs/smoltcp/pulls/153","html_url":"https://github.com/m-labs/smoltcp/pull/153","diff_url":"https://github.com/m-labs/smoltcp/pull/153.diff","patch_url":"https://github.com/m-labs/smoltcp/pull/153.patch"},"body":"Currently, `payload_mut` methods on packet types require the underlying buffer to be a mutable reference `&mut T` where `T: AsMut<u8>`. This makes the methods unusable for types like `Ipv4Packet<Vec<u8>>` or `Ipv4Packet<BytesMut>`. We can simplify this to just work over packets with buffer type `T` for `T: AsMut<u8>`.\r\n\r\nNote that removing the `?Sized` bound doesn't make these impls any less general since `&mut T` is still `Sized` even if `T` isn't.  eg. you can still use this with `Ipv4Packet<&mut [u8]>` and friends."},"comment":{"url":"https://api.github.com/repos/m-labs/smoltcp/issues/comments/363344425","html_url":"https://github.com/m-labs/smoltcp/pull/153#issuecomment-363344425","issue_url":"https://api.github.com/repos/m-labs/smoltcp/issues/153","id":363344425,"user":{"login":"whitequark","id":54771,"avatar_url":"https://avatars1.githubusercontent.com/u/54771?v=4","gravatar_id":"","url":"https://api.github.com/users/whitequark","html_url":"https://github.com/whitequark","followers_url":"https://api.github.com/users/whitequark/followers","following_url":"https://api.github.com/users/whitequark/following{/other_user}","gists_url":"https://api.github.com/users/whitequark/gists{/gist_id}","starred_url":"https://api.github.com/users/whitequark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitequark/subscriptions","organizations_url":"https://api.github.com/users/whitequark/orgs","repos_url":"https://api.github.com/users/whitequark/repos","events_url":"https://api.github.com/users/whitequark/events{/privacy}","received_events_url":"https://api.github.com/users/whitequark/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T08:17:07Z","updated_at":"2018-02-06T08:17:07Z","author_association":"OWNER","body":"@m-labs-homu r+"}}
{"actor":{"display_login":"whitequark"}}