{"action":"created","comment":{"url":"https://api.github.com/repos/Pylons/pyramid/pulls/comments/234920246","pull_request_review_id":176663373,"id":234920246,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDkyMDI0Ng==","diff_hunk":"@@ -429,7 +428,7 @@ Performing a Translation\n \n A :term:`localizer` has a ``translate`` method which accepts either a\n :term:`translation string` or a Unicode string and which returns a Unicode\n-object representing the translation.  Generating a translation in a view\n+string representing the translation.  Generating a translation in a view","path":"docs/narr/i18n.rst","position":35,"original_position":35,"commit_id":"8c943501e87bed7836bb9ec1b216a561cc3f6be6","original_commit_id":"8c943501e87bed7836bb9ec1b216a561cc3f6be6","user":{"login":"stevepiercy","id":102112,"node_id":"MDQ6VXNlcjEwMjExMg==","avatar_url":"https://avatars1.githubusercontent.com/u/102112?v=4","gravatar_id":"","url":"https://api.github.com/users/stevepiercy","html_url":"https://github.com/stevepiercy","followers_url":"https://api.github.com/users/stevepiercy/followers","following_url":"https://api.github.com/users/stevepiercy/following{/other_user}","gists_url":"https://api.github.com/users/stevepiercy/gists{/gist_id}","starred_url":"https://api.github.com/users/stevepiercy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevepiercy/subscriptions","organizations_url":"https://api.github.com/users/stevepiercy/orgs","repos_url":"https://api.github.com/users/stevepiercy/repos","events_url":"https://api.github.com/users/stevepiercy/events{/privacy}","received_events_url":"https://api.github.com/users/stevepiercy/received_events","type":"User","site_admin":false},"body":"Should the preceding \"Unicode\" be removed here?","created_at":"2018-11-20T09:14:43Z","updated_at":"2018-11-20T09:16:39Z","html_url":"https://github.com/Pylons/pyramid/pull/3421#discussion_r234920246","pull_request_url":"https://api.github.com/repos/Pylons/pyramid/pulls/3421","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Pylons/pyramid/pulls/comments/234920246"},"html":{"href":"https://github.com/Pylons/pyramid/pull/3421#discussion_r234920246"},"pull_request":{"href":"https://api.github.com/repos/Pylons/pyramid/pulls/3421"}}},"pull_request":{"url":"https://api.github.com/repos/Pylons/pyramid/pulls/3421","id":230334722,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzM0NzIy","html_url":"https://github.com/Pylons/pyramid/pull/3421","diff_url":"https://github.com/Pylons/pyramid/pull/3421.diff","patch_url":"https://github.com/Pylons/pyramid/pull/3421.patch","issue_url":"https://api.github.com/repos/Pylons/pyramid/issues/3421","number":3421,"state":"open","locked":false,"title":"initial work to remove py2 from the codebase","user":{"login":"mmerickel","id":487237,"node_id":"MDQ6VXNlcjQ4NzIzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/487237?v=4","gravatar_id":"","url":"https://api.github.com/users/mmerickel","html_url":"https://github.com/mmerickel","followers_url":"https://api.github.com/users/mmerickel/followers","following_url":"https://api.github.com/users/mmerickel/following{/other_user}","gists_url":"https://api.github.com/users/mmerickel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerickel/subscriptions","organizations_url":"https://api.github.com/users/mmerickel/orgs","repos_url":"https://api.github.com/users/mmerickel/repos","events_url":"https://api.github.com/users/mmerickel/events{/privacy}","received_events_url":"https://api.github.com/users/mmerickel/received_events","type":"User","site_admin":false},"body":"- [X] remove references to PY2\r\n- [X] remove conditional imports\r\n- [ ] figure out what to do with `pyramid.compat` going forward (more on this below)\r\n- [X] remove api docs for `pyramid.compat`\r\n- [X] remove usages of `pyramid.compat.native_`\r\n- [x] remove usages of `string_types`, `integer_types`, and other `foo_types` from `pyramid.compat`\r\n- [X] replace usages of `pyramid.compat` in codebase\r\n- [X] fix starter  cookiecutter\r\n- [ ] fix docs for supported versions\r\n- [ ] fix wiki tutorial\r\n- [ ] fix wiki2 tutorial\r\n- [ ] fix quick tutorial\r\n- [ ] fix quick tour docs\r\n- [x] fix docstrings / api docs for affected methods (track down references to bytes, unicode or python versions)\r\n\r\nOne note is that it's important to remember to keep using `text_` and `bytes_` where necessary for apis that may legitimately accept bytes or strings.\r\n\r\n**what to do about pyramid.compat**\r\n\r\n`pyramid.compat` is a public api and addons rely on it for some compatibility features.\r\n\r\nIf we want to remove it, we should push a bugfix release in pyramid that deprecates the module to help people when upgrading.\r\n\r\ncloses https://github.com/Pylons/pyramid/issues/2903","created_at":"2018-11-13T03:14:30Z","updated_at":"2018-11-20T09:16:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44a6199b091929fa33444170adbc30b546fc6648","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/Pylons/pyramid/milestones/5","html_url":"https://github.com/Pylons/pyramid/milestone/5","labels_url":"https://api.github.com/repos/Pylons/pyramid/milestones/5/labels","id":1595888,"node_id":"MDk6TWlsZXN0b25lMTU5NTg4OA==","number":5,"title":"2.0","description":null,"creator":{"login":"mmerickel","id":487237,"node_id":"MDQ6VXNlcjQ4NzIzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/487237?v=4","gravatar_id":"","url":"https://api.github.com/users/mmerickel","html_url":"https://github.com/mmerickel","followers_url":"https://api.github.com/users/mmerickel/followers","following_url":"https://api.github.com/users/mmerickel/following{/other_user}","gists_url":"https://api.github.com/users/mmerickel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerickel/subscriptions","organizations_url":"https://api.github.com/users/mmerickel/orgs","repos_url":"https://api.github.com/users/mmerickel/repos","events_url":"https://api.github.com/users/mmerickel/events{/privacy}","received_events_url":"https://api.github.com/users/mmerickel/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":8,"state":"open","created_at":"2016-02-21T21:36:21Z","updated_at":"2018-11-18T18:58:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Pylons/pyramid/pulls/3421/commits","review_comments_url":"https://api.github.com/repos/Pylons/pyramid/pulls/3421/comments","review_comment_url":"https://api.github.com/repos/Pylons/pyramid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pylons/pyramid/issues/3421/comments","statuses_url":"https://api.github.com/repos/Pylons/pyramid/statuses/8c943501e87bed7836bb9ec1b216a561cc3f6be6","head":{"label":"mmerickel:drop-py2","ref":"drop-py2","sha":"8c943501e87bed7836bb9ec1b216a561cc3f6be6","user":{"login":"mmerickel","id":487237,"node_id":"MDQ6VXNlcjQ4NzIzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/487237?v=4","gravatar_id":"","url":"https://api.github.com/users/mmerickel","html_url":"https://github.com/mmerickel","followers_url":"https://api.github.com/users/mmerickel/followers","following_url":"https://api.github.com/users/mmerickel/following{/other_user}","gists_url":"https://api.github.com/users/mmerickel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerickel/subscriptions","organizations_url":"https://api.github.com/users/mmerickel/orgs","repos_url":"https://api.github.com/users/mmerickel/repos","events_url":"https://api.github.com/users/mmerickel/events{/privacy}","received_events_url":"https://api.github.com/users/mmerickel/received_events","type":"User","site_admin":false},"repo":{"id":1212905,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEyOTA1","name":"pyramid","full_name":"mmerickel/pyramid","private":false,"owner":{"login":"mmerickel","id":487237,"node_id":"MDQ6VXNlcjQ4NzIzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/487237?v=4","gravatar_id":"","url":"https://api.github.com/users/mmerickel","html_url":"https://github.com/mmerickel","followers_url":"https://api.github.com/users/mmerickel/followers","following_url":"https://api.github.com/users/mmerickel/following{/other_user}","gists_url":"https://api.github.com/users/mmerickel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerickel/subscriptions","organizations_url":"https://api.github.com/users/mmerickel/orgs","repos_url":"https://api.github.com/users/mmerickel/repos","events_url":"https://api.github.com/users/mmerickel/events{/privacy}","received_events_url":"https://api.github.com/users/mmerickel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mmerickel/pyramid","description":"Pyramid web framework","fork":true,"url":"https://api.github.com/repos/mmerickel/pyramid","forks_url":"https://api.github.com/repos/mmerickel/pyramid/forks","keys_url":"https://api.github.com/repos/mmerickel/pyramid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmerickel/pyramid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmerickel/pyramid/teams","hooks_url":"https://api.github.com/repos/mmerickel/pyramid/hooks","issue_events_url":"https://api.github.com/repos/mmerickel/pyramid/issues/events{/number}","events_url":"https://api.github.com/repos/mmerickel/pyramid/events","assignees_url":"https://api.github.com/repos/mmerickel/pyramid/assignees{/user}","branches_url":"https://api.github.com/repos/mmerickel/pyramid/branches{/branch}","tags_url":"https://api.github.com/repos/mmerickel/pyramid/tags","blobs_url":"https://api.github.com/repos/mmerickel/pyramid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmerickel/pyramid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmerickel/pyramid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmerickel/pyramid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmerickel/pyramid/statuses/{sha}","languages_url":"https://api.github.com/repos/mmerickel/pyramid/languages","stargazers_url":"https://api.github.com/repos/mmerickel/pyramid/stargazers","contributors_url":"https://api.github.com/repos/mmerickel/pyramid/contributors","subscribers_url":"https://api.github.com/repos/mmerickel/pyramid/subscribers","subscription_url":"https://api.github.com/repos/mmerickel/pyramid/subscription","commits_url":"https://api.github.com/repos/mmerickel/pyramid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmerickel/pyramid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmerickel/pyramid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmerickel/pyramid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmerickel/pyramid/contents/{+path}","compare_url":"https://api.github.com/repos/mmerickel/pyramid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmerickel/pyramid/merges","archive_url":"https://api.github.com/repos/mmerickel/pyramid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmerickel/pyramid/downloads","issues_url":"https://api.github.com/repos/mmerickel/pyramid/issues{/number}","pulls_url":"https://api.github.com/repos/mmerickel/pyramid/pulls{/number}","milestones_url":"https://api.github.com/repos/mmerickel/pyramid/milestones{/number}","notifications_url":"https://api.github.com/repos/mmerickel/pyramid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmerickel/pyramid/labels{/name}","releases_url":"https://api.github.com/repos/mmerickel/pyramid/releases{/id}","deployments_url":"https://api.github.com/repos/mmerickel/pyramid/deployments","created_at":"2011-01-01T20:29:27Z","updated_at":"2016-02-18T17:32:41Z","pushed_at":"2018-11-20T03:35:50Z","git_url":"git://github.com/mmerickel/pyramid.git","ssh_url":"git@github.com:mmerickel/pyramid.git","clone_url":"https://github.com/mmerickel/pyramid.git","svn_url":"https://github.com/mmerickel/pyramid","homepage":"http://docs.pylonshq.com","size":21994,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"Pylons:master","ref":"master","sha":"7429fcb5a96aa10bbe86da08bd0b30c9292efdde","user":{"login":"Pylons","id":452227,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MjIyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/452227?v=4","gravatar_id":"","url":"https://api.github.com/users/Pylons","html_url":"https://github.com/Pylons","followers_url":"https://api.github.com/users/Pylons/followers","following_url":"https://api.github.com/users/Pylons/following{/other_user}","gists_url":"https://api.github.com/users/Pylons/gists{/gist_id}","starred_url":"https://api.github.com/users/Pylons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pylons/subscriptions","organizations_url":"https://api.github.com/users/Pylons/orgs","repos_url":"https://api.github.com/users/Pylons/repos","events_url":"https://api.github.com/users/Pylons/events{/privacy}","received_events_url":"https://api.github.com/users/Pylons/received_events","type":"Organization","site_admin":false},"repo":{"id":1020639,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIwNjM5","name":"pyramid","full_name":"Pylons/pyramid","private":false,"owner":{"login":"Pylons","id":452227,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MjIyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/452227?v=4","gravatar_id":"","url":"https://api.github.com/users/Pylons","html_url":"https://github.com/Pylons","followers_url":"https://api.github.com/users/Pylons/followers","following_url":"https://api.github.com/users/Pylons/following{/other_user}","gists_url":"https://api.github.com/users/Pylons/gists{/gist_id}","starred_url":"https://api.github.com/users/Pylons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pylons/subscriptions","organizations_url":"https://api.github.com/users/Pylons/orgs","repos_url":"https://api.github.com/users/Pylons/repos","events_url":"https://api.github.com/users/Pylons/events{/privacy}","received_events_url":"https://api.github.com/users/Pylons/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Pylons/pyramid","description":"Pyramid - A Python web framework","fork":false,"url":"https://api.github.com/repos/Pylons/pyramid","forks_url":"https://api.github.com/repos/Pylons/pyramid/forks","keys_url":"https://api.github.com/repos/Pylons/pyramid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pylons/pyramid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pylons/pyramid/teams","hooks_url":"https://api.github.com/repos/Pylons/pyramid/hooks","issue_events_url":"https://api.github.com/repos/Pylons/pyramid/issues/events{/number}","events_url":"https://api.github.com/repos/Pylons/pyramid/events","assignees_url":"https://api.github.com/repos/Pylons/pyramid/assignees{/user}","branches_url":"https://api.github.com/repos/Pylons/pyramid/branches{/branch}","tags_url":"https://api.github.com/repos/Pylons/pyramid/tags","blobs_url":"https://api.github.com/repos/Pylons/pyramid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pylons/pyramid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pylons/pyramid/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pylons/pyramid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pylons/pyramid/statuses/{sha}","languages_url":"https://api.github.com/repos/Pylons/pyramid/languages","stargazers_url":"https://api.github.com/repos/Pylons/pyramid/stargazers","contributors_url":"https://api.github.com/repos/Pylons/pyramid/contributors","subscribers_url":"https://api.github.com/repos/Pylons/pyramid/subscribers","subscription_url":"https://api.github.com/repos/Pylons/pyramid/subscription","commits_url":"https://api.github.com/repos/Pylons/pyramid/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pylons/pyramid/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pylons/pyramid/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pylons/pyramid/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pylons/pyramid/contents/{+path}","compare_url":"https://api.github.com/repos/Pylons/pyramid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pylons/pyramid/merges","archive_url":"https://api.github.com/repos/Pylons/pyramid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pylons/pyramid/downloads","issues_url":"https://api.github.com/repos/Pylons/pyramid/issues{/number}","pulls_url":"https://api.github.com/repos/Pylons/pyramid/pulls{/number}","milestones_url":"https://api.github.com/repos/Pylons/pyramid/milestones{/number}","notifications_url":"https://api.github.com/repos/Pylons/pyramid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pylons/pyramid/labels{/name}","releases_url":"https://api.github.com/repos/Pylons/pyramid/releases{/id}","deployments_url":"https://api.github.com/repos/Pylons/pyramid/deployments","created_at":"2010-10-24T22:00:35Z","updated_at":"2018-11-19T13:29:31Z","pushed_at":"2018-11-20T03:35:52Z","git_url":"git://github.com/Pylons/pyramid.git","ssh_url":"git@github.com:Pylons/pyramid.git","clone_url":"https://github.com/Pylons/pyramid.git","svn_url":"https://github.com/Pylons/pyramid","homepage":"https://trypyramid.com/","size":22928,"stargazers_count":2985,"watchers_count":2985,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":835,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":835,"open_issues":74,"watchers":2985,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pylons/pyramid/pulls/3421"},"html":{"href":"https://github.com/Pylons/pyramid/pull/3421"},"issue":{"href":"https://api.github.com/repos/Pylons/pyramid/issues/3421"},"comments":{"href":"https://api.github.com/repos/Pylons/pyramid/issues/3421/comments"},"review_comments":{"href":"https://api.github.com/repos/Pylons/pyramid/pulls/3421/comments"},"review_comment":{"href":"https://api.github.com/repos/Pylons/pyramid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pylons/pyramid/pulls/3421/commits"},"statuses":{"href":"https://api.github.com/repos/Pylons/pyramid/statuses/8c943501e87bed7836bb9ec1b216a561cc3f6be6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"stevepiercy"}}