{"action":"created","issue":{"url":"https://api.github.com/repos/react-native-community/react-native-svg/issues/806","repository_url":"https://api.github.com/repos/react-native-community/react-native-svg","labels_url":"https://api.github.com/repos/react-native-community/react-native-svg/issues/806/labels{/name}","comments_url":"https://api.github.com/repos/react-native-community/react-native-svg/issues/806/comments","events_url":"https://api.github.com/repos/react-native-community/react-native-svg/issues/806/events","html_url":"https://github.com/react-native-community/react-native-svg/issues/806","id":368485494,"node_id":"MDU6SXNzdWUzNjg0ODU0OTQ=","number":806,"title":"Android crash: This dynamic value has been recycled","user":{"login":"janicduplessis","id":2677334,"node_id":"MDQ6VXNlcjI2NzczMzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2677334?v=4","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-10-10T04:01:51Z","updated_at":"2018-10-13T19:54:39Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I'm seeing this crash log on Android in production since updating to ^7.0.0. I'm not sure how to reproduce locally but it comes a svg component that is animated using native animated. However I can't reproduce the crash reliably so there must be some kind of race condition, it happens rather rarely, ~20 instances in the past week for a few thousand users.\r\n\r\nI noticed the implementation uses shadow nodes to save the svg data but if I understand correctly it could just be normal uithread view manager props. Shadow nodes run on a different thread so it might be what causes this race condition.\r\n\r\nHere's the full stacktrace if that can be useful, the interesting part is the inner exception.\r\n\r\n```\r\nJSApplicationIllegalArgumentException\r\nError while updating property 'stroke' of a view managed by: RNSVGRect\r\ncom.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter in updateViewProp at line 95\r\ncom.facebook.react.uimanager.ViewManagerPropertyUpdater$FallbackViewManagerSetter in setProperty at line 132\r\ncom.facebook.react.uimanager.ViewManagerPropertyUpdater in updateProps at line 51\r\ncom.facebook.react.uimanager.ViewManager in updateProperties at line 34\r\ncom.facebook.react.uimanager.NativeViewHierarchyManager in createView at line 269\r\ncom.facebook.react.uimanager.UIViewOperationQueue$CreateViewOperation in execute at line 200\r\ncom.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback in dispatchPendingNonBatchedOperations at line 1105\r\ncom.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback in doFrameGuarded at line 1076\r\ncom.facebook.react.uimanager.GuardedFrameCallback in doFrame at line 29\r\ncom.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher in doFrame at line 134\r\ncom.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1 in doFrame at line 105\r\nandroid.view.Choreographer$CallbackRecord in run at line 869\r\nandroid.view.Choreographer in doCallbacks at line 683\r\nandroid.view.Choreographer in doFrame at line 616\r\nandroid.view.Choreographer$FrameDisplayEventReceiver in run at line 857\r\nandroid.os.Handler in handleCallback at line 751\r\nandroid.os.Handler in dispatchMessage at line 95\r\nandroid.os.Looper in loop at line 154\r\nandroid.app.ActivityThread in main at line 6154\r\njava.lang.reflect.Method in invoke\r\ncom.android.internal.os.ZygoteInit$MethodAndArgsCaller in run at line 867\r\ncom.android.internal.os.ZygoteInit in main at line 757\r\nInvocationTargetException\r\njava.lang.reflect.Method in invoke\r\ncom.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter in updateViewProp at line 83\r\ncom.facebook.react.uimanager.ViewManagerPropertyUpdater$FallbackViewManagerSetter in setProperty at line 132\r\ncom.facebook.react.uimanager.ViewManagerPropertyUpdater in updateProps at line 51\r\ncom.facebook.react.uimanager.ViewManager in updateProperties at line 34\r\ncom.facebook.react.uimanager.NativeViewHierarchyManager in createView at line 269\r\ncom.facebook.react.uimanager.UIViewOperationQueue$CreateViewOperation in execute at line 200\r\ncom.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback in dispatchPendingNonBatchedOperations at line 1105\r\ncom.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback in doFrameGuarded at line 1076\r\ncom.facebook.react.uimanager.GuardedFrameCallback in doFrame at line 29\r\ncom.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher in doFrame at line 134\r\ncom.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1 in doFrame at line 105\r\nandroid.view.Choreographer$CallbackRecord in run at line 869\r\nandroid.view.Choreographer in doCallbacks at line 683\r\nandroid.view.Choreographer in doFrame at line 616\r\nandroid.view.Choreographer$FrameDisplayEventReceiver in run at line 857\r\nandroid.os.Handler in handleCallback at line 751\r\nandroid.os.Handler in dispatchMessage at line 95\r\nandroid.os.Looper in loop at line 154\r\nandroid.app.ActivityThread in main at line 6154\r\njava.lang.reflect.Method in invoke\r\ncom.android.internal.os.ZygoteInit$MethodAndArgsCaller in run at line 867\r\ncom.android.internal.os.ZygoteInit in main at line 757\r\nIllegalStateException\r\nThis dynamic value has been recycled\r\ncom.facebook.react.bridge.DynamicFromMap in asString at line 78\r\ncom.horcrux.svg.RenderableShadowNode in setStroke at line 139\r\ncom.horcrux.svg.RenderableViewManager in setStroke at line 723\r\njava.lang.reflect.Method in invoke\r\ncom.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter in updateViewProp at line 83\r\ncom.facebook.react.uimanager.ViewManagerPropertyUpdater$FallbackViewManagerSetter in setProperty at line 132\r\ncom.facebook.react.uimanager.ViewManagerPropertyUpdater in updateProps at line 51\r\ncom.facebook.react.uimanager.ViewManager in updateProperties at line 34\r\ncom.facebook.react.uimanager.NativeViewHierarchyManager in createView at line 269\r\ncom.facebook.react.uimanager.UIViewOperationQueue$CreateViewOperation in execute at line 200\r\ncom.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback in dispatchPendingNonBatchedOperations at line 1105\r\ncom.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback in doFrameGuarded at line 1076\r\ncom.facebook.react.uimanager.GuardedFrameCallback in doFrame at line 29\r\ncom.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher in doFrame at line 134\r\ncom.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1 in doFrame at line 105\r\nandroid.view.Choreographer$CallbackRecord in run at line 869\r\nandroid.view.Choreographer in doCallbacks at line 683\r\nandroid.view.Choreographer in doFrame at line 616\r\nandroid.view.Choreographer$FrameDisplayEventReceiver in run at line 857\r\nandroid.os.Handler in handleCallback at line 751\r\nandroid.os.Handler in dispatchMessage at line 95\r\nandroid.os.Looper in loop at line 154\r\nandroid.app.ActivityThread in main at line 6154\r\njava.lang.reflect.Method in invoke\r\ncom.android.internal.os.ZygoteInit$MethodAndArgsCaller in run at line 867\r\ncom.android.internal.os.ZygoteInit in main at line 757\r\n```"},"comment":{"url":"https://api.github.com/repos/react-native-community/react-native-svg/issues/comments/429570523","html_url":"https://github.com/react-native-community/react-native-svg/issues/806#issuecomment-429570523","issue_url":"https://api.github.com/repos/react-native-community/react-native-svg/issues/806","id":429570523,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTU3MDUyMw==","user":{"login":"Almouro","id":4534323,"node_id":"MDQ6VXNlcjQ1MzQzMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4534323?v=4","gravatar_id":"","url":"https://api.github.com/users/Almouro","html_url":"https://github.com/Almouro","followers_url":"https://api.github.com/users/Almouro/followers","following_url":"https://api.github.com/users/Almouro/following{/other_user}","gists_url":"https://api.github.com/users/Almouro/gists{/gist_id}","starred_url":"https://api.github.com/users/Almouro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Almouro/subscriptions","organizations_url":"https://api.github.com/users/Almouro/orgs","repos_url":"https://api.github.com/users/Almouro/repos","events_url":"https://api.github.com/users/Almouro/events{/privacy}","received_events_url":"https://api.github.com/users/Almouro/received_events","type":"User","site_admin":false},"created_at":"2018-10-13T19:54:39Z","updated_at":"2018-10-13T19:54:39Z","author_association":"NONE","body":"@msand I confirm that this issue has disappeared 🎉 for those 10% including the PR on React Native (facebook/react-native#17842)\r\nI'll push this PR on React Native side, but might I ask: why is it that other components being animated with the native driver don't trigger this exception while `react-native-svg` components do?\r\n\r\nOur biggest crash on that newest release is now:\r\n```\r\nCaused by: java.lang.NullPointerException: \r\n  at com.horcrux.svg.RenderableViewManager$6.setR (RenderableViewManager.java:237)\r\n```\r\nI can open a new issue for it, I don't think it's related\r\n"}}
{"actor":{"display_login":"Almouro"}}