{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/199042600","pull_request_review_id":133085985,"id":199042600,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTA0MjYwMA==","diff_hunk":"@@ -121,7 +121,39 @@ oppia.directive('oppiaShortResponseDragAndDropSort', [\n   }\n ]);\n \n-// TODO(Vibhor): Rules Service for DragAndDropSort interaction.\n-oppia.factory('dragAndDropSortRulesService', ['$filter', function($filter) {\n-  return {};\n+// Rules Service for DragAndDropSort interaction.\n+oppia.factory('dragAndDropSortRulesService', [function() {\n+  var checkEquality = function(answer, inputs) {\n+    for (var i = 0; i < answer.length; i++) {\n+      if (answer[i].length === inputs.x[i].length) {\n+        for (var j = 0; j < answer[i].length; j++) {\n+          if (inputs.x[i].indexOf(answer[i][j]) === -1) {\n+            return false;\n+          }\n+        }\n+      } else {\n+        return false;\n+      }\n+    }\n+    return true;\n+  };\n+  var checkEqualityWithIncorrectPositions = function(answer, inputs) {\n+    var noOfUnmatches = 0;\n+    for (var i = 0; i < answer.length; i++) {\n+      for (var j = 0; j < answer[i].length; j++) {\n+        if (inputs.x[i].indexOf(answer[i][j]) === -1) {\n+          noOfUnmatches += 1;","path":"extensions/interactions/DragAndDropSort/directives/DragAndDropSort.js","position":37,"original_position":37,"commit_id":"515b86c6633cf7b5be4df8ac8a0ce6139dd72add","original_commit_id":"515b86c6633cf7b5be4df8ac8a0ce6139dd72add","user":{"login":"kevinlee12","id":5758256,"node_id":"MDQ6VXNlcjU3NTgyNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5758256?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinlee12","html_url":"https://github.com/kevinlee12","followers_url":"https://api.github.com/users/kevinlee12/followers","following_url":"https://api.github.com/users/kevinlee12/following{/other_user}","gists_url":"https://api.github.com/users/kevinlee12/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinlee12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinlee12/subscriptions","organizations_url":"https://api.github.com/users/kevinlee12/orgs","repos_url":"https://api.github.com/users/kevinlee12/repos","events_url":"https://api.github.com/users/kevinlee12/events{/privacy}","received_events_url":"https://api.github.com/users/kevinlee12/received_events","type":"User","site_admin":false},"body":"Ditto","created_at":"2018-06-29T03:08:23Z","updated_at":"2018-06-29T03:32:11Z","html_url":"https://github.com/oppia/oppia/pull/5162#discussion_r199042600","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/5162","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/199042600"},"html":{"href":"https://github.com/oppia/oppia/pull/5162#discussion_r199042600"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5162"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5162","id":197950637,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTUwNjM3","html_url":"https://github.com/oppia/oppia/pull/5162","diff_url":"https://github.com/oppia/oppia/pull/5162.diff","patch_url":"https://github.com/oppia/oppia/pull/5162.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5162","number":5162,"state":"open","locked":false,"title":"[WIP] Drag and drop interaction: Milestone 2.3","user":{"login":"vibhor98","id":26625980,"node_id":"MDQ6VXNlcjI2NjI1OTgw","avatar_url":"https://avatars3.githubusercontent.com/u/26625980?v=4","gravatar_id":"","url":"https://api.github.com/users/vibhor98","html_url":"https://github.com/vibhor98","followers_url":"https://api.github.com/users/vibhor98/followers","following_url":"https://api.github.com/users/vibhor98/following{/other_user}","gists_url":"https://api.github.com/users/vibhor98/gists{/gist_id}","starred_url":"https://api.github.com/users/vibhor98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vibhor98/subscriptions","organizations_url":"https://api.github.com/users/vibhor98/orgs","repos_url":"https://api.github.com/users/vibhor98/repos","events_url":"https://api.github.com/users/vibhor98/events{/privacy}","received_events_url":"https://api.github.com/users/vibhor98/received_events","type":"User","site_admin":false},"body":"<!--\r\n  - Thanks for submitting code to Oppia! Please fill out the following as part of\r\n  - your pull request so we can review your code more easily.\r\n  -->\r\n\r\n## Explanation\r\n<!--\r\n  - Explain what your PR does. If this PR fixes an existing bug, please include \r\n  - \"Fixes #bugnum:\" in the explanation so that GitHub can auto-close the issue \r\n  - when this PR is merged.\r\n  -->\r\n\r\n## Checklist\r\n- [ ] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes.\r\n- [ ] The PR explanation includes the words \"Fixes #bugnum: ...\".\r\n- [x] The linter/Karma presubmit checks have passed.\r\n  - These should run automatically, but if not, you can manually trigger them locally using `python scripts/pre_commit_linter.py` and `bash scripts/run_frontend_tests.sh`.\r\n- [x] The PR is made from a branch that's **not** called \"develop\".\r\n- [x] The PR follows the [style guide](https://github.com/oppia/oppia/wiki/Coding-style-guide).\r\n- [x] The PR is assigned to an appropriate reviewer.\r\n  - If you're a new contributor, please ask on [Gitter](https://gitter.im/oppia/oppia-chat) for someone to assign a reviewer.\r\n  - If you're not sure who the appropriate reviewer is, please assign to the issue's \"owner\" -- see the \"talk-to\" label on the issue.\r\n","created_at":"2018-06-28T08:16:35Z","updated_at":"2018-06-29T03:32:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f824c89b1e4c400083b9b86e9639c0e5e18c3a1e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/5162/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/5162/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5162/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/515b86c6633cf7b5be4df8ac8a0ce6139dd72add","head":{"label":"vibhor98:Milestone2.3","ref":"Milestone2.3","sha":"515b86c6633cf7b5be4df8ac8a0ce6139dd72add","user":{"login":"vibhor98","id":26625980,"node_id":"MDQ6VXNlcjI2NjI1OTgw","avatar_url":"https://avatars3.githubusercontent.com/u/26625980?v=4","gravatar_id":"","url":"https://api.github.com/users/vibhor98","html_url":"https://github.com/vibhor98","followers_url":"https://api.github.com/users/vibhor98/followers","following_url":"https://api.github.com/users/vibhor98/following{/other_user}","gists_url":"https://api.github.com/users/vibhor98/gists{/gist_id}","starred_url":"https://api.github.com/users/vibhor98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vibhor98/subscriptions","organizations_url":"https://api.github.com/users/vibhor98/orgs","repos_url":"https://api.github.com/users/vibhor98/repos","events_url":"https://api.github.com/users/vibhor98/events{/privacy}","received_events_url":"https://api.github.com/users/vibhor98/received_events","type":"User","site_admin":false},"repo":{"id":101491759,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0OTE3NTk=","name":"oppia","full_name":"vibhor98/oppia","owner":{"login":"vibhor98","id":26625980,"node_id":"MDQ6VXNlcjI2NjI1OTgw","avatar_url":"https://avatars3.githubusercontent.com/u/26625980?v=4","gravatar_id":"","url":"https://api.github.com/users/vibhor98","html_url":"https://github.com/vibhor98","followers_url":"https://api.github.com/users/vibhor98/followers","following_url":"https://api.github.com/users/vibhor98/following{/other_user}","gists_url":"https://api.github.com/users/vibhor98/gists{/gist_id}","starred_url":"https://api.github.com/users/vibhor98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vibhor98/subscriptions","organizations_url":"https://api.github.com/users/vibhor98/orgs","repos_url":"https://api.github.com/users/vibhor98/repos","events_url":"https://api.github.com/users/vibhor98/events{/privacy}","received_events_url":"https://api.github.com/users/vibhor98/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vibhor98/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/vibhor98/oppia","forks_url":"https://api.github.com/repos/vibhor98/oppia/forks","keys_url":"https://api.github.com/repos/vibhor98/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vibhor98/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vibhor98/oppia/teams","hooks_url":"https://api.github.com/repos/vibhor98/oppia/hooks","issue_events_url":"https://api.github.com/repos/vibhor98/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/vibhor98/oppia/events","assignees_url":"https://api.github.com/repos/vibhor98/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/vibhor98/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/vibhor98/oppia/tags","blobs_url":"https://api.github.com/repos/vibhor98/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vibhor98/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vibhor98/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/vibhor98/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vibhor98/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/vibhor98/oppia/languages","stargazers_url":"https://api.github.com/repos/vibhor98/oppia/stargazers","contributors_url":"https://api.github.com/repos/vibhor98/oppia/contributors","subscribers_url":"https://api.github.com/repos/vibhor98/oppia/subscribers","subscription_url":"https://api.github.com/repos/vibhor98/oppia/subscription","commits_url":"https://api.github.com/repos/vibhor98/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/vibhor98/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/vibhor98/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/vibhor98/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/vibhor98/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/vibhor98/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vibhor98/oppia/merges","archive_url":"https://api.github.com/repos/vibhor98/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vibhor98/oppia/downloads","issues_url":"https://api.github.com/repos/vibhor98/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/vibhor98/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/vibhor98/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/vibhor98/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vibhor98/oppia/labels{/name}","releases_url":"https://api.github.com/repos/vibhor98/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/vibhor98/oppia/deployments","created_at":"2017-08-26T14:42:02Z","updated_at":"2017-08-26T14:42:08Z","pushed_at":"2018-06-28T09:59:01Z","git_url":"git://github.com/vibhor98/oppia.git","ssh_url":"git@github.com:vibhor98/oppia.git","clone_url":"https://github.com/vibhor98/oppia.git","svn_url":"https://github.com/vibhor98/oppia","homepage":"https://www.oppia.org","size":104543,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"140687f35cfe7e7e60275c609c2515c195776eec","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"node_id":"MDEwOlJlcG9zaXRvcnk0MDY4NzU2Mw==","name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-06-28T18:36:21Z","pushed_at":"2018-06-29T01:16:04Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":104603,"stargazers_count":680,"watchers_count":680,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":651,"mirror_url":null,"archived":false,"open_issues_count":332,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":651,"open_issues":332,"watchers":680,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5162"},"html":{"href":"https://github.com/oppia/oppia/pull/5162"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/5162"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/5162/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5162/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5162/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/515b86c6633cf7b5be4df8ac8a0ce6139dd72add"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kevinlee12"}}