{"action":"created","comment":{"url":"https://api.github.com/repos/nteract/nteract/pulls/comments/226668557","pull_request_review_id":166551281,"id":226668557,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjY2ODU1Nw==","diff_hunk":"@@ -0,0 +1,27 @@\n+// @flow\n+import * as React from \"react\";\n+\n+import blueprintCSS from \"./vendor/blueprint.css.js\";\n+\n+import * as Blueprint from \"@blueprintjs/core\";\n+\n+// Takes in a blueprint component, wraps it with styled-jsx\n+function provideStyle<Props>(","path":"packages/ion/src/index.js","position":9,"original_position":9,"commit_id":"075d703c6baac000539a396a5f7925e5e0113fe2","original_commit_id":"075d703c6baac000539a396a5f7925e5e0113fe2","user":{"login":"alexandercbooth","id":15242567,"node_id":"MDQ6VXNlcjE1MjQyNTY3","avatar_url":"https://avatars3.githubusercontent.com/u/15242567?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandercbooth","html_url":"https://github.com/alexandercbooth","followers_url":"https://api.github.com/users/alexandercbooth/followers","following_url":"https://api.github.com/users/alexandercbooth/following{/other_user}","gists_url":"https://api.github.com/users/alexandercbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandercbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandercbooth/subscriptions","organizations_url":"https://api.github.com/users/alexandercbooth/orgs","repos_url":"https://api.github.com/users/alexandercbooth/repos","events_url":"https://api.github.com/users/alexandercbooth/events{/privacy}","received_events_url":"https://api.github.com/users/alexandercbooth/received_events","type":"User","site_admin":false},"body":"This seems like the simplest way to add the styles, but to echo @captainsafia's point, it would be nice if we didn't have to pass in the whole css for each. ","created_at":"2018-10-19T14:31:33Z","updated_at":"2018-10-19T14:34:56Z","html_url":"https://github.com/nteract/nteract/pull/3457#discussion_r226668557","pull_request_url":"https://api.github.com/repos/nteract/nteract/pulls/3457","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nteract/nteract/pulls/comments/226668557"},"html":{"href":"https://github.com/nteract/nteract/pull/3457#discussion_r226668557"},"pull_request":{"href":"https://api.github.com/repos/nteract/nteract/pulls/3457"}}},"pull_request":{"url":"https://api.github.com/repos/nteract/nteract/pulls/3457","id":223283717,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjgzNzE3","html_url":"https://github.com/nteract/nteract/pull/3457","diff_url":"https://github.com/nteract/nteract/pull/3457.diff","patch_url":"https://github.com/nteract/nteract/pull/3457.patch","issue_url":"https://api.github.com/repos/nteract/nteract/issues/3457","number":3457,"state":"open","locked":false,"title":"[WIP] nteract/ion wrapper edition","user":{"login":"rgbkrk","id":836375,"node_id":"MDQ6VXNlcjgzNjM3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/836375?v=4","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"body":"This 🆕 package wraps elements from blueprint.js with CSS provided via `styled-jsx`. By doing this, you can start using:\r\n\r\n```jsx\r\nimport { Tag } from \"@nteract/ion\"\r\n```\r\n\r\nThe approach I took was to wrap _each_ element with the stylesheet. This makes each component work out of the box, but may be a bit of an overkill (it's a lot of CSS text to be passing through). When transpiled, the higher order component looks like this:\r\n\r\n```jsx\r\n// Takes in a blueprint component, wraps it with styled-jsx\r\nfunction provideStyle(Component) {\r\n  return function (props) {\r\n    return React.createElement(React.Fragment, null, React.createElement(Component, props), React.createElement(_style.default, {\r\n      styleId: _blueprintCss.default.__hash,\r\n      css: _blueprintCss.default\r\n    }));\r\n  };\r\n}\r\n```\r\n\r\nAnother approach would be that whenever someone wants to use a bunch of these elements, they add the styled jsx tag themselves.\r\n\r\nThoughts?\r\n\r\ncc @captainsafia @alexandercbooth @emeeks @BenRussert ","created_at":"2018-10-16T14:55:48Z","updated_at":"2018-10-19T14:34:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76fe3eb049cb092a4149ed742dceac5003fa2147","assignee":null,"assignees":[],"requested_reviewers":[{"login":"emeeks","id":495634,"node_id":"MDQ6VXNlcjQ5NTYzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/495634?v=4","gravatar_id":"","url":"https://api.github.com/users/emeeks","html_url":"https://github.com/emeeks","followers_url":"https://api.github.com/users/emeeks/followers","following_url":"https://api.github.com/users/emeeks/following{/other_user}","gists_url":"https://api.github.com/users/emeeks/gists{/gist_id}","starred_url":"https://api.github.com/users/emeeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emeeks/subscriptions","organizations_url":"https://api.github.com/users/emeeks/orgs","repos_url":"https://api.github.com/users/emeeks/repos","events_url":"https://api.github.com/users/emeeks/events{/privacy}","received_events_url":"https://api.github.com/users/emeeks/received_events","type":"User","site_admin":false},{"login":"captainsafia","id":1857993,"node_id":"MDQ6VXNlcjE4NTc5OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1857993?v=4","gravatar_id":"","url":"https://api.github.com/users/captainsafia","html_url":"https://github.com/captainsafia","followers_url":"https://api.github.com/users/captainsafia/followers","following_url":"https://api.github.com/users/captainsafia/following{/other_user}","gists_url":"https://api.github.com/users/captainsafia/gists{/gist_id}","starred_url":"https://api.github.com/users/captainsafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/captainsafia/subscriptions","organizations_url":"https://api.github.com/users/captainsafia/orgs","repos_url":"https://api.github.com/users/captainsafia/repos","events_url":"https://api.github.com/users/captainsafia/events{/privacy}","received_events_url":"https://api.github.com/users/captainsafia/received_events","type":"User","site_admin":false},{"login":"BenRussert","id":10860657,"node_id":"MDQ6VXNlcjEwODYwNjU3","avatar_url":"https://avatars0.githubusercontent.com/u/10860657?v=4","gravatar_id":"","url":"https://api.github.com/users/BenRussert","html_url":"https://github.com/BenRussert","followers_url":"https://api.github.com/users/BenRussert/followers","following_url":"https://api.github.com/users/BenRussert/following{/other_user}","gists_url":"https://api.github.com/users/BenRussert/gists{/gist_id}","starred_url":"https://api.github.com/users/BenRussert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenRussert/subscriptions","organizations_url":"https://api.github.com/users/BenRussert/orgs","repos_url":"https://api.github.com/users/BenRussert/repos","events_url":"https://api.github.com/users/BenRussert/events{/privacy}","received_events_url":"https://api.github.com/users/BenRussert/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nteract/nteract/pulls/3457/commits","review_comments_url":"https://api.github.com/repos/nteract/nteract/pulls/3457/comments","review_comment_url":"https://api.github.com/repos/nteract/nteract/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nteract/nteract/issues/3457/comments","statuses_url":"https://api.github.com/repos/nteract/nteract/statuses/075d703c6baac000539a396a5f7925e5e0113fe2","head":{"label":"rgbkrk:ion-wrapper-edition","ref":"ion-wrapper-edition","sha":"075d703c6baac000539a396a5f7925e5e0113fe2","user":{"login":"rgbkrk","id":836375,"node_id":"MDQ6VXNlcjgzNjM3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/836375?v=4","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"repo":{"id":48899794,"node_id":"MDEwOlJlcG9zaXRvcnk0ODg5OTc5NA==","name":"nteract","full_name":"rgbkrk/nteract","private":false,"owner":{"login":"rgbkrk","id":836375,"node_id":"MDQ6VXNlcjgzNjM3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/836375?v=4","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rgbkrk/nteract","description":":notebook: Electron app of the Jupyter Notebook","fork":true,"url":"https://api.github.com/repos/rgbkrk/nteract","forks_url":"https://api.github.com/repos/rgbkrk/nteract/forks","keys_url":"https://api.github.com/repos/rgbkrk/nteract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgbkrk/nteract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgbkrk/nteract/teams","hooks_url":"https://api.github.com/repos/rgbkrk/nteract/hooks","issue_events_url":"https://api.github.com/repos/rgbkrk/nteract/issues/events{/number}","events_url":"https://api.github.com/repos/rgbkrk/nteract/events","assignees_url":"https://api.github.com/repos/rgbkrk/nteract/assignees{/user}","branches_url":"https://api.github.com/repos/rgbkrk/nteract/branches{/branch}","tags_url":"https://api.github.com/repos/rgbkrk/nteract/tags","blobs_url":"https://api.github.com/repos/rgbkrk/nteract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgbkrk/nteract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgbkrk/nteract/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgbkrk/nteract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgbkrk/nteract/statuses/{sha}","languages_url":"https://api.github.com/repos/rgbkrk/nteract/languages","stargazers_url":"https://api.github.com/repos/rgbkrk/nteract/stargazers","contributors_url":"https://api.github.com/repos/rgbkrk/nteract/contributors","subscribers_url":"https://api.github.com/repos/rgbkrk/nteract/subscribers","subscription_url":"https://api.github.com/repos/rgbkrk/nteract/subscription","commits_url":"https://api.github.com/repos/rgbkrk/nteract/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgbkrk/nteract/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgbkrk/nteract/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgbkrk/nteract/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgbkrk/nteract/contents/{+path}","compare_url":"https://api.github.com/repos/rgbkrk/nteract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgbkrk/nteract/merges","archive_url":"https://api.github.com/repos/rgbkrk/nteract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgbkrk/nteract/downloads","issues_url":"https://api.github.com/repos/rgbkrk/nteract/issues{/number}","pulls_url":"https://api.github.com/repos/rgbkrk/nteract/pulls{/number}","milestones_url":"https://api.github.com/repos/rgbkrk/nteract/milestones{/number}","notifications_url":"https://api.github.com/repos/rgbkrk/nteract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgbkrk/nteract/labels{/name}","releases_url":"https://api.github.com/repos/rgbkrk/nteract/releases{/id}","deployments_url":"https://api.github.com/repos/rgbkrk/nteract/deployments","created_at":"2016-01-02T05:29:56Z","updated_at":"2018-02-01T19:13:20Z","pushed_at":"2018-10-18T14:59:29Z","git_url":"git://github.com/rgbkrk/nteract.git","ssh_url":"git@github.com:rgbkrk/nteract.git","clone_url":"https://github.com/rgbkrk/nteract.git","svn_url":"https://github.com/rgbkrk/nteract","homepage":null,"size":17245,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"nteract:master","ref":"master","sha":"59465025af255e27490d786c92cf5a7569237415","user":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"repo":{"id":37496521,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ5NjUyMQ==","name":"nteract","full_name":"nteract/nteract","private":false,"owner":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nteract/nteract","description":"📘 Desktop, Jupyter Extension, libraries, and more","fork":false,"url":"https://api.github.com/repos/nteract/nteract","forks_url":"https://api.github.com/repos/nteract/nteract/forks","keys_url":"https://api.github.com/repos/nteract/nteract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nteract/nteract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nteract/nteract/teams","hooks_url":"https://api.github.com/repos/nteract/nteract/hooks","issue_events_url":"https://api.github.com/repos/nteract/nteract/issues/events{/number}","events_url":"https://api.github.com/repos/nteract/nteract/events","assignees_url":"https://api.github.com/repos/nteract/nteract/assignees{/user}","branches_url":"https://api.github.com/repos/nteract/nteract/branches{/branch}","tags_url":"https://api.github.com/repos/nteract/nteract/tags","blobs_url":"https://api.github.com/repos/nteract/nteract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nteract/nteract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nteract/nteract/git/refs{/sha}","trees_url":"https://api.github.com/repos/nteract/nteract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nteract/nteract/statuses/{sha}","languages_url":"https://api.github.com/repos/nteract/nteract/languages","stargazers_url":"https://api.github.com/repos/nteract/nteract/stargazers","contributors_url":"https://api.github.com/repos/nteract/nteract/contributors","subscribers_url":"https://api.github.com/repos/nteract/nteract/subscribers","subscription_url":"https://api.github.com/repos/nteract/nteract/subscription","commits_url":"https://api.github.com/repos/nteract/nteract/commits{/sha}","git_commits_url":"https://api.github.com/repos/nteract/nteract/git/commits{/sha}","comments_url":"https://api.github.com/repos/nteract/nteract/comments{/number}","issue_comment_url":"https://api.github.com/repos/nteract/nteract/issues/comments{/number}","contents_url":"https://api.github.com/repos/nteract/nteract/contents/{+path}","compare_url":"https://api.github.com/repos/nteract/nteract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nteract/nteract/merges","archive_url":"https://api.github.com/repos/nteract/nteract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nteract/nteract/downloads","issues_url":"https://api.github.com/repos/nteract/nteract/issues{/number}","pulls_url":"https://api.github.com/repos/nteract/nteract/pulls{/number}","milestones_url":"https://api.github.com/repos/nteract/nteract/milestones{/number}","notifications_url":"https://api.github.com/repos/nteract/nteract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nteract/nteract/labels{/name}","releases_url":"https://api.github.com/repos/nteract/nteract/releases{/id}","deployments_url":"https://api.github.com/repos/nteract/nteract/deployments","created_at":"2015-06-15T23:21:49Z","updated_at":"2018-10-19T13:54:37Z","pushed_at":"2018-10-19T14:13:58Z","git_url":"git://github.com/nteract/nteract.git","ssh_url":"git@github.com:nteract/nteract.git","clone_url":"https://github.com/nteract/nteract.git","svn_url":"https://github.com/nteract/nteract","homepage":"https://nteract.io","size":18573,"stargazers_count":3210,"watchers_count":3210,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":311,"mirror_url":null,"archived":false,"open_issues_count":319,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":311,"open_issues":319,"watchers":3210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nteract/nteract/pulls/3457"},"html":{"href":"https://github.com/nteract/nteract/pull/3457"},"issue":{"href":"https://api.github.com/repos/nteract/nteract/issues/3457"},"comments":{"href":"https://api.github.com/repos/nteract/nteract/issues/3457/comments"},"review_comments":{"href":"https://api.github.com/repos/nteract/nteract/pulls/3457/comments"},"review_comment":{"href":"https://api.github.com/repos/nteract/nteract/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nteract/nteract/pulls/3457/commits"},"statuses":{"href":"https://api.github.com/repos/nteract/nteract/statuses/075d703c6baac000539a396a5f7925e5e0113fe2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alexandercbooth"}}