{"action":"created","comment":{"url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/comments/198607433","pull_request_review_id":132567687,"id":198607433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODYwNzQzMw==","diff_hunk":"@@ -37,25 +41,30 @@ export default function start(languageRenderers, { routes = [], plugins = [] })\n \tconst baseRoutes = getRoutes();\n \tconst finalRoutes = [...routes, ...baseRoutes];\n \n-\tconst connection = {\n+\tconst serverConfig = {\n \t\thost: '0.0.0.0',\n \t\tport: appConfig.app_server.port,\n-\t\troutes: {\n-\t\t\tplugins: {\n-\t\t\t\t'electrode-csrf-jwt': {\n-\t\t\t\t\tenabled: false,\n-\t\t\t\t},\n-\t\t\t\t'mwp-logger-plugin': {\n-\t\t\t\t\tenabled: true,\n-\t\t\t\t},\n+\n+\t\t// accessed via server.settings.app\n+\t\tapp: appConfig,\n+\n+\t\t// accessed via server.settings.plugins\n+\t\tplugins: {\n+\t\t\t'electrode-csrf-jwt': {\n+\t\t\t\tenabled: false,","path":"packages/mwp-app-server/src/index.js","position":50,"original_position":50,"commit_id":"a664e43a6f6584034e90708f821e2f34438cdf9f","original_commit_id":"b658b906171267bbc6348c5aa88aa53247b2ca6c","user":{"login":"mmcgahan","id":1885153,"node_id":"MDQ6VXNlcjE4ODUxNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1885153?v=4","gravatar_id":"","url":"https://api.github.com/users/mmcgahan","html_url":"https://github.com/mmcgahan","followers_url":"https://api.github.com/users/mmcgahan/followers","following_url":"https://api.github.com/users/mmcgahan/following{/other_user}","gists_url":"https://api.github.com/users/mmcgahan/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcgahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcgahan/subscriptions","organizations_url":"https://api.github.com/users/mmcgahan/orgs","repos_url":"https://api.github.com/users/mmcgahan/repos","events_url":"https://api.github.com/users/mmcgahan/events{/privacy}","received_events_url":"https://api.github.com/users/mmcgahan/received_events","type":"User","site_admin":false},"body":"so that CSRF checking is _off_ by default, and individual routes can opt-in, rather than it being an implicit behavior that routes have to turn _off_","created_at":"2018-06-27T19:02:58Z","updated_at":"2018-06-27T19:02:58Z","html_url":"https://github.com/meetup/meetup-web-platform/pull/503#discussion_r198607433","pull_request_url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/503","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/comments/198607433"},"html":{"href":"https://github.com/meetup/meetup-web-platform/pull/503#discussion_r198607433"},"pull_request":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/503"}},"in_reply_to_id":198573835},"pull_request":{"url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/503","id":195024623,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDI0NjIz","html_url":"https://github.com/meetup/meetup-web-platform/pull/503","diff_url":"https://github.com/meetup/meetup-web-platform/pull/503.diff","patch_url":"https://github.com/meetup/meetup-web-platform/pull/503.patch","issue_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues/503","number":503,"state":"open","locked":false,"title":"[Prelim] Hapi 17","user":{"login":"sadafie","id":1033572,"node_id":"MDQ6VXNlcjEwMzM1NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1033572?v=4","gravatar_id":"","url":"https://api.github.com/users/sadafie","html_url":"https://github.com/sadafie","followers_url":"https://api.github.com/users/sadafie/followers","following_url":"https://api.github.com/users/sadafie/following{/other_user}","gists_url":"https://api.github.com/users/sadafie/gists{/gist_id}","starred_url":"https://api.github.com/users/sadafie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadafie/subscriptions","organizations_url":"https://api.github.com/users/sadafie/orgs","repos_url":"https://api.github.com/users/sadafie/repos","events_url":"https://api.github.com/users/sadafie/events{/privacy}","received_events_url":"https://api.github.com/users/sadafie/received_events","type":"User","site_admin":false},"body":"Just creating this PR for testing purposes. Not a functional upgrade yet.\r\n\r\nDoD:\r\n\r\n- [x] Upgrade dependencies\r\n- [x] Migrate platform code\r\n- [x] Migrate plugin code\r\n- [ ] Fork `electrode-csrf-jwt` plugin for v17\r\n- [x] `yarn build` passes\r\n- [ ] `yarn test` passes (unit tests)\r\n- [x] `yarn flow` passes\r\n- [x] `yarn lint` passes\r\n- [ ] `yarn test:integration` integration tests pass\r\n- [ ] `yarn check` passes\r\n- [ ] Update hapi refs in `mup-web` (favicon?)\r\n- [ ] Update hapi refs in `pro-web`\r\n- [ ] Test `mup-web`\r\n- [ ] Test `pro-web`\r\n- [ ] Bump major version, add release notes for breaking change","created_at":"2018-06-14T21:35:51Z","updated_at":"2018-06-27T19:02:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7a398913a36ea07599782b7c9f68f59150fe723","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/503/commits","review_comments_url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/503/comments","review_comment_url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues/503/comments","statuses_url":"https://api.github.com/repos/meetup/meetup-web-platform/statuses/a664e43a6f6584034e90708f821e2f34438cdf9f","head":{"label":"meetup:MP-670_upgrade_hapi_17","ref":"MP-670_upgrade_hapi_17","sha":"a664e43a6f6584034e90708f821e2f34438cdf9f","user":{"login":"meetup","id":147855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Nzg1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/147855?v=4","gravatar_id":"","url":"https://api.github.com/users/meetup","html_url":"https://github.com/meetup","followers_url":"https://api.github.com/users/meetup/followers","following_url":"https://api.github.com/users/meetup/following{/other_user}","gists_url":"https://api.github.com/users/meetup/gists{/gist_id}","starred_url":"https://api.github.com/users/meetup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetup/subscriptions","organizations_url":"https://api.github.com/users/meetup/orgs","repos_url":"https://api.github.com/users/meetup/repos","events_url":"https://api.github.com/users/meetup/events{/privacy}","received_events_url":"https://api.github.com/users/meetup/received_events","type":"Organization","site_admin":false},"repo":{"id":66412742,"node_id":"MDEwOlJlcG9zaXRvcnk2NjQxMjc0Mg==","name":"meetup-web-platform","full_name":"meetup/meetup-web-platform","owner":{"login":"meetup","id":147855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Nzg1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/147855?v=4","gravatar_id":"","url":"https://api.github.com/users/meetup","html_url":"https://github.com/meetup","followers_url":"https://api.github.com/users/meetup/followers","following_url":"https://api.github.com/users/meetup/following{/other_user}","gists_url":"https://api.github.com/users/meetup/gists{/gist_id}","starred_url":"https://api.github.com/users/meetup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetup/subscriptions","organizations_url":"https://api.github.com/users/meetup/orgs","repos_url":"https://api.github.com/users/meetup/repos","events_url":"https://api.github.com/users/meetup/events{/privacy}","received_events_url":"https://api.github.com/users/meetup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meetup/meetup-web-platform","description":"A collection of Node web application utilities developed for the Meetup web platform","fork":false,"url":"https://api.github.com/repos/meetup/meetup-web-platform","forks_url":"https://api.github.com/repos/meetup/meetup-web-platform/forks","keys_url":"https://api.github.com/repos/meetup/meetup-web-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meetup/meetup-web-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meetup/meetup-web-platform/teams","hooks_url":"https://api.github.com/repos/meetup/meetup-web-platform/hooks","issue_events_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues/events{/number}","events_url":"https://api.github.com/repos/meetup/meetup-web-platform/events","assignees_url":"https://api.github.com/repos/meetup/meetup-web-platform/assignees{/user}","branches_url":"https://api.github.com/repos/meetup/meetup-web-platform/branches{/branch}","tags_url":"https://api.github.com/repos/meetup/meetup-web-platform/tags","blobs_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meetup/meetup-web-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/meetup/meetup-web-platform/languages","stargazers_url":"https://api.github.com/repos/meetup/meetup-web-platform/stargazers","contributors_url":"https://api.github.com/repos/meetup/meetup-web-platform/contributors","subscribers_url":"https://api.github.com/repos/meetup/meetup-web-platform/subscribers","subscription_url":"https://api.github.com/repos/meetup/meetup-web-platform/subscription","commits_url":"https://api.github.com/repos/meetup/meetup-web-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/meetup/meetup-web-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/meetup/meetup-web-platform/contents/{+path}","compare_url":"https://api.github.com/repos/meetup/meetup-web-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meetup/meetup-web-platform/merges","archive_url":"https://api.github.com/repos/meetup/meetup-web-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meetup/meetup-web-platform/downloads","issues_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues{/number}","pulls_url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/meetup/meetup-web-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/meetup/meetup-web-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meetup/meetup-web-platform/labels{/name}","releases_url":"https://api.github.com/repos/meetup/meetup-web-platform/releases{/id}","deployments_url":"https://api.github.com/repos/meetup/meetup-web-platform/deployments","created_at":"2016-08-23T23:59:22Z","updated_at":"2018-06-22T13:51:00Z","pushed_at":"2018-06-27T17:30:13Z","git_url":"git://github.com/meetup/meetup-web-platform.git","ssh_url":"git@github.com:meetup/meetup-web-platform.git","clone_url":"https://github.com/meetup/meetup-web-platform.git","svn_url":"https://github.com/meetup/meetup-web-platform","homepage":null,"size":5913,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":4,"watchers":14,"default_branch":"master"}},"base":{"label":"meetup:master","ref":"master","sha":"9335f473c461414e8f92524dc80181b72d37a295","user":{"login":"meetup","id":147855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Nzg1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/147855?v=4","gravatar_id":"","url":"https://api.github.com/users/meetup","html_url":"https://github.com/meetup","followers_url":"https://api.github.com/users/meetup/followers","following_url":"https://api.github.com/users/meetup/following{/other_user}","gists_url":"https://api.github.com/users/meetup/gists{/gist_id}","starred_url":"https://api.github.com/users/meetup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetup/subscriptions","organizations_url":"https://api.github.com/users/meetup/orgs","repos_url":"https://api.github.com/users/meetup/repos","events_url":"https://api.github.com/users/meetup/events{/privacy}","received_events_url":"https://api.github.com/users/meetup/received_events","type":"Organization","site_admin":false},"repo":{"id":66412742,"node_id":"MDEwOlJlcG9zaXRvcnk2NjQxMjc0Mg==","name":"meetup-web-platform","full_name":"meetup/meetup-web-platform","owner":{"login":"meetup","id":147855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Nzg1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/147855?v=4","gravatar_id":"","url":"https://api.github.com/users/meetup","html_url":"https://github.com/meetup","followers_url":"https://api.github.com/users/meetup/followers","following_url":"https://api.github.com/users/meetup/following{/other_user}","gists_url":"https://api.github.com/users/meetup/gists{/gist_id}","starred_url":"https://api.github.com/users/meetup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetup/subscriptions","organizations_url":"https://api.github.com/users/meetup/orgs","repos_url":"https://api.github.com/users/meetup/repos","events_url":"https://api.github.com/users/meetup/events{/privacy}","received_events_url":"https://api.github.com/users/meetup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meetup/meetup-web-platform","description":"A collection of Node web application utilities developed for the Meetup web platform","fork":false,"url":"https://api.github.com/repos/meetup/meetup-web-platform","forks_url":"https://api.github.com/repos/meetup/meetup-web-platform/forks","keys_url":"https://api.github.com/repos/meetup/meetup-web-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meetup/meetup-web-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meetup/meetup-web-platform/teams","hooks_url":"https://api.github.com/repos/meetup/meetup-web-platform/hooks","issue_events_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues/events{/number}","events_url":"https://api.github.com/repos/meetup/meetup-web-platform/events","assignees_url":"https://api.github.com/repos/meetup/meetup-web-platform/assignees{/user}","branches_url":"https://api.github.com/repos/meetup/meetup-web-platform/branches{/branch}","tags_url":"https://api.github.com/repos/meetup/meetup-web-platform/tags","blobs_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meetup/meetup-web-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/meetup/meetup-web-platform/languages","stargazers_url":"https://api.github.com/repos/meetup/meetup-web-platform/stargazers","contributors_url":"https://api.github.com/repos/meetup/meetup-web-platform/contributors","subscribers_url":"https://api.github.com/repos/meetup/meetup-web-platform/subscribers","subscription_url":"https://api.github.com/repos/meetup/meetup-web-platform/subscription","commits_url":"https://api.github.com/repos/meetup/meetup-web-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/meetup/meetup-web-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/meetup/meetup-web-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/meetup/meetup-web-platform/contents/{+path}","compare_url":"https://api.github.com/repos/meetup/meetup-web-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meetup/meetup-web-platform/merges","archive_url":"https://api.github.com/repos/meetup/meetup-web-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meetup/meetup-web-platform/downloads","issues_url":"https://api.github.com/repos/meetup/meetup-web-platform/issues{/number}","pulls_url":"https://api.github.com/repos/meetup/meetup-web-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/meetup/meetup-web-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/meetup/meetup-web-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meetup/meetup-web-platform/labels{/name}","releases_url":"https://api.github.com/repos/meetup/meetup-web-platform/releases{/id}","deployments_url":"https://api.github.com/repos/meetup/meetup-web-platform/deployments","created_at":"2016-08-23T23:59:22Z","updated_at":"2018-06-22T13:51:00Z","pushed_at":"2018-06-27T17:30:13Z","git_url":"git://github.com/meetup/meetup-web-platform.git","ssh_url":"git@github.com:meetup/meetup-web-platform.git","clone_url":"https://github.com/meetup/meetup-web-platform.git","svn_url":"https://github.com/meetup/meetup-web-platform","homepage":null,"size":5913,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":4,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/503"},"html":{"href":"https://github.com/meetup/meetup-web-platform/pull/503"},"issue":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/issues/503"},"comments":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/issues/503/comments"},"review_comments":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/503/comments"},"review_comment":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/pulls/503/commits"},"statuses":{"href":"https://api.github.com/repos/meetup/meetup-web-platform/statuses/a664e43a6f6584034e90708f821e2f34438cdf9f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mmcgahan"}}