{"push_id":2298379558,"size":7,"distinct_size":2,"ref":"refs/heads/oauth-03-oauthapi","head":"d8ee900266556952fd32b443bbe781bf33a35330","before":"65992da372579a5848cbfcc5945b3657ed5d624b","commits":[{"sha":"b7e091b4f50275bf6b9fdd72bbc9b094fbd20ce6","author":{"name":"Wojciech Trocki","email":"009c34079506d2706fec79840c9cdddd30479dbb@redhat.com"},"message":"Display warning when socat cmd is missing\n\nDisplay warning to users when executing cluster up without `socat` cmd installed","distinct":false,"url":"https://api.github.com/repos/deads2k/origin/commits/b7e091b4f50275bf6b9fdd72bbc9b094fbd20ce6"},{"sha":"508e2ca65b70cbbcb2835977cecb517b521214c4","author":{"name":"David Eads","email":"9eea6a26ae0243814229a46d171002f67ac6168a@redhat.com"},"message":"move oauthserver off of internal user clients","distinct":false,"url":"https://api.github.com/repos/deads2k/origin/commits/508e2ca65b70cbbcb2835977cecb517b521214c4"},{"sha":"754bd6c8c0e1945fc03c15a64a459e6ff1e057a9","author":{"name":"David Eads","email":"9eea6a26ae0243814229a46d171002f67ac6168a@redhat.com"},"message":"move non-oauthserver packages out","distinct":false,"url":"https://api.github.com/repos/deads2k/origin/commits/754bd6c8c0e1945fc03c15a64a459e6ff1e057a9"},{"sha":"69dcbb203101ccff08a79547e8bb42bae61a62e3","author":{"name":"OpenShift Merge Robot","email":"2d4ca0be5be77eda757de39fc2d4a863abc04390@users.noreply.github.com"},"message":"Merge pull request #17942 from wtrocki/oc-up-socat-warning\n\nAutomatic merge from submit-queue (batch tested with PRs 17942, 18370).\n\nDisplay warning when socat cmd is missing\n\n## Motivation\r\n\r\nI have been troubleshooting couple openshift installations done using `oc cluster up` recently and found one common pattern. MacOS users who used `oc cluster up` for the first time almost always experienced problems with reaching running cluster.  Example:\r\n\r\n```\r\ncurl 127.0.0.1:8443\r\ncurl: (7) Failed connect to 127.0.0.1:8442; Connection refused\r\n```\r\n\r\nProblem related with missing or improperly installed `socat` command.\r\nFollowing [documentation](https://github.com/openshift/origin/blob/master/docs/cluster_up_down.md#macos-with-docker-for-mac) is often not enough. Users who install this command using brew may miss some additional libraries and this is really hard to debug and track cause of the issue when looking into logs. Example output:\r\n\r\n```\r\n> socat\r\ndyld: Library not loaded: /usr/local/opt/readline/lib/libreadline.7.dylib\r\n  Referenced from: /usr/local/bin/socat\r\n  Reason: image not found\r\n[1]    13015 abort      socat \r\n```\r\n\r\nProblem is not easy to investigate as currently installer provides no useful message back to the user.\r\n\r\nExample issue that was caused by problem\r\nhttps://github.com/openshift/origin/issues/17931\r\n\r\n## Proposed solution\r\n\r\nValidate if socat is available when executing `oc cluster up` to inform users about possible problems that may occur. Validation will happen only when `PortForwarding` option will be used.\r\n\r\nImplementation using non disruptive aproach - server will still start without `socat` and only warning will be displayed.\r\n\r\n## Dev notes\r\n\r\nChanges will be squashed after review. \r\nTo properly unit test changes I will need to create fake structure for `localcmd` package in order to mock execution of the command. Something like  [wrappers for os/exec](https://github.com/kubernetes/contrib/tree/master/exec-healthz/vendor/k8s.io/kubernetes/pkg/util/exec) in kubernetes dependencies.\r\nI wasn't sure if this is worth doing for such small change.\r\n\r\n## Verification\r\n```\r\nbrew uninstall socat\r\noc cluster up | grep \"Port forwarding requires socat\"\r\n```","distinct":false,"url":"https://api.github.com/repos/deads2k/origin/commits/69dcbb203101ccff08a79547e8bb42bae61a62e3"},{"sha":"3dcad957d493235de16bf47eb0390288e5a9b125","author":{"name":"OpenShift Merge Robot","email":"2d4ca0be5be77eda757de39fc2d4a863abc04390@users.noreply.github.com"},"message":"Merge pull request #18370 from deads2k/oauth-02-apis\n\nAutomatic merge from submit-queue (batch tested with PRs 17942, 18370).\n\nswitch oauthserver to external user client\n\nThis switches the vast majority of calls to external user calls. There's a bad unit test that needs to move, but that is involved.\r\n\r\nI also found some packages that are not used inside of the oauthserver and used instead in the apiserver.\r\n\r\n/assign enj\r\n/assign mfojtik","distinct":false,"url":"https://api.github.com/repos/deads2k/origin/commits/3dcad957d493235de16bf47eb0390288e5a9b125"},{"sha":"92ebabab473896fbecfb5f2c7c942120bb845c41","author":{"name":"David Eads","email":"9eea6a26ae0243814229a46d171002f67ac6168a@redhat.com"},"message":"use external oauth api clients in oauthserver","distinct":true,"url":"https://api.github.com/repos/deads2k/origin/commits/92ebabab473896fbecfb5f2c7c942120bb845c41"},{"sha":"d8ee900266556952fd32b443bbe781bf33a35330","author":{"name":"David Eads","email":"9eea6a26ae0243814229a46d171002f67ac6168a@redhat.com"},"message":"remove oauthserver dependency on k8s.io/kubernetes","distinct":true,"url":"https://api.github.com/repos/deads2k/origin/commits/d8ee900266556952fd32b443bbe781bf33a35330"}]}
{"actor":{"display_login":"deads2k"}}