{"action":"created","issue":{"url":"https://api.github.com/repos/uBlockOrigin/uBlock-issues/issues/337","repository_url":"https://api.github.com/repos/uBlockOrigin/uBlock-issues","labels_url":"https://api.github.com/repos/uBlockOrigin/uBlock-issues/issues/337/labels{/name}","comments_url":"https://api.github.com/repos/uBlockOrigin/uBlock-issues/issues/337/comments","events_url":"https://api.github.com/repos/uBlockOrigin/uBlock-issues/issues/337/events","html_url":"https://github.com/uBlockOrigin/uBlock-issues/issues/337","id":389606129,"node_id":"MDU6SXNzdWUzODk2MDYxMjk=","number":337,"title":"Pull request/RFC for new has-visible-text filter.","user":{"login":"jameshilliard","id":3298484,"node_id":"MDQ6VXNlcjMyOTg0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3298484?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshilliard","html_url":"https://github.com/jameshilliard","followers_url":"https://api.github.com/users/jameshilliard/followers","following_url":"https://api.github.com/users/jameshilliard/following{/other_user}","gists_url":"https://api.github.com/users/jameshilliard/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshilliard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshilliard/subscriptions","organizations_url":"https://api.github.com/users/jameshilliard/orgs","repos_url":"https://api.github.com/users/jameshilliard/repos","events_url":"https://api.github.com/users/jameshilliard/events{/privacy}","received_events_url":"https://api.github.com/users/jameshilliard/received_events","type":"User","site_admin":false},"labels":[{"id":902461560,"node_id":"MDU6TGFiZWw5MDI0NjE1NjA=","url":"https://api.github.com/repos/uBlockOrigin/uBlock-issues/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-11T05:47:35Z","updated_at":"2018-12-13T13:35:17Z","closed_at":"2018-12-13T13:35:17Z","author_association":"NONE","body":"Unsure how to create a pull request as [contributing](https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md) doesn't mention how to do so. I wrote a new filter method designed to break facebook's invisible element obfuscation. See the code I wrote [here](https://github.com/gorhill/uBlock/compare/master...jameshilliard:has-visible-text?expand=1), it's mostly a proof of concept at this stage but seems to work and should be more difficult to break since it tries to operate exclusively on visible text to make it more difficult for facebook to randomize the various selectors currently being used. See issue [here](https://github.com/uBlockOrigin/uAssets/issues/3367) for more details on facebook's obfuscation.\r\n\r\nThis is the test filter I'm using:\r\n```\r\nfacebook.com,facebookcorewwwi.onion##div[id^=\"hyperfeed_story_id_\"]:has(div[id^=\"feed_sub_title_\"]:has-visible-text(Sponsored))\r\n```"},"comment":{"url":"https://api.github.com/repos/uBlockOrigin/uBlock-issues/issues/comments/446970083","html_url":"https://github.com/uBlockOrigin/uBlock-issues/issues/337#issuecomment-446970083","issue_url":"https://api.github.com/repos/uBlockOrigin/uBlock-issues/issues/337","id":446970083,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Njk3MDA4Mw==","user":{"login":"gorhill","id":585534,"node_id":"MDQ6VXNlcjU4NTUzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/585534?v=4","gravatar_id":"","url":"https://api.github.com/users/gorhill","html_url":"https://github.com/gorhill","followers_url":"https://api.github.com/users/gorhill/followers","following_url":"https://api.github.com/users/gorhill/following{/other_user}","gists_url":"https://api.github.com/users/gorhill/gists{/gist_id}","starred_url":"https://api.github.com/users/gorhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorhill/subscriptions","organizations_url":"https://api.github.com/users/gorhill/orgs","repos_url":"https://api.github.com/users/gorhill/repos","events_url":"https://api.github.com/users/gorhill/events{/privacy}","received_events_url":"https://api.github.com/users/gorhill/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T13:35:17Z","updated_at":"2018-12-13T13:35:17Z","author_association":"MEMBER","body":"I am going to decline this: this is a very specific solution to one specific site: Facebook. If Facebook stops using the workaround, that now useless syntax becomes dead code and a burden. Facebook is obviously motivated to workaround whatever we throw at it, so I rather not code into uBO a filter syntax which is useful only _one_ site -- in such case it's best left to a user script or an extension dedicated to deal with Facebook."}}
{"actor":{"display_login":"gorhill"}}