{"action":"created","issue":{"url":"https://api.github.com/repos/atom/github/issues/1701","repository_url":"https://api.github.com/repos/atom/github","labels_url":"https://api.github.com/repos/atom/github/issues/1701/labels{/name}","comments_url":"https://api.github.com/repos/atom/github/issues/1701/comments","events_url":"https://api.github.com/repos/atom/github/issues/1701/events","html_url":"https://github.com/atom/github/issues/1701","id":362972026,"node_id":"MDU6SXNzdWUzNjI5NzIwMjY=","number":1701,"title":"The merged commit text on a PR is squished together","user":{"login":"mattr-","id":77174,"node_id":"MDQ6VXNlcjc3MTc0","avatar_url":"https://avatars2.githubusercontent.com/u/77174?v=4","gravatar_id":"","url":"https://api.github.com/users/mattr-","html_url":"https://github.com/mattr-","followers_url":"https://api.github.com/users/mattr-/followers","following_url":"https://api.github.com/users/mattr-/following{/other_user}","gists_url":"https://api.github.com/users/mattr-/gists{/gist_id}","starred_url":"https://api.github.com/users/mattr-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattr-/subscriptions","organizations_url":"https://api.github.com/users/mattr-/orgs","repos_url":"https://api.github.com/users/mattr-/repos","events_url":"https://api.github.com/users/mattr-/events{/privacy}","received_events_url":"https://api.github.com/users/mattr-/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-23T19:53:11Z","updated_at":"2018-09-24T22:35:46Z","closed_at":null,"author_association":"NONE","body":"### Description\r\n\r\nAfter merging a PR, the merge commit is text is squished together, as seen in the actual behavior section of this issue.\r\n\r\n### Steps to Reproduce\r\n\r\n1. Add the [tracks repo](https://github.com/TracksApp/tracks) - it's public - as a project folder to atom\r\n1. Open `test/controllers/search_controller_test.rb` with Cmd-T\r\n1. Open the GitHub tab (Ctrl-Shift-8)\r\n1. Select PR 2117 from the list of pull requests to open the PR view\r\n1. Scroll down to the section of the pane that contains the merge indication\r\n\r\n**Expected behavior:**\r\n\r\nExpected the text to be `merged commit` as in this doctored screenshot:\r\n![doctored screenshot expected behavior](https://user-images.githubusercontent.com/77174/45932212-9e544300-bf3e-11e8-95f1-d463e7c88259.png)\r\n\r\n**Actual behavior:**\r\n\r\n![screenshot of actual behavior](https://user-images.githubusercontent.com/77174/45932144-93e57980-bf3d-11e8-9ca1-f775bf85a90d.png)\r\n\r\nthe text `mergedcommit` is squished together rather than being displayed as `merged commit`\r\n\r\n**Reproduces how often:**\r\n\r\nAlways.\r\n\r\n### Versions\r\n\r\nRunning on OS X 10.13.6\r\n\r\n![atom-github package version screenshot](https://user-images.githubusercontent.com/77174/45932245-233f5c80-bf3f-11e8-878c-8eb089d03664.png)\r\n\r\n```\r\n$ atom --version\r\napmAtom    : 1.30.0\r\nElectron: 2.0.5\r\nChrome  : 61.0.3163.100\r\nNode    : 8.9.3\r\n```\r\n\r\n```\r\n$ apm --version\r\napm  1.19.0\r\nnpm  3.10.10\r\nnode 6.9.5 x64\r\natom 1.30.0\r\npython 2.7.15\r\ngit 2.18.0\r\n```\r\n\r\n### Additional Information\r\n\r\nI looked into the code for this briefly, and it looks like the UI in question is rendered here:\r\nhttps://github.com/atom/github/blob/10d4dd2b1e5bf12cc092ab0fdc7b44ddf5f6b6d2/lib/views/timeline-items/merged-event-view.js#L30-L32\r\n\r\nI'm not familiar enough with React to know how to handle this particular situation but would be happy to follow guidance or pair with someone on a fix. 🙂 \r\n\r\nThanks for your attention! :heart:\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/atom/github/issues/comments/424148043","html_url":"https://github.com/atom/github/issues/1701#issuecomment-424148043","issue_url":"https://api.github.com/repos/atom/github/issues/1701","id":424148043,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDE0ODA0Mw==","user":{"login":"rsese","id":734194,"node_id":"MDQ6VXNlcjczNDE5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/734194?v=4","gravatar_id":"","url":"https://api.github.com/users/rsese","html_url":"https://github.com/rsese","followers_url":"https://api.github.com/users/rsese/followers","following_url":"https://api.github.com/users/rsese/following{/other_user}","gists_url":"https://api.github.com/users/rsese/gists{/gist_id}","starred_url":"https://api.github.com/users/rsese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsese/subscriptions","organizations_url":"https://api.github.com/users/rsese/orgs","repos_url":"https://api.github.com/users/rsese/repos","events_url":"https://api.github.com/users/rsese/events{/privacy}","received_events_url":"https://api.github.com/users/rsese/received_events","type":"User","site_admin":true},"created_at":"2018-09-24T22:35:46Z","updated_at":"2018-09-24T22:35:46Z","author_association":"MEMBER","body":"Thanks @mattr- :v:  Just dropping into to mention I can reproduce on macOS 10.12.6 and 1.33.0-nightly0."}}
{"actor":{"display_login":"rsese"}}