{"action":"created","comment":{"url":"https://api.github.com/repos/Linaro/odp/pulls/comments/180408561","pull_request_review_id":110821001,"id":180408561,"diff_hunk":"@@ -31,6 +31,19 @@ pktio_dpdk: {\n \t}\n }\n \n+# netmap pktio options\n+pktio_netmap: {\n+\t# Default options\n+\tnr_rx_slots = 0\n+\tnr_tx_slots = 0\n+\n+\t# Interface specific options\n+\teth0: {\n+\t\tnr_rx_slots = 0\n+\t\tnr_tx_slots = 0\n+\t}","path":"config/odp-linux-generic.conf","position":14,"original_position":14,"commit_id":"37f4ca84304eb2e4e7ee1e0724cf1fdec57b23c0","original_commit_id":"37f4ca84304eb2e4e7ee1e0724cf1fdec57b23c0","user":{"login":"matiaselo","id":1427501,"avatar_url":"https://avatars1.githubusercontent.com/u/1427501?v=4","gravatar_id":"","url":"https://api.github.com/users/matiaselo","html_url":"https://github.com/matiaselo","followers_url":"https://api.github.com/users/matiaselo/followers","following_url":"https://api.github.com/users/matiaselo/following{/other_user}","gists_url":"https://api.github.com/users/matiaselo/gists{/gist_id}","starred_url":"https://api.github.com/users/matiaselo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matiaselo/subscriptions","organizations_url":"https://api.github.com/users/matiaselo/orgs","repos_url":"https://api.github.com/users/matiaselo/repos","events_url":"https://api.github.com/users/matiaselo/events{/privacy}","received_events_url":"https://api.github.com/users/matiaselo/received_events","type":"User","site_admin":false},"body":"Since these options are only significant for virtual interfaces I would simplify the config and make it clear that these options are only relevant for virtual interfaces. It's probably enough to have a single value for all virtual interfaces, so the interface specific options are not needed.\r\n\r\nE.g.\r\n```\r\npktio_netmap: {\r\n\tvirt: {\r\n\t\tnr_rx_slots = 0\r\n\t\tnr_tx_slots = 0\r\n\t}\r\n}\r\n```\r\n\r\n\r\n\r\n ","created_at":"2018-04-10T12:53:42Z","updated_at":"2018-04-10T12:53:43Z","html_url":"https://github.com/Linaro/odp/pull/516#discussion_r180408561","pull_request_url":"https://api.github.com/repos/Linaro/odp/pulls/516","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments/180408561"},"html":{"href":"https://github.com/Linaro/odp/pull/516#discussion_r180408561"},"pull_request":{"href":"https://api.github.com/repos/Linaro/odp/pulls/516"}}},"pull_request":{"url":"https://api.github.com/repos/Linaro/odp/pulls/516","id":174064386,"html_url":"https://github.com/Linaro/odp/pull/516","diff_url":"https://github.com/Linaro/odp/pull/516.diff","patch_url":"https://github.com/Linaro/odp/pull/516.patch","issue_url":"https://api.github.com/repos/Linaro/odp/issues/516","number":516,"state":"open","locked":false,"title":"[PATCH v4] linux-gen: netmap: optimal ring configuration for VALE","user":{"login":"jmtilli","id":5920982,"avatar_url":"https://avatars3.githubusercontent.com/u/5920982?v=4","gravatar_id":"","url":"https://api.github.com/users/jmtilli","html_url":"https://github.com/jmtilli","followers_url":"https://api.github.com/users/jmtilli/followers","following_url":"https://api.github.com/users/jmtilli/following{/other_user}","gists_url":"https://api.github.com/users/jmtilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtilli/subscriptions","organizations_url":"https://api.github.com/users/jmtilli/orgs","repos_url":"https://api.github.com/users/jmtilli/repos","events_url":"https://api.github.com/users/jmtilli/events{/privacy}","received_events_url":"https://api.github.com/users/jmtilli/received_events","type":"User","site_admin":false},"body":"Configure ring optimally for VALE. On my test laptop, this increases\r\nodp_l2fwd performance from 1.9 MPPS to 2.3 MPPS, so it gives over 20%\r\nmore performance.\r\n\r\nSigned-off-by: Juha-Matti Tilli <juha-matti.tilli@iki.fi>","created_at":"2018-03-09T17:34:09Z","updated_at":"2018-04-10T12:53:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43bddf0721c984b847546e6a92355a942f3ceca2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":577854052,"url":"https://api.github.com/repos/Linaro/odp/labels/Email_sent","name":"Email_sent","color":"ededed","default":false},{"id":666131932,"url":"https://api.github.com/repos/Linaro/odp/labels/checkpatch","name":"checkpatch","color":"0000ff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Linaro/odp/pulls/516/commits","review_comments_url":"https://api.github.com/repos/Linaro/odp/pulls/516/comments","review_comment_url":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Linaro/odp/issues/516/comments","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/37f4ca84304eb2e4e7ee1e0724cf1fdec57b23c0","head":{"label":"jmtilli:valeringconfig","ref":"valeringconfig","sha":"37f4ca84304eb2e4e7ee1e0724cf1fdec57b23c0","user":{"login":"jmtilli","id":5920982,"avatar_url":"https://avatars3.githubusercontent.com/u/5920982?v=4","gravatar_id":"","url":"https://api.github.com/users/jmtilli","html_url":"https://github.com/jmtilli","followers_url":"https://api.github.com/users/jmtilli/followers","following_url":"https://api.github.com/users/jmtilli/following{/other_user}","gists_url":"https://api.github.com/users/jmtilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtilli/subscriptions","organizations_url":"https://api.github.com/users/jmtilli/orgs","repos_url":"https://api.github.com/users/jmtilli/repos","events_url":"https://api.github.com/users/jmtilli/events{/privacy}","received_events_url":"https://api.github.com/users/jmtilli/received_events","type":"User","site_admin":false},"repo":{"id":114168997,"name":"odp","full_name":"jmtilli/odp","owner":{"login":"jmtilli","id":5920982,"avatar_url":"https://avatars3.githubusercontent.com/u/5920982?v=4","gravatar_id":"","url":"https://api.github.com/users/jmtilli","html_url":"https://github.com/jmtilli","followers_url":"https://api.github.com/users/jmtilli/followers","following_url":"https://api.github.com/users/jmtilli/following{/other_user}","gists_url":"https://api.github.com/users/jmtilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtilli/subscriptions","organizations_url":"https://api.github.com/users/jmtilli/orgs","repos_url":"https://api.github.com/users/jmtilli/repos","events_url":"https://api.github.com/users/jmtilli/events{/privacy}","received_events_url":"https://api.github.com/users/jmtilli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmtilli/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":true,"url":"https://api.github.com/repos/jmtilli/odp","forks_url":"https://api.github.com/repos/jmtilli/odp/forks","keys_url":"https://api.github.com/repos/jmtilli/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmtilli/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmtilli/odp/teams","hooks_url":"https://api.github.com/repos/jmtilli/odp/hooks","issue_events_url":"https://api.github.com/repos/jmtilli/odp/issues/events{/number}","events_url":"https://api.github.com/repos/jmtilli/odp/events","assignees_url":"https://api.github.com/repos/jmtilli/odp/assignees{/user}","branches_url":"https://api.github.com/repos/jmtilli/odp/branches{/branch}","tags_url":"https://api.github.com/repos/jmtilli/odp/tags","blobs_url":"https://api.github.com/repos/jmtilli/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmtilli/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmtilli/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmtilli/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmtilli/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/jmtilli/odp/languages","stargazers_url":"https://api.github.com/repos/jmtilli/odp/stargazers","contributors_url":"https://api.github.com/repos/jmtilli/odp/contributors","subscribers_url":"https://api.github.com/repos/jmtilli/odp/subscribers","subscription_url":"https://api.github.com/repos/jmtilli/odp/subscription","commits_url":"https://api.github.com/repos/jmtilli/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmtilli/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmtilli/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmtilli/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmtilli/odp/contents/{+path}","compare_url":"https://api.github.com/repos/jmtilli/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmtilli/odp/merges","archive_url":"https://api.github.com/repos/jmtilli/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmtilli/odp/downloads","issues_url":"https://api.github.com/repos/jmtilli/odp/issues{/number}","pulls_url":"https://api.github.com/repos/jmtilli/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/jmtilli/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/jmtilli/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmtilli/odp/labels{/name}","releases_url":"https://api.github.com/repos/jmtilli/odp/releases{/id}","deployments_url":"https://api.github.com/repos/jmtilli/odp/deployments","created_at":"2017-12-13T21:07:49Z","updated_at":"2017-12-13T21:07:52Z","pushed_at":"2018-04-10T03:55:02Z","git_url":"git://github.com/jmtilli/odp.git","ssh_url":"git@github.com:jmtilli/odp.git","clone_url":"https://github.com/jmtilli/odp.git","svn_url":"https://github.com/jmtilli/odp","homepage":"http://www.opendataplane.org/","size":11037,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Linaro:master","ref":"master","sha":"654507c6eeed83dd84210f7e481ded34f5d4cdca","user":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"repo":{"id":79130215,"name":"odp","full_name":"Linaro/odp","owner":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Linaro/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":false,"url":"https://api.github.com/repos/Linaro/odp","forks_url":"https://api.github.com/repos/Linaro/odp/forks","keys_url":"https://api.github.com/repos/Linaro/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Linaro/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Linaro/odp/teams","hooks_url":"https://api.github.com/repos/Linaro/odp/hooks","issue_events_url":"https://api.github.com/repos/Linaro/odp/issues/events{/number}","events_url":"https://api.github.com/repos/Linaro/odp/events","assignees_url":"https://api.github.com/repos/Linaro/odp/assignees{/user}","branches_url":"https://api.github.com/repos/Linaro/odp/branches{/branch}","tags_url":"https://api.github.com/repos/Linaro/odp/tags","blobs_url":"https://api.github.com/repos/Linaro/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Linaro/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Linaro/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Linaro/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/Linaro/odp/languages","stargazers_url":"https://api.github.com/repos/Linaro/odp/stargazers","contributors_url":"https://api.github.com/repos/Linaro/odp/contributors","subscribers_url":"https://api.github.com/repos/Linaro/odp/subscribers","subscription_url":"https://api.github.com/repos/Linaro/odp/subscription","commits_url":"https://api.github.com/repos/Linaro/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Linaro/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Linaro/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Linaro/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Linaro/odp/contents/{+path}","compare_url":"https://api.github.com/repos/Linaro/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Linaro/odp/merges","archive_url":"https://api.github.com/repos/Linaro/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Linaro/odp/downloads","issues_url":"https://api.github.com/repos/Linaro/odp/issues{/number}","pulls_url":"https://api.github.com/repos/Linaro/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/Linaro/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/Linaro/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Linaro/odp/labels{/name}","releases_url":"https://api.github.com/repos/Linaro/odp/releases{/id}","deployments_url":"https://api.github.com/repos/Linaro/odp/deployments","created_at":"2017-01-16T15:11:12Z","updated_at":"2018-04-09T18:35:23Z","pushed_at":"2018-04-10T12:08:39Z","git_url":"git://github.com/Linaro/odp.git","ssh_url":"git@github.com:Linaro/odp.git","clone_url":"https://github.com/Linaro/odp.git","svn_url":"https://github.com/Linaro/odp","homepage":"http://www.opendataplane.org/","size":10985,"stargazers_count":43,"watchers_count":43,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":49,"open_issues":18,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/516"},"html":{"href":"https://github.com/Linaro/odp/pull/516"},"issue":{"href":"https://api.github.com/repos/Linaro/odp/issues/516"},"comments":{"href":"https://api.github.com/repos/Linaro/odp/issues/516/comments"},"review_comments":{"href":"https://api.github.com/repos/Linaro/odp/pulls/516/comments"},"review_comment":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Linaro/odp/pulls/516/commits"},"statuses":{"href":"https://api.github.com/repos/Linaro/odp/statuses/37f4ca84304eb2e4e7ee1e0724cf1fdec57b23c0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"matiaselo"}}