{"action":"created","issue":{"url":"https://api.github.com/repos/opengisch/QField/issues/268","repository_url":"https://api.github.com/repos/opengisch/QField","labels_url":"https://api.github.com/repos/opengisch/QField/issues/268/labels{/name}","comments_url":"https://api.github.com/repos/opengisch/QField/issues/268/comments","events_url":"https://api.github.com/repos/opengisch/QField/issues/268/events","html_url":"https://github.com/opengisch/QField/issues/268","id":315896742,"node_id":"MDU6SXNzdWUzMTU4OTY3NDI=","number":268,"title":"Save/Cancel options","user":{"login":"signedav","id":28384354,"node_id":"MDQ6VXNlcjI4Mzg0MzU0","avatar_url":"https://avatars1.githubusercontent.com/u/28384354?v=4","gravatar_id":"","url":"https://api.github.com/users/signedav","html_url":"https://github.com/signedav","followers_url":"https://api.github.com/users/signedav/followers","following_url":"https://api.github.com/users/signedav/following{/other_user}","gists_url":"https://api.github.com/users/signedav/gists{/gist_id}","starred_url":"https://api.github.com/users/signedav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signedav/subscriptions","organizations_url":"https://api.github.com/users/signedav/orgs","repos_url":"https://api.github.com/users/signedav/repos","events_url":"https://api.github.com/users/signedav/events{/privacy}","received_events_url":"https://api.github.com/users/signedav/received_events","type":"User","site_admin":false},"labels":[{"id":151668771,"node_id":"MDU6TGFiZWwxNTE2Njg3NzE=","url":"https://api.github.com/repos/opengisch/QField/labels/bug","name":"bug","color":"fc2929","default":true},{"id":151668773,"node_id":"MDU6TGFiZWwxNTE2Njg3NzM=","url":"https://api.github.com/repos/opengisch/QField/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":151668776,"node_id":"MDU6TGFiZWwxNTE2Njg3NzY=","url":"https://api.github.com/repos/opengisch/QField/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":{"login":"signedav","id":28384354,"node_id":"MDQ6VXNlcjI4Mzg0MzU0","avatar_url":"https://avatars1.githubusercontent.com/u/28384354?v=4","gravatar_id":"","url":"https://api.github.com/users/signedav","html_url":"https://github.com/signedav","followers_url":"https://api.github.com/users/signedav/followers","following_url":"https://api.github.com/users/signedav/following{/other_user}","gists_url":"https://api.github.com/users/signedav/gists{/gist_id}","starred_url":"https://api.github.com/users/signedav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signedav/subscriptions","organizations_url":"https://api.github.com/users/signedav/orgs","repos_url":"https://api.github.com/users/signedav/repos","events_url":"https://api.github.com/users/signedav/events{/privacy}","received_events_url":"https://api.github.com/users/signedav/received_events","type":"User","site_admin":false},"assignees":[{"login":"signedav","id":28384354,"node_id":"MDQ6VXNlcjI4Mzg0MzU0","avatar_url":"https://avatars1.githubusercontent.com/u/28384354?v=4","gravatar_id":"","url":"https://api.github.com/users/signedav","html_url":"https://github.com/signedav","followers_url":"https://api.github.com/users/signedav/followers","following_url":"https://api.github.com/users/signedav/following{/other_user}","gists_url":"https://api.github.com/users/signedav/gists{/gist_id}","starred_url":"https://api.github.com/users/signedav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signedav/subscriptions","organizations_url":"https://api.github.com/users/signedav/orgs","repos_url":"https://api.github.com/users/signedav/repos","events_url":"https://api.github.com/users/signedav/events{/privacy}","received_events_url":"https://api.github.com/users/signedav/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2018-04-19T14:14:10Z","updated_at":"2018-08-13T13:38:38Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"With the Save and Canceling of **Settings** and after **editing features** there appeared some problems I don't know since when. Anyway I think we should think about it in general. Since we will have a solid focus-handling we could use sometimes the back-key instead of cancel.\r\n\r\nSave and Cancel is used in the following situations:\r\n- Settings\r\n- Edit Feature\r\n- Add Feature \r\n\r\n### Settings\r\n![01_qfield_settings](https://user-images.githubusercontent.com/28384354/38996469-8f5e300a-43eb-11e8-8e4e-d1869ae0fcde.gif)\r\n**Problem:**\r\nIt doesn't matter if I click Save or Cancel or back-key. It's saved anyway.\r\n**Suggestion:**\r\nRemove the option Save/Cancel and let it be saved always on closing (with back-key). IMHO the UX is, that it's saved then. Anyway I don't really know apps where we use Save/Close on settings...\r\n\r\n### Edit Feature\r\n![02_qfield_featureedit](https://user-images.githubusercontent.com/28384354/38996635-e6ece14a-43eb-11e8-8adf-53c2598085a8.gif)\r\n**Problem:**\r\nIt doesn't matter if I click Save or Cancel or back-key. It's saved anyway.\r\n**Suggestion:**\r\nI see three sollutions:\r\n1. Fix it. Then it will be saved on Save and not saved on Cancel or back-key.\r\n2. Remove Cancel. Then we have Save for save and back-key for cancel (because I suppose that a user anyway never uses cancel but back-key instead)\r\n3. Remove Cancel and Save. Then it will be always saved when closing (pressing back-key)\r\n\r\n### Add Feature\r\n![03_qfield_digitize](https://user-images.githubusercontent.com/28384354/38996789-39ebc4ec-43ec-11e8-9ea7-0c612d132c9a.gif)\r\n**Problem:**\r\nNo problem. This works like expected.\r\n**Suggestion:**\r\nI would make it like the Edit Feature. Means if we remove any Save/Cancel option, I would remove it here as well.\r\n\r\nWhat do you think @m-kuhn @3nids @mbernasocchi ?\r\n\r\nI suppose it's a small thing to do that. And I propose to do it before 1.0."},"comment":{"url":"https://api.github.com/repos/opengisch/QField/issues/comments/412521001","html_url":"https://github.com/opengisch/QField/issues/268#issuecomment-412521001","issue_url":"https://api.github.com/repos/opengisch/QField/issues/268","id":412521001,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjUyMTAwMQ==","user":{"login":"mbernasocchi","id":233663,"node_id":"MDQ6VXNlcjIzMzY2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/233663?v=4","gravatar_id":"","url":"https://api.github.com/users/mbernasocchi","html_url":"https://github.com/mbernasocchi","followers_url":"https://api.github.com/users/mbernasocchi/followers","following_url":"https://api.github.com/users/mbernasocchi/following{/other_user}","gists_url":"https://api.github.com/users/mbernasocchi/gists{/gist_id}","starred_url":"https://api.github.com/users/mbernasocchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbernasocchi/subscriptions","organizations_url":"https://api.github.com/users/mbernasocchi/orgs","repos_url":"https://api.github.com/users/mbernasocchi/repos","events_url":"https://api.github.com/users/mbernasocchi/events{/privacy}","received_events_url":"https://api.github.com/users/mbernasocchi/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T13:38:38Z","updated_at":"2018-08-13T13:38:38Z","author_association":"MEMBER","body":"+1"}}
{"actor":{"display_login":"mbernasocchi"}}