{"push_id":2528845896,"size":17,"distinct_size":17,"ref":"refs/heads/master","head":"4093796f57dbe6ecdcd843b67e265b1ad6c43239","before":"17c664bae975af142401907ba9db746d81d07919","commits":[{"sha":"36034a69afaa0b9de05e077a08ecf927fc614ab4","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Issue #293\n\n- Added serializeToDb and serializeFromDb functions in attrib_serializers.cpp and .h\n- In Struct GameAccountResponseCharacterData, added a serialized version of m_current_attribs\n- In Character.cpp, m_current_attribs are now serialized to and from db","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/36034a69afaa0b9de05e077a08ecf927fc614ab4"},{"sha":"6641f091e8dc0f0888da8ea9d3af85d1d65ebc04","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Merge remote-tracking branch 'upstream/master'","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/6641f091e8dc0f0888da8ea9d3af85d1d65ebc04"},{"sha":"95c95237bfe6dcea22e85ac580420f373e0b6477","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Issue #293\n\n- Fixed the mess I created for myself with merging wrongly, lol\n- Struct CharacterData now has m_current_attribs\n- SerializeFrom/ToDb for m_current_attribs now part of serializeFromQString(cd, src.m_serialized_chardata) because m_current_attribs is now part of CharacterData\n\nBelow changes made by own guesses and likely need fixing\n- Removed m_HitPoints and m_Endurance because those are part of m_current_attribs, which in turn is part of m_serialized_chardata\n- In GameDBSyncContext.cpp, removed lines that reference character.m_HitPoints and character.m_Endurance","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/95c95237bfe6dcea22e85ac580420f373e0b6477"},{"sha":"7e9f0d609f1b4572fb9e8e7a74f6b37708f63c5b","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Issue #304\n\nCTRL+H \"QString &\" to \"const QString &\" in SlashCommand\n\nRemoved some headers from Character.cpp as they are no longer needed (Was more fixing my botched merge probably)","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/7e9f0d609f1b4572fb9e8e7a74f6b37708f63c5b"},{"sha":"ce813d1a2d20852ae63a52d09a1b9a5d4cda38d7","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Merge remote-tracking branch 'upstream/master'","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/ce813d1a2d20852ae63a52d09a1b9a5d4cda38d7"},{"sha":"2e0b776127913b12d2ef4c26aa5567b8d09b0dc0","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Merge remote-tracking branch 'upstream/master'","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/2e0b776127913b12d2ef4c26aa5567b8d09b0dc0"},{"sha":"a6685235e3a284b9efee2a0e6516d738feba5c29","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Colors.h\n\n- Gave names to the struct so that they're not anonymous. Code becomes more standard (eg: rgba.a instead of just a)\n\nDataStorage.cpp\n\n- Changed sz from int to size_t. The value seems to be from filesize which is impossible to be 0. In the return part, it is compared with unsigned int (read_end - read_start), so this prevents the unsigned-signed warning.\n\nentitydata_serializers.cpp and gui_serializers.cpp\n\n- Removed ';' in CEREAL_CLASS_VERSION lines to prevent -Wpedantic error\n\nnpc_definitions.h\n\n- Changed idx from size_t (Afaik array/vector/etc indexes is impossible to be 0...)\n\nAuthServer/main.cpp\n\n- Logged reason for shutdown\n\nGameDBSyncEvents.h\n\n- Changed m_current_costume idx from int to size_t\n- Removed if condition that checks if m_current_costume_idx >= 0\n\nGameEvents.cpp\n\n- Changed i in the for loop from size_t to i\n\nGameHandler.cpp\n\n- Commented out un-used variable\n\nGameServer.cpp\n\n- Commented out un-used ACE variables\n\nEntityStorage.cpp\n\n- Commented out currently un-used is_incremental\n\nEntityUpdateCodec.cpp\n\n- Commented out unused variables (Those entities are definitely going to be used once the actual functions are done tho)\n\nMapInstance.cpp\n\n- Commented out unused variables\n\nMapServerData.cpp\n\n- Casted m_blah.size() to int\n- Should we instead cast level to unsigned int instead? In most games levels are always positive but idk about this game\n\nNetCommandManager.cpp\n\n- Commented out currently-unused commands2\n\nWorldSimulation.cpp\n\n- Don't need to declare float anymore when writing 1.0f (emphasis on the f)\n- Commented out vel_scale which is currently unused\n\nbitfield.inl\n\n(Could be a huge minefield created out of this)\n\n- Removed the 'useless' typecastings to glm::uint64 where warnings are given","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/a6685235e3a284b9efee2a0e6516d738feba5c29"},{"sha":"f0f313c2c95ed4b50bd5157c4ec797638d15e8b3","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Some fixes from last commit\n\n- qCDebug(logInput) in AuthServer/main is now qDebug()\n- Handled 1 more compiler warning","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/f0f313c2c95ed4b50bd5157c4ec797638d15e8b3"},{"sha":"d0c7c989bd6e90f9ce99482dfb77fe66d62b8263","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Reverted changes made to bitfield.inl by nem's request","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/d0c7c989bd6e90f9ce99482dfb77fe66d62b8263"},{"sha":"8a6dba6aaa5ee937ba45549fd7e3fd387f3a0c95","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Merge remote-tracking branch 'upstream/master'","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/8a6dba6aaa5ee937ba45549fd7e3fd387f3a0c95"},{"sha":"3edda40e5c482665d910bd5ff907158e93266a95","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Issue #293 and #352\n\nIssue #293\n\n- Added archive for m_current_attribs in chardata_serializers.cpp\n- Removed Character.m_current_attribs because we should be using Character.m_char_data.m_current_attribs now\n- Adjusted code that used Character.m_current_attribs to used Character.m_char_data.m_current_attribs\n\nSuggestion: Make m_max_attribs as part of CharacterData as well\n\nIssue #352\n\n- Commented out currently unused variables in InputState.cpp\n- Removed useless casting of commands.size() to uint32_t in NetCommandManager.cpp\n- Changed Team.m_team_leader_idx from int to uint32_t to remove compare warnings (also to make the type match the other variables inside the class)\n- Changed id_to_find from int to uint32_t in Team.cpp","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/3edda40e5c482665d910bd5ff907158e93266a95"},{"sha":"a16d6e4a36848fd3654e8de4e483b0e1538612b0","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Merge remote-tracking branch 'upstream/master'\n\n# Conflicts:\n#\tProjects/CoX/Common/GameData/attrib_serializers.cpp\n#\tProjects/CoX/Servers/GameServer/GameHandler.cpp\n#\tProjects/CoX/Servers/MapServer/EntityUpdateCodec.cpp\n#\tProjects/CoX/Servers/MapServer/MapInstance.cpp\n#\tProjects/CoX/Servers/MapServer/NetCommandManager.cpp\n#\tProjects/CoX/Servers/MapServer/SlashCommand.cpp","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/a16d6e4a36848fd3654e8de4e483b0e1538612b0"},{"sha":"50468dc8cd177623e351fb22d4a5a3b403927a76","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"#Issue 293\n\nIncremented CharacterData.class_version in chardata_definitions.h so that cereal throws a critical error instead of crashing the authserver\n\nIssue #352\n\nRemoved unused codes in MapInstance.cpp and changed size_t into uint32_t because size_t works differently between 32bit and 64bit systems","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/50468dc8cd177623e351fb22d4a5a3b403927a76"},{"sha":"62f441d8bca5fdd9f4574968fc76e8db0f8176b0","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Merge remote-tracking branch 'upstream/master'\n\n# Conflicts:\n#\tProjects/CoX/Servers/MapServer/SlashCommand.cpp\n#\tProjects/CoX/Servers/MapServer/WorldSimulation.cpp","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/62f441d8bca5fdd9f4574968fc76e8db0f8176b0"},{"sha":"fa357acfaeb5fbc0c5e98b210f8ba8a93b01e1d9","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"Doxy comment on attrib_serializers.cpp","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/fa357acfaeb5fbc0c5e98b210f8ba8a93b01e1d9"},{"sha":"cd3b5bbe5ac8b128bbfec06c4147273d61c44068","author":{"name":"eos428","email":"22b2b0d5e06f24055d228ccc2921aaa7e0073d90@gmail.com"},"message":"doxy comment on SlashCommand.cpp","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/cd3b5bbe5ac8b128bbfec06c4147273d61c44068"},{"sha":"4093796f57dbe6ecdcd843b67e265b1ad6c43239","author":{"name":"broxen","email":"a027184a55211cd23e3f3094f1fdc728df5e0500@broxen.net"},"message":"Merge pull request #354 from eos428/master\n\nFantastic PR @eos428 !!! :fireworks: :trophy: \r\n\r\nThis is really great eoS! Well done!\r\n\r\n- Closes Issue #293 (Serializing m_current_attribs)\r\n- Closes Issue #304 (Replacing slashCommand string parameters with const)\r\n- Closes Issue #352 (Handling Compiler Warnings)","distinct":true,"url":"https://api.github.com/repos/Segs/Segs/commits/4093796f57dbe6ecdcd843b67e265b1ad6c43239"}]}
{"actor":{"display_login":"broxen"}}