{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/174302717","pull_request_review_id":103634539,"id":174302717,"diff_hunk":"@@ -1071,6 +1072,66 @@ object PushPredicateThroughJoin extends Rule[LogicalPlan] with PredicateHelper {\n   }\n }\n \n+/**\n+ * Infer and transit predicate from the preserved side to the null-supplying side\n+ * of an outer join. The predicate is inferred from the preserved side based on the\n+ * join condition and will be pushed over to the null-supplying side. For example,\n+ * if the preserved side has constraints of the form 'a > 5' and the join condition\n+ * is 'a = b', in which 'b' is an attribute from the null-supplying side, a [[Filter]]\n+ * operator of 'b > 5' will be applied to the null-supplying side.","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala","position":18,"original_position":18,"commit_id":"ac17976fd2b024039ee6cd848b864d2d052ec573","original_commit_id":"ac17976fd2b024039ee6cd848b864d2d052ec573","user":{"login":"gatorsmile","id":11567269,"avatar_url":"https://avatars1.githubusercontent.com/u/11567269?v=4","gravatar_id":"","url":"https://api.github.com/users/gatorsmile","html_url":"https://github.com/gatorsmile","followers_url":"https://api.github.com/users/gatorsmile/followers","following_url":"https://api.github.com/users/gatorsmile/following{/other_user}","gists_url":"https://api.github.com/users/gatorsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gatorsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatorsmile/subscriptions","organizations_url":"https://api.github.com/users/gatorsmile/orgs","repos_url":"https://api.github.com/users/gatorsmile/repos","events_url":"https://api.github.com/users/gatorsmile/events{/privacy}","received_events_url":"https://api.github.com/users/gatorsmile/received_events","type":"User","site_admin":false},"body":"I am fine about the rule, but we do not need a new rule. ","created_at":"2018-03-13T22:17:31Z","updated_at":"2018-03-13T22:17:31Z","html_url":"https://github.com/apache/spark/pull/20816#discussion_r174302717","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/20816","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/174302717"},"html":{"href":"https://github.com/apache/spark/pull/20816#discussion_r174302717"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/20816"}},"in_reply_to_id":174299321},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/20816","id":174796694,"html_url":"https://github.com/apache/spark/pull/20816","diff_url":"https://github.com/apache/spark/pull/20816.diff","patch_url":"https://github.com/apache/spark/pull/20816.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/20816","number":20816,"state":"open","locked":false,"title":"SPARK-21479 Outer join filter pushdown in null supplying table when condition is on one of the joined columns","user":{"login":"maryannxue","id":4171904,"avatar_url":"https://avatars3.githubusercontent.com/u/4171904?v=4","gravatar_id":"","url":"https://api.github.com/users/maryannxue","html_url":"https://github.com/maryannxue","followers_url":"https://api.github.com/users/maryannxue/followers","following_url":"https://api.github.com/users/maryannxue/following{/other_user}","gists_url":"https://api.github.com/users/maryannxue/gists{/gist_id}","starred_url":"https://api.github.com/users/maryannxue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryannxue/subscriptions","organizations_url":"https://api.github.com/users/maryannxue/orgs","repos_url":"https://api.github.com/users/maryannxue/repos","events_url":"https://api.github.com/users/maryannxue/events{/privacy}","received_events_url":"https://api.github.com/users/maryannxue/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nAdded `TransitPredicateInOuterJoin` optimization rule that transits constraints from the preserved side of an outer join to the null-supplying side. The constraints of the join operator will remain unchanged.\r\n\r\n## How was this patch tested?\r\n\r\nAdded 3 tests in `InferFiltersFromConstraintsSuite`.\r\n","created_at":"2018-03-13T21:36:21Z","updated_at":"2018-03-13T22:17:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28c70a6b83ed6b766c728766f6cb85d0c0a4dfe0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/20816/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/20816/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/20816/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/ac17976fd2b024039ee6cd848b864d2d052ec573","head":{"label":"maryannxue:spark-21479","ref":"spark-21479","sha":"ac17976fd2b024039ee6cd848b864d2d052ec573","user":{"login":"maryannxue","id":4171904,"avatar_url":"https://avatars3.githubusercontent.com/u/4171904?v=4","gravatar_id":"","url":"https://api.github.com/users/maryannxue","html_url":"https://github.com/maryannxue","followers_url":"https://api.github.com/users/maryannxue/followers","following_url":"https://api.github.com/users/maryannxue/following{/other_user}","gists_url":"https://api.github.com/users/maryannxue/gists{/gist_id}","starred_url":"https://api.github.com/users/maryannxue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryannxue/subscriptions","organizations_url":"https://api.github.com/users/maryannxue/orgs","repos_url":"https://api.github.com/users/maryannxue/repos","events_url":"https://api.github.com/users/maryannxue/events{/privacy}","received_events_url":"https://api.github.com/users/maryannxue/received_events","type":"User","site_admin":false},"repo":{"id":104110775,"name":"spark","full_name":"maryannxue/spark","owner":{"login":"maryannxue","id":4171904,"avatar_url":"https://avatars3.githubusercontent.com/u/4171904?v=4","gravatar_id":"","url":"https://api.github.com/users/maryannxue","html_url":"https://github.com/maryannxue","followers_url":"https://api.github.com/users/maryannxue/followers","following_url":"https://api.github.com/users/maryannxue/following{/other_user}","gists_url":"https://api.github.com/users/maryannxue/gists{/gist_id}","starred_url":"https://api.github.com/users/maryannxue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryannxue/subscriptions","organizations_url":"https://api.github.com/users/maryannxue/orgs","repos_url":"https://api.github.com/users/maryannxue/repos","events_url":"https://api.github.com/users/maryannxue/events{/privacy}","received_events_url":"https://api.github.com/users/maryannxue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maryannxue/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/maryannxue/spark","forks_url":"https://api.github.com/repos/maryannxue/spark/forks","keys_url":"https://api.github.com/repos/maryannxue/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maryannxue/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maryannxue/spark/teams","hooks_url":"https://api.github.com/repos/maryannxue/spark/hooks","issue_events_url":"https://api.github.com/repos/maryannxue/spark/issues/events{/number}","events_url":"https://api.github.com/repos/maryannxue/spark/events","assignees_url":"https://api.github.com/repos/maryannxue/spark/assignees{/user}","branches_url":"https://api.github.com/repos/maryannxue/spark/branches{/branch}","tags_url":"https://api.github.com/repos/maryannxue/spark/tags","blobs_url":"https://api.github.com/repos/maryannxue/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maryannxue/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maryannxue/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/maryannxue/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maryannxue/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/maryannxue/spark/languages","stargazers_url":"https://api.github.com/repos/maryannxue/spark/stargazers","contributors_url":"https://api.github.com/repos/maryannxue/spark/contributors","subscribers_url":"https://api.github.com/repos/maryannxue/spark/subscribers","subscription_url":"https://api.github.com/repos/maryannxue/spark/subscription","commits_url":"https://api.github.com/repos/maryannxue/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/maryannxue/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/maryannxue/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/maryannxue/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/maryannxue/spark/contents/{+path}","compare_url":"https://api.github.com/repos/maryannxue/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maryannxue/spark/merges","archive_url":"https://api.github.com/repos/maryannxue/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maryannxue/spark/downloads","issues_url":"https://api.github.com/repos/maryannxue/spark/issues{/number}","pulls_url":"https://api.github.com/repos/maryannxue/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/maryannxue/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/maryannxue/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maryannxue/spark/labels{/name}","releases_url":"https://api.github.com/repos/maryannxue/spark/releases{/id}","deployments_url":"https://api.github.com/repos/maryannxue/spark/deployments","created_at":"2017-09-19T18:13:47Z","updated_at":"2018-03-13T19:21:18Z","pushed_at":"2018-03-13T21:05:54Z","git_url":"git://github.com/maryannxue/spark.git","ssh_url":"git@github.com:maryannxue/spark.git","clone_url":"https://github.com/maryannxue/spark.git","svn_url":"https://github.com/maryannxue/spark","homepage":null,"size":268087,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"918fb9beee6a2fd499b8f18dfe0d460f078f5290","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-03-13T22:08:23Z","pushed_at":"2018-03-13T22:04:38Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":269396,"stargazers_count":16462,"watchers_count":16462,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15182,"mirror_url":null,"archived":false,"open_issues_count":468,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15182,"open_issues":468,"watchers":16462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/20816"},"html":{"href":"https://github.com/apache/spark/pull/20816"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/20816"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/20816/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/20816/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/20816/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/ac17976fd2b024039ee6cd848b864d2d052ec573"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gatorsmile"}}