{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/183112310","pull_request_review_id":114053544,"id":183112310,"diff_hunk":"@@ -166,6 +167,9 @@ struct tcpx_pep {\n \tstruct fi_info\t\tinfo;\n \tSOCKET\t\t\tsock;\n \tstruct poll_fd_info\tpoll_info;\n+\t/* protected by poll mgr lock\n+\t   as pep state transitions happen in poll mgr*/\n+\tint\t\t\tstate_flags;","path":"prov/tcp/src/tcpx.h","position":14,"original_position":14,"commit_id":"eff69414350fe181e2754139704de2c5d3ca0034","original_commit_id":"eff69414350fe181e2754139704de2c5d3ca0034","user":{"login":"shefty","id":3967608,"avatar_url":"https://avatars0.githubusercontent.com/u/3967608?v=4","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"body":"This looks better as an actual state, rather than a set of flags.","created_at":"2018-04-20T17:01:41Z","updated_at":"2018-04-20T17:03:04Z","html_url":"https://github.com/ofiwg/libfabric/pull/4028#discussion_r183112310","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4028","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/183112310"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4028#discussion_r183112310"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4028"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4028","id":183116721,"html_url":"https://github.com/ofiwg/libfabric/pull/4028","diff_url":"https://github.com/ofiwg/libfabric/pull/4028.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/4028.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4028","number":4028,"state":"open","locked":false,"title":"prov/tcp: support for reserving ep address with provider context handle","user":{"login":"vkrishna","id":296785,"avatar_url":"https://avatars1.githubusercontent.com/u/296785?v=4","gravatar_id":"","url":"https://api.github.com/users/vkrishna","html_url":"https://github.com/vkrishna","followers_url":"https://api.github.com/users/vkrishna/followers","following_url":"https://api.github.com/users/vkrishna/following{/other_user}","gists_url":"https://api.github.com/users/vkrishna/gists{/gist_id}","starred_url":"https://api.github.com/users/vkrishna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkrishna/subscriptions","organizations_url":"https://api.github.com/users/vkrishna/orgs","repos_url":"https://api.github.com/users/vkrishna/repos","events_url":"https://api.github.com/users/vkrishna/events{/privacy}","received_events_url":"https://api.github.com/users/vkrishna/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Venkata Krishna Nimmagadda <venkata.krishna.nimmagadda@intel.com>\r\n","created_at":"2018-04-20T16:51:25Z","updated_at":"2018-04-20T17:03:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1237c2edccf18e0cbecd9214f41daaed95cc6079","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4028/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4028/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4028/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/eff69414350fe181e2754139704de2c5d3ca0034","head":{"label":"vkrishna:tcp-dev","ref":"tcp-dev","sha":"eff69414350fe181e2754139704de2c5d3ca0034","user":{"login":"vkrishna","id":296785,"avatar_url":"https://avatars1.githubusercontent.com/u/296785?v=4","gravatar_id":"","url":"https://api.github.com/users/vkrishna","html_url":"https://github.com/vkrishna","followers_url":"https://api.github.com/users/vkrishna/followers","following_url":"https://api.github.com/users/vkrishna/following{/other_user}","gists_url":"https://api.github.com/users/vkrishna/gists{/gist_id}","starred_url":"https://api.github.com/users/vkrishna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkrishna/subscriptions","organizations_url":"https://api.github.com/users/vkrishna/orgs","repos_url":"https://api.github.com/users/vkrishna/repos","events_url":"https://api.github.com/users/vkrishna/events{/privacy}","received_events_url":"https://api.github.com/users/vkrishna/received_events","type":"User","site_admin":false},"repo":{"id":97731920,"name":"libfabric","full_name":"vkrishna/libfabric","owner":{"login":"vkrishna","id":296785,"avatar_url":"https://avatars1.githubusercontent.com/u/296785?v=4","gravatar_id":"","url":"https://api.github.com/users/vkrishna","html_url":"https://github.com/vkrishna","followers_url":"https://api.github.com/users/vkrishna/followers","following_url":"https://api.github.com/users/vkrishna/following{/other_user}","gists_url":"https://api.github.com/users/vkrishna/gists{/gist_id}","starred_url":"https://api.github.com/users/vkrishna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkrishna/subscriptions","organizations_url":"https://api.github.com/users/vkrishna/orgs","repos_url":"https://api.github.com/users/vkrishna/repos","events_url":"https://api.github.com/users/vkrishna/events{/privacy}","received_events_url":"https://api.github.com/users/vkrishna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vkrishna/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/vkrishna/libfabric","forks_url":"https://api.github.com/repos/vkrishna/libfabric/forks","keys_url":"https://api.github.com/repos/vkrishna/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vkrishna/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vkrishna/libfabric/teams","hooks_url":"https://api.github.com/repos/vkrishna/libfabric/hooks","issue_events_url":"https://api.github.com/repos/vkrishna/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/vkrishna/libfabric/events","assignees_url":"https://api.github.com/repos/vkrishna/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/vkrishna/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/vkrishna/libfabric/tags","blobs_url":"https://api.github.com/repos/vkrishna/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vkrishna/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vkrishna/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/vkrishna/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vkrishna/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/vkrishna/libfabric/languages","stargazers_url":"https://api.github.com/repos/vkrishna/libfabric/stargazers","contributors_url":"https://api.github.com/repos/vkrishna/libfabric/contributors","subscribers_url":"https://api.github.com/repos/vkrishna/libfabric/subscribers","subscription_url":"https://api.github.com/repos/vkrishna/libfabric/subscription","commits_url":"https://api.github.com/repos/vkrishna/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/vkrishna/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/vkrishna/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/vkrishna/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/vkrishna/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/vkrishna/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vkrishna/libfabric/merges","archive_url":"https://api.github.com/repos/vkrishna/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vkrishna/libfabric/downloads","issues_url":"https://api.github.com/repos/vkrishna/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/vkrishna/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/vkrishna/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/vkrishna/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vkrishna/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/vkrishna/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/vkrishna/libfabric/deployments","created_at":"2017-07-19T15:22:30Z","updated_at":"2018-04-05T20:08:44Z","pushed_at":"2018-04-20T16:50:54Z","git_url":"git://github.com/vkrishna/libfabric.git","ssh_url":"git@github.com:vkrishna/libfabric.git","clone_url":"https://github.com/vkrishna/libfabric.git","svn_url":"https://github.com/vkrishna/libfabric","homepage":"http://libfabric.org/","size":17476,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"262d4f22572d54e04388ee1092eb5548212e47d7","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2018-04-19T16:21:18Z","pushed_at":"2018-04-20T17:01:56Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://libfabric.org/","size":17880,"stargazers_count":147,"watchers_count":147,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":128,"open_issues":104,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4028"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4028"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4028"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4028/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4028/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4028/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/eff69414350fe181e2754139704de2c5d3ca0034"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shefty"}}