{"action":"created","comment":{"url":"https://api.github.com/repos/helm/charts/pulls/comments/210994710","pull_request_review_id":147333087,"id":210994710,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDk5NDcxMA==","diff_hunk":"@@ -173,6 +173,10 @@ spec:\n         - name: KAFKA_JMX_PORT\n           value: \"{{ .Values.jmx.port }}\"\n         {{- end }}\n+        {{- range $key, $value := .Values.env }}","path":"incubator/kafka/templates/statefulset.yaml","position":4,"original_position":4,"commit_id":"00cf0f582c8579df8ed91015d1302f3fc9c07e8d","original_commit_id":"00cf0f582c8579df8ed91015d1302f3fc9c07e8d","user":{"login":"benjigoldberg","id":6841489,"node_id":"MDQ6VXNlcjY4NDE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/6841489?v=4","gravatar_id":"","url":"https://api.github.com/users/benjigoldberg","html_url":"https://github.com/benjigoldberg","followers_url":"https://api.github.com/users/benjigoldberg/followers","following_url":"https://api.github.com/users/benjigoldberg/following{/other_user}","gists_url":"https://api.github.com/users/benjigoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/benjigoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjigoldberg/subscriptions","organizations_url":"https://api.github.com/users/benjigoldberg/orgs","repos_url":"https://api.github.com/users/benjigoldberg/repos","events_url":"https://api.github.com/users/benjigoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/benjigoldberg/received_events","type":"User","site_admin":false},"body":"This isnt specified in the `values.yaml` -- is this something that could be passing through `configurationOverrides`?","created_at":"2018-08-17T18:24:49Z","updated_at":"2018-08-17T18:25:19Z","html_url":"https://github.com/helm/charts/pull/7233#discussion_r210994710","pull_request_url":"https://api.github.com/repos/helm/charts/pulls/7233","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/comments/210994710"},"html":{"href":"https://github.com/helm/charts/pull/7233#discussion_r210994710"},"pull_request":{"href":"https://api.github.com/repos/helm/charts/pulls/7233"}}},"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/7233","id":209219441,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjE5NDQx","html_url":"https://github.com/helm/charts/pull/7233","diff_url":"https://github.com/helm/charts/pull/7233.diff","patch_url":"https://github.com/helm/charts/pull/7233.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/7233","number":7233,"state":"open","locked":false,"title":"[incubator/kafka] Add ability to mount secrets","user":{"login":"rustycl0ck","id":1299606,"node_id":"MDQ6VXNlcjEyOTk2MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1299606?v=4","gravatar_id":"","url":"https://api.github.com/users/rustycl0ck","html_url":"https://github.com/rustycl0ck","followers_url":"https://api.github.com/users/rustycl0ck/followers","following_url":"https://api.github.com/users/rustycl0ck/following{/other_user}","gists_url":"https://api.github.com/users/rustycl0ck/gists{/gist_id}","starred_url":"https://api.github.com/users/rustycl0ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustycl0ck/subscriptions","organizations_url":"https://api.github.com/users/rustycl0ck/orgs","repos_url":"https://api.github.com/users/rustycl0ck/repos","events_url":"https://api.github.com/users/rustycl0ck/events{/privacy}","received_events_url":"https://api.github.com/users/rustycl0ck/received_events","type":"User","site_admin":false},"body":"* Provide the ability to mount secrets in the kafka brokers. This is useful when using custom authorizers.\r\n* Add ability to pass environment variables\r\n\r\n<!--\r\nThank you for contributing to helm/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n* Need the ability to mount secrets if using any kind of custom authorizer.\r\n* Added the missing functionality of passing on environment variables\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n","created_at":"2018-08-17T18:07:09Z","updated_at":"2018-08-17T18:25:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33aff4e70d1426d9630f4f702bd9aaea87c60453","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mgoodness","id":2781657,"node_id":"MDQ6VXNlcjI3ODE2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2781657?v=4","gravatar_id":"","url":"https://api.github.com/users/mgoodness","html_url":"https://github.com/mgoodness","followers_url":"https://api.github.com/users/mgoodness/followers","following_url":"https://api.github.com/users/mgoodness/following{/other_user}","gists_url":"https://api.github.com/users/mgoodness/gists{/gist_id}","starred_url":"https://api.github.com/users/mgoodness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgoodness/subscriptions","organizations_url":"https://api.github.com/users/mgoodness/orgs","repos_url":"https://api.github.com/users/mgoodness/repos","events_url":"https://api.github.com/users/mgoodness/events{/privacy}","received_events_url":"https://api.github.com/users/mgoodness/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/helm/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":582594847,"node_id":"MDU6TGFiZWw1ODI1OTQ4NDc=","url":"https://api.github.com/repos/helm/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/7233/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/7233/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/7233/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/00cf0f582c8579df8ed91015d1302f3fc9c07e8d","head":{"label":"rustycl0ck:feature/authed-kafka","ref":"feature/authed-kafka","sha":"00cf0f582c8579df8ed91015d1302f3fc9c07e8d","user":{"login":"rustycl0ck","id":1299606,"node_id":"MDQ6VXNlcjEyOTk2MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1299606?v=4","gravatar_id":"","url":"https://api.github.com/users/rustycl0ck","html_url":"https://github.com/rustycl0ck","followers_url":"https://api.github.com/users/rustycl0ck/followers","following_url":"https://api.github.com/users/rustycl0ck/following{/other_user}","gists_url":"https://api.github.com/users/rustycl0ck/gists{/gist_id}","starred_url":"https://api.github.com/users/rustycl0ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustycl0ck/subscriptions","organizations_url":"https://api.github.com/users/rustycl0ck/orgs","repos_url":"https://api.github.com/users/rustycl0ck/repos","events_url":"https://api.github.com/users/rustycl0ck/events{/privacy}","received_events_url":"https://api.github.com/users/rustycl0ck/received_events","type":"User","site_admin":false},"repo":{"id":124838067,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ4MzgwNjc=","name":"kubernetes-charts","full_name":"rustycl0ck/kubernetes-charts","owner":{"login":"rustycl0ck","id":1299606,"node_id":"MDQ6VXNlcjEyOTk2MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1299606?v=4","gravatar_id":"","url":"https://api.github.com/users/rustycl0ck","html_url":"https://github.com/rustycl0ck","followers_url":"https://api.github.com/users/rustycl0ck/followers","following_url":"https://api.github.com/users/rustycl0ck/following{/other_user}","gists_url":"https://api.github.com/users/rustycl0ck/gists{/gist_id}","starred_url":"https://api.github.com/users/rustycl0ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustycl0ck/subscriptions","organizations_url":"https://api.github.com/users/rustycl0ck/orgs","repos_url":"https://api.github.com/users/rustycl0ck/repos","events_url":"https://api.github.com/users/rustycl0ck/events{/privacy}","received_events_url":"https://api.github.com/users/rustycl0ck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rustycl0ck/kubernetes-charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts","forks_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/forks","keys_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/teams","hooks_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/hooks","issue_events_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/issues/events{/number}","events_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/events","assignees_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/assignees{/user}","branches_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/branches{/branch}","tags_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/tags","blobs_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/languages","stargazers_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/stargazers","contributors_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/contributors","subscribers_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/subscribers","subscription_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/subscription","commits_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/contents/{+path}","compare_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/merges","archive_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/downloads","issues_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/issues{/number}","pulls_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/labels{/name}","releases_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/releases{/id}","deployments_url":"https://api.github.com/repos/rustycl0ck/kubernetes-charts/deployments","created_at":"2018-03-12T05:31:16Z","updated_at":"2018-08-17T13:49:39Z","pushed_at":"2018-08-17T17:54:21Z","git_url":"git://github.com/rustycl0ck/kubernetes-charts.git","ssh_url":"git@github.com:rustycl0ck/kubernetes-charts.git","clone_url":"https://github.com/rustycl0ck/kubernetes-charts.git","svn_url":"https://github.com/rustycl0ck/kubernetes-charts","homepage":"","size":9665,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"0445fad8d8308f089f5fb6756a5570bc6d6f0bf5","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-08-17T17:52:44Z","pushed_at":"2018-08-17T18:07:10Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":9711,"stargazers_count":4236,"watchers_count":4236,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3749,"mirror_url":null,"archived":false,"open_issues_count":818,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3749,"open_issues":818,"watchers":4236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/7233"},"html":{"href":"https://github.com/helm/charts/pull/7233"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/7233"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/7233/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/7233/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/7233/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/00cf0f582c8579df8ed91015d1302f3fc9c07e8d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benjigoldberg"}}