{"action":"created","comment":{"url":"https://api.github.com/repos/igorski/MWEngine/pulls/comments/169901670","pull_request_review_id":98500486,"id":169901670,"diff_hunk":"@@ -312,10 +308,8 @@ void Synthesizer::render( AudioBuffer* aOutputBuffer, BaseSynthEvent* aEvent )\n \n     if ( !hasParent )\n     {\n-        _instrument->adsr->setLastEnvelope( aEvent->cachedProps.ADSRenvelope );\n-        _instrument->adsr->setBufferLength( aEvent->getEventLength() );\n+        _instrument->adsr->apply( aOutputBuffer, aEvent, bufferWriteIndex );\n ","path":"jni/generators/synthesizer.cpp","position":18,"original_position":18,"commit_id":"026276bb64a37136b5fde8a28c6b5e541dda8f2f","original_commit_id":"026276bb64a37136b5fde8a28c6b5e541dda8f2f","user":{"login":"igorski","id":730069,"avatar_url":"https://avatars3.githubusercontent.com/u/730069?v=4","gravatar_id":"","url":"https://api.github.com/users/igorski","html_url":"https://github.com/igorski","followers_url":"https://api.github.com/users/igorski/followers","following_url":"https://api.github.com/users/igorski/following{/other_user}","gists_url":"https://api.github.com/users/igorski/gists{/gist_id}","starred_url":"https://api.github.com/users/igorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorski/subscriptions","organizations_url":"https://api.github.com/users/igorski/orgs","repos_url":"https://api.github.com/users/igorski/repos","events_url":"https://api.github.com/users/igorski/events{/privacy}","received_events_url":"https://api.github.com/users/igorski/received_events","type":"User","site_admin":false},"body":"Let the ADSR module manage all cached envelope values and buffer lengths, Synthesizer shouldn't care.","created_at":"2018-02-22T09:46:11Z","updated_at":"2018-02-22T09:46:11Z","html_url":"https://github.com/igorski/MWEngine/pull/39#discussion_r169901670","pull_request_url":"https://api.github.com/repos/igorski/MWEngine/pulls/39","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/igorski/MWEngine/pulls/comments/169901670"},"html":{"href":"https://github.com/igorski/MWEngine/pull/39#discussion_r169901670"},"pull_request":{"href":"https://api.github.com/repos/igorski/MWEngine/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/igorski/MWEngine/pulls/39","id":170055250,"html_url":"https://github.com/igorski/MWEngine/pull/39","diff_url":"https://github.com/igorski/MWEngine/pull/39.diff","patch_url":"https://github.com/igorski/MWEngine/pull/39.patch","issue_url":"https://api.github.com/repos/igorski/MWEngine/issues/39","number":39,"state":"open","locked":false,"title":"Refactored ADSR module","user":{"login":"igorski","id":730069,"avatar_url":"https://avatars3.githubusercontent.com/u/730069?v=4","gravatar_id":"","url":"https://api.github.com/users/igorski","html_url":"https://github.com/igorski","followers_url":"https://api.github.com/users/igorski/followers","following_url":"https://api.github.com/users/igorski/following{/other_user}","gists_url":"https://api.github.com/users/igorski/gists{/gist_id}","starred_url":"https://api.github.com/users/igorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorski/subscriptions","organizations_url":"https://api.github.com/users/igorski/orgs","repos_url":"https://api.github.com/users/igorski/repos","events_url":"https://api.github.com/users/igorski/events{/privacy}","received_events_url":"https://api.github.com/users/igorski/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-19T21:25:23Z","updated_at":"2018-02-22T09:46:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3f7bc17493eb5c191a48607f46cd54938f5367d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/igorski/MWEngine/pulls/39/commits","review_comments_url":"https://api.github.com/repos/igorski/MWEngine/pulls/39/comments","review_comment_url":"https://api.github.com/repos/igorski/MWEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/igorski/MWEngine/issues/39/comments","statuses_url":"https://api.github.com/repos/igorski/MWEngine/statuses/026276bb64a37136b5fde8a28c6b5e541dda8f2f","head":{"label":"igorski:adsr","ref":"adsr","sha":"026276bb64a37136b5fde8a28c6b5e541dda8f2f","user":{"login":"igorski","id":730069,"avatar_url":"https://avatars3.githubusercontent.com/u/730069?v=4","gravatar_id":"","url":"https://api.github.com/users/igorski","html_url":"https://github.com/igorski","followers_url":"https://api.github.com/users/igorski/followers","following_url":"https://api.github.com/users/igorski/following{/other_user}","gists_url":"https://api.github.com/users/igorski/gists{/gist_id}","starred_url":"https://api.github.com/users/igorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorski/subscriptions","organizations_url":"https://api.github.com/users/igorski/orgs","repos_url":"https://api.github.com/users/igorski/repos","events_url":"https://api.github.com/users/igorski/events{/privacy}","received_events_url":"https://api.github.com/users/igorski/received_events","type":"User","site_admin":false},"repo":{"id":17284944,"name":"MWEngine","full_name":"igorski/MWEngine","owner":{"login":"igorski","id":730069,"avatar_url":"https://avatars3.githubusercontent.com/u/730069?v=4","gravatar_id":"","url":"https://api.github.com/users/igorski","html_url":"https://github.com/igorski","followers_url":"https://api.github.com/users/igorski/followers","following_url":"https://api.github.com/users/igorski/following{/other_user}","gists_url":"https://api.github.com/users/igorski/gists{/gist_id}","starred_url":"https://api.github.com/users/igorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorski/subscriptions","organizations_url":"https://api.github.com/users/igorski/orgs","repos_url":"https://api.github.com/users/igorski/repos","events_url":"https://api.github.com/users/igorski/events{/privacy}","received_events_url":"https://api.github.com/users/igorski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/igorski/MWEngine","description":"Audio engine and DSP for Android, written in C++ providing low latency performance in a musical context, supporting both OpenSL and AAudio.","fork":false,"url":"https://api.github.com/repos/igorski/MWEngine","forks_url":"https://api.github.com/repos/igorski/MWEngine/forks","keys_url":"https://api.github.com/repos/igorski/MWEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igorski/MWEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igorski/MWEngine/teams","hooks_url":"https://api.github.com/repos/igorski/MWEngine/hooks","issue_events_url":"https://api.github.com/repos/igorski/MWEngine/issues/events{/number}","events_url":"https://api.github.com/repos/igorski/MWEngine/events","assignees_url":"https://api.github.com/repos/igorski/MWEngine/assignees{/user}","branches_url":"https://api.github.com/repos/igorski/MWEngine/branches{/branch}","tags_url":"https://api.github.com/repos/igorski/MWEngine/tags","blobs_url":"https://api.github.com/repos/igorski/MWEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igorski/MWEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igorski/MWEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/igorski/MWEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igorski/MWEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/igorski/MWEngine/languages","stargazers_url":"https://api.github.com/repos/igorski/MWEngine/stargazers","contributors_url":"https://api.github.com/repos/igorski/MWEngine/contributors","subscribers_url":"https://api.github.com/repos/igorski/MWEngine/subscribers","subscription_url":"https://api.github.com/repos/igorski/MWEngine/subscription","commits_url":"https://api.github.com/repos/igorski/MWEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/igorski/MWEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/igorski/MWEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/igorski/MWEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/igorski/MWEngine/contents/{+path}","compare_url":"https://api.github.com/repos/igorski/MWEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igorski/MWEngine/merges","archive_url":"https://api.github.com/repos/igorski/MWEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igorski/MWEngine/downloads","issues_url":"https://api.github.com/repos/igorski/MWEngine/issues{/number}","pulls_url":"https://api.github.com/repos/igorski/MWEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/igorski/MWEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/igorski/MWEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igorski/MWEngine/labels{/name}","releases_url":"https://api.github.com/repos/igorski/MWEngine/releases{/id}","deployments_url":"https://api.github.com/repos/igorski/MWEngine/deployments","created_at":"2014-02-28T12:01:31Z","updated_at":"2018-02-12T20:03:25Z","pushed_at":"2018-02-22T09:22:31Z","git_url":"git://github.com/igorski/MWEngine.git","ssh_url":"git@github.com:igorski/MWEngine.git","clone_url":"https://github.com/igorski/MWEngine.git","svn_url":"https://github.com/igorski/MWEngine","homepage":"https://www.igorski.nl/mikrowave","size":1339,"stargazers_count":95,"watchers_count":95,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":22,"open_issues":2,"watchers":95,"default_branch":"master"}},"base":{"label":"igorski:master","ref":"master","sha":"408efed7717f84872d44a941bc89225860558260","user":{"login":"igorski","id":730069,"avatar_url":"https://avatars3.githubusercontent.com/u/730069?v=4","gravatar_id":"","url":"https://api.github.com/users/igorski","html_url":"https://github.com/igorski","followers_url":"https://api.github.com/users/igorski/followers","following_url":"https://api.github.com/users/igorski/following{/other_user}","gists_url":"https://api.github.com/users/igorski/gists{/gist_id}","starred_url":"https://api.github.com/users/igorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorski/subscriptions","organizations_url":"https://api.github.com/users/igorski/orgs","repos_url":"https://api.github.com/users/igorski/repos","events_url":"https://api.github.com/users/igorski/events{/privacy}","received_events_url":"https://api.github.com/users/igorski/received_events","type":"User","site_admin":false},"repo":{"id":17284944,"name":"MWEngine","full_name":"igorski/MWEngine","owner":{"login":"igorski","id":730069,"avatar_url":"https://avatars3.githubusercontent.com/u/730069?v=4","gravatar_id":"","url":"https://api.github.com/users/igorski","html_url":"https://github.com/igorski","followers_url":"https://api.github.com/users/igorski/followers","following_url":"https://api.github.com/users/igorski/following{/other_user}","gists_url":"https://api.github.com/users/igorski/gists{/gist_id}","starred_url":"https://api.github.com/users/igorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorski/subscriptions","organizations_url":"https://api.github.com/users/igorski/orgs","repos_url":"https://api.github.com/users/igorski/repos","events_url":"https://api.github.com/users/igorski/events{/privacy}","received_events_url":"https://api.github.com/users/igorski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/igorski/MWEngine","description":"Audio engine and DSP for Android, written in C++ providing low latency performance in a musical context, supporting both OpenSL and AAudio.","fork":false,"url":"https://api.github.com/repos/igorski/MWEngine","forks_url":"https://api.github.com/repos/igorski/MWEngine/forks","keys_url":"https://api.github.com/repos/igorski/MWEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igorski/MWEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igorski/MWEngine/teams","hooks_url":"https://api.github.com/repos/igorski/MWEngine/hooks","issue_events_url":"https://api.github.com/repos/igorski/MWEngine/issues/events{/number}","events_url":"https://api.github.com/repos/igorski/MWEngine/events","assignees_url":"https://api.github.com/repos/igorski/MWEngine/assignees{/user}","branches_url":"https://api.github.com/repos/igorski/MWEngine/branches{/branch}","tags_url":"https://api.github.com/repos/igorski/MWEngine/tags","blobs_url":"https://api.github.com/repos/igorski/MWEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igorski/MWEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igorski/MWEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/igorski/MWEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igorski/MWEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/igorski/MWEngine/languages","stargazers_url":"https://api.github.com/repos/igorski/MWEngine/stargazers","contributors_url":"https://api.github.com/repos/igorski/MWEngine/contributors","subscribers_url":"https://api.github.com/repos/igorski/MWEngine/subscribers","subscription_url":"https://api.github.com/repos/igorski/MWEngine/subscription","commits_url":"https://api.github.com/repos/igorski/MWEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/igorski/MWEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/igorski/MWEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/igorski/MWEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/igorski/MWEngine/contents/{+path}","compare_url":"https://api.github.com/repos/igorski/MWEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igorski/MWEngine/merges","archive_url":"https://api.github.com/repos/igorski/MWEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igorski/MWEngine/downloads","issues_url":"https://api.github.com/repos/igorski/MWEngine/issues{/number}","pulls_url":"https://api.github.com/repos/igorski/MWEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/igorski/MWEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/igorski/MWEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igorski/MWEngine/labels{/name}","releases_url":"https://api.github.com/repos/igorski/MWEngine/releases{/id}","deployments_url":"https://api.github.com/repos/igorski/MWEngine/deployments","created_at":"2014-02-28T12:01:31Z","updated_at":"2018-02-12T20:03:25Z","pushed_at":"2018-02-22T09:22:31Z","git_url":"git://github.com/igorski/MWEngine.git","ssh_url":"git@github.com:igorski/MWEngine.git","clone_url":"https://github.com/igorski/MWEngine.git","svn_url":"https://github.com/igorski/MWEngine","homepage":"https://www.igorski.nl/mikrowave","size":1339,"stargazers_count":95,"watchers_count":95,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":22,"open_issues":2,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/igorski/MWEngine/pulls/39"},"html":{"href":"https://github.com/igorski/MWEngine/pull/39"},"issue":{"href":"https://api.github.com/repos/igorski/MWEngine/issues/39"},"comments":{"href":"https://api.github.com/repos/igorski/MWEngine/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/igorski/MWEngine/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/igorski/MWEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/igorski/MWEngine/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/igorski/MWEngine/statuses/026276bb64a37136b5fde8a28c6b5e541dda8f2f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"igorski"}}