{"action":"created","issue":{"url":"https://api.github.com/repos/pypeit/PypeIt-development-suite/issues/54","repository_url":"https://api.github.com/repos/pypeit/PypeIt-development-suite","labels_url":"https://api.github.com/repos/pypeit/PypeIt-development-suite/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/pypeit/PypeIt-development-suite/issues/54/comments","events_url":"https://api.github.com/repos/pypeit/PypeIt-development-suite/issues/54/events","html_url":"https://github.com/pypeit/PypeIt-development-suite/issues/54","id":359593778,"node_id":"MDU6SXNzdWUzNTk1OTM3Nzg=","number":54,"title":"NIRES wavecalib is slow","user":{"login":"feigewang","id":23131361,"node_id":"MDQ6VXNlcjIzMTMxMzYx","avatar_url":"https://avatars3.githubusercontent.com/u/23131361?v=4","gravatar_id":"","url":"https://api.github.com/users/feigewang","html_url":"https://github.com/feigewang","followers_url":"https://api.github.com/users/feigewang/followers","following_url":"https://api.github.com/users/feigewang/following{/other_user}","gists_url":"https://api.github.com/users/feigewang/gists{/gist_id}","starred_url":"https://api.github.com/users/feigewang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feigewang/subscriptions","organizations_url":"https://api.github.com/users/feigewang/orgs","repos_url":"https://api.github.com/users/feigewang/repos","events_url":"https://api.github.com/users/feigewang/events{/privacy}","received_events_url":"https://api.github.com/users/feigewang/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-12T18:10:27Z","updated_at":"2018-09-14T19:53:10Z","closed_at":"2018-09-14T19:53:10Z","author_association":"COLLABORATOR","body":"The wavecalib seems quite slow for NIRES. It works ok for first two orders (i.e. Y/J bands), but getting slower in H and almost failed in K band (last order). I upload a notebook under development suite  dev_nries_run branch named as NIRES_WaveCalib.ipynb. @rcooke-ast Please check it out. Thanks!"},"comment":{"url":"https://api.github.com/repos/pypeit/PypeIt-development-suite/issues/comments/421467050","html_url":"https://github.com/pypeit/PypeIt-development-suite/issues/54#issuecomment-421467050","issue_url":"https://api.github.com/repos/pypeit/PypeIt-development-suite/issues/54","id":421467050,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTQ2NzA1MA==","user":{"login":"rcooke-ast","id":12585758,"node_id":"MDQ6VXNlcjEyNTg1NzU4","avatar_url":"https://avatars2.githubusercontent.com/u/12585758?v=4","gravatar_id":"","url":"https://api.github.com/users/rcooke-ast","html_url":"https://github.com/rcooke-ast","followers_url":"https://api.github.com/users/rcooke-ast/followers","following_url":"https://api.github.com/users/rcooke-ast/following{/other_user}","gists_url":"https://api.github.com/users/rcooke-ast/gists{/gist_id}","starred_url":"https://api.github.com/users/rcooke-ast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcooke-ast/subscriptions","organizations_url":"https://api.github.com/users/rcooke-ast/orgs","repos_url":"https://api.github.com/users/rcooke-ast/repos","events_url":"https://api.github.com/users/rcooke-ast/events{/privacy}","received_events_url":"https://api.github.com/users/rcooke-ast/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T19:53:10Z","updated_at":"2018-09-14T19:53:10Z","author_association":"COLLABORATOR","body":"Hi @feigewang - I've addressed this (I hope!) in the PR available for review in the main repo. Try it out, and let me know if this improves the speed a little. You may need to play around with some parameters in the autoid file. I haven't done an exhaustive test, but I would start with the `idthresh` fraction if the speed increase is still not sufficient."}}
{"actor":{"display_login":"rcooke-ast"}}