{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/226384071","pull_request_review_id":166193933,"id":226384071,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjM4NDA3MQ==","diff_hunk":"@@ -0,0 +1,657 @@\n+// Copyright 2018 The Chromium Authors. All rights reserved.\n+// Use of this source code is governed by a BSD-style license that can be\n+// found in the LICENSE file.\n+\n+import 'package:flutter/rendering.dart';\n+import 'package:flutter/services.dart';\n+import 'package:flutter/widgets.dart';\n+\n+import 'colors.dart';\n+import 'icons.dart';\n+import 'text_selection.dart';\n+\n+export 'package:flutter/services.dart' show TextInputType, TextInputAction, TextCapitalization;\n+\n+// Value extracted via color reader from iOS simulator.\n+const BorderSide _kDefaultRoundedBorderSide = BorderSide(\n+  color: CupertinoColors.lightBackgroundGray,\n+  style: BorderStyle.solid,\n+  width: 0.0,\n+);\n+const Border _kDefaultRoundedBorder = Border(\n+  top: _kDefaultRoundedBorderSide,\n+  bottom: _kDefaultRoundedBorderSide,\n+  left: _kDefaultRoundedBorderSide,\n+  right: _kDefaultRoundedBorderSide,\n+);\n+// Counted manually on magnified simulator.\n+const BoxDecoration _kDefaultRoundedBorderDecoration = BoxDecoration(\n+  border: _kDefaultRoundedBorder,\n+  borderRadius: BorderRadius.all(Radius.circular(4.0)),\n+);\n+\n+// Default iOS style from HIG specs with larger font.\n+const TextStyle _kDefaultTextStyle = TextStyle(\n+  fontFamily: '.SF Pro Text',\n+  fontSize: 17.0,\n+  letterSpacing: -0.38,\n+  color: CupertinoColors.black,\n+  decoration: TextDecoration.none,\n+);\n+\n+// Value extracted via color reader from iOS simulator.\n+const Color _kSelectionHighlightColor = Color(0x667FAACF);\n+const Color _kInactiveTextColor = Color(0xFFC2C2C2);\n+const Color _kDisabledBackground = Color(0xFFFAFAFA);\n+\n+/// Visibility of text field overlays based on the state of the current text entry.\n+///\n+/// Used to toggle the visibility behavior of the optional decorating widgets\n+/// surrounding the [EditableText] such as the clear text button.\n+enum OverlayVisibilityMode {\n+  /// Overlay will never appear regardless of the text entry state.\n+  never,\n+  /// Overlay will only appear when the current text entry is not empty.\n+  ///\n+  /// This includes pre-filled text that the user did not type in manually. But\n+  /// does not include text in placeholders.\n+  editing,\n+  /// Overlay will only appear when the current text entry is empty.\n+  ///\n+  /// This also includes not having pre-filled text that the user did not type\n+  /// in manually. Texts in placeholders are ignored.\n+  notEditing,\n+  /// Always show the overlay regardless of the text entry state.\n+  always,","path":"packages/flutter/lib/src/cupertino/text_field.dart","position":65,"original_position":65,"commit_id":"9d718a60851e8d2f06971b6d44294a71697177ed","original_commit_id":"9d718a60851e8d2f06971b6d44294a71697177ed","user":{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"nit: blank line between an enum value and the next's dartdoc","created_at":"2018-10-18T16:49:23Z","updated_at":"2018-10-18T16:49:24Z","html_url":"https://github.com/flutter/flutter/pull/23194#discussion_r226384071","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/23194","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/226384071"},"html":{"href":"https://github.com/flutter/flutter/pull/23194#discussion_r226384071"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/23194"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/23194","id":223492025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDkyMDI1","html_url":"https://github.com/flutter/flutter/pull/23194","diff_url":"https://github.com/flutter/flutter/pull/23194.diff","patch_url":"https://github.com/flutter/flutter/pull/23194.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/23194","number":23194,"state":"open","locked":false,"title":"Add a CupertinoTextField","user":{"login":"xster","id":156888,"node_id":"MDQ6VXNlcjE1Njg4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/156888?v=4","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"body":"Adds support for an iOS styled text field #13695 with APIs supporting default UITextField and UITextView functionalities. \r\n\r\nConsolidates docs between Material TextField, EditableText and this new widget. ","created_at":"2018-10-17T07:14:54Z","updated_at":"2018-10-18T16:49:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a475dc37f399c3e5b7128dc6c255fe4076587641","assignee":null,"assignees":[],"requested_reviewers":[{"login":"HansMuller","id":1377460,"node_id":"MDQ6VXNlcjEzNzc0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1377460?v=4","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/23194/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/23194/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/23194/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/9d718a60851e8d2f06971b6d44294a71697177ed","head":{"label":"xster:text-field","ref":"text-field","sha":"9d718a60851e8d2f06971b6d44294a71697177ed","user":{"login":"xster","id":156888,"node_id":"MDQ6VXNlcjE1Njg4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/156888?v=4","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"repo":{"id":79845855,"node_id":"MDEwOlJlcG9zaXRvcnk3OTg0NTg1NQ==","name":"flutter","full_name":"xster/flutter","private":false,"owner":{"login":"xster","id":156888,"node_id":"MDQ6VXNlcjE1Njg4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/156888?v=4","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xster/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/xster/flutter","forks_url":"https://api.github.com/repos/xster/flutter/forks","keys_url":"https://api.github.com/repos/xster/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xster/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xster/flutter/teams","hooks_url":"https://api.github.com/repos/xster/flutter/hooks","issue_events_url":"https://api.github.com/repos/xster/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/xster/flutter/events","assignees_url":"https://api.github.com/repos/xster/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/xster/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/xster/flutter/tags","blobs_url":"https://api.github.com/repos/xster/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xster/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xster/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/xster/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xster/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/xster/flutter/languages","stargazers_url":"https://api.github.com/repos/xster/flutter/stargazers","contributors_url":"https://api.github.com/repos/xster/flutter/contributors","subscribers_url":"https://api.github.com/repos/xster/flutter/subscribers","subscription_url":"https://api.github.com/repos/xster/flutter/subscription","commits_url":"https://api.github.com/repos/xster/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/xster/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/xster/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/xster/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/xster/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/xster/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xster/flutter/merges","archive_url":"https://api.github.com/repos/xster/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xster/flutter/downloads","issues_url":"https://api.github.com/repos/xster/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/xster/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/xster/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/xster/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xster/flutter/labels{/name}","releases_url":"https://api.github.com/repos/xster/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/xster/flutter/deployments","created_at":"2017-01-23T20:41:37Z","updated_at":"2017-01-23T20:41:42Z","pushed_at":"2018-10-18T01:05:30Z","git_url":"git://github.com/xster/flutter.git","ssh_url":"git@github.com:xster/flutter.git","clone_url":"https://github.com/xster/flutter.git","svn_url":"https://github.com/xster/flutter","homepage":"https://flutter.io","size":49150,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"936dea28da4be310a0c9d10601b81f728a2c6993","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-10-18T16:42:50Z","pushed_at":"2018-10-18T16:42:51Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":48879,"stargazers_count":39518,"watchers_count":39518,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3842,"mirror_url":null,"archived":false,"open_issues_count":4130,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3842,"open_issues":4130,"watchers":39518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/23194"},"html":{"href":"https://github.com/flutter/flutter/pull/23194"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/23194"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/23194/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/23194/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/23194/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/9d718a60851e8d2f06971b6d44294a71697177ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Hixie"}}