{"action":"closed","number":470,"pull_request":{"url":"https://api.github.com/repos/ucbrise/clipper/pulls/470","id":181610402,"html_url":"https://github.com/ucbrise/clipper/pull/470","diff_url":"https://github.com/ucbrise/clipper/pull/470.diff","patch_url":"https://github.com/ucbrise/clipper/pull/470.patch","issue_url":"https://api.github.com/repos/ucbrise/clipper/issues/470","number":470,"state":"closed","locked":false,"title":"Address k8s del_svc api change","user":{"login":"simon-mo","id":21118851,"avatar_url":"https://avatars3.githubusercontent.com/u/21118851?v=4","gravatar_id":"","url":"https://api.github.com/users/simon-mo","html_url":"https://github.com/simon-mo","followers_url":"https://api.github.com/users/simon-mo/followers","following_url":"https://api.github.com/users/simon-mo/following{/other_user}","gists_url":"https://api.github.com/users/simon-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/simon-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon-mo/subscriptions","organizations_url":"https://api.github.com/users/simon-mo/orgs","repos_url":"https://api.github.com/users/simon-mo/repos","events_url":"https://api.github.com/users/simon-mo/events{/privacy}","received_events_url":"https://api.github.com/users/simon-mo/received_events","type":"User","site_admin":false},"body":"Fix Kubernetes Container Manager:\r\n```\r\nCHANGELOG (Kubernetes)\r\ndelete_namespaced_service() now takes an required body (delete option) parameter. \r\nRefactor service storage to remove registry wrapper kubernetes/kubernetes#59510\r\n```\r\n\r\nSpec:\r\nhttps://github.com/kubernetes-client/python/blob/master/kubernetes/docs/CoreV1Api.md#delete_namespaced_service\r\n\r\nError like \r\n```\r\n  File \"/Users/simonmo/Desktop/clipper/clipper/clipper_admin/clipper_admin/kubernetes/kubernetes_container_manager.py\", line 393, in stop_all\r\n    namespace='default', name=service_name)\r\nTypeError: delete_namespaced_service() takes exactly 4 arguments (3 given)\r\n``` \r\nwill now go away. \r\n","created_at":"2018-04-13T22:39:12Z","updated_at":"2018-04-18T22:30:30Z","closed_at":"2018-04-18T22:30:30Z","merged_at":"2018-04-18T22:30:30Z","merge_commit_sha":"4a6533a845ab24c42ee3e5663f08c9ef9cacd0c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":526514671,"url":"https://api.github.com/repos/ucbrise/clipper/labels/status:%20needs%20review","name":"status: needs review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ucbrise/clipper/pulls/470/commits","review_comments_url":"https://api.github.com/repos/ucbrise/clipper/pulls/470/comments","review_comment_url":"https://api.github.com/repos/ucbrise/clipper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ucbrise/clipper/issues/470/comments","statuses_url":"https://api.github.com/repos/ucbrise/clipper/statuses/7d91b17cb98a47d29d691463401bf7cccbd986a5","head":{"label":"ucbrise:k8s_del_svc_fix","ref":"k8s_del_svc_fix","sha":"7d91b17cb98a47d29d691463401bf7cccbd986a5","user":{"login":"ucbrise","id":20959024,"avatar_url":"https://avatars2.githubusercontent.com/u/20959024?v=4","gravatar_id":"","url":"https://api.github.com/users/ucbrise","html_url":"https://github.com/ucbrise","followers_url":"https://api.github.com/users/ucbrise/followers","following_url":"https://api.github.com/users/ucbrise/following{/other_user}","gists_url":"https://api.github.com/users/ucbrise/gists{/gist_id}","starred_url":"https://api.github.com/users/ucbrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucbrise/subscriptions","organizations_url":"https://api.github.com/users/ucbrise/orgs","repos_url":"https://api.github.com/users/ucbrise/repos","events_url":"https://api.github.com/users/ucbrise/events{/privacy}","received_events_url":"https://api.github.com/users/ucbrise/received_events","type":"Organization","site_admin":false},"repo":{"id":72132009,"name":"clipper","full_name":"ucbrise/clipper","owner":{"login":"ucbrise","id":20959024,"avatar_url":"https://avatars2.githubusercontent.com/u/20959024?v=4","gravatar_id":"","url":"https://api.github.com/users/ucbrise","html_url":"https://github.com/ucbrise","followers_url":"https://api.github.com/users/ucbrise/followers","following_url":"https://api.github.com/users/ucbrise/following{/other_user}","gists_url":"https://api.github.com/users/ucbrise/gists{/gist_id}","starred_url":"https://api.github.com/users/ucbrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucbrise/subscriptions","organizations_url":"https://api.github.com/users/ucbrise/orgs","repos_url":"https://api.github.com/users/ucbrise/repos","events_url":"https://api.github.com/users/ucbrise/events{/privacy}","received_events_url":"https://api.github.com/users/ucbrise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucbrise/clipper","description":"A low-latency prediction-serving system","fork":false,"url":"https://api.github.com/repos/ucbrise/clipper","forks_url":"https://api.github.com/repos/ucbrise/clipper/forks","keys_url":"https://api.github.com/repos/ucbrise/clipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucbrise/clipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucbrise/clipper/teams","hooks_url":"https://api.github.com/repos/ucbrise/clipper/hooks","issue_events_url":"https://api.github.com/repos/ucbrise/clipper/issues/events{/number}","events_url":"https://api.github.com/repos/ucbrise/clipper/events","assignees_url":"https://api.github.com/repos/ucbrise/clipper/assignees{/user}","branches_url":"https://api.github.com/repos/ucbrise/clipper/branches{/branch}","tags_url":"https://api.github.com/repos/ucbrise/clipper/tags","blobs_url":"https://api.github.com/repos/ucbrise/clipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucbrise/clipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucbrise/clipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucbrise/clipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucbrise/clipper/statuses/{sha}","languages_url":"https://api.github.com/repos/ucbrise/clipper/languages","stargazers_url":"https://api.github.com/repos/ucbrise/clipper/stargazers","contributors_url":"https://api.github.com/repos/ucbrise/clipper/contributors","subscribers_url":"https://api.github.com/repos/ucbrise/clipper/subscribers","subscription_url":"https://api.github.com/repos/ucbrise/clipper/subscription","commits_url":"https://api.github.com/repos/ucbrise/clipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucbrise/clipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucbrise/clipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucbrise/clipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucbrise/clipper/contents/{+path}","compare_url":"https://api.github.com/repos/ucbrise/clipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucbrise/clipper/merges","archive_url":"https://api.github.com/repos/ucbrise/clipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucbrise/clipper/downloads","issues_url":"https://api.github.com/repos/ucbrise/clipper/issues{/number}","pulls_url":"https://api.github.com/repos/ucbrise/clipper/pulls{/number}","milestones_url":"https://api.github.com/repos/ucbrise/clipper/milestones{/number}","notifications_url":"https://api.github.com/repos/ucbrise/clipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucbrise/clipper/labels{/name}","releases_url":"https://api.github.com/repos/ucbrise/clipper/releases{/id}","deployments_url":"https://api.github.com/repos/ucbrise/clipper/deployments","created_at":"2016-10-27T17:30:27Z","updated_at":"2018-04-18T19:12:32Z","pushed_at":"2018-04-18T22:30:30Z","git_url":"git://github.com/ucbrise/clipper.git","ssh_url":"git@github.com:ucbrise/clipper.git","clone_url":"https://github.com/ucbrise/clipper.git","svn_url":"https://github.com/ucbrise/clipper","homepage":"http://clipper.ai","size":23865,"stargazers_count":514,"watchers_count":514,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":117,"open_issues":71,"watchers":514,"default_branch":"develop"}},"base":{"label":"ucbrise:develop","ref":"develop","sha":"026aca69497bce58b7cf6f4454a177b83866e320","user":{"login":"ucbrise","id":20959024,"avatar_url":"https://avatars2.githubusercontent.com/u/20959024?v=4","gravatar_id":"","url":"https://api.github.com/users/ucbrise","html_url":"https://github.com/ucbrise","followers_url":"https://api.github.com/users/ucbrise/followers","following_url":"https://api.github.com/users/ucbrise/following{/other_user}","gists_url":"https://api.github.com/users/ucbrise/gists{/gist_id}","starred_url":"https://api.github.com/users/ucbrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucbrise/subscriptions","organizations_url":"https://api.github.com/users/ucbrise/orgs","repos_url":"https://api.github.com/users/ucbrise/repos","events_url":"https://api.github.com/users/ucbrise/events{/privacy}","received_events_url":"https://api.github.com/users/ucbrise/received_events","type":"Organization","site_admin":false},"repo":{"id":72132009,"name":"clipper","full_name":"ucbrise/clipper","owner":{"login":"ucbrise","id":20959024,"avatar_url":"https://avatars2.githubusercontent.com/u/20959024?v=4","gravatar_id":"","url":"https://api.github.com/users/ucbrise","html_url":"https://github.com/ucbrise","followers_url":"https://api.github.com/users/ucbrise/followers","following_url":"https://api.github.com/users/ucbrise/following{/other_user}","gists_url":"https://api.github.com/users/ucbrise/gists{/gist_id}","starred_url":"https://api.github.com/users/ucbrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucbrise/subscriptions","organizations_url":"https://api.github.com/users/ucbrise/orgs","repos_url":"https://api.github.com/users/ucbrise/repos","events_url":"https://api.github.com/users/ucbrise/events{/privacy}","received_events_url":"https://api.github.com/users/ucbrise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucbrise/clipper","description":"A low-latency prediction-serving system","fork":false,"url":"https://api.github.com/repos/ucbrise/clipper","forks_url":"https://api.github.com/repos/ucbrise/clipper/forks","keys_url":"https://api.github.com/repos/ucbrise/clipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucbrise/clipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucbrise/clipper/teams","hooks_url":"https://api.github.com/repos/ucbrise/clipper/hooks","issue_events_url":"https://api.github.com/repos/ucbrise/clipper/issues/events{/number}","events_url":"https://api.github.com/repos/ucbrise/clipper/events","assignees_url":"https://api.github.com/repos/ucbrise/clipper/assignees{/user}","branches_url":"https://api.github.com/repos/ucbrise/clipper/branches{/branch}","tags_url":"https://api.github.com/repos/ucbrise/clipper/tags","blobs_url":"https://api.github.com/repos/ucbrise/clipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucbrise/clipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucbrise/clipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucbrise/clipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucbrise/clipper/statuses/{sha}","languages_url":"https://api.github.com/repos/ucbrise/clipper/languages","stargazers_url":"https://api.github.com/repos/ucbrise/clipper/stargazers","contributors_url":"https://api.github.com/repos/ucbrise/clipper/contributors","subscribers_url":"https://api.github.com/repos/ucbrise/clipper/subscribers","subscription_url":"https://api.github.com/repos/ucbrise/clipper/subscription","commits_url":"https://api.github.com/repos/ucbrise/clipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucbrise/clipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucbrise/clipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucbrise/clipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucbrise/clipper/contents/{+path}","compare_url":"https://api.github.com/repos/ucbrise/clipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucbrise/clipper/merges","archive_url":"https://api.github.com/repos/ucbrise/clipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucbrise/clipper/downloads","issues_url":"https://api.github.com/repos/ucbrise/clipper/issues{/number}","pulls_url":"https://api.github.com/repos/ucbrise/clipper/pulls{/number}","milestones_url":"https://api.github.com/repos/ucbrise/clipper/milestones{/number}","notifications_url":"https://api.github.com/repos/ucbrise/clipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucbrise/clipper/labels{/name}","releases_url":"https://api.github.com/repos/ucbrise/clipper/releases{/id}","deployments_url":"https://api.github.com/repos/ucbrise/clipper/deployments","created_at":"2016-10-27T17:30:27Z","updated_at":"2018-04-18T19:12:32Z","pushed_at":"2018-04-18T22:30:30Z","git_url":"git://github.com/ucbrise/clipper.git","ssh_url":"git@github.com:ucbrise/clipper.git","clone_url":"https://github.com/ucbrise/clipper.git","svn_url":"https://github.com/ucbrise/clipper","homepage":"http://clipper.ai","size":23865,"stargazers_count":514,"watchers_count":514,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":117,"open_issues":71,"watchers":514,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ucbrise/clipper/pulls/470"},"html":{"href":"https://github.com/ucbrise/clipper/pull/470"},"issue":{"href":"https://api.github.com/repos/ucbrise/clipper/issues/470"},"comments":{"href":"https://api.github.com/repos/ucbrise/clipper/issues/470/comments"},"review_comments":{"href":"https://api.github.com/repos/ucbrise/clipper/pulls/470/comments"},"review_comment":{"href":"https://api.github.com/repos/ucbrise/clipper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ucbrise/clipper/pulls/470/commits"},"statuses":{"href":"https://api.github.com/repos/ucbrise/clipper/statuses/7d91b17cb98a47d29d691463401bf7cccbd986a5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dcrankshaw","id":431588,"avatar_url":"https://avatars1.githubusercontent.com/u/431588?v=4","gravatar_id":"","url":"https://api.github.com/users/dcrankshaw","html_url":"https://github.com/dcrankshaw","followers_url":"https://api.github.com/users/dcrankshaw/followers","following_url":"https://api.github.com/users/dcrankshaw/following{/other_user}","gists_url":"https://api.github.com/users/dcrankshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcrankshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcrankshaw/subscriptions","organizations_url":"https://api.github.com/users/dcrankshaw/orgs","repos_url":"https://api.github.com/users/dcrankshaw/repos","events_url":"https://api.github.com/users/dcrankshaw/events{/privacy}","received_events_url":"https://api.github.com/users/dcrankshaw/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":7,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"dcrankshaw"}}