{"action":"created","comment":{"url":"https://api.github.com/repos/concord-consortium/rigse/pulls/comments/226145833","pull_request_review_id":165897872,"id":226145833,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjE0NTgzMw==","diff_hunk":"@@ -38,12 +38,24 @@\n \n   describe \"POST #create\" do\n     context \"with valid teacher params\" do\n+      let(:finish_enews_subscription) { double(\"finish_enews_subscription\") }\n+\n       it \"creates a new teacher\" do\n         old_teachers_count = Portal::Teacher.count\n         post :create, teacher_params\n         expect(response.status).to eq(201)\n         expect(Portal::Teacher.count).to eq(old_teachers_count + 1)\n       end\n+\n+      it \"creates a new teacher by SSO\" do\n+        user = create(:user)\n+        allow(controller).to receive(:current_user) { user }","path":"spec/controllers/api/v1/teachers_controller_spec.rb","position":15,"original_position":15,"commit_id":"5e7e0c31b34d0f61ee44b7796a4922b6e058bed4","original_commit_id":"5e7e0c31b34d0f61ee44b7796a4922b6e058bed4","user":{"login":"emcelroy","id":367459,"node_id":"MDQ6VXNlcjM2NzQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/367459?v=4","gravatar_id":"","url":"https://api.github.com/users/emcelroy","html_url":"https://github.com/emcelroy","followers_url":"https://api.github.com/users/emcelroy/followers","following_url":"https://api.github.com/users/emcelroy/following{/other_user}","gists_url":"https://api.github.com/users/emcelroy/gists{/gist_id}","starred_url":"https://api.github.com/users/emcelroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emcelroy/subscriptions","organizations_url":"https://api.github.com/users/emcelroy/orgs","repos_url":"https://api.github.com/users/emcelroy/repos","events_url":"https://api.github.com/users/emcelroy/events{/privacy}","received_events_url":"https://api.github.com/users/emcelroy/received_events","type":"User","site_admin":false},"body":"@scytacki I see, thanks. I've just tried that though and the test fails. It's gone back to saying that current_user is nil.","created_at":"2018-10-18T01:39:59Z","updated_at":"2018-10-18T01:39:59Z","html_url":"https://github.com/concord-consortium/rigse/pull/635#discussion_r226145833","pull_request_url":"https://api.github.com/repos/concord-consortium/rigse/pulls/635","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/rigse/pulls/comments/226145833"},"html":{"href":"https://github.com/concord-consortium/rigse/pull/635#discussion_r226145833"},"pull_request":{"href":"https://api.github.com/repos/concord-consortium/rigse/pulls/635"}},"in_reply_to_id":226140001},"pull_request":{"url":"https://api.github.com/repos/concord-consortium/rigse/pulls/635","id":221814751,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODE0NzUx","html_url":"https://github.com/concord-consortium/rigse/pull/635","diff_url":"https://github.com/concord-consortium/rigse/pull/635.diff","patch_url":"https://github.com/concord-consortium/rigse/pull/635.patch","issue_url":"https://api.github.com/repos/concord-consortium/rigse/issues/635","number":635,"state":"open","locked":false,"title":"Moved registration user.confirm call to student and teacher controllers","user":{"login":"emcelroy","id":367459,"node_id":"MDQ6VXNlcjM2NzQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/367459?v=4","gravatar_id":"","url":"https://api.github.com/users/emcelroy","html_url":"https://github.com/emcelroy","followers_url":"https://api.github.com/users/emcelroy/followers","following_url":"https://api.github.com/users/emcelroy/following{/other_user}","gists_url":"https://api.github.com/users/emcelroy/gists{/gist_id}","starred_url":"https://api.github.com/users/emcelroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emcelroy/subscriptions","organizations_url":"https://api.github.com/users/emcelroy/orgs","repos_url":"https://api.github.com/users/emcelroy/repos","events_url":"https://api.github.com/users/emcelroy/events{/privacy}","received_events_url":"https://api.github.com/users/emcelroy/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-10T14:36:17Z","updated_at":"2018-10-18T01:39:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef3176c9da64460c1083ab211125a6349d8e2396","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/concord-consortium/rigse/pulls/635/commits","review_comments_url":"https://api.github.com/repos/concord-consortium/rigse/pulls/635/comments","review_comment_url":"https://api.github.com/repos/concord-consortium/rigse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concord-consortium/rigse/issues/635/comments","statuses_url":"https://api.github.com/repos/concord-consortium/rigse/statuses/5e7e0c31b34d0f61ee44b7796a4922b6e058bed4","head":{"label":"concord-consortium:sso-mailchimp-integration","ref":"sso-mailchimp-integration","sha":"5e7e0c31b34d0f61ee44b7796a4922b6e058bed4","user":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":2056634,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU2NjM0","name":"rigse","full_name":"concord-consortium/rigse","private":false,"owner":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/concord-consortium/rigse","description":"Concord Consortium Portal somewhat like an LMS","fork":false,"url":"https://api.github.com/repos/concord-consortium/rigse","forks_url":"https://api.github.com/repos/concord-consortium/rigse/forks","keys_url":"https://api.github.com/repos/concord-consortium/rigse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/rigse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/rigse/teams","hooks_url":"https://api.github.com/repos/concord-consortium/rigse/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/rigse/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/rigse/events","assignees_url":"https://api.github.com/repos/concord-consortium/rigse/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/rigse/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/rigse/tags","blobs_url":"https://api.github.com/repos/concord-consortium/rigse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/rigse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/rigse/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/rigse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/rigse/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/rigse/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/rigse/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/rigse/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/rigse/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/rigse/subscription","commits_url":"https://api.github.com/repos/concord-consortium/rigse/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/rigse/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/rigse/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/rigse/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/rigse/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/rigse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/rigse/merges","archive_url":"https://api.github.com/repos/concord-consortium/rigse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/rigse/downloads","issues_url":"https://api.github.com/repos/concord-consortium/rigse/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/rigse/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/rigse/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/rigse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/rigse/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/rigse/releases{/id}","deployments_url":"https://api.github.com/repos/concord-consortium/rigse/deployments","created_at":"2011-07-16T03:22:38Z","updated_at":"2018-10-18T01:12:37Z","pushed_at":"2018-10-18T01:12:37Z","git_url":"git://github.com/concord-consortium/rigse.git","ssh_url":"git@github.com:concord-consortium/rigse.git","clone_url":"https://github.com/concord-consortium/rigse.git","svn_url":"https://github.com/concord-consortium/rigse","homepage":"","size":82193,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":50,"watchers":6,"default_branch":"master"}},"base":{"label":"concord-consortium:master","ref":"master","sha":"6af56597c97334b71ede07caebf7dd36c72e949e","user":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":2056634,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU2NjM0","name":"rigse","full_name":"concord-consortium/rigse","private":false,"owner":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/concord-consortium/rigse","description":"Concord Consortium Portal somewhat like an LMS","fork":false,"url":"https://api.github.com/repos/concord-consortium/rigse","forks_url":"https://api.github.com/repos/concord-consortium/rigse/forks","keys_url":"https://api.github.com/repos/concord-consortium/rigse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/rigse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/rigse/teams","hooks_url":"https://api.github.com/repos/concord-consortium/rigse/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/rigse/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/rigse/events","assignees_url":"https://api.github.com/repos/concord-consortium/rigse/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/rigse/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/rigse/tags","blobs_url":"https://api.github.com/repos/concord-consortium/rigse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/rigse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/rigse/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/rigse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/rigse/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/rigse/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/rigse/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/rigse/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/rigse/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/rigse/subscription","commits_url":"https://api.github.com/repos/concord-consortium/rigse/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/rigse/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/rigse/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/rigse/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/rigse/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/rigse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/rigse/merges","archive_url":"https://api.github.com/repos/concord-consortium/rigse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/rigse/downloads","issues_url":"https://api.github.com/repos/concord-consortium/rigse/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/rigse/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/rigse/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/rigse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/rigse/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/rigse/releases{/id}","deployments_url":"https://api.github.com/repos/concord-consortium/rigse/deployments","created_at":"2011-07-16T03:22:38Z","updated_at":"2018-10-18T01:12:37Z","pushed_at":"2018-10-18T01:12:37Z","git_url":"git://github.com/concord-consortium/rigse.git","ssh_url":"git@github.com:concord-consortium/rigse.git","clone_url":"https://github.com/concord-consortium/rigse.git","svn_url":"https://github.com/concord-consortium/rigse","homepage":"","size":82193,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":50,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/rigse/pulls/635"},"html":{"href":"https://github.com/concord-consortium/rigse/pull/635"},"issue":{"href":"https://api.github.com/repos/concord-consortium/rigse/issues/635"},"comments":{"href":"https://api.github.com/repos/concord-consortium/rigse/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/concord-consortium/rigse/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/concord-consortium/rigse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concord-consortium/rigse/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/concord-consortium/rigse/statuses/5e7e0c31b34d0f61ee44b7796a4922b6e058bed4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"emcelroy"}}