{"action":"created","issue":{"url":"https://api.github.com/repos/quantumlib/OpenFermion-ProjectQ/issues/42","repository_url":"https://api.github.com/repos/quantumlib/OpenFermion-ProjectQ","labels_url":"https://api.github.com/repos/quantumlib/OpenFermion-ProjectQ/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/quantumlib/OpenFermion-ProjectQ/issues/42/comments","events_url":"https://api.github.com/repos/quantumlib/OpenFermion-ProjectQ/issues/42/events","html_url":"https://github.com/quantumlib/OpenFermion-ProjectQ/pull/42","id":307127880,"number":42,"title":"Rename UCCSD functions (without fixing breaking changes)","user":{"login":"kevinsung","id":4296166,"avatar_url":"https://avatars1.githubusercontent.com/u/4296166?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinsung","html_url":"https://github.com/kevinsung","followers_url":"https://api.github.com/users/kevinsung/followers","following_url":"https://api.github.com/users/kevinsung/following{/other_user}","gists_url":"https://api.github.com/users/kevinsung/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinsung/subscriptions","organizations_url":"https://api.github.com/users/kevinsung/orgs","repos_url":"https://api.github.com/users/kevinsung/repos","events_url":"https://api.github.com/users/kevinsung/events{/privacy}","received_events_url":"https://api.github.com/users/kevinsung/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-21T05:58:08Z","updated_at":"2018-03-21T17:25:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/quantumlib/OpenFermion-ProjectQ/pulls/42","html_url":"https://github.com/quantumlib/OpenFermion-ProjectQ/pull/42","diff_url":"https://github.com/quantumlib/OpenFermion-ProjectQ/pull/42.diff","patch_url":"https://github.com/quantumlib/OpenFermion-ProjectQ/pull/42.patch"},"body":"PRs https://github.com/quantumlib/OpenFermion/pull/257 and https://github.com/quantumlib/OpenFermion/pull/267 renamed some functions and in this PR I port over these name changes.\r\n\r\nThere is one thing though: the changes made in those PRs break the tests `UnitaryCC.test_simulation_energy` and `UnitaryCC.test_simulation_with_graph` in `openfermionprojectq/_unitary_cc_test.py`. That needs to be fixed before the next version release. These tests are quite opaque to me; I don't know where these hard-coded values came from and it's hard for me to tell from reading the source code what exactly `uccsd_trotter_engine` does. Can somebody else take a look at this? I might be able to fix it with some help/advice/suggestions."},"comment":{"url":"https://api.github.com/repos/quantumlib/OpenFermion-ProjectQ/issues/comments/375027533","html_url":"https://github.com/quantumlib/OpenFermion-ProjectQ/pull/42#issuecomment-375027533","issue_url":"https://api.github.com/repos/quantumlib/OpenFermion-ProjectQ/issues/42","id":375027533,"user":{"login":"kevinsung","id":4296166,"avatar_url":"https://avatars1.githubusercontent.com/u/4296166?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinsung","html_url":"https://github.com/kevinsung","followers_url":"https://api.github.com/users/kevinsung/followers","following_url":"https://api.github.com/users/kevinsung/following{/other_user}","gists_url":"https://api.github.com/users/kevinsung/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinsung/subscriptions","organizations_url":"https://api.github.com/users/kevinsung/orgs","repos_url":"https://api.github.com/users/kevinsung/repos","events_url":"https://api.github.com/users/kevinsung/events{/privacy}","received_events_url":"https://api.github.com/users/kevinsung/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T17:25:52Z","updated_at":"2018-03-21T17:25:52Z","author_association":"NONE","body":"The problem is that the energies don't match after changing names. I also would rather not spend time on this."}}
{"actor":{"display_login":"kevinsung"}}