{"action":"created","issue":{"url":"https://api.github.com/repos/DFHack/df-structures/issues/267","repository_url":"https://api.github.com/repos/DFHack/df-structures","labels_url":"https://api.github.com/repos/DFHack/df-structures/issues/267/labels{/name}","comments_url":"https://api.github.com/repos/DFHack/df-structures/issues/267/comments","events_url":"https://api.github.com/repos/DFHack/df-structures/issues/267/events","html_url":"https://github.com/DFHack/df-structures/pull/267","id":334229667,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjU2OTA1","number":267,"title":"Add hex values to df enums","user":{"login":"suokko","id":113864,"node_id":"MDQ6VXNlcjExMzg2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/113864?v=4","gravatar_id":"","url":"https://api.github.com/users/suokko","html_url":"https://github.com/suokko","followers_url":"https://api.github.com/users/suokko/followers","following_url":"https://api.github.com/users/suokko/following{/other_user}","gists_url":"https://api.github.com/users/suokko/gists{/gist_id}","starred_url":"https://api.github.com/users/suokko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suokko/subscriptions","organizations_url":"https://api.github.com/users/suokko/orgs","repos_url":"https://api.github.com/users/suokko/repos","events_url":"https://api.github.com/users/suokko/events{/privacy}","received_events_url":"https://api.github.com/users/suokko/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-20T20:05:12Z","updated_at":"2018-06-20T20:35:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DFHack/df-structures/pulls/267","html_url":"https://github.com/DFHack/df-structures/pull/267","diff_url":"https://github.com/DFHack/df-structures/pull/267.diff","patch_url":"https://github.com/DFHack/df-structures/pull/267.patch"},"body":"Seeing enum values in header makes it easier to match those values to\r\ndissambler numbers. This helps me with both gdb and IDA. IDA has descent\r\nsuppot for offsets and constands but it requires manual setup. To help\r\nmatching values manually I like to browser headers in my source editor\r\nbecause it is the fastest tool to find types and variables."},"comment":{"url":"https://api.github.com/repos/DFHack/df-structures/issues/comments/398887655","html_url":"https://github.com/DFHack/df-structures/pull/267#issuecomment-398887655","issue_url":"https://api.github.com/repos/DFHack/df-structures/issues/267","id":398887655,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODg4NzY1NQ==","user":{"login":"suokko","id":113864,"node_id":"MDQ6VXNlcjExMzg2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/113864?v=4","gravatar_id":"","url":"https://api.github.com/users/suokko","html_url":"https://github.com/suokko","followers_url":"https://api.github.com/users/suokko/followers","following_url":"https://api.github.com/users/suokko/following{/other_user}","gists_url":"https://api.github.com/users/suokko/gists{/gist_id}","starred_url":"https://api.github.com/users/suokko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suokko/subscriptions","organizations_url":"https://api.github.com/users/suokko/orgs","repos_url":"https://api.github.com/users/suokko/repos","events_url":"https://api.github.com/users/suokko/events{/privacy}","received_events_url":"https://api.github.com/users/suokko/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T20:35:02Z","updated_at":"2018-06-20T20:35:02Z","author_association":"CONTRIBUTOR","body":"I first tried to make all hex but compiler choked on negative values which was easiest to fix with conditional hex values. (too wide number for the enum type or something like that)"}}
{"actor":{"display_login":"suokko"}}