{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/22735","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/22735/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/22735/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/22735/events","html_url":"https://github.com/cockroachdb/cockroach/pull/22735","id":297505184,"number":22735,"title":"sql: fix NULL handling in index constraints for tuple IN tuple","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars1.githubusercontent.com/u/16544120?v=4","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-02-15T16:16:08Z","updated_at":"2018-02-15T18:36:18Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/22735","html_url":"https://github.com/cockroachdb/cockroach/pull/22735","diff_url":"https://github.com/cockroachdb/cockroach/pull/22735.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/22735.patch"},"body":"This is the second (much easier) part of #22670.\r\n\r\n#### sql: fix NULL handling in index constraints for tuple IN tuple\r\n\r\nWe were incorrectly generating spans that contain NULL values. Since\r\nNULL is not equal to NULL, these tuples can be discarded.\r\n\r\nFixes #22670.\r\n\r\nRelease note (bug fix): Fixed incorrect query results when the WHERE\r\ncondition contains IN expressions where the right-hand side tuple\r\ncontains NULLs.\r\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/366020459","html_url":"https://github.com/cockroachdb/cockroach/pull/22735#issuecomment-366020459","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/22735","id":366020459,"user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars1.githubusercontent.com/u/16544120?v=4","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T18:36:18Z","updated_at":"2018-02-15T18:36:18Z","author_association":"OWNER","body":"What kind of normalization rule did you have in mind? Note that `(1, 1) IN ((1, NULL), (2, 2))` can't in general be replaced by `(1, 1) IN ((2, 2))` (the former is NULL, the latter is false). Would it be a rule that only applies to filters?\n\n---\n\nReview status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/22735#-:-L5PjE8P6rGVzcL6Ve-N:b31t3n1)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"RaduBerinde"}}