{"action":"opened","issue":{"url":"https://api.github.com/repos/cmsimple-xh/cmsimple-xh/issues/376","repository_url":"https://api.github.com/repos/cmsimple-xh/cmsimple-xh","labels_url":"https://api.github.com/repos/cmsimple-xh/cmsimple-xh/issues/376/labels{/name}","comments_url":"https://api.github.com/repos/cmsimple-xh/cmsimple-xh/issues/376/comments","events_url":"https://api.github.com/repos/cmsimple-xh/cmsimple-xh/issues/376/events","html_url":"https://github.com/cmsimple-xh/cmsimple-xh/issues/376","id":378508426,"node_id":"MDU6SXNzdWUzNzg1MDg0MjY=","number":376,"title":"Failing to start session is not handled","user":{"login":"cmb69","id":2306138,"node_id":"MDQ6VXNlcjIzMDYxMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/2306138?v=4","gravatar_id":"","url":"https://api.github.com/users/cmb69","html_url":"https://github.com/cmb69","followers_url":"https://api.github.com/users/cmb69/followers","following_url":"https://api.github.com/users/cmb69/following{/other_user}","gists_url":"https://api.github.com/users/cmb69/gists{/gist_id}","starred_url":"https://api.github.com/users/cmb69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmb69/subscriptions","organizations_url":"https://api.github.com/users/cmb69/orgs","repos_url":"https://api.github.com/users/cmb69/repos","events_url":"https://api.github.com/users/cmb69/events{/privacy}","received_events_url":"https://api.github.com/users/cmb69/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-07T23:07:30Z","updated_at":"2018-11-07T23:07:30Z","closed_at":null,"author_association":"MEMBER","body":"[`XH_startSession()`](https://github.com/cmsimple-xh/cmsimple-xh/blob/master/cmsimple/functions.php#L2510-L2529) tries to write to a file, to set the session name, and finally to start the session, without checking whether these operations succeeded, and consequently is a `void function`. This needs to be improved.\r\n\r\nNo concrete idea how to properly handle the overall conduct, but perhaps responding with `503 Service Unavailable` (and showing an explaining message; using the built-in template?), if the session couldn't be started, would be good.\r\n\r\nSuggestions welcome!"}}
{"actor":{"display_login":"cmb69"}}