{"action":"created","comment":{"url":"https://api.github.com/repos/rchain/rchain/pulls/comments/198853951","pull_request_review_id":132859064,"id":198853951,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODg1Mzk1MQ==","diff_hunk":"@@ -46,11 +46,16 @@ object StoreMetrics extends StoreMetricsInstances {\n         g(\"total-size-on-disk\", storeSize.totalSizeOnDisk),\n         g(\"rspace-size-on-disk\", storeSize.rspaceSizeOnDisk),\n         g(\"rspace-data-entries\", storeSize.rspaceDataEntries),\n-        pc(\"rspace-consumes\", storeSize.rspaceConsumesCount),\n-        pc(\"rspace-produces\", storeSize.rspaceProducesCount),\n-        cm(\"rspace-consumes-COMM\", storeSize.rspaceConsumesCommCount),\n-        cm(\"rspace-produces-COMM\", storeSize.rspaceProducesCommCount),\n-        cm(\"rspace-install-COMM\", storeSize.rspaceInstallCommCount)\n+        pc(\"rspace-consumes\", storeSize.rspace.flatMap(_.consumes)),\n+        pc(\"rspace-produces\", storeSize.rspace.flatMap(_.produces)),\n+        cm(\"rspace-consumes-COMM\", storeSize.rspace.flatMap(_.consumesComm)),\n+        cm(\"rspace-produces-COMM\", storeSize.rspace.flatMap(_.producesComm)),\n+        cm(\"rspace-install-COMM\", storeSize.rspace.flatMap(_.installComm)),\n+        pc(\"replayrspace-consumes\", storeSize.replayRSpace.flatMap(_.consumes)),\n+        pc(\"replayrspace-produces\", storeSize.replayRSpace.flatMap(_.produces)),\n+        cm(\"replayrspace-consumes-COMM\", storeSize.replayRSpace.flatMap(_.consumesComm)),\n+        cm(\"replayrspace-produces-COMM\", storeSize.replayRSpace.flatMap(_.producesComm)),\n+        cm(\"replayrspace-install-COMM\", storeSize.replayRSpace.flatMap(_.installComm))","path":"node/src/main/scala/coop/rchain/node/diagnostics/StoreMetrics.scala","position":null,"original_position":44,"commit_id":"1b653e6792ae0fe6cec768d342e5c78705e146d1","original_commit_id":"81d667b5e05e8dc2846a56390074d72a5e3418da","user":{"login":"lukasz-golebiewski","id":6169602,"node_id":"MDQ6VXNlcjYxNjk2MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6169602?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasz-golebiewski","html_url":"https://github.com/lukasz-golebiewski","followers_url":"https://api.github.com/users/lukasz-golebiewski/followers","following_url":"https://api.github.com/users/lukasz-golebiewski/following{/other_user}","gists_url":"https://api.github.com/users/lukasz-golebiewski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasz-golebiewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasz-golebiewski/subscriptions","organizations_url":"https://api.github.com/users/lukasz-golebiewski/orgs","repos_url":"https://api.github.com/users/lukasz-golebiewski/repos","events_url":"https://api.github.com/users/lukasz-golebiewski/events{/privacy}","received_events_url":"https://api.github.com/users/lukasz-golebiewski/received_events","type":"User","site_admin":false},"body":"It would make sense if we had some nested case classes here, but we don't. I'm going to extract a helper function though","created_at":"2018-06-28T14:08:35Z","updated_at":"2018-06-28T14:08:35Z","html_url":"https://github.com/rchain/rchain/pull/1052#discussion_r198853951","pull_request_url":"https://api.github.com/repos/rchain/rchain/pulls/1052","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments/198853951"},"html":{"href":"https://github.com/rchain/rchain/pull/1052#discussion_r198853951"},"pull_request":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1052"}},"in_reply_to_id":198838111},"pull_request":{"url":"https://api.github.com/repos/rchain/rchain/pulls/1052","id":198020405,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDIwNDA1","html_url":"https://github.com/rchain/rchain/pull/1052","diff_url":"https://github.com/rchain/rchain/pull/1052.diff","patch_url":"https://github.com/rchain/rchain/pull/1052.patch","issue_url":"https://api.github.com/repos/rchain/rchain/issues/1052","number":1052,"state":"open","locked":false,"title":"Rspace/core 749/metrics from both stores in casper runtime","user":{"login":"lukasz-golebiewski","id":6169602,"node_id":"MDQ6VXNlcjYxNjk2MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6169602?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasz-golebiewski","html_url":"https://github.com/lukasz-golebiewski","followers_url":"https://api.github.com/users/lukasz-golebiewski/followers","following_url":"https://api.github.com/users/lukasz-golebiewski/following{/other_user}","gists_url":"https://api.github.com/users/lukasz-golebiewski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasz-golebiewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasz-golebiewski/subscriptions","organizations_url":"https://api.github.com/users/lukasz-golebiewski/orgs","repos_url":"https://api.github.com/users/lukasz-golebiewski/repos","events_url":"https://api.github.com/users/lukasz-golebiewski/events{/privacy}","received_events_url":"https://api.github.com/users/lukasz-golebiewski/received_events","type":"User","site_admin":false},"body":"## Overview\r\nBefore: storage metrics from the rholang REPL runtime were reported. \r\nAfter: metrics from both Casper runtime storages (normal and replay) are going to be reported.\r\n\r\n### Does this PR relate to an RChain JIRA issue? \r\nhttps://rchain.atlassian.net/browse/CORE-749\r\n\r\n### Complete this checklist before you submit the PR\r\n- [ ] This PR contains no more than 200 lines of code, excluding test code.\r\n- [ ] This PR meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards).\r\n- [ ] You have someone in mind to assign for review. Make this assignment after submitting the PR.\r\n\r\n### Notes\r\nOptional. Add any notes on caveats, approaches you tried that didn't work, or anything else.\r\n","created_at":"2018-06-28T12:54:44Z","updated_at":"2018-06-28T14:08:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"794b2aa1e810f23eb1516f7fcece8af99ca20cc1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"henrytill","id":6430643,"node_id":"MDQ6VXNlcjY0MzA2NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/6430643?v=4","gravatar_id":"","url":"https://api.github.com/users/henrytill","html_url":"https://github.com/henrytill","followers_url":"https://api.github.com/users/henrytill/followers","following_url":"https://api.github.com/users/henrytill/following{/other_user}","gists_url":"https://api.github.com/users/henrytill/gists{/gist_id}","starred_url":"https://api.github.com/users/henrytill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrytill/subscriptions","organizations_url":"https://api.github.com/users/henrytill/orgs","repos_url":"https://api.github.com/users/henrytill/repos","events_url":"https://api.github.com/users/henrytill/events{/privacy}","received_events_url":"https://api.github.com/users/henrytill/received_events","type":"User","site_admin":false},{"login":"birchmd","id":13788876,"node_id":"MDQ6VXNlcjEzNzg4ODc2","avatar_url":"https://avatars1.githubusercontent.com/u/13788876?v=4","gravatar_id":"","url":"https://api.github.com/users/birchmd","html_url":"https://github.com/birchmd","followers_url":"https://api.github.com/users/birchmd/followers","following_url":"https://api.github.com/users/birchmd/following{/other_user}","gists_url":"https://api.github.com/users/birchmd/gists{/gist_id}","starred_url":"https://api.github.com/users/birchmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birchmd/subscriptions","organizations_url":"https://api.github.com/users/birchmd/orgs","repos_url":"https://api.github.com/users/birchmd/repos","events_url":"https://api.github.com/users/birchmd/events{/privacy}","received_events_url":"https://api.github.com/users/birchmd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rchain/rchain/pulls/1052/commits","review_comments_url":"https://api.github.com/repos/rchain/rchain/pulls/1052/comments","review_comment_url":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rchain/rchain/issues/1052/comments","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/1b653e6792ae0fe6cec768d342e5c78705e146d1","head":{"label":"lukasz-golebiewski:rspace/CORE-749/metrics-from-both-stores-in-casper-runtime","ref":"rspace/CORE-749/metrics-from-both-stores-in-casper-runtime","sha":"1b653e6792ae0fe6cec768d342e5c78705e146d1","user":{"login":"lukasz-golebiewski","id":6169602,"node_id":"MDQ6VXNlcjYxNjk2MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6169602?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasz-golebiewski","html_url":"https://github.com/lukasz-golebiewski","followers_url":"https://api.github.com/users/lukasz-golebiewski/followers","following_url":"https://api.github.com/users/lukasz-golebiewski/following{/other_user}","gists_url":"https://api.github.com/users/lukasz-golebiewski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasz-golebiewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasz-golebiewski/subscriptions","organizations_url":"https://api.github.com/users/lukasz-golebiewski/orgs","repos_url":"https://api.github.com/users/lukasz-golebiewski/repos","events_url":"https://api.github.com/users/lukasz-golebiewski/events{/privacy}","received_events_url":"https://api.github.com/users/lukasz-golebiewski/received_events","type":"User","site_admin":false},"repo":{"id":133328145,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzMjgxNDU=","name":"rchain","full_name":"lukasz-golebiewski/rchain","owner":{"login":"lukasz-golebiewski","id":6169602,"node_id":"MDQ6VXNlcjYxNjk2MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6169602?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasz-golebiewski","html_url":"https://github.com/lukasz-golebiewski","followers_url":"https://api.github.com/users/lukasz-golebiewski/followers","following_url":"https://api.github.com/users/lukasz-golebiewski/following{/other_user}","gists_url":"https://api.github.com/users/lukasz-golebiewski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasz-golebiewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasz-golebiewski/subscriptions","organizations_url":"https://api.github.com/users/lukasz-golebiewski/orgs","repos_url":"https://api.github.com/users/lukasz-golebiewski/repos","events_url":"https://api.github.com/users/lukasz-golebiewski/events{/privacy}","received_events_url":"https://api.github.com/users/lukasz-golebiewski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukasz-golebiewski/rchain","description":null,"fork":true,"url":"https://api.github.com/repos/lukasz-golebiewski/rchain","forks_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/forks","keys_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/teams","hooks_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/hooks","issue_events_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/events","assignees_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/tags","blobs_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/languages","stargazers_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/stargazers","contributors_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/contributors","subscribers_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/subscribers","subscription_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/subscription","commits_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/merges","archive_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/downloads","issues_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/labels{/name}","releases_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/lukasz-golebiewski/rchain/deployments","created_at":"2018-05-14T08:19:49Z","updated_at":"2018-05-14T08:19:53Z","pushed_at":"2018-06-28T13:46:39Z","git_url":"git://github.com/lukasz-golebiewski/rchain.git","ssh_url":"git@github.com:lukasz-golebiewski/rchain.git","clone_url":"https://github.com/lukasz-golebiewski/rchain.git","svn_url":"https://github.com/lukasz-golebiewski/rchain","homepage":null,"size":12086,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rchain:dev","ref":"dev","sha":"8ab1afe9807c6ee67f85311a68fa9d32ab621bcd","user":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"repo":{"id":84493691,"node_id":"MDEwOlJlcG9zaXRvcnk4NDQ5MzY5MQ==","name":"rchain","full_name":"rchain/rchain","owner":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rchain/rchain","description":null,"fork":false,"url":"https://api.github.com/repos/rchain/rchain","forks_url":"https://api.github.com/repos/rchain/rchain/forks","keys_url":"https://api.github.com/repos/rchain/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchain/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchain/rchain/teams","hooks_url":"https://api.github.com/repos/rchain/rchain/hooks","issue_events_url":"https://api.github.com/repos/rchain/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/rchain/rchain/events","assignees_url":"https://api.github.com/repos/rchain/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/rchain/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/rchain/rchain/tags","blobs_url":"https://api.github.com/repos/rchain/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchain/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchain/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchain/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/rchain/rchain/languages","stargazers_url":"https://api.github.com/repos/rchain/rchain/stargazers","contributors_url":"https://api.github.com/repos/rchain/rchain/contributors","subscribers_url":"https://api.github.com/repos/rchain/rchain/subscribers","subscription_url":"https://api.github.com/repos/rchain/rchain/subscription","commits_url":"https://api.github.com/repos/rchain/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchain/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchain/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchain/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchain/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/rchain/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchain/rchain/merges","archive_url":"https://api.github.com/repos/rchain/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchain/rchain/downloads","issues_url":"https://api.github.com/repos/rchain/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/rchain/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/rchain/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/rchain/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchain/rchain/labels{/name}","releases_url":"https://api.github.com/repos/rchain/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/rchain/rchain/deployments","created_at":"2017-03-09T22:15:35Z","updated_at":"2018-06-27T16:38:09Z","pushed_at":"2018-06-28T13:46:42Z","git_url":"git://github.com/rchain/rchain.git","ssh_url":"git@github.com:rchain/rchain.git","clone_url":"https://github.com/rchain/rchain.git","svn_url":"https://github.com/rchain/rchain","homepage":null,"size":12062,"stargazers_count":361,"watchers_count":361,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":103,"open_issues":16,"watchers":361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1052"},"html":{"href":"https://github.com/rchain/rchain/pull/1052"},"issue":{"href":"https://api.github.com/repos/rchain/rchain/issues/1052"},"comments":{"href":"https://api.github.com/repos/rchain/rchain/issues/1052/comments"},"review_comments":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1052/comments"},"review_comment":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1052/commits"},"statuses":{"href":"https://api.github.com/repos/rchain/rchain/statuses/1b653e6792ae0fe6cec768d342e5c78705e146d1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lukasz-golebiewski"}}