{"action":"created","issue":{"url":"https://api.github.com/repos/jeffwils/grails-spring-security-saml/issues/52","repository_url":"https://api.github.com/repos/jeffwils/grails-spring-security-saml","labels_url":"https://api.github.com/repos/jeffwils/grails-spring-security-saml/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/jeffwils/grails-spring-security-saml/issues/52/comments","events_url":"https://api.github.com/repos/jeffwils/grails-spring-security-saml/issues/52/events","html_url":"https://github.com/jeffwils/grails-spring-security-saml/issues/52","id":344601435,"node_id":"MDU6SXNzdWUzNDQ2MDE0MzU=","number":52,"title":"defaultFailureUrl should be configurable","user":{"login":"jnunderwood","id":5722763,"node_id":"MDQ6VXNlcjU3MjI3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5722763?v=4","gravatar_id":"","url":"https://api.github.com/users/jnunderwood","html_url":"https://github.com/jnunderwood","followers_url":"https://api.github.com/users/jnunderwood/followers","following_url":"https://api.github.com/users/jnunderwood/following{/other_user}","gists_url":"https://api.github.com/users/jnunderwood/gists{/gist_id}","starred_url":"https://api.github.com/users/jnunderwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnunderwood/subscriptions","organizations_url":"https://api.github.com/users/jnunderwood/orgs","repos_url":"https://api.github.com/users/jnunderwood/repos","events_url":"https://api.github.com/users/jnunderwood/events{/privacy}","received_events_url":"https://api.github.com/users/jnunderwood/received_events","type":"User","site_admin":false},"labels":[{"id":567239503,"node_id":"MDU6TGFiZWw1NjcyMzk1MDM=","url":"https://api.github.com/repos/jeffwils/grails-spring-security-saml/labels/duplicate","name":"duplicate","color":"cccccc","default":true}],"state":"open","locked":false,"assignee":{"login":"valentingoebel","id":31064343,"node_id":"MDQ6VXNlcjMxMDY0MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/31064343?v=4","gravatar_id":"","url":"https://api.github.com/users/valentingoebel","html_url":"https://github.com/valentingoebel","followers_url":"https://api.github.com/users/valentingoebel/followers","following_url":"https://api.github.com/users/valentingoebel/following{/other_user}","gists_url":"https://api.github.com/users/valentingoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/valentingoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valentingoebel/subscriptions","organizations_url":"https://api.github.com/users/valentingoebel/orgs","repos_url":"https://api.github.com/users/valentingoebel/repos","events_url":"https://api.github.com/users/valentingoebel/events{/privacy}","received_events_url":"https://api.github.com/users/valentingoebel/received_events","type":"User","site_admin":false},"assignees":[{"login":"valentingoebel","id":31064343,"node_id":"MDQ6VXNlcjMxMDY0MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/31064343?v=4","gravatar_id":"","url":"https://api.github.com/users/valentingoebel","html_url":"https://github.com/valentingoebel","followers_url":"https://api.github.com/users/valentingoebel/followers","following_url":"https://api.github.com/users/valentingoebel/following{/other_user}","gists_url":"https://api.github.com/users/valentingoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/valentingoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valentingoebel/subscriptions","organizations_url":"https://api.github.com/users/valentingoebel/orgs","repos_url":"https://api.github.com/users/valentingoebel/repos","events_url":"https://api.github.com/users/valentingoebel/events{/privacy}","received_events_url":"https://api.github.com/users/valentingoebel/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/jeffwils/grails-spring-security-saml/milestones/2","html_url":"https://github.com/jeffwils/grails-spring-security-saml/milestone/2","labels_url":"https://api.github.com/repos/jeffwils/grails-spring-security-saml/milestones/2/labels","id":3192360,"node_id":"MDk6TWlsZXN0b25lMzE5MjM2MA==","number":2,"title":"3.3.1","description":"Enhancements.","creator":{"login":"irstevenson","id":7528551,"node_id":"MDQ6VXNlcjc1Mjg1NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/7528551?v=4","gravatar_id":"","url":"https://api.github.com/users/irstevenson","html_url":"https://github.com/irstevenson","followers_url":"https://api.github.com/users/irstevenson/followers","following_url":"https://api.github.com/users/irstevenson/following{/other_user}","gists_url":"https://api.github.com/users/irstevenson/gists{/gist_id}","starred_url":"https://api.github.com/users/irstevenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irstevenson/subscriptions","organizations_url":"https://api.github.com/users/irstevenson/orgs","repos_url":"https://api.github.com/users/irstevenson/repos","events_url":"https://api.github.com/users/irstevenson/events{/privacy}","received_events_url":"https://api.github.com/users/irstevenson/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":15,"state":"open","created_at":"2018-03-16T06:10:26Z","updated_at":"2018-07-26T11:46:19Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-07-25T20:48:18Z","updated_at":"2018-07-26T11:46:40Z","closed_at":null,"author_association":"NONE","body":"The method `authenticationFailureHandler()` in the file `SpringSecuritySamlGrailsPlugin.groovy` has a hard-coded value for `defaultFailureUrl`. It references a `log4J` controller(?) that does not exist in the project, causing login failures to further fail in an unexpected way. It should have a more reasonable default value, such as `conf.failureHandler.defaultFailureUrl`.\r\n\r\n```\r\nSpringSecuritySamlGrailsPlugin.groovy:\r\n\r\nauthenticationFailureHandler(AjaxAwareAuthenticationFailureHandler) {\r\n    redirectStrategy = ref('redirectStrategy')\r\n    defaultFailureUrl = '/log4J/logging' //conf.failureHandler.defaultFailureUrl //'/login/authfail?login_error=1'\r\n    useForward = conf.failureHandler.useForward // false\r\n    ajaxAuthenticationFailureUrl = conf.failureHandler.ajaxAuthFailUrl // '/login/authfail?ajax=true'\r\n    exceptionMappings = conf.failureHandler.exceptionMappings // [:]\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/jeffwils/grails-spring-security-saml/issues/comments/408070243","html_url":"https://github.com/jeffwils/grails-spring-security-saml/issues/52#issuecomment-408070243","issue_url":"https://api.github.com/repos/jeffwils/grails-spring-security-saml/issues/52","id":408070243,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODA3MDI0Mw==","user":{"login":"valentingoebel","id":31064343,"node_id":"MDQ6VXNlcjMxMDY0MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/31064343?v=4","gravatar_id":"","url":"https://api.github.com/users/valentingoebel","html_url":"https://github.com/valentingoebel","followers_url":"https://api.github.com/users/valentingoebel/followers","following_url":"https://api.github.com/users/valentingoebel/following{/other_user}","gists_url":"https://api.github.com/users/valentingoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/valentingoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valentingoebel/subscriptions","organizations_url":"https://api.github.com/users/valentingoebel/orgs","repos_url":"https://api.github.com/users/valentingoebel/repos","events_url":"https://api.github.com/users/valentingoebel/events{/privacy}","received_events_url":"https://api.github.com/users/valentingoebel/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T11:46:40Z","updated_at":"2018-07-26T11:46:40Z","author_association":"COLLABORATOR","body":"This change has already been merged in the past into the develop branch (See [SpringSecuritySamlGrailsPlugin.groovy](https://github.com/jeffwils/grails-spring-security-saml/blob/develop/src/main/groovy/org/grails/plugin/springsecurity/saml/SpringSecuritySamlGrailsPlugin.groovy#L304)) and will be available in the next release."}}
{"actor":{"display_login":"valentingoebel"}}