{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/244462414","pull_request_review_id":188398556,"id":244462414,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDQ2MjQxNA==","diff_hunk":"@@ -1,4 +1,5 @@\n #include \"task_spec.h\"\n+#include <sstream>","path":"src/ray/raylet/task_spec.cc","position":2,"original_position":2,"commit_id":"e07917e3956af6bcfef2b5cb932a7c5e63268d61","original_commit_id":"e07917e3956af6bcfef2b5cb932a7c5e63268d61","user":{"login":"robertnishihara","id":249517,"node_id":"MDQ6VXNlcjI0OTUxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/249517?v=4","gravatar_id":"","url":"https://api.github.com/users/robertnishihara","html_url":"https://github.com/robertnishihara","followers_url":"https://api.github.com/users/robertnishihara/followers","following_url":"https://api.github.com/users/robertnishihara/following{/other_user}","gists_url":"https://api.github.com/users/robertnishihara/gists{/gist_id}","starred_url":"https://api.github.com/users/robertnishihara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertnishihara/subscriptions","organizations_url":"https://api.github.com/users/robertnishihara/orgs","repos_url":"https://api.github.com/users/robertnishihara/repos","events_url":"https://api.github.com/users/robertnishihara/events{/privacy}","received_events_url":"https://api.github.com/users/robertnishihara/received_events","type":"User","site_admin":false},"body":"thee should probably be a newline above this","created_at":"2018-12-29T07:04:57Z","updated_at":"2018-12-29T07:04:58Z","html_url":"https://github.com/ray-project/ray/pull/3662#discussion_r244462414","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/3662","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/244462414"},"html":{"href":"https://github.com/ray-project/ray/pull/3662#discussion_r244462414"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3662"}}},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/3662","id":241428786,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDI4Nzg2","html_url":"https://github.com/ray-project/ray/pull/3662","diff_url":"https://github.com/ray-project/ray/pull/3662.diff","patch_url":"https://github.com/ray-project/ray/pull/3662.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/3662","number":3662,"state":"open","locked":false,"title":"Improve backend log: env variable setting and format refine.","user":{"login":"guoyuhong","id":19584326,"node_id":"MDQ6VXNlcjE5NTg0MzI2","avatar_url":"https://avatars2.githubusercontent.com/u/19584326?v=4","gravatar_id":"","url":"https://api.github.com/users/guoyuhong","html_url":"https://github.com/guoyuhong","followers_url":"https://api.github.com/users/guoyuhong/followers","following_url":"https://api.github.com/users/guoyuhong/following{/other_user}","gists_url":"https://api.github.com/users/guoyuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/guoyuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guoyuhong/subscriptions","organizations_url":"https://api.github.com/users/guoyuhong/orgs","repos_url":"https://api.github.com/users/guoyuhong/repos","events_url":"https://api.github.com/users/guoyuhong/events{/privacy}","received_events_url":"https://api.github.com/users/guoyuhong/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your contribution!\r\n\r\nPlease review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request.\r\n-->\r\n\r\n## What do these changes do?\r\n1. Enable setting raylet logging level from env variable `RAY_BACKEND_LOG_LEVEL` instead of recompiling raylet. This is a good feature when we want to debug raylet.\r\n2. In change the printed NIL ID from `ffffffffffffffffffffffffffffffffffffffff` to `NIL_ID`. This will make debug log a bit smaller.\r\n3. Change the some enum number in the log to enum name. This helps us when the enums is very big. For example, origin log shows `Message of type 11`. We need to count the 11th entry in node_manager.fbs. Now the log changes to `Message of NotifyUnblocked(11)`.\r\n<!-- Please give a short brief about these changes. -->\r\n\r\n## Related issue number\r\nN/A\r\n<!-- Are there any issues opened that will be resolved by merging this change? -->\r\n","created_at":"2018-12-29T07:00:32Z","updated_at":"2018-12-29T07:04:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7613eaf49b09504ad0413a66db42928c6a14e469","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pcmoritz","id":113316,"node_id":"MDQ6VXNlcjExMzMxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/113316?v=4","gravatar_id":"","url":"https://api.github.com/users/pcmoritz","html_url":"https://github.com/pcmoritz","followers_url":"https://api.github.com/users/pcmoritz/followers","following_url":"https://api.github.com/users/pcmoritz/following{/other_user}","gists_url":"https://api.github.com/users/pcmoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/pcmoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcmoritz/subscriptions","organizations_url":"https://api.github.com/users/pcmoritz/orgs","repos_url":"https://api.github.com/users/pcmoritz/repos","events_url":"https://api.github.com/users/pcmoritz/events{/privacy}","received_events_url":"https://api.github.com/users/pcmoritz/received_events","type":"User","site_admin":false},{"login":"stephanie-wang","id":2560516,"node_id":"MDQ6VXNlcjI1NjA1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2560516?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanie-wang","html_url":"https://github.com/stephanie-wang","followers_url":"https://api.github.com/users/stephanie-wang/followers","following_url":"https://api.github.com/users/stephanie-wang/following{/other_user}","gists_url":"https://api.github.com/users/stephanie-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanie-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanie-wang/subscriptions","organizations_url":"https://api.github.com/users/stephanie-wang/orgs","repos_url":"https://api.github.com/users/stephanie-wang/repos","events_url":"https://api.github.com/users/stephanie-wang/events{/privacy}","received_events_url":"https://api.github.com/users/stephanie-wang/received_events","type":"User","site_admin":false},{"login":"raulchen","id":2883335,"node_id":"MDQ6VXNlcjI4ODMzMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/2883335?v=4","gravatar_id":"","url":"https://api.github.com/users/raulchen","html_url":"https://github.com/raulchen","followers_url":"https://api.github.com/users/raulchen/followers","following_url":"https://api.github.com/users/raulchen/following{/other_user}","gists_url":"https://api.github.com/users/raulchen/gists{/gist_id}","starred_url":"https://api.github.com/users/raulchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raulchen/subscriptions","organizations_url":"https://api.github.com/users/raulchen/orgs","repos_url":"https://api.github.com/users/raulchen/repos","events_url":"https://api.github.com/users/raulchen/events{/privacy}","received_events_url":"https://api.github.com/users/raulchen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/3662/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/3662/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/3662/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/e07917e3956af6bcfef2b5cb932a7c5e63268d61","head":{"label":"ant-tech-alliance:improveLog","ref":"improveLog","sha":"e07917e3956af6bcfef2b5cb932a7c5e63268d61","user":{"login":"ant-tech-alliance","id":29560905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTYwOTA1","avatar_url":"https://avatars3.githubusercontent.com/u/29560905?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-tech-alliance","html_url":"https://github.com/ant-tech-alliance","followers_url":"https://api.github.com/users/ant-tech-alliance/followers","following_url":"https://api.github.com/users/ant-tech-alliance/following{/other_user}","gists_url":"https://api.github.com/users/ant-tech-alliance/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-tech-alliance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-tech-alliance/subscriptions","organizations_url":"https://api.github.com/users/ant-tech-alliance/orgs","repos_url":"https://api.github.com/users/ant-tech-alliance/repos","events_url":"https://api.github.com/users/ant-tech-alliance/events{/privacy}","received_events_url":"https://api.github.com/users/ant-tech-alliance/received_events","type":"Organization","site_admin":false},"repo":{"id":125461261,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU0NjEyNjE=","name":"ray","full_name":"ant-tech-alliance/ray","private":false,"owner":{"login":"ant-tech-alliance","id":29560905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTYwOTA1","avatar_url":"https://avatars3.githubusercontent.com/u/29560905?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-tech-alliance","html_url":"https://github.com/ant-tech-alliance","followers_url":"https://api.github.com/users/ant-tech-alliance/followers","following_url":"https://api.github.com/users/ant-tech-alliance/following{/other_user}","gists_url":"https://api.github.com/users/ant-tech-alliance/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-tech-alliance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-tech-alliance/subscriptions","organizations_url":"https://api.github.com/users/ant-tech-alliance/orgs","repos_url":"https://api.github.com/users/ant-tech-alliance/repos","events_url":"https://api.github.com/users/ant-tech-alliance/events{/privacy}","received_events_url":"https://api.github.com/users/ant-tech-alliance/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ant-tech-alliance/ray","description":"A high-performance distributed execution engine","fork":true,"url":"https://api.github.com/repos/ant-tech-alliance/ray","forks_url":"https://api.github.com/repos/ant-tech-alliance/ray/forks","keys_url":"https://api.github.com/repos/ant-tech-alliance/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ant-tech-alliance/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ant-tech-alliance/ray/teams","hooks_url":"https://api.github.com/repos/ant-tech-alliance/ray/hooks","issue_events_url":"https://api.github.com/repos/ant-tech-alliance/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ant-tech-alliance/ray/events","assignees_url":"https://api.github.com/repos/ant-tech-alliance/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ant-tech-alliance/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ant-tech-alliance/ray/tags","blobs_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ant-tech-alliance/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ant-tech-alliance/ray/languages","stargazers_url":"https://api.github.com/repos/ant-tech-alliance/ray/stargazers","contributors_url":"https://api.github.com/repos/ant-tech-alliance/ray/contributors","subscribers_url":"https://api.github.com/repos/ant-tech-alliance/ray/subscribers","subscription_url":"https://api.github.com/repos/ant-tech-alliance/ray/subscription","commits_url":"https://api.github.com/repos/ant-tech-alliance/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ant-tech-alliance/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ant-tech-alliance/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ant-tech-alliance/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ant-tech-alliance/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ant-tech-alliance/ray/merges","archive_url":"https://api.github.com/repos/ant-tech-alliance/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ant-tech-alliance/ray/downloads","issues_url":"https://api.github.com/repos/ant-tech-alliance/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ant-tech-alliance/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ant-tech-alliance/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ant-tech-alliance/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ant-tech-alliance/ray/labels{/name}","releases_url":"https://api.github.com/repos/ant-tech-alliance/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ant-tech-alliance/ray/deployments","created_at":"2018-03-16T03:58:55Z","updated_at":"2018-12-26T05:14:27Z","pushed_at":"2018-12-29T06:50:07Z","git_url":"git://github.com/ant-tech-alliance/ray.git","ssh_url":"git@github.com:ant-tech-alliance/ray.git","clone_url":"https://github.com/ant-tech-alliance/ray.git","svn_url":"https://github.com/ant-tech-alliance/ray","homepage":"","size":19690,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":10,"watchers":9,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"eb1e5fa2cf26233701ccbda3eb8a301ecd418d8c","user":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzMjM0OQ==","name":"ray","full_name":"ray-project/ray","private":false,"owner":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ray-project/ray","description":"A system for parallel and distributed Python that unifies the ML ecosystem.","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2018-12-29T06:53:37Z","pushed_at":"2018-12-29T07:00:33Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"https://ray.readthedocs.io/en/latest/","size":17719,"stargazers_count":5150,"watchers_count":5150,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":707,"mirror_url":null,"archived":false,"open_issues_count":511,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":707,"open_issues":511,"watchers":5150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3662"},"html":{"href":"https://github.com/ray-project/ray/pull/3662"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/3662"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/3662/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3662/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3662/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/e07917e3956af6bcfef2b5cb932a7c5e63268d61"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robertnishihara"}}