{"action":"created","issue":{"url":"https://api.github.com/repos/diffblue/cbmc/issues/2168","repository_url":"https://api.github.com/repos/diffblue/cbmc","labels_url":"https://api.github.com/repos/diffblue/cbmc/issues/2168/labels{/name}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/2168/comments","events_url":"https://api.github.com/repos/diffblue/cbmc/issues/2168/events","html_url":"https://github.com/diffblue/cbmc/pull/2168","id":321231878,"number":2168,"title":"Don't phi-merge uninitialised objects","user":{"login":"JohnDumbell","id":37293497,"avatar_url":"https://avatars1.githubusercontent.com/u/37293497?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnDumbell","html_url":"https://github.com/JohnDumbell","followers_url":"https://api.github.com/users/JohnDumbell/followers","following_url":"https://api.github.com/users/JohnDumbell/following{/other_user}","gists_url":"https://api.github.com/users/JohnDumbell/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnDumbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnDumbell/subscriptions","organizations_url":"https://api.github.com/users/JohnDumbell/orgs","repos_url":"https://api.github.com/users/JohnDumbell/repos","events_url":"https://api.github.com/users/JohnDumbell/events{/privacy}","received_events_url":"https://api.github.com/users/JohnDumbell/received_events","type":"User","site_admin":false},"labels":[{"id":785084552,"url":"https://api.github.com/repos/diffblue/cbmc/labels/Merge%20before%20removing%20java","name":"Merge before removing java","color":"c0f25e","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-08T15:19:13Z","updated_at":"2018-05-11T10:06:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/2168","html_url":"https://github.com/diffblue/cbmc/pull/2168","diff_url":"https://github.com/diffblue/cbmc/pull/2168.diff","patch_url":"https://github.com/diffblue/cbmc/pull/2168.patch"},"body":"This is the work mentioned in the last comment on #2121, making it so that a generation 0 of a symex variable means it's never been initialised in both Java and C. The approach is on an allocate to assign a nondet to it if it isn't zero-init'd to begin with, and then if we see a gen zero then to not consider it during conditionals on phi merges.\r\n\r\nAlong with these is a small change to test.pl's multi-line match option to enable traditional regex multi-line matching. The m flag causes ^ and $ to actually match correctly on new line/carriage returns, where before the match was actually on the entire file so ^ was just beginning of file $ was the end. This also fixes a few tests' failure condition where this subtle difference wasn't noticed and '^warning: ignoring' is used."},"comment":{"url":"https://api.github.com/repos/diffblue/cbmc/issues/comments/388320998","html_url":"https://github.com/diffblue/cbmc/pull/2168#issuecomment-388320998","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/2168","id":388320998,"user":{"login":"smowton","id":283483,"avatar_url":"https://avatars3.githubusercontent.com/u/283483?v=4","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"created_at":"2018-05-11T10:06:24Z","updated_at":"2018-05-11T10:06:24Z","author_association":"MEMBER","body":"This is looking much improved, just commented with one more nitpick, let me know when this is ready for re-review"}}
{"actor":{"display_login":"smowton"}}