{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/182600940","pull_request_review_id":113428819,"id":182600940,"diff_hunk":"@@ -334,6 +334,10 @@ class Strategy : public Engine {\n \n protected:\n   void add_engine(Control ctrl_flag, const Engine& engine) noexcept;\n+\n+  using engine_map_t = std::map <std::string, std::reference_wrapper<const Engine>>;\n+  void add_engines(std::vector <string> auth_order,","path":"src/rgw/rgw_auth.h","position":6,"original_position":6,"commit_id":"dcb81dc66ac458f6c4e01bde74453829541a2857","original_commit_id":"dcb81dc66ac458f6c4e01bde74453829541a2857","user":{"login":"rzarzynski","id":1891217,"avatar_url":"https://avatars2.githubusercontent.com/u/1891217?v=4","gravatar_id":"","url":"https://api.github.com/users/rzarzynski","html_url":"https://github.com/rzarzynski","followers_url":"https://api.github.com/users/rzarzynski/followers","following_url":"https://api.github.com/users/rzarzynski/following{/other_user}","gists_url":"https://api.github.com/users/rzarzynski/gists{/gist_id}","starred_url":"https://api.github.com/users/rzarzynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzarzynski/subscriptions","organizations_url":"https://api.github.com/users/rzarzynski/orgs","repos_url":"https://api.github.com/users/rzarzynski/repos","events_url":"https://api.github.com/users/rzarzynski/events{/privacy}","received_events_url":"https://api.github.com/users/rzarzynski/received_events","type":"User","site_admin":false},"body":"It would be nice to have `std::` for the `string` especially as this a header.","created_at":"2018-04-18T23:47:47Z","updated_at":"2018-04-18T23:59:15Z","html_url":"https://github.com/ceph/ceph/pull/21494#discussion_r182600940","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/21494","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/182600940"},"html":{"href":"https://github.com/ceph/ceph/pull/21494#discussion_r182600940"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21494"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/21494","id":182449469,"html_url":"https://github.com/ceph/ceph/pull/21494","diff_url":"https://github.com/ceph/ceph/pull/21494.diff","patch_url":"https://github.com/ceph/ceph/pull/21494.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/21494","number":21494,"state":"open","locked":false,"title":"rgw: have a configurable authentication order","user":{"login":"theanalyst","id":1433152,"avatar_url":"https://avatars0.githubusercontent.com/u/1433152?v=4","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"body":"This implements a configurable authentication order, currently used only for s3\r\nauthentication and only supporting external & local authentication, though there\r\nis potential for more finegrained control by allowing for a map of various\r\nengines and the control strategy (required vs sufficient vs fallback)\r\n\r\nThe current implementation just focuses on setting control sufficient if the\r\nengine is the last in the order (and hence the stack) and just sets fallback to\r\nevery other element.\r\n\r\nThe configuration option is rgw_auth_order which takes a comma/space seperated\r\nlist of authentication engines where currently we support the keywords `external`\r\nand `local`.\r\n\r\nFixes: http://tracker.ceph.com/issues/23089\r\nSigned-off-by: Abhishek Lekshmanan <abhishek@suse.com>","created_at":"2018-04-18T11:32:31Z","updated_at":"2018-04-18T23:59:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0387ec1907891fa8ea50e8ff9a70afee5f2f1ae5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mattbenjamin","id":301287,"avatar_url":"https://avatars2.githubusercontent.com/u/301287?v=4","gravatar_id":"","url":"https://api.github.com/users/mattbenjamin","html_url":"https://github.com/mattbenjamin","followers_url":"https://api.github.com/users/mattbenjamin/followers","following_url":"https://api.github.com/users/mattbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/mattbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbenjamin/subscriptions","organizations_url":"https://api.github.com/users/mattbenjamin/orgs","repos_url":"https://api.github.com/users/mattbenjamin/repos","events_url":"https://api.github.com/users/mattbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/mattbenjamin/received_events","type":"User","site_admin":false},{"login":"pritha-srivastava","id":10740350,"avatar_url":"https://avatars0.githubusercontent.com/u/10740350?v=4","gravatar_id":"","url":"https://api.github.com/users/pritha-srivastava","html_url":"https://github.com/pritha-srivastava","followers_url":"https://api.github.com/users/pritha-srivastava/followers","following_url":"https://api.github.com/users/pritha-srivastava/following{/other_user}","gists_url":"https://api.github.com/users/pritha-srivastava/gists{/gist_id}","starred_url":"https://api.github.com/users/pritha-srivastava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pritha-srivastava/subscriptions","organizations_url":"https://api.github.com/users/pritha-srivastava/orgs","repos_url":"https://api.github.com/users/pritha-srivastava/repos","events_url":"https://api.github.com/users/pritha-srivastava/events{/privacy}","received_events_url":"https://api.github.com/users/pritha-srivastava/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":144329618,"url":"https://api.github.com/repos/ceph/ceph/labels/rgw","name":"rgw","color":"00ffe4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/21494/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/21494/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/21494/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/dcb81dc66ac458f6c4e01bde74453829541a2857","head":{"label":"theanalyst:rgw-reorder-auth","ref":"rgw-reorder-auth","sha":"dcb81dc66ac458f6c4e01bde74453829541a2857","user":{"login":"theanalyst","id":1433152,"avatar_url":"https://avatars0.githubusercontent.com/u/1433152?v=4","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"repo":{"id":21639729,"name":"ceph","full_name":"theanalyst/ceph","owner":{"login":"theanalyst","id":1433152,"avatar_url":"https://avatars0.githubusercontent.com/u/1433152?v=4","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theanalyst/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/theanalyst/ceph","forks_url":"https://api.github.com/repos/theanalyst/ceph/forks","keys_url":"https://api.github.com/repos/theanalyst/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theanalyst/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theanalyst/ceph/teams","hooks_url":"https://api.github.com/repos/theanalyst/ceph/hooks","issue_events_url":"https://api.github.com/repos/theanalyst/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/theanalyst/ceph/events","assignees_url":"https://api.github.com/repos/theanalyst/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/theanalyst/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/theanalyst/ceph/tags","blobs_url":"https://api.github.com/repos/theanalyst/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theanalyst/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theanalyst/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/theanalyst/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theanalyst/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/theanalyst/ceph/languages","stargazers_url":"https://api.github.com/repos/theanalyst/ceph/stargazers","contributors_url":"https://api.github.com/repos/theanalyst/ceph/contributors","subscribers_url":"https://api.github.com/repos/theanalyst/ceph/subscribers","subscription_url":"https://api.github.com/repos/theanalyst/ceph/subscription","commits_url":"https://api.github.com/repos/theanalyst/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/theanalyst/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/theanalyst/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/theanalyst/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/theanalyst/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/theanalyst/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theanalyst/ceph/merges","archive_url":"https://api.github.com/repos/theanalyst/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theanalyst/ceph/downloads","issues_url":"https://api.github.com/repos/theanalyst/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/theanalyst/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/theanalyst/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/theanalyst/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theanalyst/ceph/labels{/name}","releases_url":"https://api.github.com/repos/theanalyst/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/theanalyst/ceph/deployments","created_at":"2014-07-09T04:45:38Z","updated_at":"2018-03-19T17:58:01Z","pushed_at":"2018-04-18T11:31:40Z","git_url":"git://github.com/theanalyst/ceph.git","ssh_url":"git@github.com:theanalyst/ceph.git","clone_url":"https://github.com/theanalyst/ceph.git","svn_url":"https://github.com/theanalyst/ceph","homepage":"http://ceph.com","size":287479,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"a2eea2427a7c9a576f08198e936debdf1e805f87","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-04-18T22:26:55Z","pushed_at":"2018-04-18T22:27:37Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":279860,"stargazers_count":4363,"watchers_count":4363,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2402,"mirror_url":null,"archived":false,"open_issues_count":632,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2402,"open_issues":632,"watchers":4363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21494"},"html":{"href":"https://github.com/ceph/ceph/pull/21494"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/21494"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/21494/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21494/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21494/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/dcb81dc66ac458f6c4e01bde74453829541a2857"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rzarzynski"}}