{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/comments/167082174","pull_request_review_id":95250205,"id":167082174,"diff_hunk":"@@ -32,6 +30,9 @@ import (\n \t\"k8s.io/kube-deploy/ext-apiserver/pkg/apis/cluster/common\"\n )\n \n+// Finalizer is set on PreareForCreate callback\n+const MachineFinalizer string = \"MachineFinalizer\"","path":"ext-apiserver/pkg/apis/cluster/v1alpha1/machine_types.go","position":18,"original_position":18,"commit_id":"80a3312d50c05f79c76b4057c178be95addd13d9","original_commit_id":"80a3312d50c05f79c76b4057c178be95addd13d9","user":{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"body":"This should be tagged with our API domain. Like `machine.cluster.k8s.io` or something like that.","created_at":"2018-02-08T22:05:20Z","updated_at":"2018-02-08T22:12:01Z","html_url":"https://github.com/kubernetes/kube-deploy/pull/581#discussion_r167082174","pull_request_url":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/581","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/comments/167082174"},"html":{"href":"https://github.com/kubernetes/kube-deploy/pull/581#discussion_r167082174"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/581","id":167619962,"html_url":"https://github.com/kubernetes/kube-deploy/pull/581","diff_url":"https://github.com/kubernetes/kube-deploy/pull/581.diff","patch_url":"https://github.com/kubernetes/kube-deploy/pull/581.patch","issue_url":"https://api.github.com/repos/kubernetes/kube-deploy/issues/581","number":581,"state":"open","locked":false,"title":"Implement finalizer support for machine resource","user":{"login":"medinatiger","id":30094939,"avatar_url":"https://avatars1.githubusercontent.com/u/30094939?v=4","gravatar_id":"","url":"https://api.github.com/users/medinatiger","html_url":"https://github.com/medinatiger","followers_url":"https://api.github.com/users/medinatiger/followers","following_url":"https://api.github.com/users/medinatiger/following{/other_user}","gists_url":"https://api.github.com/users/medinatiger/gists{/gist_id}","starred_url":"https://api.github.com/users/medinatiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medinatiger/subscriptions","organizations_url":"https://api.github.com/users/medinatiger/orgs","repos_url":"https://api.github.com/users/medinatiger/repos","events_url":"https://api.github.com/users/medinatiger/events{/privacy}","received_events_url":"https://api.github.com/users/medinatiger/received_events","type":"User","site_admin":false},"body":"gcp-deployer now support machine/cluster deletion.","created_at":"2018-02-07T07:50:44Z","updated_at":"2018-02-08T22:12:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fd79913d62f7975889dfbcf21b67721d5abd1d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/581/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/581/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kube-deploy/issues/581/comments","statuses_url":"https://api.github.com/repos/kubernetes/kube-deploy/statuses/80a3312d50c05f79c76b4057c178be95addd13d9","head":{"label":"medinatiger:finalizer","ref":"finalizer","sha":"80a3312d50c05f79c76b4057c178be95addd13d9","user":{"login":"medinatiger","id":30094939,"avatar_url":"https://avatars1.githubusercontent.com/u/30094939?v=4","gravatar_id":"","url":"https://api.github.com/users/medinatiger","html_url":"https://github.com/medinatiger","followers_url":"https://api.github.com/users/medinatiger/followers","following_url":"https://api.github.com/users/medinatiger/following{/other_user}","gists_url":"https://api.github.com/users/medinatiger/gists{/gist_id}","starred_url":"https://api.github.com/users/medinatiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medinatiger/subscriptions","organizations_url":"https://api.github.com/users/medinatiger/orgs","repos_url":"https://api.github.com/users/medinatiger/repos","events_url":"https://api.github.com/users/medinatiger/events{/privacy}","received_events_url":"https://api.github.com/users/medinatiger/received_events","type":"User","site_admin":false},"repo":{"id":107447062,"name":"kube-deploy","full_name":"medinatiger/kube-deploy","owner":{"login":"medinatiger","id":30094939,"avatar_url":"https://avatars1.githubusercontent.com/u/30094939?v=4","gravatar_id":"","url":"https://api.github.com/users/medinatiger","html_url":"https://github.com/medinatiger","followers_url":"https://api.github.com/users/medinatiger/followers","following_url":"https://api.github.com/users/medinatiger/following{/other_user}","gists_url":"https://api.github.com/users/medinatiger/gists{/gist_id}","starred_url":"https://api.github.com/users/medinatiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medinatiger/subscriptions","organizations_url":"https://api.github.com/users/medinatiger/orgs","repos_url":"https://api.github.com/users/medinatiger/repos","events_url":"https://api.github.com/users/medinatiger/events{/privacy}","received_events_url":"https://api.github.com/users/medinatiger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/medinatiger/kube-deploy","description":"A place for cluster deployment automation","fork":true,"url":"https://api.github.com/repos/medinatiger/kube-deploy","forks_url":"https://api.github.com/repos/medinatiger/kube-deploy/forks","keys_url":"https://api.github.com/repos/medinatiger/kube-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/medinatiger/kube-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/medinatiger/kube-deploy/teams","hooks_url":"https://api.github.com/repos/medinatiger/kube-deploy/hooks","issue_events_url":"https://api.github.com/repos/medinatiger/kube-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/medinatiger/kube-deploy/events","assignees_url":"https://api.github.com/repos/medinatiger/kube-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/medinatiger/kube-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/medinatiger/kube-deploy/tags","blobs_url":"https://api.github.com/repos/medinatiger/kube-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/medinatiger/kube-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/medinatiger/kube-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/medinatiger/kube-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/medinatiger/kube-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/medinatiger/kube-deploy/languages","stargazers_url":"https://api.github.com/repos/medinatiger/kube-deploy/stargazers","contributors_url":"https://api.github.com/repos/medinatiger/kube-deploy/contributors","subscribers_url":"https://api.github.com/repos/medinatiger/kube-deploy/subscribers","subscription_url":"https://api.github.com/repos/medinatiger/kube-deploy/subscription","commits_url":"https://api.github.com/repos/medinatiger/kube-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/medinatiger/kube-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/medinatiger/kube-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/medinatiger/kube-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/medinatiger/kube-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/medinatiger/kube-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/medinatiger/kube-deploy/merges","archive_url":"https://api.github.com/repos/medinatiger/kube-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/medinatiger/kube-deploy/downloads","issues_url":"https://api.github.com/repos/medinatiger/kube-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/medinatiger/kube-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/medinatiger/kube-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/medinatiger/kube-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/medinatiger/kube-deploy/labels{/name}","releases_url":"https://api.github.com/repos/medinatiger/kube-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/medinatiger/kube-deploy/deployments","created_at":"2017-10-18T18:26:14Z","updated_at":"2017-10-18T18:26:16Z","pushed_at":"2018-02-07T07:46:53Z","git_url":"git://github.com/medinatiger/kube-deploy.git","ssh_url":"git@github.com:medinatiger/kube-deploy.git","clone_url":"https://github.com/medinatiger/kube-deploy.git","svn_url":"https://github.com/medinatiger/kube-deploy","homepage":null,"size":113506,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b3e1525d0df7a2b4bffac131acd1c7b55fb5e03c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":54912542,"name":"kube-deploy","full_name":"kubernetes/kube-deploy","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kube-deploy","description":"A place for cluster deployment automation","fork":false,"url":"https://api.github.com/repos/kubernetes/kube-deploy","forks_url":"https://api.github.com/repos/kubernetes/kube-deploy/forks","keys_url":"https://api.github.com/repos/kubernetes/kube-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kube-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kube-deploy/teams","hooks_url":"https://api.github.com/repos/kubernetes/kube-deploy/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kube-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kube-deploy/events","assignees_url":"https://api.github.com/repos/kubernetes/kube-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kube-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kube-deploy/tags","blobs_url":"https://api.github.com/repos/kubernetes/kube-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kube-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kube-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kube-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kube-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kube-deploy/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kube-deploy/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kube-deploy/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kube-deploy/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kube-deploy/subscription","commits_url":"https://api.github.com/repos/kubernetes/kube-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kube-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kube-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kube-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kube-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kube-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kube-deploy/merges","archive_url":"https://api.github.com/repos/kubernetes/kube-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kube-deploy/downloads","issues_url":"https://api.github.com/repos/kubernetes/kube-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kube-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kube-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kube-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kube-deploy/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kube-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kube-deploy/deployments","created_at":"2016-03-28T18:05:52Z","updated_at":"2018-02-08T21:57:43Z","pushed_at":"2018-02-08T19:53:41Z","git_url":"git://github.com/kubernetes/kube-deploy.git","ssh_url":"git@github.com:kubernetes/kube-deploy.git","clone_url":"https://github.com/kubernetes/kube-deploy.git","svn_url":"https://github.com/kubernetes/kube-deploy","homepage":null,"size":123682,"stargazers_count":404,"watchers_count":404,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":189,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":189,"open_issues":81,"watchers":404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/581"},"html":{"href":"https://github.com/kubernetes/kube-deploy/pull/581"},"issue":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/issues/581"},"comments":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/statuses/80a3312d50c05f79c76b4057c178be95addd13d9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"krousey"}}