{"action":"created","comment":{"url":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments/170800002","pull_request_review_id":99541093,"id":170800002,"diff_hunk":"@@ -109,11 +109,10 @@ def unplug_device(vm, get_disk_cmd, device):\n                     controller = qdevices.QDevice(controller_model, params={\"id\":\n                                                   \"hotadded_scsi%s\" % num})\n                     bus_extra_param = params.get(\"bus_extra_params_%s\" % img_list[num + 1])\n-                    # TODO:Add iothread support for qdevice\n-                    if bus_extra_param and \"iothread\" in bus_extra_param:\n-                        match = re.search(\"iothread=(\\w+)\", bus_extra_param)\n-                        if match:\n-                            qdevice_params = {\"iothread\": match.group(1)}\n+                    if bus_extra_param:","path":"qemu/tests/block_hotplug.py","position":9,"original_position":9,"commit_id":"ab49f0aae66b2422a607a6ab20ec8bda439d2c5d","original_commit_id":"ab49f0aae66b2422a607a6ab20ec8bda439d2c5d","user":{"login":"aliang123","id":19542879,"avatar_url":"https://avatars1.githubusercontent.com/u/19542879?v=4","gravatar_id":"","url":"https://api.github.com/users/aliang123","html_url":"https://github.com/aliang123","followers_url":"https://api.github.com/users/aliang123/followers","following_url":"https://api.github.com/users/aliang123/following{/other_user}","gists_url":"https://api.github.com/users/aliang123/gists{/gist_id}","starred_url":"https://api.github.com/users/aliang123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliang123/subscriptions","organizations_url":"https://api.github.com/users/aliang123/orgs","repos_url":"https://api.github.com/users/aliang123/repos","events_url":"https://api.github.com/users/aliang123/events{/privacy}","received_events_url":"https://api.github.com/users/aliang123/received_events","type":"User","site_admin":false},"body":"hachen, bus_extra_param is defined in the last line of block_hotplug.cfg, at present it just means 'bus_extra_params_stg0 = \"iothread=${iothreads}\"'.  If we have new (key, value) for bus_extra_param latter, we don't need to modify the code again.","created_at":"2018-02-27T02:33:03Z","updated_at":"2018-02-27T02:33:03Z","html_url":"https://github.com/autotest/tp-qemu/pull/1226#discussion_r170800002","pull_request_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/1226","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments/170800002"},"html":{"href":"https://github.com/autotest/tp-qemu/pull/1226#discussion_r170800002"},"pull_request":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/1226"}},"in_reply_to_id":170793917},"pull_request":{"url":"https://api.github.com/repos/autotest/tp-qemu/pulls/1226","id":166793568,"html_url":"https://github.com/autotest/tp-qemu/pull/1226","diff_url":"https://github.com/autotest/tp-qemu/pull/1226.diff","patch_url":"https://github.com/autotest/tp-qemu/pull/1226.patch","issue_url":"https://api.github.com/repos/autotest/tp-qemu/issues/1226","number":1226,"state":"open","locked":false,"title":"block_resize: add subtest \"block_resize\" after hotplug","user":{"login":"aliang123","id":19542879,"avatar_url":"https://avatars1.githubusercontent.com/u/19542879?v=4","gravatar_id":"","url":"https://api.github.com/users/aliang123","html_url":"https://github.com/aliang123","followers_url":"https://api.github.com/users/aliang123/followers","following_url":"https://api.github.com/users/aliang123/following{/other_user}","gists_url":"https://api.github.com/users/aliang123/gists{/gist_id}","starred_url":"https://api.github.com/users/aliang123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliang123/subscriptions","organizations_url":"https://api.github.com/users/aliang123/orgs","repos_url":"https://api.github.com/users/aliang123/repos","events_url":"https://api.github.com/users/aliang123/events{/privacy}","received_events_url":"https://api.github.com/users/aliang123/received_events","type":"User","site_admin":false},"body":"Add subtest \"block_resize\" after hotplug.\r\n\r\nSigned-off-by: Aihua Liang <aliang@redhat.com>\r\n\r\nbug id:1466231","created_at":"2018-02-02T12:44:24Z","updated_at":"2018-02-27T02:33:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52136b118dd180fe05fe1102bbcc9b5759ad6510","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/1226/commits","review_comments_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/1226/comments","review_comment_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autotest/tp-qemu/issues/1226/comments","statuses_url":"https://api.github.com/repos/autotest/tp-qemu/statuses/ab49f0aae66b2422a607a6ab20ec8bda439d2c5d","head":{"label":"aliang123:1466231","ref":"1466231","sha":"ab49f0aae66b2422a607a6ab20ec8bda439d2c5d","user":{"login":"aliang123","id":19542879,"avatar_url":"https://avatars1.githubusercontent.com/u/19542879?v=4","gravatar_id":"","url":"https://api.github.com/users/aliang123","html_url":"https://github.com/aliang123","followers_url":"https://api.github.com/users/aliang123/followers","following_url":"https://api.github.com/users/aliang123/following{/other_user}","gists_url":"https://api.github.com/users/aliang123/gists{/gist_id}","starred_url":"https://api.github.com/users/aliang123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliang123/subscriptions","organizations_url":"https://api.github.com/users/aliang123/orgs","repos_url":"https://api.github.com/users/aliang123/repos","events_url":"https://api.github.com/users/aliang123/events{/privacy}","received_events_url":"https://api.github.com/users/aliang123/received_events","type":"User","site_admin":false},"repo":{"id":70447801,"name":"tp-qemu","full_name":"aliang123/tp-qemu","owner":{"login":"aliang123","id":19542879,"avatar_url":"https://avatars1.githubusercontent.com/u/19542879?v=4","gravatar_id":"","url":"https://api.github.com/users/aliang123","html_url":"https://github.com/aliang123","followers_url":"https://api.github.com/users/aliang123/followers","following_url":"https://api.github.com/users/aliang123/following{/other_user}","gists_url":"https://api.github.com/users/aliang123/gists{/gist_id}","starred_url":"https://api.github.com/users/aliang123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliang123/subscriptions","organizations_url":"https://api.github.com/users/aliang123/orgs","repos_url":"https://api.github.com/users/aliang123/repos","events_url":"https://api.github.com/users/aliang123/events{/privacy}","received_events_url":"https://api.github.com/users/aliang123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aliang123/tp-qemu","description":"Virt Test Provider for qemu and other related virtualization backends","fork":true,"url":"https://api.github.com/repos/aliang123/tp-qemu","forks_url":"https://api.github.com/repos/aliang123/tp-qemu/forks","keys_url":"https://api.github.com/repos/aliang123/tp-qemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aliang123/tp-qemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aliang123/tp-qemu/teams","hooks_url":"https://api.github.com/repos/aliang123/tp-qemu/hooks","issue_events_url":"https://api.github.com/repos/aliang123/tp-qemu/issues/events{/number}","events_url":"https://api.github.com/repos/aliang123/tp-qemu/events","assignees_url":"https://api.github.com/repos/aliang123/tp-qemu/assignees{/user}","branches_url":"https://api.github.com/repos/aliang123/tp-qemu/branches{/branch}","tags_url":"https://api.github.com/repos/aliang123/tp-qemu/tags","blobs_url":"https://api.github.com/repos/aliang123/tp-qemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aliang123/tp-qemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aliang123/tp-qemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/aliang123/tp-qemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aliang123/tp-qemu/statuses/{sha}","languages_url":"https://api.github.com/repos/aliang123/tp-qemu/languages","stargazers_url":"https://api.github.com/repos/aliang123/tp-qemu/stargazers","contributors_url":"https://api.github.com/repos/aliang123/tp-qemu/contributors","subscribers_url":"https://api.github.com/repos/aliang123/tp-qemu/subscribers","subscription_url":"https://api.github.com/repos/aliang123/tp-qemu/subscription","commits_url":"https://api.github.com/repos/aliang123/tp-qemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/aliang123/tp-qemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/aliang123/tp-qemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/aliang123/tp-qemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/aliang123/tp-qemu/contents/{+path}","compare_url":"https://api.github.com/repos/aliang123/tp-qemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aliang123/tp-qemu/merges","archive_url":"https://api.github.com/repos/aliang123/tp-qemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aliang123/tp-qemu/downloads","issues_url":"https://api.github.com/repos/aliang123/tp-qemu/issues{/number}","pulls_url":"https://api.github.com/repos/aliang123/tp-qemu/pulls{/number}","milestones_url":"https://api.github.com/repos/aliang123/tp-qemu/milestones{/number}","notifications_url":"https://api.github.com/repos/aliang123/tp-qemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aliang123/tp-qemu/labels{/name}","releases_url":"https://api.github.com/repos/aliang123/tp-qemu/releases{/id}","deployments_url":"https://api.github.com/repos/aliang123/tp-qemu/deployments","created_at":"2016-10-10T03:15:51Z","updated_at":"2016-10-10T03:15:54Z","pushed_at":"2018-02-23T06:52:04Z","git_url":"git://github.com/aliang123/tp-qemu.git","ssh_url":"git@github.com:aliang123/tp-qemu.git","clone_url":"https://github.com/aliang123/tp-qemu.git","svn_url":"https://github.com/aliang123/tp-qemu","homepage":null,"size":14167,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"eb9da2d9681586048ca829afd2afb0d4bf18b265","user":{"login":"autotest","id":472856,"avatar_url":"https://avatars1.githubusercontent.com/u/472856?v=4","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":16180304,"name":"tp-qemu","full_name":"autotest/tp-qemu","owner":{"login":"autotest","id":472856,"avatar_url":"https://avatars1.githubusercontent.com/u/472856?v=4","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autotest/tp-qemu","description":"Virt Test Provider for qemu and other related virtualization backends","fork":false,"url":"https://api.github.com/repos/autotest/tp-qemu","forks_url":"https://api.github.com/repos/autotest/tp-qemu/forks","keys_url":"https://api.github.com/repos/autotest/tp-qemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/tp-qemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/tp-qemu/teams","hooks_url":"https://api.github.com/repos/autotest/tp-qemu/hooks","issue_events_url":"https://api.github.com/repos/autotest/tp-qemu/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/tp-qemu/events","assignees_url":"https://api.github.com/repos/autotest/tp-qemu/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/tp-qemu/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/tp-qemu/tags","blobs_url":"https://api.github.com/repos/autotest/tp-qemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/tp-qemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/tp-qemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/tp-qemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/tp-qemu/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/tp-qemu/languages","stargazers_url":"https://api.github.com/repos/autotest/tp-qemu/stargazers","contributors_url":"https://api.github.com/repos/autotest/tp-qemu/contributors","subscribers_url":"https://api.github.com/repos/autotest/tp-qemu/subscribers","subscription_url":"https://api.github.com/repos/autotest/tp-qemu/subscription","commits_url":"https://api.github.com/repos/autotest/tp-qemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/tp-qemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/tp-qemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/tp-qemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/autotest/tp-qemu/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/tp-qemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/tp-qemu/merges","archive_url":"https://api.github.com/repos/autotest/tp-qemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/tp-qemu/downloads","issues_url":"https://api.github.com/repos/autotest/tp-qemu/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/tp-qemu/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/tp-qemu/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/tp-qemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/tp-qemu/labels{/name}","releases_url":"https://api.github.com/repos/autotest/tp-qemu/releases{/id}","deployments_url":"https://api.github.com/repos/autotest/tp-qemu/deployments","created_at":"2014-01-23T17:51:34Z","updated_at":"2018-01-22T18:44:35Z","pushed_at":"2018-02-26T10:49:13Z","git_url":"git://github.com/autotest/tp-qemu.git","ssh_url":"git@github.com:autotest/tp-qemu.git","clone_url":"https://github.com/autotest/tp-qemu.git","svn_url":"https://github.com/autotest/tp-qemu","homepage":null,"size":14163,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":109,"open_issues":64,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/1226"},"html":{"href":"https://github.com/autotest/tp-qemu/pull/1226"},"issue":{"href":"https://api.github.com/repos/autotest/tp-qemu/issues/1226"},"comments":{"href":"https://api.github.com/repos/autotest/tp-qemu/issues/1226/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/1226/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/1226/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/tp-qemu/statuses/ab49f0aae66b2422a607a6ab20ec8bda439d2c5d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aliang123"}}