{"action":"created","comment":{"url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls/comments/187446124","pull_request_review_id":119229531,"id":187446124,"diff_hunk":"@@ -520,6 +526,15 @@ def configure_callback(conf):\n             ENABLE_CLUSTER_STATS = bool(node.values[0])\n         elif node.key == 'Interval':\n             COLLECTION_INTERVAL = int(node.values[0])\n+        elif node.key == 'HttpTlsEnabled':\n+            if bool(node.values[0]):\n+                ES_URL_SCHEME = \"https\"","path":"elasticsearch_collectd.py","position":35,"original_position":35,"commit_id":"5b55380396519a0699ffdcf08f13710235fa5810","original_commit_id":"5b55380396519a0699ffdcf08f13710235fa5810","user":{"login":"natejlong","id":3227132,"avatar_url":"https://avatars2.githubusercontent.com/u/3227132?v=4","gravatar_id":"","url":"https://api.github.com/users/natejlong","html_url":"https://github.com/natejlong","followers_url":"https://api.github.com/users/natejlong/followers","following_url":"https://api.github.com/users/natejlong/following{/other_user}","gists_url":"https://api.github.com/users/natejlong/gists{/gist_id}","starred_url":"https://api.github.com/users/natejlong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natejlong/subscriptions","organizations_url":"https://api.github.com/users/natejlong/orgs","repos_url":"https://api.github.com/users/natejlong/repos","events_url":"https://api.github.com/users/natejlong/events{/privacy}","received_events_url":"https://api.github.com/users/natejlong/received_events","type":"User","site_admin":false},"body":"Alternatively, there might be a better pattern for using globals without implying constant that cleans this up. My python-fu is weak there though ","created_at":"2018-05-10T20:14:33Z","updated_at":"2018-05-10T20:30:12Z","html_url":"https://github.com/HubSpot/collectd-elasticsearch/pull/1#discussion_r187446124","pull_request_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls/comments/187446124"},"html":{"href":"https://github.com/HubSpot/collectd-elasticsearch/pull/1#discussion_r187446124"},"pull_request":{"href":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls/1"}},"in_reply_to_id":187445536},"pull_request":{"url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls/1","id":185289772,"html_url":"https://github.com/HubSpot/collectd-elasticsearch/pull/1","diff_url":"https://github.com/HubSpot/collectd-elasticsearch/pull/1.diff","patch_url":"https://github.com/HubSpot/collectd-elasticsearch/pull/1.patch","issue_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/issues/1","number":1,"state":"open","locked":false,"title":"SSL support for ES HTTP requests","user":{"login":"gtschurwald","id":38668979,"avatar_url":"https://avatars3.githubusercontent.com/u/38668979?v=4","gravatar_id":"","url":"https://api.github.com/users/gtschurwald","html_url":"https://github.com/gtschurwald","followers_url":"https://api.github.com/users/gtschurwald/followers","following_url":"https://api.github.com/users/gtschurwald/following{/other_user}","gists_url":"https://api.github.com/users/gtschurwald/gists{/gist_id}","starred_url":"https://api.github.com/users/gtschurwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtschurwald/subscriptions","organizations_url":"https://api.github.com/users/gtschurwald/orgs","repos_url":"https://api.github.com/users/gtschurwald/repos","events_url":"https://api.github.com/users/gtschurwald/events{/privacy}","received_events_url":"https://api.github.com/users/gtschurwald/received_events","type":"User","site_admin":false},"body":"If SSL and a cert-key pair are needed to hit ES endpoints, this will update collectd to work properly. ","created_at":"2018-05-01T22:12:08Z","updated_at":"2018-05-10T20:30:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75588adb595c364c0c3da18040ed3b1710c93e30","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls/1/commits","review_comments_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls/1/comments","review_comment_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/issues/1/comments","statuses_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/statuses/5b55380396519a0699ffdcf08f13710235fa5810","head":{"label":"gtschurwald:correct-tls-branch","ref":"correct-tls-branch","sha":"5b55380396519a0699ffdcf08f13710235fa5810","user":{"login":"gtschurwald","id":38668979,"avatar_url":"https://avatars3.githubusercontent.com/u/38668979?v=4","gravatar_id":"","url":"https://api.github.com/users/gtschurwald","html_url":"https://github.com/gtschurwald","followers_url":"https://api.github.com/users/gtschurwald/followers","following_url":"https://api.github.com/users/gtschurwald/following{/other_user}","gists_url":"https://api.github.com/users/gtschurwald/gists{/gist_id}","starred_url":"https://api.github.com/users/gtschurwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtschurwald/subscriptions","organizations_url":"https://api.github.com/users/gtschurwald/orgs","repos_url":"https://api.github.com/users/gtschurwald/repos","events_url":"https://api.github.com/users/gtschurwald/events{/privacy}","received_events_url":"https://api.github.com/users/gtschurwald/received_events","type":"User","site_admin":false},"repo":{"id":130761038,"name":"collectd-elasticsearch","full_name":"gtschurwald/collectd-elasticsearch","owner":{"login":"gtschurwald","id":38668979,"avatar_url":"https://avatars3.githubusercontent.com/u/38668979?v=4","gravatar_id":"","url":"https://api.github.com/users/gtschurwald","html_url":"https://github.com/gtschurwald","followers_url":"https://api.github.com/users/gtschurwald/followers","following_url":"https://api.github.com/users/gtschurwald/following{/other_user}","gists_url":"https://api.github.com/users/gtschurwald/gists{/gist_id}","starred_url":"https://api.github.com/users/gtschurwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtschurwald/subscriptions","organizations_url":"https://api.github.com/users/gtschurwald/orgs","repos_url":"https://api.github.com/users/gtschurwald/repos","events_url":"https://api.github.com/users/gtschurwald/events{/privacy}","received_events_url":"https://api.github.com/users/gtschurwald/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gtschurwald/collectd-elasticsearch","description":"CollectD ElasticSearch plugin","fork":true,"url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch","forks_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/forks","keys_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/teams","hooks_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/events","assignees_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/tags","blobs_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/subscription","commits_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/merges","archive_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/downloads","issues_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/gtschurwald/collectd-elasticsearch/deployments","created_at":"2018-04-23T21:51:36Z","updated_at":"2018-05-01T16:03:10Z","pushed_at":"2018-05-01T16:22:21Z","git_url":"git://github.com/gtschurwald/collectd-elasticsearch.git","ssh_url":"git@github.com:gtschurwald/collectd-elasticsearch.git","clone_url":"https://github.com/gtschurwald/collectd-elasticsearch.git","svn_url":"https://github.com/gtschurwald/collectd-elasticsearch","homepage":"","size":128,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HubSpot:master","ref":"master","sha":"2cd3484acb980f0b3a096daceee37f24df0bb014","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars2.githubusercontent.com/u/326419?v=4","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":60407907,"name":"collectd-elasticsearch","full_name":"HubSpot/collectd-elasticsearch","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars2.githubusercontent.com/u/326419?v=4","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/collectd-elasticsearch","description":"CollectD ElasticSearch plugin","fork":true,"url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch","forks_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/forks","keys_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/teams","hooks_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/events","assignees_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/tags","blobs_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/subscription","commits_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/merges","archive_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/downloads","issues_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/deployments","created_at":"2016-06-04T11:50:02Z","updated_at":"2018-04-23T19:46:24Z","pushed_at":"2018-05-01T22:12:08Z","git_url":"git://github.com/HubSpot/collectd-elasticsearch.git","ssh_url":"git@github.com:HubSpot/collectd-elasticsearch.git","clone_url":"https://github.com/HubSpot/collectd-elasticsearch.git","svn_url":"https://github.com/HubSpot/collectd-elasticsearch","homepage":"","size":59,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls/1"},"html":{"href":"https://github.com/HubSpot/collectd-elasticsearch/pull/1"},"issue":{"href":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/issues/1"},"comments":{"href":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/HubSpot/collectd-elasticsearch/statuses/5b55380396519a0699ffdcf08f13710235fa5810"}},"author_association":"NONE"}}
{"actor":{"display_login":"natejlong"}}