{"action":"created","comment":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/183821152","pull_request_review_id":114892948,"id":183821152,"diff_hunk":"@@ -229,10 +50,6 @@ def __init__(self,\n       Class-Path set to those jars.\n     :param string archive: Create an archive of this type from the bundle.\n     \"\"\"\n-    if archive and archive not in Archive.TYPE_NAMES:","path":"src/python/pants/backend/jvm/targets/jvm_app.py","position":201,"original_position":201,"commit_id":"bccd7551b77053bd2fe615d06874e1e2d0cf61d7","original_commit_id":"bccd7551b77053bd2fe615d06874e1e2d0cf61d7","user":{"login":"stuhood","id":46740,"avatar_url":"https://avatars1.githubusercontent.com/u/46740?v=4","gravatar_id":"","url":"https://api.github.com/users/stuhood","html_url":"https://github.com/stuhood","followers_url":"https://api.github.com/users/stuhood/followers","following_url":"https://api.github.com/users/stuhood/following{/other_user}","gists_url":"https://api.github.com/users/stuhood/gists{/gist_id}","starred_url":"https://api.github.com/users/stuhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuhood/subscriptions","organizations_url":"https://api.github.com/users/stuhood/orgs","repos_url":"https://api.github.com/users/stuhood/repos","events_url":"https://api.github.com/users/stuhood/events{/privacy}","received_events_url":"https://api.github.com/users/stuhood/received_events","type":"User","site_admin":false},"body":"It looks like the `archive`, `binary`, `basename`, `bundles`, etc arguments should be lifted into the baseclass, as they are/should-be shared between subclasses. `deployjar` is I think a JVM-specific concept though, so can stay.","created_at":"2018-04-24T17:41:17Z","updated_at":"2018-04-24T17:52:12Z","html_url":"https://github.com/pantsbuild/pants/pull/5704#discussion_r183821152","pull_request_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5704","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/183821152"},"html":{"href":"https://github.com/pantsbuild/pants/pull/5704#discussion_r183821152"},"pull_request":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5704"}}},"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/5704","id":181740739,"html_url":"https://github.com/pantsbuild/pants/pull/5704","diff_url":"https://github.com/pantsbuild/pants/pull/5704.diff","patch_url":"https://github.com/pantsbuild/pants/pull/5704.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/5704","number":5704,"state":"open","locked":false,"title":"Add python_app support","user":{"login":"traviscrawford","id":112258,"avatar_url":"https://avatars0.githubusercontent.com/u/112258?v=4","gravatar_id":"","url":"https://api.github.com/users/traviscrawford","html_url":"https://github.com/traviscrawford","followers_url":"https://api.github.com/users/traviscrawford/followers","following_url":"https://api.github.com/users/traviscrawford/following{/other_user}","gists_url":"https://api.github.com/users/traviscrawford/gists{/gist_id}","starred_url":"https://api.github.com/users/traviscrawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviscrawford/subscriptions","organizations_url":"https://api.github.com/users/traviscrawford/orgs","repos_url":"https://api.github.com/users/traviscrawford/repos","events_url":"https://api.github.com/users/traviscrawford/events{/privacy}","received_events_url":"https://api.github.com/users/traviscrawford/received_events","type":"User","site_admin":false},"body":"Pants supports the \"app\" concept - a binary + other loose files - but currently only has the `jvm_app` implementation. Here we add `python_app` which is given a `python_binary` and `bundles` to include in an archive. This enables users to easily create a pex along with other files needed in production and create a deployable archive.","created_at":"2018-04-16T02:42:17Z","updated_at":"2018-04-24T17:52:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa30bffdf423f188fb6f520a48dc86741c1b17d5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jsirois","id":157586,"avatar_url":"https://avatars1.githubusercontent.com/u/157586?v=4","gravatar_id":"","url":"https://api.github.com/users/jsirois","html_url":"https://github.com/jsirois","followers_url":"https://api.github.com/users/jsirois/followers","following_url":"https://api.github.com/users/jsirois/following{/other_user}","gists_url":"https://api.github.com/users/jsirois/gists{/gist_id}","starred_url":"https://api.github.com/users/jsirois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsirois/subscriptions","organizations_url":"https://api.github.com/users/jsirois/orgs","repos_url":"https://api.github.com/users/jsirois/repos","events_url":"https://api.github.com/users/jsirois/events{/privacy}","received_events_url":"https://api.github.com/users/jsirois/received_events","type":"User","site_admin":false},{"login":"benjyw","id":512764,"avatar_url":"https://avatars2.githubusercontent.com/u/512764?v=4","gravatar_id":"","url":"https://api.github.com/users/benjyw","html_url":"https://github.com/benjyw","followers_url":"https://api.github.com/users/benjyw/followers","following_url":"https://api.github.com/users/benjyw/following{/other_user}","gists_url":"https://api.github.com/users/benjyw/gists{/gist_id}","starred_url":"https://api.github.com/users/benjyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjyw/subscriptions","organizations_url":"https://api.github.com/users/benjyw/orgs","repos_url":"https://api.github.com/users/benjyw/repos","events_url":"https://api.github.com/users/benjyw/events{/privacy}","received_events_url":"https://api.github.com/users/benjyw/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5704/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5704/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/5704/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/bccd7551b77053bd2fe615d06874e1e2d0cf61d7","head":{"label":"traviscrawford:travis/python_app","ref":"travis/python_app","sha":"bccd7551b77053bd2fe615d06874e1e2d0cf61d7","user":{"login":"traviscrawford","id":112258,"avatar_url":"https://avatars0.githubusercontent.com/u/112258?v=4","gravatar_id":"","url":"https://api.github.com/users/traviscrawford","html_url":"https://github.com/traviscrawford","followers_url":"https://api.github.com/users/traviscrawford/followers","following_url":"https://api.github.com/users/traviscrawford/following{/other_user}","gists_url":"https://api.github.com/users/traviscrawford/gists{/gist_id}","starred_url":"https://api.github.com/users/traviscrawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviscrawford/subscriptions","organizations_url":"https://api.github.com/users/traviscrawford/orgs","repos_url":"https://api.github.com/users/traviscrawford/repos","events_url":"https://api.github.com/users/traviscrawford/events{/privacy}","received_events_url":"https://api.github.com/users/traviscrawford/received_events","type":"User","site_admin":false},"repo":{"id":18538979,"name":"pants","full_name":"traviscrawford/pants","owner":{"login":"traviscrawford","id":112258,"avatar_url":"https://avatars0.githubusercontent.com/u/112258?v=4","gravatar_id":"","url":"https://api.github.com/users/traviscrawford","html_url":"https://github.com/traviscrawford","followers_url":"https://api.github.com/users/traviscrawford/followers","following_url":"https://api.github.com/users/traviscrawford/following{/other_user}","gists_url":"https://api.github.com/users/traviscrawford/gists{/gist_id}","starred_url":"https://api.github.com/users/traviscrawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviscrawford/subscriptions","organizations_url":"https://api.github.com/users/traviscrawford/orgs","repos_url":"https://api.github.com/users/traviscrawford/repos","events_url":"https://api.github.com/users/traviscrawford/events{/privacy}","received_events_url":"https://api.github.com/users/traviscrawford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/traviscrawford/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/traviscrawford/pants","forks_url":"https://api.github.com/repos/traviscrawford/pants/forks","keys_url":"https://api.github.com/repos/traviscrawford/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/traviscrawford/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/traviscrawford/pants/teams","hooks_url":"https://api.github.com/repos/traviscrawford/pants/hooks","issue_events_url":"https://api.github.com/repos/traviscrawford/pants/issues/events{/number}","events_url":"https://api.github.com/repos/traviscrawford/pants/events","assignees_url":"https://api.github.com/repos/traviscrawford/pants/assignees{/user}","branches_url":"https://api.github.com/repos/traviscrawford/pants/branches{/branch}","tags_url":"https://api.github.com/repos/traviscrawford/pants/tags","blobs_url":"https://api.github.com/repos/traviscrawford/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/traviscrawford/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/traviscrawford/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/traviscrawford/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/traviscrawford/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/traviscrawford/pants/languages","stargazers_url":"https://api.github.com/repos/traviscrawford/pants/stargazers","contributors_url":"https://api.github.com/repos/traviscrawford/pants/contributors","subscribers_url":"https://api.github.com/repos/traviscrawford/pants/subscribers","subscription_url":"https://api.github.com/repos/traviscrawford/pants/subscription","commits_url":"https://api.github.com/repos/traviscrawford/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/traviscrawford/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/traviscrawford/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/traviscrawford/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/traviscrawford/pants/contents/{+path}","compare_url":"https://api.github.com/repos/traviscrawford/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/traviscrawford/pants/merges","archive_url":"https://api.github.com/repos/traviscrawford/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/traviscrawford/pants/downloads","issues_url":"https://api.github.com/repos/traviscrawford/pants/issues{/number}","pulls_url":"https://api.github.com/repos/traviscrawford/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/traviscrawford/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/traviscrawford/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/traviscrawford/pants/labels{/name}","releases_url":"https://api.github.com/repos/traviscrawford/pants/releases{/id}","deployments_url":"https://api.github.com/repos/traviscrawford/pants/deployments","created_at":"2014-04-08T00:06:04Z","updated_at":"2018-04-06T03:54:41Z","pushed_at":"2018-04-21T03:30:31Z","git_url":"git://github.com/traviscrawford/pants.git","ssh_url":"git@github.com:traviscrawford/pants.git","clone_url":"https://github.com/traviscrawford/pants.git","svn_url":"https://github.com/traviscrawford/pants","homepage":"http://pantsbuild.github.io/","size":83754,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"22fb51c2dd13520756e006e584a2f5178f3f8e94","user":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"The Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","deployments_url":"https://api.github.com/repos/pantsbuild/pants/deployments","created_at":"2012-12-17T17:39:04Z","updated_at":"2018-04-24T17:35:21Z","pushed_at":"2018-04-24T17:35:13Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.org/","size":83482,"stargazers_count":947,"watchers_count":947,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":272,"mirror_url":null,"archived":false,"open_issues_count":613,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":272,"open_issues":613,"watchers":947,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5704"},"html":{"href":"https://github.com/pantsbuild/pants/pull/5704"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/5704"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/5704/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5704/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5704/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/bccd7551b77053bd2fe615d06874e1e2d0cf61d7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"stuhood"}}