{"action":"opened","number":430,"pull_request":{"url":"https://api.github.com/repos/mullvad/mullvadvpn-app/pulls/430","id":213942099,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTQyMDk5","html_url":"https://github.com/mullvad/mullvadvpn-app/pull/430","diff_url":"https://github.com/mullvad/mullvadvpn-app/pull/430.diff","patch_url":"https://github.com/mullvad/mullvadvpn-app/pull/430.patch","issue_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/issues/430","number":430,"state":"open","locked":false,"title":"Removes conditional navigation from routes","user":{"login":"pronebird","id":704044,"node_id":"MDQ6VXNlcjcwNDA0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/704044?v=4","gravatar_id":"","url":"https://api.github.com/users/pronebird","html_url":"https://github.com/pronebird","followers_url":"https://api.github.com/users/pronebird/followers","following_url":"https://api.github.com/users/pronebird/following{/other_user}","gists_url":"https://api.github.com/users/pronebird/gists{/gist_id}","starred_url":"https://api.github.com/users/pronebird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pronebird/subscriptions","organizations_url":"https://api.github.com/users/pronebird/orgs","repos_url":"https://api.github.com/users/pronebird/repos","events_url":"https://api.github.com/users/pronebird/events{/privacy}","received_events_url":"https://api.github.com/users/pronebird/received_events","type":"User","site_admin":false},"body":"Describe **what** this PR changes. **Why** this is wanted. And, if needed, **how** it does it.\r\n\r\nGit checklist:\r\n\r\n* [X] Describe the change in **`CHANGELOG.md`** under the `[Unreleased]` header.\r\n* [X] Check that commits follow the [Mullvad coding guidelines](https://github.com/mullvad/coding-guidelines)\r\n\r\n## What\r\n\r\nThis PR removes conditional navigation from `<Route/>`s.\r\n\r\n## Why\r\n\r\nAll of the navigation now happens in `app.js` in response to either unix socket RPC connection changes, or daemon subscription events, etc.. \r\n\r\nI expect that soon we'll have to handle even more disruptive events such as log out by other frontend and CLI.\r\n\r\nThis PR attempts to collect all of the navigation happening within GUI in one place. This should also patch up the obscure situation when user ends up on the \"Logged in\" screen on statup..\r\n","created_at":"2018-09-07T14:16:31Z","updated_at":"2018-09-07T14:16:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/pulls/430/commits","review_comments_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/pulls/430/comments","review_comment_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/issues/430/comments","statuses_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/statuses/d44d7a759d6976d5a0625a9e4ba2fd3af4bba66f","head":{"label":"mullvad:fix-routing","ref":"fix-routing","sha":"d44d7a759d6976d5a0625a9e4ba2fd3af4bba66f","user":{"login":"mullvad","id":10848549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ4NTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/10848549?v=4","gravatar_id":"","url":"https://api.github.com/users/mullvad","html_url":"https://github.com/mullvad","followers_url":"https://api.github.com/users/mullvad/followers","following_url":"https://api.github.com/users/mullvad/following{/other_user}","gists_url":"https://api.github.com/users/mullvad/gists{/gist_id}","starred_url":"https://api.github.com/users/mullvad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mullvad/subscriptions","organizations_url":"https://api.github.com/users/mullvad/orgs","repos_url":"https://api.github.com/users/mullvad/repos","events_url":"https://api.github.com/users/mullvad/events{/privacy}","received_events_url":"https://api.github.com/users/mullvad/received_events","type":"Organization","site_admin":false},"repo":{"id":114742422,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3NDI0MjI=","name":"mullvadvpn-app","full_name":"mullvad/mullvadvpn-app","owner":{"login":"mullvad","id":10848549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ4NTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/10848549?v=4","gravatar_id":"","url":"https://api.github.com/users/mullvad","html_url":"https://github.com/mullvad","followers_url":"https://api.github.com/users/mullvad/followers","following_url":"https://api.github.com/users/mullvad/following{/other_user}","gists_url":"https://api.github.com/users/mullvad/gists{/gist_id}","starred_url":"https://api.github.com/users/mullvad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mullvad/subscriptions","organizations_url":"https://api.github.com/users/mullvad/orgs","repos_url":"https://api.github.com/users/mullvad/repos","events_url":"https://api.github.com/users/mullvad/events{/privacy}","received_events_url":"https://api.github.com/users/mullvad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mullvad/mullvadvpn-app","description":"The Mullvad VPN client app for desktop and mobile","fork":false,"url":"https://api.github.com/repos/mullvad/mullvadvpn-app","forks_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/forks","keys_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/teams","hooks_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/hooks","issue_events_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/issues/events{/number}","events_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/events","assignees_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/assignees{/user}","branches_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/branches{/branch}","tags_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/tags","blobs_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/statuses/{sha}","languages_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/languages","stargazers_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/stargazers","contributors_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/contributors","subscribers_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/subscribers","subscription_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/subscription","commits_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/contents/{+path}","compare_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/merges","archive_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/downloads","issues_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/issues{/number}","pulls_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/pulls{/number}","milestones_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/milestones{/number}","notifications_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/labels{/name}","releases_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/releases{/id}","deployments_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/deployments","created_at":"2017-12-19T08:59:42Z","updated_at":"2018-09-07T13:28:58Z","pushed_at":"2018-09-07T14:14:29Z","git_url":"git://github.com/mullvad/mullvadvpn-app.git","ssh_url":"git@github.com:mullvad/mullvadvpn-app.git","clone_url":"https://github.com/mullvad/mullvadvpn-app.git","svn_url":"https://github.com/mullvad/mullvadvpn-app","homepage":null,"size":12929,"stargazers_count":137,"watchers_count":137,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":10,"open_issues":17,"watchers":137,"default_branch":"master"}},"base":{"label":"mullvad:master","ref":"master","sha":"ad640c6314f839f14083786dea5c158fb388195f","user":{"login":"mullvad","id":10848549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ4NTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/10848549?v=4","gravatar_id":"","url":"https://api.github.com/users/mullvad","html_url":"https://github.com/mullvad","followers_url":"https://api.github.com/users/mullvad/followers","following_url":"https://api.github.com/users/mullvad/following{/other_user}","gists_url":"https://api.github.com/users/mullvad/gists{/gist_id}","starred_url":"https://api.github.com/users/mullvad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mullvad/subscriptions","organizations_url":"https://api.github.com/users/mullvad/orgs","repos_url":"https://api.github.com/users/mullvad/repos","events_url":"https://api.github.com/users/mullvad/events{/privacy}","received_events_url":"https://api.github.com/users/mullvad/received_events","type":"Organization","site_admin":false},"repo":{"id":114742422,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3NDI0MjI=","name":"mullvadvpn-app","full_name":"mullvad/mullvadvpn-app","owner":{"login":"mullvad","id":10848549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ4NTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/10848549?v=4","gravatar_id":"","url":"https://api.github.com/users/mullvad","html_url":"https://github.com/mullvad","followers_url":"https://api.github.com/users/mullvad/followers","following_url":"https://api.github.com/users/mullvad/following{/other_user}","gists_url":"https://api.github.com/users/mullvad/gists{/gist_id}","starred_url":"https://api.github.com/users/mullvad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mullvad/subscriptions","organizations_url":"https://api.github.com/users/mullvad/orgs","repos_url":"https://api.github.com/users/mullvad/repos","events_url":"https://api.github.com/users/mullvad/events{/privacy}","received_events_url":"https://api.github.com/users/mullvad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mullvad/mullvadvpn-app","description":"The Mullvad VPN client app for desktop and mobile","fork":false,"url":"https://api.github.com/repos/mullvad/mullvadvpn-app","forks_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/forks","keys_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/teams","hooks_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/hooks","issue_events_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/issues/events{/number}","events_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/events","assignees_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/assignees{/user}","branches_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/branches{/branch}","tags_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/tags","blobs_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/statuses/{sha}","languages_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/languages","stargazers_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/stargazers","contributors_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/contributors","subscribers_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/subscribers","subscription_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/subscription","commits_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/contents/{+path}","compare_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/merges","archive_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/downloads","issues_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/issues{/number}","pulls_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/pulls{/number}","milestones_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/milestones{/number}","notifications_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/labels{/name}","releases_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/releases{/id}","deployments_url":"https://api.github.com/repos/mullvad/mullvadvpn-app/deployments","created_at":"2017-12-19T08:59:42Z","updated_at":"2018-09-07T13:28:58Z","pushed_at":"2018-09-07T14:14:29Z","git_url":"git://github.com/mullvad/mullvadvpn-app.git","ssh_url":"git@github.com:mullvad/mullvadvpn-app.git","clone_url":"https://github.com/mullvad/mullvadvpn-app.git","svn_url":"https://github.com/mullvad/mullvadvpn-app","homepage":null,"size":12929,"stargazers_count":137,"watchers_count":137,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":10,"open_issues":17,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mullvad/mullvadvpn-app/pulls/430"},"html":{"href":"https://github.com/mullvad/mullvadvpn-app/pull/430"},"issue":{"href":"https://api.github.com/repos/mullvad/mullvadvpn-app/issues/430"},"comments":{"href":"https://api.github.com/repos/mullvad/mullvadvpn-app/issues/430/comments"},"review_comments":{"href":"https://api.github.com/repos/mullvad/mullvadvpn-app/pulls/430/comments"},"review_comment":{"href":"https://api.github.com/repos/mullvad/mullvadvpn-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mullvad/mullvadvpn-app/pulls/430/commits"},"statuses":{"href":"https://api.github.com/repos/mullvad/mullvadvpn-app/statuses/d44d7a759d6976d5a0625a9e4ba2fd3af4bba66f"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":45,"deletions":179,"changed_files":5}}
{"actor":{"display_login":"pronebird"}}