{"push_id":2727569013,"size":6,"distinct_size":6,"ref":"refs/heads/master","head":"93954858227937a34b99f14c26292e04ea450df0","before":"daa7c78055857cd2d9ea650de0c4b0f72d3f2acf","commits":[{"sha":"e906d4cdc928b35d2648482e7a83122004ac584d","author":{"name":"Valentin Shergin","email":"af6d8ef37a13207735edb899bf79438570064a0b@fb.com"},"message":"Simplifying child nodes management in YogaLayoutableShadowNode\n\nSummary:\n@public\n\nThis diff consists of many interdependent changes which support one simple idea: YogaLayoutableShadowNode is now using YGNode children to iterate on them (it previously relied on `ShadowNode::getChildren()`). All other changes are just an unavoidable consequence of that. Hence we don't need to filter child nodes every single time when we do layout anymore! The logic around `clone callback` is also drastically simpler now.\nThe new approach also implies that `LayoutableShadowNode` and `YogaLayoutableShadowNode` don't use `shared_ptr`s to refer to ShadowNode objects because new relationship does not imply ownership. No more `SharedShadowNode` objects in those two classes.\n\nReviewed By: mdvacca\n\nDifferential Revision: D8796159\n\nfbshipit-source-id: 6f52f92d1826f3eb13b2f8a132c3ea77de155d82","distinct":true,"url":"https://api.github.com/repos/facebook/react-native/commits/e906d4cdc928b35d2648482e7a83122004ac584d"},{"sha":"ec5b1fd259403b613100286fe73a0592b8d57781","author":{"name":"Valentin Shergin","email":"af6d8ef37a13207735edb899bf79438570064a0b@fb.com"},"message":"Fabric: Optimized ShadowNode::replaceChild() with `suggestedIndex` argument\n\nSummary:\n@public\nIn most cases callsite knows probable index of replacing child node, hence it makes sense to provide this info to `replaceChild` to illuminate O(n) search in most cases.\n\nReviewed By: mdvacca\n\nDifferential Revision: D8814809\n\nfbshipit-source-id: 0edf82878a72260365e2757beb3886ad07c7464d","distinct":true,"url":"https://api.github.com/repos/facebook/react-native/commits/ec5b1fd259403b613100286fe73a0592b8d57781"},{"sha":"58da98149d3de4bea46c9b0c59d04f65ae80e062","author":{"name":"Valentin Shergin","email":"af6d8ef37a13207735edb899bf79438570064a0b@fb.com"},"message":"Fabric: Support for optional `key` parameter to register/retrieve in ContextContainer\n\nSummary:\n@public\nWe need this in case when we want to store several intances of the same class in the container.\n\nReviewed By: mdvacca\n\nDifferential Revision: D8814808\n\nfbshipit-source-id: 78ab15d78cf3878d03bf0a45bc42b968d87435e7","distinct":true,"url":"https://api.github.com/repos/facebook/react-native/commits/58da98149d3de4bea46c9b0c59d04f65ae80e062"},{"sha":"88b861643794804f8e5b2a1ff6d9ae64a3b38b51","author":{"name":"Valentin Shergin","email":"af6d8ef37a13207735edb899bf79438570064a0b@fb.com"},"message":"Fabric: Using `unordered_map` instead of `map` for RawProps\n\nSummary:\n@public\nWe don't need to maintain an order of this collection, so using `unordered_map` is more appropriate.\n\nReviewed By: mdvacca\n\nDifferential Revision: D8826946\n\nfbshipit-source-id: f6890097cc5d6a1e06f6b2cfd1b7d68a388da461","distinct":true,"url":"https://api.github.com/repos/facebook/react-native/commits/88b861643794804f8e5b2a1ff6d9ae64a3b38b51"},{"sha":"07a4a959a7ff60b4c25c4c1057883e77a747a21d","author":{"name":"Valentin Shergin","email":"af6d8ef37a13207735edb899bf79438570064a0b@fb.com"},"message":"Fabric: Events related classes were moved to separate buck target\n\nSummary:\n@public\nWe need that because gonna add much more event-related stuff, so it deserves separate buck target.\n\nReviewed By: mdvacca\n\nDifferential Revision: D8831547\n\nfbshipit-source-id: 616581b39b425a49302d5f7f86267e62b0d58389","distinct":true,"url":"https://api.github.com/repos/facebook/react-native/commits/07a4a959a7ff60b4c25c4c1057883e77a747a21d"},{"sha":"93954858227937a34b99f14c26292e04ea450df0","author":{"name":"Valentin Shergin","email":"af6d8ef37a13207735edb899bf79438570064a0b@fb.com"},"message":"Fabric: ContextContainer is now able to store any copyable values\n\nSummary:\n@public\nPreviously, ContextContainer could store only `shared_ptr`s, but now it wraps all values in own `shared_ptr` container.\nI wish we can use `unique_ptr` here, but apparently we cannot because `unique_ptr` does not support type-erasure (`std::unique_ptr<void>` is illigal).\nBecasue ContextContainer is not supposed to be used in hot paths, the performance aspect of that does not actually matter.\n\nReviewed By: mdvacca\n\nDifferential Revision: D8853446\n\nfbshipit-source-id: e5d0a5595fe44c59f1395d6ffccf9d3fed923c83","distinct":true,"url":"https://api.github.com/repos/facebook/react-native/commits/93954858227937a34b99f14c26292e04ea450df0"}]}
{"actor":{"display_login":"facebook-github-bot"}}