{"action":"created","issue":{"url":"https://api.github.com/repos/lxde/qterminal/issues/394","repository_url":"https://api.github.com/repos/lxde/qterminal","labels_url":"https://api.github.com/repos/lxde/qterminal/issues/394/labels{/name}","comments_url":"https://api.github.com/repos/lxde/qterminal/issues/394/comments","events_url":"https://api.github.com/repos/lxde/qterminal/issues/394/events","html_url":"https://github.com/lxde/qterminal/pull/394","id":293342071,"number":394,"title":"Convert connect to the new syntax","user":{"login":"kdave","id":1729844,"avatar_url":"https://avatars2.githubusercontent.com/u/1729844?v=4","gravatar_id":"","url":"https://api.github.com/users/kdave","html_url":"https://github.com/kdave","followers_url":"https://api.github.com/users/kdave/followers","following_url":"https://api.github.com/users/kdave/following{/other_user}","gists_url":"https://api.github.com/users/kdave/gists{/gist_id}","starred_url":"https://api.github.com/users/kdave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdave/subscriptions","organizations_url":"https://api.github.com/users/kdave/orgs","repos_url":"https://api.github.com/users/kdave/repos","events_url":"https://api.github.com/users/kdave/events{/privacy}","received_events_url":"https://api.github.com/users/kdave/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-01-31T22:54:52Z","updated_at":"2018-02-01T12:48:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/lxde/qterminal/pulls/394","html_url":"https://github.com/lxde/qterminal/pull/394","diff_url":"https://github.com/lxde/qterminal/pull/394.diff","patch_url":"https://github.com/lxde/qterminal/pull/394.patch"},"body":"Convert connect calls that use the string-based syntax to the new one based on member pointer. Most of the conversions were straightforward, but there are some that are not:\r\n* overloaded slots need to be explicitly cast, using static_cast, it looks ugly, the syntax used is from the qt wiki\r\n* lambdas were converted to member functions\r\n* inherited singals/slots must be typed to the base class\r\n* signal and slot parameters must match, in simple cases dummy params were added, otherwise the static_cast would be needed\r\n* implicit parameter values do not work anymore, but were used in some cases to keep the changes minimal where functions had no params and do not care\r\n\r\nThere's one conversion not done yet. It's in mainwindow.cpp, MainWindow::setup_Action. The slot name is passed as string. I did not succeed to convert that to the member pointer syntax with. The code could be refactored to avoid passing the slot as argument, but I'd rather get an ack before I do that."},"comment":{"url":"https://api.github.com/repos/lxde/qterminal/issues/comments/362256079","html_url":"https://github.com/lxde/qterminal/pull/394#issuecomment-362256079","issue_url":"https://api.github.com/repos/lxde/qterminal/issues/394","id":362256079,"user":{"login":"kdave","id":1729844,"avatar_url":"https://avatars2.githubusercontent.com/u/1729844?v=4","gravatar_id":"","url":"https://api.github.com/users/kdave","html_url":"https://github.com/kdave","followers_url":"https://api.github.com/users/kdave/followers","following_url":"https://api.github.com/users/kdave/following{/other_user}","gists_url":"https://api.github.com/users/kdave/gists{/gist_id}","starred_url":"https://api.github.com/users/kdave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdave/subscriptions","organizations_url":"https://api.github.com/users/kdave/orgs","repos_url":"https://api.github.com/users/kdave/repos","events_url":"https://api.github.com/users/kdave/events{/privacy}","received_events_url":"https://api.github.com/users/kdave/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T12:48:46Z","updated_at":"2018-02-01T12:48:46Z","author_association":"CONTRIBUTOR","body":"> >  lambdas were converted to member functions\r\n\r\n> Why?\r\n\r\nThat one was likely wrong, the lambdas cannot be used if we'd want to do disconnect(). I mixed that up from another patch. Lambdas work with the new syntax fine, sorry for confusion."}}
{"actor":{"display_login":"kdave"}}