{"action":"created","comment":{"url":"https://api.github.com/repos/apache/nifi/pulls/comments/189464759","pull_request_review_id":121649455,"id":189464759,"diff_hunk":"@@ -375,7 +376,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session\n                         // If our determined timestamp is the same as that of our last listing, skip this execution as there are no updates\n                         if (minTimestampToListMillis.equals(this.lastListedLatestEntryTimestampMillis)) {\n                             context.yield();","path":"nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/AbstractListProcessor.java","position":11,"original_position":11,"commit_id":"29e737b62aa765a67c324ceb93ec6a1844db5fc1","original_commit_id":"29e737b62aa765a67c324ceb93ec6a1844db5fc1","user":{"login":"viazovskyi","id":1545234,"avatar_url":"https://avatars0.githubusercontent.com/u/1545234?v=4","gravatar_id":"","url":"https://api.github.com/users/viazovskyi","html_url":"https://github.com/viazovskyi","followers_url":"https://api.github.com/users/viazovskyi/followers","following_url":"https://api.github.com/users/viazovskyi/following{/other_user}","gists_url":"https://api.github.com/users/viazovskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/viazovskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viazovskyi/subscriptions","organizations_url":"https://api.github.com/users/viazovskyi/orgs","repos_url":"https://api.github.com/users/viazovskyi/repos","events_url":"https://api.github.com/users/viazovskyi/events{/privacy}","received_events_url":"https://api.github.com/users/viazovskyi/received_events","type":"User","site_admin":false},"body":"I'd like to move the original 'if' with yield out of the loop closer catch, then I don't need this new 'if' and variable. What do you think?","created_at":"2018-05-20T17:11:50Z","updated_at":"2018-05-20T17:11:51Z","html_url":"https://github.com/apache/nifi/pull/2657#discussion_r189464759","pull_request_url":"https://api.github.com/repos/apache/nifi/pulls/2657","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments/189464759"},"html":{"href":"https://github.com/apache/nifi/pull/2657#discussion_r189464759"},"pull_request":{"href":"https://api.github.com/repos/apache/nifi/pulls/2657"}},"in_reply_to_id":189455715},"pull_request":{"url":"https://api.github.com/repos/apache/nifi/pulls/2657","id":184071532,"html_url":"https://github.com/apache/nifi/pull/2657","diff_url":"https://github.com/apache/nifi/pull/2657.diff","patch_url":"https://github.com/apache/nifi/pull/2657.patch","issue_url":"https://api.github.com/repos/apache/nifi/issues/2657","number":2657,"state":"open","locked":false,"title":"NIFI-5109 Reset justElectedPrimaryNode flag right after reelection happen","user":{"login":"viazovskyi","id":1545234,"avatar_url":"https://avatars0.githubusercontent.com/u/1545234?v=4","gravatar_id":"","url":"https://api.github.com/users/viazovskyi","html_url":"https://github.com/viazovskyi","followers_url":"https://api.github.com/users/viazovskyi/followers","following_url":"https://api.github.com/users/viazovskyi/following{/other_user}","gists_url":"https://api.github.com/users/viazovskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/viazovskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viazovskyi/subscriptions","organizations_url":"https://api.github.com/users/viazovskyi/orgs","repos_url":"https://api.github.com/users/viazovskyi/repos","events_url":"https://api.github.com/users/viazovskyi/events{/privacy}","received_events_url":"https://api.github.com/users/viazovskyi/received_events","type":"User","site_admin":false},"body":"Thank you for submitting a contribution to Apache NiFi.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced \r\n     in the commit message?\r\n\r\n- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n- [x] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? \r\n- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?\r\n- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?\r\n- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?\r\n\r\n### For documentation related changes:\r\n- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\n","created_at":"2018-04-25T15:16:05Z","updated_at":"2018-05-20T17:11:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c37bcd543dcd373eeaeab465e6229d31ea6bdfa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/nifi/pulls/2657/commits","review_comments_url":"https://api.github.com/repos/apache/nifi/pulls/2657/comments","review_comment_url":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/nifi/issues/2657/comments","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/29e737b62aa765a67c324ceb93ec6a1844db5fc1","head":{"label":"viazovskyi:nifi-5109","ref":"nifi-5109","sha":"29e737b62aa765a67c324ceb93ec6a1844db5fc1","user":{"login":"viazovskyi","id":1545234,"avatar_url":"https://avatars0.githubusercontent.com/u/1545234?v=4","gravatar_id":"","url":"https://api.github.com/users/viazovskyi","html_url":"https://github.com/viazovskyi","followers_url":"https://api.github.com/users/viazovskyi/followers","following_url":"https://api.github.com/users/viazovskyi/following{/other_user}","gists_url":"https://api.github.com/users/viazovskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/viazovskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viazovskyi/subscriptions","organizations_url":"https://api.github.com/users/viazovskyi/orgs","repos_url":"https://api.github.com/users/viazovskyi/repos","events_url":"https://api.github.com/users/viazovskyi/events{/privacy}","received_events_url":"https://api.github.com/users/viazovskyi/received_events","type":"User","site_admin":false},"repo":{"id":131024180,"name":"nifi","full_name":"viazovskyi/nifi","owner":{"login":"viazovskyi","id":1545234,"avatar_url":"https://avatars0.githubusercontent.com/u/1545234?v=4","gravatar_id":"","url":"https://api.github.com/users/viazovskyi","html_url":"https://github.com/viazovskyi","followers_url":"https://api.github.com/users/viazovskyi/followers","following_url":"https://api.github.com/users/viazovskyi/following{/other_user}","gists_url":"https://api.github.com/users/viazovskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/viazovskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viazovskyi/subscriptions","organizations_url":"https://api.github.com/users/viazovskyi/orgs","repos_url":"https://api.github.com/users/viazovskyi/repos","events_url":"https://api.github.com/users/viazovskyi/events{/privacy}","received_events_url":"https://api.github.com/users/viazovskyi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/viazovskyi/nifi","description":"Mirror of Apache NiFi","fork":true,"url":"https://api.github.com/repos/viazovskyi/nifi","forks_url":"https://api.github.com/repos/viazovskyi/nifi/forks","keys_url":"https://api.github.com/repos/viazovskyi/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viazovskyi/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viazovskyi/nifi/teams","hooks_url":"https://api.github.com/repos/viazovskyi/nifi/hooks","issue_events_url":"https://api.github.com/repos/viazovskyi/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/viazovskyi/nifi/events","assignees_url":"https://api.github.com/repos/viazovskyi/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/viazovskyi/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/viazovskyi/nifi/tags","blobs_url":"https://api.github.com/repos/viazovskyi/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viazovskyi/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viazovskyi/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/viazovskyi/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viazovskyi/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/viazovskyi/nifi/languages","stargazers_url":"https://api.github.com/repos/viazovskyi/nifi/stargazers","contributors_url":"https://api.github.com/repos/viazovskyi/nifi/contributors","subscribers_url":"https://api.github.com/repos/viazovskyi/nifi/subscribers","subscription_url":"https://api.github.com/repos/viazovskyi/nifi/subscription","commits_url":"https://api.github.com/repos/viazovskyi/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/viazovskyi/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/viazovskyi/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/viazovskyi/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/viazovskyi/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/viazovskyi/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viazovskyi/nifi/merges","archive_url":"https://api.github.com/repos/viazovskyi/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viazovskyi/nifi/downloads","issues_url":"https://api.github.com/repos/viazovskyi/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/viazovskyi/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/viazovskyi/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/viazovskyi/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viazovskyi/nifi/labels{/name}","releases_url":"https://api.github.com/repos/viazovskyi/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/viazovskyi/nifi/deployments","created_at":"2018-04-25T15:07:22Z","updated_at":"2018-05-16T15:11:43Z","pushed_at":"2018-05-19T21:36:06Z","git_url":"git://github.com/viazovskyi/nifi.git","ssh_url":"git@github.com:viazovskyi/nifi.git","clone_url":"https://github.com/viazovskyi/nifi.git","svn_url":"https://github.com/viazovskyi/nifi","homepage":"","size":122044,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d79216d6b08a842dc0c5f6b847429aae87fb5561","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":27911088,"name":"nifi","full_name":"apache/nifi","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/nifi","description":"Mirror of Apache NiFi","fork":false,"url":"https://api.github.com/repos/apache/nifi","forks_url":"https://api.github.com/repos/apache/nifi/forks","keys_url":"https://api.github.com/repos/apache/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/nifi/teams","hooks_url":"https://api.github.com/repos/apache/nifi/hooks","issue_events_url":"https://api.github.com/repos/apache/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/apache/nifi/events","assignees_url":"https://api.github.com/repos/apache/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/apache/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/apache/nifi/tags","blobs_url":"https://api.github.com/repos/apache/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/nifi/languages","stargazers_url":"https://api.github.com/repos/apache/nifi/stargazers","contributors_url":"https://api.github.com/repos/apache/nifi/contributors","subscribers_url":"https://api.github.com/repos/apache/nifi/subscribers","subscription_url":"https://api.github.com/repos/apache/nifi/subscription","commits_url":"https://api.github.com/repos/apache/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/apache/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/nifi/merges","archive_url":"https://api.github.com/repos/apache/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/nifi/downloads","issues_url":"https://api.github.com/repos/apache/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/apache/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/nifi/labels{/name}","releases_url":"https://api.github.com/repos/apache/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/apache/nifi/deployments","created_at":"2014-12-12T08:00:05Z","updated_at":"2018-05-20T10:37:34Z","pushed_at":"2018-05-20T14:17:44Z","git_url":"git://github.com/apache/nifi.git","ssh_url":"git@github.com:apache/nifi.git","clone_url":"https://github.com/apache/nifi.git","svn_url":"https://github.com/apache/nifi","homepage":"","size":122038,"stargazers_count":942,"watchers_count":942,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":901,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":901,"open_issues":129,"watchers":942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/2657"},"html":{"href":"https://github.com/apache/nifi/pull/2657"},"issue":{"href":"https://api.github.com/repos/apache/nifi/issues/2657"},"comments":{"href":"https://api.github.com/repos/apache/nifi/issues/2657/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/nifi/pulls/2657/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/nifi/pulls/2657/commits"},"statuses":{"href":"https://api.github.com/repos/apache/nifi/statuses/29e737b62aa765a67c324ceb93ec6a1844db5fc1"}},"author_association":"NONE"}}
{"actor":{"display_login":"viazovskyi"}}