{"action":"closed","number":534,"pull_request":{"url":"https://api.github.com/repos/auth0/node-jsonwebtoken/pulls/534","id":222981080,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTgxMDgw","html_url":"https://github.com/auth0/node-jsonwebtoken/pull/534","diff_url":"https://github.com/auth0/node-jsonwebtoken/pull/534.diff","patch_url":"https://github.com/auth0/node-jsonwebtoken/pull/534.patch","issue_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/issues/534","number":534,"state":"closed","locked":false,"title":"Implement async/sync tests for sub claim","user":{"login":"MitMaro","id":177427,"node_id":"MDQ6VXNlcjE3NzQyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/177427?v=4","gravatar_id":"","url":"https://api.github.com/users/MitMaro","html_url":"https://github.com/MitMaro","followers_url":"https://api.github.com/users/MitMaro/followers","following_url":"https://api.github.com/users/MitMaro/following{/other_user}","gists_url":"https://api.github.com/users/MitMaro/gists{/gist_id}","starred_url":"https://api.github.com/users/MitMaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitMaro/subscriptions","organizations_url":"https://api.github.com/users/MitMaro/orgs","repos_url":"https://api.github.com/users/MitMaro/repos","events_url":"https://api.github.com/users/MitMaro/events{/privacy}","received_events_url":"https://api.github.com/users/MitMaro/received_events","type":"User","site_admin":false},"body":"For #492 \r\n\r\nThis implements the test helpers introduced in #523 for the sub claim. It's a pretty simple refactoring without any significant changes to the current tests.\r\n\r\n#### Coverage Master\r\n```\r\n=============================== Coverage summary ===============================\r\nStatements   : 97.87% ( 230/235 )\r\nBranches     : 97.55% ( 199/204 )\r\nFunctions    : 100% ( 23/23 )\r\nLines        : 98.28% ( 228/232 )\r\n================================================================================\r\n```\r\n\r\n#### Coverage Branch\r\n```\r\n=============================== Coverage summary ===============================\r\nStatements   : 97.87% ( 230/235 )\r\nBranches     : 97.55% ( 199/204 )\r\nFunctions    : 100% ( 23/23 )\r\nLines        : 98.28% ( 228/232 )\r\n================================================================================\r\n```","created_at":"2018-10-15T17:17:48Z","updated_at":"2018-10-16T16:45:43Z","closed_at":"2018-10-16T16:45:43Z","merged_at":"2018-10-16T16:45:43Z","merge_commit_sha":"342b07bb105a35739eb91265ba5b9dd33c300fc6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/pulls/534/commits","review_comments_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/pulls/534/comments","review_comment_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/pulls/comments{/number}","comments_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/issues/534/comments","statuses_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/statuses/8cd3f393a9b5a5047030ec8d6453564afd006bd0","head":{"label":"MitMaro:sub-async-tests","ref":"sub-async-tests","sha":"8cd3f393a9b5a5047030ec8d6453564afd006bd0","user":{"login":"MitMaro","id":177427,"node_id":"MDQ6VXNlcjE3NzQyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/177427?v=4","gravatar_id":"","url":"https://api.github.com/users/MitMaro","html_url":"https://github.com/MitMaro","followers_url":"https://api.github.com/users/MitMaro/followers","following_url":"https://api.github.com/users/MitMaro/following{/other_user}","gists_url":"https://api.github.com/users/MitMaro/gists{/gist_id}","starred_url":"https://api.github.com/users/MitMaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitMaro/subscriptions","organizations_url":"https://api.github.com/users/MitMaro/orgs","repos_url":"https://api.github.com/users/MitMaro/repos","events_url":"https://api.github.com/users/MitMaro/events{/privacy}","received_events_url":"https://api.github.com/users/MitMaro/received_events","type":"User","site_admin":false},"repo":{"id":137383714,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczODM3MTQ=","name":"node-jsonwebtoken","full_name":"MitMaro/node-jsonwebtoken","private":false,"owner":{"login":"MitMaro","id":177427,"node_id":"MDQ6VXNlcjE3NzQyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/177427?v=4","gravatar_id":"","url":"https://api.github.com/users/MitMaro","html_url":"https://github.com/MitMaro","followers_url":"https://api.github.com/users/MitMaro/followers","following_url":"https://api.github.com/users/MitMaro/following{/other_user}","gists_url":"https://api.github.com/users/MitMaro/gists{/gist_id}","starred_url":"https://api.github.com/users/MitMaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitMaro/subscriptions","organizations_url":"https://api.github.com/users/MitMaro/orgs","repos_url":"https://api.github.com/users/MitMaro/repos","events_url":"https://api.github.com/users/MitMaro/events{/privacy}","received_events_url":"https://api.github.com/users/MitMaro/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MitMaro/node-jsonwebtoken","description":"JsonWebToken implementation for node.js http://self-issued.info/docs/draft-ietf-oauth-json-web-token.html","fork":true,"url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken","forks_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/forks","keys_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/teams","hooks_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/hooks","issue_events_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/issues/events{/number}","events_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/events","assignees_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/assignees{/user}","branches_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/branches{/branch}","tags_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/tags","blobs_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/git/refs{/sha}","trees_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/statuses/{sha}","languages_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/languages","stargazers_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/stargazers","contributors_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/contributors","subscribers_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/subscribers","subscription_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/subscription","commits_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/commits{/sha}","git_commits_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/git/commits{/sha}","comments_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/comments{/number}","issue_comment_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/issues/comments{/number}","contents_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/contents/{+path}","compare_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/merges","archive_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/downloads","issues_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/issues{/number}","pulls_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/pulls{/number}","milestones_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/milestones{/number}","notifications_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/labels{/name}","releases_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/releases{/id}","deployments_url":"https://api.github.com/repos/MitMaro/node-jsonwebtoken/deployments","created_at":"2018-06-14T16:36:17Z","updated_at":"2018-07-22T00:55:37Z","pushed_at":"2018-10-16T16:02:24Z","git_url":"git://github.com/MitMaro/node-jsonwebtoken.git","ssh_url":"git@github.com:MitMaro/node-jsonwebtoken.git","clone_url":"https://github.com/MitMaro/node-jsonwebtoken.git","svn_url":"https://github.com/MitMaro/node-jsonwebtoken","homepage":null,"size":363,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"auth0:master","ref":"master","sha":"29cd654b956529e939ae8f8c30b9da7063aad501","user":{"login":"auth0","id":2824157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjQxNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/2824157?v=4","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"repo":{"id":11081405,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA4MTQwNQ==","name":"node-jsonwebtoken","full_name":"auth0/node-jsonwebtoken","private":false,"owner":{"login":"auth0","id":2824157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjQxNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/2824157?v=4","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/auth0/node-jsonwebtoken","description":"JsonWebToken implementation for node.js http://self-issued.info/docs/draft-ietf-oauth-json-web-token.html","fork":false,"url":"https://api.github.com/repos/auth0/node-jsonwebtoken","forks_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/forks","keys_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/teams","hooks_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/hooks","issue_events_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/issues/events{/number}","events_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/events","assignees_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/assignees{/user}","branches_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/branches{/branch}","tags_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/tags","blobs_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/git/refs{/sha}","trees_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/statuses/{sha}","languages_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/languages","stargazers_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/stargazers","contributors_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/contributors","subscribers_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/subscribers","subscription_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/subscription","commits_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/commits{/sha}","git_commits_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/git/commits{/sha}","comments_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/comments{/number}","issue_comment_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/issues/comments{/number}","contents_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/contents/{+path}","compare_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/merges","archive_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/downloads","issues_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/issues{/number}","pulls_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/pulls{/number}","milestones_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/milestones{/number}","notifications_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/labels{/name}","releases_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/releases{/id}","deployments_url":"https://api.github.com/repos/auth0/node-jsonwebtoken/deployments","created_at":"2013-07-01T01:28:43Z","updated_at":"2018-10-16T15:39:04Z","pushed_at":"2018-10-16T16:45:43Z","git_url":"git://github.com/auth0/node-jsonwebtoken.git","ssh_url":"git@github.com:auth0/node-jsonwebtoken.git","clone_url":"https://github.com/auth0/node-jsonwebtoken.git","svn_url":"https://github.com/auth0/node-jsonwebtoken","homepage":null,"size":355,"stargazers_count":8691,"watchers_count":8691,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":632,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":632,"open_issues":43,"watchers":8691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/auth0/node-jsonwebtoken/pulls/534"},"html":{"href":"https://github.com/auth0/node-jsonwebtoken/pull/534"},"issue":{"href":"https://api.github.com/repos/auth0/node-jsonwebtoken/issues/534"},"comments":{"href":"https://api.github.com/repos/auth0/node-jsonwebtoken/issues/534/comments"},"review_comments":{"href":"https://api.github.com/repos/auth0/node-jsonwebtoken/pulls/534/comments"},"review_comment":{"href":"https://api.github.com/repos/auth0/node-jsonwebtoken/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/auth0/node-jsonwebtoken/pulls/534/commits"},"statuses":{"href":"https://api.github.com/repos/auth0/node-jsonwebtoken/statuses/8cd3f393a9b5a5047030ec8d6453564afd006bd0"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ziluvatar","id":1424663,"node_id":"MDQ6VXNlcjE0MjQ2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1424663?v=4","gravatar_id":"","url":"https://api.github.com/users/ziluvatar","html_url":"https://github.com/ziluvatar","followers_url":"https://api.github.com/users/ziluvatar/followers","following_url":"https://api.github.com/users/ziluvatar/following{/other_user}","gists_url":"https://api.github.com/users/ziluvatar/gists{/gist_id}","starred_url":"https://api.github.com/users/ziluvatar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziluvatar/subscriptions","organizations_url":"https://api.github.com/users/ziluvatar/orgs","repos_url":"https://api.github.com/users/ziluvatar/repos","events_url":"https://api.github.com/users/ziluvatar/events{/privacy}","received_events_url":"https://api.github.com/users/ziluvatar/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":97,"deletions":51,"changed_files":1}}
{"actor":{"display_login":"ziluvatar"}}