{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/180468482","pull_request_review_id":110893413,"id":180468482,"diff_hunk":"@@ -678,7 +678,7 @@ added: v0.3.0\n Reference to the underlying socket. Usually users will not want to access\n this property. In particular, the socket will not emit `'readable'` events\n because of how the protocol parser attaches to the socket. After\n-`response.end()`, the property is nulled. The `socket` may also be accessed\n+`request.end()`, the property is nulled. The `socket` may also be accessed","path":"doc/api/http.md","position":5,"original_position":5,"commit_id":"9c421966d8070b33eb71056142fbd006b0c2b8e8","original_commit_id":"9c421966d8070b33eb71056142fbd006b0c2b8e8","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars2.githubusercontent.com/u/439929?v=4","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"body":"hmmm... actually good point. Missed that on my initial read through","created_at":"2018-04-10T15:37:27Z","updated_at":"2018-04-10T15:37:27Z","html_url":"https://github.com/nodejs/node/pull/19507#discussion_r180468482","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/19507","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/180468482"},"html":{"href":"https://github.com/nodejs/node/pull/19507#discussion_r180468482"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/19507"}},"in_reply_to_id":176018663},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/19507","id":176407177,"html_url":"https://github.com/nodejs/node/pull/19507","diff_url":"https://github.com/nodejs/node/pull/19507.diff","patch_url":"https://github.com/nodejs/node/pull/19507.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/19507","number":19507,"state":"open","locked":false,"title":"doc: fix wrong response.end() at request.socket","user":{"login":"ikasumiwt","id":4006425,"avatar_url":"https://avatars2.githubusercontent.com/u/4006425?v=4","gravatar_id":"","url":"https://api.github.com/users/ikasumiwt","html_url":"https://github.com/ikasumiwt","followers_url":"https://api.github.com/users/ikasumiwt/followers","following_url":"https://api.github.com/users/ikasumiwt/following{/other_user}","gists_url":"https://api.github.com/users/ikasumiwt/gists{/gist_id}","starred_url":"https://api.github.com/users/ikasumiwt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikasumiwt/subscriptions","organizations_url":"https://api.github.com/users/ikasumiwt/orgs","repos_url":"https://api.github.com/users/ikasumiwt/repos","events_url":"https://api.github.com/users/ikasumiwt/events{/privacy}","received_events_url":"https://api.github.com/users/ikasumiwt/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\nFixed `response.end()` to `request.end()` at request.socket because `request.socket` property was null when called after `request.end()` method.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-03-21T08:31:21Z","updated_at":"2018-04-10T15:37:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f4ff620a5b26e4d8ea08bd8a70ad51c6810a25a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267517,"url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false},{"id":155267422,"url":"https://api.github.com/repos/nodejs/node/labels/http","name":"http","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/19507/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/19507/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19507/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/9c421966d8070b33eb71056142fbd006b0c2b8e8","head":{"label":"ikasumiwt:feature/fix-request-socket-doc","ref":"feature/fix-request-socket-doc","sha":"9c421966d8070b33eb71056142fbd006b0c2b8e8","user":{"login":"ikasumiwt","id":4006425,"avatar_url":"https://avatars2.githubusercontent.com/u/4006425?v=4","gravatar_id":"","url":"https://api.github.com/users/ikasumiwt","html_url":"https://github.com/ikasumiwt","followers_url":"https://api.github.com/users/ikasumiwt/followers","following_url":"https://api.github.com/users/ikasumiwt/following{/other_user}","gists_url":"https://api.github.com/users/ikasumiwt/gists{/gist_id}","starred_url":"https://api.github.com/users/ikasumiwt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikasumiwt/subscriptions","organizations_url":"https://api.github.com/users/ikasumiwt/orgs","repos_url":"https://api.github.com/users/ikasumiwt/repos","events_url":"https://api.github.com/users/ikasumiwt/events{/privacy}","received_events_url":"https://api.github.com/users/ikasumiwt/received_events","type":"User","site_admin":false},"repo":{"id":125956875,"name":"node","full_name":"ikasumiwt/node","owner":{"login":"ikasumiwt","id":4006425,"avatar_url":"https://avatars2.githubusercontent.com/u/4006425?v=4","gravatar_id":"","url":"https://api.github.com/users/ikasumiwt","html_url":"https://github.com/ikasumiwt","followers_url":"https://api.github.com/users/ikasumiwt/followers","following_url":"https://api.github.com/users/ikasumiwt/following{/other_user}","gists_url":"https://api.github.com/users/ikasumiwt/gists{/gist_id}","starred_url":"https://api.github.com/users/ikasumiwt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikasumiwt/subscriptions","organizations_url":"https://api.github.com/users/ikasumiwt/orgs","repos_url":"https://api.github.com/users/ikasumiwt/repos","events_url":"https://api.github.com/users/ikasumiwt/events{/privacy}","received_events_url":"https://api.github.com/users/ikasumiwt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ikasumiwt/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/ikasumiwt/node","forks_url":"https://api.github.com/repos/ikasumiwt/node/forks","keys_url":"https://api.github.com/repos/ikasumiwt/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ikasumiwt/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ikasumiwt/node/teams","hooks_url":"https://api.github.com/repos/ikasumiwt/node/hooks","issue_events_url":"https://api.github.com/repos/ikasumiwt/node/issues/events{/number}","events_url":"https://api.github.com/repos/ikasumiwt/node/events","assignees_url":"https://api.github.com/repos/ikasumiwt/node/assignees{/user}","branches_url":"https://api.github.com/repos/ikasumiwt/node/branches{/branch}","tags_url":"https://api.github.com/repos/ikasumiwt/node/tags","blobs_url":"https://api.github.com/repos/ikasumiwt/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ikasumiwt/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ikasumiwt/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/ikasumiwt/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ikasumiwt/node/statuses/{sha}","languages_url":"https://api.github.com/repos/ikasumiwt/node/languages","stargazers_url":"https://api.github.com/repos/ikasumiwt/node/stargazers","contributors_url":"https://api.github.com/repos/ikasumiwt/node/contributors","subscribers_url":"https://api.github.com/repos/ikasumiwt/node/subscribers","subscription_url":"https://api.github.com/repos/ikasumiwt/node/subscription","commits_url":"https://api.github.com/repos/ikasumiwt/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/ikasumiwt/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/ikasumiwt/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/ikasumiwt/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/ikasumiwt/node/contents/{+path}","compare_url":"https://api.github.com/repos/ikasumiwt/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ikasumiwt/node/merges","archive_url":"https://api.github.com/repos/ikasumiwt/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ikasumiwt/node/downloads","issues_url":"https://api.github.com/repos/ikasumiwt/node/issues{/number}","pulls_url":"https://api.github.com/repos/ikasumiwt/node/pulls{/number}","milestones_url":"https://api.github.com/repos/ikasumiwt/node/milestones{/number}","notifications_url":"https://api.github.com/repos/ikasumiwt/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ikasumiwt/node/labels{/name}","releases_url":"https://api.github.com/repos/ikasumiwt/node/releases{/id}","deployments_url":"https://api.github.com/repos/ikasumiwt/node/deployments","created_at":"2018-03-20T03:42:33Z","updated_at":"2018-03-20T03:43:00Z","pushed_at":"2018-03-21T08:00:41Z","git_url":"git://github.com/ikasumiwt/node.git","ssh_url":"git@github.com:ikasumiwt/node.git","clone_url":"https://github.com/ikasumiwt/node.git","svn_url":"https://github.com/ikasumiwt/node","homepage":"https://nodejs.org","size":357306,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"3dc540410596ff1173586ba1bd9c171196d6f348","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-04-10T15:33:19Z","pushed_at":"2018-04-10T15:31:51Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":369593,"stargazers_count":47424,"watchers_count":47424,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9959,"mirror_url":null,"archived":false,"open_issues_count":817,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9959,"open_issues":817,"watchers":47424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/19507"},"html":{"href":"https://github.com/nodejs/node/pull/19507"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/19507"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/19507/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/19507/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/19507/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/9c421966d8070b33eb71056142fbd006b0c2b8e8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jasnell"}}