{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/184018869","pull_request_review_id":115127439,"id":184018869,"diff_hunk":"@@ -595,6 +595,8 @@ class MyObject : public node::ObjectWrap {\n   static void PlusOne(const v8::FunctionCallbackInfo<v8::Value>& args);\n   static v8::Persistent<v8::Function> constructor;\n   double value_;\n+  napi_env env_;","path":"doc/api/addons.md","position":4,"original_position":4,"commit_id":"adbe3ccd07c5837a2b3d205f324e473be069cb39","original_commit_id":"adbe3ccd07c5837a2b3d205f324e473be069cb39","user":{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars0.githubusercontent.com/u/4299420?v=4","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"body":"The N-API code here are all unnecessary. When I mention the napi tests in https://github.com/nodejs/node/issues/19876#issuecomment-379524249 , I meant the tests demonstrates how it works *in the context of napi*.","created_at":"2018-04-25T11:02:37Z","updated_at":"2018-04-25T11:02:37Z","html_url":"https://github.com/nodejs/node/pull/20269#discussion_r184018869","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/20269","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/184018869"},"html":{"href":"https://github.com/nodejs/node/pull/20269#discussion_r184018869"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/20269"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20269","id":183907004,"html_url":"https://github.com/nodejs/node/pull/20269","diff_url":"https://github.com/nodejs/node/pull/20269.diff","patch_url":"https://github.com/nodejs/node/pull/20269.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/20269","number":20269,"state":"open","locked":false,"title":"doc: modified docs to reflect how to invoke gc on Wrapping C++ objects","user":{"login":"isurusiri","id":4610706,"avatar_url":"https://avatars3.githubusercontent.com/u/4610706?v=4","gravatar_id":"","url":"https://api.github.com/users/isurusiri","html_url":"https://github.com/isurusiri","followers_url":"https://api.github.com/users/isurusiri/followers","following_url":"https://api.github.com/users/isurusiri/following{/other_user}","gists_url":"https://api.github.com/users/isurusiri/gists{/gist_id}","starred_url":"https://api.github.com/users/isurusiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isurusiri/subscriptions","organizations_url":"https://api.github.com/users/isurusiri/orgs","repos_url":"https://api.github.com/users/isurusiri/repos","events_url":"https://api.github.com/users/isurusiri/events{/privacy}","received_events_url":"https://api.github.com/users/isurusiri/received_events","type":"User","site_admin":false},"body":"Currently the documentation for Wrapping C++ Objects doesn't explain\r\nhow to destruct an object by explicitly invoking the garbage collector.\r\nThis commit includes a modification to docs which explains how to\r\ninvoke garbage collector to delete an object by executing its\r\ndestructor.\r\n\r\nFixes: https://github.com/nodejs/node/issues/19876\r\n\r\n##### Checklist\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-04-25T01:53:40Z","updated_at":"2018-04-25T11:02:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8bc6a7d01ee90303620b87eab01bb5adf46ace9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":400498270,"url":"https://api.github.com/repos/nodejs/node/labels/addons","name":"addons","color":"ededed","default":false},{"id":155267517,"url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/20269/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/20269/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20269/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/adbe3ccd07c5837a2b3d205f324e473be069cb39","head":{"label":"isurusiri:obj-wrapping-destructor","ref":"obj-wrapping-destructor","sha":"adbe3ccd07c5837a2b3d205f324e473be069cb39","user":{"login":"isurusiri","id":4610706,"avatar_url":"https://avatars3.githubusercontent.com/u/4610706?v=4","gravatar_id":"","url":"https://api.github.com/users/isurusiri","html_url":"https://github.com/isurusiri","followers_url":"https://api.github.com/users/isurusiri/followers","following_url":"https://api.github.com/users/isurusiri/following{/other_user}","gists_url":"https://api.github.com/users/isurusiri/gists{/gist_id}","starred_url":"https://api.github.com/users/isurusiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isurusiri/subscriptions","organizations_url":"https://api.github.com/users/isurusiri/orgs","repos_url":"https://api.github.com/users/isurusiri/repos","events_url":"https://api.github.com/users/isurusiri/events{/privacy}","received_events_url":"https://api.github.com/users/isurusiri/received_events","type":"User","site_admin":false},"repo":{"id":128598720,"name":"node","full_name":"isurusiri/node","owner":{"login":"isurusiri","id":4610706,"avatar_url":"https://avatars3.githubusercontent.com/u/4610706?v=4","gravatar_id":"","url":"https://api.github.com/users/isurusiri","html_url":"https://github.com/isurusiri","followers_url":"https://api.github.com/users/isurusiri/followers","following_url":"https://api.github.com/users/isurusiri/following{/other_user}","gists_url":"https://api.github.com/users/isurusiri/gists{/gist_id}","starred_url":"https://api.github.com/users/isurusiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isurusiri/subscriptions","organizations_url":"https://api.github.com/users/isurusiri/orgs","repos_url":"https://api.github.com/users/isurusiri/repos","events_url":"https://api.github.com/users/isurusiri/events{/privacy}","received_events_url":"https://api.github.com/users/isurusiri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isurusiri/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/isurusiri/node","forks_url":"https://api.github.com/repos/isurusiri/node/forks","keys_url":"https://api.github.com/repos/isurusiri/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isurusiri/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isurusiri/node/teams","hooks_url":"https://api.github.com/repos/isurusiri/node/hooks","issue_events_url":"https://api.github.com/repos/isurusiri/node/issues/events{/number}","events_url":"https://api.github.com/repos/isurusiri/node/events","assignees_url":"https://api.github.com/repos/isurusiri/node/assignees{/user}","branches_url":"https://api.github.com/repos/isurusiri/node/branches{/branch}","tags_url":"https://api.github.com/repos/isurusiri/node/tags","blobs_url":"https://api.github.com/repos/isurusiri/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isurusiri/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isurusiri/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/isurusiri/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isurusiri/node/statuses/{sha}","languages_url":"https://api.github.com/repos/isurusiri/node/languages","stargazers_url":"https://api.github.com/repos/isurusiri/node/stargazers","contributors_url":"https://api.github.com/repos/isurusiri/node/contributors","subscribers_url":"https://api.github.com/repos/isurusiri/node/subscribers","subscription_url":"https://api.github.com/repos/isurusiri/node/subscription","commits_url":"https://api.github.com/repos/isurusiri/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/isurusiri/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/isurusiri/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/isurusiri/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/isurusiri/node/contents/{+path}","compare_url":"https://api.github.com/repos/isurusiri/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isurusiri/node/merges","archive_url":"https://api.github.com/repos/isurusiri/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isurusiri/node/downloads","issues_url":"https://api.github.com/repos/isurusiri/node/issues{/number}","pulls_url":"https://api.github.com/repos/isurusiri/node/pulls{/number}","milestones_url":"https://api.github.com/repos/isurusiri/node/milestones{/number}","notifications_url":"https://api.github.com/repos/isurusiri/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isurusiri/node/labels{/name}","releases_url":"https://api.github.com/repos/isurusiri/node/releases{/id}","deployments_url":"https://api.github.com/repos/isurusiri/node/deployments","created_at":"2018-04-08T04:46:21Z","updated_at":"2018-04-25T00:31:40Z","pushed_at":"2018-04-25T01:48:01Z","git_url":"git://github.com/isurusiri/node.git","ssh_url":"git@github.com:isurusiri/node.git","clone_url":"https://github.com/isurusiri/node.git","svn_url":"https://github.com/isurusiri/node","homepage":"https://nodejs.org","size":373887,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"317c2e13a3b43e5bdf4f5845ec2af8f4e8d6913b","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-04-25T10:40:18Z","pushed_at":"2018-04-25T10:39:41Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":375615,"stargazers_count":48004,"watchers_count":48004,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10126,"mirror_url":null,"archived":false,"open_issues_count":710,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10126,"open_issues":710,"watchers":48004,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/20269"},"html":{"href":"https://github.com/nodejs/node/pull/20269"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/20269"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/20269/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/20269/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/20269/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/adbe3ccd07c5837a2b3d205f324e473be069cb39"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joyeecheung"}}