{"action":"created","comment":{"url":"https://api.github.com/repos/zcoinofficial/zcoin/pulls/comments/221541210","pull_request_review_id":160211368,"id":221541210,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTU0MTIxMA==","diff_hunk":"@@ -4045,6 +4376,77 @@ string CWallet::SpendZerocoin(std::string &thirdPartyaddress, int64_t nValue, li\n     return \"\";\n }\n \n+\n+/**\n+ * @brief CWallet::SpendZerocoin\n+ * @param thirdPartyaddress\n+ * @param nValue\n+ * @param denomination\n+ * @param wtxNew\n+ * @param coinSerial\n+ * @param txHash\n+ * @param zcSelectedValue\n+ * @param zcSelectedIsUsed\n+ * @return\n+ */\n+string CWallet::SpendMultipleZerocoin(std::string &thirdPartyaddress, std::vector<std::pair<int64_t, libzerocoin::CoinDenomination>> denominations, CWalletTx &wtxNew,","path":"src/wallet/wallet.cpp","position":362,"original_position":362,"commit_id":"5d6e8b8b66cbed0c144a1f3b9f356471f5aa146b","original_commit_id":"5d6e8b8b66cbed0c144a1f3b9f356471f5aa146b","user":{"login":"ultimaweapon","id":3048307,"node_id":"MDQ6VXNlcjMwNDgzMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3048307?v=4","gravatar_id":"","url":"https://api.github.com/users/ultimaweapon","html_url":"https://github.com/ultimaweapon","followers_url":"https://api.github.com/users/ultimaweapon/followers","following_url":"https://api.github.com/users/ultimaweapon/following{/other_user}","gists_url":"https://api.github.com/users/ultimaweapon/gists{/gist_id}","starred_url":"https://api.github.com/users/ultimaweapon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultimaweapon/subscriptions","organizations_url":"https://api.github.com/users/ultimaweapon/orgs","repos_url":"https://api.github.com/users/ultimaweapon/repos","events_url":"https://api.github.com/users/ultimaweapon/events{/privacy}","received_events_url":"https://api.github.com/users/ultimaweapon/received_events","type":"User","site_admin":false},"body":"Is it possible to change to `const std::vector<std::pair<int64_t, libzerocoin::CoinDenomination>>& denominations` instead? This will prevent a new vector instantiation, thus increase execution performance.","created_at":"2018-10-01T09:16:18Z","updated_at":"2018-10-01T09:16:18Z","html_url":"https://github.com/zcoinofficial/zcoin/pull/267#discussion_r221541210","pull_request_url":"https://api.github.com/repos/zcoinofficial/zcoin/pulls/267","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zcoinofficial/zcoin/pulls/comments/221541210"},"html":{"href":"https://github.com/zcoinofficial/zcoin/pull/267#discussion_r221541210"},"pull_request":{"href":"https://api.github.com/repos/zcoinofficial/zcoin/pulls/267"}}},"pull_request":{"url":"https://api.github.com/repos/zcoinofficial/zcoin/pulls/267","id":219141275,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTQxMjc1","html_url":"https://github.com/zcoinofficial/zcoin/pull/267","diff_url":"https://github.com/zcoinofficial/zcoin/pull/267.diff","patch_url":"https://github.com/zcoinofficial/zcoin/pull/267.patch","issue_url":"https://api.github.com/repos/zcoinofficial/zcoin/issues/267","number":267,"state":"open","locked":false,"title":"Allow for multiple ZeroSpend inputs in a single transaction","user":{"login":"riordant","id":6988731,"node_id":"MDQ6VXNlcjY5ODg3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/6988731?v=4","gravatar_id":"","url":"https://api.github.com/users/riordant","html_url":"https://github.com/riordant","followers_url":"https://api.github.com/users/riordant/followers","following_url":"https://api.github.com/users/riordant/following{/other_user}","gists_url":"https://api.github.com/users/riordant/gists{/gist_id}","starred_url":"https://api.github.com/users/riordant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riordant/subscriptions","organizations_url":"https://api.github.com/users/riordant/orgs","repos_url":"https://api.github.com/users/riordant/repos","events_url":"https://api.github.com/users/riordant/events{/privacy}","received_events_url":"https://api.github.com/users/riordant/received_events","type":"User","site_admin":false},"body":"- Adds transaction creation logic\r\n- Extends transaction validation logic first created by @psolstice \r\n- Adds RPC method\r\n- Adds relevant tests\r\n\r\nA few more tests are to be added, however I think it's best to get the review process underway now.","created_at":"2018-09-29T10:50:38Z","updated_at":"2018-10-01T09:16:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"psolstice","id":14033990,"node_id":"MDQ6VXNlcjE0MDMzOTkw","avatar_url":"https://avatars0.githubusercontent.com/u/14033990?v=4","gravatar_id":"","url":"https://api.github.com/users/psolstice","html_url":"https://github.com/psolstice","followers_url":"https://api.github.com/users/psolstice/followers","following_url":"https://api.github.com/users/psolstice/following{/other_user}","gists_url":"https://api.github.com/users/psolstice/gists{/gist_id}","starred_url":"https://api.github.com/users/psolstice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psolstice/subscriptions","organizations_url":"https://api.github.com/users/psolstice/orgs","repos_url":"https://api.github.com/users/psolstice/repos","events_url":"https://api.github.com/users/psolstice/events{/privacy}","received_events_url":"https://api.github.com/users/psolstice/received_events","type":"User","site_admin":false},{"login":"nopslide","id":15003298,"node_id":"MDQ6VXNlcjE1MDAzMjk4","avatar_url":"https://avatars2.githubusercontent.com/u/15003298?v=4","gravatar_id":"","url":"https://api.github.com/users/nopslide","html_url":"https://github.com/nopslide","followers_url":"https://api.github.com/users/nopslide/followers","following_url":"https://api.github.com/users/nopslide/following{/other_user}","gists_url":"https://api.github.com/users/nopslide/gists{/gist_id}","starred_url":"https://api.github.com/users/nopslide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nopslide/subscriptions","organizations_url":"https://api.github.com/users/nopslide/orgs","repos_url":"https://api.github.com/users/nopslide/repos","events_url":"https://api.github.com/users/nopslide/events{/privacy}","received_events_url":"https://api.github.com/users/nopslide/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zcoinofficial/zcoin/pulls/267/commits","review_comments_url":"https://api.github.com/repos/zcoinofficial/zcoin/pulls/267/comments","review_comment_url":"https://api.github.com/repos/zcoinofficial/zcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zcoinofficial/zcoin/issues/267/comments","statuses_url":"https://api.github.com/repos/zcoinofficial/zcoin/statuses/5d6e8b8b66cbed0c144a1f3b9f356471f5aa146b","head":{"label":"zcoinofficial:multiple-spend-inputs","ref":"multiple-spend-inputs","sha":"5d6e8b8b66cbed0c144a1f3b9f356471f5aa146b","user":{"login":"zcoinofficial","id":22083410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDgzNDEw","avatar_url":"https://avatars3.githubusercontent.com/u/22083410?v=4","gravatar_id":"","url":"https://api.github.com/users/zcoinofficial","html_url":"https://github.com/zcoinofficial","followers_url":"https://api.github.com/users/zcoinofficial/followers","following_url":"https://api.github.com/users/zcoinofficial/following{/other_user}","gists_url":"https://api.github.com/users/zcoinofficial/gists{/gist_id}","starred_url":"https://api.github.com/users/zcoinofficial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcoinofficial/subscriptions","organizations_url":"https://api.github.com/users/zcoinofficial/orgs","repos_url":"https://api.github.com/users/zcoinofficial/repos","events_url":"https://api.github.com/users/zcoinofficial/events{/privacy}","received_events_url":"https://api.github.com/users/zcoinofficial/received_events","type":"Organization","site_admin":false},"repo":{"id":67837600,"node_id":"MDEwOlJlcG9zaXRvcnk2NzgzNzYwMA==","name":"zcoin","full_name":"zcoinofficial/zcoin","private":false,"owner":{"login":"zcoinofficial","id":22083410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDgzNDEw","avatar_url":"https://avatars3.githubusercontent.com/u/22083410?v=4","gravatar_id":"","url":"https://api.github.com/users/zcoinofficial","html_url":"https://github.com/zcoinofficial","followers_url":"https://api.github.com/users/zcoinofficial/followers","following_url":"https://api.github.com/users/zcoinofficial/following{/other_user}","gists_url":"https://api.github.com/users/zcoinofficial/gists{/gist_id}","starred_url":"https://api.github.com/users/zcoinofficial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcoinofficial/subscriptions","organizations_url":"https://api.github.com/users/zcoinofficial/orgs","repos_url":"https://api.github.com/users/zcoinofficial/repos","events_url":"https://api.github.com/users/zcoinofficial/events{/privacy}","received_events_url":"https://api.github.com/users/zcoinofficial/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zcoinofficial/zcoin","description":"The Zerocoin Cryptocurrency","fork":false,"url":"https://api.github.com/repos/zcoinofficial/zcoin","forks_url":"https://api.github.com/repos/zcoinofficial/zcoin/forks","keys_url":"https://api.github.com/repos/zcoinofficial/zcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zcoinofficial/zcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zcoinofficial/zcoin/teams","hooks_url":"https://api.github.com/repos/zcoinofficial/zcoin/hooks","issue_events_url":"https://api.github.com/repos/zcoinofficial/zcoin/issues/events{/number}","events_url":"https://api.github.com/repos/zcoinofficial/zcoin/events","assignees_url":"https://api.github.com/repos/zcoinofficial/zcoin/assignees{/user}","branches_url":"https://api.github.com/repos/zcoinofficial/zcoin/branches{/branch}","tags_url":"https://api.github.com/repos/zcoinofficial/zcoin/tags","blobs_url":"https://api.github.com/repos/zcoinofficial/zcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zcoinofficial/zcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zcoinofficial/zcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/zcoinofficial/zcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zcoinofficial/zcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/zcoinofficial/zcoin/languages","stargazers_url":"https://api.github.com/repos/zcoinofficial/zcoin/stargazers","contributors_url":"https://api.github.com/repos/zcoinofficial/zcoin/contributors","subscribers_url":"https://api.github.com/repos/zcoinofficial/zcoin/subscribers","subscription_url":"https://api.github.com/repos/zcoinofficial/zcoin/subscription","commits_url":"https://api.github.com/repos/zcoinofficial/zcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/zcoinofficial/zcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/zcoinofficial/zcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/zcoinofficial/zcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/zcoinofficial/zcoin/contents/{+path}","compare_url":"https://api.github.com/repos/zcoinofficial/zcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zcoinofficial/zcoin/merges","archive_url":"https://api.github.com/repos/zcoinofficial/zcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zcoinofficial/zcoin/downloads","issues_url":"https://api.github.com/repos/zcoinofficial/zcoin/issues{/number}","pulls_url":"https://api.github.com/repos/zcoinofficial/zcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/zcoinofficial/zcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/zcoinofficial/zcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zcoinofficial/zcoin/labels{/name}","releases_url":"https://api.github.com/repos/zcoinofficial/zcoin/releases{/id}","deployments_url":"https://api.github.com/repos/zcoinofficial/zcoin/deployments","created_at":"2016-09-09T22:50:27Z","updated_at":"2018-09-29T05:47:55Z","pushed_at":"2018-09-29T10:50:39Z","git_url":"git://github.com/zcoinofficial/zcoin.git","ssh_url":"git@github.com:zcoinofficial/zcoin.git","clone_url":"https://github.com/zcoinofficial/zcoin.git","svn_url":"https://github.com/zcoinofficial/zcoin","homepage":null,"size":109555,"stargazers_count":333,"watchers_count":333,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":254,"open_issues":38,"watchers":333,"default_branch":"master"}},"base":{"label":"zcoinofficial:master","ref":"master","sha":"b11ef465126e9b67a68af7e52f4dbb45473a6f71","user":{"login":"zcoinofficial","id":22083410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDgzNDEw","avatar_url":"https://avatars3.githubusercontent.com/u/22083410?v=4","gravatar_id":"","url":"https://api.github.com/users/zcoinofficial","html_url":"https://github.com/zcoinofficial","followers_url":"https://api.github.com/users/zcoinofficial/followers","following_url":"https://api.github.com/users/zcoinofficial/following{/other_user}","gists_url":"https://api.github.com/users/zcoinofficial/gists{/gist_id}","starred_url":"https://api.github.com/users/zcoinofficial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcoinofficial/subscriptions","organizations_url":"https://api.github.com/users/zcoinofficial/orgs","repos_url":"https://api.github.com/users/zcoinofficial/repos","events_url":"https://api.github.com/users/zcoinofficial/events{/privacy}","received_events_url":"https://api.github.com/users/zcoinofficial/received_events","type":"Organization","site_admin":false},"repo":{"id":67837600,"node_id":"MDEwOlJlcG9zaXRvcnk2NzgzNzYwMA==","name":"zcoin","full_name":"zcoinofficial/zcoin","private":false,"owner":{"login":"zcoinofficial","id":22083410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDgzNDEw","avatar_url":"https://avatars3.githubusercontent.com/u/22083410?v=4","gravatar_id":"","url":"https://api.github.com/users/zcoinofficial","html_url":"https://github.com/zcoinofficial","followers_url":"https://api.github.com/users/zcoinofficial/followers","following_url":"https://api.github.com/users/zcoinofficial/following{/other_user}","gists_url":"https://api.github.com/users/zcoinofficial/gists{/gist_id}","starred_url":"https://api.github.com/users/zcoinofficial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcoinofficial/subscriptions","organizations_url":"https://api.github.com/users/zcoinofficial/orgs","repos_url":"https://api.github.com/users/zcoinofficial/repos","events_url":"https://api.github.com/users/zcoinofficial/events{/privacy}","received_events_url":"https://api.github.com/users/zcoinofficial/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zcoinofficial/zcoin","description":"The Zerocoin Cryptocurrency","fork":false,"url":"https://api.github.com/repos/zcoinofficial/zcoin","forks_url":"https://api.github.com/repos/zcoinofficial/zcoin/forks","keys_url":"https://api.github.com/repos/zcoinofficial/zcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zcoinofficial/zcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zcoinofficial/zcoin/teams","hooks_url":"https://api.github.com/repos/zcoinofficial/zcoin/hooks","issue_events_url":"https://api.github.com/repos/zcoinofficial/zcoin/issues/events{/number}","events_url":"https://api.github.com/repos/zcoinofficial/zcoin/events","assignees_url":"https://api.github.com/repos/zcoinofficial/zcoin/assignees{/user}","branches_url":"https://api.github.com/repos/zcoinofficial/zcoin/branches{/branch}","tags_url":"https://api.github.com/repos/zcoinofficial/zcoin/tags","blobs_url":"https://api.github.com/repos/zcoinofficial/zcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zcoinofficial/zcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zcoinofficial/zcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/zcoinofficial/zcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zcoinofficial/zcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/zcoinofficial/zcoin/languages","stargazers_url":"https://api.github.com/repos/zcoinofficial/zcoin/stargazers","contributors_url":"https://api.github.com/repos/zcoinofficial/zcoin/contributors","subscribers_url":"https://api.github.com/repos/zcoinofficial/zcoin/subscribers","subscription_url":"https://api.github.com/repos/zcoinofficial/zcoin/subscription","commits_url":"https://api.github.com/repos/zcoinofficial/zcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/zcoinofficial/zcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/zcoinofficial/zcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/zcoinofficial/zcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/zcoinofficial/zcoin/contents/{+path}","compare_url":"https://api.github.com/repos/zcoinofficial/zcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zcoinofficial/zcoin/merges","archive_url":"https://api.github.com/repos/zcoinofficial/zcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zcoinofficial/zcoin/downloads","issues_url":"https://api.github.com/repos/zcoinofficial/zcoin/issues{/number}","pulls_url":"https://api.github.com/repos/zcoinofficial/zcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/zcoinofficial/zcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/zcoinofficial/zcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zcoinofficial/zcoin/labels{/name}","releases_url":"https://api.github.com/repos/zcoinofficial/zcoin/releases{/id}","deployments_url":"https://api.github.com/repos/zcoinofficial/zcoin/deployments","created_at":"2016-09-09T22:50:27Z","updated_at":"2018-09-29T05:47:55Z","pushed_at":"2018-09-29T10:50:39Z","git_url":"git://github.com/zcoinofficial/zcoin.git","ssh_url":"git@github.com:zcoinofficial/zcoin.git","clone_url":"https://github.com/zcoinofficial/zcoin.git","svn_url":"https://github.com/zcoinofficial/zcoin","homepage":null,"size":109555,"stargazers_count":333,"watchers_count":333,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":254,"open_issues":38,"watchers":333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zcoinofficial/zcoin/pulls/267"},"html":{"href":"https://github.com/zcoinofficial/zcoin/pull/267"},"issue":{"href":"https://api.github.com/repos/zcoinofficial/zcoin/issues/267"},"comments":{"href":"https://api.github.com/repos/zcoinofficial/zcoin/issues/267/comments"},"review_comments":{"href":"https://api.github.com/repos/zcoinofficial/zcoin/pulls/267/comments"},"review_comment":{"href":"https://api.github.com/repos/zcoinofficial/zcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zcoinofficial/zcoin/pulls/267/commits"},"statuses":{"href":"https://api.github.com/repos/zcoinofficial/zcoin/statuses/5d6e8b8b66cbed0c144a1f3b9f356471f5aa146b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ultimaweapon"}}