{"action":"created","comment":{"url":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls/comments/223214120","pull_request_review_id":162290761,"id":223214120,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIxNDEyMA==","diff_hunk":"@@ -29,6 +29,7 @@ Gem::Specification.new do |spec|\n \n   spec.add_dependency \"cbor\", \"~> 0.5.9.2\"\n   spec.add_dependency \"cose\", \"~> 0.1.0\"\n+  spec.add_dependency \"jwt\", \"~> 2.0\"","path":"webauthn.gemspec","position":4,"original_position":4,"commit_id":"10be776f67af8b996fb38918eca5bfc3e0b83653","original_commit_id":"10be776f67af8b996fb38918eca5bfc3e0b83653","user":{"login":"bdewater","id":496367,"node_id":"MDQ6VXNlcjQ5NjM2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/496367?v=4","gravatar_id":"","url":"https://api.github.com/users/bdewater","html_url":"https://github.com/bdewater","followers_url":"https://api.github.com/users/bdewater/followers","following_url":"https://api.github.com/users/bdewater/following{/other_user}","gists_url":"https://api.github.com/users/bdewater/gists{/gist_id}","starred_url":"https://api.github.com/users/bdewater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdewater/subscriptions","organizations_url":"https://api.github.com/users/bdewater/orgs","repos_url":"https://api.github.com/users/bdewater/repos","events_url":"https://api.github.com/users/bdewater/events{/privacy}","received_events_url":"https://api.github.com/users/bdewater/received_events","type":"User","site_admin":false},"body":"Good call, https://rubygems.org/gems/jwt/reverse_dependencies lists `oauth2` as a popular dependency tied to `~> 1.0`.","created_at":"2018-10-07T13:43:01Z","updated_at":"2018-10-07T13:43:01Z","html_url":"https://github.com/cedarcode/webauthn-ruby/pull/86#discussion_r223214120","pull_request_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls/86","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls/comments/223214120"},"html":{"href":"https://github.com/cedarcode/webauthn-ruby/pull/86#discussion_r223214120"},"pull_request":{"href":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls/86"}},"in_reply_to_id":223208457},"pull_request":{"url":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls/86","id":220919126,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTE5MTI2","html_url":"https://github.com/cedarcode/webauthn-ruby/pull/86","diff_url":"https://github.com/cedarcode/webauthn-ruby/pull/86.diff","patch_url":"https://github.com/cedarcode/webauthn-ruby/pull/86.patch","issue_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/issues/86","number":86,"state":"open","locked":false,"title":"feat: support 'android-safetynet' attestation format","user":{"login":"bdewater","id":496367,"node_id":"MDQ6VXNlcjQ5NjM2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/496367?v=4","gravatar_id":"","url":"https://api.github.com/users/bdewater","html_url":"https://github.com/bdewater","followers_url":"https://api.github.com/users/bdewater/followers","following_url":"https://api.github.com/users/bdewater/following{/other_user}","gists_url":"https://api.github.com/users/bdewater/gists{/gist_id}","starred_url":"https://api.github.com/users/bdewater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdewater/subscriptions","organizations_url":"https://api.github.com/users/bdewater/orgs","repos_url":"https://api.github.com/users/bdewater/repos","events_url":"https://api.github.com/users/bdewater/events{/privacy}","received_events_url":"https://api.github.com/users/bdewater/received_events","type":"User","site_admin":false},"body":"Verify Android SafetyNet attestation as described at:\r\n- https://www.w3.org/TR/2018/CR-webauthn-20180807/#android-safetynet-attestation\r\n- https://developer.android.com/training/safetynet/attestation#compat-check-response\r\n\r\nThis is the attestation returned by Chrome 70 on Android when using the fingerprint scanner to register. Closes https://github.com/cedarcode/webauthn-ruby/issues/75\r\n\r\nThe W3C documentation does a poor job of explaining how and why the certificates must be verified. If this step were to be skipped, anybody could forge a response with a self-signed certificate issued to attest.android.com. From what I could find only Google's checklist (https://developer.android.com/training/safetynet/attestation-checklist) as well as some third-party resources mention it.\r\n\r\nAlso it is not really clear what a \"valid SafetyNet response of version ver\" is supposed to look like.\r\n\r\nInspired by the excellent work in #81 - happy to rebase this once that is merged!","created_at":"2018-10-07T00:19:49Z","updated_at":"2018-10-07T13:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dd309745ef134d48e25ed7b1ad93be33a64d093","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls/86/commits","review_comments_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls/86/comments","review_comment_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/issues/86/comments","statuses_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/statuses/10be776f67af8b996fb38918eca5bfc3e0b83653","head":{"label":"bdewater:android-safetynet-attstmt","ref":"android-safetynet-attstmt","sha":"10be776f67af8b996fb38918eca5bfc3e0b83653","user":{"login":"bdewater","id":496367,"node_id":"MDQ6VXNlcjQ5NjM2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/496367?v=4","gravatar_id":"","url":"https://api.github.com/users/bdewater","html_url":"https://github.com/bdewater","followers_url":"https://api.github.com/users/bdewater/followers","following_url":"https://api.github.com/users/bdewater/following{/other_user}","gists_url":"https://api.github.com/users/bdewater/gists{/gist_id}","starred_url":"https://api.github.com/users/bdewater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdewater/subscriptions","organizations_url":"https://api.github.com/users/bdewater/orgs","repos_url":"https://api.github.com/users/bdewater/repos","events_url":"https://api.github.com/users/bdewater/events{/privacy}","received_events_url":"https://api.github.com/users/bdewater/received_events","type":"User","site_admin":false},"repo":{"id":150982663,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA5ODI2NjM=","name":"webauthn-ruby","full_name":"bdewater/webauthn-ruby","private":false,"owner":{"login":"bdewater","id":496367,"node_id":"MDQ6VXNlcjQ5NjM2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/496367?v=4","gravatar_id":"","url":"https://api.github.com/users/bdewater","html_url":"https://github.com/bdewater","followers_url":"https://api.github.com/users/bdewater/followers","following_url":"https://api.github.com/users/bdewater/following{/other_user}","gists_url":"https://api.github.com/users/bdewater/gists{/gist_id}","starred_url":"https://api.github.com/users/bdewater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdewater/subscriptions","organizations_url":"https://api.github.com/users/bdewater/orgs","repos_url":"https://api.github.com/users/bdewater/repos","events_url":"https://api.github.com/users/bdewater/events{/privacy}","received_events_url":"https://api.github.com/users/bdewater/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bdewater/webauthn-ruby","description":"WebAuthn in ruby ― Ruby implementation of a WebAuthn Relying Party","fork":true,"url":"https://api.github.com/repos/bdewater/webauthn-ruby","forks_url":"https://api.github.com/repos/bdewater/webauthn-ruby/forks","keys_url":"https://api.github.com/repos/bdewater/webauthn-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bdewater/webauthn-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bdewater/webauthn-ruby/teams","hooks_url":"https://api.github.com/repos/bdewater/webauthn-ruby/hooks","issue_events_url":"https://api.github.com/repos/bdewater/webauthn-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/bdewater/webauthn-ruby/events","assignees_url":"https://api.github.com/repos/bdewater/webauthn-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/bdewater/webauthn-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/bdewater/webauthn-ruby/tags","blobs_url":"https://api.github.com/repos/bdewater/webauthn-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bdewater/webauthn-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bdewater/webauthn-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/bdewater/webauthn-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bdewater/webauthn-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/bdewater/webauthn-ruby/languages","stargazers_url":"https://api.github.com/repos/bdewater/webauthn-ruby/stargazers","contributors_url":"https://api.github.com/repos/bdewater/webauthn-ruby/contributors","subscribers_url":"https://api.github.com/repos/bdewater/webauthn-ruby/subscribers","subscription_url":"https://api.github.com/repos/bdewater/webauthn-ruby/subscription","commits_url":"https://api.github.com/repos/bdewater/webauthn-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/bdewater/webauthn-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/bdewater/webauthn-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/bdewater/webauthn-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/bdewater/webauthn-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/bdewater/webauthn-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bdewater/webauthn-ruby/merges","archive_url":"https://api.github.com/repos/bdewater/webauthn-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bdewater/webauthn-ruby/downloads","issues_url":"https://api.github.com/repos/bdewater/webauthn-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/bdewater/webauthn-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/bdewater/webauthn-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/bdewater/webauthn-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bdewater/webauthn-ruby/labels{/name}","releases_url":"https://api.github.com/repos/bdewater/webauthn-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/bdewater/webauthn-ruby/deployments","created_at":"2018-09-30T16:07:19Z","updated_at":"2018-09-30T16:07:21Z","pushed_at":"2018-10-07T00:33:14Z","git_url":"git://github.com/bdewater/webauthn-ruby.git","ssh_url":"git@github.com:bdewater/webauthn-ruby.git","clone_url":"https://github.com/bdewater/webauthn-ruby.git","svn_url":"https://github.com/bdewater/webauthn-ruby","homepage":"","size":281,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cedarcode:master","ref":"master","sha":"886f723ea61a115ae1b57567c2aa80ae3ca1ee67","user":{"login":"cedarcode","id":34521846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTIxODQ2","avatar_url":"https://avatars3.githubusercontent.com/u/34521846?v=4","gravatar_id":"","url":"https://api.github.com/users/cedarcode","html_url":"https://github.com/cedarcode","followers_url":"https://api.github.com/users/cedarcode/followers","following_url":"https://api.github.com/users/cedarcode/following{/other_user}","gists_url":"https://api.github.com/users/cedarcode/gists{/gist_id}","starred_url":"https://api.github.com/users/cedarcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedarcode/subscriptions","organizations_url":"https://api.github.com/users/cedarcode/orgs","repos_url":"https://api.github.com/users/cedarcode/repos","events_url":"https://api.github.com/users/cedarcode/events{/privacy}","received_events_url":"https://api.github.com/users/cedarcode/received_events","type":"Organization","site_admin":false},"repo":{"id":132816323,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI4MTYzMjM=","name":"webauthn-ruby","full_name":"cedarcode/webauthn-ruby","private":false,"owner":{"login":"cedarcode","id":34521846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTIxODQ2","avatar_url":"https://avatars3.githubusercontent.com/u/34521846?v=4","gravatar_id":"","url":"https://api.github.com/users/cedarcode","html_url":"https://github.com/cedarcode","followers_url":"https://api.github.com/users/cedarcode/followers","following_url":"https://api.github.com/users/cedarcode/following{/other_user}","gists_url":"https://api.github.com/users/cedarcode/gists{/gist_id}","starred_url":"https://api.github.com/users/cedarcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedarcode/subscriptions","organizations_url":"https://api.github.com/users/cedarcode/orgs","repos_url":"https://api.github.com/users/cedarcode/repos","events_url":"https://api.github.com/users/cedarcode/events{/privacy}","received_events_url":"https://api.github.com/users/cedarcode/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cedarcode/webauthn-ruby","description":"WebAuthn in ruby ― Ruby implementation of a WebAuthn Relying Party","fork":false,"url":"https://api.github.com/repos/cedarcode/webauthn-ruby","forks_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/forks","keys_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/teams","hooks_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/hooks","issue_events_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/events","assignees_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/tags","blobs_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/languages","stargazers_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/stargazers","contributors_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/contributors","subscribers_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/subscribers","subscription_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/subscription","commits_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/merges","archive_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/downloads","issues_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/labels{/name}","releases_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/cedarcode/webauthn-ruby/deployments","created_at":"2018-05-09T21:49:17Z","updated_at":"2018-10-05T16:36:10Z","pushed_at":"2018-10-07T10:45:28Z","git_url":"git://github.com/cedarcode/webauthn-ruby.git","ssh_url":"git@github.com:cedarcode/webauthn-ruby.git","clone_url":"https://github.com/cedarcode/webauthn-ruby.git","svn_url":"https://github.com/cedarcode/webauthn-ruby","homepage":"","size":281,"stargazers_count":23,"watchers_count":23,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":13,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls/86"},"html":{"href":"https://github.com/cedarcode/webauthn-ruby/pull/86"},"issue":{"href":"https://api.github.com/repos/cedarcode/webauthn-ruby/issues/86"},"comments":{"href":"https://api.github.com/repos/cedarcode/webauthn-ruby/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cedarcode/webauthn-ruby/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/cedarcode/webauthn-ruby/statuses/10be776f67af8b996fb38918eca5bfc3e0b83653"}},"author_association":"NONE"}}
{"actor":{"display_login":"bdewater"}}