{"action":"created","issue":{"url":"https://api.github.com/repos/silx-kit/silx/issues/1778","repository_url":"https://api.github.com/repos/silx-kit/silx","labels_url":"https://api.github.com/repos/silx-kit/silx/issues/1778/labels{/name}","comments_url":"https://api.github.com/repos/silx-kit/silx/issues/1778/comments","events_url":"https://api.github.com/repos/silx-kit/silx/issues/1778/events","html_url":"https://github.com/silx-kit/silx/pull/1778","id":315057170,"number":1778,"title":"[nxdata] refactoring","user":{"login":"PiRK","id":419570,"avatar_url":"https://avatars2.githubusercontent.com/u/419570?v=4","gravatar_id":"","url":"https://api.github.com/users/PiRK","html_url":"https://github.com/PiRK","followers_url":"https://api.github.com/users/PiRK/followers","following_url":"https://api.github.com/users/PiRK/following{/other_user}","gists_url":"https://api.github.com/users/PiRK/gists{/gist_id}","starred_url":"https://api.github.com/users/PiRK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiRK/subscriptions","organizations_url":"https://api.github.com/users/PiRK/orgs","repos_url":"https://api.github.com/users/PiRK/repos","events_url":"https://api.github.com/users/PiRK/events{/privacy}","received_events_url":"https://api.github.com/users/PiRK/received_events","type":"User","site_admin":false},"labels":[{"id":487976400,"url":"https://api.github.com/repos/silx-kit/silx/labels/work%20in%20progress","name":"work in progress","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-17T13:21:44Z","updated_at":"2018-05-03T07:19:21Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/silx-kit/silx/pulls/1778","html_url":"https://github.com/silx-kit/silx/pull/1778","diff_url":"https://github.com/silx-kit/silx/pull/1778.diff","patch_url":"https://github.com/silx-kit/silx/pull/1778.patch"},"body":"This PR transforms the `silx.io.nxdata` module into a package, with 3 modules: `parse`, `validate` and `write`.\r\n\r\nThe `validate` module will need a major refactoring if we want to be able to improve and maintain it. The current validation function `is_valid_nxdata` has become too large, and still it fails to catch important issues (like missing axes #1775)."},"comment":{"url":"https://api.github.com/repos/silx-kit/silx/issues/comments/386210098","html_url":"https://github.com/silx-kit/silx/pull/1778#issuecomment-386210098","issue_url":"https://api.github.com/repos/silx-kit/silx/issues/1778","id":386210098,"user":{"login":"PiRK","id":419570,"avatar_url":"https://avatars2.githubusercontent.com/u/419570?v=4","gravatar_id":"","url":"https://api.github.com/users/PiRK","html_url":"https://github.com/PiRK","followers_url":"https://api.github.com/users/PiRK/followers","following_url":"https://api.github.com/users/PiRK/following{/other_user}","gists_url":"https://api.github.com/users/PiRK/gists{/gist_id}","starred_url":"https://api.github.com/users/PiRK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiRK/subscriptions","organizations_url":"https://api.github.com/users/PiRK/orgs","repos_url":"https://api.github.com/users/PiRK/repos","events_url":"https://api.github.com/users/PiRK/events{/privacy}","received_events_url":"https://api.github.com/users/PiRK/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T07:19:21Z","updated_at":"2018-05-03T07:19:21Z","author_association":"OWNER","body":"I think that we should merge this, there are already important patches in the middle of the refactoring (https://github.com/silx-kit/silx/pull/1778/commits/44a7586b9b9453b46aaeed2e616dd4e72fea0e17, https://github.com/silx-kit/silx/pull/1778/commits/4ebed9ee911d146622c3f1cb68dcca823d800075 and https://github.com/silx-kit/silx/pull/1778/commits/741564269487006195ff4110d99fa57134f1bfa5). \r\n\r\nThe remaining work, properly refactoring the validation, requires a separate pull request and will take some time. "}}
{"actor":{"display_login":"PiRK"}}