{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/7220","repository_url":"https://api.github.com/repos/puppetlabs/puppet","labels_url":"https://api.github.com/repos/puppetlabs/puppet/issues/7220/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/7220/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/7220/events","html_url":"https://github.com/puppetlabs/puppet/pull/7220","id":376397041,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NjIyNTAw","number":7220,"title":"(PUP-9294) Report illegal 3x function defining methods","user":{"login":"hlindberg","id":563066,"node_id":"MDQ6VXNlcjU2MzA2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/563066?v=4","gravatar_id":"","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-11-01T13:41:34Z","updated_at":"2018-12-05T19:41:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/7220","html_url":"https://github.com/puppetlabs/puppet/pull/7220","diff_url":"https://github.com/puppetlabs/puppet/pull/7220.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/7220.patch"},"body":"Before this, methods added in a legacy function implementation file\r\ncould reside a) inside the body given to `newfunction` or b) before or\r\nafter the call to `newfunction` in the `Puppet::Parser::Functions`\r\nmodule. or c) outside the module, In all three cases the method could be added with a `def mname`\r\nor `def self.mname` neither defining a method where the user expects it\r\nto be added. \r\n\r\nThis commit adds protection against these method definitions by raising\r\nan error when they are added."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/444617873","html_url":"https://github.com/puppetlabs/puppet/pull/7220#issuecomment-444617873","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/7220","id":444617873,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDYxNzg3Mw==","user":{"login":"jbondpdx","id":7927296,"node_id":"MDQ6VXNlcjc5MjcyOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/7927296?v=4","gravatar_id":"","url":"https://api.github.com/users/jbondpdx","html_url":"https://github.com/jbondpdx","followers_url":"https://api.github.com/users/jbondpdx/followers","following_url":"https://api.github.com/users/jbondpdx/following{/other_user}","gists_url":"https://api.github.com/users/jbondpdx/gists{/gist_id}","starred_url":"https://api.github.com/users/jbondpdx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbondpdx/subscriptions","organizations_url":"https://api.github.com/users/jbondpdx/orgs","repos_url":"https://api.github.com/users/jbondpdx/repos","events_url":"https://api.github.com/users/jbondpdx/events{/privacy}","received_events_url":"https://api.github.com/users/jbondpdx/received_events","type":"User","site_admin":false},"created_at":"2018-12-05T19:41:34Z","updated_at":"2018-12-05T19:41:34Z","author_association":"CONTRIBUTOR","body":"Docs for this will be located at https://puppet.com/docs/puppet/latest/functions_refactor_legacy.html\r\n\r\n^ @jhelwig @hlindberg \r\n\r\nAnd my apologies for the delay. I must have missed an email notification from GitHub."}}
{"actor":{"display_login":"jbondpdx"}}