{"action":"created","comment":{"url":"https://api.github.com/repos/google/benchmark/pulls/comments/232461106","pull_request_review_id":173670175,"id":232461106,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQ2MTEwNg==","diff_hunk":"@@ -1518,6 +1518,7 @@ inline const char* GetTimeUnitString(TimeUnit unit) {\n     case kMicrosecond:\n       return \"us\";\n     case kNanosecond:\n+    default:\t\n       return \"ns\";\n   }\n   BENCHMARK_UNREACHABLE();","path":"include/benchmark/benchmark.h","position":3,"original_position":7,"commit_id":"5cdbab7258ebbfff6029b1482445d68208532e63","original_commit_id":"bc7b44e6f7e0934b0699fa992abfd20ad341a778","user":{"login":"brenoguim","id":7646859,"node_id":"MDQ6VXNlcjc2NDY4NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7646859?v=4","gravatar_id":"","url":"https://api.github.com/users/brenoguim","html_url":"https://github.com/brenoguim","followers_url":"https://api.github.com/users/brenoguim/followers","following_url":"https://api.github.com/users/brenoguim/following{/other_user}","gists_url":"https://api.github.com/users/brenoguim/gists{/gist_id}","starred_url":"https://api.github.com/users/brenoguim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenoguim/subscriptions","organizations_url":"https://api.github.com/users/brenoguim/orgs","repos_url":"https://api.github.com/users/brenoguim/repos","events_url":"https://api.github.com/users/brenoguim/events{/privacy}","received_events_url":"https://api.github.com/users/brenoguim/received_events","type":"User","site_admin":false},"body":"Option #2 introduces warnings in MSVC :( https://ci.appveyor.com/project/google/benchmark/builds/20198554/job/ub5ulj85wb67ym3o\r\n\r\n","created_at":"2018-11-10T18:12:36Z","updated_at":"2018-11-10T18:12:36Z","html_url":"https://github.com/google/benchmark/pull/716#discussion_r232461106","pull_request_url":"https://api.github.com/repos/google/benchmark/pulls/716","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/google/benchmark/pulls/comments/232461106"},"html":{"href":"https://github.com/google/benchmark/pull/716#discussion_r232461106"},"pull_request":{"href":"https://api.github.com/repos/google/benchmark/pulls/716"}},"in_reply_to_id":232443125},"pull_request":{"url":"https://api.github.com/repos/google/benchmark/pulls/716","id":229839098,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODM5MDk4","html_url":"https://github.com/google/benchmark/pull/716","diff_url":"https://github.com/google/benchmark/pull/716.diff","patch_url":"https://github.com/google/benchmark/pull/716.patch","issue_url":"https://api.github.com/repos/google/benchmark/issues/716","number":716,"state":"open","locked":false,"title":"Added default case in switch to avoid warning","user":{"login":"amallia","id":9058516,"node_id":"MDQ6VXNlcjkwNTg1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9058516?v=4","gravatar_id":"","url":"https://api.github.com/users/amallia","html_url":"https://github.com/amallia","followers_url":"https://api.github.com/users/amallia/followers","following_url":"https://api.github.com/users/amallia/following{/other_user}","gists_url":"https://api.github.com/users/amallia/gists{/gist_id}","starred_url":"https://api.github.com/users/amallia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amallia/subscriptions","organizations_url":"https://api.github.com/users/amallia/orgs","repos_url":"https://api.github.com/users/amallia/repos","events_url":"https://api.github.com/users/amallia/events{/privacy}","received_events_url":"https://api.github.com/users/amallia/received_events","type":"User","site_admin":false},"body":"```\r\nwarning: missing return statement at end of non-void function \"benchmark::GetTimeUnitString\"\r\nwarning: missing return statement at end of non-void function \"benchmark::GetTimeUnitMultiplier\"\r\n```\r\nnvcc: NVIDIA (R) Cuda compiler driver\r\nCopyright (c) 2005-2016 NVIDIA Corporation\r\nBuilt on Tue_Jan_10_13:22:03_CST_2017\r\nCuda compilation tools, release 8.0, V8.0.61","created_at":"2018-11-09T22:39:51Z","updated_at":"2018-11-10T18:12:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e2e0bf53cc224c48a97fd539c11bfd8c917d08b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":186811505,"node_id":"MDU6TGFiZWwxODY4MTE1MDU=","url":"https://api.github.com/repos/google/benchmark/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/benchmark/pulls/716/commits","review_comments_url":"https://api.github.com/repos/google/benchmark/pulls/716/comments","review_comment_url":"https://api.github.com/repos/google/benchmark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/benchmark/issues/716/comments","statuses_url":"https://api.github.com/repos/google/benchmark/statuses/5cdbab7258ebbfff6029b1482445d68208532e63","head":{"label":"amallia:patch-1","ref":"patch-1","sha":"5cdbab7258ebbfff6029b1482445d68208532e63","user":{"login":"amallia","id":9058516,"node_id":"MDQ6VXNlcjkwNTg1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9058516?v=4","gravatar_id":"","url":"https://api.github.com/users/amallia","html_url":"https://github.com/amallia","followers_url":"https://api.github.com/users/amallia/followers","following_url":"https://api.github.com/users/amallia/following{/other_user}","gists_url":"https://api.github.com/users/amallia/gists{/gist_id}","starred_url":"https://api.github.com/users/amallia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amallia/subscriptions","organizations_url":"https://api.github.com/users/amallia/orgs","repos_url":"https://api.github.com/users/amallia/repos","events_url":"https://api.github.com/users/amallia/events{/privacy}","received_events_url":"https://api.github.com/users/amallia/received_events","type":"User","site_admin":false},"repo":{"id":156925761,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5MjU3NjE=","name":"benchmark","full_name":"amallia/benchmark","private":false,"owner":{"login":"amallia","id":9058516,"node_id":"MDQ6VXNlcjkwNTg1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9058516?v=4","gravatar_id":"","url":"https://api.github.com/users/amallia","html_url":"https://github.com/amallia","followers_url":"https://api.github.com/users/amallia/followers","following_url":"https://api.github.com/users/amallia/following{/other_user}","gists_url":"https://api.github.com/users/amallia/gists{/gist_id}","starred_url":"https://api.github.com/users/amallia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amallia/subscriptions","organizations_url":"https://api.github.com/users/amallia/orgs","repos_url":"https://api.github.com/users/amallia/repos","events_url":"https://api.github.com/users/amallia/events{/privacy}","received_events_url":"https://api.github.com/users/amallia/received_events","type":"User","site_admin":false},"html_url":"https://github.com/amallia/benchmark","description":"A microbenchmark support library","fork":true,"url":"https://api.github.com/repos/amallia/benchmark","forks_url":"https://api.github.com/repos/amallia/benchmark/forks","keys_url":"https://api.github.com/repos/amallia/benchmark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amallia/benchmark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amallia/benchmark/teams","hooks_url":"https://api.github.com/repos/amallia/benchmark/hooks","issue_events_url":"https://api.github.com/repos/amallia/benchmark/issues/events{/number}","events_url":"https://api.github.com/repos/amallia/benchmark/events","assignees_url":"https://api.github.com/repos/amallia/benchmark/assignees{/user}","branches_url":"https://api.github.com/repos/amallia/benchmark/branches{/branch}","tags_url":"https://api.github.com/repos/amallia/benchmark/tags","blobs_url":"https://api.github.com/repos/amallia/benchmark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amallia/benchmark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amallia/benchmark/git/refs{/sha}","trees_url":"https://api.github.com/repos/amallia/benchmark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amallia/benchmark/statuses/{sha}","languages_url":"https://api.github.com/repos/amallia/benchmark/languages","stargazers_url":"https://api.github.com/repos/amallia/benchmark/stargazers","contributors_url":"https://api.github.com/repos/amallia/benchmark/contributors","subscribers_url":"https://api.github.com/repos/amallia/benchmark/subscribers","subscription_url":"https://api.github.com/repos/amallia/benchmark/subscription","commits_url":"https://api.github.com/repos/amallia/benchmark/commits{/sha}","git_commits_url":"https://api.github.com/repos/amallia/benchmark/git/commits{/sha}","comments_url":"https://api.github.com/repos/amallia/benchmark/comments{/number}","issue_comment_url":"https://api.github.com/repos/amallia/benchmark/issues/comments{/number}","contents_url":"https://api.github.com/repos/amallia/benchmark/contents/{+path}","compare_url":"https://api.github.com/repos/amallia/benchmark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amallia/benchmark/merges","archive_url":"https://api.github.com/repos/amallia/benchmark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amallia/benchmark/downloads","issues_url":"https://api.github.com/repos/amallia/benchmark/issues{/number}","pulls_url":"https://api.github.com/repos/amallia/benchmark/pulls{/number}","milestones_url":"https://api.github.com/repos/amallia/benchmark/milestones{/number}","notifications_url":"https://api.github.com/repos/amallia/benchmark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amallia/benchmark/labels{/name}","releases_url":"https://api.github.com/repos/amallia/benchmark/releases{/id}","deployments_url":"https://api.github.com/repos/amallia/benchmark/deployments","created_at":"2018-11-09T22:38:41Z","updated_at":"2018-11-09T22:38:44Z","pushed_at":"2018-11-10T16:51:55Z","git_url":"git://github.com/amallia/benchmark.git","ssh_url":"git@github.com:amallia/benchmark.git","clone_url":"https://github.com/amallia/benchmark.git","svn_url":"https://github.com/amallia/benchmark","homepage":"","size":1577,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"a9b31c51b1ee7ec7b31438c647123c2cbac5d956","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":15122806,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyMjgwNg==","name":"benchmark","full_name":"google/benchmark","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/benchmark","description":"A microbenchmark support library","fork":false,"url":"https://api.github.com/repos/google/benchmark","forks_url":"https://api.github.com/repos/google/benchmark/forks","keys_url":"https://api.github.com/repos/google/benchmark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/benchmark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/benchmark/teams","hooks_url":"https://api.github.com/repos/google/benchmark/hooks","issue_events_url":"https://api.github.com/repos/google/benchmark/issues/events{/number}","events_url":"https://api.github.com/repos/google/benchmark/events","assignees_url":"https://api.github.com/repos/google/benchmark/assignees{/user}","branches_url":"https://api.github.com/repos/google/benchmark/branches{/branch}","tags_url":"https://api.github.com/repos/google/benchmark/tags","blobs_url":"https://api.github.com/repos/google/benchmark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/benchmark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/benchmark/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/benchmark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/benchmark/statuses/{sha}","languages_url":"https://api.github.com/repos/google/benchmark/languages","stargazers_url":"https://api.github.com/repos/google/benchmark/stargazers","contributors_url":"https://api.github.com/repos/google/benchmark/contributors","subscribers_url":"https://api.github.com/repos/google/benchmark/subscribers","subscription_url":"https://api.github.com/repos/google/benchmark/subscription","commits_url":"https://api.github.com/repos/google/benchmark/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/benchmark/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/benchmark/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/benchmark/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/benchmark/contents/{+path}","compare_url":"https://api.github.com/repos/google/benchmark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/benchmark/merges","archive_url":"https://api.github.com/repos/google/benchmark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/benchmark/downloads","issues_url":"https://api.github.com/repos/google/benchmark/issues{/number}","pulls_url":"https://api.github.com/repos/google/benchmark/pulls{/number}","milestones_url":"https://api.github.com/repos/google/benchmark/milestones{/number}","notifications_url":"https://api.github.com/repos/google/benchmark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/benchmark/labels{/name}","releases_url":"https://api.github.com/repos/google/benchmark/releases{/id}","deployments_url":"https://api.github.com/repos/google/benchmark/deployments","created_at":"2013-12-12T00:10:48Z","updated_at":"2018-11-10T12:15:48Z","pushed_at":"2018-11-10T16:51:56Z","git_url":"git://github.com/google/benchmark.git","ssh_url":"git@github.com:google/benchmark.git","clone_url":"https://github.com/google/benchmark.git","svn_url":"https://github.com/google/benchmark","homepage":"","size":1539,"stargazers_count":2900,"watchers_count":2900,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":548,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":548,"open_issues":67,"watchers":2900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/benchmark/pulls/716"},"html":{"href":"https://github.com/google/benchmark/pull/716"},"issue":{"href":"https://api.github.com/repos/google/benchmark/issues/716"},"comments":{"href":"https://api.github.com/repos/google/benchmark/issues/716/comments"},"review_comments":{"href":"https://api.github.com/repos/google/benchmark/pulls/716/comments"},"review_comment":{"href":"https://api.github.com/repos/google/benchmark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/benchmark/pulls/716/commits"},"statuses":{"href":"https://api.github.com/repos/google/benchmark/statuses/5cdbab7258ebbfff6029b1482445d68208532e63"}},"author_association":"NONE"}}
{"actor":{"display_login":"brenoguim"}}