{"action":"created","comment":{"url":"https://api.github.com/repos/nudibranchrecords/hedron/pulls/comments/217895920","pull_request_review_id":155725550,"id":217895920,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzg5NTkyMA==","diff_hunk":"@@ -8,7 +8,7 @@ const getSingle = (state, sketchId) => {\n \n   sketchParams.forEach((id) => {\n     const param = state.nodes[id]\n-    if (param.min && param.max) {\n+    if (param.min !== undefined && param.max !== undefined) {","path":"src/selectors/getSketchParams.js","position":null,"original_position":5,"commit_id":"9800c41cf090e794df74cbbb2104ff5889540ca9","original_commit_id":"a0ed4e8f770b224934d1f789f72283c233cbbed2","user":{"login":"netgrind","id":4506708,"node_id":"MDQ6VXNlcjQ1MDY3MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/4506708?v=4","gravatar_id":"","url":"https://api.github.com/users/netgrind","html_url":"https://github.com/netgrind","followers_url":"https://api.github.com/users/netgrind/followers","following_url":"https://api.github.com/users/netgrind/following{/other_user}","gists_url":"https://api.github.com/users/netgrind/gists{/gist_id}","starred_url":"https://api.github.com/users/netgrind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netgrind/subscriptions","organizations_url":"https://api.github.com/users/netgrind/orgs","repos_url":"https://api.github.com/users/netgrind/repos","events_url":"https://api.github.com/users/netgrind/events{/privacy}","received_events_url":"https://api.github.com/users/netgrind/received_events","type":"User","site_admin":false},"body":"Ahh, I'll be more verbose in the future!","created_at":"2018-09-15T21:29:41Z","updated_at":"2018-09-15T21:29:41Z","html_url":"https://github.com/nudibranchrecords/hedron/pull/75#discussion_r217895920","pull_request_url":"https://api.github.com/repos/nudibranchrecords/hedron/pulls/75","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nudibranchrecords/hedron/pulls/comments/217895920"},"html":{"href":"https://github.com/nudibranchrecords/hedron/pull/75#discussion_r217895920"},"pull_request":{"href":"https://api.github.com/repos/nudibranchrecords/hedron/pulls/75"}},"in_reply_to_id":216175079},"pull_request":{"url":"https://api.github.com/repos/nudibranchrecords/hedron/pulls/75","id":204960176,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTYwMTc2","html_url":"https://github.com/nudibranchrecords/hedron/pull/75","diff_url":"https://github.com/nudibranchrecords/hedron/pull/75.diff","patch_url":"https://github.com/nudibranchrecords/hedron/pull/75.patch","issue_url":"https://api.github.com/repos/nudibranchrecords/hedron/issues/75","number":75,"state":"open","locked":false,"title":"added min/max range to sketch params","user":{"login":"netgrind","id":4506708,"node_id":"MDQ6VXNlcjQ1MDY3MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/4506708?v=4","gravatar_id":"","url":"https://api.github.com/users/netgrind","html_url":"https://github.com/netgrind","followers_url":"https://api.github.com/users/netgrind/followers","following_url":"https://api.github.com/users/netgrind/following{/other_user}","gists_url":"https://api.github.com/users/netgrind/gists{/gist_id}","starred_url":"https://api.github.com/users/netgrind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netgrind/subscriptions","organizations_url":"https://api.github.com/users/netgrind/orgs","repos_url":"https://api.github.com/users/netgrind/repos","events_url":"https://api.github.com/users/netgrind/events{/privacy}","received_events_url":"https://api.github.com/users/netgrind/received_events","type":"User","site_admin":false},"body":"Params can have an optional min and max value, defaults to 0 and 1 if not found. This allows for a sketch creator to determine what numbers they would like in the config so that the data is as they would want it when it reaches their update function. A good example is setting a params max to 360 so it can be used as a hue.\r\n\r\nThe user can also then change their min/max values in the params extended controls to fit their needs or to be able to extend a range mid-show","created_at":"2018-07-30T23:46:25Z","updated_at":"2018-09-15T21:29:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ddb7c41628328f372b0c22dabd450291b822d7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/nudibranchrecords/hedron/milestones/2","html_url":"https://github.com/nudibranchrecords/hedron/milestone/2","labels_url":"https://api.github.com/repos/nudibranchrecords/hedron/milestones/2/labels","id":3176778,"node_id":"MDk6TWlsZXN0b25lMzE3Njc3OA==","number":2,"title":"0.4.0","description":"Multi scene A/B functionality + lots of simple yet useful additions/fixes","creator":{"login":"funwithtriangles","id":1876324,"node_id":"MDQ6VXNlcjE4NzYzMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1876324?v=4","gravatar_id":"","url":"https://api.github.com/users/funwithtriangles","html_url":"https://github.com/funwithtriangles","followers_url":"https://api.github.com/users/funwithtriangles/followers","following_url":"https://api.github.com/users/funwithtriangles/following{/other_user}","gists_url":"https://api.github.com/users/funwithtriangles/gists{/gist_id}","starred_url":"https://api.github.com/users/funwithtriangles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funwithtriangles/subscriptions","organizations_url":"https://api.github.com/users/funwithtriangles/orgs","repos_url":"https://api.github.com/users/funwithtriangles/repos","events_url":"https://api.github.com/users/funwithtriangles/events{/privacy}","received_events_url":"https://api.github.com/users/funwithtriangles/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":34,"state":"open","created_at":"2018-03-11T12:38:56Z","updated_at":"2018-09-10T09:50:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/nudibranchrecords/hedron/pulls/75/commits","review_comments_url":"https://api.github.com/repos/nudibranchrecords/hedron/pulls/75/comments","review_comment_url":"https://api.github.com/repos/nudibranchrecords/hedron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nudibranchrecords/hedron/issues/75/comments","statuses_url":"https://api.github.com/repos/nudibranchrecords/hedron/statuses/9800c41cf090e794df74cbbb2104ff5889540ca9","head":{"label":"netgrind:feature/min-max","ref":"feature/min-max","sha":"9800c41cf090e794df74cbbb2104ff5889540ca9","user":{"login":"netgrind","id":4506708,"node_id":"MDQ6VXNlcjQ1MDY3MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/4506708?v=4","gravatar_id":"","url":"https://api.github.com/users/netgrind","html_url":"https://github.com/netgrind","followers_url":"https://api.github.com/users/netgrind/followers","following_url":"https://api.github.com/users/netgrind/following{/other_user}","gists_url":"https://api.github.com/users/netgrind/gists{/gist_id}","starred_url":"https://api.github.com/users/netgrind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netgrind/subscriptions","organizations_url":"https://api.github.com/users/netgrind/orgs","repos_url":"https://api.github.com/users/netgrind/repos","events_url":"https://api.github.com/users/netgrind/events{/privacy}","received_events_url":"https://api.github.com/users/netgrind/received_events","type":"User","site_admin":false},"repo":{"id":126336759,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYzMzY3NTk=","name":"hedron","full_name":"netgrind/hedron","private":false,"owner":{"login":"netgrind","id":4506708,"node_id":"MDQ6VXNlcjQ1MDY3MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/4506708?v=4","gravatar_id":"","url":"https://api.github.com/users/netgrind","html_url":"https://github.com/netgrind","followers_url":"https://api.github.com/users/netgrind/followers","following_url":"https://api.github.com/users/netgrind/following{/other_user}","gists_url":"https://api.github.com/users/netgrind/gists{/gist_id}","starred_url":"https://api.github.com/users/netgrind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netgrind/subscriptions","organizations_url":"https://api.github.com/users/netgrind/orgs","repos_url":"https://api.github.com/users/netgrind/repos","events_url":"https://api.github.com/users/netgrind/events{/privacy}","received_events_url":"https://api.github.com/users/netgrind/received_events","type":"User","site_admin":false},"html_url":"https://github.com/netgrind/hedron","description":"Perform live shows your three.js creations","fork":true,"url":"https://api.github.com/repos/netgrind/hedron","forks_url":"https://api.github.com/repos/netgrind/hedron/forks","keys_url":"https://api.github.com/repos/netgrind/hedron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netgrind/hedron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netgrind/hedron/teams","hooks_url":"https://api.github.com/repos/netgrind/hedron/hooks","issue_events_url":"https://api.github.com/repos/netgrind/hedron/issues/events{/number}","events_url":"https://api.github.com/repos/netgrind/hedron/events","assignees_url":"https://api.github.com/repos/netgrind/hedron/assignees{/user}","branches_url":"https://api.github.com/repos/netgrind/hedron/branches{/branch}","tags_url":"https://api.github.com/repos/netgrind/hedron/tags","blobs_url":"https://api.github.com/repos/netgrind/hedron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netgrind/hedron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netgrind/hedron/git/refs{/sha}","trees_url":"https://api.github.com/repos/netgrind/hedron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netgrind/hedron/statuses/{sha}","languages_url":"https://api.github.com/repos/netgrind/hedron/languages","stargazers_url":"https://api.github.com/repos/netgrind/hedron/stargazers","contributors_url":"https://api.github.com/repos/netgrind/hedron/contributors","subscribers_url":"https://api.github.com/repos/netgrind/hedron/subscribers","subscription_url":"https://api.github.com/repos/netgrind/hedron/subscription","commits_url":"https://api.github.com/repos/netgrind/hedron/commits{/sha}","git_commits_url":"https://api.github.com/repos/netgrind/hedron/git/commits{/sha}","comments_url":"https://api.github.com/repos/netgrind/hedron/comments{/number}","issue_comment_url":"https://api.github.com/repos/netgrind/hedron/issues/comments{/number}","contents_url":"https://api.github.com/repos/netgrind/hedron/contents/{+path}","compare_url":"https://api.github.com/repos/netgrind/hedron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netgrind/hedron/merges","archive_url":"https://api.github.com/repos/netgrind/hedron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netgrind/hedron/downloads","issues_url":"https://api.github.com/repos/netgrind/hedron/issues{/number}","pulls_url":"https://api.github.com/repos/netgrind/hedron/pulls{/number}","milestones_url":"https://api.github.com/repos/netgrind/hedron/milestones{/number}","notifications_url":"https://api.github.com/repos/netgrind/hedron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netgrind/hedron/labels{/name}","releases_url":"https://api.github.com/repos/netgrind/hedron/releases{/id}","deployments_url":"https://api.github.com/repos/netgrind/hedron/deployments","created_at":"2018-03-22T13:08:15Z","updated_at":"2018-05-08T17:25:55Z","pushed_at":"2018-09-09T23:46:34Z","git_url":"git://github.com/netgrind/hedron.git","ssh_url":"git@github.com:netgrind/hedron.git","clone_url":"https://github.com/netgrind/hedron.git","svn_url":"https://github.com/netgrind/hedron","homepage":null,"size":112484,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nudibranchrecords:dev","ref":"dev","sha":"05f27c948fc315e421770e0e49eaa2479b761868","user":{"login":"nudibranchrecords","id":37108326,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTA4MzI2","avatar_url":"https://avatars2.githubusercontent.com/u/37108326?v=4","gravatar_id":"","url":"https://api.github.com/users/nudibranchrecords","html_url":"https://github.com/nudibranchrecords","followers_url":"https://api.github.com/users/nudibranchrecords/followers","following_url":"https://api.github.com/users/nudibranchrecords/following{/other_user}","gists_url":"https://api.github.com/users/nudibranchrecords/gists{/gist_id}","starred_url":"https://api.github.com/users/nudibranchrecords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nudibranchrecords/subscriptions","organizations_url":"https://api.github.com/users/nudibranchrecords/orgs","repos_url":"https://api.github.com/users/nudibranchrecords/repos","events_url":"https://api.github.com/users/nudibranchrecords/events{/privacy}","received_events_url":"https://api.github.com/users/nudibranchrecords/received_events","type":"Organization","site_admin":false},"repo":{"id":122497380,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI0OTczODA=","name":"hedron","full_name":"nudibranchrecords/hedron","private":false,"owner":{"login":"nudibranchrecords","id":37108326,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTA4MzI2","avatar_url":"https://avatars2.githubusercontent.com/u/37108326?v=4","gravatar_id":"","url":"https://api.github.com/users/nudibranchrecords","html_url":"https://github.com/nudibranchrecords","followers_url":"https://api.github.com/users/nudibranchrecords/followers","following_url":"https://api.github.com/users/nudibranchrecords/following{/other_user}","gists_url":"https://api.github.com/users/nudibranchrecords/gists{/gist_id}","starred_url":"https://api.github.com/users/nudibranchrecords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nudibranchrecords/subscriptions","organizations_url":"https://api.github.com/users/nudibranchrecords/orgs","repos_url":"https://api.github.com/users/nudibranchrecords/repos","events_url":"https://api.github.com/users/nudibranchrecords/events{/privacy}","received_events_url":"https://api.github.com/users/nudibranchrecords/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nudibranchrecords/hedron","description":"Perform live shows your three.js creations","fork":false,"url":"https://api.github.com/repos/nudibranchrecords/hedron","forks_url":"https://api.github.com/repos/nudibranchrecords/hedron/forks","keys_url":"https://api.github.com/repos/nudibranchrecords/hedron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nudibranchrecords/hedron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nudibranchrecords/hedron/teams","hooks_url":"https://api.github.com/repos/nudibranchrecords/hedron/hooks","issue_events_url":"https://api.github.com/repos/nudibranchrecords/hedron/issues/events{/number}","events_url":"https://api.github.com/repos/nudibranchrecords/hedron/events","assignees_url":"https://api.github.com/repos/nudibranchrecords/hedron/assignees{/user}","branches_url":"https://api.github.com/repos/nudibranchrecords/hedron/branches{/branch}","tags_url":"https://api.github.com/repos/nudibranchrecords/hedron/tags","blobs_url":"https://api.github.com/repos/nudibranchrecords/hedron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nudibranchrecords/hedron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nudibranchrecords/hedron/git/refs{/sha}","trees_url":"https://api.github.com/repos/nudibranchrecords/hedron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nudibranchrecords/hedron/statuses/{sha}","languages_url":"https://api.github.com/repos/nudibranchrecords/hedron/languages","stargazers_url":"https://api.github.com/repos/nudibranchrecords/hedron/stargazers","contributors_url":"https://api.github.com/repos/nudibranchrecords/hedron/contributors","subscribers_url":"https://api.github.com/repos/nudibranchrecords/hedron/subscribers","subscription_url":"https://api.github.com/repos/nudibranchrecords/hedron/subscription","commits_url":"https://api.github.com/repos/nudibranchrecords/hedron/commits{/sha}","git_commits_url":"https://api.github.com/repos/nudibranchrecords/hedron/git/commits{/sha}","comments_url":"https://api.github.com/repos/nudibranchrecords/hedron/comments{/number}","issue_comment_url":"https://api.github.com/repos/nudibranchrecords/hedron/issues/comments{/number}","contents_url":"https://api.github.com/repos/nudibranchrecords/hedron/contents/{+path}","compare_url":"https://api.github.com/repos/nudibranchrecords/hedron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nudibranchrecords/hedron/merges","archive_url":"https://api.github.com/repos/nudibranchrecords/hedron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nudibranchrecords/hedron/downloads","issues_url":"https://api.github.com/repos/nudibranchrecords/hedron/issues{/number}","pulls_url":"https://api.github.com/repos/nudibranchrecords/hedron/pulls{/number}","milestones_url":"https://api.github.com/repos/nudibranchrecords/hedron/milestones{/number}","notifications_url":"https://api.github.com/repos/nudibranchrecords/hedron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nudibranchrecords/hedron/labels{/name}","releases_url":"https://api.github.com/repos/nudibranchrecords/hedron/releases{/id}","deployments_url":"https://api.github.com/repos/nudibranchrecords/hedron/deployments","created_at":"2018-02-22T15:29:25Z","updated_at":"2018-09-11T09:22:40Z","pushed_at":"2018-09-09T23:46:35Z","git_url":"git://github.com/nudibranchrecords/hedron.git","ssh_url":"git@github.com:nudibranchrecords/hedron.git","clone_url":"https://github.com/nudibranchrecords/hedron.git","svn_url":"https://github.com/nudibranchrecords/hedron","homepage":null,"size":2180,"stargazers_count":107,"watchers_count":107,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":5,"open_issues":45,"watchers":107,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/nudibranchrecords/hedron/pulls/75"},"html":{"href":"https://github.com/nudibranchrecords/hedron/pull/75"},"issue":{"href":"https://api.github.com/repos/nudibranchrecords/hedron/issues/75"},"comments":{"href":"https://api.github.com/repos/nudibranchrecords/hedron/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/nudibranchrecords/hedron/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/nudibranchrecords/hedron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nudibranchrecords/hedron/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/nudibranchrecords/hedron/statuses/9800c41cf090e794df74cbbb2104ff5889540ca9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"netgrind"}}