{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/195105096","pull_request_review_id":128405215,"id":195105096,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTEwNTA5Ng==","diff_hunk":"@@ -1,4 +1,33 @@\n-{ stdenv, buildPythonApplication, fetchFromGitHub, matplotlib, netperf, procps, pyqt5 }:\n+{ stdenv, buildPythonApplication, fetchFromGitHub, matplotlib, netperf, procps, pyqt5\n+, makeWrapper, iperf2\n+, withMan ? true, sphinx ? null","path":"pkgs/applications/networking/flent/default.nix","position":null,"original_position":4,"commit_id":"0080fe93fcaf18f390696f9c4e715b5ac6952d4a","original_commit_id":"9c6dda72bea2fc2b5650c5a106df13ee90ef0810","user":{"login":"teto","id":886074,"node_id":"MDQ6VXNlcjg4NjA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"body":"I received different feedback on other PRs but I definitely agree we should encourage manpages so I build it by default.","created_at":"2018-06-13T14:30:34Z","updated_at":"2018-06-13T14:30:35Z","html_url":"https://github.com/NixOS/nixpkgs/pull/41614#discussion_r195105096","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41614","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/195105096"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/41614#discussion_r195105096"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41614"}},"in_reply_to_id":194270876},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41614","id":193203521,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMjAzNTIx","html_url":"https://github.com/NixOS/nixpkgs/pull/41614","diff_url":"https://github.com/NixOS/nixpkgs/pull/41614.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/41614.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/41614","number":41614,"state":"open","locked":false,"title":"flent: wrap binaries with netperf/iperf/http-getter","user":{"login":"teto","id":886074,"node_id":"MDQ6VXNlcjg4NjA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nwithout at least netperf the program is useless since it is an interface to netperf.\r\nhttp-getter is a small utility used just by flent so I addded it to the flent default.nix.\r\n\r\nNB: for those testing it, I kept the stable release but there is a nasty bug that was solved there\r\nhttps://github.com/tohojo/flent/issues/137 so you might need to override the src to sthg more recent.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-06-07T04:55:06Z","updated_at":"2018-06-13T14:30:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0253abe64d7b3af26b828164f06709ee9172be3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41614/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41614/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/41614/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/0080fe93fcaf18f390696f9c4e715b5ac6952d4a","head":{"label":"teto:flent_wrap","ref":"flent_wrap","sha":"0080fe93fcaf18f390696f9c4e715b5ac6952d4a","user":{"login":"teto","id":886074,"node_id":"MDQ6VXNlcjg4NjA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"repo":{"id":61347607,"node_id":"MDEwOlJlcG9zaXRvcnk2MTM0NzYwNw==","name":"nixpkgs","full_name":"teto/nixpkgs","owner":{"login":"teto","id":886074,"node_id":"MDQ6VXNlcjg4NjA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teto/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/teto/nixpkgs","forks_url":"https://api.github.com/repos/teto/nixpkgs/forks","keys_url":"https://api.github.com/repos/teto/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teto/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teto/nixpkgs/teams","hooks_url":"https://api.github.com/repos/teto/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/teto/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/teto/nixpkgs/events","assignees_url":"https://api.github.com/repos/teto/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/teto/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/teto/nixpkgs/tags","blobs_url":"https://api.github.com/repos/teto/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teto/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teto/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/teto/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teto/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/teto/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/teto/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/teto/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/teto/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/teto/nixpkgs/subscription","commits_url":"https://api.github.com/repos/teto/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/teto/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/teto/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/teto/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/teto/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/teto/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teto/nixpkgs/merges","archive_url":"https://api.github.com/repos/teto/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teto/nixpkgs/downloads","issues_url":"https://api.github.com/repos/teto/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/teto/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/teto/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/teto/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teto/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/teto/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/teto/nixpkgs/deployments","created_at":"2016-06-17T05:22:26Z","updated_at":"2018-06-01T05:23:31Z","pushed_at":"2018-06-13T14:29:52Z","git_url":"git://github.com/teto/nixpkgs.git","ssh_url":"git@github.com:teto/nixpkgs.git","clone_url":"https://github.com/teto/nixpkgs.git","svn_url":"https://github.com/teto/nixpkgs","homepage":null,"size":698820,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"606ff955fb8856d092aa5a5889b98227b0d2295b","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-06-13T13:58:28Z","pushed_at":"2018-06-13T14:30:25Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":805576,"stargazers_count":2506,"watchers_count":2506,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2806,"mirror_url":null,"archived":false,"open_issues_count":3205,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2806,"open_issues":3205,"watchers":2506,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41614"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/41614"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/41614"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/41614/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41614/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41614/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/0080fe93fcaf18f390696f9c4e715b5ac6952d4a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"teto"}}