{"action":"created","issue":{"url":"https://api.github.com/repos/chainer/chainer/issues/4421","repository_url":"https://api.github.com/repos/chainer/chainer","labels_url":"https://api.github.com/repos/chainer/chainer/issues/4421/labels{/name}","comments_url":"https://api.github.com/repos/chainer/chainer/issues/4421/comments","events_url":"https://api.github.com/repos/chainer/chainer/issues/4421/events","html_url":"https://github.com/chainer/chainer/pull/4421","id":301008818,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcxOTQxNzk5","number":4421,"title":"FunctionNodes as implementation details","user":{"login":"hvy","id":5983694,"node_id":"MDQ6VXNlcjU5ODM2OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5983694?v=4","gravatar_id":"","url":"https://api.github.com/users/hvy","html_url":"https://github.com/hvy","followers_url":"https://api.github.com/users/hvy/followers","following_url":"https://api.github.com/users/hvy/following{/other_user}","gists_url":"https://api.github.com/users/hvy/gists{/gist_id}","starred_url":"https://api.github.com/users/hvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvy/subscriptions","organizations_url":"https://api.github.com/users/hvy/orgs","repos_url":"https://api.github.com/users/hvy/repos","events_url":"https://api.github.com/users/hvy/events{/privacy}","received_events_url":"https://api.github.com/users/hvy/received_events","type":"User","site_admin":false},"labels":[{"id":220754695,"node_id":"MDU6TGFiZWwyMjA3NTQ2OTU=","url":"https://api.github.com/repos/chainer/chainer/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":306538927,"node_id":"MDU6TGFiZWwzMDY1Mzg5Mjc=","url":"https://api.github.com/repos/chainer/chainer/labels/no-compat","name":"no-compat","color":"000000","default":false}],"state":"open","locked":false,"assignee":{"login":"kmaehashi","id":939877,"node_id":"MDQ6VXNlcjkzOTg3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/939877?v=4","gravatar_id":"","url":"https://api.github.com/users/kmaehashi","html_url":"https://github.com/kmaehashi","followers_url":"https://api.github.com/users/kmaehashi/followers","following_url":"https://api.github.com/users/kmaehashi/following{/other_user}","gists_url":"https://api.github.com/users/kmaehashi/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaehashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaehashi/subscriptions","organizations_url":"https://api.github.com/users/kmaehashi/orgs","repos_url":"https://api.github.com/users/kmaehashi/repos","events_url":"https://api.github.com/users/kmaehashi/events{/privacy}","received_events_url":"https://api.github.com/users/kmaehashi/received_events","type":"User","site_admin":false},"assignees":[{"login":"kmaehashi","id":939877,"node_id":"MDQ6VXNlcjkzOTg3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/939877?v=4","gravatar_id":"","url":"https://api.github.com/users/kmaehashi","html_url":"https://github.com/kmaehashi","followers_url":"https://api.github.com/users/kmaehashi/followers","following_url":"https://api.github.com/users/kmaehashi/following{/other_user}","gists_url":"https://api.github.com/users/kmaehashi/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaehashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaehashi/subscriptions","organizations_url":"https://api.github.com/users/kmaehashi/orgs","repos_url":"https://api.github.com/users/kmaehashi/repos","events_url":"https://api.github.com/users/kmaehashi/events{/privacy}","received_events_url":"https://api.github.com/users/kmaehashi/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/chainer/chainer/milestones/69","html_url":"https://github.com/chainer/chainer/milestone/69","labels_url":"https://api.github.com/repos/chainer/chainer/milestones/69/labels","id":3397601,"node_id":"MDk6TWlsZXN0b25lMzM5NzYwMQ==","number":69,"title":"v5.0.0b3","description":"Date is tentative.","creator":{"login":"kmaehashi","id":939877,"node_id":"MDQ6VXNlcjkzOTg3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/939877?v=4","gravatar_id":"","url":"https://api.github.com/users/kmaehashi","html_url":"https://github.com/kmaehashi","followers_url":"https://api.github.com/users/kmaehashi/followers","following_url":"https://api.github.com/users/kmaehashi/following{/other_user}","gists_url":"https://api.github.com/users/kmaehashi/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaehashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaehashi/subscriptions","organizations_url":"https://api.github.com/users/kmaehashi/orgs","repos_url":"https://api.github.com/users/kmaehashi/repos","events_url":"https://api.github.com/users/kmaehashi/events{/privacy}","received_events_url":"https://api.github.com/users/kmaehashi/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":5,"state":"open","created_at":"2018-06-04T07:50:36Z","updated_at":"2018-06-23T08:56:35Z","due_on":"2018-07-31T07:00:00Z","closed_at":null},"comments":28,"created_at":"2018-02-28T12:39:33Z","updated_at":"2018-06-23T09:22:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/chainer/chainer/pulls/4421","html_url":"https://github.com/chainer/chainer/pull/4421","diff_url":"https://github.com/chainer/chainer/pull/4421.diff","patch_url":"https://github.com/chainer/chainer/pull/4421.patch"},"body":"This PR hides all `FunctionNode` implementations from `functions/__init__.py` since these are considered implementation details and should not \"be visible\" to the user.\r\n\r\nSome exceptions are `FunctionNode`s with states that are exposed through APIs such as the indices for the max pooling classes and the random states in dropout and gaussian noise.\r\n\r\nTests are modified accordingly to not rely on these classes directly. There are few exceptions including the the ones above.\r\n\r\n- [x] Remove FunctionNode imports from `functions/__init__`\r\n- [x] Do not use FunctionNodes classes directly in tests if possible\r\n- ~[ ] Remove `FunctionNode`'s `__init__`'s default arguments~ (Maybe better done in a separate PR)\r\n\r\n_Note: Reviewing commit by commit is probably much easier than looking at the total diff._"},"comment":{"url":"https://api.github.com/repos/chainer/chainer/issues/comments/399656723","html_url":"https://github.com/chainer/chainer/pull/4421#issuecomment-399656723","issue_url":"https://api.github.com/repos/chainer/chainer/issues/4421","id":399656723,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTY1NjcyMw==","user":{"login":"hvy","id":5983694,"node_id":"MDQ6VXNlcjU5ODM2OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5983694?v=4","gravatar_id":"","url":"https://api.github.com/users/hvy","html_url":"https://github.com/hvy","followers_url":"https://api.github.com/users/hvy/followers","following_url":"https://api.github.com/users/hvy/following{/other_user}","gists_url":"https://api.github.com/users/hvy/gists{/gist_id}","starred_url":"https://api.github.com/users/hvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvy/subscriptions","organizations_url":"https://api.github.com/users/hvy/orgs","repos_url":"https://api.github.com/users/hvy/repos","events_url":"https://api.github.com/users/hvy/events{/privacy}","received_events_url":"https://api.github.com/users/hvy/received_events","type":"User","site_admin":false},"created_at":"2018-06-23T09:22:08Z","updated_at":"2018-06-23T09:22:08Z","author_association":"MEMBER","body":"jenkins, test this please."}}
{"actor":{"display_login":"hvy"}}