{"action":"created","issue":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2751","repository_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf","labels_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2751/labels{/name}","comments_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2751/comments","events_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2751/events","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2751","id":328585183,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDg0Nzk1","number":2751,"title":"feat(analytics): integrate google tag manager","user":{"login":"milesap","id":10187181,"node_id":"MDQ6VXNlcjEwMTg3MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10187181?v=4","gravatar_id":"","url":"https://api.github.com/users/milesap","html_url":"https://github.com/milesap","followers_url":"https://api.github.com/users/milesap/followers","following_url":"https://api.github.com/users/milesap/following{/other_user}","gists_url":"https://api.github.com/users/milesap/gists{/gist_id}","starred_url":"https://api.github.com/users/milesap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesap/subscriptions","organizations_url":"https://api.github.com/users/milesap/orgs","repos_url":"https://api.github.com/users/milesap/repos","events_url":"https://api.github.com/users/milesap/events{/privacy}","received_events_url":"https://api.github.com/users/milesap/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"AleksueiR","id":2285779,"node_id":"MDQ6VXNlcjIyODU3Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2285779?v=4","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false},"assignees":[{"login":"AleksueiR","id":2285779,"node_id":"MDQ6VXNlcjIyODU3Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2285779?v=4","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false},{"login":"JahidAhmed","id":9637542,"node_id":"MDQ6VXNlcjk2Mzc1NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/9637542?v=4","gravatar_id":"","url":"https://api.github.com/users/JahidAhmed","html_url":"https://github.com/JahidAhmed","followers_url":"https://api.github.com/users/JahidAhmed/followers","following_url":"https://api.github.com/users/JahidAhmed/following{/other_user}","gists_url":"https://api.github.com/users/JahidAhmed/gists{/gist_id}","starred_url":"https://api.github.com/users/JahidAhmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JahidAhmed/subscriptions","organizations_url":"https://api.github.com/users/JahidAhmed/orgs","repos_url":"https://api.github.com/users/JahidAhmed/repos","events_url":"https://api.github.com/users/JahidAhmed/events{/privacy}","received_events_url":"https://api.github.com/users/JahidAhmed/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-06-01T16:33:33Z","updated_at":"2018-06-01T16:35:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/pulls/2751","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2751","diff_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2751.diff","patch_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2751.patch"},"body":"## Description\r\nAdds [Google Tag Manager](https://developers.google.com/tag-manager/quickstart) code programmatically on RAMP startup. Adds the GTM dataLayer on our api.  `tag-manager.js` will contain push events triggered by api observations and consolidates tracking into one central location. Most tracking is configured within GTM console. The one's that aren't are included in this PR:\r\n\r\n-  tracking the time it takes from page landing to when `events.rvMapLoaded` is fired. This is passed through to analytics user speed analysis. \r\n- extent changes (pan/zoom)\r\n- basemap changes\r\n\r\n## Testing\r\nTags firing as expected when tested in preview mode in GTM.\r\n\r\n## Documentation\r\nNone yet\r\n\r\n## Checklist\r\n<!-- Quick checklist for items that are easy to miss -->\r\n\r\n- [x] Commit messages follow [the guidelines](https://github.com/fgpv-vpgf/fgpv-vpgf/blob/master/CONTRIBUTING.md#-git-commit-guidelines)\r\n- [ ] Release notes have been updated\r\n- [x] PR targets the correct release version\r\n- [] Help files and documentation have been updated\r\n\r\nRemember, it is a *muffin offence* to open a PR with any of the above checklist items incomplete.\r\n\r\nPlease keep the original issue up to date with the final solution, expected behaviour, and any additional notes for testers\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fgpv-vpgf/fgpv-vpgf/2751)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/comments/393937161","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2751#issuecomment-393937161","issue_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2751","id":393937161,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzkzNzE2MQ==","user":{"login":"glitch-bot","id":13870658,"node_id":"MDQ6VXNlcjEzODcwNjU4","avatar_url":"https://avatars3.githubusercontent.com/u/13870658?v=4","gravatar_id":"","url":"https://api.github.com/users/glitch-bot","html_url":"https://github.com/glitch-bot","followers_url":"https://api.github.com/users/glitch-bot/followers","following_url":"https://api.github.com/users/glitch-bot/following{/other_user}","gists_url":"https://api.github.com/users/glitch-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/glitch-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glitch-bot/subscriptions","organizations_url":"https://api.github.com/users/glitch-bot/orgs","repos_url":"https://api.github.com/users/glitch-bot/repos","events_url":"https://api.github.com/users/glitch-bot/events{/privacy}","received_events_url":"https://api.github.com/users/glitch-bot/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T16:35:44Z","updated_at":"2018-06-01T16:35:44Z","author_association":"CONTRIBUTOR","body":"Hey, I updated your PR Demo (__Build #4835__):\n\n| Dev Builds                      | Prod Builds                     |\n| ------------------------------- | ------------------------------- |\n| [index-one.html](http://fgpv.cloudapp.net/demo/users/milesap/gtm/dev/samples/index-one.html)    | [index-one.html](http://fgpv.cloudapp.net/demo/users/milesap/gtm/prod/samples/index-one.html)    |\n| [index-mobile.html](http://fgpv.cloudapp.net/demo/users/milesap/gtm/dev/samples/index-mobile.html)    | [index-mobile.html](http://fgpv.cloudapp.net/demo/users/milesap/gtm/prod/samples/index-mobile.html)    |\n| [index-samples.html](http://fgpv.cloudapp.net/demo/users/milesap/gtm/dev/samples/index-samples.html)    | [index-samples.html](http://fgpv.cloudapp.net/demo/users/milesap/gtm/prod/samples/index-samples.html)    |\n| [index-fgp-en.html](http://fgpv.cloudapp.net/demo/users/milesap/gtm/dev/samples/index-fgp-en.html) | [index-fgp-en.html](http://fgpv.cloudapp.net/demo/users/milesap/gtm/prod/samples/index-fgp-en.html) |\n| [index-fgp-fr.html](http://fgpv.cloudapp.net/demo/users/milesap/gtm/dev/samples/index-fgp-fr.html) | [index-fgp-fr.html](http://fgpv.cloudapp.net/demo/users/milesap/gtm/prod/samples/index-fgp-fr.html) |\n\nIs it working as expected?"}}
{"actor":{"display_login":"glitch-bot"}}