{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/charts/issues/4118","repository_url":"https://api.github.com/repos/kubernetes/charts","labels_url":"https://api.github.com/repos/kubernetes/charts/issues/4118/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/4118/comments","events_url":"https://api.github.com/repos/kubernetes/charts/issues/4118/events","html_url":"https://github.com/kubernetes/charts/pull/4118","id":304541157,"number":4118,"title":"Add annotations and service type to zookeeper","user":{"login":"ravi-kumar","id":1299606,"avatar_url":"https://avatars0.githubusercontent.com/u/1299606?v=4","gravatar_id":"","url":"https://api.github.com/users/ravi-kumar","html_url":"https://github.com/ravi-kumar","followers_url":"https://api.github.com/users/ravi-kumar/followers","following_url":"https://api.github.com/users/ravi-kumar/following{/other_user}","gists_url":"https://api.github.com/users/ravi-kumar/gists{/gist_id}","starred_url":"https://api.github.com/users/ravi-kumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravi-kumar/subscriptions","organizations_url":"https://api.github.com/users/ravi-kumar/orgs","repos_url":"https://api.github.com/users/ravi-kumar/repos","events_url":"https://api.github.com/users/ravi-kumar/events{/privacy}","received_events_url":"https://api.github.com/users/ravi-kumar/received_events","type":"User","site_admin":false},"labels":[{"id":484586588,"url":"https://api.github.com/repos/kubernetes/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676009699,"url":"https://api.github.com/repos/kubernetes/charts/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"lachie83","id":6912984,"avatar_url":"https://avatars2.githubusercontent.com/u/6912984?v=4","gravatar_id":"","url":"https://api.github.com/users/lachie83","html_url":"https://github.com/lachie83","followers_url":"https://api.github.com/users/lachie83/followers","following_url":"https://api.github.com/users/lachie83/following{/other_user}","gists_url":"https://api.github.com/users/lachie83/gists{/gist_id}","starred_url":"https://api.github.com/users/lachie83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachie83/subscriptions","organizations_url":"https://api.github.com/users/lachie83/orgs","repos_url":"https://api.github.com/users/lachie83/repos","events_url":"https://api.github.com/users/lachie83/events{/privacy}","received_events_url":"https://api.github.com/users/lachie83/received_events","type":"User","site_admin":false},"assignees":[{"login":"unguiculus","id":925412,"avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},{"login":"lachie83","id":6912984,"avatar_url":"https://avatars2.githubusercontent.com/u/6912984?v=4","gravatar_id":"","url":"https://api.github.com/users/lachie83","html_url":"https://github.com/lachie83","followers_url":"https://api.github.com/users/lachie83/followers","following_url":"https://api.github.com/users/lachie83/following{/other_user}","gists_url":"https://api.github.com/users/lachie83/gists{/gist_id}","starred_url":"https://api.github.com/users/lachie83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachie83/subscriptions","organizations_url":"https://api.github.com/users/lachie83/orgs","repos_url":"https://api.github.com/users/lachie83/repos","events_url":"https://api.github.com/users/lachie83/events{/privacy}","received_events_url":"https://api.github.com/users/lachie83/received_events","type":"User","site_admin":false},{"login":"kow3ns","id":11380896,"avatar_url":"https://avatars3.githubusercontent.com/u/11380896?v=4","gravatar_id":"","url":"https://api.github.com/users/kow3ns","html_url":"https://github.com/kow3ns","followers_url":"https://api.github.com/users/kow3ns/followers","following_url":"https://api.github.com/users/kow3ns/following{/other_user}","gists_url":"https://api.github.com/users/kow3ns/gists{/gist_id}","starred_url":"https://api.github.com/users/kow3ns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kow3ns/subscriptions","organizations_url":"https://api.github.com/users/kow3ns/orgs","repos_url":"https://api.github.com/users/kow3ns/repos","events_url":"https://api.github.com/users/kow3ns/events{/privacy}","received_events_url":"https://api.github.com/users/kow3ns/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-03-12T21:09:53Z","updated_at":"2018-03-16T12:41:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/4118","html_url":"https://github.com/kubernetes/charts/pull/4118","diff_url":"https://github.com/kubernetes/charts/pull/4118.diff","patch_url":"https://github.com/kubernetes/charts/pull/4118.patch"},"body":"Enable the zookeeper service to be accessible from inside as well as outside the cluster if required.\r\n\r\n<!--\r\nThank you for contributing to kubernetes/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**: Enables the zookeeper service to be accessible from inside as well as outside the cluster if required.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/charts/issues/comments/373701442","html_url":"https://github.com/kubernetes/charts/pull/4118#issuecomment-373701442","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/4118","id":373701442,"user":{"login":"unguiculus","id":925412,"avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T12:41:14Z","updated_at":"2018-03-16T12:41:14Z","author_association":"MEMBER","body":"/lgtm"}}
{"actor":{"display_login":"unguiculus"}}