{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/22103","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/22103/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/22103/comments","events_url":"https://api.github.com/repos/apache/spark/issues/22103/events","html_url":"https://github.com/apache/spark/pull/22103","id":350377534,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MjQyMTUw","number":22103,"title":"[SPARK-25113][SQL] Add logging to CodeGenerator when any generated method's bytecode size goes above HugeMethodLimit","user":{"login":"rednaxelafx","id":107834,"node_id":"MDQ6VXNlcjEwNzgzNA==","avatar_url":"https://avatars1.githubusercontent.com/u/107834?v=4","gravatar_id":"","url":"https://api.github.com/users/rednaxelafx","html_url":"https://github.com/rednaxelafx","followers_url":"https://api.github.com/users/rednaxelafx/followers","following_url":"https://api.github.com/users/rednaxelafx/following{/other_user}","gists_url":"https://api.github.com/users/rednaxelafx/gists{/gist_id}","starred_url":"https://api.github.com/users/rednaxelafx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rednaxelafx/subscriptions","organizations_url":"https://api.github.com/users/rednaxelafx/orgs","repos_url":"https://api.github.com/users/rednaxelafx/repos","events_url":"https://api.github.com/users/rednaxelafx/events{/privacy}","received_events_url":"https://api.github.com/users/rednaxelafx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-14T10:53:21Z","updated_at":"2018-08-14T10:58:22Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22103","html_url":"https://github.com/apache/spark/pull/22103","diff_url":"https://github.com/apache/spark/pull/22103.diff","patch_url":"https://github.com/apache/spark/pull/22103.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nAdd logging for all generated methods from the `CodeGenerator` whose bytecode size goes above 8000 bytes.\r\nThis is to help with gathering stats on how often Spark is generating methods too big to be JIT'd. It covers all codegen scenarios, include whole-stage codegen and also individual expression codegen, e.g. unsafe projection, mutable projection, etc.\r\n\r\n## How was this patch tested?\r\n\r\nManually tested that logging did happen when generated method was above 8000 bytes.\r\nAlso added a new unit test case to `CodeGenerationSuite` to verify that the logging did happen."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/412833989","html_url":"https://github.com/apache/spark/pull/22103#issuecomment-412833989","issue_url":"https://api.github.com/repos/apache/spark/issues/22103","id":412833989,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjgzMzk4OQ==","user":{"login":"SparkQA","id":8108735,"node_id":"MDQ6VXNlcjgxMDg3MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8108735?v=4","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T10:58:22Z","updated_at":"2018-08-14T10:58:22Z","author_association":"NONE","body":"**[Test build #94740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94740/testReport)** for PR 22103 at commit [`640c9cd`](https://github.com/apache/spark/commit/640c9cd3b99d51f38c9b1a0c3f94bae676d11e51)."}}
{"actor":{"display_login":"SparkQA"}}