{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/18666","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/18666/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/18666/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/18666/events","html_url":"https://github.com/dotnet/coreclr/pull/18666","id":336046584,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTk0MDkx","number":18666,"title":"Fix Sync.sh to Property Handle Positional Parameters and Remove Conditional DotNETRuntimeEventSource.cs Compilation","user":{"login":"brianrob","id":6210322,"node_id":"MDQ6VXNlcjYyMTAzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/6210322?v=4","gravatar_id":"","url":"https://api.github.com/users/brianrob","html_url":"https://github.com/brianrob","followers_url":"https://api.github.com/users/brianrob/followers","following_url":"https://api.github.com/users/brianrob/following{/other_user}","gists_url":"https://api.github.com/users/brianrob/gists{/gist_id}","starred_url":"https://api.github.com/users/brianrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianrob/subscriptions","organizations_url":"https://api.github.com/users/brianrob/orgs","repos_url":"https://api.github.com/users/brianrob/repos","events_url":"https://api.github.com/users/brianrob/events{/privacy}","received_events_url":"https://api.github.com/users/brianrob/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-27T01:34:04Z","updated_at":"2018-06-27T17:03:34Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/18666","html_url":"https://github.com/dotnet/coreclr/pull/18666","diff_url":"https://github.com/dotnet/coreclr/pull/18666.diff","patch_url":"https://github.com/dotnet/coreclr/pull/18666.patch"},"body":"Fixes #18661.\r\n\r\nOfficial builds call sync.sh using the following command line:\r\n```\r\n./sync.sh -- /p:BuildType=Debug\r\n```\r\n\r\nDue to a bug in sync.sh, instead of just doing a sync operation, this does a full build of the managed components - System.Private.CoreLib and SOS.NETCore.  This used to work and wasn't a huge deal, but now is broken because we generate DotNETRuntimeEventSource.cs as part of the build and this occurs after the sync operation.\r\n\r\nThe root cause of the bug is that sync.sh does not specify the default argument ```-p``` to run.exe if any arguments are specified to sync.sh.  This includes positional parameters after the double dash.  If -p is not specified then ```/t:sync``` is not passed to msbuild, thus causing the full managed build instead of just the restore operation.\r\n\r\nThe solution is to detect this case (no args other than positional parameters after ```--```) and assume ```-p```."},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/400757509","html_url":"https://github.com/dotnet/coreclr/pull/18666#issuecomment-400757509","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/18666","id":400757509,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDc1NzUwOQ==","user":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T17:03:33Z","updated_at":"2018-06-27T17:03:33Z","author_association":"MEMBER","body":"Looks like corefx doesn't hit this bug currently because we always pass `-p`, https://github.com/dotnet/corefx/blob/master/buildpipeline/DotNet-CoreFx-Trusted-Linux.json#L441. Whereas coreclr https://github.com/dotnet/coreclr/blob/master/buildpipeline/DotNet-CoreClr-Trusted-Linux.json#L142 doesn't pass `-p` and expects it to get defaulted. "}}
{"actor":{"display_login":"weshaggard"}}