{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/229917710","pull_request_review_id":170531367,"id":229917710,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTkxNzcxMA==","diff_hunk":"@@ -316,17 +344,24 @@ class FontSize extends Gatherer {\n     passContext.driver.on('CSS.styleSheetAdded', onStylesheetAdd);\n \n     await Promise.all([\n+      passContext.driver.sendCommand('DOMSnapshot.enable'),\n       passContext.driver.sendCommand('DOM.enable'),\n       passContext.driver.sendCommand('CSS.enable'),\n     ]);\n \n+    // Use DOMSnapshot.captureSnapshot to get the computed font-size style of every node.\n+    const snapshot = await passContext.driver.sendCommand('DOMSnapshot.captureSnapshot', {\n+      computedStyles: ['font-size'],\n+    });\n+    // backendIdsToFontData will include all non-empty TextNodes,\n+    const backendIdsToFontData = this.calculateBackendIdsToFontData(snapshot);\n+    // but nodes will only contain the Body node and its descendants.\n+    const crdpNodes = await getAllNodesFromBody(passContext.driver);","path":"lighthouse-core/gather/gatherers/seo/font-size.js","position":234,"original_position":234,"commit_id":"f15f8f2a5cdb2770ff8de3cbecc7d657b66c24c8","original_commit_id":"d6698dd8c4da292941478dc0e8693e3e517f7cf8","user":{"login":"paulirish","id":39191,"node_id":"MDQ6VXNlcjM5MTkx","avatar_url":"https://avatars0.githubusercontent.com/u/39191?v=4","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false},"body":"Yeah looks like the snapshot doesn't have `nodeId`. only `backendNodeId`. Bummer.\r\n\r\nK. We'll keep the current protocol calls. :)","created_at":"2018-11-01T01:42:22Z","updated_at":"2018-11-01T01:44:14Z","html_url":"https://github.com/GoogleChrome/lighthouse/pull/6391#discussion_r229917710","pull_request_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6391","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/229917710"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/6391#discussion_r229917710"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6391"}},"in_reply_to_id":229870781},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6391","id":225835579,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODM1NTc5","html_url":"https://github.com/GoogleChrome/lighthouse/pull/6391","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/6391.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/6391.patch","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/6391","number":6391,"state":"open","locked":false,"title":"core(font-size): speed up gatherer","user":{"login":"Hoten","id":4071474,"node_id":"MDQ6VXNlcjQwNzE0NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4071474?v=4","gravatar_id":"","url":"https://api.github.com/users/Hoten","html_url":"https://github.com/Hoten","followers_url":"https://api.github.com/users/Hoten/followers","following_url":"https://api.github.com/users/Hoten/following{/other_user}","gists_url":"https://api.github.com/users/Hoten/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoten/subscriptions","organizations_url":"https://api.github.com/users/Hoten/orgs","repos_url":"https://api.github.com/users/Hoten/repos","events_url":"https://api.github.com/users/Hoten/events{/privacy}","received_events_url":"https://api.github.com/users/Hoten/received_events","type":"User","site_admin":false},"body":"Fixes #6386.\r\n\r\nSee comments in discussion and code. LMK if anything is unclear :)","created_at":"2018-10-25T17:04:05Z","updated_at":"2018-11-01T01:44:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b852cc910b43df054520ee8d84466b71d77dc920","assignee":{"login":"paulirish","id":39191,"node_id":"MDQ6VXNlcjM5MTkx","avatar_url":"https://avatars0.githubusercontent.com/u/39191?v=4","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false},"assignees":[{"login":"paulirish","id":39191,"node_id":"MDQ6VXNlcjM5MTkx","avatar_url":"https://avatars0.githubusercontent.com/u/39191?v=4","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6391/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6391/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/6391/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/f15f8f2a5cdb2770ff8de3cbecc7d657b66c24c8","head":{"label":"GoogleChrome:issue-6386-speed-up-font-size-gatherer","ref":"issue-6386-speed-up-font-size-gatherer","sha":"f15f8f2a5cdb2770ff8de3cbecc7d657b66c24c8","user":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"node_id":"MDEwOlJlcG9zaXRvcnk1MzM3MDk4OA==","name":"lighthouse","full_name":"GoogleChrome/lighthouse","private":false,"owner":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleChrome/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2018-11-01T01:01:29Z","pushed_at":"2018-11-01T01:01:22Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":"https://developers.google.com/web/tools/lighthouse/","size":27488,"stargazers_count":14995,"watchers_count":14995,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":4862,"mirror_url":null,"archived":false,"open_issues_count":371,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4862,"open_issues":371,"watchers":14995,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"5a113dc567633fac3e5843b82c875d21a4b23564","user":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"node_id":"MDEwOlJlcG9zaXRvcnk1MzM3MDk4OA==","name":"lighthouse","full_name":"GoogleChrome/lighthouse","private":false,"owner":{"login":"GoogleChrome","id":1778935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzg5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleChrome/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2018-11-01T01:01:29Z","pushed_at":"2018-11-01T01:01:22Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":"https://developers.google.com/web/tools/lighthouse/","size":27488,"stargazers_count":14995,"watchers_count":14995,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":4862,"mirror_url":null,"archived":false,"open_issues_count":371,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4862,"open_issues":371,"watchers":14995,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6391"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/6391"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/6391"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/6391/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6391/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/6391/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/f15f8f2a5cdb2770ff8de3cbecc7d657b66c24c8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"paulirish"}}