{"action":"created","comment":{"url":"https://api.github.com/repos/ef-carbon/dom/pulls/comments/198177673","pull_request_review_id":132060223,"id":198177673,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODE3NzY3Mw==","diff_hunk":"@@ -9,13 +9,16 @@ import {\n } from '@ef-carbon/primitive';\n \n import { IMutable } from '@node/IAudio';\n+import { IMutable as INodeTextMutable } from '@node/IText';\n+import Text, { IOptions as INodeTextOptions } from '@node/Text';\n import Type from '@node/Type';\n export * from '@node/IAudio';\n \n export interface IOptions {\n   url: UrlAccepted;\n   start?: MillisecondsAccepted;\n   end?: MillisecondsAccepted;\n+  text?: INodeTextOptions | string;","path":"lib/node/Audio.ts","position":13,"original_position":13,"commit_id":"c43d68ddb49acf7c104c69bbd3858a952a64d2dd","original_commit_id":"c43d68ddb49acf7c104c69bbd3858a952a64d2dd","user":{"login":"mattyclarkson","id":1081113,"node_id":"MDQ6VXNlcjEwODExMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1081113?v=4","gravatar_id":"","url":"https://api.github.com/users/mattyclarkson","html_url":"https://github.com/mattyclarkson","followers_url":"https://api.github.com/users/mattyclarkson/followers","following_url":"https://api.github.com/users/mattyclarkson/following{/other_user}","gists_url":"https://api.github.com/users/mattyclarkson/gists{/gist_id}","starred_url":"https://api.github.com/users/mattyclarkson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattyclarkson/subscriptions","organizations_url":"https://api.github.com/users/mattyclarkson/orgs","repos_url":"https://api.github.com/users/mattyclarkson/repos","events_url":"https://api.github.com/users/mattyclarkson/events{/privacy}","received_events_url":"https://api.github.com/users/mattyclarkson/received_events","type":"User","site_admin":false},"body":"Just realised we have a `Track.Type.Transcript`. Waaaay more work to add in that though, but more future proof. Could do the following:\r\n\r\n```typescript\r\nconst transcript = audio.tracks.transcript.items.join(' ');\r\n```\r\n\r\nThat could be hidden behind a `get transcipt(): string` function on the `Audio` class.\r\n\r\nBenefits:\r\n\r\n  * Works with the current tracks interfaces we have\r\n  * Allows transcript of the audio with time points in the future\r\n\r\nDisadvantages\r\n\r\n  * Requires waaay more work... 😞\r\n\r\nDepends what you want to do.","created_at":"2018-06-26T14:54:28Z","updated_at":"2018-06-26T14:54:29Z","html_url":"https://github.com/ef-carbon/dom/pull/22#discussion_r198177673","pull_request_url":"https://api.github.com/repos/ef-carbon/dom/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ef-carbon/dom/pulls/comments/198177673"},"html":{"href":"https://github.com/ef-carbon/dom/pull/22#discussion_r198177673"},"pull_request":{"href":"https://api.github.com/repos/ef-carbon/dom/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/ef-carbon/dom/pulls/22","id":197123923,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTIzOTIz","html_url":"https://github.com/ef-carbon/dom/pull/22","diff_url":"https://github.com/ef-carbon/dom/pull/22.diff","patch_url":"https://github.com/ef-carbon/dom/pull/22.patch","issue_url":"https://api.github.com/repos/ef-carbon/dom/issues/22","number":22,"state":"open","locked":false,"title":"feat(audio): accept optional text","user":{"login":"gcottrell1","id":30590984,"node_id":"MDQ6VXNlcjMwNTkwOTg0","avatar_url":"https://avatars1.githubusercontent.com/u/30590984?v=4","gravatar_id":"","url":"https://api.github.com/users/gcottrell1","html_url":"https://github.com/gcottrell1","followers_url":"https://api.github.com/users/gcottrell1/followers","following_url":"https://api.github.com/users/gcottrell1/following{/other_user}","gists_url":"https://api.github.com/users/gcottrell1/gists{/gist_id}","starred_url":"https://api.github.com/users/gcottrell1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcottrell1/subscriptions","organizations_url":"https://api.github.com/users/gcottrell1/orgs","repos_url":"https://api.github.com/users/gcottrell1/repos","events_url":"https://api.github.com/users/gcottrell1/events{/privacy}","received_events_url":"https://api.github.com/users/gcottrell1/received_events","type":"User","site_admin":false},"body":"allows audio to accept an optional text property that conforms to `INodeTextOptions`","created_at":"2018-06-25T14:04:01Z","updated_at":"2018-06-26T14:54:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04e553b498917c2215cf92151a8dd6df998e5dbf","assignee":{"login":"gcottrell1","id":30590984,"node_id":"MDQ6VXNlcjMwNTkwOTg0","avatar_url":"https://avatars1.githubusercontent.com/u/30590984?v=4","gravatar_id":"","url":"https://api.github.com/users/gcottrell1","html_url":"https://github.com/gcottrell1","followers_url":"https://api.github.com/users/gcottrell1/followers","following_url":"https://api.github.com/users/gcottrell1/following{/other_user}","gists_url":"https://api.github.com/users/gcottrell1/gists{/gist_id}","starred_url":"https://api.github.com/users/gcottrell1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcottrell1/subscriptions","organizations_url":"https://api.github.com/users/gcottrell1/orgs","repos_url":"https://api.github.com/users/gcottrell1/repos","events_url":"https://api.github.com/users/gcottrell1/events{/privacy}","received_events_url":"https://api.github.com/users/gcottrell1/received_events","type":"User","site_admin":false},"assignees":[{"login":"gcottrell1","id":30590984,"node_id":"MDQ6VXNlcjMwNTkwOTg0","avatar_url":"https://avatars1.githubusercontent.com/u/30590984?v=4","gravatar_id":"","url":"https://api.github.com/users/gcottrell1","html_url":"https://github.com/gcottrell1","followers_url":"https://api.github.com/users/gcottrell1/followers","following_url":"https://api.github.com/users/gcottrell1/following{/other_user}","gists_url":"https://api.github.com/users/gcottrell1/gists{/gist_id}","starred_url":"https://api.github.com/users/gcottrell1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcottrell1/subscriptions","organizations_url":"https://api.github.com/users/gcottrell1/orgs","repos_url":"https://api.github.com/users/gcottrell1/repos","events_url":"https://api.github.com/users/gcottrell1/events{/privacy}","received_events_url":"https://api.github.com/users/gcottrell1/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mattetre","id":1724838,"node_id":"MDQ6VXNlcjE3MjQ4Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1724838?v=4","gravatar_id":"","url":"https://api.github.com/users/mattetre","html_url":"https://github.com/mattetre","followers_url":"https://api.github.com/users/mattetre/followers","following_url":"https://api.github.com/users/mattetre/following{/other_user}","gists_url":"https://api.github.com/users/mattetre/gists{/gist_id}","starred_url":"https://api.github.com/users/mattetre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattetre/subscriptions","organizations_url":"https://api.github.com/users/mattetre/orgs","repos_url":"https://api.github.com/users/mattetre/repos","events_url":"https://api.github.com/users/mattetre/events{/privacy}","received_events_url":"https://api.github.com/users/mattetre/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ef-carbon/dom/pulls/22/commits","review_comments_url":"https://api.github.com/repos/ef-carbon/dom/pulls/22/comments","review_comment_url":"https://api.github.com/repos/ef-carbon/dom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ef-carbon/dom/issues/22/comments","statuses_url":"https://api.github.com/repos/ef-carbon/dom/statuses/c43d68ddb49acf7c104c69bbd3858a952a64d2dd","head":{"label":"ef-carbon:text-audio-component","ref":"text-audio-component","sha":"c43d68ddb49acf7c104c69bbd3858a952a64d2dd","user":{"login":"ef-carbon","id":34236648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjM2NjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/34236648?v=4","gravatar_id":"","url":"https://api.github.com/users/ef-carbon","html_url":"https://github.com/ef-carbon","followers_url":"https://api.github.com/users/ef-carbon/followers","following_url":"https://api.github.com/users/ef-carbon/following{/other_user}","gists_url":"https://api.github.com/users/ef-carbon/gists{/gist_id}","starred_url":"https://api.github.com/users/ef-carbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ef-carbon/subscriptions","organizations_url":"https://api.github.com/users/ef-carbon/orgs","repos_url":"https://api.github.com/users/ef-carbon/repos","events_url":"https://api.github.com/users/ef-carbon/events{/privacy}","received_events_url":"https://api.github.com/users/ef-carbon/received_events","type":"Organization","site_admin":false},"repo":{"id":118615863,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2MTU4NjM=","name":"dom","full_name":"ef-carbon/dom","owner":{"login":"ef-carbon","id":34236648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjM2NjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/34236648?v=4","gravatar_id":"","url":"https://api.github.com/users/ef-carbon","html_url":"https://github.com/ef-carbon","followers_url":"https://api.github.com/users/ef-carbon/followers","following_url":"https://api.github.com/users/ef-carbon/following{/other_user}","gists_url":"https://api.github.com/users/ef-carbon/gists{/gist_id}","starred_url":"https://api.github.com/users/ef-carbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ef-carbon/subscriptions","organizations_url":"https://api.github.com/users/ef-carbon/orgs","repos_url":"https://api.github.com/users/ef-carbon/repos","events_url":"https://api.github.com/users/ef-carbon/events{/privacy}","received_events_url":"https://api.github.com/users/ef-carbon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ef-carbon/dom","description":"A TypeScript representation of a simple Document Object Model","fork":false,"url":"https://api.github.com/repos/ef-carbon/dom","forks_url":"https://api.github.com/repos/ef-carbon/dom/forks","keys_url":"https://api.github.com/repos/ef-carbon/dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ef-carbon/dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ef-carbon/dom/teams","hooks_url":"https://api.github.com/repos/ef-carbon/dom/hooks","issue_events_url":"https://api.github.com/repos/ef-carbon/dom/issues/events{/number}","events_url":"https://api.github.com/repos/ef-carbon/dom/events","assignees_url":"https://api.github.com/repos/ef-carbon/dom/assignees{/user}","branches_url":"https://api.github.com/repos/ef-carbon/dom/branches{/branch}","tags_url":"https://api.github.com/repos/ef-carbon/dom/tags","blobs_url":"https://api.github.com/repos/ef-carbon/dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ef-carbon/dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ef-carbon/dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/ef-carbon/dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ef-carbon/dom/statuses/{sha}","languages_url":"https://api.github.com/repos/ef-carbon/dom/languages","stargazers_url":"https://api.github.com/repos/ef-carbon/dom/stargazers","contributors_url":"https://api.github.com/repos/ef-carbon/dom/contributors","subscribers_url":"https://api.github.com/repos/ef-carbon/dom/subscribers","subscription_url":"https://api.github.com/repos/ef-carbon/dom/subscription","commits_url":"https://api.github.com/repos/ef-carbon/dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/ef-carbon/dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/ef-carbon/dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/ef-carbon/dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/ef-carbon/dom/contents/{+path}","compare_url":"https://api.github.com/repos/ef-carbon/dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ef-carbon/dom/merges","archive_url":"https://api.github.com/repos/ef-carbon/dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ef-carbon/dom/downloads","issues_url":"https://api.github.com/repos/ef-carbon/dom/issues{/number}","pulls_url":"https://api.github.com/repos/ef-carbon/dom/pulls{/number}","milestones_url":"https://api.github.com/repos/ef-carbon/dom/milestones{/number}","notifications_url":"https://api.github.com/repos/ef-carbon/dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ef-carbon/dom/labels{/name}","releases_url":"https://api.github.com/repos/ef-carbon/dom/releases{/id}","deployments_url":"https://api.github.com/repos/ef-carbon/dom/deployments","created_at":"2018-01-23T13:43:04Z","updated_at":"2018-06-21T13:34:02Z","pushed_at":"2018-06-25T14:04:02Z","git_url":"git://github.com/ef-carbon/dom.git","ssh_url":"git@github.com:ef-carbon/dom.git","clone_url":"https://github.com/ef-carbon/dom.git","svn_url":"https://github.com/ef-carbon/dom","homepage":"https://ef-carbon.github.io/dom/","size":895,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ef-carbon:master","ref":"master","sha":"c489e2c5d2b32e1b28caf5906a45bf68a791aaad","user":{"login":"ef-carbon","id":34236648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjM2NjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/34236648?v=4","gravatar_id":"","url":"https://api.github.com/users/ef-carbon","html_url":"https://github.com/ef-carbon","followers_url":"https://api.github.com/users/ef-carbon/followers","following_url":"https://api.github.com/users/ef-carbon/following{/other_user}","gists_url":"https://api.github.com/users/ef-carbon/gists{/gist_id}","starred_url":"https://api.github.com/users/ef-carbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ef-carbon/subscriptions","organizations_url":"https://api.github.com/users/ef-carbon/orgs","repos_url":"https://api.github.com/users/ef-carbon/repos","events_url":"https://api.github.com/users/ef-carbon/events{/privacy}","received_events_url":"https://api.github.com/users/ef-carbon/received_events","type":"Organization","site_admin":false},"repo":{"id":118615863,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2MTU4NjM=","name":"dom","full_name":"ef-carbon/dom","owner":{"login":"ef-carbon","id":34236648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjM2NjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/34236648?v=4","gravatar_id":"","url":"https://api.github.com/users/ef-carbon","html_url":"https://github.com/ef-carbon","followers_url":"https://api.github.com/users/ef-carbon/followers","following_url":"https://api.github.com/users/ef-carbon/following{/other_user}","gists_url":"https://api.github.com/users/ef-carbon/gists{/gist_id}","starred_url":"https://api.github.com/users/ef-carbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ef-carbon/subscriptions","organizations_url":"https://api.github.com/users/ef-carbon/orgs","repos_url":"https://api.github.com/users/ef-carbon/repos","events_url":"https://api.github.com/users/ef-carbon/events{/privacy}","received_events_url":"https://api.github.com/users/ef-carbon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ef-carbon/dom","description":"A TypeScript representation of a simple Document Object Model","fork":false,"url":"https://api.github.com/repos/ef-carbon/dom","forks_url":"https://api.github.com/repos/ef-carbon/dom/forks","keys_url":"https://api.github.com/repos/ef-carbon/dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ef-carbon/dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ef-carbon/dom/teams","hooks_url":"https://api.github.com/repos/ef-carbon/dom/hooks","issue_events_url":"https://api.github.com/repos/ef-carbon/dom/issues/events{/number}","events_url":"https://api.github.com/repos/ef-carbon/dom/events","assignees_url":"https://api.github.com/repos/ef-carbon/dom/assignees{/user}","branches_url":"https://api.github.com/repos/ef-carbon/dom/branches{/branch}","tags_url":"https://api.github.com/repos/ef-carbon/dom/tags","blobs_url":"https://api.github.com/repos/ef-carbon/dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ef-carbon/dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ef-carbon/dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/ef-carbon/dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ef-carbon/dom/statuses/{sha}","languages_url":"https://api.github.com/repos/ef-carbon/dom/languages","stargazers_url":"https://api.github.com/repos/ef-carbon/dom/stargazers","contributors_url":"https://api.github.com/repos/ef-carbon/dom/contributors","subscribers_url":"https://api.github.com/repos/ef-carbon/dom/subscribers","subscription_url":"https://api.github.com/repos/ef-carbon/dom/subscription","commits_url":"https://api.github.com/repos/ef-carbon/dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/ef-carbon/dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/ef-carbon/dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/ef-carbon/dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/ef-carbon/dom/contents/{+path}","compare_url":"https://api.github.com/repos/ef-carbon/dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ef-carbon/dom/merges","archive_url":"https://api.github.com/repos/ef-carbon/dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ef-carbon/dom/downloads","issues_url":"https://api.github.com/repos/ef-carbon/dom/issues{/number}","pulls_url":"https://api.github.com/repos/ef-carbon/dom/pulls{/number}","milestones_url":"https://api.github.com/repos/ef-carbon/dom/milestones{/number}","notifications_url":"https://api.github.com/repos/ef-carbon/dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ef-carbon/dom/labels{/name}","releases_url":"https://api.github.com/repos/ef-carbon/dom/releases{/id}","deployments_url":"https://api.github.com/repos/ef-carbon/dom/deployments","created_at":"2018-01-23T13:43:04Z","updated_at":"2018-06-21T13:34:02Z","pushed_at":"2018-06-25T14:04:02Z","git_url":"git://github.com/ef-carbon/dom.git","ssh_url":"git@github.com:ef-carbon/dom.git","clone_url":"https://github.com/ef-carbon/dom.git","svn_url":"https://github.com/ef-carbon/dom","homepage":"https://ef-carbon.github.io/dom/","size":895,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ef-carbon/dom/pulls/22"},"html":{"href":"https://github.com/ef-carbon/dom/pull/22"},"issue":{"href":"https://api.github.com/repos/ef-carbon/dom/issues/22"},"comments":{"href":"https://api.github.com/repos/ef-carbon/dom/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/ef-carbon/dom/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/ef-carbon/dom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ef-carbon/dom/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/ef-carbon/dom/statuses/c43d68ddb49acf7c104c69bbd3858a952a64d2dd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mattyclarkson"}}