{"action":"created","comment":{"url":"https://api.github.com/repos/uclouvain/osis/pulls/comments/231869633","pull_request_review_id":172933905,"id":231869633,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTg2OTYzMw==","diff_hunk":"@@ -52,12 +52,19 @@ class PersonAdmin(SerializableModelAdmin):\n     list_filter = ('gender', 'language')\n \n \n+class EmployeeManager(SerializableModelManager):\n+    def get_queryset(self):\n+        return super().get_queryset().filter(employee=True).order_by(\"last_name\", \"first_name\")\n+\n+\n class Person(SerializableModel):\n     GENDER_CHOICES = (\n         ('F', _('female')),\n         ('M', _('male')),\n         ('U', _('unknown')))\n \n+    employees = EmployeeManager()\n+","path":"base/models/person.py","position":25,"original_position":25,"commit_id":"9eac3968a42663d635cb772299a9a2143a035196","original_commit_id":"9eac3968a42663d635cb772299a9a2143a035196","user":{"login":"albrugnetti","id":19836473,"node_id":"MDQ6VXNlcjE5ODM2NDcz","avatar_url":"https://avatars3.githubusercontent.com/u/19836473?v=4","gravatar_id":"","url":"https://api.github.com/users/albrugnetti","html_url":"https://github.com/albrugnetti","followers_url":"https://api.github.com/users/albrugnetti/followers","following_url":"https://api.github.com/users/albrugnetti/following{/other_user}","gists_url":"https://api.github.com/users/albrugnetti/gists{/gist_id}","starred_url":"https://api.github.com/users/albrugnetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albrugnetti/subscriptions","organizations_url":"https://api.github.com/users/albrugnetti/orgs","repos_url":"https://api.github.com/users/albrugnetti/repos","events_url":"https://api.github.com/users/albrugnetti/events{/privacy}","received_events_url":"https://api.github.com/users/albrugnetti/received_events","type":"User","site_admin":false},"body":"Il faut absolument redéfinir objects = <Manager de Serializable>\r\n/!\\ https://docs.djangoproject.com/fr/2.1/topics/db/managers/#django.db.models.Model._default_manager","created_at":"2018-11-08T12:32:30Z","updated_at":"2018-11-08T12:32:34Z","html_url":"https://github.com/uclouvain/osis/pull/4479#discussion_r231869633","pull_request_url":"https://api.github.com/repos/uclouvain/osis/pulls/4479","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/uclouvain/osis/pulls/comments/231869633"},"html":{"href":"https://github.com/uclouvain/osis/pull/4479#discussion_r231869633"},"pull_request":{"href":"https://api.github.com/repos/uclouvain/osis/pulls/4479"}}},"pull_request":{"url":"https://api.github.com/repos/uclouvain/osis/pulls/4479","id":228732626,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzMyNjI2","html_url":"https://github.com/uclouvain/osis/pull/4479","diff_url":"https://github.com/uclouvain/osis/pull/4479.diff","patch_url":"https://github.com/uclouvain/osis/pull/4479.patch","issue_url":"https://api.github.com/repos/uclouvain/osis/issues/4479","number":4479,"state":"open","locked":false,"title":"OSIS-2177 Modification pour passer de Tutor à Person dans le formulai…","user":{"login":"chfivet","id":15813887,"node_id":"MDQ6VXNlcjE1ODEzODg3","avatar_url":"https://avatars3.githubusercontent.com/u/15813887?v=4","gravatar_id":"","url":"https://api.github.com/users/chfivet","html_url":"https://github.com/chfivet","followers_url":"https://api.github.com/users/chfivet/followers","following_url":"https://api.github.com/users/chfivet/following{/other_user}","gists_url":"https://api.github.com/users/chfivet/gists{/gist_id}","starred_url":"https://api.github.com/users/chfivet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfivet/subscriptions","organizations_url":"https://api.github.com/users/chfivet/orgs","repos_url":"https://api.github.com/users/chfivet/repos","events_url":"https://api.github.com/users/chfivet/events{/privacy}","received_events_url":"https://api.github.com/users/chfivet/received_events","type":"User","site_admin":false},"body":"…re d'ajouts d'attribution\r\n\r\nRéférence Jira : OSIS-2177\r\n\r\nVérifier les points suivants : \r\n- [ ] Ouvrir une release task Jira si le ticket génère une tâche pour la release : \r\n    - modification de configuration\r\n    - table à synchroniser en entier, etc.\r\n- [ ] Uniformiser les modèles osis-portal avec les changements effectués dans osis si nécessaire\r\n- [ ] Permissions et droits d’accès mettre à jour la documentation si : \r\n    - on rajoute/modifie une permission\r\n    - on rajoute/modifie un groupe d’utilisateurs, etc.\r\n","created_at":"2018-11-06T15:32:25Z","updated_at":"2018-11-08T12:32:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22aa25bee8558eb864c188a36094f1a67d25d277","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uclouvain/osis/pulls/4479/commits","review_comments_url":"https://api.github.com/repos/uclouvain/osis/pulls/4479/comments","review_comment_url":"https://api.github.com/repos/uclouvain/osis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uclouvain/osis/issues/4479/comments","statuses_url":"https://api.github.com/repos/uclouvain/osis/statuses/9eac3968a42663d635cb772299a9a2143a035196","head":{"label":"uclouvain:OSIS-2177","ref":"OSIS-2177","sha":"9eac3968a42663d635cb772299a9a2143a035196","user":{"login":"uclouvain","id":9862060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NjIwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/9862060?v=4","gravatar_id":"","url":"https://api.github.com/users/uclouvain","html_url":"https://github.com/uclouvain","followers_url":"https://api.github.com/users/uclouvain/followers","following_url":"https://api.github.com/users/uclouvain/following{/other_user}","gists_url":"https://api.github.com/users/uclouvain/gists{/gist_id}","starred_url":"https://api.github.com/users/uclouvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclouvain/subscriptions","organizations_url":"https://api.github.com/users/uclouvain/orgs","repos_url":"https://api.github.com/users/uclouvain/repos","events_url":"https://api.github.com/users/uclouvain/events{/privacy}","received_events_url":"https://api.github.com/users/uclouvain/received_events","type":"Organization","site_admin":false},"repo":{"id":37489388,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ4OTM4OA==","name":"osis","full_name":"uclouvain/osis","private":false,"owner":{"login":"uclouvain","id":9862060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NjIwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/9862060?v=4","gravatar_id":"","url":"https://api.github.com/users/uclouvain","html_url":"https://github.com/uclouvain","followers_url":"https://api.github.com/users/uclouvain/followers","following_url":"https://api.github.com/users/uclouvain/following{/other_user}","gists_url":"https://api.github.com/users/uclouvain/gists{/gist_id}","starred_url":"https://api.github.com/users/uclouvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclouvain/subscriptions","organizations_url":"https://api.github.com/users/uclouvain/orgs","repos_url":"https://api.github.com/users/uclouvain/repos","events_url":"https://api.github.com/users/uclouvain/events{/privacy}","received_events_url":"https://api.github.com/users/uclouvain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uclouvain/osis","description":"Open Student Information System Backoffice","fork":false,"url":"https://api.github.com/repos/uclouvain/osis","forks_url":"https://api.github.com/repos/uclouvain/osis/forks","keys_url":"https://api.github.com/repos/uclouvain/osis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uclouvain/osis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uclouvain/osis/teams","hooks_url":"https://api.github.com/repos/uclouvain/osis/hooks","issue_events_url":"https://api.github.com/repos/uclouvain/osis/issues/events{/number}","events_url":"https://api.github.com/repos/uclouvain/osis/events","assignees_url":"https://api.github.com/repos/uclouvain/osis/assignees{/user}","branches_url":"https://api.github.com/repos/uclouvain/osis/branches{/branch}","tags_url":"https://api.github.com/repos/uclouvain/osis/tags","blobs_url":"https://api.github.com/repos/uclouvain/osis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uclouvain/osis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uclouvain/osis/git/refs{/sha}","trees_url":"https://api.github.com/repos/uclouvain/osis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uclouvain/osis/statuses/{sha}","languages_url":"https://api.github.com/repos/uclouvain/osis/languages","stargazers_url":"https://api.github.com/repos/uclouvain/osis/stargazers","contributors_url":"https://api.github.com/repos/uclouvain/osis/contributors","subscribers_url":"https://api.github.com/repos/uclouvain/osis/subscribers","subscription_url":"https://api.github.com/repos/uclouvain/osis/subscription","commits_url":"https://api.github.com/repos/uclouvain/osis/commits{/sha}","git_commits_url":"https://api.github.com/repos/uclouvain/osis/git/commits{/sha}","comments_url":"https://api.github.com/repos/uclouvain/osis/comments{/number}","issue_comment_url":"https://api.github.com/repos/uclouvain/osis/issues/comments{/number}","contents_url":"https://api.github.com/repos/uclouvain/osis/contents/{+path}","compare_url":"https://api.github.com/repos/uclouvain/osis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uclouvain/osis/merges","archive_url":"https://api.github.com/repos/uclouvain/osis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uclouvain/osis/downloads","issues_url":"https://api.github.com/repos/uclouvain/osis/issues{/number}","pulls_url":"https://api.github.com/repos/uclouvain/osis/pulls{/number}","milestones_url":"https://api.github.com/repos/uclouvain/osis/milestones{/number}","notifications_url":"https://api.github.com/repos/uclouvain/osis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uclouvain/osis/labels{/name}","releases_url":"https://api.github.com/repos/uclouvain/osis/releases{/id}","deployments_url":"https://api.github.com/repos/uclouvain/osis/deployments","created_at":"2015-06-15T20:25:28Z","updated_at":"2018-11-08T12:22:02Z","pushed_at":"2018-11-08T12:22:02Z","git_url":"git://github.com/uclouvain/osis.git","ssh_url":"git@github.com:uclouvain/osis.git","clone_url":"https://github.com/uclouvain/osis.git","svn_url":"https://github.com/uclouvain/osis","homepage":"http://uclouvain.github.io/osis","size":65625,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":18,"open_issues":16,"watchers":38,"default_branch":"dev"}},"base":{"label":"uclouvain:dev","ref":"dev","sha":"ccce22421fbb90ab00593f7f409f8820b2a98696","user":{"login":"uclouvain","id":9862060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NjIwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/9862060?v=4","gravatar_id":"","url":"https://api.github.com/users/uclouvain","html_url":"https://github.com/uclouvain","followers_url":"https://api.github.com/users/uclouvain/followers","following_url":"https://api.github.com/users/uclouvain/following{/other_user}","gists_url":"https://api.github.com/users/uclouvain/gists{/gist_id}","starred_url":"https://api.github.com/users/uclouvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclouvain/subscriptions","organizations_url":"https://api.github.com/users/uclouvain/orgs","repos_url":"https://api.github.com/users/uclouvain/repos","events_url":"https://api.github.com/users/uclouvain/events{/privacy}","received_events_url":"https://api.github.com/users/uclouvain/received_events","type":"Organization","site_admin":false},"repo":{"id":37489388,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ4OTM4OA==","name":"osis","full_name":"uclouvain/osis","private":false,"owner":{"login":"uclouvain","id":9862060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NjIwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/9862060?v=4","gravatar_id":"","url":"https://api.github.com/users/uclouvain","html_url":"https://github.com/uclouvain","followers_url":"https://api.github.com/users/uclouvain/followers","following_url":"https://api.github.com/users/uclouvain/following{/other_user}","gists_url":"https://api.github.com/users/uclouvain/gists{/gist_id}","starred_url":"https://api.github.com/users/uclouvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclouvain/subscriptions","organizations_url":"https://api.github.com/users/uclouvain/orgs","repos_url":"https://api.github.com/users/uclouvain/repos","events_url":"https://api.github.com/users/uclouvain/events{/privacy}","received_events_url":"https://api.github.com/users/uclouvain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uclouvain/osis","description":"Open Student Information System Backoffice","fork":false,"url":"https://api.github.com/repos/uclouvain/osis","forks_url":"https://api.github.com/repos/uclouvain/osis/forks","keys_url":"https://api.github.com/repos/uclouvain/osis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uclouvain/osis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uclouvain/osis/teams","hooks_url":"https://api.github.com/repos/uclouvain/osis/hooks","issue_events_url":"https://api.github.com/repos/uclouvain/osis/issues/events{/number}","events_url":"https://api.github.com/repos/uclouvain/osis/events","assignees_url":"https://api.github.com/repos/uclouvain/osis/assignees{/user}","branches_url":"https://api.github.com/repos/uclouvain/osis/branches{/branch}","tags_url":"https://api.github.com/repos/uclouvain/osis/tags","blobs_url":"https://api.github.com/repos/uclouvain/osis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uclouvain/osis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uclouvain/osis/git/refs{/sha}","trees_url":"https://api.github.com/repos/uclouvain/osis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uclouvain/osis/statuses/{sha}","languages_url":"https://api.github.com/repos/uclouvain/osis/languages","stargazers_url":"https://api.github.com/repos/uclouvain/osis/stargazers","contributors_url":"https://api.github.com/repos/uclouvain/osis/contributors","subscribers_url":"https://api.github.com/repos/uclouvain/osis/subscribers","subscription_url":"https://api.github.com/repos/uclouvain/osis/subscription","commits_url":"https://api.github.com/repos/uclouvain/osis/commits{/sha}","git_commits_url":"https://api.github.com/repos/uclouvain/osis/git/commits{/sha}","comments_url":"https://api.github.com/repos/uclouvain/osis/comments{/number}","issue_comment_url":"https://api.github.com/repos/uclouvain/osis/issues/comments{/number}","contents_url":"https://api.github.com/repos/uclouvain/osis/contents/{+path}","compare_url":"https://api.github.com/repos/uclouvain/osis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uclouvain/osis/merges","archive_url":"https://api.github.com/repos/uclouvain/osis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uclouvain/osis/downloads","issues_url":"https://api.github.com/repos/uclouvain/osis/issues{/number}","pulls_url":"https://api.github.com/repos/uclouvain/osis/pulls{/number}","milestones_url":"https://api.github.com/repos/uclouvain/osis/milestones{/number}","notifications_url":"https://api.github.com/repos/uclouvain/osis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uclouvain/osis/labels{/name}","releases_url":"https://api.github.com/repos/uclouvain/osis/releases{/id}","deployments_url":"https://api.github.com/repos/uclouvain/osis/deployments","created_at":"2015-06-15T20:25:28Z","updated_at":"2018-11-08T12:22:02Z","pushed_at":"2018-11-08T12:22:02Z","git_url":"git://github.com/uclouvain/osis.git","ssh_url":"git@github.com:uclouvain/osis.git","clone_url":"https://github.com/uclouvain/osis.git","svn_url":"https://github.com/uclouvain/osis","homepage":"http://uclouvain.github.io/osis","size":65625,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":18,"open_issues":16,"watchers":38,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/uclouvain/osis/pulls/4479"},"html":{"href":"https://github.com/uclouvain/osis/pull/4479"},"issue":{"href":"https://api.github.com/repos/uclouvain/osis/issues/4479"},"comments":{"href":"https://api.github.com/repos/uclouvain/osis/issues/4479/comments"},"review_comments":{"href":"https://api.github.com/repos/uclouvain/osis/pulls/4479/comments"},"review_comment":{"href":"https://api.github.com/repos/uclouvain/osis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uclouvain/osis/pulls/4479/commits"},"statuses":{"href":"https://api.github.com/repos/uclouvain/osis/statuses/9eac3968a42663d635cb772299a9a2143a035196"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"albrugnetti"}}