{"action":"created","comment":{"url":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls/comments/211054446","pull_request_review_id":147407996,"id":211054446,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA1NDQ0Ng==","diff_hunk":"@@ -6,19 +6,46 @@ def __init__(self):\n     self.size = 0\n \n   def insert(self, value):\n-    pass\n+    self.storage.append(value)\n+    self.size += 1\n+    self._bubble_up(self.size)\n \n   def delete(self):\n-    pass\n+    max = self.storage[1] #store max so we can return it\n+    #replace first storage el w last el in the heap\n+    if len(self.storage) == 1:","path":"heap/heap.py","position":13,"original_position":13,"commit_id":"860bd8c639e09db7938bafbf058348f9439466a4","original_commit_id":"860bd8c639e09db7938bafbf058348f9439466a4","user":{"login":"rawalpunit","id":19376080,"node_id":"MDQ6VXNlcjE5Mzc2MDgw","avatar_url":"https://avatars2.githubusercontent.com/u/19376080?v=4","gravatar_id":"","url":"https://api.github.com/users/rawalpunit","html_url":"https://github.com/rawalpunit","followers_url":"https://api.github.com/users/rawalpunit/followers","following_url":"https://api.github.com/users/rawalpunit/following{/other_user}","gists_url":"https://api.github.com/users/rawalpunit/gists{/gist_id}","starred_url":"https://api.github.com/users/rawalpunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawalpunit/subscriptions","organizations_url":"https://api.github.com/users/rawalpunit/orgs","repos_url":"https://api.github.com/users/rawalpunit/repos","events_url":"https://api.github.com/users/rawalpunit/events{/privacy}","received_events_url":"https://api.github.com/users/rawalpunit/received_events","type":"User","site_admin":false},"body":"comments need to spell stuff out clearly..thats the point of comments...what is 'el' here...element?","created_at":"2018-08-17T23:40:56Z","updated_at":"2018-08-17T23:46:20Z","html_url":"https://github.com/LambdaSchool/Data-Structures/pull/106#discussion_r211054446","pull_request_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls/106","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls/comments/211054446"},"html":{"href":"https://github.com/LambdaSchool/Data-Structures/pull/106#discussion_r211054446"},"pull_request":{"href":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls/106","id":201772030,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzcyMDMw","html_url":"https://github.com/LambdaSchool/Data-Structures/pull/106","diff_url":"https://github.com/LambdaSchool/Data-Structures/pull/106.diff","patch_url":"https://github.com/LambdaSchool/Data-Structures/pull/106.patch","issue_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/issues/106","number":106,"state":"open","locked":false,"title":"Sagar Desai","user":{"login":"sagardesai90","id":24217185,"node_id":"MDQ6VXNlcjI0MjE3MTg1","avatar_url":"https://avatars3.githubusercontent.com/u/24217185?v=4","gravatar_id":"","url":"https://api.github.com/users/sagardesai90","html_url":"https://github.com/sagardesai90","followers_url":"https://api.github.com/users/sagardesai90/followers","following_url":"https://api.github.com/users/sagardesai90/following{/other_user}","gists_url":"https://api.github.com/users/sagardesai90/gists{/gist_id}","starred_url":"https://api.github.com/users/sagardesai90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagardesai90/subscriptions","organizations_url":"https://api.github.com/users/sagardesai90/orgs","repos_url":"https://api.github.com/users/sagardesai90/repos","events_url":"https://api.github.com/users/sagardesai90/events{/privacy}","received_events_url":"https://api.github.com/users/sagardesai90/received_events","type":"User","site_admin":false},"body":"- [x] linked list\r\n\r\n- [x] queue\r\n\r\n- [x] binary search trees\r\n\r\n- [ ] heaps\r\n\r\n- [ ] doubly linked lists","created_at":"2018-07-16T21:59:50Z","updated_at":"2018-08-17T23:46:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d825a160fa915bafa1418feffe6d49a683f30d0d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls/106/commits","review_comments_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls/106/comments","review_comment_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/issues/106/comments","statuses_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/statuses/860bd8c639e09db7938bafbf058348f9439466a4","head":{"label":"sagardesai90:master","ref":"master","sha":"860bd8c639e09db7938bafbf058348f9439466a4","user":{"login":"sagardesai90","id":24217185,"node_id":"MDQ6VXNlcjI0MjE3MTg1","avatar_url":"https://avatars3.githubusercontent.com/u/24217185?v=4","gravatar_id":"","url":"https://api.github.com/users/sagardesai90","html_url":"https://github.com/sagardesai90","followers_url":"https://api.github.com/users/sagardesai90/followers","following_url":"https://api.github.com/users/sagardesai90/following{/other_user}","gists_url":"https://api.github.com/users/sagardesai90/gists{/gist_id}","starred_url":"https://api.github.com/users/sagardesai90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagardesai90/subscriptions","organizations_url":"https://api.github.com/users/sagardesai90/orgs","repos_url":"https://api.github.com/users/sagardesai90/repos","events_url":"https://api.github.com/users/sagardesai90/events{/privacy}","received_events_url":"https://api.github.com/users/sagardesai90/received_events","type":"User","site_admin":false},"repo":{"id":141168217,"node_id":"MDEwOlJlcG9zaXRvcnkxNDExNjgyMTc=","name":"Data-Structures","full_name":"sagardesai90/Data-Structures","owner":{"login":"sagardesai90","id":24217185,"node_id":"MDQ6VXNlcjI0MjE3MTg1","avatar_url":"https://avatars3.githubusercontent.com/u/24217185?v=4","gravatar_id":"","url":"https://api.github.com/users/sagardesai90","html_url":"https://github.com/sagardesai90","followers_url":"https://api.github.com/users/sagardesai90/followers","following_url":"https://api.github.com/users/sagardesai90/following{/other_user}","gists_url":"https://api.github.com/users/sagardesai90/gists{/gist_id}","starred_url":"https://api.github.com/users/sagardesai90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagardesai90/subscriptions","organizations_url":"https://api.github.com/users/sagardesai90/orgs","repos_url":"https://api.github.com/users/sagardesai90/repos","events_url":"https://api.github.com/users/sagardesai90/events{/privacy}","received_events_url":"https://api.github.com/users/sagardesai90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sagardesai90/Data-Structures","description":null,"fork":true,"url":"https://api.github.com/repos/sagardesai90/Data-Structures","forks_url":"https://api.github.com/repos/sagardesai90/Data-Structures/forks","keys_url":"https://api.github.com/repos/sagardesai90/Data-Structures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sagardesai90/Data-Structures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sagardesai90/Data-Structures/teams","hooks_url":"https://api.github.com/repos/sagardesai90/Data-Structures/hooks","issue_events_url":"https://api.github.com/repos/sagardesai90/Data-Structures/issues/events{/number}","events_url":"https://api.github.com/repos/sagardesai90/Data-Structures/events","assignees_url":"https://api.github.com/repos/sagardesai90/Data-Structures/assignees{/user}","branches_url":"https://api.github.com/repos/sagardesai90/Data-Structures/branches{/branch}","tags_url":"https://api.github.com/repos/sagardesai90/Data-Structures/tags","blobs_url":"https://api.github.com/repos/sagardesai90/Data-Structures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sagardesai90/Data-Structures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sagardesai90/Data-Structures/git/refs{/sha}","trees_url":"https://api.github.com/repos/sagardesai90/Data-Structures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sagardesai90/Data-Structures/statuses/{sha}","languages_url":"https://api.github.com/repos/sagardesai90/Data-Structures/languages","stargazers_url":"https://api.github.com/repos/sagardesai90/Data-Structures/stargazers","contributors_url":"https://api.github.com/repos/sagardesai90/Data-Structures/contributors","subscribers_url":"https://api.github.com/repos/sagardesai90/Data-Structures/subscribers","subscription_url":"https://api.github.com/repos/sagardesai90/Data-Structures/subscription","commits_url":"https://api.github.com/repos/sagardesai90/Data-Structures/commits{/sha}","git_commits_url":"https://api.github.com/repos/sagardesai90/Data-Structures/git/commits{/sha}","comments_url":"https://api.github.com/repos/sagardesai90/Data-Structures/comments{/number}","issue_comment_url":"https://api.github.com/repos/sagardesai90/Data-Structures/issues/comments{/number}","contents_url":"https://api.github.com/repos/sagardesai90/Data-Structures/contents/{+path}","compare_url":"https://api.github.com/repos/sagardesai90/Data-Structures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sagardesai90/Data-Structures/merges","archive_url":"https://api.github.com/repos/sagardesai90/Data-Structures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sagardesai90/Data-Structures/downloads","issues_url":"https://api.github.com/repos/sagardesai90/Data-Structures/issues{/number}","pulls_url":"https://api.github.com/repos/sagardesai90/Data-Structures/pulls{/number}","milestones_url":"https://api.github.com/repos/sagardesai90/Data-Structures/milestones{/number}","notifications_url":"https://api.github.com/repos/sagardesai90/Data-Structures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sagardesai90/Data-Structures/labels{/name}","releases_url":"https://api.github.com/repos/sagardesai90/Data-Structures/releases{/id}","deployments_url":"https://api.github.com/repos/sagardesai90/Data-Structures/deployments","created_at":"2018-07-16T17:00:51Z","updated_at":"2018-07-18T18:36:12Z","pushed_at":"2018-07-18T18:36:10Z","git_url":"git://github.com/sagardesai90/Data-Structures.git","ssh_url":"git@github.com:sagardesai90/Data-Structures.git","clone_url":"https://github.com/sagardesai90/Data-Structures.git","svn_url":"https://github.com/sagardesai90/Data-Structures","homepage":null,"size":77,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LambdaSchool:master","ref":"master","sha":"009b2189bcd2902a3392c78c3c876c416c8f8f5f","user":{"login":"LambdaSchool","id":24780114,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NzgwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/24780114?v=4","gravatar_id":"","url":"https://api.github.com/users/LambdaSchool","html_url":"https://github.com/LambdaSchool","followers_url":"https://api.github.com/users/LambdaSchool/followers","following_url":"https://api.github.com/users/LambdaSchool/following{/other_user}","gists_url":"https://api.github.com/users/LambdaSchool/gists{/gist_id}","starred_url":"https://api.github.com/users/LambdaSchool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LambdaSchool/subscriptions","organizations_url":"https://api.github.com/users/LambdaSchool/orgs","repos_url":"https://api.github.com/users/LambdaSchool/repos","events_url":"https://api.github.com/users/LambdaSchool/events{/privacy}","received_events_url":"https://api.github.com/users/LambdaSchool/received_events","type":"Organization","site_admin":false},"repo":{"id":132027752,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjc3NTI=","name":"Data-Structures","full_name":"LambdaSchool/Data-Structures","owner":{"login":"LambdaSchool","id":24780114,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NzgwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/24780114?v=4","gravatar_id":"","url":"https://api.github.com/users/LambdaSchool","html_url":"https://github.com/LambdaSchool","followers_url":"https://api.github.com/users/LambdaSchool/followers","following_url":"https://api.github.com/users/LambdaSchool/following{/other_user}","gists_url":"https://api.github.com/users/LambdaSchool/gists{/gist_id}","starred_url":"https://api.github.com/users/LambdaSchool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LambdaSchool/subscriptions","organizations_url":"https://api.github.com/users/LambdaSchool/orgs","repos_url":"https://api.github.com/users/LambdaSchool/repos","events_url":"https://api.github.com/users/LambdaSchool/events{/privacy}","received_events_url":"https://api.github.com/users/LambdaSchool/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LambdaSchool/Data-Structures","description":null,"fork":false,"url":"https://api.github.com/repos/LambdaSchool/Data-Structures","forks_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/forks","keys_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/teams","hooks_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/hooks","issue_events_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/issues/events{/number}","events_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/events","assignees_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/assignees{/user}","branches_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/branches{/branch}","tags_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/tags","blobs_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/git/refs{/sha}","trees_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/statuses/{sha}","languages_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/languages","stargazers_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/stargazers","contributors_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/contributors","subscribers_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/subscribers","subscription_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/subscription","commits_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/commits{/sha}","git_commits_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/git/commits{/sha}","comments_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/comments{/number}","issue_comment_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/issues/comments{/number}","contents_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/contents/{+path}","compare_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/merges","archive_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/downloads","issues_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/issues{/number}","pulls_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls{/number}","milestones_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/milestones{/number}","notifications_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/labels{/name}","releases_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/releases{/id}","deployments_url":"https://api.github.com/repos/LambdaSchool/Data-Structures/deployments","created_at":"2018-05-03T17:22:09Z","updated_at":"2018-08-16T20:44:08Z","pushed_at":"2018-08-17T16:16:32Z","git_url":"git://github.com/LambdaSchool/Data-Structures.git","ssh_url":"git@github.com:LambdaSchool/Data-Structures.git","clone_url":"https://github.com/LambdaSchool/Data-Structures.git","svn_url":"https://github.com/LambdaSchool/Data-Structures","homepage":null,"size":75,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":146,"license":null,"forks":188,"open_issues":146,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls/106"},"html":{"href":"https://github.com/LambdaSchool/Data-Structures/pull/106"},"issue":{"href":"https://api.github.com/repos/LambdaSchool/Data-Structures/issues/106"},"comments":{"href":"https://api.github.com/repos/LambdaSchool/Data-Structures/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LambdaSchool/Data-Structures/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/LambdaSchool/Data-Structures/statuses/860bd8c639e09db7938bafbf058348f9439466a4"}},"author_association":"NONE"}}
{"actor":{"display_login":"rawalpunit"}}