{"action":"created","issue":{"url":"https://api.github.com/repos/skycoin/skywire/issues/100","repository_url":"https://api.github.com/repos/skycoin/skywire","labels_url":"https://api.github.com/repos/skycoin/skywire/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/skycoin/skywire/issues/100/comments","events_url":"https://api.github.com/repos/skycoin/skywire/issues/100/events","html_url":"https://github.com/skycoin/skywire/issues/100","id":343060715,"node_id":"MDU6SXNzdWUzNDMwNjA3MTU=","number":100,"title":"Logic error in verifyLogin function in Monitor.go (Low Priority)","user":{"login":"BigOokie","id":36015380,"node_id":"MDQ6VXNlcjM2MDE1Mzgw","avatar_url":"https://avatars0.githubusercontent.com/u/36015380?v=4","gravatar_id":"","url":"https://api.github.com/users/BigOokie","html_url":"https://github.com/BigOokie","followers_url":"https://api.github.com/users/BigOokie/followers","following_url":"https://api.github.com/users/BigOokie/following{/other_user}","gists_url":"https://api.github.com/users/BigOokie/gists{/gist_id}","starred_url":"https://api.github.com/users/BigOokie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigOokie/subscriptions","organizations_url":"https://api.github.com/users/BigOokie/orgs","repos_url":"https://api.github.com/users/BigOokie/repos","events_url":"https://api.github.com/users/BigOokie/events{/privacy}","received_events_url":"https://api.github.com/users/BigOokie/received_events","type":"User","site_admin":false},"labels":[{"id":608726933,"node_id":"MDU6TGFiZWw2MDg3MjY5MzM=","url":"https://api.github.com/repos/skycoin/skywire/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-20T10:44:14Z","updated_at":"2018-10-16T11:05:06Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The `verifyLogin` function within  `Monitor.go` appears to have a logic error whereby a session value is read into the variable `hash` however the `pass` variable is checked determine if it is `nil`. Suspect this should be a check of the `hash` variable instead.  \r\n\r\nSections of the associated code below - the variable `pass` is checked twice.\r\n\r\n```\r\nverifyLogin(w http.ResponseWriter, r *http.Request, checkDefaultPass bool) bool {\r\n\t... \r\n\tpass := sess.Get(\"user\")\r\n\tif pass == nil {...}\r\n\r\n\thash := sess.Get(\"pass\")\r\n\tif pass == nil {...}\r\n\t...\t\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/skycoin/skywire/issues/comments/430195673","html_url":"https://github.com/skycoin/skywire/issues/100#issuecomment-430195673","issue_url":"https://api.github.com/repos/skycoin/skywire/issues/100","id":430195673,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDE5NTY3Mw==","user":{"login":"BigOokie","id":36015380,"node_id":"MDQ6VXNlcjM2MDE1Mzgw","avatar_url":"https://avatars0.githubusercontent.com/u/36015380?v=4","gravatar_id":"","url":"https://api.github.com/users/BigOokie","html_url":"https://github.com/BigOokie","followers_url":"https://api.github.com/users/BigOokie/followers","following_url":"https://api.github.com/users/BigOokie/following{/other_user}","gists_url":"https://api.github.com/users/BigOokie/gists{/gist_id}","starred_url":"https://api.github.com/users/BigOokie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigOokie/subscriptions","organizations_url":"https://api.github.com/users/BigOokie/orgs","repos_url":"https://api.github.com/users/BigOokie/repos","events_url":"https://api.github.com/users/BigOokie/events{/privacy}","received_events_url":"https://api.github.com/users/BigOokie/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T11:05:06Z","updated_at":"2018-10-16T11:05:06Z","author_association":"CONTRIBUTOR","body":"Also note that the Manager Web UI appears to enforce its own length restrictions on the user password (must be between 4 and 20 characters)"}}
{"actor":{"display_login":"BigOokie"}}