{"action":"created","issue":{"url":"https://api.github.com/repos/skycoin/skycoin-lite/issues/9","repository_url":"https://api.github.com/repos/skycoin/skycoin-lite","labels_url":"https://api.github.com/repos/skycoin/skycoin-lite/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/skycoin/skycoin-lite/issues/9/comments","events_url":"https://api.github.com/repos/skycoin/skycoin-lite/issues/9/events","html_url":"https://github.com/skycoin/skycoin-lite/pull/9","id":325515253,"number":9,"title":"Add Skycoin as dependency","user":{"login":"Senyoret1","id":34079003,"avatar_url":"https://avatars0.githubusercontent.com/u/34079003?v=4","gravatar_id":"","url":"https://api.github.com/users/Senyoret1","html_url":"https://github.com/Senyoret1","followers_url":"https://api.github.com/users/Senyoret1/followers","following_url":"https://api.github.com/users/Senyoret1/following{/other_user}","gists_url":"https://api.github.com/users/Senyoret1/gists{/gist_id}","starred_url":"https://api.github.com/users/Senyoret1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Senyoret1/subscriptions","organizations_url":"https://api.github.com/users/Senyoret1/orgs","repos_url":"https://api.github.com/users/Senyoret1/repos","events_url":"https://api.github.com/users/Senyoret1/events{/privacy}","received_events_url":"https://api.github.com/users/Senyoret1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-23T01:15:56Z","updated_at":"2018-05-23T14:38:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/skycoin/skycoin-lite/pulls/9","html_url":"https://github.com/skycoin/skycoin-lite/pull/9","diff_url":"https://github.com/skycoin/skycoin-lite/pull/9.diff","patch_url":"https://github.com/skycoin/skycoin-lite/pull/9.patch"},"body":"This pr greatly simplifies the structure of the repository.\r\n\r\nPreviously, this repository was primarily composed of code copied from the Skycoin repository. Apparently it was done that way because the `github.com/skycoin/skycoin/src/util/logging` package of the Skycoin repo is incompatible with gopherjs, so it was necessary to manually modify the files and comment any line that used that package. This means that applying any change made in the Skycoin repo would require a lot of work.\r\n\r\nThis pr deletes all the code copied from the Skycoin repository and simply adds Skycoin as a vendored dependency using dep. To avoid compatibility problems with gopherjs, a file called `fix-skycoin-dependency.sh` was created, which replaces all the calls to the `github.com/skycoin/skycoin/src/util/logging` package with calls to the `log` package. The file can be executed by running `make fix-skycoin-dependency`. This means that it is now possible to apply changes made in the Skycoin repository simply by updating the dependencies with dep and then running `make fix-skycoin-dependency`, instead of having to modify code manually.\r\n\r\nAfter making these changes, the library was recompiled with gopher and tested in the web wallet. Everything seems to continue to work as before.\r\n\r\nThe other changes are that `make format` was used in the files, to solve the formating problems; some comments were added in the code and `readme.md` was updated with information about how to compile with gopherjs, what to do after updating the dependencies, how to format Go files, etc. As always, the texts in readme.md could have writing errors."},"comment":{"url":"https://api.github.com/repos/skycoin/skycoin-lite/issues/comments/391371772","html_url":"https://github.com/skycoin/skycoin-lite/pull/9#issuecomment-391371772","issue_url":"https://api.github.com/repos/skycoin/skycoin-lite/issues/9","id":391371772,"user":{"login":"gz-c","id":26845312,"avatar_url":"https://avatars0.githubusercontent.com/u/26845312?v=4","gravatar_id":"","url":"https://api.github.com/users/gz-c","html_url":"https://github.com/gz-c","followers_url":"https://api.github.com/users/gz-c/followers","following_url":"https://api.github.com/users/gz-c/following{/other_user}","gists_url":"https://api.github.com/users/gz-c/gists{/gist_id}","starred_url":"https://api.github.com/users/gz-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gz-c/subscriptions","organizations_url":"https://api.github.com/users/gz-c/orgs","repos_url":"https://api.github.com/users/gz-c/repos","events_url":"https://api.github.com/users/gz-c/events{/privacy}","received_events_url":"https://api.github.com/users/gz-c/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T14:38:52Z","updated_at":"2018-05-23T14:38:52Z","author_association":"MEMBER","body":"What is the problem with `github.com/skycoin/skycoin/src/util/logging`?\r\n\r\n`github.com/skycoin/skycoin/src/util/logging` was changed entirely relatively recently, so the original decision may not have been related."}}
{"actor":{"display_login":"gz-c"}}