{"action":"created","comment":{"url":"https://api.github.com/repos/the-control-group/voyager/pulls/comments/194065027","pull_request_review_id":127170333,"id":194065027,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDA2NTAyNw==","diff_hunk":"@@ -241,50 +241,58 @@\n @stop\n \n @section('css')\n-@if(!$dataType->server_side && config('dashboard.data_tables.responsive'))\n-<link rel=\"stylesheet\" href=\"{{ voyager_asset('lib/css/responsive.dataTables.min.css') }}\">\n-@endif\n+    @if(!$dataType->server_side && config('dashboard.data_tables.responsive'))\n+        <link rel=\"stylesheet\" href=\"{{ voyager_asset('lib/css/responsive.dataTables.min.css') }}\">\n+    @endif\n @stop\n \n @section('javascript')\n-    <!-- DataTables -->\n-    @if(!$dataType->server_side && config('dashboard.data_tables.responsive'))\n-        <script src=\"{{ voyager_asset('lib/js/dataTables.responsive.min.js') }}\"></script>\n-    @endif\n-    <script>\n-        $(document).ready(function () {\n-            @if (!$dataType->server_side)\n-                var table = $('#dataTable').DataTable({!! json_encode(\n+<!-- DataTables -->\n+@if(!$dataType->server_side && config('dashboard.data_tables.responsive'))\n+    <script src=\"{{ voyager_asset('lib/js/dataTables.responsive.min.js') }}\"></script>\n+@endif\n+<script>\n+    $(document).ready(function () {\n+                @if (!$dataType->server_side)\n+        var table = $('#dataTable').DataTable({!! json_encode(\n                     array_merge([\n                         \"order\" => [],\n                         \"language\" => __('voyager::datatable'),\n                         \"columnDefs\" => [['targets' => -1, 'searchable' =>  false, 'orderable' => false]],\n                     ],\n                     config('voyager.dashboard.data_tables', []))\n                 , true) !!});\n-            @else\n-                $('#search-input select').select2({\n-                    minimumResultsForSearch: Infinity\n-                });\n-            @endif\n+        @else\n+        $('#search-input select').select2({\n+            minimumResultsForSearch: Infinity\n+        });\n+        @endif\n \n-            @if ($isModelTranslatable)\n-                $('.side-body').multilingual();\n-                //Reinitialise the multilingual features when they change tab\n-                $('#dataTable').on('draw.dt', function(){\n-                    $('.side-body').data('multilingual').init();\n-                })\n-            @endif\n-            $('.select_all').on('click', function(e) {\n-                $('input[name=\"row_id\"]').prop('checked', $(this).prop('checked'));\n-            });\n+        @if ($isModelTranslatable)\n+        $('.side-body').multilingual();\n+        //Reinitialise the multilingual features when they change tab\n+        $('#dataTable').on('draw.dt', function(){\n+            $('.side-body').data('multilingual').init();\n+        })\n+        @endif\n+        $('.select_all').on('click', function(e) {\n+            $('input[name=\"row_id\"]').prop('checked', $(this).prop('checked'));\n         });\n+    });\n \n \n-        var deleteFormAction;\n-        $('td').on('click', '.delete', function (e) {\n-            $('#delete_form')[0].action = '{{ route('voyager.'.$dataType->slug.'.destroy', ['id' => '__id']) }}'.replace('__id', $(this).data('id'));\n-            $('#delete_modal').modal('show');\n-        });\n-    </script>\n+    var deleteFormAction;\n+    $('td').on('click', '.delete', function (e) {\n+        $('#delete_form')[0].action = '{{ route('voyager.'.$dataType->slug.'.destroy', ['id' => '__id']) }}'.replace('__id', $(this).data('id'));\n+        $('#delete_modal').modal('show');\n+    });\n+\n+    $('tr.js-row').on('dblclick', function (e) {\n+        var doubleClickLocation = \"{{lcfirst($dataType->display_name_plural)}}\" + \"/\" + $(this).data('id');\n+        @can('edit', app($dataType->model_name))\n+            doubleClickLocation += \"/edit\";","path":"resources/views/bread/browse.blade.php","position":208,"original_position":208,"commit_id":"60372145452a011ef7720eb26130ef6b9a96964c","original_commit_id":"60372145452a011ef7720eb26130ef6b9a96964c","user":{"login":"fletch3555","id":1387843,"node_id":"MDQ6VXNlcjEzODc4NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1387843?v=4","gravatar_id":"","url":"https://api.github.com/users/fletch3555","html_url":"https://github.com/fletch3555","followers_url":"https://api.github.com/users/fletch3555/followers","following_url":"https://api.github.com/users/fletch3555/following{/other_user}","gists_url":"https://api.github.com/users/fletch3555/gists{/gist_id}","starred_url":"https://api.github.com/users/fletch3555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fletch3555/subscriptions","organizations_url":"https://api.github.com/users/fletch3555/orgs","repos_url":"https://api.github.com/users/fletch3555/repos","events_url":"https://api.github.com/users/fletch3555/events{/privacy}","received_events_url":"https://api.github.com/users/fletch3555/received_events","type":"User","site_admin":false},"body":"I think varying the click action like this might be confusing to end-users.\r\n\r\nI believe the `read` view also has an edit button, can we simply link them to the read page and they can edit if desired?\r\n\r\nI'm open to suggestions on this.","created_at":"2018-06-08T13:55:43Z","updated_at":"2018-06-08T14:02:46Z","html_url":"https://github.com/the-control-group/voyager/pull/3282#discussion_r194065027","pull_request_url":"https://api.github.com/repos/the-control-group/voyager/pulls/3282","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/the-control-group/voyager/pulls/comments/194065027"},"html":{"href":"https://github.com/the-control-group/voyager/pull/3282#discussion_r194065027"},"pull_request":{"href":"https://api.github.com/repos/the-control-group/voyager/pulls/3282"}}},"pull_request":{"url":"https://api.github.com/repos/the-control-group/voyager/pulls/3282","id":193261478,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMjYxNDc4","html_url":"https://github.com/the-control-group/voyager/pull/3282","diff_url":"https://github.com/the-control-group/voyager/pull/3282.diff","patch_url":"https://github.com/the-control-group/voyager/pull/3282.patch","issue_url":"https://api.github.com/repos/the-control-group/voyager/issues/3282","number":3282,"state":"open","locked":false,"title":"Add double click function to BREAD row","user":{"login":"marijnz0r","id":12230678,"node_id":"MDQ6VXNlcjEyMjMwNjc4","avatar_url":"https://avatars1.githubusercontent.com/u/12230678?v=4","gravatar_id":"","url":"https://api.github.com/users/marijnz0r","html_url":"https://github.com/marijnz0r","followers_url":"https://api.github.com/users/marijnz0r/followers","following_url":"https://api.github.com/users/marijnz0r/following{/other_user}","gists_url":"https://api.github.com/users/marijnz0r/gists{/gist_id}","starred_url":"https://api.github.com/users/marijnz0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marijnz0r/subscriptions","organizations_url":"https://api.github.com/users/marijnz0r/orgs","repos_url":"https://api.github.com/users/marijnz0r/repos","events_url":"https://api.github.com/users/marijnz0r/events{/privacy}","received_events_url":"https://api.github.com/users/marijnz0r/received_events","type":"User","site_admin":false},"body":"Add a way the user can navigate through the BREAD views. By double\r\nclicking the row, the user goes to the view or edit page, depending\r\non their rights. To simplify the way to delete a single item, add a\r\ndelete button in the browse view if the user has rights to delete it.","created_at":"2018-06-07T09:43:10Z","updated_at":"2018-06-08T14:02:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4de5490ac091e342da0b6e45a2d89835caaee8bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/the-control-group/voyager/pulls/3282/commits","review_comments_url":"https://api.github.com/repos/the-control-group/voyager/pulls/3282/comments","review_comment_url":"https://api.github.com/repos/the-control-group/voyager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/the-control-group/voyager/issues/3282/comments","statuses_url":"https://api.github.com/repos/the-control-group/voyager/statuses/60372145452a011ef7720eb26130ef6b9a96964c","head":{"label":"marijnz0r:feature/add-double-click-function-to-bread-row","ref":"feature/add-double-click-function-to-bread-row","sha":"60372145452a011ef7720eb26130ef6b9a96964c","user":{"login":"marijnz0r","id":12230678,"node_id":"MDQ6VXNlcjEyMjMwNjc4","avatar_url":"https://avatars1.githubusercontent.com/u/12230678?v=4","gravatar_id":"","url":"https://api.github.com/users/marijnz0r","html_url":"https://github.com/marijnz0r","followers_url":"https://api.github.com/users/marijnz0r/followers","following_url":"https://api.github.com/users/marijnz0r/following{/other_user}","gists_url":"https://api.github.com/users/marijnz0r/gists{/gist_id}","starred_url":"https://api.github.com/users/marijnz0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marijnz0r/subscriptions","organizations_url":"https://api.github.com/users/marijnz0r/orgs","repos_url":"https://api.github.com/users/marijnz0r/repos","events_url":"https://api.github.com/users/marijnz0r/events{/privacy}","received_events_url":"https://api.github.com/users/marijnz0r/received_events","type":"User","site_admin":false},"repo":{"id":129111348,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxMTEzNDg=","name":"voyager","full_name":"marijnz0r/voyager","owner":{"login":"marijnz0r","id":12230678,"node_id":"MDQ6VXNlcjEyMjMwNjc4","avatar_url":"https://avatars1.githubusercontent.com/u/12230678?v=4","gravatar_id":"","url":"https://api.github.com/users/marijnz0r","html_url":"https://github.com/marijnz0r","followers_url":"https://api.github.com/users/marijnz0r/followers","following_url":"https://api.github.com/users/marijnz0r/following{/other_user}","gists_url":"https://api.github.com/users/marijnz0r/gists{/gist_id}","starred_url":"https://api.github.com/users/marijnz0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marijnz0r/subscriptions","organizations_url":"https://api.github.com/users/marijnz0r/orgs","repos_url":"https://api.github.com/users/marijnz0r/repos","events_url":"https://api.github.com/users/marijnz0r/events{/privacy}","received_events_url":"https://api.github.com/users/marijnz0r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marijnz0r/voyager","description":"Voyager - The Missing Laravel Admin","fork":true,"url":"https://api.github.com/repos/marijnz0r/voyager","forks_url":"https://api.github.com/repos/marijnz0r/voyager/forks","keys_url":"https://api.github.com/repos/marijnz0r/voyager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marijnz0r/voyager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marijnz0r/voyager/teams","hooks_url":"https://api.github.com/repos/marijnz0r/voyager/hooks","issue_events_url":"https://api.github.com/repos/marijnz0r/voyager/issues/events{/number}","events_url":"https://api.github.com/repos/marijnz0r/voyager/events","assignees_url":"https://api.github.com/repos/marijnz0r/voyager/assignees{/user}","branches_url":"https://api.github.com/repos/marijnz0r/voyager/branches{/branch}","tags_url":"https://api.github.com/repos/marijnz0r/voyager/tags","blobs_url":"https://api.github.com/repos/marijnz0r/voyager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marijnz0r/voyager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marijnz0r/voyager/git/refs{/sha}","trees_url":"https://api.github.com/repos/marijnz0r/voyager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marijnz0r/voyager/statuses/{sha}","languages_url":"https://api.github.com/repos/marijnz0r/voyager/languages","stargazers_url":"https://api.github.com/repos/marijnz0r/voyager/stargazers","contributors_url":"https://api.github.com/repos/marijnz0r/voyager/contributors","subscribers_url":"https://api.github.com/repos/marijnz0r/voyager/subscribers","subscription_url":"https://api.github.com/repos/marijnz0r/voyager/subscription","commits_url":"https://api.github.com/repos/marijnz0r/voyager/commits{/sha}","git_commits_url":"https://api.github.com/repos/marijnz0r/voyager/git/commits{/sha}","comments_url":"https://api.github.com/repos/marijnz0r/voyager/comments{/number}","issue_comment_url":"https://api.github.com/repos/marijnz0r/voyager/issues/comments{/number}","contents_url":"https://api.github.com/repos/marijnz0r/voyager/contents/{+path}","compare_url":"https://api.github.com/repos/marijnz0r/voyager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marijnz0r/voyager/merges","archive_url":"https://api.github.com/repos/marijnz0r/voyager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marijnz0r/voyager/downloads","issues_url":"https://api.github.com/repos/marijnz0r/voyager/issues{/number}","pulls_url":"https://api.github.com/repos/marijnz0r/voyager/pulls{/number}","milestones_url":"https://api.github.com/repos/marijnz0r/voyager/milestones{/number}","notifications_url":"https://api.github.com/repos/marijnz0r/voyager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marijnz0r/voyager/labels{/name}","releases_url":"https://api.github.com/repos/marijnz0r/voyager/releases{/id}","deployments_url":"https://api.github.com/repos/marijnz0r/voyager/deployments","created_at":"2018-04-11T15:01:14Z","updated_at":"2018-04-11T15:01:17Z","pushed_at":"2018-06-07T11:08:50Z","git_url":"git://github.com/marijnz0r/voyager.git","ssh_url":"git@github.com:marijnz0r/voyager.git","clone_url":"https://github.com/marijnz0r/voyager.git","svn_url":"https://github.com/marijnz0r/voyager","homepage":"https://laravelvoyager.com","size":29742,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.0"}},"base":{"label":"the-control-group:1.x","ref":"1.x","sha":"3ae697e1c3a96ca42189249373f5cf485b1c484f","user":{"login":"the-control-group","id":5199022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTkwMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5199022?v=4","gravatar_id":"","url":"https://api.github.com/users/the-control-group","html_url":"https://github.com/the-control-group","followers_url":"https://api.github.com/users/the-control-group/followers","following_url":"https://api.github.com/users/the-control-group/following{/other_user}","gists_url":"https://api.github.com/users/the-control-group/gists{/gist_id}","starred_url":"https://api.github.com/users/the-control-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-control-group/subscriptions","organizations_url":"https://api.github.com/users/the-control-group/orgs","repos_url":"https://api.github.com/users/the-control-group/repos","events_url":"https://api.github.com/users/the-control-group/events{/privacy}","received_events_url":"https://api.github.com/users/the-control-group/received_events","type":"Organization","site_admin":false},"repo":{"id":72069409,"node_id":"MDEwOlJlcG9zaXRvcnk3MjA2OTQwOQ==","name":"voyager","full_name":"the-control-group/voyager","owner":{"login":"the-control-group","id":5199022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTkwMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5199022?v=4","gravatar_id":"","url":"https://api.github.com/users/the-control-group","html_url":"https://github.com/the-control-group","followers_url":"https://api.github.com/users/the-control-group/followers","following_url":"https://api.github.com/users/the-control-group/following{/other_user}","gists_url":"https://api.github.com/users/the-control-group/gists{/gist_id}","starred_url":"https://api.github.com/users/the-control-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-control-group/subscriptions","organizations_url":"https://api.github.com/users/the-control-group/orgs","repos_url":"https://api.github.com/users/the-control-group/repos","events_url":"https://api.github.com/users/the-control-group/events{/privacy}","received_events_url":"https://api.github.com/users/the-control-group/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/the-control-group/voyager","description":"Voyager - The Missing Laravel Admin","fork":false,"url":"https://api.github.com/repos/the-control-group/voyager","forks_url":"https://api.github.com/repos/the-control-group/voyager/forks","keys_url":"https://api.github.com/repos/the-control-group/voyager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/the-control-group/voyager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/the-control-group/voyager/teams","hooks_url":"https://api.github.com/repos/the-control-group/voyager/hooks","issue_events_url":"https://api.github.com/repos/the-control-group/voyager/issues/events{/number}","events_url":"https://api.github.com/repos/the-control-group/voyager/events","assignees_url":"https://api.github.com/repos/the-control-group/voyager/assignees{/user}","branches_url":"https://api.github.com/repos/the-control-group/voyager/branches{/branch}","tags_url":"https://api.github.com/repos/the-control-group/voyager/tags","blobs_url":"https://api.github.com/repos/the-control-group/voyager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/the-control-group/voyager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/the-control-group/voyager/git/refs{/sha}","trees_url":"https://api.github.com/repos/the-control-group/voyager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/the-control-group/voyager/statuses/{sha}","languages_url":"https://api.github.com/repos/the-control-group/voyager/languages","stargazers_url":"https://api.github.com/repos/the-control-group/voyager/stargazers","contributors_url":"https://api.github.com/repos/the-control-group/voyager/contributors","subscribers_url":"https://api.github.com/repos/the-control-group/voyager/subscribers","subscription_url":"https://api.github.com/repos/the-control-group/voyager/subscription","commits_url":"https://api.github.com/repos/the-control-group/voyager/commits{/sha}","git_commits_url":"https://api.github.com/repos/the-control-group/voyager/git/commits{/sha}","comments_url":"https://api.github.com/repos/the-control-group/voyager/comments{/number}","issue_comment_url":"https://api.github.com/repos/the-control-group/voyager/issues/comments{/number}","contents_url":"https://api.github.com/repos/the-control-group/voyager/contents/{+path}","compare_url":"https://api.github.com/repos/the-control-group/voyager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/the-control-group/voyager/merges","archive_url":"https://api.github.com/repos/the-control-group/voyager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/the-control-group/voyager/downloads","issues_url":"https://api.github.com/repos/the-control-group/voyager/issues{/number}","pulls_url":"https://api.github.com/repos/the-control-group/voyager/pulls{/number}","milestones_url":"https://api.github.com/repos/the-control-group/voyager/milestones{/number}","notifications_url":"https://api.github.com/repos/the-control-group/voyager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/the-control-group/voyager/labels{/name}","releases_url":"https://api.github.com/repos/the-control-group/voyager/releases{/id}","deployments_url":"https://api.github.com/repos/the-control-group/voyager/deployments","created_at":"2016-10-27T03:56:49Z","updated_at":"2018-06-08T06:50:18Z","pushed_at":"2018-06-08T08:32:54Z","git_url":"git://github.com/the-control-group/voyager.git","ssh_url":"git@github.com:the-control-group/voyager.git","clone_url":"https://github.com/the-control-group/voyager.git","svn_url":"https://github.com/the-control-group/voyager","homepage":"https://laravelvoyager.com","size":29738,"stargazers_count":6316,"watchers_count":6316,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1419,"mirror_url":null,"archived":false,"open_issues_count":289,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1419,"open_issues":289,"watchers":6316,"default_branch":"1.1"}},"_links":{"self":{"href":"https://api.github.com/repos/the-control-group/voyager/pulls/3282"},"html":{"href":"https://github.com/the-control-group/voyager/pull/3282"},"issue":{"href":"https://api.github.com/repos/the-control-group/voyager/issues/3282"},"comments":{"href":"https://api.github.com/repos/the-control-group/voyager/issues/3282/comments"},"review_comments":{"href":"https://api.github.com/repos/the-control-group/voyager/pulls/3282/comments"},"review_comment":{"href":"https://api.github.com/repos/the-control-group/voyager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/the-control-group/voyager/pulls/3282/commits"},"statuses":{"href":"https://api.github.com/repos/the-control-group/voyager/statuses/60372145452a011ef7720eb26130ef6b9a96964c"}},"author_association":"NONE"}}
{"actor":{"display_login":"fletch3555"}}