{"action":"created","comment":{"url":"https://api.github.com/repos/kilopowq/7520studie/pulls/comments/232454189","pull_request_review_id":173663712,"id":232454189,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQ1NDE4OQ==","diff_hunk":"@@ -22,6 +22,6 @@ public boolean add(Product product) {\n     public List<Product> searchByFields(Map<String, String> mapProductParam) {\n         Map<String, String> filteredmap = mapProductParam.entrySet().stream().filter(mapEntry -> !mapEntry.getValue()\n                 .equals(\"\")).collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));\n-        return productDAO.findByFields(filteredmap);\n+        return filteredmap.isEmpty() ? null : productDAO.findByFields(filteredmap);","path":"src/main/java/com/kilopo/kosshop/service/Impl/ProductServiceImpl.java","position":5,"original_position":5,"commit_id":"71674bc2b3f7f1b9881fd9b2dedc8cd1af20a033","original_commit_id":"71674bc2b3f7f1b9881fd9b2dedc8cd1af20a033","user":{"login":"kilopowq","id":24812703,"node_id":"MDQ6VXNlcjI0ODEyNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/24812703?v=4","gravatar_id":"","url":"https://api.github.com/users/kilopowq","html_url":"https://github.com/kilopowq","followers_url":"https://api.github.com/users/kilopowq/followers","following_url":"https://api.github.com/users/kilopowq/following{/other_user}","gists_url":"https://api.github.com/users/kilopowq/gists{/gist_id}","starred_url":"https://api.github.com/users/kilopowq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kilopowq/subscriptions","organizations_url":"https://api.github.com/users/kilopowq/orgs","repos_url":"https://api.github.com/users/kilopowq/repos","events_url":"https://api.github.com/users/kilopowq/events{/privacy}","received_events_url":"https://api.github.com/users/kilopowq/received_events","type":"User","site_admin":false},"body":"good practice to return empty list. not null\r\nwith this approach you can avoid NullPointerException","created_at":"2018-11-10T14:52:02Z","updated_at":"2018-11-10T14:52:48Z","html_url":"https://github.com/kilopowq/7520studie/pull/25#discussion_r232454189","pull_request_url":"https://api.github.com/repos/kilopowq/7520studie/pulls/25","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kilopowq/7520studie/pulls/comments/232454189"},"html":{"href":"https://github.com/kilopowq/7520studie/pull/25#discussion_r232454189"},"pull_request":{"href":"https://api.github.com/repos/kilopowq/7520studie/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/kilopowq/7520studie/pulls/25","id":229198301,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MTk4MzAx","html_url":"https://github.com/kilopowq/7520studie/pull/25","diff_url":"https://github.com/kilopowq/7520studie/pull/25.diff","patch_url":"https://github.com/kilopowq/7520studie/pull/25.patch","issue_url":"https://api.github.com/repos/kilopowq/7520studie/issues/25","number":25,"state":"open","locked":false,"title":"KOS-10/Base Layout","user":{"login":"Pasha7520","id":33636001,"node_id":"MDQ6VXNlcjMzNjM2MDAx","avatar_url":"https://avatars0.githubusercontent.com/u/33636001?v=4","gravatar_id":"","url":"https://api.github.com/users/Pasha7520","html_url":"https://github.com/Pasha7520","followers_url":"https://api.github.com/users/Pasha7520/followers","following_url":"https://api.github.com/users/Pasha7520/following{/other_user}","gists_url":"https://api.github.com/users/Pasha7520/gists{/gist_id}","starred_url":"https://api.github.com/users/Pasha7520/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pasha7520/subscriptions","organizations_url":"https://api.github.com/users/Pasha7520/orgs","repos_url":"https://api.github.com/users/Pasha7520/repos","events_url":"https://api.github.com/users/Pasha7520/events{/privacy}","received_events_url":"https://api.github.com/users/Pasha7520/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-07T23:05:57Z","updated_at":"2018-11-10T14:52:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2452d0e7f0246d916e42f345c255be5c48fd94da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kilopowq/7520studie/pulls/25/commits","review_comments_url":"https://api.github.com/repos/kilopowq/7520studie/pulls/25/comments","review_comment_url":"https://api.github.com/repos/kilopowq/7520studie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kilopowq/7520studie/issues/25/comments","statuses_url":"https://api.github.com/repos/kilopowq/7520studie/statuses/71674bc2b3f7f1b9881fd9b2dedc8cd1af20a033","head":{"label":"kilopowq:feature/KOS-10","ref":"feature/KOS-10","sha":"71674bc2b3f7f1b9881fd9b2dedc8cd1af20a033","user":{"login":"kilopowq","id":24812703,"node_id":"MDQ6VXNlcjI0ODEyNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/24812703?v=4","gravatar_id":"","url":"https://api.github.com/users/kilopowq","html_url":"https://github.com/kilopowq","followers_url":"https://api.github.com/users/kilopowq/followers","following_url":"https://api.github.com/users/kilopowq/following{/other_user}","gists_url":"https://api.github.com/users/kilopowq/gists{/gist_id}","starred_url":"https://api.github.com/users/kilopowq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kilopowq/subscriptions","organizations_url":"https://api.github.com/users/kilopowq/orgs","repos_url":"https://api.github.com/users/kilopowq/repos","events_url":"https://api.github.com/users/kilopowq/events{/privacy}","received_events_url":"https://api.github.com/users/kilopowq/received_events","type":"User","site_admin":false},"repo":{"id":110587341,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1ODczNDE=","name":"7520studie","full_name":"kilopowq/7520studie","private":false,"owner":{"login":"kilopowq","id":24812703,"node_id":"MDQ6VXNlcjI0ODEyNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/24812703?v=4","gravatar_id":"","url":"https://api.github.com/users/kilopowq","html_url":"https://github.com/kilopowq","followers_url":"https://api.github.com/users/kilopowq/followers","following_url":"https://api.github.com/users/kilopowq/following{/other_user}","gists_url":"https://api.github.com/users/kilopowq/gists{/gist_id}","starred_url":"https://api.github.com/users/kilopowq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kilopowq/subscriptions","organizations_url":"https://api.github.com/users/kilopowq/orgs","repos_url":"https://api.github.com/users/kilopowq/repos","events_url":"https://api.github.com/users/kilopowq/events{/privacy}","received_events_url":"https://api.github.com/users/kilopowq/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kilopowq/7520studie","description":null,"fork":false,"url":"https://api.github.com/repos/kilopowq/7520studie","forks_url":"https://api.github.com/repos/kilopowq/7520studie/forks","keys_url":"https://api.github.com/repos/kilopowq/7520studie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kilopowq/7520studie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kilopowq/7520studie/teams","hooks_url":"https://api.github.com/repos/kilopowq/7520studie/hooks","issue_events_url":"https://api.github.com/repos/kilopowq/7520studie/issues/events{/number}","events_url":"https://api.github.com/repos/kilopowq/7520studie/events","assignees_url":"https://api.github.com/repos/kilopowq/7520studie/assignees{/user}","branches_url":"https://api.github.com/repos/kilopowq/7520studie/branches{/branch}","tags_url":"https://api.github.com/repos/kilopowq/7520studie/tags","blobs_url":"https://api.github.com/repos/kilopowq/7520studie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kilopowq/7520studie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kilopowq/7520studie/git/refs{/sha}","trees_url":"https://api.github.com/repos/kilopowq/7520studie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kilopowq/7520studie/statuses/{sha}","languages_url":"https://api.github.com/repos/kilopowq/7520studie/languages","stargazers_url":"https://api.github.com/repos/kilopowq/7520studie/stargazers","contributors_url":"https://api.github.com/repos/kilopowq/7520studie/contributors","subscribers_url":"https://api.github.com/repos/kilopowq/7520studie/subscribers","subscription_url":"https://api.github.com/repos/kilopowq/7520studie/subscription","commits_url":"https://api.github.com/repos/kilopowq/7520studie/commits{/sha}","git_commits_url":"https://api.github.com/repos/kilopowq/7520studie/git/commits{/sha}","comments_url":"https://api.github.com/repos/kilopowq/7520studie/comments{/number}","issue_comment_url":"https://api.github.com/repos/kilopowq/7520studie/issues/comments{/number}","contents_url":"https://api.github.com/repos/kilopowq/7520studie/contents/{+path}","compare_url":"https://api.github.com/repos/kilopowq/7520studie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kilopowq/7520studie/merges","archive_url":"https://api.github.com/repos/kilopowq/7520studie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kilopowq/7520studie/downloads","issues_url":"https://api.github.com/repos/kilopowq/7520studie/issues{/number}","pulls_url":"https://api.github.com/repos/kilopowq/7520studie/pulls{/number}","milestones_url":"https://api.github.com/repos/kilopowq/7520studie/milestones{/number}","notifications_url":"https://api.github.com/repos/kilopowq/7520studie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kilopowq/7520studie/labels{/name}","releases_url":"https://api.github.com/repos/kilopowq/7520studie/releases{/id}","deployments_url":"https://api.github.com/repos/kilopowq/7520studie/deployments","created_at":"2017-11-13T18:46:24Z","updated_at":"2018-11-06T09:00:11Z","pushed_at":"2018-11-10T14:36:17Z","git_url":"git://github.com/kilopowq/7520studie.git","ssh_url":"git@github.com:kilopowq/7520studie.git","clone_url":"https://github.com/kilopowq/7520studie.git","svn_url":"https://github.com/kilopowq/7520studie","homepage":null,"size":818,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"kilopowq:develop","ref":"develop","sha":"1806354100122ee748533309d9ece70d3f6a39d2","user":{"login":"kilopowq","id":24812703,"node_id":"MDQ6VXNlcjI0ODEyNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/24812703?v=4","gravatar_id":"","url":"https://api.github.com/users/kilopowq","html_url":"https://github.com/kilopowq","followers_url":"https://api.github.com/users/kilopowq/followers","following_url":"https://api.github.com/users/kilopowq/following{/other_user}","gists_url":"https://api.github.com/users/kilopowq/gists{/gist_id}","starred_url":"https://api.github.com/users/kilopowq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kilopowq/subscriptions","organizations_url":"https://api.github.com/users/kilopowq/orgs","repos_url":"https://api.github.com/users/kilopowq/repos","events_url":"https://api.github.com/users/kilopowq/events{/privacy}","received_events_url":"https://api.github.com/users/kilopowq/received_events","type":"User","site_admin":false},"repo":{"id":110587341,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1ODczNDE=","name":"7520studie","full_name":"kilopowq/7520studie","private":false,"owner":{"login":"kilopowq","id":24812703,"node_id":"MDQ6VXNlcjI0ODEyNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/24812703?v=4","gravatar_id":"","url":"https://api.github.com/users/kilopowq","html_url":"https://github.com/kilopowq","followers_url":"https://api.github.com/users/kilopowq/followers","following_url":"https://api.github.com/users/kilopowq/following{/other_user}","gists_url":"https://api.github.com/users/kilopowq/gists{/gist_id}","starred_url":"https://api.github.com/users/kilopowq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kilopowq/subscriptions","organizations_url":"https://api.github.com/users/kilopowq/orgs","repos_url":"https://api.github.com/users/kilopowq/repos","events_url":"https://api.github.com/users/kilopowq/events{/privacy}","received_events_url":"https://api.github.com/users/kilopowq/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kilopowq/7520studie","description":null,"fork":false,"url":"https://api.github.com/repos/kilopowq/7520studie","forks_url":"https://api.github.com/repos/kilopowq/7520studie/forks","keys_url":"https://api.github.com/repos/kilopowq/7520studie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kilopowq/7520studie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kilopowq/7520studie/teams","hooks_url":"https://api.github.com/repos/kilopowq/7520studie/hooks","issue_events_url":"https://api.github.com/repos/kilopowq/7520studie/issues/events{/number}","events_url":"https://api.github.com/repos/kilopowq/7520studie/events","assignees_url":"https://api.github.com/repos/kilopowq/7520studie/assignees{/user}","branches_url":"https://api.github.com/repos/kilopowq/7520studie/branches{/branch}","tags_url":"https://api.github.com/repos/kilopowq/7520studie/tags","blobs_url":"https://api.github.com/repos/kilopowq/7520studie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kilopowq/7520studie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kilopowq/7520studie/git/refs{/sha}","trees_url":"https://api.github.com/repos/kilopowq/7520studie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kilopowq/7520studie/statuses/{sha}","languages_url":"https://api.github.com/repos/kilopowq/7520studie/languages","stargazers_url":"https://api.github.com/repos/kilopowq/7520studie/stargazers","contributors_url":"https://api.github.com/repos/kilopowq/7520studie/contributors","subscribers_url":"https://api.github.com/repos/kilopowq/7520studie/subscribers","subscription_url":"https://api.github.com/repos/kilopowq/7520studie/subscription","commits_url":"https://api.github.com/repos/kilopowq/7520studie/commits{/sha}","git_commits_url":"https://api.github.com/repos/kilopowq/7520studie/git/commits{/sha}","comments_url":"https://api.github.com/repos/kilopowq/7520studie/comments{/number}","issue_comment_url":"https://api.github.com/repos/kilopowq/7520studie/issues/comments{/number}","contents_url":"https://api.github.com/repos/kilopowq/7520studie/contents/{+path}","compare_url":"https://api.github.com/repos/kilopowq/7520studie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kilopowq/7520studie/merges","archive_url":"https://api.github.com/repos/kilopowq/7520studie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kilopowq/7520studie/downloads","issues_url":"https://api.github.com/repos/kilopowq/7520studie/issues{/number}","pulls_url":"https://api.github.com/repos/kilopowq/7520studie/pulls{/number}","milestones_url":"https://api.github.com/repos/kilopowq/7520studie/milestones{/number}","notifications_url":"https://api.github.com/repos/kilopowq/7520studie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kilopowq/7520studie/labels{/name}","releases_url":"https://api.github.com/repos/kilopowq/7520studie/releases{/id}","deployments_url":"https://api.github.com/repos/kilopowq/7520studie/deployments","created_at":"2017-11-13T18:46:24Z","updated_at":"2018-11-06T09:00:11Z","pushed_at":"2018-11-10T14:36:17Z","git_url":"git://github.com/kilopowq/7520studie.git","ssh_url":"git@github.com:kilopowq/7520studie.git","clone_url":"https://github.com/kilopowq/7520studie.git","svn_url":"https://github.com/kilopowq/7520studie","homepage":null,"size":818,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/kilopowq/7520studie/pulls/25"},"html":{"href":"https://github.com/kilopowq/7520studie/pull/25"},"issue":{"href":"https://api.github.com/repos/kilopowq/7520studie/issues/25"},"comments":{"href":"https://api.github.com/repos/kilopowq/7520studie/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/kilopowq/7520studie/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/kilopowq/7520studie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kilopowq/7520studie/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/kilopowq/7520studie/statuses/71674bc2b3f7f1b9881fd9b2dedc8cd1af20a033"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kilopowq"}}