{"push_id":2531468397,"size":4,"distinct_size":2,"ref":"refs/heads/commitfest/18/922","head":"531465eeaee4fd50de67497e2e4a340cd9a0b858","before":"eb6a5d1af74c1b232d2bafd523d799b2afe053ed","commits":[{"sha":"41c912cad15955b5f9270ef3688a44e91d410d3d","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Clean up warnings from -Wimplicit-fallthrough.\n\nRecent gcc can warn about switch-case fall throughs that are not\nexplicitly labeled as intentional.  This seems like a good thing,\nso clean up the warnings exposed thereby by labeling all such\ncases with comments that gcc will recognize.\n\nIn files that already had one or more suitable comments, I generally\nmatched the existing style of those.  Otherwise I went with\n/* FALLTHROUGH */, which is one of the spellings approved at the\nmore-restrictive-than-default level -Wimplicit-fallthrough=4.\n(At the default level you can also spell it /* FALL ?THRU */,\nand it's not picky about case.  What you can't do is include\nadditional text in the same comment, so some existing comments\ncontaining versions of this aren't good enough.)\n\nTesting with gcc 8.0.1 (Fedora 28's current version), I found that\nI also had to put explicit \"break\"s after elog(ERROR) or ereport(ERROR);\napparently, for this purpose gcc doesn't recognize that those don't\nreturn.  That seems like possibly a gcc bug, but it's fine because\nin most places we did that anyway; so this amounts to a visit from the\nstyle police.\n\nDiscussion: https://postgr.es/m/15083.1525207729@sss.pgh.pa.us","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/41c912cad15955b5f9270ef3688a44e91d410d3d"},{"sha":"b2328bf62b6465236e318d31a011ced5dccfd580","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Fix some assorted compiler warnings on Windows.\n\nDon't overflow the result type of constant expressions.  Don't negate\nunsigned types.  Define HAVE_STDBOOL_H for Visual C++ 2013 and later.\n\nThomas Munro\nReviewed-By: Michael Paquier and Tom Lane\n\nDiscussion: https://postgr.es/m/CAEepm%3D3%3DTDYEXUEcHpEx%2BTwc31wo7PA0oBAiNt6sWmq93MW02A%40mail.gmail.com","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/b2328bf62b6465236e318d31a011ced5dccfd580"},{"sha":"2993435dbae5deb8d2f6c2a715690a5aef4eddb8","author":{"name":"Andres Freund","email":"883768b6dd2c42aea0031b24be8a2da40fef4b64@anarazel.de"},"message":"Further -Wimplicit-fallthrough cleanup.\n\nTom's earlier commit in 41c912cad159 didn't update a few cases that\nare only encountered with the non-standard --with-llvm config\nflag. Additionally there's also one case that appears to be a\ndeficiency in gcc's (up to trunk as of a few days ago) detection of\n\"fallthrough\" comments - changing the placement slightly fixes that.\n\nAuthor: Andres Freund\nDiscussion: https://postgr.es/m/20180502003239.wfnqu7ekz7j7imm4@alap3.anarazel.de","distinct":true,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/2993435dbae5deb8d2f6c2a715690a5aef4eddb8"},{"sha":"531465eeaee4fd50de67497e2e4a340cd9a0b858","author":{"name":"Commitfest Bot","email":"b9e638e07cc2e2abf56c9c0cad7954f2e3bc1641@cputube.org"},"message":"[CF 18/922] Failure at replay for corrupted 2PC files + reduce window between end-of-recovery record and history file write\n\nThis commit was automatically generated by cfbot at commitfest.cputube.org.\nIt is based on patches submitted to the PostgreSQL mailing lists and\nregistered in the PostgreSQL Commitfest application.\n\nThis branch will be overwritten each time a new patch version is posted to\nthe email thread or the master branch changes.\n\nCommitfest entry: https://commitfest.postgresql.org/18/922\nPatch(es): https://www.postgresql.org/message-id/CAB7nPqT9V6N7Wm7npkqcHf-beLtZ82z2dNG_5cwfBLg%3Dm5PfUw%40mail.gmail.com\nAuthor(s): Heikki Linnakangas, Michael Paquier","distinct":true,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/531465eeaee4fd50de67497e2e4a340cd9a0b858"}]}
{"actor":{"display_login":"postgresql-cfbot"}}