{"action":"created","comment":{"url":"https://api.github.com/repos/ifmeorg/ifme/pulls/comments/224879698","pull_request_review_id":164362435,"id":224879698,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDg3OTY5OA==","diff_hunk":"@@ -17,29 +17,7 @@\n \n       <div class=\"mostFocus\">\n         <% most_focus.each do |key, value| %>\n-          <div class=\"someFocus\">\n-            <div class=\"someFocusText\">\n-              <% if local_assigns[:data_type] == 'category' && (!local_assigns[:profile] || local_assigns[:profile] == current_user.id) %>\n-                <%= viewers_hover(get_viewers_for(Category.where(id: key).first, 'category'), Category.where(id: key).first) %>\n-              <% elsif local_assigns[:data_type] == 'category' && local_assigns[:profile] %>\n-                <div class=\"someFocusTextName\">\n-                  <%= Category.where(id: key).first.name %>\n-                </div>\n-              <% elsif local_assigns[:data_type] == 'mood' && (!local_assigns[:profile] || local_assigns[:profile] == current_user.id) %>\n-                <%= viewers_hover(get_viewers_for(Mood.where(id: key).first, 'mood'), Mood.where(id: key).first) %>\n-              <% elsif local_assigns[:data_type] == 'mood' && local_assigns[:profile] %>\n-                <div class=\"someFocusTextName\">\n-                  <%= Mood.where(id: key).first.name %>\n-                </div>\n-              <% elsif local_assigns[:data_type] == 'strategy' && (!local_assigns[:profile] || local_assigns[:profile] == current_user.id) %>\n-                <%= viewers_hover(get_viewers_for(Strategy.where(id: key).first, 'strategy'), Strategy.where(id: key).first) %>\n-              <% elsif local_assigns[:data_type] == 'strategy' && local_assigns[:profile] %>\n-                <div class=\"someFocusTextName\">\n-                  <%= Strategy.where(id: key).first.name %>\n-                </div>\n-              <% end %>\n-            </div>\n-          </div>\n+          <%= render 'shared/focus' %>","path":"app/views/shared/_stats.html.erb","position":33,"original_position":33,"commit_id":"f9433675ffe35ca647f7ddf7c6c5271617db9821","original_commit_id":"5dec21230737995105008fc482048c482dde34e7","user":{"login":"julianguyen","id":3010728,"node_id":"MDQ6VXNlcjMwMTA3Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/3010728?v=4","gravatar_id":"","url":"https://api.github.com/users/julianguyen","html_url":"https://github.com/julianguyen","followers_url":"https://api.github.com/users/julianguyen/followers","following_url":"https://api.github.com/users/julianguyen/following{/other_user}","gists_url":"https://api.github.com/users/julianguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/julianguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianguyen/subscriptions","organizations_url":"https://api.github.com/users/julianguyen/orgs","repos_url":"https://api.github.com/users/julianguyen/repos","events_url":"https://api.github.com/users/julianguyen/events{/privacy}","received_events_url":"https://api.github.com/users/julianguyen/received_events","type":"User","site_admin":false},"body":"You should really be running the app locally on your machine while making changes to it. Unfortunately, we don't have automated tests for everything. Things like UI often times have to be tested manually.\r\n\r\nAre you using Windows or Linux? I recommend using Linux and following our [Installation](https://github.com/ifmeorg/ifme/wiki/Installation) steps for that.","created_at":"2018-10-12T18:36:09Z","updated_at":"2018-10-12T18:36:10Z","html_url":"https://github.com/ifmeorg/ifme/pull/1142#discussion_r224879698","pull_request_url":"https://api.github.com/repos/ifmeorg/ifme/pulls/1142","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ifmeorg/ifme/pulls/comments/224879698"},"html":{"href":"https://github.com/ifmeorg/ifme/pull/1142#discussion_r224879698"},"pull_request":{"href":"https://api.github.com/repos/ifmeorg/ifme/pulls/1142"}},"in_reply_to_id":224662398},"pull_request":{"url":"https://api.github.com/repos/ifmeorg/ifme/pulls/1142","id":222253015,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjUzMDE1","html_url":"https://github.com/ifmeorg/ifme/pull/1142","diff_url":"https://github.com/ifmeorg/ifme/pull/1142.diff","patch_url":"https://github.com/ifmeorg/ifme/pull/1142.patch","issue_url":"https://api.github.com/repos/ifmeorg/ifme/issues/1142","number":1142,"state":"open","locked":false,"title":"/app/views/shared/_stats.html.erb refactor","user":{"login":"OPARA-PROSPER","id":30195980,"node_id":"MDQ6VXNlcjMwMTk1OTgw","avatar_url":"https://avatars3.githubusercontent.com/u/30195980?v=4","gravatar_id":"","url":"https://api.github.com/users/OPARA-PROSPER","html_url":"https://github.com/OPARA-PROSPER","followers_url":"https://api.github.com/users/OPARA-PROSPER/followers","following_url":"https://api.github.com/users/OPARA-PROSPER/following{/other_user}","gists_url":"https://api.github.com/users/OPARA-PROSPER/gists{/gist_id}","starred_url":"https://api.github.com/users/OPARA-PROSPER/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPARA-PROSPER/subscriptions","organizations_url":"https://api.github.com/users/OPARA-PROSPER/orgs","repos_url":"https://api.github.com/users/OPARA-PROSPER/repos","events_url":"https://api.github.com/users/OPARA-PROSPER/events{/privacy}","received_events_url":"https://api.github.com/users/OPARA-PROSPER/received_events","type":"User","site_admin":false},"body":"<!--[\r\n  Thank you for contributing! Please use this pull request (PR) template.\r\n\r\n  Contributor Blurb: https://github.com/ifmeorg/ifme/wiki/Contributor-Blurb\r\n  Join Our Slack: https://github.com/ifmeorg/ifme/wiki/Join-Our-Slack\r\n\r\n  Need help? Post in the #dev channel on Slack\r\n  Use the \"wip\" label if this PR is not ready for review\r\n]-->\r\n# Description \r\n\r\n<!--[A few sentences describing your changes]-->\r\nI refactored the _stats.html.erb partial view like @julianguyen suggested on issue #968\r\n## More Details\r\n\r\n<!--[More details on your changes, remove if not applicable]-->\r\nRefactoring this partial view involved:\r\n- Creating another partial view in the _shared folder_ i named the view __focus.html.erb__ \r\n- Replacing local_assigns[:data_type] == 'category' || local_assigns[:data_type] == 'mood' || local_assigns[:data_type] == 'strategy' with %w(category mood strategy).include? local_assigns[:data_type] \r\n## Corresponding Issue\r\n\r\n<!--[Link to GitHub issue related to this PR here, remove if not applicable]-->\r\nhttps://github.com/ifmeorg/ifme/issues/968\r\n# Screenshots\r\n\r\n<!--[\r\n  Screenshots (required for user interface work), remove if not applicable\r\n  Create a GIF: https://www.cockos.com/licecap\r\n]-->\r\n\r\n# Test Coverage\r\n\r\n✅ <!--[YES, remove line if not applicable]-->\r\n🚫 <!--[NO, remove line if not applicable]-->\r\n\r\n<!--[Must be YES, if NO explain why]-->\r\n","created_at":"2018-10-11T19:29:56Z","updated_at":"2018-10-12T18:36:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3278091430457a0bd031a8194febb5493d6dca43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ifmeorg/ifme/pulls/1142/commits","review_comments_url":"https://api.github.com/repos/ifmeorg/ifme/pulls/1142/comments","review_comment_url":"https://api.github.com/repos/ifmeorg/ifme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ifmeorg/ifme/issues/1142/comments","statuses_url":"https://api.github.com/repos/ifmeorg/ifme/statuses/f9433675ffe35ca647f7ddf7c6c5271617db9821","head":{"label":"OPARA-PROSPER:stats_view_refactor","ref":"stats_view_refactor","sha":"f9433675ffe35ca647f7ddf7c6c5271617db9821","user":{"login":"OPARA-PROSPER","id":30195980,"node_id":"MDQ6VXNlcjMwMTk1OTgw","avatar_url":"https://avatars3.githubusercontent.com/u/30195980?v=4","gravatar_id":"","url":"https://api.github.com/users/OPARA-PROSPER","html_url":"https://github.com/OPARA-PROSPER","followers_url":"https://api.github.com/users/OPARA-PROSPER/followers","following_url":"https://api.github.com/users/OPARA-PROSPER/following{/other_user}","gists_url":"https://api.github.com/users/OPARA-PROSPER/gists{/gist_id}","starred_url":"https://api.github.com/users/OPARA-PROSPER/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPARA-PROSPER/subscriptions","organizations_url":"https://api.github.com/users/OPARA-PROSPER/orgs","repos_url":"https://api.github.com/users/OPARA-PROSPER/repos","events_url":"https://api.github.com/users/OPARA-PROSPER/events{/privacy}","received_events_url":"https://api.github.com/users/OPARA-PROSPER/received_events","type":"User","site_admin":false},"repo":{"id":151790681,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3OTA2ODE=","name":"ifme","full_name":"OPARA-PROSPER/ifme","private":false,"owner":{"login":"OPARA-PROSPER","id":30195980,"node_id":"MDQ6VXNlcjMwMTk1OTgw","avatar_url":"https://avatars3.githubusercontent.com/u/30195980?v=4","gravatar_id":"","url":"https://api.github.com/users/OPARA-PROSPER","html_url":"https://github.com/OPARA-PROSPER","followers_url":"https://api.github.com/users/OPARA-PROSPER/followers","following_url":"https://api.github.com/users/OPARA-PROSPER/following{/other_user}","gists_url":"https://api.github.com/users/OPARA-PROSPER/gists{/gist_id}","starred_url":"https://api.github.com/users/OPARA-PROSPER/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPARA-PROSPER/subscriptions","organizations_url":"https://api.github.com/users/OPARA-PROSPER/orgs","repos_url":"https://api.github.com/users/OPARA-PROSPER/repos","events_url":"https://api.github.com/users/OPARA-PROSPER/events{/privacy}","received_events_url":"https://api.github.com/users/OPARA-PROSPER/received_events","type":"User","site_admin":false},"html_url":"https://github.com/OPARA-PROSPER/ifme","description":"Open source app to share mental health experiences with loved ones","fork":true,"url":"https://api.github.com/repos/OPARA-PROSPER/ifme","forks_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/forks","keys_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/teams","hooks_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/hooks","issue_events_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/issues/events{/number}","events_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/events","assignees_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/assignees{/user}","branches_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/branches{/branch}","tags_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/tags","blobs_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/statuses/{sha}","languages_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/languages","stargazers_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/stargazers","contributors_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/contributors","subscribers_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/subscribers","subscription_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/subscription","commits_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/contents/{+path}","compare_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/merges","archive_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/downloads","issues_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/issues{/number}","pulls_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/pulls{/number}","milestones_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/milestones{/number}","notifications_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/labels{/name}","releases_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/releases{/id}","deployments_url":"https://api.github.com/repos/OPARA-PROSPER/ifme/deployments","created_at":"2018-10-06T00:16:54Z","updated_at":"2018-10-06T00:16:57Z","pushed_at":"2018-10-12T09:51:35Z","git_url":"git://github.com/OPARA-PROSPER/ifme.git","ssh_url":"git@github.com:OPARA-PROSPER/ifme.git","clone_url":"https://github.com/OPARA-PROSPER/ifme.git","svn_url":"https://github.com/OPARA-PROSPER/ifme","homepage":"http://www.if-me.org/","size":34039,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ifmeorg:master","ref":"master","sha":"1323a53a834c074fa2b43f84e11acdf78a0321ec","user":{"login":"ifmeorg","id":23299450,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjk5NDUw","avatar_url":"https://avatars3.githubusercontent.com/u/23299450?v=4","gravatar_id":"","url":"https://api.github.com/users/ifmeorg","html_url":"https://github.com/ifmeorg","followers_url":"https://api.github.com/users/ifmeorg/followers","following_url":"https://api.github.com/users/ifmeorg/following{/other_user}","gists_url":"https://api.github.com/users/ifmeorg/gists{/gist_id}","starred_url":"https://api.github.com/users/ifmeorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifmeorg/subscriptions","organizations_url":"https://api.github.com/users/ifmeorg/orgs","repos_url":"https://api.github.com/users/ifmeorg/repos","events_url":"https://api.github.com/users/ifmeorg/events{/privacy}","received_events_url":"https://api.github.com/users/ifmeorg/received_events","type":"Organization","site_admin":false},"repo":{"id":18935740,"node_id":"MDEwOlJlcG9zaXRvcnkxODkzNTc0MA==","name":"ifme","full_name":"ifmeorg/ifme","private":false,"owner":{"login":"ifmeorg","id":23299450,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjk5NDUw","avatar_url":"https://avatars3.githubusercontent.com/u/23299450?v=4","gravatar_id":"","url":"https://api.github.com/users/ifmeorg","html_url":"https://github.com/ifmeorg","followers_url":"https://api.github.com/users/ifmeorg/followers","following_url":"https://api.github.com/users/ifmeorg/following{/other_user}","gists_url":"https://api.github.com/users/ifmeorg/gists{/gist_id}","starred_url":"https://api.github.com/users/ifmeorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifmeorg/subscriptions","organizations_url":"https://api.github.com/users/ifmeorg/orgs","repos_url":"https://api.github.com/users/ifmeorg/repos","events_url":"https://api.github.com/users/ifmeorg/events{/privacy}","received_events_url":"https://api.github.com/users/ifmeorg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ifmeorg/ifme","description":"Open source app to share mental health experiences with loved ones","fork":false,"url":"https://api.github.com/repos/ifmeorg/ifme","forks_url":"https://api.github.com/repos/ifmeorg/ifme/forks","keys_url":"https://api.github.com/repos/ifmeorg/ifme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifmeorg/ifme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifmeorg/ifme/teams","hooks_url":"https://api.github.com/repos/ifmeorg/ifme/hooks","issue_events_url":"https://api.github.com/repos/ifmeorg/ifme/issues/events{/number}","events_url":"https://api.github.com/repos/ifmeorg/ifme/events","assignees_url":"https://api.github.com/repos/ifmeorg/ifme/assignees{/user}","branches_url":"https://api.github.com/repos/ifmeorg/ifme/branches{/branch}","tags_url":"https://api.github.com/repos/ifmeorg/ifme/tags","blobs_url":"https://api.github.com/repos/ifmeorg/ifme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifmeorg/ifme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifmeorg/ifme/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifmeorg/ifme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifmeorg/ifme/statuses/{sha}","languages_url":"https://api.github.com/repos/ifmeorg/ifme/languages","stargazers_url":"https://api.github.com/repos/ifmeorg/ifme/stargazers","contributors_url":"https://api.github.com/repos/ifmeorg/ifme/contributors","subscribers_url":"https://api.github.com/repos/ifmeorg/ifme/subscribers","subscription_url":"https://api.github.com/repos/ifmeorg/ifme/subscription","commits_url":"https://api.github.com/repos/ifmeorg/ifme/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifmeorg/ifme/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifmeorg/ifme/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifmeorg/ifme/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifmeorg/ifme/contents/{+path}","compare_url":"https://api.github.com/repos/ifmeorg/ifme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifmeorg/ifme/merges","archive_url":"https://api.github.com/repos/ifmeorg/ifme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifmeorg/ifme/downloads","issues_url":"https://api.github.com/repos/ifmeorg/ifme/issues{/number}","pulls_url":"https://api.github.com/repos/ifmeorg/ifme/pulls{/number}","milestones_url":"https://api.github.com/repos/ifmeorg/ifme/milestones{/number}","notifications_url":"https://api.github.com/repos/ifmeorg/ifme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifmeorg/ifme/labels{/name}","releases_url":"https://api.github.com/repos/ifmeorg/ifme/releases{/id}","deployments_url":"https://api.github.com/repos/ifmeorg/ifme/deployments","created_at":"2014-04-19T06:58:25Z","updated_at":"2018-10-12T15:12:51Z","pushed_at":"2018-10-12T18:24:36Z","git_url":"git://github.com/ifmeorg/ifme.git","ssh_url":"git@github.com:ifmeorg/ifme.git","clone_url":"https://github.com/ifmeorg/ifme.git","svn_url":"https://github.com/ifmeorg/ifme","homepage":"http://www.if-me.org/","size":34089,"stargazers_count":714,"watchers_count":714,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":404,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":404,"open_issues":84,"watchers":714,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ifmeorg/ifme/pulls/1142"},"html":{"href":"https://github.com/ifmeorg/ifme/pull/1142"},"issue":{"href":"https://api.github.com/repos/ifmeorg/ifme/issues/1142"},"comments":{"href":"https://api.github.com/repos/ifmeorg/ifme/issues/1142/comments"},"review_comments":{"href":"https://api.github.com/repos/ifmeorg/ifme/pulls/1142/comments"},"review_comment":{"href":"https://api.github.com/repos/ifmeorg/ifme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ifmeorg/ifme/pulls/1142/commits"},"statuses":{"href":"https://api.github.com/repos/ifmeorg/ifme/statuses/f9433675ffe35ca647f7ddf7c6c5271617db9821"}},"author_association":"NONE"}}
{"actor":{"display_login":"julianguyen"}}