{"action":"closed","number":13362,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13362","id":232802449,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODAyNDQ5","html_url":"https://github.com/apache/incubator-mxnet/pull/13362","diff_url":"https://github.com/apache/incubator-mxnet/pull/13362.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/13362.patch","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/13362","number":13362,"state":"closed","locked":false,"title":"Add NHWC layout support to Pooling (cuDNN only)","user":{"login":"ptrendx","id":8398980,"node_id":"MDQ6VXNlcjgzOTg5ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/8398980?v=4","gravatar_id":"","url":"https://api.github.com/users/ptrendx","html_url":"https://github.com/ptrendx","followers_url":"https://api.github.com/users/ptrendx/followers","following_url":"https://api.github.com/users/ptrendx/following{/other_user}","gists_url":"https://api.github.com/users/ptrendx/gists{/gist_id}","starred_url":"https://api.github.com/users/ptrendx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptrendx/subscriptions","organizations_url":"https://api.github.com/users/ptrendx/orgs","repos_url":"https://api.github.com/users/ptrendx/repos","events_url":"https://api.github.com/users/ptrendx/events{/privacy}","received_events_url":"https://api.github.com/users/ptrendx/received_events","type":"User","site_admin":false},"body":"## Description ##\r\nThis PR adds NHWC layout support to Pooling operator. Work mostly done by @DickJC123 \r\n\r\nTraining using TensorCores is more efficient when using NHWC data layout. Convolutions and BatchNorm operators in MXNet already have support for NHWC, while Pooling operator currently accepts only NCHW format. This PR introduces NHWC layout support for Pooling when using cuDNN.\r\n\r\nThis PR is part of upstreaming improvements available in NVIDIA's NGC MXNet container and was tested as part of it to train multiple convnets to expected accuracy. We also introduced additional tests checking consistency between NHWC and NCHW versions of pooling.\r\n\r\n## Checklist ##\r\n### Essentials ###\r\nPlease feel free to remove inapplicable items for your PR.\r\n- [x] Changes are complete (i.e. I finished coding on this PR)\r\n- [x] All changes have test coverage:\r\n- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)\r\n- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)\r\n- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)\r\n- [x] Code is well-documented: \r\n- For user-facing API changes, API doc string has been updated. \r\n- For new C++ functions in header files, their functionalities and arguments are documented. \r\n- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable\r\n- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html\r\n- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change\r\n\r\n## Comments ##\r\n- Support for channel last is done only when cuDNN is enabled (noted in the updated documentation)\r\n","created_at":"2018-11-21T21:28:37Z","updated_at":"2018-12-31T01:32:40Z","closed_at":"2018-12-31T01:32:40Z","merged_at":null,"merge_commit_sha":"0691473a315845668df32009bb3ce76799ab5e74","assignee":null,"assignees":[],"requested_reviewers":[{"login":"szha","id":2626883,"node_id":"MDQ6VXNlcjI2MjY4ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/2626883?v=4","gravatar_id":"","url":"https://api.github.com/users/szha","html_url":"https://github.com/szha","followers_url":"https://api.github.com/users/szha/followers","following_url":"https://api.github.com/users/szha/following{/other_user}","gists_url":"https://api.github.com/users/szha/gists{/gist_id}","starred_url":"https://api.github.com/users/szha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szha/subscriptions","organizations_url":"https://api.github.com/users/szha/orgs","repos_url":"https://api.github.com/users/szha/repos","events_url":"https://api.github.com/users/szha/events{/privacy}","received_events_url":"https://api.github.com/users/szha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":707556574,"node_id":"MDU6TGFiZWw3MDc1NTY1NzQ=","url":"https://api.github.com/repos/apache/incubator-mxnet/labels/Operator","name":"Operator","color":"fbca04","default":false},{"id":1018798522,"node_id":"MDU6TGFiZWwxMDE4Nzk4NTIy","url":"https://api.github.com/repos/apache/incubator-mxnet/labels/pr-awaiting-review","name":"pr-awaiting-review","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13362/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13362/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/13362/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/7fcbdac1281b8ff819e2c173b124dec9a3365e20","head":{"label":"ptrendx:pr_nhwc_pooling","ref":"pr_nhwc_pooling","sha":"7fcbdac1281b8ff819e2c173b124dec9a3365e20","user":{"login":"ptrendx","id":8398980,"node_id":"MDQ6VXNlcjgzOTg5ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/8398980?v=4","gravatar_id":"","url":"https://api.github.com/users/ptrendx","html_url":"https://github.com/ptrendx","followers_url":"https://api.github.com/users/ptrendx/followers","following_url":"https://api.github.com/users/ptrendx/following{/other_user}","gists_url":"https://api.github.com/users/ptrendx/gists{/gist_id}","starred_url":"https://api.github.com/users/ptrendx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptrendx/subscriptions","organizations_url":"https://api.github.com/users/ptrendx/orgs","repos_url":"https://api.github.com/users/ptrendx/repos","events_url":"https://api.github.com/users/ptrendx/events{/privacy}","received_events_url":"https://api.github.com/users/ptrendx/received_events","type":"User","site_admin":false},"repo":{"id":76683609,"node_id":"MDEwOlJlcG9zaXRvcnk3NjY4MzYwOQ==","name":"mxnet","full_name":"ptrendx/mxnet","private":false,"owner":{"login":"ptrendx","id":8398980,"node_id":"MDQ6VXNlcjgzOTg5ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/8398980?v=4","gravatar_id":"","url":"https://api.github.com/users/ptrendx","html_url":"https://github.com/ptrendx","followers_url":"https://api.github.com/users/ptrendx/followers","following_url":"https://api.github.com/users/ptrendx/following{/other_user}","gists_url":"https://api.github.com/users/ptrendx/gists{/gist_id}","starred_url":"https://api.github.com/users/ptrendx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptrendx/subscriptions","organizations_url":"https://api.github.com/users/ptrendx/orgs","repos_url":"https://api.github.com/users/ptrendx/repos","events_url":"https://api.github.com/users/ptrendx/events{/privacy}","received_events_url":"https://api.github.com/users/ptrendx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ptrendx/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/ptrendx/mxnet","forks_url":"https://api.github.com/repos/ptrendx/mxnet/forks","keys_url":"https://api.github.com/repos/ptrendx/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ptrendx/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ptrendx/mxnet/teams","hooks_url":"https://api.github.com/repos/ptrendx/mxnet/hooks","issue_events_url":"https://api.github.com/repos/ptrendx/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/ptrendx/mxnet/events","assignees_url":"https://api.github.com/repos/ptrendx/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/ptrendx/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/ptrendx/mxnet/tags","blobs_url":"https://api.github.com/repos/ptrendx/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ptrendx/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ptrendx/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ptrendx/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ptrendx/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/ptrendx/mxnet/languages","stargazers_url":"https://api.github.com/repos/ptrendx/mxnet/stargazers","contributors_url":"https://api.github.com/repos/ptrendx/mxnet/contributors","subscribers_url":"https://api.github.com/repos/ptrendx/mxnet/subscribers","subscription_url":"https://api.github.com/repos/ptrendx/mxnet/subscription","commits_url":"https://api.github.com/repos/ptrendx/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ptrendx/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ptrendx/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ptrendx/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ptrendx/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/ptrendx/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ptrendx/mxnet/merges","archive_url":"https://api.github.com/repos/ptrendx/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ptrendx/mxnet/downloads","issues_url":"https://api.github.com/repos/ptrendx/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/ptrendx/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/ptrendx/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/ptrendx/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ptrendx/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/ptrendx/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/ptrendx/mxnet/deployments","created_at":"2016-12-16T20:29:59Z","updated_at":"2018-11-17T11:53:35Z","pushed_at":"2018-12-21T00:24:59Z","git_url":"git://github.com/ptrendx/mxnet.git","ssh_url":"git@github.com:ptrendx/mxnet.git","clone_url":"https://github.com/ptrendx/mxnet.git","svn_url":"https://github.com/ptrendx/mxnet","homepage":"http://mxnet.io","size":51055,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1e4afd53b7e92cacf0a174d2da8e8fb178da1bfd","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg2NDQwMg==","name":"incubator-mxnet","full_name":"apache/incubator-mxnet","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/apache/incubator-mxnet","forks_url":"https://api.github.com/repos/apache/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/apache/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/apache/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/apache/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2018-12-30T23:44:47Z","pushed_at":"2018-12-31T01:11:01Z","git_url":"git://github.com/apache/incubator-mxnet.git","ssh_url":"git@github.com:apache/incubator-mxnet.git","clone_url":"https://github.com/apache/incubator-mxnet.git","svn_url":"https://github.com/apache/incubator-mxnet","homepage":"https://mxnet.apache.org","size":51691,"stargazers_count":15919,"watchers_count":15919,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5773,"mirror_url":null,"archived":false,"open_issues_count":1006,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5773,"open_issues":1006,"watchers":15919,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13362"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/13362"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/13362"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/13362/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13362/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13362/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mxnet/statuses/7fcbdac1281b8ff819e2c173b124dec9a3365e20"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":28,"review_comments":26,"maintainer_can_modify":false,"commits":6,"additions":355,"deletions":158,"changed_files":6}}
{"actor":{"display_login":"ptrendx"}}