{"action":"created","issue":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/10455","repository_url":"https://api.github.com/repos/gatsbyjs/gatsby","labels_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/10455/labels{/name}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/10455/comments","events_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/10455/events","html_url":"https://github.com/gatsbyjs/gatsby/pull/10455","id":390757226,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDUxNTY1","number":10455,"title":"Upgrade `react-hot-loader` to 4.6","user":{"login":"jgierer12","id":4331946,"node_id":"MDQ6VXNlcjQzMzE5NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/4331946?v=4","gravatar_id":"","url":"https://api.github.com/users/jgierer12","html_url":"https://github.com/jgierer12","followers_url":"https://api.github.com/users/jgierer12/followers","following_url":"https://api.github.com/users/jgierer12/following{/other_user}","gists_url":"https://api.github.com/users/jgierer12/gists{/gist_id}","starred_url":"https://api.github.com/users/jgierer12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgierer12/subscriptions","organizations_url":"https://api.github.com/users/jgierer12/orgs","repos_url":"https://api.github.com/users/jgierer12/repos","events_url":"https://api.github.com/users/jgierer12/events{/privacy}","received_events_url":"https://api.github.com/users/jgierer12/received_events","type":"User","site_admin":false},"labels":[{"id":1030072314,"node_id":"MDU6TGFiZWwxMDMwMDcyMzE0","url":"https://api.github.com/repos/gatsbyjs/gatsby/labels/status:%20WIP","name":"status: WIP","color":"daf282","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-12-13T16:27:03Z","updated_at":"2018-12-13T19:13:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/10455","html_url":"https://github.com/gatsbyjs/gatsby/pull/10455","diff_url":"https://github.com/gatsbyjs/gatsby/pull/10455.diff","patch_url":"https://github.com/gatsbyjs/gatsby/pull/10455.patch"},"body":"Fixes #9489 \r\n\r\n~~The docs also [recommend](https://github.com/gaearon/react-hot-loader#react--dom) (but don't require) using a patched `react-dom`, but as I understand it that would override the user's `react-dom` version we have as a peer dependency so I left it out.~~ :arrow_right: https://github.com/gatsbyjs/gatsby/pull/10455/commits/3894f0a65c1684880e8723e9c6476a042e9c9cc3\r\n\r\n/cc @wKovacs64 "},"comment":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/comments/447085626","html_url":"https://github.com/gatsbyjs/gatsby/pull/10455#issuecomment-447085626","issue_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/10455","id":447085626,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzA4NTYyNg==","user":{"login":"DSchau","id":3924690,"node_id":"MDQ6VXNlcjM5MjQ2OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3924690?v=4","gravatar_id":"","url":"https://api.github.com/users/DSchau","html_url":"https://github.com/DSchau","followers_url":"https://api.github.com/users/DSchau/followers","following_url":"https://api.github.com/users/DSchau/following{/other_user}","gists_url":"https://api.github.com/users/DSchau/gists{/gist_id}","starred_url":"https://api.github.com/users/DSchau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSchau/subscriptions","organizations_url":"https://api.github.com/users/DSchau/orgs","repos_url":"https://api.github.com/users/DSchau/repos","events_url":"https://api.github.com/users/DSchau/events{/privacy}","received_events_url":"https://api.github.com/users/DSchau/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T19:13:07Z","updated_at":"2018-12-13T19:13:07Z","author_association":"CONTRIBUTOR","body":"Also I'm not sure we _want_ to implement the webpack loader as we've done in 3894f0a. I think we should prefer the babel loader, which we currently use.\r\n\r\nThis _was_ working with the babel loader, and there's some _spooky_ language about using the webpack plugin with class plugins.\r\n\r\n> We recommend to use babel plugin, but there are situations when you are unable to use it. Then - try webpack loader (as seen in v3), but remember - it is not compatible with class-based components, but help with TypeScript or spreading \"cold API\" to all node_modules."}}
{"actor":{"display_login":"DSchau"}}