{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt-jenkins/pulls/comments/175091423","pull_request_review_id":104567472,"id":175091423,"diff_hunk":"@@ -169,4 +175,4 @@ suites:\n           test_git_commit: <%= ENV['TRAVIS_BRANCH'] == 'master' ? 'develop' : ENV['TRAVIS_BRANCH'] %>\n           py3: true\n         windows.sls:\n-          virtualenv_path: 'c:\\Python36\\Scripts\\pip.exe'\n+          virtualenv_path: 'c:\\Program Files (x86)\\Python35-32\\Scripts\\pip.exe'","path":".kitchen.yml","position":39,"original_position":39,"commit_id":"7c731a3b4a386aa8ee0ea0558ea392104717c35b","original_commit_id":"7c731a3b4a386aa8ee0ea0558ea392104717c35b","user":{"login":"gtmanfred","id":732321,"avatar_url":"https://avatars0.githubusercontent.com/u/732321?v=4","gravatar_id":"","url":"https://api.github.com/users/gtmanfred","html_url":"https://github.com/gtmanfred","followers_url":"https://api.github.com/users/gtmanfred/followers","following_url":"https://api.github.com/users/gtmanfred/following{/other_user}","gists_url":"https://api.github.com/users/gtmanfred/gists{/gist_id}","starred_url":"https://api.github.com/users/gtmanfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtmanfred/subscriptions","organizations_url":"https://api.github.com/users/gtmanfred/orgs","repos_url":"https://api.github.com/users/gtmanfred/repos","events_url":"https://api.github.com/users/gtmanfred/events{/privacy}","received_events_url":"https://api.github.com/users/gtmanfred/received_events","type":"User","site_admin":false},"body":"does the Python27 also need to be fixed, or are we just using the python that comes with salt?","created_at":"2018-03-16T13:39:29Z","updated_at":"2018-03-16T13:42:04Z","html_url":"https://github.com/saltstack/salt-jenkins/pull/880#discussion_r175091423","pull_request_url":"https://api.github.com/repos/saltstack/salt-jenkins/pulls/880","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt-jenkins/pulls/comments/175091423"},"html":{"href":"https://github.com/saltstack/salt-jenkins/pull/880#discussion_r175091423"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt-jenkins/pulls/880"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt-jenkins/pulls/880","id":174557672,"html_url":"https://github.com/saltstack/salt-jenkins/pull/880","diff_url":"https://github.com/saltstack/salt-jenkins/pull/880.diff","patch_url":"https://github.com/saltstack/salt-jenkins/pull/880.patch","issue_url":"https://api.github.com/repos/saltstack/salt-jenkins/issues/880","number":880,"state":"open","locked":false,"title":"Fix vagrant builds","user":{"login":"dwoz","id":1527763,"avatar_url":"https://avatars3.githubusercontent.com/u/1527763?v=4","gravatar_id":"","url":"https://api.github.com/users/dwoz","html_url":"https://github.com/dwoz","followers_url":"https://api.github.com/users/dwoz/followers","following_url":"https://api.github.com/users/dwoz/following{/other_user}","gists_url":"https://api.github.com/users/dwoz/gists{/gist_id}","starred_url":"https://api.github.com/users/dwoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwoz/subscriptions","organizations_url":"https://api.github.com/users/dwoz/orgs","repos_url":"https://api.github.com/users/dwoz/repos","events_url":"https://api.github.com/users/dwoz/events{/privacy}","received_events_url":"https://api.github.com/users/dwoz/received_events","type":"User","site_admin":false},"body":"This PR fixes vagrant builds for salt-jenkins allowing converge to be run against a fresh windows image. Salt kitchen installs a minion from the windows installer. We then use salt-jenkins to bootstrap the Winrepo package repository. Having Winrepo available allows us to install git, a Microsoft compiler and a python to test against. Including the `windeps` state before git.salt will bootstrap the system.","created_at":"2018-03-13T04:51:23Z","updated_at":"2018-03-16T13:42:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbef62ac3038d75590e92c1ee61ea18a99d158f5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"twangboy","id":9383935,"avatar_url":"https://avatars3.githubusercontent.com/u/9383935?v=4","gravatar_id":"","url":"https://api.github.com/users/twangboy","html_url":"https://github.com/twangboy","followers_url":"https://api.github.com/users/twangboy/followers","following_url":"https://api.github.com/users/twangboy/following{/other_user}","gists_url":"https://api.github.com/users/twangboy/gists{/gist_id}","starred_url":"https://api.github.com/users/twangboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twangboy/subscriptions","organizations_url":"https://api.github.com/users/twangboy/orgs","repos_url":"https://api.github.com/users/twangboy/repos","events_url":"https://api.github.com/users/twangboy/events{/privacy}","received_events_url":"https://api.github.com/users/twangboy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt-jenkins/pulls/880/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt-jenkins/pulls/880/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt-jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt-jenkins/issues/880/comments","statuses_url":"https://api.github.com/repos/saltstack/salt-jenkins/statuses/7c731a3b4a386aa8ee0ea0558ea392104717c35b","head":{"label":"dwoz:vagrant","ref":"vagrant","sha":"7c731a3b4a386aa8ee0ea0558ea392104717c35b","user":{"login":"dwoz","id":1527763,"avatar_url":"https://avatars3.githubusercontent.com/u/1527763?v=4","gravatar_id":"","url":"https://api.github.com/users/dwoz","html_url":"https://github.com/dwoz","followers_url":"https://api.github.com/users/dwoz/followers","following_url":"https://api.github.com/users/dwoz/following{/other_user}","gists_url":"https://api.github.com/users/dwoz/gists{/gist_id}","starred_url":"https://api.github.com/users/dwoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwoz/subscriptions","organizations_url":"https://api.github.com/users/dwoz/orgs","repos_url":"https://api.github.com/users/dwoz/repos","events_url":"https://api.github.com/users/dwoz/events{/privacy}","received_events_url":"https://api.github.com/users/dwoz/received_events","type":"User","site_admin":false},"repo":{"id":123173801,"name":"salt-jenkins","full_name":"dwoz/salt-jenkins","owner":{"login":"dwoz","id":1527763,"avatar_url":"https://avatars3.githubusercontent.com/u/1527763?v=4","gravatar_id":"","url":"https://api.github.com/users/dwoz","html_url":"https://github.com/dwoz","followers_url":"https://api.github.com/users/dwoz/followers","following_url":"https://api.github.com/users/dwoz/following{/other_user}","gists_url":"https://api.github.com/users/dwoz/gists{/gist_id}","starred_url":"https://api.github.com/users/dwoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwoz/subscriptions","organizations_url":"https://api.github.com/users/dwoz/orgs","repos_url":"https://api.github.com/users/dwoz/repos","events_url":"https://api.github.com/users/dwoz/events{/privacy}","received_events_url":"https://api.github.com/users/dwoz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwoz/salt-jenkins","description":"Salt states used to run jenkins tests","fork":true,"url":"https://api.github.com/repos/dwoz/salt-jenkins","forks_url":"https://api.github.com/repos/dwoz/salt-jenkins/forks","keys_url":"https://api.github.com/repos/dwoz/salt-jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwoz/salt-jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwoz/salt-jenkins/teams","hooks_url":"https://api.github.com/repos/dwoz/salt-jenkins/hooks","issue_events_url":"https://api.github.com/repos/dwoz/salt-jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/dwoz/salt-jenkins/events","assignees_url":"https://api.github.com/repos/dwoz/salt-jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/dwoz/salt-jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/dwoz/salt-jenkins/tags","blobs_url":"https://api.github.com/repos/dwoz/salt-jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwoz/salt-jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwoz/salt-jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwoz/salt-jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwoz/salt-jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/dwoz/salt-jenkins/languages","stargazers_url":"https://api.github.com/repos/dwoz/salt-jenkins/stargazers","contributors_url":"https://api.github.com/repos/dwoz/salt-jenkins/contributors","subscribers_url":"https://api.github.com/repos/dwoz/salt-jenkins/subscribers","subscription_url":"https://api.github.com/repos/dwoz/salt-jenkins/subscription","commits_url":"https://api.github.com/repos/dwoz/salt-jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwoz/salt-jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwoz/salt-jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwoz/salt-jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwoz/salt-jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/dwoz/salt-jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwoz/salt-jenkins/merges","archive_url":"https://api.github.com/repos/dwoz/salt-jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwoz/salt-jenkins/downloads","issues_url":"https://api.github.com/repos/dwoz/salt-jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/dwoz/salt-jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/dwoz/salt-jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/dwoz/salt-jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwoz/salt-jenkins/labels{/name}","releases_url":"https://api.github.com/repos/dwoz/salt-jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/dwoz/salt-jenkins/deployments","created_at":"2018-02-27T18:56:01Z","updated_at":"2018-02-27T18:56:03Z","pushed_at":"2018-03-16T07:45:33Z","git_url":"git://github.com/dwoz/salt-jenkins.git","ssh_url":"git@github.com:dwoz/salt-jenkins.git","clone_url":"https://github.com/dwoz/salt-jenkins.git","svn_url":"https://github.com/dwoz/salt-jenkins","homepage":null,"size":2036,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saltstack:2017.7","ref":"2017.7","sha":"d9a7b5e52cd72e230a3dbbedf0f35ab4d3c4d585","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":12017151,"name":"salt-jenkins","full_name":"saltstack/salt-jenkins","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt-jenkins","description":"Salt states used to run jenkins tests","fork":false,"url":"https://api.github.com/repos/saltstack/salt-jenkins","forks_url":"https://api.github.com/repos/saltstack/salt-jenkins/forks","keys_url":"https://api.github.com/repos/saltstack/salt-jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt-jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt-jenkins/teams","hooks_url":"https://api.github.com/repos/saltstack/salt-jenkins/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt-jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt-jenkins/events","assignees_url":"https://api.github.com/repos/saltstack/salt-jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt-jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt-jenkins/tags","blobs_url":"https://api.github.com/repos/saltstack/salt-jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt-jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt-jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt-jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt-jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt-jenkins/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt-jenkins/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt-jenkins/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt-jenkins/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt-jenkins/subscription","commits_url":"https://api.github.com/repos/saltstack/salt-jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt-jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt-jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt-jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt-jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt-jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt-jenkins/merges","archive_url":"https://api.github.com/repos/saltstack/salt-jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt-jenkins/downloads","issues_url":"https://api.github.com/repos/saltstack/salt-jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt-jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt-jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt-jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt-jenkins/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt-jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt-jenkins/deployments","created_at":"2013-08-10T07:10:38Z","updated_at":"2018-03-12T21:50:13Z","pushed_at":"2018-03-16T06:02:57Z","git_url":"git://github.com/saltstack/salt-jenkins.git","ssh_url":"git@github.com:saltstack/salt-jenkins.git","clone_url":"https://github.com/saltstack/salt-jenkins.git","svn_url":"https://github.com/saltstack/salt-jenkins","homepage":null,"size":2033,"stargazers_count":43,"watchers_count":43,"language":"SaltStack","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":26,"license":null,"forks":45,"open_issues":26,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt-jenkins/pulls/880"},"html":{"href":"https://github.com/saltstack/salt-jenkins/pull/880"},"issue":{"href":"https://api.github.com/repos/saltstack/salt-jenkins/issues/880"},"comments":{"href":"https://api.github.com/repos/saltstack/salt-jenkins/issues/880/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt-jenkins/pulls/880/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt-jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt-jenkins/pulls/880/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt-jenkins/statuses/7c731a3b4a386aa8ee0ea0558ea392104717c35b"}},"author_association":"NONE"}}
{"actor":{"display_login":"gtmanfred"}}