{"action":"created","issue":{"url":"https://api.github.com/repos/cellml/libcellml/issues/248","repository_url":"https://api.github.com/repos/cellml/libcellml","labels_url":"https://api.github.com/repos/cellml/libcellml/issues/248/labels{/name}","comments_url":"https://api.github.com/repos/cellml/libcellml/issues/248/comments","events_url":"https://api.github.com/repos/cellml/libcellml/issues/248/events","html_url":"https://github.com/cellml/libcellml/pull/248","id":341736733,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODAzODU0","number":248,"title":"Imports revisited","user":{"login":"hsorby","id":778048,"node_id":"MDQ6VXNlcjc3ODA0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/778048?v=4","gravatar_id":"","url":"https://api.github.com/users/hsorby","html_url":"https://github.com/hsorby","followers_url":"https://api.github.com/users/hsorby/followers","following_url":"https://api.github.com/users/hsorby/following{/other_user}","gists_url":"https://api.github.com/users/hsorby/gists{/gist_id}","starred_url":"https://api.github.com/users/hsorby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsorby/subscriptions","organizations_url":"https://api.github.com/users/hsorby/orgs","repos_url":"https://api.github.com/users/hsorby/repos","events_url":"https://api.github.com/users/hsorby/events{/privacy}","received_events_url":"https://api.github.com/users/hsorby/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-17T01:52:40Z","updated_at":"2018-07-21T00:45:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cellml/libcellml/pulls/248","html_url":"https://github.com/cellml/libcellml/pull/248","diff_url":"https://github.com/cellml/libcellml/pull/248.diff","patch_url":"https://github.com/cellml/libcellml/pull/248.patch"},"body":"Moving @nickerso work from outside the library to inside.  The added import functionality only works for local on disk imports.\r\n\r\nAddresses #238.\r\n\r\nThis PR supersedes #167, should this PR be merged then #167 should be closed and not merged."},"comment":{"url":"https://api.github.com/repos/cellml/libcellml/issues/comments/406758055","html_url":"https://github.com/cellml/libcellml/pull/248#issuecomment-406758055","issue_url":"https://api.github.com/repos/cellml/libcellml/issues/248","id":406758055,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjc1ODA1NQ==","user":{"login":"nickerso","id":811244,"node_id":"MDQ6VXNlcjgxMTI0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/811244?v=4","gravatar_id":"","url":"https://api.github.com/users/nickerso","html_url":"https://github.com/nickerso","followers_url":"https://api.github.com/users/nickerso/followers","following_url":"https://api.github.com/users/nickerso/following{/other_user}","gists_url":"https://api.github.com/users/nickerso/gists{/gist_id}","starred_url":"https://api.github.com/users/nickerso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickerso/subscriptions","organizations_url":"https://api.github.com/users/nickerso/orgs","repos_url":"https://api.github.com/users/nickerso/repos","events_url":"https://api.github.com/users/nickerso/events{/privacy}","received_events_url":"https://api.github.com/users/nickerso/received_events","type":"User","site_admin":false},"created_at":"2018-07-21T00:45:41Z","updated_at":"2018-07-21T00:45:41Z","author_association":"CONTRIBUTOR","body":"The introduction of the `enable_share_from_this` is giving me the below warning with VS 2017 every time `model.h` is included.\r\n\r\n```\r\n3>c:\\users\\...\\libcellml\\src\\api\\libcellml\\model.h(36): warning C4251: 'std::enable_shared_from_this<libcellml::Model>::_Wptr': class 'std::weak_ptr<_Ty>' needs to have dll-interface to be used by clients of class 'std::enable_shared_from_this<libcellml::Model>'\r\n3>        with\r\n3>        [\r\n3>            _Ty=libcellml::Model\r\n3>        ]\r\n3>c:\\program files (x86)\\microsoft visual studio\\2017\\community\\vc\\tools\\msvc\\14.14.26428\\include\\memory(2000): note: see declaration of 'std::weak_ptr<_Ty>'\r\n3>        with\r\n3>        [\r\n3>            _Ty=libcellml::Model\r\n3>        ]\r\n```"}}
{"actor":{"display_login":"nickerso"}}