{"action":"created","comment":{"url":"https://api.github.com/repos/opesci/devito/pulls/comments/175124434","pull_request_review_id":104608289,"id":175124434,"diff_hunk":"@@ -86,16 +86,9 @@ def detect_flow_directions(exprs):\n     mapper.update({d: {Any} for d in flatten(i.aindices for i in reads + writes)\n                    if d is not None and d not in mapper})\n \n-    # Add in stepping dimensions (just in case they haven't been detected yet)\n-    # note: stepping dimensions may force a direction on the parent\n-    assert all(v == {Any} or mapper.get(k.parent, v) in [v, {Any}]\n-               for k, v in mapper.items() if k.is_Stepping)\n+    # Add in derived-dimensions parents, in case they haven't been detected yet","path":"devito/ir/support/utils.py","position":null,"original_position":8,"commit_id":"d9f7922a7b61adb2b7f6f31d5655c53ef9a061e5","original_commit_id":"d9f7922a7b61adb2b7f6f31d5655c53ef9a061e5","user":{"login":"mloubout","id":5702350,"avatar_url":"https://avatars3.githubusercontent.com/u/5702350?v=4","gravatar_id":"","url":"https://api.github.com/users/mloubout","html_url":"https://github.com/mloubout","followers_url":"https://api.github.com/users/mloubout/followers","following_url":"https://api.github.com/users/mloubout/following{/other_user}","gists_url":"https://api.github.com/users/mloubout/gists{/gist_id}","starred_url":"https://api.github.com/users/mloubout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mloubout/subscriptions","organizations_url":"https://api.github.com/users/mloubout/orgs","repos_url":"https://api.github.com/users/mloubout/repos","events_url":"https://api.github.com/users/mloubout/events{/privacy}","received_events_url":"https://api.github.com/users/mloubout/received_events","type":"User","site_admin":false},"body":"There is few other issue with `detect_flow_directions` I'm trying to create example for","created_at":"2018-03-16T15:22:05Z","updated_at":"2018-03-16T15:22:05Z","html_url":"https://github.com/opesci/devito/pull/517#discussion_r175124434","pull_request_url":"https://api.github.com/repos/opesci/devito/pulls/517","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/opesci/devito/pulls/comments/175124434"},"html":{"href":"https://github.com/opesci/devito/pull/517#discussion_r175124434"},"pull_request":{"href":"https://api.github.com/repos/opesci/devito/pulls/517"}},"in_reply_to_id":175116289},"pull_request":{"url":"https://api.github.com/repos/opesci/devito/pulls/517","id":175543829,"html_url":"https://github.com/opesci/devito/pull/517","diff_url":"https://github.com/opesci/devito/pull/517.diff","patch_url":"https://github.com/opesci/devito/pull/517.patch","issue_url":"https://api.github.com/repos/opesci/devito/issues/517","number":517,"state":"open","locked":false,"title":"fix detection of functions in presence of indirections","user":{"login":"FabioLuporini","id":478143,"avatar_url":"https://avatars3.githubusercontent.com/u/478143?v=4","gravatar_id":"","url":"https://api.github.com/users/FabioLuporini","html_url":"https://github.com/FabioLuporini","followers_url":"https://api.github.com/users/FabioLuporini/followers","following_url":"https://api.github.com/users/FabioLuporini/following{/other_user}","gists_url":"https://api.github.com/users/FabioLuporini/gists{/gist_id}","starred_url":"https://api.github.com/users/FabioLuporini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FabioLuporini/subscriptions","organizations_url":"https://api.github.com/users/FabioLuporini/orgs","repos_url":"https://api.github.com/users/FabioLuporini/repos","events_url":"https://api.github.com/users/FabioLuporini/events{/privacy}","received_events_url":"https://api.github.com/users/FabioLuporini/received_events","type":"User","site_admin":false},"body":"depends on #512 \r\n\r\nfixes #505 \r\n\r\ntook the opportunity for some refactoring\r\n\r\nEDIT: now also\r\n\r\nfixes #513 \r\n\r\n(@tjb900 @mloubout these were bugs you raised; not sure if Travis will be green because I'm at the airport on battery and I've only run a quick sample of them)","created_at":"2018-03-16T14:11:04Z","updated_at":"2018-03-16T15:22:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47b0c4f4b3388267465e1a612428302e0ae911a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opesci/devito/pulls/517/commits","review_comments_url":"https://api.github.com/repos/opesci/devito/pulls/517/comments","review_comment_url":"https://api.github.com/repos/opesci/devito/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opesci/devito/issues/517/comments","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/d9f7922a7b61adb2b7f6f31d5655c53ef9a061e5","head":{"label":"opesci:fix-operator-creation","ref":"fix-operator-creation","sha":"d9f7922a7b61adb2b7f6f31d5655c53ef9a061e5","user":{"login":"opesci","id":10018551,"avatar_url":"https://avatars1.githubusercontent.com/u/10018551?v=4","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"repo":{"id":54585666,"name":"devito","full_name":"opesci/devito","owner":{"login":"opesci","id":10018551,"avatar_url":"https://avatars1.githubusercontent.com/u/10018551?v=4","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opesci/devito","description":"Code generation framework for automated finite difference computation","fork":false,"url":"https://api.github.com/repos/opesci/devito","forks_url":"https://api.github.com/repos/opesci/devito/forks","keys_url":"https://api.github.com/repos/opesci/devito/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opesci/devito/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opesci/devito/teams","hooks_url":"https://api.github.com/repos/opesci/devito/hooks","issue_events_url":"https://api.github.com/repos/opesci/devito/issues/events{/number}","events_url":"https://api.github.com/repos/opesci/devito/events","assignees_url":"https://api.github.com/repos/opesci/devito/assignees{/user}","branches_url":"https://api.github.com/repos/opesci/devito/branches{/branch}","tags_url":"https://api.github.com/repos/opesci/devito/tags","blobs_url":"https://api.github.com/repos/opesci/devito/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opesci/devito/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opesci/devito/git/refs{/sha}","trees_url":"https://api.github.com/repos/opesci/devito/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/{sha}","languages_url":"https://api.github.com/repos/opesci/devito/languages","stargazers_url":"https://api.github.com/repos/opesci/devito/stargazers","contributors_url":"https://api.github.com/repos/opesci/devito/contributors","subscribers_url":"https://api.github.com/repos/opesci/devito/subscribers","subscription_url":"https://api.github.com/repos/opesci/devito/subscription","commits_url":"https://api.github.com/repos/opesci/devito/commits{/sha}","git_commits_url":"https://api.github.com/repos/opesci/devito/git/commits{/sha}","comments_url":"https://api.github.com/repos/opesci/devito/comments{/number}","issue_comment_url":"https://api.github.com/repos/opesci/devito/issues/comments{/number}","contents_url":"https://api.github.com/repos/opesci/devito/contents/{+path}","compare_url":"https://api.github.com/repos/opesci/devito/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opesci/devito/merges","archive_url":"https://api.github.com/repos/opesci/devito/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opesci/devito/downloads","issues_url":"https://api.github.com/repos/opesci/devito/issues{/number}","pulls_url":"https://api.github.com/repos/opesci/devito/pulls{/number}","milestones_url":"https://api.github.com/repos/opesci/devito/milestones{/number}","notifications_url":"https://api.github.com/repos/opesci/devito/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opesci/devito/labels{/name}","releases_url":"https://api.github.com/repos/opesci/devito/releases{/id}","deployments_url":"https://api.github.com/repos/opesci/devito/deployments","created_at":"2016-03-23T18:59:49Z","updated_at":"2018-03-14T09:11:50Z","pushed_at":"2018-03-16T14:55:22Z","git_url":"git://github.com/opesci/devito.git","ssh_url":"git@github.com:opesci/devito.git","clone_url":"https://github.com/opesci/devito.git","svn_url":"https://github.com/opesci/devito","homepage":"http://www.opesci.org/devito-public","size":43981,"stargazers_count":49,"watchers_count":49,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":38,"watchers":49,"default_branch":"master"}},"base":{"label":"opesci:master","ref":"master","sha":"11eb71741ae8d837ea1d53f665a5037b54d4c446","user":{"login":"opesci","id":10018551,"avatar_url":"https://avatars1.githubusercontent.com/u/10018551?v=4","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"repo":{"id":54585666,"name":"devito","full_name":"opesci/devito","owner":{"login":"opesci","id":10018551,"avatar_url":"https://avatars1.githubusercontent.com/u/10018551?v=4","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opesci/devito","description":"Code generation framework for automated finite difference computation","fork":false,"url":"https://api.github.com/repos/opesci/devito","forks_url":"https://api.github.com/repos/opesci/devito/forks","keys_url":"https://api.github.com/repos/opesci/devito/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opesci/devito/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opesci/devito/teams","hooks_url":"https://api.github.com/repos/opesci/devito/hooks","issue_events_url":"https://api.github.com/repos/opesci/devito/issues/events{/number}","events_url":"https://api.github.com/repos/opesci/devito/events","assignees_url":"https://api.github.com/repos/opesci/devito/assignees{/user}","branches_url":"https://api.github.com/repos/opesci/devito/branches{/branch}","tags_url":"https://api.github.com/repos/opesci/devito/tags","blobs_url":"https://api.github.com/repos/opesci/devito/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opesci/devito/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opesci/devito/git/refs{/sha}","trees_url":"https://api.github.com/repos/opesci/devito/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/{sha}","languages_url":"https://api.github.com/repos/opesci/devito/languages","stargazers_url":"https://api.github.com/repos/opesci/devito/stargazers","contributors_url":"https://api.github.com/repos/opesci/devito/contributors","subscribers_url":"https://api.github.com/repos/opesci/devito/subscribers","subscription_url":"https://api.github.com/repos/opesci/devito/subscription","commits_url":"https://api.github.com/repos/opesci/devito/commits{/sha}","git_commits_url":"https://api.github.com/repos/opesci/devito/git/commits{/sha}","comments_url":"https://api.github.com/repos/opesci/devito/comments{/number}","issue_comment_url":"https://api.github.com/repos/opesci/devito/issues/comments{/number}","contents_url":"https://api.github.com/repos/opesci/devito/contents/{+path}","compare_url":"https://api.github.com/repos/opesci/devito/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opesci/devito/merges","archive_url":"https://api.github.com/repos/opesci/devito/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opesci/devito/downloads","issues_url":"https://api.github.com/repos/opesci/devito/issues{/number}","pulls_url":"https://api.github.com/repos/opesci/devito/pulls{/number}","milestones_url":"https://api.github.com/repos/opesci/devito/milestones{/number}","notifications_url":"https://api.github.com/repos/opesci/devito/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opesci/devito/labels{/name}","releases_url":"https://api.github.com/repos/opesci/devito/releases{/id}","deployments_url":"https://api.github.com/repos/opesci/devito/deployments","created_at":"2016-03-23T18:59:49Z","updated_at":"2018-03-14T09:11:50Z","pushed_at":"2018-03-16T14:55:22Z","git_url":"git://github.com/opesci/devito.git","ssh_url":"git@github.com:opesci/devito.git","clone_url":"https://github.com/opesci/devito.git","svn_url":"https://github.com/opesci/devito","homepage":"http://www.opesci.org/devito-public","size":43981,"stargazers_count":49,"watchers_count":49,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":38,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opesci/devito/pulls/517"},"html":{"href":"https://github.com/opesci/devito/pull/517"},"issue":{"href":"https://api.github.com/repos/opesci/devito/issues/517"},"comments":{"href":"https://api.github.com/repos/opesci/devito/issues/517/comments"},"review_comments":{"href":"https://api.github.com/repos/opesci/devito/pulls/517/comments"},"review_comment":{"href":"https://api.github.com/repos/opesci/devito/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opesci/devito/pulls/517/commits"},"statuses":{"href":"https://api.github.com/repos/opesci/devito/statuses/d9f7922a7b61adb2b7f6f31d5655c53ef9a061e5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mloubout"}}