{"action":"created","comment":{"url":"https://api.github.com/repos/taverntesting/tavern/pulls/comments/205937008","pull_request_review_id":141311190,"id":205937008,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTkzNzAwOA==","diff_hunk":"@@ -301,12 +301,28 @@ def _format_err(which):\n                 except KeyError:\n                     logger.debug(\"Skipping comparing missing key %s due to strict=%s\", key, strict)\n         elif isinstance(expected_val, list):\n-            if len(expected_val) != len(actual_val):\n-                raise_from(exceptions.KeyMismatchError(\"Length of returned list was different than expected - expected {} items, got {} ({})\".format(len(expected_val), len(actual_val), full_err())), e)\n-\n             # TODO\n             # Check things in the wrong order?\n \n+            if not strict:\n+                # Iterate over list items to see if any of them match...\n+                for i, e_val in enumerate(expected_val):\n+                    for a_val in actual_val:\n+                        try:\n+                            check_keys_match_recursive(e_val, a_val, keys + [i], strict)\n+                        except exceptions.KeyMismatchError:\n+                            pass\n+                        else:\n+                            logger.debug(\"One (or more) list items present - continuing due to strict=%s\", strict)\n+                            # TODO\n+                            # do we need to check more here?","path":"tavern/util/dict_util.py","position":21,"original_position":21,"commit_id":"fcec9fff432cb2b49d96202be0f47779b407ca0f","original_commit_id":"fcec9fff432cb2b49d96202be0f47779b407ca0f","user":{"login":"benhowes","id":471170,"node_id":"MDQ6VXNlcjQ3MTE3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/471170?v=4","gravatar_id":"","url":"https://api.github.com/users/benhowes","html_url":"https://github.com/benhowes","followers_url":"https://api.github.com/users/benhowes/followers","following_url":"https://api.github.com/users/benhowes/following{/other_user}","gists_url":"https://api.github.com/users/benhowes/gists{/gist_id}","starred_url":"https://api.github.com/users/benhowes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhowes/subscriptions","organizations_url":"https://api.github.com/users/benhowes/orgs","repos_url":"https://api.github.com/users/benhowes/repos","events_url":"https://api.github.com/users/benhowes/events{/privacy}","received_events_url":"https://api.github.com/users/benhowes/received_events","type":"User","site_admin":false},"body":"What were you thinking here?","created_at":"2018-07-28T08:14:33Z","updated_at":"2018-07-28T08:16:19Z","html_url":"https://github.com/taverntesting/tavern/pull/162#discussion_r205937008","pull_request_url":"https://api.github.com/repos/taverntesting/tavern/pulls/162","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/taverntesting/tavern/pulls/comments/205937008"},"html":{"href":"https://github.com/taverntesting/tavern/pull/162#discussion_r205937008"},"pull_request":{"href":"https://api.github.com/repos/taverntesting/tavern/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/taverntesting/tavern/pulls/162","id":204427620,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDI3NjIw","html_url":"https://github.com/taverntesting/tavern/pull/162","diff_url":"https://github.com/taverntesting/tavern/pull/162.diff","patch_url":"https://github.com/taverntesting/tavern/pull/162.patch","issue_url":"https://api.github.com/repos/taverntesting/tavern/issues/162","number":162,"state":"open","locked":false,"title":"Feature/list strictness change","user":{"login":"michaelboulton","id":3809868,"node_id":"MDQ6VXNlcjM4MDk4Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/3809868?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelboulton","html_url":"https://github.com/michaelboulton","followers_url":"https://api.github.com/users/michaelboulton/followers","following_url":"https://api.github.com/users/michaelboulton/following{/other_user}","gists_url":"https://api.github.com/users/michaelboulton/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelboulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelboulton/subscriptions","organizations_url":"https://api.github.com/users/michaelboulton/orgs","repos_url":"https://api.github.com/users/michaelboulton/repos","events_url":"https://api.github.com/users/michaelboulton/events{/privacy}","received_events_url":"https://api.github.com/users/michaelboulton/received_events","type":"User","site_admin":false},"body":"closes #133 ","created_at":"2018-07-27T13:11:57Z","updated_at":"2018-07-28T08:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33adcf4d1d781a89120539470cf4ddd85482bbe2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/taverntesting/tavern/pulls/162/commits","review_comments_url":"https://api.github.com/repos/taverntesting/tavern/pulls/162/comments","review_comment_url":"https://api.github.com/repos/taverntesting/tavern/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taverntesting/tavern/issues/162/comments","statuses_url":"https://api.github.com/repos/taverntesting/tavern/statuses/fcec9fff432cb2b49d96202be0f47779b407ca0f","head":{"label":"taverntesting:feature/list-strictness-change","ref":"feature/list-strictness-change","sha":"fcec9fff432cb2b49d96202be0f47779b407ca0f","user":{"login":"taverntesting","id":33286481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg2NDgx","avatar_url":"https://avatars1.githubusercontent.com/u/33286481?v=4","gravatar_id":"","url":"https://api.github.com/users/taverntesting","html_url":"https://github.com/taverntesting","followers_url":"https://api.github.com/users/taverntesting/followers","following_url":"https://api.github.com/users/taverntesting/following{/other_user}","gists_url":"https://api.github.com/users/taverntesting/gists{/gist_id}","starred_url":"https://api.github.com/users/taverntesting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taverntesting/subscriptions","organizations_url":"https://api.github.com/users/taverntesting/orgs","repos_url":"https://api.github.com/users/taverntesting/repos","events_url":"https://api.github.com/users/taverntesting/events{/privacy}","received_events_url":"https://api.github.com/users/taverntesting/received_events","type":"Organization","site_admin":false},"repo":{"id":109144395,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkxNDQzOTU=","name":"tavern","full_name":"taverntesting/tavern","owner":{"login":"taverntesting","id":33286481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg2NDgx","avatar_url":"https://avatars1.githubusercontent.com/u/33286481?v=4","gravatar_id":"","url":"https://api.github.com/users/taverntesting","html_url":"https://github.com/taverntesting","followers_url":"https://api.github.com/users/taverntesting/followers","following_url":"https://api.github.com/users/taverntesting/following{/other_user}","gists_url":"https://api.github.com/users/taverntesting/gists{/gist_id}","starred_url":"https://api.github.com/users/taverntesting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taverntesting/subscriptions","organizations_url":"https://api.github.com/users/taverntesting/orgs","repos_url":"https://api.github.com/users/taverntesting/repos","events_url":"https://api.github.com/users/taverntesting/events{/privacy}","received_events_url":"https://api.github.com/users/taverntesting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taverntesting/tavern","description":"A command-line tool and Python library and Pytest plugin for automated testing of RESTful APIs, with a simple, concise and flexible YAML-based syntax","fork":false,"url":"https://api.github.com/repos/taverntesting/tavern","forks_url":"https://api.github.com/repos/taverntesting/tavern/forks","keys_url":"https://api.github.com/repos/taverntesting/tavern/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taverntesting/tavern/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taverntesting/tavern/teams","hooks_url":"https://api.github.com/repos/taverntesting/tavern/hooks","issue_events_url":"https://api.github.com/repos/taverntesting/tavern/issues/events{/number}","events_url":"https://api.github.com/repos/taverntesting/tavern/events","assignees_url":"https://api.github.com/repos/taverntesting/tavern/assignees{/user}","branches_url":"https://api.github.com/repos/taverntesting/tavern/branches{/branch}","tags_url":"https://api.github.com/repos/taverntesting/tavern/tags","blobs_url":"https://api.github.com/repos/taverntesting/tavern/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taverntesting/tavern/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taverntesting/tavern/git/refs{/sha}","trees_url":"https://api.github.com/repos/taverntesting/tavern/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taverntesting/tavern/statuses/{sha}","languages_url":"https://api.github.com/repos/taverntesting/tavern/languages","stargazers_url":"https://api.github.com/repos/taverntesting/tavern/stargazers","contributors_url":"https://api.github.com/repos/taverntesting/tavern/contributors","subscribers_url":"https://api.github.com/repos/taverntesting/tavern/subscribers","subscription_url":"https://api.github.com/repos/taverntesting/tavern/subscription","commits_url":"https://api.github.com/repos/taverntesting/tavern/commits{/sha}","git_commits_url":"https://api.github.com/repos/taverntesting/tavern/git/commits{/sha}","comments_url":"https://api.github.com/repos/taverntesting/tavern/comments{/number}","issue_comment_url":"https://api.github.com/repos/taverntesting/tavern/issues/comments{/number}","contents_url":"https://api.github.com/repos/taverntesting/tavern/contents/{+path}","compare_url":"https://api.github.com/repos/taverntesting/tavern/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taverntesting/tavern/merges","archive_url":"https://api.github.com/repos/taverntesting/tavern/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taverntesting/tavern/downloads","issues_url":"https://api.github.com/repos/taverntesting/tavern/issues{/number}","pulls_url":"https://api.github.com/repos/taverntesting/tavern/pulls{/number}","milestones_url":"https://api.github.com/repos/taverntesting/tavern/milestones{/number}","notifications_url":"https://api.github.com/repos/taverntesting/tavern/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taverntesting/tavern/labels{/name}","releases_url":"https://api.github.com/repos/taverntesting/tavern/releases{/id}","deployments_url":"https://api.github.com/repos/taverntesting/tavern/deployments","created_at":"2017-11-01T14:51:25Z","updated_at":"2018-07-28T03:52:25Z","pushed_at":"2018-07-27T16:11:18Z","git_url":"git://github.com/taverntesting/tavern.git","ssh_url":"git@github.com:taverntesting/tavern.git","clone_url":"https://github.com/taverntesting/tavern.git","svn_url":"https://github.com/taverntesting/tavern","homepage":"https://taverntesting.github.io/","size":563,"stargazers_count":199,"watchers_count":199,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":31,"watchers":199,"default_branch":"master"}},"base":{"label":"taverntesting:master","ref":"master","sha":"e1b656bfdcd777d4f66e37fc33bec21e29d1bcea","user":{"login":"taverntesting","id":33286481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg2NDgx","avatar_url":"https://avatars1.githubusercontent.com/u/33286481?v=4","gravatar_id":"","url":"https://api.github.com/users/taverntesting","html_url":"https://github.com/taverntesting","followers_url":"https://api.github.com/users/taverntesting/followers","following_url":"https://api.github.com/users/taverntesting/following{/other_user}","gists_url":"https://api.github.com/users/taverntesting/gists{/gist_id}","starred_url":"https://api.github.com/users/taverntesting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taverntesting/subscriptions","organizations_url":"https://api.github.com/users/taverntesting/orgs","repos_url":"https://api.github.com/users/taverntesting/repos","events_url":"https://api.github.com/users/taverntesting/events{/privacy}","received_events_url":"https://api.github.com/users/taverntesting/received_events","type":"Organization","site_admin":false},"repo":{"id":109144395,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkxNDQzOTU=","name":"tavern","full_name":"taverntesting/tavern","owner":{"login":"taverntesting","id":33286481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg2NDgx","avatar_url":"https://avatars1.githubusercontent.com/u/33286481?v=4","gravatar_id":"","url":"https://api.github.com/users/taverntesting","html_url":"https://github.com/taverntesting","followers_url":"https://api.github.com/users/taverntesting/followers","following_url":"https://api.github.com/users/taverntesting/following{/other_user}","gists_url":"https://api.github.com/users/taverntesting/gists{/gist_id}","starred_url":"https://api.github.com/users/taverntesting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taverntesting/subscriptions","organizations_url":"https://api.github.com/users/taverntesting/orgs","repos_url":"https://api.github.com/users/taverntesting/repos","events_url":"https://api.github.com/users/taverntesting/events{/privacy}","received_events_url":"https://api.github.com/users/taverntesting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taverntesting/tavern","description":"A command-line tool and Python library and Pytest plugin for automated testing of RESTful APIs, with a simple, concise and flexible YAML-based syntax","fork":false,"url":"https://api.github.com/repos/taverntesting/tavern","forks_url":"https://api.github.com/repos/taverntesting/tavern/forks","keys_url":"https://api.github.com/repos/taverntesting/tavern/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taverntesting/tavern/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taverntesting/tavern/teams","hooks_url":"https://api.github.com/repos/taverntesting/tavern/hooks","issue_events_url":"https://api.github.com/repos/taverntesting/tavern/issues/events{/number}","events_url":"https://api.github.com/repos/taverntesting/tavern/events","assignees_url":"https://api.github.com/repos/taverntesting/tavern/assignees{/user}","branches_url":"https://api.github.com/repos/taverntesting/tavern/branches{/branch}","tags_url":"https://api.github.com/repos/taverntesting/tavern/tags","blobs_url":"https://api.github.com/repos/taverntesting/tavern/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taverntesting/tavern/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taverntesting/tavern/git/refs{/sha}","trees_url":"https://api.github.com/repos/taverntesting/tavern/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taverntesting/tavern/statuses/{sha}","languages_url":"https://api.github.com/repos/taverntesting/tavern/languages","stargazers_url":"https://api.github.com/repos/taverntesting/tavern/stargazers","contributors_url":"https://api.github.com/repos/taverntesting/tavern/contributors","subscribers_url":"https://api.github.com/repos/taverntesting/tavern/subscribers","subscription_url":"https://api.github.com/repos/taverntesting/tavern/subscription","commits_url":"https://api.github.com/repos/taverntesting/tavern/commits{/sha}","git_commits_url":"https://api.github.com/repos/taverntesting/tavern/git/commits{/sha}","comments_url":"https://api.github.com/repos/taverntesting/tavern/comments{/number}","issue_comment_url":"https://api.github.com/repos/taverntesting/tavern/issues/comments{/number}","contents_url":"https://api.github.com/repos/taverntesting/tavern/contents/{+path}","compare_url":"https://api.github.com/repos/taverntesting/tavern/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taverntesting/tavern/merges","archive_url":"https://api.github.com/repos/taverntesting/tavern/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taverntesting/tavern/downloads","issues_url":"https://api.github.com/repos/taverntesting/tavern/issues{/number}","pulls_url":"https://api.github.com/repos/taverntesting/tavern/pulls{/number}","milestones_url":"https://api.github.com/repos/taverntesting/tavern/milestones{/number}","notifications_url":"https://api.github.com/repos/taverntesting/tavern/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taverntesting/tavern/labels{/name}","releases_url":"https://api.github.com/repos/taverntesting/tavern/releases{/id}","deployments_url":"https://api.github.com/repos/taverntesting/tavern/deployments","created_at":"2017-11-01T14:51:25Z","updated_at":"2018-07-28T03:52:25Z","pushed_at":"2018-07-27T16:11:18Z","git_url":"git://github.com/taverntesting/tavern.git","ssh_url":"git@github.com:taverntesting/tavern.git","clone_url":"https://github.com/taverntesting/tavern.git","svn_url":"https://github.com/taverntesting/tavern","homepage":"https://taverntesting.github.io/","size":563,"stargazers_count":199,"watchers_count":199,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":31,"watchers":199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taverntesting/tavern/pulls/162"},"html":{"href":"https://github.com/taverntesting/tavern/pull/162"},"issue":{"href":"https://api.github.com/repos/taverntesting/tavern/issues/162"},"comments":{"href":"https://api.github.com/repos/taverntesting/tavern/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/taverntesting/tavern/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/taverntesting/tavern/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taverntesting/tavern/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/taverntesting/tavern/statuses/fcec9fff432cb2b49d96202be0f47779b407ca0f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benhowes"}}