{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls/comments/186236018","pull_request_review_id":117785113,"id":186236018,"diff_hunk":"@@ -49,7 +50,14 @@ public MessageDispatcher(ConnectionConfiguration configuration, IAmazonS3 s3Clie\n         async Task Dispatch(UnicastTransportOperation unicastMessage)\n         {\n             var sqsTransportMessage = new TransportMessage(unicastMessage.Message, unicastMessage.DeliveryConstraints);\n-            var serializedMessage = JsonConvert.SerializeObject(sqsTransportMessage);\n+\n+            var jsonSerializerSettings = new JsonSerializerSettings\n+            {","path":"src/NServiceBus.AmazonSQS/MessageDispatcher.cs","position":15,"original_position":15,"commit_id":"d06d38625dd34330ac29a8f85f7f5a0fd9b18a47","original_commit_id":"d06d38625dd34330ac29a8f85f7f5a0fd9b18a47","user":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars1.githubusercontent.com/u/174258?v=4","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"body":"Is it necessary to create these settings for each dispatch? ","created_at":"2018-05-04T22:32:29Z","updated_at":"2018-05-04T22:34:05Z","html_url":"https://github.com/Particular/NServiceBus.AmazonSQS/pull/214#discussion_r186236018","pull_request_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls/214","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls/comments/186236018"},"html":{"href":"https://github.com/Particular/NServiceBus.AmazonSQS/pull/214#discussion_r186236018"},"pull_request":{"href":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls/214","id":184221040,"html_url":"https://github.com/Particular/NServiceBus.AmazonSQS/pull/214","diff_url":"https://github.com/Particular/NServiceBus.AmazonSQS/pull/214.diff","patch_url":"https://github.com/Particular/NServiceBus.AmazonSQS/pull/214.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/issues/214","number":214,"state":"open","locked":false,"title":"1.x compatible TransportMessage","user":{"login":"boblangley","id":2546913,"avatar_url":"https://avatars3.githubusercontent.com/u/2546913?v=4","gravatar_id":"","url":"https://api.github.com/users/boblangley","html_url":"https://github.com/boblangley","followers_url":"https://api.github.com/users/boblangley/followers","following_url":"https://api.github.com/users/boblangley/following{/other_user}","gists_url":"https://api.github.com/users/boblangley/gists{/gist_id}","starred_url":"https://api.github.com/users/boblangley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boblangley/subscriptions","organizations_url":"https://api.github.com/users/boblangley/orgs","repos_url":"https://api.github.com/users/boblangley/repos","events_url":"https://api.github.com/users/boblangley/events{/privacy}","received_events_url":"https://api.github.com/users/boblangley/received_events","type":"User","site_admin":false},"body":"Connects to #213\r\n\r\nThis PR reintroduces the `TimeToBeReceived` and `ReplyToAddress` properties on the internal `TransportMessage` class used to wrap headers and message body in the SQS message payload.\r\n\r\nThe intent is to:\r\n\r\n* Add the properties to allow 1.x messages to be correctly processed by 3.x endpoints where no header is present, but the serialized `TransportMessage` properties have been provided.\r\n* Ensure the properties are populated for serialization when 3.x endpoints send a message that may be consumed by 1.x endpoints.\r\n* Ensure that pre-patch 3.x / 2.x endpoints, where only the header is expected, continue to have the header correctly populated.","created_at":"2018-04-26T04:05:55Z","updated_at":"2018-05-04T22:34:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8952a1006dfb02c16e95ab3464dfe3fdfea99829","assignee":{"login":"boblangley","id":2546913,"avatar_url":"https://avatars3.githubusercontent.com/u/2546913?v=4","gravatar_id":"","url":"https://api.github.com/users/boblangley","html_url":"https://github.com/boblangley","followers_url":"https://api.github.com/users/boblangley/followers","following_url":"https://api.github.com/users/boblangley/following{/other_user}","gists_url":"https://api.github.com/users/boblangley/gists{/gist_id}","starred_url":"https://api.github.com/users/boblangley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boblangley/subscriptions","organizations_url":"https://api.github.com/users/boblangley/orgs","repos_url":"https://api.github.com/users/boblangley/repos","events_url":"https://api.github.com/users/boblangley/events{/privacy}","received_events_url":"https://api.github.com/users/boblangley/received_events","type":"User","site_admin":false},"assignees":[{"login":"boblangley","id":2546913,"avatar_url":"https://avatars3.githubusercontent.com/u/2546913?v=4","gravatar_id":"","url":"https://api.github.com/users/boblangley","html_url":"https://github.com/boblangley","followers_url":"https://api.github.com/users/boblangley/followers","following_url":"https://api.github.com/users/boblangley/following{/other_user}","gists_url":"https://api.github.com/users/boblangley/gists{/gist_id}","starred_url":"https://api.github.com/users/boblangley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boblangley/subscriptions","organizations_url":"https://api.github.com/users/boblangley/orgs","repos_url":"https://api.github.com/users/boblangley/repos","events_url":"https://api.github.com/users/boblangley/events{/privacy}","received_events_url":"https://api.github.com/users/boblangley/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":823082993,"url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls/214/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls/214/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/issues/214/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/statuses/d06d38625dd34330ac29a8f85f7f5a0fd9b18a47","head":{"label":"Particular:ttbr-wirecompatibility","ref":"ttbr-wirecompatibility","sha":"d06d38625dd34330ac29a8f85f7f5a0fd9b18a47","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":28653941,"name":"NServiceBus.AmazonSQS","full_name":"Particular/NServiceBus.AmazonSQS","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.AmazonSQS","description":"An AWS SQS transport for NServiceBus.","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS","forks_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/deployments","created_at":"2014-12-31T03:03:44Z","updated_at":"2018-03-26T08:54:21Z","pushed_at":"2018-05-04T17:28:14Z","git_url":"git://github.com/Particular/NServiceBus.AmazonSQS.git","ssh_url":"git@github.com:Particular/NServiceBus.AmazonSQS.git","clone_url":"https://github.com/Particular/NServiceBus.AmazonSQS.git","svn_url":"https://github.com/Particular/NServiceBus.AmazonSQS","homepage":null,"size":4097,"stargazers_count":15,"watchers_count":15,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":11,"open_issues":32,"watchers":15,"default_branch":"develop"}},"base":{"label":"Particular:master","ref":"master","sha":"f1b1a6f96f46e1c3f12eda36e9f5d38a31372adb","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":28653941,"name":"NServiceBus.AmazonSQS","full_name":"Particular/NServiceBus.AmazonSQS","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.AmazonSQS","description":"An AWS SQS transport for NServiceBus.","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS","forks_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/deployments","created_at":"2014-12-31T03:03:44Z","updated_at":"2018-03-26T08:54:21Z","pushed_at":"2018-05-04T17:28:14Z","git_url":"git://github.com/Particular/NServiceBus.AmazonSQS.git","ssh_url":"git@github.com:Particular/NServiceBus.AmazonSQS.git","clone_url":"https://github.com/Particular/NServiceBus.AmazonSQS.git","svn_url":"https://github.com/Particular/NServiceBus.AmazonSQS","homepage":null,"size":4097,"stargazers_count":15,"watchers_count":15,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":11,"open_issues":32,"watchers":15,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls/214"},"html":{"href":"https://github.com/Particular/NServiceBus.AmazonSQS/pull/214"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/issues/214"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus.AmazonSQS/statuses/d06d38625dd34330ac29a8f85f7f5a0fd9b18a47"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"danielmarbach"}}