{"action":"created","comment":{"url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls/comments/176364010","pull_request_review_id":106050556,"id":176364010,"diff_hunk":"@@ -1164,6 +1164,17 @@ Choose from the list of available rules:\n \n   *Risky rule: this fixer may change functions named setUp or tearDown outside of PHPUnit tests, when a class is wrongly seen as a PHPUnit test.*\n \n+* **php_unit_static_assertion_calls**\n+\n+  PHPUnit assertion calls must all be of the same type.\n+\n+  *Risky rule: risky when PHPUnit methods are overridden or not accessible, or when project has PHPUnit incompatibilities.*\n+\n+  Configuration options:\n+\n+  - ``call_type`` (``'self'``, ``'static'``, ``'this'``): the call type to use for referring\n+    to PHPUnit methods; defaults to ``'static'``","path":"README.rst","position":13,"original_position":13,"commit_id":"693d16008d069ee7d2346eb281be690219dea4ab","original_commit_id":"693d16008d069ee7d2346eb281be690219dea4ab","user":{"login":"keradus","id":2716794,"avatar_url":"https://avatars1.githubusercontent.com/u/2716794?v=4","gravatar_id":"","url":"https://api.github.com/users/keradus","html_url":"https://github.com/keradus","followers_url":"https://api.github.com/users/keradus/followers","following_url":"https://api.github.com/users/keradus/following{/other_user}","gists_url":"https://api.github.com/users/keradus/gists{/gist_id}","starred_url":"https://api.github.com/users/keradus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keradus/subscriptions","organizations_url":"https://api.github.com/users/keradus/orgs","repos_url":"https://api.github.com/users/keradus/repos","events_url":"https://api.github.com/users/keradus/events{/privacy}","received_events_url":"https://api.github.com/users/keradus/received_events","type":"User","site_admin":false},"body":"*** it, let's be strict and spread the word. long live SCA.\r\n","created_at":"2018-03-22T10:05:01Z","updated_at":"2018-03-22T10:05:01Z","html_url":"https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3476#discussion_r176364010","pull_request_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls/3476","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls/comments/176364010"},"html":{"href":"https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3476#discussion_r176364010"},"pull_request":{"href":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls/3476"}},"in_reply_to_id":176360233},"pull_request":{"url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls/3476","id":165332689,"html_url":"https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3476","diff_url":"https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3476.diff","patch_url":"https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3476.patch","issue_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/issues/3476","number":3476,"state":"open","locked":false,"title":"Add PhpUnitStaticAssertionCalls","user":{"login":"Slamdunk","id":152236,"avatar_url":"https://avatars0.githubusercontent.com/u/152236?v=4","gravatar_id":"","url":"https://api.github.com/users/Slamdunk","html_url":"https://github.com/Slamdunk","followers_url":"https://api.github.com/users/Slamdunk/followers","following_url":"https://api.github.com/users/Slamdunk/following{/other_user}","gists_url":"https://api.github.com/users/Slamdunk/gists{/gist_id}","starred_url":"https://api.github.com/users/Slamdunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slamdunk/subscriptions","organizations_url":"https://api.github.com/users/Slamdunk/orgs","repos_url":"https://api.github.com/users/Slamdunk/repos","events_url":"https://api.github.com/users/Slamdunk/events{/privacy}","received_events_url":"https://api.github.com/users/Slamdunk/received_events","type":"User","site_admin":false},"body":"```diff\r\n class MyTest extends \\PHPUnit_Framework_TestCase\r\n {\r\n     public function testMe()\r\n     {\r\n-        $this->assertSame(1, 2);\r\n+        static::assertSame(1, 2);\r\n     }\r\n }\r\n```\r\n\r\n- [x] Convert `PHPUnit\\Framework\\Assert` static methods\r\n- [x] Convert `PHPUnit\\Framework\\TestCase` static methods\r\n- [x] Adapt `PhpUnitStrictFixer` to check for `self::` and `static::` calls too: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3477\r\n- [x] Adapt `PhpUnitDedicateAssertFixer` to check for `self::` and `static::` calls too: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3478\r\n- [x] Adapt `PhpUnitConstructFixer` to check for `self::` and `static::` calls too: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3479\r\n- [ ] Add to `.php_cs.dist` with `$this->` syntax: only after review","created_at":"2018-01-26T10:30:39Z","updated_at":"2018-03-22T10:05:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec8a8a68a1c79228c5e341768e3b0f2aa3c2040b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":132262556,"url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/labels/feature","name":"feature","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls/3476/commits","review_comments_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls/3476/comments","review_comment_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/issues/3476/comments","statuses_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/statuses/693d16008d069ee7d2346eb281be690219dea4ab","head":{"label":"Slamdunk:phpunit_static_assert","ref":"phpunit_static_assert","sha":"693d16008d069ee7d2346eb281be690219dea4ab","user":{"login":"Slamdunk","id":152236,"avatar_url":"https://avatars0.githubusercontent.com/u/152236?v=4","gravatar_id":"","url":"https://api.github.com/users/Slamdunk","html_url":"https://github.com/Slamdunk","followers_url":"https://api.github.com/users/Slamdunk/followers","following_url":"https://api.github.com/users/Slamdunk/following{/other_user}","gists_url":"https://api.github.com/users/Slamdunk/gists{/gist_id}","starred_url":"https://api.github.com/users/Slamdunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slamdunk/subscriptions","organizations_url":"https://api.github.com/users/Slamdunk/orgs","repos_url":"https://api.github.com/users/Slamdunk/repos","events_url":"https://api.github.com/users/Slamdunk/events{/privacy}","received_events_url":"https://api.github.com/users/Slamdunk/received_events","type":"User","site_admin":false},"repo":{"id":26592681,"name":"PHP-CS-Fixer","full_name":"Slamdunk/PHP-CS-Fixer","owner":{"login":"Slamdunk","id":152236,"avatar_url":"https://avatars0.githubusercontent.com/u/152236?v=4","gravatar_id":"","url":"https://api.github.com/users/Slamdunk","html_url":"https://github.com/Slamdunk","followers_url":"https://api.github.com/users/Slamdunk/followers","following_url":"https://api.github.com/users/Slamdunk/following{/other_user}","gists_url":"https://api.github.com/users/Slamdunk/gists{/gist_id}","starred_url":"https://api.github.com/users/Slamdunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slamdunk/subscriptions","organizations_url":"https://api.github.com/users/Slamdunk/orgs","repos_url":"https://api.github.com/users/Slamdunk/repos","events_url":"https://api.github.com/users/Slamdunk/events{/privacy}","received_events_url":"https://api.github.com/users/Slamdunk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Slamdunk/PHP-CS-Fixer","description":"Analyzes some PHP source code and tries to fix coding standards issues (PSR-1 and PSR-2 compatible)","fork":true,"url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer","forks_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/forks","keys_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/teams","hooks_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/hooks","issue_events_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/issues/events{/number}","events_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/events","assignees_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/assignees{/user}","branches_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/branches{/branch}","tags_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/tags","blobs_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/statuses/{sha}","languages_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/languages","stargazers_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/stargazers","contributors_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/contributors","subscribers_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/subscribers","subscription_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/subscription","commits_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/contents/{+path}","compare_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/merges","archive_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/downloads","issues_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/issues{/number}","pulls_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/pulls{/number}","milestones_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/milestones{/number}","notifications_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/labels{/name}","releases_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/releases{/id}","deployments_url":"https://api.github.com/repos/Slamdunk/PHP-CS-Fixer/deployments","created_at":"2014-11-13T14:56:30Z","updated_at":"2018-03-22T07:30:27Z","pushed_at":"2018-03-22T08:42:06Z","git_url":"git://github.com/Slamdunk/PHP-CS-Fixer.git","ssh_url":"git@github.com:Slamdunk/PHP-CS-Fixer.git","clone_url":"https://github.com/Slamdunk/PHP-CS-Fixer.git","svn_url":"https://github.com/Slamdunk/PHP-CS-Fixer","homepage":"cs.sensiolabs.org","size":11630,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FriendsOfPHP:master","ref":"master","sha":"c1a3c20197f8de5529e25aa800603c0d1ff69f51","user":{"login":"FriendsOfPHP","id":5947812,"avatar_url":"https://avatars0.githubusercontent.com/u/5947812?v=4","gravatar_id":"","url":"https://api.github.com/users/FriendsOfPHP","html_url":"https://github.com/FriendsOfPHP","followers_url":"https://api.github.com/users/FriendsOfPHP/followers","following_url":"https://api.github.com/users/FriendsOfPHP/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfPHP/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfPHP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfPHP/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfPHP/orgs","repos_url":"https://api.github.com/users/FriendsOfPHP/repos","events_url":"https://api.github.com/users/FriendsOfPHP/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfPHP/received_events","type":"Organization","site_admin":false},"repo":{"id":4344257,"name":"PHP-CS-Fixer","full_name":"FriendsOfPHP/PHP-CS-Fixer","owner":{"login":"FriendsOfPHP","id":5947812,"avatar_url":"https://avatars0.githubusercontent.com/u/5947812?v=4","gravatar_id":"","url":"https://api.github.com/users/FriendsOfPHP","html_url":"https://github.com/FriendsOfPHP","followers_url":"https://api.github.com/users/FriendsOfPHP/followers","following_url":"https://api.github.com/users/FriendsOfPHP/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfPHP/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfPHP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfPHP/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfPHP/orgs","repos_url":"https://api.github.com/users/FriendsOfPHP/repos","events_url":"https://api.github.com/users/FriendsOfPHP/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfPHP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfPHP/PHP-CS-Fixer","description":"A tool to automatically fix PHP coding standards issues","fork":false,"url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer","forks_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/forks","keys_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/teams","hooks_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/events","assignees_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/tags","blobs_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/languages","stargazers_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/subscription","commits_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/issues/comments{/number}","contents_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/merges","archive_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/downloads","issues_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/releases{/id}","deployments_url":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/deployments","created_at":"2012-05-16T06:42:23Z","updated_at":"2018-03-21T15:37:32Z","pushed_at":"2018-03-22T09:27:22Z","git_url":"git://github.com/FriendsOfPHP/PHP-CS-Fixer.git","ssh_url":"git@github.com:FriendsOfPHP/PHP-CS-Fixer.git","clone_url":"https://github.com/FriendsOfPHP/PHP-CS-Fixer.git","svn_url":"https://github.com/FriendsOfPHP/PHP-CS-Fixer","homepage":"http://cs.sensiolabs.org","size":12757,"stargazers_count":5664,"watchers_count":5664,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":819,"mirror_url":null,"archived":false,"open_issues_count":208,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":819,"open_issues":208,"watchers":5664,"default_branch":"2.10"}},"_links":{"self":{"href":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls/3476"},"html":{"href":"https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3476"},"issue":{"href":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/issues/3476"},"comments":{"href":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/issues/3476/comments"},"review_comments":{"href":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls/3476/comments"},"review_comment":{"href":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/pulls/3476/commits"},"statuses":{"href":"https://api.github.com/repos/FriendsOfPHP/PHP-CS-Fixer/statuses/693d16008d069ee7d2346eb281be690219dea4ab"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"keradus"}}